commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
exec.c: fix dirty bitmap reallocation
For each newly created RAM block, dirty bitmap is reallocated with g_realloc, which doesn't
make any promises on initial content of new extra data in returned buffer. In theory,
we initialize this new data with cpu_physical_memory_set_dirty_range() call. The
problem is, cpu_physical_memory_set_dirty_range() has a side effect of incrementing
ram_list.dirty_pages variable, but only for pages which are not already dirty. And
page "cleanliness" is determined using the same not yet uninitialized dirty bitmap
we've just reallocated. This results in inconsistency between real dirty page number
and value in ram_list.dirty_pages variable, which in turn could (and will) result
in errors during VM migration.
Zero initialize new dirty bitmap bytes to fix this problem.
Signed-off-by: Igor Mitsyanko <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 5fda043f9c8b8ab18da2704de8e77b7c86fa9435 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5fda043f9c8b8ab18da2704de8e77b7c86fa9435 | 2012-08-11 12:23:46+00:00 |
SCSI: Update the sense code for PREVENT REMOVAL errors
Change the sense codes for failures to eject a device that is locked
by PREVENT_ALLOW_MEDIUM_REMOVAL from
the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific
MEDIUM_REMOVAL_PREVENTED.
The second sense code is more accurate, and is also listed in MMC annex F
for the recommended sense codes for MMC devices while the first sense code is not.
Signed-off-by: Ronnie Sahlberg <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| 93161b69a53241be71e1aab7f792d78d9bfd19d3 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/93161b69a53241be71e1aab7f792d78d9bfd19d3 | 2012-08-03 10:01:35+02:00 |
esp: add AMD PCscsi emulation (PCI SCSI adapter)
The PCI version is supported in lots of Operating Systems,
and has been successfully tested on:
- MS DOS 6.22 (using DC390 driver)
- MS Windows 3.11 (using DC390 driver)
- MS Windows 98 SE (using default driver)
- MS Windows NT 3.1 (using DC390 driver)
- MS Windows NT 4.0 (using default driver)
Signed-off-by: Hervé Poussineau <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| fabaaf1d1f3f793999257cb16b509e32dfc1de71 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fabaaf1d1f3f793999257cb16b509e32dfc1de71 | 2012-07-14 10:13:29+00:00 |
configure: Don't run configure tests with -Werror enabled
Don't run configure tests with -Werror in the compiler flags. The idea
of -Werror is that it makes problems very obvious to developers, so
they get fixed quickly. However, when running configure tests, failures
due to -Werror are far from obvious -- they simply result in the test
quietly failing when it should have passed. Not using -Werror is in
line with recommended practice in the Autoconf world.
This commit is essentially backing out the changes in commit 417c9d72.
Instead we fix the problem that commit was trying to address in a
different way: we add -Werror only for the test of the nss headers,
with a comment that this is specifically intended to detect a bug
in some releases of nss.
We also have to clean up a bug in the smartcard test where it was
trying to include smartcard_cflags in the test compile flags: this
would always result in a failure with -Werror, because they include
an escaped "$(SRC_PATH)" which is only valid when used in the final
makefile.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Stefan Weil <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 6ca026cb376f1ac5d228c7980201b8a6c678ae67 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6ca026cb376f1ac5d228c7980201b8a6c678ae67 | 2012-07-31 20:05:34+00:00 |
virtio-scsi: do not crash on adding buffers to the event queue
The event queue is not supported yet and the handler does not
have to do much anyway when buffers are added. However, the
handler is called unconditionally by the virtio layer, and this
results in a crash as soon as buffers are added to the event
queue because we pass NULL.
Reported-by: Bryan Venteicher <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| 619d7ae952bb61ec27ec21fe4a383a8d4dd4cd70 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/619d7ae952bb61ec27ec21fe4a383a8d4dd4cd70 | 2012-07-02 11:27:00+02:00 |
pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure
The pseries platform already contains an IOMMU implementation, since it is
essential for the platform's paravirtualized VIO devices. This IOMMU
support is currently built into the implementation of the VIO "bus" and
the various VIO devices.
This patch converts this code to make use of the new common IOMMU
infrastructure.
We don't yet handle synchronization of map/unmap callbacks vs. invalidations,
this will require some complex interaction with the kernel and is not a
major concern at this stage.
Cc: Alex Graf <[email protected]>
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| ad0ebb91cd8b5fdc4a583b03645677771f420a46 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ad0ebb91cd8b5fdc4a583b03645677771f420a46 | 2012-06-27 16:33:25-05:00 |
xilinx_timer: Fixed deadlock issue
The timer was deadlocking when the interval was set too low. It would cause a
flood of timer events and the CPU would halt indefinately. This is a known issue
and theres a generic workaround in place in ptimer on ptimer_set_limit(),
however the Xilinx timer uses ptimer_set_count() instead of set_limit. Changed
the call to set_count() to an equivalent call of set_limit() instead, which
brings the workaround into play.
Signed-off-by: Peter A. G. Crosthwaite <[email protected]>
Signed-off-by: Edgar E. Iglesias <[email protected]>
| 7798a8828a654ce438584bdfccaa3e8a120cf998 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7798a8828a654ce438584bdfccaa3e8a120cf998 | 2012-06-21 15:19:16+02:00 |
target-arm: Implement privileged-execute-never (PXN)
Implement the privileged-execute-never (PXN) translation table bit.
It is implementation-defined whether this is implemented, so we give
it its own ARM_FEATURE_ flag. LPAE requires PXN, so add also an
LPAE feature flag and the implication logic, as a placeholder
for actually implementing LPAE at a later date.
Signed-off-by: Peter Maydell <[email protected]>
| de9b05b807918d40db9e26ddd6a54ad2978ac5b7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/de9b05b807918d40db9e26ddd6a54ad2978ac5b7 | 2012-07-12 10:59:54+00:00 |
do not include <libutil.h> needlessly or if it doesn't exist
<libutil.h> and <util.h> on *BSD (some have one, some another)
were #included just for openpty() declaration. The only file
where this function is actually used is qemu-char.c.
In vl.c and net/tap-bsd.c, none of functions declared in libutil.h
(login logout logwtmp timdomain openpty forkpty uu_lock realhostname
fparseln and a few others depending on version) are used.
Initially the code which is currently in qemu-char.c was in vl.c,
it has been removed into separate file in commit 0e82f34d077dc2542
Fri Oct 31 18:44:40 2008, but the #includes were left in vl.c.
So with vl.c, we just remove includes - libutil.h, util.h and
pty.h (which declares only openpty() and forkpty()) from there.
The code in net/tap-bsd.c, which come from net/tap.c, had this
commit 5281d757efa6e40d74ce124be048b08d43887555
Author: Mark McLoughlin <[email protected]>
Date: Thu Oct 22 17:49:07 2009 +0100
net: split all the tap code out into net/tap.c
Note this commit not only moved stuff out of net.c to net/tap.c,
but also rewrote large portions of the tap code, and added these
completely unnecessary #includes -- as usual, I question why such
a misleading commit messages are allowed.
Again, no functions defined in libutil.h or util.h on *BSD are
used by neither net/tap.c nor net/tap-bsd.c. Removing them.
And finally, the only real user for these #includes, qemu-char.c,
which actually uses openpty(). There, the #ifdef logic is wrong.
A GLIBC-based system has <pty.h>, even if it is a variant of *BSD.
So __GLIBC__ should be checked first, and instead of trying to
include <libutil.h> or <util.h>, we include <pty.h>. If it is not
GLIBC-based, we check for variations between <*util.h> as before.
This patch fixes build of qemu 1.1 on Debian/kFreebsd (well, one
of the two problems): it is a distribution with a FreeBSD kernel,
so it #defines at least __FreeBSD_kernel__, but since it is based
on GLIBC, it has <pty.h>, but current version does not have neither
<util.h> nor <libutil.h>, which the code tries to include 3 times
but uses only once.
Signed-off-By: Michael Tokarev <[email protected]>
Cc: Aurelien Jarno <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 3294ce1893620aecf0d2a693c7177a0f84129422 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3294ce1893620aecf0d2a693c7177a0f84129422 | 2012-06-09 10:30:08+00:00 |
rtl8139: honor RxOverflow flag in can_receive method
Some drivers (Linux' 8139too among them) rely on the NIC
injecting an interrupt in the event of a receive buffer overflow
and, accordingly, set the RxOverflow bit in the interrupt
mask. Unfortunately rtl8139's can_receive method ignores the
RxOverflow flag, which may lead to a situation where rtl8139
stops receiving packets (can_receive returns 0) when the receive
buffer becomes full.
If the driver eventually read from the receive buffer or reset
the card the emulator could recover from this situation. However
some implementations only do this upon receiving an interrupt
with either RxOK or RxOverflow set in the ISR; interrupt that
will never come because QEMU's flow control mechanisms would
prevent rtl8139 from receiving any packet.
Letting packets go through when the overflow interrupt is enabled
makes the QEMU emulator compliant to the spec and solves the
problem.
This patch should fix a relatively common (in our experience)
network stall observed when running enterprise distros with
rtl8139 as the NIC; in some cases the 8139too device driver gets
loaded and when under heavy load the network eventually stops
working.
Reported-by: Hayato Kakuta <[email protected]>
Tested-by: Hayato Kakuta <[email protected]>
Acked-by: Igor Kovalenko <[email protected]>
Signed-off-by: Fernando Luis Vazquez Cao <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| fee9d348ffc5c9f80068086799a948996f633f7e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fee9d348ffc5c9f80068086799a948996f633f7e | 2012-06-07 17:18:58+03:00 |
block: prevent snapshot mode $TMPDIR symlink attack
In snapshot mode, bdrv_open creates an empty temporary file without
checking for mkstemp or close failure, and ignoring the possibility
of a buffer overrun given a surprisingly long $TMPDIR.
Change the get_tmp_filename function to return int (not void),
so that it can inform its two callers of those failures.
Also avoid the risk of buffer overrun and do not ignore mkstemp
or close failure.
Update both callers (in block.c and vvfat.c) to propagate
temp-file-creation failure to their callers.
get_tmp_filename creates and closes an empty file, while its
callers later open that presumed-existing file with O_CREAT.
The problem was that a malicious user could provoke mkstemp failure
and race to create a symlink with the selected temporary file name,
thus causing the qemu process (usually root owned) to open through
the symlink, overwriting an attacker-chosen file.
This addresses CVE-2012-2652.
http://bugzilla.redhat.com/CVE-2012-2652
Signed-off-by: Jim Meyering <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| c2d76497b6eafcaedc806e07804e7bed55a98a0b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c2d76497b6eafcaedc806e07804e7bed55a98a0b | 2012-05-30 10:18:20+02:00 |
virtio: check virtio_load return code
Otherwise we crash on error.
Signed-off-by: Ulrich Obergfell <[email protected]>
Signed-off-by: Orit Wassermann <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 2a633c461e96cb9a856292c46917653bd43959c8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2a633c461e96cb9a856292c46917653bd43959c8 | 2012-05-21 15:40:50-05:00 |
ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs
Update the configure test for libiscsi support to detect version 1.3
or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well
as UNMAP commands.
Update the iscsi block layer to use READCAPACITY16 to detect the size of
the LUN instead of READCAPACITY10. This allows support for LUNs larger
than 2TB.
Update to implement bdrv_aio_discard() using the UNMAP command.
This allows us to use thin-provisioned LUNs from TGTD and other iSCSI
targets that support thin-provisioning.
Signed-off-by: Ronnie Sahlberg <[email protected]>
[squashed in subsequent patch from Ronnie to fix off-by-one in LBA count]
Signed-off-by: Paolo Bonzini <[email protected]>
| fa6acb0c2ff3f256fb5f2fede4768b27374b03ca | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fa6acb0c2ff3f256fb5f2fede4768b27374b03ca | 2012-05-04 10:39:18+02:00 |
slirp: don't use "smb ports = 0" option
The "smb ports = 0" option causes recent samba versions to crash. It was
introduced in commit 157777ef3e with log message "Samba 3 support".
However, a value of 0 has never been officially supported by smb and is
also not necessary: if stdin is a socket, smb does not try to listen on
any ports and uses just stdin. This is necessary to support inetd based
operation (otherwise smbd would always fail when called from inetd,
because inetd already listens on the SMB port). Since samba has
supported inetd operation since pre-3.x, it should be safe to rely on
this feature. I have tested it with Samba 3.6.4 -- communication works
fine, and smbd is not listening on any ports.
I suspect the "smb ports = 0" hack may have been introduced when someone
tested the qemu generated samba config from the command line with "smbd
-i" and found it to fail (because then stdin isn't a socket).
Signed-off-by: Nikolaus Rath <[email protected]>
Signed-off-by: Jan Kiszka <[email protected]>
| de305b1387dad4473ae4cec48467d10d949e0f10 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/de305b1387dad4473ae4cec48467d10d949e0f10 | 2012-05-01 19:08:44-03:00 |
qcow2: Fix refcount block allocation during qcow2_alloc_cluster_at()
Refcount block allocation and refcount table growth rely on
s->free_cluster_index pointing to somewhere after the current
allocation. Change qcow2_alloc_cluster_at() to fulfill this
assumption.
Without this change it could happen that a newly allocated refcount
block and the allocated data block point to the same area in the image
file, causing data corruption in the long run.
This fixes a bug that became first visible after commit 250196f1.
Signed-off-by: Kevin Wolf <[email protected]>
| f24423bd902bce29bc546cf8d030bfa369726ab1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f24423bd902bce29bc546cf8d030bfa369726ab1 | 2012-04-20 15:56:19+02:00 |
nbd: avoid out of bounds access to recv_coroutine array
This can happen with a buggy or malicious server.
Reported-by: Michael Tokarev <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| dd3e8ac413a74a58d6a3ba16a26952f84370fcff | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dd3e8ac413a74a58d6a3ba16a26952f84370fcff | 2012-04-19 16:36:42+02:00 |
softfloat: float*_to_int32_round_to_zero: don't assume int32 is 32 bits
Code in the float64_to_int32_round_to_zero() function was assuming
that int32 would not be wider than 32 bits; this meant it might
not correctly detect the overflow case. We take the simple approach
of using int32_t. Also fix equivalent issues in the functions
for other float sizes.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| b3a6a2e0417c78ec5491347eb85a7d125a5fefdc | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b3a6a2e0417c78ec5491347eb85a7d125a5fefdc | 2012-04-07 11:15:44+00:00 |
virtio-scsi: call unregister_savevm properly
This fixes a use-after-free when migrating after hot-unplug.
Signed-off-by: Paolo Bonzini <[email protected]>
| eb2fa76418402c8b26e1ab4cb53498ee0f4e52ef | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/eb2fa76418402c8b26e1ab4cb53498ee0f4e52ef | 2012-03-19 16:35:43+01:00 |
pci: fix double free of romfile property
The qdev property release function frees any string properties. This was
resulting in a double free during hot unplug.
It manifests in network devices because block devices have a NULL romfile
property by default.
Cc: Michael Tsirkin <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| e5ab1404d014cefe22e9a10fca00d0acf4fe412b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e5ab1404d014cefe22e9a10fca00d0acf4fe412b | 2012-03-16 13:17:06-05:00 |
virtio-blk: refuse SG_IO requests with scsi=off
QEMU does have a "scsi" option (to be used like -device
virtio-blk-pci,drive=foo,scsi=off). However, it only
masks the feature bit, and does not reject the command
if a malicious guest disregards the feature bits and
issues a request.
Without this patch, using scsi=off does not protect you
from CVE-2011-4127.
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 1ba1f2e319afdcb485963cd3f426fdffd1b725f2 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1ba1f2e319afdcb485963cd3f426fdffd1b725f2 | 2012-01-13 10:20:51-06:00 |
kvm: x86: Add user space part for in-kernel i8259
Introduce the alternative 'kvm-i8259' device model that exploits KVM
in-kernel acceleration.
The PIIX3 initialization code is furthermore extended by KVM specific
IRQ route setup. GSI injection differs in KVM mode from the user space
model. As we can dispatch ISA-range IRQs to both IOAPIC and PIC inside
the kernel, we do not need to inject them separately. This is reflected
by a KVM-specific GSI handler.
Signed-off-by: Jan Kiszka <[email protected]>
| 10b618827507fbdbe7cf1a9b1f2c81d254dcd8b8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/10b618827507fbdbe7cf1a9b1f2c81d254dcd8b8 | 2012-01-19 12:14:42+01:00 |
qemu-thread: implement joinable threads for Win32
Rewrite the handshaking between qemu_thread_create and the
win32_start_routine, so that the thread can be joined without races.
Similar handshaking is done now between qemu_thread_exit and
qemu_thread_join.
This also simplifies how QemuThreads are initialized.
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 403e633126b7a781ecd48a29e3355770d46bbf1a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/403e633126b7a781ecd48a29e3355770d46bbf1a | 2011-12-12 17:06:22-06:00 |
qcow2: Fix order of refcount updates in qcow2_snapshot_goto
The refcount updates must be moved so that in the worst case we can get
cluster leaks, but refcounts may never be too low.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
| 43a0cac4658bbee9c9e84554712a94daa092c1cd | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/43a0cac4658bbee9c9e84554712a94daa092c1cd | 2011-12-05 14:51:36+01:00 |
qcow2: Rework qcow2_snapshot_create error handling
Increase refcounts only after allocating a new L1 table has succeeded in
order to make leaks less likely. If writing the snapshot table fails,
revert in-memory state to be consistent with that on disk.
While at it, make it return the real error codes instead of -1.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
| d1ea98d56dc2485b4637a1ca19feef786b3aee8f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d1ea98d56dc2485b4637a1ca19feef786b3aee8f | 2011-12-05 14:51:36+01:00 |
msix: Prevent bogus mask updates on MMIO accesses
>From: Jan Kiszka <[email protected]>
Only accesses to the MSI-X table must trigger a call to
msix_handle_mask_update, otherwise the vector
value might be out of range.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 9a93b61730e3b46ef1c01ca522c6abe80ec13832 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9a93b61730e3b46ef1c01ca522c6abe80ec13832 | 2011-11-21 15:05:59-06:00 |
virtio-blk: pass full status to the guest
When SCSI passthrough is being used by the guest with virtio-blk, the
guest is not able to detect disk failures. This is because the status
field is expected by the guest driver to include also the msg_status,
host_status and driver_status fields, but the device is only passing
down the SCSI status.
The patch fixes this, and also makes sure that the guest always sees a
CHECK_CONDITION status when there is valid sense data.
Signed-off-by: Anthony Liguori <[email protected]>
| 5bb23927761db0d48507c60f56c4e28f72f3c2a7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5bb23927761db0d48507c60f56c4e28f72f3c2a7 | 2011-11-02 07:51:58-05:00 |
qemu-queue: Introduce QLIST_INSERT_HEAD_RCU and dummy RCU wrappers.
SynthFS needs a QLIST_INSERT_HEAD_RCU to make sure list instructions are not
re-ordered and therefore avoiding a crash. There may be parallel readers which
should be allowed for lock-free access and this variant allows us to get rid
of rwlocks used by readers.
SynthFS is a special case where we dont really need full RCU capabilities as
it doesnt allow list entry deletion but concurrent readers/writers and
instruction re-ordering should not result in a crash.
Also, once the real rcu is available, dummy rcu macro definitions will go away
and the code will still work as expected.
This patchwork is based on inputs from Paolo Bonzini.
Signed-off-by: Harsh Prateek Bora <[email protected]>
Signed-off-by: Aneesh Kumar K.V <[email protected]>
| 5f7d05ecfda56b0b66ade19bc4d81eab46954149 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5f7d05ecfda56b0b66ade19bc4d81eab46954149 | 2011-10-31 12:34:18+05:30 |
target-xtensa: implement exceptions
- mark privileged opcodes with ring check;
- make debug exception on exception handler entry.
Signed-off-by: Max Filippov <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 40643d7c0fe4dc967ebc2f75e6758a4649776949 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/40643d7c0fe4dc967ebc2f75e6758a4649776949 | 2011-09-10 16:57:38+00:00 |
usb: fix use after free
The ->complete() callback might have released the USBPacket (uhci
actually does), so we must not touch it after the callback returns.
Signed-off-by: Gerd Hoffmann <[email protected]>
| 4d8debba766265d70cb7bf11570e3622512641d6 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4d8debba766265d70cb7bf11570e3622512641d6 | 2011-09-07 09:58:26+02:00 |
target-xtensa: add gdb support
Specific xtensa processor overlay for GDB contains register map in
the gdb/xtensa-config.c. This description is used by the GDB to e.g.
parse 'g' response packets and it may be reused in the qemu's gdbstub
(only XTREG definitions for non-pseudoregisters are needed).
Currently mainline GDB does not support operations with privileged SRs
(see http://sourceware.org/ml/gdb/2011-07/msg00075.html). This support
may be enabled, see NUM_CORE_REGS comment in the gdbstub.c
Signed-off-by: Max Filippov <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| ccfcaba6fd9f69a9322af1911302e71127bee1e0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ccfcaba6fd9f69a9322af1911302e71127bee1e0 | 2011-09-10 16:57:40+00:00 |
trace: avoid conditional code compilation during option parsing
A default implementation for backend-specific routines is provided in
"trace/default.c", which backends can override by setting "trace_default=no" in
"configure".
Signed-off-by: Lluís Vilanova <[email protected]>
| e4858974ec36afd8a6b3a9e2b0ad8f357f28efc7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e4858974ec36afd8a6b3a9e2b0ad8f357f28efc7 | 2011-09-01 10:34:53+01:00 |
vga: Silence bogus gcc warning about uninitialized variables
Some gcc versions do not properly detect that all possible cases are
covered and base and size are always initialized. Please gcc by defining
a pseudo default case.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| f065aa0a005ac539bf8ca556775e5cc4c3d2d3b7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f065aa0a005ac539bf8ca556775e5cc4c3d2d3b7 | 2011-08-25 13:56:54-05:00 |
block: add cache=directsync parameter to -drive
This patch adds -drive cache=directsync for O_DIRECT | O_SYNC host file
I/O with no disk write cache presented to the guest.
This mode is useful when guests may not be sending flushes when
appropriate and therefore leave data at risk in case of power failure.
When cache=directsync is used, write operations are only completed to
the guest when data is safely on disk.
This new mode is like cache=writethrough but it bypasses the host page
cache.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 92196b2f5664d5defa778b1b24df56e2239b5e93 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/92196b2f5664d5defa778b1b24df56e2239b5e93 | 2011-08-23 14:15:17+02:00 |
Check fread() results to avoid gcc 4.6 warnings
When compiling with gcc 4.6, some code in fw_cfg.c complains that fop_ret
is assigned but not used (which is true). However, it looks like the
meaningless assignments to fop_ret were done to suppress other gcc warnings
due to the fact that fread() is labelled as warn_unused_result in glibc.
This patch avoids both errors, by actually checking the fread() result code
and dropping out with an error message if it fails.
Reviewed-by: Stefan Hajnoczi <[email protected]>
Tested-by: Stefan Berger <[email protected]>
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 257a7375582e4c3b32687c72d0f52279d28b2d85 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/257a7375582e4c3b32687c72d0f52279d28b2d85 | 2011-08-05 10:57:34-05:00 |
block/vpc.c: Detect too-large vpc file
VHD files technically can be up to 2Tb, but virtual pc is limited
to 127G. Currently qemu-img refused to create vpc files > 127G,
but it is failing to return error when converting from a non-vpc
VHD file which is >127G. It returns success, but creates a truncated
converted image. Also, qemu-img info claims the vpc file is 127G
(and clean).
This patch detects a too-large vpc file and returns -EFBIG. Without
this patch,
=============================================================
root@ip-10-38-123-242:~/qemu-fixed# qemu-img info /mnt/140g-dynamic.vhd
image: /mnt/140g-dynamic.vhd
file format: vpc
virtual size: 127G (136899993600 bytes)
disk size: 284K
root@ip-10-38-123-242:~/qemu-fixed# qemu-img convert -f vpc -O raw /mnt/140g-dynamic.vhd /mnt/y
root@ip-10-38-123-242:~/qemu-fixed# echo $?
0
root@ip-10-38-123-242:~/qemu-fixed# qemu-img info /mnt/y
image: /mnt/y
file format: raw
virtual size: 127G (136899993600 bytes)
disk size: 0
=============================================================
(The 140G image was truncated with no warning or error.)
With the patch, I get:
=============================================================
root@ip-10-38-123-242:~/qemu-fixed# ./qemu-img info /mnt/140g-dynamic.vhd
qemu-img: Could not open '/mnt/140g-dynamic.vhd': File too large
root@ip-10-38-123-242:~/qemu-fixed# ./qemu-img convert -f vpc -O raw /mnt/140g-dynamic.vhd /mnt/y
qemu-img: Could not open '/mnt/140g-dynamic.vhd': File too large
qemu-img: Could not open '/mnt/140g-dynamic.vhd'
=============================================================
See https://bugs.launchpad.net/qemu/+bug/814222 for details.
Signed-off-by: Serge Hallyn <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| efc8243d00ab4cf4fa05a9be93233cb883b7caa0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/efc8243d00ab4cf4fa05a9be93233cb883b7caa0 | 2011-08-01 12:10:28+02:00 |
Don't translate pointer when in restore_sigcontext
Fixes crash in i386 when user emulation base address is non-zero.
21797 rt_sigreturn(8,1082124603,1,0,1082126048,1082126248)Exit reason and status: signal 11
Signed-off-by: Mike McCormack <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
| 9a826d7854baf6b90de46fea785d1bfc5d2c22a7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9a826d7854baf6b90de46fea785d1bfc5d2c22a7 | 2011-06-20 17:00:18+03:00 |
qed: Fix consistency check on 32-bit hosts
The qed_bytes_to_clusters() function is normally used with size_t
lengths. Consistency check used it with file size length and therefore
failed on 32-bit hosts when the image file is 4 GB or more.
Make qed_bytes_to_clusters() explicitly 64-bit and update consistency
check to keep 64-bit cluster counts.
Reported-by: Michael Tokarev <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 19dfc44a94f759848a0f7de7378b2f8b9af6b5d0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/19dfc44a94f759848a0f7de7378b2f8b9af6b5d0 | 2011-04-27 16:21:00+02:00 |
hw/xen_disk: ioreq not finished on error
Bug fix: routines 'ioreq_runio_qemu_sync' and 'ioreq_runio_qemu_aio'
won't call 'ioreq_unmap' or 'ioreq_finish' on errors, leaving ioreq in
the blkdev->inflight list and a leak.
Signed-off-by: Feiran Zheng <[email protected]>
Acked-by: Stefano Stabellini <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| f6ec953ca329d4509e5a1a1ff051365fccdbb6b7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f6ec953ca329d4509e5a1a1ff051365fccdbb6b7 | 2011-04-07 13:51:47+02:00 |
spice: add SASL support
Turn on SASL support by appending "sasl" to the spice arguments, which
requires that the client use SASL to authenticate with the spice. The
exact choice of authentication method used is controlled from the
system / user's SASL configuration file for the 'qemu' service. This
is typically found in /etc/sasl2/qemu.conf. If running QEMU as an
unprivileged user, an environment variable SASL_CONF_PATH can be used
to make it search alternate locations for the service config. While
some SASL auth methods can also provide data encryption (eg GSSAPI),
it is recommended that SASL always be combined with the 'tls' and
'x509' settings to enable use of SSL and server certificates. This
ensures a data encryption preventing compromise of authentication
credentials.
It requires support from spice 0.8.1.
[ kraxel: moved spell fix to separate commit ]
Signed-off-by: Gerd Hoffmann <[email protected]>
| 48b3ed0a68b8c1b288b4e15743ea39b7b5b318c3 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/48b3ed0a68b8c1b288b4e15743ea39b7b5b318c3 | 2011-06-06 09:14:42+02:00 |
hw/fmopl: Fix buffer access out-of-bounds errors
Index 75 is one too large for AR_TABLE[75], DR_TABLE[75].
This error was reported by cppcheck.
hw/fmopl.c:600: error: Buffer access out-of-bounds: OPL.AR_TABLE
hw/fmopl.c:601: error: Buffer access out-of-bounds: OPL.DR_TABLE
Fix this by limiting the access to the allowed range.
MultiArcadeMachineEmulator has newer versions of fmopl,
but using these requires more efforts.
Cc: Blue Swirl <[email protected]>
Reviewed-by: malc <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 913895ab96507db2bc448d3ae72a409407172d2e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/913895ab96507db2bc448d3ae72a409407172d2e | 2011-03-13 13:35:21+00:00 |
hw/slavio_intctl.c: fix gcc warning about array bounds overrun
The Ubuntu 10.10 gcc for ARM complains that we might be overrunning
the cpu_irqs[][] array: silence this by correcting the bounds on the
loop. (In fact we would not have overrun the array because bit
MAX_PILS in pil_pending and irl_out will always be 0.)
Also add a comment about why the loop's lower bound is OK.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| c84a88d8cb298b6757ad01a12a8bbba66cb6eaa2 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c84a88d8cb298b6757ad01a12a8bbba66cb6eaa2 | 2011-02-01 17:02:15+00:00 |
kvm: x86: Fix DPL write back of segment registers
The DPL is stored in the flags and not in the selector. In fact, the RPL
may differ from the DPL at some point in time, and so we were corrupting
the guest state so far.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
| acaa75507b34f7b588924a09c76c6848d209e08c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/acaa75507b34f7b588924a09c76c6848d209e08c | 2011-01-21 14:05:22-02:00 |
user: speed up init_paths a bit
The current init_paths code will attempt to opendir() every single file it
finds. This can obviously generated a huge number of syscalls with even a
moderately small sysroot that will fail. Since the readdir() call provides
the file type in the struct itself, use it. On my system, this prevents
over 1000 syscalls from being made at every invocation of a target binary,
and I only have a C library installed.
Signed-off-by: Mike Frysinger <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
| 2296f194dfde4c0a54f249d3fdb8c8ca21dc611b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2296f194dfde4c0a54f249d3fdb8c8ca21dc611b | 2011-02-09 10:33:54+02:00 |
target-sh4: fix fpu disabled/illegal exception
Illegal instructions in a slot delay should generate a slot illegal
instruction exception instead of an illegal instruction exception.
The current PC should be saved before generating such an exception,
but should not be corrected if in a delay slot, given it's already
done in the exception handler do_interrupt().
Signed-off-by: Aurelien Jarno <[email protected]>
| 86865c5ff16bd1a2ef2b9ce217a7bb8f39e2126c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/86865c5ff16bd1a2ef2b9ce217a7bb8f39e2126c | 2011-01-11 17:25:24+01:00 |
virtio-net: stop/start bh when appropriate
Avoid sending out packets, and modifying
memory, when VM is stopped.
Add assert statements to verify this does not happen.
Avoid scheduling bh when vhost-net is started.
Stop bh when driver disabled bus mastering
(we must not access memory after this).
Signed-off-by: Michael S. Tsirkin <[email protected]>
Tested-by: Jason Wang <[email protected]>
| 783e7706937fe15523b609b545587a028a2bdd03 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/783e7706937fe15523b609b545587a028a2bdd03 | 2010-12-09 12:47:48+02:00 |
vvfat: Fix double free for opening the image rw
Allocation and deallocation of bs->opaque is not in the control of a
block driver. Therefore it should not set bs->opaque to a data structure
used by another bs, or closing the image will lead to a double free.
Signed-off-by: Kevin Wolf <[email protected]>
| 9217e26f43df4aab7deaea35b21caacc1f1f854b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9217e26f43df4aab7deaea35b21caacc1f1f854b | 2010-09-21 15:39:42+02:00 |
qemu-img convert: Use cache=unsafe for output image
If qemu-img crashes during the conversion, the user will throw away the broken
output file anyway and start over. So no need to be too cautious.
Signed-off-by: Kevin Wolf <[email protected]>
| 1bd8e175580a87c7b9e6791faca7626f9bc3ceeb | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1bd8e175580a87c7b9e6791faca7626f9bc3ceeb | 2010-09-08 12:39:20+02:00 |
usb-serial: Fail instead of crash when chardev is missing
Signed-off-by: Markus Armbruster <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| 81bf96d3d299a7f88bf3e2ece4f795a9949db5f7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/81bf96d3d299a7f88bf3e2ece4f795a9949db5f7 | 2010-06-30 20:35:46+02:00 |
ide: Improve error messages
Use error_report(), because it points to the error location.
Reword "tried to assign twice" messages to make it clear that we're
complaining about the unit property.
Report invalid unit property instead of failing silently.
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| f597627ff5eb683501d65cf169f467bb4e894626 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f597627ff5eb683501d65cf169f467bb4e894626 | 2010-07-06 17:05:49+02:00 |
Avoid crash on '-usbdevice <device>' without parameters
Many usbdevice_init implementors assume params is non-NULL.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 702f3e0fb52c124c07f215426eeadb70a716643f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/702f3e0fb52c124c07f215426eeadb70a716643f | 2010-03-17 10:42:12-05:00 |
sparc32 don't mark page dirty when failing
if the access check fails, the page can not be modified
and shouldn't be marked dirty.
The patch fixes the "hsfs_putpage: dirty HSFS page"
error in Solaris guests.
Signed-off-by: Artyom Tarasenko <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 698235aab6f55e960203dc2ef9a3a580982dae2f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/698235aab6f55e960203dc2ef9a3a580982dae2f | 2010-01-31 07:49:26+00:00 |
qdev: fix thinko leading to guest crashes
Without this fix, guest crashes with drive=virtio.
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| dbd483242c2e6dfaacb9fd3d20c333bbdad87243 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dbd483242c2e6dfaacb9fd3d20c333bbdad87243 | 2010-01-12 13:24:52-06:00 |
raw-posix: Detect CDROM via ioctl on linux
Current CDROM detection is hardcoded based on source file name.
Make this smarter on linux by attempting a CDROM specific ioctl.
This makes '-cdrom /dev/sr0' succeed with no media present.
v2:
Give ioctl check higher priority than filename check.
v3:
Actually initialize 'prio' variable.
Check for ioctl success rather than absence of specific failure.
v4:
Explicitly mention that change is linux specific.
Signed-off-by: Cole Robinson <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 3baf720e6b920d583ce2834d05e5a4e9603a1d56 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3baf720e6b920d583ce2834d05e5a4e9603a1d56 | 2010-01-19 16:31:03-06:00 |
Don't leak file descriptors
We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
descriptors that don't need to be passed to children to stop this misbehaviour.
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4 | 2009-12-03 11:45:50-06:00 |
Send a RARP packet after migration.
Currently, after a migration qemu sends a broadcast packet to update
switches' MAC->port mappings.
Unfortunately, it picks a random (constant) ethertype and crosses its
fingers that no one else is using it.
This patch causes it to send a RARP packet instead. RARP was chosen for
2 reasons. One, it is always harmless, and will continue to be so even
as new ethertypes are allocated. Two, it is what VMware ESX sends, so
people who write filtering rules for switches already know about it.
I also changed the code to send SELF_ANNOUNCE_ROUNDS packets, instead of
SELF_ANNOUNCE_ROUNDS + 1, and added a simple backoff scheme.
Signed-off-by: Nolan Leake <nolan <at> sigbus.net>
Signed-off-by: Anthony Liguori <[email protected]>
| 18995b9808dc48897bda6ed93ce3e978191f7251 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/18995b9808dc48897bda6ed93ce3e978191f7251 | 2009-10-27 12:28:36-05:00 |
Warn if value of qdev_init() isn't checked
After qdev_init() fails, the device is gone. Failure to check runs a
high risk of use-after-free.
Patchworks-ID: 35166
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| dde8bbb44de41ea68f9bede0a6a778ce046b2bcf | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dde8bbb44de41ea68f9bede0a6a778ce046b2bcf | 2009-10-07 08:54:55-05:00 |
vnc: fix copyrect screen corruption
When sending a copyrect command to the vnc client, we must also update
the local server surface. Otherwise the server's and the client's idea
of the screen content run out of sync and screen updates don't work
correctly.
Signed-off-by: Anthony Liguori <[email protected]>
| 3e28c9adf4bfe2f4792557ee45684181bd6e6d1c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3e28c9adf4bfe2f4792557ee45684181bd6e6d1c | 2009-07-30 09:50:37-05:00 |
Handle BH's queued by AIO completions in qemu_aio_flush()
Without this, the call to qemu_aio_flush during migration doesn't
actually flush all in-flight SCSI IOs.
Signed-off-by: Nolan Leake <nolan <at> sigbus.net>
Signed-off-by: Anthony Liguori <[email protected]>
| 6e5d97d01d9da6f295f9888d4b34e29fd737861a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6e5d97d01d9da6f295f9888d4b34e29fd737861a | 2009-07-22 10:58:46-05:00 |
xen_disk: move sanity check to the correct place
Signed-off-by: Gerd Hoffmann <[email protected]>
| 908c7b9f788b6faed2fbfdf19920770614f8e853 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/908c7b9f788b6faed2fbfdf19920770614f8e853 | 2009-06-13 16:11:07+03:00 |
Add documentation for Multiboot
The documentation shows how to use -kernel and friends for booting Linux,
but obviously knows nothing about multiboot yet.
Let's include some documentation for multiboot, so people know how to fully
exploit this cool new feature.
Signed-off-by: Alexander Graf <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 7677f05d843cb41d50578bfa9615c51c08cb64a7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7677f05d843cb41d50578bfa9615c51c08cb64a7 | 2009-06-29 14:18:06-05:00 |
net: Fix and improved ordered packet delivery
Fix a race in qemu_send_packet when delivering deferred packets and
add proper deferring also to qemu_sendv_packet.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Mark McLoughlin <[email protected]>
| c27ff60871aff588a35e51d1a90faed410993e55 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c27ff60871aff588a35e51d1a90faed410993e55 | 2009-06-09 11:38:48+01:00 |
qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf)
This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables
are big endian, so entries must be converted before being passed to functions.
This bug is easy to trigger. The following script will create and destroy a
qcow2 image (the header is gone after three loop iterations):
#!/bin/bash
qemu-img create -f qcow2 test.qcow 1M
for i in $(seq 1 10); do
qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 <<EOF
savevm test-$i
quit
EOF
done
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7165 c046a42c-6fe2-441c-8c8c-71466251a162
| 641636d19e3d8eeb8fac31e20641eaf33befd6e7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/641636d19e3d8eeb8fac31e20641eaf33befd6e7 | 2009-04-17 20:44:06+00:00 |
Fix display breakage when resizing the screen (v2) (Avi Kivity)
When the vga resolution changes, a new display surface is not allocated
immediately; instead that is deferred until the next update. However,
if we're running without a display client attached, that won't happen
and the next bitblt is likely to cause a segfault by overflowing the
display surface.
Fix by reallocating the display immediately when the resolution changes.
Tested with (Windows|Linux) x (cirrus|std) x (curses|sdl).
Changes from v1:
- fix segfault when switching virtual consoles with curses
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6989 c046a42c-6fe2-441c-8c8c-71466251a162
| 9586fefefe383a9aa25ad99bde9a6b240309ca33 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9586fefefe383a9aa25ad99bde9a6b240309ca33 | 2009-04-05 18:41:18+00:00 |
Fix uninitialized variable warning
r6322 introduced a warning pointed out by Jan Kiszka.
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6342 c046a42c-6fe2-441c-8c8c-71466251a162
| e9ebead2b5c70890454e698d9ff174e3020ea861 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e9ebead2b5c70890454e698d9ff174e3020ea861 | 2009-01-16 14:27:37+00:00 |
Make sure ACPI structures are byte-aligned
Apparently, guests are very tolerant of corrupt ACPI tables because our
tables have been badly corrupted for some time now. A version of
Knoppix using a 2.6.11 kernel refused to boot and it turned out it was
due to the interrupt override table introduced by the recent HPET
commit.
This patch updates the BIOS and introduces a patch to pack the ACPI
tables. If you have a guest that used to work and is broken by the this
commit, let me know. We have some weird hacks in the tables that I
suspect are work arounds for this bug.
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6108 c046a42c-6fe2-441c-8c8c-71466251a162
| ebd7fc5099f8c643a2427bc18b8333d0cebef0d5 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ebd7fc5099f8c643a2427bc18b8333d0cebef0d5 | 2008-12-19 16:17:10+00:00 |
Correctly initialize msr list in KVM
I believe this was spotted by Gerd Hoffman but I can't find his patch
now. This will cause very subtle corruption on the heap because we
don't allocate the appropriately sized buffer.
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6017 c046a42c-6fe2-441c-8c8c-71466251a162
| 4c9f7372fcf158d8a5d85ce9ce2988c27be63baf | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4c9f7372fcf158d8a5d85ce9ce2988c27be63baf | 2008-12-13 20:41:58+00:00 |
uImage: don't leak file data or file descriptor (Hollis Blanchard)
Signed-off-by: Hollis Blanchard <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5761 c046a42c-6fe2-441c-8c8c-71466251a162
| 265ca29a7162a9437efabdb3b133237eef49ab7b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/265ca29a7162a9437efabdb3b133237eef49ab7b | 2008-11-20 22:02:56+00:00 |
Make bottom halves more robust
Bottom halves are supposed to not complete until the next iteration of the main
loop. This is very important to ensure that guests can not cause stack
overflows in the block driver code. Right now, if you attempt to schedule a
bottom half within a bottom half callback, you will enter an infinite loop.
This patch uses the same logic that we use for the IOHandler loop to make the
bottom half processing robust in list manipulation while in a callback.
This patch also introduces idle scheduling for bottom halves. qemu_bh_poll()
returns an indication of whether any bottom halves were successfully executed.
qemu_aio_wait() uses this to immediately return if a bottom half was executed
instead of waiting for a completion notification.
qemu_bh_schedule_idle() works around this by not reporting the callback has
run in the qemu_bh_poll loop. qemu_aio_wait() probably needs some refactoring
but that would require a larger code audit. idle scheduling seems like a good
compromise.
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5572 c046a42c-6fe2-441c-8c8c-71466251a162
| 1b435b10324fe9937f254bb00718f78d5e50837a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1b435b10324fe9937f254bb00718f78d5e50837a | 2008-10-31 17:24:21+00:00 |
ETRAX-FS: Add support for DMA channel resets, needed for recent linux kernels.
* Correct numeric value for the RST state.
* Add emulation for reseting a DMA channel.
* Add a few sanity checks.
* Make it compile with debug enabled.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5147 c046a42c-6fe2-441c-8c8c-71466251a162
| 4487fd349baa6d2ae34ab86dea843642d20a036a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4487fd349baa6d2ae34ab86dea843642d20a036a | 2008-09-03 14:40:17+00:00 |
Revert "fix power management timer overflow handling" (Avi Kivity).
The fix is bogus, causing sci to be deferred for longer and longer.
Noticed by Alex Williamson.
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4904 c046a42c-6fe2-441c-8c8c-71466251a162
| 82258945ef2cc4a4ec7cdcef02e751bd30cb199f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/82258945ef2cc4a4ec7cdcef02e751bd30cb199f | 2008-07-19 14:11:22+00:00 |
Avoid decremented overflow.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4862 c046a42c-6fe2-441c-8c8c-71466251a162
| 266910c4346a24dff83ec01c7e1fa87eb938243f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/266910c4346a24dff83ec01c7e1fa87eb938243f | 2008-07-09 15:31:50+00:00 |
Refactor and fix do_sendkey (Jan Kiszka).
Looking at the sendkey implementation, planning to enhance it with a
hold time argument, I found some potential out-of-bound access and not
very readable code. Here is a fix for the former and a (subjective)
improvement of the latter.
Signed-off-by: Jan Kiszka <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4657 c046a42c-6fe2-441c-8c8c-71466251a162
| 3401c0d95ffb9a9a57093ee002d24d014ffed4f8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3401c0d95ffb9a9a57093ee002d24d014ffed4f8 | 2008-06-04 10:05:59+00:00 |
Revert fix for CVE-2008-0928. Will be fixed in a different way later.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4041 c046a42c-6fe2-441c-8c8c-71466251a162
| b5eff355460643d09e533024360fe0522f368c07 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b5eff355460643d09e533024360fe0522f368c07 | 2008-03-11 23:30:22+00:00 |
Add missing definition for number of input pins for the PowerPC 970 bus.
Use proper INPUT_NB definitions to allocate PowerPC input pins structure,
fixing a buffer overflow in the 6xx bus case.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3659 c046a42c-6fe2-441c-8c8c-71466251a162
| 7b62a955047934bab158e84ecb63cb432c193ace | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7b62a955047934bab158e84ecb63cb432c193ace | 2007-11-17 02:04:00+00:00 |
Full implementation of PowerPC 64 MMU, just missing support for 1 TB
memory segments.
Remove the PowerPC 64 "bridge" MMU model and implement segment registers
emulation using SLB entries instead.
Make SLB area size implementation dependant.
Improve TLB & SLB search debug traces.
Temporary hack to make PowerPC 970 boot from ROM instead of RAM.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3335 c046a42c-6fe2-441c-8c8c-71466251a162
| 12de9a396acbc95e25c5d60ed097cc55777eaaed | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/12de9a396acbc95e25c5d60ed097cc55777eaaed | 2007-10-05 22:06:02+00:00 |
Fix inconsistent end conditions in ppc_find_xxx functions.
(crash reported by Andreas Farber when using default CPU).
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3293 c046a42c-6fe2-441c-8c8c-71466251a162
| 068abdc8a57023eeafe1025b964a50f8a39929b4 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/068abdc8a57023eeafe1025b964a50f8a39929b4 | 2007-09-30 14:52:08+00:00 |
Avoid crash on NULL timers.
This is a rework of Stefan Weil proposed patch.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3283 c046a42c-6fe2-441c-8c8c-71466251a162
| 868d585aced5457218b3443398d08594d9c3ba6d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/868d585aced5457218b3443398d08594d9c3ba6d | 2007-09-30 01:29:07+00:00 |
Improved sanity checking to -net options
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2877 c046a42c-6fe2-441c-8c8c-71466251a162
| 833c7174ce5145397d2b3405f6857ca607fed1f1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/833c7174ce5145397d2b3405f6857ca607fed1f1 | 2007-05-27 19:36:43+00:00 |
Update OpenBIOS/Sparc32 to SVN 144. Changes:
- Fix power-management location
- Fix out of bounds accesses
- Increase virtual memory supply to meet NetBSD and OpenBSD demand
- More obviously alarming return values for find_pte
- Fix unaligned memory access
- Fix memory corruption problems reported by glibc
- Fix boot-device use
- Use nvram boot-args and boot-device variables
- Set variable defaults before nvram_init
- Improve escape sequence handling
- Fix nvram parameter area
- More Sparc32 CPUs
- Clear preloaded kernel parameters to avoid crash at reset
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2781 c046a42c-6fe2-441c-8c8c-71466251a162
| 64ddcd797a06a4598e0f5fe77aa82f7a11ef5695 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/64ddcd797a06a4598e0f5fe77aa82f7a11ef5695 | 2007-05-07 17:59:32+00:00 |
Fix qemu crash due to sparc division-by-zero, by Aurelien Jarno.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2510 c046a42c-6fe2-441c-8c8c-71466251a162
| 9bb234b3b170299c39c9e88cfe7da5434a92d99d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9bb234b3b170299c39c9e88cfe7da5434a92d99d | 2007-03-19 19:16:00+00:00 |
buffer overflow fix
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@932 c046a42c-6fe2-441c-8c8c-71466251a162
| eba2af633fb8fa3b20ad578184d79e1f0eabcefe | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/eba2af633fb8fa3b20ad578184d79e1f0eabcefe | 2004-06-19 17:23:39+00:00 |
hw/pci-bridge: fix QEMU crash because of pcie-root-port
If we try to use more pcie_root_ports then available slots
and an IO hint is passed to the port, QEMU crashes because
we try to init the "IO hint" capability even if the device
is not created.
Fix it by checking for error before adding the capability,
so QEMU can fail gracefully.
Signed-off-by: Marcel Apfelbaum <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| fced4d00e68e7559c73746d963265f7fd0b6abf9 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fced4d00e68e7559c73746d963265f7fd0b6abf9 | 2018-01-18 21:52:38+02:00 |
s390x/tcg: fixup TEST PROTECTION
CC == 2 can only happen due to a protection exception, not if memory is
not available (PGM_ADDRESSING). So all PGM_ADDRESSING exceptions have to
be forwarded to the guest.
Since the initial definition of TEST PROTECTION, we now read globals
(e.g. PSW mask), so we have to correctly mark the instruction
(otherwise, e.g. booting fedora 27 fails).
Also, the architecture explicitly specifies which exceptions are
forwarded to the guest, this makes the code a little nicer.
Signed-off-by: David Hildenbrand <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
| b5e85329026115b5a679849f45e7c19c2714e4fd | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b5e85329026115b5a679849f45e7c19c2714e4fd | 2018-01-22 11:04:52+01:00 |
trace: Simplify find_debugfs()
The return vale of find_debugfs() is 1 if it could find a mount point of
debugfs. It can be saved in the while loop instead of checking it again.
Signed-off-by: Namhyung Kim <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 5070570c9089b905dd9efae30ee4318033c6ccd6 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5070570c9089b905dd9efae30ee4318033c6ccd6 | 2017-12-18 14:37:36+00:00 |
xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done
Don't set TX FIFO UNDERFLOW interrupt after transmitting the commands.
Also update interrupts after reading out the interrupt status.
Signed-off-by: Francisco Iglesias <[email protected]>
Acked-by: Alistair Francis <[email protected]>
Reviewed-by: Edgar E. Iglesias <[email protected]>
Tested-by: Edgar E. Iglesias <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
| 2e1cf2c9685978193ef429cdb711bf50debea9d8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2e1cf2c9685978193ef429cdb711bf50debea9d8 | 2017-12-13 17:59:22+00:00 |
migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END
When migrating a VM with 'migrate_set_capability postcopy-ram on'
a postcopy_state is set during the process, ending up with the
state POSTCOPY_INCOMING_END when the migration is over. This
postcopy_state is taken into account inside ram_load to check
how it will load the memory pages. This same ram_load is called when
in a loadvm command.
Inside ram_load, the logic to see if we're at postcopy_running state
is:
postcopy_running = postcopy_state_get() >= POSTCOPY_INCOMING_LISTENING
postcopy_state_get() returns this enum type:
typedef enum {
POSTCOPY_INCOMING_NONE = 0,
POSTCOPY_INCOMING_ADVISE,
POSTCOPY_INCOMING_DISCARD,
POSTCOPY_INCOMING_LISTENING,
POSTCOPY_INCOMING_RUNNING,
POSTCOPY_INCOMING_END
} PostcopyState;
In the case where ram_load is executed and postcopy_state is
POSTCOPY_INCOMING_END, postcopy_running will be set to 'true' and
ram_load will behave like a postcopy is in progress. This scenario isn't
achievable in a migration but it is reproducible when executing
savevm/loadvm after migrating with 'postcopy-ram on', causing loadvm
to fail with Error -22:
Source:
(qemu) migrate_set_capability postcopy-ram on
(qemu) migrate tcp:127.0.0.1:4444
Dest:
(qemu) migrate_set_capability postcopy-ram on
(qemu)
ubuntu1704-intel login:
Ubuntu 17.04 ubuntu1704-intel ttyS0
ubuntu1704-intel login: (qemu)
(qemu) savevm test1
(qemu) loadvm test1
Unknown combination of migration flags: 0x4 (postcopy mode)
error while loading state for instance 0x0 of device 'ram'
Error -22 while loading VM state
(qemu)
This patch fixes this problem by changing the existing logic for
postcopy_advised and postcopy_running in ram_load, making them
'false' if we're at POSTCOPY_INCOMING_END state.
Signed-off-by: Daniel Henrique Barboza <[email protected]>
CC: Juan Quintela <[email protected]>
CC: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Peter Xu <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Reported-by: Balamuruhan S <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
| acab30b85db0885ab161aff4c83c550628f6d8ca | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/acab30b85db0885ab161aff4c83c550628f6d8ca | 2017-11-22 08:50:37+01:00 |
qemu-iotest: add test for blockjob coroutine race condition
Signed-off-by: Jeff Cody <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
| d975301dc8ae56fb3154348878e47a6211843c0b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d975301dc8ae56fb3154348878e47a6211843c0b | 2017-11-21 11:58:12-05:00 |
nbd: Don't crash when server reports NBD_CMD_READ failure
If a server fails a read, for example with EIO, but the connection
is still live, then we would crash trying to print a non-existent
error message in nbd_client_co_preadv(). For consistency, also
change the error printout in nbd_read_reply_entry(), although that
instance does not crash. Bug introduced in commit f140e300.
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]>
| 08ace1d75372b57c5ab56aea02c71cdda4b58fdf | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/08ace1d75372b57c5ab56aea02c71cdda4b58fdf | 2017-11-17 08:02:45-06:00 |
block: Make bdrv_next() keep strong references
On one hand, it is a good idea for bdrv_next() to return a strong
reference because ideally nearly every pointer should be refcounted.
This fixes intermittent failure of iotest 194.
On the other, it is absolutely necessary for bdrv_next() itself to keep
a strong reference to both the BB (in its first phase) and the BDS (at
least in the second phase) because when called the next time, it will
dereference those objects to get a link to the next one. Therefore, it
needs these objects to stay around until then. Just storing the pointer
to the next in the iterator is not really viable because that pointer
might become invalid as well.
Both arguments taken together means we should probably just invoke
bdrv_ref() and blk_ref() in bdrv_next(). This means we have to assert
that bdrv_next() is always called from the main loop, but that was
probably necessary already before this patch and judging from the
callers, it also looks to actually be the case.
Keeping these strong references means however that callers need to give
them up if they decide to abort the iteration early. They can do so
through the new bdrv_next_cleanup() function.
Suggested-by: Kevin Wolf <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
Message-id: [email protected]
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
| 5e003f17ec518cd96f5d2ac23ce9e14144426235 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5e003f17ec518cd96f5d2ac23ce9e14144426235 | 2017-11-17 18:21:31+01:00 |
s390x/css: unrestrict cssids
The default css 0xfe is currently restricted to virtual subchannel
devices. The hope when the decision was made was, that non-virtual
subchannel devices will come around when guest can exploit multiple
channel subsystems. Since the guests generally don't do, the pain
of the partitioned (cssid) namespace outweighs the gain.
Let us remove the corresponding restrictions (virtual devices
can be put only in 0xfe and non-virtual devices in any css except
the 0xfe -- while s390-squash-mcss then remaps everything to cssid 0).
At the same time, change our schema for generating css bus ids to put
both virtual and non-virtual devices into the default css (spilling over
into other css images, if needed). The intention is to deprecate
s390-squash-mcss. With this change devices without a specified devno
won't end up hidden to guests not supporting multiple channel subsystems,
unless this can not be avoided (default css full).
Let us also advertise the changes to the management software (so it can
tell are cssids unrestricted or restricted).
The adverse effect of getting rid of the restriction on migration should
not be too severe. Vfio-ccw devices are not live-migratable yet, and for
virtual devices using the extra freedom would only make sense with the
aforementioned guest support in place.
The auto-generated bus ids are affected by both changes. We hope to not
encounter any auto-generated bus ids in production as Libvirt is always
explicit about the bus id. Since 8ed179c937 ("s390x/css: catch section
mismatch on load", 2017-05-18) the worst that can happen because the same
device ended up having a different bus id is a cleanly failed migration.
I find it hard to reason about the impact of changed auto-generated bus
ids on migration for command line users as I don't know which rules is
such an user supposed to follow.
Another pain-point is down- or upgrade of QEMU for command line users.
The old way and the new way of doing vfio-ccw are mutually incompatible.
Libvirt is only going to support the new way, so for libvirt users, the
possible problems at QEMU downgrade are the following. If a domain
contains virtual devices placed into a css different than 0xfe the domain
will refuse to start with a QEMU not having this patch. Putting devices
into a css different that 0xfe however won't make much sense in the near
future (guest support). Libvirt will refuse to do vfio-ccw with a QEMU
not having this patch. This is business as usual.
Signed-off-by: Halil Pasic <[email protected]>
Acked-by: Christian Borntraeger <[email protected]>
Reviewed-by: Dong Jia Shi <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
| 99577c492fb2916165ed9bc215f058877f0a4106 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/99577c492fb2916165ed9bc215f058877f0a4106 | 2017-12-14 17:56:54+01:00 |
tests: Run the luks tests in test-crypto-block only if encryption is available
The test-crypto-block currently fails if encryption has not been
compiled into QEMU:
TEST: tests/test-crypto-block... (pid=22231)
/crypto/block/qcow: OK
/crypto/block/luks/default:
Unexpected error in qcrypto_pbkdf2() at qemu/crypto/pbkdf-stub.c:41:
FAIL
GTester: last random seed: R02Sbbb5b6f299c6727f41bb50ba4aa6ef5c
(pid=22237)
/crypto/block/luks/aes-256-cbc-plain64:
Unexpected error in qcrypto_pbkdf2() at qemu/crypto/pbkdf-stub.c:41:
FAIL
GTester: last random seed: R02S3e27992a5ab4cc95e141c4ed3c7f0d2e
(pid=22239)
/crypto/block/luks/aes-256-cbc-essiv:
Unexpected error in qcrypto_pbkdf2() at qemu/crypto/pbkdf-stub.c:41:
FAIL
GTester: last random seed: R02S51b52bb02a66c42d8b331fd305384f53
(pid=22241)
FAIL: tests/test-crypto-block
So run the luks test only if the required encryption support is available.
Signed-off-by: Thomas Huth <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
| b417a7624c67a1544f8b6afe3de1a18fc380746e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b417a7624c67a1544f8b6afe3de1a18fc380746e | 2017-11-08 11:03:46+00:00 |
sockets: avoid leak of listen file descriptor
If we iterate over the full port range without successfully binding+listening
on the socket, we'll try the next address, whereupon we overwrite the slisten
file descriptor variable without closing it.
Rather than having two places where we open + close socket FDs on different
iterations of nested for loops, re-arrange the code to always open+close
within the same loop iteration.
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
| 10a7b7e6fd9f250f0506568345d7b4d2ab52889d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/10a7b7e6fd9f250f0506568345d7b4d2ab52889d | 2017-11-07 14:10:20+00:00 |
Revert "qdev: Free QemuOpts when the QOM path goes away"
This reverts commit abed886ec60cf239a03515cf0b30fb11fa964c44.
This patch originally addressed an issue where a DEVICE_DELETED
event could be emitted (in device_unparent()) before a Device's
QemuOpts were cleaned up (in device_finalize()), leading to a
"duplicate ID" error if management attempted to immediately add
a device with the same ID in response to the DEVICE_DELETED event.
An alternative will be implemented in a subsequent patch where we
defer the DEVICE_DELETED event until device_finalize(), which would
also prevent the race, so we revert the original fix in preparation.
Signed-off-by: Michael Roth <[email protected]>
Reviewed-by: Greg Kurz <[email protected]>
Tested-by: Eric Auger <[email protected]>
Reviewed-by: David Gibson <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| 2fc06c4ac65594ad248e9a9150ebdde9ff5a1253 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2fc06c4ac65594ad248e9a9150ebdde9ff5a1253 | 2017-10-18 10:34:50+02:00 |
hw/ppc/spapr.c: abort unplug_request if previous unplug isn't done
LMB removal is completed only when the spapr_lmb_release callback
is called after all DRCs of the dimm are detached. During this
time, it is possible that a unplug request for the same dimm
arrives, trying to detach DRCs that were detached by the guest
in the first unplug_request.
BQL doesn't help in this case - the lock will prevent any concurrent
removal from happening until the end of spapr_memory_unplug_request
only. What happens is that the second unplug_request ends up calling
spapr_drc_detach in a DRC that were detached already, causing an
assert error in spapr_drc_detach (e.g
https://bugs.launchpad.net/qemu/+bug/1718118).
spapr_lmb_release uses a structure called sPAPRDIMMState, stored in the
spapr->pending_dimm_unplugs QTAIL, to track how many LMB DRCs are left
to be detached by the guest. When there are no more DRCs left, this
structure is deleted and the pc-dimm unplug handler is called to
finish the process.
This patch reuses the sPAPRDIMMState to allow unplug_request to know
if there is an ongoing unplug process for a given dimm, aborting the
unplug request in this case, by doing the following changes:
- in spapr_lmb_release callback, move the dimm state removal to the
end, after pc-dimm unplug handler. With this change we can check for
the existence of the dimm state to see if the unplug process is
done.
- use spapr_pending_dimm_unplugs_find in spapr_memory_unplug_request
to check if the dimm state exists. If positive, there is an unplug
operation already in progress for this dimm, meaning that we should
abort it and warn the user about it.
Fixes: https://bugs.launchpad.net/qemu/+bug/1718118
Signed-off-by: Daniel Henrique Barboza <[email protected]>
Signed-off-by: David Gibson <[email protected]>
| 2a129767ebb13ffc29dad6a8e8e6eec06dc38b25 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2a129767ebb13ffc29dad6a8e8e6eec06dc38b25 | 2017-10-17 10:34:00+11:00 |
filter-mirror: segfault when specifying non existent device
When using filter-mirror like the example below where the interface
'ndev0' does not exist on the host, QEMU crashes into segmentation
fault.
$ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=ndev0
This happens because the function filter_mirror_setup() does not check
if the device actually exists and still keep on processing calling
qemu_chr_find(). This patch fixes this issue.
Signed-off-by: Eduardo Otubo <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
| aa1530dec499f7525d2ccaa0e3a876dc8089ed1e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/aa1530dec499f7525d2ccaa0e3a876dc8089ed1e | 2017-10-16 23:16:06+03:00 |
io: fix mem leak in websock error path
Coverity pointed out the 'date' is not free()d in the error
path
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
| 7fc3fcefe2fc5966c6aa1ef4f10e9740d8d73bf2 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7fc3fcefe2fc5966c6aa1ef4f10e9740d8d73bf2 | 2017-10-16 16:57:08+01:00 |
hw/arm: Mark the "fsl,imx6" device with user_creatable = false
This device causes QEMU to abort if the user tries to instantiate it:
$ qemu-system-aarch64 -M sabrelite -smp 1,maxcpus=2 -device fsl,,imx6
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
qemu-system-aarch64: -device fsl,,imx6: Device 'serial0' is in use
Aborted (core dumped)
The device uses serial_hds[] directly in its realize function, so it
can not be instantiated again by the user.
Signed-off-by: Thomas Huth <[email protected]>
Message-id: [email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
| 70fbd3c4bf9850fce733eea2c910c397905fb9a3 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/70fbd3c4bf9850fce733eea2c910c397905fb9a3 | 2017-11-07 13:03:51+00:00 |
hw/pci-bridge/pcie_pci_bridge: properly handle MSI unavailability case
QEMU with the pcie-pci-bridge device crashes if the guest board doesn't support MSI,
e.g. 'qemu-system-ppc64 -M prep -device pcie-pci-bridge'.
This is caused by wrong pcie-pci-bridge instantiation error handling. This patch fixes this issue
by falling back to legacy INTx if MSI is not available.
Also set the bridge's 'msi' property default value to 'auto' in order to trigger errors
only when user explicitly set msi=on.
Reported-by: Eduardo Habkost <[email protected]>
Signed-off-by: Aleksandr Bezzubikov <[email protected]>
Reviewed-by: Marcel Apfelbaum <[email protected]>
Tested-by: Thomas Huth <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| d659d94013390238961fac741572306c95496bf5 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d659d94013390238961fac741572306c95496bf5 | 2017-10-15 05:54:41+03:00 |
docker: don't rely on submodules existing in the main checkout
When building the tarball to pass into the docker/vm test image,
the code relies on the git submodules being checked out in the
main checkout.
ie if the developer has not run 'git submodule update --init dtc'
many of the docker tests will fail due to the libfdt package not
being present in the test images. Patchew manually checks out the
dtc submodule in the main git checkout, but this is a bad idea.
When running tests we want to have a predictable set of submodules
included in the source that's tested. The build environment is
completely independent of the developers host OS, so the submodules
the developer has checked out should not be considered relevant for
the tests.
This changes the archive-source.sh script so that it clones the
current git checkout into a temporary directory, checks out a
fixed set of submodules, builds the tarball and finally removes
the temporary git clone.
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-id: [email protected]
Signed-off-by: Gerd Hoffmann <[email protected]>
| 47bb908dd195a0f25a13bb2bb5ff5fdcdfd218fb | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/47bb908dd195a0f25a13bb2bb5ff5fdcdfd218fb | 2017-10-16 14:50:54+02:00 |
chardev/baum: fix baum that releases brlapi twice
Error process of baum_chr_open needs to set brlapi null, so it won't
get released twice in char_braille_finalize, which will cause
"/usr/bin/qemu-system-x86_64: double free or corruption (!prev)"
Signed-off-by: Liang Yan <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
| 98e8790326d732fc79f0c133d9658f4761ba9cb7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/98e8790326d732fc79f0c133d9658f4761ba9cb7 | 2017-09-26 09:11:22+03:00 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.