commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
Prevent use after free in `DecodePng` kernel. We are cleaning up the memory in `decode` and then we are using an `OP_REQUIRES` to check an invariant on the `decode` data. PiperOrigin-RevId: 409299145 Change-Id: I4eb93aaca52483eb202e89b78df07fbb2f6cb254
e746adbfcfee15e9cfdb391ff746c765b99bdf9b
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e746adbfcfee15e9cfdb391ff746c765b99bdf9b
2021-11-11 19:18:59-08:00
Prevent memory leak in decoding PNG images. PiperOrigin-RevId: 409300653 Change-Id: I6182124c545989cef80cefd439b659095920763b
ab51e5b813573dc9f51efa335aebcf2994125ee9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ab51e5b813573dc9f51efa335aebcf2994125ee9
2021-11-11 19:36:01-08:00
Validate real and expected type of arguments to cwise ops. Without this validation, it is possible to trigger a `CHECK`-fail denial of service. This is a rollforward of a previous commit which was rolled back as it was relying on RTTI. This time we don't use RTTI, we replace `typeid(Tin).name()` with a double function call, `DataTypeString(DataTypeToEnum<Tin>::v())`. PiperOrigin-RevId: 409340416 Change-Id: I96080b2796729a3a9b65e7c68307ac276070f2f0
a7c02f1a9bbc35473969618a09ee5f9f5d3e52d9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/a7c02f1a9bbc35473969618a09ee5f9f5d3e52d9
2021-11-12 00:29:24-08:00
Eliminate `CHECK`-fail from `function.cc`. PiperOrigin-RevId: 409414744 Change-Id: Ic854e12ab2edb88b165d32e2d632c4ee654d71ad
3d89911481ba6ebe8c88c1c0b595412121e6c645
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/3d89911481ba6ebe8c88c1c0b595412121e6c645
2021-11-12 08:17:44-08:00
Check for type inference error on node construction. PiperOrigin-RevId: 409415804 Change-Id: Ieb6e020906b96f522bf8e2fa103715ddbbdc434a
955059813cc325dc1db5e2daa6221271406d4439
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/955059813cc325dc1db5e2daa6221271406d4439
2021-11-12 08:23:09-08:00
Eliminate debug `CHECK`-fail from `function.cc` PiperOrigin-RevId: 409416119 Change-Id: I8376ee464d434e9b970ff0ad49edfdaa2a273cfe
dcc21c7bc972b10b6fb95c2fb0f4ab5a59680ec2
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/dcc21c7bc972b10b6fb95c2fb0f4ab5a59680ec2
2021-11-12 08:28:29-08:00
Handle invalid inputs instead of crashing. PiperOrigin-RevId: 409549744 Change-Id: I7f5935b34b53f7e426a5462fcc027bdbf5dcda24
c99d98cd189839dcf51aee94e7437b54b31f8abd
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/c99d98cd189839dcf51aee94e7437b54b31f8abd
2021-11-12 17:47:55-08:00
Prevent `CHECK`-fail when building reference tensor. The tensor constructor does not allow reference dtypes, as these should not show up explicitly. However, when passed these invalid types instead of building an invalid object the constructor crashes via a `CHECK`-fail. We have a static builder that properly handles this case but is not applicable given current usage. Instead, before calling the constructor, we can check that the dtype is not a reference type and return an error otherwise, given that the dtype is user controlled so malicious users can trigger denial of service. PiperOrigin-RevId: 409662503 Change-Id: I5892f831fde7f276cd7ab34519cf6b8061c71a59
6b5adc0877de832b2a7c189532dbbbc64622eeb6
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/6b5adc0877de832b2a7c189532dbbbc64622eeb6
2021-11-13 07:34:25-08:00
Prevent overflow in grappler cost estimation of crop&resize op. The crop parameters are user controlled, so we should make sure a user can not trigger an overflow maliciously. PiperOrigin-RevId: 409670234 Change-Id: I7994734a98b037c5642e051240329d16f959aae4
0aaaae6eca5a7175a193696383f582f53adab23f
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/0aaaae6eca5a7175a193696383f582f53adab23f
2021-11-13 08:23:57-08:00
Prevent null pointer dereference in constant folding. Under certain conditions, an invalid protobuf saved model with invalid nodes would be loaded. During optimization phase, Grappler optimizer will then dereference a null pointer. PiperOrigin-RevId: 409683530 Change-Id: I1f10340a7ec384bc9bc587300390f1078cf5caa0
0a365c029e437be0349c31f8d4c9926b69fa3fa1
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/0a365c029e437be0349c31f8d4c9926b69fa3fa1
2021-11-13 10:10:49-08:00
Prevent null pointer dereference in `mutable_graph_view` PiperOrigin-RevId: 409684472 Change-Id: I577eb9d9ac470fcec0501423171e739a4ec0cb5c
045deec1cbdebb27d817008ad5df94d96a08b1bf
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/045deec1cbdebb27d817008ad5df94d96a08b1bf
2021-11-13 10:16:06-08:00
[tf.data] Set limit on number of threads used in threadpool_dataset. PiperOrigin-RevId: 410922677 Change-Id: Ib25814a99043ab10805b5d2d7088ae0e0b7b04fd
e3749a6d5d1e8d11806d4a2e9cc3123d1a90b75e
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e3749a6d5d1e8d11806d4a2e9cc3123d1a90b75e
2021-11-18 16:14:53-08:00
Fix out of bound access in DequantizeOp by adding check for axis < input dimension PiperOrigin-RevId: 411214268 Change-Id: I3249d2a69ddc82f182c589a3a5bbfb71543f4b29
23968a8bf65b009120c43b5ebcceaf52dbc9e943
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/23968a8bf65b009120c43b5ebcceaf52dbc9e943
2021-11-19 23:22:12-08:00
Internal change PiperOrigin-RevId: 411896058 Change-Id: Ia031058247e3cf382957a6662d3f9e1cbb481ca2
3218043d6d3a019756607643cf65574fbfef5d7a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/3218043d6d3a019756607643cf65574fbfef5d7a
2021-11-23 14:37:54-08:00
Fix out of bound error in ReverseSequence Op shape function PiperOrigin-RevId: 411896080 Change-Id: I7e59a38e2f960886edf2b6c54ed5a84e86a9b193
37c01fb5e25c3d80213060460196406c43d31995
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/37c01fb5e25c3d80213060460196406c43d31995
2021-11-23 14:42:02-08:00
Fix Segfault in Concat V2 shape function. PiperOrigin-RevId: 412120654 Change-Id: I3ff915faea694f9ad8b00024e9af2de9909011be
08d7b00c0a5a20926363849f611729f53f3ec022
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/08d7b00c0a5a20926363849f611729f53f3ec022
2021-11-24 13:14:19-08:00
Fix Integer overflow error in Dequantize op shape function, by adding a bound check on axis. PiperOrigin-RevId: 412121389 Change-Id: I3088dbad9e90f9998d406b618c16694388a9dfb4
b64638ec5ccaa77b7c1eb90958e3d85ce381f91b
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/b64638ec5ccaa77b7c1eb90958e3d85ce381f91b
2021-11-24 13:25:41-08:00
Fix potential divide by zero error when executing FractionalMaxPool, when pooling ratio is higher than input size for a particular dimension. PiperOrigin-RevId: 412151722 Change-Id: I06e57cbb8eca43816eff79eac264fa7aae8f7163
ba4e8ac4dc2991e350d5cc407f8598c8d4ee70fb
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ba4e8ac4dc2991e350d5cc407f8598c8d4ee70fb
2021-11-24 16:08:51-08:00
Fix integer overflow leading to divide by zero error in Unravel index kernel when dimensions product exceeds max int value. PiperOrigin-RevId: 413250052 Change-Id: I9450b6e8acecd2e881a64b882e2b7c70e8e9289a
58b34c6c8250983948b5a781b426f6aa01fd47af
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/58b34c6c8250983948b5a781b426f6aa01fd47af
2021-11-30 14:55:43-08:00
Add a check for pad width to be a positive value. PiperOrigin-RevId: 413275853 Change-Id: I261a8db9dabf5ce48a806a9e58129080c9fac619
f68fdab93fb7f4ddb4eb438c8fe052753c9413e8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/f68fdab93fb7f4ddb4eb438c8fe052753c9413e8
2021-11-30 16:57:47-08:00
Add a check for Key being scalar tensor for MapStage and OrderedMapStage ops. According to documentation[1][2], key must be int64 value, but this wasn't enforced and the ops would fail with check failure for non-scalar key value. [1]https://www.tensorflow.org/api_docs/cc/class/tensorflow/ops/ordered-map-stage [2]https://www.tensorflow.org/api_docs/cc/class/tensorflow/ops/map-stage PiperOrigin-RevId: 413822112 Change-Id: I9d118faf990e6361900aa32272eff486ad9f0e2e
f57315566d7094f322b784947093406c2aea0d7d
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/f57315566d7094f322b784947093406c2aea0d7d
2021-12-02 19:02:16-08:00
Add negative bound check for row and column pooling_sequence in FractionalAvgPoolGrad op to avoid out of bound heap access PiperOrigin-RevId: 413837346 Change-Id: I2b86034101df31bee161abcb781755e236c7bccd
002408c3696b173863228223d535f9de72a101a9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/002408c3696b173863228223d535f9de72a101a9
2021-12-02 21:02:49-08:00
Fix nullptr exception in QuantizedMaxPool op when empty list is sent to min_input or max_input parameters. PiperOrigin-RevId: 413960973 Change-Id: I9e3ded593f3c4eabf0d6d5dc356e6a19a3ad2682
53b0dd6dc5957652f35964af16b892ec9af4a559
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/53b0dd6dc5957652f35964af16b892ec9af4a559
2021-12-03 10:12:34-08:00
Prevent stack overflow when FunctionLib in GraphDef has a self-recursive function. It is likely that no recursivity is supported, but we should handle this separately. PiperOrigin-RevId: 414860329 Change-Id: I02a2270e86282b37362ddd485eeef16fb986a9e0
448a16182065bd08a202d9057dd8ca541e67996c
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/448a16182065bd08a202d9057dd8ca541e67996c
2021-12-07 16:54:09-08:00
Cleanup and remove duplicate validation in `SparseCount`. We have valdiation that is duplicated, checking different conditions, in different formats and failing to capture all cases. This should fix all the previous bugs. PiperOrigin-RevId: 414886981 Change-Id: Ibf0bba0beb057b76d505324bb9487565daf95f01
2b7100d6cdff36aa21010a82269bc05a6d1cc74a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/2b7100d6cdff36aa21010a82269bc05a6d1cc74a
2021-12-07 19:40:32-08:00
Further validate sparse tensor for `SparseCount`: indices must be valid within dense shape. PiperOrigin-RevId: 414888122 Change-Id: I4552bd74c135ecd4bcb5448acc0a3ce9402d8286
adbbabdb0d3abb3cdeac69e38a96de1d678b24b3
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/adbbabdb0d3abb3cdeac69e38a96de1d678b24b3
2021-12-07 19:49:35-08:00
Prevent crash due to integer overflow followed by allocating negative sized array. PiperOrigin-RevId: 414891322 Change-Id: I5df390e0dc1d9f115209293708950cdf9306931c
6f4d3e8139ec724dbbcb40505891c81dd1052c4a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/6f4d3e8139ec724dbbcb40505891c81dd1052c4a
2021-12-07 20:09:14-08:00
Fix check-fail when bincount ops are passed invalid values. PiperOrigin-RevId: 415063028 Change-Id: I20f8dc09933ddca1111c4efbf9a3a1e863215d02
7019ce4f68925fd01cdafde26f8d8c938f47e6f9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/7019ce4f68925fd01cdafde26f8d8c938f47e6f9
2021-12-08 12:10:17-08:00
Add missing validation to `AddManySparseToTensorsMap`. Sparse tensors have a set of requirements for the 3 components and not all of them were checked. PiperOrigin-RevId: 415358027 Change-Id: I96cbb672999cd1da772c22fabbd15507e32e12dc
b51b82fe65ebace4475e3c54eb089c18a4403f1c
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/b51b82fe65ebace4475e3c54eb089c18a4403f1c
2021-12-09 14:41:08-08:00
Properly validate sparse tensor in `SparseTensorSliceDataset` Existing validation was incomplete. PiperOrigin-RevId: 415375048 Change-Id: I14cd18f29ede73286f3ffac35171bd15828997e9
965b97e4a9650495cda5a8c210ef6684b4b9eceb
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/965b97e4a9650495cda5a8c210ef6684b4b9eceb
2021-12-09 15:55:37-08:00
Replace faulty overflow check with a builder for `TensorShape`. Prevents an integer overflow that was not caught before. PiperOrigin-RevId: 415381595 Change-Id: I76585ddedc912bd9f4a390aeafa8e2ced1a28863
a68f68061e263a88321c104a6c911fe5598050a8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/a68f68061e263a88321c104a6c911fe5598050a8
2021-12-09 16:21:06-08:00
Add missing validation to sparse dense cwise ops. PiperOrigin-RevId: 415543133 Change-Id: I5baf3284e919338afb96178c468ad3d3cb0d956c
1b54cadd19391b60b6fcccd8d076426f7221d5e8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/1b54cadd19391b60b6fcccd8d076426f7221d5e8
2021-12-10 09:51:09-08:00
Prevent overflow in sparse dense cwise ops. PiperOrigin-RevId: 415543171 Change-Id: I22dab7c41be2121ab5efe5403ca0e2f9b7cb24b8
e952a89b7026b98fe8cbe626514a93ed68b7c510
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e952a89b7026b98fe8cbe626514a93ed68b7c510
2021-12-10 10:05:21-08:00
[lite] Add check for bias_size is zero to avoid division by zero. This shouldn't happen for properly converted models. Just safety check PiperOrigin-RevId: 416383645 Change-Id: If8e508bf696ae8ecfb927e69c139a8ccf7fe60cb
8c6f391a2282684a25cbfec7687bd5d35261a209
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/8c6f391a2282684a25cbfec7687bd5d35261a209
2021-12-14 13:45:48-08:00
[lite] Add validation check for dilation height/width to be positive integers. PiperOrigin-RevId: 416429178 Change-Id: If7cdcddca54486434d9b2f06e7e2b401d7c3ee25
e5b0eec199c2d03de54fd6a7fd9275692218e2bc
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e5b0eec199c2d03de54fd6a7fd9275692218e2bc
2021-12-14 17:13:47-08:00
[lite] Update TfLiteIntArrayCreate to return size_t PiperOrigin-RevId: 416439896 Change-Id: I847f69b68d1ddaff4b1e925a09b8b69c1756653b
a1e1511dde36b3f8aa27a6ec630838e7ea40e091
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/a1e1511dde36b3f8aa27a6ec630838e7ea40e091
2021-12-14 18:14:24-08:00
[lite] Move MultiplyAndCheckOverflow to util to be able to share it. PiperOrigin-RevId: 416897229 Change-Id: I5feb44881bdcbb6ed911da4f17c55bb978754059
f19be71717c497723ba0cea0379e84f061a75e01
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/f19be71717c497723ba0cea0379e84f061a75e01
2021-12-16 14:37:01-08:00
[lite] Add some safety checks to avoid out of bound access for sparsity format PiperOrigin-RevId: 416910386 Change-Id: Ic0b4dc048dc4b5a6309c572b8c4c9f776e4db60a
6364463d6f5b6254cac3d6aedf999b6a96225038
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/6364463d6f5b6254cac3d6aedf999b6a96225038
2021-12-16 15:46:23-08:00
Avoid Segfault for scalar shapes. Calling tensor::FromElementsOp with an empty vector of elements and no type causes a segfault. We need to let the FromElementsOp know which scalar type it should have. Also add back the DynamicBroadcastInDimOp canonicalization patterns, which previously prevented this bug from happening. Add a regression test that demonstrates the bug. PiperOrigin-RevId: 417561444 Change-Id: I6d1d6cfb71aabbad6102422625a00bbe253ac95a
35f0fabb4c178253a964d7aabdbb15c6a398b69a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/35f0fabb4c178253a964d7aabdbb15c6a398b69a
2021-12-21 01:12:06-08:00
[lite] Check for overflow when creating required bytes. PiperOrigin-RevId: 417629001 Change-Id: Ia7feb3ea8e988f4fd4b3c98c1a1fed4557d99fd7
1de49725a5fc4e48f1a3b902ec3599ee99283043
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/1de49725a5fc4e48f1a3b902ec3599ee99283043
2021-12-21 08:52:29-08:00
[lite] add validation check for sparse fully connected PiperOrigin-RevId: 417629354 Change-Id: If96171c4bd4f5fdb01d6368d6deab19d1c9beca7
6c0b2b70eeee588591680f5b7d5d38175fd7cdf6
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/6c0b2b70eeee588591680f5b7d5d38175fd7cdf6
2021-12-21 09:02:48-08:00
Prevent segfault in `embedding_lookup_sparse.cc` Previous fixes missed one additional case. PiperOrigin-RevId: 417676944 Change-Id: I8ab412155cf9b1e897448a6611d209eaa7ca9e66
a4e401da71458d253b05e41f28637b65baf64be4
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/a4e401da71458d253b05e41f28637b65baf64be4
2021-12-21 13:11:50-08:00
Fix Null-pointer dereference in BuildXlaCompilationCache If ConfigProto is not used, then use the default settings which is to allow all devices. PiperOrigin-RevId: 420391800 Change-Id: I88161ad7042990aef678e77b597a2fb2c8f815be
e21af685e1828f7ca65038307df5cc06de4479e8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e21af685e1828f7ca65038307df5cc06de4479e8
2022-01-07 16:25:21-08:00
Improve to cover scale value greater than one PiperOrigin-RevId: 433050921
a989426ee1346693cc015792f11d715f6944f2b8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/a989426ee1346693cc015792f11d715f6944f2b8
2022-03-07 15:35:57-08:00
Validate `num_segments > 0` in `unsorted_segment_join` Fixes #55305 PiperOrigin-RevId: 442047005
84563f265f28b3c36a15335c8b005d405260e943
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/84563f265f28b3c36a15335c8b005d405260e943
2022-04-15 10:37:43-07:00
Prevent crash when histogram is called with NaN values. Fixes #45770 PiperOrigin-RevId: 443149951
e57fd691c7b0fd00ea3bfe43444f30c1969748b5
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e57fd691c7b0fd00ea3bfe43444f30c1969748b5
2022-04-20 11:40:43-07:00
Allow 0 for number of segments in `unsorted_segment_join_op.cc` Related to the fix for #55305 PiperOrigin-RevId: 443157549
20cb18724b0bf6c09071a3f53434c4eec53cc147
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/20cb18724b0bf6c09071a3f53434c4eec53cc147
2022-04-20 12:08:41-07:00
Fix tf.compat.v1.placeholder_with_default vulnerability with quantized types. When iterating through the tensor to extract shape values, an underlying missing kernel (`StridedSlice` for quantized types) causes an error, which then results in a `nullptr` being passed to `ParseDimensionValue()`, causing a segfault. The `nullptr` check allows the missing kernel error to propagate. Adding the missing kernel registrations allows the shape values to be extracted successfully. PiperOrigin-RevId: 445045957
237822b59fc504dda2c564787f5d3ad9c4aa62d9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/237822b59fc504dda2c564787f5d3ad9c4aa62d9
2022-04-27 20:55:48-07:00
Fix tf.raw_ops.TensorSummaryV2 vulnerability with invalid serialized_summary_metadata. Check that input is actually a scalar before treating it as such. PiperOrigin-RevId: 445197183
290bb05c80c327ed74fae1d089f1001b1e2a4ef7
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/290bb05c80c327ed74fae1d089f1001b1e2a4ef7
2022-04-28 11:05:57-07:00
Fix tf.raw_ops.QuantizeAndDequantizeV4Grad vulnerability with invalid input_min or input_max. Check that argument is actually a scalar before treating it as such. PiperOrigin-RevId: 445198280
098e7762d909bac47ce1dbabe6dfd06294cb9d58
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/098e7762d909bac47ce1dbabe6dfd06294cb9d58
2022-04-28 11:18:27-07:00
Fix tf.raw_ops.UnsortedSegmentJoin vulnerability with invalid num_segments. Check that input is actually a scalar before treating it as such. PiperOrigin-RevId: 445206880
13d38a07ce9143e044aa737cfd7bb759d0e9b400
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/13d38a07ce9143e044aa737cfd7bb759d0e9b400
2022-04-28 11:51:59-07:00
Fix tf.raw_ops.GetSessionTensor vulnerability with invalid handle. Check that input is actually a scalar before treating it as such. PiperOrigin-RevId: 445218701
48305e8ffe5246d67570b64096a96f8e315a7281
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/48305e8ffe5246d67570b64096a96f8e315a7281
2022-04-28 12:29:12-07:00
Fix tf.raw_ops.DeleteSessionTensor vulnerability with invalid `handle`. Check that `handle` input is actually a scalar before treating it as such. PiperOrigin-RevId: 445228994
cff267650c6a1b266e4b4500f69fbc49cdd773c5
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/cff267650c6a1b266e4b4500f69fbc49cdd773c5
2022-04-28 13:12:18-07:00
Fix tf.raw_ops.EditDistance vulnerability with negative indices. Check that indices are non-negative. Fix several identical code sites. Clean up grammar in error message. PiperOrigin-RevId: 445442017
30721cf564cb029d34535446d6a5a6357bebc8e7
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/30721cf564cb029d34535446d6a5a6357bebc8e7
2022-04-29 09:51:06-07:00
Fix failed check in Conv3DBackpropFilterV2. Passing in a rank-0 `filter_size` causes a check fail and crash, coming from a `filter_size.vec<>()` call. Here we check the size first. PiperOrigin-RevId: 445517122
174c5096f303d5be7ed2ca2662b08371bff4ab88
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/174c5096f303d5be7ed2ca2662b08371bff4ab88
2022-04-29 15:20:38-07:00
Fix undefined behavior in QuantizedConv2D Added more input validation and tests. Prior to this, we could get `nullptr` exceptions when attempting to access 0th elements of 0-sized inputs, leading to security vulnerability bugs. Also needed to modify `quantized_conv_ops_test.cc` for consistency. Previously the CPU kernel did technically support passing tensors of rank larger than 0 for min/max values. However, the XLA kernels do not. PiperOrigin-RevId: 445518507
0f0b080ecde4d3dfec158d6f60da34d5e31693c4
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/0f0b080ecde4d3dfec158d6f60da34d5e31693c4
2022-04-29 15:32:23-07:00
Fix tf.raw_ops.LoadAndRemapMatrix vulnerability with invalid `row_remapping`. Check that `row_remapping` has the correct dims(). PiperOrigin-RevId: 445522800
3150642acbbe254e3c3c5d2232143fa591855ac9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/3150642acbbe254e3c3c5d2232143fa591855ac9
2022-04-29 15:46:05-07:00
Fix tf.raw_ops.StagePeek vulnerability with invalid `index`. Check that input is actually a scalar before treating it as such. PiperOrigin-RevId: 445524908
cebe3c45d76357d201c65bdbbf0dbe6e8a63bbdb
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/cebe3c45d76357d201c65bdbbf0dbe6e8a63bbdb
2022-04-29 15:59:39-07:00
Fix security vulnerability with SpaceToBatchNDOp. PiperOrigin-RevId: 445527615
acd56b8bcb72b163c834ae4f18469047b001fadf
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/acd56b8bcb72b163c834ae4f18469047b001fadf
2022-04-29 16:14:54-07:00
Fix empty resource handle vulnerability. Some ops that attempt to extract a resource handle from user input can lead to nullptr dereferences. This returns an error in such a case. PiperOrigin-RevId: 445571938
a5b89cd68c02329d793356bda85d079e9e69b4e7
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/a5b89cd68c02329d793356bda85d079e9e69b4e7
2022-04-29 21:10:29-07:00
Fix security vulnerability with LSTMBlockCellOp PiperOrigin-RevId: 446028341
803404044ae7a1efac48ba82d74111fce1ddb09a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/803404044ae7a1efac48ba82d74111fce1ddb09a
2022-05-02 14:28:15-07:00
Fix failed check in SparseTensorToCSRSparseMatrix Security vulnerability fix. A `CHECK` fails if inputing either an empty `dense_shape`, or a non-rank-2 `indices`. Added appropriate checks and tests. PiperOrigin-RevId: 446053984
ea50a40e84f6bff15a0912728e35b657548cef11
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ea50a40e84f6bff15a0912728e35b657548cef11
2022-05-02 16:16:54-07:00
Fix UB in SparseTensorDenseAdd Added more input validation to avoid nullptr dereferencing and array index out of bounds issues. PiperOrigin-RevId: 446192704
11ced8467eccad9c7cb94867708be8fa5c66c730
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/11ced8467eccad9c7cb94867708be8fa5c66c730
2022-05-03 07:54:57-07:00
Fix TensorKey hash function. The original hash function only used total estimated `AllocatedBytes()`, which (a) is an estimate per tensor, and (b) is a very poor hash function for constants (e.g. `int32_t`). It also tried to access individual tensor bytes through `tensor.data()` of size `AllocatedBytes()`. This led to ASAN failures because the `AllocatedBytes()` is an estimate of total bytes allocated by a tensor, including any pointed-to constructs (e.g. strings), and does not refer to contiguous bytes in the `.data()` buffer. We couldn't use this byte vector anyways, since types like `tstring` include pointers, whereas we need to hash the string values themselves. Modified the hash function to more closely mirror the `==` operator. This correctly handles `tstring` and any numeric types that do have contiguous storage. Other types are currently left as unimplemented. PiperOrigin-RevId: 446265413
1b85a28d395dc91f4d22b5f9e1e9a22e92ccecd6
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/1b85a28d395dc91f4d22b5f9e1e9a22e92ccecd6
2022-05-03 12:51:58-07:00
Fix heap buffer overflow in UnsortedSegmentSum. When Index=int32, data_size and num_segments were truncated from int64 to int32. This truncation can produce negative numbers, which causes UnsortedSegmentFunctor to access out of bounds memory. Also: - Switches some indexing calculations to int64 to avoid signed integer overflow when either the input or output tensors have more than 2**31 - 1 elements. - Fixes a range check error in the GPU kernel. The segment ID was checked against an upper bound measured in elements, not segments. PiperOrigin-RevId: 256451663
db4f9717c41bccc3ce10099ab61996b246099892
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/db4f9717c41bccc3ce10099ab61996b246099892
2019-07-03 18:10:21-07:00
[tflite] Validate segment ids for segment_sum. Segment identifiers in segment_sum should be in a 1-D tensor of same size as the first dimension of the input. The values of the tensor should be integers from {0, 1, 2, ... k-1}, where k is the first dimension of the input. The segment identifiers must not contain jumps and must be increasing. See https://www.tensorflow.org/api_docs/python/tf/math#Segmentation as the source for these constraints. PiperOrigin-RevId: 332510942 Change-Id: I898beaba00642c918bcd4b4d4ce893ebb190d869
204945b19e44b57906c9344c0d00120eeeae178a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/204945b19e44b57906c9344c0d00120eeeae178a
2020-09-18 13:17:42-07:00
[tflite] Test for `kTfLiteOptionalTensor` in `GetInput`. `GetInput`, `GetVariableInput` and `GetOutput` all fail to check for the case where `node->inputs->data[index]` is the special `kTfLiteOptionalTensor` value (-1) which then causes `context->tensors[node->inputs->data[index]]` to read from invalid memory location. This fix makes `GetInput` and related return `nullptr` in those cases, asking the caller to check for `nullptr`. This is better than having `GetOptionalInputTensor` and `GetOptionalOutputTensor` (does not exist but could be added) as using the patched `GetInput` in error would be caught by a sanitizer test in the default optimized build (due to the `-fsanitize=null` option). PiperOrigin-RevId: 332512190 Change-Id: Iabca54da2f2de02b6ece3c38b54f76d4277d689e
46d5b0852528ddfd614ded79bccc75589f801bd9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/46d5b0852528ddfd614ded79bccc75589f801bd9
2020-09-18 13:21:55-07:00
[tflite] Make `GetOptionalInputTensor` the same as `GetInput`. With the previous change, there is no more need for two separate APIs. We would deprecate `GetOptionalInputTensor` in the future. PiperOrigin-RevId: 332513386 Change-Id: Id7110271c25ebd6126ad8c82a493e37e0e0756b3
00302787b788c5ff04cb6f62aed5a74d936e86c0
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/00302787b788c5ff04cb6f62aed5a74d936e86c0
2020-09-18 13:32:01-07:00
[tflite]: Insert `nullptr` checks when obtaining tensors. As part of ongoing refactoring, `tflite::GetInput`, `tflite::GetOutput`, `tflite::GetTemporary` and `tflite::GetIntermediates` will return `nullptr` in some cases. Hence, we insert the `nullptr` checks on all usages. We also insert `nullptr` checks on usages of `tflite::GetVariableInput` and `tflite::GetOptionalInputTensor` but only in the cases where there is no obvious check that `nullptr` is acceptable (that is, we only insert the check for the output of these two functions if the tensor is accessed as if it is always not `nullptr`). PiperOrigin-RevId: 332517854 Change-Id: Ic27221dd1f0fbe302f311c2fe5a846ed8ff02016
e11f55585f614645b360563072ffeb5c3eeff162
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/e11f55585f614645b360563072ffeb5c3eeff162
2020-09-18 13:53:51-07:00
[tflite]: Insert `nullptr` checks when obtaining tensors. As part of ongoing refactoring, `tflite::GetInput`, `tflite::GetOutput`, `tflite::GetTemporary` and `tflite::GetIntermediates` will return `nullptr` in some cases. Hence, we insert the `nullptr` checks on all usages. We also insert `nullptr` checks on usages of `tflite::GetVariableInput` and `tflite::GetOptionalInputTensor` but only in the cases where there is no obvious check that `nullptr` is acceptable (that is, we only insert the check for the output of these two functions if the tensor is accessed as if it is always not `nullptr`). PiperOrigin-RevId: 332518902 Change-Id: I92eb164a6101ac3cca66090061a9b56a97288236
cd31fd0ce0449a9e0f83dcad08d6ed7f1d6bef3f
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/cd31fd0ce0449a9e0f83dcad08d6ed7f1d6bef3f
2020-09-18 14:01:54-07:00
[tflite]: Insert `nullptr` checks when obtaining tensors. As part of ongoing refactoring, `tflite::GetInput`, `tflite::GetOutput`, `tflite::GetTemporary` and `tflite::GetIntermediates` will return `nullptr` in some cases. Hence, we insert the `nullptr` checks on all usages. We also insert `nullptr` checks on usages of `tflite::GetVariableInput` and `tflite::GetOptionalInputTensor` but only in the cases where there is no obvious check that `nullptr` is acceptable (that is, we only insert the check for the output of these two functions if the tensor is accessed as if it is always not `nullptr`). PiperOrigin-RevId: 332520146 Change-Id: I405d986cfc653aaafcfdf4162c0acbd46220b921
fff2c8326280c07733828f990548979bdc893859
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/fff2c8326280c07733828f990548979bdc893859
2020-09-18 14:10:11-07:00
[tflite]: Insert `nullptr` checks when obtaining tensors. As part of ongoing refactoring, `tflite::GetInput`, `tflite::GetOutput`, `tflite::GetTemporary` and `tflite::GetIntermediates` will return `nullptr` in some cases. Hence, we insert the `nullptr` checks on all usages. We also insert `nullptr` checks on usages of `tflite::GetVariableInput` and `tflite::GetOptionalInputTensor` but only in the cases where there is no obvious check that `nullptr` is acceptable (that is, we only insert the check for the output of these two functions if the tensor is accessed as if it is always not `nullptr`). PiperOrigin-RevId: 332521299 Change-Id: I29af455bcb48d0b92e58132d951a3badbd772d56
1970c2158b1ffa416d159d03c3370b9a462aee35
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/1970c2158b1ffa416d159d03c3370b9a462aee35
2020-09-18 14:13:50-07:00
[tflite] Ensure inputs and outputs don't overlap. If a model uses the same tensor for both an input and an output then this can result in data loss and memory corruption. This should not happen. PiperOrigin-RevId: 332522916 Change-Id: If0905b142415a9dfceaf2d181872f2a8fb88f48a
d58c96946b2880991d63d1dacacb32f0a4dfa453
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/d58c96946b2880991d63d1dacacb32f0a4dfa453
2020-09-18 14:21:55-07:00
[tflite] Ensure input tensors don't have `nullptr` buffers. A crafted TFLite model can force a node to have as input a tensor backed by a `nullptr` buffer. That is, by carefully changing the buffer index in the flatbuffer serialization, we can force the TFLite interpreter to consider a read-only tensor to be a read-write one and assume that there is an operator that has this tensor as output, writing to it and allocating memory before the tensor is used as input. If this does not happen, we get memory corruption. PiperOrigin-RevId: 332524692 Change-Id: I57ef175152a29020af9ab041dc959e5631dce40f
0b5662bc2be13a8c8f044d925d87fb6e56247cd8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/0b5662bc2be13a8c8f044d925d87fb6e56247cd8
2020-09-18 14:34:47-07:00
[tflite] Ensure `ResolveAxis` properly handles negative inputs. In Python, a list `l` of length `n` allows indexing with negative indices, `l[i]`. The only constraint is that `n + i` becomes positive. Code in `ResolveAxis` assumes the constraints and only checks it using a `DCHECK`. But the macro is a no-op in non-debug builds and that can result in reading from negative offsets (buffer underflows). PiperOrigin-RevId: 332530683 Change-Id: I464e073fee618054ae3719a3679739007bb3f3bc
2d88f470dea2671b430884260f3626b1fe99830a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/2d88f470dea2671b430884260f3626b1fe99830a
2020-09-18 14:57:58-07:00
Validate `NodeDef`s from `FunctionDefLibrary` of a `GraphDef`. We already validated `NodeDef`s from a `GraphDef` but missed validating those from the `FunctionDefLibrary`. Thus, some maliciously crafted models could evade detection and cause denial of service due to a `CHECK`-fail. PiperOrigin-RevId: 332536309 Change-Id: I052efe919ff1fe2f90815e286a1aa4c54c7b94ff
adf095206f25471e864a8e63a0f1caef53a0e3a6
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/adf095206f25471e864a8e63a0f1caef53a0e3a6
2020-09-18 15:17:30-07:00
Validate `data_splits` for `tf.StringNGrams`. Without validation, we can cause a heap buffer overflow which results in data leakage and/or segfaults. PiperOrigin-RevId: 332543478 Change-Id: Iee5bda24497a195d09d122355502480830b1b317
0462de5b544ed4731aa2fb23946ac22c01856b80
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/0462de5b544ed4731aa2fb23946ac22c01856b80
2020-09-18 16:00:29-07:00
Prevent segfault in `GetSessionHandle{,V2}`. In eager mode, session state is null. PiperOrigin-RevId: 332548597 Change-Id: If094812c2e094044220b9ba28f7d7601be042f38
9a133d73ae4b4664d22bd1aa6d654fec13c52ee1
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/9a133d73ae4b4664d22bd1aa6d654fec13c52ee1
2020-09-18 16:30:02-07:00
Prevent format string vulnerability in `tf.strings.as_string`. The `printf` format specifier only allows `#`, `0`, `-`, `+` and space as flag characters. Others are interpreted as width/precision/length modifier or conversion specifiers. If a character does not fit into any of these sets `printf` just displays it. Also add a test suite for `tf.strings.as_string`. Also fix the issue where the flag character was used only if width was specified. PiperOrigin-RevId: 332553548 Change-Id: Ie57cf2a7c14d1a36097642794c14329db669bbba
33be22c65d86256e6826666662e40dbdfe70ee83
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/33be22c65d86256e6826666662e40dbdfe70ee83
2020-09-18 16:59:09-07:00
Prevent `int64` to `int` truncation in `Shard` API usage. The function argument in `Shard` must be a function of two `int64` arguments. However, we are passing in a function with two `int` arguments. Thus, for large workloads, these arguments get truncated from positive `int64` values to negative `int` ones, resulting in a buffer out of bounds write. PiperOrigin-RevId: 332557334 Change-Id: I236c9a2e7f53580e520571da8ba941a3aa9fa0b5
27b417360cbd671ef55915e4bb6bb06af8b8a832
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/27b417360cbd671ef55915e4bb6bb06af8b8a832
2020-09-18 17:34:10-07:00
Prevent integer truncation from 64 to 32 bits. The `tensorflow::Shard` functions last argument must be a 2 argument function where both arguments are `int64` (`long long`, 64 bits). However, there are usages where code passes in a function where arguments are `int` or `int32` (32 bits). In these cases, it is possible that the integer truncation would later cause a segfault or other unexpected behavior. PiperOrigin-RevId: 332560414 Change-Id: Ief649406babc8d4f60b3e7a9d573cbcc5ce5b767
ca8c013b5e97b1373b3bb1c97ea655e69f31a575
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ca8c013b5e97b1373b3bb1c97ea655e69f31a575
2020-09-18 17:56:30-07:00
Fix multiple vulnerabilities in `tf.raw_ops.*CountSparseOutput`. Also add tests for these API points, both for the happy paths and for the vulnerable ones. PiperOrigin-RevId: 332563222 Change-Id: Ib3b52116a83a134c2e742a7c66e5e956db8fba05
3cbb917b4714766030b28eba9fb41bb97ce9ee02
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/3cbb917b4714766030b28eba9fb41bb97ce9ee02
2020-09-18 18:20:14-07:00
Fix heap buffer overflow in `tf.raw_ops.SparseFillEmptyRowsGrad`. Also add tests as they were lacking PiperOrigin-RevId: 332566071 Change-Id: I44277578e26ff5fb3fdb0dcbba6e91b2ec3e7859
390611e0d45c5793c7066110af37c8514e6a6c54
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/390611e0d45c5793c7066110af37c8514e6a6c54
2020-09-18 18:53:02-07:00
Fix multiple vulnerabilities in `tf.experimental.dlpack.to_dlpack`. We have a use after free caused by memory coruption, a segmentation fault caused by memory corruption, several memory leaks and an undefined behavior when taking the reference of a nullptr. PiperOrigin-RevId: 332568894 Change-Id: Ife0fc05e103b35325094ae5d822ee5fdea764572
22e07fb204386768e5bcbea563641ea11f96ceb8
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/22e07fb204386768e5bcbea563641ea11f96ceb8
2020-09-18 19:19:43-07:00
Fix undefined behavior in `tf.raw_ops.Switch` in eager mode. PiperOrigin-RevId: 332578058 Change-Id: I9727571d2f21476b10d8aa27c1b7176564b76ac9
da8558533d925694483d2c136a9220d6d49d843c
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/da8558533d925694483d2c136a9220d6d49d843c
2020-09-18 21:20:16-07:00
Prevent segfault in `quantize_and_dequantize` Fixes #42105. If `tf.quantization.quantize_and_dequantize` is called with `axis` argument pointing to outside of the input tensor, we obtain a `CHECK` fail which then aborts the application/interpreter. This change adds a condition check and returns a `Status` instead of crashing. PiperOrigin-RevId: 337972243 Change-Id: I71ec32c00a87266e364fb017f0ad5dfd3e23542f
eccb7ec454e6617738554a255d77f08e60ee0808
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/eccb7ec454e6617738554a255d77f08e60ee0808
2020-10-19 18:03:39-07:00
Default initialize fixed point Eigen types. In certain cases, tensors are filled with default values of the type. But, for these fixed point types, these values were uninitialized. Thus, we would have uninitialized memory access bugs, some of which were caught by MSAN. PiperOrigin-RevId: 344101137 Change-Id: I14555fda74dca3b5f1582da9008901937e3f14e2
ace0c15a22f7f054abcc1f53eabbcb0a1239a9e2
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ace0c15a22f7f054abcc1f53eabbcb0a1239a9e2
2020-11-24 11:48:54-08:00
Mark `MemmappedTensorAllocator` as returning opaque handle. This allocator is used for `ImmutableConstantOp` and it returns a handle to the contents of a memory mapped file which is supposed to represent a tensor. For tensors of complex types (resources, variables and strings), allocators which are not marked as returning opaque handles will call placement new to initialize each element. This means writing to the buffer. However, in our case, the buffer is immutable and already contains the tensor data. Hence, writing to it is both destructive and causes a crash. PiperOrigin-RevId: 345786451 Change-Id: I46369c50fa60b3431709ffe068a728d3061f49c4
c1e1fc899ad5f8c725dcbb6470069890b5060bc7
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/c1e1fc899ad5f8c725dcbb6470069890b5060bc7
2020-12-04 17:12:18-08:00
Validate that `DataFormat*` attributes form a permutation. The `src_format` and `dst_format` attributes for the `DataFormatDimMap` and `DataFormatVecPermute` raw ops are supposed to determine a permutation. However, this was not validated and could result in unitialized memory accesses as well as writes outside of bounds and potential crashes. While here, we also test that the format attributes have the needed length, add tests for all validation failure cases, remove unnecessary calls to `strings::StrCat`, and fix a few grammar errors. This will be cherry-picked on the supported release branches. PiperOrigin-RevId: 346135579 Change-Id: I1c76392382c89ad8f072d5bc93d70669851eb404
ebc70b7a592420d3d2f359e4b1694c236b82c7ae
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ebc70b7a592420d3d2f359e4b1694c236b82c7ae
2020-12-07 11:25:52-08:00
Completely rewrite `GetMatchingPaths`. The current parallel implementation is too complex (lambda inside lambda, two levels of parallelism) and has a read outside of bounds issue. The new implementation cleans up artifacts from the previous implementations that were left in the code as it evolves. We add multiple helper functions, and document invariants and preconditions as well as every major step. This way, we fix the security issue and a potential new one which was not caught before PiperOrigin-RevId: 346146220 Change-Id: Iec0f44673f43349797bf9944dffe9b2f779137d8
8b5b9dc96666a3a5d27fad7179ff215e3b74b67c
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/8b5b9dc96666a3a5d27fad7179ff215e3b74b67c
2020-12-07 12:04:28-08:00
Prevent CHECK-fail in LSTM/GRU with zero-length input. PiperOrigin-RevId: 346239181 Change-Id: I5f233dbc076aab7bb4e31ba24f5abd4eaf99ea4f
14755416e364f17fb1870882fa778c7fec7f16e3
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/14755416e364f17fb1870882fa778c7fec7f16e3
2020-12-07 20:37:00-08:00
Prevent unitialized memory access in `GraphConstructor::MakeEdge` The `MakeEdge` implementation assumes that there exists an output at `output_index` of `src` node and an input at `input_index` of `dst` node. However, if this is not the case this results in accessing data out of bounds. Because we are accessing an array that is a private member of a class and only in read only mode, this usually results only in unitialized memory access. However, it is reasonable to think that malicious users could manipulate these indexes to actually read data outside the class, thus resulting in information leakage and further exploits. PiperOrigin-RevId: 346343288 Change-Id: I2127da27c2023d27f26efd39afa6c853385cab6f
0cc38aaa4064fd9e79101994ce9872c6d91f816b
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/0cc38aaa4064fd9e79101994ce9872c6d91f816b
2020-12-08 09:57:20-08:00
Allowlist certain data types to avoid a seg fault. PiperOrigin-RevId: 356326671 Change-Id: I23b65b52e93798cb5a6744632d31b0f88c6b6b31
4f663d4b8f0bec1b48da6fa091a7d29609980fa4
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/4f663d4b8f0bec1b48da6fa091a7d29609980fa4
2021-02-08 12:37:40-08:00
Fix segfaults in `tf.raw_ops.SparseCountSparseOutput`. PiperOrigin-RevId: 360547563 Change-Id: I781c7af4b54a63d867c6e18d43a44d64a5c4e7c9
82e6203221865de4008445b13c69b6826d2b28d9
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/82e6203221865de4008445b13c69b6826d2b28d9
2021-03-02 17:06:27-08:00
Fix an invalid address vulnerability in `tf.raw_ops.RaggedBincount`. PiperOrigin-RevId: 368293153 Change-Id: I4b4e493d3fd05e7dc55a55de3a041a80a4f275c3
eebb96c2830d48597d055d247c0e9aebaea94cd5
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/eebb96c2830d48597d055d247c0e9aebaea94cd5
2021-04-13 14:22:27-07:00
Fix `tf.raw_ops.GetSessionTensor` and `tf.raw_ops.DeleteSessionTensor` null pointer dereferences. PiperOrigin-RevId: 368294154 Change-Id: Ie10f07a0a9a1c2b685e08153d48a0ca4b93f9fc9
ff70c47a396ef1e3cb73c90513da4f5cb71bebba
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/ff70c47a396ef1e3cb73c90513da4f5cb71bebba
2021-04-13 14:28:51-07:00
Fix `tf.raw_ops.ResourceCountUpTo` null pointer dereference. PiperOrigin-RevId: 368294347 Change-Id: I2c16fbfc9b4966c402c3d8e311f0d665a9c852d8
030af767d357d1b4088c4a25c72cb3906abac489
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/030af767d357d1b4088c4a25c72cb3906abac489
2021-04-13 14:34:14-07:00
Fix `tf.raw_ops.RaggedTensorToVariant` invalid resize. PiperOrigin-RevId: 368299574 Change-Id: I751c186325aa0bab397928845e790e60c2d90918
b055b9c474cd376259dde8779908f9eeaf097d93
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/b055b9c474cd376259dde8779908f9eeaf097d93
2021-04-13 14:54:48-07:00
Fix `tf.raw_ops.RaggedTensorToTensor` failing CHECK in `tensor.cc`. PiperOrigin-RevId: 368300502 Change-Id: I91255d23c4bfd3aa3c029aac773937c09daf3c64
f94ef358bb3e91d517446454edff6535bcfe8e4a
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/f94ef358bb3e91d517446454edff6535bcfe8e4a
2021-04-13 15:01:45-07:00
Fix `tf.raw_ops.SparseCross` failing CHECK. PiperOrigin-RevId: 368701671 Change-Id: Id805729dd9ba0bda36e4bb309408129b55fb649d
b1cc5e5a50e7cee09f2c6eb48eb40ee9c4125025
tensorflow
cvefixes
1
https://github.com/tensorflow/tensorflow
https://github.com/tensorflow/tensorflow/commit/b1cc5e5a50e7cee09f2c6eb48eb40ee9c4125025
2021-04-15 13:08:45-07:00