file_path
stringlengths 21
207
| content
stringlengths 5
1.02M
| size
int64 5
1.02M
| lang
stringclasses 9
values | avg_line_length
float64 1.33
100
| max_line_length
int64 4
993
| alphanum_fraction
float64 0.27
0.93
|
|---|---|---|---|---|---|---|
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-05-21.md | Minutes from 50th OpenVDB TSC meeting, May 21st, 2020, (EDT)
Happy 50th meeting anniversary!
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees:
JT Nelson (Blender), Bruce Chernia (Intel), Andre Pradhana (DWA),
Peter Cheng (DWA)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
Quorom is present
2) Secretary
Jeff Lait
3) Forum
Question about multires; appears to be addressed.
4) houdini_utils
DWA will look into whether this can be integrated into a single directory or
not. Can we separate off the houdini_utils code as a pure VDB support tool?
Can DWA fork their internal houdini_utils from the VDB version so we don't
have to keep targeting a separate directory?
5) Ken's workload
a) Fast Sweeping PR
b) Benchmark for Multi-Res
Can we get the funding from ASWF to do the benchmark component? Potential targets of the funding are busy for a month or so. Can we get the ASWF dedicated resources moved to VDB? Send a letter out?
DWA is planning the Gas Net Slice Exchange as current priority.
Ken's first priority is Fast Sweeping. We'll re-address the benchmark
requirements in another month.
6) Siggraph
We discussed what things might be possible to annouce for Siggraph.
Fast Sweeping. Has a lot of functionality not exposed in the sop. Some should be in a new SOP, such as extrapolation. Others, such as renormalizing, should fold into existing SOPs. Best plan is to get it in the tool level before worrying too much about these decisions.
AX: hopefully? Depends on amount of time for reviewing. Some PRs need reviewing now!
Sharpening.
VDB Activate. Is in now.
VDB Merge. Dan is hopeful.
7) Website
We tend to forget that PRs are there. We should add a code owner so the website triggers code reviewers for all of the TSC. None of the download links work now that we moved from nexus to artifact; and artifact is not working. Linux foundation is investigating.
8) AX
Matches VEX Scalar promotion rules. Have CMake PR for finding the right modules. And AX is ready to integrate.
9) Grid Types
Becoming more frequent of an issue.
In AX we have our own types based on VDB math. This includes matrices. AX should be agnostic to registered VDB types. Registration should only matter for serialization. Any intermediate data structure should be allowed. We should be able to make a 6-float VDB without registration.
Clip, prune, and other grid tools defined on the tree require certain functions to exist: less than, greater than, absolute value, etc. These don't really exist on Matrix. Would like an agnostic grid, so matrix3 <-> float9. And move away from math library. So VDB_Grid::float3 rather than VDB_Grid::Vec3. This is helped as we move more stuff from the nodes to the grids. Should we add < for matrices? Or add a openvdb::lessthan() that does explicit lexigraphic comparison? The ABI means we will keep these methods for a while, so we should find a solution that doesn't require moving them out. Matrix2 is not currently supported in AX, so the float4 is still unambiguous. Nick will share the code needed, along with an email of what Jeff's suggestion is.
10) Next Meeting
May 28st 2020. 2pm-3pm EDT (GMT-4).
| 3,220 | Markdown | 38.280487 | 766 | 0.764286 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-06-25.md | Minutes from 53rd OpenVDB TSC meeting, June 25th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Brecht Van Lommel, Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) New Meeting Time
4) Forum Posts
5) 7.1/8 Release Schedule
6) VDB Net Slice Exchange
7) Next meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) New Meeting Time
Dan has requested the TSC meeting be moved to an earlier day of the week.
Consensus that the new time should be on Tuesday and an hour earlier than the
current meeting (5pm GMT) - 10am PDT / 1pm EDT / 6pm BST. Ken to adjust the
calendar invite.
4) Forum Posts
A question was raised about the sharpen feature in the Convert VDB SOP when
converting polygons. This implementation (hvdb::SharpenFeaturesOp) is only
provided in the Houdini toolset and not in the core library itself. Initial
suggestion was for other vendors to copy the implementation in the Houdini
library with an acknowledgement that this implementation should really be pushed
down to the core library. However, it was noted that VDB provides rather
primitive mesh data structures. The best approach would probably be to wrap the
Houdini API and to adapt the implementation to work based on a templated wrapper
class, but needs more investigation to understand how easy that may be to
achieve in practice. At the very least a unit test based on the implementation
in the Houdini plugin would be more useful to other DCCs and allow us to offer
basic regression testing.
A generic mesh data structure in Houdini could be useful. Ken also keen on a
tetrahedral data structure, converting VDBs to tets would be useful. Jeff
mentioned that dumb tet conversion is trivial, robust tet conversion that works
well with finite element simulation is much harder, but would be very desirable.
5) 7.1/8 Release Schedule
Aim is to release VDB 7.1 as soon as possible so that Jeff can base the next
Houdini release on this version, ideally by 1st July. Likely will be until a
week or two after this date. Jeff suggests that a 7.2 release should come before
8.0 and include AX so that DCCs do not need to wait on the VFX Reference
Platform bumping to the next major version. 8.0 is scheduled for Q4.
* VDB Sharpen SOP
Ken to look at and approve the VDB Sharpen SOP. Still needs a unit test, but Ken
may approve without for sake of expediency.
* Fast Sweeping / VDB Extrapolate SOP
Andre to look at creating a draft PR with the DWA version of the Extrapolate SOP
adapted to the Ken's implementation. Work can be done on refining the SOP UI
parameters in parallel with finishing the API.
* VDB Merge SOP
Dan to look at finishing a first version of the VDB Merge SOP. It will be
limited in functionality (add fog volumes, union SDFs) and can be extended in
future releases. Question about usability if reordering of inputs changes
resolution as proposed with first input being used as resolution only.
Nick raised concerns about having two SOPs doing the same thing (VDB Combine SOP
vs VDB Merge SOP). Adapting the Combine SOP is feasible however would not be as
efficient as a multi-input SOP for stealing use cases. The multi-input is also
more intuitive for many common workflows and would not require changing modes as
often - the default mode in the VDB Combine SOP is Copy A which is almost never
what is needed.
General feeling that the VDB Combine SOP is a bit of a kitchen sink and could do
with some improvements. The Combine SOP is still useful because it is intuitive
in certain cases such as subtracting one VDB from another. Open question about
what to do with the Combine SOP in the future, but decision is to proceed with
introducing VDB Merge SOP for now and allow artists to opt-in gradually.
* VDB Net Slice Exchange
Andre has compiled and tested the VDB Net Slice Exchange that SideFX provides as
part of the HDK toolkit samples, however has not been able to test it on
production examples yet. Waiting on a little more production testing before
including it in a VDB release.
6) Next Meeting
New day, new time. Tuesday June 30th, 2020. 1pm-2pm EDT (GMT-4).
| 4,162 | Markdown | 40.63 | 80 | 0.788323 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2021-01-12.md | Minutes from 75th OpenVDB TSC meeting, Jan 12th, 2021, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Chernaik (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) GitHub Issues
4) ASWF Questionnaire
5) SIGGRAPH
6) Listing of authors
7) [[deprecated]] C++14
8) Deprecation of visitTree()
9) Adding Half
10) VDB visualize as points tool
11) Change Logs
12) Next Meeting
1) Confirm Quorum
Quorum is present.
2) Secretary
Secretary is Nick Avramoussis.
3) forum
Briefly revisited the topic of Github issues vs the forum vs JIRA. Still no
consensus, TBD.
4) ASWF Questionnaire
The ASWF questionnaire has been distributed. Noted that there is a lot of
questions before you get to the OpenVDB specific section and that it
presents topics on every other ASWF FOSS too.
5) SIGGRAPH
Course vs Open Source Days. General agreement that the OSDs feel like more BOF
style presentations. Should clarify with the ASWF any expectations this year
for those days.
6) Listing of authors
Revisited the conversation on @author tagging in files. General consensus now
is that both having the names or removing them is fine, but what is the policy.
All agreed to keep the current stance, names are purely optional depending on
the author and conflicts or issues on changes can be raised on the PR in
question or with the TSC.
7) [[deprecated]] C++14
Questions about the removal of the OPENVDB_DEPRECATED macro in OpenVDB 8.0.0.
Have a macro makes deprecations easy to disable/enable per project. Most
agreed this is a useful feature. Other solutions (system includes/include
guards) are not necessarily always viable.
Vote on re-introducing the macro with an argument option for compiler
messages: Nick, Ken, Jeff for, Dan against. Passed.
8) Deprecation of tree visit() methods
Tree::visit() methods were deprecated with a message to use the
DynamicNodeManager, but this is not a simple transition. It's not a 1:1
replacement as it changes execution order and parallelism. This needs
documentation. We should only deprecate methods with similar or matching
new functionality, or provide transition guides.
9) Adding Half
10) VDB visualize as points tool
11) Change Logs
Time.
12) Next Meeting
Next meeting is Jan 19th, 2021. 12pm-1pm EST (GMT-5).
| 2,373 | Markdown | 26.604651 | 79 | 0.774968 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-03-19.md | Minutes from 43rd OpenVDB TSC meeting, Match 19th, 2020, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: Bruce Chernia (Intel), Johannes Meng (Intel),
JT Nelson (Blender), Robin Rowe (Cinepaint)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) NanoVDB
4) AX
5) CI and GitHub Actions migration
6) Level set tracking
7) PR review
8) Roadmap
9) Next meeting
1) Quorum was confirmed.g
2) Secretary was Dan Bailey
3) NanoVDB
Ken has implemented a GPU version of OpenVDB called NanoVDB. It is currently
based on CUDA but could be re-implemented using OpenCL without too much work.
Data structures are immutable, so primary application is rendering. Ken
reporting around a 30x speedup on the GPU compared with an 88-thread CPU for
doing a naive raymarching using bundles of rays. CPU version being compared
against is not fully accelerated (ie no vectorization). It uses a binary search
for the root node which may improve performance on the CPU too.
4) AX
Nick has been working on a language spec to be shared soon. As a test
application, vdb_view has been modified to manipulate VDB grids on-the-fly using
AX.
5) CI and GitHub Actions migration
PR665 has successfully used PR re-targetting as a way of ingesting external
contributions. The default branch will be reverted back to master soon as a
result. This is a precursor to storing Houdini daily builds in the GitHub
Actions cache to sidestep any issues with secret keys.
6) Level set tracking
Level set tracking currently dilates in both directions whereas a more efficient
implementation may be to look at the direction of the moving interface and to
dilate in just one direction. Dan to investigate.
Nick has a faster, but less accurate implementation of dilation and erosion to
share for future discussion. In some cases it can be as much as 2x faster.
7) PR review
Quick review of some outstanding PRs.
8) Roadmap
Time
9) Next meeting
April 2nd 2020. 2pm-3pm EDT (GMT-4).
| 1,995 | Markdown | 27.514285 | 80 | 0.776942 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2021-01-26.md | Minutes from 77th OpenVDB TSC meeting, Jan 26th, 2021, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B., *Andre* P.
Additional: Vojta Kuzel, JT Nelson (Blender), Laura Lediaev (Sony Pictures Imageworks), Bruce Cherniak (Intel), Johannes Meng (Intel).
Regrets: Peter C.
1) Forum (DAG)
2) Half
3) VDB 8 bugfix progress #936
4) Blender update (JT)
5) Min boost requirement #935
6) AX SOP progress #931
7) Comment on USD
8) Next Meeting
1) Question in the forum: why do we
Octree v.s. VDB grid. Octree has a small fan-out factor (8) while the smallest fan-out factor in a VDB grid is 512. The chance of two leaf nodes having collision is small in VDB.
An OpenVDB grid is also designed to change topology, whereas DAG is mainly designed to be a (preconditioning) data structure to be used for rendering. For this purpose, a NanoVDB grid is maybe more suitable for the problem. Updating a DAG dynamically will be difficult. However, Jeff Lait mentioned that NanoVDB also adds bounding box information in the Leaf Nodes, making it not suitable for a DAG-like data structure (at least in its current implementation).
Ken thinks that the idea is interesting and encourages Vojta Kuzel to explore it. However, having DAG as a first class citizen in OpenVDB will be difficult because we allow the tree to dynamically change. Ken mentions that the reason people shy away from implementing it is because of skepticism over whether it will work out in practice.
Dan mentions that applying this idea to a Mask Grid may be more appropriate.
2) Half
Dan mentions that Carry from ILM reached out. Dan thinks that Carry would like an ASWF project to use another ASWF project so we can give feedback. The look up table in OpenEXR half has gone away in version 2.5. Dan also mentions using Imath’s vector classes. Ken says that the vector classes discussion is a bigger discussion that should be discussed at another point.
Jeff mentions that we want to reduce OpenVDB’s dependency and that no matter what we do, we need to put the embedded half implementation in a new namespace. Ken would like to have this PR to be approved since it will be useful for NanoVDB.
Ken mentions something we are forgetting: OpenVDB's dependency on half is hidden now: there is no in-memory representation that has a half. Any grid that is stored as a half on disk is converted to full 32 bit. This has come up from Autodesk (stuck in OpenVDB version 5 because they introduced a hack to load half from disk, keep it as half, and ray-trace it as a half in memory.) Ken mentions that, today, if you have a half grid, when you read it, it will be converted to full float. The HALF flag is only used in IO right now. Ken hasn't seen the changes that are implemented by Autodesk. Jeff sees this as another point to add a half type as a native type.
Ken says that what we need is a way to go from 32 bit float to 16 bit float and back again. OpenVDB will work if we have that today. But Ken would like to have half as a first class citizen, so you can have a half grid in memory so that you can do ray tracing, etc.
Dan believes that PointDataGrid supports half types: the truncate codec stores it as half in memory and when you read it, it is turned into a float.
Jeff also agrees that we need to have half as a first class citizen (as openvdb::math::half). He proposes to have Vec3H for Vector 3 of halfs.
Cary from ILM was asking if there is anything that they can do to make OpenEXR/Imath's half to be easier to use by OpenVDB. According to Nick: if they make it to be header only. Supposedly, if you have half float intrinsic provided by the compiler, then there is no need for a lookup table. At the end of this discussion, there is nothing that the OpenEXR/Imath group can do to make their implementation to be easier to be adopted by OpenVDB.
Nick mentions that this PR will lock OpenVDB down to this implementation of half.
Ken asks why we can't explore a way to have the build process pick the embedded OpenVDB's half with the other half that comes from, e.g., OpenEXR/Imath.
Nick mentions several possibilities to do this:
- generate the header at build time.
- we can use compile defines to do this, but this is not particularly nice because downstream projects will need to use this as well.
- we can do something weird to mimic the folder structure of OpenEXR inside of OpenVDB so we can change the include path.
Jeff mentions that he is not sure how to inject the type-traits in half.
Ken mentions that the first step is to accept this PR so that we have a default implementation that ships with OpenVDB. In the future, we can update the half implementation with a newer version of half that comes with OpenEXR/Imath or with a version from CUDA.
Jeff gives an argument on why this PR can be 'harmful' because it complicates the build system even more. But he believes that it is not that harmful.
Ken asks Jeff about Houdini, since Houdini has another implementation of half? Jeff says that Houdini uses fpreal16, which will be separate from the one that is name-spaced in OpenVDB. It is not a problem right now. It will start to be a problem when we have a half grid and a developer wants to use the half implementation that is not shipped with OpenVDB.
Jeff mentions that this PR will get rid of OpenEXR dependency. We can talk about moving it to a third_party directory. But this does not solve the problem of being able to easily link against the OpenEXR half. Is there a way to inject OpenEXR half to the openvdb::math namespace so that you can use an #ifdef in half.h/Types.h. Should we add a compile flag? Dan thinks that it is worth a try.
Ken mentions that the current PR does not block us from including the dependency on OpenEXR/Imath in the future. Nick agrees.
Nick thinks that we want to make the dependency to be optional, instead of removing it completely.
Jeff mentions the problem with backward compatibility because right now OpenVDB links against OpenEXR and Types.h includes OpenEXR/half.h. The problem with this PR is that it will break someone's code if the developer depends on OpenVDB to link against OpenEXR. However, this is bad development practice, which should be avoided by including OpenEXR/half and linking against OpenEXR directly in the first place. Now, a developer may need to change the code by replacing half with math::half. Dan mentions a similar problem that comes with gcc upgrade.
Dan summarizes what we are trying to achieve: if we were to put this embedded half into a third_party directory and always build it with the OpenVDB core library and include a mechanism that optionally switches the definition that is used by the name-spaced version, whether it is the embedded half or an external half.
According to Nick, the issue is in installation. Nick strongly believes that we should have that option of switching the definition of half. The build-time dependency is fine. If you want to use the embedded version of half, you need to install it, and the include path should be valid because Types.h should be able to pull in the embedded version of half. We may be able to replicate the directory structure of OpenEXR to make sure that the include path of the embedded half matches with the one that is shipped with OpenEXR, but this is not the ideal solution. Nick will continue to think about this and will come up with something that works.
Ken asks if the current PR blocks the other approach? Nick says that it temporarily removes the dependency. Jeff says that it is a red-line we are crossing. Dan thinks that this is a good thing to figure out because it will help us to solve other dependency issues, such as blosc.
Nick will look at this problem again and will get back.
3) VDB 8 bugfix progress #936 (Fix CSG Intersection)
Dan is writing a more meticulous unit test around all the functionality. The existing Composite unit test does not cover everything. Merge needs to come up-stream of Composite. Dan believes that Jeff's comment on the internal node is not an issue, but he will double check this and will make sure that it is covered by the unit test. The current problem is in intersection when a child of the root node exists in one, but not the other.
OpenVDB is still using linear search. Ken says that linear search with 8 entries is faster than binary search. Ken will take a look at how to do a search more efficiently.
Ken will also take a look at TBB issue again.
4) Blender update (JT)
JT has a 15 seconds update. His team has been working on making mesh to volume conversion to be better. Some of the conversion is half-baked. His group has been working on USD, Jupyter Notebook, and using OpenVDB and OpenVDBAX kernel.
5) Min boost requirement #935
6) AX SOP progress #931
7) Comment on USD
8) Next Meeting
Next meeting is Feb 2nd, 2021. 12pm-1pm EST (GMT-5).
| 8,890 | Markdown | 92.589473 | 661 | 0.782227 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-03-07.md | Minutes from 10th OpenVDB TSC meeting, Mar. 7, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), Andrew Pearce (DWA),
Thanh Ha (LF), John Mertic (LF), Daniel Elliot (Weta)
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) OpenVDB BOF @ SIGGRAPH
4) Posting questions to Forum or mailing list or ...
5) Contributing.md
6) Houdini MMB improvements for Mako Templates
7) unifying open-source and native SOPs
8) OpenVDB 6.0.0 next steps and announcement
9) CI/CMake Update *
10) VDB tools and grid member functions *
11) Documentation *
12) Source headers *
13) JIRA Improvements *
14) Other? *
15) Schedule next meeting
* This was an optimistic agenda, we only had time to discuss items 1-8 and 15.
1) A quorum was confirmed.
2) Secretary - Dan Bailey
3) OpenVDB BOF @ SIGGRAPH
The TAC has proposed a Siggraph Birds of a Feather to discuss the ASWF with a
focus on governance and migration of the first few projects. This will likely
include some of the proposed agenda for the OpenVDB course, meaning the course
content will be more focused on the project itself than the governance.
4) Posting questions to Forum or mailing list or ...
There was a post to the OpenVDB Google groups forum by a member of the
community that suggested that the forum was no longer monitored by the
maintainers. Ken previously made a post to the forum which was slightly
ambiguous and has since clarified the situation.
We need to decide the process by which people should ask questions. John is
helping OpenColorIO move from their own forum to groups.io which is the
service used to host our three ASWF mailing lists (openvdb-dev, openvdb-user,
openvdb-tsc-private). The benefits are that it would help consolidate
communication and that lots of people prefer mailing lists. The service also
offers a calendar and file storage per mailing list. China communication is
also possible because it doesn't run through a Google service that is blocked
by the firewall. John confirmed that it is possible to bring over the history
from the forum to the new mailing list, however users would need to be
migrated manually. For OpenColorIO, they are communicating that they're
closing the forum and directing the subscribed members how to sign up to the
new mailing list. This can serve as a useful way to cull out subscribed
members that are no longer interested in the forum.
John highlighted that some communities prefer differentiating developer-
related discussion to user-related discussions hence the openvdb-dev and
openvdb-user lists, but that may not be right for OpenVDB. He also mentioned
that many projects use a rotating triage person who will be responsible for
responding and forwarding emails that come into the forum or mailing list.
There was support for trying this idea.
There was a brief discussion about what to do with GitHub issues, an email
redirection could be set up or it could be shut down entirely to avoid
confusion. The project still needs clearer documentation about how to
contribute and a follow-on announcement to clarify the process to the
community. All TSC members to look at Dan's email regarding contribution.md as
a first step to improving this. A vote will be scheduled for next time about
which services to keep and which ones to discard.
5) Contributing.md
After approval from the TSC in a previous meeting, Jeff has submitted a PR to
remove the explicit 25% contribution time for committers. There was some
confusion about the distinction between committers and TSC members. John
clarified with an example that in the situation where a company might have 20
people with committer priviliges, there may be desire to have a subset of
these committers represented on the TSC so as not to increase the
representation of that company in TSC votes. That is not currently an issue
for OpenVDB.
Ken wanted a change to the wording to ensure that committers were active
developers and specifically on the project. John thought that Ken's proposed
changes were fine and that there was sufficient ability for the TSC to revoke
committer privileges for an individual that has ceased to contribute
development to the project. Unanimous vote in favour of Ken's proposed changes
to Jeff's PR.
6) Houdini MMB improvements for Mako Templates
This PR has been outstanding for some time. Dan has concerns about the code
not being tested and allowed to drift so that it was no longer functional.
Jeff thought this was the best place to document how to make changes that
could be picked up by mako templates and would discourage rewriting of this
code in the future.
It was decided that Nick would make two tweaks to his PR - to match the branch
names that Jeff has chosen for Houdini and to add a #define to disable the
code from being compiled by default unless explicitly enabled, then we approve
and merge. Dan to bump the email thread with his proposed MMB changes to the
mako templates as this was not included as part of this PR.
7) Unifying open-source and native SOPs
General discussion of the proposed change. Nick asked about using namespacing
as an alternative and Jeff explained some limitations in the namespacing
approach such as the operator type bar only being applicable for HDAs and not
for compiled SOPs. Dan explained the proposed ophide policy mechanism of using
a compile-time flag optionally overriden by a run-time environment variable.
Nick is concerned about the phases of this proposed solution, particularly
about any confusion arising from introducing the interlacing of the label
names before the ophide policy has been implemented. No objections raised to
tackling this proposal in a different order. Nick and Dan to comment further
on the PR.
8) OpenVDB 6.0.0 next steps and announcement
OpenVDB 6.0.0 has only undergone a soft release and has yet to be officially
announced. The main blocker is updating the Doxygen documentation on the
website. Discussion followed about changing the process, Thanh suggested an
approach using ReadTheDocs or GitHub Pages that might be suitable. Decision
made to proceed with this release using the current process and to table
further changes to the documentation for a later date.
15) Next Meeting
Next meeting is scheduled for March 21st, 2019, 11am-12pm PST.
| 6,328 | Markdown | 46.586466 | 78 | 0.801675 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-02-28.md | Minutes from 9th OpenVDB TSC meeting, Feb. 28, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), Thanh Ha
Retrospective Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) Update from TAC
4) Adding Libraries
4a) Adding Eigen
4b) 3rd party reporting
4c) Adding CLI library
5) Deprecation policy
6) OpenVDB and Houdini Unification
7) Next Meeting
1) A quorum was confirmed.
2) Secretary - Jeff Lait
3) Dan gave an update from the TAC meeting. They are considering
Circle CI rather than Travis.
Circle Upsides
- No 50 min limit; instead a 5hr limit
- Can produce build artifacts
- 2x as fast (despite same hardware?)
- Doesn't lock your step order
Circle Downsides
- No commit vs PR build. Might need to setup for PR builds only, which
may require extra merges to force a PR build before sending to master.
- Randomizes job order
- 4gb limit. But this can be addressed if non-free version is used.
Concerns were raised about the 4gb limit and VDBs notorious use of memory.
In any case, decision will be made pending the results of the TACs
investigation.
4a) Ken requires Eigen for some new tools so would like to add as
dependency. It is header only, and several parties are already using it
internally. But it likely can't be confined to a .cpp file.
MKL was suggested as an Eigen alternative. While the license is likely
now compliant, concerns were raised about the library install size.
Ken moved that we adopt Eigen.
Dan amended that it should be gated by a USE_EIGEN compile time flag.
Passed with unanimous consent.
4b) An ongoing problem is for people to determine what dependencies are
required to build VDB. Different people pick different versions of the
library, either causing direct build failures, or failures when mixing
together. Blosc in particular has issues if latests versions are used.
Since the CI must already know the true versions for its install, this
is a documentation problem to provide it for users. Two action items
are:
1) Update the install file to reflect the current versions in the CI
2) Add 3rd party list on the website modeled after:
http://www.sidefx.com/docs/houdini/licenses/index
4c) Ken suggested we include the CLI library to make the command line
programs less fully of boilerplate. boost::options was suggested as
another alternative as boost already is included. Suggestion was
tabled for later.
5) Dan moved that the deprecation policy forwarded by email should
be adopted.
Support will consist of current and last two years of the VFX platform.
Currently this is 2019, 2018, and 2017. This will make a minimum Houdini
version of 16.5.
Next year will be 2020, 2019, and 2018, and will unlock C++14.
Passed with unanimous consent.
6) Dan moved we adopt the proposals for renaming OpenVDB nodes
user-facing labels to match Houdini's and add a (aswf) suffix, along
with built-in policies to allow auto-hiding of duplicate nodes.
General agreement, but concerns were raised about the specific names
to use. Many have got used to OpenVDB prefixes, so change will cause
friction. Likewise, many do not know what "ASWF" means. Though,
alternatively, it might be good to start the education about ASWF
in this manner.
Dan moved that he prepare a PR and we can continue the bike-shedding
when we have something concrete.
Passed with unanimous consent.
7) Next Meeting
Next meeting is scheduled for March 7th, 2019, 11am-12pm PST.
| 3,496 | Markdown | 35.051546 | 74 | 0.777174 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-08-29.md | Minutes from 26th OpenVDB TSC meeting, August 29th, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M., *Peter* C.
Additional Attendees: Sean McDuffee
Agenda:
1) Quorum
2) Secretary
3) Round Robin
4) Release Schedule for 6.2.0
5) levelSetVolume
6) VDB Smooth doesn't densify
7) Bitscan/popcount
8) Deprecation
9) Combine SOP Performance
10) Tree Refactoring
11) Delayed Loading
12) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Round Robin
A quick round robin to identify what is being worked on and what may
make it for 6.2.
Ken: Working on velocity extension. Read-Only grid may end up being internal
only. Has found interesting results by making a write-only grid that allows
better multithreaded scaling than usual multiple grids + merge.
Nick: AX integration. Feature branch is hoped to exist in a week or so.
As well, CMake as required. Should anistropic rasterization be higher
priority? In response to a later question, MPI will not be available with
current priorities.
Dan: Point partitioning improvements. C++11 changes. 30-40% better performance
on some datasets. Merging of grids is open questions. Likewise, refactoring
tree hierarchy and improving combine SOP.
Jeff: Hopes to get VDB Activate moved to OpenVDB. 6.1 integration into
Houdini 18.0.
Peter: Principle axis extraction from volumes, moment of inertia. Sharpen
filter. Discussion on sharpen filter. Does support non-level set, consensus
was it should be kept regardless of differences with Ken's version.
4) Release Schedule for 6.2.0
No one had any critical items to be done for 6.2.0.
5) levelSetVolume
VDB Clip in 6.X leaves different values in inactive voxels, causing volume
computation to change. Consensus is that such half-open SDF don't have
a proper volume so this is acceptable.
Peter notes that there is an error computing volume of entirely empty
leaf nodes as empty bounding boxes are not detected by the volume
computation.
6) VDB Smooth doesn't densify
This is a known issue. Jeff will submit a Jira ticket on it.
Committee differs on whether the right course of action is to add a densify
node to Houdini, or change all algorithms to support sparse tiles.
However, algorithms that don't support sparse volumes should be documented as
such, and the relevant help updated.
7) Bitscan/popcount
The TSC was unsure of the performance difference, so recommended asking
the submitter to verify a measurable difference. POPCOUNT is the more
debatable as SSE 4.2 is more recent (Only with Houdini 17.0 did that become
a requirement).
We noted that this method does not belong in Utils, but belongs in Tree.
No objections to moving to Tree for 7.
8) Deprecation
Our deprecation policy was unclear in what happens if we release 7 before
the new year. The intent with 7 is to support the 3 VFX platform years
2020, 2019, and 2018, but it might be read that if it is released in 2019
it must support 2019, 2018, and 2017. No objections to allowing releases
to base on future VFX platforms. Dan will submit a PR with a clarification.
9) Combine SOP Performance
Combining 300 VDBs with maximum ends up entirely single threaded. While
the SOP interface allows a list to merge at once, not in the underlying
API. May require re-ordering if mixed grid types.
10) Tree Refactoring
Clip is particularly problematic as it is in the File operations.
This is useful for CUDA/GPU and MRes because it would allow subclassing
the internal nodes without as much meaningless boilerplate. But a main
motivation is that these are depth-first algorithms, so redoing as breadth
first would allow multithreading and performance.
Concerns were raised that this will break a lot of client code. Proposal
is to provide free floating functions that perform the grid-dispatch
internally, to make it easier to transform grid->foo() into foo(grid).
Another concern is that this may open too much to the API. Current
interface provides a nice abstraction to internal details. The counter
argument is that these sort of operations should be possible by external
code, so this is a good way to find where the API falls short.
Is this a good chance to rethink the whole tree? There seems to be
some cruft that could be removed as is for obsolete file formats.
General agreement that we should always be ready to re-think our structures.
11) Delayed Loading
This is still in a state of limbo between the File SOP and VDB. One
sticking point has been Windows support. Another is the difficulty
to pass options to the IO translator.
12) Next Meeting
Next planned meeting is:
September 12th 2019. 3pm-4pm EDT (GMT-4).
| 4,665 | Markdown | 34.348485 | 80 | 0.783923 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-11-03.md | Minutes from 69th OpenVDB TSC meeting, Nov 3rd, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Timezones
4) OpenVDB Grid Layout (Cell centered vs Node centered)
5) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Timezones
Agreed to move with daylight savings - i.e. whatever the meeting invite says!
4) Node Value Locations (Cell centered vs Node centered)
A user has run into issues where the distinction between how values may
potentially be stored in OpenVDB numerical grids vs OpenVDB Points grids was not
clear. The problem is essentially that methods to retrieve node bounding
information from a given VDB do not necessary respect the positioning of cell
values. This is especially true for CoordBBoxs whose integer coordinates can
either represent the minimum to maximum-1 bounds (Node centered) OR the
minimum-0.5 to maximum+0.5 bounds (Cell centered). The distinction between the
two is left to the underlying algorithm. Comments were made in regards to the
position information of points within a PointDataGrid. Points are stored
relative to the cell center; that is their voxel offsets are between -0.5,+0.5
and not 0,1. This difference is irrelevant when considering the fast discarding
of candidate nodes; instead one must account for the differences of a volume
modeling a continuum and a points grid with discrete data stored potentially
throughout a given cell. Jeff observed that the ray intersection code could
potentially be incorrect for cell centered values. All agreed that better
documentation is a must. Nick, derived or specialized implementation of bounding
boxes which represent either state with clearer API methods would also help show
this distinction. Ken to investigate further and draw up images representing the
problem for further discussion and to hopefully include in the docs.
5) Next Meeting
Next meeting is November 10th, 2020. 1pm-2pm EDT (GMT-4).
| 2,118 | Markdown | 40.549019 | 80 | 0.795562 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2018-12-06.md | Minutes from 3rd OpenVDB TSC meeting, Dec. 6th, 2018
Attendees: John M., *Jeff* L., *Nick* A., *Ken* M., *Peter* C., *Dan* B., Andrew P.
A quorum was confirmed.
Secretary - Jeff Lait
3) Guidelines on Code Reviews
We will attempt the CODEOWNER files to automate assignment of initial
code reviews of pull requests. Squashing is discouraged unless
required for bisection; but will be reviewed in a few months. We
probably want documentation explaining how third parties can submit
pull requests; the intention is for this to be included in the CONTRIBUTING file whereas the code review guidelines will live in a process subdirectory along with any other TSC-related docs.
3a) Ken will follow up to find out when/how we can get commit bits set
for TSC members.
4) VFX Platform
The VFX platform has requested a version be ready by mid-december.
The ABI6 version has been tested on Clang versions and Houdini
versions.
It was acknowledged that a December 6.0 would be an extremely light
release - substantial upcoming features will not make it in this
window.
Motion: Release current ABI6 on git, but not make any noise about it.
Make noise about it in the new year.
Unanimous consent.
Action: Peter will merge the ABI6 pull request.
5) Questions for Autodesk
The current question list will be shared for another week to see if
there is any more input.
Dan will pose a question about the potential to use the VDB Point Grid
to dangle multi-res off the node structure.
Question for Autodesk: What do they think of VDB's LOD structure?
Question for us: What is the minimum set of tools for us to be interested?
6) Security Expert
We have specific concerns about security, likely limited to file
interporability. This could be added to the Contributing document.
In particular, hardening VDB so it can be used as a service is of
lower importance than performance.
"We take security seriously. Our primary concern is attacks via the
.vdb file format."
It remains unclear what is required by this role. No one declared any
formal training in the role, and all are uncertain about the
implications of being nominated. In particular, is the security
expert seen as having vetted the code? Or are they just the primary
contact for security issues?
7) Website
Discussed during section 3. Currently the build scripts and 2gb of
data needs to be migrated to allow the website to live outside of DW.
John suggested he will look into feasibility of moving to github
pages.
8) Next Meeting
Next meeting will be next week. Unanimous consent.
| 2,559 | Markdown | 33.133333 | 190 | 0.783509 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-01-16.md | Minutes from 38th OpenVDB TSC meeting, January 16th, 2020, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: Bruce Chernia (Intel), Nathan Walster (Framestore),
Manuel Gamito (Framestore), Mark Elendt (SideFX), Daniel Lee (SideFX)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Discussion on per-node-meta-data
4) Update on MRes from Bifrost
5) Google Summer Of Code
6) Faster tree-merge based on the recently added addChild methods.
7) Next meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Background: Various studios are using (or want to use) OpenVDB's data
structure for custom rendering of volumes. From previous discussions with
Framestore, the TSC understands that some of the statistical data that's needed
from VDBs (min/max/average etc) can be cumbersome to compute and store. The TSC
has been discussing ways in which the leaf nodes of VDBs could be used to store
additional 'metadata'. The aim was to gather a better understanding of the use
case and whether these paths could align.
The particular rendering technique being discussed uses ray tracking and
requires sampling collision distances withing the volume. These samples further
need to be aware of the localised minimum and maximum values. This localised
region is typically the size of a VDB leaf nodes with a given filter parameter.
This means that reductions can map well to a leaf node, but there is no way to
store this value alongside the node itself (in the same volume). To solve,
additional minimum and maximum volumes are stored alongside the source
(surface/density) volume. These extra volumes are computed on write of the final
source volume and hold tiled extrema representations of the source. That is,
each leaf node of the source grid corresponds to a tile value in each minimum
and maximum grid. There can be high computation expense necessary to compute
these volumes depending on the filter parameters, which can be further
influenced by velocity (for motion blur). Additionally, users are able to modify
the source grids final values at render time using AX, requiring statistics to
be recomputed. An ideal work-flow would involve values not being recomputed in
areas where they don't need to be, with the ability to keep them in sync with
the source grid using some sort of native VDB data structure. The challenge with
this synchronisation is ensuring that other applications know when this data
needs to be regenerated, however the implementations in most of the scenarios
being discussed are completely custom. Custom tree types are also being
leveraged, which would make an AX or native storage solution potentially more
complex. It was noted that these custom types may not be necessary and could
potentially be dropped in favour of standard vector types. Conclusion:
- It would be useful to have faster and more general reduction tools in VDB to
compute hierarchal values, with more general approaches allowing users to
specify their own filter/reduction requirements. An initial simple example
could include new header functionality which takes a VDB and returns
tiled/consolidated leaf level values as a new tree.
- It would be possible to extend AX to support such reductions. Controls to
choose tree level iteration and coordinate lookups would be necessary.
- Storing blind data at the leaf node level would provide a native solution for
'linking' custom statistics to their corresponding locations. This would
avoid having sidecar files/vdbs to hold this extra data. VDB's LOD structure
was also mentioned as a way of providing a more closely coupled set of grids
(also see additional notes). The general consensus was that a more specific
solution for customizable reduction may be easier to begin with.
Jeff to look at Mantras implementation of extrema values and feedback. Dan to
put together a Google doc with ideas.
4) Update on MRes from Bifrost
Ken continues to be in contact with Autodesk who remain committed to the MRes
discussion. Ken to implement a simple MRes example provided by Micheal Bang
(Autodesk) in VDB's LOD grid structure and share it with Autodesk to help
compare and demonstrate the pros of the MRes structure.
5) Google Summer Of Code
Dan to put together a Google doc on project ideas.
6) ~Time
Additional notes:
General consensus that a more extensive (better than just a vector of grids)
native way to 'link' or group VDBs together would be extremely useful. In
addition to grouping statistical data, a common scenario that comes up in
simulations is linking collision SDFs to their collision velocity fields. It
becomes difficult on read of a VDB file to infer this link without metadata or
relying on naming conventions. Nick to create a ticket describing the problem.
8) Next meeting
January 23th 2020. 2pm-3pm EST (GMT-5).
| 4,881 | Markdown | 47.82 | 80 | 0.797173 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-04-18.md | Minutes from 13th OpenVDB TSC meeting, April 18, 2019
NOTE: This meeting was moved one week later from the originally scheduled
April 11th and one hour later.
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), John Mertic (LF)
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) Response from Autodesk
4) 6.1 Release
5) Copyright/SPDX
6) DSO_TAG_INFO
7) OpenVDB Twitter
8) Next Meeting
1) A quorum was confirmed. Ken chaired.
2) Secretary - Jeff Lait
3) Response from Autodesk
Existing mres system doesn't have file io or transform implemented,
which means it has a lot to gain by VDB unification.
The existing mres system doesn't seem to have canonical formats for template
parameters. We've found with VDB that while fully templatable topology
was useful for prototyping, in the long run it is infeasible to support
multiple options across compilation boundaries - VDB is already notoriously
slow to compile with just type instantiation. Mres would need to find
ideally one, perhaps two, canonical template instantiations.
Mres has multiple roots so can support all of space rather than only
a single cube.
While Grid/Metadata/Transform/IO may be shared, it seems the Tree is
less likely to be shared. Having a different structure, however,
justifies integration - if it were truly the same there would be
little point to it.
The TSC was divided on importance of activation. This is an essential
part of VDB and is widely used outside of just narrow band computations
to do masking and achieve efficiency. However, activation implies
non-present voxels that complicates a lot of algorithms (like blur)
possibly unnecessarily. Some were concerned imposing activation may
remove some of the benefits of Mres, such as being defined throughout
space and/or efficiency.
We are still unsure which algorithms are being provided. A critical
number likely need to be present to justify including it.
We need a clearer understanding of how mres is superior to a stack-of-grids.
Successful multi-res has been implemented in, for example, SP-grids using
stack-of-grids, and VDB seems well suited to a stack-of-grids multi
resolution workflow. Ideally some non-trivial algorithm (such as maybe
Eikonal equation?) could be shared in the Mres implementation, and we
could attempt to re-implement as a stack-of-vdb grids. This would give
a good understanding of where Mres is superior and provide some bench
marks of speed differences.
We will start a new email thread to discuss a response and attempt
a conference call when that is ready. SIGGRAPH is proposed as a potential
meeting time to discuss this directly.
4) 6.1 Release
There is a press release planned for SIGGRAPH for which we want a release.
Nick and Dan believe we are ready for a 6.1 release of primarily CMake
changes in a few weeks. Pushing 6.1 too long into the future will leave
the SIGGRAPH release hollow, however. But getting CMake out of the way
would help close a lot of outstanding work.
Nick is hopeful AX may make the SIGGRAPH release timeframe which will
provide significant updates for that release.
Werror PR is mostly done, except outstanding type conversion. Since
how to handle type conversions is ambiguous and would delay the PR,
instead they should be silenced until a future PR.
Circle CI seems strictly better than Travis and we will switch to Circle
going forward.
Pre-Houdini 16.0 deprecation removes 2.5k LOC so is eagerly awaited.
Unanimous consent on sending an email with planned 6.1 Release Candidate PRs.
TSC members should comment if they have outstanding issues. If not, will merge
by middle of next week.
5) Copyright/SPDX
Dan will remove the 2018 to 2019 transition. Peter will seek explicit
permission to remove the year from copyright notices so we can stop
the yearly bump. SPDX is to be left to later.
6) DSO TAG INFO
It is believed that the DSO_TAG_INFO is unnecessary, so can be removed
from CMake builds to avoid breaking compiler caches. Jeff requested
verification from production as this has been removed from the 18.0
examples.
7) OpenVDB Twitter
Dan has acquired the openvdb twitter handle and will make it available
to the TSC for our social media needs.
8) Next Meeting
April 25th 2019. 3pm-4pm EDT (GMT-4).
Note it will be at the same time as this meeting (moved one hour later to
account for NZ non-DST)
| 4,431 | Markdown | 36.243697 | 79 | 0.789889 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-04-02.md | Minutes from 44th OpenVDB TSC meeting, April 2nd, 2020, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: Bruce Chernia (Intel), Johannes Meng (Intel), JT Nelson (Blender), John Metric (Linux Foundation), Jim Leuper (DW), David Tonnesen (DW), Peter Cheng (DW), Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Intel VKL
4) Nano VDB
5) Hashing VDB Grids
6) CI Instability
7) Admin rights
8) Google Summer of Code
9) Houdini 18++
10) VDB Activate
11) AX language spec out.
12) Improved Morphology, PR #675
13) ASWF Nexus
14) Fast Sweeping
15) Next meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Intel VKL
Tentative plan for a presentation in 3 weeks. Will announce on the mailing
list when ready.
4) Nano VDB
Presented at the render council. Linearized tree, not fragmented. Uses grid
as native BVH. DDA rewritten for this. Much faster than current, even on CPU.
1.2 GigaRay/second on dragon. On par with triangle meshes. In talks to release
it. Min/max per node. Active bbox per node. Some of the DDA could port back
to mainline VDB.
5) Hashing VDB Grids
Is hashing useful? Need a fast hash function, and a cryptographic hash.
Ideally hash data separate from metadata. We should provide the architecture
to plug in a hash function that is multithreaded & knows about active voxels,
and how to sequence the node hashes. This was already brought up on a
previous TSC meeting.
6) CI Instability
Reasons CI is broken:
a) Out of disk space building Houdini dsos. Sometimes we get extra space so it doesn't fail, but if we get the actual official limits it fails. Need an auto-deleter as we build dsos. Maybe remove symobls? We have a PR to remove the debug build, this should be approved by someone on the TSC.
b) TBB version was broken in vcpackage. Fixed temporarily until github actions fixes it.
c) On Windows, cpu-timer unit test. Concern is if the timer is a steady timer. Or is thread-safe. Need to double check this. Unit tests with timers in general are a problem.
Dan will split up the unit test change from the chrono changes and investigate if the new timer is thread safe now.
7) Admin rights
Dan moves he gets admin rights to OpenVDB, contingent on him not turning off CLA checks. Ken, Nick, Jeff, and Dan vote aye, no one disagrees. This motion passes.
8) Google Summer of Code
10 proposals, 1 of which passes initial cut. Student wants to improve delayed loading on windows. Likely based in India. We have to choose two mentors. Likely need Nick for similar timezone. Talk about in next meeting. April 20th deadline to decide.
9) Houdini 18++
Next major version of Houdini will have at least VDB 7.0.0.
10) VDB Activate
How much should be changed to make a PR? Brace correction?
Jeff to do a PR of current version, we will then decide how much
prettying needs to be done to bring it in.
11) AX language spec out.
This is still being written, but the original spec for bikeshedding
can be found here:
https://idclip.github.io/openvdbax-doxygen/ax.html
Nick will send around a set of high level questions that are known issues.
12) Improved Morphology, PR #675
Greatly improves speed of dilating more than 8 voxels. Google sheet on the PR with some timings. Mostly a change of framework.
13) ASWF Nexus
Only OpenVDB is using it. Do we really need it? We have >100 MB files that we can host somewhere. If we can be given new links, we'll reset the links. ASWF will move to S3 and give us new links.
All four TSC members at the meeting explicitly approve of this transition.
14) Fast Sweeping
Version at DW has issues, but are improved and fixed in the new one. Ken has a PR almost ready.
15) Next Meeting:
April 9th 2020. 2pm-3pm EDT (GMT-4).
| 3,808 | Markdown | 33.627272 | 295 | 0.754989 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2021-01-05.md | Minutes from 74th OpenVDB TSC meeting, Jan 5th, 2021, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) GitHub Issues
4) SIGGRAPH Course
5) VDB 7.2.1 Release and VDB 8.0.0 Release
6) Extrapolate
7) ASWF Video
8) Misc ground work
9) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) GitHub Issues
PR#903: Wrong distance sign computation issue.
Touching spheres have a vanishing gradient at the tangent. This means the Eikonal equation fails. But the smoothing may also be responsible. If you have no self intersections, openvdb is not necessarily best for converting to SDF. The mesh is only treated as a suggestion as we work around many common errors.
If you look at plane of symmetry between two spheres, the gradient is less than one. And as you go to the center it goes to zero. Just because you have an SDF does not imply length of normal is always one.
Maybe we need an assume manifold option that works only with correct meshes.
Jeff will add a link to the meeting notes.
4) SIGGRAPH Course
Do we go for short or long course? Ken, Dan, and Jeff confirmed. But AX isn't brand new? But courses are not for solely new stuff. We need a mock-up of the schedule. Nick will confirm in a week.
5) VDB 7.2.1 Release and VDB 8.0.0 Release
Patch release was to fix include bug and node manager change. We should write a test to verify the copying is occurring the way we expect. The operator needs to be copied, but accidentally references were left behind.
The 8.0.0 release has most stuff. No extrapolate SOP, but look forward to that in 8.1.
Release announcement isn't done yet. Ken will do the announcement.
The ABI changes for trivial types is guarded by ABI.
One issue bulding with Houdini 18.0, which uses boost 1.6.1. VFX19 is now 1.6.6. 18.0 uses the older VFX platform, so to comply with 18.0's VFX platform causes a mismatch. If we remove support for a VFX platform, we should remove corresponding versions of Houdini.
We will add a note that Houdini18.0 uses boost 1.6.1 so the warning has to be disabled.
Note: Post meeting I verified that Houdini 18.0 is VFX19. Houdini 18.0 uses Boost 1.6.1, but since its symbols are hidden it is irrelevant for its compliance to VFX19. (There is a note to that effect in the licenses page)
6) Extrapolate
Found a crash bug where multiple fields were updated. Checking to see if it is fixed and will push soon.
7) ASWF Video
Embedded version of video, should we put it on the homepage? People are in favour.
Can we secure some new images? Approval can be long and slow. We can get ASWF to approve images rather than going internally. Some in DW have already started a process to get permission. Maybe a gallery if we get too many images.
8) Misc ground work
a) TBB Deprecations
We have hit the wall for this as the deprecations are now gone.
There is a comment in LeafBuffer that suggests std::atomic is insufficient, but it appears to have std::memory_order now. It is likely std::memory_release is the correct option.
Ken is to investigate this.
b) Blosc
What are the valid versions?
c) PRs to make optional
Various PRs to make dependencies optional - try to push these through.
c) i) Half.h
We could add #include, implement our own, or a software/hardware option.
There is a component that uses EXR for output.
OpenEXR should be an optional dependency. Do we do a link time, run time, or compile time error? We wanted a pure #define independent header, but that then means that you run-time discover the missing functionality.
Addressing the raytracing tool is straightforward. But removing half is a problem - all the website files stop working.
How do we include half quickly? What if we just include it? We'd have to namespace it.
Jeff is to investigate this.
d) Release notes clashing
Every time you go to make a PR you get conflicts in the release notes as they stomp on each other.
e) Automating Releases
This is a huge amount of work due to rebuilding documentation.
It is rebuilding the doxygen that is painful. Maybe a draft github release that triggers an action to do the doc building. The doc building needs to be done on the cloud, not locally.
Should we do more frequent releases?
f) Move fully to GTest
Move AX over.
9) Next Meeting
January 12th, 2021. 1pm-2pm EST (GMT-5)
| 4,508 | Markdown | 36.890756 | 314 | 0.761091 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-06-27.md | Minutes from 22nd OpenVDB TSC meeting, June 27, 2019
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: John Mertic (LF), Sean McPherson (Intel)
Absent: *Peter* C.
Agenda:
1) Quorum
2) Secretary
3)
CII Best Practices / TAC CI meeting
3b) CLA Process
4) Quick PR Review
5) Lambdas and ValueAccessors
Unplanned) Regression Tests
6) H18 + ABI=6
7) GCC and Dual ABI
8) Metadata and .bgeo
9) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) CII Best Practices / TAC CI meeting
Making progress towards migration to Azure CI. A CMake issue with GLFW arose
from the transition from Ubuntu to CentOS 7. PR has just been merged that
addresses this. Waiting on Andrew from LF to setup authentication to produce
official ASWF images, then we'll add VFX 2019 CI using Azure.
Next steps will be adopting a similar CI workflow for VFX 2018 and VFX 2017.
Outstanding item relating to how to handle a Docker image with Houdini in it.
This is a legal issue, not a technical issue as these images cannot be public,
otherwise users can access the Houdini HDK without signing the EULA. One
approach is to use a private repository, Dan has experimented with this and it
works well. However as brought up in the CI meeting, this is sub-optimal because
it means that anyone using their own fork won't have access to a Houdini build
for testing. General agreement that there should be a better solution to this
problem. It was noted that the ASWF is actively investigating this and that the
LF has also looked into how to resolve this in the past. John to reach out to
Daniel Heckenberg to see if he can help with this effort. Current thinking is to
install Houdini HDK on every build so as to be able to complete the migration
from Circle to Azure.
CII Best Practices was discussed in the CI working group meeting yesterday.
We're still missing a few areas. Dan has submitted a PR to add the security
mailing alias to the website, Peter asked for a minor tweak to the wording. Ken
has requested an edit to the security policy document and approved it, this has
been merged now. It was noted that other ASWF projects are interested in this
document.
A question was raised about some of the wording in the CII Best Practices and
John clarified that it is acceptable to mark Unmet or N/A to "Suggested" items.
Only "Must" items have to be marked Met. As a result should be possible to
ignore the dynamic analysis section for now as this is not mandatory. Worth
adding a comment to any items being marked Unmet though.
Still some issues with getting static analysis up-and-running. Dan speculated
that this might be a problem to run on every commit because our unit tests take
a long time to run with the code coverage flags enabled. Further discussion on
this issue put off until Dan has had a chance to properly investigate.
3b) CLA Process
DWA and DNeg have digitally signed CLAs. Still awaiting Weta, SideFX and ILM
before switching on the automated CLA checks. John to resend the CLA
instructions and clarified that the LF will be managing the CLAs once this
system is in place. OpenCue are using it, OpenColorIO haven't switched it on
yet.
4) Quick PR Review
477 - Dan to follow up with Ken offline, as there appears to be some older
commits attached to this PR. 474 - All feedback addressed, ready to be merged
once the CI passes. 459 - John's PR to add the maintainers file is failing the
CI, but not clear why. Merge anyway.
Other PRs require Peter's input so moved on from this agenda point.
5) Lambdas and ValueAccessors
Discussion following the recent email thread about how to use ValueAccessors
with lambdas. Ken highlighted that provided the ValueAccessor is being used for
a reasonable number of accesses, the extra performance cost of construction vs
copy construction is almost negligible. Ken pointed out that another typically
negligible performance penalty in the ValueAccessor is registering them with the
tree which can be optionally disabled.
Ken recounted that Peter's original objection was that a user of the library
would expect copy-construction to perform a copy. Changing this behavior
wouldn't be ideal. In general, no major concerns with changing the
copy-constructor of the ValueAccessor anyway, but some brief discussions about
alternatives that might be favored instead. Ultimately, no decision made on
this. Ken proposed we start out by doing some benchmarking.
Dan asked about whether using a hash map at the root node as well as an ordered
map for faster access performance would alleviate much of the need for the
ValueAccessor. Ken replied that this had been attempted in an earlier version of
VDB, but that std map performance is fast with a small data set. This is
typically the case with the root node due to the high fan-out factor.
Nonetheless, the ValueAccessor would still represent a performance increase over
a hash map.
All in agreement that there are a number of different patterns of how
ValueAccessors are used throughout the library and no clear recommendations. It
would be worth providing some guidelines and improving the consistency of how
this is done, particularly around the use of lambdas.
Unplanned) Regression Tests
Ken would like to see regression tests included in the library. Weta and SideFX
are both using regression tests that involve rendering images and using image
difference algorithms.
Nick raised that VDB hashing would be a useful feature to add to the library to
help with regression testing. Ticket to be made to track this as this has been
mentioned before.
6) H18 + ABI=6
Jeff mentioned that the H18 alpha does not yet have a version of OpenVDB with
ABI=6. The major sticking point is the issue with how to handle metadata (as
discussed in 8).
7) GCC and Dual ABI
The VFX Reference Platform specifically states to use the old C++ ABI (defining
the compiler flag -D_GLIBCXX_USE_CXX11_ABI=0). As a result Houdini is shipped
using this ABI. An issue was reported on the OpenVDB forum where a user was
using a later version of GCC (or a later OS such as Fedora 23) which uses the
newer ABI by default. This was causing confusion because the OpenVDB core
library was built with the new ABI but failed in attempting to link against
Houdini which was built with the old ABI. We agreed that the best option would
be to explicitly define the compiler flag for the old ABI when building the core
library for Houdini.
8) Metadata and .bgeo
Jeff has encountered a regression attempting to upgrade VDB for Houdini where
the VDB Clip SOP has started outputting file_ primitive attributes as a result
of a bug fix Peter made some time ago. The proposed solution here is to drop all
file_ metadata when reading from a .bgeo file. No concerns with this solution.
9) Next Meeting
July 11th 2019. 3pm-4pm EDT (GMT-4).
| 6,836 | Markdown | 44.58 | 80 | 0.794324 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-10-20.md | Minutes from 67th OpenVDB TSC meeting, Oct 20th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) ASWF Questions
4) Screen-sharing
5) Faster CSG Operations (PR785)
6) Review Process Retrospective
7) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) ASWF Questions
Ken is providing some project-specific questions to the ASWF tomorrow. Various
questions posed such as locking-down the tree configuration, usage of the Maya
plugin, etc. Any others people think of, please share with Ken before tomorrow.
4) Screen-sharing
Screen-sharing is still disabled in our ASWF calls. Ken is joining the meeting
using his NVidia Zoom account and believes the host account is the official
openvdb gmail account. Ken to look into how to unlock screen-sharing and/or to
discuss with John about changing which account is the host account. In this
instance, Dan's ILM Zoom account was used to host a new call with screen-sharing
enabled.
5) Faster CSG Operations (PR785)
Dan re-presented the theory behind this functionality as presented in the
Siggraph 2019 OpenVDB Course and gave an overview of the code changes in the PR,
answering questions from the TSC as they came up. Changes are organized in the
PR by commit.
Some areas of discussion and/or investigation include:
Ken highlighted that different words of a node mask could in theory be modified
concurrently to unlock parallelism across a single node.
Nick and Jeff wish to try and resolve the confusion of sometimes using a bool
threaded parameter and sometimes using a bool serial parameter across the
codebase in general. Using bool serial is probably the right decision here to
maintain consistency, but would be nice to fix in an independent effort. Jeff
suggested using an enum to maintain backwards compatibility.
Ken raised that the new DynamicNodeManager class needs more documentation. Dan
to address this.
Nick raised that there were issues in the past with threading a core method that
was previously unthreaded as a result of nested parallelism. Dan to investigate
whether there are situations in which construction of the LeafManager or
NodeManager happens inside a thread.
Jeff and Ken raised concerns with the TreeToMerge class accepting either const
or non-const trees and users inadvertently picking the wrong one. The suggestion
proposed here is to add a dummy class parameter to each constructor similar to
tbb::split to make construction more explicit. Potentially this dummy class
could be part of the Types header. Dan to look into making this change.
This feature has been deployed at ILM along with the VDB Merge SOP that is not
part of this PR. Main item of feedback was that the Tree visitor pattern was
previously being used with a const tree as the NodeManager required a non-const
tree. Dan has extended the NodeManager to accept a const tree following the
implementation of the LeafManager which also does this. This change is now
included as part of this PR.
Jeff proposes that we aim to approve this PR by the TSC meeting next week.
6) Review Process Retrospective
Big changes such as AX, NanoVDB and the PR discussed here are hard to get into
the codebase. Bikeshedding occurs and smaller, simpler changes tend to be
discussed and merged as priority. Need to keep trying to address how to unblock
changes that are hard to review and particularly those that are refactoring
large portions of the existing codebase.
Public API is most important to review as that can be time-consuming to try and
change later. Bugs in the implementation details will often be discovered in due
course but that should not hold up features progressing. Provided there is
decent unit test coverage of new functionality being added and that all of the
existing unit tests pass, that should help to lower the barrier to approval.
Ken reiterates that we should perceive the master branch in GitHub as in
development. Users deploying directly from this take on a fair amount of risk.
In general, all in favor of using this live code review process again in these
types of cases to help push the project forwards.
7) Next Meeting
Next meeting is October 27th, 2020. 1pm-2pm EDT (GMT-4). Jeff will be dressed up
for Halloween.
| 4,408 | Markdown | 41.39423 | 80 | 0.80127 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-05-14.md | Minutes from 49th OpenVDB TSC meeting, May 14th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Bruce Chernia (Intel), Robin Rowe (Cinepaint)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Fixing CI Builds
4) OpenVDB Houdini / Houdini Utils library
5) VDB Blur with Constant Tiles
6) AX Update
7) VDB SOP vs VDB Create SOP
8) VDB Grid Types
9) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Fixing CI Builds
The VDB CI was broken due to vcpkg updates. Dan to fix with a new PR. We
currently don't receive notifications if the CI fails and there are no cron
jobs. Dan to investigate these. It was noted that the vcpkg and homebrew
installations are volatile as they are not locked down to particular
dependencies. Ideally we'd have VFX platform style images across all OS's,
with "latest" CI representing the current style. There exists another PR #708
which also fixes the windows builds and looks to improve them.
4) OpenVDB Houdini / Houdini Utils library
Dan, proposal to merge the directory structure of of these two "libraries". The
separation was introduced by DW to help manage internal vs external source code.
Note VDB View also perform a similar build step (where headers are copied into a
temporary location). Discussion tabled until DW representatives are available.
5) VDB Blur with Constant Tiles
Jeff, bug reports in mantra due to strange "voxel" artifacts on blurred VDBs
which contained active constant tiles and therefore do not blur across node
boundaries. Ideal solution would be to only voxelize tiles which are guaranteed
to be affected. Ticket created to represent this work OVDB-143. Nick, explicit
calls to voxelize would assist in the short term even with the memory side
effects.
6) AX Update
Plan to have AX exist as a feature branch week beginning 18th May. Blocked on
two CMake PRs, #708 and a future CMake change to FindOpenVDB.
7) VDB SOP vs VDB Create SOP
Last outstanding SOP with discrepancies with Side FX's custom implementation.
Jeff is aware and will look to upstream.
8) VDB Grid Types
Nick, discussion around the VDB math library and VDB's default registered grid
types. AX aims to support a subset of its implemented types on VDB types but
it's not clear which of these types should be supported. For example, AX support
Vec4 point attributes but only Quat attributes are registered. This unveils a
further issue with grid/point types which are equivalent but cannot be
represented without using the explicit math implementation. This relates to
previous discussion about introducing runtime grid types and possible changes to
the VDB math library. Questions around which grid types should be registered and
how to better allow conversion from compatible types. To be discussed further at
future meeting.
9) Next Meeting
May 21st 2020. 2pm-3pm EDT (GMT-4).
| 2,947 | Markdown | 36.316455 | 80 | 0.788938 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-01-09.md | Minutes from 37th OpenVDB TSC meeting, January 9th, 2020, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel)
Regrets: *Ken* M., *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Next Week's Rendering Meeting
4) Google Summer of Code
5) PR Reviews
6) VDB on Windows
7) CMake Configuration
8) Next meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Next Week's Rendering Meeting
Ken will talk to Framestore and see if we can confirm this.
4) Google Summer of Code
There is a thread on TAC mailing list. We need 4-5 summer tasks for 12 weeks with mentorship. Should expect it to take as much time to mentor as it would take to write.
Some ideas:
* Delayed loading on Windows
* CSG operations without rebuilding
* Integrate Ken's Levelset Sweeping
* Erosion to work better
* Blur that doesn't fail at constant tiles
* Dilate active values apparently fixes dilate.
5) PR Reviews
562: Looks good, needs us to look at.
Ideally needs unit test, but shouldn't be submitter's task.
Performance might be a hit, doesn't seem to be, but can't tell.
Jeff to second-approve. Nick to merge.
402: Add note to help cards for ASWF SOPs. Peter wished a more complete implementation, but pending that we can go with this one.
579: ABS change shouldn't be done, just the ordering issue.
591: Jeff to Approve
Recent MSVC PRs: Min spec changes. We need a CMake check to verify our MSVC version. 2017 is our MSVC requirement.
Dan to resubmit one with just the template change, and update the build
check for MSVC version.
598: VDB Merge
Jeff has not looked at it yet. Should have everything for the inplace all requirements.
Draft PR for UI discussion incoming.
6) VDB on Windows
VDB on Windows for Houdini: We have no CI for it now. Revisit git hub actions. Jeff to check if there is a settings to switch off github actions for copies of the repos. (Editor: There are)
7) CMake Configuration
Ability for OpenVDB to output the cmake module for what it was built for. Could be a student task? Text file to describe the cmake for what was built. We would want Houdini to ship with this cmake file to show how it was built.
8) Next meeting
This will either be on Rendering or Roadmap.
January 16th 2020. 2pm-3pm EST (GMT-5).
| 2,299 | Markdown | 28.870129 | 230 | 0.755111 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-08-04.md | Minutes from 59th OpenVDB TSC meeting, Aug 4th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Bruce Chernia (Intel), Peter Cheng (DW), Richard Jones (DNeg),
Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) Open Source Day
5) Fast Sweeping and 7.1
6) NanoVDB
7) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Forum
Nothing to discuss
4) Open Source Day
The ASWF is hosting an Open Source Day, with VDB having a 55 minute slot on the
20th August, 10am PDT, 6pm BST. Nick and Ken to be put down as speakers. First
half to comprise of an overview and new features/AX, with the second half
opening to an open forum discussion. Ken to draft an abstract and send to Nick
for approval.
5) Fast sweeping and 7.1
Ken has made all necessary changes. Nick, some file writes still occurring in
the unit tests. Jeff, what happens if you have a single VDB with topologically
disconnected surfaces, once which can be processed and one which can't (i.e the
second has an invalid iso crossing). Ken, not sure, will investigate and
attempt to implement desirable behaviour, ideally returning a topologically
matching VDB (for non-expanding methods) with the first valid disjoint SDF
correctly processed. Specifically with fogToSdf, the result should always match
in terms of topology. 7.1 to be delayed until this is resolved.
6) NanoVDB
Ken presented the latest work on NanoVDB, a project parallel to the OpenVDB
project which aims to solve some specific use cases with the data structure.
The presentation covered the main aims and features of NanoVDB for the TSC.
A vote was held to assess whether NanoVDB should be considered for adoption
to the OpenVDB project.
Intent to adopt: Unanimous consent.
Next steps to come after public announcement.
7) Next Meeting
Aug 11th 2020. 2pm-3pm EDT (GMT-4).
| 1,955 | Markdown | 30.047619 | 79 | 0.771867 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-09-01.md | Minutes from 63rd OpenVDB TSC meeting, Sep 1st, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Ahmed Mahmoud
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) 7.2
5) NanoVDB
6) GCC 9.1 (PR 769)
7) CpuTimer using C++11 chrono (PR 690)
8) Introducing a "feature/abi8" branch (related to PR 788)
9) Deprecating code (PR 806, StringGrid, Tree::prune(), LeafNode::str(), etc)
10) "Locking down the grid configuration"
11) Extrapolate SOP
12) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Forum
Ken to reply to post about large VDBs/OOC. Dan to reply to delayed-loading
post.
There was a question about static libraries on Windows. Include paths need to
be included as a system header using MSVC. Including VDB headers is generating
warnings that are suppressed when building the core library. Nick has replied
to this qs.
4) 7.2
Nick has merged the PRs that removed the Makefiles and restructured the
codebase. Planning on introducing the first PR that brings AX into the master
branch, initially the core AX library only, then the Houdini SOP subsequently.
5) NanoVDB
NanoVDB probably aiming for an 8.0 integration to allow a little more time for
the codebase to mature. Ken currently merging NanoVDB up to the feature branch
on a weekly cadence.
New work includes a tool for recomputing the grid statistics, foreach, range
and invoke wrappers around TBB functionality. Current effort is in adding
DirectX support, seems this will be relatively trivial.
Some users are asking for documentation around the memory layout. Investigation
ongoing to look at replacing Jeff's work with the C library with a more
automated approach. Jeff notes that initial compile time is a bit of a problem
when using JIT.
Matt Pharr has incorporated NanoVDB into PBRT with pleasing results.
6) GCC 9.1 (PR 769)
Addressed concerns Jeff raised with bool specialization for higher-order
intepolation schemes by tackling the problem at the source. PR is now ready to
be merged.
7) CpuTimer using C++11 chrono (PR 690)
Dan investigated thread-safety issues with C++11 chrono. Adopted similar
solution to that favored by TBB which is to store the number of microseconds
since epoch instead of the time_point struct. This allows for starting and
stopping a CpuTimer across multiple threads. PR is now ready to be merged.
8) Introducing a "feature/abi8" branch (related to PR 788)
Need somewhere to put ABI=8 development in the run-up to 8.0.0. Solution
preferred by all is to use the master branch instead of introducing a new
feature branch that needs to be kept in sync. This will be gated by a standard
ABI=8 macro but with an additional EXPERIMENTAL flag to reduce chance it will
be picked up by accident, similar to the DEPRECATED flag.
9) Deprecating code (PR 806, StringGrid, Tree::prune(), LeafNode::str(), etc)
When should we deprecate? Is one minor version sufficient? Consensus that we
should be a bit more aggressive with deprecations, users often ignore
deprecation warnings anyway. Still nice to give users as much warning as
possible. New major version is a good time to drop API support and force
users to change their code. We should consider introducing a 7.1.1 patch
version with deprecation warnings. All to review the CSG operation PR 785.
Can we drop support for duplicateSourceStealable()? Nick still using it
heavily. Limitations with current SOP implementation that causes issues with
time dependency. Solution is to migrate to DS, but big sweep required to do so.
Agreement that we should remove these methods anyway, Jeff/SideFX keen for
people to not use this technique now.
10) "Locking down the grid configuration"
Dan has implemented explicit template instantiation for the tree hierarchy. It
speeds up building unit tests by around 30%, but building the core library now
slower. It works by suppressing implicit template instantiation whenever tree
hierarchy headers are included and explicitly instantiating them once in a
source file compiled with the core library. Unfortunately had to be implemented
using C preprocessor. More discussion needed, implementation shared as draft
PR 813.
11) Extrapolate SOP
Andre reports an issue with an assert firing in the fast sweeping code when run
in debug mode, despite it working correctly in release mode. Assert in question
validates that array indices are non-negative. Andre to share an example with
Dan to investigate the root cause.
12) Next Meeting
Skipping next week. September 15th, 2020. 1pm-2pm EDT (GMT-4).
| 4,643 | Markdown | 38.02521 | 79 | 0.789145 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-10-27.md | Minutes from 68th OpenVDB TSC meeting, Oct 27th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm Quorum
2) Secretary
3) Paged Array
4) AX
5) Faster Merge
6) Author Field in Headers
7) Next Meeting
1) Confirm Quorum
Quorum is present.
2) Secretary
Secretary is Jeff Lait.
3) Paged Array
Nick's concurrent unit test script manages to consistently crash the paged array test. There was a thread-unsafe method. The current fix is just decreasing the chance of race conditions.
There is an atomic counter checking against capacity. But there is no barrier, so two could trigger the capacity check at once. This is only the direct method; the accessor method doesn't have the problem as it does local insertions that it passes on demand, which is mutex locked.
The paged array has two APIs to add values. A direct access, and an accessor-style method. Using accessors is almost always faster than the direct method. Having a slow method leads people to think VDB is 100x slower than a direct grid, as they don't try the accessor. Why have an inferior method?
The direct access for paged array is not thread safe. So why do we have it?
Should we take out non-accessor methods, for this and VDB? What about a single query on a tree? So what about an accessor type that isn't cached? Maybe we should have a set of different accessor types to handle different caching policies?
If we lose the direct access, it is much harder for new users to get going.
But people keep going with very slow approaches. valueOn accessor is so much
slower that it should just be removed.
Is most of the time the root hash? Should we re-root the hash to reduce the amount of overlap? Or replace the root hash to be faster?
a) Can we make the tree faster?
b) Should we specialize the accessor for non-caching methods?
Replacing the root hash is tricky. We are requiring the sorting property of the root node. We may need to change the root node behaviour depending on the number of entries - small entries could be a raw vector, for example.
4) AX
Nick has been working on it.
Modulo implementation. Currently does C-standard method. Will change to match on VEX/Python approach. Done and upstreamed.
rand() uses boost::rand. Switched to std::. Speed is slower for 32-bit, faster for 64-bit. Currently API is rand and rand32, considering whether 32-bit generator has better distribution than 64-bit. Done and upstreamed.
Integer: do we remove short type for local variables? We need to keep the syntax to access the grid types. The same applies to int / long. Not sure yet of performance cost. Literals should be 64-bit. Vec3 local variables are currently 32-bit to match grids, this could be changed to 64-bit with 32-bit as a specifier for grids. The other big question is literals: can 32-bit AX have 64-bit literals? Generally agreed having the L suffix is not a good idea, but how to compute intermediate values is unclear.
Short circuit boolean operations. AX doesn't currently short circuit, so if (false && i++) would increment i. VEX doesn't short circuit. This surprises members of the committee, and has been submitted as a bug.
CI is now not bulding LLVM from source but using the docker containers.
Most runtime exceptions have been replaced by a logger. The compiler will now return nulls and generate a log if logger provided. Otherwise it will throw exceptions on errors.
5) Faster Merge
The feedback has been addressed. Now requires references and the const vs non-const is now deep vs steal.
6) Author Field in Headers
What do we do with @author fields? Having a prime author is useful. You don't get that from git. Historically files were committed by one username. Is this an owner or primary authors?
Some files have no names as there is no one author as too many have touched the file.
To avoid potential drama, we have drafted an ad-hoc author policty. We will not remove people from the @author list. If we make a substantial change to a file, we can add ourselves at our discretion.
7) Next Meeting
Next meeting is November 3rd, 2020. 12pm-1pm EST (GMT-5).
| 4,297 | Markdown | 51.414634 | 515 | 0.767745 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-12-19.md | Minutes from 36th OpenVDB TSC meeting, December 19, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: John Mertic (LF)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Road map / AX
4) OpenVDB user mailing list
5) Update regarding PointPartitioning/PointMerging
6) Proposal for alternative workflow for external contributors
7) Dev analytics
8) Timeline for deprecating Makefiles
9) Meeting with Framestore regarding I/O of custom leaf node meta data
10) Next meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Road map / AX
Nick has a concrete list of things to do before making a feature branch for AX.
Intention is to send a list of qs to TSC with links to the documentation.
Extensibility is a key concern currently. Priority is to send a full language
spec to the TSC as a google doc for discussion. Implementation completion aiming
for end of Feb/March.
Going through the rest of the Road Map tabled for a later meeting. Ken wishes us
to make this a recurring topic.
4) OpenVDB user mailing list
Discussion about migrating from Google Groups to groups.io openvdb-user mailing
list, most LF projects now using groups.io and general feeling that this would
be a good thing to do. Desire to maintain content history during migration, John
thinks that is not a problem. Open question about whether to merge openvdb-dev
and openvdb-user, but general feeling that both have their uses. Auto-migration
of mailing list not generally considered a good idea and this can be used as a
chance to cull mailing addresses that are no longer in use. Embedding the panel
in the OpenVDB website important but not a blocking issue, John to contact
groups.io people about how to achieve this.
5) Update regarding PointPartitioning/PointMerging
Dan starting to submit small PRs to build towards this effort, request for more
code reviews.
6) Proposal for alternative workflow for external contributors
Dan is suggesting that we set the default branch to something else (develop?)
instead of master so that by default, external contributors are not making their
contributions directly into the master branch of the repository. This gives us a
chance to tweak contributions, add release notes, etc then submit our own PR
from develop back to master which will run additional CI checks. TSC members
will still have the right to make PRs directly into master. The TSC member that
approves an external PR should also be the one that prepares the PR into master,
intention is that the changes do not live on develop for long. Open question
from Nick about permissions regarding making PRs into master. General agreement
to the idea, Dan to flesh out a proposal with more details.
7) Dev analytics
John shared the LF efforts with dev analytics
(https://lfanalytics.io/projects/ad847f51-3046-4989-b500-f5237ecd49d0/dashboard).
Some questions about what is the best metric to use, it primarily relies on Git
commits at present, but lines of code also not an ideal metric.
8) Timeline for deprecating Makefiles
Still a list of outstanding items for CMake, desire to formalize which are
required for us to move away from supporting the old Makefile build system. Need
a warning when you use the old Makefiles. Jeff / SideFX still relying on the old
Makefiles for now, Ken occasionally uses them.
9) Meeting with Framestore regarding I/O of custom leaf node meta data
Proposed date for 16th January to discuss storing min/max mipmap data for delta
tracking for rendering. Ken to reach out to Framestore as they are believed to
already have an implementation of this to confirm a meeting date. Intention is
to add other interested parties to this meeting and focus on this one issue -
Pixar, SideFX, etc.
10) Next meeting
January 9th 2020. 2pm-3pm EST (GMT-5).
| 3,819 | Markdown | 40.521739 | 81 | 0.795758 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-08-18.md | Minutes from 61st OpenVDB TSC meeting, Aug 4th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Bruce Chernia (Intel), Peter Cheng (DW), Andre Pradhana (DW)
Regrets: *Peter* C, *Dan* B..
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) NanoVDB
5) Repository Structure
6) Makefile
7) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Forum
Questions about computing averages of leaf nodes. Unclear if the questioner wants it baked in the tree or just computed. "On load" implies it is to be computed on construction.
Another post is on large VDBs and Out of Core (OOC). Wants to be able to stream it and unload it. Ken has in the past written a minimal version that does delayed loading and unloading. Loads in only the leaf data into a preset pool.
A mistake we've tried to do is make VDB try to do everything. So we kept putting everything in one structure, so it is not ideal for any application. Out of core is substandard, and random access is harmed by the out of core. We're trying to simplify the tree, and reduce dependency. Ken would like to contribute his streamable read only tree at some point. Ken will reply to the thread.
4) NanoVDB
Nick and Ken will talk at the OpenSource event where we can talk about it. This will be an alpha release of NanoVDB. There is still another platform that might cause tree changes. This will imply there is a long period where it isn't official.
How can we push to it without a pull request? Can do development on a fork. The feature branch on the fork can be done quickly. And this is then pushed up regularly to master. How to make it easy for people to push up changes?
AX for example has three repos that are all trying to stay up to date. Previously we had a private repo, that required a sync to the dneg fork.
Ken can keep the current private repo private. He can manually send synchronization pull requests by copying over from the private repo to the public. It is expected development will occur on the private repo and push to the public for the next few months until it transfers fully. Any PRs to the public repo can be hand-merged by Ken into the private repo to apply.
5) Repository structure.
Proposal to change the structure to allow for different versions to mix together for different submodules. Requires headers not be off the root directory, so you can -I include submodules from different locations. Each module can get a subdirectory of its same name to store the C and header files. This will affect existing tooling. Doing this before AX and Nano will be good. We then also end up with a clean source folder. Build system can ensure that the correct componets are built, so you never include anything from the local repo that is supposed to go from the installation on disk.
This will break existing PRs so we should make sure they are relatively up to date. The actual change is easy, the implications are harder.
All present vote in favour.
6) Makefile
Jeff reported Houdini's transition to the CMake from the Makefile. Ideally we support multi-target builds so can build Release and Debug in one configuration.
Should CMAKE_POSTFIX_DEBUG have a _d by default.
Mac seems to be inconsistent with where to put the 7.1.0 decorator - it goes ahead of the library extension rather than after.
We should consider now removing the Makefile. Unclear how many are using it as it currently doesn't work. We should raise it at the OpenSource day to see if there is push back.
We are currently letting the Makefile rot. So we should remove it.
We will put NanoVDB in raw, with both its Makefile and CMake. We will create a feature branch on Wednesday for NanoVDB.
7) Next Meeting
Tuesday, August 25th 2020. 1pm-2pm EDT
| 3,836 | Markdown | 56.268656 | 598 | 0.773201 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2021-02-02.md | Minutes from 78th OpenVDB TSC meeting, Feb 2nd, 2021, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B, *Andre* P.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Bruce Chernaik (Intel), Laura Lediaev (ImageWorks)
Regrets: none
Agenda:
1) Confirm Quorum
2) Secretary
3) Blender Update
4) GitHub Issues
5) Removal of EXR from Core
6) Half Update
7) NanoVDB
8) CSG Intersection Fix
9) Update Documentation Process
10) Boost Minimum Requirements
11) AX SOP
12) Next meeting
1) Confirm Quorum
Quorum is present.
2) Secretary
Secretary is Jeff Lait.
3) Blender Update
A brief update on the current integration status of VDB with Blender,
a more full update will be done when the documentation and code are
properly in sync.
4) GitHub Issues
We have an issue with issues. We have too many and it is growing. Some issues are things like tbb 2021 not being supported. Others are things we have already triaged - but they stay on the list. For example, the suggestion for a proxy for meshes. Moving to Jira would clear our Issue list, but mean there are many places to look (and submit) for the current status. We find the Issues are mixture of bugs, ideas, and questions. One option is a discussion tab. But this again is another place to go, and what happens when a discussion becomes a bug? Submitters should not be expected to know where things go.
There is a flow of new issues from Unprocessed to In Process to Discussed. Should we make this explicit so we can ensure all issues have been Discussed?
There is a risk that if we leave discussed issues active, our project looks incompetent as there are many open issues.
Bug vs Enhancement labels is something we should probably add as a result of discussion rather than from the submitter. The How To Submit Issues should talk about how we use labels and what they mean.
Do we want a tag for issues we are currently working on?
We decided to continute the discussion offline. Nick will provide an initial google doc seeded with the Jira workflow.
5) Removal of EXR from Core
Problematic as people use it. However, known use cases are with the command
line render tool, which will be unaffected. Could we have it still kept
without support in our CMake? But this leaves people little better off,
if they can alter the CMake to add the library support, they could as
easily add the explicit saveEXR code from the command line utility.
We are now in agreement to remove the saveEXR from the core library.
6) Half Update
CMake now configures BuildConfig.h. This stores if you built with EXR half. Still needs to be validated that this works with external Half implementations. It was proposed the flag refer to IMath half rather than Exr as it is planned to move to an external library. Or maybe it should be an external half flag?
7) NanoVDB
How to store half in memory? Could quantize on statistics? Ie, the leaf nodes know their min/max, so if had 8bits of precision could store values within that. If the quantization is stored per leaf node, this would require the codec switch to be done per leaf node. The suggestion is instead that the entire tree gets quantized with a fixed codec.
It was noted you need to dither the quantization. Raytracing soft fog can become very sensitive to quantization jumps. It was pointed out Bayer dithering does not work for this as it is optimal for area integrals, but volumes need to be optimal for arbitrary line integrals.
NanoVDB stores tile offsets rather than byte offsets, so cannot have varying codec in the leaf nodes as leave nodes must be fixed size. Points tried varying codecs, but not very useful. Maybe leave room for a codec per leaf node?
Maybe a global range to avoid jumps in quality between neighbour leaves. Having each leaf have its own quantization can result in neighbour leaves having very different qualities - imagine a single stray 1000 value that crushes low values around it; versus a leaf with only low density that is preserved. Out of range values could then be clamped, letting an artist control quality with an a priori quality metric.
A big question is do we have half as a type or a codec? Discussion is tabled until a later meeting.
8) CSG Intersection Fix
Fix is complete. Resolves the root node problem. Updated the old unit tests and verified against the old composite header. One change is to make the operations commutative in an rare case, but this is likely more correct.
Does this need migration documentation? The migration document is required for the leaf manager, not for this. This merely fixes what should have been a drop in replacement.
9) Update Documentation Process
The 7.2.2 update is a chance to streamline this. Will try to build documentation via github actions. Goal is to get into github pages. Then website can point to the github pages.
10) Boost Minimum Requirements
We need to support 1.66, but do not need to prohibit 1.61. While Houdini is technically correct to have 1.61 in 18.0 because it is hboost, not boost, in practice we pass void * across from the built OpenVDB with the native Houdini OpenVDB; so if there are any internal boost structures they need to be binary compatible. So moving forward the Houdini boost should sync with the vfx reference platform even though it is hboosted. 18.5 has already moved forward.
In the short term we can change the cmake to only require 1.61 so you can use 18.0. We should consider adding a CI test for Houdini 18.0 compatibility to explicitly use 1.61 rather than 1.66, however, to verify we do not introduce a 1.61 incompatibility.
11) AX SOP
Ready to go, needs approval
12) Next meeting
Next meeting is Feb 9th, 2021. 12pm-1pm EST (GMT-5).
| 5,753 | Markdown | 54.864077 | 618 | 0.78081 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2018-11-30.md | Minutes from 2nd OpenVDB TSC meeting, Nov. 30, 2018
Attendees: Nick A., Andrew P., Ken M., Jeff L., John M., Dan B., Peter C., Thanh H. A quorum
was confirmed.
Secretary - Ken Museth. It was decided that in the future this role will be rotating among the
TSC members.
3) Autodesk (specifically the Bifrost team) has reached out to Ken regarding a proposal to
adopting their multi-resolution grid into OpenVDB. The committee expressed interest in
investigating this further and will compose a set of questions that will help decide if this is
feasible and beneficial. Ken will collect these equations and forward them to Autodesk.
4) Currently only Peter C. has permission to to merge pull-requests but the committee decided
that this privilege should be granted to all TSC members. Thanh H can facilitate this but will
need to check with the TAC first. All TSC members will email their GitHub emails to Ken and
he will forward them to Thanh H.
5) Dan B. informed the committee of some ongoing challenges related to our transition to the
new Continuous Integration system (Travis to Jenkins) and build system (make to cmake). Dan
suggested to downgrade the failure threshold momentarily and Thanh M will configure it.
6) Andrew brought up the need for a dedicated “Security Expert” on the project. The committee
is requesting more information about what exactly this means and John M agreed to do some
research, including to see if the Linux Foundation offers any course on this subject matter. We
also agreed to revisit this topic again.
7) Ken wanted to confirmation that we plan to offer binary distributions of OpenVDB in the
future - especially for Window. Thanh M. confirmed that this is in fact the plan.
8) Ken raised the general question of copyright notices in our source code. DreamWorks will
retain this notice in existing files, and newly added files will specify the relevant copyright
(either of the developer or their organization as appropriate). Jeff L. agreed to write up a temple
that we will add to the coding standards.
9) Dan B. is still waiting to hear back for the VFX Platform group about a December release of
version 6. His ABI changes has been reviewed and approved by Nic A. and Jeff L. agreed to try
and build them at his end. Once merge privileges has been granted to the TSC we can go ahead
to merge and release v6.0 - assuming we get the OK for the VFX Platform. Else there seems
little rush to make this release and we could potentially open up for more features to be included
in v6.0.
10) Our next TSC meeting is scheduled for next Thursday Dec 6, 2018 2pm-3pm. John M. also
offered to set up a mailing-list for the TSC.
| 2,667 | Markdown | 58.288888 | 99 | 0.790026 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-06-06.md | Minutes from 19th OpenVDB TSC meeting, June 6, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel)
Agenda:
1) Quorum Secretary
2) Secretary Selection
3) CI Update
4) Plans for 6.2
Non-Planned A) Rasterization
Non-Planned B) Response to Autodesk
5) TestUtil::testPagedArray
6) OpHiding Next Steps
Non-Planned C) Retrospective
7) Delayed Load Update
8) Version/Namespacing SOPs
9) Speed of hasActiveTiles/voxelizeActiveTiles
10) GCC and Dual ABI
11) Memory Allocators
12) Topology Replace
13) Schedule Next Meeting
1) A quorum was confirmed
2) Secretary - Dan Bailey
3) CI Update
The ASWF is likely going to be selecting Azure Pipelines as their favored CI
service so we are investigating moving to this. Azure Pipelines has been enabled
as a GitHub Check and Dan has submitted a PR to switch on everything that
currently builds in Circle. This works a little differently in Azure than
Circle, because it uses Docker containers to store pre-installed dependencies to
accelerate the startup time and avoid re-installing all our dependencies from
scratch.
The next step is to consolidate the Houdini installations into a single docker
container and to make this docker repository private, as we cannot distribute
releases of Houdini in a public repository, because it requires signing a EULA.
DockerHub individuals have access to one private repository, whereas DockerHub
organizations have none so without paying a regular monthly subscription, the
Houdini repository will need to live under Dan's account for the time being.
Longer term, the intention is to build using DockerHub images published through
the ASWF, though that's not included as part of this initial migration.
4) Plans for 6.2
No precise date is present at the moment. Siggraph is still a tentative date.
Integration with Houdini++ likely requires a release around that date. Peter
reminds the committee that we shouldn't feel under pressure to do this release.
We should hold off if the release isn't ready or there are not sufficient
changes for it to be worthwhile.
In turn each committee member listed what they would like to contribute to 6.2.
Peter is looking to include a new sharpening tool and SOP. PR has been
submitted, awaiting feedback from Ken. Jeff was asked about how to best display
kernel coefficients in Houdini's UI and replied that SideFX hadn't found an
ideal solution to this problem.
Ken will release a fix to PagedArray later today. Planning to submit
multi-threaded conversion to spheres and velocity extension among a few other
tools. He would like to include read-only grid data structure developed at Weta,
but thinks it's unlikely to be possible by 6.2. This may be of particular
interest to the rendering community.
Nick believes surfacing is not feasible in the likely timeframe and is primarily
focused on AX. Initial aim is to include AX on a feature branch that is part of
the main repository by 6.2. Nick to ask John Mertic about setting up a private
repo for the committee to share features that cannot yet be made public.
Dan would primarily like to include delayed-loading improvements and VDB SOP
unification, both of are submitted as PRs and under active discussion. A
secondary goal is to extend the move points API to add merge capability and
introduce this functionality to VDB SOPs. Nick to share DNeg's production-proven
implementation of merging VDB Points grids to help with this effort.
Non-Planned A) Rasterization
It was widely acknowledged that rasterization is a hard problem and has many
differing requirements resulting in a highly divergent solution space. Jeff gave
a brief overview of some of the key considerations and a little history about
the various different rasterization tools that Houdini ships with. The TSC
members are in agreement that we would like to better solve this problem and it
was suggested that Siggraph might provide a good opportunity to discuss this
area in more detail.
Non-Planned B) Response to Autodesk
Ken is working on a response to Autodesk and will share a Google Doc with the
TSC members shortly.
5) TestUtil::testPagedArray
Ken has completed a fix, planning to submit shortly.
6) OpHiding Next Steps
An in-depth discussion about this feature was held. The TSC members are
currently unable to find consensus on the right approach to take here. However,
agreement was found in a number of areas. The TSC remains motivated to resolve
the underlying problem where duplicate OpenVDB and VDB SOPs show up in the tab
menus as this behavior has caused confusion to artists for many years.
There was agreement on the need to provide a link between the open-source SOPs
and the native SOPs shipped with Houdini. It was felt that this would be best
done in C++ by extending the existing policies and the operator registration.
There was no objection to including a startup script in some form. There was
agreement that using HScript/OPcustomize was well-suited for simple startup
scripts that hide nodes and Jeff confirmed that there was no plans to deprecate
HScript. Where any conditional logic were to be included, it was felt that using
a pythonrc script would be a better fit.
There was a desire to try and provide just one solution to this problem. This
was mainly motivated from not wanting to cause undue confusion to artists and
developers.
It was also agreed that the configurability of the new policy/flags mechanism
implemented by Dan in C++ was overkill given that a startup script would be
offered. Dan will remove this functionality from the PR.
The TSC was largely in agreement that an environment variable was an acceptable
mechanism to provide to artists to adjust the hiding policy.
The main area of contention was whether to make a startup script the only way to
adjust hiding of nodes or whether to also allow this to be configured from C++.
Dan and Jeff felt that adding an OPcustomize/pythonrc file added an additional
point of failure and that it required users to correctly install OpenVDB which
shouldn't be taken for granted. Peter and Nick felt that using
OPcustomize/pythonrc was the correct way to solve this problem and that VDB
should instead follow precedence and advice offered by SideFX in using that
mechanism. To make use of this feature, users would be expected to install this
additional file.
Jeff highlighted an additional problem in how the ASWF label suffix should be
added if two different mechanisms for controlling visibility are in use. Peter
suggested using an oprename in the start script to solve this there.
The next steps are for Dan to re-visit the current implementation and attempt to
find some common ground. Peter will look at implementing an alternative solution
using pythonrc as a prototype for discussion in the meeting next week or the
week after.
Non-Planned C) Retrospective
The TSC acknowledged that the process of resolving the OpHiding problem wasn't
very effective and has resulted in some back-and-forth. Dan and Jeff
collaborated on a proposal that didn't receive any feedback at the time. There
was an assumption that lack of feedback meant no significant objection to the
proposal. Dan put together an initial implementation which has been subsequently
changed multiple times and Peter has spent quite a lot of time reviewing. One
suggestion was to present this proposal to the TSC members in an earlier
meeting, which may have helped elevate some of this discussion earlier. Peter
cautioned that sometimes the discussion can only be had once there is an
implementation to look at.
Ken raised an additional concern - in the past features used to be vetted
internally at Dreamworks, proven in production first and then released publicly.
With a cross-company collaboration now in-place, much of that vetting is now
happening before a feature has been production-proven. This may give the TSC
less confidence in including it in OpenVDB.
8-12) Time
13) Schedule Next Meeting
June 13th 2019. 3pm-4pm EDT (GMT-4).
| 8,028 | Markdown | 45.680232 | 80 | 0.808047 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-12-15.md | Minutes from 73rd OpenVDB TSC meeting, Dec 15th, 2020, (EDT)
Attendees: *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Andre Pradhana (DW)
Regrets: *Peter* C., *Nick* A.
Agenda:
1) Confirm quorum
2) Secretary
3) TSC Membership
4) Latest Dependencies
5) NodeUnion issues
6) Templated volumeToMesh()
7) Obsolete parms
8) 8.0.0 Release
9) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) TSC Membership
Ken would like to invite Andre Pradhana to become an official TSC member.
Simplest route to achieving this is for Peter Cucka to officially nominate Andre
as his DWA replacement. Ken to reach out to Peter.
4) Latest Dependencies
Need a CI solution for building the latest dependencies, particularly the GCC
compiler and Boost. Current master breaks using GCC 10 due to removing headers
related to size_t declaration. Dan has introduced an apt-get solution that
builds against GCC 10 and resolved the size_t issue. Would be better to find a
way to build against a bleeding edge set of all dependencies.
5) NodeUnion issues
There was a breaking ABI change in the NodeUnion changes that Nick has reverted
for 8.0 and re-applied with ABI guards. Nick has also looked at expanding the
ABI checks to try and better catch this in future. Ken proposed checking data
member offsets which would help catch these ABI errors but any modifications to
the vtable would still go unnoticed.
6) Templated volumeToMesh()
There has been a question about using a templated API to volumeToMesh similar to
MeshDataAdaper. A good idea, but not a priority for the TSC and hard to make it
work efficiently using the proposal put forward as it will involve frequent
resizing. Jeff to reply.
7) Obsolete parms
Jeff found an issue with an obsolete parameter in VDB to Spheres SOP that caused
reverting of a parameter to the default value and has fixed. We should check if
there are any other cases where this comes up.
8) 8.0.0 Release
PRs to merge include PR898 (deprecating old code) once Dan has addressed
feedback from Ken and PR839 (find active values improvements) once Ken has
addressed feedback from Dan.
8.0.0 release on track to be released before Christmas.
9) Next Meeting
Next meeting is January 5th, 2020. 1pm-2pm EST (GMT-5).
| 2,261 | Markdown | 30.416666 | 80 | 0.783282 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-07-28.md | Minutes from 58th OpenVDB TSC meeting, July 28st, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), Bruce Chernia (Intel),
JT Nelson (Blender), Peter Cheng (DW), Andre Pradhana (DW).
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum Issues
4) Fast Sweeping
5) GCC 9, PRs for 7.1
6) 7.1 Release, who does it?
7) VDB Point Move
8) Leaf manager/Node manager.
9) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Forum Issues
None to discuss
4) Fast Sweeping
Working on Dan's changes. While benchmarking, surprise arose as the performance improvement does not primarily come from the new sorting, but rather from faster subsequent access to the coordinates in the fast-sweeping kernel. Less memory traffic, and more coherent, makes the raw stencil 2x faster. Should be possible to extend any attribute if you support lerp. So we should support vectors in a single sweep.
Andre found convergence better than expected. Extending the Flip! SDF from Houdini. L1 error 7x10-4 for single sweep vs 30 sweeps.
A purely convex model could do a single pass which does all 8 sweeps in parallel rather than sequentially. Topologically disjoing domains could be processed entirely independently.
Currently if you have a very small sphere with not many points in the cross planes more divisions would be beneficial. This might not work on the GPU where you need to be more aggressive in finding more threads.
The extension attribute will be templated, allowing for support of velocity fields.
Not looked at introducing a tolerance yet.
How to expose a functor into Houdini? Suggestion is to provide a VDB for that purpose. So should be two optional inputs, for a mask and for the functor. Instead, perhaps main input can have both the surface an extrap source fields. Output would be the source field re-created in the space of the surface field.
The mask will be used for the region to extrapolate. The SDF will be used only for computing isosurfaces within this mask. So mask should be second input.
We aren't sure of the tolerance to use. If we have an explicit tolerance that is lower than what the algorithm can achieve, it will never converge. Tolerance support is not a blocker.
5) GCC 9, PRs for 7.1
Ken related his ABI=0 and ABI=1 build issues from CentOS 8. Nick has improved the error messages so it is easier to debug at least.
We should make sure gcc 9 works before 7.1 release. We realized we weren't testing gcc in our VFX2021 test, but clang instead. So needed to move the CI to gcc. Some errors are simple, but at least one is tricky. Implicit conversion of bool to int. LOD fails, prolong operators use + rather than |, for example.
Ken should try to build LOD tet. Unit tests don't build bool and mask grids.
Nick has encountered LOD not working. Can't find the fix. He does not think it should be rushed for 7.1. We should remove the multires grid of boolean from LOD in 7.1. We can fix the tranform grid as it is simpler. But some are concerned this might cause problems. Maybe a way to disable the warning, but the warning doesn't exist in gcc 6.
Should we get the Blosc change in? Agreement to send it in. Ken will commit it.
6) 7.1 Release, who does it?
Ken will attempt the release following the instructions.
7) VDB Point Move
On pause waiting for the VDB Merge.
8) Leaf manager/Node manager.
Moved to a 7.2 change. Possibly pushed into a branch? Will be removing the ability to create a node manager from a leaf manager as that got complicated.
9) Next meeting
August 4th, 2020. 1pm-2pm EDT (GMT-4).
| 3,671 | Markdown | 46.688311 | 415 | 0.765459 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-03-05.md | Minutes from 42nd OpenVDB TSC meeting, Match 5th, 2020, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: Bruce Chernia (Intel), Johannes Meng (Intel), JT Nelson (Blender)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Release notes build section
4) Update on Windows changes
5) Houdini -> VDB voxel size conversion
6) CI and Github Actions
7) LevelSet Tracking
8) Active value deep copy
9) Volume Advection grain size and topology options
10) Next meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Release notes build section
Proposal to separate out the build related release notes from the other
release note sub-headings. It was noted that these notes have changed
already in the past to adapt to new formatting being needed. Unanimous
consensus, with the addition to additionally include any large changes
in the highlights section. Nick to reformat the current release notes.
4) Update on Windows changes
Nick has been looking through the Windows build and attempting to
resolve various issues that have been raised. The following issues in
particular are currently being addressed:
#627, #624, #620, #611, #603
Main issues with the windows build continues to be the ability to
support the both the Release and Debug builds in a single configuration
as well as the both static and shared builds. vdb_view continues to be
unsupported, but the work required to fix it is minimal. Ken to connect
Nick to community who have reached out expressing desire to help improve
the windows builds.
5) Houdini -> VDB voxel size conversion
Nick has reported an issue to SideFX regarding conversion of Houdini DOP
volumes to SOPs and subsequently to VDB volumes. The issue that
manifests is that a volume which is intrinsically uniform in terms of
its voxel size components can end up being represented as a non uniform
scale map when converted to VDB. This can stop various optimizations
from being performed further down the line and can additionally cause
unnecessary re-sampling operations to occur. Jeff explained that Houdini
volumes to not have an explicit representation of their voxel size.
Instead, The voxel size of a Houdini volume is inferred from its
transform projected onto a canonical unit cube. This can cause floating
point differences to manifest when this value is calculated per
component and presented to the user, as well during conversion to VDB.
Nick mentioned that an ideal solution would be to be able to query some
intrinsic details from the Houdini Volume's configuration and use this
information to determine whether checks should be made on the final
voxel size computations to ensure they are all equal. Jeff mentioned
that Houdini Volumes currently contain no such information and instead
proposed that a clamp can instead be used to ensure components match to
a given tolerance. Note that whilst this problem originally focused on
improving the conversion from Houdini->VDB, this issue could also be
addressed by improving the comparisons between various VDB Map types.
Nick to verify that the example provided to SideFX exhibits the above
behaviour.
6) CI and GitHub Actions
Dan has put a request in to the LF to disable appveyor and instead
switch to github actions for our CI. Additional discussion around the
new develop branch system. Jeff and Dan have both been caught out by
having to switch the target branch to Master for TSC PRs. Nick suggested
that we all should instead be merging into develop. Dan proposed an ad
hoc target branch to instead be created for PRs which require additional
changes from the TSC (coined "develop on demand"). Jeff, Ken and Dan
voted in favour of this system vs maintaining a develop and master
branch, with the condition a test is first demonstrated on an existing
PR.
7) LevelSet Tracking
8) Active value deep copy
9) Volume Advection grain size and topology options
Time
10) Additional Discussion
Proposal to make IlmBase/OpenEXR optional currently in review but needs
more changes. Questions were raised on why this would be useful, however
various users of VDB seem to not require the writing and reading of half
grids. Ultimately this further progresses the ability to build VDB with
less enforced dependencies and makes it easier to build for users who do
not need Half support.
11) Next meeting
March 12th 2020. 2pm-3pm EDT (GMT-4).
| 4,396 | Markdown | 40.87619 | 87 | 0.80323 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-05-23.md | Minutes from 17th OpenVDB TSC meeting, May 23, 2019
Attendees: *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), John Mertic (LF)
Regrets: *Ken* M.
Agenda:
1) Quorum Confirmation
2) Secretary Selection
3) CI Update (Dan)
4) CLA Update (John)
5) Mainline Remote Branches (Nick)
6) Switch to Relative Header Paths (Peter)
7) OpHiding Next Steps (Dan)
8) GitHub Issues Cleanup / Process for Submitting Bug Reports (Nick/Jeff)
9) VDB Delayed Loading (Dan)
10) Maya Plugin (Nick)
11) Level Target Pruning/Voxelization (Nick)
12) Speed of hasActiveTiles/voxelizeActiveTiles (Nick)
13) Schedule Next Meeting
1) A quorum was confirmed
2) Secretary - Nick Avramoussis
3) CI Update
The ASWF is moving towards Azure Pipelines. We will again have to migrate over
our CircleCI implementation. Tests using docker have already been put together
and show promising results. We'll most likely support both Circle and Azure
during Azure adoption, then deprecate and remove Circle.
4) CLA Update
Up until now there has been no automatic process whilst we've been waiting for
the LF automated CLA system. This new system can be triggered through first
commits or pull requests to the repository. The DCO will still be required -
there are a bunch of command line signoff tools to help with this, John has
compiled a list here:
https://github.com/jmertic/dco-org-check#useful-tools-to-make-doing-dco-signoffs-easier
TSC members should look to sign the digital CLA as a CLA manager and get signoff
from a CLA Signatory from within their organization. Consensus from the TSC was
to wait for all 5 TSC members to have gone through the new digital CLA process
before enabling it on the OpenVDB repository.
5) Mainline Remote Branches
A brief comment about keeping the repository clear of remote branches. Nick to
remove the last remote created by Ken and to close off that work. Informal
agreement to keep the main repository clear of remote branches bar release
branches.
6) Switch to Relative Header Paths
OpenVDB currently uses absolutely header paths to pull in other OpenVDB headers.
This may be an issue if you already have an installed version of OpenVDB on your
system, those headers could be pulled in during compilation. This was true with
the old Make system but may not be an issue anymore with how the CMake is set-up.
There are three avenues to explore here - changing the Core library to use
relative headers to itself, the plugins to use relative headers to themselves
and finally the plugins to use relative header paths to the core library. The
latter will impact Jeffs/SESIs Houdini integration. Peter to do the bare minimum
update. Nick to investigate if this is still an issue with CMake.
7) OpHiding Next Steps
A idea to expand the Houdini menu system via xml/python to provide options to
disable/enable OpenVDB Nodes could potentially help users switch between
SESI/ASWF nodes interactively, though is orthogonal to the issue of site set-up.
The SESI nodes have different opnames to the ASWF ones which complicates
generating an opcustomize file - though the current way around this is hard
coding them in the AWSF SOPs so this could potentially be duplicated. The SOPs
themselves could also be used to generate the opcustomize script. Dan to
investigate command line tooling during or post compilation to achieve this.
8) GitHub Issues Cleanup / Process for Submitting Bug Reports
Forums vs github Issues. At first glance the forum seems to be mainly for
discussion where as github issues are being used far more for bug reporting.
github issues can only be open or closed - there is no intermediate state such
as 'Stalled' or 'Awaiting Response' which makes them harder to use for
communicating with users and tracking status. We have set no expectations for
users who are reporting bugs/issues/questions. It was generally agreed to
continue monitoring the forums and github issues, creating tickets in Jira from
verified posts and closing out github issues which have received no update in
over a week. Nick to write up a proposal for this which, once agreed, can also
be posted/pinned to the forum.
9) VDB Delayed Loading
Currently uses OpenVDB's metadata system to track the enabling/disabling of
the improved delay loading implementation. A more ideal solution would be to
expose a hook in the file io code, but this will take time to filter down due
to ABI/file format compatibility. We don't really want two APIs achieving the
same result, it would be good if an attempt at implementing a hook in the file
io could be proposed to achieve later forwards compatibility. It was decided
that the metadata should at least be cleaned-up on read so it is in no way
exposed to the user. We should also investigate warning/skipping on internally
known types and ensure the metadata name is prefixed with "__".
10) Maya Plugin
There are issues with the Maya plugin, specifically the OpenVDB Visualize node,
in Maya's view-port 2. We should create tickets to get Maya into CI and at a
minimum produce documentation explaining how to enable the OpenVDB Visualize
node in Maya 2018/2019.
11) Level Target Pruning/Voxelization (Nick)
Using VDB topology for load balancing operations which are sensitive to the
node size used i.e. voxel, tile, internal node. Nick to send around a
proposal for what this implementation could look like and the desired
functionality.
12) Speed of hasActiveTiles/voxelizeActiveTiles (Nick)
Time.
13) Schedule Next Meeting
May 30th 2019. 3pm-4pm EDT (GMT-4).
| 5,550 | Markdown | 42.708661 | 87 | 0.797117 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-09-26.md | Minutes from 28th OpenVDB TSC meeting, September 26th, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M., *Peter* C.
Agenda:
1) Confirm quorum
2) Select TSC member to take minutes
3) OpenVDB 6.2 postmortem
4) Proposal for new improved interpolates
5) (OVDB-117) MeshToVolume non-deterministic bug
6) Windows CI
7) Update on copyright notices
8) User feedback (usd/python bindings/Maya support)
9) Plans for ABI=7
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) OpenVDB 6.2 postmortem
An issue was reported with the OpenVDB 6.2.0 release which broke ABI
compatibility with Houdini. This was reproducible with a vanilla install of the
toolkit (on Linux) and manifested during serialization of OpenVDB Point Data
Grids into Houdini file formats (.bgeo and subsequent derivations) as a
segmentation fault. Generally, the definition of ABI compatibility that we apply
to the software is isolated to the Grid and Transform objects. Ken mentioned
that the major ABI definition should guarantee a reinterpret cast of the Grid.
However the io::StreamMetadata and internally held io::StreamMetadata::Impl
objects can also be passed between libraries using OpenVDB. These classes are
used for file IO and hold information about the current state of the IO stream.
In the above case, the StreamMetadata object was being constructed by Houdini
and passed across the library boundary to the writeBuffers() methods. This
function is unique for OpenVDB Point serialization in that it accesses auxiliary
stream metadata. Changes to the memory layout of the io::StreamMetadata::Impl
class made in PR #436 (OVDB-91) meant that the relative position of the
auxiliary stream metadata was no longer correct when passed across the library
boundary. Similar changes have been made to this class before, but have been
fortunate enough to be 1) small enough in bytes that the padding and alignment
resulted in the memory layout remaining the same, 2) members after the inserted
members were not accessed in the serialization routine or 3) they were only
appended to the end of the class. The proposed and agreed upon fix is to move
the new members added in #436 to the end of the class and to consider the
StreamMetadata object as part of the major ABI.
Note that this is not an issue for deserialization. The problem arises when
creating a VDB using a native SOP and serializating into a .vdb file or creating
the VDB using an ASWF SOP and serializing into a .bgeo file. Despite being
casted across the library boundary, the virtual functions still point at the
library definition from which the grid was authored.
There was discussion in regards to creating tests for problems specifically
related to Houdini ABI. Dan suggested that whilst a fully Houdini integration
test would be useful, it was probably not necessary for testing this particular
bug - instead, a binary which links to both the Houdini deployed version of
OpenVDB and the CI built OpenVDB could be used to test compatibility.
4) Proposal for new improved interpolates
A proposal from Ken to introduce new interpolators. Currently the existing
methods in Interpolation.h support zero, first and second order interpolation
with collocated and staggered grids. They're implemented as static classes with
no members which, whilst providing a very simple and easy to use interface,
requires them to fetch all stencil points on every sample call. There are
additional issues with some of the staggered implementations which perform
unnecessary operations on unused extents. Ken proposed a re-work of the current
methods to solve these issues and potentially introduce new third order
interpolators. Discussion on how this would differ from the methods available in
math/Stencils.h which currently provide various interpolation methods from
cached buffers of grid points. It could be possible to use the stencil framework
for efficient caching and fetching of values with a separate framework for the
interpolation algorithms. Discussion on how introducing new non-static classes
would impact the API of methods which are templated on the current static
interpolators, as these methods would need to construct these objects.
Suggestion would be to update all uses of the interpolation with any new ones
and mark the old ones as deprecated. Note that these interpolators are currently
not being unit tested. Any new interpolators should attempt to match the output
of the existing methods exactly. Ken to create a jira ticket with a description
of the proposal and notify the mailing list.
5) (OVDB-117) MeshToVolume non-deterministic bug
Nick reported a non deterministic bug with the MeshToVolume algorithm which is
producing different results with the same input. This originally came from a
regression test testing a P2LS operation followed by a level set rebuild.
OVDB-117 contains a main which has isolated the issue down to the
tools::meshToVolume call and, more specifically, to the first threaded operation
mesh_to_volume_internal::VoxelizePolygons. Attempts have been made to isolate
this down even further, however the suspicion is that it is related to threading
and the TLS primitive ID tree which is being used to track triangle visits to
individual voxels. Has not been reproduced unthreaded and requires multiple
instances of the binary to catch quickly. More testing to be performed.
6) Windows CI
A number of github issues regarding the windows CMake build have been raised.
Nick attempting to field these, however it has been challenging without a
Windows CI matrix. Dan mentioned that github actions has recently been made
available (open BETA). Dan to share an example implementation of github actions
which can be run from a forked repository and potentially share a version for
Windows which could be extended.
7) Update on copyright notices
DreamWorks are currently in discussions with the Linux Foundation on the best
way to proceed with any potential copyright notice changes. Changes to copyright
notices stalled on this decision.
8) User feedback (usd/python bindings/Maya support)
9) Plans for ABI=7
Time.
11) Next Meeting
Next planned meeting is:
October 10th 2019. 3pm-4pm EDT (GMT-4).
| 6,206 | Markdown | 50.29752 | 80 | 0.811473 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-06-04.md | Minutes from 51st OpenVDB TSC meeting, June 4th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Peter Cheng (DW), Andre Pradhana (DW), Bruce Chernia (Intel),
Ibrahim Sani Kache (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Fast Sweeping
4) Python 3
5) Other
6) Next meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Fast Sweeping
Ken has pushed up his implementation of his approach to the re-computation of
signed distance fields, Fast Sweeping:
http://www.museth.org/Ken/Publications_files/Museth_SIG17.pdf
The code is available on Ken's fork of OpenVDB:
https://github.com/kmuseth/openvdb/tree/OVDB-133_FastSweeping
Ken to open a draft pull request into VDB for others to comment on and trial the
implementation. Ken, some work still to be done however the bulk of the
algorithm is complete. There exists a variety of new public methods to perform
re-computations of level sets, conversions of scalar fields (signed fog) to
level sets and the value extrapolation of level sets, potentially coupled with
another scalar grid. CI build is currently failing due to some strict C++
checks which should be easy to fix. It was noted that the extension of anything
other than a scalar grid (i.e. vector grid) currently requires multiple
invocations of the algorithm, something that could be improved.
4) Python 3
Ibrahim asked about python 3 support and OpenVDB. We currently have CI images
that run in VFX 2020 which test with 2020's python version, currently at 3.7.
There have been some reported issues with python 3.8, however this should only
be specific to the architecture of the unit tests and not actually the python
plugin itself. TSC unaware of any other issues regarding python 3. Note that the
VFX 2021 container has now be drafted.
https://vfxplatform.com/
5) Other
Discussion into OpenVDB's dependencies. Ken, one of the biggest complaints he
hears is VDB's dependency list. Having some of these dependencies as VFX
platform candidates could help - mainly referring to blosc. Jeff, LLVM (as a
requirement of AX) should not really be a part of the VFX platform (due to its
volatility w.r.t API/ABI), with downstream software instead opting for always
hiding LLVM symbols. Boost python is heavily relied on - pybind would be a
reasonable alternative but that also does not appear as part of the VFX platform.
Note, OpenEXR have decided to split out Imath and potentially advocate it as a
math library for VFX:
https://github.com/AcademySoftwareFoundation/Imath
Ken mentioned open source licensing rules for contributors - would it matter if
an addition to OpenVDB was made under a different Open Source license? Nick, AX
has opted to use the same license as OpenVDB so there are no concerns there.
Potentially would have to be deferred to the Linux foundation.
6) Next meeting
June 18th, 2020. 2pm-3pm EDT (GMT-4).
| 2,964 | Markdown | 39.616438 | 81 | 0.78475 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-06-30.md | Minutes from 54th OpenVDB TSC meeting, June 30th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Peter Cheng (DW), Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) New Meeting Time
4) 7.1 Fast Sweeping
5) 7.1 Sharpening
6) Dilation Improvements
7) Next meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) New Meeting Time
New meeting time to be scheduled an hour earlier.
Every Tuesday at 10am PST / 1pm EDT / 6pm BST.
Johannes to check with Bruce about a possible conflict.
4) 7.1 Fast Sweeping
Jeff and Nick have posted reviews on the PR. Jeff, various comments on input
types and exception behaviour. Nick, primarily concerned about const casting and
redundant code. Ken to attempt to address the feedback. Andre had tested the new
SDF dilation based algorithms which are working and will continue to work with
Jeff to prepare a SOP component. Noted that vector grid processing still
requires per component extension via vector splits and merges. Ken to see how
feasible it would be to avoid this step. Dan, CI builds are still failing on
this PR, requires local builds to build with -DOPENVDB_CXX_STRICT to reproduce
the problems.
5) 7.1 Sharpening
Ken, approved implementation but unable to checkout/copy peters changes to
ASWF/fork so still needs unit tests. Two ways to resolve this, either clone the
fork or merge into a temporary branch in the ASWF repo. Dan to take a look at
achieving the latter. Nick, concern that no unit tests now mean none later. Ken
to take another look at the result of Dan's merge of Peter's branch. Touched
again on the fact that Peter's implementation of the sharpening kernel is not
separable and thus trades some performance for more robustness. Ken, Peter's
benchmarks look promising and the alternative implementation (unsharpen masking
i.e. signal processing, low pass filter to remove high freq) may not work on
levelsets.
6) Dilation Improvements
Nick, new PR which fully implements the proposed changes from #675 will be up
shortly. Aims to deprecate the existing dilateVoxels and erodeVoxel methods with
new functions that provide a more uniform interface and support matching
functionality. Adds support for edge/vertex erosion based on inverse dilation.
Significant performance improvements to large dilations. Note that the result of
the threaded dilation differs due to the behaviour of topologyUnion. This is
addressed by #751.
7) Next meeting
July 7th, 2020. 1pm-2pm EDT (GMT-4).
| 2,584 | Markdown | 36.463768 | 80 | 0.787926 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-01-24.md | Minutes from 6th OpenVDB TSC meeting, Jan. 24, 2019
Attendees: John M., *Jeff* L., *Nick* A., *Ken* M., *Peter* C., *Dan* B., Andrew P.
Additional Attendees: Bruce Chernia (Intel), naren vadaplli, Thanh Ha, Greg Gewickey
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) SIGGRAPH Course proposal (Ken)
4) Update on permissions, release process, jira & code coverage (Dan)
5) Cleanup and improve repository (Ken)
6) Road map (Ken)
7) Schedule next meeting
1) Quorum was confirmed
2) Secretary - Jeff Lait.
3) Siggraph Course
Nick, Dan and Ken confirmed they are interested and likely have topics to
present as a 1.5 hour course submission.
4a) Update on permissions
admin status is restricted to ASWF admin, so will not be granted to TSC.
Dan will submit a help desk ticket to increase minimum reviews to one
from zero.
4b) Release Process
4b1) Website
Website repo is built and functional. DNS transfer is still on-going, but
may have just been approved. Doxygen build step is still missing, but
that can be fixed later.
4b2) Release Process documentation
Peter will draft a release document to roughly cover the current release
process.
4b3) Conflicts in Changes file
With the non-linear nature of pull requests, the changes file generates
conflicts.
One approach is to use openstack reno. Dan will investigate reno, as used in
https://docs.releng.linuxfoundation.org/projects/lftools/en/latest/release-notes.html
as one option.
Another suggestion is to submit changes as separate files that are then merged
after the pull request is approved.
Any automated system should document all the changes since the last
version and preserve links by to DOxygen documentation.
4c) JIRA
Jeff & Ken still have to sign into JIRA.
Ideally we have JIRA & GitHub integration. Most solutions seem to cost
money. Thanh will investigate what are practical as this may show
up for other ASWF projects. Ken will raise this in the next ASWF TAC meeting.
4d) Continuous Integration Update
Cmake transition is unclear. It seems other projects are waiting on
our decisions, so we may need to move first to cmake. Pushing to Jenkins
may be a way to trigger a push to Cmake.
Currently in process of increasing warning level in CI to match that at
DreamWorks so CI compliant checkins don't fail at DWA.
Interest in adding the Intel Compiler to CI; but the licensing implications
have to be determined.
4e) Code Coverage
There is a unit code coverage plugin that we need approval for.
Unanimous consent for installing CodeCov plugin (https://codecov.io/)
We also have interest in some form of tab/whitespace validation.
The DCO test has probot that seems to be able to handle these. However,
pre-commit was suggested as another option. It can also hook into
git-hooks so the enforcment can be done before CI.
5/6) Cleanup and Roadmap
A lot of time is spent on adminstration. When can we talk about the
actual product?
- Improve build time
- split up unit tests, avoid trailing tests
- Unit test coverage
- Documentation
- Cook books - completely out of date
- Source tree messy?
- Headers that define many classes
- Consolidate methods that do the same thing
- What are we planning on adding?
- Provide tasks
We resolved 20 minutes of next meeting to be devoted to roadmap.
7) The next TSC meeting is scheduled for Thursday Jan 31, 2019, 11am-12pm PST.
| 3,392 | Markdown | 29.845454 | 85 | 0.775354 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-07-07.md | Minutes from 55th OpenVDB TSC meeting, July 7th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees:
Bruce Cherniak (intel), Johannes Meng (Intel), Andre Pradhana (DW),
JT Nelson (Blender), Peter Cheng (DW)
Regrets: *Peter* C.
Agenda:
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Forum
Discussions about debug builds. There is advice on how to improve it, the
changes are agreed upon, the question is who will do it. This is to fix
multi-target cmake generators on Windows. The default version looks for debug
variants, the downstream is supposed select. This is showing up because we
finally have a working Windows build. We want to ensure we can still build
debug symbols on Linux with an optimized build.
4) CI Review
Now builds Houdini from actions cache. Seems to be mostly fine. One PR failed
to download so populated an empty cache. Added a check to avoid this. When
the download stops failing occasionally we can move from the Azure pipeline.
5) Sharpen PR
Lots of stuff has changed. Dan tried to rebuild back at the point it was
submitted, which also failed. So tried moving the branch, which was protected.
So tried to close and repoen. But this re-did the CLA test so failed. So
created a fresh clean PR for this. A few small changes but mostly getting it
compiling.
This re-introduced a boost dependency for a multi-array reference on a flat
array. We will have to remove this later.
There is now PR to work from. Ken to look at, skim the API, and add some unit
tests.
6) Fast Sweeping
Ken will go over the review comments today. Dan proposes that you can bucket
the slices without sorting. A particular leaf node, for example, has 21 slices
on the diagonal. So you don't need a list of indices to each slice. The
current system has a hash to slices. Ken is unsure if the details will hold
up. We should investigate this sooner after the PR is in.
Andrew Pearce is still proofing the PR from DW. Hopefully done by this week.
What is the best way to create a mask grid from a Houdini grid? There is a
boolean grid. If we use an SDF as a mask it would be confusing that the center
isn't filled. We should copy the VDB tools::clip that uses topology.
Andre is an author on a paper with another approach than fast sweeping, Ken and
him will investigate its applicability.
7) 7.1
For 7.1, we will aim to have Fast Sweeping complete. Or, put another way, when
fast sweeping is in we can release 7.1. We will not stress over vector
support, and not add to the SOP. Instead it will be up to the tool to support
it if it can.
8) PR 747.
We seem to be using the wrong attribute name here. This is a bad merge from
the Houdini side.
9) Merging Trees together
Originally did level-by-level merge. Now is an operator you pass into a node
manager. However, the node manager has a pre-cache so it can't modify during
building, but has to keep rebuilding. Proposal to add a for-each top-down
dynamic method that builds the cache at each level as you progress down. This
means the node manager now has two modes - flat and static, or dynamic. OTOH,
it always had a clear method. This is mostly a way to have a non pre-built
constructor. Is a node manager a reference to a tree? Or is it just a set of
leaf nodes? Maybe a dynamic node manager subclassing that does the auto
rebuilding? We note a lot of operations already have to be careful of node
managers, suggesting it is already a state machine.
Dan will create a PR and we will look at it.
10) Next meeting
Tuesday July 14th 2020, 1pm EDT (GMT-4)
| 3,611 | Markdown | 38.260869 | 79 | 0.759346 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-11-14.md | Minutes from 32nd OpenVDB TSC meeting, November 14th, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Peter* C.
Additional Attendees: Bruce Chernia (Intel), Daniel Elliott
Regrets: *Ken* M.
Agenda:
1) Confirm quorum
2) Secretary
3) Peter's Status
4) Const Grid Copying
5) PR 547: LOD Metadata
6) PR 548: Rename Translate
7) POPCNT.
8) PR 498: Install directory
9) VDB Points Merge SOP
10) Windows Update
11) Leaf Node Data
12) Meeting Time
13) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Peter's Status
With Peter's departure from DreamWorks he feels it is likely he will not
be able to contribute as much to the project. We note that DreamWorks
does not need to have a TSC member in order to attend the meetings, and TSC
members are to be active contributors. We unanimously agreed that Peter will
retain his TSC status for the next few months. At that time we will better
know how involved with the project he chooses to be.
4) Const Grid Copying
The PR to allow deep copy of only metadata or transforms was unresolved
due to disputes about how to name. We concluded that copyFrom was
too ambiguous and the consensus was copyGridReplacingMetadata
5) PR 547: LOD Metadata
We agree we need a more comprehensive solution. In particular, user
meta data tends to be lost. A common meta data is something to link
VDBs together that has to survive both .vdb and .bgeo export.
This particular PR is to be pushed, however, as the band-aid is better
than awawiting a fuller version.
6) PR 548: Rename Translate
Similar to PR547, the identified fix would be more righteous. But this
PR will keep in sync with Houdini pending such a better fix.
7) POPCNT.
It has been verified to be 40% faster. Compiler flags can
secretly undo the instrinsic, making it seem slower. We need a CMAKE
flag for SSE4.2 and AVX. We will have this off by default but turn
it on by default in the future. Dan will provide a step-by-step guide
of how to make the PR something we can bring in. Dan will also
offer taking over the PR and resubmitting if the author just wants
the PR in.
8) PR 498: Install directory
This has not been tested on other platforms. But as it adds the LIBDIR
tuple it might possible solve our install directory problem without
special casing.
9) VDB Points Merge SOP
The initial question was how to detect if grids are unique. This would
be a GU_PrimVDB::isGridUnique, which Jeff will investigate implementing.
This will not make the 18.0 gold window.
A bigger problem was discovered: the compile SOP world has an INPLACE
but no mode to let you steal all your inputs. For a many-merge VDB
SOP you want to steal all of them. It is possible the duplicateInputStealable
doesn't work properly for this (but it has been used in production) Jeff
is to look at the code and comment.
A VDB Merge Points will be done without the clever stealing, then we
can investigate how to fix Verbs to work with a steal all world.
10) Windows Update
Biggest hiccup for compiling on Windows was setting the 64-bit flag.
The set of PRs submitted should make this a lot more turn key. They
also remove the magic statics that aren't needed any more.
11) Leaf Node Data
We investigated if there was room to store data in the leaf node. In
particular, Ken wanted to free up 8-bytes as a general utility. We
knew we had 4 bytes at the tail, but it would be nice to future proof.
One idea is to have fileinfo always be present. If we don't purge
fileinfo once a node is paged in, we can then also move the mutexs
into the fileinfo structure. The absense of a fileinfo node is a signal
there is no need to use those mutexes. One concern is they may have
already been re-used as an internal flag in some algorithms, but
those may have just been planned uses.
A serious problem raised is that we don't have a good window for these
changes. It is likely too late for ABI 7, but we couldn't have done it
earlier as we were on ABI6. This suggests we should have these projects
sitting as PRs lying dormant until the start of a new ABI where we
can bring them in.
12) Meeting Time
The meeting will stay the same regardless of anyone's daylight savings. Some
confusion existed as it was often reported as EDT/EST. This means the default
time is now 2-3 EST.
13) Next Meeting
Next planned meeting is:
Novemeber 22nd 2019. 2pm-3pm EST (GMT-5).
| 4,391 | Markdown | 34.419355 | 78 | 0.77135 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-05-07.md | Minutes from 48th OpenVDB TSC meeting, May 7th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DWA), Bruce Chernia (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Google Summer of Code
4) ASWF TAC Meeting Update
5) Forum Posts
6) Promotional Videos
7) AX Presentation
8) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Google Summer of Code
The ASWF was only awarded three slots for all five projects by Google. OpenVDB
have given up their slot in favour of other projects which had stronger
submissions. There's motivation to collectively accept our best submissions as
each successful GSOC project will make it more likely Google will give us more
slots next year. Dan to reach out to our candidate(s) and encourage their
contribution or re-submission for next year.
4) ASWF TAC Meeting Update
Ken attended the recent TAC meeting and gave a quick summary. The ASWF is
looking to create an ASWF fund to help support developers affected by Covid19 as
many companies are scaling down or furloughing employees.
5) Forum Posts
Windows build should work now. Nick to reply to recent post which is related to
building the OpenVDB Houdini plugin on Windows using Python3.
6) Promotional Videos
Hard to find the time to assemble videos, but all see the value in doing so to
building the community and attracting new developers to the library. Ken
proposed that AX might be a good candidate.
7) AX Presentation
Nick gave an overview on AX. The plan for integration into OpenVDB is to start
with the core OpenVDB AX library, then look to tackle the tools and the Houdini
SOP soon after that. Some discussion about the level of integration. The key
question is whether it should be an option to the core library itself that would
require LLVM as a dependency or as a separate AX library that depends on the
core OpenVDB library (and LLVM). While the latter is the simplest, there are
some challenges. There is an extension to the VDB viewer that can support AX
which would result in a cyclic dependency chain. The Python module may also be
problematic with this model. General agreement that the unit tests should remain
part of the core library, but perhaps this is an opportunity to reconsider where
the binaries and Python module should live. With CMake now being the primary
build system, restructuring the library is easier. Decision is to continue with
AX being a separate library, but more discussion needed on the other questions.
8) Next Meeting
May 14th 2020. 2pm-3pm EDT (GMT-4).
| 2,642 | Markdown | 36.757142 | 80 | 0.789175 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-12-01.md | Minutes from 72nd OpenVDB TSC meeting, Dec 1st, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) 7.2.0 / 8.0.0 Release
4) Google Test Migration
5) Extrapolating Integer grids in Fast Sweeping
6) Next Meeting
1) Quorum was confirmed.
2) No secretary by accident, brief notes prepared by Dan Bailey
3) 7.2.0 / 8.0.0 Release
Dan to carry out 7.2.0 and 8.0.0 releases, Ken to do announcements. Work ongoing
to assess which PRs will make it into the 8.0 release.
4) Google Test Migration
Decision to adopt Dan's Google Test migration of core library to prevent it
becoming stale. Releases before the end of the year will still use CppUnit for
AX unit tests, Nick to revisit to migrate to Google Test in early 2021.
5) Extrapolating Integer grids in Fast Sweeping
Andre running into some problems attempting to extrapolate integer grids in the
fast sweeping. Right behavior should be nearest neighbor rather than an
interpolation.
6) Next Meeting
Next meeting is December 1st, 2020. 1pm-2pm EST (GMT-5).
| 1,132 | Markdown | 25.97619 | 80 | 0.757951 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-02-13.md | Minutes from 40th OpenVDB TSC meeting, February 13th, 2020, (GMT)
Attendees: *Ken* M., *Nick* A., *Dan* B., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Summary of annual TAC/ASWF meetings
4) Mres from Autodesk
5) Google summer of code - revisited
6) SIGGRAPH
7) Roadmap
8) GitHub Actions / develop branch
9) GPU discussion (unplanned)
10) Quick review of outstanding PRs
11) Next meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Summary of annual TAC/ASWF meetings
Ken presented an overview of OpenVDB and brief summary of the project activites
over the last year at the annual face-to-face TAC meeting. Not a lot of progress
this last year, main achievement has been CMake. Ken spoke to someone who might
be interested in helping with our CMake build system.
USD is a big focus of the ASWF, new working group being set up. Like us,
developers at Pixar are suffering from support burden from many studios building
the project and asking questions.
Security is still a concern.
4) Mres from Autodesk
Ken received version from Autodesk, will aim to get it building in preparation
for developing a VDB alternative starting sometime in the next month or so.
5) Google summer of code - revisited
Project proposals made and submitted as part of ASWF application, organizations
announced 20th Feb.
6) SIGGRAPH
Deadline has passed for a Course, however all agreed there should only be a BOF
this year.
7) Roadmap
Putting off until next meeting as Jeff has no mic. Intend for it to be a
dedicated meeting.
8) GitHub Actions / develop branch
The plan is to make the develop branch the default merge target for PRs. All
external contributors will make PRs into the develop branch and once approved,
one of the TSC members will take responsibility for merging into develop, adding
release notes and making any other edits, then making an additional PR from
develop into master. TSC members will predominantly make PRs directly into
master.
This will tie into adopting GitHub Actions as our sole CI and deprecating our
use of Azure. The develop branch will have fewer CI checks to attempt to reduce
the barrier to entry and will only run the Houdini checks if the user has set a
Houdini CLA environment variable. All TSC members will be required to set this
environment variable so that Houdini checks are always run when making PRs into
master.
GitHub Actions will also be used for other automation such as preparing releases
and keeping the develop branch synced up with the master branch.
Dan has a PR into the TAC to list requirements for one TSC member of each
project having admin access. Once permissions have been granted, this migration
can start.
9) GPU discussion (unplanned)
Ken has tried a linear read-only implementation of the grid for the GPU and it
works well. Considering extending to incorporate min/max. Question about making
just the topology read-only and allow value edits, not currently implemented but
should be feasible. Jeff very interested, Ken to share his implementation in the
next few weeks.
Still room to modify tree data structure to make it more amenable to the GPU, in
particular allowing for custom allocators (ABI change). Dan suggested we
dedicate one TSC meeting to focus on the GPU and invite some domain experts.
10) Quick review of outstanding PRs
PR605 - Ken happy for this to be merged.
PR455 - what to do with the sharpen, Nick suggests we integrate true gaussian
implementation first. Still waiting Ken approval.
PR623 - Jeff to review and give feedback.
PR589 - Nick has verbally approved, awaiting final approval from Ken.
11) Next meeting
February 20th 2020. 2pm-3pm EST (GMT-5).
| 3,744 | Markdown | 33.357798 | 80 | 0.789263 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2018-11-17.md | Nov. 15, 2018
Secretary – Andrew Pearce
Attendees – Nick A., Andrew P., Ken M., Jeff L., John M., Dan B., Peter C., Doug Walker
11:05 – Quorum achieved, all 5 TSC voting members on line
Ken Museth nominated as chair. Discussion of chair role & responsibility.
- Technical direction
- Press release
- Represent the project on the TAC
- Run TSC meetings
11:13 - Dan nominated, Nick seconded. Vote called. The TSC unanimously ratified Ken Museth as chair.
Discussion of Technical Charter
Discussion of CLA Corp. vs. Individual & DCO
There is a LF CLA system – John will follow up with info. For now – email CLA to email address on the site, one of the TSC can add them to the CONTRIBUTOR file at the head of the github repo.
One person from the company can state the DCO for other individuals, or each contributor can sign the individual CLA and be added to the CONTRIBUTOR file.
TSC needs to update the license file template at the top of files. Recommend to move to SPDX. Recommend not to add dates to the license header unless TSC wants to make massive changes every January 1.
Andrew will check with the notices change for file headers & copyright holders re: DreamWorks language.
John offered to provide a modified governance document that may cover initial needs.
Target for recurring meeting is Thursday’s at 11am-12pm Pacific. For now weekly, starting Thursday, Nov 29, 2018.
When is the next major release? Pressure from the VFX Ref Platform. A new release is not realistic within two weeks. Proposal for an API / ABI change release with light-weight functional changes to prepare for future changes without having to wait a year. Dan will ask VFX Ref Platform if OpenVDB can delay until early Dec to allow time for changes to be reviewed and stabilized for a release. Also will re-send the pull request discussion around to the TSC.
Ken will maintain and set future meetings.
12:10 PM Pacific, meeting adjourned.
| 1,937 | Markdown | 49.999999 | 458 | 0.780589 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-10-31.md | Minutes from 31st OpenVDB TSC meeting, October 31st, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M., *Peter* C.
Additional Attendees: Bruce Chernia (Intel)
Agenda:
1) Confirm quorum
2) Secretary
3) EasyCLA (PRs #227 #493 #498)
4) PR 537
5) OVDB-119
6) OVDB-122
7) OVDB-124
8) Refactoring Tree (OVDB-121 / PR536 + PR539)
9) OVDB-123 (Gaussian and principal curvatures)
10) Follow Up on Leaf Node Memory Usage
11) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) EasyCLA (PRs #227 #493)
Jeff confirmed that the EasyCLA has started working on his pull requests. We
are now in a position to start asking for contributors to update their PRs and
go through the automated CLA process. Jeff to follow up on PR 227. Dan to follow
up with PR 493 with additional comments about his brief tests. Nick to follow
up with PR 498.
4) PR 537
Changes confirmed by Peter. Jeff to re-trigger the build and then merge. There
seems to be no easy way to re-trigger builds through the github UI/API due to
the LF setup. Nick to mention this to John.
5) OVDB-119
Reported by Jeff, there is a reproducible case where level set construction from
a closed water-tight surface seems to be failing with artifacts similar to
those seen with failures during signed flood filling. Bringing this to the
attention of TSC members.
6) OVDB-122
Reported by Jeff, there was an issue with the way group membership was
transfered to VDB points from Houdini geometry, due to the mixed and incorrect
use of GA_Index and GA_Offet. Nick believes this was fixed in PR263 which has
since been merged. Jeff to check and report back.
7) OVDB-124
Reported by Dan, this is the result of a continued investigation by the TSC into
ways in which VDB tools are designed, primarily comparing tools which exist as
methods on the Tree to those that exist as free functions. This particular
ticket represents the only method (RootNode::addChild()) which has been
highlighted thus far to be missing for an example VDB merge free function which
would not have private member access. There were concerns that accessors that
are caching the current node being added may be referencing different trees
after the child has been set, however it was generally agreed that it is the
responsibility of whoever is providing the child to invalidate the accessor. Dan
mentioned that you are already able to set arbitrary nodes on Internal nodes by
leveraging the Tree Iterators setItem() function, however it was generally
agreed that this was not its intended public use and that, were we to pursue
this, we should consider adding methods to the InteralNode too. Some discussion
around the function name (addNode vs addChild), where addChild is only capable
of adding a child type. addNode is a more powerful method as it lets users add
any node type are the appropriate descendant location.
Discussion also around the addLeaf and addLeafAndCache methods. These exist on
the Tree and on the ValueAccessors. The intended use of addLeafAndCache is
mainly through the ValueAccessor API which ensures that a given ValueAccessor's
cache is updated to cache the descendant path to added leaf nodes. This is
intended to provide performance improvements on subsequent leaf additions which
reside within the same branch of the Tree. Noted that adding addChild methods to
the ValueAccessor which mimic those proposed to the RootNode would provide no
benefit as no branch traversal need be performed.
8) Refactoring Tree (OVDB-121 / PR536 + PR539)
Next TSC meeting to attempt to progress this discussion. TSC members to look at
both PRs. One additional thing to consider is what to do with other possible
counting methods which benefit heavily from better parallelization. General
consensus was that both methods could coexist whilst we continue this
investigation.
9) OVDB-123 (Gaussian and principal curvatures)
Ken's methods to compute principal curvature, Gaussian curvature and
disconnected components are almost completed. These will slot into existing
frameworks in VDB however an initial PR will most likely not expose them
to Houdini. The Gaussian curvature analysis also allows for computation of the
genus value of a given surface.
10) Follow Up on Leaf Node Memory Usage
Still some investigation to do here, but agreement that it is a priority due to
an ABI 7 release date approaching. Ken mentioned that his read-only Tree
implementation was able to cut down memory usage from ~90 to ~16 bytes.
Agreement that focus should be on ABI 7 changes for the next few weeks.
11) Next Meeting
Next planned meeting is:
November 14th 2019. 2pm-3pm EST (GMT-5)
| 4,652 | Markdown | 40.918919 | 80 | 0.795572 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-07-11.md | Minutes from 23rd OpenVDB TSC meeting, July 11, 2019
Attendees: *Dan* B., *Peter* C., *Ken* M.
Absent: *Nick* A., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), John Mertic (LF)
Agenda:
1) Quorum
2) Secretary
3) Round-Robin: Current and upcoming PRs
4) Graduation
5) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Round-Robin: Current and upcoming PRs
Ken:
Fast sweeping, value extension tool to be shared very soon. Initially this will
just be the core library implementation with subsequent discussion about the
right approach for a Houdini integration to follow.
Peter:
PR 455 - Some issues raised on the Sharpening PR that need consideration.
Optimization to repopulate stencil in Z-axis could be generalized to more axes
and extended to support jumps of more than one voxel. Also, Peter has been asked
by artists at DWA for a more generic convolution kernel and this PR could be
seen as a proof of concept of doing that.
Ken proposed (and has already implemented) an alternative technique which is
well established (actually dates back to the 1930s) and often referred to as
"unsharp masking". Peter wasn't able to get satisfactory results using this
technique, however that does not mean that it doesn't work - it certainly does
for Ken. However, it suggests that Peter might have found a better solution
which of course remains to be proven. Both methods are based on separable filter
kernels so Ken doesn't see why there should be a significant difference in the
computational efficiency, but cannot speak to the difference in quality since he
hasn't had a change to do a direct comparison.
The current implementation only works on level sets, but could be relatively
easily extended to support fog volumes and vector fields. Ken mentioned that
vector fields would be very useful to him. One option is to complete the current
PR and then introduce a new PR for the extension.
Peter didn't have access to his list of forthcoming work.
Dan:
PR 487 - Fixes CI issue where Houdini builds are skipped rather than fail when
run outside of ASWF Azure account. Trivial fix, anyone can approve.
PR 483 - Adds code coverage support to CMake, Nick currently reviewing. Minor
issue where code coverage takes a very long time to run (2 hours+) so can only
be run sporadically. A number of options to resolve this. Ken suggested running
the unit tests concurrently, though there may be issues if the tests themselves
run in parallel. Dan suggested using a smaller data set for some of the heavy
tests, perhaps with a flag that enables the more expensive tests for a less
frequent test run. Peter suggested using a mode that he added to the unit tests
where you can supply a file that defines which unit tests to execute. This
would allow for partitioning the tests into groups to be run concurrently
across multiple vdb_test processes.
All agreed there's lots of maintenance work to do around unit tests, improving
code coverage, breaking up some of the bigger tests like TestTools, etc.
PR 482 - An attempt to resolve the vulnerabilities reported by SonarCloud. Low
priority PR, merely included to start conversation. This adds a log or error to
empty catch statements based on whether they are expected to fail or not. Peter
commented that this might be problematic for the matrix inverse in particular,
Dan suggested we slightly refactor this one to not communicate with exceptions.
PR 479 - Meeting notes from last meeting, would quite like a meeting attendee to
approve before merge.
PR 464 - Unification PR. Peter to look into the spare data API and how to
retrieve a value previously inserted. Peter prefers exposing a non-const
OP_Table than communicating the labels to hide down into the OP_Factory, Dan to
change this.
PR 452 - Dan to address remaining feedback by adding syncNodeVersion support to
VDB Scatter SOP to be able to add position compression option now that spare
data API has been introduced.
PR 436 - Delay-loading PR. One remaining question from Peter about what happens
to the metadata when loading just the metadata in the VDB file as a preliminary
process to loading the rest of the file. Dan to investigate and reply to this
then Peter to do a final pass before we merge.
PR 402 - Peter to look into improving VDB SOP documentation, low priority item.
Main upcoming feature includes an extension to point moving to provide merging
grid functionality. Two options for exposing in Houdini, extending the VDB
Combine SOP and adding a new VDB Point Merge SOP. Dan presented Nick's argument
for the latter and all agreed that this is the better option considering compile
times and the existing node parameterization.
4) Graduation
Quick review of the graduation requirements. One remaining item needs looking at
before presenting for graduation - Steve Winslow has raised an issue in the
proprietary license notices included in the Houdini plugin, Dan to mail Jeff to
detail the specifics. Everything else seems in good shape, so hope to achieve
graduation before Siggraph.
Not necessarily a strict requirement for graduation but would be nice if all
could seek to sign the digital CCLA. Dreamworks and DNeg have already signed. If
the paper CLA that has been signed is not the Dreamworks-based CLA, but the more
recent one, this can be imported without needing to sign a new one. Send John
any signed paper CLAs to import if so.
5) Next Meeting
No meeting next week, next one scheduled for just before Siggraph.
July 25th 2019. 3pm-4pm EDT (GMT-4).
| 5,533 | Markdown | 43.629032 | 80 | 0.797217 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-04-30.md | Minutes from 47th OpenVDB TSC meeting, April 30th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DWA), Bruce Chernia (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Github protected branches
4) VDB Activate PR #692
5) Multithreaded File Compression
6) AX Update
7) Siggraph
8) Forum Posts
9) USD
10) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Github protected branches
All branches are protected. So as soon as you create a branch it can't be deleted. Only master should not be deleted.
Possible v3.3 and 6.2 branches should also be protected.
This showed up because we've started making branches on the master branch to hold changes. Unanimous consent to propose new rules for protected branches.
4) VDB Activate PR #692
Awaiting Ken's feedback. If he has not replied we can push it through tomorrow.
5) Multithreaded File Compression
Require big enough data sets to break into blocks. The grid's are working at too fine of a layer to benefit. We'd need to add a paging support to be able to coalesce the operations
6) AX Update
Most feed back has been addressed, other than the matrix issues.
A feature branch will be updated showing how it can be integrated on Nick's fork. Matrix is still an outstanding issue, specifically scalar matrix promotion.
CMake is still blocking this. Next week ideally will have demonstration.
Easiset way to build AX is to add LLVM to VDB as an option. This would allow VDB core to experiment with LLVM. However, the concern is that LLVM is hard to support so we should avoid locking down one version.
7) Siggraph
We have a BOF that will have to be virtual.
8) Forum Posts
Managed to defeat the Google UI and approve 15 people for the forum.
An issue with points docs was pointed out.
Our Vec3D code somewhere hard codes down to floats that needs to be fixed.
Question about associating grids together. 100 grids with same topology need duplicate accessors. Blind data could work. Or a way to get a linear node number into an offset table. We should reply and suggest solutions. The origin info in the node can be re-used as a blind data. This ties back to the float[N] grid type discussed previously. Dan will attempt to form a response.
9) USD
Some schemas exist already. They don't seem very VDB specific. Is there a problem we need to solve? Does VDB have to be more than an opaque volume format. As a render format, it doesn't need any over-operations. But what about USD as an interchange format? USD is a metadata format, so VDB can live within that without needing to be exposed at the USD level. What are images in USD? They seem to be references to file on disk.
10) Next Meeting
May 7th 2020. 2pm-3pm EDT (GMT-4).
| 2,862 | Markdown | 37.689189 | 434 | 0.7645 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-08-25.md | Minutes from 62nd OpenVDB TSC meeting, Aug 25th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Bruce Chernia (Intel), Andre Pradhana (DW), Ahmed Mahmoud
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) Siggraph Recap
5) Roadmap
6) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Forum
Ken to reply to post about large VDBs/OOC.
4) Siggraph Recap
Good response from the ASWF Open Source days, presentations are now live. Good
idea to present the roadmap. Multiple questions w.r.t NanoVDB vs GVDB, it would
be good to clarify to the community the differences and scopes. Ken, comparing
the two directly is difficult.
ASWF forum vs Google forum question - unclear reply. We should dedicate a
meeting soon to come up with a stance. Dan is monitoring the ASWF slack. We
could deprecate the google forum. Ken, would be a shame to lose users. TBD.
5) Roadmap
We only have a few months for a 7.2/8 release window. Ken, main focus is
NanoVDB, Nick, main focus is AX. AX is ready to go. OpenVDB repo needs some
adjustments before a PR can be made. Ken, feature branch approvals is
frustrating, Dan to investigate if it can be removed.
Dependencies are a big focus. Ken, NanoVDB uses a utility header/wrapper around
TBB to abstract away the implementation. Dan, all we need is a threaded/
non-threaded switch to begin with and users can subsequently implement their
own threading constructs. Nick, TLS constructs are slightly tricker. The wrapper
should all be task based threading which provides an interface for others to
extend. All agree this is a worthwhile investment to port to OpenVDB. Dan to
investigate some of the other dependencies - primarily zlib, half and boost
(w.r.t delay loading). Need to make sure not to break ABI with any delay loading
changes. However ABI 8 could provide a nice opportunity for more substantial
change. All skeptical of how useful the per leaf delay loading granularity
thats currently implemented is - it convolutes the tree. Lots of work in this
area, no obvious/agreed on solution, though enabling/disabling through an
optional dependency is a good start.
Makefiles, vote to remove. Unanimous consent. Nick to action.
Bump to CMake 3.12. Unanimous consent. Nick to action.
Look over deprecated code for removal for 7.2/8.
Pruning of tree methods. Dan, proposed new CSG methods make a bunch of methods
(primarily the visit methods) obsolete and could be deprecated. All agreed that
this concept is still worth pursuing. Dan, once this PR is in, can contribute
the Merge SOP.
Locking down the tree structure. Non-obvious timeframe, would most likely be
significant work. Jeff, for VDB 8, see if we can make it harder for this to
be customized or to build in compiler warnings for users who are doing so.
Tile support for all tools. Ken, there's no one size fits all - each tool will
treat tiles differently. Nick, will push an extension to Filter.h which supports
tiles. Ideally this should be generalised such that all tools can call the same
tool to configure tile topologies. Indirect goal to remove the Densify SOP.
Andre, continuing to work on the Extrapolate SOP for 7.2/8. Seems to be a
problem with extensions of non-float grid types. Andre to provide an example to
Ken to fix.
Ken to take another look at the sharpen PR #756 and merge.
Nick, Morphololgy PR #754 is ready for review and can be targeted for 7.2.
JT, preparing a demonstration of VDB in blender, both on master and other more
experimental features.
Dan, will merge CI changes.
Dan, release notes conflicts are still annoying. Jeff, can we implement custom
conflict rules for github. All agreed this would be ideal, but unsure on
githubs support for this. Dan to investigate.
In future meetings, we should discuss how to better organise the roadmap for
"good first issue" tasks to on-board more developers.
6) Next Meeting
September 1st, 2020. 1pm-2pm EDT (GMT-4).
| 4,028 | Markdown | 39.29 | 80 | 0.780288 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-08-22.md | Minutes from 25th OpenVDB TSC meeting, August 22, 2019
Attendees: *Nick* A., *Dan* B., *Peter* C.
Absent: *Ken* M., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), John Mertic (LF)
Agenda:
1) Quorum
2) Secretary
3) CMake / CI updates?
4) SPDX changeover
5) Upcoming Point Partitioner refactoring
6) Modifying deprecation policy
7) Where to start with modifying Tree classes
8) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) CMake / CI updates
Windows builds are still an issue. We believe this is due to the manual system
path setup which omits windows and disables CMake's automatic path detection
when given a toolchain file. The README should be updated to clarify the build
instructions listed are a starting point for CMake builds, intended for users to
be able to iteratively run and react to any CMake warnings/errors presented.
Nick believes PR #504 will help resolve some of these issues but there are some
outstanding questions with the implementation. Nick to continue to investigate.
CLA/PRs
Some PRs are becoming stalled on the CLA. All TSC members to chase/ensure they
have signed the digital LF CLA.
Older PRs/github issues are becoming awkward due to new submissions superseding
or re-implementing them. In the next TSC we should decide on a system for
closing or declining unresponsive or old PRs/issues.
4) SPDX changeover
Peter to take the lead on this change due to DreamWorks owning the current
license. Dan to provide Peter with examples of the requested changes that need
to occur. Chat links:
Dan: https://github.com/imageworks/OpenColorIO/pull/799
John: https://github.com/AcademySoftwareFoundation/openvdb/blob/master/LICENSE
John to start a discussion with DreamWorks legal on the migration to SPDX.
5) Upcoming Point Partitioner refactoring
Dan working on a refactor to the internals of the current point partitioner to
better work with OpenVDB Points. Currently it requires a two pass system (for
VDB Points) which isn't ideal. There are also a number of C++11 improvements
which can be made. Nick asked if the changes also benefit arrays of positions
(non VDB Point data). Dan reported faster performance with linear arrays.
6) Modifying deprecation policy
Discussed adding deprecation warnings in the next releases of VDB. VDB 6.2.0
will be the last supported VFX17 release which should introduce all related
deprecation warnings based on the VFX18 requirements. VDB 7.0.0 planned to bump
all minimum versions to the VFX18 platform (notably C++14). Support for ABI 2,
3, 4 and 5 to be maintained until VDB 7.0.0, with the plan to remove them at
the end of the year.
7) Where to start with modifying Tree classes
Discussion around the free function vs base (untyped) member function
implementation of grid/tree methods (prune, clip, topologyUnion etc). prune and
clip are interesting cases as they live on the untyped base version of the grid
object. This delegates runtime branching of the grid type to the virtual
function table rather than forcing the user to perform boilerplate switching on
unknown grids. This is particularly useful for the clip method which is used in
file IO. It's unclear whether we should continue to remove these methods because
of this. Methods that live solely on the typed derived classes can more easily
be moved into standalone header/free function combinations. However a decision
should be made as to how we want to leverage the base class API before we
consider this, as an argument could also be made to make some of these methods
on the derived grid/tree also available as pure virtual methods on the base
class. Discussion to continue.
8) Next Meeting
August 29th 2019. 3pm-4pm EDT (GMT-4).
| 3,721 | Markdown | 39.901098 | 80 | 0.795754 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-03-28.md | Minutes from 12th OpenVDB TSC meeting, Mar. 28, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C.
Additional Attendees: Andrew Pearce (DWA), Thanh Ha (LF)
Apologies: *Jeff* L.
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) TAC Update
4) Multi-Res Grid
5) Out-of-Core Read-only Grid
6) Instantiation / Compile-times
7) Tools vs Grid Methods
8) Release Schedule
9) CMake/CI Update
10) Improve / Update Cookbooks
11) CLA Check
12) Update Website
13) Documentation on how to file bug-reports or ask questions
14) Grid Iterator Performance
15) Next Meeting
1) A quorum was confirmed. Ken was phoning in, so Dan chaired.
2) Secretary - Dan Bailey
3) TAC Update
No-one available to represent OpenVDB in TAC Meeting the day before. Dan sent
Daniel Heckenberg a brief summary of OpenVDB updates which were shared. Thanh
gave a brief update from the TAC Meeting. The ASWF board are in support of using
Circle CI but remain interested in being able to provide reproducible builds
outside of Circle. Thanh also announced he was leaving the Linux Foundation for
a startup. Andrew Grimberg is taking over his responsibilities and is already
up-to-speed. It is envisioned that Andrew will attend the TAC and CI working
group meetings, but likely not the project TSC meetings.
4) Multi-Res Grid
Ken has received a comprehensive response from Autodesk answering the TSC
questions regarding Autodesk's proposal for introducing the Multi-Res Grid to
OpenVDB. He will be sending it around to the group shortly for discussion in the
next meeting. First impressions look promising.
5) Out-of-Core Read-only Grid
Ken has a working implementation of an out-of-core VDB grid. It is read-only,
supports random access with a pre-defined fixed memory footprint and can be
built from a standard out-of-core VDB grid. A fully out-of-core VDB grid
requires half the memory footprint of a standard VDB grid in out-of-core mode.
Savings are also possible through not supporting very old file formats. Ken
plans to release at Weta and then to look to introduce to the OpenVDB codebase.
Some concerns from Peter and Dan about introducing a new Grid structure, but
keen on understanding more of the implementation details.
6) Instantiation / Compile-times
Compilation of applications and plugins built against OpenVDB is slow and uses a
lot of memory, which we wish to address. Peter wants to consider baking the
configuration of the grid so as to improve compilation times and suggests asking
users whether they ever change the grid configuration. Ken mentioned that he
knows people change the size of the leaf node for GPU and other uses, but
unaware of many people changing the configuration of the tree. He wants to find
out if this is a consideration for Autodesk's Multi-Res Grid. Potential
investigation around where the compilation time is going could help direct our
efforts. Explicit template specialization also worth looking into.
7) Tools vs Grid Methods
Over time, there has been a gradual migration towards using free functions in
the tools directory instead of adding to the Grid and Tree classes. Question of
whether it's a good time to introduce a policy around this and to look at
removing some of the Grid and Tree methods. Ken proposed that the first step is
to look at all the methods and confirm whether they can currently be removed or
whether they need new access functions to be able to remove them. This change is
also expected to improve compilation times. Removing virtual functions needs to
be done in a major release, so they would need to be marked deprecated in a
prior release.
8) Release Schedule
Peter proposes we do a new release in the next few weeks. It was decided that
the next release should be 6.1.0, as there is a lot of new functionality and
some of the changes appear that they may affect the API. Unanimous vote in
favour. Potentially hold off to ensure we can include CMake changes. Peter
proposes adding static casts to fix the precision warnings as a temporary
solution so that we can make this release compile with strict mode enabled
without behavior changes. Ken proposes another minor/patch release shortly
before Siggraph. Rough plan is to do a new 7.0 release in September / October
which changes ABI, so we should start gathering ideas now. This new major
release can also be when we mark methods as deprecated that we intend to remove
in early 2020.
9) CMake/CI Update
Nick gave an update on his progress with refactoring CMake, his stage branch
contains further improvements. Main issues are around IlmBase/OpenEXR version
suffixes and case-sensitivity of CMake modules. Peter is currently testing with
DWA infrastructure and has run into a few issues, particularly around GLFW. Dan
has added CircleCI support which now builds all third-party dependencies from
scratch. More testing to come. Dan proposes changing the syntax, Nick suggested
after this PR gets merged is a good time. Peter asked about improved ways to
help users build against OpenVDB instead of using openvdb_print, Dan suggested a
"Hello World" sample might be a nice way of getting people started. Nick says
there is still some work needed on introducing a CMake module and improving the
find package mechanism for building against OpenVDB.
10) Improve / Update Cookbooks
Dan suggested building the cookbooks as part of the CI. Peter and Ken proposed
instead turning the cookbook examples into samples modeled after the SideFX HDK
samples with links from the documentation where relevant.
11) CLA Check
Thanh says to follow up with John regarding the progress of this.
12) Update Website
Website originally designed by Mihai Alden, needs some updating. All present
should seek permission for images from their respective studios to add to the
website with the aim for an update to be completed by Siggraph.
13) Documentation on how to file bug-reports or ask questions
General desire to keep Google forum around to avoid having to ask 600 or so
users to re-subscribe. Need a proposal on what to do with other communication
mechanisms such as GitHub issues and mailing lists. Dan to do a first draft of
changes to contributing.md.
14) Grid Iterator Performance
Dan raised performance issues with the grid iterator. When used in
tools::extrema(), it represented as much as 30x performance differential. Ken
mentioned that it's a significant problem and often his first question to a user
asking about performance is around which iterator they are using. The main issue
is poor ability to split when threading. Peter highlighted that this iterator
was designed for convenience, not performance and that performance varies based
on the use. Ken believes people are using it by accident without realizing the
performance consequences and better documentation wouldn't necessarily address
this. Two potential solutions were discussed - removing the grid iterator
entirely and re-writing it to offer a faster, underlying implementation.
15) Next Meeting
Our next TSC meeting is scheduled for Thursday April 11, 2019 11am-12pm PST.
| 7,074 | Markdown | 45.546052 | 80 | 0.804213 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2021-01-19.md | Minutes from 76th OpenVDB TSC meeting, Jan 19th, 2021, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Richard Jones (DNeg), Bruce Chernaik (Intel),
Laura Lediaev
Regrets: *Peter* C.
Agenda:
1) Confirm Quorum
2) Secretary
3) AX
4) Andre joining TSC
5) Images
6) TAC Survey
7) VDB Activate SOP
8) CSG Intersection Bug
9) Inline Half
10) Next Meeting
1) Confirm Quorum
Quorum is present.
2) Secretary
Secretary is Dan Bailey.
3) AX
Nick looking to get PR931 merged as soon as possible. This is the last piece
that requires maintaining a separate DNeg repo which is time-consuming.
Attributes to create needs fixing so that it includes pattern matching. Jeff
suggests looking into using UT_String::multimatch() for this.
Active tiles should be densified by default, as constant tiles should be
primarily considered a space-saving optimization and not affect which data gets
evaluated. Easiest solution is to globally densify and constify. Better approach
would be to stream - densify and constify each tile in turn as it's processed -
this is more challenging to implement but would likely reduce memory footprint.
Easiest solution is likely most appropriate here as additional optimization can
be performed later without changing behaviour.
Currently, a missing attribute errors on read. This is different to how VEX
works, which errors on write but not read.
There should not be a mode for running over inactive voxels. For now, acceptable
to include a compile guard to disable this option.
4) Andre joining TSC
Ken has reached out to Peter Cucka and Peter agrees to allowing Andre to replace
him on the TSC. Motion to make Peter an Emeritus TSC member, update the website,
remove him from GitHub OpenVDB group membership and as an OpenVDB code owner. 4
of 5 TSC members approve. Peter not present, but approved offline.
Andre Pradhana accepts the invitation to become a TSC member. Will follow up
with DWA leadership.
5) Images
ASWF has obtained a few more OpenVDB images from studios, still need more. Andre
believes DWA may be able to contribute some new images.
6) TAC Survey
Ken has requested an OpenVDB-specific survey to the TAC, as the most useful
questions appear late in the ASWF distributed survey.
7) VDB Activate SOP
Deactivation is a slow, single-threaded method. Jeff believes it may have
existed prior to tools::deactivate() but is in favour of switching it out.
8) CSG Intersection Bug
Jeff has reported a bug in the new CSG Intersection method and had to roll back
Houdini 18.5 to 7.1 as a result. Dan to investigate and look to release 7.2.2 /
8.0.1 with the bug addressed.
9) Inline Half
No objections regarding licensing from TAC.
Lots of questions regarding the correct level of integration of Half. It would
be preferrable to be able to swap out an embedded OpenVDB Half implementation
with the third-party library to easily test and adopt improvements, however this
is not trivial to achieve. Jeff's PR embeds Half in openvdb/math and uses an
openvdb::math namespace. This means we are essentially forking the
implementation for OpenVDB. Is this a problem? Not much has changed in Half in a
long time, though there are ongoing plans to update it. Not simply a matter of
changing the namespaces as we also wish to bake the auto-generated lookup table.
Half support is coming in C++23, but it will take a long time before we can
adopt that. Also, there is potential to switch to using Imath as a math library
in the future. Would this affect the decision here? Conversation ongoing on the
PR about the right approach to take here.
10) Next Meeting
Next meeting is Jan 26th, 2021. 12pm-1pm EST (GMT-5).
| 3,752 | Markdown | 34.40566 | 80 | 0.784648 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-10-13.md | Minutes from 65th OpenVDB TSC meeting, Oct 13th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) AX Follow-up
5) Filter Tile Support
6) Paged Array Segfault
7) USD Support
8) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Forum
One question on the forum about using Visual Studio and CMake. No-one in the TSC
has much experience in this area. Still might be useful to post that we don't
know the answer and encourage others in the community to comment. D&I group are
looking at how to improve onboarding. Many people who use OpenVDB through
Windows use vcpkg rather than compiling from source.
4) AX Follow-up
Nick to review all feedback. Will take a while to get through everything,
priority is the core library at the moment. SOP feedback will follow.
Int conversion is proving tricky. No JIT compilation based on the type in VEX.
In AX, there is a separate accessor per-type, so hard to resolve integer issues.
Most likely route forward is to introduce explicit integer types for bindings
and then in future turn these into an alias to make them all int. That would
avoid backwards compatibility issues.
Looking for alternatives to running over inactive values, however Nick relies on
this mechanism heavily. Jeff prefers the ability to provide an optional stencil
mask as an optimization.
Don't use VEX language editor, not only will it highlight syntax incorrectly,
but it will reference the VEX documentation. Currently no hooks to introduce a
custom language editor in Houdini. Easiest route is likely to incorporate this
into VDB then let SideFX introduce a new language editor when natively
integrating AX into Houdini.
5) Filter Tile Support
Nick has submitted a PR to add tile support to the filter methods. It eliminates
tile artefacts in smoothing.
6) Paged Array Segfault
Nick has reported a number of sporadic segfaults related to the PagedArray data
structure. Last instance of a segfault in PagedArray was fixed by switching from
vector to deque. May be related to a standard library implementation offering a
deque implementation that is not thread-safe. However, there does not appear to
be any pattern in compiler, standard library or platform.
Nick to provide Ken with a bit more data to help try and track down the root
problem.
7) USD Support
All agreed that it could use some work as the current VDB integration is fairly
basic.
8) Next Meeting
Next meeting is October 20th, 2020. 1pm-2pm EDT (GMT-4). Dan to present PR785
for discussion and review.
| 2,716 | Markdown | 33.392405 | 80 | 0.787555 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-07-21.md | Minutes from 57th OpenVDB TSC meeting, July 21st, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), Bruce Chernia (Intel),
JT Nelson (Blender), Peter Cheng (DW), Andre Pradhana (DW),
Robin Rowe (Cinepaint), Roman Zulak
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum Issues
4) Windows/Blosc Issues
5) Fast Sweeping
6) #739
7) Merge/Dynamic Load Manager
8) 7.1 Deadline
9) AX Merge
10) Next meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Forum Issues
None to discuss
4) Windows/Blosc Issues
Ken, issues at NVIDIA with OpenVDB reading/writing examples files with blosc
compression (on Windows). Believe to be related to blosc setup but, as they're
confident 1.5 is being used, it could be something else. All agree that an
investigation into blosc versioning is a major issue. NVIDIA to open up an issue
with more information for us to diagnose.
5) Fast Sweeping
Dan, performance improvements have been completed and discussed with Ken.
Between 2-4x faster, however it does use more memory - this along with some
minor additional improvements remain but can be completed at a later date.
Remaining work mostly related to the return behaviour and type of the available
free functions. Discussion around the automatic termination behaviour of some of
the methods. Ken to investigate adding tolerance controls to detect increases
(or negligible decreases) from previous iterations and exit accordingly.
6) #739
PR to change the attribute transfer field on the VDB From Polygons SOP to a
string field with some common defaults as options. Dan, added point.v as a
default, perhaps point.Cd/.N should also be added? All agreed that the main
use of these drop down options are to educate users on how to specify
attributes and we can add more options later. Dan, confirmed that the PR will
not break existing scenes. Dan to merge as is.
7) Merge/Dynamic Load Manager
Dan, still investigating how best to provide this support. Tests with perfectly
overlapping SDFs perform significantly faster than the current NodeManager,
however completely non-overlapping SDFs are slower as they still need to iterate
over all levels of the tree. Could design user functors to return true or false
if subsequent iteration is required, however it would be nice if functors could
work with any NodeManager. Discussed free-function support in the context of a
merge header. Dan, could provide signatures which behave differently on const
presence. Concern that this behaviour is too obscure to users and may cause
unintended results when user implementation changes. Questions as to where this
functionality should live; in a dedicated Merge header or in the NodeManager
header.
8) 7.1 Deadline
Deadline for 7.1 changes set to 2 weeks from today (deadline 4th August).
9) AX Merge
Whilst all TSC members still want to work towards an AX merge for 7.2, may have
to consider the possibility of delaying either the 7.2 release or AX depending
on TSC review time. Nick to also contribute the AX Houdini SOP as part of the
initial AX merge.
10) Next meeting
July 28th, 2020. 1pm-2pm EDT (GMT-4).
| 3,191 | Markdown | 35.272727 | 80 | 0.787841 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-12-05.md | Minutes from 35th OpenVDB TSC meeting, December 5, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional Attendees: Andrew Pearce (DreamWorks), Daneil Elliot (Weta)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Outstanding 7.0 Items
4) PR568
5) PR578
6) Optional build dependencies/Thread pools and TBB
7) VDB Merge SOP
8) Roadmap discussion
9) OpenVDB Blog post by Emily
10) Website Logos
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
Update by Andrew with TSC recommendations from DreamWorks. The TSC has discussed
with Peter C his desired involvement going forward, with the plan being to wait
a few months to gauge how active Peter would be. Andrew confirmed that no one at
DreamWorks is currently in a position to replace Peter as a TSC member. All
members of the TSC express lots of interest for more people to contribute to all
levels of the project.
3) Outstanding 7.0 Items
An issue exists with PR 536 (merged), where virtual methods introduced to the
Tree have not been guarded in an ABI clause. This produces crashes when VDBs
created in other applications prior to these changes are passed to custom
builds. These needs to be fixed before the 7.0 release. Ken to fix and push up
changes, Nick to release once this has been tested and confirmed. All members in
agreement that we should investigate ABI tests (OVB-118).
4) PR568
Needs an additional approval before merge.
5) PR578
Houdini 18 now requires a license when certain functions from its CMake modules
are used (as they run hython). Our CI can work around this by manually providing
an install path. Questions raised whether using hython here is necessary.
6) Optional build dependencies/Thread pools and TBB
It would be nice if as many as possible of OpenVDB's dependencies were optional
(tbb, zlib, ilmbase, openexr, boost are not). Specifically with TBB,
generalizing our threading infrastructure would be extremely useful. A shared
utility header/some other type of higher level abstraction providing common
macros/links which can be used to implement custom schedulers or even completely
disable threading would help provide more custom control over multi-threaded
methods. Note that the C++ committee is currently working on a TBB "replacement"
(executors), but this is not expected to arrive until C++20.
7) VDB Merge SOP
Dan proposing a merge SOP which merges all types of volumes. This could
incorporate a subset of the combine SOPs features, the most obvious of which
would be union type functionality. There currently exists a Vector Merge SOP
which will be confusing. Initial TSC reaction positive, Dan to put together a
more detailed proposal.
8) Roadmap discussion
Discussion to be delayed until after release. AX mentioned as a significant
contribution, Nick is looking to priorities this.
9) OpenVDB Blog post by Emily
Not many exciting things to include for a blog post bar those we've already
mentioned. Consensus was that if we could wait until next year that would be
ideal.
10) Website Logos
Consensus that we shouldn't shy away from reaching out to companies who release
software with VDB support with logo requests. The VFX platform logo should be
last on the list on the website. Ken to reach out to some vendors.
11) Next planned meeting is:
December 19th 2019. 2pm-3pm EST (GMT-5).
| 3,354 | Markdown | 35.868131 | 80 | 0.790698 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-05-30.md | Minutes from 18th OpenVDB TSC meeting, May 30, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: John Mertic (LF)
Regrets: We have no regrets.
Agenda:
1) Quorum Secretary
2) Secretary Selection
3) CI Update (Dan)
4) CLA Update (John)
Non-Planned A) Siggraph
Non-Planned B) Floodgates
5) Mainline Remote Branches (Nick)
6) Switch to Relative Header Paths (Peter)
7) OpHiding Next Steps (Dan)
8) GitHub Issues Cleanup / Process for Submitting Bug Reports (Nick/Jeff)
9) VDB Delayed Loading (Dan)
10) Maya Plugin (Nick)
11) Level Target Pruning/Voxelization (Nick)
12) Speed of hasActiveTiles/voxelizeActiveTiles (Nick)
13) Schedule Next Meeting
1) A quorum was confirmed
2) Secretary - Jeff Lait
3) General concerns and remarks about the project (Ken/Peter)
A wide ranging discussion about the state and purpose of the VDB
project was held. The rate of PRs has made it difficult to
adequately review them, and people are feeling rushed into
approval. There also doesn't seem to be any real "meat" to
show for all the PRs - the 6.0 and 6.1 releases don't seem
to generate a lot of attention to users as they seem to involve
no new exciting features.
We agreed it would be good to use the TSC meetings to discuss
upcoming plans rather than administration. In particular,
we could prioritize what features are coming rather than just
having them appear suddenly.
Different opinions are held on whether a release needs to have
any major features. The majority opinion holds that the users
don't care about version numbers, so we shouldn't hold ourselves
to any release cadence. The minority feels that without press-release
relevant features VDB may fall out of favour.
We agreed that part of the TSC meetings should be dedicatd to
actual feature discussion. One proposal was to alternate the purpose,
another was to have a fixed timeslot reserved for this to avoid
being crowded out.
It is acknowledged that some PRs will inevitably come out of the
blue as they are from production rather than TSC needs. Likewise,
bug fixes are unlikely to have any advanced notice. But where
possible we would like all feature PRs to be announced at a TSC
meeting to give the other members an advanced notice of what
might be coming down the pipe.
It is planned to do explicit roadmap discussion at Siggraph this year.
4) Plans for v6.2 (all)
No precise date is present at the moment. Siggraph is still a
tentative date. Integration with Houdini++ likely requires
a release around that date.
It is expected that AX will exist as a feature branch by that point.
Action Item: TSC members are to make a short list of contributions
they plan for Siggraph by next meeting.
Non-Planned A) Siggraph
The course appears to be a go ahead, the issues with course
notes seems to have been addressed.
There will be a Birds of the Feather with two blocks devoted
to VDB.
Non-Planned B) Floodgates
It was noted that if we start getting external contributions, we
should keep in mind to groom potential future maintainers.
5) Response to Autodesk (Ken)
Not done yet. Being worked on. Should meet with them at Siggraph.
6) Memory pools and custom allocators (Ken)
Should we add memory pools and custom allocators to our
tree structures? Useful for host/device and out-of-core computations.
Needs to be somehow backwards compatible.
7) CII badge status (John M)
It is important not to overthink these badges.
The bug reporting would likely be solved by Nick's planned progress.
No one wants to volunteer to be known as the security expert.
MITM attacks are likely handled by github's distribution model.
8-12) Time
13) Schedule Next Meeting
June 6th 2019. 3pm-4pm EDT (GMT-4).
| 3,731 | Markdown | 31.452174 | 73 | 0.778344 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-06-20.md | Minutes from 21st OpenVDB TSC meeting, June 20, 2019
Attendees: *Nick* A., *Dan* B., *Peter* C., *Jeff* L., *Ken* M.
Additional Attendees: Bruce Chernia (Intel)
Agenda:
1) Quorum
2) Secretary
3) Siggraph planning
4) PagedArray unit test fix
5) SOP unification and hiding
6) SOP tab sub-menu and suffix
7) Static Pointer Memory Leaks (PR 227)
7a) CI Update
7b) Houdini status
8) Memory Allocators
9) VDB Points MMB bug (OVDB-100)
10) Speed of hasActiveTiles/voxelizeActiveTiles
11) GCC and Dual ABI
12) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Siggraph planning
We have a dedicated meeting slot in the BoF for discussing development
issues rather than as an open forum. The plan is Wednesday 11am-Noon
to discuss with Autodesk the MultiResolution issues.
With both a course and a BoF, it is unclear how to handle the BoF. Less
need to just dump new updates as the course will cover that. "What would
you like to see?" was a goo conversation starter in the past. Previous
answers were Multi Res and Delayed Loading.
4) PagedArray unit test fix
Still trying to build a PR for this. Unfortunately, git is very
painful to work with. Might end up just being a patch forwarded.
gitk is listed as a good tool to figure out what git is trying to do.
5) SOP unification and hiding
We now have separate PRs for both adding spare data to OP_Operator
and for creating a pythonrc to do the hiding. Consensus is both the
env-variable and pythonrc can go in as the overlap has been minimized.
It would be a good if it triggered a warning if you turned both on.
The SpareData technique should be adopted by Houdini some day to allow
generic sparedata on all OP_Operators. RFE: 97588 has been submitted
for this.
The environment variable should match the pythonrc, so be a three way toggle.
CMake should let you set both, but with a warning that you likely will
confuse yourself.
6) SOP tab sub-menu and suffix
Previous default menu was Custom. Instead, by using a named menu we
can ensure conflicts get a suffix automatically. ASWF isn't a good
top level menu as no one will know to look in it. Renaming nodes is
finicky, so consensus is the tab suffixing is a better approach to
deal with ambiguity.
Bug: 97465 for suffixes not working has been fixed in 17.0.620, 17.5.295.
7) Static Pointer Memory Leaks (PR 227)
This is a long standing PR from Autodesk. We should at least answer.
It wasn't merged because older versions of MSVC did not conform to C++11
for function statics. It also isn't a memory leak, as it will be
freed on destruction in either case. Further, destruction order causes
its own risks so safest to not delete. OTOH, C++11 is now a requirement
and going forward we can support function statics.
Next version will be C++14 so this implies 2017 MSVC. We should
state this on the upgrade.
While this PR isn't necessary, it would be a good test for the new CLA
process. Jeff will comment on the PR and ask them to wait for the
CLA mechanism to be active.
7a) CI Update
Switching over to a host repository on a ASWF docker. This will have
a pre-installed CentoS7 with all the dependencies pre-built. All is
working except the Houdini install. Installing glfw is problematic,
however. Bumping glfw (which is only used by vdbview) to a higher version
will likely simplify. Unanimous consent to bump to 3.1 to match
Ubunut 16.04.
Minimum is currently 3.0. But 3.1 is what you get with apt-get. However,
vdbview crashes on close with unpatched glfw due to EGL problems.
Recommendation is 3.3.
7b) Houdini status
Attempt to upgrade HEAD Houdini to latest VDB ran into a problem with
the VDB Clip changes. The question of if primitive attributes or vdb
metadata should be authoritative when processing SOPs (and when processing
VDB code) is thorny and error prone. In this case, file_bbox is generated
on save to .bgeo streams. So reloaded .vdbs have the value as metadata
and do not have matching primitive and vdb data. Interestingly,
file_bbox is off in the open source build. Should it be on by default
in all builds?
8) Memory Allocators
Discussion at Siggraph on memory allocators and file format changes.
9) VDB Points MMB bug (OVDB-100)
Jeff Lait is to look at this.
10) Speed of hasActiveTiles/voxelizeActiveTiles
Time
11) GCC and Dual ABI
Time
12) Schedule Next Meeting
June 27th 2019. 3pm-4pm EDT (GMT-4).
| 4,405 | Markdown | 33.155039 | 77 | 0.772077 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-04-09.md | Minutes from 45th OpenVDB TSC meeting, April 9th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Peter Cheng (DW), Andre Pradhana (DW)
Regrets: *Peter* C., *Dan* B.
Agenda:
1) Confirm quorum
2) Secretary
3) OpenVDB AX recap
4) Forum/Github Issues update
5) Plan for Improved Morphology
6) Google Summer of Code
7) CI Updated
8) VDB Activate/Activate SDF
9) OVDB-136
10) OpenVDB & USD
11) Next meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) OpenVDB AX recap
Discussion ongoing between Nick and Jeff as various AX features are nailed down.
A number of proposed changes have been approved - bitwise operations on
integer vectors, restricting comparison operation on container types and correct
implementation of fmod. Two outstanding requests are the beahviour of
matrix and scalar operations and container (vector) extension. Jeff's preferred
behaviour for the prior is to treat scalar promotion as an identity matrix
with its identity components set to the corresponding scalar. For the latter,
VEX currently extends vectors with a value of one to better match the behaviour
of various applications against matrices of otherwise incompatible sizes and to
better correspond to a default value of colour (alpha) or homogeneous coordiante
(w). The alternative would be to explicitly error on this behaviour. AX
currently already errors on assignment of containers of mismatching sizes.
4) Nick proposed that every TSC meeting additionally begin with a quick recap
of newly opened forum posts or github issues. Unanimous consensus. Two topics
for discussion.
4a) OpenVDB Documentation
New forum post requesting update on OpenVDB documentation. Agreement that
OpenVDB technical documentation needs a revamp and could benefit from extension.
This is a significant task with no obvious starting point. Andre mentioned that
the unit tests have served as a good place to observe various intended usage of
VDB methods. Using the unit tests would provide a base set of examples to start
writing documentation. Nick, concern that as the unit tests have not necessarily
been designed for this that some of the logic in there could be "inaccurate" in
terms of an optimal implementation solution. Additional care to be taken that
the unit tests are first and foremost that, with clear documentation of the
intended example. Nick to create a ticket with a task to identity some of the
larger tools missing documentation and corresponding unit tests which could be
used as a first doc attempt.
4b) Hessian computation of VDB grids
Github issue asking if OpenVDB supports the computation of the Hessian matrix
from a scalar Grid. Currently unsupported. Ken, should be fairly trivial to
implement. However, as the result per value is a matrix, there is no native way
to store this information as VDB does not register matrix grids by default.
Registering these grid types would be one option - however compile and runtime
variants of "strided" grids (where each voxel/tile value contains an array of
scalar values of a fixed size) were discussed as alternative solutions which
could add more flexibility. Some potential confusion when inferring values on
a grid with an "intrinsic" type i.e. Vec3f vs float[3] collocated vs staggered
interpretation. General agreement that runtime variants would be interesting to
pursue. Nick to create a ticket and reply to issue.
5) Plan for Improved Morphology
Ken and Nick to catch up at a later date.
6) Google Summer of Code
Two mentors are needed. Dan has already volunteered to be one. Nick has
volunteered to be the second, with an agreement with Ken to share responsibility
if required.
7) CI Updated
General notice that all VDB builds should now be passing on new PRs and that PRs
should not be merged if any builds fail. Dan has a fix in the works to re-enable
the Houdini 18 Debug builds.
8) VDB Activate/Activate SDF
Two open PRs (PR692, PR695) could do with additional review from Ken and Nick.
9) OVDB-136 (Point Merging/Moving)
Nick needs to review PRs PR652 and PR631.
10) OpenVDB & USD
Additional discussion to be had next meeting.
11) Next meeting
April 16th 2020. 2pm-3pm EDT (GMT-4).
| 4,245 | Markdown | 38.682243 | 80 | 0.797173 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-07-25.md | Minutes from 24th OpenVDB TSC meeting, July 25, 2019
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M., *Peter* C.
Additional Attendees: Emily Olin, Daniel Elliott
Agenda:
1) Quorum
2) Secretary
3) Siggraph
4) Graduation
5) Delayed Loading PR
6) Copyright
7) Outstanding Bugs
8) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Siggraph
We have three engagements.
A) Course: Sunday 9-10:30
Nick, Dan, and Ken are presenting.
Nick will be covering AX exclusively for a 30 minute slot. He may have
a live demo pending laptop issues.
Dan will cover in a 30 minute window:
* VDB/OpenVDB renaming
* Delayed Loading (still outstanding PR)
* Point Moving (a new implementation)
* Scattering/Merging multithreading solution.
Ken will cover parallel fast sweeping and general optimization techniques
focusing on multithreading.
B) BOF: Tuesday 9-10am
This will have a projector with HDMI but we need our own laptops.
Mikes will be setup, so we should arrive 10 minutes early. This
will be recorded. It is expected Q&A will be difficult so we should
have something prepared. We can re-arrange chairs but only if we
fix it before the next session.
We have the slide templates distributed in the TSC private.
We decided discussion of the CMake project best fits in this BOF,
not in the course.
C) Internal TSC Meeting, Wednesday 11-Noon
Will be the meeting with Bifrost over multiresolution questions.
4) Graduation
TAC met to discuss the graduation and ran a vote over the email thread now
that we fulfilled the requirements. A check of commit logs shows that we
are now graduated! Hurrah!
Announcement of graduation will be part of press release on Tuesday,
but we can refer to it prior to then.
6.0, 6.1, and 6.2 releases should likely be grouped as 6.X release.
5) Delayed Loading PR
An existing delayed loading PR is awaiting approval. Peter okayed
it being pushed through by Dan.
6) Copyright
The thread on how to setup copyright boilerplate on DNegs new files
for AX was left a bit vague. We will resurrect that thread and verify
we are on the same page for what should be done.
7) Outstanding Bugs
Nick idenfitied some new issues on Mac. Linking to python is failing
and the current concurrent allocator is crashing on his version of OSX.
8) Next Meeting
Between SIGGRAPH and various vacations this has been delayed considerably
to:
August 22nd 2019. 3pm-4pm EDT (GMT-4).
| 2,449 | Markdown | 25.630435 | 74 | 0.766435 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-06-13.md | Minutes from 20th OpenVDB TSC meeting, June 13, 2019
Attendees: *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel)
Regrets: *Ken* M.
Agenda:
1) Quorum
2) Chair and Secretary Selection
3) AX Update
4) Security Policy
5) Namespacing/SyncNodeVersion/GetVersion
6) OpHiding
7) Delayed Loading
8) File Format Version
9) 64-bit Metadata
10) Speed of hasActiveTiles/voxelizeActiveTiles
11) GCC and Dual ABI
12) Memory Allocators
13) Topology Replace
14) Schedule Next Meeting
1) A quorum was confirmed.
2) Secretary - Nick Avramoussis. Chair - Dan Bailey.
3) AX Update
Significant changes on the way for AX, primarily focused around future proofing
the code base and upstreaming improvements and new features in preparation for
migration into a feature branch. Currently time-line is for this to become
available at the start of July. There was some discussion on the best migration
plan. Consensus was to simply copy the codebase directly onto a feature branch
once TSC members had a chance to look at the proposed repository structure,
which will be available in the current OpenVDB AX repository. No PR is to be
required for the initial migration. Subsequent changes and feedback will then go
through full review. It is expected there won't be a complete merge into the
mainline branch of OpenVDB for Siggraph and there should be no rush with this
process.
4) Security Policy
Jeff to make a PR of the proposed security policy which all members should
accept before merge. A private email alias still needs to be created and
advertised on the website for users to report security concerns. Noted that
this is the only thing that is actually required for the CII best practices
badge.
5) Namespacing/SyncNodeVersion/GetVersion
Discussion on the best way to proceed with node versioning. SyncNodeVersion
is specific to the Houdini Verison. GetVersion is a method on the Operator class
which has been designed not to incorporate any VDB dependencies. Ideally we would
be looking for methods on the node class. It was suggested to investigate using
sparedata/metadata which should solve both current use cases (ophiding for native
naming and the new OpenVDB Scatter default behavior). We would attach version
string information via this approach which would avoid introducing new dependencies
to the base houdini utility library. Note that this version information would have
to correlate to the OpenVDB release or commit version for this to work. General
consensus was that we should feel comfortable bumping the library version with
problems like these, which are clear examples of changes in behavior. Peter
to look at updating the OP Builder workflow to support this.
6) OpHiding
Two solutions put forward are named simply as the compile side and script side
solutions. To avoid both workflows being active in a given installation, CMake
could be used to configure the OpenVDB install to only activate one or the other.
Concerns were raised that this could cause confusion even if documented well.
Peter to look at the script side solution. Dan to put in a simpler PR for the
compiled solution.
7) Delayed Loading
No major concerns with the current solution, however it would be better if the
problem was solved on a larger scale by tackling the file format rather than
the proposed temporary metadata. Note that for the proposed solution to work,
all users must adopt the metadata changes.
8) File Format Version
The file format version warning can cause confusion for users loading OpenVDB files
into different readers. If subsequent problems arise, this is generally highlighted
as the fault when it may be irrelevant. One solution would be to save out each VDB
file with the lowest possible file format version number corresponding to the
feature set required by the file. This would be extremely tricky to do with VDB
currently and it also changes the interpretation of the file format number to a file
"feature" version.
9) 64-bit Metadata
Currently metadata size is capped at the value of an unsigned 32 bit integer.
The goal suggested here is to provide the ability to write out metadata with a size
up to a 64 bit integer. The proposed solution is to limit current VDB metadata
serialization to the size of a signed 32 bit integer so that the last bit can be
used to represent metadata that exceeds signed 32 bits in the future. This is not
guaranteed to be 100% safe - old readers will either crash or produce undefined
behavior with larger metadata sizes. It was proposed that VDB should ideally
check the full size of the file prior to seeking so that overflows can be safely
caught.
Concerns were raised that the general metadata workflow in OpenVDB assumes metadata
to be relatively small and trivial to copy/read (methods such as copying OpenVDB
grids and file deserialization). 64 bit support would require some restructuring to how
these methods and others deal with that assumption, highlighting the possibility that
a new framework would be needed. It was suggested that all these changes could be
bundled into one massive file version update, which would also include all the
necessary IO hooks that have been identified.
10) Topology Replace
There are no methods to perform topology replacement given two OpenVDB trees
(specifically, no methods akin to the topologyIntersction/Difference/Union member
functions). The desired outcome given a->topologyReplace(b), would be 'a' containing
active topology that matches 'b', leaving other node values and topology hierarchy
untouched but inactive. This can be achieved through a combination of Intersection +
Union, however this can be slightly more expensive and even produce 'incorrect' value
results due to Intersection potentially deleting branches of 'a'. A more efficient
method would be to perform a deactivation of all nodes in 'a' followed by a union.
Note that an ideal solution would only have to deactivate the values not represented
in 'b'.
11) Speed of hasActiveTiles/voxelizeActiveTiles
12) GCC and Dual ABI
13) Memory Allocators
Time.
14) Schedule Next Meeting
June 20th 2019. 3pm-4pm EDT (GMT-4).
| 6,140 | Markdown | 44.488889 | 87 | 0.807818 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-04-16.md | Minutes from 46th OpenVDB TSC meeting, April 16th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Peter Cheng (DW), Andre Pradhana (DW), Bruce Chernia (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum/Github Issues update
4) PR review
5) Google Summer of Code
6) Changing VDB background value in Houdini
7) Expected release date for 7.1.0?
8) OpenVDB & USD
9) Next meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Runtime Grids and Compile Times
Discussion about runtime grids and follow-on from last weeks discussion. In
general all in agreement that it would be useful and a nice new flexible
mechanism for the library. Preferred over continuing to add more compile-time
grid types. However, implementation is not trivial, including extending the file
format and figuring out a new value access mechanism.
Subsequent discussion about tackling the orthogonal, but related issue of
compile times in the library. In many cases this is down to using excessively
templated classes or functions in order to optimize inner loops, we should be
vigilant to ensure each template parameter is translating into improved runtime
performance to reduce the template bloat where possible.
There is also a general desire to reduce redundant template instantiation time
that is repeated across multiple translation units. Modules in C++17 will likely
improve our ability to address this, but that's a minimum of three or four years
away. An alternative approach is to perform compile-time registration of grid
types in the library requiring users to recompile the library itself if they
wish to add new types. General agreement to do this. Jeff cautioned that
explicit template instantiation can easily result in some messy preprocessor
code.
3) Forum/Github Issues update
One new issue concerning Python 3.8 - time.clock has been removed.
time.perf_counter can be used but is not available in Python 2.7. Will likely
need a solution that branches on Python version.
4) PR review
697 - Jeff has approved, can now be merged
692 - Dan has approved, ideally needs another reviewer to approve the code
style, Ken to review
690 - Dan to progress this soon
675 - Ken to discuss with Nick soon
671 - few minor doc updates needed then ready to merge, Nick to progress this
soon
670 - wider discussion needed about documenting package manager installation,
tabled for now
654 - mostly ready, solving a number of issues but not perfectly, Nick to break
it up into smaller PRs
652 - Dan and Nick to meet offline to discuss next steps with this PR along
with OVDB-116
651 - Dan to take this on at some point
650 - awaiting progress on 652
631 - Nick reviewed recently, Dan to finish
623/598 - Dan to progress this at some point
455 - awaiting Ken's final approval to progress this
5) Google Summer of Code
Plan is to formally ask for one slot. Dan and Nick to mentor.
6) Changing VDB background value in Houdini
No way to change the VDB background value in Houdini as the core VDB tool is not
currently exposed. Ken mentioned that at DWA they were initially reluctant to
offer this to the artists for fear it may get misused. General feeling that it
would be best to avoid a dedicated SOP if possible. One option is to add it to
the native Houdini primitive SOP, but other parameters relate to metadata so
performance cost may not be clear. All in favour of adding it to the newly
introduced VDB Activate SOP.
Nick mentioned that there will be functionality in AX to modify all inactive
values.
7) Expected release date for 7.1.0?
No rush for Houdini integration, some time before Siggraph is good.
8) OpenVDB & USD
Time. To discuss in a future meeting.
9) Next meeting
Johannes Meng has proposed that Intel will present on OpenVKL. Meeting to remain
open for all interested parties to attend, so Intel will present with that in
mind.
April 23rd 2020. 2pm-3pm EDT (GMT-4).
| 3,996 | Markdown | 36.009259 | 80 | 0.787037 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-01-23.md | Minutes from 39th OpenVDB TSC meeting, January 23rd, 2020, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), John Metric (Linux Foundation)
Regrets: *Ken* M., *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Google summer of code
4) Default GitHub branch
5) Devirtualization
6) Mantra
7) Siggraph
8) Next meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Google summer of code
We covered the samples in the shared document.
a) Delayed Loading. Cleaning up temporary files is already an issue. Why is there a temporary file? Is it possible to have a asynchronous copy update in the background? The recalled purpose of the temporary file is to stop the application from crashing if it changed. We currently have a transition at 500MB, which means large vdb would still crash.
Why not background this copy? Which then becomes a future?
Backgrounding would increase the scope of this project. Maybe we should have a background process to fill in the data?
b) CSG operations without rebuilding. Does it rebuild after? Header functions call renormalize. We can definitely can avoid resampling one of them. We should investigate if the SOP needs a rebuild operation.
Does this require a rebuild? The VDB Combine in particular requires it for SDF.
"How to do iterative CSG without changing the rest of your VDB"
Jeff to produce a melting VDB example to hopefully demonstrate what we
want fixed.
c) Erosion Improvements
Find out from Ken why not possible, seems like a good idea if possible.
d) Sequential Tree Methods
A good straightforward pattern for people to follow in the implementation.
e) Faster Statistics
Implementations is well known, some discussion needed for top level.
Support the sum-prototypes - build a new constant tile grid of a higher level version of the grid. This may answer the requirements of the rendering meeting.
f) Fix Filter Operations for Tiles
Straightforward, but lots of corner cases.
Likely builds on dialateActive? Match Volume Box Blur.
g) Optimizations by Intrinsics
Internal operations are key. Masked operations may work well for intrinsics.
Meta) The two tasks, Combine Faster Statistics and Sequential Tree, are both generic breadth-first parallel operations so might be combined.
Meta) Are the first issues good? TSC to look at it.
4) Default GitHub branch
Adds a layer to stage external contributions so we can restage. We can also reduce CI checks on the incoming to make it faster.
Await Ken's approval.
Should we get Admin rights? Current thread with TAC to acquire permissions. Will be at last a month. Granting admin has casued problems in the past. For us, the CI changes are the big sticking point. Git Hub actions are also locked out, which we need for more automation.
5) Devirtualization
Dan will run some stats on this to verify it makes a difference. Link time optimization off by default. Much FUD about link time optimization causing hard to find bugs, hopefully if we restrict it to the library we'll catch them in the tests. So add a link time option to test it out. Add final keyword to the map derive classes. Does adding final change ABI?
So first add ABI test, then add final keyword and see if it changes ABI.
Another option is to have a fastIndexToPos(). This is a lot of code.
Another option is explicitly devirtualizing with this->MAPTYPE::indexToPos()
6) Mantra
Mantra does not have interesting code for the bound summation, it is a boring min/max process.
7) Siggraph
Should we start thinking about a course? Or a BOF?
8) Next meeting
January 30th 2020. 2pm-3pm EST (GMT-5).
| 3,672 | Markdown | 35.73 | 365 | 0.776961 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-03-21.md | Minutes from 11th OpenVDB TSC meeting, Mar. 21, 2019
Attendees: *Nick* A., *Dan* B. (late), *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), Andrew Pearce (DWA),
Thanh Ha (LF)
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) Update on CMake
4) Reno Change
5) Documentation.
6) Warnings as Errors
7) Unifying SOP Labels (postponed)
8) JIRA is not working
9) Deprecation (added)
10) Next Meeting
1) A quorum was confirmed. Nick was selected to chair the meeting.
Ken had announced he could not attend due to pre-existing conflict,
and had approved the meeting proceeding without him.
2) Secretary - Jeff Lait
3) Update on CMake from Nick
3a) CMake
The PR is in a good place. Required more work than expected, but mostly
tidying up and testing on Mac and Linux. Not tested on Maya-Windows.
Blosc, ILM-Half, TBB, and a few others do not have CMake modules yet.
Houdini and GLFW modules done - using the CMake examples from SideFX.
There will be a PR add a custom module for numpy to avoid it requiring CMake
3.14.
Call for everyone to test the CMake on their own platforms.
3b) Circle CI and Travis
The TAC has enabled CircleCI so we can move forward with that and it should
work. Dan will help with CircleCI additions to the CMake PR so it can
be merged with very basic CI support (Houdini 17 / ABI 6). Initially
CircleCI will be turned on as an optional check and TravisCI as the
required check as we build up CircleCI support.
sesitag causes problems with .dsos not being cacheable as they keep
changing. SideFX should provide insight on a better workflow.
4) Reno Change
Proposal is to use reno to do intra-release change files. This involves
any change to the change file being stored as a separate yaml text
file, so avoid any conflicts on out-of-order resolution of PRs.
Concerns were raised about the doxygen and plain text requiring separate
verbage. One idea is to generate all the doxygen text when doing final
flattening. Another is to have two headers in the yaml, one for text
and one for doxygen.
Concerns were raised that reno is too heavyweight. Dan will provide
an example of what the contributing text will look like so we can ascertain
how heavyweight this process is.
5) Documentation.
Should published doxygen be all releases or only the current release?
ReadTheDocs may have a neat way to have multiple releases in one page;
but it may also require Sphynx and/or restructured text. Generally
acknowledged that doxygen workflow doesn't require an extra tool, but
just requires automation of existing tool.
Agreed that CI & CMake should be processed first. Then consider
documentation process improvements.
6) Warnings as Errors
PR for removing all warnings, allowing warnings to be treated as errors,
in target gcc platform is largely complete. Most are from trivial
casting conversions and escaping casts. This forces us to make
an explicit choice of where precision is gained or lost.
In some cases, like interpolation, we may have a float grid with a double
position. Should it upcast everything to double, tri-lerp, and then
down cast to float? Or downcast the position to float, then do all
the computation? First will give more precision, second possibly more
speed (but this should be verified). The current situation where we
repeatedly cast up and down is likely worst of all worlds.
Nick will cut the contentious components out of the PR so it can go
in and build a new PR that deals with the precision questions.
8) JIRA is not working
Dan is currently manually adding everyone to every ticket. Thanh
requested a helpdesk ticket is made to resolve this.
9) Deprecation
Removal of deprecated code will wait until after the CI/CMake issues are clear.
Dan will start to add deprecation warnings according to the new deprecation
policy. Code will not be removed until the next release. (Note: I'm unclear
if this means minor or major)
10) Next Meeting
Our next TSC meeting is scheduled for Thursday March 28, 2019 11am-12pm PST.
| 4,043 | Markdown | 34.78761 | 79 | 0.781845 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-05-09.md | Minutes from 16th OpenVDB TSC meeting, May 9, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), John Mertic (LF)
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) 6.1 release
4) Plans for next release
5) Siggraph Course
6) CI Update
7) SOP OpHiding - OVDB-64 / PR404
8) Schedule next meeting
1) A quorum was confirmed
2) Secretary - Dan Bailey
3) 6.1 Release
Peter has completed the 6.1.0 release, Ken to announce the release on the Google
Forum.
4) Plans for next release
Next minor release scheduled for around Siggraph, ideally before but preferably
no later than August to allow SideFX time to integrate it into the next release
of Houdini. Intention for this next release to include a number of big changes -
AX from Nick, tools previously shared via Google Doc from Ken, delayed-loading
and improved VDB points advection from Dan, generic convolution and sharpening
tools from Peter. We are hoping for progress towards receiving a contribution
from Autodesk too. The following release will be a major ABI one in Q3/Q4.
There was discussion around using feature branches that live in the main
repository to allow large new contributions such as AX and Multi-Res to mature.
Proposal is to use PRs in the normal way and to continue using one approval on
every PR for the time being. No opposition to this.
5) Siggraph Course
There appears to have been a change in how Course Notes are shared at Siggraph
requiring them to have been prepared by 14th May this year, which is
significantly sooner than previous years. Jeff suggested Ken reach out to
Michael Reed as the Courses Chair for clarification. Nick and Dan to share slide
decks with Ken from previous years to help with preparing material.
6) CI Update
With integration of CMake, migration to Circle CI from Travis CI has been
completed. Two outstanding issues, a segmentation fault that appears to happen
sporadically, most commonly on the ABI=4 branch. Dan has recently merged a PR to
migrate the ABI=4 branch from TBB 4.4.0 to 4.4.6 which seems to have improved
stability. Need to wait a little longer to fully assess the impact. A build
failed in the ABI=5 build today so question about whether this may have been
related to TBB. Nick suggested perhaps it was related to memory allocators. Ken
suggested we enable asserts in release mode. The second issue is that the Circle
CI configuration is not setup correctly which manifests in an issue where the
builds are kicked off from a PR but not linked back to it rendering the PR
un-mergeable. Dan has emailed Andrew Grimberg at the Linux Foundation about
resolving the issue and is waiting to hear back. Circle checks have been
downgraded to not required for the time being.
7) SOP OpHiding - OVDB-64 / PR404
Artists are regularly confused about having duplicate VDB/OpenVDB SOPs show up
in the tab menu in Houdini when installing the open-source SOPs. Peter says at
Dreamworks, many shows use opcustomize scripts to alleviate this issue, Nick
reports that DNeg is also using opcustomize scripts.
The committee was largely split on how best to solve this problem. Dan and Jeff
have discussed one proposal and Dan has submitted as PR OVDB-64 which Jeff has
approved. Peter has concerns with this approach in that there would be two
contradictory mechanisms for hiding nodes, one using the SideFX ophide script
mechanism and one using a compiled ophide policy mechanism and would prefer to
see them unified. Jeff highlighted an example scenario where a facility may wish
to hide all of the open-source SOPs except for one which they had modified and
extended. The solution to this scenario under this proposal would require
modification of the SOP definition itself by either manipulating the existing
policy flags or adding a new flag which would need support added to all existing
SOPs. Otherwise, the facility would fall back on using an opcustomize script.
The simple alternative to this proposal is a single script that has all the
ophide commands in it to allow users to customize as they chose and then install
it. However, there are a number of key problems with this approach. It requires
users to deploy a new configuration file which adds an extra source of
unreliability in deployment. It doesn't support users installing only a subset
of the nodes without running the risk of neither SOP being visible. It requires
contributors to the project to maintain a side-car file in addition to the
existing SOPs. Nick and Peter briefly discussed auto-generating an opcustomize
file using CMake but not yet clear how that might work.
The meeting wrapped up without a clear consensus on the way forward on this
issue. Dan mentioned that Siggraph would be a nice opportunity to share a
solution with the community if possible and invited others to contribute an
alternative implementation for discussion in a future meeting. The Committee is
also looking to gather more feedback from production to better inform this
decision.
8) Next Meeting
May 23rd 2019. 3pm-4pm EDT (GMT-4).
| 5,091 | Markdown | 47.495238 | 80 | 0.801414 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-10-24.md | Minutes from 30th OpenVDB TSC meeting, October 24th, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M., *Peter* C.
Additional Attendees: Bruce Chernia (Intel), John Mertic (LF)
Agenda:
1) Confirm quorum
2) Secretary
3) EasyCLA
4) Dropping Support ABI 2/3 (PR534)
5) New Methods for Const Copying Grids (OVDB-54/PR535)
6) OpFactory Deconstructor (OVDB-102/PR531)
7) Tree vs Tool Methods (OVDB-121/PR539/PR536)
8) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) EasyCLA
EasyCLA has been working for Ken and Nick using ICLA and for Dan using CCLA.
Jeff having issues with CCLA, John to follow up on helping track down the issue
Jeff is facing. Peter signed up to CCLA but hasn't submitted a PR since it was
switched on. Goal is to get this working for all TSC members before requesting
external contributors to use it. Autodesk have used EasyCLA for OpenColorIO, so
be smooth for them.
Confusion over which email is important, the one attached to GitHub account, the
one in the commit or the one in the DCO sign-off. From a legal standpoint, John
confirms that the DCO one most important, but not clear which one EasyCLA is
actually relying on.
No problem merging TSC PRs with failed EasyCLA checks as we have all signed
paper CLA.
4) Dropping Support ABI 2/3 (PR534)
Unanimous consent, Dan to merge.
5) New Methods for Const Copying Grids (OVDB-54/PR535)
Peter and Dan discussing method names on PR, but currently unresolved. Request
for others to contribute.
6) OpFactory Deconstructor (OVDB-102/PR531)
Nick votes that this change should go in, Dan to merge once approved.
7) Counting and Tree vs Tool Methods (OVDB-121/PR539/PR536)
Ken submitted PR536 for a new nodeCount() method implemented on Tree, Dan
submitted draft PR539 for nodeCount() and activeVoxelCount() implemented as
tools. Dan's nodeCount() implementation marginally faster than Ken's due to
threading but also more complicated, activeVoxelCount() significantly faster
than current implementation due to threading. Ken would prefer counting methods
to live on tree as convenient. TreeBase print method also needs counting
functionality so there's a snowball effect.
General question as to which methods should live on tree and which in tools. Dan
proposed line should be between functionality that benefits from threading, ie
navigates more than just one path through the tree. Some cases like merging and
topology methods would clearly benefit in terms of performance if extracted.
Counting functionality is closer to the line.
Ken's priorities are that the methods should be intuitive, performant and not
require exposing private tree data. Potential cost of asking people to change
their code a consideration too.
Dan feels that the breadth-first merge is fairly representative and noted that
it required just one private member access in RootNode. Dan to look into the
details again and to consider how this could be provided in a safe way.
Jeff proposed making TreeBase methods non-virtual and using dispatch. One option
is to introduce TreeBase::apply() to perform dispatch of a compile-time list of
grid types. Peter and Ken against limiting core functionality like counting to
only be available for known grid types. Jeff and Nick suggested mechanism to
register types at compile time. Peter proposed introducing a counting visitor
pattern.
NodeManager leaf node pointer caching was a performance bottleneck in
activeVoxelCount(), Ken highlighted that the NodeManager could be optionally
cached only up to a certain level, Dan to look into this.
Time. No clear direction yet, discussion to continue.
8) Next Meeting
Next planned meeting is:
October 31st 2019. 3pm-4pm EDT (GMT-4). Costumes encouraged.
| 3,738 | Markdown | 38.776595 | 80 | 0.79374 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-09-22.md | Minutes from 64th OpenVDB TSC meeting, Sep 22nd, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) NanoVDB
5) PRs Outstanding
6) Checksums
7) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) Forum
Ken still to reply to the out of core question. The answer to the question is straightforward, but what would we like in the future?
4) NanoVDB
NanoVDB also has interest in delayed loading.
Jeff does not want NanoVDB to be more complicated than it has to be.
There are some additional changes still coming to support DirectX.
An improved C-port also exists.
5) PRs Outstanding
What is the process for external PR. Does the second Reviewer merge or the first? Or someone else does? We will continue to work ad-hoc.
Feature branches, however, must be merged by the owner of the feature branch.
Likewise, if a PR is for a particular person's domain, that person will be left with the merge.
a) PR 829, sync names. To be merged
b) PR 823, make delayed loading/iostreams optional.
This disables delayed loading. This does change the File::Impl, but this should be name-spaced and internal, so not cause actual ABI changes.
Should we have ENABLE or DISABLE? First we should have config flags in the source file only where possible. Flag names depending on cmake defaults is scary. Our Find Module is not yet powerful enough yet. So we want to keep Find Module as simple as possible.
If we tried to move the delayed loading to the C file we'd lose the ability to remove the mutex.
Configuration of the build system is USE_FOO. These Cmake variables then drive -D variables. These vary currently. Should half and delayed loading be off by default? Apparently our models on the web are all half...
Ideally the default is no dependency.
The define will be DISABLE for delayed loading.
C) PR 819. Remove half.
Should we just bring in a Half.C/Half.h rather than removing Half.h?
In future version of OpenEXR it will be its own header we can include.
What should we do with missing dependencies? A runtime check is required because we don't know the source of the grid, it can come from another library that has support. We will go for runtime errors, not compile time or linker error.
D) PR 818, all of AX
This has AX based CI. It has to install multiple versons of LLVM, which eventually evicts the Houdini caches. But as LLVM isn't EULA based, we should be able to pre-populate the containers with them.
We should read over this prior to the next TSC, especially any questions inside.
6) Checksums
Ken is researching CRC-variants, some are parallel, so fast. Three modes have been added. No checksum. Checksum for the metadata only. Full checksum. Separate CRC are for grid, tree, root, and else.
One use is debugging, quickly verifying things are identical.
Validation tool for NanoVDB to verify no pointers go out of scope. The security member approves.
7) Next Meeting
Focus on AX.
Tuesday September 29th 2020, 1-2pm EDT (GMT-4)
| 3,201 | Markdown | 34.577777 | 262 | 0.762887 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2018-12-13.md | Minutes from 4th OpenVDB TSC meeting, Dec. 13, 2018
Attendees: Nick A., Ken M., Jeff L., Dan B., John M.
A quorum was confirmed.
Secretary - Dan Bailey.
3) Decision on coding guidelines. Ken initially suggested a policy of at least one code owner should
approve every commit, Jeff raised that a best practice would be better so that simple reformatting
commits wouldn't require approval and that a commit that touched lots of areas of code wouldn't then
require every TSC member to approve. It was agreed that this was a better approach. In lieu of
demoting this from being a policy, a cooling-off period was suggested as a best practice to allow
time for feedback to be gathered, particularly from code owners. 72 hours was proposed as the
recommended time to wait. With these additional changes, the TSC members present unanimously agreed
on merging the proposed code review guidelines.
4) Decision on questions for Autodesk. Ken will send out a final email with questions shortly. The
hope is that after the initial information gathering, that this can turn into a back-and-forth
discussion to find out the best way to proceed here.
5) Update on merge permission for TSC members. All TSC members now have write access except Nick.
Dan to loop Nick into the Linux help desk ticket to follow up. In addition to write access, this now
opens up the ability to add requested reviewers and to approve pull requests. However it is
understood the Linux Foundation (ie Thanh) are the only ones with Admin permissions, so the TSC
members will need to communicate with them for adjusting repository settings (such as enforcing the
code review policies).
6) Latest update on plan for version 6.0.0. The ABI 6 pull request has already been merged in by
Peter in preparation for a release. All present agreed on moving forward with doing a soft release
for 6.0.0 to be compliant with the VFX Reference Platform for next year and then to follow up with
an announcement in January, once Peter has had a chance to update the website. This will include a
couple of outstanding pull requests such as the H17 fixes from Nick and a change to minor change
remove a test function suggested by Ken. The process for doing the release is to update the list of
changes and to send round to all TSC members to review before tagging the release. Once the release
has been tagged, a subsequent update will then mark the codebase in development once again and to
bump the version to 6.1.0 which is planned to be a big release with many more updates to come! A
follow-on discussion to be had about software dependency deprecations.
7) Misc. OpenVDB won a Luminaire Tech award from the Advanced Imaging Society! John joined the call
towards the end and brought up the recent discussions held by the TAC about licensing for DCC
dependencies. Jeff clarified that SideFX's recommendation is to use a Houdini Apprentice license and
highlighted that there is a Linux standard license exception that approves including code from a
third-party in released binaries and headers.
8) Our next TSC meeting is scheduled for Thursday Jan 3, 2018 2pm-3pm.
| 3,121 | Markdown | 65.425531 | 100 | 0.801025 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-07-14.md | Minutes from 56th OpenVDB TSC meeting, July 14th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Peter Cheng (DW), Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum Issues
4) Siggraph
5) Fast Sweeping
6) Morphology Improvements
7) Next meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Forum Issues
User running into issues with Centos8 compilation, should have been fixed in
later release of OpenVDB. Nick to suggest using CMake >= 3.12 to resolve
subsequent Python3 issue.
There is an unrelated issue that Ken and Nick have run into attempting to use
Mac OSX Catalina and a later Clang compiler(?) which manifests as a deprecation
warning about a random number generator. Currently, our CI only tests one
configuration on Mac which doesn't expose this error. More investigation needed.
4) Siggraph
Have to decide between a 25 minute and 55 minute session. Our preference is for
the free user event instead of the official Siggraph birds of a feather event
which requires a paid registration.
Discussion about what the target audience is for such an event. Decision to opt
for 55 minute session split into two - the first half an introductory overview
of the library for new users and how to start contributing, the second half a
more advanced session. Ken feels the most useful for us is the discussion with
the community so would rather dedicate the advanced session entirely to this.
Jeff mentioned that we should at least present a quick overview of new and
upcoming features first. Dan likely not able to present due to being on an
unreliable internet connection for this session.
Question about how well the ASWF format will lend itself to a group discussion
rather than being geared towards presentations from the TSC. Ken to reach out to
ASWF to ask about what we can do here to improve our ability to hear from the
community. Dan mentioned that David Morin frequently uses a poll to allow the
audience to pose questions and upvote on other questions asked by the audience,
this could be a good way to direct the discussion towards the areas of most
interest.
Need to put together title slides.
5) Fast Sweeping
What to do when the algorithm fails. Jeff highlighted a number of cases where
not having a zero crossing for a level set should be acceptable. One such
example is disconnected level set regions arising from a fluid simulation. The
algorithm shouldn't generate an exception in this case because it's not an
exceptional case. Ken to revisit this.
Andre still awaiting DWA approval for the Extrapolate SOP, hoping to push up a
PR soon.
Dan and Ken to discuss voxel slicing optimization offline.
6) Morphology Improvements
Currently, a topology union gives different results dependent on whether the
serial or parallel algorithm is used. Nick submitted PR751 to add a
preserveActiveTiles flag to Tree::topologyUnion() to avoid always densifying
active tiles. No objections to doing this. It is acceptable to treat this as a
bug and to change the existing behavior, especially as the documentation does
not mention tile behavior.
Nick also has improvements to dilation and erosion in PR754. Aim is to deprecate
the existing dilateVoxels and erodeVoxel methods with new functions that provide
a more uniform interface and support matching functionality. Adds support for
edge/vertex erosion based on inverse dilation. Significant performance
improvements to large dilations. Note that the result of the threaded dilation
differs due to the behaviour of topologyUnion (as discussed above). This PR also
fixes a bug where tools::erodeVoxels() always calls pruneLevelSet() regardless
of whether the input is a level set.
7) Next meeting
July 21st, 2020. 1pm-2pm EDT (GMT-4).
| 3,847 | Markdown | 39.505263 | 80 | 0.799064 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-06-18.md | Minutes from 52nd OpenVDB TSC meeting, June 18th, 2020, (GMT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: JT Nelson (Blender), Brecht Van Lommel,
Larry Gritz, Andre Pradhana (DW), Bruce Chernia (Intel).
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) JE Malloc Issues
4) Boost
5) AX
6) Fast Sweeping
7) Next meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) JE Malloc Issues
JE Malloc 5 has an issue that loading dynamically can fail. Latest Ubuntu has
an issue with this. Generating hard to trace memory problems from an
application that brings in OpenVDB, and OpenVDB's default build links in
jemalloc. So should jemalloc be included in openvdb at all? This should be
the top level application. So we should change the default to None. The
concern is that people will not know to use jemalloc, so end up with slow
performance. Maybe a way to check? Print out if it is missing with an env
variable? Having OpenVDB override the allocator makes it hard to even test
different allocators.
We can make a CMake target that also includes jemalloc.
The VDB applications should be using jemalloc. Unanimous consent on setting
the default to None.
4) Boost
Most of the easy boost dependencies are removed. So the hard ones are for the
rest of the TSC to fix.
Interprocess Module: Tricky
UUID: Ken believes this should be replaced with a hash, as it is just to find quickly same grids. Current UUID approach is too conservative so doesn't help find identical grids. The concern is that computing the hash would be significant. However we have to traverse the grid anyways to save; so a hash may just be CPU cost. Can be used for delayed loading.
Conversion Traits: To select numeric types of higher precision. Used primarily for selecting container sizes. Boost can handle nested container types. This is likely solveable.
PRs exist for replacing MPL. boost::string replacments. And replace boost::any with the existing MetaMap.
Most PRs have merit, but string is a re-invention problem.
We need to decide if we are trying to avoid future boost, and being willing to do extra work to get rid of existing boost requirements.
Motion: We will not introduce more boost
- unanimous
Motion: We will remove boost, possibly rewriting code, or making it optional. But not by adding more dependencies.
- unanimous
Dan will look at Half being optional and inteprocess optional.
Nick will look at conversion types/traits.
5) AX
New feature branch. Will address Dan's feedback. Question is if we should switch to a submodule implementation. Lot of changes are being pushed up. Be hard to keep syncing to the feature branch.
We are not sure of legality of submodules.
Instead try to get the feature_ax branch sent in, then replace the working branch at DNeg with a new version forked from the ASWF.
Still on target for Siggraph.
6) Fast Sweeping
New Draft PR for evaluation. Need feedback on the API.
No significant changes from a week ago.
Still wish for more performance. Sorting is a bottleneck.
7) Next Meeting
June 25th, 2020. 2pm-3pm EDT (GMT-4).
| 3,148 | Markdown | 34.784091 | 361 | 0.772236 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-08-11.md | Minutes from 60th OpenVDB TSC meeting, Aug 11th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: JT Nelson (Blender), Andre Pradhana (DW)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) Fast Sweeping
5) 7.1 Release
6) NanoVDB
7) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Forum
Request to remove v3.3.0 branch, Dan has done this. Request to improve
benchmarks, this would be good to do. Request to move INVALID_IDX definition to
header, it is believed that this is indicative of a deeper linking issue rather
than an issue in itself, Nick to reply to question.
4) Fast Sweeping
Nick advocating removing testing logic from the PR. Ken to leave in until this
feature has matured slightly, then tidy up. Brief discussion about unit testing
in general as it is solving many purposes. Would be worth separating out
benchmarks, regression tests, sample code and debugging data from unit tests.
In case of no zero crossing in all or part of a grid, Jeff wants the same
topology but different values. Never useful to know if sweep did something or
not. Algorithm should return original grid not an empty grid. Ken agreed and
will revisit this.
Andre asked about what should happen at the SOP level if a vector field is
passed in to be used for zero crossing. Should produce an error in this case.
Fast sweeping SOP can either handle pairs of grids containing one SDF and one
extension field or one SDF with multiple extension fields. Not clear what to do
here. Best option seems to be to produce a warning if more than one SDF is
passed in.
5) 7.1 Release
Dan to do 7.1 release as Ken and Nick are preparing for Open Source Day. Last
two PRs are 746 (fast sweeping) and 775 (openexr 2.5 fix). Nick to merge 775,
Ken / Dan to look at DCO issue and then once merged, 7.1 can be released.
Decision to hold off on merging other PRs until after 7.1. Next time, a separate
release branch would be preferable here.
6) NanoVDB
Question about how to deploy. Two options were considered 1) adding NanoVDB into
the existing OpenVDB repository as a "feature branch" or 2) initially releasing
NanoVDB as a separate repository and then integrate it into openvdb later. All
voted in favour of option 1.
7) Next Meeting
August 18th, 2020. 1pm-2pm EDT (GMT-4). Open Source presentation will be August
20th. 1pm-2pm EDT (GMT-4). Dan unable to attend next meeting.
| 2,447 | Markdown | 33.478873 | 80 | 0.770331 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-10-10.md | Minutes from 29th OpenVDB TSC meeting, October 10th, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M.
Additional: John Metric, Daniel Elliot.
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Select TSC member to take minutes
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) 18.0 Update
18.0 has updated to the core 6.2.0 library with the patch. It should, however, be updated to 6.2.1 to minimize confusion about versions. Node changes still have not been merged.
4) C++14
C++14 doesn't currently compile in 7.0, but it should. Dan has a PR active to fix this.
5) Interpolator Proposal
This is still outstanding. Ken is planning submitting Jira tickets about the proposal. This includes a few different things: curvature, fast sweeping, node count, etc.
It was pointed out that any new Jira ticket requires explictly adding all of the TSC as watchers.
6) ABI=7 and 7.0 Release
We want to maximize our ABI changes in this window. 7.0 will close off in the early December timeframe at the latest.
Do we want an extra 64-bit word in the leaf node? This can be useful for building references to external caches without hashmaps. But a 32-bit integer may also suffice, and might fit in existing padding rules of the coordinates. Likewise, there may be enough that we can trim away. For example, we store separate offsets for the Value Mask and Value Offsets for a disk file, but these are now contiguous. Indeed, we might be able to union those with the blind data as live algorithsm shouldn't need them.
We have a ticket with the ABI7 label to track the various stuff we couldn't do over the year due to ABI. Dan will send a link of all 4. Some are easy, but one of note is that you can't do a shallow copy of a tree and update the meta data or transform without doing a const cast.
Attribute Array seems to produce lots of warnings in ABI 7. This is under latest OSX clang.
7) CLA Easy Engaged
This has been turned on so we can beging to find out how things work.
8) Windows CI
There is a PR to enable python tests, but Windows is not building the python plugin. It is suggested the python module should be optional by default, like the Houdini and Maya support. Consensus was to disable by default so people can get a build, then add python.
9) CMake
Will look into improvements on default paths.
10) Mesh to Volume non determinism
Nick wishes someone other than himself to verify this does fail, so he can rule out hardware or some strange configuration issue on his end.
It appears to be isolated to the prim id tree. Next stage may be to remove thread local storage in case it is TBB non-re-entrancy. Valgrind or Address Sanitizer in Clang might be useful.
11) Next Meeting
Next planned meeting:
October 17th 2019. 3pm-4pm EDT (GMT-4).
| 2,808 | Markdown | 43.587301 | 510 | 0.763177 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-09-29.md | Minutes from 64th OpenVDB TSC meeting, Sep 29th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Robin Rowe (Cinepaint)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) PR 818 AX Review
5) Simd
6) Next Meeting
1) Quorum was confirmed.
2) Secretary was Nick Avramoussis
3) Forum
Still need to reply to some forum posts, Dan to take a look. A few issues w.r.t
VDB 7.x dependent software not building as users are not realizing C++14 is now
required. Dan to put in a compile time check in Platform.h to explicitly fail
if C++14 is not enabled.
4) PR 818 AX Review
Most of this meeting was spent reviewing the comments made on PR 818. Replies
are copied here for convenience.
AX CI
Currently the AX CI builds LLVM from source and caches it on the available
github actions cache. Dan has initiated conversations with the LF to see if they
can provide docker containers for different LLVM versions.
Precision of integers and strict type binding
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496308313
AX currently support short, int and long signed integer values which are aliased
to 16, 32 and 64 bit respectively. This is primarily required due to the way AX
strictly binds to grids/attributes of the same type (i.e short@myattrib). Agreed
that, realistically, 32 or 64 bits should be exposed. There are some performance
considerations making everything 64 bit on some architectures. Best solution was
to first allow @ to bind to the same type category, remove short, rename int and
long to int32 and int64 and alias int to either int32 or int64 at compile time.
Same comments were made w.r.t float and double, however GPU support will
definitely need float and the lack of float for CPU code will make it impossible
to produce deterministic results.
$ syntax in Houdini
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496311518
The AX Houdini SOP supports some vex functions like ch/chramp etc. It evaluates
the raw string to avoid $ expanding at the cost of no backtick support (though
this can be added). Ultimately the presence of ch means that this isn't an issue.
Attrib dependencies
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496312075
No evaluation is performed on code values, so dead/unreachable code paths still
contribute to attribute/grid creation and dependencies.
C vs python style modulo
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496312423
Currently uses LLVM's default IR builder modulo instruction which will be C
style remainder op. Agreed to instead switch to python style "true" modulo op.
Line directives, pre-processing and runtime errors
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496315058
Currently no # directive support. Agreed adding it would be good. Catching
exceptions is not an ideal way to control top level behavior. Agreed that
custom logging would be better. This actually already exists but needs to be
upstreamed. This was going to be done as a subsequent PR but may as well be
bundled into this now.
lerp()
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496317012
fit()
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496318424
Agreed to investigate better formulation of lerp() and fit()
signbit()
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496319359
Agreed to change to sign()
Function signature type support
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496317548
Depending on the int precision work, this work will be simplified. Signatures
should really exist for all types unless it really doesn't make sense for some
specifically. Agreed to add a maxComponent style method for vector elements.
Determinant checking of polardecomp
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496319863
Need to check the behavior of openvdbs polardecomposition function if the
calculated det is negative and document this.
AX namespace, API/ABI
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496322339
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496449902
Agree on the two options stated - either AX should use its own versioned namespace
or be locked to VDBs. This includes lib versioning too. Preference is to lock to
VDBs namespace. Will peruse this and see if any issues arise.
VDB changes
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496433146
Although minor, agreed to split out VDB specific changes to a different PR.
Deprecated methods and odd implementations
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496434030
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496441704
For backwards compatibility and internal reasons, some design decisions were
made which now look odd in the open source version of AX. These still need to
exist in the standalone repo but can be removed and re-worked for the merge into
VDB. Agreed to action these.
Executable terminology
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496439529
Agreeded to rename to Binary and see what it looks like.
Executable member interface and usage
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496444627
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496443272
In the current design, the executables store all settings on a sub struct unique
ptr. This produces a clean API with separation of the trivial execute calls
from the member settings. However it means that they must be copied to make
modifications if the exe is const (though this copying is cheap) and requires
explicit copy constructors/assignment operators. Another option would be to have
users provide these settings on each call to execute. This better ties in some
settings to the grid data being executed, produces a trivially copyable object
and means the executable can be const. Nick, will play around with these ideas.
Combination of Compiler to Executable
https://github.com/AcademySoftwareFoundation/openvdb/pull/818#discussion_r496446789
The templated compile methods exist for internal reasons and can be removed. It
may be better to introduce static creators on the executables which take a compiler
vs the friend implementation. No clear advantage currently, but agreeded that
the workflow between the code generators, compiler and exes could use some
attention.
ax::run() with multiple grids/attribute bindings
Agreed that this particular signature could use some more explicit behavior.
Agreed to error if points and volumes are provided. Custom way to bind attributes
to grids should exist that don't rely on the grid name (i.e. what if the grid is
const).
Below are the main action points which block the initial merge:
- Integer precision changes
- Modulo implementation
- Deprecated code removal
- lerp(), fit(), signbit() changes
- AX Versioning changes
5) Simd
Ken, working on some more intrinsic functionality for VDB. Nick, has code he'd
like to upstream which uses SIMD wrappers. TSC is open to including external
SIMD intrinsic wrapper software in VDB.
6) Next Meeting
Skipping next week.
Next meeting is October 13th, 2020. 1pm-2pm EDT (GMT-4).
| 7,526 | Markdown | 40.816666 | 83 | 0.809062 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-05-28.md | Minutes from 51st OpenVDB TSC meeting, May 28st, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees:
JT Nelson (Blender), Bruce Chernia (Intel), Andre Pradhana (DWA),
Peter Cheng (DWA), Robin Rowe (Cinepaint), Johannes Meng (Intel),
Ibrahim Sani (DWA)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) Forum
4) PR Review
5) houdini_utils
6) Paraview
7) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Forum
Ken replied to a recent post about AMR.
4) PR Review
* PR 719 - Dan gave an overview of the caching workflow and the motivation. All
agreed with the strategy of running the scheduled cache job until it is
successful then switching on the reading of the caches in a subsequent PR. To
be merged this week.
* PR 720 - ABI=4 support removed with this PR. Should really deprecate ABI=5 in
preparation for removal next year. However, many studios still using ABI=5,
particularly for Houdini 17.5 so marking this deprecated will likely encourage
users to add the OPENVDB_USE_DEPRECATED_ABI flag to their builds. Not
remembering to remove this flag risks users not being made aware of future
deprecations if they aren't closely monitoring compiler warnings. Decision is
to change the compiler flag to OPENVDB_USE_DEPRECATED_ABI_5 so that the next
ABI flag will need to be explicitly added to turn compiler errors into
warnings as a result of using a deprecated ABI.
* PR 722 - This needs to be merged before AX can be introduced to VDB.
* PR 723 - Instantiating matrix grid types needs to work. Introducing a
cwiseCmp() method to the value type reduces chance of comparing matrix /
vectors incorrectly, but requires all types to have it (PointIndex, etc). This
is needed by the prune Grid method which should ultimately be deprecated in
favour of the prune tool. Ideal implementation would be a prune method that
takes a custom functor. The tuple type which vec types are derived from have
the less than operator, so matrix types should do too.
5) houdini_utils
Brief outline of the proposed plan here and potential impact on DWA of
deprecating this. Discussion to continue through email.
6) Paraview
Paraview are introducing VDB support. MPI distribution is one of the key
features.
7) Next Meeting
May 28st 2020. 2pm-3pm EDT (GMT-4).
| 2,324 | Markdown | 31.291666 | 79 | 0.774096 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-09-12.md | Minutes from 27th OpenVDB TSC meeting, September 12th, 2019, (GMT)
Attendees: *Nick* A., *Dan* B., *Jeff* L., *Ken* M., *Peter* C.
Additional Attendees: Bruce Chernia (Intel), Dan Elliott (Weta)
Agenda:
1) Quorum
2) Secretary
3) Latest on our release plans, specifically v6.2
4) Changes to unit-tests (Ken)
4b) Staggered Interpolation
5) SPDX Update
6) CLA Update
7) OP_Operator::getVersion format (PR502)
8) OpenVKL
9) Renderman and H18
10) Anisotropic Surfacing
11) Next Meeting
1) Quorum was confirmed.
2) Secretary was Dan Bailey
3) Latest on our release plans, specifically v6.2
Jeff would like a 6.2.0 release within the next ten days so it can be integrated
into Houdini 18.0 before the upcoming release. Peter has agreed to do this
release, but would like us to move to a model where others on the TSC can also
do releases. Primary barrier is improving the way Doxygen gets released as
currently this is a manual, offline process and would be better if automated.
Dan mentioned that there are a number of other admin tasks that are still
outstanding of which this is one.
Outstanding items to complete before we release:
* PR502 - Dan to finish, see discussion in (7).
* PR504 - Nick to do more testing, affects Windows builds, may not make the cut
for 6.2.
* PR506 - Nick to merge.
* CMake Deprecation Warnings - Nick to add a few deprecation warnings to CMake.
4) Changes to unit-tests (Ken)
Ken would like to see us move to Google Test over CppUnit. More modern C++ unit
testing framework actively developed by Google. Various useful features such as
parallel testing, running a test until failure, less finicky over type
mismatches, etc. Peter concerned about adding a new dependency, Nick suggested
Boost Test as an alternative. Some discussion about our policy regarding Boost,
general feeling that we have been trying to migrate towards using standard
library as functionality becomes available but no plan to try and accelerate
this. It is deemed more important to reduce the use of Boost in the core library
than the unit tests. It was also suggested that we should look at other
open-source projects and which unit test framework they use.
All agreed that we would benefit from the increased feature set provided in
Google Test, but less certainty about whether the migration would be worth the
effort. Ken to share an example as a test case of how complicated the migration
might be.
Dan to share a link to the SonarCloud code coverage so that all can get an
understanding of areas of the codebase that might be lacking in coverage.
4b) Staggered Interpolation
Ken mentioned that in writing a simple fluid solver, he ran into issues with
efficiency of interpolation of staggered grids, Nick concurred. It is currently
redundantly interpolating in axes that are not used and there is no stencil
caching as recently discussed in regards to sharpening. Ken to look at
contributing an improvement here.
5) SPDX Update
John Mertic not on the call, Dan to reach out to find out if there has been any
progress here.
Update: John Mertic and Steve Winslow had a conference call with Andrew Pearce.
Dreamworks have some concerns on the impact of removing the language from the
license moving to the SPDX license. John and Steve are exploring options to
resolve the non-standard license language while at the same time address
Dreamworks' concerns.
6) CLA Update
Ken, Jeff and Dan have not completed the digital CLAs. This is holding up our
ability to accept external contributions. Dan is still awaiting Lucasfilm/Disney
legal to proceed. Ken and Jeff to follow up on their end. Ken to look at signing
the individual CLA.
7) OP_Operator::getVersion format (PR502)
Peter has suggested both Houdini and VDB versions to be included in the version
string for possible future use and no objections to this. Question over whether
there is a benefit to align with existing version mechanism as
OP_Operator::getVersion is a public function. Jeff said that lots of hip file
nodes such as HDAs use custom strings which cannot be parsed so no real value in
attempting to do so. Jeff proposed "vdb6.1.0 houdini18.0.222" as the format. All
in agreement. Dan to make that change in time for inclusion in a 6.2.0 release.
8) OpenVKL
Bruce to discuss with Greg about the possibility of the TSC receiving an OpenVKL
update from Intel around October. Intel's plan is to incorporate VDB in Q4,
OpenVKL not intended to replace OpenVDB.
9) Renderman and H18
Dan mentioned a discussion being had offline with the Renderman group. Hope that
the developers will be able to join us in a future call to discuss and may even
be able to contribute to the project in the future.
10) Anisotropic Surfacing
Nick looking at open-sourcing this tool. Jeff not certain of the exact
implementation but confirmed that the Particle Fluid Surface SOP is the primary
tool for surfacing particles provided by Houdini.
11) Next Meeting
Next planned meeting is:
September 26th 2019. 3pm-4pm EDT (GMT-4). Option to hold one on September 19th,
depending on the status of the 6.2.0 release.
| 5,086 | Markdown | 39.696 | 80 | 0.790405 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2020-11-17.md | Minutes from 71st OpenVDB TSC meeting, Nov 17th, 2020, (EDT)
Attendees: *Nick* A., *Jeff* L., *Ken* M., *Dan* B.
Additional Attendees: Johannes Meng (Intel), JT Nelson (Blender),
Andre Pradhana (DW), Bruce Cherniak (Intel)
Regrets: *Peter* C.
Agenda:
1) Confirm quorum
2) Secretary
3) GitHub Issues
4) OpenVDB AX
5) PR #754 - Morphology
6) SOP Extrapolate
7) Corner vs Center Sampled
8) Google Test
9) Does the Meeting Survive Host Leaving?
10) Next Meeting
1) Quorum was confirmed.
2) Secretary was Jeff Lait
3) GitHub Issues
Initialize is on Dan's agenda. No one has looked into CMake issue yet.
4) OpenVDB AX
After merge deprecated code will be removed. Along with any additional feedback for 7.2. Unless Ken blocks, it can be committed tomorrow. Nick will make Jira tickets for the items that we wish to get to later.
5) PR #754 - Morphology
PR is for speeding up dilation, cleaning up the file and adding new methods for nearest neighbour algoirthms, and add the tile policies.
dilateVoxels now calls through to the new morphology class. They produce the same result, so un-updated code will work as expected. Free functions activate/deactivate have been moved to Activation.h to separate them out.
New erodeActiveValues supports neighbour rules as well as tile policies. dileate/erodeActiveLeafValues only runs over leaf nodes and is invoked by the higher level once the tiles are set.
PRESERVE_TILES followed by density is the same result as EXPAND_TILES, but PRESERVE_TILES has optimizations.
topologyUnion traditionally will always fully voxelize active tiles where there is overlap. The new preserveTiles will avoid this and leave active tiles active.
Grain size is not clear for this algorithm, which is why only a threaded flag is exposed.
There is now a choice to steal the node or collapse the tile into a constant tile that greatly speeds up the dilation of large trees.
To support the other choices for erosion, we dilate by one, subtract to get the wave front, then dilate this wave front the desired iterations. Subtracting this from the original gives us the erosion. Erode by face will use the old implemenation, other choices will use this new implementation that is slower, but not too much slower.
Methods that call this from Houdini have not been changed. We suggest we can change this now as it is a bug fix.
Excellent comments in the code.
How important is it to keep the broken paths around? We keep complicating the API to support broken behaviour. Should we have more documentation to solve this? It is important to know about PRESERVE vs IGNORE tiles as you need to be aware of tiles when working with grids. But doesn't dilate always activate, and the addition of new tiles is just chance?
Do we introduce a new method, dilate, that has the proper behaviour, and deprecate the old one? Maybe an API compatibility flag to adjust the defaults? We don't have a clear answer how to solve this, in this particular case it isn't relevant as the only one we'd want to change would be topologyUnion, that should be removed in any case.
6) SOP Extrapolate
PR has been updated, needs Jeff to look at it.
7) Corner vs Center Sampled
The PDF has been posted internally and is approved.
8) Google Test
We had already discussed this a year ago as well. Dan now has a version done swapping our own test out. We should put this in after AX.
9) Does the Meeting Survive Host Leaving?
Nope.
10) Next Meeting
Next meeting is December 1st, 2020. 1pm-2pm EST (GMT-5).
| 3,531 | Markdown | 43.149999 | 359 | 0.776834 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-02-14.md | Minutes from 8th OpenVDB TSC meeting, Feb. 14, 2019
Attendees: *Jeff* L., *Nick* A., *Ken* M., *Peter* C., *Dan* B., Andrew P.
Additional Attendees: Bruce Chernia (Intel), Thanh Ha
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) Update from TAC
4) SIGGRAPH course
5) Jenkins vs Travis
6) Bug Reporting / External PRs
7) Other
8) Schedule next meeting
1) A quorum was confirmed.
2) Secretary - Nick Avramoussis.
3) Ken gave a brief 5 minute overview of the TSC at the TAC meet. The majority
of our time thus far has been spent on process + gave a condensed overview of our
future work (ax, extended points support etc). OpenColorIO has been fully
approved as the second ASWF project. OpenEXR is on track for approval in March
2019.
Apple is now on the TAC, Andrew mentioned to them that they could provide
assistance through build system contributions for their platform for ASWF
projects. There is some concern with the level of emphasis on MacOS and Windows
support as they have not been specified as requirements by the ASWF.
The issue of a security consultant was again raised. Ken mentioned to the TAC
that the OpenVDB TSC have struggled to fill this position. Jim/Bruce at Intel
spoke that they might be able to provide assistance in this area. It's currently
not clear exactly what security issues the TSC needs to be responsible for. Jeff/
Nick gave examples of supported implementation that could be used maliciously.
Andrew: anything we provide from the ASWF should be signed that it's a valid file
in the given format.
4) Ken submitted a proposal for the OpenVDB SIGGRAPH Course on Feb. 12th. The
submission is still open for a 1h 30min time slot and has room for potentially
one more presentation. The first topic, presented by Ken, will be an update on
OpenVDB since the last course (4.1->6.1) and content about the new governance.
Nick will present OpenVDB AX, Dan's content may include delay loading and point
advection. There may be an opportunity to discuss the Autodesk's mres grid,
depending on their reply (still pending).
5) Dan: three points in favor of Travis/Circle/Github CI. The first is that the
current Jenkins setup uses an additional repository for the CI build system,
where as Travis uses the CI included in the OpenVDB repository. This is a
limitation of the way that Jenkins is currently configured in the ASWF. Having
the CI in the same repo makes it easier to sync, jump around the history, merge,
fork etc. Thanh mentioned that there is a way that Jenkins might be setup to
accommodate this, but it uses Jenkins's own proprietary systems. Second, the
logs in Travis have a much nicer layout to Jenkins. Third, Travis has inbuilt
ccache support. We also already have Travis integration. The additional
computational resources are the main benefit of the current Jenkins system.
Thanh has been investigating Circle CI and another LF group (the LF Networking
group) has been looking at alternatives. This group meets Fridays.
Meeting notes from the Tooling working group:
https://wiki.lfnetworking.org/display/LN/LFN+Infra+Work+Group+1+Feb+19
Meeting schedule/mailing list for the working group for anyone who's interested
in attending:
https://lists.lfnetworking.org/g/TAC/topic/lfn_tooling_subgroup/29576852?p=
Note that CMake support is unrelated to the CI and should be prioritized.
6) Main point of entry for reporting bugs isn't clear. There are four places:
JIRA, Github issues, e-mail, forum. The forum has recently been getting spam.
Membership is required for the forum which Ken has to confirm. We could enable
moderation so that posts have to be approved before they are visible. Jeff
mentioned that SideFX only moderate first posts.
Dan: Github issues are nice as they allow you to close the issue/mark as resolved.
Nick: the lack of documentation exacerbates the problem of potentially trivial
forum posts and dilutes the forum. Nick brought up the current issue with external
(non-TSC) pull requests stagnating. It was agreed that we need a Github check for
CLA. Dan mentioned that it might be worth consolidating the current contributing
.md files to have a clearer documented process for external PRs.
Dan's message on the above: https://lists.aswf.io/g/openvdb-dev/message/41
7) Jeff used the current statistics header in OpenVDB to introduce VDB reduction
support (for volumes, not points) in Houdini 17.5. Nick asked if the hscript
expression might also benefit from supporting VDBs.
Peter mentioned that the process functions in Houdini which operate on set types
of VDB grids could be changed to take a tuple of types to allow for cleaner
instantiation of supported grid types across Houdini SOPs.
TAC meeting discussed versioning. All projects should be using the same type of
versioning. Semantic versioning was the common thread.
OpenVDB ABI only for grid compatibility. Nick asked if this was written down
anywhere, it doesn't seem to be. Dan mentioned the issue with unsupported file
format warnings causing lots of confusion.
Peter asked about Clarisse render hooks for VDB points. Nick: we tried something
like this in the past but never completed it. Clarisse tools which work on
VDB Points pass around the grids with a final conversion to Clarisse geometry
when rendered.
Dan brought up the removal of deprecation warnings. Dan to write a proposal on
our deprecation policy to vote on at the next TSC meeting.
Jeff: should we remove GU/GR Prim VDB from the repository. Consensus was that as
long as they build, they are good to stay.
Andrew, chat log: is there someone that I can send the CII certification
spreadsheet document to so the TSC can begin to own the completion of the process?
We'll continue to help complete it as we can, but I think ownership of the doc
should transfer to the TSC.
8) The next TSC meeting is TBC. Pending agenda, this will either be on Feb 21st
or Feb 28th, 2019, 11am-12pm PST.
| 5,918 | Markdown | 47.917355 | 82 | 0.794356 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-01-31.md | Minutes from 7th OpenVDB TSC meeting, Jan. 31, 2019
Attendees: John M., *Jeff* L., *Nick* A., *Ken* M., *Peter* C., *Dan* B., Andrew P.
Additional Attendees: Bruce Chernia (Intel), Thanh Ha
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) TAC Presentation 2/7 (Ken)
4) SIGGRAPH Course (Ken)
5) Plans and roadmap (all)
6) Release process (Peter)
7) Web site (?)
8) CI/Jira update (Dan)
9) Other?
10) Schedule next meeting
1) Quorum was confirmed
2) Secretary - Dan Bailey.
3) TAC Presentation 2/7
Ken to present a 3-slide summary of the OpenVDB project since being accepted to
ASWF to the TAC. Dan to summarize and send Ken pull request stats before and
after acceptance. Dan and Jeff highlighted the improved process since being part
of ASWF and Peter concurred it had eased his workflow.
A roadmap for further process improvements was mentioned - Peter suggested we
better codify the process for contributing to OpenVDB as a non-TSC member,
including guidelines around code coverage and unit testing as well as a GitHub
check for the CLA. John to check on launch of an official CLA system from LF
using Docusign that would help with this. Thanh mentioned that he thought the
rollout had been delayed slightly.
4) Siggraph Course
Ken has shared a Google doc to collaborate on presentation details. He would
like to see some production-friendly sessions as well as features of the
library. Deadline is 12th February.
5) Plans and roadmap
Nick, Ken, Dan and Jeff all shared summaries of features they wish to
contribute, wish lists and desired library cleanup. Aim to put as much
functionality into the next release in time for next major release of Houdini.
This is intended to be broad bullet-points for now. Some more detail shared
through Google Docs, but a few highlights and points of discussion:
Nick:
* tools to merge, rasterize and surface VDB Points, Jeff suggested where SOPs
didn't support Houdini points to convert them into VDB points on-the-fly
* restructuring SOPs to move implementation details up into core library where
they can be unit tested - Remove Divergence SOP was highlighted as a good
example of where this is needed
* a Reduce SOP for performing deterministic reduction of volumes, Ken suggested
looking at using some of the functionality in tools/Diagnostics.h that solves
some of these problems, Jeff considering extending Volume Reduce SOP to support
VDBs
* performance of Advect SOP compared with Houdini volume advection, Jeff and Ken
mentioned that the bottleneck was the front-tracking that would make it hard to
get comparable performance but perhaps still improvements to be made
* core AX features include sampling and rasterization in order to reach a v1.0
for Siggraph
Ken:
* tools Ken has completed and wishes to push up soon include fast sweeping,
finding all active values within a bounding box, MLS and some higher-level
tools and higher-order alternatives to existing methods
* a more efficient way of building masks from meshes that doesn't use levelsets
* Ken would like a read-only out-of-core grid that allows for random-access with
a memory limit to page data in and out automatically. Jeff suggested looking at
a similar solution in OpenImageIO for inspiration in paging in and out tiles of
textures
Dan:
* wishlist includes distributed computing tools, faster levelset segmentation,
faster resampling of masks and more solvers including multigrid, FFT and
variational solves
* working on some higher-level sample applications
* better parallelization of multiple VDBs through combine SOP, Nick suggested
trying to put the existing combine SOP into a foreach SOP
* various VDB Points improvements include strided attribute arrays, dynamic
attribute arrays, curves and poly soups as well as a SOP to support creation,
delete, casting, renaming, etc of attributes
* extend point moving to support merging additional grids and work with Nick on
coming up with a common API for point merging
Jeff:
* would like to see a GPU representation of OpenVDB, may consider writing one
* 2D grids for OpenVDB would be useful for terrain, Ken mentioned using a
different leaf size but Jeff would like it kept consistent with standard 3D grid
configuration (ie 8x8 voxels)
* Dan asked about SideFX potentially contributing the VDB SOP and VDB Activate
SOP to help to unify open-source/DWA SOPs and SideFX SOPs
6) Release process
Not covered due to time constraints.
7) Web site
John highlighted an issue with the DNS of the website and Peter mentioned that
some of the download links are currently broken. Peter to ask Andrew (who had
just left the meeting).
8/9) CI/Jira update and Other
Jeff has signed into ASWF JIRA now.
Ken now the only TSC member that hasn't signed into JIRA (https://jira.aswf.io)
or accepted GitHub write permissions
(https://github.com/AcademySoftwareFoundation/openvdb/invitations). However, he
does now have a signed CLA from Weta.
10) The next TSC meeting is scheduled for Thursday Feb 14, 2019, 11am-12pm PST.
Note that the meeting scheduled for next week is cancelled due to a clash with
the presentations to the TAC.
| 5,128 | Markdown | 39.385826 | 83 | 0.795047 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-05-02.md | Minutes from 15th OpenVDB TSC meeting, May 2, 2019
Attendees: *Ken* M., *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel)
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) Status update (6.1)
4) Release schedule
5) SIGGRAPH (course and BOF)
6) Response to MRES
7) Other
8) Schedule next meeting
1) A quorum was confirmed
2) Secretary - Nick Avramoussis
3) Status update (6.1)
The CMake refactor (#382) and Circle CI frameworks (#409) have been
merged and a ticket has been created to track outstanding CMake and
CI work (https://jira.aswf.io/browse/OVDB-89). There were a few minor
updates to the CMake implementation after merge, notably adding missing
unit tests to the source file list. #378 (warnings as errors) has also
been merged. A few outstanding PRs exist for 6.1; CMake syntax
improvements and Houdini deprecations.
The deprecations of some Houdini utility functions initiated discussion
on the Houdini utilities deployed with OpenVDB. Some are not actively
being used in the OpenVDB codebase. The original source of these methods
stems from a separate standalone library being used at Dreamworks. They
are a useful place for generalized Houdini development tools. It would
be worth considering a separate module for the Houdini utilities which
doesn't depend on OpenVDB (but could still be deployed with it). There
is interest outside of OpenVDB for users wishing to use some of these
methods, but who don't want to rely on or pull in an unnecessary OpenVDB
dependency.
Some methods in particular worth discussing. duplicateSourceStealable()
could be removed though it would force any users inheriting from
SOP_OpenVDBNode to verbify their SOPs to gain similar performance
benefits. Note that as long as a sop is marked as INPLACE, mainline
Houdini will perform a "duplicateSourceStealable" in the same
circumstances. Consensus to mark as deprecated for now. It would be worth
taking another look at the DS Houdini workflow for parameters to
better resolve parameter dependencies for verbified SOPs
(https://jira.aswf.io/browse/OVDB-22). Currently VDB doesn't know how
to handle 'disable whens' when resolving these. ScopedInputLock to
remain in place. OP_NodeChain was being used in the OpenVDB Filter
nodes but has been removed as part of removing the pre 16.5 logic (for
non verbified nodes). The Houdini mindset on these types of methods is
that nodes should not be analyzing the surrounding graph network for
optimizations. OP_NodeChain is theoretically slightly more efficient
than the verbification implementation as it doesn't need to construct
duplicates of the same filter classes, but the performance differences
should be minimal.
4) Release schedule
Consensus to release 6.1.0 early next week (beginning 6th May). The CI
has been completely transitioned to circle and travis implementation
has been removed. The Makefile is no longer being tested. AppVeyor is
running. We're still missing a Mac and Maya CI build. The TAC is
moving towards Azure pipelines over circle.
5) SIGGRAPH
The SIGGRAPH course has been accepted and there will also be an OpenVDB
Birds of a Feather with a block of time just for the OpenVDB TSC
(allocated by the ASWF). We should continue to collect course material
for submission and clarify the submission requirements and deadlines.
6) Response to MRES
Ken to put together an initial document with some feedback from the TSC
which other can extend. Primary question is that we're still unclear
why a stack of OpenVDB grids is not necessary better or as valid an
approach to the currently proposed MRES structure. We would ultimately
like to see a solution to one of the proposed problems outlined in the
response.
Discussion lead to OpenVDBs Tree resolution flexibility at compile
time. It was proposed to consider locking down the available Tree
templates instantiations to improve portability and compile times
whilst decreasing code bloat. It's still not clear if this is a
realistic goal due as we're unsure how users (if at all) are
utilizing the available flexibility of the Tree node structures and
how exactly we would introduce these limitations.
Additional discussion on the idea of a read only Tree (static or const)
following on from last weeks metadata conversation. It's not clear
what a static Tree configuration (specialized with potentially a
different ABI) would give over a const Tree, but it would be worth
exploring this idea.
7) Other
Briefly discussed the idea of blog posts and other more "user friendly"
ways of relaying documentation as alternatives to doxygen.
8) Next Meeting
May 9th 2019. 3pm-4pm EDT (GMT-4).
| 4,663 | Markdown | 42.185185 | 73 | 0.801844 |
NVIDIA-Omniverse/ext-openvdb/tsc/meetings/2019-04-25.md | Minutes from 14th OpenVDB TSC meeting, April 25, 2019
Attendees: *Nick* A., *Dan* B., *Peter* C., *Jeff* L.
Additional Attendees: Bruce Chernia (Intel), Andrew Pearce (DWA)
Regrets: *Ken* M.
Agenda:
1) Confirmation of quorum
2) Selection of secretary
3) VDB Visualize Changes
4) CMake Update
1) A quorum was confirmed. Dan chaired.
2) Secretary - Jeff Lait
3) VDB Visualize Changes
Proposal to remove meshing options from the open source version to
have it match the SideFX version. Unanimous consent.
It is too many clicks to setup the visualize to put-values-on-points
to work with the spreadsheet. Suggestion is to make a shelf
tool that shows up in the tab menu only to alias that functionality
(like how Extract All Points works in 17.5) Any change will
wait until after 6.1
4) CMake Update
It is unclear how much detail goes into readme vs the doxygen,
especially as doxygen only shows up after build, or from the
website that is out of date. Will merge and figure these
out afterwards as we want CI stabilized first.
VRay has to be installed only into one directory, the mantra
specific dso, not both.
Current CMake rules make it hard to install one SOP. (Not build,
install) Commenting out unwanted SOPs in the build list doesn't
work as some build rules refer to SOPs specifically. In particular,
the OpenVDB Write.
An uninstall target, while not common practice, would be useful.
Lint integration will be delayed until after CMake PR is successful.
Should we auto-install all available dependencies, or demand the
default library match a core requirement? In particular is BLOSC
which people are unlikely to have installed. OTOH, if you build
VDB without BLOSC you will not be able to inter-operate. Conclusion
was to require BLOSC by default.
We should make a list of missing CMake features so we can slowly
check them off.
5) Circle vs Azure
Azure is currently gcc 5.4 and slower. And Circle's Debian is nicer
to work with. But Azure has all 3 main platforms and supports GPU.
6) 6.1 Release
The deprecation ticket is complete.
VDB Point issue has had advection tested and is fine.
Note that ragged arrays are supported in Houdini and VDB Points, but not
in the glue between them. Probably should be.
Warnings as errors is almost finsihed.
7) Bug reporting
For bugs that come within the TSC, submit with JIRA.
8) Standard Types
3rd party uses uint32 datatype in VDB to Points, rendering their files
unreadable with standard install. Lack of uint32 is an intentional
choice to avoid type explosion. It is agreed the problems of unsigned
are not worth saving a bit, if you are at that boundary you should
just go to int64. Or, if absolutely necessary, cast on the client
end.
We should add a comment in the core library where types are registered
providing our reasoning and warning against adding a type there.
Registering a type from outside the core library should be locked
and generate a warning to avoid people accidentally becoming
incompatible.
9) VDB Course
Course approved! Everyone should do the rights management.
10) Renderman Handoff
Renderman requires a MIPMAP of min/max values, likely for early culling
and partial loading.
Not clear if this has to be a power of 2 pyramid, or could be min/max
on tiles.
Concerns about live min/max data in the VDB structure is it will be
swiftly out of date and cause confusion. Solved for pipelines by
always regenerating on write and ignoring any already on the
grid.
If load data from an old version that doesn't know how to regenerate
on write, throw away the data.
We need more clarity about what this metadata would consist of.
11) Next Meeting
May 2nd 2019. 3pm-4pm EDT (GMT-4).
| 3,713 | Markdown | 29.694215 | 72 | 0.778885 |
NVIDIA-Omniverse/IsaacSim-dockerfiles/README.md | # Isaac Sim Dockerfiles
## Introduction
This repository contains Dockerfiles for building an Isaac Sim container.
### Pre-Requisites
Before getting started, ensure that the system has the latest [NVIDIA Driver](https://www.nvidia.com/en-us/drivers/unix/) and the [NVIDIA Container Toolkit](https://github.com/NVIDIA/nvidia-docker) installed.
Use your [NGC Account](https://docs.nvidia.com/ngc/ngc-overview/index.html#registering-activating-ngc-account) to get access to the [Isaac Sim Container](https://catalog.ngc.nvidia.com/orgs/nvidia/containers/isaac-sim) and generate your [NGC API Key](https://docs.nvidia.com/ngc/ngc-overview/index.html#generating-api-key).
## Build
Clone this repository and then build the image:
```bash
docker login nvcr.io
docker build --pull -t \
isaac-sim:2023.1.0-ubuntu22.04 \
--build-arg ISAACSIM_VERSION=2023.1.0 \
--file Dockerfile.2023.1.0-ubuntu22.04 .
```
## Usage
To run the container and start Isaac Sim as a headless app:
```bash
docker run --name isaac-sim --entrypoint bash -it --gpus all -e "ACCEPT_EULA=Y" --rm --network=host \
-e "PRIVACY_CONSENT=Y" \
-v ~/docker/isaac-sim/cache/kit:/isaac-sim/kit/cache:rw \
-v ~/docker/isaac-sim/cache/ov:/root/.cache/ov:rw \
-v ~/docker/isaac-sim/cache/pip:/root/.cache/pip:rw \
-v ~/docker/isaac-sim/cache/glcache:/root/.cache/nvidia/GLCache:rw \
-v ~/docker/isaac-sim/cache/computecache:/root/.nv/ComputeCache:rw \
-v ~/docker/isaac-sim/logs:/root/.nvidia-omniverse/logs:rw \
-v ~/docker/isaac-sim/data:/root/.local/share/ov/data:rw \
-v ~/docker/isaac-sim/documents:/root/Documents:rw \
isaac-sim:2023.1.0-ubuntu22.04 \
./runheadless.native.sh -v
```
To run the container and start Isaac Sim as a windowed app:
```bash
xhost +
docker run --name isaac-sim --entrypoint bash -it --gpus all -e "ACCEPT_EULA=Y" --rm --network=host \
-e "PRIVACY_CONSENT=Y" \
-v $HOME/.Xauthority:/root/.Xauthority \
-e DISPLAY \
-v ~/docker/isaac-sim/cache/kit:/isaac-sim/kit/cache:rw \
-v ~/docker/isaac-sim/cache/ov:/root/.cache/ov:rw \
-v ~/docker/isaac-sim/cache/pip:/root/.cache/pip:rw \
-v ~/docker/isaac-sim/cache/glcache:/root/.cache/nvidia/GLCache:rw \
-v ~/docker/isaac-sim/cache/computecache:/root/.nv/ComputeCache:rw \
-v ~/docker/isaac-sim/logs:/root/.nvidia-omniverse/logs:rw \
-v ~/docker/isaac-sim/data:/root/.local/share/ov/data:rw \
-v ~/docker/isaac-sim/documents:/root/Documents:rw \
isaac-sim:2023.1.0-ubuntu22.04 \
./runapp.sh
```
Connect to Isaac Sim using the [Omniverse Streaming Client](https://docs.omniverse.nvidia.com/streaming-client/latest/user-manual.html).
See [Container Deployment](https://docs.omniverse.nvidia.com/isaacsim/latest/install_container.html#container-deployment) for information on container deployment.
## Licensing
The source code in this repository is licensed under [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0).
The resulting container images are licensed under the [NVIDIA Omniverse License Agreement](https://developer.nvidia.com/omniverse/license).
## Support
* Please use [NVIDIA Developer Forums](https://forums.developer.nvidia.com/c/omniverse/simulation/69) for questions and comments.
* See [Isaac Sim Documentation](https://docs.omniverse.nvidia.com/isaacsim/latest/index.html) for more information.
| 3,315 | Markdown | 41.51282 | 323 | 0.732127 |
NVIDIA-Omniverse/kit-extension-template-cpp/VERSION.md | 105.1 | 5 | Markdown | 4.999995 | 5 | 0.8 |
NVIDIA-Omniverse/kit-extension-template-cpp/repo.toml | ########################################################################################################################
# Repo tool base settings
########################################################################################################################
[repo]
# Use the Kit Template repo configuration as a base. Only override things specific to the repo.
import_configs = ["${root}/_repo/deps/repo_kit_tools/kit-template/repo.toml"]
# Repository Name
name = "kit-extension-template-cpp"
[repo_build]
msbuild.vs_version = "vs2019"
post_build.commands = []
[repo_docs]
name = "Kit Extension Template C++"
project = "kit-extension-template-cpp"
api_output_directory = "api"
use_fast_doxygen_conversion=false
sphinx_version = "4.5.0.2-py3.10-${platform}"
sphinx_exclude_patterns = [
"_build",
"tools",
"VERSION.md",
"source/extensions/*/docs/Overview.md",
"source/extensions/*/docs/CHANGELOG.md",
"source/extensions/*/README.md",
]
[repo_docs.kit]
extensions = [
"omni.example.cpp.actions",
"omni.example.cpp.commands",
"omni.example.cpp.hello_world",
"omni.example.cpp.omnigraph_node",
"omni.example.cpp.pybind",
"omni.example.cpp.ui_widget",
"omni.example.cpp.usd",
"omni.example.cpp.usd_physics",
"omni.example.cpp.usdrt",
"omni.example.python.hello_world",
"omni.example.python.ui",
"omni.example.python.usdrt",
]
[repo_package.packages."platform:windows-x86_64".docs]
windows_max_path_length = 0
| 1,492 | TOML | 28.859999 | 120 | 0.577748 |
NVIDIA-Omniverse/kit-extension-template-cpp/README.md | # Omniverse Kit C++ Extension Template
This project contains everything necessary to develop extensions that contain C++ code, along with a number of examples demonstrating best practices for creating them.
## What Are Extensions?
While an extension can consist of a single `extension.toml` file, most contain Python code, C++ code, or a mixture of both:
```
Kit
|
___________________________________|___________________________________
| | |
Python Only C++ Only Mixed
(eg. omni.example.python.hello_world) (eg. omni.example.cpp.hello_world) (eg. omni.example.cpp.pybind)
```
Extensive documentation detailing what extensions are and how they work can be found [here](https://docs.omniverse.nvidia.com/py/kit/docs/guide/extensions.html).
## Getting Started
1. Clone the [GitHub repo](https://github.com/NVIDIA-Omniverse/kit-extension-template-cpp) to your local machine.
2. Open a command prompt and navigate to the root of your cloned repo.
3. Run `build.bat` to bootstrap your dev environment and build the example extensions.
4. Run `_build\{platform}\release\omni.app.example.extension_browser.bat` to open an example kit application.
- Run `omni.app.example.viewport.bat` instead if you want the renderer and main viewport to be enabled.
- Run `omni.app.kit.dev.bat` instead if you want the full kit developer experience to be enabled.
5. From the menu, select `Window->Extensions` to open the extension browser window.
6. Enter `omni.example.cpp` in the search bar at the top of the extension browser window to view the example extensions included with this repo.
## Debugging C++ Extensions
1. Run `build.bat` (if you haven't already) to generate the solution file.
2. Open `_compiler\vs2019\kit-extension-template-cpp.sln` using Visual Studio 2019.
3. Select `omni.app.example.extension_browser` as the startup project (if it isn't already).
- Select `omni.app.example.viewport` instead if you want the renderer and main viewport to be enabled.
- Select `omni.app.kit.dev` instead if you want the full kit developer experience to be enabled.
4. Run/debug the example kit application, using the extension browser window to enable/disable extensions.
## Creating New C++ Extensions
1. Copy one of the existing extension examples to a new folder within the `source/extensions` folder.
- The name of the new folder will be the name of your new extension.
- The **omni** prefix is reserved for NVIDIA applications and extensions.
2. Update the fields in your new extension's `config/extension.toml` file as necessary.
3. Update your new extension's `premake5.lua` file as necessary.
4. Update your new extension's C++ code in the `plugins` folder as necessary.
5. Update your new extension's Python code in the `python` folder as necessary.
6. Update your new extension's Python bindings in the `bindings` folder as necessary.
7. Update your new extension's documentation in the `docs` folder as necessary.
8. Run `build.bat` to build your new extension.
9. Refer to the *Getting Started* section above to open the example kit application and extension browser window.
10. Enter the name of your new extension in the search bar at the top of the extension browser window to view it.
## Generating Documentation
1. Run `repo.bat docs` to generate the documentation for the repo, including all extensions it contains.
- You can generate the documentation for a single extension by running `repo.bat docs -p {extension_name}`
2. Open `_build/docs/kit-extension-template-cpp/latest/index.html` to view the generated documentation.
## Publishing
Developers can publish publicly hosted extensions to the community extension registry using the following steps:
1. Tag the GitHub repository with the **[omniverse-kit-extension](https://github.com/topics/omniverse-kit-extension)** tag.
2. Create a [GitHub release](https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository).
3. Upload the packaged extension archives, created with `./repo.bat package` on Windows or `./repo.sh package` on Linux, to the GitHub release. You must rename the packaged extension archive to match the following convention:
- Linux: `{github-namespace}-{github-repository}-linux-x86_64-{github-release-tag}.zip`
- Windows: `{github-namespace}-{github-repository}-windows-x86_64-{github-release-tag}.zip`
For example, the v0.0.2 release of the extension at <https://github.com/jshrake-nvidia/kit-community-release-test/releases/tag/v0.0.2> has archives named `jshrake-nvidia-kit-community-release-test-linux-x86_64-v0.0.2.zip` and `jshrake-nvidia-kit-community-release-test-windows-x86_64-v0.0.2.zip` for Linux and Windows, respectively.
Our publishing pipeline runs nightly and discovers any publicly hosted GitHub repository with the `omniverse-kit-extension` tag. The published extensions should be visible in the community registry the day following the creation of a GitHub release.
Refer to [the kit extension documentation](https://docs.omniverse.nvidia.com/kit/docs/kit-manual/latest/guide/extensions_advanced.html#package-writetarget) for how to specify the Kit version compatibility for your extension. This ensures that the correct version of your extension is listed in any given Kit application.
## Contributing
The source code for this repository is provided as-is and we are not accepting outside contributions.
| 5,806 | Markdown | 62.119565 | 332 | 0.728557 |
NVIDIA-Omniverse/kit-extension-template-cpp/index.rst | Kit C++ Extension Template
##########################
.. mdinclude:: README.md
Example Extensions
##################
* `omni.example.cpp.actions <../../omni.example.cpp.actions/latest/index.html>`_
* `omni.example.cpp.commands <../../omni.example.cpp.commands/latest/index.html>`_
* `omni.example.cpp.hello_world <../../omni.example.cpp.hello_world/latest/index.html>`_
* `omni.example.cpp.omnigraph_node <../../omni.example.cpp.omnigraph_node/latest/index.html>`_
* `omni.example.cpp.pybind <../../omni.example.cpp.pybind/latest/index.html>`_
* `omni.example.cpp.ui_widget <../../omni.example.cpp.ui_widget/latest/index.html>`_
* `omni.example.cpp.usd <../../omni.example.cpp.usd/latest/index.html>`_
* `omni.example.cpp.usd_physics <../../omni.example.cpp.usd_physics/latest/index.html>`_
* `omni.example.cpp.usdrt <../../omni.example.cpp.usdrt/latest/index.html>`_
* `omni.example.python.hello_world <../../omni.example.python.hello_world/latest/index.html>`_
* `omni.example.python.ui <../../omni.example.python.ui/latest/index.html>`_
* `omni.example.python.usdrt <../../omni.example.python.usdrt/latest/index.html>`_
| 1,126 | reStructuredText | 52.666664 | 94 | 0.67762 |
NVIDIA-Omniverse/kit-extension-template-cpp/deps/repo-deps.packman.xml | <project toolsVersion="5.0">
<dependency name="repo_build" linkPath="../_repo/deps/repo_build">
<package name="repo_build" version="0.52.0" checksum="39dfc49adb0839b203aec3279b8a1bd8327b2f7de2a7ed231991bdbd22d1f9e9" />
</dependency>
<dependency name="repo_changelog" linkPath="../_repo/deps/repo_changelog">
<package name="repo_changelog" version="0.3.13" checksum="63ede6e88417131acd3d5d257307c931d2165b7750e4c202c08514568b39c05f" />
</dependency>
<dependency name="repo_docs" linkPath="../_repo/deps/repo_docs">
<package name="repo_docs" version="0.37.3" checksum="78bd6488c1cd7295ab6728d9cd0b79fac3684598bcaebefad710fc79e3a7b8ea" />
</dependency>
<dependency name="repo_kit_tools" linkPath="../_repo/deps/repo_kit_tools">
<package name="repo_kit_tools" version="0.13.42" checksum="e4b2cfdc4054b4975c2c1e913cd38f4df33dc5385370d622cb95e4b153f06624" />
</dependency>
<dependency name="repo_licensing" linkPath="../_repo/deps/repo_licensing">
<package name="repo_licensing" version="1.12.0" checksum="2fa002302a776f1104896f39c8822a8c9516ef6c0ce251548b2b915979666b9d" />
</dependency>
<dependency name="repo_man" linkPath="../_repo/deps/repo_man">
<package name="repo_man" version="1.46.2" checksum="195f1ce8ea953cd61392904817344707ca17e3ac215d0bdc72af50a509358781" />
</dependency>
<dependency name="repo_package" linkPath="../_repo/deps/repo_package">
<package name="repo_package" version="5.9.2" checksum="3b870e71b09d6cb7a7b48385da268275e675a141cb408581a2581733452fdff8" />
</dependency>
<dependency name="repo_format" linkPath="../_repo/deps/repo_format">
<package name="repo_format" version="2.8.0" checksum="37c365c0579091336a9f4e608644207eaf8f07ee997d6daef4ea673d5c7bfb48" />
</dependency>
<dependency name="repo_source" linkPath="../_repo/deps/repo_source">
<package name="repo_source" version="0.4.3" checksum="24e602070cb95ea03c9930da7108f9a693f2d7920a4ee9ba3b6ca4f2f7e45f33" />
</dependency>
<dependency name="repo_test" linkPath="../_repo/deps/repo_test">
<package name="repo_test" version="2.18.2" checksum="9d6a1b86367b791a5b39369c28ed83600a760d3bb2b7ed61ff7dbb206a777192" />
</dependency>
</project>
| 2,194 | XML | 65.51515 | 131 | 0.760711 |
NVIDIA-Omniverse/kit-extension-template-cpp/deps/kit-sdk.packman.xml | <project toolsVersion="5.0">
<!-- We always depend on the release kit-sdk package, regardless of config -->
<dependency name="kit_sdk_${config}" linkPath="../_build/${platform}/${config}/kit" tags="${config} non-redist">
<package name="kit-sdk" version="105.1.0+release.51.a7407fb5.tc.windows-x86_64.release" platforms="windows-x86_64" checksum="aa561b1037c434fe1dc450238f99c077327ca47482e34e0cf0cb96b5a4d5e037" />
<package name="kit-sdk" version="105.1.0+release.51.a7407fb5.tc.linux-x86_64.release" platforms="linux-x86_64" checksum="57d69c91f185491cc1f8181062c908f5389d5e2b780efd20aa9ed6187e12328d" />
</dependency>
</project>
| 644 | XML | 79.62499 | 197 | 0.754658 |
NVIDIA-Omniverse/kit-extension-template-cpp/deps/host-deps.packman.xml | <project toolsVersion="5.0">
<dependency name="premake" linkPath="../_build/host-deps/premake">
<package name="premake" version="5.0.0-alpha15.dev+pipeline3388156.1f299ea4-windows-x86_64" checksum="b1e5dcef9acf47b0c86a4630afa4fadc9485b878e25e4321ac5afbb826bbdf93" platforms="windows-x86_64" />
<package name="premake" version="5.0.0-alpha15.dev+pipeline3388156.1f299ea4-linux-x86_64" checksum="ae15e63cf6d53571fa3bdfa33ddcec8a3be90675cdd155590a26bcd75d04d73f" platforms="linux-x86_64" />
</dependency>
<dependency name="msvc" linkPath="../_build/host-deps/msvc">
<package name="msvc" version="2019-16.7.6-license" platforms="windows-x86_64" checksum="0e37c0f29899fe10dcbef6756bcd69c2c4422a3ca1101206df272dc3d295b92d" />
</dependency>
<dependency name="winsdk" linkPath="../_build/host-deps/winsdk">
<package name="winsdk" version="10.0.18362.0-license" platforms="windows-x86_64" checksum="2db7aeb2278b79c6c9fbca8f5d72b16090b3554f52b1f3e5f1c8739c5132a3d6" />
</dependency>
</project>
| 1,012 | XML | 76.923071 | 201 | 0.778656 |
NVIDIA-Omniverse/kit-extension-template-cpp/deps/kit-sdk-deps.packman.xml | <project toolsVersion="5.0">
<!-- Import dependencies from Kit SDK to ensure we're using the same versions. -->
<import path="../_build/${platform}/${config}/kit/dev/all-deps.packman.xml">
<filter include="carb_sdk_plugins"/>
<filter include="cuda"/>
<filter include="doctest"/>
<filter include="pybind11"/>
<filter include="python"/>
</import>
<!-- Override the link paths to point to the correct locations. -->
<dependency name="carb_sdk_plugins" linkPath="../_build/target-deps/carb_sdk_plugins"/>
<dependency name="cuda" linkPath="../_build/target-deps/cuda"/>
<dependency name="doctest" linkPath="../_build/target-deps/doctest"/>
<dependency name="pybind11" linkPath="../_build/target-deps/pybind11"/>
<dependency name="python" linkPath="../_build/target-deps/python"/>
</project>
| 826 | XML | 42.526314 | 89 | 0.679177 |
NVIDIA-Omniverse/kit-extension-template-cpp/deps/ext-deps.packman.xml | <project toolsVersion="5.0">
<!-- Import dependencies from Kit SDK to ensure we're using the same versions. -->
<import path="../_build/${platform}/${config}/kit/dev/all-deps.packman.xml">
<filter include="boost_preprocessor"/>
<filter include="imgui"/>
<filter include="nv_usd_py310_release"/>
</import>
<!-- Override the link paths to point to the correct locations. -->
<dependency name="boost_preprocessor" linkPath="../_build/target-deps/boost-preprocessor"/>
<dependency name="imgui" linkPath="../_build/target-deps/imgui"/>
<dependency name="nv_usd_py310_release" linkPath="../_build/target-deps/nv_usd/release"/>
<!-- Because we always use the release kit-sdk we have to explicitly refer to the debug usd package. -->
<dependency name="nv_usd_py310_debug" linkPath="../_build/target-deps/nv_usd/debug">
<package name="nv-usd" version="22.11.nv.0.2.1058.7d2f59ad-win64_py310_debug-dev_omniverse" platforms="windows-x86_64" checksum="02f7c3477830eb17699cc91774438edd8651f3ec0031582c67093ae3276f360b" />
<package name="nv-usd" version="22.11.nv.0.2.1058.7d2f59ad-linux64_py310-centos_debug-dev_omniverse" platforms="linux-x86_64" checksum="2ac18e0470d05b251a2f36691a1dc1b28da340da92b19175d890addb762adb0f"/>
<package name="nv-usd" version="22.11.nv.0.2.1058.7d2f59ad-linux-aarch64_py310_debug-dev_omniverse" platforms="linux-aarch64" checksum="904ede636008fb011b5f3d66c1a7c2969dfba291dcf1a227fa7503a714f1f18d" />
</dependency>
</project>
| 1,497 | XML | 67.090906 | 210 | 0.739479 |
NVIDIA-Omniverse/kit-extension-template-cpp/tools/repoman/repoman.py | import os
import sys
import io
import contextlib
import packmanapi
REPO_ROOT = os.path.join(os.path.dirname(os.path.realpath(__file__)), "../..")
REPO_DEPS_FILE = os.path.join(REPO_ROOT, "deps/repo-deps.packman.xml")
def bootstrap():
"""
Bootstrap all omni.repo modules.
Pull with packman from repo.packman.xml and add them all to python sys.path to enable importing.
"""
#with contextlib.redirect_stdout(io.StringIO()):
deps = packmanapi.pull(REPO_DEPS_FILE)
for dep_path in deps.values():
if dep_path not in sys.path:
sys.path.append(dep_path)
if __name__ == "__main__":
bootstrap()
import omni.repo.man
omni.repo.man.main(REPO_ROOT)
| 703 | Python | 23.275861 | 100 | 0.661451 |
NVIDIA-Omniverse/kit-extension-template-cpp/tools/packman/packmanconf.py | # Use this file to bootstrap packman into your Python environment (3.7.x). Simply
# add the path by doing sys.insert to where packmanconf.py is located and then execute:
#
# >>> import packmanconf
# >>> packmanconf.init()
#
# It will use the configured remote(s) and the version of packman in the same folder,
# giving you full access to the packman API via the following module
#
# >> import packmanapi
# >> dir(packmanapi)
import os
import platform
import sys
def init():
"""Call this function to initialize the packman configuration.
Calls to the packman API will work after successfully calling this function.
Note:
This function only needs to be called once during the execution of your
program. Calling it repeatedly is harmless but wasteful.
Compatibility with your Python interpreter is checked and upon failure
the function will report what is required.
Example:
>>> import packmanconf
>>> packmanconf.init()
>>> import packmanapi
>>> packmanapi.set_verbosity_level(packmanapi.VERBOSITY_HIGH)
"""
major = sys.version_info[0]
minor = sys.version_info[1]
if major != 3 or minor != 10:
raise RuntimeError(
f"This version of packman requires Python 3.10.x, but {major}.{minor} was provided"
)
conf_dir = os.path.dirname(os.path.abspath(__file__))
os.environ["PM_INSTALL_PATH"] = conf_dir
packages_root = get_packages_root(conf_dir)
version = get_version(conf_dir)
module_dir = get_module_dir(conf_dir, packages_root, version)
sys.path.insert(1, module_dir)
def get_packages_root(conf_dir: str) -> str:
root = os.getenv("PM_PACKAGES_ROOT")
if not root:
platform_name = platform.system()
if platform_name == "Windows":
drive, _ = os.path.splitdrive(conf_dir)
root = os.path.join(drive, "packman-repo")
elif platform_name == "Darwin":
# macOS
root = os.path.join(
os.path.expanduser("~"), "/Library/Application Support/packman-cache"
)
elif platform_name == "Linux":
try:
cache_root = os.environ["XDG_HOME_CACHE"]
except KeyError:
cache_root = os.path.join(os.path.expanduser("~"), ".cache")
return os.path.join(cache_root, "packman")
else:
raise RuntimeError(f"Unsupported platform '{platform_name}'")
# make sure the path exists:
os.makedirs(root, exist_ok=True)
return root
def get_module_dir(conf_dir, packages_root: str, version: str) -> str:
module_dir = os.path.join(packages_root, "packman-common", version)
if not os.path.exists(module_dir):
import tempfile
tf = tempfile.NamedTemporaryFile(delete=False)
target_name = tf.name
tf.close()
url = f"https://bootstrap.packman.nvidia.com/packman-common@{version}.zip"
print(f"Downloading '{url}' ...")
import urllib.request
urllib.request.urlretrieve(url, target_name)
from importlib.machinery import SourceFileLoader
# import module from path provided
script_path = os.path.join(conf_dir, "bootstrap", "install_package.py")
ip = SourceFileLoader("install_package", script_path).load_module()
print("Unpacking ...")
ip.install_package(target_name, module_dir)
os.unlink(tf.name)
return module_dir
def get_version(conf_dir: str):
path = os.path.join(conf_dir, "packman")
if not os.path.exists(path): # in dev repo fallback
path += ".sh"
with open(path, "rt", encoding="utf8") as launch_file:
for line in launch_file.readlines():
if line.startswith("PM_PACKMAN_VERSION"):
_, value = line.split("=")
return value.strip()
raise RuntimeError(f"Unable to find 'PM_PACKMAN_VERSION' in '{path}'")
| 3,933 | Python | 35.425926 | 95 | 0.632596 |
NVIDIA-Omniverse/kit-extension-template-cpp/tools/packman/config.packman.xml | <config remotes="cloudfront">
<remote2 name="cloudfront">
<transport actions="download" protocol="https" packageLocation="d4i3qtqj3r0z5.cloudfront.net/${name}@${version}" />
</remote2>
</config>
| 211 | XML | 34.333328 | 123 | 0.691943 |
NVIDIA-Omniverse/kit-extension-template-cpp/tools/packman/bootstrap/install_package.py | # Copyright 2019 NVIDIA CORPORATION
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# https://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import logging
import zipfile
import tempfile
import sys
import os
import stat
import time
from typing import Any, Callable
RENAME_RETRY_COUNT = 100
RENAME_RETRY_DELAY = 0.1
logging.basicConfig(level=logging.WARNING, format="%(message)s")
logger = logging.getLogger("install_package")
def remove_directory_item(path):
if os.path.islink(path) or os.path.isfile(path):
try:
os.remove(path)
except PermissionError:
# make sure we have access and try again:
os.chmod(path, stat.S_IRWXU)
os.remove(path)
else:
# try first to delete the dir because this will work for folder junctions, otherwise we would follow the junctions and cause destruction!
clean_out_folder = False
try:
# make sure we have access preemptively - this is necessary because recursing into a directory without permissions
# will only lead to heart ache
os.chmod(path, stat.S_IRWXU)
os.rmdir(path)
except OSError:
clean_out_folder = True
if clean_out_folder:
# we should make sure the directory is empty
names = os.listdir(path)
for name in names:
fullname = os.path.join(path, name)
remove_directory_item(fullname)
# now try to again get rid of the folder - and not catch if it raises:
os.rmdir(path)
class StagingDirectory:
def __init__(self, staging_path):
self.staging_path = staging_path
self.temp_folder_path = None
os.makedirs(staging_path, exist_ok=True)
def __enter__(self):
self.temp_folder_path = tempfile.mkdtemp(prefix="ver-", dir=self.staging_path)
return self
def get_temp_folder_path(self):
return self.temp_folder_path
# this function renames the temp staging folder to folder_name, it is required that the parent path exists!
def promote_and_rename(self, folder_name):
abs_dst_folder_name = os.path.join(self.staging_path, folder_name)
os.rename(self.temp_folder_path, abs_dst_folder_name)
def __exit__(self, type, value, traceback):
# Remove temp staging folder if it's still there (something went wrong):
path = self.temp_folder_path
if os.path.isdir(path):
remove_directory_item(path)
def rename_folder(staging_dir: StagingDirectory, folder_name: str):
try:
staging_dir.promote_and_rename(folder_name)
except OSError as exc:
# if we failed to rename because the folder now exists we can assume that another packman process
# has managed to update the package before us - in all other cases we re-raise the exception
abs_dst_folder_name = os.path.join(staging_dir.staging_path, folder_name)
if os.path.exists(abs_dst_folder_name):
logger.warning(
f"Directory {abs_dst_folder_name} already present, package installation already completed"
)
else:
raise
def call_with_retry(
op_name: str, func: Callable, retry_count: int = 3, retry_delay: float = 20
) -> Any:
retries_left = retry_count
while True:
try:
return func()
except (OSError, IOError) as exc:
logger.warning(f"Failure while executing {op_name} [{str(exc)}]")
if retries_left:
retry_str = "retry" if retries_left == 1 else "retries"
logger.warning(
f"Retrying after {retry_delay} seconds"
f" ({retries_left} {retry_str} left) ..."
)
time.sleep(retry_delay)
else:
logger.error("Maximum retries exceeded, giving up")
raise
retries_left -= 1
def rename_folder_with_retry(staging_dir: StagingDirectory, folder_name):
dst_path = os.path.join(staging_dir.staging_path, folder_name)
call_with_retry(
f"rename {staging_dir.get_temp_folder_path()} -> {dst_path}",
lambda: rename_folder(staging_dir, folder_name),
RENAME_RETRY_COUNT,
RENAME_RETRY_DELAY,
)
def install_package(package_path, install_path):
staging_path, version = os.path.split(install_path)
with StagingDirectory(staging_path) as staging_dir:
output_folder = staging_dir.get_temp_folder_path()
with zipfile.ZipFile(package_path, allowZip64=True) as zip_file:
zip_file.extractall(output_folder)
# attempt the rename operation
rename_folder_with_retry(staging_dir, version)
print(f"Package successfully installed to {install_path}")
if __name__ == "__main__":
executable_paths = os.getenv("PATH")
paths_list = executable_paths.split(os.path.pathsep) if executable_paths else []
target_path_np = os.path.normpath(sys.argv[2])
target_path_np_nc = os.path.normcase(target_path_np)
for exec_path in paths_list:
if os.path.normcase(os.path.normpath(exec_path)) == target_path_np_nc:
raise RuntimeError(f"packman will not install to executable path '{exec_path}'")
install_package(sys.argv[1], target_path_np)
| 5,777 | Python | 36.277419 | 145 | 0.645145 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.cpp.tasking/config/extension.toml | [package]
version = "1.0.0" # Semantic Versioning is used: https://semver.org/
# These fields are used primarily for display in the extension browser UI.
title = "Example C++ Extension: Tasking"
description = "Demonstrates how to create a C++ plugin that uses the carb tasking system."
category = "Example"
keywords = ["example", "C++", "cpp", "Async", "Fibers", "Task", "Tasking"]
icon = "data/icon.png"
preview_image = "data/preview.png"
changelog = "docs/CHANGELOG.md"
readme = "docs/README.md"
authors = ["David Bosnich <[email protected]>"]
repository = "https://github.com/NVIDIA-Omniverse/kit-extension-template-cpp"
# Define the Python modules that this extension provides.
# C++ only extensions need this just so tests don't fail.
[[python.module]]
name = "omni.example.cpp.tasking"
# Define the C++ plugins that this extension provides.
[[native.plugin]]
path = "bin/*.plugin"
# Define the documentation that will be generated for this extension.
[documentation]
pages = [
"docs/Overview.md",
"docs/CHANGELOG.md",
]
| 1,041 | TOML | 32.612902 | 90 | 0.71854 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.cpp.tasking/plugins/omni.example.cpp.tasking/ExampleTaskingExtension.cpp | // Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
//
// NVIDIA CORPORATION and its licensors retain all intellectual property
// and proprietary rights in and to this software, related documentation
// and any modifications thereto. Any use, reproduction, disclosure or
// distribution of this software and related documentation without an express
// license agreement from NVIDIA CORPORATION is strictly prohibited.
//
#define CARB_EXPORTS
#include <carb/PluginUtils.h>
#include <carb/tasking/ITasking.h>
#include <carb/tasking/TaskingUtils.h>
#include <omni/ext/IExt.h>
#include <omni/kit/IApp.h>
const struct carb::PluginImplDesc pluginImplDesc = { "omni.example.cpp.tasking.plugin",
"An example C++ extension.", "NVIDIA",
carb::PluginHotReload::eEnabled, "dev" };
CARB_PLUGIN_IMPL_DEPS(omni::kit::IApp)
namespace omni
{
namespace example
{
namespace cpp
{
namespace tasking
{
class ExampleTaskingExtension;
void exampleStandaloneFunctionTask(ExampleTaskingExtension* exampleTaskingExtension);
class ExampleTaskingExtension : public omni::ext::IExt
{
public:
void onStartup(const char* extId) override
{
// Get the tasking interface from the Carbonite Framework.
carb::tasking::ITasking* tasking = carb::getCachedInterface<carb::tasking::ITasking>();
// Add a task defined by a standalone function.
tasking->addTask(carb::tasking::Priority::eDefault, {}, &exampleStandaloneFunctionTask, this);
// Add a task defined by a member function.
tasking->addTask(carb::tasking::Priority::eDefault, {}, &ExampleTaskingExtension::exampleMemberFunctionTask, this);
// Add a task defined by a lambda function.
tasking->addTask(carb::tasking::Priority::eDefault, {}, [this] {
// Artifical wait to ensure this task finishes first.
carb::getCachedInterface<carb::tasking::ITasking>()->sleep_for(std::chrono::milliseconds(1000));
printHelloFromTask("exampleLambdaFunctionTask");
});
}
void onShutdown() override
{
std::lock_guard<carb::tasking::MutexWrapper> lock(m_helloFromTaskCountMutex);
m_helloFromTaskCount = 0;
}
void exampleMemberFunctionTask()
{
// Artifical wait to ensure this task finishes second.
carb::getCachedInterface<carb::tasking::ITasking>()->sleep_for(std::chrono::milliseconds(2000));
printHelloFromTask("exampleMemberFunctionTask");
}
void printHelloFromTask(const char* taskName)
{
std::lock_guard<carb::tasking::MutexWrapper> lock(m_helloFromTaskCountMutex);
++m_helloFromTaskCount;
printf("Hello from task: %s\n"
"%d tasks have said hello since extension startup.\n\n",
taskName, m_helloFromTaskCount);
}
private:
// We must use a fiber aware mutex: https://docs.omniverse.nvidia.com/kit/docs/carbonite/latest/docs/tasking/TaskingBestPractices.html#mutexes
carb::tasking::MutexWrapper m_helloFromTaskCountMutex;
int m_helloFromTaskCount = 0;
};
void exampleStandaloneFunctionTask(ExampleTaskingExtension* exampleTaskingExtension)
{
// Artifical wait to ensure this task finishes last.
carb::getCachedInterface<carb::tasking::ITasking>()->sleep_for(std::chrono::milliseconds(3000));
exampleTaskingExtension->printHelloFromTask("exampleStandaloneFunctionTask");
}
}
}
}
}
CARB_PLUGIN_IMPL(pluginImplDesc, omni::example::cpp::tasking::ExampleTaskingExtension)
void fillInterface(omni::example::cpp::tasking::ExampleTaskingExtension& iface)
{
}
| 3,669 | C++ | 33.952381 | 146 | 0.700736 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.cpp.tasking/omni/example/cpp/tasking/__init__.py | ## Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
##
## NVIDIA CORPORATION and its licensors retain all intellectual property
## and proprietary rights in and to this software, related documentation
## and any modifications thereto. Any use, reproduction, disclosure or
## distribution of this software and related documentation without an express
## license agreement from NVIDIA CORPORATION is strictly prohibited.
##
# This file is needed so tests don't fail.
| 480 | Python | 42.727269 | 77 | 0.785417 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.cpp.tasking/docs/CHANGELOG.md | # Changelog
## [1.0.0] - 2023-01-12
### Added
- Initial implementation.
| 73 | Markdown | 11.333331 | 25 | 0.630137 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.cpp.tasking/docs/Overview.md | # Overview
An example C++ extension that can be used as a reference/template for creating new extensions.
Demonstrates how to create a C++ object that uses the carb tasking system for async processing.
See also: [https://docs.omniverse.nvidia.com/kit/docs/carbonite/latest/docs/tasking/index.html](https://docs.omniverse.nvidia.com/kit/docs/carbonite/latest/docs/tasking/index.html)
# C++ Usage Examples
## Spawning Tasks
```
class ExampleTaskingExtension : public omni::ext::IExt
{
public:
void onStartup(const char* extId) override
{
// Get the tasking interface from the Carbonite Framework.
carb::tasking::ITasking* tasking = carb::getCachedInterface<carb::tasking::ITasking>();
// Add a task defined by a standalone function.
tasking->addTask(carb::tasking::Priority::eDefault, {}, &exampleStandaloneFunctionTask, this);
// Add a task defined by a member function.
tasking->addTask(carb::tasking::Priority::eDefault, {}, &ExampleTaskingExtension::exampleMemberFunctionTask, this);
// Add a task defined by a lambda function.
tasking->addTask(carb::tasking::Priority::eDefault, {}, [this] {
// Artifical wait to ensure this task finishes first.
carb::getCachedInterface<carb::tasking::ITasking>()->sleep_for(std::chrono::milliseconds(1000));
printHelloFromTask("exampleLambdaFunctionTask");
});
}
void onShutdown() override
{
std::lock_guard<carb::tasking::MutexWrapper> lock(m_helloFromTaskCountMutex);
m_helloFromTaskCount = 0;
}
void exampleMemberFunctionTask()
{
// Artifical wait to ensure this task finishes second.
carb::getCachedInterface<carb::tasking::ITasking>()->sleep_for(std::chrono::milliseconds(2000));
printHelloFromTask("exampleMemberFunctionTask");
}
void printHelloFromTask(const char* taskName)
{
std::lock_guard<carb::tasking::MutexWrapper> lock(m_helloFromTaskCountMutex);
++m_helloFromTaskCount;
printf("Hello from task: %s\n"
"%d tasks have said hello since extension startup.\n\n",
taskName, m_helloFromTaskCount);
}
private:
// We must use a fiber aware mutex: https://docs.omniverse.nvidia.com/kit/docs/carbonite/latest/docs/tasking/TaskingBestPractices.html#mutexes
carb::tasking::MutexWrapper m_helloFromTaskCountMutex;
int m_helloFromTaskCount = 0;
};
void exampleStandaloneFunctionTask(ExampleTaskingExtension* exampleTaskingExtension)
{
// Artifical wait to ensure this task finishes last.
carb::getCachedInterface<carb::tasking::ITasking>()->sleep_for(std::chrono::milliseconds(3000));
exampleTaskingExtension->printHelloFromTask("exampleStandaloneFunctionTask");
}
```
| 2,800 | Markdown | 36.346666 | 180 | 0.702143 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/README.md | # omni.example.python.usdrt_mesh
Example Kit extension that demonstrates how to use USDRT to create, update, and delete a UsdGeom.Mesh prim.
## Usage
### Windows
```bash
.\build.bat
.\_build\windows-x86_64\release\kit\kit.exe .\source\apps\omni.app.kit.dev.kit --enable omni.example.python.usdrt_mesh --ext-folder source\extensions --/app/useFabricSceneDelegate=true
```
### Linux
```bash
./build.sh
./_build/linux-x86_64/release/kit/kit ./source/apps/omni.app.kit.dev.kit --enable omni.example.python.usdrt_mesh --ext-folder source/extensions --/app/useFabricSceneDelegate=true
```
| 589 | Markdown | 28.499999 | 184 | 0.743633 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/config/extension.toml | [package]
# Semantic Versioning is used: https://semver.org/
version = "0.0.1"
# Lists people or organizations that are considered the "authors" of the package.
authors = ["Justin Shrake <[email protected]>"]
# The title and description fields are primarily for displaying extension info in UI
title = "Example Python Extension: USDRT Mesh"
description="Example Kit extension that demonstrates how to create, update, and delete a USDRT Mesh"
# Path (relative to the root) or content of readme markdown file for UI.
readme = "docs/README.md"
# URL of the extension source repository.
repository = "https://github.com/NVIDIA-Omniverse/kit-extension-template-cpp"
# One of categories for UI.
category = "Example"
# Keywords for the extension
keywords = ["kit", "example", "usdrt", "scenegraph", "fabric"]
# Location of change log file in target (final) folder of extension, relative to the root.
# More info on writing changelog: https://keepachangelog.com/en/1.0.0/
changelog="docs/CHANGELOG.md"
# Preview image and icon. Folder named "data" automatically goes in git lfs (see .gitattributes file).
# Preview image is shown in "Overview" of Extensions window. Screenshot of an extension might be a good preview image.
preview_image = "data/preview.png"
# Icon is shown in Extensions window, it is recommended to be square, of size 256x256.
icon = "data/icon.png"
# Extension dependencies
[dependencies]
"omni.kit.uiapp" = {}
"usdrt.scenegraph" = {}
"omni.usd" = {}
"omni.kit.primitive.mesh" = {}
"omni.warp" = { optional = true }
# Main python module this extension provides
[[python.module]]
name = "omni.example.python.usdrt_mesh"
[[test]]
waiver = "Just example code, not for production"
#TODO
# Define the documentation that will be generated for this extension.
[documentation]
pages = [
"docs/Overview.md",
"docs/CHANGELOG.md",
] | 1,856 | TOML | 32.160714 | 118 | 0.738685 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/omni/example/python/usdrt_mesh/__init__.py | from .example_python_usdrt_mesh_extension import *
| 51 | Python | 24.999988 | 50 | 0.803922 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/omni/example/python/usdrt_mesh/example_python_usdrt_mesh_extension.py | ## Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved.
##
## NVIDIA CORPORATION and its licensors retain all intellectual property
## and proprietary rights in and to this software, related documentation
## and any modifications thereto. Any use, reproduction, disclosure or
## distribution of this software and related documentation without an express
## license agreement from NVIDIA CORPORATION is strictly prohibited.
##
import carb
import carb.events
import numpy as np
import omni.ext
import omni.kit.app
import omni.ui
import omni.usd
import usdrt
PLANE_SUBDIV = 32
PLANE_EXTENT = 50
PLANE_HEIGHT = 10
PRIM_PATH = f"/World/Plane{PLANE_SUBDIV}x{PLANE_SUBDIV}"
class ExamplePythonUsdrtMeshExtension(omni.ext.IExt):
def on_startup(self, ext_id):
self.sub = None
self.step = 0
self.playing = False
self.init_ui()
def on_shutdown(self):
if self.sub:
self.sub.unsubscribe()
self.sub = None
self.step = 0
self.playing = False
def init_ui(self):
def create_mesh():
stage = get_usdrt_stage()
create_mesh_usdrt(stage, PRIM_PATH, PLANE_SUBDIV, PLANE_SUBDIV)
def delete_mesh():
stage = get_usdrt_stage()
delete_prim_usdrt(stage, PRIM_PATH)
def toggle_update_mesh():
self.playing = not self.playing
if not self.sub:
self.init_on_update()
def toggle_mesh_visibility():
stage = get_usdrt_stage()
prim = stage.GetPrimAtPath(PRIM_PATH)
attr = prim.GetAttribute("_worldVisibility")
val = attr.Get()
attr.Set(not val)
return
def save_stage_to_file():
stage = get_usdrt_stage()
stage.WriteToLayer("example_python_usdrt_mesh_example.usda")
return
self.window = omni.ui.Window("omni.example.python.usdrt_mesh", width=300, height=300)
style = {
# "color": omni.ui.color.WHITE,
# "background_color": omni.ui.color.BLACK,
}
self.window.frame.style = style
with self.window.frame:
with omni.ui.VStack():
with omni.ui.HStack():
omni.ui.Button("Create Plane").set_clicked_fn(create_mesh)
omni.ui.Button("Delete Plane").set_clicked_fn(delete_mesh)
with omni.ui.HStack():
omni.ui.Button("Toggle Update").set_clicked_fn(toggle_update_mesh)
omni.ui.Button("Toggle Visibility").set_clicked_fn(toggle_mesh_visibility)
omni.ui.Button("Save").set_clicked_fn(save_stage_to_file)
def init_on_update(self):
@carb.profiler.profile(zone_name="omni.example.python.usdrt_mesh.on_update")
def on_update(e: carb.events.IEvent):
if not self.playing:
return
try:
stage = get_usdrt_stage()
self.step += 1
update_mesh_usdrt(stage, PRIM_PATH, PLANE_SUBDIV, PLANE_SUBDIV, self.step)
except Exception as e:
carb.log_error(e)
return
update_stream = omni.kit.app.get_app().get_update_event_stream()
self.sub = update_stream.create_subscription_to_pop(on_update, name="omni.example.python.usdrt_mesh.on_update")
return
def get_usdrt_stage() -> usdrt.Usd.Stage:
ctx = omni.usd.get_context()
stage = usdrt.Usd.Stage.Attach(ctx.get_stage_id())
return stage
def create_mesh_usdrt(stage: usdrt.Usd.Stage, prim_path: str, num_x_divisions: int, num_z_divisions: int):
mesh = usdrt.UsdGeom.Mesh.Define(stage, prim_path)
# Create the vertices and face counts
vertices = calculate_mesh_vertices(num_x_divisions, num_z_divisions, 0)
face_vertex_counts = []
face_vertex_indices = []
for z in range(num_z_divisions):
for x in range(num_x_divisions):
vertex0 = z * (num_x_divisions + 1) + x
vertex1 = vertex0 + 1
vertex2 = (z + 1) * (num_x_divisions + 1) + x
vertex3 = vertex2 + 1
face_vertex_counts.append(4)
face_vertex_indices.extend([vertex0, vertex1, vertex3, vertex2])
# Set the mesh data
mesh.CreatePointsAttr().Set(usdrt.Vt.Vec3fArray(vertices))
mesh.CreateFaceVertexCountsAttr().Set(usdrt.Vt.IntArray(face_vertex_counts))
mesh.CreateFaceVertexIndicesAttr().Set(usdrt.Vt.IntArray(face_vertex_indices))
prim = mesh.GetPrim()
# Visibility Attribute
attr = prim.CreateAttribute("_worldVisibility", usdrt.Sdf.ValueTypeNames.Bool, True)
attr.Set(True)
# Set the xform
xformable = usdrt.Rt.Xformable(prim)
xformable.CreateWorldPositionAttr(usdrt.Gf.Vec3d(0.0, 0.0, 0.0))
xformable.CreateWorldScaleAttr(usdrt.Gf.Vec3f(1.0, 1.0, 1.0))
xformable.CreateWorldOrientationAttr(usdrt.Gf.Quatf(0.0, 0.0, 0.0, 1.0))
# Set the extents
bound = usdrt.Rt.Boundable(prim)
world_ext = bound.CreateWorldExtentAttr()
world_ext.Set(
usdrt.Gf.Range3d(
usdrt.Gf.Vec3d(-PLANE_EXTENT, -PLANE_EXTENT, -PLANE_EXTENT),
usdrt.Gf.Vec3d(PLANE_EXTENT, PLANE_EXTENT, PLANE_EXTENT),
)
)
return mesh
def delete_prim_usdrt(stage: usdrt.Usd.Stage, prim_path: str):
stage.RemovePrim(prim_path)
return
def update_mesh_usdrt(stage: usdrt.Usd.Stage, prim_path: str, num_x_divisions: int, num_z_divisions: int, step: int):
# Find the prim
prim = stage.GetPrimAtPath(prim_path)
if not prim.IsValid():
carb.log_verbose(f"Prim at '{prim_path}' is invalid")
return
vertices = calculate_mesh_vertices(num_x_divisions, num_z_divisions, step)
# Set the mesh data
mesh = usdrt.UsdGeom.Mesh(prim)
mesh.CreateVisibilityAttr().Set(True)
mesh.GetPointsAttr().Set(usdrt.Vt.Vec3fArray(vertices))
return mesh
def calculate_mesh_vertices(num_x_divisions: int, num_z_divisions: int, step: int) -> [float]:
x_positions = np.linspace(-PLANE_EXTENT, PLANE_EXTENT, num_x_divisions + 1)
z_positions = np.linspace(-PLANE_EXTENT, PLANE_EXTENT, num_z_divisions + 1)
x_grid, z_grid = np.meshgrid(x_positions, z_positions)
tau = 6.28318
s = 100.0
t = step / s
sx = tau / s
sz = tau / s
y_grid = PLANE_HEIGHT * (np.cos(sx * x_grid + t) + np.sin(sz * z_grid + t))
vertices = np.column_stack((x_grid.flatten(), y_grid.flatten(), z_grid.flatten()))
return vertices.tolist()
| 6,531 | Python | 34.118279 | 119 | 0.62456 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/omni/example/python/usdrt_mesh/tests/__init__.py | ## Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved.
##
## NVIDIA CORPORATION and its licensors retain all intellectual property
## and proprietary rights in and to this software, related documentation
## and any modifications thereto. Any use, reproduction, disclosure or
## distribution of this software and related documentation without an express
## license agreement from NVIDIA CORPORATION is strictly prohibited.
##
| 436 | Python | 47.55555 | 77 | 0.793578 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/docs/CHANGELOG.md | # Changelog
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## [0.1.0] - 2023-12-01
- Initial version
| 137 | Markdown | 18.714283 | 80 | 0.678832 |
NVIDIA-Omniverse/kit-extension-template-cpp/source/extensions/omni.example.python.usdrt_mesh/docs/Overview.md | # USDRT UsdGeom.Mesh Example [omni.example.python.usdrt_mesh]
Example Kit extension that demonstrates how to use USDRT to create, update, and delete a UsdGeom.Mesh prim. Specifically:
- How to create a Usdrt.UsdGeom.Mesh
- How to delete a Usdrt prim
- How to update the vertex buffer data
- How to toggle the mesh visbility
- How to save the Usdrt stage to disk
| 364 | Markdown | 35.499996 | 121 | 0.774725 |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.