url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/1890 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1890/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1890/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1890/events | https://github.com/NVIDIA/NeMo/pull/1890 | 828,812,006 | MDExOlB1bGxSZXF1ZXN0NTkwNTc3NDUz | 1,890 | add qa tutorial | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Cannot root cause why DCO fails"
] | 2021-03-11T06:30:06 | 2021-11-08T21:15:13 | 2021-03-16T21:52:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1890",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1890",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1890.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1890.patch",
"merged_at": null
} | Signed-off-by: Yang Zhang <[email protected]> | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1890/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1890/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1889 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1889/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1889/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1889/events | https://github.com/NVIDIA/NeMo/pull/1889 | 828,737,494 | MDExOlB1bGxSZXF1ZXN0NTkwNTEwNDA3 | 1,889 | fix typo | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-11T05:01:38 | 2021-03-11T06:30:15 | 2021-03-11T06:06:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1889",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1889",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1889.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1889.patch",
"merged_at": "2021-03-11T06:06:41"
} | Signed-off-by: Yang Zhang <[email protected]> | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1889/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1889/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1888 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1888/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1888/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1888/events | https://github.com/NVIDIA/NeMo/pull/1888 | 828,589,347 | MDExOlB1bGxSZXF1ZXN0NTkwMzgwMDk0 | 1,888 | Update ASR pretrained models | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-11T01:52:40 | 2021-05-02T09:16:57 | 2021-03-11T22:12:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1888",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1888",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1888.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1888.patch",
"merged_at": "2021-03-11T22:12:22"
} | # Changelog
- Add pretrained model info for CTC, CTC-BPE models
- ^ for ASR Classificiation models
- Remove old reference to QuartzNet15x5Base-En
Signed-off-by: smajumdar <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1888/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1888/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1887 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1887/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1887/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1887/events | https://github.com/NVIDIA/NeMo/pull/1887 | 828,559,052 | MDExOlB1bGxSZXF1ZXN0NTkwMzU0NDI4 | 1,887 | removing loading of the trained model from the example to prevent mul… | {
"login": "vladgets",
"id": 8079846,
"node_id": "MDQ6VXNlcjgwNzk4NDY=",
"avatar_url": "https://avatars.githubusercontent.com/u/8079846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vladgets",
"html_url": "https://github.com/vladgets",
"followers_url": "https://api.github.com/users/vladgets/followers",
"following_url": "https://api.github.com/users/vladgets/following{/other_user}",
"gists_url": "https://api.github.com/users/vladgets/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vladgets/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vladgets/subscriptions",
"organizations_url": "https://api.github.com/users/vladgets/orgs",
"repos_url": "https://api.github.com/users/vladgets/repos",
"events_url": "https://api.github.com/users/vladgets/events{/privacy}",
"received_events_url": "https://api.github.com/users/vladgets/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 1 alert** when merging 4a0ca9b202c7c01f9d827cf392f0cd7cbb3af566 into 5d80627ca696384dc16e462f1e17efd33917a9dd - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-119caa9229f75b6c349ae1b681724d504f3e2940)\n\n**new alerts:**\n\n* 1 for Unused local variable"
] | 2021-03-11T01:15:32 | 2022-01-11T16:36:50 | 2021-03-11T04:58:03 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1887",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1887",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1887.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1887.patch",
"merged_at": "2021-03-11T04:58:03"
} | …ti gpu bug
Signed-off-by: Vlad Getselevich <[email protected]> | {
"login": "vladgets",
"id": 8079846,
"node_id": "MDQ6VXNlcjgwNzk4NDY=",
"avatar_url": "https://avatars.githubusercontent.com/u/8079846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vladgets",
"html_url": "https://github.com/vladgets",
"followers_url": "https://api.github.com/users/vladgets/followers",
"following_url": "https://api.github.com/users/vladgets/following{/other_user}",
"gists_url": "https://api.github.com/users/vladgets/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vladgets/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vladgets/subscriptions",
"organizations_url": "https://api.github.com/users/vladgets/orgs",
"repos_url": "https://api.github.com/users/vladgets/repos",
"events_url": "https://api.github.com/users/vladgets/events{/privacy}",
"received_events_url": "https://api.github.com/users/vladgets/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1887/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1887/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1886 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1886/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1886/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1886/events | https://github.com/NVIDIA/NeMo/issues/1886 | 828,494,384 | MDU6SXNzdWU4Mjg0OTQzODQ= | 1,886 | [Question] Exporting custom NeMo models to Jarvis (.ejrvs) | {
"login": "xaiguy",
"id": 48219849,
"node_id": "MDQ6VXNlcjQ4MjE5ODQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/48219849?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xaiguy",
"html_url": "https://github.com/xaiguy",
"followers_url": "https://api.github.com/users/xaiguy/followers",
"following_url": "https://api.github.com/users/xaiguy/following{/other_user}",
"gists_url": "https://api.github.com/users/xaiguy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xaiguy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xaiguy/subscriptions",
"organizations_url": "https://api.github.com/users/xaiguy/orgs",
"repos_url": "https://api.github.com/users/xaiguy/repos",
"events_url": "https://api.github.com/users/xaiguy/events{/privacy}",
"received_events_url": "https://api.github.com/users/xaiguy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@xaiguy Can you please clarify what do you mean by \"custom NeMo model\"? \r\nEvery TLT model can be exported to Jarvis. But NeMo contains more models than TLT, including many \"research\" ones which can't be deployed to Jarvis yet.\r\n \r\nWe are constantly increasing the number of models supported by Jarvis by adding them to TLT.\r\n",
"@okuchaiev Oh, pardon the ambiguity. With \"custom\" I just meant models fine-tuned with NeMo, in particular Jasper. I just mentioned TLT because I saw that it's very easy to save and export models to .ejvrs format from there and I was hoping to find something similar for NeMo.",
"I saw a new passage was added to the docs, thanks! I'll close this issue now, as the answer can be found following the link below:\r\n\r\nhttps://docs.nvidia.com/deeplearning/jarvis/user-guide/docs/model-overview.html?highlight=servicemaker#nemo-to-jarvis"
] | 2021-03-10T23:55:59 | 2021-03-11T19:36:34 | 2021-03-11T19:36:34 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Dear NeMo team,
I'm currently looking into Jarvis and haven't found a pre-built way to export my custom NeMo models to .ejrvs format yet, only for TLT. Several sources (including https://developer.nvidia.com/nvidia-nemo) state that it's possible with a single command. If anyone knows the magic words, please let me know. 👍
Kind regards!
PS: I'm using NeMo 1.0.0b3 via the official docker. | {
"login": "xaiguy",
"id": 48219849,
"node_id": "MDQ6VXNlcjQ4MjE5ODQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/48219849?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xaiguy",
"html_url": "https://github.com/xaiguy",
"followers_url": "https://api.github.com/users/xaiguy/followers",
"following_url": "https://api.github.com/users/xaiguy/following{/other_user}",
"gists_url": "https://api.github.com/users/xaiguy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xaiguy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xaiguy/subscriptions",
"organizations_url": "https://api.github.com/users/xaiguy/orgs",
"repos_url": "https://api.github.com/users/xaiguy/repos",
"events_url": "https://api.github.com/users/xaiguy/events{/privacy}",
"received_events_url": "https://api.github.com/users/xaiguy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1886/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1886/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1885 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1885/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1885/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1885/events | https://github.com/NVIDIA/NeMo/pull/1885 | 828,486,248 | MDExOlB1bGxSZXF1ZXN0NTkwMjg5NTg4 | 1,885 | Update tarred ASR dataset creation script | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T23:45:38 | 2021-03-11T22:13:28 | 2021-03-11T06:09:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1885",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1885",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1885.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1885.patch",
"merged_at": "2021-03-11T06:09:29"
} | # Changelog
- Update ASR Tarred dataset creation to support metadata
- Add more tarfiles to dataset
Signed-off-by: smajumdar <[email protected]> | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1885/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1885/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1884 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1884/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1884/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1884/events | https://github.com/NVIDIA/NeMo/pull/1884 | 828,479,705 | MDExOlB1bGxSZXF1ZXN0NTkwMjgzNjg3 | 1,884 | Update tarred ASR dataset creation script | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Wrong branch"
] | 2021-03-10T23:38:01 | 2021-03-10T23:38:51 | 2021-03-10T23:38:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1884",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1884",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1884.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1884.patch",
"merged_at": null
} | # Changelog
- Update ASR Tarred dataset creation to support metadata + add more tarfiles to dataset
Signed-off-by: smajumdar <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1884/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1884/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1883 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1883/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1883/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1883/events | https://github.com/NVIDIA/NeMo/pull/1883 | 828,397,703 | MDExOlB1bGxSZXF1ZXN0NTkwMjEwNDUy | 1,883 | Add Stan's Durations and Gaussian Embedding | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 10 alerts** and **fixes 6** when merging f44c492473364106bcc445a9b723ed3c961f2ac3 into cf23c451ecdc8bd8b0d2bd48103717121780e989 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-0671fc7ef505fcdfab6011715546b767428230d0)\n\n**new alerts:**\n\n* 9 for Unused import\n* 1 for Unnecessary pass\n\n**fixed alerts:**\n\n* 6 for Unused import"
] | 2021-03-10T22:09:34 | 2021-06-14T14:01:31 | 2021-03-11T21:42:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1883",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1883",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1883.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1883.patch",
"merged_at": "2021-03-11T21:42:48"
} | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1883/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1883/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1882 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1882/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1882/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1882/events | https://github.com/NVIDIA/NeMo/pull/1882 | 828,358,360 | MDExOlB1bGxSZXF1ZXN0NTkwMTc1NDQ5 | 1,882 | Renamed pretrained names | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T21:29:21 | 2021-03-11T17:27:03 | 2021-03-11T16:59:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1882",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1882",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1882.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1882.patch",
"merged_at": "2021-03-11T16:59:24"
} | Signed-off-by: nithinraok <[email protected]> | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1882/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1882/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1881 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1881/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1881/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1881/events | https://github.com/NVIDIA/NeMo/pull/1881 | 828,170,624 | MDExOlB1bGxSZXF1ZXN0NTkwMDA4Mjc1 | 1,881 | Adding pre-trained translation models links | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T18:34:27 | 2021-03-12T20:23:00 | 2021-03-12T20:22:55 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1881",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1881",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1881.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1881.patch",
"merged_at": "2021-03-12T20:22:55"
} | Signed-off-by: Oleksii Kuchaiev <[email protected]> | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1881/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1881/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1880 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1880/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1880/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1880/events | https://github.com/NVIDIA/NeMo/pull/1880 | 828,086,131 | MDExOlB1bGxSZXF1ZXN0NTg5OTMxNTUx | 1,880 | Fix for Pre-LN Transformers | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"if the encoders & decoders are basically the same thing, would it make sense to have a single file that they import blocks from?",
"> if the encoders & decoders are basically the same thing, would it make sense to have a single file that they import blocks from?\r\n\r\nThat is already happening to a good extent - both import MultiHeadAttention and PositionWiseFF blocks and that logic lies outside the Encoder/Decoder layers.",
"This pull request **introduces 1 alert** when merging 21a598eb581a78f1dfa171dc1b41d2cb7ca21732 into a33d2794cba9cff5b29044f787e41f654325424a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-afa1324fdce133834d87c84752630c214b1d11cb)\n\n**new alerts:**\n\n* 1 for Unused import",
"LGTM",
"EDIT: it's the same return issue i pointed out.\r\n\r\n\r\ndont merge yet; i am getting some sort of error:\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"examples/nlp/machine_translation/enc_dec_nmt.py\", line 127, in main\r\n trainer.fit(mt_model)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py\", line 513, in fit\r\n self.dispatch()\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py\", line 553, in dispatch\r\n self.accelerator.start_training(self)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/accelerators/accelerator.py\", line 74, in start_training\r\n self.training_type_plugin.start_training(trainer)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py\", line 111, in start_training\r\n self._results = trainer.run_train()\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py\", line 614, in run_train\r\n self.run_sanity_check(self.lightning_module)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py\", line 863, in run_sanity_check\r\n _, eval_results = self.run_evaluation(max_batches=self.num_sanity_val_batches)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py\", line 732, in run_evaluation\r\n output = self.evaluation_loop.evaluation_step(batch, batch_idx, dataloader_idx)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/evaluation_loop.py\", line 164, in evaluation_step\r\n output = self.trainer.accelerator.validation_step(args)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/accelerators/accelerator.py\", line 178, in validation_step\r\n return self.training_type_plugin.validation_step(*args)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/plugins/training_type/ddp.py\", line 290, in validation_step\r\n return self.model(*args, **kwargs)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/parallel/distributed.py\", line 671, in forward\r\n output = self.module(*inputs[0], **kwargs[0])\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/opt/conda/lib/python3.6/site-packages/pytorch_lightning/overrides/base.py\", line 63, in forward\r\n output = self.module.validation_step(*inputs, **kwargs)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py\", line 234, in validation_step\r\n return self.eval_step(batch, batch_idx, 'val')\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py\", line 199, in eval_step\r\n log_probs = self(src_ids, src_mask, tgt_ids, tgt_mask)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/core/classes/common.py\", line 721, in __call__\r\n return wrapped(*args, **kwargs)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py\", line 167, in forward\r\n src_hiddens = self.encoder(src, src_mask)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/modules/common/transformer/transformer.py\", line 103, in forward\r\n encoder_hidden_states = self._encoder(embeddings, encoder_mask)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/modules/common/transformer/transformer_encoders.py\", line 158, in forward\r\n encoder_states = layer(encoder_states, encoder_attn_mask, memory_states)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/modules/common/transformer/transformer_encoders.py\", line 99, in forward\r\n self.forward_preln(encoder_query, encoder_mask, encoder_keys)\r\n File \"/home/dcg-adlr-mchrzanowski-source/NeMo2/nemo/collections/nlp/modules/common/transformer/transformer_encoders.py\", line 70, in forward_preln\r\n encoder_query = self.layer_norm_1(encoder_query)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 727, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/modules/normalization.py\", line 170, in forward\r\n input, self.normalized_shape, self.weight, self.bias, self.eps)\r\n File \"/opt/conda/lib/python3.6/site-packages/torch/nn/functional.py\", line 2072, in layer_norm\r\n torch.backends.cudnn.enabled)\r\nTypeError: layer_norm(): argument 'input' (position 1) must be Tensor, not NoneType\r\n```\r\n\r\nsomewhere in between 3676721 and 9efb1e7",
"Good catch @mchrzanowski . I would have thought one of our tests would have failed for something like this.",
"Nice catch, our CI runs with`pre_ln=false` and this was happening only when `pre_ln=true`. Fixed now."
] | 2021-03-10T17:29:24 | 2021-03-11T17:26:08 | 2021-03-11T17:26:03 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1880",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1880",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1880.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1880.patch",
"merged_at": "2021-03-11T17:26:03"
} | This PR fixes bugs in the Pre-LN implementation in transformer encoders and decoders. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1880/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1880/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1879 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1879/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1879/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1879/events | https://github.com/NVIDIA/NeMo/issues/1879 | 827,706,026 | MDU6SXNzdWU4Mjc3MDYwMjY= | 1,879 | conformer to onnx not working | {
"login": "mutkach",
"id": 5160943,
"node_id": "MDQ6VXNlcjUxNjA5NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/5160943?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mutkach",
"html_url": "https://github.com/mutkach",
"followers_url": "https://api.github.com/users/mutkach/followers",
"following_url": "https://api.github.com/users/mutkach/following{/other_user}",
"gists_url": "https://api.github.com/users/mutkach/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mutkach/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mutkach/subscriptions",
"organizations_url": "https://api.github.com/users/mutkach/orgs",
"repos_url": "https://api.github.com/users/mutkach/repos",
"events_url": "https://api.github.com/users/mutkach/events{/privacy}",
"received_events_url": "https://api.github.com/users/mutkach/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"I think we haven't properly implemented export for Conformer. @VahidooX to comment further. If this isn't supported yet, maybe should raise \"NotImplemented\" exception? ",
"We have not tested the export for Conformer yet. I would raise NotImplemented for now. \r\nUpdate: I fixed the issue with the export function in this PR https://github.com/NVIDIA/NeMo/pull/1898. It is just a part of that PR, and not merged yet. Now it creates the onnx file but there is no guarantee that it works. yet",
"closing since PR is merged"
] | 2021-03-10T13:03:20 | 2021-04-24T00:09:09 | 2021-04-24T00:09:09 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Conformer model export to onnx not working as intended. Onnx export worked ok and did not report anything and onnx.checker.check_model worked without errors too. Loading the onnx file and running the sample audio file causes onnxruntime to die quietly (jupyter just reloads the kernel, and running script just says "segmentation fault")
Steps to reproduce:
load .nemo model for conformer
`model = nemo_asr.models.EncDecCTCModelBPE.restore_from('conformer.nemo')`
export conformer encoder to onnx
`model.encoder.export('conformer_encoder.onnx')`
load onnx in onnxruntime and run through a sample file
```
sess = onnxruntime.InferenceSession(conformer_encoder)
input_name = sess.get_inputs()[0].name
output_name = sess.get_outputs()[0].name
result = sess.run([output_name], {input_name: features})
```
After running these steps I got a segmentation fault error. For feature extraction and onnx export/load I used the same pipeline that I used for jasper models (and it worked perfectly for jasper). Conformer works okay during training and evaluation within nemo and ptl frameworks.
In which case onnxruntime just fails completely without even reporting for something like incorrect dimensions or unsupported operations (like it usually does)?
Maybe I am missing something obvious here?
environment:
DGX-1, Ubuntu 18.04
nemo - up to date
torch - 1.8.0
onnxruntime - 1.6.0
onnxruntime-gpu - 1.4.0
I tried different combination of versions of the libraries but most of them cause the effect as mentioned above and the others fail for other reasons - mostly during the export step. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1879/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1879/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1878 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1878/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1878/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1878/events | https://github.com/NVIDIA/NeMo/pull/1878 | 827,272,839 | MDExOlB1bGxSZXF1ZXN0NTg5MjAxODM4 | 1,878 | self.log and fix top-k acc metrics | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T07:29:37 | 2021-03-10T19:09:22 | 2021-03-10T19:09:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1878",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1878",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1878.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1878.patch",
"merged_at": "2021-03-10T19:09:15"
} | Part of [PR#1777](https://github.com/NVIDIA/NeMo/pull/1777) that should go to 1.0.0RC
Signed-off-by: fayejf <[email protected]> | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1878/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1878/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1877 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1877/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1877/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1877/events | https://github.com/NVIDIA/NeMo/pull/1877 | 827,227,067 | MDExOlB1bGxSZXF1ZXN0NTg5MTYwNzAw | 1,877 | Fix and improvement for SD | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T06:49:48 | 2021-03-12T21:58:39 | 2021-03-10T19:51:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1877",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1877",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1877.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1877.patch",
"merged_at": "2021-03-10T19:51:36"
} | 1. handle if dot in the filename
2. Add flexible input format for VAD tune threshold | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1877/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1877/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1876 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1876/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1876/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1876/events | https://github.com/NVIDIA/NeMo/pull/1876 | 826,894,652 | MDExOlB1bGxSZXF1ZXN0NTg4ODU4OTY0 | 1,876 | Minor core docs updates | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T01:12:30 | 2021-03-10T18:12:28 | 2021-03-10T18:12:23 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1876",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1876",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1876.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1876.patch",
"merged_at": "2021-03-10T18:12:23"
} | Signed-off-by: Oleksii Kuchaiev <[email protected]> | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1876/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1876/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1875 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1875/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1875/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1875/events | https://github.com/NVIDIA/NeMo/pull/1875 | 826,846,020 | MDExOlB1bGxSZXF1ZXN0NTg4ODE1MjE4 | 1,875 | ASR Documentation | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-10T00:21:38 | 2021-03-10T22:03:41 | 2021-03-10T22:03:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1875",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1875",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1875.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1875.patch",
"merged_at": "2021-03-10T22:03:41"
} | Adding:
- Custom dataset creation instructions
- Local & NGC checkpoint loading instructions and examples
- Additional info on intro page
- `configs.rst`: details about nemo_asr model configs (dataset, preprocessor, augmentation, per-model configs)
- Some missing modules in the API | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1875/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1875/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1874 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1874/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1874/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1874/events | https://github.com/NVIDIA/NeMo/pull/1874 | 826,654,755 | MDExOlB1bGxSZXF1ZXN0NTg4NjM5NDgy | 1,874 | Lightning 1.2.3 | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-09T21:23:56 | 2021-03-09T21:37:24 | 2021-03-09T21:37:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1874",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1874",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1874.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1874.patch",
"merged_at": null
} | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1874/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1874/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1873 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1873/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1873/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1873/events | https://github.com/NVIDIA/NeMo/issues/1873 | 826,617,709 | MDU6SXNzdWU4MjY2MTc3MDk= | 1,873 | I often find conflicts in the environment when using NeMo. | {
"login": "pervrosen",
"id": 46034369,
"node_id": "MDQ6VXNlcjQ2MDM0MzY5",
"avatar_url": "https://avatars.githubusercontent.com/u/46034369?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pervrosen",
"html_url": "https://github.com/pervrosen",
"followers_url": "https://api.github.com/users/pervrosen/followers",
"following_url": "https://api.github.com/users/pervrosen/following{/other_user}",
"gists_url": "https://api.github.com/users/pervrosen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pervrosen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pervrosen/subscriptions",
"organizations_url": "https://api.github.com/users/pervrosen/orgs",
"repos_url": "https://api.github.com/users/pervrosen/repos",
"events_url": "https://api.github.com/users/pervrosen/events{/privacy}",
"received_events_url": "https://api.github.com/users/pervrosen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"I also had to fix torch to 1.7.1. I also opened a pull request for that, but is not accepted to stick the version of torch. You can read more here https://github.com/NVIDIA/NeMo/issues/1868 and follow until you see my pull request, which is a temporary workaround for me. Maybe you should apply to yourself the same practice.",
"Closing due to inactivity. Please reopen if still having the issue."
] | 2021-03-09T20:52:45 | 2021-04-20T05:32:49 | 2021-04-20T05:32:49 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I often find/see conflicts in the environment between - torch, torchtext, torchaudio, torchvision, pytorch-lightning and nemo and this causes many problems for me. Also, it seems like many of the issues posted here are related to those conflicts. This is to be expected with the fast pace these libraries are developing, but things could improve for the user when it comes to theses issues.
A solution would be to post fixed and verified library/environment versions and install readme:s for the environment supporting the release, e.g. an INSTALL.md with fixed versions per release.
Another solution would be to be more strict with the versions required in the requirements-files under the requirements folder. That would not support anaconda environments, so please also consider to include how to achieve a stable anaconda environment.
Further more, a nice example is the [pytorch local install page](https://pytorch.org/get-started/locally/), where you could iteratively get instructions how to install.
(OR a novel approach would be to simply tar the environment and offer it as an s3-artefact along with the release, e.g. arm, x86-64 etc?)
Br, PvR | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1873/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1873/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1872 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1872/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1872/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1872/events | https://github.com/NVIDIA/NeMo/pull/1872 | 826,513,068 | MDExOlB1bGxSZXF1ZXN0NTg4NTEwNDUx | 1,872 | TTS RC Docs Update | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-09T19:28:08 | 2021-03-11T16:29:15 | 2021-03-11T16:29:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1872",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1872",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1872.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1872.patch",
"merged_at": "2021-03-11T16:29:13"
} | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1872/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1872/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1871 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1871/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1871/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1871/events | https://github.com/NVIDIA/NeMo/pull/1871 | 826,261,660 | MDExOlB1bGxSZXF1ZXN0NTg4Mjc3NTQ2 | 1,871 | NMT adding pretrained HF encoders | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 9 alerts** when merging 8abd6c6c4439cc5ce3e1e65f5dfb1950faecceaf into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-57eaca60590a915a6de70d40a43478f84286be8b)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 8 alerts** when merging 25c47c98b4f926d7ecde0983fd78afa298fa6262 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-93a20e9ba45f5b25b0d1aea9927876859d0dc06b)\n\n**new alerts:**\n\n* 8 for Unused import",
"This pull request **introduces 8 alerts** when merging 451c58ede732b03459401125db3d863ee3cde7d6 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-7b59b100be33fa5ec49e9830cfd5a50e2564af38)\n\n**new alerts:**\n\n* 8 for Unused import",
"This pull request **introduces 8 alerts** when merging bccf4359ded0623538005f8306e3e43aa0ee1901 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-e64814b5067e63dd3def67107ec3ade6870ce1c3)\n\n**new alerts:**\n\n* 8 for Unused import",
"This pull request **introduces 8 alerts** when merging e497e9c9f3cca1bc222eab775384894e52892100 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5ce35f5f9af6e8021615d26d34756d2a441f8444)\n\n**new alerts:**\n\n* 8 for Unused import",
"This pull request **introduces 8 alerts** when merging e9e24b0642ba4442d8ecc1ed232cb6d0d22e5942 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-707978e222e3dd83f9122e0d7f8a1868a5228ccf)\n\n**new alerts:**\n\n* 8 for Unused import",
"This pull request **introduces 9 alerts** when merging ace6054f6ff8e187a3dabb6c8579ffe37994ed67 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-4c85b3a77bb89c17a75099d929758ede363b0712)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 9 alerts** when merging 840d85a2be80a1bdaaaa4ce89dac9e8d66ab210e into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5448b514e9884d39d1bf7390ab6baa7cd4ee243f)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 9 alerts** when merging b5548e8ac629d09238907accd078968e0eb2343c into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-bf6f33958e2a39abcf23e1556be4677f0ecfba77)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 9 alerts** when merging 4ec5233841f60524fe467e0ef47efa67c38af3df into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-64b32681122ebce805dac4871d3c8ff5e86b9e20)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 9 alerts** when merging 9415668530a3b8cecc6c59f8dfc32d614e8a710b into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-e8cf742f834fe689da5d110aae105f285ae04b5c)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 9 alerts** when merging ce91bc6f760ec8d0cb5ceb6b20e77cb9b25d833b into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2d7e75c8d23771faac96c610a683be97be76f6a7)\n\n**new alerts:**\n\n* 9 for Unused import",
"This pull request **introduces 10 alerts** when merging f716c2a62119dffda6970b180aaf8f2ac9da7297 into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-4dc03d91b173b523df4671949257c290a3719471)\n\n**new alerts:**\n\n* 10 for Unused import",
"This pull request **introduces 1 alert** when merging c1ffc2f4afa9944f6e144c85cb1f7bdcc0746c90 into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c99f08d69fe3218ec44d0ee9aa9b9c7bd82b2835)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 8c66456ce66de0e9ca0c1e59b333a35f531140e2 into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2c936e8bba47f81569faf00f09ed12652cb3500e)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 4fe9ec3856069c022b594cc05467f9dcde063bd6 into a33d2794cba9cff5b29044f787e41f654325424a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2611a24d4bcd182d90cfe48ba77f8de8a98c5443)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging d0c0ad094f0d962bf46c3a0710f3d6fabdf89cd7 into a33d2794cba9cff5b29044f787e41f654325424a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-faeb51f6d07a71183a9f2de39e302f23d2dcc555)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 2bf7978ace5bf9e1e9915e2aebd66247719e4da1 into 5d80627ca696384dc16e462f1e17efd33917a9dd - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-db259f4d4535a335027996896f845157461243e0)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging ac50ff7f38dc0b40fadd043ba89f48115432326c into 5d80627ca696384dc16e462f1e17efd33917a9dd - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1ff35793b6715f4e03900e37765fde7ff64b2152)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 6d9d547a3f2a0c46e4d17d515d5bbc3da0872a87 into 05eb2587a95e512b5e95705d9f77582634abbd95 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-da27fb011b14e210486260eec93f4e64e784c32c)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 1a8aa0967db281d5e09a9efd400936b0e2eac727 into 646aff11aa788b7d874dae930ce6ffcd658c1f16 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-083514a3c31f38a8f876cbcabe0fcdef74f98916)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging e0cca8f60c7a3946eee8bd18010029bf33384d1a into 646aff11aa788b7d874dae930ce6ffcd658c1f16 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-814ada8b11f65d71e003845db1a54f0de081bb01)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 1876f3f6f1cd743ef30df8e34e935730892652a3 into b0f9f94469b1b7bacb10fb1851f8fabfd8b4323d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-0e99d19428b41e342b29946e4215b117bcc5121e)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** and **fixes 1** when merging ff3b03ada6ec8677b8d4295fbea0d05138103fd5 into 4b8dd8ba7d02fd52e863f554b98f6be4c470948d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b5cebddab2c1ffcba131a6c0751a71c8dec470f9)\n\n**new alerts:**\n\n* 1 for Unused import\n\n**fixed alerts:**\n\n* 1 for Unused import"
] | 2021-03-09T16:56:21 | 2021-03-12T00:29:38 | 2021-03-12T00:29:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1871",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1871",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1871.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1871.patch",
"merged_at": "2021-03-12T00:29:34"
} | This PR will add HuggingFace Encoder support to NeMo NMT.
When training NeMo NMT models, users can now:
- Download pretrained model from HF and use it for NMT automatically
- The NMT data preprocessor will automatically use the tokenizer associated with pretrained when preprocessing the data
- The HF encoder can be used with the pretrained weights or with randomly initialized weights
- The HF encoder can be configured from scratch.
# Implementation Details
Since our ultimate goal is to be able to use encoders from HuggingFace, Megatron-LM, and NeMo, we've added some new flags to NMT.
The `library` flag takes values: `huggingface`, `megatron` (when implemented), and `nemo`.
NMT has `library=nemo` by default to maintain backwards compatibility.
The `model_name` flag is used to indicate a _named_ model architecture. From HuggingFace, we have `bert_base_cased` for example.
We've also added the `pretrained` flag. This allows users to decide whether they want to download the named model's pretrained weights `pretrained=True` or simply instantiated the named model architecture with random weights `pretrained=False`.
If a user wants to use a model architecture from a specific library, then they can use `model_name=None` and add the custom configuration under the `encoder` configuration. For example:
```
encoder:
_target_: transformers.BertConfig
hidden_size: 1536
```
Also note that `shared_tokenizer` should `False` when using HuggingFace encoders since we do not support HuggingFace Decoders yet.
# Usage
We've provided a config file to use with HuggingFace encoders: examples/nlp/machine_translation/conf/huggingface.yaml
We can use that config file by specifying from the CLI:
```
--config-path=conf \
--config-name=huggingface
```
## Pretrained HuggingFace Encoder
This will train an NMT model with a pretrained encoder model from HuggingFace and
a randomly initialized decoder from NeMo.
To train the encoder from scratch, set `encoder.pretrained=False`.
```
MODEL_NAME = bert-base-cased
python examples/nlp/machine_translation/enc_dec_nmt.py \
--config-path=conf \
--config-name=huggingface \
model.src_language=en \
model.tgt_language=de \
model.preproc_out_dir=/raid/data/hf_en_de_preproc_${MODEL_NAME} \
model.shared_tokenizer=false \
model.encoder_tokenizer.library=huggingface \
model.encoder.library=huggingface \
model.encoder.pretrained=true \
model.encoder.model_name=${MODEL_NAME} \
model.decoder_tokenizer.library=yttm \
model.decoder_tokenizer.vocab_size=32000 \
model.decoder.library=nemo \
model.decoder.inner_size=4096 \
model.decoder.num_attention_heads=16 \
model.decoder.attn_layer_dropout=0.1 \
model.decoder.ffn_dropout=0.1 \
model.decoder.num_layers=6 \
...
```
## Custom HuggingFace Encoder
This will train an NMT model with a custom encoder model from HuggingFace and
a randomly initialized decoder from NeMo.
Note: we have to use `+` from the CLI if we are not adding the argument to the config file.
```
python examples/nlp/machine_translation/enc_dec_nmt.py \
--config-path=conf \
--config-name=huggingface \
model.src_language=en \
model.tgt_language=de \
model.preproc_out_dir=/raid/data/hf_en_de_preproc_custom \
model.shared_tokenizer=false \
model.encoder_tokenizer.library=huggingface \
model.encoder.library=huggingface \
+model.encoder._target_=transformers.BertConfig \
+model.encoder.hidden_size=1536 \
model.decoder_tokenizer.library=yttm \
model.decoder_tokenizer.vocab_size=32000 \
model.decoder.library=nemo \
model.decoder.inner_size=4096 \
model.decoder.num_attention_heads=16 \
model.decoder.attn_layer_dropout=0.1 \
model.decoder.ffn_dropout=0.1 \
model.decoder.num_layers=6 \
...
``` | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1871/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1871/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1870 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1870/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1870/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1870/events | https://github.com/NVIDIA/NeMo/issues/1870 | 825,821,152 | MDU6SXNzdWU4MjU4MjExNTI= | 1,870 | NEMO ASR on the audio recorded with phone | {
"login": "kruthikakr",
"id": 12526620,
"node_id": "MDQ6VXNlcjEyNTI2NjIw",
"avatar_url": "https://avatars.githubusercontent.com/u/12526620?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kruthikakr",
"html_url": "https://github.com/kruthikakr",
"followers_url": "https://api.github.com/users/kruthikakr/followers",
"following_url": "https://api.github.com/users/kruthikakr/following{/other_user}",
"gists_url": "https://api.github.com/users/kruthikakr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kruthikakr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kruthikakr/subscriptions",
"organizations_url": "https://api.github.com/users/kruthikakr/orgs",
"repos_url": "https://api.github.com/users/kruthikakr/repos",
"events_url": "https://api.github.com/users/kruthikakr/events{/privacy}",
"received_events_url": "https://api.github.com/users/kruthikakr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | true | null | [] | null | [
"I did not played enough with that, but my first impression it was that with my studio microphone without dynamic compression and leveling, already was worst. Therefore at the beginning I will use with hardware dynamic compression. Once I am sure that this is the biggest issue, then I will make this compression in software also.",
"ok thanks for replying. Now i need to use NeMo for audio recorded using phone /laptop microphone. Is there any way to improve the audio quality before giving it to the model. how to get the quality speech to text with phone recording /zoom audio ?",
"Before going into development... first try to do some experiments. Take some audio processing tools, where you can do dynamic compression, limiting, even better if you can do proper noise reduction. Prepare manually a few variants of quality from the same file and compare the results. Then you will have the correct observation what makes sense to do and what doesn't make sense.\r\nIf you see the clear process what works, then the same thing can be implemented with librosa. (Of course some AI based noise reduction which you can make by iZotope RX you will not be able to reproduct by just using librosa.) Then you will go to search implementation examples from librosa or ISMIR, etc.\r\nThis requires a bit of work like this, a kind of R&D approach.",
"@kruthikakr Could you share some samples that you are seeing an issue with? Most of our training data consists of clean studio recordings but you should get reasonable transcripts for noisy audio say up to 20 dB SNR. Could you also share which model/models you experimented with? \r\n\r\n> Now i need to use NeMo for audio recorded using phone /laptop microphone. Is there any way to improve the audio quality before giving it to the model. how to get the quality speech to text with phone recording /zoom audio ?\r\n\r\nYou could finetune the model to with noise augmentation to improve noise robustness of the model, we have a noise robust QuartzNet model that you could give a try. We have a new release coming up (in a couple of weeks) with better models trained on more conversational data that may fit your application.\r\n",
"**1. we tried with 1 zoom recorded audio which was m4a format and the the size was7.62MB and then converted in to .wav format (15 MB size) which is required by the Nemo using \"ffmpeg\". if there is an option to give in m4a , let us know the script .Sharing the both audio here ([audio_data.zip](https://github.com/NVIDIA/NeMo/files/6141588/audio_data.zip)).\r\n\r\n2. Results using \"QuartzNet15x5Base-En\" model the transcript is pasted here.**\r\n\r\nO.\r\nNexi, okay.\r\nSo I am just reading an article related to deepplenartic architectures for action recognition.\r\nSo, Oh, this is Thi the article related to.\r\nExplore spacial temporal features.\r\nThrough various deep architectures, the role of optical flor is an import.\r\nThe impact ond real time capabilities and the compactness and indeve.\r\nRetability of the learn features.\r\nSo before?\r\nIn that, I'll just start with Er.\r\nSome paper or papers on the.\r\nYou see of fond, Zero, an dataset.\r\nOh.\r\nSo large scale video classification with convelsional red work.\r\nAnd two stream networks.\r\nDearis to popularity of single stream under two Streem network in action recondition.\r\nSo the single frame network is essentially an image classubition atwork.\r\nWith no temporal features.\r\nLate fusion uses too far apart frames and nfuses deep iancil features at the densely connected layers by flatktening.\r\nFeatures process from the two fribs.\r\nThe strength of the single stream strategieis that.\r\nWe can use transfer learning from model.\r\nTrained on last kilihis deterset.\r\nWe also have.\r\nNo one need to preporses the images for offical flow.\r\nEdirectly used the Rgbma Tata in this architecture.\r\nThis makes single stream network a candate for real time processing.\r\nIn the fusion architectures.\r\nDhid, the author proposed.\r\nThe number of cerometer increases significantly from a deep toti sanente.\r\nTo mitigate this, the author proposed.\r\nUsing a multiresorlation streng.\r\nOne, the dambets say high resolution for Viar steam on Ah, center crop of the video combined with Et.\r\nLow resolution contacts trim from the.\r\nHold vidio.\r\nI seen Inda.\r\nArchitecture, Iao.\r\nOky, so I'll just to or change the ear.\r\nContext.\r\nEr one secend ham, just ster.\r\nLet trile some.\r\nSo, generating optic, cof, floo, using, and videofloet.\r\nTo implementation.\r\nThe blog was originally published in Ta a blocg.\r\nBad slogan.\r\nIn a previous post, an introduction, tooptical flaws conducted, as well as an oervi of in its architecture, west of Pflonic.\r\nThis blot will focus in going deeper into optical floo.\r\nWhich will be done by generating optical Flo files?\r\nBoth from the standard.\r\nCintal Deta and the custom dance Vidio.\r\nIt will be conducted using a fork ofter.\r\nInvidioflown into pytorch cord bass, which can be found in the.\r\nFollowing link.\r\nOkay, I think I know a ond two three minutes. I talk.\r\nThank you.\r\nYama'am thank you.\r\nSo?\r\nYeai'll start for a.\r\nSome drenning stories.\r\nChecking.\r\nLike.\r\nDon't even O bac bag, okay?\r\nI'm selecting some.\r\nI'm sorry.\r\nA Ther deely, ie, no problem.\r\nAn ofa.\r\nYour background dis clear now.\r\nNothing, I'll go into an none.\r\nKi'm starting to read one article.\r\nMy speech is made up of many frequencies at the same time that it is a sum.\r\nOf all those frequencies.\r\nTo analyze the signal, we use the component frequencies as features.\r\nFor a transform is used to break the signal into.\r\nThese components.\r\nWe can use this splitting technique to convert the sound to a spectracram.\r\nGe frequency on the.\r\nMertical axis is splotted against.\r\nThe intensity of shady indicates the amplitude of the signal.\r\nTo create a spectrogram.\r\nThere are three lines sor.\r\nOf the cord.\r\nDivide the singer into.\r\nTime frequencies.\r\nSplit each frim.\r\nFrame singen into frequency components with an Ff. T.\r\nAnthardies is weat.\r\nEach timeframe is now represented with a vector of amplitude.\r\nAt each frequency.\r\nWel line up the vectors again.\r\nTheir time serius order, we have a.\r\nIual picture of the sound component.\r\nTheepectogram.\r\nNext you ill look at turfect.\r\nFeature exsection techniques which werd.\r\nWould reduce the noise and dimenslity of.\r\nOur data.\r\nSo?\r\nWhat his feature extruction with Ama Cisi.\r\nMetal frequency.\r\nCeptum cofision analysis is the deduction of an audio signal.\r\nTo essential speech component.\r\nPita.\r\nUsing both mel, frequency analysis and separate anasis.\r\nThe range of frequencies are reduced and bint.\r\nInto groups of frequencies that humans can distinguish.\r\nThe thing that is for ther.\r\nSeparated into sores and filter.\r\nSo that variations between speakers unrelated to.\r\nLatin can be filtered away.\r\nSo that is from my side.\r\nHank you?\r\nOcalre, the article whit have shared in the.\r\nThen I thought.\r\nYour tue.\r\nIn the social ignitic action isjed he minor of omanging a language. Anyone who speaks our language does so. in our accent, The way of the native speaker. speaker of the language speaks, Fo, languer, is define the standard ponudication, and is generally considered to be standard for Tesmantano.\r\nYour voice is not clar.\r\nNot too.\r\nCan use Um?\r\nYe fall nearer mouth.\r\nThe Mik never.\r\nEnglish has become an important language of O communication among the younger generations of the India, because of tic status as a language for the formal education, a large number of the young Indians in thebinokinnes.\r\nT thatif, they speak one of the Twentie Twola Indian language as their first language alongside eglists.\r\nAn implication of this is that when speaking English, the intervetion from phonology of their first language, enample, malalum gives rise to the accent in the speech of the Indian speakers of English.\r\nThis accent is generally very distinct and is deadly.\r\nIdentiable, for example, as the Malarlum, English, acpenthe, sengunlix, acenabungala bungari in English action derecto.\r\nThis younger genetration of Windia, is also a large, an a growing group of a user of a speech pace technology, togh a Hn.\r\nAndhelt device, and a voice assistant, This voice assistance has become very cool.\r\nEntifyigi English is spoken in the native accent, Altourh, nonative accent. Speece continues to challenge for them for Sa. Rc. System of the Voyce assists have knowledge that the speaker is going to speak with a certain accent. The voice assistante may be trimeg, to listen to Sudten feature in the voice, which would lead to a great performance security.\r\nBut sheud de not.\r\nO.\r\nYeah, ol kiv.\r\nOka.\r\nOh gesel, thank you.\r\nYen.\r\n\r\n**3. Results using \"QuartzNet15x5NR-En\" model the transcript is pasted here.**\r\nO Ol.\r\nNexsy O E.\r\nSo I am just reading an article related to Deplein Arctic architectures for action recognition.\r\nSo this is hi, the article related to.\r\nExplore spacial temporal features.\r\nThrough various deep architectures, the role of optical flour is an import.\r\nThe impact owned real time capabilities and the compactness a\r\nnd intevee.\r\nRetability of the learn features.\r\nSo before?\r\nIn that, I'll just start with her.\r\nSome paper or the papers on the.\r\nYou see a fone zero on at a set.\r\nSo lastscale video classification with convelsional red work.\r\nAnd two stream networks.\r\nEis to popularity of single stream, anda two Strepm network in action, a condition.\r\nSo the single frame network is essentially an image classivition atwork.\r\nWith no temporal features.\r\nAlate fusion uses two far apart frames and infuses deep irancill features at the densely connected layers by flatktning.\r\nFeatures processed from the two fribs.\r\nThe strength of the single stream strategy is ther.\r\nWe can use transfer learning from model.\r\nTrained on Lare killimi, etase.\r\nWe also have.\r\nNo, onnee to preposess the images for offical flow.\r\nDirectly used the Rgbmas Tata in this architectuce.\r\nThis makes single stream network a candate for real time processing.\r\nIn the fusion architectures.\r\nDid the author proposed?\r\nThe number of carameter increases significantly from a deep todi sanente.\r\nTo mitigate this, the author proposed.\r\nUsing a multiresolution street.\r\nN, the dambets a high resolution for vi steam on a center crop of the video combined with her.\r\nLow resolution contects trim from the.\r\nHold ridio.\r\nAs seen in the.\r\nArhitectui.\r\nOyso, I'll just tar or change the or.\r\nContext.\r\nErone, se cend am just stir.\r\nLet's change some.\r\nSogenerating optic co flow, usinga.\r\nTo implementation.\r\nThe blog was originally published in De a block.\r\nBad slogan.\r\nI aprevious post an introduction, Toptic Al Floos conducted, as well as an overview of Inix architecture, West offloic.\r\nThis blot will focus in going deeper into toptical flow.\r\nWhich will be done by generating optical flofiles?\r\nBoth from the standard.\r\nCentrel Deta and the custom dance ridio.\r\nIt will be conducted using he fork ofter.\r\nInvidio flow into pytoch hord bass, which can be found in the.\r\nFollowing link.\r\nOki think I know around to three minutes I talke.\r\nThank you.\r\nYama, thank you.\r\nSo?\r\nI'll start for E.\r\nSome reading stories.\r\nIcecking.\r\nEen o bu. o.\r\nI'm selecting some.\r\nI'am sorry.\r\nO.\r\nAno.\r\nBackground I ceno.\r\nNo, I'll go into an oe.\r\nAi'm starting to read one article.\r\nMy speech is made up of many frequencies at the same time thati it, isasum.\r\nAll those frequencies.\r\nTo analyze the signal, we use the component frequencies as features.\r\nFor a transform is used to break the signal into.\r\nThese components.\r\nWe can use this splitting technique to convert the sound to a spectrocram.\r\nGet frequency on the.\r\nVertical axess is plotted against.\r\nThe intensity of shady indicates the amplitude of the signal.\r\nTo create a spectrogram.\r\nThere are three lines her.\r\nEr.\r\nDivide the singar into.\r\nTime frequencies.\r\nSplit eas frim.\r\nFrame singgan into frequency components with an Ff. T.\r\nNtarti iseet.\r\nEach timeframe is now represented with a vector of amplitude.\r\nAt each frequency.\r\nWe line up the vectors again.\r\nIn theirtime series order, we have a.\r\nIsual picture of the sound component.\r\nThe expectocam.\r\nNext, you'll look at Teri.\r\nFeature exsection techniques picturded.\r\nWould reduce the noise and dimensility of.\r\nOur data.\r\nSo?\r\nWhat is feature extruction with Ama Piz?\r\nMetal frequency.\r\nSeptem cofision analysis is the deduction of an audio signal.\r\nTwo essential speech component.\r\nEt.\r\nUsing both mal, frequency analysis and seprate anlysis.\r\nThe range of frequencies are reduced and binn.\r\nInto groups of frequencies that humans can distinguish.\r\nThe thingtat is for Ther.\r\nSeparated into sores and filter.\r\nSo that variations between speakers unelated to.\r\nArticulation can be filtered away.\r\nSo that is from my side.\r\nHnyou.\r\nOkay, I'll read the article which has shared in the.\r\nHen, I thought.\r\nYe do.\r\nIn the social liitic actiont is wethe, minor ofper managingal language. Anyone who speaks our language does so in our accent, The way of the nativist speaker. speaker of the language speaks, o languageis, define ter standard pronuniciation and is generally considered to be standard or deferent action.\r\nYour voice is not cler.\r\nNot to goo.\r\nCan use em.\r\nYe fall near er mouth.\r\nEnglish has become an important language or for communication among the younger generation of the India, because of missus status as a language for the formal education, a large number of young Indians inarbinocene.\r\nThat if they speak one of the Twenti, two la Indian language as their first language alongside Iles.\r\nAn implication of this is that when speaking English, the intervesion from phonology of their first language, enample, Malalam gives srise to the accent in the speech of the Indian speakers of English.\r\nThis accent is generally very distinct and is deadly.\r\nIdentiable for the example, as the Madarlum English actenthor, sengunli, acentandbungala, bungai, in English action derectro.\r\nThis younger generation of Windia, is also a large and a growing group of a user of a steep pace technology through a han.\r\nAndhel device, and a Voyd assistant, Thiss woyce, The assistance has become very good.\r\nIentiying this English, S spoken in the lative accent, Olwer, nonative accents, Speece continues to challenge for them, for S. A Rc. system of the voyce assists have knowledge that the speaker is going to speak with a certain accent. The voice assistants may be trying to listen to sudden feature in the voice, which would lead to a great performance security.\r\nBut should be not.\r\nYe.\r\nYeah, I'l ges.\r\nOkin.\r\nOh, guesso, thank you.\r\nYen.\r\n",
"Also provide some suitable or comparable tool /Script to record the audio using laptop /phone microphone, so that we get good transcript .It would be of great help, Thank you",
"@jbalam-nv Can you please check on the sample audio and respective transcript and give us some inputs on how to improvise the result ?"
] | 2021-03-09T12:06:30 | 2021-04-28T00:13:47 | 2021-04-28T00:13:46 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Question :
Trying to run the Nemo for the audio recorded with the phone /zoom meeting , but the text output is very bad, the same audio which has been recorded with good microphone ,the text output is exact.
Can i know is there any reference for audio quality ? how to check the quality of the audio or how to use NeMo for real work applications. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1870/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1870/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1869 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1869/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1869/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1869/events | https://github.com/NVIDIA/NeMo/pull/1869 | 825,121,479 | MDExOlB1bGxSZXF1ZXN0NTg3MjQ3MDI2 | 1,869 | After upgrading P.Lightening to 1.2.3, remains other incompatibilities with torch 1.8.0. A workaround until is sorted out all, is to stick with torch 1.7.1. | {
"login": "tiborkiss",
"id": 531899,
"node_id": "MDQ6VXNlcjUzMTg5OQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/531899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tiborkiss",
"html_url": "https://github.com/tiborkiss",
"followers_url": "https://api.github.com/users/tiborkiss/followers",
"following_url": "https://api.github.com/users/tiborkiss/following{/other_user}",
"gists_url": "https://api.github.com/users/tiborkiss/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tiborkiss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tiborkiss/subscriptions",
"organizations_url": "https://api.github.com/users/tiborkiss/orgs",
"repos_url": "https://api.github.com/users/tiborkiss/repos",
"events_url": "https://api.github.com/users/tiborkiss/events{/privacy}",
"received_events_url": "https://api.github.com/users/tiborkiss/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"thanks again @tiborkiss but we'll close this one for now because we can't pin torch version to the exact number like 1.7.1 We could add something like this right before upload to pypi though."
] | 2021-03-09T00:59:02 | 2021-03-10T22:35:14 | 2021-03-10T22:35:14 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1869",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1869",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1869.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1869.patch",
"merged_at": null
} | … pull down 1.8.0. https://github.com/PyTorchLightning/pytorch-lightning/pull/6168
This diff temporarily solves the imported incompatibility reported in https://github.com/NVIDIA/NeMo/issues/1868
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1869/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1869/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1868 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1868/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1868/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1868/events | https://github.com/NVIDIA/NeMo/issues/1868 | 825,090,069 | MDU6SXNzdWU4MjUwOTAwNjk= | 1,868 | torch 1.8.0 incompatibility: pytorch-lightening needs to be updated to 1.2.3, but is not enough. | {
"login": "tiborkiss",
"id": 531899,
"node_id": "MDQ6VXNlcjUzMTg5OQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/531899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tiborkiss",
"html_url": "https://github.com/tiborkiss",
"followers_url": "https://api.github.com/users/tiborkiss/followers",
"following_url": "https://api.github.com/users/tiborkiss/following{/other_user}",
"gists_url": "https://api.github.com/users/tiborkiss/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tiborkiss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tiborkiss/subscriptions",
"organizations_url": "https://api.github.com/users/tiborkiss/orgs",
"repos_url": "https://api.github.com/users/tiborkiss/repos",
"events_url": "https://api.github.com/users/tiborkiss/events{/privacy}",
"received_events_url": "https://api.github.com/users/tiborkiss/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"PTL was recently fixed this problem here: https://github.com/PyTorchLightning/pytorch-lightning/commit/60d0c95e07b8edfa22f5892ebb72d93b1d35832f \r\nand they released `pytorch-lightening` 1.2.3 .\r\n\r\nTherefore I updated in `requirements/requirements.txt`\r\n```\r\n-pytorch-lightning>=1.1.0,<=1.1.5\r\n+pytorch-lightning>=1.2.3,<=1.2.3\r\n```\r\nThen I made a fresh new `venv` and installed NeMo from `r1.0.0rc1` with `./reinstall.sh`\r\n\r\nThat problem now related to `pytorch-lightening` version incompatibility with `torch` 1.8.0 has been solved.\r\nThen I start the first tutorial, in the following cell, now it crashes with another problem.\r\n\r\n```\r\nquartznet = nemo_asr.models.EncDecCTCModel.from_pretrained('QuartzNet15x5Base-En')\r\n[NeMo I 2021-03-09 22:19:02 cloud:56] Found existing object /home/tibor/.cache/torch/NeMo/NeMo_1.0.0rc1/QuartzNet15x5Base-En/00869f9c89b8393ca3de640e0c536bd2/QuartzNet15x5Base-En.nemo.\r\n[NeMo I 2021-03-09 22:19:02 cloud:62] Re-using file from: /home/tibor/.cache/torch/NeMo/NeMo_1.0.0rc1/QuartzNet15x5Base-En/00869f9c89b8393ca3de640e0c536bd2/QuartzNet15x5Base-En.nemo\r\n[NeMo I 2021-03-09 22:19:02 common:615] Instantiating model from pre-trained checkpoint\r\n---------------------------------------------------------------------------\r\nAttributeError Traceback (most recent call last)\r\n<ipython-input-6-38ceefde5424> in <module>\r\n----> 1 quartznet = nemo_asr.models.EncDecCTCModel.from_pretrained('QuartzNet15x5Base-En')\r\n\r\n~/asr/NeMo/nemo/core/classes/common.py in from_pretrained(cls, model_name, refresh_cache, override_config_path, map_location, strict, return_config)\r\n 616 if class_ is None:\r\n 617 class_ = cls\r\n--> 618 instance = class_.restore_from(\r\n 619 restore_path=nemo_model_file_in_cache,\r\n 620 override_config_path=override_config_path,\r\n\r\n~/asr/NeMo/nemo/core/classes/modelPT.py in restore_from(cls, restore_path, override_config_path, map_location, strict, return_config)\r\n 417 global _MODEL_RESTORE_PATH\r\n 418 _MODEL_RESTORE_PATH = os.path.abspath(os.path.expanduser(restore_path))\r\n--> 419 return cls._default_restore_from(restore_path, override_config_path, map_location, strict, return_config)\r\n 420 \r\n 421 @classmethod\r\n\r\n~/asr/NeMo/nemo/core/classes/modelPT.py in _default_restore_from(cls, restore_path, override_config_path, map_location, strict, return_config)\r\n 370 model_weights = path.join(tmpdir, _MODEL_WEIGHTS)\r\n 371 OmegaConf.set_struct(conf, True)\r\n--> 372 instance = cls.from_config_dict(config=conf)\r\n 373 instance = instance.to(map_location)\r\n 374 instance.load_state_dict(torch.load(model_weights, map_location=map_location), strict=strict)\r\n\r\n~/asr/NeMo/nemo/core/classes/common.py in from_config_dict(cls, config)\r\n 433 else:\r\n 434 # models are handled differently for now\r\n--> 435 instance = cls(cfg=config)\r\n 436 \r\n 437 if not hasattr(instance, '_cfg'):\r\n\r\n~/asr/NeMo/nemo/collections/asr/models/ctc_models.py in __init__(self, cfg, trainer)\r\n 87 def __init__(self, cfg: DictConfig, trainer: Trainer = None):\r\n 88 # Get global rank and total number of GPU workers for IterableDataset partitioning, if applicable\r\n---> 89 self.global_rank = 0\r\n 90 self.world_size = 1\r\n 91 self.local_rank = 0\r\n\r\n~/venv/pt8nemo/lib/python3.8/site-packages/torch/nn/modules/module.py in __setattr__(self, name, value)\r\n 993 buffers[name] = value\r\n 994 else:\r\n--> 995 object.__setattr__(self, name, value)\r\n 996 \r\n 997 def __delattr__(self, name):\r\n\r\nAttributeError: can't set attribute\r\n```\r\n\r\nThis looks like now the model is not compatible with `torch` 1.8.0.\r\n\r\nTherefore, I can still continue my work only if I apply https://github.com/NVIDIA/NeMo/pull/1869\r\nLooks like, it will take some time and effort to upgrade NeMo to use torch 1.8.0.",
"A temporary workaround for myself it is here https://github.com/NVIDIA/NeMo/pull/1869",
"@tiborkiss Please note that NeMo RC1 does not work on lightning 1.2.0. In fact, RC1 pins Lightning <= 1.1.5. If you need Lightning 1.2.0 or high, please use the NeMo main branch",
"Thank you for the tips @blisc .\r\nLooks like the shortest workaround is to stick with torch 1.7.1",
"In the setup.py we have a section related to `SUPPORTED_TORCH_VERSION` where is the `REMOVE AFTER 21.03 Container is released !` comment. \r\nAt least until this container is released it works, therefore I close this PR.",
"@tiborkiss Sorry, what do you mean? Did you find a fix? Thanks!",
"> @tiborkiss Sorry, what do you mean? Did you find a fix? Thanks!\r\n\r\nYes, in this branch, this file it does that fix. https://github.com/NVIDIA/NeMo/blob/r1.0.0rc1/setup.py\r\nAs soon as is not removed (read the comments there), it is enough. I just use this branch and it works."
] | 2021-03-09T00:18:07 | 2021-03-24T06:47:40 | 2021-03-16T23:09:07 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Due to `torch` 1.8.0 just was released a few days ago, `pytorch-lightning` is still incompatible with the new torch.
Since NeMo setup pulls the latest stable torch release, imports this problem.
The problem is not visible during the install, but when using `pytorch-lightning` within NeMo tutorials for example.
**Steps/Code to reproduce bug**
I installed NeMo from r1.0.0rc17
```
python -m pip install git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all]
```
It was working while the official stable pytorch was 1.7.1.
Since PyTorch 1.8.0 came out, in fresh venv NeMo's requirements are pulling the latest torch, which is 1.8.0,
With torch 1.8.0 the second ASR tutorial notebook fails while using `pytorch-lightning` because `torchtext.data.Batch` was deprecated (and moved to` torchtext.legacy.data.Batch`, which breaks PyTorch Lightning. For more information read: https://github.com/PyTorchLightning/pytorch-lightning/pull/6168
**Expected behavior**
Since the bug is indirectly caused by the incompatibility between the current `pytorch-lightning` installed by NeMo and the latest `torch` 1,8.0, the only temporary solution I see that NeMo should stick with `torch<=1.7.1` and it's associated libraries.
I tried to edit the requirements by myself, then `./reinstall.sh`, unfortunately something is still pulling 1.8.0 somewhere at the end of the setup process.
The expected behavior is to be able to stick to torch==1.7.1
**Environment overview (please complete the following information)**
- Environment location: WSL2 with GPU support and Ubuntu 20.04
**Environment details**
- OS version: Ubuntu 20.04 running in WSL2 with GPU support.
- PyTorch version: 1.8.0
- Python version: 3.8.5
**Additional context**
I think, I completely described the problem and the possible solution.
| {
"login": "tiborkiss",
"id": 531899,
"node_id": "MDQ6VXNlcjUzMTg5OQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/531899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tiborkiss",
"html_url": "https://github.com/tiborkiss",
"followers_url": "https://api.github.com/users/tiborkiss/followers",
"following_url": "https://api.github.com/users/tiborkiss/following{/other_user}",
"gists_url": "https://api.github.com/users/tiborkiss/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tiborkiss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tiborkiss/subscriptions",
"organizations_url": "https://api.github.com/users/tiborkiss/orgs",
"repos_url": "https://api.github.com/users/tiborkiss/repos",
"events_url": "https://api.github.com/users/tiborkiss/events{/privacy}",
"received_events_url": "https://api.github.com/users/tiborkiss/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1868/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1868/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1867 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1867/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1867/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1867/events | https://github.com/NVIDIA/NeMo/issues/1867 | 825,083,626 | MDU6SXNzdWU4MjUwODM2MjY= | 1,867 | Running NeMo on Linux or Collab and not working | {
"login": "antandrieux",
"id": 33870813,
"node_id": "MDQ6VXNlcjMzODcwODEz",
"avatar_url": "https://avatars.githubusercontent.com/u/33870813?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/antandrieux",
"html_url": "https://github.com/antandrieux",
"followers_url": "https://api.github.com/users/antandrieux/followers",
"following_url": "https://api.github.com/users/antandrieux/following{/other_user}",
"gists_url": "https://api.github.com/users/antandrieux/gists{/gist_id}",
"starred_url": "https://api.github.com/users/antandrieux/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/antandrieux/subscriptions",
"organizations_url": "https://api.github.com/users/antandrieux/orgs",
"repos_url": "https://api.github.com/users/antandrieux/repos",
"events_url": "https://api.github.com/users/antandrieux/events{/privacy}",
"received_events_url": "https://api.github.com/users/antandrieux/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This is a pytorch lightning issue, please downgrade to 1.2.1 for the time being until they are able to support pytorch 1.8 as well as it's dependency of torchtext",
"> This is a pytorch lightning issue, please downgrade to 1.2.1 for the time being until they are able to support pytorch 1.8 as well as it's dependency of torchtext\r\n\r\nMe neither :/ ",
"I described already here https://github.com/NVIDIA/NeMo/issues/1868",
"Duplicate of #1868"
] | 2021-03-09T00:05:17 | 2021-04-20T05:33:49 | 2021-04-20T05:33:49 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello everyone,
I have some problems trying NeMo. I want to setup an environment on a Linux machine but after the installation of nemo_toolkit, the import (_import nemo.collections.nlp as nemo_nlp_) keeps rejecting an error:
**ImportError: cannot import name 'Batch' from 'torchtext.data' (/usr/local/lib/python3.7/dist-packages/torchtext/data/__init__.py)
**
I also tried the projects from a NeMo example (https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/nlp/Punctuation_and_Capitalization.ipynb) but I got the same issue...
Can anyone tell me if I miss something? Thank you all in advance!
Yours. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1867/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1867/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1866 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1866/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1866/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1866/events | https://github.com/NVIDIA/NeMo/pull/1866 | 825,067,485 | MDExOlB1bGxSZXF1ZXN0NTg3MjAwNTY2 | 1,866 | NMT export, _prepare_for_export refactor | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 4 alerts** when merging 03cb3ef0aad58dcaea2e849989897a94c849dcdc into 4d868b662af0fab87a4ad4078156486885bbb0a4 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-477438a4d8b220885f444f3455bf533d4efff55d)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"As per @MaximumEntropy suggestion, triangle mask can actually be dropped for inference (not just for export). I have verified that on a 100-sentence set (no diffs).",
"This pull request **introduces 4 alerts** when merging 87d2435ef7a81a51cc3771ddda6231fad2d933b9 into 4d868b662af0fab87a4ad4078156486885bbb0a4 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-604b80f9af4f4b75ec5f1e8e4fddfba76c75e73a)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"This pull request **introduces 4 alerts** when merging d14de501f99f55b642cc61aa80c8b39ee1f99af2 into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a0fadd69ffd0b4f84de7709fc606afd5480bf2c7)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"This pull request **introduces 4 alerts** when merging d934479f956f5db25dea8a1c5a38b4684deaa87f into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-41c0615a46a7ec0c6eaf82a52f20acec4313b320)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"This pull request **introduces 4 alerts** when merging 9868414685036be59fa91740da4615a6ba24e3bb into 5d80627ca696384dc16e462f1e17efd33917a9dd - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f2678947f893bee51552520cb19713b8d0e6632f)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"@borisfom unittests are failing",
"> @borisfom unittests are failing\r\n\r\nWas there a change in CI machines setup? The tests still work on my machine, and I do not see changes in PT version in Dockerfile.\r\n================================================================================ slowest durations =================================================================================\r\n16.87s call tests/collections/nlp/test_nmt_model.py::TestMTEncDecModel::test_creation_saving_restoring\r\n10.79s call tests/collections/nlp/test_nmt_model.py::TestMTEncDecModel::test_cpu_export\r\n10.51s call tests/collections/nlp/test_nmt_model.py::TestMTEncDecModel::test_gpu_export\r\n\r\n(6 durations < 0.005s hidden. Use -vv to show these durations.)\r\n========================================================================= 3 passed, 20 warnings in 42.35s ==========================================================================\r\nboris@snikolaev-DGXStation:~/git/NeMo$ sudo pip3 list | grep torch\r\npytorch-lightning 1.2.2\r\ntorch 1.7.1+cu110\r\ntorch-stft 0.1.4\r\ntorchaudio 0.7.2\r\ntorchtext 0.8.0\r\ntorchvision 0.8.2+cu110\r\ntrtorch 0.2.0a0\r\n",
"@borisfom can you try inside the container? main branch uses 21.02-py3 for CI",
"This pull request **introduces 4 alerts** when merging 162a4b41dde512b057aad5f990c2344bce2908c1 into 05eb2587a95e512b5e95705d9f77582634abbd95 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-ac780a854af2a49debda5da204bee3d09754fd53)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"This pull request **introduces 4 alerts** when merging feb2aa98a412a0522af824985c077d0ea6380b94 into 05eb2587a95e512b5e95705d9f77582634abbd95 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-91c724a41e11640e779d8bba07b580a716b769b0)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"> @borisfom can you try inside the container? main branch uses 21.02-py3 for CI\r\n\r\nRight, so I did - also bumped the base in Dockerfile and enabled Megatron export test that works with 21.02",
"This pull request **introduces 4 alerts** when merging c9c2978935a5618d4452bd69b00c9db35658ada2 into 646aff11aa788b7d874dae930ce6ffcd658c1f16 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-18195fa22e39d5a4c0088a69831cfed2ce88b4a8)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import",
"> > @borisfom can you try inside the container? main branch uses 21.02-py3 for CI\r\n> \r\n> Right, so I did - also bumped the base in Dockerfile and enabled Megatron export test that works with 21.02\r\n\r\nAfter fixing Torch compatibility issues with upgraded PT, the CI fails on unrelated test:\r\ncd tools/ctc_segmentation && pip install -r requirements.txt && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends ffmpeg\r\ntest -f /etc/shinit_v2\r\n+ source /etc/shinit_v2\r\n+++ sed -n 's/^NVRM.*Kernel Module *\\([^() ]*\\).*$/\\1/p' /proc/driver/nvidia/version\r\n+++ sed 's/^$/unknown/'\r\n++ NV_DRIVER_VERS=460.39\r\n++ export _CUDA_COMPAT_PATH=/usr/local/cuda/compat\r\n++ _CUDA_COMPAT_PATH=/usr/local/cuda/compat\r\n+++ hostname\r\n++ _CUDA_COMPAT_CHECKFILE=/usr/local/cuda/compat/.460.39.7fb21172b5cf.checked\r\n++ _CUDA_COMPAT_REALLIB=/usr/local/cuda/compat/lib.real\r\n++ _CUDA_COMPAT_SYMLINK=/usr/local/cuda/compat/lib\r\n++ '[' -n 460.39 -a -e /dev/nvidiactl -a '!' -e /usr/local/cuda/compat/.460.39.7fb21172b5cf.checked ']'\r\n+++ cat /sys/module/mlx5_core/version\r\n+++ true\r\n++ DETECTED_MOFED=\r\n++ dpkg --compare-versions 0 lt 4.9\r\n++ export 'OMPI_MCA_pml=^ucx'\r\n++ OMPI_MCA_pml='^ucx'\r\n++ unset _CUDA_COMPAT_CHECKFILE\r\n++ unset _CUDA_COMPAT_REALLIB\r\n++ unset _CUDA_COMPAT_SYMLINK\r\n+ '[' -z '' ']'\r\n+ return\r\n+ cd tools/ctc_segmentation\r\n+ pip install -r requirements.txt\r\nCollecting ctc_segmentation==1.1.0\r\n Downloading ctc_segmentation-1.1.0.tar.gz (57 kB)\r\nCollecting num2words\r\n Downloading num2words-0.5.10-py3-none-any.whl (101 kB)\r\nRequirement already satisfied: setuptools in /opt/conda/lib/python3.8/site-packages (from ctc_segmentation==1.1.0->-r requirements.txt (line 1)) (50.3.1.post20201107)\r\nRequirement already satisfied: numpy in /opt/conda/lib/python3.8/site-packages (from ctc_segmentation==1.1.0->-r requirements.txt (line 1)) (1.19.2)\r\nRequirement already satisfied: Cython in /opt/conda/lib/python3.8/site-packages (from ctc_segmentation==1.1.0->-r requirements.txt (line 1)) (0.28.4)\r\nCollecting docopt>=0.6.2\r\n Downloading docopt-0.6.2.tar.gz (25 kB)\r\nBuilding wheels for collected packages: ctc-segmentation, docopt\r\n Building wheel for ctc-segmentation (setup.py): started\r\n Building wheel for ctc-segmentation (setup.py): finished with status 'done'\r\n Created wheel for ctc-segmentation: filename=ctc_segmentation-1.1.0-cp38-cp38-linux_x86_64.whl size=120481 sha256=6583c5221f311b58278d169b5ad53ba162917094963459610a404440fb6d6759\r\n Stored in directory: /root/.cache/pip/wheels/4e/6e/9e/2904d4b4f46b220690572ef09688e6cf248a6340cd2758742c\r\n Building wheel for docopt (setup.py): started\r\n Building wheel for docopt (setup.py): finished with status 'done'\r\n Created wheel for docopt: filename=docopt-0.6.2-py2.py3-none-any.whl size=13704 sha256=09cec6b7a65ec64f9ee6bb37422283e3ed48fa51d054016adb6da1201a39e327\r\n Stored in directory: /root/.cache/pip/wheels/56/ea/58/ead137b087d9e326852a851351d1debf4ada529b6ac0ec4e8c\r\nSuccessfully built ctc-segmentation docopt\r\nInstalling collected packages: ctc-segmentation, docopt, num2words\r\nSuccessfully installed ctc-segmentation-1.1.0 docopt-0.6.2 num2words-0.5.10\r\n+ DEBIAN_FRONTEND=noninteractive\r\n+ apt-get install -y --no-install-recommends ffmpeg\r\nReading package lists...\r\nBuilding dependency tree...\r\nReading state information...\r\nE: Unable to locate package ffmpeg\r\nscript returned exit code 100\r\nClearly CI issue - ffmpeg os one of the pre-reqs to install NeMo, mentoned both in README and Dockerfile:\r\nUse this installation mode if you want the latest released version.\r\n.. code-block:: bash\r\n apt-get update && apt-get install -y libsndfile1 ffmpeg\r\n pip install Cython\r\n pip install nemo_toolkit[all]==1.0.0b3\r\n",
"This pull request **introduces 4 alerts** when merging 874f1f65c64abf867643f8f7094cfd1ad32f99c9 into b0f9f94469b1b7bacb10fb1851f8fabfd8b4323d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-fbdba08fb50cdc68c493f8dca8e7c382bbc5a95a)\n\n**new alerts:**\n\n* 2 for Modification of dictionary returned by locals\\(\\)\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import"
] | 2021-03-08T23:41:05 | 2021-03-11T22:53:30 | 2021-03-11T22:53:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1866",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1866",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1866.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1866.patch",
"merged_at": "2021-03-11T22:53:30"
} | Here, added export tp NMT's encoder and decoder.
The design decision is is to have those 2 parts explicitly exportable, instead of having whole model's export() produce 2 files.
Test added. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1866/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1866/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1865 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1865/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1865/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1865/events | https://github.com/NVIDIA/NeMo/pull/1865 | 825,063,764 | MDExOlB1bGxSZXF1ZXN0NTg3MTk3NTI2 | 1,865 | Update CI container to 21.02 | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-08T23:35:10 | 2022-10-06T01:56:56 | 2021-03-09T05:02:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1865",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1865",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1865.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1865.patch",
"merged_at": "2021-03-09T05:02:14"
} | Signed-off-by: smajumdar <[email protected]> | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1865/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1865/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1864 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1864/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1864/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1864/events | https://github.com/NVIDIA/NeMo/pull/1864 | 825,004,521 | MDExOlB1bGxSZXF1ZXN0NTg3MTQ2ODIw | 1,864 | HiFiGAN to STFT Patch | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-08T22:14:27 | 2021-03-09T19:23:44 | 2021-03-09T00:56:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1864",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1864",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1864.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1864.patch",
"merged_at": "2021-03-09T00:56:56"
} | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1864/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1864/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1863 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1863/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1863/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1863/events | https://github.com/NVIDIA/NeMo/pull/1863 | 824,936,528 | MDExOlB1bGxSZXF1ZXN0NTg3MDkwMjE1 | 1,863 | EnJa tokenize output format fix | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"buncha tests are failing but i dont think theyre related to this pr "
] | 2021-03-08T20:44:31 | 2021-03-08T22:42:53 | 2021-03-08T22:42:47 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1863",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1863",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1863.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1863.patch",
"merged_at": "2021-03-08T22:42:47"
} | ~preprocessor `tokenize(txt)` methods should probably return a list of tokens, not a string. these can then be converted into ids without the intermediate steps of producing a string and then immediately splitting it for the tokens again, as was being done in `translate`~
it turns out that `text_to_ids(txt)` acts differently than `tokens_to_ids(txt.split(' '))`, so i am changing the output of the `processsor.tokenize` to be `str` again. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1863/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1863/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1862 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1862/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1862/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1862/events | https://github.com/NVIDIA/NeMo/pull/1862 | 824,934,393 | MDExOlB1bGxSZXF1ZXN0NTg3MDg4Mzk3 | 1,862 | remote hard fix path | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-08T20:41:37 | 2021-03-08T21:35:20 | 2021-03-08T21:27:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1862",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1862",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1862.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1862.patch",
"merged_at": "2021-03-08T21:27:58"
} | Signed-off-by: nithinraok <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1862/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1862/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1861 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1861/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1861/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1861/events | https://github.com/NVIDIA/NeMo/pull/1861 | 824,868,547 | MDExOlB1bGxSZXF1ZXN0NTg3MDMyNDYw | 1,861 | NMT fix for DDP training hanging | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-08T19:16:00 | 2021-03-08T23:07:24 | 2021-03-08T23:07:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1861",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1861",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1861.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1861.patch",
"merged_at": "2021-03-08T23:07:19"
} | NMT DDP training is hanging after training for a few epochs. This hanging is likely due to validation metrics becoming out of sync.
See the PTL discussion here: https://github.com/PyTorchLightning/pytorch-lightning/issues/5604
Was able to train for over 24 epochs with 4 GPUs without hanging.
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1861/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1861/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1860 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1860/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1860/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1860/events | https://github.com/NVIDIA/NeMo/pull/1860 | 824,818,515 | MDExOlB1bGxSZXF1ZXN0NTg2OTkwNzQw | 1,860 | Fix qa tutorial | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-08T18:09:04 | 2021-03-08T21:20:22 | 2021-03-08T18:49:33 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1860",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1860",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1860.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1860.patch",
"merged_at": "2021-03-08T18:49:33"
} | fix syntax | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1860/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1860/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1859 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1859/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1859/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1859/events | https://github.com/NVIDIA/NeMo/pull/1859 | 824,752,466 | MDExOlB1bGxSZXF1ZXN0NTg2OTM0ODcw | 1,859 | Update README.rst | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Commits not signed."
] | 2021-03-08T16:56:30 | 2021-03-08T17:12:12 | 2021-03-08T17:11:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1859",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1859",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1859.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1859.patch",
"merged_at": null
} | Readme was pointing to a container that hasn't been released yet. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1859/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1859/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1858 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1858/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1858/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1858/events | https://github.com/NVIDIA/NeMo/pull/1858 | 823,992,238 | MDExOlB1bGxSZXF1ZXN0NTg2MzA4MjM1 | 1,858 | RC1 NeMo Core Docs Update | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-07T19:04:39 | 2021-03-09T00:22:01 | 2021-03-09T00:21:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1858",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1858",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1858.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1858.patch",
"merged_at": "2021-03-09T00:21:54"
} | Updating NeMo Core docs here. Adding docs for Hydra, Pytorch Lightning and Experiment Manager. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1858/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1858/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1856 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1856/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1856/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1856/events | https://github.com/NVIDIA/NeMo/pull/1856 | 823,885,882 | MDExOlB1bGxSZXF1ZXN0NTg2MjI3ODcw | 1,856 | Typo: Github URL -> Colab URL | {
"login": "adv-ai-tech",
"id": 42356823,
"node_id": "MDQ6VXNlcjQyMzU2ODIz",
"avatar_url": "https://avatars.githubusercontent.com/u/42356823?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adv-ai-tech",
"html_url": "https://github.com/adv-ai-tech",
"followers_url": "https://api.github.com/users/adv-ai-tech/followers",
"following_url": "https://api.github.com/users/adv-ai-tech/following{/other_user}",
"gists_url": "https://api.github.com/users/adv-ai-tech/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adv-ai-tech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adv-ai-tech/subscriptions",
"organizations_url": "https://api.github.com/users/adv-ai-tech/orgs",
"repos_url": "https://api.github.com/users/adv-ai-tech/repos",
"events_url": "https://api.github.com/users/adv-ai-tech/events{/privacy}",
"received_events_url": "https://api.github.com/users/adv-ai-tech/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"thanks!"
] | 2021-03-07T10:43:18 | 2021-03-13T00:19:09 | 2021-03-13T00:19:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1856",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1856",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1856.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1856.patch",
"merged_at": "2021-03-13T00:19:09"
} | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1856/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1856/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1855 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1855/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1855/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1855/events | https://github.com/NVIDIA/NeMo/issues/1855 | 823,659,078 | MDU6SXNzdWU4MjM2NTkwNzg= | 1,855 | Fine-tune QuartzNet15x5NR-En to another language [Question] | {
"login": "Gorodecki",
"id": 60197702,
"node_id": "MDQ6VXNlcjYwMTk3NzAy",
"avatar_url": "https://avatars.githubusercontent.com/u/60197702?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Gorodecki",
"html_url": "https://github.com/Gorodecki",
"followers_url": "https://api.github.com/users/Gorodecki/followers",
"following_url": "https://api.github.com/users/Gorodecki/following{/other_user}",
"gists_url": "https://api.github.com/users/Gorodecki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Gorodecki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Gorodecki/subscriptions",
"organizations_url": "https://api.github.com/users/Gorodecki/orgs",
"repos_url": "https://api.github.com/users/Gorodecki/repos",
"events_url": "https://api.github.com/users/Gorodecki/events{/privacy}",
"received_events_url": "https://api.github.com/users/Gorodecki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@okuchaiev Maybe there is some information on this issue? Thanks!",
"There are several notebooks for transfer learning char and subword models in Nemo now, please have a look and reopen the issue if they are insufficient. "
] | 2021-03-06T14:12:12 | 2021-08-17T01:02:04 | 2021-08-17T01:02:04 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
Thank you for this opensource product!
I want to try fine-tune model **QuartzNet15x5NR-En** to Russian language. This article [Transfer learning from English to Russian](https://developer.nvidia.com/blog/jump-start-training-for-speech-recognition-models-with-nemo/) is good practice for my experiment, but i have some questions.
1. In `config.yaml` in this model `RIR_and_Noise` i find this sample for augmentation:
> rir_manifest_path: /data/datasets/freesound_20s/rir_noises_tarred/rir_tarred/tarred/tarred_audio_manifest.json
> rir_tar_filepaths: /data/datasets/freesound_20s/rir_noises_tarred/rir_tarred/tarred/audio_{0..63}.tar
How i download this files and create this manifest?
I find this script - `download_resample_freesound.sh` - what parameters should be specified for download?
2. How many `hrs` should dataset have? What type of audio data should it contain? (phone calls, audio book...)
3. What `learning rate` to use? What parametrs set to `SpecAug`?
Thank you! | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1855/reactions",
"total_count": 2,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 2
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1855/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1854 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1854/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1854/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1854/events | https://github.com/NVIDIA/NeMo/pull/1854 | 823,548,015 | MDExOlB1bGxSZXF1ZXN0NTg1OTg4Mjcx | 1,854 | Add Numba CPU+CUDA support for RNNT Loss | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 1 alert** when merging 9de7bc589925be7b77ffcaa8fad5ffe14115971e into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-9075874939d4e184867f5ce3384215d359cffa1d)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 8f8a275bc0321594d826a55b91750ea1cfd7b309 into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5702410f047f78f5ebaca2b3ad87b84a369204ef)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging e454c4c70dee1a67c73d14585861fc4610532a80 into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-165135c81c13b53411b41f1e0f9f5cf9f515bee4)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 4946314772b952f444e1987916b49a47f1f23534 into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b0d15459dd8c2abe527d715a5a24ac92a14546ae)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging ea51c3bc89ae0e1f82c716660d23292975adac0f into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5e16827ec1a959c6e51f28f101ab929799a0b6db)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging aea2b7278270f0d796712b3a079b390d9c718885 into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3353ae343a0372e2b188232c07455155bf4163d7)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging bcb683ae9433d3c7c3ccfae71f648932e2d8249d into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-abc49ad19b712e818b0805472983308351fb9d74)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 5addd5014507e769fdc2700e14e501183bf54bd7 into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1c0a2b37f5c7205bf9a1c9662429605a9df6e7e3)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging af028e9e1e7a3a40389c59790868c181cab9607d into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-45592136e0f1e62132408bb0de4eedcb314936d9)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 8edd7f134be7cf2b2d415cb3123bd0a2120e13cb into 74a1ed8618872d331fcea3133d47b8b3552c435f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b4c1efb631689292d9cf6c19c8a2a488b511fea1)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 5bf8f3dd8229d94784d1f301d9ab5987a70e5813 into e8912ca6e3321347272a6a7da18e052812fb2062 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-646fe486329bfa5221e90de446743d60ef1dc076)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging b3f93aea208c0ab36b565b512e82917ffa6b7339 into aaab31781309fa2c6a3e5e3cb91e4ee7f4d002c8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b0c16830e674bdfaf523e442d9a41a66f39909df)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 9cdc539c6fa572a78284a4f9dd2fdccf25b16f2d into d623109ee752f654355c141bae43b64b2b98dba8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6474142b94e4abb4a8b7d85403bbbbbf08fc112a)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 19215a16d84f72539a08ce91f99d8e1aa64dc33e into 480bbc39b8c35f2f5ff0e2a2b61f4e2526de28eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-621b2b8007367a6fb5be4448bf9d3840f1ae809e)\n\n**new alerts:**\n\n* 1 for Unused local variable"
] | 2021-03-06T03:18:40 | 2021-03-29T05:59:53 | 2021-03-29T05:59:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1854",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1854",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1854.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1854.patch",
"merged_at": "2021-03-29T05:59:50"
} | # Changelog
- Add Numba CUDA + CPU kernels for RNNT Loss ported from https://github.com/HawkAaron/warp-transducer
- Add tests for CUDA + CPU kernels + reference numpy implementation.
# Todo:
- [x] Add documentation for all kernels and wrapped modules
- [x] Add Typing information to `RNNTLossNumba` (Done by resolver)
- [x] Rename this module to avoid clash with original `warprnnt_pytorch` loss
- [x] Add WarpRNNT LICENSE header in all files that implement functionality as ported.
- [x] Fix imports inside `__init__.py`
- [x] Enable loss switching for RNNT / RNNTBPE models via config (done in next PR) | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1854/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1854/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1853 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1853/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1853/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1853/events | https://github.com/NVIDIA/NeMo/pull/1853 | 823,445,963 | MDExOlB1bGxSZXF1ZXN0NTg1OTA0NDAz | 1,853 | Freeze modules during transcribe to prevent graph accumulation during transcribe loop | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@okuchaiev done"
] | 2021-03-05T21:50:52 | 2021-03-06T03:13:23 | 2021-03-06T01:07:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1853",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1853",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1853.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1853.patch",
"merged_at": "2021-03-06T01:07:16"
} | # Changelog
- Freeze internal modules when transcribing data so as to prevent graph from accumulating data during loop
Signed-off-by: smajumdar <[email protected]> | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1853/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1853/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1852 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1852/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1852/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1852/events | https://github.com/NVIDIA/NeMo/issues/1852 | 823,368,011 | MDU6SXNzdWU4MjMzNjgwMTE= | 1,852 | [Load token classification model from checkpoint get No such file or directory: 'megatron-bert-cased_encoder_config.json'] | {
"login": "bugface",
"id": 16659741,
"node_id": "MDQ6VXNlcjE2NjU5NzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/16659741?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bugface",
"html_url": "https://github.com/bugface",
"followers_url": "https://api.github.com/users/bugface/followers",
"following_url": "https://api.github.com/users/bugface/following{/other_user}",
"gists_url": "https://api.github.com/users/bugface/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bugface/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bugface/subscriptions",
"organizations_url": "https://api.github.com/users/bugface/orgs",
"repos_url": "https://api.github.com/users/bugface/repos",
"events_url": "https://api.github.com/users/bugface/events{/privacy}",
"received_events_url": "https://api.github.com/users/bugface/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | true | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Hi, restoring NLP models can be complicated as there are potentially many different artifacts needed for restore. This is why we've created the .nemo file and .restore_from. We mainly use the PyTorch Lightning Checkpoints to auto-resume from training. They can be used in other workflows outside of NeMo, but then the user would need to add custom implementation for restore.\r\n\r\nAnd to answer your question \"I did not know where did the megatron-bert-cased_encoder_config.json come from?\"\r\nMegatron models need certain artifacts to be instantiated, mainly the config and vocab. We generate both of these and automatically save them in the .nemo file when using Megatron models in NeMo NLP.\r\n\r\nAlso, we will be updating the NeMo NLP documentation with this information in the near future. Sorry for the current inconvenience."
] | 2021-03-05T19:50:19 | 2021-03-12T17:36:13 | 2021-03-12T17:36:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe your question**
After training token classification model, several checkpoints .ckpt were generated along with .nemo. Load .nemo is ok. But I tried to load checkpoints via:
```
nemo_nlp.models.TokenClassificationModel.load_from_checkpoint(my_chk_path)
```
but give an Error:
```
No such file or directory: 'megatron-bert-cased_encoder_config.json'
```
I unpacked the .nemo and found 5 files:
```
label_ids.csv
megatron-bert-cased_encoder_config.json
model_config.yaml
model_weights.ckpt
vocab.txt
```
I did not know where did the megatron-bert-cased_encoder_config.json come from?
**Environment overview (please complete the following information)**
using nemo docker from ngc and at BRANCH = 'r1.0.0rc1'
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1852/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1852/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1851 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1851/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1851/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1851/events | https://github.com/NVIDIA/NeMo/pull/1851 | 823,358,747 | MDExOlB1bGxSZXF1ZXN0NTg1ODI5NzMy | 1,851 | Cleanup save/restore | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-05T19:34:53 | 2021-03-05T20:49:33 | 2021-03-05T20:49:29 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1851",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1851",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1851.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1851.patch",
"merged_at": "2021-03-05T20:49:28"
} | * Remove EFF save/restore routes
* This PR also fixes some Copyright Headers
* Once we can take EFF dependency we will use EFF.Archive directly
Signed-off-by: Oleksii Kuchaiev <[email protected]> | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1851/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1851/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1850 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1850/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1850/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1850/events | https://github.com/NVIDIA/NeMo/pull/1850 | 823,354,236 | MDExOlB1bGxSZXF1ZXN0NTg1ODI1OTIz | 1,850 | ASR with Speaker Diarization noteboook | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-05T19:27:10 | 2021-03-08T05:41:23 | 2021-03-08T05:41:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1850",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1850",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1850.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1850.patch",
"merged_at": "2021-03-08T05:41:19"
} | Signed-off-by: nithinraok <[email protected]>
* Adds ASR with Speaker Diarization tutorial notebook that outputs transcripts with speaker label along with time stamps
Sample output:
`speaker_0 [0.40 - 2.62 sec] eleven twenty seven fifty seven`
`speaker_1 [3.20 - 5.02 sec] october twenty fourth nineteen seventy` | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1850/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1850/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1849 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1849/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1849/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1849/events | https://github.com/NVIDIA/NeMo/pull/1849 | 823,226,606 | MDExOlB1bGxSZXF1ZXN0NTg1NzIxNjg5 | 1,849 | Try TTS Updates Again | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-05T16:12:51 | 2021-03-05T19:58:17 | 2021-03-05T19:26:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1849",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1849",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1849.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1849.patch",
"merged_at": "2021-03-05T19:26:34"
} | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1849/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1849/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1848 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1848/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1848/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1848/events | https://github.com/NVIDIA/NeMo/pull/1848 | 822,612,065 | MDExOlB1bGxSZXF1ZXN0NTg1MjA5OTkw | 1,848 | Patch SPE tokenizer not being available in older ASR Checkpoints | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-04T23:59:38 | 2021-03-05T20:14:17 | 2021-03-05T03:44:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1848",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1848",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1848.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1848.patch",
"merged_at": "2021-03-05T03:44:00"
} | # Bugfix
- Older checkpoints might not have the `tokenizer.vocab` file when using SentencePiece tokenizers. This will cause model restoration to fail.
- Wrap in a try catch that catches ModelPT raised FileNotFoundError for this particular case to enable backward compatibility
Signed-off-by: smajumdar <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1848/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1848/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1847 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1847/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1847/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1847/events | https://github.com/NVIDIA/NeMo/pull/1847 | 822,535,758 | MDExOlB1bGxSZXF1ZXN0NTg1MTQ1MjEw | 1,847 | fix asr notebooks | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-04T21:48:02 | 2021-03-04T23:00:20 | 2021-03-04T23:00:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1847",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1847",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1847.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1847.patch",
"merged_at": "2021-03-04T23:00:13"
} | Signed-off-by: fayejf <[email protected]> | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1847/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1847/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1846 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1846/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1846/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1846/events | https://github.com/NVIDIA/NeMo/pull/1846 | 822,423,564 | MDExOlB1bGxSZXF1ZXN0NTg1MDUxMDA0 | 1,846 | fix 'DATA_DIR not found'. | {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-04T19:17:26 | 2021-03-04T19:57:42 | 2021-03-04T19:57:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1846",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1846",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1846.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1846.patch",
"merged_at": "2021-03-04T19:57:36"
} | Signed-off-by: Hoo Chang Shin <[email protected]> | {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1846/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1846/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1845 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1845/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1845/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1845/events | https://github.com/NVIDIA/NeMo/pull/1845 | 822,413,497 | MDExOlB1bGxSZXF1ZXN0NTg1MDQyODE1 | 1,845 | fix output path | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-04T19:02:07 | 2021-03-04T22:32:46 | 2021-03-04T22:32:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1845",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1845",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1845.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1845.patch",
"merged_at": "2021-03-04T22:32:46"
} | Signed-off-by: Yang Zhang <[email protected]> | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1845/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1845/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1844 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1844/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1844/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1844/events | https://github.com/NVIDIA/NeMo/pull/1844 | 821,839,783 | MDExOlB1bGxSZXF1ZXN0NTg0NTYwNzYy | 1,844 | Organizing the script folder | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Suggestion to change the folder name from speaker_diarization to speaker_recognition in scripts.\r\nI couldn't comment on unchanged files. Some links in speaker recognition notebooks point to these scripts. \r\nSome of them:\r\n\r\n> in tutorials/Speaker_Recognition_Verification.ipynb\r\n\r\n* get_hi-mia-data.py (https://github.com/NVIDIA/NeMo/blob/rir_noise_aug_2/scripts/get_hi-mia_data.py) script to download the necessary files -> get_hi-mia-data.py (https://github.com/NVIDIA/NeMo/blob/main/scripts/speaker_recognition/get_hi-mia_data.py) script to download the necessary files\r\n* wget -P scripts https://raw.githubusercontent.com/NVIDIA/NeMo/$BRANCH/scripts/scp_to_manifest.py -> wget -P scripts https://raw.githubusercontent.com/NVIDIA/NeMo/$BRANCH/scripts/speaker_recogntion/scp_to_manifest.py",
"This pull request **introduces 4 alerts** when merging 26e75e512ebd029be9c09f92a61ca2ad7d0fb257 into 89a8ea037a121001e105e95b49d71906a8de29aa - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-18e7412bcf8ad035dda398a0b8f5fffef1c6d2db)\n\n**new alerts:**\n\n* 4 for Unused import",
"I've checked scripts and tutorials for speech command, VAD and speaker diarization. \r\n\r\nCould you please change\r\n1. **NeMo/scripts/** in examples/asr/vad_infer to **NeMo/scripts/voice_activity_detection**\r\n2. multiple **<NEMO_ROOT>/scripts** in examples/asr/speech_to_label.py to correposinding subfolders.\r\n3. in tutorials/asr/06 VAD: scripts/voice_activity_recognition/process_vad_data -> scripts/**dataset_processing**/process_vad_data\r\n4. in tutorials/speaker_recognition/Speaker_Diarization_Inference.ipynb: \"you can also tune the threshold on your dev set. Use this provided script\" fix the link of the **script**. It would be much appreciated if you can also help change the link to https://github.com/NVIDIA/NeMo/blob/r1.0.0rc1/nemo/collections/asr/parts/vad_utils.py in the above line. \r\n\r\nThanks!\r\n",
"> \r\n> \r\n> I've checked scripts and tutorials for speech command, VAD and speaker diarization.\r\n> \r\n> Could you please change\r\n> \r\n> 1. **NeMo/scripts/** in examples/asr/vad_infer to **NeMo/scripts/voice_activity_detection**\r\n> \r\n> 2. multiple **<NEMO_ROOT>/scripts** in examples/asr/speech_to_label.py to correposinding subfolders.\r\n> \r\n> 3. in tutorials/asr/06 VAD: scripts/voice_activity_recognition/process_vad_data -> scripts/**dataset_processing**/process_vad_data\r\n> \r\n> 4. in tutorials/speaker_recognition/Speaker_Diarization_Inference.ipynb: \"you can also tune the threshold on your dev set. Use this provided script\" fix the link of the **script**. It would be much appreciated if you can also help change the link to https://github.com/NVIDIA/NeMo/blob/r1.0.0rc1/nemo/collections/asr/parts/vad_utils.py in the above line.\r\n> \r\n> \r\n> Thanks!\r\n\r\nThanks for checking them out. I missed them.\r\n1-done\r\n2-done\r\n3-done\r\n4-Please check it again to make sure I put the right links. We need to change them to main after the release?",
"> > I've checked scripts and tutorials for speech command, VAD and speaker diarization.\r\n> > Could you please change\r\n> > ```\r\n> > 1. **NeMo/scripts/** in examples/asr/vad_infer to **NeMo/scripts/voice_activity_detection**\r\n> > \r\n> > 2. multiple **<NEMO_ROOT>/scripts** in examples/asr/speech_to_label.py to correposinding subfolders.\r\n> > \r\n> > 3. in tutorials/asr/06 VAD: scripts/voice_activity_recognition/process_vad_data -> scripts/**dataset_processing**/process_vad_data\r\n> > \r\n> > 4. in tutorials/speaker_recognition/Speaker_Diarization_Inference.ipynb: \"you can also tune the threshold on your dev set. Use this provided script\" fix the link of the **script**. It would be much appreciated if you can also help change the link to https://github.com/NVIDIA/NeMo/blob/r1.0.0rc1/nemo/collections/asr/parts/vad_utils.py in the above line.\r\n> > ```\r\n> > \r\n> > \r\n> > Thanks!\r\n> \r\n> Thanks for checking them out. I missed them.\r\n> 1-done\r\n> 2-done\r\n> 3-done\r\n> 4-Please check it again to make sure I put the right links. We need to change them to main after the release?\r\n\r\nThe **here** one should be https://github.com/NVIDIA/NeMo/blob/r1.0.0rc1/nemo/collections/asr/parts/vad_utils.py\r\nThe **script** one should be https://github.com/NVIDIA/NeMo/blob/r1.0.0rc1/scripts/voice_activity_detection/vad_tune_threshold.py\r\n\r\nYes after the release. \r\nThanks.",
"I see you are merging to rc1 branch but links are pointed to main. If we test before merging to main, notebook tutorials gonna fail ",
"> \r\n> \r\n> I see you are merging to rc1 branch but links are pointed to main. If we test before merging to main, notebook tutorials gonna fail\r\n\r\nIt looks tricky. I tried not to change those parts. The code should work with both actually as RC is merged into main everyday. So if it is based on main, it was going to get tested with main anyway and this PR is not going to affect the results. Should I change all to main or RC?",
"> > I see you are merging to rc1 branch but links are pointed to main. If we test before merging to main, notebook tutorials gonna fail\r\n> \r\n> It looks tricky. I tried not to change those parts. The code should work with both actually as RC is merged into main everyday. So if it is based on main, it was going to get tested with main anyway and this PR is not going to affect the results. Should I change all to main or RC?\r\n\r\nActually I just see [one notebook](https://github.com/VahidooX/NeMo/blob/organize_scripts/tutorials/speaker_recognition/Speaker_Recognition_Verification.ipynb) script (get_hi-mia-data.py) to main branch, but rest of notebooks looks good. Also its path should be changed to `dataset_processing` not `speaker_recognition`. Just this rest all looks good to me. I vote main since for later releases we don't need to change again. ",
"> \r\n> \r\n> > > I see you are merging to rc1 branch but links are pointed to main. If we test before merging to main, notebook tutorials gonna fail\r\n> > \r\n> > \r\n> > It looks tricky. I tried not to change those parts. The code should work with both actually as RC is merged into main everyday. So if it is based on main, it was going to get tested with main anyway and this PR is not going to affect the results. Should I change all to main or RC?\r\n> \r\n> Actually I just see [one notebook](https://github.com/VahidooX/NeMo/blob/organize_scripts/tutorials/speaker_recognition/Speaker_Recognition_Verification.ipynb) script (get_hi-mia-data.py) to main branch, but rest of notebooks looks good. Also its path should be changed to `dataset_processing` not `speaker_recognition`. Just this rest all looks good to me. I vote main since for later releases we don't need to change again.\r\n\r\nThanks for catching them! Updated those. I also prefer main, but for now, I made them all RC as we are need to change others to master later anyway. "
] | 2021-03-04T07:20:13 | 2021-05-03T21:54:42 | 2021-03-10T23:24:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1844",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1844",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1844.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1844.patch",
"merged_at": "2021-03-10T23:24:00"
} | Organized the scripts folder based on the task. This is an initial draft. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1844/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1844/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1843 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1843/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1843/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1843/events | https://github.com/NVIDIA/NeMo/pull/1843 | 821,656,182 | MDExOlB1bGxSZXF1ZXN0NTg0NDA5NDg2 | 1,843 | grammar fix | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-04T01:15:28 | 2021-03-04T16:36:53 | 2021-03-04T16:36:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1843",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1843",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1843.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1843.patch",
"merged_at": "2021-03-04T16:36:49"
} | Signed-off-by: nithinraok <[email protected]> | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1843/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1843/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1842 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1842/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1842/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1842/events | https://github.com/NVIDIA/NeMo/pull/1842 | 821,627,804 | MDExOlB1bGxSZXF1ZXN0NTg0Mzg2NTk0 | 1,842 | Limit the maximum length of subwords generated from corpus | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-04T00:15:37 | 2021-03-04T01:09:59 | 2021-03-04T01:09:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1842",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1842",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1842.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1842.patch",
"merged_at": "2021-03-04T01:09:57"
} | # Changelog
- Add tokenizer generator flag to limit the maximum length of subwords generated | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1842/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1842/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1841 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1841/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1841/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1841/events | https://github.com/NVIDIA/NeMo/pull/1841 | 821,621,661 | MDExOlB1bGxSZXF1ZXN0NTg0MzgxNzcx | 1,841 | fix to avoid 'DATA_DIR not found' | {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Thanks @ekmb , just did :) ",
"yes please, this looks like bugfix for r1.0.0rc1",
"Thanks @ekmb and @okuchaiev - rebasing to r1.0.0rc1 resulted in many file changes, but notebook hasn't changed at all.",
"This pull request **introduces 4 alerts** when merging f6e7fc182f103e0b58c47ccb39645995ac178324 into bc38019ffa144dcf0bfc735a9838bb0e6fba71ab - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2d6425e234837de89ff7012c4a2fb38315c3ad09)\n\n**new alerts:**\n\n* 4 for Unused import"
] | 2021-03-04T00:03:21 | 2021-03-04T19:14:28 | 2021-03-04T19:13:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1841",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1841",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1841.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1841.patch",
"merged_at": null
} | Signed-off-by: Hoo Chang Shin <[email protected]> | {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1841/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1841/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1840 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1840/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1840/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1840/events | https://github.com/NVIDIA/NeMo/pull/1840 | 821,541,804 | MDExOlB1bGxSZXF1ZXN0NTg0MzExMjQz | 1,840 | fix path name | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-03T22:29:50 | 2021-03-04T00:06:01 | 2021-03-04T00:05:58 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1840",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1840",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1840.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1840.patch",
"merged_at": "2021-03-04T00:05:58"
} | Signed-off-by: Yang Zhang <[email protected]> | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1840/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1840/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1839 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1839/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1839/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1839/events | https://github.com/NVIDIA/NeMo/pull/1839 | 821,476,460 | MDExOlB1bGxSZXF1ZXN0NTg0MjU5NzU1 | 1,839 | CI Fixes for Lightning 1.2.1 | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-03T20:58:41 | 2021-03-04T20:01:00 | 2021-03-04T19:50:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1839",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1839",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1839.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1839.patch",
"merged_at": "2021-03-04T19:50:30"
} | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1839/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1839/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1838 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1838/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1838/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1838/events | https://github.com/NVIDIA/NeMo/pull/1838 | 821,459,095 | MDExOlB1bGxSZXF1ZXN0NTg0MjQ1Mjg2 | 1,838 | typo fixes | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-03T20:31:44 | 2021-03-03T22:08:15 | 2021-03-03T22:08:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1838",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1838",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1838.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1838.patch",
"merged_at": "2021-03-03T22:08:08"
} | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1838/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1838/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1837 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1837/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1837/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1837/events | https://github.com/NVIDIA/NeMo/pull/1837 | 821,457,045 | MDExOlB1bGxSZXF1ZXN0NTg0MjQzNTk0 | 1,837 | Fix TTS Notebook bugs | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-03T20:28:43 | 2021-03-03T21:37:25 | 2021-03-03T21:37:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1837",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1837",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1837.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1837.patch",
"merged_at": "2021-03-03T21:37:22"
} | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1837/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1837/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1836 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1836/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1836/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1836/events | https://github.com/NVIDIA/NeMo/pull/1836 | 821,423,016 | MDExOlB1bGxSZXF1ZXN0NTg0MjE1NzQz | 1,836 | Fix text norm tutorial | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-03T19:38:26 | 2021-03-03T22:34:04 | 2021-03-03T22:33:59 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1836",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1836",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1836.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1836.patch",
"merged_at": "2021-03-03T22:33:59"
} | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1836/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1836/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1835 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1835/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1835/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1835/events | https://github.com/NVIDIA/NeMo/pull/1835 | 821,422,968 | MDExOlB1bGxSZXF1ZXN0NTg0MjE1NzA2 | 1,835 | Fix enja decoding (round 2) | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-03T19:38:20 | 2022-01-11T16:36:53 | 2021-03-03T20:27:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1835",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1835",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1835.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1835.patch",
"merged_at": "2021-03-03T20:27:35"
} | after trying hard to make yttm and spm play nicely together, i am giving up on the latter. the en<>ja pipeline is now moses -> yttm. from what i can see, this fixes tokenization & detokenization issues we were seeing (eg, `'` was being split apart incorrectly during tokenization, preventing it from being detokenized correctly).
we also turn off moses normalization for japanese because it wasn't handling punctuation correctly | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1835/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1835/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1834 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1834/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1834/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1834/events | https://github.com/NVIDIA/NeMo/pull/1834 | 821,396,464 | MDExOlB1bGxSZXF1ZXN0NTg0MTk0MzM2 | 1,834 | fix nlp typos in notebooks | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Looks like you fixed it in #1836. Closing this one"
] | 2021-03-03T19:01:22 | 2021-03-04T16:43:01 | 2021-03-04T16:42:54 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1834",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1834",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1834.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1834.patch",
"merged_at": null
} | Signed-off-by: Yang Zhang <[email protected]> | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1834/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1834/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1833 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1833/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1833/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1833/events | https://github.com/NVIDIA/NeMo/issues/1833 | 820,944,942 | MDU6SXNzdWU4MjA5NDQ5NDI= | 1,833 | Bug in the Text_Classification_Sentiment_Analysis notebook when using wietsedv/bert-base-dutch-cased config | {
"login": "DanaIlie",
"id": 19664770,
"node_id": "MDQ6VXNlcjE5NjY0Nzcw",
"avatar_url": "https://avatars.githubusercontent.com/u/19664770?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DanaIlie",
"html_url": "https://github.com/DanaIlie",
"followers_url": "https://api.github.com/users/DanaIlie/followers",
"following_url": "https://api.github.com/users/DanaIlie/following{/other_user}",
"gists_url": "https://api.github.com/users/DanaIlie/gists{/gist_id}",
"starred_url": "https://api.github.com/users/DanaIlie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanaIlie/subscriptions",
"organizations_url": "https://api.github.com/users/DanaIlie/orgs",
"repos_url": "https://api.github.com/users/DanaIlie/repos",
"events_url": "https://api.github.com/users/DanaIlie/events{/privacy}",
"received_events_url": "https://api.github.com/users/DanaIlie/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2021-03-03T09:54:44 | 2021-10-26T23:43:52 | 2021-10-26T23:43:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
When im trying to run the sentiment notebook in the main branch I can perfectly use the bert-base-uncased and bert-base-multilingual-uncased models and finetune on our data. However, when we run the wietsedv/bert-base-dutch-cased model we get the following error: Index out of range in self. To me it seems like there is something going wrong in the embedding layers. When we ran this model in NeMo version 0.11 it worked fine.

Is there anything in the configs that changed?
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1833/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1833/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1832 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1832/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1832/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1832/events | https://github.com/NVIDIA/NeMo/pull/1832 | 820,795,576 | MDExOlB1bGxSZXF1ZXN0NTgzNjk1Nzk2 | 1,832 | bug removed : onnx file was not getting added to the tarfile (.enemo) | {
"login": "snlpatel001213",
"id": 6880272,
"node_id": "MDQ6VXNlcjY4ODAyNzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6880272?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/snlpatel001213",
"html_url": "https://github.com/snlpatel001213",
"followers_url": "https://api.github.com/users/snlpatel001213/followers",
"following_url": "https://api.github.com/users/snlpatel001213/following{/other_user}",
"gists_url": "https://api.github.com/users/snlpatel001213/gists{/gist_id}",
"starred_url": "https://api.github.com/users/snlpatel001213/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/snlpatel001213/subscriptions",
"organizations_url": "https://api.github.com/users/snlpatel001213/orgs",
"repos_url": "https://api.github.com/users/snlpatel001213/repos",
"events_url": "https://api.github.com/users/snlpatel001213/events{/privacy}",
"received_events_url": "https://api.github.com/users/snlpatel001213/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **fixes 1 alert** when merging aebab0e12600a6fa4be346c88112a88716f7dc42 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-427bb1d02f76b9b8378adc5f5b98f401e4e73e54)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **fixes 1 alert** when merging 5c91f70297421bb1ded56458e495982d792fe642 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f81a394a8cc0e26c328d44e7ef1ff6720d0d5c78)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **fixes 1 alert** when merging 71382baea3f1b4ad5dca5c110ce2e9a2e8c640eb into 91774a74a38335d6b0090174861fecde54c764ff - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-26525b782c9a8caa3f1ebac9212adc62a61c6849)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"@purn3ndu Please have a look",
"This pull request **fixes 1 alert** when merging 789e805879470681bea97140154030977073e61d into 91774a74a38335d6b0090174861fecde54c764ff - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-0bbe084f8116a5f9e7f31fee1e1b69ca85e9b896)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"Approved, pending CI.",
"This pull request **fixes 1 alert** when merging 57c696a633a6d8d1907655ad26c8ab5ae7579cec into 91774a74a38335d6b0090174861fecde54c764ff - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-566dec3fc8194ef92f30111e8d9cafdc42767199)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **fixes 1 alert** when merging 8b58cb55fd62896c8d6536509b3a5a1bb0f90560 into 37f65336d0fe8fb0360258da98756384f2f11196 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3946a2ce11d9dda043a870035889dafb0688c2a2)\n\n**fixed alerts:**\n\n* 1 for Unused import"
] | 2021-03-03T06:30:46 | 2021-03-04T20:40:00 | 2021-03-04T20:40:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1832",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1832",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1832.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1832.patch",
"merged_at": "2021-03-04T20:40:00"
} | **What was wrong** : renaming and adding onnx to tar was not working
**How solved** : make a temp copy of the file rename and add to tar(.enemo). cleanup extra file
**Nvidia internal bug** : 200706409 | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1832/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1832/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1831 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1831/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1831/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1831/events | https://github.com/NVIDIA/NeMo/pull/1831 | 820,574,986 | MDExOlB1bGxSZXF1ZXN0NTgzNDk2NTQw | 1,831 | Patch ASR Notebooks | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@redoctopus Ignore the huge diff for speech commands (notebook 3). Switched it to Colab compatible notebook."
] | 2021-03-03T02:31:24 | 2021-03-03T17:22:38 | 2021-03-03T17:22:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1831",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1831",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1831.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1831.patch",
"merged_at": "2021-03-03T17:22:35"
} | # Changelog
- Fixes for notebook
- Add back image for CTC alignments
Signed-off-by: smajumdar <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1831/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1831/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1830 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1830/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1830/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1830/events | https://github.com/NVIDIA/NeMo/pull/1830 | 820,443,394 | MDExOlB1bGxSZXF1ZXN0NTgzMzg2MzQ5 | 1,830 | Update TTS Docs for RC1 | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-02T22:29:02 | 2021-03-11T18:06:22 | 2021-03-09T19:26:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1830",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1830",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1830.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1830.patch",
"merged_at": null
} | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1830/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1830/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1829 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1829/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1829/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1829/events | https://github.com/NVIDIA/NeMo/pull/1829 | 820,441,703 | MDExOlB1bGxSZXF1ZXN0NTgzMzg0OTE4 | 1,829 | Fixing NMT DDP override that no longer works with PTL 1.2 | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"thanks @ericharper !",
"This pull request **introduces 3 alerts** when merging 9dcc1f64b1c17437a1403e44e44ef03cfce3e122 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-70210a020f64159d504b1a88930512edba534cf8)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging dbfa7b3854023ef0910227de56ce26457f036edb into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6cca4e6f4f304898526462dbd12742b412bde2d5)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging 0f411448a03fc5d4515edaf1af3b2f282adef0b8 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1d886c4d0c8f69a070dbfb8071a77b1c22dfc067)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging 9631de965b199109a65c7dc491ca0ddbce21a40c into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-de2cf13324bb7e30b1e222a508c63c509f1104bc)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging 182eb34c53839e8f01983b14cdbaec77bb53c4e1 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-61260e6612c74a9efc3f854317ef448854a8be1c)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging 86bc8dea2aa33a4025b62284105dfc2b74b44faa into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1571b280ef8b396e3c8be708ab133621c586a039)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging 8644e66856d98be42e51d2cd70dc50593b464037 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-34316b2eaedd7c8bf182799535c6745c7ae97d0f)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging c0099e9d464493ad3ccdd68aeb4fd13f8c163426 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-d3bcf405a97cc818651b03e0a12bd33dc2d6901c)\n\n**new alerts:**\n\n* 3 for Unused import",
"This pull request **introduces 3 alerts** when merging 6c488a4ade1d451ff513ab046d2cc53759c5dae2 into 79bef5681e9023287c8a839b3eb5d0bad25dd3eb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-39a83a00139f45b4f32a32c18c6d5ee3c6bd0a5e)\n\n**new alerts:**\n\n* 3 for Unused import"
] | 2021-03-02T22:26:08 | 2021-03-03T22:08:42 | 2021-03-03T20:50:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1829",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1829",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1829.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1829.patch",
"merged_at": "2021-03-03T20:50:09"
} | Also, need to update/add tests that would have caught this problem. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1829/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1829/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1828 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1828/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1828/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1828/events | https://github.com/NVIDIA/NeMo/issues/1828 | 820,380,933 | MDU6SXNzdWU4MjAzODA5MzM= | 1,828 | PTL 1.2.0 upgrade breaks draco training | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This should be fixed on main now: https://github.com/NVIDIA/NeMo/pull/1829\r\n\r\nPlease let use know if there are still issues.",
"Closing, reopen if needed"
] | 2021-03-02T20:51:08 | 2021-03-12T15:58:34 | 2021-03-12T15:58:34 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | traceback error on draco:
```
Traceback (most recent call last):
File "/home/dcg-adlr-mchrzanowski-source/NeMo/examples/nlp/machine_translation/enc_dec_nmt.py", line 127, in main
trainer.fit(mt_model)
File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 471, in fit
self.call_setup_hook(model)
File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 1072, in call_setup_hook
model.setup(stage_name)
File "/home/dcg-adlr-mchrzanowski-source/NeMo/nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py", line 453, in setup
self._trainer.accelerator_backend.ddp_plugin.configure_ddp = self.configure_ddp
AttributeError: 'GPUAccelerator' object has no attribute 'ddp_plugin'
```
reverting the changes from [PR 1774](https://github.com/NVIDIA/NeMo/pull/1774) fixes things. | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1828/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1828/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1827 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1827/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1827/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1827/events | https://github.com/NVIDIA/NeMo/pull/1827 | 820,282,737 | MDExOlB1bGxSZXF1ZXN0NTgzMjUxOTM0 | 1,827 | Fix for variable names in tarred dataset creation | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-02T18:39:42 | 2021-03-04T17:06:11 | 2021-03-02T21:45:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1827",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1827",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1827.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1827.patch",
"merged_at": "2021-03-02T21:45:15"
} | Fixes a bug in the variable names when creating tarred parallel datasets. | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1827/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1827/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1826 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1826/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1826/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1826/events | https://github.com/NVIDIA/NeMo/pull/1826 | 820,201,181 | MDExOlB1bGxSZXF1ZXN0NTgzMTg1MTQ3 | 1,826 | WIP: intent/slot training with separate datasets | {
"login": "carolmanderson",
"id": 25518180,
"node_id": "MDQ6VXNlcjI1NTE4MTgw",
"avatar_url": "https://avatars.githubusercontent.com/u/25518180?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carolmanderson",
"html_url": "https://github.com/carolmanderson",
"followers_url": "https://api.github.com/users/carolmanderson/followers",
"following_url": "https://api.github.com/users/carolmanderson/following{/other_user}",
"gists_url": "https://api.github.com/users/carolmanderson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carolmanderson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carolmanderson/subscriptions",
"organizations_url": "https://api.github.com/users/carolmanderson/orgs",
"repos_url": "https://api.github.com/users/carolmanderson/repos",
"events_url": "https://api.github.com/users/carolmanderson/events{/privacy}",
"received_events_url": "https://api.github.com/users/carolmanderson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"If only intents are available, please use the text classification model. If only slots - token classification model.",
"@ekmb the goal here is to train a single model capable of predicting both intents and slots, for use in the botmaker framework. We want users to be able to train the model even if they don't have intents and slots labeled in the same set of utterances. We don't want to force them to have two separate models.\r\n\r\nTo clarify: we are assuming the user has data with slots labeled AND data with intents labeled. The labels just might be for different sets of utterances.",
"This pull request **introduces 8 alerts** when merging c7ee58244625478ca35462dddfe7a300326dde14 into ac79c2c6a5f50186bdcaceb9e72a8391271ce120 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2ca8db7e3dff8cdeb6c5991d077644b4945c5f04)\n\n**new alerts:**\n\n* 7 for Variable defined multiple times\n* 1 for Unguarded next in generator",
"Carol, I am not sure that it is needed from a practical point of view. Since usually you do not label slots separately from intents since they are usually related, no?",
"This feature will make it much easier for users of the botmaker framework to create training data. They may not have intents and slots labeled at all, or may not have both labeled in the same data set. With this change, they can use existing data sets that have entities labeled and just label the intents in their own data (or vice-versa). Example: currently Zhen has created a data set for his bot with only intents labeled. We want to add slots, but we don't want to have to go through every single one of Zhen's utterances to label the slots. With this change we make a smaller training data set just for slots.",
"This model is so widely used and I am afraid that any significant changes in it may have unforeseen effects. @carolmanderson let's discuss more offline your needs for training of this model. May be I can think on some alternative solution during data preparation or the opposite you will convince me that this model extension is necessary.",
"@carolmanderson and @vladgets is this PR still WIP?",
"I'll close it. I haven't had time to work on it lately and I think we may end up trying a different approach. "
] | 2021-03-02T16:54:08 | 2021-07-20T02:26:22 | 2021-07-20T02:26:22 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1826",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1826",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1826.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1826.patch",
"merged_at": null
} | Requesting early feedback on the approach.
The purpose of these changes is to allow the joint intent/slot model to be trained on data where only slots are labeled or only intents are labeled.
* Users can supply _up to_ three labeled data sets: one with only slots labeled, one with only intents labeled, and one with both slots and intents labeled
* Separate Dataset objects are created for each of the above
* A custom Sampler tells the training Dataloader which examples to put into each minibatch
* Each minibatch draws from only one data source. When the loss is calculated, intent loss is set to zeroes if no intent labels are supplied; slot loss is set to zeroes if no slot labels are supplied. This is controlled by a data type indicator variable passed from the data loader.
I initially implemented these changes in a subclass of the existing intent/slot model (as well as the dataset and data descriptor classes), but it seems like that will create an extra burden to maintain two model classes that do essentially the same thing. So now I've made the changes directly in the existing model.
| {
"login": "carolmanderson",
"id": 25518180,
"node_id": "MDQ6VXNlcjI1NTE4MTgw",
"avatar_url": "https://avatars.githubusercontent.com/u/25518180?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carolmanderson",
"html_url": "https://github.com/carolmanderson",
"followers_url": "https://api.github.com/users/carolmanderson/followers",
"following_url": "https://api.github.com/users/carolmanderson/following{/other_user}",
"gists_url": "https://api.github.com/users/carolmanderson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carolmanderson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carolmanderson/subscriptions",
"organizations_url": "https://api.github.com/users/carolmanderson/orgs",
"repos_url": "https://api.github.com/users/carolmanderson/repos",
"events_url": "https://api.github.com/users/carolmanderson/events{/privacy}",
"received_events_url": "https://api.github.com/users/carolmanderson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1826/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1826/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1825 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1825/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1825/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1825/events | https://github.com/NVIDIA/NeMo/issues/1825 | 820,062,543 | MDU6SXNzdWU4MjAwNjI1NDM= | 1,825 | [Question] How to use exported ASR model? | {
"login": "loganlebanoff",
"id": 10007282,
"node_id": "MDQ6VXNlcjEwMDA3Mjgy",
"avatar_url": "https://avatars.githubusercontent.com/u/10007282?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/loganlebanoff",
"html_url": "https://github.com/loganlebanoff",
"followers_url": "https://api.github.com/users/loganlebanoff/followers",
"following_url": "https://api.github.com/users/loganlebanoff/following{/other_user}",
"gists_url": "https://api.github.com/users/loganlebanoff/gists{/gist_id}",
"starred_url": "https://api.github.com/users/loganlebanoff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/loganlebanoff/subscriptions",
"organizations_url": "https://api.github.com/users/loganlebanoff/orgs",
"repos_url": "https://api.github.com/users/loganlebanoff/repos",
"events_url": "https://api.github.com/users/loganlebanoff/events{/privacy}",
"received_events_url": "https://api.github.com/users/loganlebanoff/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Is there any progress on this issue? I am currently trying to run inference for QuartzNet model using ONNX. I used EncDecCTCModel.export to export my model in ONNX format and using onnxruntime to do inference as follows:\r\n\r\n```\r\nsess = onnxruntime.InferenceSession(\"model.onnx\")\r\npred = sess.run(None, {input_name: input_.reshape(1, 64, -1)})[0]\r\n```\r\n\r\nHowever, input here is just an arbitrary tensor created with numpy. How should we process our audio files for this?",
"I'm also stuck on this. I can't find any information that describes how to process audio onnxruntime. Would really appreciate some guidance.",
"> I'm also stuck on this. I can't find any information that describes how to process audio onnxruntime. Would really appreciate some guidance.\r\n\r\nSince onnx model includes the pytorch model only and not preprocessing or postprocessing parts, what we need to do is follow the NeMo code and see how it processes input and output of the model. I managed to succesfully use onnx exported QuartzNet model for ASR. I used default QuartzNet configs provided by Nvidia. What I did is as follows, you may need to adjust code structure a bit.\r\n\r\nNote that this is partly same as code provided in the original question.\r\n\r\n\r\n```\r\nimport onnxruntime\r\nfrom nemo.collections.asr.models.ctc_models import EncDecCTCModel\r\n# wer applied after getting logits from onnx model\r\nfrom nemo.collections.asr.metrics import wer\r\n# we will use these to replicate what NeMo does\r\nfrom util import softmax, get_nemo_dataset\r\n\r\n\r\n# create onnx session with model (assuming you already exported your model)\r\nself.sess = onnxruntime.InferenceSession(model_to_load)\r\nself.input_name = self.sess.get_inputs()[0].name\r\nself.label_name = self.sess.get_outputs()[0].name\r\n\r\nself.wer = wer.WER(\r\n vocabulary=self.params[\"labels\"], # your vocabulary here (characters in your alphabet)\r\n batch_dim_index=0,\r\n use_cer=False, # I only tested with wer and not cer\r\n ctc_decode=True,\r\n dist_sync_on_step=True,\r\n)\r\n\r\n# your quartznet config\r\nconfig_path = \"./nemo_stt_engine/configs/quartznet5x5.yaml\"\r\n# your exported onnx model path\r\nmodel_to_load = \"./nemo_stt_engine/models/QuartzNet5x5/epoch=99.onnx\" \r\n\r\nyaml = YAML(typ='safe')\r\nwith open(config_path) as f:\r\n self.params = yaml.load(f)\r\n\r\n# create preprocessor (NeMo does this inside EncDecCTCModel, here we do it explicitly since we are going to use onnx and not EncDecCTCModel)\r\npreprocessor_cfg = DictConfig(self.params['model']).preprocessor\r\nself.preprocessor = EncDecCTCModel.from_config_dict(preprocessor_cfg)\r\n\r\n# this part is just copy pasted from NeMo library code\r\nwith tempfile.TemporaryDirectory() as dataloader_tmpdir:\r\n with open(os.path.join(dataloader_tmpdir, 'manifest.json'), 'w') as fp:\r\n for audio_file in files:\r\n entry = {'audio_filepath': audio_file, 'duration': 100000, 'text': 'nothing'}\r\n fp.write(json.dumps(entry) + '\\n')\r\n out_batch = []\r\n config = {'paths2audio_files': files, 'batch_size': 1, 'temp_dir': dataloader_tmpdir}\r\n temporary_datalayer = get_nemo_dataset(config, self.params[\"labels\"], 16000)\r\n for test_batch in temporary_datalayer:\r\n out_batch.append(test_batch)\r\n\r\n# preprocess audio just like NeMo does\r\nprocessed_signal, processed_signal_length = self.preprocessor(input_signal=out_batch[0][0], length=out_batch[0][1], )\r\nprocessed_signal = processed_signal.cpu().numpy()\r\n\r\n# finally make an inference using onnx model\r\nlogits = self.sess.run([self.label_name], {self.input_name: processed_signal})\r\n\r\n# if you want to decode your logits to sentence\r\nprobabilities = logits[0][0]\r\na = np.array([np.argmax(x) for x in probabilities])\r\na = np.expand_dims(a, 0)\r\na = torch.from_numpy(a)\r\nprediction = self.wer.ctc_decoder_predictions_tensor(a)\r\n```",
"@ulucsahin hi, where could I find `get_nemo_dataset` function?",
"My mistake, as far as I remember, it is a method that I wrote by using code parts from NeMo (I may copy pasted it completely from NeMo source code, but currently I can't recall it).\r\n\r\nHere is my implementation for get_nemo_dataset.\r\n\r\n```\r\ndef get_nemo_dataset(config, vocab, sample_rate=16000):\r\n augmentor = None\r\n\r\n config = {\r\n 'manifest_filepath': os.path.join(config['temp_dir'], 'manifest.json'),\r\n 'sample_rate': sample_rate,\r\n 'labels': vocab,\r\n 'batch_size': min(config['batch_size'], len(config['paths2audio_files'])),\r\n 'trim_silence': True,\r\n 'shuffle': False,\r\n }\r\n\r\n dataset = AudioToCharDataset(\r\n manifest_filepath=config['manifest_filepath'],\r\n labels=config['labels'],\r\n sample_rate=config['sample_rate'],\r\n int_values=config.get('int_values', False),\r\n augmentor=augmentor,\r\n max_duration=config.get('max_duration', None),\r\n min_duration=config.get('min_duration', None),\r\n max_utts=config.get('max_utts', 0),\r\n blank_index=config.get('blank_index', -1),\r\n unk_index=config.get('unk_index', -1),\r\n normalize=config.get('normalize_transcripts', False),\r\n trim=config.get('trim_silence', True),\r\n load_audio=config.get('load_audio', True),\r\n parser=config.get('parser', 'en'),\r\n add_misc=config.get('add_misc', False),\r\n )\r\n\r\n return torch.utils.data.DataLoader(\r\n dataset=dataset,\r\n batch_size=config['batch_size'],\r\n collate_fn=dataset.collate_fn,\r\n drop_last=config.get('drop_last', False),\r\n shuffle=True,\r\n num_workers=config.get('num_workers', 0),\r\n pin_memory=config.get('pin_memory', False),\r\n )\r\n```",
"@ulucsahin thanks! \r\n\r\nwell, it looks like the order of steps is the next and it should work for all models:\r\n\r\n1. Export onnx model and config\r\n```\r\nimport nemo.collections.asr as nemo_asr\r\nfrom omegaconf import OmegaConf\r\n\r\nmodelReco = nemo_asr.models.ASRModel.restore_from(restore_path=\"stt_en_citrinet_256.nemo\")\r\nmodelReco.export(\"stt_en_citrinet_256.onnx\", onnx_opset_version=12)\r\n\r\nmodelReco = nemo_asr.models.ASRModel.restore_from(restore_path=\"stt_en_citrinet_256.nemo\", return_config = True) # restore config is set to True\r\ntextfile = open(\"config_stt_en_citrinet_256.yaml\", \"w\")\r\ntextfile.write(str(OmegaConf.to_yaml(modelReco)))\r\ntextfile.close()\r\n```\r\nnow we have onnx and yaml files\r\n\r\n2. Load onnx and yaml together with wav file:\r\n```\r\nimport onnxruntime\r\nimport tempfile\r\nfrom nemo.collections.asr.models.ctc_models import EncDecCTCModel\r\nfrom nemo.collections.asr.data.audio_to_text import AudioToCharDataset\r\nimport os\r\nimport torch\r\nimport yaml\r\nfrom omegaconf import DictConfig\r\nimport json\r\nimport numpy as np\r\n\r\n# your quartznet config\r\nconfig_path = \"config_stt_en_citrinet_256.yaml\"\r\n# your exported onnx model path\r\nmodel_to_load = \"stt_en_citrinet_256.onnx\"\r\n\r\nwith open(config_path) as f:\r\n params = yaml.safe_load(f)\r\n\r\n# create onnx session with model (assuming you already exported your model)\r\nsess = onnxruntime.InferenceSession(model_to_load)\r\ninput_name = sess.get_inputs()[0].name\r\nlabel_name = sess.get_outputs()[0].name\r\n\r\n# create preprocessor (NeMo does this inside EncDecCTCModel, here we do it explicitly since we are going to use onnx and not EncDecCTCModel)\r\npreprocessor_cfg = DictConfig(params).preprocessor\r\npreprocessor = EncDecCTCModel.from_config_dict(preprocessor_cfg)\r\n\r\naudio_file = \"test.wav\"\r\nlabels = params['decoder']['vocabulary'] #\"vocabulary\" could be something else depending on model\r\n\r\n# this part is just copy pasted from NeMo library code\r\nwith tempfile.TemporaryDirectory() as dataloader_tmpdir:\r\n with open(os.path.join(dataloader_tmpdir, 'manifest.json'), 'w') as fp:\r\n entry = {'audio_filepath': audio_file, 'duration': 100000, 'text': 'nothing'}\r\n fp.write(json.dumps(entry) + '\\n')\r\n out_batch = []\r\n config = {'paths2audio_files': [audio_file], 'batch_size': 1, 'temp_dir': dataloader_tmpdir}\r\n temporary_datalayer = get_nemo_dataset(config, labels, 16000)\r\n for test_batch in temporary_datalayer:\r\n out_batch.append(test_batch)\r\n\r\n# preprocess audio just like NeMo does\r\nprocessed_signal, processed_signal_length = preprocessor(input_signal=out_batch[0][0], length=out_batch[0][1], )\r\nprocessed_signal = processed_signal.cpu().numpy()\r\n\r\n# finally make an inference using onnx model\r\nlogits = sess.run([label_name], {input_name: processed_signal})\r\nprobabilities = logits[0][0]\r\n\r\nprobs = softmax(probabilities)\r\n\r\n#silence\r\nlabels.append(\"blank\")\r\n\r\nletters = get_letters(probs)\r\n```\r\n\r\nwith several helper functions to get letters from logits:\r\n```\r\ndef softmax(logits):\r\n e = np.exp(logits - np.max(logits))\r\n return e / e.sum(axis=-1).reshape([logits.shape[0], 1])\r\n\r\ndef get_nemo_dataset(config, vocab, sample_rate=16000):\r\n augmentor = None\r\n\r\n config = {\r\n 'manifest_filepath': os.path.join(config['temp_dir'], 'manifest.json'),\r\n 'sample_rate': sample_rate,\r\n 'labels': vocab,\r\n 'batch_size': min(config['batch_size'], len(config['paths2audio_files'])),\r\n 'trim_silence': True,\r\n 'shuffle': False,\r\n }\r\n\r\n dataset = AudioToCharDataset(\r\n manifest_filepath=config['manifest_filepath'],\r\n labels=config['labels'],\r\n sample_rate=config['sample_rate'],\r\n int_values=config.get('int_values', False),\r\n augmentor=augmentor,\r\n max_duration=config.get('max_duration', None),\r\n min_duration=config.get('min_duration', None),\r\n max_utts=config.get('max_utts', 0),\r\n blank_index=config.get('blank_index', -1),\r\n unk_index=config.get('unk_index', -1),\r\n normalize=config.get('normalize_transcripts', False),\r\n trim=config.get('trim_silence', True),\r\n load_audio=config.get('load_audio', True),\r\n parser=config.get('parser', 'en'),\r\n add_misc=config.get('add_misc', False),\r\n )\r\n\r\n return torch.utils.data.DataLoader(\r\n dataset=dataset,\r\n batch_size=config['batch_size'],\r\n collate_fn=dataset.collate_fn,\r\n drop_last=config.get('drop_last', False),\r\n shuffle=True,\r\n num_workers=config.get('num_workers', 0),\r\n pin_memory=config.get('pin_memory', False),\r\n )\r\n\r\ndef get_letters(probs):\r\n letters = []\r\n for idx in range(0, probs.shape[0]):\r\n current_char_idx = np.argmax(probs[idx])\r\n if labels[current_char_idx] != \"blank\":\r\n letters.append([labels[current_char_idx], idx])\r\n return letters\r\n```",
"The main reason of using `.onnx`-model is the possibility to run the nemo-model for transcribing without `nemo`-classes.\r\nOtherwise, why do I need to export the model to ONNX?\r\n\r\nIs there a way to do the preprocessing and postprocessing without classes from `nemo`-library?\r\n",
"Can you provider onnx model dowload links? thank you!"
] | 2021-03-02T14:19:22 | 2024-12-29T07:06:05 | 2021-07-13T15:23:46 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I've successfully run this script (https://github.com/NVIDIA/NeMo/blob/v1.0.0b3/scripts/convasr_to_single_onnx.py) to convert QuartzNet15x5 to ONNX. But how do I then use that model for inference in python? I.e., what preprocessing steps do I need to do in order to pass inputs into the ONNX model?
To make it work for me, I had to do the following workaround, but what is the right way to do this?
```
import nemo.collections.asr as asr
import onnxruntime
import tempfile
import os
import json
asr_model = asr.models.EncDecCTCModel.from_pretrained(model_name='QuartzNet15x5Base-En', strict=True)
so = onnxruntime.SessionOptions()
so.graph_optimization_level = onnxruntime.GraphOptimizationLevel.ORT_ENABLE_ALL
so.intra_op_num_threads = 1
onnx_file = 'quartznet.onnx'
session = onnxruntime.InferenceSession(onnx_file, so)
wav_path = '/path/to/file.wav'
paths2audio_files = [wav_path]
with tempfile.TemporaryDirectory() as dataloader_tmpdir:
with open(os.path.join(dataloader_tmpdir, 'manifest.json'), 'w') as fp:
for audio_file in paths2audio_files:
entry = {'audio_filepath': audio_file, 'duration': 100000, 'text': 'nothing'}
fp.write(json.dumps(entry) + '\n')
out_batch = []
config = {'paths2audio_files': paths2audio_files, 'batch_size': 4, 'temp_dir': dataloader_tmpdir}
temporary_datalayer = asr_model._setup_transcribe_dataloader(config)
for test_batch in temporary_datalayer:
out_batch.append(test_batch)
processed_signal, processed_signal_length = asr_model.preprocessor(
input_signal=out_batch[0][0], length=out_batch[0][1],
)
processed_signal = processed_signal.cpu().numpy()
logits = session.run([output_name], {input_name: processed_signal})[0]
``` | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1825/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1825/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1824 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1824/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1824/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1824/events | https://github.com/NVIDIA/NeMo/issues/1824 | 819,756,451 | MDU6SXNzdWU4MTk3NTY0NTE= | 1,824 | [Question] When is the latest beta version going to be on PyPI? | {
"login": "m-zat",
"id": 68003799,
"node_id": "MDQ6VXNlcjY4MDAzNzk5",
"avatar_url": "https://avatars.githubusercontent.com/u/68003799?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/m-zat",
"html_url": "https://github.com/m-zat",
"followers_url": "https://api.github.com/users/m-zat/followers",
"following_url": "https://api.github.com/users/m-zat/following{/other_user}",
"gists_url": "https://api.github.com/users/m-zat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/m-zat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/m-zat/subscriptions",
"organizations_url": "https://api.github.com/users/m-zat/orgs",
"repos_url": "https://api.github.com/users/m-zat/repos",
"events_url": "https://api.github.com/users/m-zat/events{/privacy}",
"received_events_url": "https://api.github.com/users/m-zat/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"You can use pip install --upgrade nemo_toolkit[all] to get the latest version now."
] | 2021-03-02T08:06:56 | 2021-06-19T04:38:59 | 2021-06-19T04:38:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I would like to experiment with the latest version of NeMo, v1.0.0b4, however due to some firewall issues at my workplace I can only install through PyPI and not from Github.
Do you have any plan to release that version on PyPI in the near future?
Thanks! | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1824/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1824/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1823 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1823/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1823/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1823/events | https://github.com/NVIDIA/NeMo/issues/1823 | 819,577,195 | MDU6SXNzdWU4MTk1NzcxOTU= | 1,823 | Tried to restore a nemo model after 3 months, but can't do it just like I used to. | {
"login": "BradAxl",
"id": 36090422,
"node_id": "MDQ6VXNlcjM2MDkwNDIy",
"avatar_url": "https://avatars.githubusercontent.com/u/36090422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BradAxl",
"html_url": "https://github.com/BradAxl",
"followers_url": "https://api.github.com/users/BradAxl/followers",
"following_url": "https://api.github.com/users/BradAxl/following{/other_user}",
"gists_url": "https://api.github.com/users/BradAxl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BradAxl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BradAxl/subscriptions",
"organizations_url": "https://api.github.com/users/BradAxl/orgs",
"repos_url": "https://api.github.com/users/BradAxl/repos",
"events_url": "https://api.github.com/users/BradAxl/events{/privacy}",
"received_events_url": "https://api.github.com/users/BradAxl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"can you try ``pip install nemo_toolkit['all']==1.0.0rc1`` ?",
"I just tried it and it works. Thank you very much, I was waiting literally like 2 months for this helpful answer. Can you please explain what's the difference between `pip install nemo_toolkit['all']==1.0.0rc1`, `!pip install nemo_toolkit[all]==1.0.0b3` and `!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[asr]` PLEASE ?"
] | 2021-03-02T03:46:23 | 2021-05-13T03:05:06 | 2021-05-13T03:05:06 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I trained **EncDecCTCModel** model with Mozilla Voice Project dataset like 3 months ago and save it by `.save_to` and I used to restore it by `nemo.collections.asr.models.EncDecCTCModel.restore_from(restore_path=_path_to_nemo_model_)`. I didn't have any problem at that moment and I stopped working on that project.
Today I tried to restore just like I did it before and got an error that says: `AttributeError: can't set attribute`. I followed the traceback and found a comment which says `# models are handled differently for now` that makes me thinks something has changed and probably I need to restore it in other way. If that's correct, how should I restore the model at the moment ? Do I need to retrain a new model because something has change about the training and the way which a model is stored ? I would appreciate any answer or some advice.
Brad,
Thanks in advance.
```
- Environment location: Google Colab
- Method of NeMo install: !python -m pip install git+https://github.com/NVIDIA/NeMo.git@$v1.0.0b2#egg=nemo_toolkit[asr]
```
| {
"login": "BradAxl",
"id": 36090422,
"node_id": "MDQ6VXNlcjM2MDkwNDIy",
"avatar_url": "https://avatars.githubusercontent.com/u/36090422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BradAxl",
"html_url": "https://github.com/BradAxl",
"followers_url": "https://api.github.com/users/BradAxl/followers",
"following_url": "https://api.github.com/users/BradAxl/following{/other_user}",
"gists_url": "https://api.github.com/users/BradAxl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BradAxl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BradAxl/subscriptions",
"organizations_url": "https://api.github.com/users/BradAxl/orgs",
"repos_url": "https://api.github.com/users/BradAxl/repos",
"events_url": "https://api.github.com/users/BradAxl/events{/privacy}",
"received_events_url": "https://api.github.com/users/BradAxl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1823/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1823/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1822 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1822/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1822/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1822/events | https://github.com/NVIDIA/NeMo/pull/1822 | 819,574,193 | MDExOlB1bGxSZXF1ZXN0NTgyNjY0OTc4 | 1,822 | Add SPE support for huge dataset corpus | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-02T03:39:07 | 2021-03-04T23:47:29 | 2021-03-03T18:20:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1822",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1822",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1822.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1822.patch",
"merged_at": "2021-03-03T18:20:00"
} | # Changelog
- Add flags to subsample text + use special SPE flags
- Update notebook docs | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1822/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1822/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1821 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1821/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1821/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1821/events | https://github.com/NVIDIA/NeMo/pull/1821 | 819,322,471 | MDExOlB1bGxSZXF1ZXN0NTgyNDQ4ODg4 | 1,821 | Add SPE tokenizer.vocab to registered archive | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-03-01T21:45:53 | 2021-03-02T00:09:26 | 2021-03-02T00:09:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1821",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1821",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1821.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1821.patch",
"merged_at": "2021-03-02T00:09:23"
} | Signed-off-by: smajumdar <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1821/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1821/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1820 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1820/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1820/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1820/events | https://github.com/NVIDIA/NeMo/pull/1820 | 819,107,565 | MDExOlB1bGxSZXF1ZXN0NTgyMjYxNTM0 | 1,820 | Fix enja decoding | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@mchrzanowski can you please send these changes to ``batch_translate`` branch?",
"Will do at some point soon. don’t let me block you for now and merge away;\nI’ll fix things in a subsequent pr later\n\nOn Mon, Mar 1, 2021 at 16:53 Oleksii Kuchaiev <[email protected]>\nwrote:\n\n> @mchrzanowski <https://github.com/mchrzanowski> can you please send these\n> changes to batch_translate branch?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/NVIDIA/NeMo/pull/1820#issuecomment-788461636>, or\n> unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AAKER5ZWEGVZUMZOCBII5W3TBQZJHANCNFSM4YM72J6A>\n> .\n>\n",
"i think this PR hopefully wont have to be merged. i think the path of least resistance for en<>ja will be to have the preprocessing pipeline produce integer ids as opposed to tokens. that way, there's no ambiguity between sequences of chars or tokens. detokenization will i think at that point just work with the default pathway and we wont have to special case en<>ja like this draft does."
] | 2021-03-01T17:53:12 | 2021-03-02T21:07:34 | 2021-03-02T21:07:34 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1820",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1820",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1820.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1820.patch",
"merged_at": "2021-03-02T21:07:34"
} | the current en<>ja preprocessing pipeline is being shifted to using integers for intermediate steps. this will avoid tokenization issues between yttm, sentencepiece, and sacremoses due to parsing incomptabilities. this PR changes the detokenization to deal with integer inputs and output tokens only at the end. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1820/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1820/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1819 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1819/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1819/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1819/events | https://github.com/NVIDIA/NeMo/issues/1819 | 817,914,911 | MDU6SXNzdWU4MTc5MTQ5MTE= | 1,819 | [Question] how to improve QuartzNet for production | {
"login": "YYUUUY",
"id": 27238658,
"node_id": "MDQ6VXNlcjI3MjM4NjU4",
"avatar_url": "https://avatars.githubusercontent.com/u/27238658?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/YYUUUY",
"html_url": "https://github.com/YYUUUY",
"followers_url": "https://api.github.com/users/YYUUUY/followers",
"following_url": "https://api.github.com/users/YYUUUY/following{/other_user}",
"gists_url": "https://api.github.com/users/YYUUUY/gists{/gist_id}",
"starred_url": "https://api.github.com/users/YYUUUY/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/YYUUUY/subscriptions",
"organizations_url": "https://api.github.com/users/YYUUUY/orgs",
"repos_url": "https://api.github.com/users/YYUUUY/repos",
"events_url": "https://api.github.com/users/YYUUUY/events{/privacy}",
"received_events_url": "https://api.github.com/users/YYUUUY/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Please look into Nvidia Jarvis - https://developer.nvidia.com/nvidia-jarvis"
] | 2021-02-27T12:48:20 | 2021-07-13T15:23:15 | 2021-07-13T15:23:15 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe your question**
seeking guidelines from the community for improving QuartzNet for production:
1. different accents, for example, US/UK/AU English
2. filler words, for example, um; ah
3. domain words, for example, company names, finance terms
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1819/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1819/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1818 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1818/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1818/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1818/events | https://github.com/NVIDIA/NeMo/pull/1818 | 817,788,328 | MDExOlB1bGxSZXF1ZXN0NTgxMjI1NDIw | 1,818 | Rc1 fix bert lm model 2 | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-27T01:39:25 | 2021-03-04T17:06:37 | 2021-02-27T02:02:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1818",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1818",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1818.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1818.patch",
"merged_at": "2021-02-27T02:02:58"
} | This corrects the fix. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1818/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1818/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1817 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1817/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1817/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1817/events | https://github.com/NVIDIA/NeMo/pull/1817 | 817,776,388 | MDExOlB1bGxSZXF1ZXN0NTgxMjE1NzI4 | 1,817 | check if attr exist | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-27T00:54:03 | 2021-02-27T00:55:50 | 2021-02-27T00:55:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1817",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1817",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1817.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1817.patch",
"merged_at": "2021-02-27T00:55:50"
} | Bert LM model doesn't necessarily have the tokenizer in the config. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1817/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1817/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1816 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1816/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1816/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1816/events | https://github.com/NVIDIA/NeMo/pull/1816 | 817,757,895 | MDExOlB1bGxSZXF1ZXN0NTgxMjAwMjUz | 1,816 | Remove CTC parts from RNNT transcribe | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-26T23:56:03 | 2021-02-27T01:35:20 | 2021-02-27T01:29:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1816",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1816",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1816.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1816.patch",
"merged_at": "2021-02-27T01:29:20"
} | Signed-off-by: smajumdar <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1816/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1816/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1815 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1815/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1815/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1815/events | https://github.com/NVIDIA/NeMo/pull/1815 | 817,719,759 | MDExOlB1bGxSZXF1ZXN0NTgxMTY4MTAx | 1,815 | Update EncDecClassificationDatasetConfig Dataclass | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 4 alerts** when merging f0e045e8eee83caf8d2db6464752d36f76871aa2 into 0f9a772feea56397479d06354ee4fcb9db8c6b04 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-23db6c861086ff7b5c8149283645de15e29f3d75)\n\n**new alerts:**\n\n* 4 for Unused import"
] | 2021-02-26T22:18:54 | 2021-02-26T23:16:34 | 2021-02-26T23:09:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1815",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1815",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1815.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1815.patch",
"merged_at": "2021-02-26T23:09:23"
} | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1815/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1815/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1814 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1814/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1814/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1814/events | https://github.com/NVIDIA/NeMo/pull/1814 | 817,644,827 | MDExOlB1bGxSZXF1ZXN0NTgxMTAyODQw | 1,814 | diarization tutorial | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-26T20:32:43 | 2021-02-26T21:10:33 | 2021-02-26T21:10:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1814",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1814",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1814.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1814.patch",
"merged_at": "2021-02-26T21:10:27"
} | Signed-off-by: nithinraok <[email protected]>
* Adds diarization tutoria
* Modify clustering diarizer to support pretrained speakernet and marblenet models | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1814/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1814/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1813 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1813/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1813/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1813/events | https://github.com/NVIDIA/NeMo/pull/1813 | 817,641,448 | MDExOlB1bGxSZXF1ZXN0NTgxMDk5OTky | 1,813 | Handle class balancing in a way to support TLT. | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **fixes 3 alerts** when merging 2817d5e5b74e67436fcec1ff3adef8f9b138c265 into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f1f11b89c657df4cd1e55fc67022c52b4bf50e66)\n\n**fixed alerts:**\n\n* 2 for Unused local variable\n* 1 for Unused import",
"This pull request **fixes 3 alerts** when merging fc7a45b0719139f60f0a62510c1f19b266940522 into 4d6cad6a4e59e9d10fcc82984c1ddb3a1f40067f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-64d97a7b249c433648647052ef331e51826914f1)\n\n**fixed alerts:**\n\n* 2 for Unused local variable\n* 1 for Unused import",
"> \r\n> \r\n> Please rebase to latest main - export() and attach_onnx_to_onnx should disappear.\r\n\r\nDropped them.",
"This pull request **fixes 2 alerts** when merging 2c32926718d5e73878a294594a449e316b6ed9bf into f4ffb4300d6ef1227e0a2cec9c692a38606be299 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a65e4ee17c4a44d729f0bcb33450c2768f21faec)\n\n**fixed alerts:**\n\n* 2 for Unused local variable",
"This pull request **fixes 2 alerts** when merging 270225370b979757b56fc83aed66a5ec611e5ba7 into 4b74402feeeb672f8982bb9fa51861f6c1d5f94b - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-4cb7bb67a2c3b70709410a3d4600a565f7756d97)\n\n**fixed alerts:**\n\n* 2 for Unused local variable",
"This pull request **introduces 4 alerts** and **fixes 3** when merging e960719173952bde00afb73f501fdf59ea89d049 into 89a8ea037a121001e105e95b49d71906a8de29aa - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-dff537058ff2f9f5e2402227e7a70b7901933ea1)\n\n**new alerts:**\n\n* 4 for Unused import\n\n**fixed alerts:**\n\n* 2 for Unused local variable\n* 1 for Unused import",
"This pull request **fixes 2 alerts** when merging e960719173952bde00afb73f501fdf59ea89d049 into e816905e286df545ce344e865ea6cf8e4b0c85ca - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-00578344bfd1f5b5828305d31be724d2517c5881)\n\n**fixed alerts:**\n\n* 2 for Unused local variable",
"This pull request **fixes 2 alerts** when merging d975797c7625d62d8a94c808c3107c7d58cec3e7 into 89a8ea037a121001e105e95b49d71906a8de29aa - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-75901b1980139ecbd71de6d9fa50d2aa4d594d5b)\n\n**fixed alerts:**\n\n* 2 for Unused local variable"
] | 2021-02-26T20:26:28 | 2021-05-03T21:57:41 | 2021-03-10T00:59:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1813",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1813",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1813.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1813.patch",
"merged_at": "2021-03-10T00:59:21"
} | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1813/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1813/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1812 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1812/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1812/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1812/events | https://github.com/NVIDIA/NeMo/pull/1812 | 817,580,658 | MDExOlB1bGxSZXF1ZXN0NTgxMDQ5NzI0 | 1,812 | Applying PR 1794 to r1.0.0rc1 | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-26T18:43:25 | 2021-03-04T17:06:47 | 2021-02-26T19:23:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1812",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1812",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1812.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1812.patch",
"merged_at": "2021-02-26T19:23:07"
} | PR https://github.com/NVIDIA/NeMo/pull/1794 is important for nemo saving but was applied to the main branch only; for most of us, the working branch is r1.0.0rc1. This PR applies the same change to this branch.
Signed-off-by: mchrzanowski [email protected]
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1812/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1812/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1811 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1811/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1811/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1811/events | https://github.com/NVIDIA/NeMo/issues/1811 | 817,530,539 | MDU6SXNzdWU4MTc1MzA1Mzk= | 1,811 | [Question] FileNotFoundError in Relation Extraction w/ BioMegatron | {
"login": "vdbedem",
"id": 14059561,
"node_id": "MDQ6VXNlcjE0MDU5NTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/14059561?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vdbedem",
"html_url": "https://github.com/vdbedem",
"followers_url": "https://api.github.com/users/vdbedem/followers",
"following_url": "https://api.github.com/users/vdbedem/following{/other_user}",
"gists_url": "https://api.github.com/users/vdbedem/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vdbedem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vdbedem/subscriptions",
"organizations_url": "https://api.github.com/users/vdbedem/orgs",
"repos_url": "https://api.github.com/users/vdbedem/repos",
"events_url": "https://api.github.com/users/vdbedem/events{/privacy}",
"received_events_url": "https://api.github.com/users/vdbedem/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Hi there is a branch change, I had the same issue. \r\n\r\nchangeing the variable at the start of the notebook from\r\nBRANCH = 'main'\r\nto\r\nBRANCH = 'r1.0.0rc1'"
] | 2021-02-26T17:21:38 | 2021-05-28T08:40:43 | 2021-05-28T08:40:43 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Executing the example notebook 'Relation_Extraction-BioMegatron.ipynb' leads to an error
> FileNotFoundError: Could not find tokenizer.vocab_file
after running cell `model = nemo_nlp.models.TextClassificationModel(cfg=config.model, trainer=trainer)`. This happens both when I run the notebook on colab or on my local setup.
How can I fix this error?
Thanks! | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1811/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1811/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1810 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1810/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1810/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1810/events | https://github.com/NVIDIA/NeMo/issues/1810 | 817,526,898 | MDU6SXNzdWU4MTc1MjY4OTg= | 1,810 | [Question] 'FileNotFoundError error' in Relation Extraction (RE) w/ biomegatron-bert-345m-uncased | {
"login": "vdbedem",
"id": 14059561,
"node_id": "MDQ6VXNlcjE0MDU5NTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/14059561?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vdbedem",
"html_url": "https://github.com/vdbedem",
"followers_url": "https://api.github.com/users/vdbedem/followers",
"following_url": "https://api.github.com/users/vdbedem/following{/other_user}",
"gists_url": "https://api.github.com/users/vdbedem/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vdbedem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vdbedem/subscriptions",
"organizations_url": "https://api.github.com/users/vdbedem/orgs",
"repos_url": "https://api.github.com/users/vdbedem/repos",
"events_url": "https://api.github.com/users/vdbedem/events{/privacy}",
"received_events_url": "https://api.github.com/users/vdbedem/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This was fixed here: https://github.com/NVIDIA/NeMo/pull/1808"
] | 2021-02-26T17:16:10 | 2021-02-26T17:27:06 | 2021-02-26T17:24:24 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | {
"login": "vdbedem",
"id": 14059561,
"node_id": "MDQ6VXNlcjE0MDU5NTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/14059561?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vdbedem",
"html_url": "https://github.com/vdbedem",
"followers_url": "https://api.github.com/users/vdbedem/followers",
"following_url": "https://api.github.com/users/vdbedem/following{/other_user}",
"gists_url": "https://api.github.com/users/vdbedem/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vdbedem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vdbedem/subscriptions",
"organizations_url": "https://api.github.com/users/vdbedem/orgs",
"repos_url": "https://api.github.com/users/vdbedem/repos",
"events_url": "https://api.github.com/users/vdbedem/events{/privacy}",
"received_events_url": "https://api.github.com/users/vdbedem/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1810/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1810/timeline | null | completed | false |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1809 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1809/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1809/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1809/events | https://github.com/NVIDIA/NeMo/pull/1809 | 817,516,405 | MDExOlB1bGxSZXF1ZXN0NTgwOTk2NTYw | 1,809 | set max seq length for inference | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-26T17:00:52 | 2021-02-26T18:47:05 | 2021-02-26T18:47:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1809",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1809",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1809.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1809.patch",
"merged_at": "2021-02-26T18:47:00"
} | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1809/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1809/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1808 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1808/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1808/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1808/events | https://github.com/NVIDIA/NeMo/pull/1808 | 817,094,964 | MDExOlB1bGxSZXF1ZXN0NTgwNjQ1NTI2 | 1,808 | Registering vocab automatically was pointing to the .nemo vocab instead of the actual location | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-26T06:53:23 | 2021-02-26T14:22:11 | 2021-02-26T14:22:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1808",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1808",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1808.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1808.patch",
"merged_at": "2021-02-26T14:22:07"
} | One line fix. | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1808/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1808/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1807 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1807/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1807/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1807/events | https://github.com/NVIDIA/NeMo/pull/1807 | 817,046,781 | MDExOlB1bGxSZXF1ZXN0NTgwNjA1NDIz | 1,807 | Add basic grpc MT server | {
"login": "ryanleary",
"id": 2212584,
"node_id": "MDQ6VXNlcjIyMTI1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/2212584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ryanleary",
"html_url": "https://github.com/ryanleary",
"followers_url": "https://api.github.com/users/ryanleary/followers",
"following_url": "https://api.github.com/users/ryanleary/following{/other_user}",
"gists_url": "https://api.github.com/users/ryanleary/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ryanleary/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ryanleary/subscriptions",
"organizations_url": "https://api.github.com/users/ryanleary/orgs",
"repos_url": "https://api.github.com/users/ryanleary/repos",
"events_url": "https://api.github.com/users/ryanleary/events{/privacy}",
"received_events_url": "https://api.github.com/users/ryanleary/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 5 alerts** when merging 619df560e621887e9e39036327916f33ed1f2884 into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5d117bfdd38ba6fec4b6fc1cdf243cb5d2c7c0fd)\n\n**new alerts:**\n\n* 5 for Unused import",
"This pull request **introduces 5 alerts** when merging f044219620649fd7ab955162679af4ae186c6f9e into 4d6cad6a4e59e9d10fcc82984c1ddb3a1f40067f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b8718369403138f57b007315c303021993359be2)\n\n**new alerts:**\n\n* 5 for Unused import",
"This pull request **introduces 5 alerts** when merging 79d9ee7515229a969ccc82e4332279254bd66454 into 91774a74a38335d6b0090174861fecde54c764ff - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-4f2048c187405a163f5a4ec692ab2d47163efd3f)\n\n**new alerts:**\n\n* 5 for Unused import",
"This pull request **introduces 5 alerts** when merging 645d84e8c12c338ff5f0d93957f2f65229aeccd8 into 7ecf04ffd7ee05ad557a7d1aab5b7c6218e256ba - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-69c60a8069fcba6422b44ca370300ddddee693b2)\n\n**new alerts:**\n\n* 5 for Unused import",
"This pull request **introduces 5 alerts** when merging 40640081543c22b2980b0e5a762da467f53b834f into 52c20a17d6b2ccc761f284663ab629b4b5502747 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5dc138d588dac762b8c829858a0efd736924c94d)\n\n**new alerts:**\n\n* 5 for Unused import",
"This pull request **introduces 6 alerts** when merging 6b474ed61ba0d7d05669e88dc788d9e938407741 into 241855cc2a41af737b01565ab472f0ef84f74584 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-99a06654b2a178850e483b666af1d8ea0b8bc9e0)\n\n**new alerts:**\n\n* 4 for Unused import\n* 2 for Modification of parameter with default",
"This pull request **introduces 2 alerts** when merging 323d938a4aa9f38665ef8ccd9eb9cc1c0b791c79 into 241855cc2a41af737b01565ab472f0ef84f74584 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a38f6e01cdee5910e2aa9d628ba0bd3b9cbf2ad3)\n\n**new alerts:**\n\n* 2 for Modification of parameter with default",
"This pull request **introduces 2 alerts** when merging af51a3d11b8468ad185563d81e8d7f64b2327c87 into 241855cc2a41af737b01565ab472f0ef84f74584 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b5f66ad9ba7a3b5f9b7d99baed89d06af35d77a2)\n\n**new alerts:**\n\n* 2 for Modification of parameter with default",
"This pull request **introduces 2 alerts** when merging e3f7898d85fa1a78fd07989d15c74a3d015050ce into 7e6197d33da24465fe89a3e2bd9d2a35395643d2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-30324401431086c680e63b3a6391e0e3d52c96d3)\n\n**new alerts:**\n\n* 2 for Modification of parameter with default"
] | 2021-02-26T05:14:43 | 2021-08-09T22:31:41 | 2021-08-09T22:31:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1807",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1807",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1807.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1807.patch",
"merged_at": "2021-08-09T22:31:41"
} | Add readme, server updates
Signed-off-by: Ryan Leary <[email protected]> | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1807/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1807/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1806 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1806/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1806/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1806/events | https://github.com/NVIDIA/NeMo/pull/1806 | 816,963,550 | MDExOlB1bGxSZXF1ZXN0NTgwNTM1Mzk4 | 1,806 | Concatenation of tarred datasets for NMT | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Can you add example usage to the README?"
] | 2021-02-26T02:16:16 | 2021-05-17T17:14:23 | 2021-05-17T17:14:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1806",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1806",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1806.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1806.patch",
"merged_at": null
} | This PR lets you combine multiple TarredTranslationDatasets and sample minibatches from them with different ratios. Right now our config setup allows specifying only two tarred datasets at a time, but the `ConcatTarredTranslationDataset` should support an arbitrary number of datasets. | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1806/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1806/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1805 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1805/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1805/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1805/events | https://github.com/NVIDIA/NeMo/pull/1805 | 816,920,844 | MDExOlB1bGxSZXF1ZXN0NTgwNTAxNjA1 | 1,805 | [WIP] Refactoring translation routines | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "RPrenger",
"id": 8484670,
"node_id": "MDQ6VXNlcjg0ODQ2NzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/8484670?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RPrenger",
"html_url": "https://github.com/RPrenger",
"followers_url": "https://api.github.com/users/RPrenger/followers",
"following_url": "https://api.github.com/users/RPrenger/following{/other_user}",
"gists_url": "https://api.github.com/users/RPrenger/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RPrenger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RPrenger/subscriptions",
"organizations_url": "https://api.github.com/users/RPrenger/orgs",
"repos_url": "https://api.github.com/users/RPrenger/repos",
"events_url": "https://api.github.com/users/RPrenger/events{/privacy}",
"received_events_url": "https://api.github.com/users/RPrenger/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This pull request **introduces 1 alert** when merging 363f32e68832590ee89335af22f4a878a29b598d into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-979f06969d7ee8670113e8c823984cfdd8315809)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 8886b806f38c1fa1d3ecccb41f83d0106a3dffcc into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-4793ce9452b56c71730cafd6c9d3064bf02cd5c6)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 71b99105d635686ef8a3d2d3650308518de1212e into 4d6cad6a4e59e9d10fcc82984c1ddb3a1f40067f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3c21db23a3add8743d7dc315fea42502f6e33cb2)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging 9bb8a42e1031673add45830cc49c195954c29078 into f4ffb4300d6ef1227e0a2cec9c692a38606be299 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-96e68b4597c7b3938ef8f60957bb746ed7745c02)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging 82503548d2fff72044e4d5d2c5c6bd9b6a943974 into f4ffb4300d6ef1227e0a2cec9c692a38606be299 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5c342ec512de2a5cf460061466b77dff394519c3)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging f58fe8e6dddee6438fe6796073015e889551f759 into 7d4ad85dc38d41eae4369f2d1b6ec8f3de5cf1b7 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-90f900630c6b454b2d25a26e0035dfa03a0e0ac8)\n\n**new alerts:**\n\n* 1 for Unused import"
] | 2021-02-26T00:34:58 | 2021-03-03T22:16:48 | 2021-03-03T22:16:41 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1805",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1805",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1805.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1805.patch",
"merged_at": "2021-03-03T22:16:41"
} | This PR does the following:
* Makes sure that all pipeline pieces are create inside the constructor: src_normalizer, src_pre_tokenizer, encoder/decoder_tokenizers, tgt_post_tokenizer. This is necessary for their artifacts to be handled correctly and be included in .nemo file
* Refactors "batch_translate", "translate" and "eval_step" so that:
- eval_step relies on batch_translate
- translate and batch_translate call pipeline pieces, hopefully, in a correct order
TODOs:
translate method should really just prepare input batch and call batch_translate so that core pipeline logic is implemented in a single place (batch_translate)
@ericharper I suspect if we the conversion of raw text training data to tarred files might be missing corrsponding src_normalizer and src_pre_tokenizer calls. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1805/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1805/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1804 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1804/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1804/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1804/events | https://github.com/NVIDIA/NeMo/pull/1804 | 816,891,023 | MDExOlB1bGxSZXF1ZXN0NTgwNDc3MjUz | 1,804 | Hotfix for en/ ja preprocessing | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-25T23:26:05 | 2021-03-04T17:06:59 | 2021-02-26T00:08:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1804",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1804",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1804.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1804.patch",
"merged_at": "2021-02-26T00:08:49"
} | 1) hotfix for https://github.com/NVIDIA/NeMo/pull/1801. one call to `get_detokenizer` wasn't updated.
2) @MaximumEntropy noticed that the previous logic would apply the en/ja preprocessing in the case that the user did src == tgt (for whatever reason they wanted to do this). The current logic fixes this. | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1804/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1804/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1803 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1803/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1803/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1803/events | https://github.com/NVIDIA/NeMo/pull/1803 | 816,879,817 | MDExOlB1bGxSZXF1ZXN0NTgwNDY3NzY4 | 1,803 | Fix megatron vocab file | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-25T23:05:25 | 2021-02-25T23:46:59 | 2021-02-25T23:46:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1803",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1803",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1803.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1803.patch",
"merged_at": "2021-02-25T23:46:56"
} | Megatron-LM is not using the vocab file specified by the user. This PR fixes that. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1803/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1803/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1802 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1802/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1802/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1802/events | https://github.com/NVIDIA/NeMo/pull/1802 | 816,854,288 | MDExOlB1bGxSZXF1ZXN0NTgwNDQ2MzQ3 | 1,802 | Speaker Diarization tutorial | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 1 alert** when merging fc4e65d2e9ab237e6a8f967ee78ec699b6f2ff41 into 4efb9055494a623b2dd4b0366fb51022633662da - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-cb69f4b17826be237efbbf1894cf25f80a6f8e89)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging b01ffab694408453586234f56e0a5dffc5feb5b1 into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-19343706cb7a1972e452539930d35fa8e76a4b7a)\n\n**new alerts:**\n\n* 1 for Unused import",
"> 1. Should we merge it to RC instead of main?\r\nI think main should be fine since this PR is not for any bug fix. @titu1994 what do you think? \r\n\r\n"
] | 2021-02-25T22:18:08 | 2021-02-26T20:31:22 | 2021-02-26T20:31:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1802",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1802",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1802.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1802.patch",
"merged_at": null
} | Signed-off-by: nithinraok <[email protected]>
* Add speaker diarization tutorial | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1802/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1802/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1801 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1801/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1801/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1801/events | https://github.com/NVIDIA/NeMo/pull/1801 | 816,699,038 | MDExOlB1bGxSZXF1ZXN0NTgwMzE1NDg2 | 1,801 | share the same pre and post processing pipelines for Ja & En | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 2 alerts** when merging 2a7441a7ca2cd2d9914cd41b68fbec872047e9ff into b467d6f20a13965e65522b3fbaf833b7cbf9f3ac - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3cdfd9c5b9dcc8e2bbebd0e0aa3b259abcb75ea0)\n\n**new alerts:**\n\n* 2 for Variable defined multiple times"
] | 2021-02-25T18:46:21 | 2021-02-25T22:15:36 | 2021-02-25T22:15:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1801",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1801",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1801.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1801.patch",
"merged_at": "2021-02-25T22:15:36"
} | The current japanese and english pre and post processing pipelines are shared. However, that wasnt reflected in the nemo code. This PR rectifies this discrepancy and makes sure english is processed the same way as japanese text is whenever the source or target language is the latter. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1801/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1801/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1800 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1800/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1800/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1800/events | https://github.com/NVIDIA/NeMo/issues/1800 | 816,467,154 | MDU6SXNzdWU4MTY0NjcxNTQ= | 1,800 | The decoded sentence is empty in the Japanese data set | {
"login": "SenriYoshikawa",
"id": 5346613,
"node_id": "MDQ6VXNlcjUzNDY2MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/5346613?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SenriYoshikawa",
"html_url": "https://github.com/SenriYoshikawa",
"followers_url": "https://api.github.com/users/SenriYoshikawa/followers",
"following_url": "https://api.github.com/users/SenriYoshikawa/following{/other_user}",
"gists_url": "https://api.github.com/users/SenriYoshikawa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SenriYoshikawa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SenriYoshikawa/subscriptions",
"organizations_url": "https://api.github.com/users/SenriYoshikawa/orgs",
"repos_url": "https://api.github.com/users/SenriYoshikawa/repos",
"events_url": "https://api.github.com/users/SenriYoshikawa/events{/privacy}",
"received_events_url": "https://api.github.com/users/SenriYoshikawa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"The training loss is near 150~ after two epochs. You need to train longer so that loss drops to around 50-80 or lower before tokens actually appear. \r\n\r\nThe first phase of CTC learning is to learn to predict all blank tokens. ",
"Thank you very much!\r\nI am going to train more longer.",
"I got a better result after 1200 epoch.\r\nThank you very much!\r\n```\r\n[NeMo I 2021-02-28 03:43:45 wer:160] reference:簡易ベッドの組み立て方を教えてもらえますか\r\n[NeMo I 2021-02-28 03:43:45 wer:161] decoded :ーイベットのみたて方をを教えてもらいますか\r\n[NeMo I 2021-02-28 03:43:46 wer:159] \r\n[NeMo I 2021-02-28 03:43:46 wer:160] reference:また近いうちにお目にかかりましょう\r\n[NeMo I 2021-02-28 03:43:46 wer:161] decoded :まただいうちにおめにかかりましょう\r\n[NeMo I 2021-02-28 03:43:46 wer:159] \r\n[NeMo I 2021-02-28 03:43:46 wer:160] reference:夫からもくれぐれもよろしくとのことです\r\n[NeMo I 2021-02-28 03:43:46 wer:161] decoded :夫からもれぐれもよろしくとのことです\r\n[NeMo I 2021-02-28 03:44:00 wer:159] \r\n[NeMo I 2021-02-28 03:44:00 wer:160] reference:車や飛行機ではいつも安全ベルトを締めることが法律で決められています\r\n[NeMo I 2021-02-28 03:44:00 wer:161] decoded :車や飛行機ではいつも安全ベルトを締めることが法律で決められています\r\n[NeMo I 2021-02-28 03:44:14 wer:159] \r\n[NeMo I 2021-02-28 03:44:14 wer:160] reference:現在の滑走を目的としたスキーブーツは硬いプラスチックシェルと柔らかいインナーブーツからなる\r\n[NeMo I 2021-02-28 03:44:14 wer:161] decoded :現在の滑走を目的としたスキーブーツは硬いプラスチックシェルと柔らかいインナブーツからなる\r\n[NeMo I 2021-02-28 03:44:28 wer:159] \r\n```"
] | 2021-02-25T14:04:21 | 2021-03-01T12:02:06 | 2021-03-01T12:02:05 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I have used the JSUT (Japanese speech corpus of Saruwatari-lab., University of Tokyo) data set to train the ASR model.
I set `normalize_transcript` parameter of train_ds and validation_ds to False.
```
params['model']['train_ds']['manifest_filepath'] = train_manifest
params['model']['train_ds']['normalize_transcripts'] = False
params['model']['train_ds']['labels'] = labels
params['model']['validation_ds']['manifest_filepath'] = test_manifest
params['model']['validation_ds']['normalize_transcripts'] = False
params['model']['validation_ds']['labels'] = labels
params['model']['preprocessor']['params']['stft_conv'] = True
params['model']['decoder']['params']['num_classes'] = len(labels)
params['model']['decoder']['params']['vocabulary'] = labels
params['labels'] = labels
```
However, the "decoded" of the result of the `trainer.fit()` is empty after the second epoch.
```
[NeMo I 2021-02-25 12:33:22 modelPT:597] Optimizer config = Novograd (
Parameter Group 0
amsgrad: False
betas: [0.8, 0.5]
eps: 1e-08
grad_averaging: False
lr: 0.01
weight_decay: 0.001
)
[NeMo I 2021-02-25 12:33:22 lr_scheduler:562] Scheduler "<nemo.core.optim.lr_scheduler.CosineAnnealing object at 0x7f35252f6750>"
will be used during training (effective maximum steps = 1398) -
Parameters :
(warmup_steps: null
warmup_ratio: null
min_lr: 0.0
last_epoch: -1
max_steps: 1398
)
| Name | Type | Params
------------------------------------------------------------------------
0 | preprocessor | AudioToMelSpectrogramPreprocessor | 0
1 | encoder | ConvASREncoder | 1.2 M
2 | decoder | ConvASRDecoder | 2.8 M
3 | loss | CTCLoss | 0
4 | spec_augmentation | SpectrogramAugmentation | 0
5 | _wer | WER | 0
[NeMo I 2021-02-25 12:33:24 wer:159]
[NeMo I 2021-02-25 12:33:24 wer:160] reference:演奏会の切符は当事務所で販売しています
[NeMo I 2021-02-25 12:33:24 wer:161] decoded :平溝平溝平溝捕溝平溝平溝平情溝捕溝捕平捕平捕平溝平捕溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平溝捕溝捕平溝平溝平溝捕溝平溝平溝平溝平溝捕溝捕溝平
[NeMo I 2021-02-25 12:33:24 wer:159]
[NeMo I 2021-02-25 12:33:24 wer:160] reference:鳥だったらすぐそこに飛んでいくのに
[NeMo I 2021-02-25 12:33:24 wer:161] decoded :平溝捕溝捕溝平溝平情溝平溝平溝平捕平溝情溝平溝平溝平溝平溝平溝平溝平溝捕平溝捕溝平溝平溝平溝平溝平溝平溝平情溝平溝平溝平溝平捕溝平溝平情溝捕溝捕平溝平溝平情溝平溝平捕溝捕溝捕溝捕溝捕溝平溝平溝平溝平溝捕平溝平捕溝捕溝平溝捕溝捕溝平溝平溝平溝平溝平溝平溝平溝平溝平溝平捕溝捕溝平
Epoch 2: 100%
474/474 [02:35<00:00, 3.06it/s, loss=80.696, v_num=1]
[NeMo I 2021-02-25 12:33:41 wer:159]
[NeMo I 2021-02-25 12:33:41 wer:160] reference:
[NeMo I 2021-02-25 12:33:41 wer:161] decoded :
[NeMo I 2021-02-25 12:33:57 wer:159]
[NeMo I 2021-02-25 12:33:57 wer:160] reference:孫策の死後はやや無気力感を漂わせたが頭の中では自身の周りで起きた運命や世の中の流れについて終わる事のない自問を繰り返していた
[NeMo I 2021-02-25 12:33:57 wer:161] decoded :
[NeMo I 2021-02-25 12:34:14 wer:159]
[NeMo I 2021-02-25 12:34:14 wer:160] reference:学識の点で彼は彼の友人のだれよりも上です
[NeMo I 2021-02-25 12:34:14 wer:161] decoded :
[NeMo I 2021-02-25 12:34:30 wer:159]
```
Any help would be appreciated.
**Environment overview (please complete the following information)**
- Environment location: Collab (https://colab.research.google.com/drive/1kPb1p-3IRfjCu1Hu_kTRHwSOsWmSvA7V?usp=sharing)
- Method of NeMo install: pip install from github
- NeMo version: r1.0.0b3
| {
"login": "SenriYoshikawa",
"id": 5346613,
"node_id": "MDQ6VXNlcjUzNDY2MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/5346613?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SenriYoshikawa",
"html_url": "https://github.com/SenriYoshikawa",
"followers_url": "https://api.github.com/users/SenriYoshikawa/followers",
"following_url": "https://api.github.com/users/SenriYoshikawa/following{/other_user}",
"gists_url": "https://api.github.com/users/SenriYoshikawa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SenriYoshikawa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SenriYoshikawa/subscriptions",
"organizations_url": "https://api.github.com/users/SenriYoshikawa/orgs",
"repos_url": "https://api.github.com/users/SenriYoshikawa/repos",
"events_url": "https://api.github.com/users/SenriYoshikawa/events{/privacy}",
"received_events_url": "https://api.github.com/users/SenriYoshikawa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1800/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1800/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/1799 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1799/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1799/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1799/events | https://github.com/NVIDIA/NeMo/pull/1799 | 816,463,494 | MDExOlB1bGxSZXF1ZXN0NTgwMTIwMzYw | 1,799 | Port DLE FastPitch | {
"login": "alancucki",
"id": 16889482,
"node_id": "MDQ6VXNlcjE2ODg5NDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16889482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/alancucki",
"html_url": "https://github.com/alancucki",
"followers_url": "https://api.github.com/users/alancucki/followers",
"following_url": "https://api.github.com/users/alancucki/following{/other_user}",
"gists_url": "https://api.github.com/users/alancucki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/alancucki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alancucki/subscriptions",
"organizations_url": "https://api.github.com/users/alancucki/orgs",
"repos_url": "https://api.github.com/users/alancucki/repos",
"events_url": "https://api.github.com/users/alancucki/events{/privacy}",
"received_events_url": "https://api.github.com/users/alancucki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 4 alerts** when merging e137574cbe6348159a8b4366afc9a13fe013a805 into db5a787f460d67f0cd89b400cf81826fa2cc9ed6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-d995225ae3f70723701e1bbfd5fc23850e9055a6)\n\n**new alerts:**\n\n* 2 for Unused import\n* 1 for Mismatch in multiple assignment\n* 1 for Comparison of constants",
"This pull request **introduces 4 alerts** when merging 9788daf44fc7ebee1bd216ae4178ba8856f2b088 into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-74022e590a7d5291a428b2ba1204b35a7b92840b)\n\n**new alerts:**\n\n* 2 for Unused import\n* 1 for Mismatch in multiple assignment\n* 1 for Comparison of constants",
"This pull request **introduces 4 alerts** when merging 36ecb1918b2afeec84f5daa4e27ab54bd65048e8 into efaab9e67346d633e3efd49c44a5c2b83661d1fc - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-9ae6fcf87a522bcd80a19e1b46437ecd02db8a2d)\n\n**new alerts:**\n\n* 2 for Unused import\n* 1 for Mismatch in multiple assignment\n* 1 for Comparison of constants",
"This pull request **introduces 4 alerts** when merging f99838327079814d6d178436697eb88c6ceaf37d into ac79c2c6a5f50186bdcaceb9e72a8391271ce120 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-7ee480fada9f0d7ebd56261140205d5fa05877cd)\n\n**new alerts:**\n\n* 2 for Unused import\n* 1 for Mismatch in multiple assignment\n* 1 for Comparison of constants",
"This pull request **introduces 4 alerts** when merging 27b51de0c580c2c56a09204b5d57f31ea51f0580 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-ee003775be88098d3241e00c091277b56a908b46)\n\n**new alerts:**\n\n* 2 for Unused import\n* 1 for Mismatch in multiple assignment\n* 1 for Comparison of constants",
"This pull request **introduces 2 alerts** when merging 7b2bd34c671e7e91df031f2f3d2a31e1c9453e07 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-418ba9d751ea9806fb6596aeb78ed06ec920e730)\n\n**new alerts:**\n\n* 1 for Mismatch in multiple assignment\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging c603190bbb7be0f1b93552dcf5d0074cc55919ed into ff84f14611b64ee27f16757662ebdc9e2400cd1c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1ce6fcb3fb65a68bbae9845ed15db3c08cc619f6)\n\n**new alerts:**\n\n* 1 for Mismatch in multiple assignment",
"This pull request **introduces 1 alert** when merging 6ee0998abe186cc5cf05ef2972bbe5baca025455 into ff84f14611b64ee27f16757662ebdc9e2400cd1c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-51eb8500cdb7e8126a3307c6e63f861285a6fdfa)\n\n**new alerts:**\n\n* 1 for Mismatch in multiple assignment",
"Hi, I am training FastPitch on a private dataset(text-speech). \r\nI did everything as mentioned, \r\n1) calculate pitch, durations with [this script](https://github.com/NVIDIA/DeepLearningExamples/blob/master/PyTorch/SpeechSynthesis/FastPitch/scripts/prepare_dataset.sh)\r\n2) train using nemo example training file.\r\n\r\nDuring training, it throws this error\r\n\r\n\r\n`Epoch 0: 0%| | 0/380 [00:00<?, ?it/s][W reducer.cpp:1050] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters, consider turning this flag off. Note that this warning may be a false positive your model has flow control causing later iterations to have unused parameters. (function operator())\r\nEpoch 0: 2%|██▊ | 8/380 [00:08<06:56, 1.12s/it, loss=37, v_num=1-50]Epoch 0: 2%|██▊ | 8/380 [00:08<06:56, 1.12s/it, loss=36.2, v_num=1-50]Error executing job with overrides: []\r\nTraceback (most recent call last):\r\n File \"train_fastPitch.py\", line 31, in main\r\n trainer.fit(model)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 460, in fit\r\n self._run(model)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 758, in _run\r\n self.dispatch()\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 799, in dispatch\r\n self.accelerator.start_training(self)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py\", line 96, in start_training\r\n self.training_type_plugin.start_training(trainer)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py\", line 144, in start_training\r\n self._results = trainer.run_stage()\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 809, in run_stage\r\n return self.run_train()\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 871, in run_train\r\n self.train_loop.run_training_epoch()\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py\", line 491, in run_training_epoch\r\n for batch_idx, (batch, is_last_batch) in train_dataloader:\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/profiler/profilers.py\", line 112, in profile_iterable\r\n value = next(iterator)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py\", line 534, in prefetch_iterator\r\n for val in it:\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py\", line 464, in __next__\r\n return self.request_next_batch(self.loader_iters)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py\", line 478, in request_next_batch\r\n return apply_to_collection(loader_iters, Iterator, next)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/utilities/apply_func.py\", line 85, in apply_to_collection\r\n return function(data, *args, **kwargs)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/dataloader.py\", line 517, in __next__\r\n data = self._next_data()\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/dataloader.py\", line 1179, in _next_data\r\n return self._process_data(data)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/dataloader.py\", line 1225, in _process_data\r\n data.reraise()\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/_utils.py\", line 429, in reraise\r\n raise self.exc_type(msg)\r\nAssertionError: Caught AssertionError in DataLoader worker process 9.\r\nOriginal Traceback (most recent call last):\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py\", line 202, in _worker_loop\r\n data = fetcher.fetch(index)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py\", line 47, in fetch\r\n return self.collate_fn(data)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/nemo/core/classes/common.py\", line 792, in __call__\r\n outputs = wrapped(*args, **kwargs)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/nemo/core/classes/dataset.py\", line 59, in collate_fn\r\n return self._collate_fn(batch)\r\n File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_text.py\", line 696, in _collate_fn\r\n assert len(durs_i) == tokens_i_len, f\"{len(durs_i)}, {tokens_i_len}: {path_i}\"\r\nAssertionError: 54, 56: /root/shangeth/Dataset/20hrs_22khtz/wavs/b-4_2000-5164_4562.wav`",
"> Hi, I am training FastPitch on a private dataset(text-speech).\r\n> I did everything as mentioned,\r\n> \r\n> 1. calculate pitch, durations with [this script](https://github.com/NVIDIA/DeepLearningExamples/blob/master/PyTorch/SpeechSynthesis/FastPitch/scripts/prepare_dataset.sh)\r\n> 2. train using nemo example training file.\r\n> \r\n> During training, it throws this error\r\n> \r\n> `Epoch 0: 0%| | 0/380 [00:00<?, ?it/s][W reducer.cpp:1050] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters, consider turning this flag off. Note that this warning may be a false positive your model has flow control causing later iterations to have unused parameters. (function operator()) Epoch 0: 2%|██▊ | 8/380 [00:08<06:56, 1.12s/it, loss=37, v_num=1-50]Epoch 0: 2%|██▊ | 8/380 [00:08<06:56, 1.12s/it, loss=36.2, v_num=1-50]Error executing job with overrides: [] Traceback (most recent call last): File \"train_fastPitch.py\", line 31, in main trainer.fit(model) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 460, in fit self._run(model) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 758, in _run self.dispatch() File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 799, in dispatch self.accelerator.start_training(self) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py\", line 96, in start_training self.training_type_plugin.start_training(trainer) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py\", line 144, in start_training self._results = trainer.run_stage() File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 809, in run_stage return self.run_train() File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py\", line 871, in run_train self.train_loop.run_training_epoch() File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py\", line 491, in run_training_epoch for batch_idx, (batch, is_last_batch) in train_dataloader: File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/profiler/profilers.py\", line 112, in profile_iterable value = next(iterator) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py\", line 534, in prefetch_iterator for val in it: File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py\", line 464, in __next__ return self.request_next_batch(self.loader_iters) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py\", line 478, in request_next_batch return apply_to_collection(loader_iters, Iterator, next) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/pytorch_lightning/utilities/apply_func.py\", line 85, in apply_to_collection return function(data, *args, **kwargs) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/dataloader.py\", line 517, in __next__ data = self._next_data() File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/dataloader.py\", line 1179, in _next_data return self._process_data(data) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/dataloader.py\", line 1225, in _process_data data.reraise() File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/_utils.py\", line 429, in reraise raise self.exc_type(msg) AssertionError: Caught AssertionError in DataLoader worker process 9. Original Traceback (most recent call last): File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py\", line 202, in _worker_loop data = fetcher.fetch(index) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py\", line 47, in fetch return self.collate_fn(data) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/nemo/core/classes/common.py\", line 792, in __call__ outputs = wrapped(*args, **kwargs) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/nemo/core/classes/dataset.py\", line 59, in collate_fn return self._collate_fn(batch) File \"/root/anaconda3/envs/nemoenv/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_text.py\", line 696, in _collate_fn assert len(durs_i) == tokens_i_len, f\"{len(durs_i)}, {tokens_i_len}: {path_i}\" AssertionError: 54, 56: /root/shangeth/Dataset/20hrs_22khtz/wavs/b-4_2000-5164_4562.wav`\r\n\r\nPlease fill an issue."
] | 2021-02-25T14:00:10 | 2021-08-17T14:36:48 | 2021-03-23T14:36:31 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1799",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1799",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1799.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1799.patch",
"merged_at": "2021-03-23T14:36:31"
} | This PR ports the [DLE FastPitch](https://github.com/NVIDIA/DeepLearningExamples/tree/master/PyTorch/SpeechSynthesis/FastPitch) model ([arxiv](https://arxiv.org/abs/2006.06873)). There is an example of training in `examples/tts/fastpitch.py`, and inference with a `.nemo` model has been tested.
Issuess for full integration:
1. **Data preparation**
Currently it assumes a dataset structure:
```bash
LJSpeech-1.1
├── durations
├── pitch
└── wavs
```
where `pitch` and `durations` can be pre-calculated with a [script](https://github.com/NVIDIA/DeepLearningExamples/blob/master/PyTorch/SpeechSynthesis/FastPitch/scripts/prepare_dataset.sh) from DLE.
.json dataset entries should have the following structure:
```bash
{"audio_filepath": <path>, "text": <transcript>, "duration": <duration_in_seconds>, "speaker": <speaker_index_0_based>}
```
Speakers are optional, single-speaker dataset should always have `"spaker": 0`.
2. **Mean and std of F0**
in the DLE model, mean and std of F0 are being stored inside the model for pitch manipulation during inference. In order to specify pitch transformations in Hz, one needs a way to recompute pitch in standarized values. In this PR, these are empty [placeholders](https://github.com/alancucki/NeMo/blob/fastpitch/nemo/collections/tts/modules/fastpitch.py#L143) that can be used or deleted.
3. **Best checkpoints shouldn't be determined with val loss**
The training loop saves the best checkpoint based on validation loss; it tends to increase during training and is a poor proxy for quality; the last checkpoint should be the final one. | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1799/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1799/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1798 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1798/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1798/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1798/events | https://github.com/NVIDIA/NeMo/pull/1798 | 816,082,568 | MDExOlB1bGxSZXF1ZXN0NTc5ODA0MjQ1 | 1,798 | checkpoint name fix | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-25T04:54:24 | 2021-02-25T17:28:55 | 2021-02-25T05:55:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1798",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1798",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1798.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1798.patch",
"merged_at": "2021-02-25T05:55:44"
} | Signed-off-by: nithinraok <[email protected]>
* checkpoint `last` name fix | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1798/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1798/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1797 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1797/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1797/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1797/events | https://github.com/NVIDIA/NeMo/pull/1797 | 815,959,370 | MDExOlB1bGxSZXF1ZXN0NTc5NzAxNTA2 | 1,797 | Text denormalization | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 55 alerts** when merging 0760edf72a1c9210a4b84081f52a4ebb69f91408 into db5a787f460d67f0cd89b400cf81826fa2cc9ed6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b2818a87c73567cb6706894ac48ef65064c145a5)\n\n**new alerts:**\n\n* 49 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 1 alert** when merging e807860c5f1d14e675255e3d89d917f74de96e09 into db5a787f460d67f0cd89b400cf81826fa2cc9ed6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-eac33ae64d795dbdc1df8d0314b67c00540d5314)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging f2a75637a38e6c96a3513da287e07a3f67807ffd into 308c7d2115d30dfccf734d467cb61ef6c5c30813 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f567ce1c601ede9781a995ba4c8e42da94af5c77)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 1 alert** when merging d49bb6d8d311f8e3c3d32e085fca03f6dbea8c12 into 27e5f2dce512495d93577c39618409d3403b210a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-71587ee9efa31974453d149270427d4eca6dc73a)\n\n**new alerts:**\n\n* 1 for Unused local variable",
"This pull request **introduces 25 alerts** when merging ef510f5f526639b92a83f0b6c752d2b73f2e6caa into cf1b6787e91d5354d5b0d053c6a2ae72caaa1f1a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3dec1e10cd6ae73e45cd44d04c4228dbf70d1d0a)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 25 alerts** when merging be1d55ff62b5e36a1cb76b663bae414702693b12 into cf1b6787e91d5354d5b0d053c6a2ae72caaa1f1a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-28817fcbdd1b9aab87fd75ffa1ef63a1b43ad9d6)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 25 alerts** when merging 2edf9fc00b4e6b160e24d9db1d72e4c7d30772b4 into cf1b6787e91d5354d5b0d053c6a2ae72caaa1f1a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3d7b0dd0e34f343742ae25144fdb6970aca11329)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 25 alerts** when merging 57862ab8231937e7322be9c41ed5288637c08e96 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f8d846764b7321473627ca086231bf502648c1db)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 25 alerts** when merging 9f55611151d6f9dfd2e589faf9fcdbea8dba1826 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-46ffcdb32c91775dc976195590658a74f2d84086)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 25 alerts** when merging c0990ecb6beacd5fafc8ab0f9dbfe6e4ddb3d0ba into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-26820db341e7f6e90d3abac291fe595b78e981f0)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 25 alerts** when merging b4f69800bb88f0d19f867cfb8b8afeb0926589cc into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a29ee40c612fe88bb1aae65b17806d0828c15b86)\n\n**new alerts:**\n\n* 19 for Unused import\n* 4 for Unused local variable\n* 2 for Variable defined multiple times",
"This pull request **introduces 2 alerts** when merging 53963d4dc2f3898d48082ac0bd359906e4b2d2d6 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-98df2372d702223a7f2e10c5654aa205cd5bf928)\n\n**new alerts:**\n\n* 1 for Unused local variable\n* 1 for Unused import",
"This pull request **introduces 2 alerts** when merging 8bcd0dd90c1ed831b49e0c671b3f8af0e122fca1 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-38fb5857074ee8ea6011cfd9455760b777e1c690)\n\n**new alerts:**\n\n* 1 for Unused local variable\n* 1 for Unused import",
"This pull request **introduces 2 alerts** when merging 7ca527fa6b05255131a722d0b5373c4bb99325c7 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1023b7803ab22fbadc03a7538eb6c153ac74a379)\n\n**new alerts:**\n\n* 2 for Unused import",
"This pull request **introduces 1 alert** when merging 65b96825a3b433806acb8ff9fcb3b41611831682 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-0b7ad1a04d5ffae6cb99bfbc285db92d9b6f0e33)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging b17369f0b67a09f1d6082eff556c424f3b82d07f into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3cc2a31fb8305abf8131487faf8ae76e1dc2af08)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging ee24ea0c68cc21d474b0b6a5e976e2e92cfa3da3 into 479b6155710e1564c60d7824a8e88ee3d18de1f6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-edbe537e823b50ff4646511ff409d9fbd3f0a8db)\n\n**new alerts:**\n\n* 1 for Unused import",
"Could you please fix the LGTM errors. @okuchaiev to review the new lib",
"> Could you please fix the LGTM errors. @okuchaiev to review the new lib\r\n\r\nthe LGTM should be already fixed, those are old ones",
"How about adding to the main README what are nemo_tools vs tools?",
"> How about adding to the main README what are nemo_tools vs tools?\r\nThe main Readme is pretty crisp and only talks about installation. Its better to add a readme to NeMo/tools folder what this folder is doing. I added readme to NeMo/nemo_tools too, just like NeMo/nemo/README"
] | 2021-02-25T00:31:26 | 2021-03-31T20:31:19 | 2021-03-31T20:31:19 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1797",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1797",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1797.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1797.patch",
"merged_at": "2021-03-31T20:31:19"
} | * added nemo_tools sub package with python requirements and setup.sh
* added doc strings
* added text denormalization to nemo_tools
* added pytests and pynini tests
* added export option for inverse text normalization to NeMo/tools | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1797/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1797/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1796 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1796/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1796/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1796/events | https://github.com/NVIDIA/NeMo/pull/1796 | 815,921,728 | MDExOlB1bGxSZXF1ZXN0NTc5NjcwMzc5 | 1,796 | Bio meg dir update | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2021-02-24T23:11:11 | 2021-02-25T22:46:15 | 2021-02-25T22:17:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1796",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1796",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1796.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1796.patch",
"merged_at": "2021-02-25T22:17:21"
} | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1796/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1796/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1795 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1795/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1795/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1795/events | https://github.com/NVIDIA/NeMo/pull/1795 | 815,902,821 | MDExOlB1bGxSZXF1ZXN0NTc5NjU1Mjk0 | 1,795 | Fastspeech2 | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 5 alerts** when merging 23a6b0e5cb4cb53703400b9bd7bcec44906c6afa into f2378dd28b1c1a0bac985a979bb79059143d8026 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a6b19a6b94f0b89c2397eb614e1f75249088c340)\n\n**new alerts:**\n\n* 4 for Unused import\n* 1 for Unused local variable",
"This pull request **introduces 5 alerts** when merging 619be165a7a12708ed649ce6133dba2cba605fb2 into f2378dd28b1c1a0bac985a979bb79059143d8026 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-bbbd15bbaaa2720bf8eb5fa61fe56270f657ed19)\n\n**new alerts:**\n\n* 4 for Unused import\n* 1 for Unused local variable",
"This pull request **introduces 5 alerts** when merging 29a1dd910673c372909fd05c997f6c25e88e8d75 into f2378dd28b1c1a0bac985a979bb79059143d8026 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-30dd77b19347fcb2e6d5cf4236e5b0930bf80547)\n\n**new alerts:**\n\n* 4 for Unused import\n* 1 for Unused local variable",
"This pull request **introduces 5 alerts** when merging 952bd13864fe73a3de78d3c982abeb19bd80980c into f2378dd28b1c1a0bac985a979bb79059143d8026 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-fc4657d6769d9851fff2c718f7a7e5f8190ae756)\n\n**new alerts:**\n\n* 4 for Unused import\n* 1 for Unused local variable",
"This pull request **introduces 5 alerts** when merging 1b1a2daed825a0c689908d264c2ea50b05878202 into f2378dd28b1c1a0bac985a979bb79059143d8026 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-7c3e5b3aa97e5ced36a0d24d9f8e08f86b0e0721)\n\n**new alerts:**\n\n* 4 for Unused import\n* 1 for Unused local variable",
"This pull request **introduces 5 alerts** when merging b3a43bed5737f3eb78f99e9a5ce5d8b6ab3adfbe into f2378dd28b1c1a0bac985a979bb79059143d8026 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-7cb2de0d78daa4692edeb1a8b4318fa6299bc1f0)\n\n**new alerts:**\n\n* 4 for Unused import\n* 1 for Unused local variable"
] | 2021-02-24T22:36:38 | 2021-02-26T18:25:00 | 2021-02-26T18:25:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1795",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1795",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1795.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1795.patch",
"merged_at": "2021-02-26T18:25:00"
} | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1795/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1795/timeline | null | null | true |
|
https://api.github.com/repos/NVIDIA/NeMo/issues/1794 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1794/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1794/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1794/events | https://github.com/NVIDIA/NeMo/pull/1794 | 815,899,771 | MDExOlB1bGxSZXF1ZXN0NTc5NjUyODA3 | 1,794 | Adding option to always create .nemo file when writing checkpoint | {
"login": "RPrenger",
"id": 8484670,
"node_id": "MDQ6VXNlcjg0ODQ2NzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/8484670?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RPrenger",
"html_url": "https://github.com/RPrenger",
"followers_url": "https://api.github.com/users/RPrenger/followers",
"following_url": "https://api.github.com/users/RPrenger/following{/other_user}",
"gists_url": "https://api.github.com/users/RPrenger/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RPrenger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RPrenger/subscriptions",
"organizations_url": "https://api.github.com/users/RPrenger/orgs",
"repos_url": "https://api.github.com/users/RPrenger/repos",
"events_url": "https://api.github.com/users/RPrenger/events{/privacy}",
"received_events_url": "https://api.github.com/users/RPrenger/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mchrzanowski",
"id": 1329399,
"node_id": "MDQ6VXNlcjEzMjkzOTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1329399?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mchrzanowski",
"html_url": "https://github.com/mchrzanowski",
"followers_url": "https://api.github.com/users/mchrzanowski/followers",
"following_url": "https://api.github.com/users/mchrzanowski/following{/other_user}",
"gists_url": "https://api.github.com/users/mchrzanowski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mchrzanowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mchrzanowski/subscriptions",
"organizations_url": "https://api.github.com/users/mchrzanowski/orgs",
"repos_url": "https://api.github.com/users/mchrzanowski/repos",
"events_url": "https://api.github.com/users/mchrzanowski/events{/privacy}",
"received_events_url": "https://api.github.com/users/mchrzanowski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Could you make sure that at any point only 1 \".nemo\" file is saved ? We dont want to clutter with dozens of nemo + dozens of PTL checkpoints for consecutive runs. ",
"> Could you make sure that at any point only 1 \".nemo\" file is saved ? We dont want to clutter with dozens of nemo + dozens of PTL checkpoints for consecutive runs.\r\n\r\nThat's how it works now. It'll either overwrite the old file with the latest or overwrite it with the best each time depending on your `save_best_model` option. I basically copied the functionality of the `on_train_end` hook",
"I just realized that if \"save_best_model\" is True, this will make it so the training will continue after saving the checkpoint with the best model rather than the with the latest. I'm making the PR a draft until I fix it.\r\n",
"Cool that sounds nice. Maybe a good default for this is True ? @blisc for final review ",
"also, @blisc please decide whether this OK for rc (looks small enough of a change to me) or should stay on main",
"Lightning's callbacks have `on_keyboard_interrupt`, https://pytorch-lightning.readthedocs.io/en/stable/extensions/callbacks.html#on-keyboard-interrupt. Maybe we should just leverage that instead.",
"@blisc this is for scenario when training takes several days, but you want to be able to grab intermediate results and evaluate them/deploy intermediate result to debugging tool, etc.",
"> Lightning's callbacks have `on_keyboard_interrupt`, https://pytorch-lightning.readthedocs.io/en/stable/extensions/callbacks.html#on-keyboard-interrupt. Maybe we should just leverage that instead.\r\n\r\nIf we use the keyboard interrupt and we have a long running job, we can't have a .nemo file unless we kill our job. We should be able to deploy our best model while it's still training.",
"> > Lightning's callbacks have `on_keyboard_interrupt`, https://pytorch-lightning.readthedocs.io/en/stable/extensions/callbacks.html#on-keyboard-interrupt. Maybe we should just leverage that instead.\r\n> \r\n> If we use the keyboard interrupt and we have a long running job, we can't have a .nemo file unless we kill our job. We should be able to deploy our best model while it's still training.\r\n\r\nI'm confused as to why the lightning .ckpt isn't sufficient for your needs.",
"for translation, we have to use a model to produce segmented text before it's fed into the Nemo model (ie, sentencepiece processor). this must be stored alongside the model, but it is not itself part of the model we're training. a Nemo file contains this, but I dont think ckpt files would. a model is not deployable without this preprocessing built-in.\r\n\r\nfurthermore, I believe that .ckpt files dont store the config that was used to create the model but that Nemo files do. that would be very useful to have to ensure reproducibility."
] | 2021-02-24T22:30:49 | 2021-02-26T00:03:19 | 2021-02-26T00:03:19 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1794",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1794",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1794.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1794.patch",
"merged_at": "2021-02-26T00:03:19"
} | Right now we only get a `.nemo` file when the training is finished. However, it is common to let training continue for an unspecified amount of epochs and just stop when the training stops improving, in which case we'd never get a `.nemo` file.
This commit adds the option save the nemo file whenever a checkpoint is saved.
Use:
`+exp_manager.checkpoint_callback_params.always_save_nemo = True`
Signed-off-by: rprenger <[email protected]> | {
"login": "RPrenger",
"id": 8484670,
"node_id": "MDQ6VXNlcjg0ODQ2NzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/8484670?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RPrenger",
"html_url": "https://github.com/RPrenger",
"followers_url": "https://api.github.com/users/RPrenger/followers",
"following_url": "https://api.github.com/users/RPrenger/following{/other_user}",
"gists_url": "https://api.github.com/users/RPrenger/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RPrenger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RPrenger/subscriptions",
"organizations_url": "https://api.github.com/users/RPrenger/orgs",
"repos_url": "https://api.github.com/users/RPrenger/repos",
"events_url": "https://api.github.com/users/RPrenger/events{/privacy}",
"received_events_url": "https://api.github.com/users/RPrenger/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1794/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1794/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1793 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1793/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1793/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1793/events | https://github.com/NVIDIA/NeMo/pull/1793 | 815,808,635 | MDExOlB1bGxSZXF1ZXN0NTc5NTc2NTEz | 1,793 | Notebook fix and modified some scripts | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 1 alert** when merging 23389db2bfbb66f34af4fc4bfc3c70d58a37b791 into 1b82b571c2f32e1b109677a67c5820222cb696fe - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-73b2bd0cd56408059f13b25d589e438f9dcb3fba)\n\n**new alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** when merging fa085934cf1e249a38988d8be3420bec67f461c8 into 1b82b571c2f32e1b109677a67c5820222cb696fe - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a484d0a7cf244b188356a2d7da6ce0cb8bec3807)\n\n**new alerts:**\n\n* 1 for Unused import"
] | 2021-02-24T20:13:47 | 2021-02-25T04:44:38 | 2021-02-24T20:46:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1793",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1793",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1793.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1793.patch",
"merged_at": "2021-02-24T20:46:24"
} | Signed-off-by: nithinraok <[email protected]>
* Pytorch Lightening links fix
* renamed get_spkr_emb.py to extract_speaker_embeddings.py
* Added helper speaker_reco_infer.py example script to get labels from trained speaker recognition model
* Added get_hi-mia.py script. (use to be part of old nemo -> used in tutorial) | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1793/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1793/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1791 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1791/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1791/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1791/events | https://github.com/NVIDIA/NeMo/pull/1791 | 815,589,763 | MDExOlB1bGxSZXF1ZXN0NTc5Mzk0MzI4 | 1,791 | Fix language filtering | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"I cannot understand how to fix\r\n```\r\n==================================== ERRORS ====================================\r\n\r\n_______________ ERROR collecting examples/tts/test_tts_infer.py ________________\r\n\r\nImportError while importing test module '/home/mrjenkins/workspace/NeMo_PR-1791/examples/tts/test_tts_infer.py'.\r\n\r\nHint: make sure your test modules/packages have valid Python names.\r\n\r\nTraceback:\r\n\r\n/opt/conda/lib/python3.6/importlib/__init__.py:126: in import_module\r\n\r\n return _bootstrap._gcd_import(name[level:], package, level)\r\n\r\nexamples/tts/test_tts_infer.py:27: in <module>\r\n\r\n from nemo.collections.asr.metrics.wer import word_error_rate\r\n\r\nnemo/collections/asr/__init__.py:15: in <module>\r\n\r\n from nemo.collections.asr import data, losses, models, modules\r\n\r\nnemo/collections/asr/models/__init__.py:16: in <module>\r\n\r\n from nemo.collections.asr.models.classification_models import EncDecClassificationModel\r\n\r\nnemo/collections/asr/models/classification_models.py:38: in <module>\r\n\r\n from nemo.utils.export_utils import attach_onnx_to_onnx\r\n\r\nE ImportError: cannot import name 'attach_onnx_to_onnx'\r\n\r\n------------------------------- Captured stderr --------------------------------\r\n\r\n[NeMo W 2021-02-24 15:37:06 nemo_logging:349 rank:0] /opt/conda/lib/python3.6/site-packages/pydub/utils.py:170: RuntimeWarning: Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work\r\n\r\n warn(\"Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work\", RuntimeWarning)\r\n```"
] | 2021-02-24T15:33:34 | 2021-03-04T17:06:24 | 2021-02-27T05:08:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1791",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1791",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1791.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1791.patch",
"merged_at": "2021-02-27T05:08:05"
} | Signed-off-by: PeganovAnton <[email protected]>
The script `filter_langs_nmt.py` did not work on monolingual data. This pull request fixes the bug. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1791/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1791/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1790 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1790/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1790/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1790/events | https://github.com/NVIDIA/NeMo/pull/1790 | 815,361,239 | MDExOlB1bGxSZXF1ZXN0NTc5MjAzNDUz | 1,790 | Removing attach_onnx_to_onnx | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 1 alert** when merging 647a5bc614dcf01757efb363fabd1958b233e663 into bd6e1ff7a16e2cf0ec5c52df53d975df459cfe4e - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2bdcfa9f3a865f559588bd10e67a3d2798937dcd)\n\n**new alerts:**\n\n* 1 for Unused import"
] | 2021-02-24T10:53:30 | 2021-02-24T16:28:58 | 2021-02-24T16:28:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1790",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1790",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1790.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1790.patch",
"merged_at": "2021-02-24T16:28:58"
} | Signed-off-by: Boris Fomitchev <[email protected]> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1790/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1790/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/1789 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/1789/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/1789/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/1789/events | https://github.com/NVIDIA/NeMo/pull/1789 | 815,232,592 | MDExOlB1bGxSZXF1ZXN0NTc5MDk2NTE1 | 1,789 | Refactor of tokenization and detokenization within the NMT model | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This pull request **introduces 4 alerts** and **fixes 1** when merging ae81427bba749fe8dd90229c958aef151bd8aa33 into cc4bfc06993326fcd8bb978460754b89026341ff - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-257f9409c9404fe2fe6c2d87d34dc968e99b8e1c)\n\n**new alerts:**\n\n* 4 for Unused import\n\n**fixed alerts:**\n\n* 1 for Unused import",
"thank you for doing this. lgtm.",
"This pull request **introduces 4 alerts** and **fixes 1** when merging 9193ed5c9dd5a6002c2c366556783ee68978a825 into 1b82b571c2f32e1b109677a67c5820222cb696fe - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-80bd0bb0142abf15d8bcf3404d2ff85ea5ab25cf)\n\n**new alerts:**\n\n* 4 for Unused import\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **introduces 1 alert** and **fixes 1** when merging ed75070f3ba732944f4ae09ac6c913ba5da3470d into 1b82b571c2f32e1b109677a67c5820222cb696fe - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-d3199dbf754c721c131a5e33985cad4ea3fb9ef1)\n\n**new alerts:**\n\n* 1 for Unused import\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **fixes 1 alert** when merging b761630ea0b35facb77865e3b126cb958b374740 into 1b82b571c2f32e1b109677a67c5820222cb696fe - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-53e715d1d4bfc01e223032c2575b07bbda2109b5)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **fixes 1 alert** when merging 843d255e3f9d52e4cc09ad220c9986c80adb0342 into 1666139b6b3334dc8f699f69d5a97aec4fe53419 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5fda55ea2dcf9960b6efde9acea83ddbabad54fa)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"This pull request **fixes 1 alert** when merging e3ec54b607ed63a44cd55b867876eecb310ec34c into 2e9e5b174ed3b766abbd6bb89b9d2c96e5d8f66c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5e15a729fe2d136a97e9b121d1cb6b589edb1016)\n\n**fixed alerts:**\n\n* 1 for Unused import",
"Lgtm. Thanks again!"
] | 2021-02-24T08:10:47 | 2021-03-04T17:07:33 | 2021-02-25T18:08:23 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/1789",
"html_url": "https://github.com/NVIDIA/NeMo/pull/1789",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/1789.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/1789.patch",
"merged_at": "2021-02-25T18:08:23"
} | This PR refactors some of the fetching of tokenizers, normalizers, and detokenizers within the model and creates Chinese/Japanese tokenizer and detokenizer classes to match Moses semantics. | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/1789/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/1789/timeline | null | null | true |
Subsets and Splits