url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/7627 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7627/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7627/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7627/events | https://github.com/NVIDIA/NeMo/pull/7627 | 1,925,642,605 | PR_kwDOC_bI7s5b3szo | 7,627 | bugfix: pin nemo-text-process to fix Chinese normalizer error. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-10-04T08:08:48 | 2023-10-11T16:34:10 | 2023-10-11T16:34:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7627",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7627",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7627.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7627.patch",
"merged_at": "2023-10-11T16:34:09"
} | # What does this PR do ?
Related to [bug report](https://nvbugswb.nvidia.com/NvBugs5/SWBug.aspx?bugid=4312419&cmtNo=),
Chinese normalizer outputted wrong normalized text for the input, '双辽境内除东辽河、西辽河等**5**条河流', where we expect '双辽境内除东辽河、西辽河等**五**条河流'.
**Evidence**
- On the latest version, i.e. nemo-text-processing=0.2.0rc0, it always normalized it as '双辽境内除东辽河、西辽河等5条河流';
- On the previous version, i.e. nemo-text-processing=0.1.8rc0, it normalized it as expected text, '双辽境内除东辽河、西辽河等五条河流'.
**Detailed Log**
- 0.2.0rc0
```
In [1]: from nemo_text_processing.text_normalization.normalize import Normalizer
In [2]: normalizer = Normalizer(lang='zh', input_case='cased', overwrite_cache=True, cache_dir="./cache_dir")
In [3]: text = '双辽境内除东辽河、西辽河等5条河流'
In [4]: normalizer.normalize(text)
Out[4]: '双辽境内除东辽河、西辽河等5条河流'
```
- 0.1.8rc0
```
Downloading nemo_text_processing-0.1.8rc0-py3-none-any.whl (2.3 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.3/2.3 MB 12.5 MB/s eta 0:00:00
Installing collected packages: nemo-text-processing
Attempting uninstall: nemo-text-processing
Found existing installation: nemo-text-processing 0.2.0rc0
Uninstalling nemo-text-processing-0.2.0rc0:
Successfully uninstalled nemo-text-processing-0.2.0rc0
Successfully installed nemo-text-processing-0.1.8rc0
In [1]: from nemo_text_processing.text_normalization.normalize import Normalizer
In [2]: normalizer = Normalizer(lang='zh', input_case='cased', overwrite_cache=True, cache_dir="./cache_dir")
In [3]: text = '双辽境内除东辽河、西辽河等5条河流'
In [4]: normalizer.normalize(text)
Out[4]: '双辽境内除东辽河、西辽河等五条河流'
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7627/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7627/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7626 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7626/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7626/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7626/events | https://github.com/NVIDIA/NeMo/pull/7626 | 1,925,444,327 | PR_kwDOC_bI7s5b3CWl | 7,626 | PEFT eval fix | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-04T05:41:24 | 2023-10-04T19:21:46 | 2023-10-04T19:21:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7626",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7626",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7626.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7626.patch",
"merged_at": "2023-10-04T19:21:45"
} | # What does this PR do ?
Fix issue where peft weights are not loaded for distributed checkpoints
**Collection**: NLP
# Changelog
- Load peft weights in restore_from instead of _load_state_dict_from_disk if distributed checkpoint is used
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7626/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7626/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7625 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7625/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7625/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7625/events | https://github.com/NVIDIA/NeMo/issues/7625 | 1,925,403,348 | I_kwDOC_bI7s5yw1LU | 7,625 | Hifigan Finetuning Error | {
"login": "potatocharlie1",
"id": 87079816,
"node_id": "MDQ6VXNlcjg3MDc5ODE2",
"avatar_url": "https://avatars.githubusercontent.com/u/87079816?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/potatocharlie1",
"html_url": "https://github.com/potatocharlie1",
"followers_url": "https://api.github.com/users/potatocharlie1/followers",
"following_url": "https://api.github.com/users/potatocharlie1/following{/other_user}",
"gists_url": "https://api.github.com/users/potatocharlie1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/potatocharlie1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/potatocharlie1/subscriptions",
"organizations_url": "https://api.github.com/users/potatocharlie1/orgs",
"repos_url": "https://api.github.com/users/potatocharlie1/repos",
"events_url": "https://api.github.com/users/potatocharlie1/events{/privacy}",
"received_events_url": "https://api.github.com/users/potatocharlie1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-10-04T04:53:51 | 2023-11-25T01:44:54 | 2023-11-25T01:44:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I am trying to finetune hifigan with spectrograms created with a previously finetuned FastPitch, following the tutorials: FastPitch_Finetuning.ipynb and FastPitch_GermanTTS_Training.ipynb. Finetuning Fastpitch went well, however when I try to finetune hifigan on the same data is always raises this error:
Sanity Checking: 0it [00:00, ?it/s]Error executing job with overrides: ['model.max_steps=10', 'model.optim.lr=0.00001', '~model.optim.sched', 'train_dataset=./sad_data_manifest_train_local_mel.json', 'validation_datasets=./sad_data_manifest_test_local_mel.json', 'exp_manager.exp_dir=hifigan_ft', '+trainer.val_check_interval=5', '+init_from_pretrained_model=tts_en_hifigan', 'trainer.check_val_every_n_epoch=null', 'model/train_ds=train_ds_finetune', 'model/validation_ds=val_ds_finetune']
Traceback (most recent call last):
File "/mnt/c/Users/charl/Documents/synvoice/hifigan_finetune.py", line 28, in main
trainer.fit(model)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 532, in fit
call._call_and_handle_interrupt(
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 42, in _call_and_handle_interrupt
return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 93, in launch
return function(*args, **kwargs)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 571, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 980, in _run
results = self._run_stage()
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1021, in _run_stage
self._run_sanity_check()
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1050, in _run_sanity_check
val_loop.run()
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/loops/utilities.py", line 181, in _decorator
return loop_run(self, *args, **kwargs)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/loops/evaluation_loop.py", line 108, in run
batch, batch_idx, dataloader_idx = next(data_fetcher)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/loops/fetchers.py", line 137, in __next__
self._fetch_next_batch(self.dataloader_iter)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/loops/fetchers.py", line 151, in _fetch_next_batch
batch = next(iterator)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/utilities/combined_loader.py", line 285, in __next__
out = next(self._iterator)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/utilities/combined_loader.py", line 123, in __next__
out = next(self.iterators[0])
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 630, in __next__
data = self._next_data()
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 1345, in _next_data
return self._process_data(data)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 1371, in _process_data
data.reraise()
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/_utils.py", line 694, in reraise
raise exception
ValueError: Caught ValueError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
data = fetcher.fetch(index)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 51, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 51, in <listcomp>
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/tts/data/dataset.py", line 1144, in __getitem__
start = random.randint(0, mel.shape[1] - frames - 1)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/random.py", line 370, in randint
return self.randrange(a, b+1)
File "/home/charlie/anaconda3/envs/nemo/lib/python3.10/random.py", line 353, in randrange
raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))
ValueError: empty range for randrange() (0, -12, -12)
**Steps/Code to reproduce bug**
generates mels using the generate_mels.py:
```
python generate_mels.py \
--cpu \
--fastpitch-model-ckpt {fastpitch_model_path} \
--input-json-manifests sad_data_manifest_train_local.json sad_data_manifest_test_local.json \
--output-json-manifest-root ./
```
and then started finetuning:
```
python hifigan_finetune.py --config-name=hifigan.yaml \
model.max_steps=10 model.optim.lr=0.00001 ~model.optim.sched \
train_dataset=./sad_data_manifest_train_local_mel.json \
validation_datasets=./sad_data_manifest_test_local_mel.json \
exp_manager.exp_dir=hifigan_ft \
+trainer.val_check_interval=5 \
+init_from_pretrained_model=tts_en_hifigan \
trainer.check_val_every_n_epoch=null \
model/train_ds=train_ds_finetune \
model/validation_ds=val_ds_finetune \
```
**Expected behavior**
Hifigan finetuning starts
**Environment overview (please complete the following information)**
- Method of NeMo install: python -m pip install git+https://github.com/NVIDIA/NeMo.git@main#egg=nemo_toolkit[all]
**Environment details**
OS: Linux 5.15.90.1-microsoft-standard-WSL2
PyTorch version: 2.2.0.dev20230913
Python version: 3.10.12 (main, Jul 5 2023, 18:54:27) [GCC 11.2.0]
**Additional context**
I am using parts of the iemocap dataset. The files differ in length, but generating the mels already pads/cuts them to roughly 6 seconds. The mels from generate_mels.py look good. I have looked into the other similar issues and therefore changed to the generate_mels.py code, but it did not fix the issue. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7625/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7625/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7624 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7624/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7624/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7624/events | https://github.com/NVIDIA/NeMo/pull/7624 | 1,925,380,623 | PR_kwDOC_bI7s5b200d | 7,624 | Fix ptuning crash for llama 2 ckpt | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-04T04:26:01 | 2023-10-11T17:39:36 | 2023-10-11T17:39:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7624",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7624",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7624.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7624.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7624/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7624/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7623 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7623/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7623/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7623/events | https://github.com/NVIDIA/NeMo/pull/7623 | 1,925,362,170 | PR_kwDOC_bI7s5b2w__ | 7,623 | Add ddp_find_unused_parameters=True and change accelerator to auto | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-04T04:01:29 | 2023-10-05T03:17:20 | 2023-10-05T03:17:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7623",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7623",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7623.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7623.patch",
"merged_at": "2023-10-05T03:17:19"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7623/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7623/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7622 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7622/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7622/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7622/events | https://github.com/NVIDIA/NeMo/pull/7622 | 1,925,183,895 | PR_kwDOC_bI7s5b2K3O | 7,622 | fix llama2 70b lora tuning bug | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-04T00:46:06 | 2023-10-04T16:29:13 | 2023-10-04T16:29:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7622",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7622",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7622.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7622.patch",
"merged_at": "2023-10-04T16:29:12"
} | # What does this PR do ?
Fixes a bug in LLaMa2 70b LoRA tuning. There was a modification to specifically deal with LLaMa2 70b (which uses GQA) in the old API that was not propagated during the refactor.
**Collection**: NLP
# Changelog
- Modified LoraPEFTConfig to exactly follow the logic in the old MegatronGPTLoRAModel
# Usage
```python
python megatron_gpt_peft_tuning.py <...> model.restore_from_path=<a llama2 70b checkpoint>
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #7299 and #7308
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7622/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7622/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7621 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7621/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7621/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7621/events | https://github.com/NVIDIA/NeMo/pull/7621 | 1,925,029,140 | PR_kwDOC_bI7s5b1pWq | 7,621 | bugfix: trainer.gpus, trainer.strategy, trainer.accelerator | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T22:11:41 | 2023-10-04T21:09:29 | 2023-10-04T21:09:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7621",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7621",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7621.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7621.patch",
"merged_at": "2023-10-04T21:09:28"
} | # What does this PR do ?
fixed trainer.devices and trainer.accelerator.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7621/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7621/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7620 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7620/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7620/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7620/events | https://github.com/NVIDIA/NeMo/pull/7620 | 1,925,028,856 | PR_kwDOC_bI7s5b1pSz | 7,620 | Bound transformers version in requirements | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-10-03T22:11:24 | 2023-10-04T02:35:07 | 2023-10-04T02:35:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7620",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7620",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7620.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7620.patch",
"merged_at": "2023-10-04T02:35:06"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7620/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7620/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7619 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7619/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7619/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7619/events | https://github.com/NVIDIA/NeMo/pull/7619 | 1,924,950,833 | PR_kwDOC_bI7s5b1YLm | 7,619 | Safeguard nemo_text_processing installation on ARM (#7485) | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T21:06:06 | 2023-10-18T14:42:45 | 2023-10-05T05:11:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7619",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7619",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7619.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7619.patch",
"merged_at": "2023-10-05T05:11:36"
} | * safeguard nemo_text_processing installing
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* update check
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7619/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7619/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7618 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7618/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7618/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7618/events | https://github.com/NVIDIA/NeMo/issues/7618 | 1,924,822,807 | I_kwDOC_bI7s5yuncX | 7,618 | Get scores from inferences from the Text_Classification_Sentiment_Analysis script | {
"login": "CRochaVox",
"id": 94137813,
"node_id": "U_kgDOBZxt1Q",
"avatar_url": "https://avatars.githubusercontent.com/u/94137813?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/CRochaVox",
"html_url": "https://github.com/CRochaVox",
"followers_url": "https://api.github.com/users/CRochaVox/followers",
"following_url": "https://api.github.com/users/CRochaVox/following{/other_user}",
"gists_url": "https://api.github.com/users/CRochaVox/gists{/gist_id}",
"starred_url": "https://api.github.com/users/CRochaVox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CRochaVox/subscriptions",
"organizations_url": "https://api.github.com/users/CRochaVox/orgs",
"repos_url": "https://api.github.com/users/CRochaVox/repos",
"events_url": "https://api.github.com/users/CRochaVox/events{/privacy}",
"received_events_url": "https://api.github.com/users/CRochaVox/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-10-03T19:40:29 | 2023-10-06T11:49:00 | 2023-10-06T11:48:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello everyone, I trained a model with Text_Classification_Sentiment_Analysis.ipynb and I would like to know if I can extract the scores for each sentiment e.g.:
"I answered a call" is a neutral phrase, what score does the engine understand that this phrase is neutral rather than positive or negative?
Is it possible to obtain this information?
I'm using extraction this way
```
model = nemo_nlp.models.TextClassificationModel.restore_from("path/model")
l_results = model.classifytext(queries=keys_list, batch_size=3, max_seq_length=512)
``` | {
"login": "CRochaVox",
"id": 94137813,
"node_id": "U_kgDOBZxt1Q",
"avatar_url": "https://avatars.githubusercontent.com/u/94137813?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/CRochaVox",
"html_url": "https://github.com/CRochaVox",
"followers_url": "https://api.github.com/users/CRochaVox/followers",
"following_url": "https://api.github.com/users/CRochaVox/following{/other_user}",
"gists_url": "https://api.github.com/users/CRochaVox/gists{/gist_id}",
"starred_url": "https://api.github.com/users/CRochaVox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CRochaVox/subscriptions",
"organizations_url": "https://api.github.com/users/CRochaVox/orgs",
"repos_url": "https://api.github.com/users/CRochaVox/repos",
"events_url": "https://api.github.com/users/CRochaVox/events{/privacy}",
"received_events_url": "https://api.github.com/users/CRochaVox/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7618/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7618/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7617 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7617/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7617/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7617/events | https://github.com/NVIDIA/NeMo/pull/7617 | 1,924,806,230 | PR_kwDOC_bI7s5b04mK | 7,617 | Added NKB | {
"login": "ertkonuk",
"id": 22161733,
"node_id": "MDQ6VXNlcjIyMTYxNzMz",
"avatar_url": "https://avatars.githubusercontent.com/u/22161733?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ertkonuk",
"html_url": "https://github.com/ertkonuk",
"followers_url": "https://api.github.com/users/ertkonuk/followers",
"following_url": "https://api.github.com/users/ertkonuk/following{/other_user}",
"gists_url": "https://api.github.com/users/ertkonuk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ertkonuk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ertkonuk/subscriptions",
"organizations_url": "https://api.github.com/users/ertkonuk/orgs",
"repos_url": "https://api.github.com/users/ertkonuk/repos",
"events_url": "https://api.github.com/users/ertkonuk/events{/privacy}",
"received_events_url": "https://api.github.com/users/ertkonuk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T19:29:54 | 2023-10-26T01:44:10 | 2023-10-26T01:44:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7617",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7617",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7617.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7617.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7617/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7617/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7616 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7616/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7616/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7616/events | https://github.com/NVIDIA/NeMo/pull/7616 | 1,924,769,204 | PR_kwDOC_bI7s5b0wOT | 7,616 | Fix py3.11 dataclasses issue | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T19:14:38 | 2023-10-05T17:18:33 | 2023-10-05T17:18:32 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7616",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7616",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7616.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7616.patch",
"merged_at": "2023-10-05T17:18:32"
} | # What does this PR do ?
Fixes an issue with mutable defaults inside dataclasses across NeMo configs
Fixes #7166
**Collection**: [Core, ASR, NLP, TTS, Tools]
# Changelog
- Guard mecab and ipadic
- Remove dependence on mecab and ipadic from sacrebleu
- Fix dataclasses across domains and tools
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7616/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7616/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7615 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7615/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7615/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7615/events | https://github.com/NVIDIA/NeMo/pull/7615 | 1,924,571,544 | PR_kwDOC_bI7s5b0FcJ | 7,615 | Minor blog website updates | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-10-03T17:05:31 | 2023-10-03T18:01:23 | 2023-10-03T18:01:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7615",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7615",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7615.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7615.patch",
"merged_at": "2023-10-03T18:01:22"
} | # What does this PR do ?
Updating metadata and docs. Changing buttons on home page.
**Collection**: NeMo github io website
# Changelog
- explain `<!-- more -->` tag in template and README
- update date of the Numba post
- update the OpenGraph metadata of the NFA, alignment and Numba blog posts
- add documentation of OpenGraph metadata in the README
- reorder the metadata in the blog posts so it's a bit tidier
- change 3 ASR/Megatron/TTS buttons on the homepage to one 'Documentation' button.
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7615/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7615/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7614 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7614/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7614/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7614/events | https://github.com/NVIDIA/NeMo/pull/7614 | 1,924,551,941 | PR_kwDOC_bI7s5b0BOm | 7,614 | fix ssl models ptl monitor val through logging | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T16:52:11 | 2023-10-05T05:44:49 | 2023-10-05T05:44:48 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7614",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7614",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7614.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7614.patch",
"merged_at": "2023-10-05T05:44:48"
} | # What does this PR do ?
Add logging of loss by adding to validation_outputs (self.log) for ssl_models
**Collection**: ASR
# Changelog
- Add to self.log by setting to validation_step_outputs
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7614/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7614/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7613 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7613/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7613/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7613/events | https://github.com/NVIDIA/NeMo/pull/7613 | 1,924,505,357 | PR_kwDOC_bI7s5bz3Qq | 7,613 | adding special_tokens from tokenizer config for transformer-lm model | {
"login": "clumsy",
"id": 379115,
"node_id": "MDQ6VXNlcjM3OTExNQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/379115?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/clumsy",
"html_url": "https://github.com/clumsy",
"followers_url": "https://api.github.com/users/clumsy/followers",
"following_url": "https://api.github.com/users/clumsy/following{/other_user}",
"gists_url": "https://api.github.com/users/clumsy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/clumsy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/clumsy/subscriptions",
"organizations_url": "https://api.github.com/users/clumsy/orgs",
"repos_url": "https://api.github.com/users/clumsy/repos",
"events_url": "https://api.github.com/users/clumsy/events{/privacy}",
"received_events_url": "https://api.github.com/users/clumsy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T16:24:08 | 2023-11-08T18:59:35 | 2023-11-08T00:36:03 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7613",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7613",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7613.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7613.patch",
"merged_at": "2023-11-08T00:36:03"
} | # What does this PR do ?
`special_tokens` are currently ignored when constructing a tokenizer for `transformer_lm_model` using the following example: https://github.com/NVIDIA/NeMo/blob/5cb76a53f21d7470773a80d62fd513defa24ddbf/examples/nlp/language_modeling/conf/bert_pretraining_from_text_config.yaml#L51
**Collection**: NLP/language-modeling
# Changelog
- transformer_lm_model: use `special_tokens` from config when creating the tokenizer, making it backward-compatible with previous behavior (when `special_tokens` are not provided we proceed with `None`).
# Usage
* https://github.com/NVIDIA/NeMo/blob/5cb76a53f21d7470773a80d62fd513defa24ddbf/examples/nlp/language_modeling/conf/bert_pretraining_from_text_config.yaml#L51
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7613/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7613/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7612 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7612/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7612/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7612/events | https://github.com/NVIDIA/NeMo/pull/7612 | 1,924,475,480 | PR_kwDOC_bI7s5bzwt0 | 7,612 | Fix metrics for SE tutorial | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T16:09:27 | 2023-10-05T05:45:21 | 2023-10-05T05:45:20 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7612",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7612",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7612.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7612.patch",
"merged_at": "2023-10-05T05:45:20"
} | # What does this PR do ?
This PR fixes a bug in SE tutorial caused by initialization of metrics for audio-to-audio models.
**Collection**: ASR, Tutorials
# Changelog
- Updated metric initialization
- Small fixes in the tutorial notebook
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7612/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7612/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7610 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7610/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7610/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7610/events | https://github.com/NVIDIA/NeMo/pull/7610 | 1,923,864,114 | PR_kwDOC_bI7s5bxsJ- | 7,610 | [pre-commit.ci] pre-commit suggestions | {
"login": "pre-commit-ci[bot]",
"id": 66853113,
"node_id": "MDM6Qm90NjY4NTMxMTM=",
"avatar_url": "https://avatars.githubusercontent.com/in/68672?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D",
"html_url": "https://github.com/apps/pre-commit-ci",
"followers_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-10-03T10:53:15 | 2023-10-26T01:44:12 | 2023-10-26T01:44:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7610",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7610",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7610.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7610.patch",
"merged_at": null
} | <!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](https://github.com/pre-commit/pre-commit-hooks/compare/v4.3.0...v4.4.0)
- [github.com/psf/black: 19.10b0 → 23.9.1](https://github.com/psf/black/compare/19.10b0...23.9.1)
<!--pre-commit.ci end--> | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7610/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7610/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7608 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7608/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7608/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7608/events | https://github.com/NVIDIA/NeMo/pull/7608 | 1,923,353,471 | PR_kwDOC_bI7s5bv_yh | 7,608 | fix ssl models ptl monitor val through logging | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-03T05:41:53 | 2023-10-03T16:51:29 | 2023-10-03T16:51:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7608",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7608",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7608.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7608.patch",
"merged_at": "2023-10-03T16:51:29"
} | # What does this PR do ?
Add logging of loss by adding to validation_outputs (self.log) for ssl_models
**Collection**: ASR
# Changelog
- Add to self.log by setting to validation_step_outputs
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7608/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7608/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7607 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7607/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7607/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7607/events | https://github.com/NVIDIA/NeMo/issues/7607 | 1,923,056,912 | I_kwDOC_bI7s5yn4UQ | 7,607 | convert_hf_llama_to_nemo.py -> megatron_change_num_partitions.py on Llama 2 70b results in a crash. | {
"login": "LouisCastricato",
"id": 5066878,
"node_id": "MDQ6VXNlcjUwNjY4Nzg=",
"avatar_url": "https://avatars.githubusercontent.com/u/5066878?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LouisCastricato",
"html_url": "https://github.com/LouisCastricato",
"followers_url": "https://api.github.com/users/LouisCastricato/followers",
"following_url": "https://api.github.com/users/LouisCastricato/following{/other_user}",
"gists_url": "https://api.github.com/users/LouisCastricato/gists{/gist_id}",
"starred_url": "https://api.github.com/users/LouisCastricato/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LouisCastricato/subscriptions",
"organizations_url": "https://api.github.com/users/LouisCastricato/orgs",
"repos_url": "https://api.github.com/users/LouisCastricato/repos",
"events_url": "https://api.github.com/users/LouisCastricato/events{/privacy}",
"received_events_url": "https://api.github.com/users/LouisCastricato/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-10-03T00:28:14 | 2023-11-10T01:45:06 | 2023-11-10T01:45:06 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I'm trying to RLHF Llama 2 70b w/ trlX NeMo. A required step of this is to convert llama 2 70b to the nemo format and perform tensor parallel sharding.
Currently, conversion works fine. I can get a copy of llama 70b that loads within nemo, albeit without tensor parallel sharding. When I run `megatron_change_num_partitions.py` on my checkpoint though, and attempt to change the number of TP shards from 1 to 8, I get the following error:
```[NeMo I 2023-10-02 15:58:58 megatron_change_num_partitions:352] Writing pp rank 0 tp rank 7 to file /home-dir/nemo_checkpoints/SB2_8tp
Invalid access pattern for ShardedTensor(key='model.embedding.word_embeddings.weight'): tensor([[1],
[0],
[0],
[0],
[0],
[0],
[0],
[0]], dtype=torch.int32)
Traceback (most recent call last):
File "/home-dir/nemo-trlx/NeMo/examples/nlp/language_modeling/megatron_change_num_partitions.py", line 1502, in <module>
main()
File "/home-dir/nemo-trlx/NeMo/examples/nlp/language_modeling/megatron_change_num_partitions.py", line 1455, in main
global_offset = split_partition(
File "/home-dir/nemo-trlx/NeMo/examples/nlp/language_modeling/megatron_change_num_partitions.py", line 746, in split_partition
write_tp_pp_split(model, splits, app_state, tp_size, pp_rank, write_path)
File "/home-dir/nemo-trlx/NeMo/examples/nlp/language_modeling/megatron_change_num_partitions.py", line 353, in write_tp_pp_split
model.save_to(write_path)
File "/opt/NeMo/nemo/core/classes/modelPT.py", line 392, in save_to
self._save_restore_connector.save_to(self, str(save_path)) # downstream tasks expect str, not Path
File "/opt/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 480, in save_to
dist_checkpointing.save(sharded_state_dict=sharded_state_dict, checkpoint_dir=dist_ckpt_dir)
File "/opt/Megatron-LM/megatron/core/dist_checkpointing/serialization.py", line 160, in save
validate_sharding_integrity(sharded_tensors)
File "/opt/Megatron-LM/megatron/core/dist_checkpointing/serialization.py", line 217, in validate_sharding_integrity
_validate_sharding_for_key(shardings)
File "/opt/Megatron-LM/megatron/core/dist_checkpointing/serialization.py", line 245, in _validate_sharding_for_key
raise CheckpointingException(f'Invalid access pattern for {rank_sharding[0][1]}')
```
**Steps/Code to reproduce bug**
1. Download llama 2 70b
2. Create a copy of the llama 2 config that is provided [here](https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_llama_config.yaml) and tweak it for 70b as opposed to 7b. Details on how to do so are provided within the configuration file.
3. Run `convert_hf_llama_to_nemo.py` within NeMo's docker container (in my case, on a node of H100s).
4. Point `megatron_change_num_partitions.py` to the tar created by the conversion process. (Note that as it stands right now, you actually cannot run this script on extracted tars. It does not work. See [here](https://github.com/NVIDIA/NeMo/blob/f477e051ec68aaa909ca891c1605383f87e11fbb/examples/nlp/language_modeling/megatron_change_num_partitions.py#L986). It will attempt to extract the tar regardless of parameters.)
5. Get trace/error provided above during the saving sequence after sharding has been completed (?)
**Expected behavior**
I expect a fully sharded model to be produced at the end, however this obviously does not occur.
**Environment overview (please complete the following information)**
- Environment location: Lambda Labs, NeMo GAI Docker Image (nvcr.io/ea-bignlp/ga-participants/nemofw-training:23.08.02)
- Method of NeMo install: [pip install or from source]. Docker
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7607/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7607/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7606 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7606/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7606/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7606/events | https://github.com/NVIDIA/NeMo/pull/7606 | 1,922,924,683 | PR_kwDOC_bI7s5buhw- | 7,606 | Fix validation in G2PModel and ThutmoseTaggerModel | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T22:53:37 | 2023-10-03T18:15:09 | 2023-10-03T18:15:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7606",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7606",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7606.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7606.patch",
"merged_at": "2023-10-03T18:15:09"
} | # What does this PR do ?
Append output of val step to `self.validation_step_outputs` in `ThutmoseTaggerModel` and `T5G2PModel` as required by lightning 2.0. Also removes `outputs` arg from `on_validation_epoch_end` and `on_test_epoch_end` in `ThutmoseTaggerModel`
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7606/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7606/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7605 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7605/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7605/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7605/events | https://github.com/NVIDIA/NeMo/pull/7605 | 1,922,901,671 | PR_kwDOC_bI7s5bucaj | 7,605 | Use native mkdocs-material plugin | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-10-02T22:43:31 | 2023-10-03T00:38:43 | 2023-10-03T00:38:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7605",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7605",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7605.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7605.patch",
"merged_at": "2023-10-03T00:38:42"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: NeMo's Github io webpage
# Changelog
- Move from using mkdocs-material nav functionality to built-in blog plug-in for hosting blog posts
- Move 'posts' and 'technical blog' into the same place.
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [TO DO] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7605/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7605/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7604 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7604/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7604/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7604/events | https://github.com/NVIDIA/NeMo/pull/7604 | 1,922,865,640 | PR_kwDOC_bI7s5buUBC | 7,604 | Fix metrics for SE tutorial | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T22:29:45 | 2023-10-03T16:08:59 | 2023-10-03T16:08:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7604",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7604",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7604.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7604.patch",
"merged_at": "2023-10-03T16:08:59"
} | # What does this PR do ?
This PR fixes a bug in SE tutorial caused by initialization of metrics for audio-to-audio models.
**Collection**: ASR, Tutorials
# Changelog
- Updated metric initialization
- Small fixes in the tutorial notebook
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7604/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7604/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7603 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7603/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7603/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7603/events | https://github.com/NVIDIA/NeMo/issues/7603 | 1,922,814,493 | I_kwDOC_bI7s5ym9Id | 7,603 | Export to mlmodel/mlpackage? | {
"login": "hadiidbouk",
"id": 19314956,
"node_id": "MDQ6VXNlcjE5MzE0OTU2",
"avatar_url": "https://avatars.githubusercontent.com/u/19314956?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hadiidbouk",
"html_url": "https://github.com/hadiidbouk",
"followers_url": "https://api.github.com/users/hadiidbouk/followers",
"following_url": "https://api.github.com/users/hadiidbouk/following{/other_user}",
"gists_url": "https://api.github.com/users/hadiidbouk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hadiidbouk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hadiidbouk/subscriptions",
"organizations_url": "https://api.github.com/users/hadiidbouk/orgs",
"repos_url": "https://api.github.com/users/hadiidbouk/repos",
"events_url": "https://api.github.com/users/hadiidbouk/events{/privacy}",
"received_events_url": "https://api.github.com/users/hadiidbouk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-10-02T22:06:42 | 2023-11-09T01:45:02 | 2023-11-09T01:45:02 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
No
**Describe the solution you'd like**
A way to export to models like ECAPA-TDNN to an mlmodel/mlpackage so we can add it easily to our iOS applications
Provide a code snippet on how new APIs/changes would be used by others.
**Describe alternatives you've considered**
I already traced the model and used Libtorch, it works well, but I believe having a mlpackage will reduce the size of the model and the performance will be better. Without forgetting how easy the implementation is.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7603/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7603/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7602 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7602/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7602/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7602/events | https://github.com/NVIDIA/NeMo/pull/7602 | 1,922,752,124 | PR_kwDOC_bI7s5bt6Iy | 7,602 | [TTS] Fix FastPitch data prep tutorial | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T21:28:29 | 2023-10-03T04:21:00 | 2023-10-03T04:21:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7602",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7602",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7602.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7602.patch",
"merged_at": "2023-10-03T04:21:00"
} | # What does this PR do ?
Update TTS tutorial to be consistent with recent code changes.
Merge to r1.21.0 branch.
**Collection**: [TTS]
# Changelog
- Update lower_case and batch_size arguments examples for preprocess_text.py
- Add dataset name to path of logged audio.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7602/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7602/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7601 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7601/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7601/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7601/events | https://github.com/NVIDIA/NeMo/pull/7601 | 1,922,583,533 | PR_kwDOC_bI7s5btUO2 | 7,601 | French g2p with pronunciation dictionary | {
"login": "mgrafu",
"id": 47233618,
"node_id": "MDQ6VXNlcjQ3MjMzNjE4",
"avatar_url": "https://avatars.githubusercontent.com/u/47233618?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mgrafu",
"html_url": "https://github.com/mgrafu",
"followers_url": "https://api.github.com/users/mgrafu/followers",
"following_url": "https://api.github.com/users/mgrafu/following{/other_user}",
"gists_url": "https://api.github.com/users/mgrafu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mgrafu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mgrafu/subscriptions",
"organizations_url": "https://api.github.com/users/mgrafu/orgs",
"repos_url": "https://api.github.com/users/mgrafu/repos",
"events_url": "https://api.github.com/users/mgrafu/events{/privacy}",
"received_events_url": "https://api.github.com/users/mgrafu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-10-02T19:57:46 | 2023-10-20T19:03:32 | 2023-10-20T19:03:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7601",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7601",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7601.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7601.patch",
"merged_at": "2023-10-20T19:03:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7601/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7601/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7600 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7600/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7600/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7600/events | https://github.com/NVIDIA/NeMo/pull/7600 | 1,922,479,834 | PR_kwDOC_bI7s5bs9KS | 7,600 | defaults changed | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-10-02T19:02:30 | 2023-10-03T03:20:03 | 2023-10-03T03:20:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7600",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7600",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7600.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7600.patch",
"merged_at": "2023-10-03T03:20:02"
} | # What does this PR do ?
minor change to defaults..
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7600/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7600/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7599 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7599/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7599/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7599/events | https://github.com/NVIDIA/NeMo/pull/7599 | 1,922,439,964 | PR_kwDOC_bI7s5bs0a0 | 7,599 | add build os key | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-10-02T18:43:23 | 2023-10-02T20:06:37 | 2023-10-02T20:06:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7599",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7599",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7599.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7599.patch",
"merged_at": "2023-10-02T20:06:36"
} | # What does this PR do ?
update build for rtd docs | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7599/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7599/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7598 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7598/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7598/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7598/events | https://github.com/NVIDIA/NeMo/pull/7598 | 1,922,432,345 | PR_kwDOC_bI7s5bszRy | 7,598 | SDE Tutorial minor fix | {
"login": "Jorjeous",
"id": 37293288,
"node_id": "MDQ6VXNlcjM3MjkzMjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/37293288?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jorjeous",
"html_url": "https://github.com/Jorjeous",
"followers_url": "https://api.github.com/users/Jorjeous/followers",
"following_url": "https://api.github.com/users/Jorjeous/following{/other_user}",
"gists_url": "https://api.github.com/users/Jorjeous/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jorjeous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jorjeous/subscriptions",
"organizations_url": "https://api.github.com/users/Jorjeous/orgs",
"repos_url": "https://api.github.com/users/Jorjeous/repos",
"events_url": "https://api.github.com/users/Jorjeous/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jorjeous/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "Jorjeous",
"id": 37293288,
"node_id": "MDQ6VXNlcjM3MjkzMjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/37293288?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jorjeous",
"html_url": "https://github.com/Jorjeous",
"followers_url": "https://api.github.com/users/Jorjeous/followers",
"following_url": "https://api.github.com/users/Jorjeous/following{/other_user}",
"gists_url": "https://api.github.com/users/Jorjeous/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jorjeous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jorjeous/subscriptions",
"organizations_url": "https://api.github.com/users/Jorjeous/orgs",
"repos_url": "https://api.github.com/users/Jorjeous/repos",
"events_url": "https://api.github.com/users/Jorjeous/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jorjeous/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Jorjeous",
"id": 37293288,
"node_id": "MDQ6VXNlcjM3MjkzMjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/37293288?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jorjeous",
"html_url": "https://github.com/Jorjeous",
"followers_url": "https://api.github.com/users/Jorjeous/followers",
"following_url": "https://api.github.com/users/Jorjeous/following{/other_user}",
"gists_url": "https://api.github.com/users/Jorjeous/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jorjeous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jorjeous/subscriptions",
"organizations_url": "https://api.github.com/users/Jorjeous/orgs",
"repos_url": "https://api.github.com/users/Jorjeous/repos",
"events_url": "https://api.github.com/users/Jorjeous/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jorjeous/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-10-02T18:39:29 | 2023-10-03T14:54:23 | 2023-10-03T14:54:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7598",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7598",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7598.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7598.patch",
"merged_at": "2023-10-03T14:54:22"
} | specifies the branch
# What does this PR do?
Specified a branch in the tutorial
**Collection**: [Note which collection this PR will affect]
# Changelog
replaced "!git clone https://github.com/NVIDIA/NeMo"
with
"BRANCH = 'main'
!git clone -b $BRANCH https://github.com/NVIDIA/NeMo"
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [+] Bugfix
- [+] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Jorjeous",
"id": 37293288,
"node_id": "MDQ6VXNlcjM3MjkzMjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/37293288?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jorjeous",
"html_url": "https://github.com/Jorjeous",
"followers_url": "https://api.github.com/users/Jorjeous/followers",
"following_url": "https://api.github.com/users/Jorjeous/following{/other_user}",
"gists_url": "https://api.github.com/users/Jorjeous/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jorjeous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jorjeous/subscriptions",
"organizations_url": "https://api.github.com/users/Jorjeous/orgs",
"repos_url": "https://api.github.com/users/Jorjeous/repos",
"events_url": "https://api.github.com/users/Jorjeous/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jorjeous/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7598/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7598/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7597 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7597/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7597/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7597/events | https://github.com/NVIDIA/NeMo/pull/7597 | 1,922,422,153 | PR_kwDOC_bI7s5bsxVe | 7,597 | Fix validation in G2PModel and ThutmoseTaggerModel | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T18:33:04 | 2023-10-02T22:53:13 | 2023-10-02T22:53:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7597",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7597",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7597.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7597.patch",
"merged_at": "2023-10-02T22:53:12"
} | # What does this PR do ?
Append output of val step to `self.validation_step_outputs` in `ThutmoseTaggerModel` and `T5G2PModel` as required by lightning 2.0. Also removes `outputs` arg from `on_validation_epoch_end` and `on_test_epoch_end` in `ThutmoseTaggerModel`
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7597/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7597/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7596 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7596/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7596/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7596/events | https://github.com/NVIDIA/NeMo/pull/7596 | 1,922,417,806 | PR_kwDOC_bI7s5bswZR | 7,596 | add build os key | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-10-02T18:29:55 | 2023-10-02T18:42:58 | 2023-10-02T18:42:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7596",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7596",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7596.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7596.patch",
"merged_at": "2023-10-02T18:42:57"
} | # What does this PR do ?
update build for rtd docs | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7596/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7596/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7595 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7595/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7595/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7595/events | https://github.com/NVIDIA/NeMo/issues/7595 | 1,922,417,355 | I_kwDOC_bI7s5ylcLL | 7,595 | After running install_beamsearch_decoders.sh, testing script starts endless loop. | {
"login": "Varuzhan97",
"id": 35900214,
"node_id": "MDQ6VXNlcjM1OTAwMjE0",
"avatar_url": "https://avatars.githubusercontent.com/u/35900214?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Varuzhan97",
"html_url": "https://github.com/Varuzhan97",
"followers_url": "https://api.github.com/users/Varuzhan97/followers",
"following_url": "https://api.github.com/users/Varuzhan97/following{/other_user}",
"gists_url": "https://api.github.com/users/Varuzhan97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Varuzhan97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Varuzhan97/subscriptions",
"organizations_url": "https://api.github.com/users/Varuzhan97/orgs",
"repos_url": "https://api.github.com/users/Varuzhan97/repos",
"events_url": "https://api.github.com/users/Varuzhan97/events{/privacy}",
"received_events_url": "https://api.github.com/users/Varuzhan97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-10-02T18:29:34 | 2023-10-02T21:30:36 | 2023-10-02T21:30:36 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | After running install_beamsearch_decoders.sh, testing script starts endless loop. I am using Ubuntu 22.04 with Python 3.10.
The loop is somewhere in this code:
`with self.autocast():
with torch.no_grad():
if isinstance(self.asr_model, EncDecHybridRNNTCTCModel):
self.asr_model.cur_decoder = 'ctc'
all_logits = self.asr_model.transcribe([audio_file], logprobs=True, verbose = 0)
preds = np.argmax(all_logits[0], axis=1)
preds_tensor = torch.tensor(preds, device=self._device).unsqueeze(0)
if isinstance(self.asr_model, EncDecHybridRNNTCTCModel):
pred_text = self.asr_model.ctc_decoding.ctc_decoder_predictions_tensor(preds_tensor)[0][0]
else:
pred_text = self.asr_model._wer.decoding.ctc_decoder_predictions_tensor(preds_tensor)[0][0]
#self.asr_model = self.asr_model.to('cpu')
decoding = self.toggle_decoder("beam")
probs_lens = torch.tensor([all_logits[0].shape[0]])
with torch.no_grad():
packed_batch = torch.cat([torch.tensor(all_logits[0], device=self._device, dtype=torch.float32).unsqueeze(0)], dim=1)
hypotheses = decoding.ctc_decoder_predictions_tensor(packed_batch, decoder_lengths=probs_lens, return_hypotheses=True)`
I also tried to setup environment on Python 3.8, 3.9 and 3.11, either gives "install_beamsearch_decoders.sh not installed " error, or starts endless loop.
| {
"login": "Varuzhan97",
"id": 35900214,
"node_id": "MDQ6VXNlcjM1OTAwMjE0",
"avatar_url": "https://avatars.githubusercontent.com/u/35900214?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Varuzhan97",
"html_url": "https://github.com/Varuzhan97",
"followers_url": "https://api.github.com/users/Varuzhan97/followers",
"following_url": "https://api.github.com/users/Varuzhan97/following{/other_user}",
"gists_url": "https://api.github.com/users/Varuzhan97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Varuzhan97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Varuzhan97/subscriptions",
"organizations_url": "https://api.github.com/users/Varuzhan97/orgs",
"repos_url": "https://api.github.com/users/Varuzhan97/repos",
"events_url": "https://api.github.com/users/Varuzhan97/events{/privacy}",
"received_events_url": "https://api.github.com/users/Varuzhan97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7595/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7595/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7594 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7594/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7594/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7594/events | https://github.com/NVIDIA/NeMo/pull/7594 | 1,922,414,577 | PR_kwDOC_bI7s5bsvsS | 7,594 | Fix ptuning crash for llama 2 ckpt | {
"login": "yuanzhedong",
"id": 5069709,
"node_id": "MDQ6VXNlcjUwNjk3MDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5069709?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yuanzhedong",
"html_url": "https://github.com/yuanzhedong",
"followers_url": "https://api.github.com/users/yuanzhedong/followers",
"following_url": "https://api.github.com/users/yuanzhedong/following{/other_user}",
"gists_url": "https://api.github.com/users/yuanzhedong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yuanzhedong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yuanzhedong/subscriptions",
"organizations_url": "https://api.github.com/users/yuanzhedong/orgs",
"repos_url": "https://api.github.com/users/yuanzhedong/repos",
"events_url": "https://api.github.com/users/yuanzhedong/events{/privacy}",
"received_events_url": "https://api.github.com/users/yuanzhedong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T18:27:34 | 2023-10-04T04:25:37 | 2023-10-04T04:25:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7594",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7594",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7594.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7594.patch",
"merged_at": "2023-10-04T04:25:37"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7594/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7594/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7593 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7593/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7593/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7593/events | https://github.com/NVIDIA/NeMo/issues/7593 | 1,922,367,347 | I_kwDOC_bI7s5ylP9z | 7,593 | replace json with ujson? | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | null | [] | null | null | 2023-10-02T17:54:40 | 2023-10-18T00:18:01 | 2023-10-18T00:18:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
Recently facing too many warning message during model training like `NOTE! Installing ujson may make loading annotations faster.`. Went over a little on `ujson` vs `json`, it seems a worth to switch mostly because `ujson` is faster,
ref: https://github.com/ultrajson/ultrajson
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7593/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7593/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7592 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7592/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7592/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7592/events | https://github.com/NVIDIA/NeMo/pull/7592 | 1,922,346,707 | PR_kwDOC_bI7s5bshAB | 7,592 | PEFT needs mp config propagated for dist ckpt | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T17:40:13 | 2023-10-03T19:08:50 | 2023-10-03T19:08:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7592",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7592",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7592.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7592.patch",
"merged_at": null
} | # What does this PR do ?
Updates the base model config so it will use the right mp config.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7592/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7591 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7591/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7591/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7591/events | https://github.com/NVIDIA/NeMo/pull/7591 | 1,922,250,092 | PR_kwDOC_bI7s5bsMMl | 7,591 | Typo fixes | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-02T16:30:26 | 2023-10-03T06:24:06 | 2023-10-03T06:24:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7591",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7591",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7591.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7591.patch",
"merged_at": "2023-10-03T06:24:06"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7591/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7591/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7590 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7590/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7590/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7590/events | https://github.com/NVIDIA/NeMo/pull/7590 | 1,920,897,026 | PR_kwDOC_bI7s5bnsBx | 7,590 | generate tokens_to_generate for all items in a batch | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-10-01T18:11:40 | 2023-11-30T01:46:09 | 2023-11-30T01:46:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7590",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7590",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7590.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7590.patch",
"merged_at": null
} | # What does this PR do ?
ensure that all examples in a batch generate only `tokens_to_generate` number of tokens.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7590/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7590/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7589 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7589/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7589/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7589/events | https://github.com/NVIDIA/NeMo/pull/7589 | 1,920,385,262 | PR_kwDOC_bI7s5bmCeL | 7,589 | PEFT needs mp config propagated for dist ckpt | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-30T20:08:57 | 2023-10-02T17:39:45 | 2023-10-02T17:39:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7589",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7589",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7589.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7589.patch",
"merged_at": "2023-10-02T17:39:44"
} | # What does this PR do ?
Updates the base model config so it will use the right mp config.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7589/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7589/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7588 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7588/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7588/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7588/events | https://github.com/NVIDIA/NeMo/pull/7588 | 1,920,384,165 | PR_kwDOC_bI7s5bmCRg | 7,588 | best ckpt fix | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-30T20:04:45 | 2023-10-03T03:42:40 | 2023-10-03T03:42:39 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7588",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7588",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7588.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7588.patch",
"merged_at": "2023-10-03T03:42:39"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7588/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7588/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7587 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7587/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7587/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7587/events | https://github.com/NVIDIA/NeMo/pull/7587 | 1,920,342,814 | PR_kwDOC_bI7s5bl6Vi | 7,587 | add ItalianPhonemesTokenizer | {
"login": "GiacomoLeoneMaria",
"id": 72698188,
"node_id": "MDQ6VXNlcjcyNjk4MTg4",
"avatar_url": "https://avatars.githubusercontent.com/u/72698188?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GiacomoLeoneMaria",
"html_url": "https://github.com/GiacomoLeoneMaria",
"followers_url": "https://api.github.com/users/GiacomoLeoneMaria/followers",
"following_url": "https://api.github.com/users/GiacomoLeoneMaria/following{/other_user}",
"gists_url": "https://api.github.com/users/GiacomoLeoneMaria/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GiacomoLeoneMaria/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GiacomoLeoneMaria/subscriptions",
"organizations_url": "https://api.github.com/users/GiacomoLeoneMaria/orgs",
"repos_url": "https://api.github.com/users/GiacomoLeoneMaria/repos",
"events_url": "https://api.github.com/users/GiacomoLeoneMaria/events{/privacy}",
"received_events_url": "https://api.github.com/users/GiacomoLeoneMaria/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-30T17:35:54 | 2023-10-03T03:40:13 | 2023-10-03T03:40:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7587",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7587",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7587.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7587.patch",
"merged_at": "2023-10-03T03:40:12"
} | # What does this PR do ?
Add ItalianPhonemesTokenizer and fix some bugs in ItalianCharsTokenizer
**PR Type**:
- [x] New Feature
- [x] Bugfix
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7587/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7587/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7586 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7586/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7586/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7586/events | https://github.com/NVIDIA/NeMo/pull/7586 | 1,920,306,924 | PR_kwDOC_bI7s5blzVn | 7,586 | Broadcast loss only when using pipeline parallelism and within the pipeline parallel domain | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-30T15:50:12 | 2023-10-03T20:11:11 | 2023-10-03T20:11:10 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7586",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7586",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7586.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7586.patch",
"merged_at": "2023-10-03T20:11:10"
} | Broadcast train and validation loss only when pipeline parallel size is larger than 1.
Also, the loss broadcasting only within the pipeline parallel domain.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7586/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7586/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7585 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7585/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7585/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7585/events | https://github.com/NVIDIA/NeMo/pull/7585 | 1,920,180,087 | PR_kwDOC_bI7s5blavL | 7,585 | Update Speaker_Diarization_Training.ipynb | {
"login": "Hefero",
"id": 32193636,
"node_id": "MDQ6VXNlcjMyMTkzNjM2",
"avatar_url": "https://avatars.githubusercontent.com/u/32193636?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Hefero",
"html_url": "https://github.com/Hefero",
"followers_url": "https://api.github.com/users/Hefero/followers",
"following_url": "https://api.github.com/users/Hefero/following{/other_user}",
"gists_url": "https://api.github.com/users/Hefero/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Hefero/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Hefero/subscriptions",
"organizations_url": "https://api.github.com/users/Hefero/orgs",
"repos_url": "https://api.github.com/users/Hefero/repos",
"events_url": "https://api.github.com/users/Hefero/events{/privacy}",
"received_events_url": "https://api.github.com/users/Hefero/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-30T08:52:08 | 2023-10-23T17:05:18 | 2023-10-23T17:05:17 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7585",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7585",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7585.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7585.patch",
"merged_at": null
} | auto trainer strategy set to "auto"
# What does this PR do ?
Fix a simple bug in a example, config.trainer.strategy = auto changed to config.trainer.strategy = 'auto'
that was interrupting the execution of the code
**Collection**: [Note which collection this PR will affect]
Speaker_Diarization_Training.ipynb
tutorial example
# Changelog
- Add specific line by line info of high level changes in this PR.
config.trainer.strategy = auto changed to config.trainer.strategy = 'auto'
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x ] Did you write any new necessary tests? Ran the notebook
- [ ] Did you add or update any necessary documentation? No need
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7585/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7584 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7584/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7584/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7584/events | https://github.com/NVIDIA/NeMo/pull/7584 | 1,920,148,270 | PR_kwDOC_bI7s5blUhm | 7,584 | Change hifigan finetune strategy to ddp_find_unused_parameters_true | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-30T06:55:21 | 2023-10-02T16:35:23 | 2023-10-02T16:35:22 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7584",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7584",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7584.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7584.patch",
"merged_at": "2023-10-02T16:35:22"
} | # What does this PR do ?
Change strategy from ddp to auto because of PL 2.0
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7584/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7584/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7583 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7583/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7583/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7583/events | https://github.com/NVIDIA/NeMo/pull/7583 | 1,920,061,033 | PR_kwDOC_bI7s5blDS6 | 7,583 | fix typos in nfa and speech enhancement tutorials | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-30T01:54:22 | 2023-09-30T02:12:54 | 2023-09-30T02:12:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7583",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7583",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7583.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7583.patch",
"merged_at": "2023-09-30T02:12:53"
} | # What does this PR do ?
Fix typos
**Collection**: tutorials
# Changelog
- Fix typos in NFA and Speech Enhancement tutorials
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [N/A] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7583/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7583/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7582 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7582/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7582/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7582/events | https://github.com/NVIDIA/NeMo/pull/7582 | 1,920,053,321 | PR_kwDOC_bI7s5blB0B | 7,582 | Fix py3.11 dataclasses issue | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-30T01:26:50 | 2023-10-03T19:14:11 | 2023-10-03T19:14:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7582",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7582",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7582.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7582.patch",
"merged_at": "2023-10-03T19:14:10"
} | # What does this PR do ?
Fixes an issue with mutable defaults inside dataclasses across NeMo configs
Fixes #7166
**Collection**: [Core, ASR, NLP, TTS, Tools]
# Changelog
- Guard mecab and ipadic
- Remove dependence on mecab and ipadic from sacrebleu
- Fix dataclasses across domains and tools
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7582/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7582/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7581 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7581/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7581/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7581/events | https://github.com/NVIDIA/NeMo/pull/7581 | 1,920,024,484 | PR_kwDOC_bI7s5bk7-R | 7,581 | Fix typos in confidence tutorial notebooks | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-30T00:01:37 | 2023-10-02T15:00:53 | 2023-10-02T15:00:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7581",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7581",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7581.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7581.patch",
"merged_at": "2023-10-02T15:00:52"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7581/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7581/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7580 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7580/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7580/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7580/events | https://github.com/NVIDIA/NeMo/pull/7580 | 1,920,023,980 | PR_kwDOC_bI7s5bk73q | 7,580 | fix typos in nfa and speech enhancement tutorials | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-30T00:00:31 | 2023-09-30T01:53:56 | 2023-09-30T01:53:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7580",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7580",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7580.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7580.patch",
"merged_at": "2023-09-30T01:53:56"
} | # What does this PR do ?
Fix typos
**Collection**: tutorials
# Changelog
- Fix typos in NFA and Speech Enhancement tutorials
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [N/A] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7580/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7580/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7579 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7579/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7579/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7579/events | https://github.com/NVIDIA/NeMo/pull/7579 | 1,919,976,502 | PR_kwDOC_bI7s5bkxzl | 7,579 | Change hifigan finetune strategy to ddp_find_unused_parameters_true | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T22:26:33 | 2023-09-30T06:54:55 | 2023-09-30T06:54:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7579",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7579",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7579.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7579.patch",
"merged_at": "2023-09-30T06:54:54"
} | # What does this PR do ?
Change strategy from ddp to auto because of PL 2.0
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7579/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7579/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7578 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7578/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7578/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7578/events | https://github.com/NVIDIA/NeMo/pull/7578 | 1,919,955,095 | PR_kwDOC_bI7s5bktCe | 7,578 | update strategy | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T22:02:58 | 2023-09-30T20:11:14 | 2023-09-30T20:11:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7578",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7578",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7578.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7578.patch",
"merged_at": "2023-09-30T20:11:13"
} | # What does this PR do ?
update strategy to `auto` | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7578/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7578/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7577 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7577/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7577/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7577/events | https://github.com/NVIDIA/NeMo/pull/7577 | 1,919,947,394 | PR_kwDOC_bI7s5bkrYb | 7,577 | update strategy | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T21:51:57 | 2023-09-29T22:02:27 | 2023-09-29T22:02:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7577",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7577",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7577.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7577.patch",
"merged_at": "2023-09-29T22:02:26"
} | # What does this PR do ?
update strategy to `auto` | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7577/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7577/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7576 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7576/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7576/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7576/events | https://github.com/NVIDIA/NeMo/pull/7576 | 1,919,927,407 | PR_kwDOC_bI7s5bknBP | 7,576 | Broadcast loss only when using pipeline parallelism and within the pipeline parallel domain | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T21:26:04 | 2023-09-30T15:49:47 | 2023-09-30T15:49:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7576",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7576",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7576.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7576.patch",
"merged_at": "2023-09-30T15:49:46"
} | Broadcast train and validation loss only when pipeline parallel size is larger than 1.
Also, the loss broadcasting only within the pipeline parallel domain.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "layalir",
"id": 31741533,
"node_id": "MDQ6VXNlcjMxNzQxNTMz",
"avatar_url": "https://avatars.githubusercontent.com/u/31741533?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/layalir",
"html_url": "https://github.com/layalir",
"followers_url": "https://api.github.com/users/layalir/followers",
"following_url": "https://api.github.com/users/layalir/following{/other_user}",
"gists_url": "https://api.github.com/users/layalir/gists{/gist_id}",
"starred_url": "https://api.github.com/users/layalir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/layalir/subscriptions",
"organizations_url": "https://api.github.com/users/layalir/orgs",
"repos_url": "https://api.github.com/users/layalir/repos",
"events_url": "https://api.github.com/users/layalir/events{/privacy}",
"received_events_url": "https://api.github.com/users/layalir/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7576/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7576/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7575 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7575/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7575/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7575/events | https://github.com/NVIDIA/NeMo/pull/7575 | 1,919,926,374 | PR_kwDOC_bI7s5bkmzO | 7,575 | Path to Convert from Dist Ckpt to Legacy | {
"login": "IzzyPutterman",
"id": 16809717,
"node_id": "MDQ6VXNlcjE2ODA5NzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/16809717?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/IzzyPutterman",
"html_url": "https://github.com/IzzyPutterman",
"followers_url": "https://api.github.com/users/IzzyPutterman/followers",
"following_url": "https://api.github.com/users/IzzyPutterman/following{/other_user}",
"gists_url": "https://api.github.com/users/IzzyPutterman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/IzzyPutterman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/IzzyPutterman/subscriptions",
"organizations_url": "https://api.github.com/users/IzzyPutterman/orgs",
"repos_url": "https://api.github.com/users/IzzyPutterman/repos",
"events_url": "https://api.github.com/users/IzzyPutterman/events{/privacy}",
"received_events_url": "https://api.github.com/users/IzzyPutterman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T21:24:49 | 2023-10-22T01:45:38 | 2023-10-22T01:45:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7575",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7575",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7575.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7575.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7575/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7575/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7574 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7574/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7574/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7574/events | https://github.com/NVIDIA/NeMo/pull/7574 | 1,919,650,790 | PR_kwDOC_bI7s5bjrOK | 7,574 | [TTS] fixed trainer's accelerator and strategy. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-29T17:17:35 | 2023-09-29T21:16:52 | 2023-09-29T21:16:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7574",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7574",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7574.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7574.patch",
"merged_at": "2023-09-29T21:16:51"
} | # What does this PR do ?
strategy should be replaced as `ddp_find_unused_parameters_true`.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7574/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7574/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7573 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7573/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7573/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7573/events | https://github.com/NVIDIA/NeMo/pull/7573 | 1,919,650,344 | PR_kwDOC_bI7s5bjrH_ | 7,573 | Append val/test output to instance variable in EncDecSpeakerLabelModel | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T17:17:21 | 2023-09-29T23:16:37 | 2023-09-29T23:16:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7573",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7573",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7573.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7573.patch",
"merged_at": "2023-09-29T23:16:37"
} | # What does this PR do ?
Appends val/test output to self.validation/test_step_outputs in `evaluation_step` method of `EncDecSpeakerLabelModel` and `EncMaskDecAudioToAudioModel`
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7573/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7573/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7572 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7572/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7572/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7572/events | https://github.com/NVIDIA/NeMo/pull/7572 | 1,919,538,549 | PR_kwDOC_bI7s5bjTyY | 7,572 | fix validation_step_outputs initialization for multi-dataloader | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T15:57:08 | 2023-09-29T18:12:44 | 2023-09-29T18:12:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7572",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7572",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7572.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7572.patch",
"merged_at": "2023-09-29T18:12:43"
} | # What does this PR do ?
Correctly handle initialization of validation_step_outputs and test_step_outputs (to log metrics) when multiple dataloaders are set after initialization of model.
**Collection**:
Core
# Changelog
In modelPT.py -
```python
@property
def validation_step_outputs(self):
"""
Cached outputs of validation_step. It can be a list of items (for single data loader) or a list of lists
(for multiple data loaders).
Returns:
List of outputs of validation_step.
"""
if self._validation_step_outputs is not None:
return self._validation_step_outputs
# Initialize new output list
self._validation_step_outputs = []
# Check len(self._validation_dl) > 1 as sometimes single dataloader can be in a list: [<Dataloader obj>] when ds_item in
# config has 1 item passed in a list
if (
self._validation_dl is not None
and isinstance(self._validation_dl, (list, tuple))
and len(self._validation_dl) > 1
):
for _ in range(len(self._validation_dl)):
self._validation_step_outputs.append([])
return self._validation_step_outputs
@validation_step_outputs.setter
def validation_step_outputs(self, value):
self._validation_step_outputs = value
@property
def test_step_outputs(self):
"""
Cached outputs of test_step. It can be a list of items (for single data loader) or a list of lists (for multiple data loaders).
Returns:
List of outputs of test_step.
"""
if self._test_step_outputs is not None:
return self._test_step_outputs
# Initialize new output list
self._test_step_outputs = []
# Check len(self._test_dl) > 1 as sometimes single dataloader can be in a list: [<Dataloader obj>] when ds_item in
# config has 1 item passed in a list
if self._test_dl is not None and isinstance(self._test_dl, (list, tuple)) and len(self._test_dl) > 1:
for _ in range(len(self._test_dl)):
self._test_step_outputs.append([])
return self._test_step_outputs
@test_step_outputs.setter
def test_step_outputs(self, value):
self._test_step_outputs = value
def _cleanup_on_execution_end(self):
"""
Utility function to clean up the module state at the end of execution.
"""
# dynamic freezing cleanup
if hasattr(self, '_freeze_cfg'):
delattr(self, '_freeze_cfg')
# Clear up the val and test output caches
self._validation_step_outputs = None
self._test_step_outputs = None
def on_test_end(self):
""" PyTorch Lightning hook:
https://pytorch-lightning.readthedocs.io/en/stable/common/lightning_module.html#on-test-end
"""
self._cleanup_on_execution_end()
def on_predict_end(self):
""" PyTorch Lightning hook:
https://pytorch-lightning.readthedocs.io/en/stable/common/lightning_module.html#on-test-end
"""
self._cleanup_on_execution_end()
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "KunalDhawan",
"id": 15515031,
"node_id": "MDQ6VXNlcjE1NTE1MDMx",
"avatar_url": "https://avatars.githubusercontent.com/u/15515031?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KunalDhawan",
"html_url": "https://github.com/KunalDhawan",
"followers_url": "https://api.github.com/users/KunalDhawan/followers",
"following_url": "https://api.github.com/users/KunalDhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/KunalDhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/KunalDhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KunalDhawan/subscriptions",
"organizations_url": "https://api.github.com/users/KunalDhawan/orgs",
"repos_url": "https://api.github.com/users/KunalDhawan/repos",
"events_url": "https://api.github.com/users/KunalDhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/KunalDhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7572/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7572/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7571 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7571/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7571/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7571/events | https://github.com/NVIDIA/NeMo/pull/7571 | 1,919,474,939 | PR_kwDOC_bI7s5bjGCx | 7,571 | Clarify that `length_params.max_length` is not a hard constraint | {
"login": "odelalleau",
"id": 507137,
"node_id": "MDQ6VXNlcjUwNzEzNw==",
"avatar_url": "https://avatars.githubusercontent.com/u/507137?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/odelalleau",
"html_url": "https://github.com/odelalleau",
"followers_url": "https://api.github.com/users/odelalleau/followers",
"following_url": "https://api.github.com/users/odelalleau/following{/other_user}",
"gists_url": "https://api.github.com/users/odelalleau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/odelalleau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/odelalleau/subscriptions",
"organizations_url": "https://api.github.com/users/odelalleau/orgs",
"repos_url": "https://api.github.com/users/odelalleau/repos",
"events_url": "https://api.github.com/users/odelalleau/events{/privacy}",
"received_events_url": "https://api.github.com/users/odelalleau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T15:21:16 | 2023-10-02T12:40:25 | 2023-10-02T12:40:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7571",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7571",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7571.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7571.patch",
"merged_at": null
} | # What does this PR do ?
Update docstring describing `length_params.max_length` to say that generated sequences may actually exceed this length, since this can be surprising.
**Collection**: nlp
# Changelog
- Clarify that `length_params.max_length` is not a hard constraint
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [X] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
I need someone to confirm whether the same doc change should be applied to this `asr` file, that seems to be copied from `nlp`:
https://github.com/NVIDIA/NeMo/blob/82e1f4f9f1a280edb70088bf30bf0a099152e185/nemo/collections/asr/modules/transformer/text_generation.py#L79
@stevehuang52 would you be able to confirm by any chance? | {
"login": "odelalleau",
"id": 507137,
"node_id": "MDQ6VXNlcjUwNzEzNw==",
"avatar_url": "https://avatars.githubusercontent.com/u/507137?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/odelalleau",
"html_url": "https://github.com/odelalleau",
"followers_url": "https://api.github.com/users/odelalleau/followers",
"following_url": "https://api.github.com/users/odelalleau/following{/other_user}",
"gists_url": "https://api.github.com/users/odelalleau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/odelalleau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/odelalleau/subscriptions",
"organizations_url": "https://api.github.com/users/odelalleau/orgs",
"repos_url": "https://api.github.com/users/odelalleau/repos",
"events_url": "https://api.github.com/users/odelalleau/events{/privacy}",
"received_events_url": "https://api.github.com/users/odelalleau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7571/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7571/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7570 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7570/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7570/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7570/events | https://github.com/NVIDIA/NeMo/pull/7570 | 1,918,657,404 | PR_kwDOC_bI7s5bgTgc | 7,570 | Add two youtube introductory videos to README and Docs. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-29T06:17:10 | 2023-09-29T16:39:52 | 2023-09-29T16:39:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7570",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7570",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7570.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7570.patch",
"merged_at": "2023-09-29T16:39:51"
} | # What does this PR do ?
See attached html snippets for the results.
**README**
**Documentation**
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7570/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7570/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7569 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7569/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7569/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7569/events | https://github.com/NVIDIA/NeMo/pull/7569 | 1,918,443,504 | PR_kwDOC_bI7s5bflwn | 7,569 | [TTS] fixed trainer's accelerator and strategy. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-29T00:46:23 | 2023-09-29T17:17:09 | 2023-09-29T17:17:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7569",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7569",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7569.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7569.patch",
"merged_at": "2023-09-29T17:17:08"
} | # What does this PR do ?
strategy should be replaced as `ddp_find_unused_parameters_true`.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7569/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7569/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7568 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7568/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7568/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7568/events | https://github.com/NVIDIA/NeMo/pull/7568 | 1,918,400,201 | PR_kwDOC_bI7s5bfcgj | 7,568 | Hotfix: change the order of config overrides | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T23:38:00 | 2023-10-11T17:32:05 | 2023-10-11T17:32:04 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7568",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7568",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7568.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7568.patch",
"merged_at": "2023-10-11T17:32:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7568/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7568/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7567 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7567/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7567/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7567/events | https://github.com/NVIDIA/NeMo/pull/7567 | 1,918,370,505 | PR_kwDOC_bI7s5bfWJg | 7,567 | layernorm1p fix | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T22:53:42 | 2023-10-10T09:54:50 | 2023-10-10T09:54:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7567",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7567",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7567.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7567.patch",
"merged_at": "2023-10-10T09:54:49"
} | # What does this PR do ?
Passes layernorm_zero_centered_gamma param properly which fixes layernorm1p issue.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7567/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7567/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7566 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7566/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7566/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7566/events | https://github.com/NVIDIA/NeMo/pull/7566 | 1,918,334,836 | PR_kwDOC_bI7s5bfObG | 7,566 | Avoid duplicated dist checkpoint save | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T22:07:54 | 2023-10-11T17:33:00 | 2023-10-11T17:32:59 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7566",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7566",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7566.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7566.patch",
"merged_at": "2023-10-11T17:32:59"
} | # What does this PR do ?
This is a WAR for the case of saving a checkpoint twice into the same directory.
A proper fix would be avoiding calling the `save_checkpoint` method altogether.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Avoid duplicated dist checkpoint save
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7566/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7566/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7565 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7565/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7565/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7565/events | https://github.com/NVIDIA/NeMo/pull/7565 | 1,918,244,716 | PR_kwDOC_bI7s5be7J7 | 7,565 | Distributed optimizer support for experimental FP8 tensors (r1.20.0 branch) | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T20:43:13 | 2023-11-26T01:46:58 | 2023-11-26T01:46:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7565",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7565",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7565.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7565.patch",
"merged_at": null
} | Rebased #7469 onto https://github.com/NVIDIA/NeMo/tree/r1.20.0_pt_23.09. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7565/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7565/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7564 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7564/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7564/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7564/events | https://github.com/NVIDIA/NeMo/pull/7564 | 1,918,155,848 | PR_kwDOC_bI7s5ben5S | 7,564 | best ckpt fix | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-28T19:42:12 | 2023-09-30T20:04:16 | 2023-09-30T20:04:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7564",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7564",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7564.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7564.patch",
"merged_at": "2023-09-30T20:04:15"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7564/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7564/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7563 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7563/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7563/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7563/events | https://github.com/NVIDIA/NeMo/pull/7563 | 1,918,138,588 | PR_kwDOC_bI7s5bekJ9 | 7,563 | Fix image for numba post | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-28T19:30:37 | 2023-09-28T19:31:26 | 2023-09-28T19:31:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7563",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7563",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7563.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7563.patch",
"merged_at": "2023-09-28T19:31:25"
} | # What does this PR do ?
Fix the image loaded when the post is created
**Collection**: [Docs]
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7563/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7563/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7562 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7562/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7562/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7562/events | https://github.com/NVIDIA/NeMo/pull/7562 | 1,918,129,894 | PR_kwDOC_bI7s5beiS1 | 7,562 | Append val/test output to instance variable in EncDecSpeakerLabelModel | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T19:23:52 | 2023-09-29T17:16:52 | 2023-09-29T17:16:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7562",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7562",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7562.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7562.patch",
"merged_at": "2023-09-29T17:16:51"
} | # What does this PR do ?
Appends val/test output to self.validation/test_step_outputs in `evaluation_step` method of `EncDecSpeakerLabelModel` and `EncMaskDecAudioToAudioModel`
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7562/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7562/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7561 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7561/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7561/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7561/events | https://github.com/NVIDIA/NeMo/pull/7561 | 1,918,039,942 | PR_kwDOC_bI7s5beOup | 7,561 | Log averaged metric if at least one metric other than loss | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T18:14:26 | 2023-10-27T01:44:09 | 2023-10-27T01:44:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7561",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7561",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7561.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7561.patch",
"merged_at": null
} | # What does this PR do ?
This PR adds explanation for the bug fix (actual fix in #7308)
If user specifies at least one validation metric in the config that is not loss, the average_metric should be calculated and logged so that the CheckpointMonitor does not through an error.
**Collection**: [Note which collection this PR will affect]
NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #7308
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7561/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7561/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7560 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7560/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7560/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7560/events | https://github.com/NVIDIA/NeMo/pull/7560 | 1,918,012,494 | PR_kwDOC_bI7s5beIu3 | 7,560 | [TTS] remove curly braces from ${BRANCH} in jupyer notebook cell. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-28T17:55:14 | 2023-09-28T23:46:42 | 2023-09-28T23:46:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7560",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7560",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7560.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7560.patch",
"merged_at": "2023-09-28T23:46:41"
} | # What does this PR do ?
**Change 1**
In jupyter notebook, when trying to run,
```
## Install NeMo
BRANCH = 'r1.21.0'
!python -m pip install "git+https://github.com/NVIDIA/NeMo.git@${BRANCH}#egg=nemo_toolkit[all]"
```
It will get below errors due to `${BRANCH}`. Removing the curly braces fixes the error.
```shell
DEPRECATION: git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce this behaviour change. A possible replacement is to use the req @ url syntax, and remove the egg fragment. Discussion can be found at https://github.com/pypa/pip/issues/11617
Collecting nemo_toolkit[all]
Cloning https://github.com/NVIDIA/NeMo.git (to revision .21.0) to /tmp/pip-install-gzajrtok/nemo-toolkit_d9d14f8e02594d728021197cbfbd43ee
Running command git clone --filter=blob:none --quiet https://github.com/NVIDIA/NeMo.git /tmp/pip-install-gzajrtok/nemo-toolkit_d9d14f8e02594d728021197cbfbd43ee
WARNING: Did not find branch or tag '.21.0', assuming revision or ref.
Running command git checkout -q .21.0
error: pathspec '.21.0' did not match any file(s) known to git
error: subprocess-exited-with-error
× git checkout -q .21.0 did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× git checkout -q .21.0 did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
\nRemember to restart the runtime for the kernel to pick up any upgraded packages (e.g. matplotlib)!\nAlternatively, you can uncomment the exit() below to crash and restart the kernel, in the case\nthat you want to use the "Run All Cells" (or similar) option.\n
```
**Change 2**
remove pynini installation since it is now a dependency of nemo-text-processing lib.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7560/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7560/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7559 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7559/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7559/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7559/events | https://github.com/NVIDIA/NeMo/pull/7559 | 1,917,922,583 | PR_kwDOC_bI7s5bd1CH | 7,559 | Add rope pos idx fp32 | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T16:51:22 | 2023-09-28T22:41:09 | 2023-09-28T22:41:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7559",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7559",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7559.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7559.patch",
"merged_at": "2023-09-28T22:41:08"
} | # What does this PR do ?
Add fp32 rope pos idx
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
`+model.enforce_fp32_pos_idx=true` to enable using fp32 rope pos index. By default we set this param to `True`.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7559/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7559/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7558 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7558/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7558/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7558/events | https://github.com/NVIDIA/NeMo/issues/7558 | 1,917,760,839 | I_kwDOC_bI7s5yTrVH | 7,558 | Speaker Diarization on short audios fails to estimate number of speakers correctly | {
"login": "gabitza-tech",
"id": 53811655,
"node_id": "MDQ6VXNlcjUzODExNjU1",
"avatar_url": "https://avatars.githubusercontent.com/u/53811655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gabitza-tech",
"html_url": "https://github.com/gabitza-tech",
"followers_url": "https://api.github.com/users/gabitza-tech/followers",
"following_url": "https://api.github.com/users/gabitza-tech/following{/other_user}",
"gists_url": "https://api.github.com/users/gabitza-tech/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gabitza-tech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gabitza-tech/subscriptions",
"organizations_url": "https://api.github.com/users/gabitza-tech/orgs",
"repos_url": "https://api.github.com/users/gabitza-tech/repos",
"events_url": "https://api.github.com/users/gabitza-tech/events{/privacy}",
"received_events_url": "https://api.github.com/users/gabitza-tech/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-09-28T15:13:07 | 2024-01-15T01:48:09 | 2024-01-15T01:48:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
I have run multiscale clustering diarization on some short audios (30s-60s) with either 1 or 2 speakers. They have a little noise in the background/music, but I wouldn't say it's a big SNR. However, each time the diarizer detects 8-10 speakers on these audios.
Unfortunately, I am not able to share the recordings, but do you happen to have any suggestions on tackling diarization on such short audios with noise?
I have tried to use `maj_vote_spk_count`=True, but I ran in another problem for other types of audios: when number of speakers is high (5-8 speakers), when maj_vote=True, it detects only 2-3 speakers..
This is the config I use:
```
# This YAML file is created for all types of offline speaker diarization inference tasks in `<NeMo git root>/example/speaker_tasks/diarization` folder.
# The inference parameters for VAD, speaker embedding extractor, clustering module, MSDD module, ASR decoder are all included in this YAML file.
# All the keys under `diarizer` key (`vad`, `speaker_embeddings`, `clustering`, `msdd_model`, `asr`) can be selectively used for its own purpose and also can be ignored if the module is not used.
# The configurations in this YAML file is suitable for 3~5 speakers participating in a meeting and may not show the best performance on other types of dialogues.
# An example line in an input manifest file (`.json` format):
# {"audio_filepath": "/path/to/audio_file", "offset": 0, "duration": null, "label": "infer", "text": "-", "num_speakers": null, "rttm_filepath": "/path/to/rttm/file", "uem_filepath": "/path/to/uem/file"}
name: &name "ClusterDiarizer"
config_name: "nemo_meet"
num_workers: 1
sample_rate: 16000
batch_size: 64
diarizer:
manifest_filepath: null # inainte era ???, acum il obtinem din prepare_data in zevo_clustering.py
out_dir: null # inainte era ???, acum il obtinem din prepare_data in zevo_clustering.py
oracle_vad: False # If True, uses RTTM files provided in the manifest file to get speech activity (VAD) timestamps
collar: 0.25 # Collar value for scoring
ignore_overlap: False # Consider or ignore overlap segments while scoring
vad:
model_path: 'nemo_models/vad_multilingual_marblenet.nemo' # .nemo local model path or pretrained VAD model name
external_vad_manifest: null # This option is provided to use external vad and provide its speech activity labels for speaker embeddings extraction. Only one of model_path or external_vad_manifest should be set
parameters: # Tuned parameters for CH109 (using the 11 multi-speaker sessions as dev set)
window_length_in_sec: 0.63 # Window length in sec for VAD context input
shift_length_in_sec: 0.08 # Shift length in sec for generate frame level VAD prediction
smoothing: False # False or type of smoothing method (eg: median)
overlap: 0.5 # Overlap ratio for overlapped mean/median smoothing filter
onset: 0.9 # Onset threshold for detecting the beginning and end of a speech
offset: 0.5 # Offset threshold for detecting the end of a speech
pad_onset: 0 # Adding durations before each speech segment
pad_offset: 0 # Adding durations after each speech segment
min_duration_on: 0.5 # Threshold for small speech deletion
min_duration_off: 0.6 # Threshold for short non_speech segment deletion
filter_speech_first: True
speaker_embeddings:
model_path: 'nemo_models/titanet-s.nemo' # .nemo local model path or pretrained model name (titanet_large, ecapa_tdnn or speakerverification_speakernet)
parameters:
window_length_in_sec: [3.5,3.0,2.5,2.0,1.5,1.0,0.5] # Window length(s) in sec (floating-point number). either a number or a list. ex) 1.5 or [1.5,1.0,0.5]
shift_length_in_sec: [1.75,1.5,1.25,1.0,0.75,0.5,0.25] # Shift length(s) in sec (floating-point number). either a number or a list. ex) 0.75 or [0.75,0.5,0.25]
multiscale_weights: [1,1,1,1,1,1,1] # Weight for each scale. should be null (for single scale) or a list matched with window/shift scale count. ex) [0.33,0.33,0.33]
save_embeddings: False # If True, save speaker embeddings in pickle format. This should be True if clustering result is used for other models, such as `msdd_model`.
clustering:
parameters:
oracle_num_speakers: True # If True, use num of speakers value provided in manifest file.
max_num_speakers: 12 # Note: maybe decrease back to 8; Max number of speakers for each recording. If an oracle number of speakers is passed, this value is ignored.
enhanced_count_thres: 80 # If the number of segments is lower than this number, enhanced speaker counting is activated.
max_rp_threshold: 0.25 # Determines the range of p-value search: 0 < p <= max_rp_threshold.
sparse_search_volume: 30 # The higher the number, the more values will be examined with more time.
maj_vote_spk_count: False # If True, take a majority vote on multiple p-values to estimate the number of speakers.
msdd_model:
model_path: null # .nemo local model path or pretrained model name for multiscale diarization decoder (MSDD)
parameters:
use_speaker_model_from_ckpt: True # If True, use speaker embedding model in checkpoint. If False, the provided speaker embedding model in config will be used.
infer_batch_size: 25 # Batch size for MSDD inference.
sigmoid_threshold: [0.7] # Sigmoid threshold for generating binarized speaker labels. The smaller the more generous on detecting overlaps.
seq_eval_mode: False # If True, use oracle number of speaker and evaluate F1 score for the given speaker sequences. Default is False.
split_infer: True # If True, break the input audio clip to short sequences and calculate cluster average embeddings for inference.
diar_window_length: 50 # The length of split short sequence when split_infer is True.
overlap_infer_spk_limit: 5 # If the estimated number of speakers are larger than this number, overlap speech is not estimated.
```
Thank you in advance!
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7558/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7558/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7557 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7557/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7557/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7557/events | https://github.com/NVIDIA/NeMo/pull/7557 | 1,917,744,755 | PR_kwDOC_bI7s5bdN7S | 7,557 | wording corrections | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-28T15:04:11 | 2023-10-26T01:44:17 | 2023-10-26T01:44:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7557",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7557",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7557.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7557.patch",
"merged_at": null
} | 1. Changed `sde_proxy_link` printing position
2. Changed some wording | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7557/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7557/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7556 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7556/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7556/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7556/events | https://github.com/NVIDIA/NeMo/pull/7556 | 1,917,707,522 | PR_kwDOC_bI7s5bdFuO | 7,556 | Some wording has been corrected | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-28T14:45:47 | 2023-09-28T14:54:28 | 2023-09-28T14:54:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7556",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7556",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7556.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7556.patch",
"merged_at": null
} | 1. Changed `sde_proxy_link` printing position
2. Changed some wording | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7556/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7556/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7555 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7555/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7555/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7555/events | https://github.com/NVIDIA/NeMo/pull/7555 | 1,916,992,146 | PR_kwDOC_bI7s5bam0R | 7,555 | Avoid duplicated dist checkpoint save | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T08:35:40 | 2023-09-28T22:07:27 | 2023-09-28T22:07:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7555",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7555",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7555.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7555.patch",
"merged_at": "2023-09-28T22:07:27"
} | # What does this PR do ?
This is a WAR for the case of saving a checkpoint twice into the same directory.
A proper fix would be avoiding calling the `save_checkpoint` method altogether.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Avoid duplicated dist checkpoint save
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7555/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7555/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7554 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7554/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7554/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7554/events | https://github.com/NVIDIA/NeMo/pull/7554 | 1,916,816,715 | PR_kwDOC_bI7s5baBDo | 7,554 | [TTS] remove curly braces from ${BRANCH} in jupyer notebook cell. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T06:41:47 | 2023-09-28T17:54:44 | 2023-09-28T17:54:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7554",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7554",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7554.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7554.patch",
"merged_at": "2023-09-28T17:54:43"
} | # What does this PR do ?
**Change 1**
In jupyter notebook, when trying to run,
```
## Install NeMo
BRANCH = 'r1.21.0'
!python -m pip install "git+https://github.com/NVIDIA/NeMo.git@${BRANCH}#egg=nemo_toolkit[all]"
```
It will get below errors due to `${BRANCH}`. Removing the curly braces fixes the error.
```shell
DEPRECATION: git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce this behaviour change. A possible replacement is to use the req @ url syntax, and remove the egg fragment. Discussion can be found at https://github.com/pypa/pip/issues/11617
Collecting nemo_toolkit[all]
Cloning https://github.com/NVIDIA/NeMo.git (to revision .21.0) to /tmp/pip-install-gzajrtok/nemo-toolkit_d9d14f8e02594d728021197cbfbd43ee
Running command git clone --filter=blob:none --quiet https://github.com/NVIDIA/NeMo.git /tmp/pip-install-gzajrtok/nemo-toolkit_d9d14f8e02594d728021197cbfbd43ee
WARNING: Did not find branch or tag '.21.0', assuming revision or ref.
Running command git checkout -q .21.0
error: pathspec '.21.0' did not match any file(s) known to git
error: subprocess-exited-with-error
× git checkout -q .21.0 did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× git checkout -q .21.0 did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
\nRemember to restart the runtime for the kernel to pick up any upgraded packages (e.g. matplotlib)!\nAlternatively, you can uncomment the exit() below to crash and restart the kernel, in the case\nthat you want to use the "Run All Cells" (or similar) option.\n
```
**Change 2**
remove pynini installation since it is now a dependency of nemo-text-processing lib.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7554/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7554/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7553 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7553/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7553/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7553/events | https://github.com/NVIDIA/NeMo/pull/7553 | 1,916,549,019 | PR_kwDOC_bI7s5bZHsQ | 7,553 | Update FFMPEG version to fix issue with torchaudio | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T00:59:43 | 2023-09-28T01:00:28 | 2023-09-28T01:00:27 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7553",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7553",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7553.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7553.patch",
"merged_at": "2023-09-28T01:00:27"
} | # What does this PR do ?
Fixes an issue with Torchaudio trying to load latest versions of ffmpeg (7+)
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7553/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7553/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7552 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7552/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7552/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7552/events | https://github.com/NVIDIA/NeMo/pull/7552 | 1,916,543,723 | PR_kwDOC_bI7s5bZGlD | 7,552 | Add LoRA support to MLP layers. | {
"login": "ertkonuk",
"id": 22161733,
"node_id": "MDQ6VXNlcjIyMTYxNzMz",
"avatar_url": "https://avatars.githubusercontent.com/u/22161733?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ertkonuk",
"html_url": "https://github.com/ertkonuk",
"followers_url": "https://api.github.com/users/ertkonuk/followers",
"following_url": "https://api.github.com/users/ertkonuk/following{/other_user}",
"gists_url": "https://api.github.com/users/ertkonuk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ertkonuk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ertkonuk/subscriptions",
"organizations_url": "https://api.github.com/users/ertkonuk/orgs",
"repos_url": "https://api.github.com/users/ertkonuk/repos",
"events_url": "https://api.github.com/users/ertkonuk/events{/privacy}",
"received_events_url": "https://api.github.com/users/ertkonuk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T00:51:06 | 2023-10-19T01:44:37 | 2023-10-19T01:44:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7552",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7552",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7552.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7552.patch",
"merged_at": null
} | # What does this PR do ?
Adds LoRA support to the linear transformations in the MLP layer.
**Collection**: [NLP]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* Add target_modules: ['attention', 'mlp'] to the lora_tuning field in the config file
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
@arendu
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7552/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7552/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7551 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7551/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7551/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7551/events | https://github.com/NVIDIA/NeMo/pull/7551 | 1,916,539,570 | PR_kwDOC_bI7s5bZFs0 | 7,551 | Update FFMPEG version to fix issue with torchaudio | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T00:43:49 | 2023-09-28T00:59:19 | 2023-09-28T00:59:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7551",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7551",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7551.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7551.patch",
"merged_at": "2023-09-28T00:59:18"
} | # What does this PR do ?
Fixes an issue with Torchaudio trying to load latest versions of ffmpeg (7+)
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7551/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7551/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7550 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7550/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7550/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7550/events | https://github.com/NVIDIA/NeMo/pull/7550 | 1,916,534,933 | PR_kwDOC_bI7s5bZEvG | 7,550 | Cherry pick Fix sft dataset truncation (#7464) to r1.21.0 | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T00:35:56 | 2023-09-28T16:42:30 | 2023-09-28T16:42:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7550",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7550",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7550.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7550.patch",
"merged_at": "2023-09-28T16:42:29"
} | # What does this PR do ?
Cherry pick fix from main into r1.21.0
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7550/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7550/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7549 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7549/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7549/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7549/events | https://github.com/NVIDIA/NeMo/pull/7549 | 1,916,516,863 | PR_kwDOC_bI7s5bZA2G | 7,549 | Append output of val_step to self.validation_step_outputs in EncMaskDecAudioToAudioModel | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T00:10:51 | 2023-10-23T18:25:09 | 2023-10-23T18:25:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7549",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7549",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7549.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7549.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7549/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7549/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7548 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7548/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7548/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7548/events | https://github.com/NVIDIA/NeMo/pull/7548 | 1,916,516,175 | PR_kwDOC_bI7s5bZAtF | 7,548 | [BugFix] Add missing quotes for auto strategy in tutorial notebooks | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-28T00:09:49 | 2023-10-02T16:55:09 | 2023-10-02T16:55:07 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7548",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7548",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7548.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7548.patch",
"merged_at": "2023-10-02T16:55:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7548/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7548/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7547 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7547/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7547/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7547/events | https://github.com/NVIDIA/NeMo/pull/7547 | 1,916,501,410 | PR_kwDOC_bI7s5bY9dh | 7,547 | Add rope pos emb in fp32 | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T23:54:58 | 2023-09-28T15:52:35 | 2023-09-28T15:52:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7547",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7547",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7547.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7547.patch",
"merged_at": "2023-09-28T15:52:33"
} | # What does this PR do ?
Support pure fp32 for rope pos embedding
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7547/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7547/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7546 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7546/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7546/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7546/events | https://github.com/NVIDIA/NeMo/pull/7546 | 1,916,473,436 | PR_kwDOC_bI7s5bY3SV | 7,546 | fix validation_step_outputs initialization for multi-dataloader | {
"login": "KunalDhawan",
"id": 15515031,
"node_id": "MDQ6VXNlcjE1NTE1MDMx",
"avatar_url": "https://avatars.githubusercontent.com/u/15515031?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KunalDhawan",
"html_url": "https://github.com/KunalDhawan",
"followers_url": "https://api.github.com/users/KunalDhawan/followers",
"following_url": "https://api.github.com/users/KunalDhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/KunalDhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/KunalDhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KunalDhawan/subscriptions",
"organizations_url": "https://api.github.com/users/KunalDhawan/orgs",
"repos_url": "https://api.github.com/users/KunalDhawan/repos",
"events_url": "https://api.github.com/users/KunalDhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/KunalDhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T23:22:20 | 2023-09-29T15:56:43 | 2023-09-29T15:56:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7546",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7546",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7546.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7546.patch",
"merged_at": "2023-09-29T15:56:41"
} | # What does this PR do ?
In tutorials/asr/Multilang_ASR.ipynb, added the correct initialization of asr_model.validation_step_outputs for the case of multiple dataloaders. This is in accordance with the changes introduced in https://github.com/NVIDIA/NeMo/pull/7533 and is normally taken care of by modelPT __init__ (https://github.com/NVIDIA/NeMo/blob/main/nemo/core/classes/modelPT.py#L185)
**Collection**:
ASR
# Changelog
In the section "Creating training / validation sets" of the notebook -
```python
asr_model.setup_multiple_validation_data(val_data_config=validation_ds)
# Correctly setting up validation_step_outputs for multi dataloader, orifinally taken care of in ModelPT.__init__()
if asr_model._validation_dl and type(asr_model._validation_dl) == list and len(asr_model._validation_dl) > 1:
for _ in range(len(asr_model._validation_dl)):
asr_model.validation_step_outputs.append([])
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "KunalDhawan",
"id": 15515031,
"node_id": "MDQ6VXNlcjE1NTE1MDMx",
"avatar_url": "https://avatars.githubusercontent.com/u/15515031?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KunalDhawan",
"html_url": "https://github.com/KunalDhawan",
"followers_url": "https://api.github.com/users/KunalDhawan/followers",
"following_url": "https://api.github.com/users/KunalDhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/KunalDhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/KunalDhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KunalDhawan/subscriptions",
"organizations_url": "https://api.github.com/users/KunalDhawan/orgs",
"repos_url": "https://api.github.com/users/KunalDhawan/repos",
"events_url": "https://api.github.com/users/KunalDhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/KunalDhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7546/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7546/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7545 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7545/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7545/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7545/events | https://github.com/NVIDIA/NeMo/pull/7545 | 1,916,150,143 | PR_kwDOC_bI7s5bXv3_ | 7,545 | gpus -> devices | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T18:59:35 | 2023-09-28T00:37:54 | 2023-09-28T00:37:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7545",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7545",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7545.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7545.patch",
"merged_at": "2023-09-28T00:37:53"
} | # What does this PR do ?
update gpus -> devices in notebook | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7545/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7545/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7544 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7544/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7544/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7544/events | https://github.com/NVIDIA/NeMo/issues/7544 | 1,916,120,875 | I_kwDOC_bI7s5yNa8r | 7,544 | AttributeError: type object 'MegatronGPTPromptLearningModel' has no attribute 'frozen_model' | {
"login": "csung7",
"id": 1879258,
"node_id": "MDQ6VXNlcjE4NzkyNTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/1879258?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/csung7",
"html_url": "https://github.com/csung7",
"followers_url": "https://api.github.com/users/csung7/followers",
"following_url": "https://api.github.com/users/csung7/following{/other_user}",
"gists_url": "https://api.github.com/users/csung7/gists{/gist_id}",
"starred_url": "https://api.github.com/users/csung7/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/csung7/subscriptions",
"organizations_url": "https://api.github.com/users/csung7/orgs",
"repos_url": "https://api.github.com/users/csung7/repos",
"events_url": "https://api.github.com/users/csung7/events{/privacy}",
"received_events_url": "https://api.github.com/users/csung7/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-27T18:38:11 | 2023-12-09T01:45:25 | 2023-12-09T01:45:24 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | from nemo.collections.nlp.models.language_modeling.megatron_gpt_prompt_learning_model import MegatronGPTPromptLearningModel
AttributeError: 'MegatronGPTPromptLearningModel' object has no attribute 'frozen_model'
https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/models/language_modeling/megatron_base_prompt_learning_model.py
```
def load_frozen_model(self, cfg, trainer):
pass
```
empty. Any idea? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7544/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7544/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7543 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7543/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7543/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7543/events | https://github.com/NVIDIA/NeMo/pull/7543 | 1,916,084,007 | PR_kwDOC_bI7s5bXh6s | 7,543 | Append output of val_step to self.validation_step_outputs in EncMaskDecAudioToAudioModel | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T18:12:08 | 2023-09-28T00:31:54 | 2023-09-28T00:10:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7543",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7543",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7543.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7543.patch",
"merged_at": "2023-09-28T00:10:24"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7543/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7543/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7542 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7542/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7542/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7542/events | https://github.com/NVIDIA/NeMo/pull/7542 | 1,916,062,286 | PR_kwDOC_bI7s5bXdKw | 7,542 | gpus -> devices | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T17:56:14 | 2023-09-27T18:59:07 | 2023-09-27T18:59:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7542",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7542",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7542.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7542.patch",
"merged_at": "2023-09-27T18:59:06"
} | # What does this PR do ?
update gpus -> devices in notebook | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7542/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7542/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7541 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7541/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7541/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7541/events | https://github.com/NVIDIA/NeMo/pull/7541 | 1,916,034,683 | PR_kwDOC_bI7s5bXXK5 | 7,541 | [BugFix] Add missing quotes for auto strategy in tutorial notebooks | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T17:35:18 | 2023-09-28T00:09:22 | 2023-09-28T00:09:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7541",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7541",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7541.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7541.patch",
"merged_at": "2023-09-28T00:09:21"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7541/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7541/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7540 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7540/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7540/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7540/events | https://github.com/NVIDIA/NeMo/pull/7540 | 1,915,836,474 | PR_kwDOC_bI7s5bWr95 | 7,540 | StarCoder SFT test + bump PyT NGC image to 23.09 | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T15:28:08 | 2023-10-02T20:43:55 | 2023-10-02T20:43:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7540",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7540",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7540.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7540.patch",
"merged_at": "2023-10-02T20:43:54"
} | # What does this PR do ?
Add SFT test for StarCoder MCore checkpoint.
**Collection**: NLP
# Changelog
- Editing Jenkinsfile
# Usage
* To be used in CI
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/7421
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7540/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7540/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7539 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7539/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7539/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7539/events | https://github.com/NVIDIA/NeMo/issues/7539 | 1,915,658,824 | I_kwDOC_bI7s5yLqJI | 7,539 | Issue with text normalization HUI German Dataset | {
"login": "ken2190",
"id": 79817296,
"node_id": "MDQ6VXNlcjc5ODE3Mjk2",
"avatar_url": "https://avatars.githubusercontent.com/u/79817296?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ken2190",
"html_url": "https://github.com/ken2190",
"followers_url": "https://api.github.com/users/ken2190/followers",
"following_url": "https://api.github.com/users/ken2190/following{/other_user}",
"gists_url": "https://api.github.com/users/ken2190/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ken2190/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ken2190/subscriptions",
"organizations_url": "https://api.github.com/users/ken2190/orgs",
"repos_url": "https://api.github.com/users/ken2190/repos",
"events_url": "https://api.github.com/users/ken2190/events{/privacy}",
"received_events_url": "https://api.github.com/users/ken2190/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-09-27T14:00:03 | 2023-09-28T05:09:16 | 2023-09-28T05:08:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I'm trying to processe text normalization for HUI German Dataset but i get error like below. Does anyone have idea to resolve this issue?
**Steps/Code to reproduce bug**
```
(nemo) ubuntu@HP:/mnt/e/tools/nemo$ python /mnt/e/tools/NeMo/get_data.py --data-root /mnt/f/hui_acg --manifests-root /mnt/f/hui_acg/ --normalize-text
[NeMo I 2023-09-27 13:31:45 get_data:105] Skipped downloading data because it exists: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/datasetStatisticClean.zip
[NeMo I 2023-09-27 13:31:45 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/datasetStatisticClean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:32:21 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/datasetStatisticClean.zip.
[NeMo I 2023-09-27 13:32:21 get_data:100] Downloading data: https://opendata.iisys.de/opendata/Datasets/HUI-Audio-Corpus-German/dataset_clean/Friedrich_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Friedrich_Clean.zip
[NeMo I 2023-09-27 13:32:21 get_data:105] Skipped downloading data because it exists: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Bernd_Ungerer_Clean.zip
[NeMo I 2023-09-27 13:32:21 get_data:105] Skipped downloading data because it exists: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Karlsson_Clean.zip
[NeMo I 2023-09-27 13:32:21 get_data:105] Skipped downloading data because it exists: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/others_Clean.zip
[NeMo I 2023-09-27 13:32:21 get_data:105] Skipped downloading data because it exists: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Eva_K_Clean.zip
[NeMo I 2023-09-27 13:32:21 get_data:105] Skipped downloading data because it exists: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Hokuspokus_Clean.zip
[NeMo I 2023-09-27 13:48:43 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Bernd_Ungerer_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:48:43 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Eva_K_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:48:43 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Friedrich_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:48:43 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Hokuspokus_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:48:43 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Karlsson_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:48:43 get_data:109] Unzipping data: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/others_Clean.zip --> /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean
[NeMo I 2023-09-27 13:55:58 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Eva_K_Clean.zip.
[NeMo I 2023-09-27 13:56:16 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Friedrich_Clean.zip.
[NeMo I 2023-09-27 13:57:41 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Hokuspokus_Clean.zip.
[NeMo I 2023-09-27 14:24:01 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Karlsson_Clean.zip.
[NeMo I 2023-09-27 14:44:50 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/others_Clean.zip.
[NeMo I 2023-09-27 14:55:32 get_data:111] Unzipping data is complete: /mnt/f/hui_acg/HUI-Audio-Corpus-German-clean/Bernd_Ungerer_Clean.zip.
[NeMo I 2023-09-27 14:55:32 get_data:263] Processing Speaker: Alexandra_Bogensperger
[NeMo I 2023-09-27 14:55:32 get_data:124] Preparing JSON split for speaker 1.
545it [00:00, 33618.58it/s]
[NeMo I 2023-09-27 14:55:32 get_data:161] Preparing JSON split for speaker 1 is complete.
[NeMo I 2023-09-27 14:55:32 get_data:263] Processing Speaker: Algy_Pug
[NeMo I 2023-09-27 14:55:32 get_data:124] Preparing JSON split for speaker 2.
141it [00:00, 33753.60it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 2 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: AliceDe
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 3.
4it [00:00, 6700.17it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 3 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Anastasiia_Solokha
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 4.
4it [00:00, 9714.66it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 4 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Anka
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 5.
471it [00:00, 30448.79it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 5 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Anna_Samrowski
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 6.
5it [00:00, 8859.96it/s]
[NeMo W 2023-09-27 14:55:33 get_data:158] Skipped speaker 6. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Anna_Simon
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 7.
19it [00:00, 20159.82it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 7 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Anne
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 8.
72it [00:00, 28945.64it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 8 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Antoinette_Huting
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 9.
55it [00:00, 25470.54it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 9 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Anton
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 10.
21it [00:00, 23227.95it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 10 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Apneia
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 11.
10it [00:00, 12136.30it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 11 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Availle
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 12.
532it [00:00, 29288.45it/s]
[NeMo I 2023-09-27 14:55:33 get_data:161] Preparing JSON split for speaker 12 is complete.
[NeMo I 2023-09-27 14:55:33 get_data:263] Processing Speaker: Bernd_Ungerer
[NeMo I 2023-09-27 14:55:33 get_data:124] Preparing JSON split for speaker 13.
32880it [00:01, 28967.69it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 13 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: Boris
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 14.
257it [00:00, 26216.31it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 14 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: Capybara
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 15.
383it [00:00, 35107.60it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 15 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: caromopfen
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 16.
856it [00:00, 31935.28it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 16 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: Cate_Mackenzie
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 17.
12it [00:00, 18497.48it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 17 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: Christian_Al-Kadi
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 18.
408it [00:00, 30715.92it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 18 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: Christina_Lindgruen
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 19.
16it [00:00, 23522.21it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 19 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: ClaudiaSterngucker
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 20.
323it [00:00, 25071.44it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 20 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: ColOhr
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 21.
93it [00:00, 25849.59it/s]
[NeMo I 2023-09-27 14:55:34 get_data:161] Preparing JSON split for speaker 21 is complete.
[NeMo I 2023-09-27 14:55:34 get_data:263] Processing Speaker: Crln_Yldz_Ksr
[NeMo I 2023-09-27 14:55:34 get_data:124] Preparing JSON split for speaker 22.
536it [00:00, 31930.28it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 22 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: DanielGrams
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 23.
29it [00:00, 25425.34it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 23 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: danio
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 24.
3it [00:00, 4822.89it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 24 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Desirée_Löffler
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 25.
18it [00:00, 21832.70it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 25 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Dini_Steyn
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 26.
2it [00:00, 3563.55it/s]
[NeMo W 2023-09-27 14:55:35 get_data:158] Skipped speaker 26. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Dirk_Weber
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 27.
137it [00:00, 26192.89it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 27 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: DomBombadil
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 28.
183it [00:00, 28871.83it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 28 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Eki_Teebi
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 29.
139it [00:00, 28998.17it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 29 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: ekyale
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 30.
224it [00:00, 28817.11it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 30 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Elli
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 31.
286it [00:00, 25192.60it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 31 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Eva_K
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 32.
8539it [00:00, 22756.44it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 32 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Fabian_Grant
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 33.
32it [00:00, 31018.66it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 33 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: fantaeiner
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 34.
200it [00:00, 31004.61it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 34 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Franziska_Paul
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 35.
60it [00:00, 28807.03it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 35 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: fremdschaemen
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 36.
28it [00:00, 30432.89it/s]
[NeMo I 2023-09-27 14:55:35 get_data:161] Preparing JSON split for speaker 36 is complete.
[NeMo I 2023-09-27 14:55:35 get_data:263] Processing Speaker: Friedrich
[NeMo I 2023-09-27 14:55:35 get_data:124] Preparing JSON split for speaker 37.
9590it [00:00, 31844.18it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 37 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Frown
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 38.
209it [00:00, 28455.81it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 38 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Gaby
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 39.
7it [00:00, 12671.61it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 39 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Gesine
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 40.
1it [00:00, 2270.87it/s]
[NeMo W 2023-09-27 14:55:36 get_data:158] Skipped speaker 40. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: heeheekitty
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 41.
81it [00:00, 25623.25it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 41 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Herman_Roskams
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 42.
70it [00:00, 26438.66it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 42 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Herr_Klugbeisser
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 43.
43it [00:00, 18635.57it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 43 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Hokuspokus
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 44.
10584it [00:00, 31652.75it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 44 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Igor_Teaforay
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 45.
215it [00:00, 29591.63it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 45 is complete.
[NeMo I 2023-09-27 14:55:36 get_data:263] Processing Speaker: Imke_Grassl
[NeMo I 2023-09-27 14:55:36 get_data:124] Preparing JSON split for speaker 46.
136it [00:00, 21508.44it/s]
[NeMo I 2023-09-27 14:55:36 get_data:161] Preparing JSON split for speaker 46 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Ingo_Breuer
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 47.
114it [00:00, 23795.69it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 47 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: IvanDean
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 48.
32it [00:00, 26854.29it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 48 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Jessi
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 49.
305it [00:00, 28271.00it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 49 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Joe_Kay
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 50.
35it [00:00, 18842.34it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 50 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: josimosi98
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 51.
6it [00:00, 12912.17it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 51 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Julia_Niedermaier
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 52.
2012it [00:00, 29746.73it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 52 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Kaktus
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 53.
4it [00:00, 5797.24it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 53 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Kalynda
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 54.
394it [00:00, 22042.89it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 54 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Kanta
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 55.
3it [00:00, 5003.15it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 55 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Kara_Shallenberg
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 56.
52it [00:00, 26223.86it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 56 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: KarinM
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 57.
307it [00:00, 20873.95it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 57 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Karlsson
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 58.
10736it [00:00, 30896.67it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 58 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: keltoi
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 59.
860it [00:00, 26357.30it/s]
[NeMo I 2023-09-27 14:55:37 get_data:161] Preparing JSON split for speaker 59 is complete.
[NeMo I 2023-09-27 14:55:37 get_data:263] Processing Speaker: Klaus_Beutelspacher
[NeMo I 2023-09-27 14:55:37 get_data:124] Preparing JSON split for speaker 60.
12it [00:00, 16496.77it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 60 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Klaus_Neubauer
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 61.
758it [00:00, 28217.40it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 61 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Knubbel
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 62.
3it [00:00, 5182.42it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 62 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Laila_Katinka
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 63.
1it [00:00, 1679.06it/s]
[NeMo W 2023-09-27 14:55:38 get_data:158] Skipped speaker 63. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Larry_Greene
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 64.
16it [00:00, 15705.33it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 64 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Lars_Rolander_(1942-2016)
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 65.
745it [00:00, 28759.04it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 65 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Lektor
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 66.
3it [00:00, 6801.57it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 66 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: leserchen
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 67.
65it [00:00, 27876.25it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 67 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: LillY
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 68.
7it [00:00, 11829.22it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 68 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: lorda
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 69.
195it [00:00, 28319.29it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 69 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: LordOider
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 70.
21it [00:00, 9642.08it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 70 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: LyricalWB
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 71.
479it [00:00, 25347.54it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 71 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: manuwolf
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 72.
9it [00:00, 14485.32it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 72 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: marham63
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 73.
1877it [00:00, 32591.92it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 73 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Markus_Wachenheim
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 74.
91it [00:00, 23905.90it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 74 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Martin_Harbecke
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 75.
102it [00:00, 22139.26it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 75 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Mat
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 76.
1it [00:00, 2383.13it/s]
[NeMo W 2023-09-27 14:55:38 get_data:158] Skipped speaker 76. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Matze
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 77.
65it [00:00, 17870.33it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 77 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: melaniesandra
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 78.
24it [00:00, 23481.06it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 78 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: merendo07
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 79.
10it [00:00, 15851.49it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 79 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: mindfulheart
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 80.
3it [00:00, 6253.93it/s]
[NeMo W 2023-09-27 14:55:38 get_data:158] Skipped speaker 80. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: Monika_M._C
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 81.
326it [00:00, 31313.68it/s]
[NeMo I 2023-09-27 14:55:38 get_data:161] Preparing JSON split for speaker 81 is complete.
[NeMo I 2023-09-27 14:55:38 get_data:263] Processing Speaker: njall
[NeMo I 2023-09-27 14:55:38 get_data:124] Preparing JSON split for speaker 82.
5it [00:00, 7492.50it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 82 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: noonday
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 83.
1it [00:00, 1560.96it/s]
[NeMo W 2023-09-27 14:55:39 get_data:158] Skipped speaker 83. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Ohrbuch
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 84.
663it [00:00, 27358.73it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 84 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: OldZach
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 85.
125it [00:00, 19049.09it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 85 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Orsina
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 86.
6it [00:00, 8425.12it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 86 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: PeWaOt
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 87.
231it [00:00, 19847.27it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 87 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Ragnar
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 88.
330it [00:00, 16557.06it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 88 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Rainer
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 89.
94it [00:00, 23163.42it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 89 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Ralf
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 90.
1it [00:00, 2559.06it/s]
[NeMo W 2023-09-27 14:55:39 get_data:158] Skipped speaker 90. Not enough data for train, val and test.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Ramona_Deininger-Schnabel
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 91.
1482it [00:00, 28377.02it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 91 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Rebecca_Braunert-Plunkett
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 92.
667it [00:00, 27243.96it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 92 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: RenateIngrid
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 93.
1274it [00:00, 27668.83it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 93 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Rhigma
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 94.
108it [00:00, 21351.10it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 94 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Robert_Steiner
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 95.
212it [00:00, 24120.23it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 95 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Rogthey
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 96.
960it [00:00, 25748.05it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 96 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Sandra_Schmit
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 97.
95it [00:00, 26779.95it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 97 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Sascha
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 98.
5it [00:00, 9035.55it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 98 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: schrm
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 99.
385it [00:00, 28601.41it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 99 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Sebastian
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 100.
125it [00:00, 29896.11it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 100 is complete.
[NeMo I 2023-09-27 14:55:39 get_data:263] Processing Speaker: Sellafield
[NeMo I 2023-09-27 14:55:39 get_data:124] Preparing JSON split for speaker 101.
10it [00:00, 15905.59it/s]
[NeMo I 2023-09-27 14:55:39 get_data:161] Preparing JSON split for speaker 101 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Shanty
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 102.
28it [00:00, 27242.06it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 102 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Silke_Britz
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 103.
45it [00:00, 21924.00it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 103 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Silmaryllis
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 104.
336it [00:00, 14878.76it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 104 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Sonia
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 105.
473it [00:00, 30093.38it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 105 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Sonja
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 106.
130it [00:00, 23313.64it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 106 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: storylines
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 107.
21it [00:00, 26804.74it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 107 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Tabea
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 108.
13it [00:00, 18958.95it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 108 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Tanja_Ben_Jeroud
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 109.
105it [00:00, 24909.61it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 109 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: thinkofelephants
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 110.
6it [00:00, 9935.19it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 110 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Traxxo
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 111.
96it [00:00, 26051.58it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 111 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Ute2013
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 112.
64it [00:00, 21387.58it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 112 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Verena
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 113.
58it [00:00, 21884.64it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 113 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Victoria_Asztaller
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 114.
165it [00:00, 29841.76it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 114 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Wolfgang
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 115.
60it [00:00, 26302.07it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 115 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Zach_K
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 116.
18it [00:00, 24020.83it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 116 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Zieraffe
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 117.
33it [00:00, 18107.28it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 117 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:263] Processing Speaker: Zue_Von_Zob
[NeMo I 2023-09-27 14:55:40 get_data:124] Preparing JSON split for speaker 118.
11it [00:00, 13261.67it/s]
[NeMo I 2023-09-27 14:55:40 get_data:161] Preparing JSON split for speaker 118 is complete.
[NeMo I 2023-09-27 14:55:40 get_data:298] Saving Speaker to ID mapping to /mnt/f/hui_acg/spk2id.csv.
[NeMo I 2023-09-27 14:55:40 get_data:115] Saving JSON split to /mnt/f/hui_acg/train_manifest.json.
[NeMo I 2023-09-27 14:55:42 get_data:115] Saving JSON split to /mnt/f/hui_acg/val_manifest.json.
[NeMo I 2023-09-27 14:55:42 get_data:115] Saving JSON split to /mnt/f/hui_acg/test_manifest.json.
[NeMo I 2023-09-27 14:56:17 get_data:196] Normalizing text for /mnt/f/hui_acg/train_manifest.json.
10%|███████▌ | 8692/86811 [28:47<7:53:04, 2.75it/s]joblib.externals.loky.process_executor._RemoteTraceback:
"""
Traceback (most recent call last):
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/_parallel_backends.py", line 273, in _wrap_func_call
return func()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 588, in __call__
return [func(*args, **kwargs)
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 588, in <listcomp>
return [func(*args, **kwargs)
File "/mnt/e/tools/NeMo/get_data.py", line 192, in add_normalized_text
normalized_text = normalizer_call(line_dict["text"])
File "/mnt/e/tools/NeMo/get_data.py", line 189, in normalizer_call
return text_normalizer.normalize(x, **text_normalizer_call_kwargs)
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/normalize.py", line 328, in normalize
tokens = self.parser.parse()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/token_parser.py", line 53, in parse
token = self.parse_token()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/token_parser.py", line 76, in parse_token
value = self.parse_token_value()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/token_parser.py", line 98, in parse_token_value
list_token_dicts = self.parse()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/token_parser.py", line 53, in parse
token = self.parse_token()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/token_parser.py", line 67, in parse_token
key = self.parse_string_key()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo_text_processing/text_normalization/token_parser.py", line 141, in parse_string_key
assert self.char not in string.whitespace and self.char != EOS
AssertionError
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/mnt/e/tools/NeMo/get_data.py", line 316, in <module>
main()
File "/mnt/e/tools/NeMo/get_data.py", line 310, in main
__text_normalization(train_json, args.num_workers)
File "/mnt/e/tools/NeMo/get_data.py", line 201, in __text_normalization
dict_list = Parallel(n_jobs=num_workers, backend="threading")(
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 1944, in __call__
return output if self.return_generator else list(output)
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 1587, in _get_outputs
yield from self._retrieve()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 1691, in _retrieve
self._raise_error_fast()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 1726, in _raise_error_fast
error_job.get_result(self.timeout)
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 735, in get_result
return self._return_or_raise()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/joblib/parallel.py", line 753, in _return_or_raise
raise self._result
AssertionError
10%|███████▋ | 8735/86811 [28:50<4:17:48, 5.05it/s]
```
**Environment overview**
- Environment location: [Local]
- Method of NeMo install: [from source].
**Environment details**
- OS version: Window 10, WSL Ubuntu-20.04
- PyTorch version: Pytorch-cuda 11.8
- Python version: Python 3.10
**Additional context**
GPU model: RTX3090
| {
"login": "ken2190",
"id": 79817296,
"node_id": "MDQ6VXNlcjc5ODE3Mjk2",
"avatar_url": "https://avatars.githubusercontent.com/u/79817296?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ken2190",
"html_url": "https://github.com/ken2190",
"followers_url": "https://api.github.com/users/ken2190/followers",
"following_url": "https://api.github.com/users/ken2190/following{/other_user}",
"gists_url": "https://api.github.com/users/ken2190/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ken2190/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ken2190/subscriptions",
"organizations_url": "https://api.github.com/users/ken2190/orgs",
"repos_url": "https://api.github.com/users/ken2190/repos",
"events_url": "https://api.github.com/users/ken2190/events{/privacy}",
"received_events_url": "https://api.github.com/users/ken2190/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7539/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7539/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/7538 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7538/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7538/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7538/events | https://github.com/NVIDIA/NeMo/pull/7538 | 1,915,502,380 | PR_kwDOC_bI7s5bVigL | 7,538 | Create per.py | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T12:42:35 | 2023-10-07T01:51:12 | 2023-10-07T01:51:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7538",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7538",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7538.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7538.patch",
"merged_at": "2023-10-07T01:51:12"
} | Script for calculation Punctuation Error Rate and related rates (correct rate, deletions rate, etc.)
@karpnv @ekmb @vsl9 @KunalDhawan | {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7538/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7538/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7537 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7537/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7537/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7537/events | https://github.com/NVIDIA/NeMo/pull/7537 | 1,915,294,155 | PR_kwDOC_bI7s5bUzfM | 7,537 | ZH-EN Multilingual/Code-switching ASR tutorials | {
"login": "wd929",
"id": 20455986,
"node_id": "MDQ6VXNlcjIwNDU1OTg2",
"avatar_url": "https://avatars.githubusercontent.com/u/20455986?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wd929",
"html_url": "https://github.com/wd929",
"followers_url": "https://api.github.com/users/wd929/followers",
"following_url": "https://api.github.com/users/wd929/following{/other_user}",
"gists_url": "https://api.github.com/users/wd929/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wd929/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wd929/subscriptions",
"organizations_url": "https://api.github.com/users/wd929/orgs",
"repos_url": "https://api.github.com/users/wd929/repos",
"events_url": "https://api.github.com/users/wd929/events{/privacy}",
"received_events_url": "https://api.github.com/users/wd929/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T11:07:36 | 2023-11-10T01:45:08 | 2023-11-10T01:45:08 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7537",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7537",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7537.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7537.patch",
"merged_at": null
} | # What does this PR do ?
This PR adds the tutorials for Mandarin-English Multilingual/Code-switching ASR training.
**Collection**: [ASR]
# Changelog
- Add a tutorial for ZH-EN multilingual/code-switching training
- How to prepare data, change tokenizer and finetune with pre-trained ZH-EN model etc
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7537/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7537/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7536 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7536/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7536/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7536/events | https://github.com/NVIDIA/NeMo/pull/7536 | 1,915,049,224 | PR_kwDOC_bI7s5bUDde | 7,536 | Remap speakers to continuous range of speaker_id for dataset AISHELL3 | {
"login": "RobinDong",
"id": 1953397,
"node_id": "MDQ6VXNlcjE5NTMzOTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/1953397?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RobinDong",
"html_url": "https://github.com/RobinDong",
"followers_url": "https://api.github.com/users/RobinDong/followers",
"following_url": "https://api.github.com/users/RobinDong/following{/other_user}",
"gists_url": "https://api.github.com/users/RobinDong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RobinDong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RobinDong/subscriptions",
"organizations_url": "https://api.github.com/users/RobinDong/orgs",
"repos_url": "https://api.github.com/users/RobinDong/repos",
"events_url": "https://api.github.com/users/RobinDong/events{/privacy}",
"received_events_url": "https://api.github.com/users/RobinDong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T09:08:27 | 2023-09-29T16:57:59 | 2023-09-29T16:57:58 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7536",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7536",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7536.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7536.patch",
"merged_at": "2023-09-29T16:57:58"
} | # What does this PR do ?
Remap discrete speakers of AISHELL3 (like SSB0005, SSB0009 etc.) to continuous range of speaker_id (from 1 to 174)
# Changelog
- Remap speakers to a continuous range of speaker_id for dataset AISHELL3
# Usage
```python
from nemo.collections.tts.models.base import SpectrogramGenerator, Vocoder
from nemo.collections.tts.models import FastPitchModel, HifiGanModel
text = "这些新一代的中央处理器不只效能惊人，价格也十分有竞争力。"
device = "cpu"
fastpitch_model = FastPitchModel.restore_from("~/Downloads/aishell3.nemo").eval().to(device)
model = HifiGanModel.from_pretrained(model_name="tts_zh_hifigan_sfspeech").eval().to(device)
# Normalize the text and convert it into individual phonemes/tokens.
tokens = fastpitch_model.parse(text)
# Generate spectrogram from text
spectrogram = fastpitch_model.generate_spectrogram(tokens=tokens, speaker=1)
# Invert the spectrogram into audio samples
audio = model.convert_spectrogram_to_audio(spec=spectrogram)
# Convert output from pytorch tensor to numpy array
audio = audio.cpu().detach().numpy()
import soundfile as sf
sf.write("sample.wav", audio.T, 22050, format="WAV")
```
Sample with `speaker=1` [001.zip](https://github.com/NVIDIA/NeMo/files/12736697/001.zip)
Sample with `speaker=100` [100.zip](https://github.com/NVIDIA/NeMo/files/12736729/100.zip)
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
@XuesongYang
# Additional Information
* https://github.com/NVIDIA/NeMo/pull/7409#discussion_r1336613673
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7536/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7536/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7535 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7535/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7535/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7535/events | https://github.com/NVIDIA/NeMo/pull/7535 | 1,914,985,458 | PR_kwDOC_bI7s5bT1n8 | 7,535 | unpin setuptools | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-27T08:30:46 | 2023-09-27T11:56:54 | 2023-09-27T11:56:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7535",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7535",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7535.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7535.patch",
"merged_at": "2023-09-27T11:56:53"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7535/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7535/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7534 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7534/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7534/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7534/events | https://github.com/NVIDIA/NeMo/pull/7534 | 1,914,898,953 | PR_kwDOC_bI7s5bTirI | 7,534 | unpin setuptools | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-27T07:42:29 | 2023-09-27T08:30:19 | 2023-09-27T08:30:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7534",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7534",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7534.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7534.patch",
"merged_at": "2023-09-27T08:30:18"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7534/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7534/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7533 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7533/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7533/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7533/events | https://github.com/NVIDIA/NeMo/pull/7533 | 1,914,876,160 | PR_kwDOC_bI7s5bTdrf | 7,533 | Fix PTL2.0 related ASR bugs in r1.21.0: Val metrics logging, None dataloader issue | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T07:28:48 | 2023-09-27T21:45:18 | 2023-09-27T21:45:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7533",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7533",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7533.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7533.patch",
"merged_at": "2023-09-27T21:45:17"
} | # What does this PR do ?
This PR added fixes for PTL2.0 related ASR bugs in r1.21.0: Val metrics logging, None dataloader issue
**Collection**:
ASR, Core
# Changelog
- val_dataloader() and test_dataloader() functions in nemo/core/classes/modelPT.py updated to handle cases where dataloader is None
- updated validation_pass(), validation_step(), test_step() in nemo/collections/asr/models/rnnt_models.py to correctly add metrics to validation_step_outputs, test_step_outputs. This is following the updates to ctc_models and hybrid_rnnt_ctc_models as done in [Upgrade to pytorch lightning 2.0](https://github.com/NVIDIA/NeMo/pull/6433/files#top)
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "KunalDhawan",
"id": 15515031,
"node_id": "MDQ6VXNlcjE1NTE1MDMx",
"avatar_url": "https://avatars.githubusercontent.com/u/15515031?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KunalDhawan",
"html_url": "https://github.com/KunalDhawan",
"followers_url": "https://api.github.com/users/KunalDhawan/followers",
"following_url": "https://api.github.com/users/KunalDhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/KunalDhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/KunalDhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KunalDhawan/subscriptions",
"organizations_url": "https://api.github.com/users/KunalDhawan/orgs",
"repos_url": "https://api.github.com/users/KunalDhawan/repos",
"events_url": "https://api.github.com/users/KunalDhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/KunalDhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7533/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7533/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7532 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7532/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7532/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7532/events | https://github.com/NVIDIA/NeMo/pull/7532 | 1,914,632,032 | PR_kwDOC_bI7s5bSoj2 | 7,532 | Append val output to self.validation_step_outputs in GLUEModel | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T03:42:31 | 2023-09-29T19:31:22 | 2023-09-29T19:31:21 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7532",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7532",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7532.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7532.patch",
"merged_at": "2023-09-29T19:31:21"
} | # What does this PR do ?
Appends the output of `validation_step` in `GLUEModel` to the instance variable `self.validation_step_outputs` as expected by PTL 2.0.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7532/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7532/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7531 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7531/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7531/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7531/events | https://github.com/NVIDIA/NeMo/pull/7531 | 1,914,464,126 | PR_kwDOC_bI7s5bSE2y | 7,531 | Fix PTL2.0 related ASR bugs in r1.21.0: Val metrics logging, None dataloader issue | {
"login": "KunalDhawan",
"id": 15515031,
"node_id": "MDQ6VXNlcjE1NTE1MDMx",
"avatar_url": "https://avatars.githubusercontent.com/u/15515031?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KunalDhawan",
"html_url": "https://github.com/KunalDhawan",
"followers_url": "https://api.github.com/users/KunalDhawan/followers",
"following_url": "https://api.github.com/users/KunalDhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/KunalDhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/KunalDhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KunalDhawan/subscriptions",
"organizations_url": "https://api.github.com/users/KunalDhawan/orgs",
"repos_url": "https://api.github.com/users/KunalDhawan/repos",
"events_url": "https://api.github.com/users/KunalDhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/KunalDhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T00:11:18 | 2023-09-27T07:28:18 | 2023-09-27T07:28:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7531",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7531",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7531.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7531.patch",
"merged_at": "2023-09-27T07:28:17"
} | # What does this PR do ?
This PR added fixes for PTL2.0 related ASR bugs in r1.21.0: Val metrics logging, None dataloader issue
**Collection**:
ASR, Core
# Changelog
- val_dataloader() and test_dataloader() functions in nemo/core/classes/modelPT.py updated to handle cases where dataloader is None
- updated validation_pass(), validation_step(), test_step() in nemo/collections/asr/models/rnnt_models.py to correctly add metrics to validation_step_outputs, test_step_outputs. This is following the updates to ctc_models and hybrid_rnnt_ctc_models as done in [Upgrade to pytorch lightning 2.0](https://github.com/NVIDIA/NeMo/pull/6433/files#top)
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "KunalDhawan",
"id": 15515031,
"node_id": "MDQ6VXNlcjE1NTE1MDMx",
"avatar_url": "https://avatars.githubusercontent.com/u/15515031?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KunalDhawan",
"html_url": "https://github.com/KunalDhawan",
"followers_url": "https://api.github.com/users/KunalDhawan/followers",
"following_url": "https://api.github.com/users/KunalDhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/KunalDhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/KunalDhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KunalDhawan/subscriptions",
"organizations_url": "https://api.github.com/users/KunalDhawan/orgs",
"repos_url": "https://api.github.com/users/KunalDhawan/repos",
"events_url": "https://api.github.com/users/KunalDhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/KunalDhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7531/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7531/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7530 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7530/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7530/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7530/events | https://github.com/NVIDIA/NeMo/pull/7530 | 1,914,460,352 | PR_kwDOC_bI7s5bSEDR | 7,530 | Append val output to self.validation_step_outputs in GLUEModel | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-27T00:05:59 | 2023-09-27T03:42:03 | 2023-09-27T03:42:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7530",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7530",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7530.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7530.patch",
"merged_at": "2023-09-27T03:42:02"
} | # What does this PR do ?
Appends the output of `validation_step` in `GLUEModel` to the instance variable `self.validation_step_outputs` as expected by PTL 2.0.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7530/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7530/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7529 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7529/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7529/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7529/events | https://github.com/NVIDIA/NeMo/pull/7529 | 1,914,427,425 | PR_kwDOC_bI7s5bR9BX | 7,529 | Fix branch version for SDE | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-09-26T23:17:02 | 2023-10-11T18:01:56 | 2023-10-11T18:01:56 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7529",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7529",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7529.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7529.patch",
"merged_at": null
} | # What does this PR do ?
Fixes branch selection for tutorial
**Collection**: [Tools]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7529/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7529/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7528 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7528/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7528/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7528/events | https://github.com/NVIDIA/NeMo/pull/7528 | 1,914,426,206 | PR_kwDOC_bI7s5bR8wG | 7,528 | Fix branch version for SDE | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-09-26T23:15:08 | 2023-09-26T23:16:37 | 2023-09-26T23:16:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7528",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7528",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7528.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7528.patch",
"merged_at": "2023-09-26T23:16:36"
} | # What does this PR do ?
Fixes branch selection for tutorial
**Collection**: [Tools]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7528/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7528/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7527 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7527/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7527/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7527/events | https://github.com/NVIDIA/NeMo/pull/7527 | 1,914,391,145 | PR_kwDOC_bI7s5bR1J0 | 7,527 | Replace strategy = None with strategy = auto for notebooks | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-09-26T22:29:21 | 2023-09-27T06:13:40 | 2023-09-27T06:13:39 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/7527",
"html_url": "https://github.com/NVIDIA/NeMo/pull/7527",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/7527.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/7527.patch",
"merged_at": "2023-09-27T06:13:39"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7527/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7527/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/7526 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/7526/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/7526/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/7526/events | https://github.com/NVIDIA/NeMo/issues/7526 | 1,914,376,624 | I_kwDOC_bI7s5yGxGw | 7,526 | KeyError for T5 Text Normalization with latest transformers version | {
"login": "murali1996",
"id": 30381152,
"node_id": "MDQ6VXNlcjMwMzgxMTUy",
"avatar_url": "https://avatars.githubusercontent.com/u/30381152?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/murali1996",
"html_url": "https://github.com/murali1996",
"followers_url": "https://api.github.com/users/murali1996/followers",
"following_url": "https://api.github.com/users/murali1996/following{/other_user}",
"gists_url": "https://api.github.com/users/murali1996/gists{/gist_id}",
"starred_url": "https://api.github.com/users/murali1996/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/murali1996/subscriptions",
"organizations_url": "https://api.github.com/users/murali1996/orgs",
"repos_url": "https://api.github.com/users/murali1996/repos",
"events_url": "https://api.github.com/users/murali1996/events{/privacy}",
"received_events_url": "https://api.github.com/users/murali1996/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4910680898,
"node_id": "LA_kwDOC_bI7s8AAAABJLMLQg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TN/ITN",
"name": "TN/ITN",
"color": "0052cc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-09-26T22:12:24 | 2023-11-03T02:16:01 | 2023-11-03T02:16:01 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Following the installation guide in README installs the latest transformers version. However the starter code provided here https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/neural_text_normalization_t5 fails to work with an error
```
RuntimeError: Error(s) in loading state_dict for DuplexTaggerModel:
Unexpected key(s) in state_dict: "model.albert.embeddings.position_ids".
```
**Steps/Code to reproduce bug**
[Same as in description above]
**Expected behavior**
RuntimeError in this line
```
tagger = nemo_nlp.models.duplex_text_normalization.DuplexTaggerModel.from_pretrained(model_name="neural_text_normalization_t5")
```
---
One solution that worked in my case is to re-install an earlier version of transformers, eg. 4.30.2
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/7526/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/7526/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.