url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/6427 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6427/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6427/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6427/events | https://github.com/NVIDIA/NeMo/pull/6427 | 1,667,379,715 | PR_kwDOC_bI7s5OSDyX | 6,427 | fix CPU overheads of GPT synthetic dataset | {
"login": "xrennvidia",
"id": 103958965,
"node_id": "U_kgDOBjJJtQ",
"avatar_url": "https://avatars.githubusercontent.com/u/103958965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xrennvidia",
"html_url": "https://github.com/xrennvidia",
"followers_url": "https://api.github.com/users/xrennvidia/followers",
"following_url": "https://api.github.com/users/xrennvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/xrennvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xrennvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xrennvidia/subscriptions",
"organizations_url": "https://api.github.com/users/xrennvidia/orgs",
"repos_url": "https://api.github.com/users/xrennvidia/repos",
"events_url": "https://api.github.com/users/xrennvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/xrennvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-14T01:43:49 | 2023-04-25T17:18:42 | 2023-04-14T05:49:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6427",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6427",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6427.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6427.patch",
"merged_at": "2023-04-14T05:49:30"
} | # What does this PR do ?
Move mask and position id generation in GPT synthetic dataset to __init__. They are same for each data loading, so doing it for every data loading is redundant, it also can create big CPU overheads while seq_len is long. Hence, move them to __init__.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6427/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6427/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6426 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6426/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6426/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6426/events | https://github.com/NVIDIA/NeMo/pull/6426 | 1,667,276,769 | PR_kwDOC_bI7s5ORuSK | 6,426 | Added/updated new Conformer configs | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T23:30:26 | 2023-04-20T22:03:14 | 2023-04-20T22:03:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6426",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6426",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6426.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6426.patch",
"merged_at": "2023-04-20T22:03:13"
} | # What does this PR do ?
Added some new configurations and updated some of the older configuration files for Conformer models.
# Changelog
- Added configs for cache-aware fastconformer and hybrid ASR.
- Added more info on batch size and precision suggestions in the configs.
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6426/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6426/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6425 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6425/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6425/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6425/events | https://github.com/NVIDIA/NeMo/pull/6425 | 1,666,784,777 | PR_kwDOC_bI7s5OQEgF | 6,425 | Add Frame-VAD | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T16:57:23 | 2023-04-18T14:49:25 | 2023-04-18T14:48:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6425",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6425",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6425.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6425.patch",
"merged_at": null
} | # What does this PR do ?
Add Frame-VAD, including related datasets and models for multi-label audio classification. Also, ASR+VAD pipeline is updated to use Frame-VAD, and support for dropping frames instead of masking is added.
**Collection**: [ASR]
# Changelog
- Frame-VAD:
- Model: `nemo.collections.asr.models.classification_models.EncDecFrameClassificationModel`
- Dataset:
- `nemo.collections.asr.datasets.audio_to_label.AudioToMultiLabelDataset`
- `nemo.collections.asr.datasets.audio_to_label.TarredAudioToMultiLabelDataset`
- `nemo.collections.asr.datasets.audio_to_label_dataset.get_audio_multi_label_dataset`
- `nemo.collections.asr.datasets.audio_to_label_dataset.get_tarred_audio_multi_label_dataset`
- Utils: `nemo.collections.asr.parts.utils.vad_utils.py`
- Example:
- `examples/asr/speech_classifications/speech_to_frame_label.py`
- `examples/asr/speech_classifications/frame_vad_infer.py`
- `examples/asr/conf/marblenet/marblenet_3x2x64_20ms.yaml`
- ASR+VAD:
- Example:
- `examples/asr_vad/speech_to_text_with_frame_vad.py`
- Datasets:
- `nemo/collections/asr/data/feature_to_text.py`
- `nemo/collections/asr/data/feature_to_label.py`
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests? [Todo in next PR]
- [ ] Did you add or update any necessary documentation? [Todo in next PR]
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6425/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6425/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6424 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6424/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6424/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6424/events | https://github.com/NVIDIA/NeMo/pull/6424 | 1,666,664,049 | PR_kwDOC_bI7s5OPqc6 | 6,424 | add rampup batch size support for Megatron GPT | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T15:36:17 | 2023-04-20T17:30:56 | 2023-04-20T17:30:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6424",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6424",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6424.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6424.patch",
"merged_at": "2023-04-20T17:30:55"
} | # What does this PR do ?
This PR adds ramp up batch size support for GPT models. It allows to increase the batch size up to global batch size linearly during training in a given number of samples.
**Collection**: NLP
# Changelog
- Add rampup_batch_size value to the training config.
- Input rampup_batch_size to the apex microbatch_calculator.
- Add current global_batch_size value to the progress bar when using rampup_batch_size.
- Update the apex microbatch_calculator after each training step.
# Usage
Can be set via config or CLI.
**Config:**
```python
rampup_batch_size: [8, 4, 10000] # Should be a list of 3 values: [<start_batch_size>, <batch_size_increment>, <rampup_samples>]
```
**CLI:**
```python
model.rampup_batch_size=[8,4,10000]
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6424/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6424/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6423 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6423/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6423/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6423/events | https://github.com/NVIDIA/NeMo/pull/6423 | 1,665,714,474 | PR_kwDOC_bI7s5OMeo0 | 6,423 | fixing the ability to use temp sampling with concat datasets | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T05:02:20 | 2023-04-14T04:28:36 | 2023-04-14T04:28:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6423",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6423",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6423.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6423.patch",
"merged_at": "2023-04-14T04:28:35"
} | # What does this PR do ?
fixing the ability to use temp sampling with concat datasets
**Collection**: ASR
# Changelog
In `audio_to_text_dataset.py` check for sampling probabilities only if the sampling technique is random
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6423/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6423/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6422 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6422/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6422/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6422/events | https://github.com/NVIDIA/NeMo/pull/6422 | 1,665,555,587 | PR_kwDOC_bI7s5OL8_p | 6,422 | Cache and reuse inputs when no reset | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T02:04:15 | 2023-12-09T05:50:50 | 2023-04-19T04:50:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6422",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6422",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6422.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6422.patch",
"merged_at": "2023-04-19T04:50:48"
} | # What does this PR do ?
Cache inputs (attention mask, loss mask, and position ids) and reuse.
This mitigates CPU-side overhead.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6422/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6422/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6421 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6421/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6421/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6421/events | https://github.com/NVIDIA/NeMo/pull/6421 | 1,665,503,392 | PR_kwDOC_bI7s5OLxeN | 6,421 | exceptions with empty test / val ds config sections | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-13T01:14:59 | 2023-04-13T01:34:04 | 2023-04-13T01:34:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6421",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6421",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6421.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6421.patch",
"merged_at": "2023-04-13T01:34:03"
} | # What does this PR do ?
Resolves exceptions when trying to train with empty test/ val ds config sections
**Collection**: ASR
# Changelog
In `nemo/utils/model_utils.py` check if ds_values has values in it before trying to assign names to entries within. These names would have become visible in the test / validation sections of experiment manager (e.g. wandb) - but if these sections are emptty, there is no need to try.
# Usage
* You can potentially add a usage example below
```python
# should no longer fail:
python asr_transducer/speech_to_text_rnnt_bpe.py --config-path=../conf/contextnet_rnnt/ --config-name=config_rnnt_bpe.yaml model.tokenizer.dir=data/tokenizer/tokenizer_bpe_v1024/ model.tokenizer.type="bpe" model.train_ds.manifest_filepath=data/LibriSpeech/train_clean_100.json model.train_ds.batch_size=32 model.joint.fuse_loss_wer=true model.joint.fused_batch_size=8 model.decoding.greedy.max_symbols=5 ~model.validation_ds +accelerator="gpu" +strategy="ddp" +devices=4 trainer.max_epochs=1 exp_manager.checkpoint_callback_params.monitor="train_loss" "
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to bug 4067510
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6421/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6421/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6420 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6420/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6420/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6420/events | https://github.com/NVIDIA/NeMo/pull/6420 | 1,665,488,263 | PR_kwDOC_bI7s5OLuKe | 6,420 | Bug 4067510 | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T00:58:55 | 2023-04-13T01:06:30 | 2023-04-13T00:59:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6420",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6420",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6420.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6420.patch",
"merged_at": null
} | # What does this PR do ?
fixes exceptions when running with empty test /val ds sections
**Collection**: ASR
# Changelog
in `/nemo/utils/model_utils.py`, check if len(ds_values) > 0 before trying to assign dataset names
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6420/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6420/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6419 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6419/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6419/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6419/events | https://github.com/NVIDIA/NeMo/pull/6419 | 1,665,475,015 | PR_kwDOC_bI7s5OLrNW | 6,419 | Refactor PP conversion + add support for TP only conversion | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-13T00:47:50 | 2023-04-14T01:29:28 | 2023-04-14T01:29:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6419",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6419",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6419.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6419.patch",
"merged_at": "2023-04-14T01:29:24"
} | # What does this PR do ?
Updates the TP PP conversion script to support TP only conversion (back ported from NeMo 1.16)
Refactor PP conversion mechanism.
**Collection**: [NLP]
# Changelog
- Refactor components to functions, split apart TP and PP conversion components
- Refactor PP conversion to model specific classes for PP conversion support
- Backport TP only conversion support (irrespective of whether PP conversion is supported or not)
# Usage
```python
python megatron_change_num_partitions.py \
--model_file="ckpt/megatron_gpt_model.nemo" \
--target_file="ckpt/megatron_gpt_model_tp2_pp1.nemo" \
--tensor_model_parallel_size=1 \
--target_tensor_model_parallel_size=2 \
--pipeline_model_parallel_size=1 \
--target_pipeline_model_parallel_size=1 \
--tp_conversion_only
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6419/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6419/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6417 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6417/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6417/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6417/events | https://github.com/NVIDIA/NeMo/pull/6417 | 1,663,837,408 | PR_kwDOC_bI7s5OGJJG | 6,417 | [TTS] FastPitch speaker encoder | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-12T05:37:39 | 2023-04-18T02:19:16 | 2023-04-18T02:19:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6417",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6417",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6417.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6417.patch",
"merged_at": "2023-04-18T02:19:15"
} | # What does this PR do ?
Adds FastPitch speaker encoder with reference audio and reference speaker embedding
**Collection**: TTS
# Changelog
- Adds multi-speaker FastPitch pre-training with 1) Speaker verification model speaker embedding (reference speaker embedding) and 2) Global Style Tokens (reference audio)
- `nemo/collections/tts/data/tts_dataset.py`
- `nemo/collections/tts/torch/tts_data_types.py`
- `nemo/collections/tts/models/fastpitch.py`
- `nemo/collections/tts/modules/fastpitch.py`
- `nemo/collections/tts/modules/submodules.py`
- Modified config and fine-tuning python script
- `examples/tts/conf/fastpitch_speaker_adaptation.yaml`
- `examples/tts/fastpitch_finetune_adapters.py`
# Usage
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6417/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6417/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6416 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6416/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6416/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6416/events | https://github.com/NVIDIA/NeMo/pull/6416 | 1,663,833,259 | PR_kwDOC_bI7s5OGIO5 | 6,416 | [TTS] FastPitch adapter fine-tune and conditional layer normalization | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-12T05:34:31 | 2023-04-17T16:45:52 | 2023-04-17T16:45:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6416",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6416",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6416.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6416.patch",
"merged_at": "2023-04-17T16:45:51"
} | # What does this PR do ?
Adds FastPitch pre-training with CLNs and fine-tuning with adapters.
**Collection**: TTS
# Changelog
- Adds multi-speaker FastPitch pre-training with Conditional Layer Normalization
- `nemo/collections/tts/modules/fastpitch.py`
- `nemo/collections/tts/modules/transformer.py`
- `nemo/collections/tts/modules/submodules.py`
- Add adapter modules for FastPitch fine-tuning
- `nemo/collections/tts/models/fastpitch.py`
- `nemo/collections/tts/modules/fastpitch.py`
- `nemo/collections/tts/modules/transformer.py`
- `nemo/collections/tts/modules/aligner.py`
- `nemo/collections/tts/parts/mixins/__init__.py`
- `nemo/collections/tts/parts/mixins/fastpitch_adapter_mixins.py`
- Add config and fine-tuning python script
- `examples/tts/conf/fastpitch_speaker_adaptation.yaml`
- `examples/tts/fastpitch_finetune_adapters.py`
- Fix aligner `nan` loss bug
- `nemo/collections/tts/losses/aligner_loss.py`
# Usage
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6416/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6416/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6413 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6413/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6413/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6413/events | https://github.com/NVIDIA/NeMo/pull/6413 | 1,663,146,864 | PR_kwDOC_bI7s5ODxaM | 6,413 | Fix FastConformer config: correct bucketing strategy | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-11T20:12:28 | 2023-04-12T07:53:50 | 2023-04-11T21:31:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6413",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6413",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6413.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6413.patch",
"merged_at": "2023-04-11T21:31:12"
} | # What does this PR do ?
Fix typo in bucketing strategy in FastConformer configs.
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6413/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6413/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6412 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6412/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6412/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6412/events | https://github.com/NVIDIA/NeMo/pull/6412 | 1,663,039,228 | PR_kwDOC_bI7s5ODaGT | 6,412 | [TTS] whitelist broken path fix. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-11T18:52:13 | 2023-04-17T23:12:50 | 2023-04-17T23:12:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6412",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6412",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6412.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6412.patch",
"merged_at": "2023-04-17T23:12:46"
} | # What does this PR do ?
fixed broken file path.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue): https://github.com/NVIDIA/NeMo/issues/6408
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6412/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6412/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6411 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6411/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6411/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6411/events | https://github.com/NVIDIA/NeMo/pull/6411 | 1,663,012,482 | PR_kwDOC_bI7s5ODUiC | 6,411 | update container info in readme | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-11T18:30:44 | 2023-11-03T20:37:16 | 2023-05-04T01:50:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6411",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6411",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6411.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6411.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6411/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6411/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6410 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6410/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6410/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6410/events | https://github.com/NVIDIA/NeMo/issues/6410 | 1,662,958,019 | I_kwDOC_bI7s5jHrnD | 6,410 | Is MoE implemented correctly? | {
"login": "njb-ms",
"id": 111463040,
"node_id": "U_kgDOBqTKgA",
"avatar_url": "https://avatars.githubusercontent.com/u/111463040?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/njb-ms",
"html_url": "https://github.com/njb-ms",
"followers_url": "https://api.github.com/users/njb-ms/followers",
"following_url": "https://api.github.com/users/njb-ms/following{/other_user}",
"gists_url": "https://api.github.com/users/njb-ms/gists{/gist_id}",
"starred_url": "https://api.github.com/users/njb-ms/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/njb-ms/subscriptions",
"organizations_url": "https://api.github.com/users/njb-ms/orgs",
"repos_url": "https://api.github.com/users/njb-ms/repos",
"events_url": "https://api.github.com/users/njb-ms/events{/privacy}",
"received_events_url": "https://api.github.com/users/njb-ms/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-04-11T17:46:36 | 2023-05-23T22:31:39 | 2023-05-10T18:59:39 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | MoE FFNs are supposed to be sharded between GPUs. It seems like the current MoE implementation puts all FFNs on each GPU. See e.g. `https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/modules/common/megatron/mlp.py#L321`. Am I missing something here? | {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6410/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6410/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6409 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6409/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6409/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6409/events | https://github.com/NVIDIA/NeMo/pull/6409 | 1,662,774,223 | PR_kwDOC_bI7s5OChX4 | 6,409 | Fix the GPT SFT datasets loss mask bug | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-11T15:40:31 | 2023-04-11T17:42:52 | 2023-04-11T17:42:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6409",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6409",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6409.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6409.patch",
"merged_at": "2023-04-11T17:42:50"
} | # What does this PR do ?
Currently the mask position is off by 1. The first token in the label is not included in the loss calculation. | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6409/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6409/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6408 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6408/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6408/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6408/events | https://github.com/NVIDIA/NeMo/issues/6408 | 1,662,676,418 | I_kwDOC_bI7s5jGm3C | 6,408 | file does not exist in TTS get_data.py | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-04-11T14:53:17 | 2023-05-16T04:21:23 | 2023-05-16T04:21:23 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | https://github.com/NVIDIA/NeMo/blob/main/scripts/dataset_processing/tts/ljspeech/get_data.py#L59
does not exist and needs to be updated. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6408/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6408/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6406 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6406/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6406/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6406/events | https://github.com/NVIDIA/NeMo/issues/6406 | 1,661,705,141 | I_kwDOC_bI7s5jC5u1 | 6,406 | Config `share_embeddings_and_output_weights` does not work. | {
"login": "flymark2010",
"id": 8042816,
"node_id": "MDQ6VXNlcjgwNDI4MTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/8042816?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/flymark2010",
"html_url": "https://github.com/flymark2010",
"followers_url": "https://api.github.com/users/flymark2010/followers",
"following_url": "https://api.github.com/users/flymark2010/following{/other_user}",
"gists_url": "https://api.github.com/users/flymark2010/gists{/gist_id}",
"starred_url": "https://api.github.com/users/flymark2010/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/flymark2010/subscriptions",
"organizations_url": "https://api.github.com/users/flymark2010/orgs",
"repos_url": "https://api.github.com/users/flymark2010/repos",
"events_url": "https://api.github.com/users/flymark2010/events{/privacy}",
"received_events_url": "https://api.github.com/users/flymark2010/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-11T03:19:24 | 2023-05-19T01:52:58 | 2023-05-19T01:52:58 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
The code [here](https://github.com/NVIDIA/NeMo/blob/ecc116c29a14534abfe393f6eee4339b24ca6e57/nemo/collections/nlp/modules/common/megatron/module.py#L262) init the super class [MegatronModule](https://github.com/NVIDIA/NeMo/blob/ecc116c29a14534abfe393f6eee4339b24ca6e57/nemo/collections/nlp/modules/common/megatron/module.py#L46) with default parameter `share_token_embeddings=True`, so the attribute `share_embeddings_and_output_weights` of the input `module` parameter will never be used in `Float16Module`. Is that a bug or designed? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6406/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6406/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6405 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6405/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6405/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6405/events | https://github.com/NVIDIA/NeMo/pull/6405 | 1,661,199,927 | PR_kwDOC_bI7s5N9NHR | 6,405 | Update hyperparameter recommendation based on experiments | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-10T18:56:35 | 2023-04-13T01:13:27 | 2023-04-13T01:13:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6405",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6405",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6405.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6405.patch",
"merged_at": "2023-04-13T01:13:26"
} | # What does this PR do ?
Update hyperparameter recommendation based on experiments
**Collection**: tools
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6405/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6405/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6404 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6404/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6404/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6404/events | https://github.com/NVIDIA/NeMo/pull/6404 | 1,661,198,691 | PR_kwDOC_bI7s5N9M2L | 6,404 | Add semi sorted sampler. | {
"login": "fedorovgv",
"id": 50668534,
"node_id": "MDQ6VXNlcjUwNjY4NTM0",
"avatar_url": "https://avatars.githubusercontent.com/u/50668534?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fedorovgv",
"html_url": "https://github.com/fedorovgv",
"followers_url": "https://api.github.com/users/fedorovgv/followers",
"following_url": "https://api.github.com/users/fedorovgv/following{/other_user}",
"gists_url": "https://api.github.com/users/fedorovgv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fedorovgv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fedorovgv/subscriptions",
"organizations_url": "https://api.github.com/users/fedorovgv/orgs",
"repos_url": "https://api.github.com/users/fedorovgv/repos",
"events_url": "https://api.github.com/users/fedorovgv/events{/privacy}",
"received_events_url": "https://api.github.com/users/fedorovgv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-10T18:55:21 | 2023-05-05T01:48:25 | 2023-05-05T01:48:25 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6404",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6404",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6404.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6404.patch",
"merged_at": null
} | # What does this PR do ?
Helps to speed up ASR models training without quality degradation.
**Collection**: ASR, Core
# Changelog
- Adds a semi sorted batch sampler and its prepare function to a new file (in the future it might be some other samplers or new techniques like dynamic batching):
`nemo/collections/asr/parts/utils/asr_batching.py`
- Added changes to the data loader preparation function in the following model classes:
`nemo/collections/asr/models/ctc_models.py`
`nemo/collections/asr/models/rnnt_bpe_models.py`
- Adds changes to the scheduler prepare function because the batch sampler is passed to the dataloader as a sampler and we need to parse the batch size from it.
`nemo/core/optim/lr_scheduler.py`
- Adds a change to the `__getitem__` dataset method, as the batch sampler becomes an iterator and returns a list of indices instead of a single index.
`nemo/collections/asr/data/audio_to_text.py`
# Usage
The sampler is currently added to the following models:
* `nemo.collections.asr.models.EncDecCTCModel`
* `nemo.collections.asr.models.EncDecCTCModelBPE`
* `nemo.collections.asr.models.EncDecRNNTModel`
* `nemo.collections.asr.models.EncDecRNNTBPEModel`
Needs just to add one line in config.
```bash
++config.model.train_ds.use_semi_sorted_batching=true
```
and two line if we want to specify randomization factor (see more in additional information).
```bash
++config.model.train_ds.randomization_factor=0.1
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Semi Sorted Batching, was proposed in "Speed up training with variable length inputs by efficient batching strategies.", Zhenhao Ge et al. (2021).
* **Idea**: let's sort the samples by their duration, after adding pseudo noise to them, and then sample the batches from the sorted list. This way we avoid strict sorting and keep some level of randomness.
* Experiment for Conformer RNNT BPE:
* Experiment setup
The config is used from the [example configs](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/conf/conformer/conformer_transducer_bpe.yaml) with overridden parameters of ` trainer.epochs=50`, `trainer.devices=8` after the divergence of the first experiment `model.optim.lr=1.0`. For the train data LibriSpeech clean 100 and train clean 360, as well as for the test data, LibriSpeech test clean was used. For data processing, a BPE with a dictionary size of 512 was used.
* first experiment
<img src="https://github.com/fedorovgv/asr_ckpt/blob/main/step_1.png?raw=true" width="500" height="250">
<img src="https://github.com/fedorovgv/asr_ckpt/blob/main/wer_1.png?raw=true" width="500" height="250">
* second experiment
<img src="https://github.com/fedorovgv/asr_ckpt/blob/main/step_2.png?raw=true" width="500" height="250">
<img src="https://github.com/fedorovgv/asr_ckpt/blob/main/wer_2.png?raw=true" width="500" height="250">
* Interesting, that in the first experiment, the training of the model broke up without ssb.
* In the second experiment, after reducing the learning rate (from default 5.0 to 1.0), it can be seen that the ssb model converges without quality degradation to ~4.4 WER in the first 50k steps and at **17.5%** faster in time.
* In paper experiments, it was shown that with further training, the quality of training improves compared to the model without sbb for the same number of epochs with decreasing time. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6404/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6404/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6403 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6403/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6403/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6403/events | https://github.com/NVIDIA/NeMo/pull/6403 | 1,661,165,779 | PR_kwDOC_bI7s5N9F6C | 6,403 | Add documentation for preemption support | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-10T18:23:17 | 2023-04-10T18:28:36 | 2023-04-10T18:28:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6403",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6403",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6403.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6403.patch",
"merged_at": "2023-04-10T18:28:35"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Adds documentation for preemption support.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6403/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6403/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6402 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6402/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6402/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6402/events | https://github.com/NVIDIA/NeMo/issues/6402 | 1,660,942,314 | I_kwDOC_bI7s5i__fq | 6,402 | Logprob for stt_conformer_transducer_large | {
"login": "efyphil",
"id": 38631588,
"node_id": "MDQ6VXNlcjM4NjMxNTg4",
"avatar_url": "https://avatars.githubusercontent.com/u/38631588?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/efyphil",
"html_url": "https://github.com/efyphil",
"followers_url": "https://api.github.com/users/efyphil/followers",
"following_url": "https://api.github.com/users/efyphil/following{/other_user}",
"gists_url": "https://api.github.com/users/efyphil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/efyphil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/efyphil/subscriptions",
"organizations_url": "https://api.github.com/users/efyphil/orgs",
"repos_url": "https://api.github.com/users/efyphil/repos",
"events_url": "https://api.github.com/users/efyphil/events{/privacy}",
"received_events_url": "https://api.github.com/users/efyphil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-04-10T15:20:02 | 2023-04-10T16:57:07 | 2023-04-10T16:57:07 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The Quartz model uses [logprobs](https://colab.research.google.com/github/NVIDIA/NeMo/blob/stable/tutorials/asr/Offline_ASR.ipynb#scrollTo=ZhWmR7lbvwSm) , which are very helpful in assessing how well speech is spoken. They make it possible to construct a spectrogram, but it is inferior to the model stt_conformer_transducer_large. Is it possible to get log samples or something similar for this model? Maybe I don't know something and there are other ways to get probabilities for tokens in this model?Thanks in advance for the answer | {
"login": "efyphil",
"id": 38631588,
"node_id": "MDQ6VXNlcjM4NjMxNTg4",
"avatar_url": "https://avatars.githubusercontent.com/u/38631588?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/efyphil",
"html_url": "https://github.com/efyphil",
"followers_url": "https://api.github.com/users/efyphil/followers",
"following_url": "https://api.github.com/users/efyphil/following{/other_user}",
"gists_url": "https://api.github.com/users/efyphil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/efyphil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/efyphil/subscriptions",
"organizations_url": "https://api.github.com/users/efyphil/orgs",
"repos_url": "https://api.github.com/users/efyphil/repos",
"events_url": "https://api.github.com/users/efyphil/events{/privacy}",
"received_events_url": "https://api.github.com/users/efyphil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6402/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6402/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6401 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6401/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6401/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6401/events | https://github.com/NVIDIA/NeMo/issues/6401 | 1,660,783,372 | I_kwDOC_bI7s5i_YsM | 6,401 | Process finished with exit code 139 (interrupted by signal 11: SIGSEGV) while trying to import from nemo.collections.asr.models import EncDecCTCModelBPE | {
"login": "martavkhrk",
"id": 43974784,
"node_id": "MDQ6VXNlcjQzOTc0Nzg0",
"avatar_url": "https://avatars.githubusercontent.com/u/43974784?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/martavkhrk",
"html_url": "https://github.com/martavkhrk",
"followers_url": "https://api.github.com/users/martavkhrk/followers",
"following_url": "https://api.github.com/users/martavkhrk/following{/other_user}",
"gists_url": "https://api.github.com/users/martavkhrk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/martavkhrk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martavkhrk/subscriptions",
"organizations_url": "https://api.github.com/users/martavkhrk/orgs",
"repos_url": "https://api.github.com/users/martavkhrk/repos",
"events_url": "https://api.github.com/users/martavkhrk/events{/privacy}",
"received_events_url": "https://api.github.com/users/martavkhrk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-04-10T13:24:24 | 2023-04-10T13:44:20 | 2023-04-10T13:44:20 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **I get an "Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)" when I trying to import nemo.collections.asr**
I would like to use NeMo model, but have an error Process finished with exit code 139 (interrupted by signal 11: SIGSEGV) at the asr importing step.
from nemo.collections.asr.models import EncDecCTCModelBPE
file_name = 'audio_test.wav'
model = EncDecCTCModelBPE.from_pretrained(model_name="stt_en_conformer_ctc_large_ls")
transcribed = model.transcribe(paths2audio_files=file_name, batch_size=1, logprobs=False)
Can successfully import nemo, collections, but asr causes this error.
How can I fix this problem?
| {
"login": "martavkhrk",
"id": 43974784,
"node_id": "MDQ6VXNlcjQzOTc0Nzg0",
"avatar_url": "https://avatars.githubusercontent.com/u/43974784?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/martavkhrk",
"html_url": "https://github.com/martavkhrk",
"followers_url": "https://api.github.com/users/martavkhrk/followers",
"following_url": "https://api.github.com/users/martavkhrk/following{/other_user}",
"gists_url": "https://api.github.com/users/martavkhrk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/martavkhrk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martavkhrk/subscriptions",
"organizations_url": "https://api.github.com/users/martavkhrk/orgs",
"repos_url": "https://api.github.com/users/martavkhrk/repos",
"events_url": "https://api.github.com/users/martavkhrk/events{/privacy}",
"received_events_url": "https://api.github.com/users/martavkhrk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6401/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6401/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6400 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6400/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6400/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6400/events | https://github.com/NVIDIA/NeMo/pull/6400 | 1,660,452,017 | PR_kwDOC_bI7s5N6sGI | 6,400 | remove gc collect bottleneck code | {
"login": "limdongjin",
"id": 30315743,
"node_id": "MDQ6VXNlcjMwMzE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/30315743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/limdongjin",
"html_url": "https://github.com/limdongjin",
"followers_url": "https://api.github.com/users/limdongjin/followers",
"following_url": "https://api.github.com/users/limdongjin/following{/other_user}",
"gists_url": "https://api.github.com/users/limdongjin/gists{/gist_id}",
"starred_url": "https://api.github.com/users/limdongjin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/limdongjin/subscriptions",
"organizations_url": "https://api.github.com/users/limdongjin/orgs",
"repos_url": "https://api.github.com/users/limdongjin/repos",
"events_url": "https://api.github.com/users/limdongjin/events{/privacy}",
"received_events_url": "https://api.github.com/users/limdongjin/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-10T08:39:33 | 2023-05-03T01:51:18 | 2023-05-03T01:51:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6400",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6400",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6400.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6400.patch",
"merged_at": null
} | # What does this PR do ?
Remove bottleneck code in `perform_clustering` function
**Collection**: [ASR]
# Changelog
- remove `gc.collect()` code since it makes too slow.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6400/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6400/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6399 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6399/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6399/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6399/events | https://github.com/NVIDIA/NeMo/pull/6399 | 1,660,084,532 | PR_kwDOC_bI7s5N5eEe | 6,399 | Fix prompt template unescaping | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-10T01:18:07 | 2023-04-10T17:04:53 | 2023-04-10T17:04:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6399",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6399",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6399.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6399.patch",
"merged_at": "2023-04-10T17:04:52"
} | # What does this PR do ?
Unescape the prompt template to allow providing escape sequences in the prompt template from the CLI.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6399/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6399/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6398 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6398/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6398/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6398/events | https://github.com/NVIDIA/NeMo/issues/6398 | 1,659,979,993 | I_kwDOC_bI7s5i8UjZ | 6,398 | Inconsistent documentation? | {
"login": "nilsjohanbjorck",
"id": 19216884,
"node_id": "MDQ6VXNlcjE5MjE2ODg0",
"avatar_url": "https://avatars.githubusercontent.com/u/19216884?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nilsjohanbjorck",
"html_url": "https://github.com/nilsjohanbjorck",
"followers_url": "https://api.github.com/users/nilsjohanbjorck/followers",
"following_url": "https://api.github.com/users/nilsjohanbjorck/following{/other_user}",
"gists_url": "https://api.github.com/users/nilsjohanbjorck/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nilsjohanbjorck/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nilsjohanbjorck/subscriptions",
"organizations_url": "https://api.github.com/users/nilsjohanbjorck/orgs",
"repos_url": "https://api.github.com/users/nilsjohanbjorck/repos",
"events_url": "https://api.github.com/users/nilsjohanbjorck/events{/privacy}",
"received_events_url": "https://api.github.com/users/nilsjohanbjorck/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-09T19:34:57 | 2023-05-19T01:53:01 | 2023-05-19T01:53:01 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The documentation at [https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/nemo_megatron/parallelisms.html] states that
`NeMo Megatron supports 4 types of parallelisms (can be mixed together arbitraritly)`
The documentation at [https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/megatron.html#model-parallelism] states that
`Currently, NeMo only supports tensor model parallelism.`
This seems inconsistent. What kind of parallelisms are supported for training and eval? Thanks! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6398/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6398/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6396 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6396/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6396/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6396/events | https://github.com/NVIDIA/NeMo/issues/6396 | 1,659,551,403 | I_kwDOC_bI7s5i6r6r | 6,396 | GPT Training process hangs during sanity checking dataloader with TP=2, PP=2 and bias=false | {
"login": "hiyijian",
"id": 4326958,
"node_id": "MDQ6VXNlcjQzMjY5NTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4326958?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hiyijian",
"html_url": "https://github.com/hiyijian",
"followers_url": "https://api.github.com/users/hiyijian/followers",
"following_url": "https://api.github.com/users/hiyijian/following{/other_user}",
"gists_url": "https://api.github.com/users/hiyijian/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hiyijian/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hiyijian/subscriptions",
"organizations_url": "https://api.github.com/users/hiyijian/orgs",
"repos_url": "https://api.github.com/users/hiyijian/repos",
"events_url": "https://api.github.com/users/hiyijian/events{/privacy}",
"received_events_url": "https://api.github.com/users/hiyijian/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-08T15:10:08 | 2024-05-17T18:45:18 | 2023-09-19T01:44:39 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
With TP=2 ,PP=2 and model.bias=false, GPT Training process hangs during dataloader sanity checking
**Steps/Code to reproduce bug**
Clone r1.15.0 realese branch and then run the offical GPT pretrain example with my trivial modification
```shell
git clone https://github.com/NVIDIA/NeMo.git
cd Nemo
git branch r1.15.0
bash reinstall.sh
cd examples/nlp/language_modeling
bash train.sh
```
Below is the content of train.sh:
```shell
MASTER_ADDR=${MASTER_ADDR:-"127.0.0.1"}
MASTER_PORT=29503
NUM_NODES=1
NODE_RANK=0
GPUS_PER_NODE=8
DATA_PREFIX="[1.0,/data/pretrain/openwebtext2/hfbpe_gpt_training_data_text_document]"
torchrun --nnodes ${NUM_NODES} --nproc_per_node ${GPUS_PER_NODE} \
--master_addr ${MASTER_ADDR} --master_port ${MASTER_PORT} --node_rank ${NODE_RANK} \
./megatron_gpt_pretraining.py \
--config-name=megatron_gpt_config.yaml \
trainer.devices=${GPUS_PER_NODE} \
trainer.num_nodes=${NUM_NODES} \
model.data.data_prefix=${DATA_PREFIX} \
model.tensor_model_parallel_size=2 \
model.pipeline_model_parallel_size=2 \
+model.bias=false \
model.bias_activation_fusion=false \
model.bias_dropout_add_fusion=false \
```
As we can see, the modification here is just:
- disable all the bias item of linear layer in GPT model
- diabale bias related CUDA kernal fusion, as we do not need bias yet
The program hangs during dataloader sanity checking at very early stage of training.
It is OK if I turn on the bias and the related kernal fusion, or if I set PP=1
Logically, there should be no relevance between bias and pipeline. So I think it is an unexpected behaviour.
**Expected behavior**
It is expected that NeMo is able to train very large model without any bias term in pipeline parallel mode, such as LLama-65B.
**Environment overview (please complete the following information)**
- Environment location: Docker
- Method of NeMo install: `bash reinstall.sh`
- If method of install is [Docker], provide `docker pull nvcr.io/nvidia/nemo:23.01 ` & `docker run --shm-size 64g --network=host -v ${HOME}:${HOME} -v ${DATAROOT}:/data -it nvcr.io/nvidia/nemo:23.01 bash` commands used
```[tasklist]
``` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6396/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6396/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6395 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6395/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6395/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6395/events | https://github.com/NVIDIA/NeMo/pull/6395 | 1,659,201,018 | PR_kwDOC_bI7s5N26hI | 6,395 | Sharded manifests for tarred datasets | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-07T21:01:54 | 2023-04-18T17:03:24 | 2023-04-18T17:03:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6395",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6395",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6395.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6395.patch",
"merged_at": "2023-04-18T17:03:23"
} | # What does this PR do ?
Helps accelerate manifest loading via optional manifest sharding. This should speed up the loading of large manifests and reduce memory footprint - each worker loads just the shards that it needs.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
Use the same notation for manifests as for tarred audio files. There should be a 1:1 correspondence between a sharded audio tar file and a manifest file. The defer_setup flag must be set, otherwise torch.distributed will not be initialized during manifest processing and we will not be able to determine the dataloader length across all loaded manifest shards.
```
model.train_ds.tarred_audio_filepaths='audio__OP_0..511_CL_.tar'
model.train_ds.manifest_filepath='manifest__OP_0..511_CL_.json'
+model.train_ds.shard_manifests=true
+model.train_ds.defer_setup=true
```
# when generating the tarred manifest, do:
```python
python convert_to_tarred_audio_dataset.py \
--manifest_path=<path to the manifest file> \
--target_dir=<path to output directory> \
--num_shards=<number of tarfiles that will contain the audio> \
--max_duration=<float representing maximum duration of audio samples> \
--min_duration=<float representing minimum duration of audio samples> \
--shuffle --shuffle_seed=1 \
--sort_in_shards \
--shard_manifests \
--workers=-1
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6395/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6395/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6394 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6394/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6394/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6394/events | https://github.com/NVIDIA/NeMo/pull/6394 | 1,659,198,654 | PR_kwDOC_bI7s5N26AK | 6,394 | add back ptuning pp2 test | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-07T20:59:34 | 2023-06-08T20:49:01 | 2023-06-08T20:49:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6394",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6394",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6394.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6394.patch",
"merged_at": "2023-06-08T20:49:00"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6394/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6394/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6393 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6393/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6393/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6393/events | https://github.com/NVIDIA/NeMo/pull/6393 | 1,658,947,823 | PR_kwDOC_bI7s5N2GO5 | 6,393 | Move Parallelism usage from Apex -> Megatron Core | {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-07T15:50:45 | 2023-04-13T16:43:00 | 2023-04-13T16:42:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6393",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6393",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6393.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6393.patch",
"merged_at": "2023-04-13T16:42:58"
} | # What does this PR do ?
This PR moves model parallelism in NeMo to use Megatron-core instead of Apex.
* All models use dataloader_iter in train and eval step (except eval for T5 p-tuning)
* All pre-training models that use a constant sequence length sample based on microbatches
* All downstream tasks - p-tuning, adapter etc - that depend on dynamic seq len use global batch based sampling
We still use Apex for microbatch calculator, some enums/utils [both to be soon shifted to core], LayerNorm/other things with kernel
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6393/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6393/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6392 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6392/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6392/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6392/events | https://github.com/NVIDIA/NeMo/pull/6392 | 1,658,353,054 | PR_kwDOC_bI7s5N0NB6 | 6,392 | remove gc bottleneck code | {
"login": "limdongjin",
"id": 30315743,
"node_id": "MDQ6VXNlcjMwMzE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/30315743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/limdongjin",
"html_url": "https://github.com/limdongjin",
"followers_url": "https://api.github.com/users/limdongjin/followers",
"following_url": "https://api.github.com/users/limdongjin/following{/other_user}",
"gists_url": "https://api.github.com/users/limdongjin/gists{/gist_id}",
"starred_url": "https://api.github.com/users/limdongjin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/limdongjin/subscriptions",
"organizations_url": "https://api.github.com/users/limdongjin/orgs",
"repos_url": "https://api.github.com/users/limdongjin/repos",
"events_url": "https://api.github.com/users/limdongjin/events{/privacy}",
"received_events_url": "https://api.github.com/users/limdongjin/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-07T04:39:16 | 2023-04-10T08:40:28 | 2023-04-10T08:31:24 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6392",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6392",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6392.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6392.patch",
"merged_at": null
} | # What does this PR do ?
Remove bottleneck code in `perform_clustering` function
**Collection**: [ASR]
# Changelog
- remove `gc.collect()` code since it makes too slow.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "limdongjin",
"id": 30315743,
"node_id": "MDQ6VXNlcjMwMzE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/30315743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/limdongjin",
"html_url": "https://github.com/limdongjin",
"followers_url": "https://api.github.com/users/limdongjin/followers",
"following_url": "https://api.github.com/users/limdongjin/following{/other_user}",
"gists_url": "https://api.github.com/users/limdongjin/gists{/gist_id}",
"starred_url": "https://api.github.com/users/limdongjin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/limdongjin/subscriptions",
"organizations_url": "https://api.github.com/users/limdongjin/orgs",
"repos_url": "https://api.github.com/users/limdongjin/repos",
"events_url": "https://api.github.com/users/limdongjin/events{/privacy}",
"received_events_url": "https://api.github.com/users/limdongjin/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6392/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6392/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6391 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6391/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6391/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6391/events | https://github.com/NVIDIA/NeMo/pull/6391 | 1,658,331,797 | PR_kwDOC_bI7s5N0I6N | 6,391 | Framework for PEFT via mixins | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-07T04:03:21 | 2023-05-05T23:26:05 | 2023-05-05T23:26:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6391",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6391",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6391.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6391.patch",
"merged_at": "2023-05-05T23:26:04"
} | # What does this PR do ?
PTuning and Adapters/IA3 have been implemented in diverging styles. Adapters and IA3 uses the elegant adapter_mixins framework. This PR implements P-Tuning via the same adapter_mixins framework.
The high level goal is to unify all PEFT methods to use adapter_mixins. This is allow us to the GPTSFTDataset to be used for all future PEFT methods.
Currently this PR does not remove the GPTPromptLearingModel functionality, but once adaper-mixin based p-tuning has been tested we can deprecate GPTPromptLearingModel GPTPromptLearningDataset classes.
PTuning does not need to flexibility to insert prompt tokens anywhere in the input. This feature has been removed for simplicity.
Also added:
- mix-n-match PEFT scheme like `adapter_and_ptuning` can be easily extended to do `ia3_and_ptuning` or `lora_and_ptuning`
- grad clipping functionality for PEFT training
- LoRA adapters added for GPT
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6391/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6391/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6390 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6390/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6390/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6390/events | https://github.com/NVIDIA/NeMo/issues/6390 | 1,658,303,758 | I_kwDOC_bI7s5i17UO | 6,390 | When training HiFiGAN, after some epochs, `d_loss`, `g_loss`, etc. become `NaN` | {
"login": "godspirit00",
"id": 16176151,
"node_id": "MDQ6VXNlcjE2MTc2MTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/16176151?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/godspirit00",
"html_url": "https://github.com/godspirit00",
"followers_url": "https://api.github.com/users/godspirit00/followers",
"following_url": "https://api.github.com/users/godspirit00/following{/other_user}",
"gists_url": "https://api.github.com/users/godspirit00/gists{/gist_id}",
"starred_url": "https://api.github.com/users/godspirit00/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/godspirit00/subscriptions",
"organizations_url": "https://api.github.com/users/godspirit00/orgs",
"repos_url": "https://api.github.com/users/godspirit00/repos",
"events_url": "https://api.github.com/users/godspirit00/events{/privacy}",
"received_events_url": "https://api.github.com/users/godspirit00/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-07T03:13:29 | 2023-05-15T01:54:11 | 2023-05-15T01:54:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I'm training a 44100 HifiGAN model on my own dataset.
After some epochs, `d_loss`, `g_loss`, etc. become `NaN`,
and `val_loss` increases,
audio quality drops dramatically.
What seems to be the problem?
Thank you! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6390/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6390/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6389 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6389/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6389/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6389/events | https://github.com/NVIDIA/NeMo/pull/6389 | 1,658,195,666 | PR_kwDOC_bI7s5Nzuo4 | 6,389 | Add [Draft][TTS] FastPitch multi-speaker pre-train and adapter fine-tune | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-07T00:23:02 | 2023-04-14T22:11:36 | 2023-04-14T22:11:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6389",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6389",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6389.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6389.patch",
"merged_at": null
} | # What does this PR do ?
Adds FastPitch speaker adaptation with adapters.
**Collection**: TTS
# Changelog
- Adds multi-speaker FastPitch pre-training with 1) Looked-up speaker embedding 2) Speaker verification model speaker embedding 3) Global Style Tokens 4) Conditional Layer Normalization
- `nemo/collections/tts/data/tts_dataset.py`
- `nemo/collections/tts/torch/tts_data_types.py`
- `nemo/collections/tts/models/fastpitch.py`
- `nemo/collections/tts/modules/fastpitch.py`
- `nemo/collections/tts/modules/transformer.py`
- `nemo/collections/tts/modules/submodules.py`
- Add adapter modules for FastPitch fine-tuning
- `nemo/collections/tts/models/fastpitch.py`
- `nemo/collections/tts/modules/fastpitch.py`
- `nemo/collections/tts/modules/transformer.py`
- `nemo/collections/tts/modules/aligner.py`
- `nemo/collections/tts/parts/mixins/__init__.py`
- `nemo/collections/tts/parts/mixins/fastpitch_adapter_mixins.py`
- Add config and fine-tuning python script
- `examples/tts/conf/fastpitch_speaker_adaptation.yaml`
- `examples/tts/fastpitch_finetune_adapters.py`
- Add tutorial
- `tutorials/tts/FastPitch_SpeakerAdaptation.ipynb`
- Add fast text normalization script
- `scripts/dataset_processing/tts/add_normalized_text.py`
- Fix aligner `nan` loss bug
- `nemo/collections/tts/losses/aligner_loss.py`
# Usage
* Follow `tutorials/tts/FastPitch_SpeakerAdaptation.ipynb`
* Pre-train multi-speaker FastPitch
* Fine-tune HiFiGAN with mel-spectrograms from pre-trained FastPitch
* Fine-tune FastPitch with adapters
* Fine-tune HiFiFAN with mel-spectrograms from fine-tuned FastPitch
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6389/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6389/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6388 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6388/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6388/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6388/events | https://github.com/NVIDIA/NeMo/pull/6388 | 1,658,145,304 | PR_kwDOC_bI7s5Nzkrw | 6,388 | Add support for Megatron GPT Untied Embd TP PP Change | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-06T22:59:43 | 2023-04-11T00:53:17 | 2023-04-11T00:29:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6388",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6388",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6388.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6388.patch",
"merged_at": "2023-04-11T00:29:06"
} | # What does this PR do ?
Adds support for untied embeddings for Megatron GPT for TP PP change
**Collection**: [NLP]
# Changelog
- Generalize indexing for tied vs untied gpt embeddings
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6388/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6388/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6387 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6387/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6387/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6387/events | https://github.com/NVIDIA/NeMo/pull/6387 | 1,658,126,521 | PR_kwDOC_bI7s5Nzg27 | 6,387 | R1.17.0 | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-06T22:30:09 | 2023-04-28T01:52:47 | 2023-04-28T01:52:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6387",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6387",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6387.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6387.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6387/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6387/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6386 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6386/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6386/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6386/events | https://github.com/NVIDIA/NeMo/pull/6386 | 1,658,126,198 | PR_kwDOC_bI7s5Nzgyz | 6,386 | user selected max_seq_len should be less than model's max_seq_len | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-06T22:29:37 | 2023-05-05T21:43:43 | 2023-05-05T21:43:42 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6386",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6386",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6386.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6386.patch",
"merged_at": "2023-05-05T21:43:42"
} | # What does this PR do ?
user selected max_seq_len should be less than model's max_seq_len
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6386/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6386/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6385 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6385/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6385/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6385/events | https://github.com/NVIDIA/NeMo/pull/6385 | 1,658,004,863 | PR_kwDOC_bI7s5NzHGx | 6,385 | Ensure fine-tuning/prompt learning work for T5 | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-06T20:28:34 | 2023-04-07T22:24:37 | 2023-04-07T22:24:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6385",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6385",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6385.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6385.patch",
"merged_at": "2023-04-07T22:24:36"
} | # What does this PR do ?
Adds support for T5 Finetuning/Prompt tuning.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6385/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6385/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6383 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6383/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6383/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6383/events | https://github.com/NVIDIA/NeMo/issues/6383 | 1,657,668,598 | I_kwDOC_bI7s5izgP2 | 6,383 | Installation fails for python 3.10 | {
"login": "LilithHafner",
"id": 60898866,
"node_id": "MDQ6VXNlcjYwODk4ODY2",
"avatar_url": "https://avatars.githubusercontent.com/u/60898866?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LilithHafner",
"html_url": "https://github.com/LilithHafner",
"followers_url": "https://api.github.com/users/LilithHafner/followers",
"following_url": "https://api.github.com/users/LilithHafner/following{/other_user}",
"gists_url": "https://api.github.com/users/LilithHafner/gists{/gist_id}",
"starred_url": "https://api.github.com/users/LilithHafner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LilithHafner/subscriptions",
"organizations_url": "https://api.github.com/users/LilithHafner/orgs",
"repos_url": "https://api.github.com/users/LilithHafner/repos",
"events_url": "https://api.github.com/users/LilithHafner/events{/privacy}",
"received_events_url": "https://api.github.com/users/LilithHafner/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 5359165368,
"node_id": "LA_kwDOC_bI7s8AAAABP25fuA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/MacOS",
"name": "MacOS",
"color": "585B8C",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-06T15:48:20 | 2023-06-15T01:58:03 | 2023-06-15T01:58:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Executing `python3.10 -m pip install mecab-python3` produces the error
```
Collecting mecab-python3
Using cached mecab-python3-1.0.6.tar.gz (77 kB)
Preparing metadata (setup.py) ... done
Installing collected packages: mecab-python3
DEPRECATION: mecab-python3 is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
Running setup.py install for mecab-python3 ... error
error: subprocess-exited-with-error
× Running setup.py install for mecab-python3 did not run successfully.
│ exit code: 1
╰─> [18 lines of output]
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
warnings.warn(
WARNING: The wheel package is not available.
WARNING: The wheel package is not available.
WARNING: The wheel package is not available.
WARNING: The wheel package is not available.
running install
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_py
creating build
creating build/lib.macosx-10.9-universal2-cpython-310
creating build/lib.macosx-10.9-universal2-cpython-310/MeCab
copying src/MeCab/__init__.py -> build/lib.macosx-10.9-universal2-cpython-310/MeCab
copying src/MeCab/cli.py -> build/lib.macosx-10.9-universal2-cpython-310/MeCab
running build_ext
error: [Errno 2] No such file or directory: 'mecab-config'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> mecab-python3
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.
```
MacOS Ventural 13.3, M2 processor. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6383/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6383/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6382 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6382/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6382/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6382/events | https://github.com/NVIDIA/NeMo/pull/6382 | 1,657,593,082 | PR_kwDOC_bI7s5Nxx58 | 6,382 | fixed torch warning on using a list of numpy arrays | {
"login": "MKNachesa",
"id": 21260224,
"node_id": "MDQ6VXNlcjIxMjYwMjI0",
"avatar_url": "https://avatars.githubusercontent.com/u/21260224?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MKNachesa",
"html_url": "https://github.com/MKNachesa",
"followers_url": "https://api.github.com/users/MKNachesa/followers",
"following_url": "https://api.github.com/users/MKNachesa/following{/other_user}",
"gists_url": "https://api.github.com/users/MKNachesa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MKNachesa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MKNachesa/subscriptions",
"organizations_url": "https://api.github.com/users/MKNachesa/orgs",
"repos_url": "https://api.github.com/users/MKNachesa/repos",
"events_url": "https://api.github.com/users/MKNachesa/events{/privacy}",
"received_events_url": "https://api.github.com/users/MKNachesa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-06T15:01:23 | 2023-04-07T21:01:44 | 2023-04-07T21:01:44 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6382",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6382",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6382.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6382.patch",
"merged_at": "2023-04-07T21:01:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: ASR
# Changelog
- Fixed torch warning about creating a tensor from a list of numpy arrays and sped up execution by putting ```audio``` in a list when calling ```np.array()``` instead of when calling ```torch.tensor()```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6382/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6382/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6381 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6381/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6381/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6381/events | https://github.com/NVIDIA/NeMo/issues/6381 | 1,656,816,106 | I_kwDOC_bI7s5iwQHq | 6,381 | Onnx export of cache aware conformer fails | {
"login": "jvcrnc",
"id": 91939832,
"node_id": "U_kgDOBXrj-A",
"avatar_url": "https://avatars.githubusercontent.com/u/91939832?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jvcrnc",
"html_url": "https://github.com/jvcrnc",
"followers_url": "https://api.github.com/users/jvcrnc/followers",
"following_url": "https://api.github.com/users/jvcrnc/following{/other_user}",
"gists_url": "https://api.github.com/users/jvcrnc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jvcrnc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jvcrnc/subscriptions",
"organizations_url": "https://api.github.com/users/jvcrnc/orgs",
"repos_url": "https://api.github.com/users/jvcrnc/repos",
"events_url": "https://api.github.com/users/jvcrnc/events{/privacy}",
"received_events_url": "https://api.github.com/users/jvcrnc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-04-06T07:21:27 | 2023-05-15T01:54:14 | 2023-05-15T01:54:14 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Latest fixes of onnx export of cache aware conformer still fail.
PR [ #6311](https://github.com/NVIDIA/NeMo/pull/6311) (This is not yet in nemo 1.17.0, only https://github.com/NVIDIA/NeMo/pull/5837 is with more problems)
The model get's exported, but inferencing results in an exception.
This can be seen when the onnx model inference results get's verified with the pytorch model as a last step of the export. This fails with:
[ONNXRuntimeError] : 6 : RUNTIME_EXCEPTION : Non-zero status code returned while running Reshape node. Name:'Reshape_1530' Status Message: D:\a_work\1\s\onnxruntime\core\providers\cpu\tensor\reshape_helper.h:26 onnxruntime::ReshapeHelper::ReshapeHelper i < input_shape.NumDimensions() was false. The dimension with value zero exceeds the dimension size of the input tensor.
(I had to change CUDAExecutionProvider to CPUExecutionProvider)
The model was trained with nemo, but I can not share such a model.
Also I would want to remark that the dimension 0 and 1 of tensors: cache_last_channel and cache_last_time get transposed at the input and transposed again at the output, while this transposing is not needed and adds overhead.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6381/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6381/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6380 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6380/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6380/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6380/events | https://github.com/NVIDIA/NeMo/pull/6380 | 1,656,576,016 | PR_kwDOC_bI7s5Nuf3Z | 6,380 | Add opengraph support for NeMo docs | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-06T02:44:46 | 2023-04-06T03:07:29 | 2023-04-06T03:07:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6380",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6380",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6380.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6380.patch",
"merged_at": "2023-04-06T03:07:26"
} | # What does this PR do ?
Adds opengraph support for NeMo documentation page
**Collection**: [Docs]
# Changelog
- Add opengraph support for NeMo docs
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6380/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6380/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6379 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6379/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6379/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6379/events | https://github.com/NVIDIA/NeMo/pull/6379 | 1,656,432,569 | PR_kwDOC_bI7s5NuBT8 | 6,379 | updated lr for FC configs | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T23:27:11 | 2023-04-06T01:01:24 | 2023-04-06T01:01:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6379",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6379",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6379.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6379.patch",
"merged_at": "2023-04-06T01:01:23"
} | # What does this PR do ?
Refines the suggested training parameters for the Fast Conformer models.
**Collection**: ASR
# Changelog
- In fast-conformer_ctc_bpe.yaml, change min_lr to 1e-4 (from 1e-6)
- in fast-conformer_transducer_bpe.yaml, change lr to 5e-3 and min_lr to 5e-4 (from 1e-6)
# Usage
* Train as usual but you will be able to use checkpoint averaging to improve results
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6379/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6379/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6378 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6378/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6378/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6378/events | https://github.com/NVIDIA/NeMo/pull/6378 | 1,656,078,218 | PR_kwDOC_bI7s5Ns1ns | 6,378 | Update gpt_training.rst | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T18:13:21 | 2023-04-06T14:07:08 | 2023-04-06T14:07:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6378",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6378",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6378.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6378.patch",
"merged_at": "2023-04-06T14:07:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6378/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6378/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6377 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6377/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6377/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6377/events | https://github.com/NVIDIA/NeMo/pull/6377 | 1,656,000,113 | PR_kwDOC_bI7s5NskvS | 6,377 | Add installation and ASR inference instructions for Mac | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T17:09:34 | 2023-04-05T17:44:15 | 2023-04-05T17:44:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6377",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6377",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6377.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6377.patch",
"merged_at": "2023-04-05T17:44:15"
} | # What does this PR do ?
Adds installation and inference instructions for Apple Mac.
**Collection**: [ASR (docs)]
# Changelog
- installation instructions
- ASR inference instructions
# Usage
Developing NeMo on Mac devices.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #6289
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6377/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6377/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6376 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6376/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6376/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6376/events | https://github.com/NVIDIA/NeMo/pull/6376 | 1,655,966,168 | PR_kwDOC_bI7s5NsdfX | 6,376 | Adapter tuning accepts expanded language model dir | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T16:42:15 | 2023-04-05T20:37:50 | 2023-04-05T20:37:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6376",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6376",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6376.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6376.patch",
"merged_at": "2023-04-05T20:37:49"
} | # What does this PR do ?
set model extracted dir such that the save restore connector can load expanded base models. This is required to load large base models so that we can avoid the untaring step during training.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6376/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6376/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6375 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6375/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6375/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6375/events | https://github.com/NVIDIA/NeMo/pull/6375 | 1,655,920,170 | PR_kwDOC_bI7s5NsTw3 | 6,375 | Make possible to control tqdm progress bar in ASR models | {
"login": "SN4KEBYTE",
"id": 36272321,
"node_id": "MDQ6VXNlcjM2MjcyMzIx",
"avatar_url": "https://avatars.githubusercontent.com/u/36272321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SN4KEBYTE",
"html_url": "https://github.com/SN4KEBYTE",
"followers_url": "https://api.github.com/users/SN4KEBYTE/followers",
"following_url": "https://api.github.com/users/SN4KEBYTE/following{/other_user}",
"gists_url": "https://api.github.com/users/SN4KEBYTE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SN4KEBYTE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SN4KEBYTE/subscriptions",
"organizations_url": "https://api.github.com/users/SN4KEBYTE/orgs",
"repos_url": "https://api.github.com/users/SN4KEBYTE/repos",
"events_url": "https://api.github.com/users/SN4KEBYTE/events{/privacy}",
"received_events_url": "https://api.github.com/users/SN4KEBYTE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T16:09:17 | 2023-04-07T12:24:35 | 2023-04-06T17:30:27 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6375",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6375",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6375.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6375.patch",
"merged_at": "2023-04-06T17:30:27"
} | # What does this PR do ?
Now it's possible to control display of progress bar when calling `transcribe` method of ASR models.
**Collection**: ASR
# Changelog
- `transcribe` method of ASR models now have `verbose` param, which allows to control display of tqdm progress bar
# Usage
```python
import nemo.collections.asr as nemo_asr
asr_model = nemo_asr.models.EncDecRNNTBPEModel.from_pretrained("nvidia/stt_en_conformer_transducer_xlarge")
# Will display progress bar by default
asr_model.transcribe(['2086-149220-0033.wav'])
# Won't display progress bar when verbose is set to False
asr_model.transcribe(['2086-149220-0033.wav'], verbose=False)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
None
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6375/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6375/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6374 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6374/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6374/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6374/events | https://github.com/NVIDIA/NeMo/pull/6374 | 1,655,705,939 | PR_kwDOC_bI7s5NrmqW | 6,374 | Update wfst_text_normalization.rst | {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T14:12:54 | 2023-04-19T11:45:13 | 2023-04-18T22:58:58 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6374",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6374",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6374.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6374.patch",
"merged_at": "2023-04-18T22:58:58"
} | Add Hungarian (incoming in NeMo-text-processing)
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [X] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6374/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6374/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6373 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6373/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6373/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6373/events | https://github.com/NVIDIA/NeMo/pull/6373 | 1,655,657,498 | PR_kwDOC_bI7s5NrcA9 | 6,373 | Bugfix for BF16 grad reductions with distopt (#6340) | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T13:48:44 | 2023-04-05T15:47:55 | 2023-04-05T15:47:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6373",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6373",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6373.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6373.patch",
"merged_at": "2023-04-05T15:47:54"
} | Cheery-pick from `main` to `r1.17.0_pt_23.04`
* Debug distopt support for BF16 grad reductions
* Dump and load FP32 main params
* Style tweaks
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6373/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6373/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6372 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6372/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6372/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6372/events | https://github.com/NVIDIA/NeMo/pull/6372 | 1,655,610,653 | PR_kwDOC_bI7s5NrSCS | 6,372 | add conformer configs for hat model | {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T13:20:36 | 2023-04-14T19:47:08 | 2023-04-14T19:47:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6372",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6372",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6372.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6372.patch",
"merged_at": "2023-04-14T19:47:08"
} | # What does this PR do ?
Add conformer char and bpe configs for hat model (https://arxiv.org/abs/2003.07705)
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6372/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6372/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6371 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6371/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6371/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6371/events | https://github.com/NVIDIA/NeMo/pull/6371 | 1,655,536,902 | PR_kwDOC_bI7s5NrCJh | 6,371 | [Experimental] Update black to 23.x | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T12:32:40 | 2023-04-05T17:38:17 | 2023-04-05T17:35:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6371",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6371",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6371.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6371.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6371/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6371/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6370 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6370/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6370/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6370/events | https://github.com/NVIDIA/NeMo/pull/6370 | 1,655,315,857 | PR_kwDOC_bI7s5NqR2_ | 6,370 | Update script for ngram rnnt and hat beam search decoding | {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-05T10:04:38 | 2023-04-21T21:44:04 | 2023-04-21T21:44:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6370",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6370",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6370.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6370.patch",
"merged_at": "2023-04-21T21:44:04"
} | # What does this PR do ?
Update previous script for ngram RNNT/HAT beam search decoding by analogy with CTC ngram decoding.
**Collection**: [ASR]
# Changelog
- Add option to return `return_encoder_embiddings` for `rnnt_mode.transcribe()` method (analogy of logits for CTC)
- Update `eval_beamsearch_ngram_transducer.py` by analogy with `eval_beamsearch_ngram.py`
- Add RNNT/HAT ngram decoding description to docs
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6370/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6370/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6369 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6369/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6369/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6369/events | https://github.com/NVIDIA/NeMo/issues/6369 | 1,655,061,856 | I_kwDOC_bI7s5ipj1g | 6,369 | ASR_with_Subword_Tokenization.ipynb's guide on process_asr_text_tokenizer script is broken | {
"login": "lolbus",
"id": 1837762,
"node_id": "MDQ6VXNlcjE4Mzc3NjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/1837762?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lolbus",
"html_url": "https://github.com/lolbus",
"followers_url": "https://api.github.com/users/lolbus/followers",
"following_url": "https://api.github.com/users/lolbus/following{/other_user}",
"gists_url": "https://api.github.com/users/lolbus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lolbus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lolbus/subscriptions",
"organizations_url": "https://api.github.com/users/lolbus/orgs",
"repos_url": "https://api.github.com/users/lolbus/repos",
"events_url": "https://api.github.com/users/lolbus/events{/privacy}",
"received_events_url": "https://api.github.com/users/lolbus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-05T07:08:21 | 2023-05-13T01:50:03 | 2023-05-13T01:50:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When following guide to Build a Customize Tokenizer, process_asr_text_tokenizer.py does not create intended tokenizer folder with required content. Unable to pre-trained on any models that use BPE vocab since no one can pass anything to the new_tokenizer_dir argument now.
**Steps/Code to reproduce bug**
Try to run below command as taught by the tutorial, see if it works for you.
`!python /content/drive/MyDrive/Colab\sNotebooks/AI6127\sNLP/GroupProject/Data/process_asr_text_tokenizer.py \
--manifest="/content/drive/MyDrive/Colab Notebooks/AI6127 NLP/GroupProject/Data/manifest_train.json" \
--data_root="/content/drive/MyDrive/Colab Notebooks/AI6127 NLP/GroupProject/Data" \
--vocab_size=32 \
--tokenizer="spe" \
--no_lower_case \
--log`
**Expected behavior**
**Environment overview (please complete the following information)**
Colab Pro +
**Environment details**
NA
**Additional context**
NA
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6369/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6369/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6368 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6368/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6368/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6368/events | https://github.com/NVIDIA/NeMo/pull/6368 | 1,654,655,362 | PR_kwDOC_bI7s5NoFWT | 6,368 | [NeMo Megatron] Cleanup configs to infer the models TP PP config automatically | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T22:21:19 | 2023-04-06T23:46:01 | 2023-04-06T23:45:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6368",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6368",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6368.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6368.patch",
"merged_at": "2023-04-06T23:45:57"
} | # What does this PR do ?
**Collection**: [NLP]
# Changelog
- Update configs to set tp pp and pp rank all to -1
- Check and update -1 to the model config results
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6368/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6368/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6367 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6367/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6367/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6367/events | https://github.com/NVIDIA/NeMo/pull/6367 | 1,654,449,874 | PR_kwDOC_bI7s5NnYro | 6,367 | Word boosting for Flashlight decoder | {
"login": "trias702",
"id": 25867060,
"node_id": "MDQ6VXNlcjI1ODY3MDYw",
"avatar_url": "https://avatars.githubusercontent.com/u/25867060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/trias702",
"html_url": "https://github.com/trias702",
"followers_url": "https://api.github.com/users/trias702/followers",
"following_url": "https://api.github.com/users/trias702/following{/other_user}",
"gists_url": "https://api.github.com/users/trias702/gists{/gist_id}",
"starred_url": "https://api.github.com/users/trias702/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/trias702/subscriptions",
"organizations_url": "https://api.github.com/users/trias702/orgs",
"repos_url": "https://api.github.com/users/trias702/repos",
"events_url": "https://api.github.com/users/trias702/events{/privacy}",
"received_events_url": "https://api.github.com/users/trias702/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T19:24:11 | 2023-04-05T01:06:12 | 2023-04-05T01:06:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6367",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6367",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6367.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6367.patch",
"merged_at": "2023-04-05T01:06:12"
} | # What does this PR do ?
Adds word boosting to the Flashlight decoder in Nemo to mirror this capability in Riva
For more info see here: https://docs.nvidia.com/deeplearning/riva/user-guide/docs/tutorials/asr-python-advanced-wordboosting.html
And here: https://docs.nvidia.com/deeplearning/riva/user-guide/docs/asr/asr-customizing.html#word-boosting
**Collection**: ASR
# Changelog
- Added word boosting to collections/asr/modules/flashlight_decoder.py
- Added new config line item to flashlight_cfg in ctc_beam_decoding.py
(I noticed that flashlight_decoder.py had Windows EOLs, so I changed them to Unix, but unfortunately this makes git show as if I had changed the entire file which isn't the case, sorry about this)
# Usage
* In order to boost certain words, you need to create a flat file which is tab separated. The format of this file is:
```
<word>\t<boost score>
```
For example, here is a valid format boost file on disk, not that it is a single tab separated file:
```
nvidia 40
geforce 50
riva 80
turing 30
badword -100
```
Positive scores boost words higher in the LM decoding step so they show up more frequently, whereas negative scores squelch words so they show up less frequently. The recommended range for the boost score is 20 to 100.
The boost file handles both in-vocabulary words and OOV words just fine, so feel free to mix and match.
You can then add it to your flashlight config object in Nemo like this:
```python
ctc_decoding.beam.flashlight_cfg.boost_path='/path/to/my_boost_file.boost'
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [X] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6367/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6367/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6366 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6366/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6366/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6366/events | https://github.com/NVIDIA/NeMo/pull/6366 | 1,654,393,544 | PR_kwDOC_bI7s5NnMW2 | 6,366 | taskname and early stopping for adapters | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T18:44:16 | 2023-04-04T21:52:58 | 2023-04-04T21:52:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6366",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6366",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6366.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6366.patch",
"merged_at": "2023-04-04T21:52:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6366/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6366/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6365 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6365/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6365/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6365/events | https://github.com/NVIDIA/NeMo/pull/6365 | 1,654,317,431 | PR_kwDOC_bI7s5Nm7nz | 6,365 | Cherrypick mlperf prs | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T17:53:30 | 2023-04-04T18:31:47 | 2023-04-04T18:31:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6365",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6365",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6365.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6365.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6365/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6365/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6364 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6364/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6364/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6364/events | https://github.com/NVIDIA/NeMo/pull/6364 | 1,654,312,686 | PR_kwDOC_bI7s5Nm6mx | 6,364 | Update readme | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-04T17:49:30 | 2023-04-04T18:00:09 | 2023-04-04T18:00:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6364",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6364",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6364.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6364.patch",
"merged_at": "2023-04-04T18:00:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6364/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6364/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6363 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6363/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6363/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6363/events | https://github.com/NVIDIA/NeMo/pull/6363 | 1,654,285,793 | PR_kwDOC_bI7s5Nm0x6 | 6,363 | Update readme | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-04T17:28:49 | 2023-04-04T17:49:05 | 2023-04-04T17:49:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6363",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6363",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6363.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6363.patch",
"merged_at": "2023-04-04T17:49:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6363/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6363/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6362 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6362/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6362/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6362/events | https://github.com/NVIDIA/NeMo/pull/6362 | 1,654,276,731 | PR_kwDOC_bI7s5Nmy1v | 6,362 | Tensor-parallel communication overlap with userbuffer backend | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T17:21:14 | 2023-12-09T05:49:43 | 2023-04-18T22:49:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6362",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6362",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6362.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6362.patch",
"merged_at": "2023-04-18T22:49:44"
} | # What does this PR do ?
Add (1) interfaces to TE and initialized (2) process group setting to support tensor-parallel communication overlap with userbuffer backend.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
Set `ub_tp_comm_overlap` to `True`
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6362/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6362/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6359 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6359/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6359/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6359/events | https://github.com/NVIDIA/NeMo/pull/6359 | 1,653,277,720 | PR_kwDOC_bI7s5NjbmM | 6,359 | [pre-commit.ci] pre-commit suggestions | {
"login": "pre-commit-ci[bot]",
"id": 66853113,
"node_id": "MDM6Qm90NjY4NTMxMTM=",
"avatar_url": "https://avatars.githubusercontent.com/in/68672?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D",
"html_url": "https://github.com/apps/pre-commit-ci",
"followers_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T06:37:48 | 2023-04-04T14:54:53 | 2023-04-04T14:54:48 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6359",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6359",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6359.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6359.patch",
"merged_at": null
} | <!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](https://github.com/pre-commit/pre-commit-hooks/compare/v4.3.0...v4.4.0)
- [github.com/psf/black: 19.10b0 → 23.3.0](https://github.com/psf/black/compare/19.10b0...23.3.0)
<!--pre-commit.ci end--> | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6359/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6359/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6358 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6358/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6358/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6358/events | https://github.com/NVIDIA/NeMo/pull/6358 | 1,653,088,006 | PR_kwDOC_bI7s5NizJH | 6,358 | using mmap dataset for ptuning | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-04T03:03:00 | 2023-05-11T01:51:50 | 2023-05-11T01:51:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6358",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6358",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6358.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6358.patch",
"merged_at": null
} | # What does this PR do ?
replaces standard pytorch dataset with a mem mapped json dataset.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6358/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6358/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6357 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6357/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6357/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6357/events | https://github.com/NVIDIA/NeMo/pull/6357 | 1,653,046,201 | PR_kwDOC_bI7s5Niqca | 6,357 | Correct image logo in NeMo Website | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-04T02:10:29 | 2023-04-04T02:11:08 | 2023-04-04T02:11:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6357",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6357",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6357.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6357.patch",
"merged_at": "2023-04-04T02:11:07"
} | # What does this PR do ?
Use better image for the website default card.
**Collection**: [Docs]
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6357/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6357/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6356 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6356/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6356/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6356/events | https://github.com/NVIDIA/NeMo/pull/6356 | 1,653,037,266 | PR_kwDOC_bI7s5NiogN | 6,356 | Correct tag for image url in NeMo Website | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-04T02:00:17 | 2023-04-04T02:00:25 | 2023-04-04T02:00:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6356",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6356",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6356.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6356.patch",
"merged_at": "2023-04-04T02:00:24"
} | # What does this PR do ?
Fix image tag for open graph
**Collection**: [Docs]
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6356/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6356/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6355 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6355/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6355/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6355/events | https://github.com/NVIDIA/NeMo/pull/6355 | 1,653,028,123 | PR_kwDOC_bI7s5Nimmj | 6,355 | Update support for twitter cards in NeMo Website | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-04T01:47:27 | 2023-04-04T01:48:14 | 2023-04-04T01:48:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6355",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6355",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6355.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6355.patch",
"merged_at": "2023-04-04T01:48:13"
} | # What does this PR do ?
Adds support for twitter cards in addition to open graph
**Collection**: [Docs]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6355/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6355/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6354 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6354/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6354/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6354/events | https://github.com/NVIDIA/NeMo/pull/6354 | 1,652,998,533 | PR_kwDOC_bI7s5NigmT | 6,354 | Add OpenGraph metadata for better links to NeMo Website | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-04T01:06:18 | 2023-04-04T01:16:59 | 2023-04-04T01:16:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6354",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6354",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6354.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6354.patch",
"merged_at": "2023-04-04T01:16:57"
} | # What does this PR do ?
Adds [OpenGraph](https://ogp.me/) support to NeMo website for richer URL linking.
**Collection**: [Docs]
# Usage
```markdown
---
title: Template 2022
author: [First Name, Second Name]
author_gh_user: [Github User 1, Github User 2]
read_time: Time to read
publish_date: Date of publishing
# Optional: OpenGraph metadata
og_title: Title of the blog post for Rich URL previews
og_image (or image): Image for Rich URL previews (absolute URL)
og_image_type: Image type (e.g. image/png). Defaults to image/png.
page_path: Relative path to the image from the website root (e.g. /assets/images/)
description: Description of the post for Rich URL previews
# DO NOT CHANGE _BELOW
template: blog.html
---
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6354/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6354/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6353 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6353/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6353/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6353/events | https://github.com/NVIDIA/NeMo/pull/6353 | 1,652,676,642 | PR_kwDOC_bI7s5NhbA7 | 6,353 | extract inference weights | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-04-03T19:52:29 | 2023-04-05T06:02:51 | 2023-04-05T06:02:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6353",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6353",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6353.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6353.patch",
"merged_at": "2023-04-05T06:02:50"
} | # What does this PR do ?
Adds a script to extract p_tuned inference weights.
More details: The ptuning training saves all params including the prompt encoder weights. These are typically not required after training is completed. The script allows you to save the required representations for inference in a separate file and you can delete the .nemo if wanted.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6353/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6353/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6352 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6352/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6352/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6352/events | https://github.com/NVIDIA/NeMo/pull/6352 | 1,652,400,292 | PR_kwDOC_bI7s5NgfOE | 6,352 | docs on the use of heterogeneous test / val manifests | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-03T16:32:28 | 2023-04-03T16:40:42 | 2023-04-03T16:40:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6352",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6352",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6352.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6352.patch",
"merged_at": "2023-04-03T16:40:41"
} | # What does this PR do ?
Adds docs for the use of multiple test / validation manifests as enabled in #6306
**Collection**: ASR
# Changelog
- Added docs to `docs/source/asr/configs.rst`
# Usage
Docs only
```python
# Add a code snippet demonstrating how to use this
n/a
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6352/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6352/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6351 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6351/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6351/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6351/events | https://github.com/NVIDIA/NeMo/pull/6351 | 1,652,395,139 | PR_kwDOC_bI7s5NgeHX | 6,351 | Added num decoder blocks in megatron export | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-03T16:28:20 | 2023-04-04T16:05:39 | 2023-04-04T16:05:38 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6351",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6351",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6351.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6351.patch",
"merged_at": "2023-04-04T16:05:38"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6351/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6351/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6349 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6349/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6349/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6349/events | https://github.com/NVIDIA/NeMo/pull/6349 | 1,651,210,142 | PR_kwDOC_bI7s5Nce4Q | 6,349 | [ASR] Add optimization util for linear sum assignment algorithm | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-03T02:07:07 | 2023-12-06T21:26:44 | 2023-04-14T22:05:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6349",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6349",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6349.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6349.patch",
"merged_at": "2023-04-14T22:05:06"
} | # What does this PR do ?
1. Add a optimization util file for linear sum assignment (LSA) solver algorithm for online-diarization/multi-speaker-ASR
LSA problem solver is needed for the following tasks in NeMo:
(1) Permutation Invariant Loss (PIL) for diarization model training
(2) Label permutation matching for online speaker diarzation
(3) Concatenated minimum-permutation Word Error Rate (cp-WER) calculation
What is LSA solver algorithm? [Google OR-tools LSA Solver](https://developers.google.com/optimization/assignment/linear_assignment)
The NeMo linear_sum_assignment function is compared with `scipy.optimization.linear_sum_assingment`.
In the [unit-test ](https://github.com/NVIDIA/NeMo/blob/49d4e80ddf1138cea9593392a9a9e76be9ca58ec/tests/collections/asr/test_diar_utils.py#L792)for NeMo LSA solver, the result is compared with the `scipy` version of `linear_sum_assignment`.
2. Removing `@torch.jit.script` decorator in speaker_utils.py since it creates type-errors when the code is not used for production purpose.
Instead, all `torch.jit.script` required classes and functions are tested in `test_diar_utils.py`.
Take a look at [these tests](https://github.com/NVIDIA/NeMo/blob/49d4e80ddf1138cea9593392a9a9e76be9ca58ec/tests/collections/asr/test_diar_utils.py#L606) for checking jit_script = [True/False] and cuda = [True/False] (testing total 4 combinations)
3. Also refactored some of the functions in online diarization
- replaced scipy LSA solver to NeMo LSA solver in `online_clustering.py`.
5. Added a couple of functions in `der.py` for online diarization DER calculation.
- replaced scipy LSA solver to NeMo LSA solver in `der.py`.
**Collection**: [ASR]
# Changelog
- nemo/collections/asr/metrics/der.py
: replaced scipy LSA solver to NeMo LSA solver in `calculate_session_cpWER ` function.
: Added two functions for online diarization evaluations: `get_partial_ref_labels` and `get_online_DER_stats`.
- nemo/collections/asr/models/online_diarizer.py
: Made `_perform_online_clustering` function simpler by moving `get_reduced_mat` and `match_labels` into online clustering function.
- nemo/collections/asr/parts/utils/offline_clustering.py
: Added `laplacian = laplacian.float().to(torch.device('cpu'))` to avoid jit-scripted module uses GPU even when CPU is specified or vice-versa. This behavior is always tested/checked in `test_diar_utils.py`.
- nemo/collections/asr/parts/utils/online_clustering.py
: replaced scipy LSA solver to NeMo LSA solver in `get_lsa_speaker_mapping` function.
: Modified the docstrings of `update_speaker_history_buffer` to make the example easier.
- nemo/collections/asr/parts/utils/optimization_utils.py
: Fully torch-jit-scriptable, linear sum assignment problem solver class and function were added.
- nemo/collections/asr/parts/utils/speaker_utils.py
: Removed `@torch.jit.script` decorators since this creates unnecessary warning messages and type related errors when used without scripting.
- tests/collections/asr/test_diar_metrics.py
: Added unit-tests for the newly added function `get_partial_ref_labels` and `get_online_DER_stats`.
- tests/collections/asr/test_diar_utils.py
: Added tests for offline clustering and online clustering for many different cases including:
[jit-script=True, cuda=True],
[jit-script=True, cuda=False],
[jit-script=False, cuda=True],
[jit-script=False, cuda=False] cases
which is using the torch-jit-scripted NeMo linear_sum_assignment function.
# Usage
```python
from nemo.collections.asr.parts.utils.optimization_utils import linear_sum_assignment
#An example cost matrix to be solved
cost_matrix = \
torch.tensor([[7, 6, 2], [6, 2, 1], [5, 6, 8]])
row_ind_nm, col_ind_nm = linear_sum_assignment(cost_matrix)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6349/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6349/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6348 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6348/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6348/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6348/events | https://github.com/NVIDIA/NeMo/issues/6348 | 1,651,172,013 | I_kwDOC_bI7s5iauKt | 6,348 | stt_ru_conformer_ctc_large Text hypothesis does not match word timestamps. | {
"login": "sh1man",
"id": 49469606,
"node_id": "MDQ6VXNlcjQ5NDY5NjA2",
"avatar_url": "https://avatars.githubusercontent.com/u/49469606?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sh1man",
"html_url": "https://github.com/sh1man",
"followers_url": "https://api.github.com/users/sh1man/followers",
"following_url": "https://api.github.com/users/sh1man/following{/other_user}",
"gists_url": "https://api.github.com/users/sh1man/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sh1man/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sh1man/subscriptions",
"organizations_url": "https://api.github.com/users/sh1man/orgs",
"repos_url": "https://api.github.com/users/sh1man/repos",
"events_url": "https://api.github.com/users/sh1man/events{/privacy}",
"received_events_url": "https://api.github.com/users/sh1man/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-04-03T01:13:24 | 2023-05-11T01:51:52 | 2023-05-11T01:51:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
It is with this model "stt_ru_conformer_ctc_large" that I have problems. Can't get timestamps, I'm executing the code:
from nemo.collections.asr.parts.utils.decoder_timestamps_utils import ASRDecoderTimeStamps
asr_decoder_ts = ASRDecoderTimeStamps(cfg.diarizer)
asr_model = asr_decoder_ts.set_asr_model()
word_hyp, word_ts_hyp = asr_decoder_ts.run_ASR(asr_model)
and I get an error:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.8/dist-packages/nemo/collections/asr/parts/utils/decoder_timestamps_utils.py", line 674, in run_ASR_BPE_CTC
text, char_ts, word_ts = werbpe_ts.ctc_decoder_predictions_tensor_with_ts(
File "/usr/local/lib/python3.8/dist-packages/nemo/collections/asr/parts/utils/decoder_timestamps_utils.py", line 98, in ctc_decoder_predictions_tensor_with_ts
word_ts, word_seq = self.get_ts_from_decoded_prediction(decoded_prediction, hypothesis, char_ts)
File "/usr/local/lib/python3.8/dist-packages/nemo/collections/asr/parts/utils/decoder_timestamps_utils.py", line 148, in get_ts_from_decoded_prediction
assert len(word_ts) == len(hypothesis.split()), "Text hypothesis does not match word timestamps."
AssertionError: Text hypothesis does not match word timestamps.
**Expected behavior**
Get timestamps.
**Environment overview (please complete the following information)**
- Environment location: Docker
- Commands used: docker run --gpus all -ti --shm-size=8g nvcr.io/nvidia/pytorch:23.02-py3
**Environment details**
i use docker | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6348/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6348/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6347 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6347/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6347/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6347/events | https://github.com/NVIDIA/NeMo/pull/6347 | 1,651,104,168 | PR_kwDOC_bI7s5NcJQl | 6,347 | specaug speedup | {
"login": "1-800-BAD-CODE",
"id": 50530592,
"node_id": "MDQ6VXNlcjUwNTMwNTky",
"avatar_url": "https://avatars.githubusercontent.com/u/50530592?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/1-800-BAD-CODE",
"html_url": "https://github.com/1-800-BAD-CODE",
"followers_url": "https://api.github.com/users/1-800-BAD-CODE/followers",
"following_url": "https://api.github.com/users/1-800-BAD-CODE/following{/other_user}",
"gists_url": "https://api.github.com/users/1-800-BAD-CODE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/1-800-BAD-CODE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/1-800-BAD-CODE/subscriptions",
"organizations_url": "https://api.github.com/users/1-800-BAD-CODE/orgs",
"repos_url": "https://api.github.com/users/1-800-BAD-CODE/repos",
"events_url": "https://api.github.com/users/1-800-BAD-CODE/events{/privacy}",
"received_events_url": "https://api.github.com/users/1-800-BAD-CODE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-02T21:42:07 | 2023-04-06T03:04:33 | 2023-04-06T00:19:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6347",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6347",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6347.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6347.patch",
"merged_at": "2023-04-06T00:19:05"
} | # What does this PR do ?
Faster implementation of non-numba specaug
**Collection**: ASR
# Changelog
Rather than repeatedly modify the features tensor in-place, build a mask and fill the features tensor once. By my measurements, about 20x faster on GPU.
It could be faster still, but it gets hard to compare output exactly to the original implementation to verify correctness.
Also, the original implementation seems to be biased away from the upper freq bins, but again fixing it would be make it impossible to compare the outputs to the original implementation.
# Usage
Running this snippet will run both the original and this implementation, verify similar output, and print latencies.
<details>
<summary>Test snippet</summary>
```python
import random
import time
import torch
from nemo.collections.asr.parts.submodules.spectr_augment import SpecAugment
from nemo.core.classes import typecheck
# Copy of original `SpecAugment.forward` for comparison
@typecheck()
@torch.no_grad()
def forward_original(self, input_spec, length):
sh = input_spec.shape
for idx in range(sh[0]):
for i in range(self.freq_masks):
x_left = self._rng.randint(0, sh[1] - self.freq_width)
w = self._rng.randint(0, self.freq_width)
input_spec[idx, x_left : x_left + w, :] = self.mask_value
for i in range(self.time_masks):
if self.adaptive_temporal_width:
time_width = max(1, int(length[idx] * self.time_width))
else:
time_width = self.time_width
y_left = self._rng.randint(0, max(1, length[idx] - time_width))
w = self._rng.randint(0, time_width)
input_spec[idx, :, y_left : y_left + w] = self.mask_value
return input_spec
seed = 12345
batch_size = 128
feat_dim = 80
max_length = 1000
device = "cuda"
num_iterations = 100
# Generate some inputs
spec = torch.randn(size=[batch_size, feat_dim, max_length], device=device)
lengths = torch.randint(low=max_length // 10, high=max_length, size=[batch_size], device=device)
# Usually, at least one element in a batch is the max length.
lengths[0] = max_length
print(f"Testing with input features shape {spec.shape}")
# This version has the new forward
augmentor: SpecAugment = SpecAugment(
freq_masks=2, time_masks=10, freq_width=27, time_width=0.05, rng=random.Random(seed)
).to(device)
# cache the first output for comparison (need to be careful of RNG values)
first_output_new = augmentor(input_spec=spec, length=lengths)
# Warm up
augmented_spec = augmentor(input_spec=spec, length=lengths)
# Loop and record time
start = time.time()
for _ in range(num_iterations):
augmented_spec = augmentor(input_spec=spec, length=lengths)
if device == "cuda":
torch.cuda.synchronize()
stop = time.time()
mean_duration = (stop - start) / num_iterations
print(f"Mean duration for new implementation: {mean_duration * 1000:0.1f} ms")
# Re-instantiate a spec aug with same RNG
augmentor: SpecAugment = SpecAugment(
freq_masks=2, time_masks=10, freq_width=27, time_width=0.05, rng=random.Random(seed)
).to(device)
# Set class's forward method to original one
setattr(SpecAugment, "forward", forward_original)
# Get baseline output. Note that the original implementation modifies in-place and returns a reference to `spec`, so
# use a clone of `spec` since we'll call forward some more for getting times
first_output_old = augmentor(input_spec=spec.clone(), length=lengths)
# Warm up
augmented_spec = augmentor(input_spec=spec, length=lengths)
# Loop and record time
start = time.time()
for _ in range(num_iterations):
augmented_spec = augmentor(input_spec=spec, length=lengths)
if device == "cuda":
torch.cuda.synchronize()
stop = time.time()
mean_duration = (stop - start) / num_iterations
print(f"Mean duration for original specaug: {mean_duration * 1000:0.1f} ms")
# Compare the output of each module. Can use hard tolerance since op is a constant fill.
print("Asserting old and new augmentations are all close...")
torch.testing.assert_close(actual=first_output_new, expected=first_output_old, rtol=0.0, atol=0.0)
print("Old and new outputs match")
```
</details>
Expected output:
```text
# With GPU
Testing with input features shape torch.Size([128, 80, 1000])
Mean duration for new implementation: 5.0 ms
Mean duration for original specaug: 100.1 ms
Asserting old and new augmentations are all close...
Old and new outputs match
# with CPU
Testing with input features shape torch.Size([128, 80, 1000])
Mean duration for new implementation: 8.5 ms
Mean duration for original specaug: 42.5 ms
Asserting old and new augmentations are all close...
Old and new outputs match
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6347/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6347/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6346 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6346/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6346/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6346/events | https://github.com/NVIDIA/NeMo/pull/6346 | 1,650,299,806 | PR_kwDOC_bI7s5NZpr0 | 6,346 | [Core] return_config=True now extracts just config, not full tarfile | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-04-01T05:01:53 | 2023-04-02T04:58:41 | 2023-04-02T04:58:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6346",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6346",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6346.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6346.patch",
"merged_at": "2023-04-02T04:58:37"
} | # What does this PR do ?
Make return_config=True now only extract out the yaml files from the tarfile, preventing opening and file extractions of all files (should significantly speedup return_config=True for Billion parameter models).
**Collection**: [Core, ASR, NLP, TTS]
# Changelog
- Add flag to extract just config from core internals
# Usage
```python
model_config = ModelClass.restore_from(..., return_config=True)
OR
model_config = ModelClass.from_pretrained(..., return_config=True)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6346/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6346/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6345 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6345/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6345/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6345/events | https://github.com/NVIDIA/NeMo/issues/6345 | 1,650,266,756 | I_kwDOC_bI7s5iXRKE | 6,345 | How to train conformer asr model | {
"login": "viralrupapara36",
"id": 104073221,
"node_id": "U_kgDOBjQIBQ",
"avatar_url": "https://avatars.githubusercontent.com/u/104073221?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/viralrupapara36",
"html_url": "https://github.com/viralrupapara36",
"followers_url": "https://api.github.com/users/viralrupapara36/followers",
"following_url": "https://api.github.com/users/viralrupapara36/following{/other_user}",
"gists_url": "https://api.github.com/users/viralrupapara36/gists{/gist_id}",
"starred_url": "https://api.github.com/users/viralrupapara36/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/viralrupapara36/subscriptions",
"organizations_url": "https://api.github.com/users/viralrupapara36/orgs",
"repos_url": "https://api.github.com/users/viralrupapara36/repos",
"events_url": "https://api.github.com/users/viralrupapara36/events{/privacy}",
"received_events_url": "https://api.github.com/users/viralrupapara36/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-04-01T03:09:09 | 2023-05-09T01:52:30 | 2023-05-09T01:52:30 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I want to train conformer ast model for different indian regional launguage but I'm not able to find proper training tutorial can anyone please guide me thought ? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6345/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6345/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6344 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6344/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6344/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6344/events | https://github.com/NVIDIA/NeMo/pull/6344 | 1,649,895,377 | PR_kwDOC_bI7s5NYVQM | 6,344 | Fix radtts sort r17 | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T19:22:33 | 2023-04-03T19:06:09 | 2023-04-03T19:06:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6344",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6344",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6344.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6344.patch",
"merged_at": "2023-04-03T19:06:09"
} | # What does this PR do ?
This is a duplicate PR of https://github.com/NVIDIA/NeMo/pull/6320 merged in main branch, but the release branch needs this fix as well.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6344/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6344/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6343 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6343/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6343/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6343/events | https://github.com/NVIDIA/NeMo/pull/6343 | 1,649,819,385 | PR_kwDOC_bI7s5NYFfN | 6,343 | Cherry-pick recent distopt commits | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T18:20:08 | 2023-04-03T17:40:34 | 2023-04-03T16:18:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6343",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6343",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6343.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6343.patch",
"merged_at": "2023-04-03T16:18:40"
} | # What does this PR do ?
This PR cherry-picks several recent distopt commits from the `main` branch into `r1.17.0`.
**Collection**: NLP
# Changelog
- GPT support for BF16 grad reductions (#5920)
- Add custom functions to launch distopt communication in interleaved pipeline parallelism (#6183)
- Bugfix for BF16 grad reductions with distopt (#6340)
# Usage
Set the optimizer to `distributed_fused_adam` in the config file:
https://github.com/NVIDIA/NeMo/blob/aaa0ccacf5b4d204ed18f6052e55ff6f20575996/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml#L207
Configure the optimizer with `grad_sync_dtype: bf16`.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6343/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6343/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6342 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6342/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6342/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6342/events | https://github.com/NVIDIA/NeMo/pull/6342 | 1,649,779,494 | PR_kwDOC_bI7s5NX9VV | 6,342 | remove pinned numba version in Dockerfile | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T17:45:57 | 2023-04-03T16:19:44 | 2023-04-03T16:19:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6342",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6342",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6342.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6342.patch",
"merged_at": "2023-04-03T16:19:43"
} | # What does this PR do ?
remove pinned numba version in Dockerfile
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6342/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6342/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6341 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6341/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6341/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6341/events | https://github.com/NVIDIA/NeMo/pull/6341 | 1,649,777,606 | PR_kwDOC_bI7s5NX87P | 6,341 | remove pinned numba version in Dockerfile | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T17:44:42 | 2023-03-31T17:45:34 | 2023-03-31T17:45:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6341",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6341",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6341.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6341.patch",
"merged_at": "2023-03-31T17:45:32"
} | # What does this PR do ?
remove pinned numba version in Dockerfile
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6341/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6341/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6340 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6340/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6340/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6340/events | https://github.com/NVIDIA/NeMo/pull/6340 | 1,649,683,047 | PR_kwDOC_bI7s5NXpWr | 6,340 | Bugfix for BF16 grad reductions with distopt | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T16:36:33 | 2023-03-31T18:04:20 | 2023-03-31T18:04:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6340",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6340",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6340.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6340.patch",
"merged_at": "2023-03-31T18:04:20"
} | # What does this PR do ?
https://github.com/NVIDIA/NeMo/pull/5920 adds support for BF16 grad reductions with distopt, with embedding grad reductions done in FP32. @mikolajblaz found some bugs and it turns out the FP32 reductions were not being done at all. This PR fixes those issues. When I run GPT-3 175B, I confirm the embedding grads are now optimized with the FP32 optimizer. Loss values are the same with FP32 and BF16 grad reductions, up to 50 steps and within numerical accuracy.
This turned out messier than I would have liked. It would have been better to integrate distopt support for multiple grad dtypes into Apex.
**Collection**: NLP
# Changelog
- Debug distopt support for BF16 grad reductions
# Usage
Set the optimizer to `distributed_fused_adam` in the config file:
https://github.com/NVIDIA/NeMo/blob/aaa0ccacf5b4d204ed18f6052e55ff6f20575996/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml#L207
Configure the optimizer with `grad_sync_dtype: bf16`.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* This PR is identical to https://github.com/NVIDIA/NeMo/pull/6297, but merges into `main` instead of `r1.17`. See that PR for discussions.
* Fixes bugs from https://github.com/NVIDIA/NeMo/pull/5920
* Depends on https://github.com/NVIDIA/apex/pull/1575
* Depends on https://github.com/NVIDIA/TransformerEngine/pull/75
| {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6340/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6340/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6339 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6339/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6339/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6339/events | https://github.com/NVIDIA/NeMo/issues/6339 | 1,649,448,499 | I_kwDOC_bI7s5iUJYz | 6,339 | TTS for Korean tokenizer/phonemizer | {
"login": "dhuberi1",
"id": 25107656,
"node_id": "MDQ6VXNlcjI1MTA3NjU2",
"avatar_url": "https://avatars.githubusercontent.com/u/25107656?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dhuberi1",
"html_url": "https://github.com/dhuberi1",
"followers_url": "https://api.github.com/users/dhuberi1/followers",
"following_url": "https://api.github.com/users/dhuberi1/following{/other_user}",
"gists_url": "https://api.github.com/users/dhuberi1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dhuberi1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dhuberi1/subscriptions",
"organizations_url": "https://api.github.com/users/dhuberi1/orgs",
"repos_url": "https://api.github.com/users/dhuberi1/repos",
"events_url": "https://api.github.com/users/dhuberi1/events{/privacy}",
"received_events_url": "https://api.github.com/users/dhuberi1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-03-31T14:23:00 | 2023-05-09T01:52:32 | 2023-05-09T01:52:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am looking to train mixer-tts model on korean dataset. I see in my config.yaml i need to complete the normalization, tokenization and phonemization. Is there a tutorial for how to train model and preprocess data for language not listed in your tts_tokenizers and then input those changes/new functions in the config.yaml? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6339/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6339/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6338 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6338/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6338/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6338/events | https://github.com/NVIDIA/NeMo/pull/6338 | 1,649,394,856 | PR_kwDOC_bI7s5NWq4S | 6,338 | simplified notebook for p-tuning | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T13:51:33 | 2023-03-31T16:15:44 | 2023-03-31T16:15:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6338",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6338",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6338.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6338.patch",
"merged_at": "2023-03-31T16:15:43"
} | # What does this PR do ?
Simplified the notebook for p-tuning. Sticks to a simple single task training and inference.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6338/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6338/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6337 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6337/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6337/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6337/events | https://github.com/NVIDIA/NeMo/pull/6337 | 1,648,665,644 | PR_kwDOC_bI7s5NUPHJ | 6,337 | Fix RNNT Joint narrow() | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T04:54:17 | 2023-03-31T04:54:53 | 2023-03-31T04:54:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6337",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6337",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6337.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6337.patch",
"merged_at": "2023-03-31T04:54:52"
} | # What does this PR do ?
Fixes a but in the signature of narrow().
Fixes #6328
**Collection**: [ASR]
# Changelog
- Casts the length input of all narrow() to int() explicitly
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6337/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6337/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6336 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6336/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6336/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6336/events | https://github.com/NVIDIA/NeMo/pull/6336 | 1,648,665,115 | PR_kwDOC_bI7s5NUO_- | 6,336 | Fix RNNT Joint narrow() | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-31T04:53:24 | 2023-03-31T04:53:55 | 2023-03-31T04:53:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6336",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6336",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6336.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6336.patch",
"merged_at": "2023-03-31T04:53:51"
} | # What does this PR do ?
Fixes a but in the signature of narrow().
Fixes #6328
**Collection**: [ASR]
# Changelog
- Casts the length input of all narrow() to int() explicitly
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6336/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6336/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6335 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6335/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6335/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6335/events | https://github.com/NVIDIA/NeMo/pull/6335 | 1,648,445,874 | PR_kwDOC_bI7s5NThe8 | 6,335 | Minor updates to MegatronGPTPromptLearningModel | {
"login": "holgerroth",
"id": 6304754,
"node_id": "MDQ6VXNlcjYzMDQ3NTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6304754?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/holgerroth",
"html_url": "https://github.com/holgerroth",
"followers_url": "https://api.github.com/users/holgerroth/followers",
"following_url": "https://api.github.com/users/holgerroth/following{/other_user}",
"gists_url": "https://api.github.com/users/holgerroth/gists{/gist_id}",
"starred_url": "https://api.github.com/users/holgerroth/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/holgerroth/subscriptions",
"organizations_url": "https://api.github.com/users/holgerroth/orgs",
"repos_url": "https://api.github.com/users/holgerroth/repos",
"events_url": "https://api.github.com/users/holgerroth/events{/privacy}",
"received_events_url": "https://api.github.com/users/holgerroth/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-30T23:17:29 | 2023-05-05T01:48:29 | 2023-05-05T01:48:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6335",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6335",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6335.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6335.patch",
"merged_at": null
} | # What does this PR do ?
Fixes typos in docstring. Removed unused imports
**Collection**: NLP
# Changelog
- fix docstring typos; remove unused imports
# Usage
n/a
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
n/a
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6335/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6335/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6334 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6334/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6334/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6334/events | https://github.com/NVIDIA/NeMo/pull/6334 | 1,648,432,377 | PR_kwDOC_bI7s5NTekl | 6,334 | Pin the version to hopefully fix rtd build | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-03-30T22:59:04 | 2023-03-31T03:52:41 | 2023-03-31T03:52:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6334",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6334",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6334.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6334.patch",
"merged_at": "2023-03-31T03:52:40"
} | # What does this PR do ?
Fix RTD using this: https://github.com/geopandas/dask-geopandas/pull/247
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6334/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6334/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6333 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6333/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6333/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6333/events | https://github.com/NVIDIA/NeMo/pull/6333 | 1,648,214,520 | PR_kwDOC_bI7s5NSwyi | 6,333 | user selected max_seq_len should be less than model's max_seq_len | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-30T19:47:12 | 2023-04-06T22:29:13 | 2023-04-06T22:29:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6333",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6333",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6333.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6333.patch",
"merged_at": "2023-04-06T22:29:12"
} | # What does this PR do ?
user selected max_seq_len should be less than model's max_seq_len
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6333/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6333/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6332 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6332/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6332/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6332/events | https://github.com/NVIDIA/NeMo/pull/6332 | 1,647,928,228 | PR_kwDOC_bI7s5NRzuH | 6,332 | Megatron hidden transformations | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-30T16:17:54 | 2023-08-11T17:59:47 | 2023-08-11T17:59:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6332",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6332",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6332.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6332.patch",
"merged_at": "2023-08-11T17:59:46"
} | # What does this PR do ?
This PR adds support in applying transformation to the hiddens in Megatron Encoder-Decoder model, and augmenting a corresponding loss. This enables support in latent variable models, like VAE and MIM.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can add the following to your config :
hidden_transforms: [MegatronGaussianHiddenTransform()] and it will apply a gaussian transform to the hiddens.
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6332/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6332/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6331 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6331/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6331/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6331/events | https://github.com/NVIDIA/NeMo/pull/6331 | 1,647,868,954 | PR_kwDOC_bI7s5NRnA9 | 6,331 | Added num decoder blocks in megatron export | {
"login": "Davood-M",
"id": 3964285,
"node_id": "MDQ6VXNlcjM5NjQyODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3964285?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Davood-M",
"html_url": "https://github.com/Davood-M",
"followers_url": "https://api.github.com/users/Davood-M/followers",
"following_url": "https://api.github.com/users/Davood-M/following{/other_user}",
"gists_url": "https://api.github.com/users/Davood-M/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Davood-M/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Davood-M/subscriptions",
"organizations_url": "https://api.github.com/users/Davood-M/orgs",
"repos_url": "https://api.github.com/users/Davood-M/repos",
"events_url": "https://api.github.com/users/Davood-M/events{/privacy}",
"received_events_url": "https://api.github.com/users/Davood-M/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-30T15:38:17 | 2023-04-03T16:27:57 | 2023-04-03T16:27:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6331",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6331",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6331.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6331.patch",
"merged_at": "2023-04-03T16:27:56"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Davood-M",
"id": 3964285,
"node_id": "MDQ6VXNlcjM5NjQyODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3964285?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Davood-M",
"html_url": "https://github.com/Davood-M",
"followers_url": "https://api.github.com/users/Davood-M/followers",
"following_url": "https://api.github.com/users/Davood-M/following{/other_user}",
"gists_url": "https://api.github.com/users/Davood-M/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Davood-M/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Davood-M/subscriptions",
"organizations_url": "https://api.github.com/users/Davood-M/orgs",
"repos_url": "https://api.github.com/users/Davood-M/repos",
"events_url": "https://api.github.com/users/Davood-M/events{/privacy}",
"received_events_url": "https://api.github.com/users/Davood-M/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6331/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6331/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6330 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6330/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6330/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6330/events | https://github.com/NVIDIA/NeMo/issues/6330 | 1,647,547,251 | I_kwDOC_bI7s5iM5Nz | 6,330 | Error when finetuning HifiGan for multi-speaker FastPitch | {
"login": "kuruhuru",
"id": 24458142,
"node_id": "MDQ6VXNlcjI0NDU4MTQy",
"avatar_url": "https://avatars.githubusercontent.com/u/24458142?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kuruhuru",
"html_url": "https://github.com/kuruhuru",
"followers_url": "https://api.github.com/users/kuruhuru/followers",
"following_url": "https://api.github.com/users/kuruhuru/following{/other_user}",
"gists_url": "https://api.github.com/users/kuruhuru/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kuruhuru/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kuruhuru/subscriptions",
"organizations_url": "https://api.github.com/users/kuruhuru/orgs",
"repos_url": "https://api.github.com/users/kuruhuru/repos",
"events_url": "https://api.github.com/users/kuruhuru/events{/privacy}",
"received_events_url": "https://api.github.com/users/kuruhuru/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-03-30T12:44:25 | 2023-04-03T17:35:05 | 2023-04-03T17:35:05 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
An error occured when trying to finetune tts_en_hifitts_hifigan_ft_fastpitch.nemo
Using a target size (torch.Size([16, 80, 64])) that is different to the input size (torch.Size([16, 80, 129])). This will likely lead to incorrect results due to broadcasting. Please ensure they have the same size.
Error executing job with overrides: ['model.max_steps=100000', 'train_dataset=data/ruslan.orig/synmels/hifigan_train_manifest_phonemes_ft.json', 'validation_datasets=data/ruslan.orig/synmels/hifigan_val_manifest_phonemes_ft.json', 'exp_manager.exp_dir=data/ruslan.orig/result', '+init_from_nemo_model=pretrained/tts_en_hifitts_hifigan_ft_fastpitch.nemo', 'trainer.devices=-1', '+trainer.val_check_interval=100', 'trainer.check_val_every_n_epoch=null', 'model/train_ds=train_ds_finetune', 'model/validation_ds=val_ds_finetune']
Traceback (most recent call last):
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/clearml/binding/hydra_bind.py", line 173, in _patched_task_function
return task_function(a_config, *a_args, **a_kwargs)
File "tts_scripts/hifigan_finetune.py", line 34, in main
trainer.fit(model)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 603, in fit
call._call_and_handle_interrupt(
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/call.py", line 36, in _call_and_handle_interrupt
return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 90, in launch
return function(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 645, in _fit_impl
self._run(model, ckpt_path=self.ckpt_path)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1098, in _run
results = self._run_stage()
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1177, in _run_stage
self._run_train()
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1190, in _run_train
self._run_sanity_check()
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1262, in _run_sanity_check
val_loop.run()
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/loops/loop.py", line 199, in run
self.advance(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 152, in advance
dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/loops/loop.py", line 199, in run
self.advance(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 137, in advance
output = self._evaluation_step(**kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 234, in _evaluation_step
output = self.trainer._call_strategy_hook(hook_name, *kwargs.values())
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1480, in _call_strategy_hook
output = fn(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/strategies/ddp.py", line 360, in validation_step
return self.model(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1533, in _call_impl
return forward_call(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 1129, in forward
output = self._run_ddp_forward(*inputs, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 1083, in _run_ddp_forward
return self.module(*inputs[0], **kwargs[0]) # type: ignore[index]
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1533, in _call_impl
return forward_call(*args, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/pytorch_lightning/overrides/base.py", line 110, in forward
return self._forward_module.validation_step(*inputs, **kwargs)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/nemo/collections/tts/models/hifigan.py", line 237, in validation_step
loss_mel = F.l1_loss(audio_mel, audio_pred_mel)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/torch/nn/functional.py", line 3268, in l1_loss
expanded_input, expanded_target = torch.broadcast_tensors(input, target)
File "/home/user/.conda/envs/nemo/lib/python3.8/site-packages/torch/functional.py", line 74, in broadcast_tensors
return _VF.broadcast_tensors(tensors) # type: ignore[attr-defined]
RuntimeError: The size of tensor a (129) must match the size of tensor b (64) at non-singleton dimension 2
**Steps/Code to reproduce bug**
I am following the standard process of fine tuning FastPitch and HifiGan
1) I finetuned /tts_en_fastpitch_multispeaker.nemo with Russian voice (44100 sr)
2) After that I decided to finetune HifiGan from finetune tts_en_hifitts_hifigan_ft_fastpitch.nemo
**Expected behavior**
I got the error above. And I fixed it when changed
### Default values for dataset with sample_rate=44100
sample_rate: 44100
n_mel_channels: 80
n_window_size: 2048
n_window_stride: 256 <- changed to 256 from 512
n_fft: 2048
lowfreq: 0
highfreq: 8000
window: hann
But can you explain why this error occured?
Both my FastPitch model and tts_en_hifitts_hifigan_ft_fastpitch.nemo contain in their config: n_window_stride: 512 | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6330/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6330/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6329 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6329/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6329/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6329/events | https://github.com/NVIDIA/NeMo/issues/6329 | 1,647,392,209 | I_kwDOC_bI7s5iMTXR | 6,329 | Support of other asr models | {
"login": "viralrupapara36",
"id": 104073221,
"node_id": "U_kgDOBjQIBQ",
"avatar_url": "https://avatars.githubusercontent.com/u/104073221?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/viralrupapara36",
"html_url": "https://github.com/viralrupapara36",
"followers_url": "https://api.github.com/users/viralrupapara36/followers",
"following_url": "https://api.github.com/users/viralrupapara36/following{/other_user}",
"gists_url": "https://api.github.com/users/viralrupapara36/gists{/gist_id}",
"starred_url": "https://api.github.com/users/viralrupapara36/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/viralrupapara36/subscriptions",
"organizations_url": "https://api.github.com/users/viralrupapara36/orgs",
"repos_url": "https://api.github.com/users/viralrupapara36/repos",
"events_url": "https://api.github.com/users/viralrupapara36/events{/privacy}",
"received_events_url": "https://api.github.com/users/viralrupapara36/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-03-30T11:03:03 | 2023-05-21T01:56:51 | 2023-05-21T01:56:51 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I have customised wav2vec model for my asr task and I want to use it in this diarization pipeline but I can't do it, because it is not supported.
Please, update the library so that we can use any pytorch models. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6329/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6329/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6328 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6328/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6328/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6328/events | https://github.com/NVIDIA/NeMo/issues/6328 | 1,647,295,919 | I_kwDOC_bI7s5iL72v | 6,328 | TypeError in RNNTJoint | {
"login": "kokamido",
"id": 7046074,
"node_id": "MDQ6VXNlcjcwNDYwNzQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/7046074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kokamido",
"html_url": "https://github.com/kokamido",
"followers_url": "https://api.github.com/users/kokamido/followers",
"following_url": "https://api.github.com/users/kokamido/following{/other_user}",
"gists_url": "https://api.github.com/users/kokamido/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kokamido/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kokamido/subscriptions",
"organizations_url": "https://api.github.com/users/kokamido/orgs",
"repos_url": "https://api.github.com/users/kokamido/repos",
"events_url": "https://api.github.com/users/kokamido/events{/privacy}",
"received_events_url": "https://api.github.com/users/kokamido/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-03-30T09:59:15 | 2023-04-03T09:17:22 | 2023-03-31T04:54:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hi. In my scenario `RNNTJoint.forward` produces TypeError and error message is
```
narrow() received an invalid combination of arguments - got (length=Tensor, start=int, dim=int, ), but expected one of:
* (int dim, Tensor start, int length)
didn't match because some of the arguments have invalid types: (dim=int, start=int, length=Tensor, )
* (int dim, int start, int length)
didn't match because some of the arguments have invalid types: (dim=int, start=int, length=Tensor )
```
**Steps/Code to reproduce bug**
I faced this issue with nemo-toolkit==1.12 but it looks like problem still exists in the version 1.16.
The nature of the error itself can be shown using the following code:
```python
import torch
a = torch.Tensor([0,1,1])
max_a = a.max()
a.narrow(dim=0, start=0, length = max_a)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-1-1104b945c0b8> in <cell line: 4>()
2 a = torch.Tensor([0,1,1])
3 max_a = a.max()
----> 4 a.narrow(dim=0, start=0, length = max_a)
TypeError: narrow() received an invalid combination of arguments - got (length=Tensor, start=int, dim=int, ), but expected one of:
* (int dim, Tensor start, int length)
didn't match because some of the arguments have invalid types: (dim=int, !start=int!, !length=Tensor!, )
* (int dim, int start, int length)
didn't match because some of the arguments have invalid types: (dim=int, start=int, !length=Tensor!, )
```
And there is the similar code in the [nemo 1.12](https://github.com/NVIDIA/NeMo/blob/dd9a30f55b7ec308cc3b55751e8ae5aa40f36a62/nemo/collections/asr/modules/rnnt.py#L1311
) (lines 1297 and 1311) as well as in the [nemo 1.16](https://github.com/NVIDIA/NeMo/blob/163111870e78a2a7224953a89b6af5ac71cb8ed9/nemo/collections/asr/modules/rnnt.py#L1315) (lines 1301 and 1315)
In order to reproduce this behavior you have to make the condition `sub_dec.shape[1] != max_sub_transcript_length + 1` true. In my scenario, this is true because I use several hacks around my own custom dataset and dataloader that applies padding to the data if "time" dimension of tensor is not a multiple of 128. But I'm quite sure there is a cleaner way to fulfill the condition, and it looks like the code will throw this error every time the condition is met.
Replacement `max_sub_transcript_length = sub_transcript_lens.max()` -> `max_sub_transcript_length = int(sub_transcript_lens.max().item())` applied [here](https://github.com/NVIDIA/NeMo/blob/dd9a30f55b7ec308cc3b55751e8ae5aa40f36a62/nemo/collections/asr/modules/rnnt.py#L1297) fixes the issue for me.
**Expected behavior**
The line `sub_dec = sub_dec.narrow(dim=1, start=0, length=max_sub_transcript_length + 1)` can be executed without rising TypeError
**Environment overview (please complete the following information)**
- Environment location: Docker, image is based on cuda:11.3.1-cudnn8-devel-ubuntu20.04
- Method of NeMo install: `pip install nemo-toolkit['all']==1.12.0`
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- Ubuntu20.04
- PyTorch version 1.10.1 (but the cause of the problem persists in 1.13.1 )
- Python version 3.9.7
**Additional context**
I have an additional question about the code I mentioned in this issue. There is a couple of comments that says:
```
# Reduce decoder length to preserve computation
# Decoder: [sub-batch, U, D] -> [sub-batch, U', D]; U' < U
if sub_dec.shape[1] != max_sub_transcript_length + 1:
sub_dec = sub_dec.narrow(dim=1, start=0, length=max_sub_transcript_length + 1)
```
I understand that we can remove the padding here in order to reduce memory consumption and computation time of the joint layer but we (probably) still have a lot of padding in the decoder output if our batch contains transcriptions of different lengths. As afs as I know current implementation of RNNT will process this padding in the joint layer and there is no way to reduce related computation and memory costs. Is it correct? | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6328/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6328/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6327 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6327/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6327/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6327/events | https://github.com/NVIDIA/NeMo/pull/6327 | 1,646,692,608 | PR_kwDOC_bI7s5NNptr | 6,327 | Add ability to enable/disable act ckpt and seq parallelism in GPT | {
"login": "markelsanz14",
"id": 10426497,
"node_id": "MDQ6VXNlcjEwNDI2NDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/10426497?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/markelsanz14",
"html_url": "https://github.com/markelsanz14",
"followers_url": "https://api.github.com/users/markelsanz14/followers",
"following_url": "https://api.github.com/users/markelsanz14/following{/other_user}",
"gists_url": "https://api.github.com/users/markelsanz14/gists{/gist_id}",
"starred_url": "https://api.github.com/users/markelsanz14/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/markelsanz14/subscriptions",
"organizations_url": "https://api.github.com/users/markelsanz14/orgs",
"repos_url": "https://api.github.com/users/markelsanz14/repos",
"events_url": "https://api.github.com/users/markelsanz14/events{/privacy}",
"received_events_url": "https://api.github.com/users/markelsanz14/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-29T23:54:18 | 2023-04-13T22:55:07 | 2023-04-13T22:55:06 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6327",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6327",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6327.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6327.patch",
"merged_at": "2023-04-13T22:55:06"
} | # What does this PR do ?
Adds functions to enable and disable activation checkpointing and sequence parallelism. This way, we can enable them during training and disable them during inference/generation.
**Collection**: nemo/collections/nlp/language_modeling
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "markelsanz14",
"id": 10426497,
"node_id": "MDQ6VXNlcjEwNDI2NDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/10426497?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/markelsanz14",
"html_url": "https://github.com/markelsanz14",
"followers_url": "https://api.github.com/users/markelsanz14/followers",
"following_url": "https://api.github.com/users/markelsanz14/following{/other_user}",
"gists_url": "https://api.github.com/users/markelsanz14/gists{/gist_id}",
"starred_url": "https://api.github.com/users/markelsanz14/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/markelsanz14/subscriptions",
"organizations_url": "https://api.github.com/users/markelsanz14/orgs",
"repos_url": "https://api.github.com/users/markelsanz14/repos",
"events_url": "https://api.github.com/users/markelsanz14/events{/privacy}",
"received_events_url": "https://api.github.com/users/markelsanz14/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6327/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6327/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6326 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6326/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6326/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6326/events | https://github.com/NVIDIA/NeMo/pull/6326 | 1,646,343,385 | PR_kwDOC_bI7s5NMe3s | 6,326 | simplified notebook for p-tuning | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-29T18:52:09 | 2023-03-31T13:51:08 | 2023-03-31T13:51:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6326",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6326",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6326.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6326.patch",
"merged_at": "2023-03-31T13:51:07"
} | # What does this PR do ?
Simplified the notebook for p-tuning. Sticks to a simple single task training and inference.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6326/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6326/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6325 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6325/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6325/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6325/events | https://github.com/NVIDIA/NeMo/pull/6325 | 1,646,033,646 | PR_kwDOC_bI7s5NLb1Y | 6,325 | Restore Thutmose Tagger tutorial, move it to nlp | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-29T15:16:58 | 2023-03-30T08:36:29 | 2023-03-29T20:28:47 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6325",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6325",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6325.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6325.patch",
"merged_at": "2023-03-29T20:28:47"
} | Restore Thutmose Tagger tutorial, move it to nlp (earlier it was in text_processing)
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6325/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6325/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6324 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6324/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6324/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6324/events | https://github.com/NVIDIA/NeMo/pull/6324 | 1,645,990,305 | PR_kwDOC_bI7s5NLSSP | 6,324 | Move checkpoint consolidation to cpu | {
"login": "wdykas",
"id": 73254672,
"node_id": "MDQ6VXNlcjczMjU0Njcy",
"avatar_url": "https://avatars.githubusercontent.com/u/73254672?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/wdykas",
"html_url": "https://github.com/wdykas",
"followers_url": "https://api.github.com/users/wdykas/followers",
"following_url": "https://api.github.com/users/wdykas/following{/other_user}",
"gists_url": "https://api.github.com/users/wdykas/gists{/gist_id}",
"starred_url": "https://api.github.com/users/wdykas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wdykas/subscriptions",
"organizations_url": "https://api.github.com/users/wdykas/orgs",
"repos_url": "https://api.github.com/users/wdykas/repos",
"events_url": "https://api.github.com/users/wdykas/events{/privacy}",
"received_events_url": "https://api.github.com/users/wdykas/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-29T14:55:07 | 2023-04-22T01:51:52 | 2023-04-22T01:51:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6324",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6324",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6324.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6324.patch",
"merged_at": null
} | # What does this PR do ?
This aims to move the megatron checkpoint to nemo conversion to cpu rather than using pytorch distributed following additions introduced [here](https://github.com/NVIDIA/NeMo/pull/6218). This is useful for large models where the user may have checkpoints to consolidate but don't want to use the massive amount of gpus just for conversion.
**Collection**: [NLP]
# Changelog
- Change megatron_ckpt_to_nemo.py to use CPU only
# Usage
```python
python3 megatron_ckpt_to_nemo.py \
--checkpoint_folder <path_to_PTL_checkpoints_folder> \
--checkpoint_name <checkpoint_name> \
--nemo_file_path <path_to_output_nemo_file> \
--tensor_model_parallel_size <tensor_model_parallel_size>\
--pipeline_model_parallel_size <pipeline_model_parallel_size> \
--model_type <model type>
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6324/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6324/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6323 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6323/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6323/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6323/events | https://github.com/NVIDIA/NeMo/pull/6323 | 1,645,924,575 | PR_kwDOC_bI7s5NLD5E | 6,323 | Correctly determine ZERO_LEVEL_SPEC_DB_VAL which affects normalization for first signal buffer | {
"login": "vidklopcic",
"id": 8578790,
"node_id": "MDQ6VXNlcjg1Nzg3OTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/8578790?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vidklopcic",
"html_url": "https://github.com/vidklopcic",
"followers_url": "https://api.github.com/users/vidklopcic/followers",
"following_url": "https://api.github.com/users/vidklopcic/following{/other_user}",
"gists_url": "https://api.github.com/users/vidklopcic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vidklopcic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vidklopcic/subscriptions",
"organizations_url": "https://api.github.com/users/vidklopcic/orgs",
"repos_url": "https://api.github.com/users/vidklopcic/repos",
"events_url": "https://api.github.com/users/vidklopcic/events{/privacy}",
"received_events_url": "https://api.github.com/users/vidklopcic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-29T14:22:12 | 2023-03-31T14:40:22 | 2023-03-31T14:40:22 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6323",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6323",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6323.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6323.patch",
"merged_at": null
} | # What does this PR do ?
If asr_model has preprocessor of type `AudioToMelSpectrogramPreprocessor`, `AudioToSpectrogram`, `AudioToMFCCPreprocessor`, etc., the `StreamingFeatureBufferer` incorrectly determines whether it uses log scale.
Instead of checking for 'log' attribute directly on preprocessor instance, it should check on the `preprocessor.featurizer` instance, which exposes the `log` property.
Therefore, the first few frames (until the generated silence is replaced by an actual audio signal) get incorrectly normalized and the model output is poor or absent.
First frame with incorrect `ZERO_LEVEL_SPEC_DB_VAL`:
First frame with correct `ZERO_LEVEL_SPEC_DB_VAL`:
**Collection**: asr (`nemo.collections.asr.parts.utils.streaming_utils`)
# Changelog
- `nemo.collections.asr.parts.utils.streaming_utils:365`
Checking for `asr_model.preprocessor.log` always resulted in False, as the `AudioToMelSpectrogramPreprocessor` doesn't define `log` property. Therefore I added an additional check for `asr_model.preprocessor.featurizer.log`.
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "vidklopcic",
"id": 8578790,
"node_id": "MDQ6VXNlcjg1Nzg3OTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/8578790?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vidklopcic",
"html_url": "https://github.com/vidklopcic",
"followers_url": "https://api.github.com/users/vidklopcic/followers",
"following_url": "https://api.github.com/users/vidklopcic/following{/other_user}",
"gists_url": "https://api.github.com/users/vidklopcic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vidklopcic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vidklopcic/subscriptions",
"organizations_url": "https://api.github.com/users/vidklopcic/orgs",
"repos_url": "https://api.github.com/users/vidklopcic/repos",
"events_url": "https://api.github.com/users/vidklopcic/events{/privacy}",
"received_events_url": "https://api.github.com/users/vidklopcic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6323/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6323/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6321 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6321/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6321/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6321/events | https://github.com/NVIDIA/NeMo/issues/6321 | 1,645,304,239 | I_kwDOC_bI7s5iEVmv | 6,321 | Numba error while fine-tuning an ASR model | {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-03-29T08:42:56 | 2023-05-12T01:50:29 | 2023-05-12T01:50:29 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When fine-tuning an ASR model, at some point throughout the first epoch of training, a Numba error occurs:
```
numba.cuda.cudadrv.driver.CudaAPIError: [1] Call to cuLaunchKernel results in CUDA_ERROR_INVALID_VALUE
```
**Steps/Code to reproduce bug**
Here is the code I run:
```python
import os
from argparse import ArgumentParser
from shutil import rmtree
import pytorch_lightning as pl
from pytorch_lightning.loggers import TensorBoardLogger
from pytorch_lightning.callbacks import ModelCheckpoint
from pytorch_lightning.strategies.ddp import DDPStrategy
from nemo.collections.asr.models.rnnt_bpe_models import EncDecRNNTBPEModel
from omegaconf import OmegaConf
def main(args):
trainer = pl.Trainer(
strategy=DDPStrategy(find_unused_parameters=False),
accelerator=args.accelerator,
num_nodes=args.devices,
max_epochs=2,
)
config = OmegaConf.load(args.config)
model = EncDecRNNTBPEModel.from_pretrained("stt_en_conformer_transducer_large")
train_dl = model._setup_dataloader_from_config(config.train)
test_dl = model._setup_dataloader_from_config(config.test)
model.setup_optimization(config.optim)
trainer.fit(model, train_dl, test_dl)
if __name__ == "__main__":
parser = ArgumentParser()
parser.add_argument("--config", default="config.yaml")
parser.add_argument("--accelerator", default="gpu")
parser.add_argument("--devices", default="1")
args = parser.parse_args()
main(args)
```
Here is the config:
```yaml
train:
manifest_filepath: train.txt
sample_rate: 16000
batch_size: 1
num_workers: 10
pin_memory: true
use_start_end_token: false
trim_silence: false
max_duration: 20.0
min_duration: 0.1
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
bucketing_strategy: "synced_randomized"
bucketing_batch_size: null
return_sample_id: false
drop_last: false
shuffle: false
test:
manifest_filepath: test.txt
sample_rate: 16000
batch_size: 1
num_workers: 10
pin_memory: true
use_start_end_token: false
trim_silence: false
max_duration: 20.0
min_duration: 0.1
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
bucketing_strategy: "synced_randomized"
bucketing_batch_size: null
return_sample_id: false
drop_last: false
shuffle: false
optim:
name: adamw
lr: 0.00001 # maximal learning rate
betas: [0.9, 0.98]
weight_decay: 0.001
```
Attached is a zip file that contains these files, as well as the data files. The data comes from English Common Voice 10.0. The audiofiles are MP3 files.
**Environment overview (please complete the following information)**
I have tried several Nemo images (1.15, 1.13, 1.10) from the Nvidia NGC cloud, and the error still persists. Our cluster runs on Enroot containers, so I import the Docker image with `enroot import`. The training starts as expected, and the predictions are always close to the references, until the Numba error occurs.
**Additional context**
I had already discussed this issue with @titu1994 on issue #5929. He suggested using the NeMo images, but it didn't solve the problem. I would appreciate any further suggestions. Thank you for your time.
Here is the ZIP file containing everything needed to reproduce my issue:
[debug_asr.zip](https://github.com/NVIDIA/NeMo/files/11098389/debug_asr.zip)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6321/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6321/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/6320 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6320/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6320/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6320/events | https://github.com/NVIDIA/NeMo/pull/6320 | 1,645,075,492 | PR_kwDOC_bI7s5NILod | 6,320 | Fixing bug in unsort_tensor | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-29T05:45:39 | 2023-03-31T19:02:35 | 2023-03-31T19:02:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6320",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6320",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6320.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6320.patch",
"merged_at": "2023-03-31T19:02:35"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6320/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6320/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6319 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6319/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6319/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6319/events | https://github.com/NVIDIA/NeMo/pull/6319 | 1,644,787,492 | PR_kwDOC_bI7s5NHOqM | 6,319 | added RPE + fixed RMSNorm | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-28T23:23:51 | 2023-04-04T16:04:10 | 2023-04-04T16:04:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6319",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6319",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6319.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6319.patch",
"merged_at": "2023-04-04T16:04:09"
} | # What does this PR do ?
- Added RPE for MegatronNMT models
- Fixed an issue with RMSNorm
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6319/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6319/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/6318 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/6318/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/6318/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/6318/events | https://github.com/NVIDIA/NeMo/pull/6318 | 1,644,734,364 | PR_kwDOC_bI7s5NHDgg | 6,318 | Make AIS CLI installation optional | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-03-28T22:21:46 | 2023-03-28T23:07:01 | 2023-03-28T23:07:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/6318",
"html_url": "https://github.com/NVIDIA/NeMo/pull/6318",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/6318.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/6318.patch",
"merged_at": "2023-03-28T23:07:00"
} | # What does this PR do ?
This PR makes installation of AIS CLI optional.
**Collection**: Dockerfile
# Changelog
- Update `Dockerfile` to install AIS CLI only if `REQUIRE_AIS_CLI == true`
- Added an installer script for AIS CLI
# Usage
AIS CLI can be installed by setting `REQUIRE_AIS_CLI=true`, for example:
```bash
docker ... --build-arg REQUIRE_AIS_CLI=true
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/6318/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/6318/timeline | null | null | true |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.