url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/5792 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5792/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5792/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5792/events | https://github.com/NVIDIA/NeMo/issues/5792 | 1,531,607,740 | I_kwDOC_bI7s5bSnq8 | 5,792 | TS-Exported SpeakerNet model has vastly different outputs than non-exported model. | {
"login": "shawnbzhang",
"id": 52870276,
"node_id": "MDQ6VXNlcjUyODcwMjc2",
"avatar_url": "https://avatars.githubusercontent.com/u/52870276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shawnbzhang",
"html_url": "https://github.com/shawnbzhang",
"followers_url": "https://api.github.com/users/shawnbzhang/followers",
"following_url": "https://api.github.com/users/shawnbzhang/following{/other_user}",
"gists_url": "https://api.github.com/users/shawnbzhang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shawnbzhang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shawnbzhang/subscriptions",
"organizations_url": "https://api.github.com/users/shawnbzhang/orgs",
"repos_url": "https://api.github.com/users/shawnbzhang/repos",
"events_url": "https://api.github.com/users/shawnbzhang/events{/privacy}",
"received_events_url": "https://api.github.com/users/shawnbzhang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-13T02:12:24 | 2023-02-20T02:01:32 | 2023-02-20T02:01:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I have exported the pre-trained SpeakerNet model into TorchScript. With the same data input, I am calling this exported model and its original non-exported model but the results are vastly different.
**Steps/Code to reproduce bug**
```
processed_signal = ... # torch.Size([1, 64, 416])
processed_signal_len = ... # torch.Size([1])
# Load original pre-trained model.
from nemo.collections.asr.models import EncDecSpeakerLabelModel
original_encoder = EncDecSpeakerLabelModel.from_pretrained(
model_name="speakerverification_speakernet"
)
original_encoder.eval()
# Export pre-trained model to TorchScript.
original_encoder.export('exported_encoder.ts')
# Original model's inference.
original_logits, original_embs = original_encoder.forward_for_export(processed_signal, processed_signal_len)
# Exported model's inference.
exported_encoder = torch.jit.load('exported_encoder.ts')
exported_logits, exported_embs = exported_encoder.forward(processed_signal=processed_signal, processed_signal_len=processed_signal_len)
```
However, I can see that `original_embs` and `exported_embs` is vastly different. This is very confusing to me.
**Expected behavior**
I would expect that the original model's and exported model's prediction to be the same (or at least very close to same).
**Environment overview (please complete the following information)**
Environment location is GCP. Method of install is from pip.
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version = Debian GNU/Linux
- PyTorch version = 1.11.0+cu113
- Python version = 3.7.12 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5792/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5792/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5791 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5791/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5791/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5791/events | https://github.com/NVIDIA/NeMo/pull/5791 | 1,531,497,621 | PR_kwDOC_bI7s5HSahs | 5,791 | Adithyare/adapter new placement | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T23:50:20 | 2023-01-23T19:37:19 | 2023-01-23T19:09:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5791",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5791",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5791.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5791.patch",
"merged_at": "2023-01-23T19:09:43"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5791/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5791/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5790 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5790/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5790/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5790/events | https://github.com/NVIDIA/NeMo/pull/5790 | 1,531,484,477 | PR_kwDOC_bI7s5HSXyf | 5,790 | Flashlight Decoder for Nemo | {
"login": "trias702",
"id": 25867060,
"node_id": "MDQ6VXNlcjI1ODY3MDYw",
"avatar_url": "https://avatars.githubusercontent.com/u/25867060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/trias702",
"html_url": "https://github.com/trias702",
"followers_url": "https://api.github.com/users/trias702/followers",
"following_url": "https://api.github.com/users/trias702/following{/other_user}",
"gists_url": "https://api.github.com/users/trias702/gists{/gist_id}",
"starred_url": "https://api.github.com/users/trias702/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/trias702/subscriptions",
"organizations_url": "https://api.github.com/users/trias702/orgs",
"repos_url": "https://api.github.com/users/trias702/repos",
"events_url": "https://api.github.com/users/trias702/events{/privacy}",
"received_events_url": "https://api.github.com/users/trias702/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T23:26:57 | 2023-02-04T00:14:19 | 2023-01-14T01:35:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5790",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5790",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5790.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5790.patch",
"merged_at": "2023-01-14T01:35:06"
} | # What does this PR do ?
Adds Flashlight decoding to Nemo
**Collection**: ASR
# Changelog
- Added flashlight_decoder.py to collections/asr/modules
- Changed collections/asr/metrics/wer.py and wer_bpe.py to support new setter methods for ctc_decoding object
- Changed collections/asr/parts/submodules/ctc_beam_decoding.py to include all of the new logic for Flashlight decoding which uses the new beam search API
- Added script to scripts/asr_language_modeling/ngram_lm which creates Flashlight format lexicon files from KenLM arpa files
# Usage
Works for lexicon and lexicon-free flashlight decoding
```python
import torch
from nemo.collections.asr.models import ASRModel
from nemo.collections.asr.metrics.wer import CTCDecodingConfig
device = torch.device('cuda')
asr_model = ASRModel.restore_from(...).to(device)
files = ['/path/to/audio1.wav', '/path/to/audio2.wav']
# Lexicon-based
decoding_cfg = CTCDecodingConfig()
decoding_cfg.strategy = "flashlight"
decoding_cfg.beam.search_type = "flashlight"
decoding_cfg.beam.kenlm_path = '/path/to/kenlm.bin'
decoding_cfg.beam.flashlight_cfg.lexicon_path='/path/to/lexicon.lexicon'
decoding_cfg.beam.beam_size = 32
decoding_cfg.beam.beam_alpha = 0.2
decoding_cfg.beam.beam_beta = 0.2
decoding_cfg.beam.flashlight_cfg.beam_size_token = 32
decoding_cfg.beam.flashlight_cfg.beam_threshold = 25.0
# Lexicon-free (for char based languages like Japanese)
decoding_cfg = CTCDecodingConfig()
decoding_cfg.strategy = "flashlight"
decoding_cfg.beam.search_type = "flashlight"
decoding_cfg.beam.kenlm_path = '/path/to/kenlm.bin'
decoding_cfg.beam.flashlight_cfg.lexicon_path=None
decoding_cfg.beam.beam_size = 32
decoding_cfg.beam.beam_alpha = 0.2
decoding_cfg.beam.beam_beta = 0.2
decoding_cfg.beam.flashlight_cfg.beam_size_token = 32
decoding_cfg.beam.flashlight_cfg.beam_threshold = 25.0
decoding_cfg.beam.flashlight_cfg.unit_lm = True
asr_model.change_decoding_strategy(decoding_cfg)
transcripts = asr_model.transcribe(paths2audio_files=files, batch_size=2, return_hypotheses=False, logprobs=False)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [X] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [X] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [X] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5790/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5790/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5789 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5789/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5789/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5789/events | https://github.com/NVIDIA/NeMo/pull/5789 | 1,531,069,723 | PR_kwDOC_bI7s5HQ-Oz | 5,789 | Update numpy requirements from 1.21 to 1.22 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-12T17:00:18 | 2023-01-12T20:43:49 | 2023-01-12T20:43:45 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5789",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5789",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5789.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5789.patch",
"merged_at": "2023-01-12T20:43:45"
} | Seeking to overcome this issue UserWarning: Failed to initialize NumPy: module compiled against API version 0xf but this version of numpy is 0xe based on https://iq.opengenus.org/module-compiled-against-api-version-0x10-but-this-version-of-numpy-is-0xe/
Note: this warning actually causes a crash later one when trying to import things from numpy typing
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: NLP, ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5789/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5789/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5788 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5788/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5788/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5788/events | https://github.com/NVIDIA/NeMo/pull/5788 | 1,530,989,064 | PR_kwDOC_bI7s5HQskv | 5,788 | Update radtts' infer path | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T16:09:09 | 2023-01-16T13:55:24 | 2023-01-16T13:55:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5788",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5788",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5788.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5788.patch",
"merged_at": "2023-01-16T13:55:20"
} | # What does this PR do ?
Update radtts' infer path.
**Collection**: TTS
# Changelog
- Update radtts' infer path
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5788/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5788/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5787 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5787/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5787/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5787/events | https://github.com/NVIDIA/NeMo/pull/5787 | 1,530,053,916 | PR_kwDOC_bI7s5HNg5Y | 5,787 | fix token id bug | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T03:58:20 | 2023-01-12T22:42:33 | 2023-01-12T22:42:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5787",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5787",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5787.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5787.patch",
"merged_at": "2023-01-12T22:42:29"
} | fixed the tokenizer bug, add `bos_id` to the tabular tokenizer | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5787/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5787/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5786 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5786/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5786/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5786/events | https://github.com/NVIDIA/NeMo/issues/5786 | 1,530,051,036 | I_kwDOC_bI7s5bMrnc | 5,786 | Finetune the pretrained nemo model | {
"login": "GarimaNarang",
"id": 42312456,
"node_id": "MDQ6VXNlcjQyMzEyNDU2",
"avatar_url": "https://avatars.githubusercontent.com/u/42312456?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GarimaNarang",
"html_url": "https://github.com/GarimaNarang",
"followers_url": "https://api.github.com/users/GarimaNarang/followers",
"following_url": "https://api.github.com/users/GarimaNarang/following{/other_user}",
"gists_url": "https://api.github.com/users/GarimaNarang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GarimaNarang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GarimaNarang/subscriptions",
"organizations_url": "https://api.github.com/users/GarimaNarang/orgs",
"repos_url": "https://api.github.com/users/GarimaNarang/repos",
"events_url": "https://api.github.com/users/GarimaNarang/events{/privacy}",
"received_events_url": "https://api.github.com/users/GarimaNarang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-12T03:53:23 | 2023-02-25T02:00:29 | 2023-02-25T02:00:29 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | python speech_to_text_ctc_bpe.py --config-path=“/path/to/confiig/file” --config-name=“conformer_ctc_bpe_v13” trainer.max_epochs=50 +init_from_nemo_model=“path/to/stt_hi_conformer_ctc_medium.nemo”
Getting error as shown below:
from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.norm_self_att.weight: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.norm_self_att.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.self_attn.pos_bias_u: copying a param with shape torch.Size([4, 64]) from checkpoint, the shape in current model is torch.Size([8, 64]).
size mismatch for encoder.layers.17.self_attn.pos_bias_v: copying a param with shape torch.Size([4, 64]) from checkpoint, the shape in current model is torch.Size([8, 64]).
size mismatch for encoder.layers.17.self_attn.linear_q.weight: copying a param with shape torch.Size([256, 256]) from checkpoint, the shape in current model is torch.Size([512, 512]).
size mismatch for encoder.layers.17.self_attn.linear_q.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.self_attn.linear_k.weight: copying a param with shape torch.Size([256, 256]) from checkpoint, the shape in current model is torch.Size([512, 512]).
size mismatch for encoder.layers.17.self_attn.linear_k.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.self_attn.linear_v.weight: copying a param with shape torch.Size([256, 256]) from checkpoint, the shape in current model is torch.Size([512, 512]).
size mismatch for encoder.layers.17.self_attn.linear_v.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.self_attn.linear_out.weight: copying a param with shape torch.Size([256, 256]) from checkpoint, the shape in current model is torch.Size([512, 512]).
size mismatch for encoder.layers.17.self_attn.linear_out.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.self_attn.linear_pos.weight: copying a param with shape torch.Size([256, 256]) from checkpoint, the shape in current model is torch.Size([512, 512]).
size mismatch for encoder.layers.17.norm_feed_forward2.weight: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.norm_feed_forward2.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.feed_forward2.linear1.weight: copying a param with shape torch.Size([1024, 256]) from checkpoint, the shape in current model is torch.Size([2048, 512]).
size mismatch for encoder.layers.17.feed_forward2.linear1.bias: copying a param with shape torch.Size([1024]) from checkpoint, the shape in current model is torch.Size([2048]).
size mismatch for encoder.layers.17.feed_forward2.linear2.weight: copying a param with shape torch.Size([256, 1024]) from checkpoint, the shape in current model is torch.Size([512, 2048]).
size mismatch for encoder.layers.17.feed_forward2.linear2.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.norm_out.weight: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for encoder.layers.17.norm_out.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
size mismatch for decoder.decoder_layers.0.weight: copying a param with shape torch.Size([129, 256, 1]) from checkpoint, the shape in current model is torch.Size([129, 512, 1]).
Can you please help out with the error?
<img width="947" alt="Screenshot 2023-01-11 at 12 34 53 PM" src="https://user-images.githubusercontent.com/42312456/211971875-1df94c67-82a3-4223-8a6e-8501e1d677c9.png">
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5786/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5786/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5785 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5785/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5785/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5785/events | https://github.com/NVIDIA/NeMo/pull/5785 | 1,530,028,363 | PR_kwDOC_bI7s5HNbhh | 5,785 | Update numpy requirements from 1.21 to 1.22 | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-12T03:14:53 | 2023-01-12T16:59:48 | 2023-01-12T16:59:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5785",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5785",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5785.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5785.patch",
"merged_at": "2023-01-12T16:59:32"
} | Seeking to overcome this issue UserWarning: Failed to initialize NumPy: module compiled against API version 0xf but this version of numpy is 0xe based on https://iq.opengenus.org/module-compiled-against-api-version-0x10-but-this-version-of-numpy-is-0xe/
Note: this warning actually causes a crash later one when trying to import things from numpy typing
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: NLP, ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5785/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5785/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5784 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5784/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5784/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5784/events | https://github.com/NVIDIA/NeMo/pull/5784 | 1,529,997,524 | PR_kwDOC_bI7s5HNU_m | 5,784 | [TTS][ZH] bugfix import jieba errors. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T02:26:45 | 2023-01-12T05:08:17 | 2023-01-12T05:08:14 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5784",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5784",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5784.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5784.patch",
"merged_at": "2023-01-12T05:08:14"
} | There was a bug which hits errors below. This PR fixed the error by importing `jieba` correctly.
```
21 Error executing job with overrides: ['++dataloader_params.num_workers=48', 'manifest_filepath=/manifest/train_manifest.json', 'sup_data_path=/sup_data']
22 Traceback (most recent call last):
23 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 92, in _call_target
24 return _target_(*args, **kwargs)
25 File "/code/nemo/collections/tts/torch/data.py", line 241, in __init__
26 file_info["text_tokens"] = self.text_tokenizer(file_info["normalized_text"])
27 File "/code/nemo/collections/common/tokenizers/text_to_speech/tts_tokenizers.py", line 74, in __call__
28 return self.encode(text)
29 File "/code/nemo/collections/common/tokenizers/text_to_speech/tts_tokenizers.py", line 723, in encode
30 g2p_text = self.g2p(text) # TODO: handle infer
31 File "/code/nemo_text_processing/g2p/modules.py", line 617, in __call__
32 words_list = list(jieba.cut(text))
33 NameError: name 'jieba' is not defined
34
35 The above exception was the direct cause of the following exception:
36
37 Traceback (most recent call last):
38 File "scripts/dataset_processing/tts/extract_sup_data.py", line 83, in <module>
39 main() # noqa pylint: disable=no-value-for-parameter
40 File "/code/nemo/core/config/hydra_runner.py", line 105, in wrapper
41 _run_hydra(
42 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 389, in _run_hydra
43 _run_app(
44 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 452, in _run_app
45 run_and_report(
46 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 216, in run_and_report
47 raise ex
48 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 213, in run_and_report
49 return func()
50 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 453, in <lambda>
51 lambda: hydra.run(
52 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/hydra.py", line 132, in run
53 _ = ret.return_value
54 File "/usr/local/lib/python3.8/dist-packages/hydra/core/utils.py", line 260, in return_value
55 raise self._return_value
56 File "/usr/local/lib/python3.8/dist-packages/hydra/core/utils.py", line 186, in run_job
57 ret.return_value = task_function(task_cfg)
58 File "scripts/dataset_processing/tts/extract_sup_data.py", line 70, in main
59 dataset = instantiate(cfg.dataset)
60 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 222, in instantiate
61 return instantiate_node(
62 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 339, in instantiate_node
63 return _call_target(_target_, partial, args, kwargs, full_key)
64 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 97, in _call_target
65 raise InstantiationException(msg) from e
66 hydra.errors.InstantiationException: Error in call to target 'nemo.collections.tts.torch.data.TTSDataset':
67 NameError("name 'jieba' is not defined")
68 full_key: dataset
```
Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5784/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5784/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5783 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5783/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5783/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5783/events | https://github.com/NVIDIA/NeMo/pull/5783 | 1,529,938,649 | PR_kwDOC_bI7s5HNIMe | 5,783 | Megatron export triton update | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T01:12:08 | 2023-01-12T22:41:53 | 2023-01-12T22:41:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5783",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5783",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5783.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5783.patch",
"merged_at": "2023-01-12T22:41:49"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- updating biased gelu
- minor updates to mimic nemo nmt
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5783/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5783/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5782 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5782/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5782/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5782/events | https://github.com/NVIDIA/NeMo/pull/5782 | 1,529,902,283 | PR_kwDOC_bI7s5HNAZp | 5,782 | Update torchaudio dependency version for tutorials | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T00:20:48 | 2023-01-12T03:09:56 | 2023-01-12T03:09:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5782",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5782",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5782.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5782.patch",
"merged_at": "2023-01-12T03:09:53"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Update torchaudio dependency in tutorials to avoid issue with torch.stft signature.
**Collection**: [ASR]
# Changelog
- Update tutorial dependency for torchaudio
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5782/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5782/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5781 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5781/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5781/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5781/events | https://github.com/NVIDIA/NeMo/pull/5781 | 1,529,901,834 | PR_kwDOC_bI7s5HNAT3 | 5,781 | Update torchaudio dependency version for tutorials | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T00:19:59 | 2023-01-12T00:20:21 | 2023-01-12T00:20:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5781",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5781",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5781.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5781.patch",
"merged_at": "2023-01-12T00:20:18"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Update torchaudio dependency in tutorials to avoid issue with torch.stft signature.
**Collection**: [ASR]
# Changelog
- Update tutorial dependency for torchaudio
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5781/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5781/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5780 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5780/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5780/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5780/events | https://github.com/NVIDIA/NeMo/pull/5780 | 1,529,892,948 | PR_kwDOC_bI7s5HM-Zq | 5,780 | set max_steps for lr decay through config | {
"login": "anmolgupt",
"id": 14880251,
"node_id": "MDQ6VXNlcjE0ODgwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14880251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anmolgupt",
"html_url": "https://github.com/anmolgupt",
"followers_url": "https://api.github.com/users/anmolgupt/followers",
"following_url": "https://api.github.com/users/anmolgupt/following{/other_user}",
"gists_url": "https://api.github.com/users/anmolgupt/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anmolgupt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anmolgupt/subscriptions",
"organizations_url": "https://api.github.com/users/anmolgupt/orgs",
"repos_url": "https://api.github.com/users/anmolgupt/repos",
"events_url": "https://api.github.com/users/anmolgupt/events{/privacy}",
"received_events_url": "https://api.github.com/users/anmolgupt/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-12T00:06:15 | 2023-02-01T17:53:11 | 2023-02-01T17:53:10 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5780",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5780",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5780.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5780.patch",
"merged_at": "2023-02-01T17:53:10"
} | # What does this PR do ?
Allows setting lr decay steps through config that could be different from the trainer.max_steps
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5780/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5780/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5779 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5779/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5779/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5779/events | https://github.com/NVIDIA/NeMo/issues/5779 | 1,529,833,554 | I_kwDOC_bI7s5bL2hS | 5,779 | DALI fails in mulit-node setup | {
"login": "msis",
"id": 577139,
"node_id": "MDQ6VXNlcjU3NzEzOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/577139?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/msis",
"html_url": "https://github.com/msis",
"followers_url": "https://api.github.com/users/msis/followers",
"following_url": "https://api.github.com/users/msis/following{/other_user}",
"gists_url": "https://api.github.com/users/msis/gists{/gist_id}",
"starred_url": "https://api.github.com/users/msis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/msis/subscriptions",
"organizations_url": "https://api.github.com/users/msis/orgs",
"repos_url": "https://api.github.com/users/msis/repos",
"events_url": "https://api.github.com/users/msis/events{/privacy}",
"received_events_url": "https://api.github.com/users/msis/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-01-11T22:58:00 | 2023-01-16T16:59:29 | 2023-01-16T16:59:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
In a multi-node setup, DALI pipelines' fail because data is only visible on one node.
**Steps/Code to reproduce bug**
1. Download the data on the main node (rank 0), place it in `/scratch/audio-data`
2. Launch training
3. DALI raises error on other nodes :
`[/opt/dali/dali/operators/reader/loader/nemo_asr_loader.cc:80] Assert on "fstream" failed: Could not open NEMO ASR manifest file: "/scratch/audio-data/manifest.json`
**Expected behavior**
If `ddp` is enabled, DALI should run only on rank 0 node and load the data from there.
**Environment overview (please complete the following information)**
- Environment location: AWS (HPC)
- Method of NeMo install: `pip install git+https://github.com/NVIDIA/NeMo.git@9bc1220132cca7ba71550105d98dd12cfc7fefbe#egg=nemo_toolkit[asr]`
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- PyTorch version 1.13.1
- Python version: 3.8.10
**Additional context**
Any other suggestions on how to setup multi-node training are welcome.
| {
"login": "msis",
"id": 577139,
"node_id": "MDQ6VXNlcjU3NzEzOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/577139?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/msis",
"html_url": "https://github.com/msis",
"followers_url": "https://api.github.com/users/msis/followers",
"following_url": "https://api.github.com/users/msis/following{/other_user}",
"gists_url": "https://api.github.com/users/msis/gists{/gist_id}",
"starred_url": "https://api.github.com/users/msis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/msis/subscriptions",
"organizations_url": "https://api.github.com/users/msis/orgs",
"repos_url": "https://api.github.com/users/msis/repos",
"events_url": "https://api.github.com/users/msis/events{/privacy}",
"received_events_url": "https://api.github.com/users/msis/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5779/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5779/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5778 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5778/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5778/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5778/events | https://github.com/NVIDIA/NeMo/pull/5778 | 1,529,829,513 | PR_kwDOC_bI7s5HMwWK | 5,778 | Port Riva's mel cepstral distortion w/ dynamic time warping notebook | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T22:53:47 | 2023-01-14T00:48:55 | 2023-01-14T00:48:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5778",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5778",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5778.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5778.patch",
"merged_at": "2023-01-14T00:48:51"
} | # What does this PR do ?
Ports the Riva Mel Cepstral Distortion - Dynamic Time Warping notebook (nvidia-riva/tutorials#96) to NeMo.
HTML version here for ease of viewing:
https://drive.google.com/file/d/1E7bk95HQXZE_LyCfryr1r9LEKPzm8J9D/view?usp=sharing
**Collection**: TTS
# Changelog
- Minor changes to ensure the notebook runs both locally and in Colab (tarred the example data, changed the way the audio is displayed)
- Additional docstrings and function explanations
- Minor text updates
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5778/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5778/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5777 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5777/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5777/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5777/events | https://github.com/NVIDIA/NeMo/pull/5777 | 1,529,811,591 | PR_kwDOC_bI7s5HMsaJ | 5,777 | fix token id bug | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-01-11T22:34:21 | 2023-01-12T03:57:49 | 2023-01-12T03:57:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5777",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5777",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5777.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5777.patch",
"merged_at": "2023-01-12T03:57:42"
} | fixed the tokenizer bug, add `bos_id` to the tabular tokenizer | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5777/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5777/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5776 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5776/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5776/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5776/events | https://github.com/NVIDIA/NeMo/pull/5776 | 1,529,694,553 | PR_kwDOC_bI7s5HMSOR | 5,776 | [TTS][ZH] bugfix import jieba errors. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T21:02:18 | 2023-01-12T02:26:22 | 2023-01-12T02:26:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5776",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5776",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5776.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5776.patch",
"merged_at": "2023-01-12T02:26:12"
} | There was a bug which hits errors below. This PR fixed the error by importing `jieba` correctly.
```
21 Error executing job with overrides: ['++dataloader_params.num_workers=48', 'manifest_filepath=/manifest/train_manifest.json', 'sup_data_path=/sup_data']
22 Traceback (most recent call last):
23 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 92, in _call_target
24 return _target_(*args, **kwargs)
25 File "/code/nemo/collections/tts/torch/data.py", line 241, in __init__
26 file_info["text_tokens"] = self.text_tokenizer(file_info["normalized_text"])
27 File "/code/nemo/collections/common/tokenizers/text_to_speech/tts_tokenizers.py", line 74, in __call__
28 return self.encode(text)
29 File "/code/nemo/collections/common/tokenizers/text_to_speech/tts_tokenizers.py", line 723, in encode
30 g2p_text = self.g2p(text) # TODO: handle infer
31 File "/code/nemo_text_processing/g2p/modules.py", line 617, in __call__
32 words_list = list(jieba.cut(text))
33 NameError: name 'jieba' is not defined
34
35 The above exception was the direct cause of the following exception:
36
37 Traceback (most recent call last):
38 File "scripts/dataset_processing/tts/extract_sup_data.py", line 83, in <module>
39 main() # noqa pylint: disable=no-value-for-parameter
40 File "/code/nemo/core/config/hydra_runner.py", line 105, in wrapper
41 _run_hydra(
42 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 389, in _run_hydra
43 _run_app(
44 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 452, in _run_app
45 run_and_report(
46 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 216, in run_and_report
47 raise ex
48 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 213, in run_and_report
49 return func()
50 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/utils.py", line 453, in <lambda>
51 lambda: hydra.run(
52 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/hydra.py", line 132, in run
53 _ = ret.return_value
54 File "/usr/local/lib/python3.8/dist-packages/hydra/core/utils.py", line 260, in return_value
55 raise self._return_value
56 File "/usr/local/lib/python3.8/dist-packages/hydra/core/utils.py", line 186, in run_job
57 ret.return_value = task_function(task_cfg)
58 File "scripts/dataset_processing/tts/extract_sup_data.py", line 70, in main
59 dataset = instantiate(cfg.dataset)
60 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 222, in instantiate
61 return instantiate_node(
62 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 339, in instantiate_node
63 return _call_target(_target_, partial, args, kwargs, full_key)
64 File "/usr/local/lib/python3.8/dist-packages/hydra/_internal/instantiate/_instantiate2.py", line 97, in _call_target
65 raise InstantiationException(msg) from e
66 hydra.errors.InstantiationException: Error in call to target 'nemo.collections.tts.torch.data.TTSDataset':
67 NameError("name 'jieba' is not defined")
68 full_key: dataset
```
Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5776/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5776/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5775 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5775/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5775/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5775/events | https://github.com/NVIDIA/NeMo/pull/5775 | 1,529,553,361 | PR_kwDOC_bI7s5HLzB_ | 5,775 | Docs g2p update | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T19:18:47 | 2023-01-11T21:07:09 | 2023-01-11T21:07:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5775",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5775",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5775.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5775.patch",
"merged_at": "2023-01-11T21:07:05"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [X ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5775/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5775/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5774 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5774/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5774/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5774/events | https://github.com/NVIDIA/NeMo/pull/5774 | 1,529,385,465 | PR_kwDOC_bI7s5HLOwB | 5,774 | [ASR] Separate Audio-to-Text (BPE, Char) dataset construction | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T17:02:21 | 2023-01-31T18:42:25 | 2023-01-31T18:42:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5774",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5774",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5774.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5774.patch",
"merged_at": "2023-01-31T18:42:20"
} | Signed-off-by: Vladimir Bataev <[email protected]>
# What does this PR do ?
Separate Audio-to-Text Char and BPE dataset construction:
- this allows to use datasets for further mixing (e.g. in hybrid ASR-TTS models #5659)
- removes duplicated code from CTC, RNNT (Char and BPE) models
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
from nemo.collections.asr.data.audio_to_text_dataset import get_audio_to_text_bpe_dataset_from_config
dataset = get_audio_to_text_bpe_dataset_from_config(...) # construct BPE dataset from parameters
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5774/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5774/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5773 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5773/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5773/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5773/events | https://github.com/NVIDIA/NeMo/pull/5773 | 1,529,301,076 | PR_kwDOC_bI7s5HK8jx | 5,773 | adding back tar script for decoder dataset for duplex | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T16:02:37 | 2023-01-11T21:12:39 | 2023-01-11T21:12:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5773",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5773",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5773.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5773.patch",
"merged_at": "2023-01-11T21:12:36"
} | Signed-off-by: Yang Zhang <[email protected]>
# What does this PR do ?
adding back create_tarred_dataset.py for duplex TN
**Collection**: nemol_nlp
# Changelog
- adding back create_tarred_dataset.py for duplex TN
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5773/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5773/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5772 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5772/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5772/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5772/events | https://github.com/NVIDIA/NeMo/pull/5772 | 1,528,620,686 | PR_kwDOC_bI7s5HIpUr | 5,772 | Add Esperanto ASR example | {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T08:23:10 | 2023-01-25T15:10:11 | 2023-01-25T15:10:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5772",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5772",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5772.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5772.patch",
"merged_at": "2023-01-25T15:10:10"
} | Signed-off-by: andrusenkoau <[email protected]>
# What does this PR do ?
Adds ASR example for training Esperanto Conformer-CTC-large model.
**Collection**: ASR
# Changelog
- Adds Esperanto example to docs/source/asr/examples/
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5772/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5772/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5771 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5771/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5771/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5771/events | https://github.com/NVIDIA/NeMo/pull/5771 | 1,528,382,347 | PR_kwDOC_bI7s5HH2Hc | 5,771 | Fixing masking in RadTTS bottleneck layer | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T03:54:24 | 2023-01-12T03:05:38 | 2023-01-12T03:05:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5771",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5771",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5771.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5771.patch",
"merged_at": "2023-01-12T03:05:38"
} | Signed-off-by: Boris Fomitchev <[email protected]>
Mask/length vector was ignored in bottleneck layer before.
**Collection**: [Note which collection this PR will affect]
TTS
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5771/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5771/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5770 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5770/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5770/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5770/events | https://github.com/NVIDIA/NeMo/pull/5770 | 1,528,256,344 | PR_kwDOC_bI7s5HHaeD | 5,770 | Adithyare/linear combination | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T01:36:36 | 2023-02-18T01:59:10 | 2023-02-18T01:59:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5770",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5770",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5770.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5770.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5770/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5770/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5769 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5769/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5769/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5769/events | https://github.com/NVIDIA/NeMo/pull/5769 | 1,528,201,963 | PR_kwDOC_bI7s5HHO7t | 5,769 | Docs g2p update | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-11T00:38:18 | 2023-01-11T19:18:11 | 2023-01-11T19:18:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5769",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5769",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5769.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5769.patch",
"merged_at": "2023-01-11T19:18:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [X ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5769/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5769/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5768 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5768/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5768/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5768/events | https://github.com/NVIDIA/NeMo/pull/5768 | 1,528,167,981 | PR_kwDOC_bI7s5HHIBS | 5,768 | TTS inference with Heteronym classification model, hc model inference refactoring | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-10T23:51:15 | 2023-01-31T05:09:03 | 2023-01-31T05:08:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5768",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5768",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5768.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5768.patch",
"merged_at": "2023-01-31T05:08:59"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5768/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5768/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5767 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5767/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5767/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5767/events | https://github.com/NVIDIA/NeMo/pull/5767 | 1,528,089,117 | PR_kwDOC_bI7s5HG3h0 | 5,767 | Fix wrong label mapping in batch_inference for label_model | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-10T22:19:59 | 2023-01-27T00:05:46 | 2023-01-27T00:05:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5767",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5767",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5767.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5767.patch",
"merged_at": "2023-01-27T00:05:38"
} | # What does this PR do ?
Fix groundtruth label mapping in `batch_inference` in `label_models.py` and add test.
**Collection**: ASR
# Changelog
- The groundtruth label `batch_inference` was mapped wrongly. Fixed it
- Add test for `batch_inference`
# Usage
* You can potentially add a usage example below
```python
from nemo.collections.asr.models import EncDecSpeakerLabelModel
model = EncDecSpeakerLabelModel.from_pretrained('langid_ambernet')
embs, logits, gt_labels, mapped_labels = model.batch_inference(<path_to_manifest>)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/5278
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5767/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5767/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5766 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5766/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5766/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5766/events | https://github.com/NVIDIA/NeMo/pull/5766 | 1,527,882,644 | PR_kwDOC_bI7s5HGL1_ | 5,766 | Megatron export triton update | {
"login": "Davood-M",
"id": 3964285,
"node_id": "MDQ6VXNlcjM5NjQyODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3964285?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Davood-M",
"html_url": "https://github.com/Davood-M",
"followers_url": "https://api.github.com/users/Davood-M/followers",
"following_url": "https://api.github.com/users/Davood-M/following{/other_user}",
"gists_url": "https://api.github.com/users/Davood-M/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Davood-M/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Davood-M/subscriptions",
"organizations_url": "https://api.github.com/users/Davood-M/orgs",
"repos_url": "https://api.github.com/users/Davood-M/repos",
"events_url": "https://api.github.com/users/Davood-M/events{/privacy}",
"received_events_url": "https://api.github.com/users/Davood-M/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-10T19:15:46 | 2023-01-12T01:11:24 | 2023-01-12T01:11:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5766",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5766",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5766.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5766.patch",
"merged_at": "2023-01-12T01:11:23"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- updating biased gelu
- minor updates to mimic nemo nmt
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5766/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5766/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5765 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5765/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5765/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5765/events | https://github.com/NVIDIA/NeMo/issues/5765 | 1,527,281,774 | I_kwDOC_bI7s5bCHhu | 5,765 | Missing "create_tarred_dataset.py" script for Duplex Text Normalization | {
"login": "fr0zenshard",
"id": 24573300,
"node_id": "MDQ6VXNlcjI0NTczMzAw",
"avatar_url": "https://avatars.githubusercontent.com/u/24573300?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fr0zenshard",
"html_url": "https://github.com/fr0zenshard",
"followers_url": "https://api.github.com/users/fr0zenshard/followers",
"following_url": "https://api.github.com/users/fr0zenshard/following{/other_user}",
"gists_url": "https://api.github.com/users/fr0zenshard/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fr0zenshard/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fr0zenshard/subscriptions",
"organizations_url": "https://api.github.com/users/fr0zenshard/orgs",
"repos_url": "https://api.github.com/users/fr0zenshard/repos",
"events_url": "https://api.github.com/users/fr0zenshard/events{/privacy}",
"received_events_url": "https://api.github.com/users/fr0zenshard/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-01-10T12:09:03 | 2023-01-12T11:32:28 | 2023-01-12T11:32:28 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The script for creation **TarredDataset** described in the [Duplex Text Normalization Doc](https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/text_normalization/nn_text_normalization.html) is missing.
According to the documentation it should be located:
`examples/nlp/duplex_text_normalization/create_tarred_dataset.py` | {
"login": "fr0zenshard",
"id": 24573300,
"node_id": "MDQ6VXNlcjI0NTczMzAw",
"avatar_url": "https://avatars.githubusercontent.com/u/24573300?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fr0zenshard",
"html_url": "https://github.com/fr0zenshard",
"followers_url": "https://api.github.com/users/fr0zenshard/followers",
"following_url": "https://api.github.com/users/fr0zenshard/following{/other_user}",
"gists_url": "https://api.github.com/users/fr0zenshard/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fr0zenshard/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fr0zenshard/subscriptions",
"organizations_url": "https://api.github.com/users/fr0zenshard/orgs",
"repos_url": "https://api.github.com/users/fr0zenshard/repos",
"events_url": "https://api.github.com/users/fr0zenshard/events{/privacy}",
"received_events_url": "https://api.github.com/users/fr0zenshard/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5765/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5765/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5763 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5763/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5763/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5763/events | https://github.com/NVIDIA/NeMo/pull/5763 | 1,526,457,142 | PR_kwDOC_bI7s5HBd2Y | 5,763 | [ASR][Test] Enable test for cache audio with a single worker | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-09T22:50:22 | 2023-01-12T00:11:21 | 2023-01-12T00:11:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5763",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5763",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5763.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5763.patch",
"merged_at": "2023-01-12T00:11:20"
} | Signed-off-by: Ante Jukić <[email protected]>
# What does this PR do ?
Enable a test which was disabled in #5615.
**Collection**: ASR tests
# Changelog
- Enabled the test using a single worker
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #5607 and #5615
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5763/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5763/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5762 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5762/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5762/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5762/events | https://github.com/NVIDIA/NeMo/pull/5762 | 1,526,362,438 | PR_kwDOC_bI7s5HBJPS | 5,762 | Update Tacotron2 NGC checkpoint load to latest version | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-09T21:36:31 | 2023-01-10T00:43:36 | 2023-01-10T00:43:33 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5762",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5762",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5762.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5762.patch",
"merged_at": "2023-01-10T00:43:33"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Second version of #5748, applied to r1.15.0 this time.
Tacotron2's `list_available_models()` was still pointing to a previous version, so it would load that instead of the newest one.
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [x] Documentation
# Additional Information
* First noticed in #5714
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5762/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5762/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5761 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5761/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5761/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5761/events | https://github.com/NVIDIA/NeMo/pull/5761 | 1,526,352,873 | PR_kwDOC_bI7s5HBHJL | 5,761 | [Fix] ConformerEncoder forward when length is None | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-09T21:29:22 | 2023-01-10T00:01:01 | 2023-01-10T00:01:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5761",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5761",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5761.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5761.patch",
"merged_at": "2023-01-10T00:01:00"
} | Signed-off-by: Ante Jukić <[email protected]>
# What does this PR do ?
This PR fixes a bug in `forward` of `ConformerEncoder` when `length is None`
**Collection**: ASR
# Changelog
- Fixed initialization of `length` with `new_full`
# Usage
Currently, the following
```
import torch
from nemo.collections.asr.modules.conformer_encoder import ConformerEncoder
# create layer
conformer_encoder = ConformerEncoder(feat_in=10, n_layers=1, d_model=16)
# run
out, out_length = conformer_encoder(audio_signal=torch.rand(10, 9, 32), length=None)
```
results in a `TypeError`:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "${PATH}/miniforge3/envs/nemo_env/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1482, in _call_impl
return forward_call(*args, **kwargs)
File "${NEMO}/nemo/core/classes/common.py", line 1087, in __call__
outputs = wrapped(*args, **kwargs)
File "${NEMO}/nemo/collections/asr/modules/conformer_encoder.py", line 416, in forward
length = audio_signal.new_full(
TypeError: new_full(): argument 'size' (position 1) must be tuple of ints, not int
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5761/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5761/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5760 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5760/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5760/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5760/events | https://github.com/NVIDIA/NeMo/pull/5760 | 1,526,107,737 | PR_kwDOC_bI7s5HARAi | 5,760 | Update Tacotron2 NGC checkpoint load to latest version | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-09T18:34:11 | 2023-01-09T21:36:03 | 2023-01-09T21:35:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5760",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5760",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5760.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5760.patch",
"merged_at": "2023-01-09T21:35:59"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Second version of #5748, applied to r1.15.0 this time.
Tacotron2's `list_available_models()` was still pointing to a previous version, so it would load that instead of the newest one.
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [x] Documentation
# Additional Information
* First noticed in #5714
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5760/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5760/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5759 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5759/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5759/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5759/events | https://github.com/NVIDIA/NeMo/issues/5759 | 1,525,787,258 | I_kwDOC_bI7s5a8ap6 | 5,759 | TypeError: _run_hydra() missing 1 required positional argument: 'args' | {
"login": "np-n",
"id": 39429615,
"node_id": "MDQ6VXNlcjM5NDI5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/39429615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/np-n",
"html_url": "https://github.com/np-n",
"followers_url": "https://api.github.com/users/np-n/followers",
"following_url": "https://api.github.com/users/np-n/following{/other_user}",
"gists_url": "https://api.github.com/users/np-n/gists{/gist_id}",
"starred_url": "https://api.github.com/users/np-n/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/np-n/subscriptions",
"organizations_url": "https://api.github.com/users/np-n/orgs",
"repos_url": "https://api.github.com/users/np-n/repos",
"events_url": "https://api.github.com/users/np-n/events{/privacy}",
"received_events_url": "https://api.github.com/users/np-n/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-01-09T15:12:33 | 2023-01-14T13:05:49 | 2023-01-14T13:05:49 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | While training tacotron2, I end up with the following error.
```
Traceback (most recent call last):
File "tacotron2.py", line 44, in <module>
main() # noqa pylint: disable=no-value-for-parameter
File "/usr/local/lib/python3.8/dist-packages/nemo/core/config/hydra_runner.py", line 98, in wrapper
_run_hydra(
TypeError: _run_hydra() missing 1 required positional argument: 'args'
[ ]
```
Just before that, I fixed the following issue using this [solution](https://github.com/NVIDIA/NeMo/issues/3915):
```
noqa pylint: disable=no-value-for-parameter File "/usr/local/lib/python3.7/dist-packages/nemo/core/config/hydra_runner.py", line 103, in wrapper strict=None,
TypeError: _run_hydra() got an unexpected keyword argument 'strict'
```
After removing the argument `strict=None`, I get the above error: `TypeError: _run_hydra() missing 1 required positional argument: 'args'`. How to fix it? Thank you!
| {
"login": "np-n",
"id": 39429615,
"node_id": "MDQ6VXNlcjM5NDI5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/39429615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/np-n",
"html_url": "https://github.com/np-n",
"followers_url": "https://api.github.com/users/np-n/followers",
"following_url": "https://api.github.com/users/np-n/following{/other_user}",
"gists_url": "https://api.github.com/users/np-n/gists{/gist_id}",
"starred_url": "https://api.github.com/users/np-n/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/np-n/subscriptions",
"organizations_url": "https://api.github.com/users/np-n/orgs",
"repos_url": "https://api.github.com/users/np-n/repos",
"events_url": "https://api.github.com/users/np-n/events{/privacy}",
"received_events_url": "https://api.github.com/users/np-n/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5759/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5759/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5758 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5758/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5758/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5758/events | https://github.com/NVIDIA/NeMo/pull/5758 | 1,525,757,580 | PR_kwDOC_bI7s5G_ET6 | 5,758 | Fix EMA topk checkpoint deletion | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2023-01-09T14:58:35 | 2023-01-12T15:41:22 | 2023-01-12T15:41:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5758",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5758",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5758.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5758.patch",
"merged_at": "2023-01-12T15:41:18"
} | # What does this PR do ?
Fixes case where we need to also delete the EMA checkpoints from previous runs.
**Collection**: Common
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5758/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5758/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5757 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5757/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5757/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5757/events | https://github.com/NVIDIA/NeMo/pull/5757 | 1,525,592,661 | PR_kwDOC_bI7s5G-g2j | 5,757 | Add EMA Docs, fix common collection documentation | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-01-09T13:24:32 | 2023-01-17T21:39:00 | 2023-01-17T21:38:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5757",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5757",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5757.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5757.patch",
"merged_at": "2023-01-17T21:38:57"
} | # What does this PR do ?
Adds simple documentation for EMA. Also fixes the docs on main due to an incorrect import in the EMA class.
**Collection**: Common
# Changelog
- Add EMA documentation
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5757/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5757/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5756 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5756/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5756/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5756/events | https://github.com/NVIDIA/NeMo/pull/5756 | 1,525,557,498 | PR_kwDOC_bI7s5G-ZBK | 5,756 | add esperanto example | {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-09T13:04:20 | 2023-01-11T08:12:39 | 2023-01-11T08:12:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5756",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5756",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5756.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5756.patch",
"merged_at": null
} | Signed-off-by: andrusenkoau <[email protected]>
# What does this PR do ?
Adds ASR example for training Esperanto Conformer-CTC-large model.
**Collection**: ASR
# Changelog
- Adds Esperanto example to docs/source/asr/examples/
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5756/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5756/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5755 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5755/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5755/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5755/events | https://github.com/NVIDIA/NeMo/issues/5755 | 1,524,889,396 | I_kwDOC_bI7s5a4_c0 | 5,755 | GPU memory leak in nemo asr_model.transcribe() | {
"login": "mehadi92",
"id": 104126711,
"node_id": "U_kgDOBjTY9w",
"avatar_url": "https://avatars.githubusercontent.com/u/104126711?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mehadi92",
"html_url": "https://github.com/mehadi92",
"followers_url": "https://api.github.com/users/mehadi92/followers",
"following_url": "https://api.github.com/users/mehadi92/following{/other_user}",
"gists_url": "https://api.github.com/users/mehadi92/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mehadi92/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mehadi92/subscriptions",
"organizations_url": "https://api.github.com/users/mehadi92/orgs",
"repos_url": "https://api.github.com/users/mehadi92/repos",
"events_url": "https://api.github.com/users/mehadi92/events{/privacy}",
"received_events_url": "https://api.github.com/users/mehadi92/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-09T04:01:16 | 2023-02-16T02:00:33 | 2023-02-16T02:00:33 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
GPU memory usage increases over the time
**Steps/Code to reproduce bug**
You can reproduce this bug using this notebook [Colab Notebook](https://colab.research.google.com/drive/1PqW0MqVyzCJ53fM1uwGrNvEcsmJN8Q6R?usp=sharing)
You can take any random WAV audio file and make sure you run it for 40 min to 1 hour. The Memory error should reproduce like mine.
**Expected behavior**
Memory usage aways should same after 1st batch processing complete
**Environment overview (please complete the following information)**
Google Colab
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5755/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5755/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5754 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5754/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5754/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5754/events | https://github.com/NVIDIA/NeMo/issues/5754 | 1,524,702,543 | I_kwDOC_bI7s5a4R1P | 5,754 | Errors when running first cell in 00_NeMo_Primer in Google Colab | {
"login": "treyd",
"id": 2250205,
"node_id": "MDQ6VXNlcjIyNTAyMDU=",
"avatar_url": "https://avatars.githubusercontent.com/u/2250205?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/treyd",
"html_url": "https://github.com/treyd",
"followers_url": "https://api.github.com/users/treyd/followers",
"following_url": "https://api.github.com/users/treyd/following{/other_user}",
"gists_url": "https://api.github.com/users/treyd/gists{/gist_id}",
"starred_url": "https://api.github.com/users/treyd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/treyd/subscriptions",
"organizations_url": "https://api.github.com/users/treyd/orgs",
"repos_url": "https://api.github.com/users/treyd/repos",
"events_url": "https://api.github.com/users/treyd/events{/privacy}",
"received_events_url": "https://api.github.com/users/treyd/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-08T22:11:38 | 2023-02-16T02:00:35 | 2023-02-16T02:00:35 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When running the first cell in tutorials/00_NeMo_Primer.ipynb on Google Colab, I get the following errors:
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorflow 2.9.2 requires protobuf<3.20,>=3.9.2, but you have protobuf 3.20.3 which is incompatible.
tensorflow 2.9.2 requires tensorboard<2.10,>=2.9, but you have tensorboard 2.11.0 which is incompatible.
```
I then get FileNotFound exceptions when running later cells trying to import NeMo collections
**Steps/Code to reproduce bug**
1. Click link on https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/starthere/tutorials.html for NeMo Fundamentals
2. Switch Runtime to use GPU Hardware Accelerator
3. Run first cell
**Expected behavior**
Expected dependencies to import without issue and to be able to go through the rest of the tutorial
**Environment overview (please complete the following information)**
- Environment location: Collab
- Method of NeMo install: pip install (specified in notebook with the commands:
```BRANCH = 'r1.14.0'
!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[all]```
**Environment details**
- Python version 3.8.16
**Additional context**
Seems NeMo wants protobuf<4,>=3.20.2, but tensorflow 2.9.2 wants < 3.20. Same for tensorboard.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5754/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5754/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5753 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5753/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5753/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5753/events | https://github.com/NVIDIA/NeMo/pull/5753 | 1,524,644,119 | PR_kwDOC_bI7s5G7Qcl | 5,753 | [TTS][DE] refine grapheme-based tokenizer and fastpitch training recipe on thorsten's neutral datasets. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-08T19:23:17 | 2023-01-10T21:08:44 | 2023-01-10T02:12:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5753",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5753",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5753.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5753.patch",
"merged_at": "2023-01-10T02:12:07"
} | # What does this PR do ?
```
1. refine `GermanCharsTokenizer` to support only graphemes as inputs by removing sentence-level phoneme representation;
2. refine `GermanCharsTokenizer` to preserve mixed cases from the original input graphemes;
3. add a new Thorsten's 22.10 dataset;
4. revise the thorsten's voice neutral datasets preparation script to support two versions of thorsten's voice datasets in a single script.
5. succeeded in running through model training.
6. fixed some typos.
```
**TODO in separate PRs**
```
1. update NGC URL with new model ckpts.
2. update the tutorial accordingly.
3. train grapheme-based models on HUI-ACG datasets and update NGC releases.
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue): https://github.com/NVIDIA/NeMo/issues/5400 | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5753/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5753/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5752 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5752/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5752/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5752/events | https://github.com/NVIDIA/NeMo/pull/5752 | 1,524,407,030 | PR_kwDOC_bI7s5G6hUF | 5,752 | Set the stream position to 0 for pydub | {
"login": "jonghwanhyeon",
"id": 1588996,
"node_id": "MDQ6VXNlcjE1ODg5OTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/1588996?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jonghwanhyeon",
"html_url": "https://github.com/jonghwanhyeon",
"followers_url": "https://api.github.com/users/jonghwanhyeon/followers",
"following_url": "https://api.github.com/users/jonghwanhyeon/following{/other_user}",
"gists_url": "https://api.github.com/users/jonghwanhyeon/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jonghwanhyeon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jonghwanhyeon/subscriptions",
"organizations_url": "https://api.github.com/users/jonghwanhyeon/orgs",
"repos_url": "https://api.github.com/users/jonghwanhyeon/repos",
"events_url": "https://api.github.com/users/jonghwanhyeon/events{/privacy}",
"received_events_url": "https://api.github.com/users/jonghwanhyeon/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-08T08:47:59 | 2023-01-08T10:57:18 | 2023-01-08T10:57:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5752",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5752",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5752.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5752.patch",
"merged_at": "2023-01-08T10:57:18"
} | # What does this PR do ?
This PR sets the stream position to 0 to use pydub as fallback if SoundFile fails to read an audio file.
When using tarred datasets, `audio_file` is a file-like object, not a path-like object. In this situation, to use pydub as fallback, we need to set the stream position of `audio_file` to 0 since SoundFile have advanced the position while reading it.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5752/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5752/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5751 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5751/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5751/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5751/events | https://github.com/NVIDIA/NeMo/issues/5751 | 1,524,177,669 | I_kwDOC_bI7s5a2RsF | 5,751 | Pretraining argument for tokenizer | {
"login": "pradeepsinghnitk",
"id": 30348381,
"node_id": "MDQ6VXNlcjMwMzQ4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/30348381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pradeepsinghnitk",
"html_url": "https://github.com/pradeepsinghnitk",
"followers_url": "https://api.github.com/users/pradeepsinghnitk/followers",
"following_url": "https://api.github.com/users/pradeepsinghnitk/following{/other_user}",
"gists_url": "https://api.github.com/users/pradeepsinghnitk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pradeepsinghnitk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pradeepsinghnitk/subscriptions",
"organizations_url": "https://api.github.com/users/pradeepsinghnitk/orgs",
"repos_url": "https://api.github.com/users/pradeepsinghnitk/repos",
"events_url": "https://api.github.com/users/pradeepsinghnitk/events{/privacy}",
"received_events_url": "https://api.github.com/users/pradeepsinghnitk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-07T21:59:10 | 2023-02-19T02:00:51 | 2023-02-19T02:00:51 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | " ${model.language_model.pretrained_model_name} # tokenizer that inherits from TokenizerSpec"
AttributeError: 'BERTLMModel' object has no attribute 'tokenizer' | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5751/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5751/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5750 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5750/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5750/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5750/events | https://github.com/NVIDIA/NeMo/pull/5750 | 1,523,352,753 | PR_kwDOC_bI7s5G3B7C | 5,750 | Expose conditional log prob method for enc-dec models. | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-07T00:35:35 | 2023-02-08T02:00:46 | 2023-02-08T02:00:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5750",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5750",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5750.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5750.patch",
"merged_at": null
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Exposes a method `log_prob()` to get the conditional log prob `p(y|x)` for enc-dec models.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5750/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5750/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5749 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5749/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5749/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5749/events | https://github.com/NVIDIA/NeMo/pull/5749 | 1,523,243,096 | PR_kwDOC_bI7s5G2tJ_ | 5,749 | Adithyare/prompt learning seed | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-06T22:11:51 | 2023-01-07T02:59:57 | 2023-01-07T02:59:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5749",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5749",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5749.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5749.patch",
"merged_at": "2023-01-07T02:59:53"
} | # What does this PR do ?
adds explicit random seed init for all prompt learning and adapter learning based methods.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5749/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5749/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5748 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5748/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5748/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5748/events | https://github.com/NVIDIA/NeMo/pull/5748 | 1,523,226,408 | PR_kwDOC_bI7s5G2ppS | 5,748 | Update Tacotron2's list_available_models() | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-06T21:55:35 | 2023-01-09T18:29:23 | 2023-01-09T18:26:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5748",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5748",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5748.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5748.patch",
"merged_at": null
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Tacotron2's `list_available_models()` was still pointing to a previous version, so it would load that instead of the newest one.
**Collection**: TTS
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
# Additional Information
* As noticed in #5714
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5748/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5748/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5747 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5747/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5747/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5747/events | https://github.com/NVIDIA/NeMo/pull/5747 | 1,523,019,665 | PR_kwDOC_bI7s5G19Xl | 5,747 | Adithyare/zero shot eval prompt learning | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-06T19:10:04 | 2023-03-16T01:57:43 | 2023-03-16T01:57:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5747",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5747",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5747.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5747.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5747/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5747/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5746 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5746/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5746/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5746/events | https://github.com/NVIDIA/NeMo/pull/5746 | 1,522,828,905 | PR_kwDOC_bI7s5G1UDO | 5,746 | link fixed | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-06T16:22:44 | 2023-01-06T18:25:42 | 2023-01-06T18:25:39 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5746",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5746",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5746.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5746.patch",
"merged_at": "2023-01-06T18:25:39"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5746/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5746/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5745 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5745/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5745/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5745/events | https://github.com/NVIDIA/NeMo/pull/5745 | 1,522,639,419 | PR_kwDOC_bI7s5G0qwf | 5,745 | link fixed | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-06T14:01:32 | 2023-01-06T16:22:03 | 2023-01-06T16:22:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5745",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5745",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5745.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5745.patch",
"merged_at": "2023-01-06T16:22:03"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5745/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5745/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5744 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5744/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5744/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5744/events | https://github.com/NVIDIA/NeMo/pull/5744 | 1,522,351,145 | PR_kwDOC_bI7s5Gzqtr | 5,744 | typo and link fixed | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-06T10:36:11 | 2023-01-06T13:53:40 | 2023-01-06T13:53:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5744",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5744",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5744.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5744.patch",
"merged_at": "2023-01-06T13:53:37"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5744/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5744/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5743 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5743/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5743/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5743/events | https://github.com/NVIDIA/NeMo/issues/5743 | 1,522,169,492 | I_kwDOC_bI7s5aunaU | 5,743 | All files present in manifest contains silence, aborting next steps | {
"login": "skanda1005",
"id": 53397947,
"node_id": "MDQ6VXNlcjUzMzk3OTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/53397947?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skanda1005",
"html_url": "https://github.com/skanda1005",
"followers_url": "https://api.github.com/users/skanda1005/followers",
"following_url": "https://api.github.com/users/skanda1005/following{/other_user}",
"gists_url": "https://api.github.com/users/skanda1005/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skanda1005/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skanda1005/subscriptions",
"organizations_url": "https://api.github.com/users/skanda1005/orgs",
"repos_url": "https://api.github.com/users/skanda1005/repos",
"events_url": "https://api.github.com/users/skanda1005/events{/privacy}",
"received_events_url": "https://api.github.com/users/skanda1005/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-01-06T08:22:53 | 2025-01-01T09:37:40 | 2023-02-25T02:00:31 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
All files present in manifest contains silence, aborting next steps.
When I run the diarization with an audio file which contains no speech, it terminates the program and throws an error
**Steps/Code to reproduce bug**
Run diarization on any audio wav file which contains no speech/audio
**Expected behavior**
Rather than program terminating, I would like a blank output and a blank rttm file.
Or how do I circumvent the "raise ValueError" in the script?
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5743/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5743/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5742 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5742/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5742/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5742/events | https://github.com/NVIDIA/NeMo/pull/5742 | 1,521,697,730 | PR_kwDOC_bI7s5Gxa-P | 5,742 | [TTS] Update Spanish TTS model to 1.15 | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-06T01:05:30 | 2023-01-06T19:21:52 | 2023-01-06T19:20:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5742",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5742",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5742.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5742.patch",
"merged_at": "2023-01-06T19:20:49"
} | Signed-off-by: Ryan <[email protected]>
# What does this PR do ?
Update FastPitch Spanish config from 1.14.0 to 1.15.0, which contains IPA support and improvements from speaker level pitch normalization.
https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/tts_es_multispeaker_fastpitchhifigan/version
**Collection**: [TTS]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5742/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5742/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5741 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5741/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5741/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5741/events | https://github.com/NVIDIA/NeMo/pull/5741 | 1,521,669,980 | PR_kwDOC_bI7s5GxVC8 | 5,741 | typo and link fixed | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-06T00:36:34 | 2023-01-06T10:35:38 | 2023-01-06T10:35:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5741",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5741",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5741.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5741.patch",
"merged_at": "2023-01-06T10:35:38"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5741/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5741/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5740 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5740/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5740/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5740/events | https://github.com/NVIDIA/NeMo/pull/5740 | 1,521,563,477 | PR_kwDOC_bI7s5Gw-Pc | 5,740 | Update 00_NeMo_Primer.ipynb | {
"login": "schaltung",
"id": 4131486,
"node_id": "MDQ6VXNlcjQxMzE0ODY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4131486?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/schaltung",
"html_url": "https://github.com/schaltung",
"followers_url": "https://api.github.com/users/schaltung/followers",
"following_url": "https://api.github.com/users/schaltung/following{/other_user}",
"gists_url": "https://api.github.com/users/schaltung/gists{/gist_id}",
"starred_url": "https://api.github.com/users/schaltung/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/schaltung/subscriptions",
"organizations_url": "https://api.github.com/users/schaltung/orgs",
"repos_url": "https://api.github.com/users/schaltung/repos",
"events_url": "https://api.github.com/users/schaltung/events{/privacy}",
"received_events_url": "https://api.github.com/users/schaltung/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-05T22:44:36 | 2023-01-05T22:51:12 | 2023-01-05T22:51:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5740",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5740",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5740.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5740.patch",
"merged_at": "2023-01-05T22:51:12"
} | Fixed a minor typo in primer tutorial.
Signed-off-by: schaltung <[email protected]>
# What does this PR do ?
Fixed a minor typo: "White" <-- "While".
**Collection**: None
# Changelog
- Single-word typo fix in the text markup of the jupyter notebook.
# Usage
* You can potentially add a usage example below
# Before your PR is "Ready for review"
**Pre checks**:
- [] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5740/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5740/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5739 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5739/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5739/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5739/events | https://github.com/NVIDIA/NeMo/pull/5739 | 1,520,835,177 | PR_kwDOC_bI7s5GueMQ | 5,739 | Remove ending newlines when encoding strings w/ sentencepiece tokenizer | {
"login": "pks",
"id": 368183,
"node_id": "MDQ6VXNlcjM2ODE4Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/368183?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pks",
"html_url": "https://github.com/pks",
"followers_url": "https://api.github.com/users/pks/followers",
"following_url": "https://api.github.com/users/pks/following{/other_user}",
"gists_url": "https://api.github.com/users/pks/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pks/subscriptions",
"organizations_url": "https://api.github.com/users/pks/orgs",
"repos_url": "https://api.github.com/users/pks/repos",
"events_url": "https://api.github.com/users/pks/events{/privacy}",
"received_events_url": "https://api.github.com/users/pks/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-05T14:25:07 | 2023-01-26T08:28:24 | 2023-01-26T03:28:32 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5739",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5739",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5739.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5739.patch",
"merged_at": "2023-01-26T03:28:32"
} | Signed-off-by: Patrick Simianer <[email protected]>
# What does this PR do ?
SentencePiece models can be generated in a number of different ways in terms of handling whitespace. An important parameter is `normalization_rule_name`: Setting this to "identity" will cause newline characters `\n` to remain in the string when encoding. In the default setting (`nmt_nfkc`) any `\n` would be replaced by a single space. Since `remove_extra_whitespaces` is also on by default this'll cause it just to be removed.
The problem with the `identity` setting in conjunction with NeMo is that NeMo presents the input strings for preprocessing with the final `\n` character included, and since sentencepiece itself won't add it to the vocabulary (https://github.com/google/sentencepiece/issues/804), this will cause an unknown token at the end of every training example. A minimal example to reproduce this behavior is:
Train SentencePiece model:
```
#!/bin/bash
../sentencepiece_upstream/build/src/spm_train \
--input ../europarl-v7.de-en.en,../europarl-v7.de-en.de \
--input_sentence_size 9999 \
--model_prefix "bpe.joint" \
--model_type "bpe" \
--pad_id 3 \
--pad_piece "<pad>" \
--normalization_rule_name "identity"
```
```
#!/usr/bin/env bash
CUDA_VISIBLE_DEVICES= python ../nemo/examples/nlp/machine_translation/create_tarred_parallel_dataset.py \
--shared_tokenizer \
--encoder_tokenizer_name sentencepiece \
--decoder_tokenizer_name sentencepiece \
--encoder_tokenizer_bpe_dropout 0.0 \
--decoder_tokenizer_bpe_dropout 0.0 \
--src_fname ../europarl-v7.de-en.en \
--tgt_fname ../europarl-v7.de-en.de \
--out_dir preproc_dir \
--max_seq_length 512 \
--min_seq_length 1 \
--tokens_in_batch 8192 \
--lines_per_dataset_fragment 1000000 \
--num_batches_per_tarfile 100 \
--encoder_tokenizer_model bpe.joint.model \
--decoder_tokenizer_model bpe.joint.model \
--n_preproc_jobs 32 \
--clean
```
Observe that every training example has a unknown token (id 0) right before EOS (id 2):
```
> cd preproc_dir
> tar xfv parallel.batches.tokens.8192.0.tar
> cd preproc_dir
> python
>>> import pickle
>>> pickle.load(open("fragment-0-batch-1.pkl", "rb"))["src"][0]
[ 1 1336 0 2]
```
As a minimal fix this PR just removes the final newline character before encoding w/ sentencepiece's methods.
(The other tokenization option, yttm, will by default remove any trailing whitespace and there's also not setting to change that. So there won't be any issues like that.)
**Collection**: `common`
# Changelog
- Remove ending newlines when encoding strings w/ sentencepiece tokenizer
# Usage
* See above.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5739/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5739/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5738 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5738/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5738/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5738/events | https://github.com/NVIDIA/NeMo/issues/5738 | 1,520,675,513 | I_kwDOC_bI7s5ao6q5 | 5,738 | Mismatch in the dimensions length of log probabilities of Nemo ASR transcribe function and Vocab size | {
"login": "manjuke",
"id": 6142443,
"node_id": "MDQ6VXNlcjYxNDI0NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6142443?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/manjuke",
"html_url": "https://github.com/manjuke",
"followers_url": "https://api.github.com/users/manjuke/followers",
"following_url": "https://api.github.com/users/manjuke/following{/other_user}",
"gists_url": "https://api.github.com/users/manjuke/gists{/gist_id}",
"starred_url": "https://api.github.com/users/manjuke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/manjuke/subscriptions",
"organizations_url": "https://api.github.com/users/manjuke/orgs",
"repos_url": "https://api.github.com/users/manjuke/repos",
"events_url": "https://api.github.com/users/manjuke/events{/privacy}",
"received_events_url": "https://api.github.com/users/manjuke/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-05T12:33:27 | 2023-02-16T02:00:37 | 2023-02-16T02:00:37 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi All,
I am working on pyctcdecode integration with Nemo ASR models. However, there is a mismatch in the dimensions of the log probabilities matrix output by Nemo ASR transcribe function and the length of vocabulary size. Because of this I am unable to proceed further. Any suggestions, will be very helpful.
asr_model1 = nemo_asr.models.EncDecCTCModelBPE.from_pretrained(model_name="stt_en_conformer_ctc_medium")
print(len(asr_model1.decoder.vocabulary)) ---> this outputs "1024"
logits = asr_model1.transcribe(["/data/manju/tamil/data/segWav/tvs_test_9976337304-in-Speaker_1-11.wav"], logprobs=True)[0]
print(logits.shape) --> This outputs " (36, 1025)". Here, it should have produced "1024" in place of "1025"
Pls suggest @titu1994 @jbalam-nv . Thanks | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5738/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5738/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5737 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5737/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5737/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5737/events | https://github.com/NVIDIA/NeMo/pull/5737 | 1,520,416,540 | PR_kwDOC_bI7s5GtA-Y | 5,737 | Don't add output directory twice when creating shared sentencepiece tokenizer | {
"login": "pks",
"id": 368183,
"node_id": "MDQ6VXNlcjM2ODE4Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/368183?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pks",
"html_url": "https://github.com/pks",
"followers_url": "https://api.github.com/users/pks/followers",
"following_url": "https://api.github.com/users/pks/following{/other_user}",
"gists_url": "https://api.github.com/users/pks/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pks/subscriptions",
"organizations_url": "https://api.github.com/users/pks/orgs",
"repos_url": "https://api.github.com/users/pks/repos",
"events_url": "https://api.github.com/users/pks/events{/privacy}",
"received_events_url": "https://api.github.com/users/pks/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-05T09:39:27 | 2023-01-13T16:39:08 | 2023-01-13T16:26:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5737",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5737",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5737.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5737.patch",
"merged_at": "2023-01-13T16:26:51"
} | Signed-off-by: Patrick Simianer <[email protected]>
# What does this PR do ?
As the title says this is a small fix: The output dir was already added to `encoder_tokenizer_model` on line 789 in the same file.
**Collection**: NLP
# Changelog
- Bugfix for creating shared sentencepiece tokenizer.
# Usage
The error can be triggered by running preprocessing with NeMo for an MT data set:
```
#!/bin/bash
python ../nemo/examples/nlp/machine_translation/enc_dec_nmt.py \
-cn aayn_base \
do_training=false \
model.preproc_out_dir=./preproc_dir/ \
model.train_ds.use_tarred_dataset=true \
model.train_ds.lines_per_dataset_fragment=1000000 \
model.train_ds.num_batches_per_tarfile=200 \
model.train_ds.src_file_name=../europarl-v7.de-en.en \
model.train_ds.tgt_file_name=../europarl-v7.de-en.de \
model.validation_ds.src_file_name=../valid.en \
model.validation_ds.tgt_file_name=../valid.de \
model.encoder_tokenizer.vocab_size=32000 \
model.decoder_tokenizer.vocab_size=32000 \
model.encoder_tokenizer.library=sentencepiece \
model.encoder_tokenizer.training_sample_size=9999 \
model.decoder_tokenizer.library=sentencepiece \
model.decoder_tokenizer.training_sample_size=9999 \
~model.test_ds \
trainer.accelerator='cpu' \
+trainer.fast_dev_run=true \
exp_manager=null
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5737/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5737/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5736 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5736/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5736/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5736/events | https://github.com/NVIDIA/NeMo/pull/5736 | 1,520,404,930 | PR_kwDOC_bI7s5Gs-ag | 5,736 | Sanitize params before DLLogger log_hyperparams | {
"login": "milesial",
"id": 30204471,
"node_id": "MDQ6VXNlcjMwMjA0NDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/30204471?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/milesial",
"html_url": "https://github.com/milesial",
"followers_url": "https://api.github.com/users/milesial/followers",
"following_url": "https://api.github.com/users/milesial/following{/other_user}",
"gists_url": "https://api.github.com/users/milesial/gists{/gist_id}",
"starred_url": "https://api.github.com/users/milesial/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/milesial/subscriptions",
"organizations_url": "https://api.github.com/users/milesial/orgs",
"repos_url": "https://api.github.com/users/milesial/repos",
"events_url": "https://api.github.com/users/milesial/events{/privacy}",
"received_events_url": "https://api.github.com/users/milesial/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-05T09:31:32 | 2023-01-10T18:46:36 | 2023-01-10T18:46:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5736",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5736",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5736.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5736.patch",
"merged_at": "2023-01-10T18:46:35"
} | # What does this PR do ?
Allows DLLogger to work with types of non-builtin containers.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5736/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5736/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5735 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5735/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5735/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5735/events | https://github.com/NVIDIA/NeMo/pull/5735 | 1,520,351,683 | PR_kwDOC_bI7s5GsyoK | 5,735 | Esperanto example | {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-05T08:55:56 | 2023-01-05T19:31:18 | 2023-01-05T19:11:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5735",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5735",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5735.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5735.patch",
"merged_at": null
} | # What does this PR do ?
Adds ASR example for training Esperanto Conformer-CTC-large model.
**Collection**: ASR
# Changelog
- Adds Esperanto example to docs/source/asr/examples/
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5735/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5735/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5734 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5734/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5734/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5734/events | https://github.com/NVIDIA/NeMo/pull/5734 | 1,519,796,502 | PR_kwDOC_bI7s5Gq2yY | 5,734 | Irish TN/ITN | {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-05T00:42:40 | 2023-01-05T00:42:49 | 2023-01-05T00:42:45 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5734",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5734",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5734.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5734.patch",
"merged_at": null
} | # What does this PR do ?
Opening to show provenance, closing immediately.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5734/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5734/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5733 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5733/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5733/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5733/events | https://github.com/NVIDIA/NeMo/pull/5733 | 1,519,524,667 | PR_kwDOC_bI7s5Gp6nB | 5,733 | Add tabular data generation documents to the index file | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-04T20:19:32 | 2023-01-04T20:39:25 | 2023-01-04T20:39:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5733",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5733",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5733.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5733.patch",
"merged_at": "2023-01-04T20:39:21"
} | Add tabular data generation documents to the index file | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5733/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5733/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5732 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5732/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5732/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5732/events | https://github.com/NVIDIA/NeMo/pull/5732 | 1,519,288,376 | PR_kwDOC_bI7s5GpG9H | 5,732 | fix: clamp keep input size in update_cache for causal conv | {
"login": "messiaen",
"id": 28207671,
"node_id": "MDQ6VXNlcjI4MjA3Njcx",
"avatar_url": "https://avatars.githubusercontent.com/u/28207671?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/messiaen",
"html_url": "https://github.com/messiaen",
"followers_url": "https://api.github.com/users/messiaen/followers",
"following_url": "https://api.github.com/users/messiaen/following{/other_user}",
"gists_url": "https://api.github.com/users/messiaen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/messiaen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/messiaen/subscriptions",
"organizations_url": "https://api.github.com/users/messiaen/orgs",
"repos_url": "https://api.github.com/users/messiaen/repos",
"events_url": "https://api.github.com/users/messiaen/events{/privacy}",
"received_events_url": "https://api.github.com/users/messiaen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-04T16:49:59 | 2023-01-20T16:47:44 | 2023-01-20T16:47:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5732",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5732",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5732.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5732.patch",
"merged_at": null
} | # What does this PR do ?
Sometimes in CausalConv1D.update_cache input_x_keep ends up having no frames (ie size of [M, N, 0]). Make sure that the we have at least one frame.
**Collection**: asr
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@VahidooX
# Additional Information
To reproduce the original issue in main run:
```
#!/bin/bash
python examples/asr/asr_cache_aware_streaming/speech_to_text_cache_aware_streaming_infer.py \
--asr_model=stt_en_conformer_ctc_small \
--chunk_size=100 \
--shift_size=50 \
--left_chunks=2 \
--online_normalization \
--manifest_file=/datasets/ls_test_other/transcripts.local.json \
--batch_size=16 \
--compare_vs_offline \
--use_amp \
--debug_mode
```
Error output:
```
...
Traceback (most recent call last):
File "examples/asr/asr_cache_aware_streaming/speech_to_text_cache_aware_streaming_infer.py", line 393, in <module>
main()
File "examples/asr/asr_cache_aware_streaming/speech_to_text_cache_aware_streaming_infer.py", line 349, in main
streaming_tran, offline_tran = perform_streaming(
File "examples/asr/asr_cache_aware_streaming/speech_to_text_cache_aware_streaming_infer.py", line 154, in perform_streaming
) = asr_model.conformer_stream_step(
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/parts/mixins/mixins.py", line 475, in conformer_stream_step
(encoded, encoded_len, cache_last_channel_next, cache_last_time_next) = self.encoder.cache_aware_stream_step(
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/parts/mixins/streaming.py", line 61, in cache_aware_stream_step
encoder_output = self(
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/core/classes/common.py", line 1087, in __call__
outputs = wrapped(*args, **kwargs)
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/modules/conformer_encoder.py", line 471, in forward
audio_signal = layer(
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/parts/submodules/conformer_modules.py", line 191, in forward
x = self.conv(x, pad_mask=pad_mask, cache=cache_last_time, cache_next=cache_last_time_next)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/parts/submodules/conformer_modules.py", line 350, in forward
x = self.depthwise_conv(x, cache=cache, cache_next=cache_next)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/parts/submodules/causal_convs.py", line 162, in forward
x = self.update_cache(x, cache=cache, cache_next=cache_next)
File "/home/grclark/code/NeMo.git/streaming-conformer/nemo/collections/asr/parts/submodules/causal_convs.py", line 158, in update_cache
cache_next[self._cache_id, :, :, -cache_keep_size:] = input_x_kept[:, :, -cache_keep_size:]
RuntimeError: The expanded size of the tensor (1) must match the existing size (0) at non-singleton dimension 2. Target sizes: [16, 176, 1]. Tensor sizes: [16, 176, 0]
``` | {
"login": "messiaen",
"id": 28207671,
"node_id": "MDQ6VXNlcjI4MjA3Njcx",
"avatar_url": "https://avatars.githubusercontent.com/u/28207671?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/messiaen",
"html_url": "https://github.com/messiaen",
"followers_url": "https://api.github.com/users/messiaen/followers",
"following_url": "https://api.github.com/users/messiaen/following{/other_user}",
"gists_url": "https://api.github.com/users/messiaen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/messiaen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/messiaen/subscriptions",
"organizations_url": "https://api.github.com/users/messiaen/orgs",
"repos_url": "https://api.github.com/users/messiaen/repos",
"events_url": "https://api.github.com/users/messiaen/events{/privacy}",
"received_events_url": "https://api.github.com/users/messiaen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5732/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5732/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5731 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5731/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5731/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5731/events | https://github.com/NVIDIA/NeMo/pull/5731 | 1,519,065,378 | PR_kwDOC_bI7s5GoXYK | 5,731 | Add keep_initializers_as_inputs to _export method | {
"login": "pks",
"id": 368183,
"node_id": "MDQ6VXNlcjM2ODE4Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/368183?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pks",
"html_url": "https://github.com/pks",
"followers_url": "https://api.github.com/users/pks/followers",
"following_url": "https://api.github.com/users/pks/following{/other_user}",
"gists_url": "https://api.github.com/users/pks/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pks/subscriptions",
"organizations_url": "https://api.github.com/users/pks/orgs",
"repos_url": "https://api.github.com/users/pks/repos",
"events_url": "https://api.github.com/users/pks/events{/privacy}",
"received_events_url": "https://api.github.com/users/pks/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
}
] | closed | false | null | [] | null | null | 2023-01-04T14:22:21 | 2023-01-05T07:56:20 | 2023-01-04T20:17:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5731",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5731",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5731.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5731.patch",
"merged_at": "2023-01-04T20:17:49"
} | Signed-off-by: Patrick Simianer <[email protected]>
# What does this PR do ?
In https://github.com/NVIDIA/NeMo/pull/5052 I forgot to add the `keep_initializers_as_inputs` arg to the `_export` method.
**Collection**: core
# Changelog
- Simple fix.
# Usage
* See https://github.com/NVIDIA/NeMo/pull/5052
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #5052 | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5731/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5731/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5730 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5730/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5730/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5730/events | https://github.com/NVIDIA/NeMo/pull/5730 | 1,517,980,044 | PR_kwDOC_bI7s5GkmT2 | 5,730 | Update ASR torch.stft() call to use return_complex=True | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-03T22:13:07 | 2023-01-03T22:22:24 | 2023-01-03T22:22:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5730",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5730",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5730.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5730.patch",
"merged_at": "2023-01-03T22:22:21"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Updates the remaining call to `torch.stft()` to use `return_complex=True` due to the deprecation of the `return_complex=False` option.
I've done a quick grep through the NeMo repo, this should be the only other place where `torch.stft()` (or `torch.istft()`) is called.
**Collection**: ASR
# Changelog
- Changed the preprocessing lambda to use `return_complex=True`, which means `torch.stft()` will always return a complex tensor
- Removed the conditional for `view_as_real` since it will always need to be called now
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
# Additional Information
* See #5729 for more information (and the TTS fixes)
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5730/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5730/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5729 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5729/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5729/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5729/events | https://github.com/NVIDIA/NeMo/pull/5729 | 1,517,934,484 | PR_kwDOC_bI7s5GkcUU | 5,729 | Update torch.stft() calls due to deprecation of return_complex=False | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-03T21:26:59 | 2023-01-03T22:19:24 | 2023-01-03T21:39:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5729",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5729",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5729.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5729.patch",
"merged_at": "2023-01-03T21:39:02"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Fixes errors due to deprecation of `return_complex=False` in `torch.stft()` in version 1.14.
Most of our calls implicitly use `return_complex=False` (was the default), which returns a tensor of shape [B, N, T, 2] where the last dimension captures the real and imaginary parts of the tensor. However, moving forward, pytorch is deprecating this in favor of the behavior of `return_complex=True`, which returns a complex tensor of shape [B, N, T].
This bugfix explicitly sets `return_complex=True` as required by v1.14, and then converts the output of `torch.stft()` back to [B, N, T, 2] using `torch.view_as_real()`.
Similarly, `torch.istft()` now wants a complex tensor input; this is fixed by calling `torch.view_as_complex()` on our original input.
**Collection**: TTS
# Changelog
- `torch.stft()` calls explicitly set `return_complex=True` and then convert output where necessary
- Added `torch.view_as_complex()` to input of `torch.istft()`
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5729/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5729/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5728 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5728/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5728/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5728/events | https://github.com/NVIDIA/NeMo/pull/5728 | 1,517,931,781 | PR_kwDOC_bI7s5Gkbv- | 5,728 | ASR evaluator | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-03T21:23:31 | 2023-01-11T16:57:36 | 2023-01-11T16:57:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5728",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5728",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5728.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5728.patch",
"merged_at": "2023-01-11T16:57:26"
} | # What does this PR do ?
A tool to thoroughly evaluate an ASR model.
**Collection**: ASR
# Changelog
- Simple step to evaluate a model in all three modes currently supported by NeMo: offline, chunked, and offline_by_chunked.
- On-the-fly data augmentation (silence, noise, etc.,) for ASR robustness evaluation.
- Investigate the model's performance by detailed insertion, deletion, and substitution error rates for each and all samples.
- Evaluate models' reliability on different target groups such as gender, and audio length if metadata is presented.
# Usage
```
python asr_evaluator.py \
engine.pretrained_name="stt_en_conformer_transducer_large" \
engine.inference_mode.mode="offline" \
engine.test_ds.augmentor.noise.manifest_path=<manifest file for noise data>
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
Note because the PR is getting bigger, on-the-fly augmentation for buffered inference mode would be included in another PR soon.
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5728/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5728/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5727 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5727/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5727/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5727/events | https://github.com/NVIDIA/NeMo/pull/5727 | 1,517,928,707 | PR_kwDOC_bI7s5GkbFW | 5,727 | [ASR] Use a subset of manifest when using `scatter` shard strategy | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-03T21:19:32 | 2023-02-09T23:57:33 | 2023-02-09T17:48:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5727",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5727",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5727.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5727.patch",
"merged_at": null
} | # What does this PR do ?
When using `shard_strategy='scatter'` this PR loads only a subset of lines from the manifest file.
This may reduce the time to process a manifest file by an order of magnitude.
Opening as a draft to get feedback if there are any underlying assumptions which may be broken by this change.
**Collection**: ASR
# Changelog
| File | Change |
| ---------------- | -------- |
| `manifest.py::item_iter` | Load only a subset of lines if `shard_strategy == 'scatter'` |
| `collections.py:: ASRAudioText ` | forward `shard_strategy`, `global_rank` and `world_size` to `manifest.item_iter` |
| `collections.py:: AudioText ` | Use rank and world size to restore the original data list length for `shard_strategy='scatter'` |
| `audio_to_text.py` | forward `shard_strategy`, `global_rank` and `world_size` to `collections.ASRAudioText` |
| `utils,py` | Added a function to get number of lines from a text file |
| `test_utils.py` | Added unit test for the utility function added above |
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5727/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5727/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5726 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5726/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5726/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5726/events | https://github.com/NVIDIA/NeMo/issues/5726 | 1,517,703,763 | I_kwDOC_bI7s5adlJT | 5,726 | Hard coded padding index for embeddings of transformer models | {
"login": "pks",
"id": 368183,
"node_id": "MDQ6VXNlcjM2ODE4Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/368183?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pks",
"html_url": "https://github.com/pks",
"followers_url": "https://api.github.com/users/pks/followers",
"following_url": "https://api.github.com/users/pks/following{/other_user}",
"gists_url": "https://api.github.com/users/pks/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pks/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pks/subscriptions",
"organizations_url": "https://api.github.com/users/pks/orgs",
"repos_url": "https://api.github.com/users/pks/repos",
"events_url": "https://api.github.com/users/pks/events{/privacy}",
"received_events_url": "https://api.github.com/users/pks/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-01-03T17:25:55 | 2023-01-06T08:53:46 | 2023-01-06T04:48:57 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
In `nemo/collections/nlp/modules/common/transformer/transformer_modules.py` a hard coded `padding_idx` is set (value 0):
https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/modules/common/transformer/transformer_modules.py#L112
According to the [documentation](https://pytorch.org/docs/stable/generated/torch.nn.Embedding.html) of `nn.Embedding` this will set the respective column to zeros on initialization. Given that the padding may be at different indices for different models (i.e. tokenizers) this should be set accordingly, and not be hard coded to index 0.
I'm also not sure if the statement from the documentation holds true for NeMo trained models:
> [...] the embedding vector at padding_idx is not updated during training, [...]
as the pertained ende model (`nmt_en_de_transformer12x2.nemo`) has non-zero weights at index 0:
```
>>> checkpoint = torch.load("model_weights.ckpt", map_location="cpu")
>>> checkpoint["decoder._embedding.token_embedding.weight"][0]
tensor([-0.0071, -0.0716, 0.0123, ..., 0.0321, 0.0360, 0.0308])
```
I could also reproduce this with a custom trained model.
**Steps/Code to reproduce bug**
1. Observe that `padding_idx` is set to a hard coded value.
2. Observe that none of the columns of the embeddings are all zeros in the pertained MTEncDec models.
**Expected behavior**
1. `padding_idx` gets set according to the index of `<pad>` in the respective tokenizer.
2. The column at `padding_idx` does not get trained/updated during training.
**Environment overview (please complete the following information)**
- Any
**Environment details**
- Any
**Additional context**
- Potential fix: https://github.com/NVIDIA/NeMo/pull/5543
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5726/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5726/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5725 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5725/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5725/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5725/events | https://github.com/NVIDIA/NeMo/pull/5725 | 1,517,597,991 | PR_kwDOC_bI7s5GjT6h | 5,725 | Don't print exp_manager warning when max_steps == -1 | {
"login": "milesial",
"id": 30204471,
"node_id": "MDQ6VXNlcjMwMjA0NDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/30204471?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/milesial",
"html_url": "https://github.com/milesial",
"followers_url": "https://api.github.com/users/milesial/followers",
"following_url": "https://api.github.com/users/milesial/following{/other_user}",
"gists_url": "https://api.github.com/users/milesial/gists{/gist_id}",
"starred_url": "https://api.github.com/users/milesial/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/milesial/subscriptions",
"organizations_url": "https://api.github.com/users/milesial/orgs",
"repos_url": "https://api.github.com/users/milesial/repos",
"events_url": "https://api.github.com/users/milesial/events{/privacy}",
"received_events_url": "https://api.github.com/users/milesial/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2023-01-03T16:00:10 | 2023-01-03T22:50:16 | 2023-01-03T22:50:16 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5725",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5725",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5725.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5725.patch",
"merged_at": "2023-01-03T22:50:16"
} | # What does this PR do ?
Doesn't print a warning when max_steps == -1 and val monitoring. For example, when we just provide max_epochs we don't want to see that warning.
```
[NeMo W 2023-01-03 15:47:31 exp_manager:988] The checkpoint callback was told to monitor a validation value and trainer's max_steps was set to -1. Please ensure that max_steps will run for at least 1 epochs to ensure that checkpointing will not error out.
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5725/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5725/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5724 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5724/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5724/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5724/events | https://github.com/NVIDIA/NeMo/pull/5724 | 1,517,236,933 | PR_kwDOC_bI7s5GiFxW | 5,724 | Ensure EMA checkpoints are also deleted when normal checkpoints are | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2023-01-03T11:05:25 | 2023-01-05T19:27:57 | 2023-01-05T19:27:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5724",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5724",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5724.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5724.patch",
"merged_at": "2023-01-05T19:27:49"
} | # What does this PR do ?
Closes #5631
**Collection**: Common
# Changelog
- Delete EMA checkpoints when normal checkpoints are deleted.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5724/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5724/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5723 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5723/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5723/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5723/events | https://github.com/NVIDIA/NeMo/issues/5723 | 1,517,134,880 | I_kwDOC_bI7s5abaQg | 5,723 | Error converting p-tuned model for inferencing | {
"login": "RaiAmanRai",
"id": 102528851,
"node_id": "U_kgDOBhx3Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/102528851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RaiAmanRai",
"html_url": "https://github.com/RaiAmanRai",
"followers_url": "https://api.github.com/users/RaiAmanRai/followers",
"following_url": "https://api.github.com/users/RaiAmanRai/following{/other_user}",
"gists_url": "https://api.github.com/users/RaiAmanRai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RaiAmanRai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RaiAmanRai/subscriptions",
"organizations_url": "https://api.github.com/users/RaiAmanRai/orgs",
"repos_url": "https://api.github.com/users/RaiAmanRai/repos",
"events_url": "https://api.github.com/users/RaiAmanRai/events{/privacy}",
"received_events_url": "https://api.github.com/users/RaiAmanRai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-03T09:34:15 | 2023-02-10T02:02:21 | 2023-02-10T02:02:21 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I am trying to p-tune a megatron_gpt_345m model using the steps and the notebook mentioned in the NeMo repo [here](https://github.com/NVIDIA/NeMo/blob/main/tutorials/nlp/Multitask_Prompt_and_PTuning.ipynb).
I am able to p-tune the model for my tasks, however when I try to convert it to [FasterTransformer](https://github.com/NVIDIA/FasterTransformer) format following the steps mentioned [here](https://developer.nvidia.com/blog/deploying-a-1-3b-gpt-3-model-with-nvidia-nemo-megatron/), I get a `KeyError`.
```
WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
============
== BigNLP ==
============
NVIDIA Release 22.08.01 (build 44509868)
Container image Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
Copyright (c) 2019-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
Copyright (c) 2014-2022 Facebook Inc.
Copyright (c) 2011-2014 Idiap Research Institute (Ronan Collobert)
Copyright (c) 2012-2014 Deepmind Technologies (Koray Kavukcuoglu)
Copyright (c) 2011-2012 NEC Laboratories America (Koray Kavukcuoglu)
Copyright (c) 2011-2013 NYU (Clement Farabet)
Copyright (c) 2006-2010 NEC Laboratories America (Ronan Collobert, Leon Bottou, Iain Melvin, Jason Weston)
Copyright (c) 2006 Idiap Research Institute (Samy Bengio)
Copyright (c) 2001-2004 Idiap Research Institute (Ronan Collobert, Samy Bengio, Johnny Mariethoz)
Copyright (c) 2015 Google Inc.
Copyright (c) 2015 Yangqing Jia
Copyright (c) 2013-2016 The Caffe contributors
All rights reserved.
Various files include modifications (c) NVIDIA CORPORATION & AFFILIATES. All rights reserved.
This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license
NOTE: Mellanox network driver detected, but NVIDIA peer memory driver not
detected. Multi-node communication performance may be reduced.
2023-01-03 09:32:00,492 __main__ [INFO] Spent 0:00:00.002772 (h:m:s) to unpack NeMo archive
=============== Argument ===============
saved_dir: /model_repository/p_tuned_gpt
in_file: /checkpoints/multitask_p_tuned_gpt.nemo
prompt_in_file: None
prompt_saved_dir: None
infer_gpu_num: 1
fused_qkv: 1
processes: 16
weight_data_type: fp16
load_checkpoints_to_cpu: 0
vocab_path: None
merges_path: None
tokenizer_model_path: None
verbose: False
========================================
Traceback (most recent call last):
File "FasterTransformer/examples/pytorch/gpt/utils/nemo_ckpt_convert.py", line 656, in <module>
main()
File "FasterTransformer/examples/pytorch/gpt/utils/nemo_ckpt_convert.py", line 629, in main
convert_checkpoint(unpacked_checkpoint_dir, args)
File "FasterTransformer/examples/pytorch/gpt/utils/nemo_ckpt_convert.py", line 280, in convert_checkpoint
val = model_00.get("state_dict", model_00)["model.language_model.embedding.position_embeddings.weight"]
KeyError: 'model.language_model.embedding.position_embeddings.weight'
```
**Steps/Code to reproduce bug**
Here's the complete docker command for converting the p-tuned `.nemo` model
```
docker run --rm \
--gpus '"device=0"' \
--shm-size=16GB \
--cpus 16 --memory 32g \
-v /opt/NeMo/additional_data:/checkpoints \
-v /opt/NeMo/additional_data/output:/model_repository \
--network dbr0 \
nvcr.io/ea-bignlp/bignlp-training:22.08.01-py3 \
bash -c 'export PYTHONPATH=/opt/bignlp/FasterTransformer:${PYTHONPATH} && \
cd /opt/bignlp && \
python3 FasterTransformer/examples/pytorch/gpt/utils/nemo_ckpt_convert.py \
--in-file /checkpoints/multitask_p_tuned_gpt.nemo \
--infer-gpu-num 1 \
--saved-dir /model_repository/p_tuned_gpt \
--weight-data-type fp16 \
--load-checkpoints-to-cpu 0 && \
python3 /opt/bignlp/bignlp-scripts/bignlp/collections/export_scripts/prepare_triton_model_config.py \
--model-train-name p_tuned_gpt \
--template-path /opt/bignlp/fastertransformer_backend/all_models/gpt/fastertransformer/config.pbtxt \
--ft-checkpoint /model_repository/p_tuned_gpt/1-gpu \
--config-path /model_repository/p_tuned_gpt/config.pbtxt \
--max-batch-size 256 \
--pipeline-model-parallel-size 1 \
--tensor-model-parallel-size 1 \
--data-type bf16'
```
**Expected behavior**
The converted is generated and stored in the output directory mounted
**Environment overview (please complete the following information)**
Here is the docker pull command
`docker pull nvcr.io/ea-bignlp/bignlp-training:22.08.01-py3`
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5723/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5723/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5722 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5722/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5722/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5722/events | https://github.com/NVIDIA/NeMo/pull/5722 | 1,516,849,025 | PR_kwDOC_bI7s5Ggzf0 | 5,722 | [pre-commit.ci] pre-commit suggestions | {
"login": "pre-commit-ci[bot]",
"id": 66853113,
"node_id": "MDM6Qm90NjY4NTMxMTM=",
"avatar_url": "https://avatars.githubusercontent.com/in/68672?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D",
"html_url": "https://github.com/apps/pre-commit-ci",
"followers_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-03T01:57:44 | 2023-01-03T02:27:55 | 2023-01-03T02:27:55 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5722",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5722",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5722.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5722.patch",
"merged_at": null
} | <!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](https://github.com/pre-commit/pre-commit-hooks/compare/v4.3.0...v4.4.0)
- [github.com/PyCQA/isort: 4.3.21 → 5.11.4](https://github.com/PyCQA/isort/compare/4.3.21...5.11.4)
- [github.com/psf/black: 19.10b0 → 22.12.0](https://github.com/psf/black/compare/19.10b0...22.12.0)
<!--pre-commit.ci end--> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5722/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5722/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5720 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5720/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5720/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5720/events | https://github.com/NVIDIA/NeMo/pull/5720 | 1,516,174,058 | PR_kwDOC_bI7s5GejH8 | 5,720 | pin torchmetrics version | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-02T09:08:10 | 2023-01-04T16:59:26 | 2023-01-04T16:59:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5720",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5720",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5720.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5720.patch",
"merged_at": "2023-01-04T16:59:21"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Fix torchmetrics version, as latest version has issues with pytorch Dataloader loading time.
**Collection**: ASR
# Changelog
- pin torchmetrics version to 0.10.3
- revert accuracy API to 0.10.3 from 0.11.0
- revert Speaker Jenkins run
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5720/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5720/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5719 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5719/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5719/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5719/events | https://github.com/NVIDIA/NeMo/pull/5719 | 1,515,974,144 | PR_kwDOC_bI7s5Gd3hq | 5,719 | Add extra data args to support proper finetuning of HF converted T5 checkpoints | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2023-01-02T02:50:47 | 2023-01-10T22:57:47 | 2023-01-10T22:57:44 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5719",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5719",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5719.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5719.patch",
"merged_at": "2023-01-10T22:57:44"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Adds args that can configure whether to add bos/eos to the encoder and to replace bos with the pad token for HF converted T5 checkpoints.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5719/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5719/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5718 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5718/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5718/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5718/events | https://github.com/NVIDIA/NeMo/issues/5718 | 1,515,561,369 | I_kwDOC_bI7s5aVaGZ | 5,718 | Univnet model | {
"login": "alexandercesarr",
"id": 105767588,
"node_id": "U_kgDOBk3ipA",
"avatar_url": "https://avatars.githubusercontent.com/u/105767588?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/alexandercesarr",
"html_url": "https://github.com/alexandercesarr",
"followers_url": "https://api.github.com/users/alexandercesarr/followers",
"following_url": "https://api.github.com/users/alexandercesarr/following{/other_user}",
"gists_url": "https://api.github.com/users/alexandercesarr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/alexandercesarr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexandercesarr/subscriptions",
"organizations_url": "https://api.github.com/users/alexandercesarr/orgs",
"repos_url": "https://api.github.com/users/alexandercesarr/repos",
"events_url": "https://api.github.com/users/alexandercesarr/events{/privacy}",
"received_events_url": "https://api.github.com/users/alexandercesarr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2023-01-01T13:22:59 | 2023-03-20T01:58:13 | 2023-03-20T01:58:13 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi. I have trained univnet model and I faced 2 issues.
1. model has memory leak
2. high response time
I attempt to convert model to onnx but I got this error:
`torch.onnx.errors.SymbolicValueError: Unsupported: ONNX export of operator Unfold, input size not accessible. Please feel free to request support or submit a pull request on PyTorch GitHub: https://github.com/pytorch/pytorch/issues [Caused by the value '381 defined in (%381 : Float(*, *, *, strides=[65600, 2050, 1], requires_grad=0, device=cuda:0) = onnx::Pad[mode="constant"](%output, %379, %380), scope: nemo.collections.tts.models.univnet.UnivNetModel::/nemo.collections.tts.modules.univnet_modules.Generator::generator/nemo.collections.tts.modules.univnet_modules.LVCBlock::res_stack.0
`
do you have any idea to fix this problem?Is fixing the memory leak problem on your plan?
@redoctopus | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5718/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5718/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5717 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5717/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5717/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5717/events | https://github.com/NVIDIA/NeMo/pull/5717 | 1,514,728,198 | PR_kwDOC_bI7s5GZnEV | 5,717 | Hungarian TN (cleaned) | {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-12-30T18:52:50 | 2022-12-30T18:52:58 | 2022-12-30T18:52:55 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5717",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5717",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5717.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5717.patch",
"merged_at": null
} | # What does this PR do ?
As with #5715 creating to show provenance + close
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5717/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5717/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5716 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5716/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5716/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5716/events | https://github.com/NVIDIA/NeMo/pull/5716 | 1,514,702,868 | PR_kwDOC_bI7s5GZhWy | 5,716 | Hungarian TN | {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-12-30T18:19:49 | 2022-12-30T18:47:44 | 2022-12-30T18:19:55 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5716",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5716",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5716.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5716.patch",
"merged_at": null
} | # What does this PR do ?
As with #5715 creating to show provenance + close
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5716/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5716/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5715 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5715/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5715/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5715/events | https://github.com/NVIDIA/NeMo/pull/5715 | 1,514,596,401 | PR_kwDOC_bI7s5GZKNO | 5,715 | [in progress] Add Swedish TN | {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-12-30T15:31:22 | 2023-01-02T11:27:10 | 2022-12-30T15:31:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5715",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5715",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5715.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5715.patch",
"merged_at": null
} | # What does this PR do ?
I've just seen that the text processing module has moved; this is messy, includes pieces that ought to be in other places, and just generally needs a cleanup. The main point of making the pull request is to show that I didn't just pluck this stuff from thin air.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jimregan",
"id": 227350,
"node_id": "MDQ6VXNlcjIyNzM1MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/227350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jimregan",
"html_url": "https://github.com/jimregan",
"followers_url": "https://api.github.com/users/jimregan/followers",
"following_url": "https://api.github.com/users/jimregan/following{/other_user}",
"gists_url": "https://api.github.com/users/jimregan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jimregan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimregan/subscriptions",
"organizations_url": "https://api.github.com/users/jimregan/orgs",
"repos_url": "https://api.github.com/users/jimregan/repos",
"events_url": "https://api.github.com/users/jimregan/events{/privacy}",
"received_events_url": "https://api.github.com/users/jimregan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5715/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5715/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5714 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5714/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5714/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5714/events | https://github.com/NVIDIA/NeMo/issues/5714 | 1,514,263,584 | I_kwDOC_bI7s5aQdQg | 5,714 | Tacotron Finetune Error(s) in loading state_dict for Tacotron2Model: size mismatch | {
"login": "dustinjoe",
"id": 7971146,
"node_id": "MDQ6VXNlcjc5NzExNDY=",
"avatar_url": "https://avatars.githubusercontent.com/u/7971146?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dustinjoe",
"html_url": "https://github.com/dustinjoe",
"followers_url": "https://api.github.com/users/dustinjoe/followers",
"following_url": "https://api.github.com/users/dustinjoe/following{/other_user}",
"gists_url": "https://api.github.com/users/dustinjoe/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dustinjoe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dustinjoe/subscriptions",
"organizations_url": "https://api.github.com/users/dustinjoe/orgs",
"repos_url": "https://api.github.com/users/dustinjoe/repos",
"events_url": "https://api.github.com/users/dustinjoe/events{/privacy}",
"received_events_url": "https://api.github.com/users/dustinjoe/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-12-30T05:48:24 | 2023-01-27T21:40:08 | 2023-01-06T18:37:10 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi, Nemo Developer:
Happy new year first.
**Describe the bug**
I am trying to have a trial on voice clone. So I am trying to finetune a TTS model based on a test person's voice clips. Have successfully realized this using that FastPitch notebook. I am stuck on Tacotron2 finetune trial.
**Steps/Code to reproduce bug**
I am trying to run that tacotron2_finetune.py for the training. As my audio clips are 22050hz, I modified the three parameters in the tacotron2_44100.yaml following the 22050hz original tacotron2.yaml training config file:
n_window_size: 1024
n_window_stride: 256
n_fft: 1024
Other configs untouched.
**Expected behavior**
I am running it as:
`!(python tacotron2_finetune.py --config-name=tacotron2_22050.yaml \
train_dataset=./TestFileList.json \
validation_datasets=./TestFileList.json \
exp_manager.exp_dir=./ljspeech_to_test_no_mixing \
+init_from_nemo_model=./tts_en_tacotron2.nemo \
trainer.max_epochs=20 \
trainer.check_val_every_n_epoch=5 \
model.train_ds.dataloader_params.batch_size=24 model.validation_ds.dataloader_params.batch_size=24 \
)`
So I am mainly adding the pretrained model of the original pretrained tacotron2 model.
The output is shown as below:
`[NeMo I 2022-12-29 23:33:49 features:267] PADDING: 16
[NeMo I 2022-12-29 23:33:49 save_restore_connector:243] Model Tacotron2Model was successfully restored from /media/xyzhou/extDisk2t1/DeepFake_Audio/Nemo_Clone/tts_nemo/tts_en_tacotron2.nemo.
Error executing job with overrides: ['train_dataset=./EricFileList.json', 'validation_datasets=./EricFileList.json', 'exp_manager.exp_dir=./ljspeech_to_eric_no_mixing', '+init_from_nemo_model=./tts_en_tacotron2.nemo', 'trainer.max_epochs=20', 'trainer.check_val_every_n_epoch=5', 'model.train_ds.dataloader_params.batch_size=24', 'model.validation_ds.dataloader_params.batch_size=24']
Traceback (most recent call last):
File "tacotron2_finetune.py", line 35, in main
model.maybe_init_from_pretrained_checkpoint(cfg=cfg)
File "/home/xyzhou/anaconda3/envs/nemo/lib/python3.8/site-packages/lightning_utilities/core/rank_zero.py", line 24, in wrapped_fn
return fn(*args, **kwargs)
File "/home/xyzhou/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/core/classes/modelPT.py", line 1066, in maybe_init_from_pretrained_checkpoint
self.load_state_dict(restored_model.state_dict(), strict=False)
File "/home/xyzhou/anaconda3/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1671, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Tacotron2Model:
size mismatch for text_embedding.weight: copying a param with shape torch.Size([69, 512]) from checkpoint, the shape in current model is torch.Size([114, 512]).`
The the main error shown is the final part:
RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format( RuntimeError: Error(s) in loading state_dict for Tacotron2Model: size mismatch for text_embedding.weight: copying a param with shape torch.Size([69, 512]) from checkpoint, the shape in current model is torch.Size([114, 512]).
Not sure how to deal with this. Thank you!
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5714/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5714/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5713 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5713/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5713/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5713/events | https://github.com/NVIDIA/NeMo/issues/5713 | 1,513,509,262 | I_kwDOC_bI7s5aNlGO | 5,713 | stt_zh_citrinet_1024_gamma_0_25 will not be found in ASRDecoderTimeStamps | {
"login": "Qxxxx",
"id": 10084303,
"node_id": "MDQ6VXNlcjEwMDg0MzAz",
"avatar_url": "https://avatars.githubusercontent.com/u/10084303?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Qxxxx",
"html_url": "https://github.com/Qxxxx",
"followers_url": "https://api.github.com/users/Qxxxx/followers",
"following_url": "https://api.github.com/users/Qxxxx/following{/other_user}",
"gists_url": "https://api.github.com/users/Qxxxx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Qxxxx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Qxxxx/subscriptions",
"organizations_url": "https://api.github.com/users/Qxxxx/orgs",
"repos_url": "https://api.github.com/users/Qxxxx/repos",
"events_url": "https://api.github.com/users/Qxxxx/events{/privacy}",
"received_events_url": "https://api.github.com/users/Qxxxx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-12-29T08:33:52 | 2023-02-06T01:57:32 | 2023-02-06T01:57:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi Nemo developers,
**Describe the bug**
I tried to run tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb with chinese data. When I changed the model from `cfg.diarizer.asr.model_path = 'stt_en_conformer_ctc_large'` to `stt_zh_citrinet_1024_gamma_0_25`, the model could not be found correctly because of the logic in https://github.com/NVIDIA/NeMo/blob/58d6765929d7c13ab933640d74630493957b1dfb/nemo/collections/asr/parts/utils/decoder_timestamps_utils.py#L331-L356.
According to current logic, as `stt_zh_citrinet_1024_gamma_0_25` contains citrinet it will go to
https://github.com/NVIDIA/NeMo/blob/58d6765929d7c13ab933640d74630493957b1dfb/nemo/collections/asr/parts/utils/decoder_timestamps_utils.py#L350-L356
the `self.encdec_class` will be `EncDecCTCModelBPE`.
However the `stt_zh_citrinet_1024_gamma_0_25` is listed here.
https://github.com/NVIDIA/NeMo/blob/58d6765929d7c13ab933640d74630493957b1dfb/nemo/collections/asr/models/ctc_models.py#L818-L822
Belongs to `EncDecCTCModel`.
I create a PR(https://github.com/NVIDIA/NeMo/pull/5712) that will not solve the issue but could express my point more clearly.
BRs,
Qxxxx
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5713/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5713/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5712 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5712/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5712/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5712/events | https://github.com/NVIDIA/NeMo/pull/5712 | 1,513,508,269 | PR_kwDOC_bI7s5GViOw | 5,712 | Fix zh_citrinet not found | {
"login": "Qxxxx",
"id": 10084303,
"node_id": "MDQ6VXNlcjEwMDg0MzAz",
"avatar_url": "https://avatars.githubusercontent.com/u/10084303?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Qxxxx",
"html_url": "https://github.com/Qxxxx",
"followers_url": "https://api.github.com/users/Qxxxx/followers",
"following_url": "https://api.github.com/users/Qxxxx/following{/other_user}",
"gists_url": "https://api.github.com/users/Qxxxx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Qxxxx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Qxxxx/subscriptions",
"organizations_url": "https://api.github.com/users/Qxxxx/orgs",
"repos_url": "https://api.github.com/users/Qxxxx/repos",
"events_url": "https://api.github.com/users/Qxxxx/events{/privacy}",
"received_events_url": "https://api.github.com/users/Qxxxx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-29T08:32:19 | 2023-01-20T02:00:21 | 2023-01-20T02:00:21 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5712",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5712",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5712.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5712.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5712/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5712/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5707 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5707/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5707/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5707/events | https://github.com/NVIDIA/NeMo/issues/5707 | 1,512,659,225 | I_kwDOC_bI7s5aKVkZ | 5,707 | Update libraries on Tutorial - Cython, gcc, g++ | {
"login": "Jasonlee1995",
"id": 49643709,
"node_id": "MDQ6VXNlcjQ5NjQzNzA5",
"avatar_url": "https://avatars.githubusercontent.com/u/49643709?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jasonlee1995",
"html_url": "https://github.com/Jasonlee1995",
"followers_url": "https://api.github.com/users/Jasonlee1995/followers",
"following_url": "https://api.github.com/users/Jasonlee1995/following{/other_user}",
"gists_url": "https://api.github.com/users/Jasonlee1995/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jasonlee1995/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jasonlee1995/subscriptions",
"organizations_url": "https://api.github.com/users/Jasonlee1995/orgs",
"repos_url": "https://api.github.com/users/Jasonlee1995/repos",
"events_url": "https://api.github.com/users/Jasonlee1995/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jasonlee1995/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-12-28T10:40:44 | 2022-12-28T19:02:49 | 2022-12-28T18:56:28 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi.
I'm new on this field and I was going to follow [this tutorial](https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/ASR_with_NeMo.ipynb) step by step.
I just made new environment using conda on my linux server and stuck with issue below.
<img width="800" alt="image" src="https://user-images.githubusercontent.com/49643709/209797058-49fa20b2-21bc-476b-929c-a2479512ac36.png">
I installed cython and stuck again like below.
<img width="800" alt="image" src="https://user-images.githubusercontent.com/49643709/209798306-f7250507-2031-4e57-9b9d-d6f6642f7964.png">
I run `apt-get install gcc` and stuck again with issue below.
<img width="800" alt="image" src="https://user-images.githubusercontent.com/49643709/209798768-a3cedfc7-a34c-411a-a13a-e16ed907c311.png">
I run `apt-get install g++` and install just works well.
For newbie like me, it would be more great to prevent someone is getting stuck at installation.
So how about adding this commands?
```
pip install cython
apt-get install gcc
apt-get install g++
``` | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5707/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5707/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5706 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5706/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5706/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5706/events | https://github.com/NVIDIA/NeMo/issues/5706 | 1,512,481,676 | I_kwDOC_bI7s5aJqOM | 5,706 | Can't pull docker image | {
"login": "RaiAmanRai",
"id": 102528851,
"node_id": "U_kgDOBhx3Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/102528851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RaiAmanRai",
"html_url": "https://github.com/RaiAmanRai",
"followers_url": "https://api.github.com/users/RaiAmanRai/followers",
"following_url": "https://api.github.com/users/RaiAmanRai/following{/other_user}",
"gists_url": "https://api.github.com/users/RaiAmanRai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RaiAmanRai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RaiAmanRai/subscriptions",
"organizations_url": "https://api.github.com/users/RaiAmanRai/orgs",
"repos_url": "https://api.github.com/users/RaiAmanRai/repos",
"events_url": "https://api.github.com/users/RaiAmanRai/events{/privacy}",
"received_events_url": "https://api.github.com/users/RaiAmanRai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-12-28T07:08:17 | 2022-12-30T06:35:59 | 2022-12-30T06:35:58 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
According to the article by nvidia published [here](https://developer.nvidia.com/blog/deploying-a-1-3b-gpt-3-model-with-nvidia-nemo-megatron/), mentions the use of a couple of docker images
```
nvcr.io/ea-bignlp/bignlp-training:22.08.01-py3
nvcr.io/ea-bignlp/bignlp-inference:22.08-py3
```
in order to use or inference on LLM. But while pulling the images I am encountering the access denied error.
**This is still the condition even after successfully logging in to nvcr.io**
**Steps/Code to reproduce bug**
docker login nvcr.io
Username: $oauthtoken
Password: <**your SECRET KEY**>
```
docker pull nvcr.io/ea-bignlp/bignlp-training:22.08.01-py3
docker pull nvcr.io/ea-bignlp/bignlp-inference:22.08-py3
```
**Expected behavior**
The docker should start pulling the images.
| {
"login": "RaiAmanRai",
"id": 102528851,
"node_id": "U_kgDOBhx3Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/102528851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RaiAmanRai",
"html_url": "https://github.com/RaiAmanRai",
"followers_url": "https://api.github.com/users/RaiAmanRai/followers",
"following_url": "https://api.github.com/users/RaiAmanRai/following{/other_user}",
"gists_url": "https://api.github.com/users/RaiAmanRai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RaiAmanRai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RaiAmanRai/subscriptions",
"organizations_url": "https://api.github.com/users/RaiAmanRai/orgs",
"repos_url": "https://api.github.com/users/RaiAmanRai/repos",
"events_url": "https://api.github.com/users/RaiAmanRai/events{/privacy}",
"received_events_url": "https://api.github.com/users/RaiAmanRai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5706/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5706/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5705 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5705/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5705/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5705/events | https://github.com/NVIDIA/NeMo/pull/5705 | 1,512,168,847 | PR_kwDOC_bI7s5GRC5K | 5,705 | Merge 1.14.0 main | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-12-27T21:12:38 | 2022-12-28T18:19:12 | 2022-12-28T18:19:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5705",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5705",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5705.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5705.patch",
"merged_at": "2022-12-28T18:19:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5705/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5705/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5704 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5704/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5704/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5704/events | https://github.com/NVIDIA/NeMo/pull/5704 | 1,511,953,716 | PR_kwDOC_bI7s5GQUNk | 5,704 | Bump setuptools from 59.5.0 to 65.5.1 in /requirements | {
"login": "dependabot[bot]",
"id": 49699333,
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"html_url": "https://github.com/apps/dependabot",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4950010227,
"node_id": "LA_kwDOC_bI7s8AAAABJwspcw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/dependencies",
"name": "dependencies",
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file"
}
] | closed | false | null | [] | null | null | 2022-12-27T16:17:55 | 2022-12-27T18:21:21 | 2022-12-27T18:21:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5704",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5704",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5704.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5704.patch",
"merged_at": "2022-12-27T18:21:18"
} | Bumps [setuptools](https://github.com/pypa/setuptools) from 59.5.0 to 65.5.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pypa/setuptools/releases">setuptools's releases</a>.</em></p>
<blockquote>
<h2>v65.5.1</h2>
<p>No release notes provided.</p>
<h2>v65.5.0</h2>
<p>No release notes provided.</p>
<h2>v65.4.1</h2>
<p>No release notes provided.</p>
<h2>v65.4.0</h2>
<p>No release notes provided.</p>
<h2>v65.3.0</h2>
<p>No release notes provided.</p>
<h2>v65.2.0</h2>
<p>No release notes provided.</p>
<h2>v65.1.1</h2>
<p>No release notes provided.</p>
<h2>v65.1.0</h2>
<p>No release notes provided.</p>
<h2>v65.0.2</h2>
<p>No release notes provided.</p>
<h2>v65.0.1</h2>
<p>No release notes provided.</p>
<h2>v65.0.0</h2>
<p>No release notes provided.</p>
<h2>v64.0.3</h2>
<p>No release notes provided.</p>
<h2>v64.0.2</h2>
<p>No release notes provided.</p>
<h2>v64.0.1</h2>
<p>No release notes provided.</p>
<h2>v64.0.0</h2>
<p>No release notes provided.</p>
<h2>v63.4.3</h2>
<p>No release notes provided.</p>
<h2>v63.4.2</h2>
<p>No release notes provided.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/pypa/setuptools/blob/main/CHANGES.rst">setuptools's changelog</a>.</em></p>
<blockquote>
<h2>v65.5.1</h2>
<p>Misc
^^^^</p>
<ul>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3638">#3638</a>: Drop a test dependency on the <code>mock</code> package, always use :external+python:py:mod:<code>unittest.mock</code> -- by :user:<code>hroncok</code></li>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3659">#3659</a>: Fixed REDoS vector in package_index.</li>
</ul>
<h2>v65.5.0</h2>
<p>Changes
^^^^^^^</p>
<ul>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3624">#3624</a>: Fixed editable install for multi-module/no-package <code>src</code>-layout projects.</li>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3626">#3626</a>: Minor refactorings to support distutils using stdlib logging module.</li>
</ul>
<p>Documentation changes
^^^^^^^^^^^^^^^^^^^^^</p>
<ul>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3419">#3419</a>: Updated the example version numbers to be compliant with PEP-440 on the "Specifying Your Project’s Version" page of the user guide.</li>
</ul>
<p>Misc
^^^^</p>
<ul>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3569">#3569</a>: Improved information about conflicting entries in the current working directory
and editable install (in documentation and as an informational warning).</li>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3576">#3576</a>: Updated version of <code>validate_pyproject</code>.</li>
</ul>
<h2>v65.4.1</h2>
<p>Misc
^^^^</p>
<ul>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3613">#3613</a>: Fixed encoding errors in <code>expand.StaticModule</code> when system default encoding doesn't match expectations for source files.</li>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3617">#3617</a>: Merge with pypa/distutils@6852b20 including fix for <a href="https://github-redirect.dependabot.com/pypa/distutils/issues/181">pypa/distutils#181</a>.</li>
</ul>
<h2>v65.4.0</h2>
<p>Changes
^^^^^^^</p>
<ul>
<li><a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3609">#3609</a>: Merge with pypa/distutils@d82d926 including support for DIST_EXTRA_CONFIG in <a href="https://github-redirect.dependabot.com/pypa/distutils/issues/177">pypa/distutils#177</a>.</li>
</ul>
<p>v65.3.0</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pypa/setuptools/commit/a462cb5edb324dcc56f903524b742305e4087014"><code>a462cb5</code></a> Bump version: 65.5.0 → 65.5.1</li>
<li><a href="https://github.com/pypa/setuptools/commit/de35d8be997c9f8508b425e33a1b6e52431091fa"><code>de35d8b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3656">#3656</a> from bmorris3/typos</li>
<li><a href="https://github.com/pypa/setuptools/commit/58e23de0d4c2ce0f2502d072bb9a2ed1e2ab0ba6"><code>58e23de</code></a> Update changelog. Ref <a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3659">#3659</a>.</li>
<li><a href="https://github.com/pypa/setuptools/commit/43a9c9bfa6aa626ec2a22540bea28d2ca77964be"><code>43a9c9b</code></a> Limit the amount of whitespace to search/backtrack. Fixes <a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3659">#3659</a>.</li>
<li><a href="https://github.com/pypa/setuptools/commit/579134321d4d9397c886a5cb50cc26d0e3fa4279"><code>5791343</code></a> Add test capturing failed expectation. Ref <a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3659">#3659</a>.</li>
<li><a href="https://github.com/pypa/setuptools/commit/1f97905bc40310ca454ff1ea3884f233b7dcc88c"><code>1f97905</code></a> ⚫ Fade to black.</li>
<li><a href="https://github.com/pypa/setuptools/commit/6254567c6ae323bb8ce19a6930ae3cc5f7fb25cc"><code>6254567</code></a> Remove workaround for emacs.</li>
<li><a href="https://github.com/pypa/setuptools/commit/729b180e926634930c21ccce5558780d42707763"><code>729b180</code></a> ⚫ Fade to black.</li>
<li><a href="https://github.com/pypa/setuptools/commit/c068081a7234a0c5c322a9312654e7d0f4aaa8d1"><code>c068081</code></a> Typo corrections</li>
<li><a href="https://github.com/pypa/setuptools/commit/f777a40ed9abf529906c2939f80a184a5ed035fa"><code>f777a40</code></a> Suppress deprecation warning in --rsyncdir. Workaround for <a href="https://github-redirect.dependabot.com/pypa/setuptools/issues/3655">#3655</a>.</li>
<li>Additional commits viewable in <a href="https://github.com/pypa/setuptools/compare/v59.5.0...v65.5.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/NVIDIA/NeMo/network/alerts).
</details> | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5704/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5704/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5703 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5703/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5703/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5703/events | https://github.com/NVIDIA/NeMo/issues/5703 | 1,511,936,754 | I_kwDOC_bI7s5aHlLy | 5,703 | Nemo with multiprocessing | {
"login": "Sasha-Bachynskyi",
"id": 93126453,
"node_id": "U_kgDOBYz_NQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93126453?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sasha-Bachynskyi",
"html_url": "https://github.com/Sasha-Bachynskyi",
"followers_url": "https://api.github.com/users/Sasha-Bachynskyi/followers",
"following_url": "https://api.github.com/users/Sasha-Bachynskyi/following{/other_user}",
"gists_url": "https://api.github.com/users/Sasha-Bachynskyi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sasha-Bachynskyi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sasha-Bachynskyi/subscriptions",
"organizations_url": "https://api.github.com/users/Sasha-Bachynskyi/orgs",
"repos_url": "https://api.github.com/users/Sasha-Bachynskyi/repos",
"events_url": "https://api.github.com/users/Sasha-Bachynskyi/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sasha-Bachynskyi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-12-27T16:00:26 | 2023-01-02T09:03:59 | 2023-01-02T09:03:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello developers.
I have a lot of useful data and would like to retrieve embeddings and get diarization
I thought to use a multiprocessing module to speed up the process. [This module](https://docs.python.org/3/library/multiprocessing.html)
But I failed. If I make a processing pool and add tasks after a while processes stop, and it seems like processes lock themselves
I tried to set up _set_start_method('spawn')_ and it didn't work out, the exception occured
Is there a possibility to use Nemo with a multiprocessing module, has someone had such an experience?
I'll appreciate any help! | {
"login": "Sasha-Bachynskyi",
"id": 93126453,
"node_id": "U_kgDOBYz_NQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93126453?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sasha-Bachynskyi",
"html_url": "https://github.com/Sasha-Bachynskyi",
"followers_url": "https://api.github.com/users/Sasha-Bachynskyi/followers",
"following_url": "https://api.github.com/users/Sasha-Bachynskyi/following{/other_user}",
"gists_url": "https://api.github.com/users/Sasha-Bachynskyi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sasha-Bachynskyi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sasha-Bachynskyi/subscriptions",
"organizations_url": "https://api.github.com/users/Sasha-Bachynskyi/orgs",
"repos_url": "https://api.github.com/users/Sasha-Bachynskyi/repos",
"events_url": "https://api.github.com/users/Sasha-Bachynskyi/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sasha-Bachynskyi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5703/reactions",
"total_count": 2,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5703/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5702 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5702/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5702/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5702/events | https://github.com/NVIDIA/NeMo/issues/5702 | 1,510,877,295 | I_kwDOC_bI7s5aDihv | 5,702 | The predicted output remains empty during training. Training loss is decreasing but validation loss is constant | {
"login": "thani-ath-nain",
"id": 71865085,
"node_id": "MDQ6VXNlcjcxODY1MDg1",
"avatar_url": "https://avatars.githubusercontent.com/u/71865085?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thani-ath-nain",
"html_url": "https://github.com/thani-ath-nain",
"followers_url": "https://api.github.com/users/thani-ath-nain/followers",
"following_url": "https://api.github.com/users/thani-ath-nain/following{/other_user}",
"gists_url": "https://api.github.com/users/thani-ath-nain/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thani-ath-nain/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thani-ath-nain/subscriptions",
"organizations_url": "https://api.github.com/users/thani-ath-nain/orgs",
"repos_url": "https://api.github.com/users/thani-ath-nain/repos",
"events_url": "https://api.github.com/users/thani-ath-nain/events{/privacy}",
"received_events_url": "https://api.github.com/users/thani-ath-nain/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-12-26T11:37:51 | 2022-12-27T13:40:15 | 2022-12-27T13:40:14 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I am training stt_en_conformer_ctc_large on my custom datset+librispeech dev and test splits. Currently, half of epoch 0 has completed but the best value of WER is 1 and logs show epty in predicted. I am a beginner and do not understand the ASR process fully so it must be something that I am doing wrong. Can someone help me?. I am tokenizing using SPE with a vocab size of 15000, and am using the default training script from
```
https://github.com/NVIDIA/NeMo/blob/main/examples/asr/asr_ctc/speech_to_text_ctc_bpe.py
```
and the config from
```
https://github.com/NVIDIA/NeMo/blob/main/examples/asr/conf/conformer/conformer_ctc_bpe.yaml
```
with some fields changed according to my need
**Steps/Code to reproduce bug**
Running the above training script with the config file which contains all the relevant path information.
**Expected behavior**
At least something should be predicted in logs
**Environment overview (please complete the following information)**
- Environment location: AWS
- Method of NeMo install: [pip install nemo_toolkit["all"]
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version Ubuntu 20.04
- PyTorch version 11.7
- Python version 3.8
**Additional context**
Add any other context about the problem here.
Tesla T4
| {
"login": "thani-ath-nain",
"id": 71865085,
"node_id": "MDQ6VXNlcjcxODY1MDg1",
"avatar_url": "https://avatars.githubusercontent.com/u/71865085?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thani-ath-nain",
"html_url": "https://github.com/thani-ath-nain",
"followers_url": "https://api.github.com/users/thani-ath-nain/followers",
"following_url": "https://api.github.com/users/thani-ath-nain/following{/other_user}",
"gists_url": "https://api.github.com/users/thani-ath-nain/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thani-ath-nain/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thani-ath-nain/subscriptions",
"organizations_url": "https://api.github.com/users/thani-ath-nain/orgs",
"repos_url": "https://api.github.com/users/thani-ath-nain/repos",
"events_url": "https://api.github.com/users/thani-ath-nain/events{/privacy}",
"received_events_url": "https://api.github.com/users/thani-ath-nain/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5702/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5702/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5701 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5701/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5701/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5701/events | https://github.com/NVIDIA/NeMo/issues/5701 | 1,510,707,989 | I_kwDOC_bI7s5aC5MV | 5,701 | No confidence score for megatron outputs? | {
"login": "RaiAmanRai",
"id": 102528851,
"node_id": "U_kgDOBhx3Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/102528851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RaiAmanRai",
"html_url": "https://github.com/RaiAmanRai",
"followers_url": "https://api.github.com/users/RaiAmanRai/followers",
"following_url": "https://api.github.com/users/RaiAmanRai/following{/other_user}",
"gists_url": "https://api.github.com/users/RaiAmanRai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RaiAmanRai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RaiAmanRai/subscriptions",
"organizations_url": "https://api.github.com/users/RaiAmanRai/orgs",
"repos_url": "https://api.github.com/users/RaiAmanRai/repos",
"events_url": "https://api.github.com/users/RaiAmanRai/events{/privacy}",
"received_events_url": "https://api.github.com/users/RaiAmanRai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-12-26T07:47:27 | 2023-01-03T08:49:32 | 2023-01-03T08:49:31 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **The outputs form the megatron generations has no scoring method**
For megatron models when `model.generate() `function is called, results returned doesn't contain any scores which could give the confidence of generation.
**Here's a code snippet**
```
response = model.generate(inputs=test_examples, length_params=None)
print(response.keys()
```
Is there a way that could validate these generations from model.
| {
"login": "RaiAmanRai",
"id": 102528851,
"node_id": "U_kgDOBhx3Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/102528851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RaiAmanRai",
"html_url": "https://github.com/RaiAmanRai",
"followers_url": "https://api.github.com/users/RaiAmanRai/followers",
"following_url": "https://api.github.com/users/RaiAmanRai/following{/other_user}",
"gists_url": "https://api.github.com/users/RaiAmanRai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RaiAmanRai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RaiAmanRai/subscriptions",
"organizations_url": "https://api.github.com/users/RaiAmanRai/orgs",
"repos_url": "https://api.github.com/users/RaiAmanRai/repos",
"events_url": "https://api.github.com/users/RaiAmanRai/events{/privacy}",
"received_events_url": "https://api.github.com/users/RaiAmanRai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5701/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5701/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5700 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5700/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5700/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5700/events | https://github.com/NVIDIA/NeMo/issues/5700 | 1,510,320,072 | I_kwDOC_bI7s5aBafI | 5,700 | I could not achieve to run eval_beamsearch_ngram.py script on my GPU. | {
"login": "mesut92",
"id": 8597737,
"node_id": "MDQ6VXNlcjg1OTc3Mzc=",
"avatar_url": "https://avatars.githubusercontent.com/u/8597737?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mesut92",
"html_url": "https://github.com/mesut92",
"followers_url": "https://api.github.com/users/mesut92/followers",
"following_url": "https://api.github.com/users/mesut92/following{/other_user}",
"gists_url": "https://api.github.com/users/mesut92/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mesut92/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mesut92/subscriptions",
"organizations_url": "https://api.github.com/users/mesut92/orgs",
"repos_url": "https://api.github.com/users/mesut92/repos",
"events_url": "https://api.github.com/users/mesut92/events{/privacy}",
"received_events_url": "https://api.github.com/users/mesut92/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-12-25T12:41:17 | 2023-01-02T17:30:30 | 2022-12-28T17:41:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | It is working on CPU but not working on my GPU. I tried Cuda 11.3, 11.8, 12.0 and Python 3.8, 3.9. It did not work. I got same error each time.
This is how i run the code;
`python eval_beamsearch_ngram.py --nemo_model_file /media/mesut/Depo1/models/49/49.nemo --kenlm_model_file /media/mesut/Depo1/models/tbmmV8/final.nemo --input_manifest /media/mesut/Depo1/works/NeMo/tools/asr_webapp/manifest_input.json --preds_output_folder out --beam_width 128 --beam_alpha 1 --beam_beta 0`
Error is something like that;
```
Reading Manifest /media/mesut/Depo1/works/NeMo/tools/asr_webapp/manifest_input.json ...: 1it [00:00, 10131.17it/s]
Transcribing: 0%| | 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
File "eval_beamsearch_ngram.py", line 362, in <module>
main()
File "eval_beamsearch_ngram.py", line 269, in main
all_logits = asr_model.transcribe(audio_file_paths, batch_size=args.acoustic_batch_size, logprobs=True)
File "/usr/local/lib/python3.8/dist-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/app/NeMo/nemo/collections/asr/models/ctc_models.py", line 183, in transcribe
logits, logits_len, greedy_predictions = self.forward(
File "/app/NeMo/nemo/core/classes/common.py", line 1084, in __call__
outputs = wrapped(*args, **kwargs)
File "/app/NeMo/nemo/collections/asr/models/ctc_models.py", line 536, in forward
processed_signal, processed_signal_length = self.preprocessor(
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
return forward_call(*input, **kwargs)
File "/app/NeMo/nemo/core/classes/common.py", line 1084, in __call__
outputs = wrapped(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/app/NeMo/nemo/collections/asr/modules/audio_preprocessing.py", line 85, in forward
processed_signal, processed_length = self.get_features(input_signal, length)
File "/app/NeMo/nemo/collections/asr/modules/audio_preprocessing.py", line 268, in get_features
return self.featurizer(input_signal, length)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
return forward_call(*input, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/app/NeMo/nemo/collections/asr/parts/preprocessing/features.py", line 350, in forward
x = self.stft(x)
File "/app/NeMo/nemo/collections/asr/parts/preprocessing/features.py", line 242, in <lambda>
self.stft = lambda x: torch.stft(
File "/usr/local/lib/python3.8/dist-packages/torch/functional.py", line 632, in stft
return _VF.stft(input, n_fft, hop_length, win_length, window, # type: ignore[attr-defined]
RuntimeError: cuFFT error: CUFFT_INTERNAL_ERROR
```
Ubuntu 20.04
GPU: Gigabyte Windforce 4090
| {
"login": "mesut92",
"id": 8597737,
"node_id": "MDQ6VXNlcjg1OTc3Mzc=",
"avatar_url": "https://avatars.githubusercontent.com/u/8597737?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mesut92",
"html_url": "https://github.com/mesut92",
"followers_url": "https://api.github.com/users/mesut92/followers",
"following_url": "https://api.github.com/users/mesut92/following{/other_user}",
"gists_url": "https://api.github.com/users/mesut92/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mesut92/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mesut92/subscriptions",
"organizations_url": "https://api.github.com/users/mesut92/orgs",
"repos_url": "https://api.github.com/users/mesut92/repos",
"events_url": "https://api.github.com/users/mesut92/events{/privacy}",
"received_events_url": "https://api.github.com/users/mesut92/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5700/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5700/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5698 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5698/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5698/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5698/events | https://github.com/NVIDIA/NeMo/issues/5698 | 1,509,443,911 | I_kwDOC_bI7s5Z-ElH | 5,698 | ModuleNotFoundError: No module named 'nemo.utils.data_utils' | {
"login": "thani-ath-nain",
"id": 71865085,
"node_id": "MDQ6VXNlcjcxODY1MDg1",
"avatar_url": "https://avatars.githubusercontent.com/u/71865085?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thani-ath-nain",
"html_url": "https://github.com/thani-ath-nain",
"followers_url": "https://api.github.com/users/thani-ath-nain/followers",
"following_url": "https://api.github.com/users/thani-ath-nain/following{/other_user}",
"gists_url": "https://api.github.com/users/thani-ath-nain/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thani-ath-nain/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thani-ath-nain/subscriptions",
"organizations_url": "https://api.github.com/users/thani-ath-nain/orgs",
"repos_url": "https://api.github.com/users/thani-ath-nain/repos",
"events_url": "https://api.github.com/users/thani-ath-nain/events{/privacy}",
"received_events_url": "https://api.github.com/users/thani-ath-nain/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-12-23T15:02:25 | 2022-12-26T11:46:19 | 2022-12-26T11:46:19 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Whenever I try to run the file for tokenization I get the above error.
**Steps/Code to reproduce bug**
Run the command
```
python ./scripts/tokenizers/process_asr_text_tokenizer.py --manifest=../code/manifests/train_clean_5.json --data_root=tokenized --vocab_size=2048 tokenizer=bpe --log
```
**Expected behavior**
It should have tokenized the text manifest.
**Environment overview (please complete the following information)**
- Environment location: AWS
- Method of NeMo install: pip install nemo_toolkit['all']
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version Ubutnu 20
- PyTorch version 1.6
- Python version 3.8
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "thani-ath-nain",
"id": 71865085,
"node_id": "MDQ6VXNlcjcxODY1MDg1",
"avatar_url": "https://avatars.githubusercontent.com/u/71865085?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thani-ath-nain",
"html_url": "https://github.com/thani-ath-nain",
"followers_url": "https://api.github.com/users/thani-ath-nain/followers",
"following_url": "https://api.github.com/users/thani-ath-nain/following{/other_user}",
"gists_url": "https://api.github.com/users/thani-ath-nain/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thani-ath-nain/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thani-ath-nain/subscriptions",
"organizations_url": "https://api.github.com/users/thani-ath-nain/orgs",
"repos_url": "https://api.github.com/users/thani-ath-nain/repos",
"events_url": "https://api.github.com/users/thani-ath-nain/events{/privacy}",
"received_events_url": "https://api.github.com/users/thani-ath-nain/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5698/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5698/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5697 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5697/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5697/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5697/events | https://github.com/NVIDIA/NeMo/issues/5697 | 1,508,812,943 | I_kwDOC_bI7s5Z7qiP | 5,697 | asr报错 | {
"login": "maomao1025",
"id": 39375578,
"node_id": "MDQ6VXNlcjM5Mzc1NTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/39375578?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maomao1025",
"html_url": "https://github.com/maomao1025",
"followers_url": "https://api.github.com/users/maomao1025/followers",
"following_url": "https://api.github.com/users/maomao1025/following{/other_user}",
"gists_url": "https://api.github.com/users/maomao1025/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maomao1025/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maomao1025/subscriptions",
"organizations_url": "https://api.github.com/users/maomao1025/orgs",
"repos_url": "https://api.github.com/users/maomao1025/repos",
"events_url": "https://api.github.com/users/maomao1025/events{/privacy}",
"received_events_url": "https://api.github.com/users/maomao1025/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-12-23T02:59:38 | 2022-12-23T07:36:40 | 2022-12-23T07:36:40 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
调用stt_zh_citrinet_512模型进行音频转文字操作
**Steps/Code to reproduce bug**
asr_model = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name="stt_zh_citrinet_512")
mandarin_text=asr_model.transcribe(paths2audio_files=["./test.wav"])
print(mandarin_text)**
**Expected behavior**
输出音频文本内容
**Environment overview (please complete the following information)**
安装方式为pip，命令为pip install nemo_toolkit['all'] -i https://pypi.doubanio.com/simple/
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- torch1.10.0+cu113
- Python 3.8
**Additional context**
报错ValueError: Input signal length=2 is too small to resample from 44100->16000
| {
"login": "maomao1025",
"id": 39375578,
"node_id": "MDQ6VXNlcjM5Mzc1NTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/39375578?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maomao1025",
"html_url": "https://github.com/maomao1025",
"followers_url": "https://api.github.com/users/maomao1025/followers",
"following_url": "https://api.github.com/users/maomao1025/following{/other_user}",
"gists_url": "https://api.github.com/users/maomao1025/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maomao1025/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maomao1025/subscriptions",
"organizations_url": "https://api.github.com/users/maomao1025/orgs",
"repos_url": "https://api.github.com/users/maomao1025/repos",
"events_url": "https://api.github.com/users/maomao1025/events{/privacy}",
"received_events_url": "https://api.github.com/users/maomao1025/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5697/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5697/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5696 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5696/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5696/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5696/events | https://github.com/NVIDIA/NeMo/pull/5696 | 1,507,065,725 | PR_kwDOC_bI7s5F_3qi | 5,696 | temp disable speaker recognision CI test | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-22T00:07:50 | 2022-12-27T19:36:20 | 2022-12-24T00:14:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5696",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5696",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5696.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5696.patch",
"merged_at": "2022-12-24T00:14:14"
} | Signed-off-by: fayejf <[email protected]>
# What does this PR do ?
temporary disable speaker recognision CI test due to long duration (~20M)
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5696/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5696/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5695 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5695/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5695/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5695/events | https://github.com/NVIDIA/NeMo/issues/5695 | 1,507,020,017 | I_kwDOC_bI7s5Z00zx | 5,695 | Error in downloading the financial_phrase_bank dataset | {
"login": "farshadsm",
"id": 25828445,
"node_id": "MDQ6VXNlcjI1ODI4NDQ1",
"avatar_url": "https://avatars.githubusercontent.com/u/25828445?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/farshadsm",
"html_url": "https://github.com/farshadsm",
"followers_url": "https://api.github.com/users/farshadsm/followers",
"following_url": "https://api.github.com/users/farshadsm/following{/other_user}",
"gists_url": "https://api.github.com/users/farshadsm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/farshadsm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/farshadsm/subscriptions",
"organizations_url": "https://api.github.com/users/farshadsm/orgs",
"repos_url": "https://api.github.com/users/farshadsm/repos",
"events_url": "https://api.github.com/users/farshadsm/events{/privacy}",
"received_events_url": "https://api.github.com/users/farshadsm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-12-21T23:06:22 | 2023-02-05T02:01:56 | 2023-02-05T02:01:56 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I was trying to run "tutorials/nlp/Multitask_Prompt_and_PTuning.ipynb". But I got the following error for downloading the "financial_phrase_bank" dataset.
https://www.researchgate.net/profile/Pekka_Malo/publication/251231364_FinancialPhraseBank-v1.0/data/0c96051eee4fb1d56e000000/FinancialPhraseBank-v1.0.zip
Resolving [www.researchgate.net](http://www.researchgate.net/) ([www.researchgate.net](http://www.researchgate.net/))... 104.17.32.105, 104.17.33.105, 2606:4700::6811:2169, ...
Connecting to [www.researchgate.net](http://www.researchgate.net/) ([www.researchgate.net)|104.17.32.105|:443](http://www.researchgate.net%29%7C104.17.32.105%7C:443/)... connected.
HTTP request sent, awaiting response... 403 Forbidden
2022-12-21 22:47:57 ERROR 403: Forbidden.
**Steps/Code to reproduce bug**
I tried to download the dataset in both my local machine and Google Colab. But both cases failed.
**Expected behavior**
I expected the dataset to be downloaded without any error.
**Environment overview (please complete the following information)**
- Environment location: Colab, MacOS
- Method of NeMo install: I uploaded the notebook on Colab
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version
- PyTorch version
- Python version
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5695/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5695/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5694 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5694/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5694/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5694/events | https://github.com/NVIDIA/NeMo/pull/5694 | 1,507,007,832 | PR_kwDOC_bI7s5F_q5i | 5,694 | Update to pytorch 22.12 container | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-21T22:52:18 | 2023-01-04T18:31:35 | 2023-01-04T18:31:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5694",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5694",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5694.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5694.patch",
"merged_at": "2023-01-04T18:31:19"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5694/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5694/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5693 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5693/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5693/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5693/events | https://github.com/NVIDIA/NeMo/pull/5693 | 1,506,894,246 | PR_kwDOC_bI7s5F_Sns | 5,693 | [ASR] Mask-based dereverb algorithm | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-21T20:49:07 | 2023-01-22T08:15:55 | 2023-01-22T08:15:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5693",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5693",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5693.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5693.patch",
"merged_at": "2023-01-22T08:15:55"
} | # What does this PR do ?
This PR adds a multichannel input, multichannel output mask-based dereverberation algorithm based on weighted prediction error (WPE).
**Collection**: ASR
# Changelog
- New: Dereverberation algorithm implemented in `MaskBasedDereverbWPE`
- Added unit tests for handling of convolution matrices
- Input length is now optional for `AudioToSpectrogram`
- Updated relevant unit tests
# Usage
An example script with a test vector is attached to this PR.
## Example script
[pr_5693_example_script.zip](https://github.com/NVIDIA/NeMo/files/10281448/pr_5693_example_script.zip)
## Code example
The algorithm can be used as follows:
```python
import soundfile as sf
import torch
from nemo.collections.asr.modules.audio_modules import MaskBasedDereverbWPE
from nemo.collections.asr.modules.audio_preprocessing import AudioToSpectrogram, SpectrogramToAudio
from nemo.collections.asr.parts.preprocessing.segment import AudioSegment
# Parameters
fft_length = 512
hop_length = fft_length // 2
filter_length = 8
delay = 2
num_iterations = 3
# Load audio
sample_rate = 16000
x = AudioSegment.from_file(filename, target_sr=sample_rate).samples.T
# Add batch dimension, shape (B, C, T)
x = x[None, ...]
# Prepare analysis and synthesis transforms
stft = AudioToSpectrogram(fft_length=fft_length, hop_length=hop_length)
istft = SpectrogramToAudio(fft_length=fft_length, hop_length=hop_length)
# Analysis transform
X, _ = stft(input=torch.tensor(x))
# Prepare dereverb instance
dereverb = MaskBasedDereverbWPE(filter_length=filter_length, prediction_delay=delay, num_iterations=num_iterations)
# Processing
Y, _ = dereverb(input=X, mask=None)
# Synthesis transform: shape (B, C, T)
y, _ = istft(input=Y)
# Save audio
sf.write('output/dereverb_output.wav', y.cpu().numpy()[0, ...].T, sample_rate)
```
## Signal example
Below we show spectrograms of the input signal and the processed output signal. Signals are available in the attached example. Only the first channel is shown.
Input signal | Output signal
:-------------------------:|:-------------------------:
 | 
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jbalam-nv",
"id": 4916480,
"node_id": "MDQ6VXNlcjQ5MTY0ODA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4916480?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbalam-nv",
"html_url": "https://github.com/jbalam-nv",
"followers_url": "https://api.github.com/users/jbalam-nv/followers",
"following_url": "https://api.github.com/users/jbalam-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/jbalam-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbalam-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbalam-nv/subscriptions",
"organizations_url": "https://api.github.com/users/jbalam-nv/orgs",
"repos_url": "https://api.github.com/users/jbalam-nv/repos",
"events_url": "https://api.github.com/users/jbalam-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbalam-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5693/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5693/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5692 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5692/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5692/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5692/events | https://github.com/NVIDIA/NeMo/pull/5692 | 1,506,861,835 | PR_kwDOC_bI7s5F_LrB | 5,692 | Fix for incorrect computation of batched alignment in transducers | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-21T20:14:20 | 2023-01-06T19:52:08 | 2023-01-06T19:52:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5692",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5692",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5692.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5692.patch",
"merged_at": "2023-01-06T19:52:07"
} | # What does this PR do ?
The original code had a bug because of which whenever at least one batch element predicted non-blank symbol, all blank elements would duplicate the last prediction in their `.alignments` variable.
Additionally, I've unified `_greedy_decode_blank_as_pad` and `_greedy_decode_masked` into a single function with an if check. The two methods had 99% of the same code except 5 lines or so, so imo it does not make sense to have them as fully separate code paths. Please let me know if for some reason we don't want to have this change.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5692/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5692/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5691 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5691/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5691/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5691/events | https://github.com/NVIDIA/NeMo/pull/5691 | 1,506,775,166 | PR_kwDOC_bI7s5F-4xz | 5,691 | Fix missing torchelastic fixes for PTL 1.8 | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-21T18:59:57 | 2022-12-21T23:19:18 | 2022-12-21T23:19:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5691",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5691",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5691.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5691.patch",
"merged_at": "2022-12-21T23:19:15"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Fixes missing torchelastic import
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5691/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5691/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5690 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5690/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5690/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5690/events | https://github.com/NVIDIA/NeMo/pull/5690 | 1,506,685,790 | PR_kwDOC_bI7s5F-lV7 | 5,690 | Remove cell output from tutorial | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-21T17:37:35 | 2022-12-21T23:04:26 | 2022-12-21T23:04:23 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5690",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5690",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5690.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5690.patch",
"merged_at": "2022-12-21T23:04:23"
} | Signed-off-by: ericharper <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5690/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5690/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5689 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5689/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5689/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5689/events | https://github.com/NVIDIA/NeMo/pull/5689 | 1,506,683,712 | PR_kwDOC_bI7s5F-k3Q | 5,689 | Remove cell output from tutorial | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-12-21T17:36:32 | 2022-12-21T17:37:04 | 2022-12-21T17:37:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5689",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5689",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5689.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5689.patch",
"merged_at": "2022-12-21T17:37:00"
} | Signed-off-by: ericharper <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5689/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5689/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5688 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5688/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5688/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5688/events | https://github.com/NVIDIA/NeMo/issues/5688 | 1,506,652,752 | I_kwDOC_bI7s5ZzbJQ | 5,688 | Trainer is required in EncDecRNNTModel | {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-12-21T17:16:45 | 2022-12-22T08:19:09 | 2022-12-21T17:53:55 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
In the constructor of the class `EncDecRNNTModel`, the PTL trainer is a kwarg with default value `null`. However, in the `self.training_step` method, the method `self.log_dict` is called (line 725 in file `collections/asr/models/rnnt_models.py`), which raises an error if no PTL trainer object is present in the `EncDecRNNTModel` object.
**Expected behavior**
If no PTL trainer is passed to the `EncDecRNNTModel`, it should not call `self.log` and just return the logs. The fix is just an if statement before the `self.log_dict`
| {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5688/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5688/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5687 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5687/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5687/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5687/events | https://github.com/NVIDIA/NeMo/issues/5687 | 1,505,874,693 | I_kwDOC_bI7s5ZwdMF | 5,687 | Using nemo LM in other nemo training | {
"login": "bew-pbwt",
"id": 78535791,
"node_id": "MDQ6VXNlcjc4NTM1Nzkx",
"avatar_url": "https://avatars.githubusercontent.com/u/78535791?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bew-pbwt",
"html_url": "https://github.com/bew-pbwt",
"followers_url": "https://api.github.com/users/bew-pbwt/followers",
"following_url": "https://api.github.com/users/bew-pbwt/following{/other_user}",
"gists_url": "https://api.github.com/users/bew-pbwt/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bew-pbwt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bew-pbwt/subscriptions",
"organizations_url": "https://api.github.com/users/bew-pbwt/orgs",
"repos_url": "https://api.github.com/users/bew-pbwt/repos",
"events_url": "https://api.github.com/users/bew-pbwt/events{/privacy}",
"received_events_url": "https://api.github.com/users/bew-pbwt/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-12-21T08:07:19 | 2023-02-13T02:00:50 | 2023-02-13T02:00:50 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I want to use our own training nemo LM in other nemo training and I found only this reference [https://github.com/NVIDIA/NeMo/blob/4cd9b3449cbfedc671348fbabbe8e3a55fbd659d/examples/nlp/text_classification/conf/ptune_text_classification_config.yaml](url) that have nemo_path in language model config
so I follow that(training text classification) but it doesn't work, it has to have model.tokenizer.tokenizer_name
> [NeMo I 2022-12-20 16:02:14 exp_manager:563] TensorboardLogger has been set up
> Traceback (most recent call last):
> File "/workspace/data/bew/NeMo/examples/nlp/text_classification/text_classification_with_bert.py", line 117, in main
> model = TextClassificationModel(cfg.model, trainer=trainer)
> File "/opt/conda/lib/python3.8/site-packages/nemo/collections/nlp/models/text_classification/text_classification_model.py", line 54, in __init__
> self.setup_tokenizer(cfg.tokenizer)
> File "/opt/conda/lib/python3.8/site-packages/nemo/collections/nlp/models/nlp_model.py", line 112, in setup_tokenizer
> tokenizer_name=cfg.tokenizer_name,
> omegaconf.errors.ConfigAttributeError: Key 'tokenizer_name' is not in struct
> full_key: model.tokenizer.tokenizer_name
> reference_type=Any
> object_type=dict
>
> Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
If I mention model.tokenizer.tokenizer_name and model.language_model.pretrained_model_name then put model.language_model.nemo_file(path to our custom nemo model), the training look ok but it seems to use the model from huggingface.
Is there a way to using custom LM model? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5687/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5687/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5686 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5686/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5686/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5686/events | https://github.com/NVIDIA/NeMo/issues/5686 | 1,505,674,642 | I_kwDOC_bI7s5ZvsWS | 5,686 | Is it possible to use Hugging face XLSR pretrained model with Nemo? | {
"login": "manjuke",
"id": 6142443,
"node_id": "MDQ6VXNlcjYxNDI0NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6142443?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/manjuke",
"html_url": "https://github.com/manjuke",
"followers_url": "https://api.github.com/users/manjuke/followers",
"following_url": "https://api.github.com/users/manjuke/following{/other_user}",
"gists_url": "https://api.github.com/users/manjuke/gists{/gist_id}",
"starred_url": "https://api.github.com/users/manjuke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/manjuke/subscriptions",
"organizations_url": "https://api.github.com/users/manjuke/orgs",
"repos_url": "https://api.github.com/users/manjuke/repos",
"events_url": "https://api.github.com/users/manjuke/events{/privacy}",
"received_events_url": "https://api.github.com/users/manjuke/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "jbalam-nv",
"id": 4916480,
"node_id": "MDQ6VXNlcjQ5MTY0ODA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4916480?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbalam-nv",
"html_url": "https://github.com/jbalam-nv",
"followers_url": "https://api.github.com/users/jbalam-nv/followers",
"following_url": "https://api.github.com/users/jbalam-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/jbalam-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbalam-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbalam-nv/subscriptions",
"organizations_url": "https://api.github.com/users/jbalam-nv/orgs",
"repos_url": "https://api.github.com/users/jbalam-nv/repos",
"events_url": "https://api.github.com/users/jbalam-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbalam-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-12-21T04:01:11 | 2022-12-30T18:41:39 | 2022-12-30T18:41:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi
Is it possible to use Hugging face XLSR pretrained model with Nemo? Thanks. Pls suggest @titu1994 @jbalam-nv | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5686/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5686/timeline | null | completed | false |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.