Datasets:

---

renwei2024

/

nemo-github-issues

like 0

[]

[]

[]

[]

[]

[ "can you please sign your commit? See DCO's bot output on how to sign already committed commits: https://github.com/NVIDIA/NeMo/pull/1575/checks?check_run_id=1569064051 \r\n\r\nThanks!", "> can you please sign your commit? See DCO's bot output on how to sign already committed commits: https://github.com/NVIDIA/NeMo/pull/1575/checks?check_run_id=1569064051\r\n> \r\n> Thanks!\r\n\r\nSorry miss that I use -S instead of -s, updated.\r\n\r\nThanks" ]

[]

[]

[ "This pull request **introduces 10 alerts** when merging d4b3ad320d1a01ecc0ae91e12594656ca38af6a6 into c375f69fad955bfbafef06273032101c9150dc8f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2666dd4ae7d79fcb4177458fcac3a5f286bcb953)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception", "This pull request **introduces 10 alerts** when merging 1b6b9599214e2cf4c6c7f59e706a9b2177b404b1 into dd35d6849f4dc9facf138bd4e380237d6e5fcbea - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-31211c6ee22bb4dd230812dfafe6b73e86e8a5a4)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception", "This pull request **introduces 10 alerts** when merging 8ed6b966a843286c715484b0fadc266253f2f272 into 297a8bdbb0370a51cb74a41288025befd9cd2392 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-28f23fe242a6e6c295aa5b65ca722e8e4e6ec390)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception", "This pull request **introduces 10 alerts** when merging 804ffd2ba7427c2f2c15b0e0d63253d20eeb34cc into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-d43d2e702b3b1b316a944a6b95b2e41b86861f38)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception", "This pull request **introduces 10 alerts** when merging 0c81769e3807cbd236d863e9c74534ec334c7191 into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-24e461c7e5d33c6c629130b108b71cb34a7d52d9)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception", "This pull request **introduces 10 alerts** and **fixes 1** when merging bda69152eb14b081dfb2c1c3c2bfdc9003eef285 into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f80520951bbce225cf696b337872ba929f4ce72a)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 10 alerts** and **fixes 1** when merging f4e1fba2f7a414dda7c6b6e627ef71a67267bc67 into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-cc24a880d0bc18746324bc85607f1b13e5f40b2b)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 10 alerts** and **fixes 1** when merging b3217a0acb503ac1a414ba33f24cb5628f357c0d into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-4c84a2ca38872c43f0a453ab42498e6a5ec3cd4c)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 10 alerts** and **fixes 1** when merging 767ff22803350ec3633d22b09fef2253d4c10a15 into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a1bc4d916b0fc52de273676c962e0057e0e64a4e)\n\n**new alerts:**\n\n* 7 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 8 alerts** and **fixes 1** when merging 0ef59f1e573ca8290f4d60e57825bdc8c44a30fb into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c8fd1928d36e361d5950cf4d49bdddcc4976c331)\n\n**new alerts:**\n\n* 5 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 8 alerts** and **fixes 1** when merging 7cb30843427fdf77a55a0cdd67cbbde3c067c850 into 51092ef7a9810ab096148cdf2d44ddfe6c72d028 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c227bb042853f7041d33a2752b9adc71ef82beef)\n\n**new alerts:**\n\n* 5 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 8 alerts** and **fixes 1** when merging 36c4a8fcca4e6e74360886fd78818055114a15ec into c6b90b3dd1321b3e95df8f91b89f55326d52a81c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f769fb3a9cb4ef93f52f716fea30b10c8fa00bd6)\n\n**new alerts:**\n\n* 5 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "let's merge https://github.com/NVIDIA/NeMo/pull/1611 here first, then merge this one", "This pull request **introduces 16 alerts** and **fixes 1** when merging 2778755f9bb8d1c248ddf5c7913784fe55b195d2 into 4f46bd84d162da80a310c69f72980de935c1e99a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-9a882882a285cc8870eb31c5f2630b2fb1d422b4)\n\n**new alerts:**\n\n* 13 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 16 alerts** and **fixes 1** when merging c773aeefc06142647ad5b06a3a577f82882ac11d into 84f69c582a76b66b208dc40ef18499b3448f2142 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6f8c3297437c8cc20ccef04c868edd0db394e7ec)\n\n**new alerts:**\n\n* 13 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 16 alerts** and **fixes 1** when merging bc9681ceb24c03a24257e773784b099937b0b6b2 into bc5f03459c7273b71c50af7c2378d5e950b408c4 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-29a5527b6e71acf832183c3461fe981360bb5f29)\n\n**new alerts:**\n\n* 13 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 16 alerts** and **fixes 1** when merging 958c7ec58c925f5549763718773741bb3c7cfab5 into 27fc97e918e3156999bb321b8fec6fa3f5fef346 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-39dfd6bf270f4bfc035037f5b69a510cd7f3e804)\n\n**new alerts:**\n\n* 13 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging df966417ce426fb6c1e96226fde6c3554ac7238f into 27fc97e918e3156999bb321b8fec6fa3f5fef346 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-a55c720804214f0dad7e7a6e5e6151b15d78c2a3)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging 089358e0794cb1562c84d3232d18828d3039f0a8 into 45f60f03e5d15a4b6e7db145b5d731d73f3a891d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6bc20655c75fd1a2461a3ccd273e1f1af631439f)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging c43e57a695bf137b7ae109f7799ace393ebf5958 into 516eb5f863331ac83407fb16d09ce022dfbcd2f0 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-9befbb2ab3fa404f00a493f6df942a0148cb5cd6)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging db5832edab92c0638c0bad7c005f9dd2d6cf94a3 into 516eb5f863331ac83407fb16d09ce022dfbcd2f0 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-68ac5942698e0b9ef97e48c3297484ba614f12d1)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging 1afb6400a7be7dfbadc8cb471c896c07e0e43313 into 516eb5f863331ac83407fb16d09ce022dfbcd2f0 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2f15413b047be2b00c2b3f53c339803d0ed22530)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging eaa491c0d090f339344afbf58ee2a2907b1bc216 into 516eb5f863331ac83407fb16d09ce022dfbcd2f0 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-92914a71e3cae2d90dce831c1e96aeb7a23d279d)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging d09eca2de6b76e5a9d5f309c6f00bfccd0a2ddd5 into eb927fe6aa69f8d73705dcb785a2afb95e4c279d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-e5006959d73034565c44b53df600990bfab067ab)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging 50d87263a82ce1d78476afe45ff3146e0664455e into eb927fe6aa69f8d73705dcb785a2afb95e4c279d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c33a59941ed219dfe825175476e6d5791f3aefa9)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging a8ed739a068de35f7ebebda6b44d9a0cedc9b632 into db60a786c71767478a49dfcad772718f9d4878d2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-7806153884d50edc4d82d21214d0f0a8cc349173)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging 45acccdef881159b534202a407baa3b0302d4d5a into db60a786c71767478a49dfcad772718f9d4878d2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b264b0b473fee1a61bfdc9aa0c3fbe6fc530d1cd)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging f8d0bef40cabf63fff7200515640177ad7b796aa into db60a786c71767478a49dfcad772718f9d4878d2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6f99d946229c3421544cd055e581ec48c3d0db21)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging 57fe8e467e4ca50910d452fa546aff30e519ad1c into db60a786c71767478a49dfcad772718f9d4878d2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c7eb7e14b5baf3b9fb3c418d3df78d58f134e727)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import", "This pull request **introduces 17 alerts** and **fixes 1** when merging ccfebd7c4afe09be3288389e116b509396e945a2 into db60a786c71767478a49dfcad772718f9d4878d2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-d629a5b3be3fdfa9ad41568c7d4e1c2d29b03fb4)\n\n**new alerts:**\n\n* 14 for Unused import\n* 3 for NotImplemented is not an Exception\n\n**fixed alerts:**\n\n* 1 for Unused import" ]

[]

[]

[]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "Could you please try with `BRANCH='main'` in the first cell of the notebook.", "@ekmb Tried `BRANCH='main'` but still getting the same error", "I forgot to restart the kernel when trying `BRANCH='main'`. So I restarted the kernel and tried `from nemo.collections import nlp as nemo_nlp` and the original `ModuleNotFoundError: No module named 'transformers.tokenization_bert'` has gone away but there is a different `ModuleNotFoundError: No module named 'webdataset'`: \r\n\r\n", "Could you please restart the kernel and run this one:\r\n\r\nBRANCH = 'main'\r\n!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[all]\r\n\r\n\r\n", "Tried it and it seems like it's fixed now. Not getting any more errors. There are two APEX warnings though:\r\n\r\n\r\n\r\n", "@kshitizgupta21 the warnings are OK (Colab doesn't have APEX). " ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "> can you please replace all references to 1.0.0b2 with 1.0.0b3 in README.md ?\r\n\r\n@okuchaiev 1.0.0b3 won't work, the notebooks were not updated from `1.0.0b2` to `1.0.0b3` when 1.0.0b3 was released. for example, this [one with `/blob/v1.0.0b3/`](https://colab.research.google.com/github/NVIDIA/NeMo/blob/v1.0.0b3/tutorials/nlp/Joint_Intent_and_Slot_Classification.ipynb) will install `BRANCH=1.0.0b2`", "can you please put paths like https://colab.research.google.com/github/NVIDIA/NeMo/blob/r1.0.0b3/tutorials/nlp/Joint_Intent_and_Slot_Classification.ipynb ?\r\n\r\nand we'll update notebooks in r1.0.0b3 to install from r1.0.0b3", "> can you please put paths like https://colab.research.google.com/github/NVIDIA/NeMo/blob/r1.0.0b3/tutorials/nlp/Joint_Intent_and_Slot_Classification.ipynb ?\r\n> \r\n> and we'll update notebooks in r1.0.0b3 to install from r1.0.0b3\r\n\r\nBut what about bug fixes, like this one https://github.com/NVIDIA/NeMo/pull/1558 ?" ]

[]

[]

[]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "I am also getting this error", "It looks like the latest version of transformers (4.0.1) is being installed. I reverted to 3.5, and the code works.\r\nBefore importing nemo.collections, run the following and it should work:\r\n```\r\n!pip uninstall transformers\r\n!pip install transformers==3.5\r\n```\r\n", "Thanks it worked for that cell, however [here](https://colab.research.google.com/github/NVIDIA/NeMo/blob/v1.0.0b2/tutorials/nlp/Text_Classification_Sentiment_Analysis.ipynb#scrollTo=NgsGLydWo-6-) I am getting another error, traceback is:\r\n```\r\nUsing bos_token, but it is not set yet.\r\nUsing eos_token, but it is not set yet.\r\n---------------------------------------------------------------------------\r\nFileNotFoundError Traceback (most recent call last)\r\n<ipython-input-31-543503bf2763> in <module>()\r\n----> 1 model = nemo_nlp.models.TextClassificationModel(cfg=config.model, trainer=trainer)\r\n\r\n4 frames\r\n/usr/local/lib/python3.6/dist-packages/nemo/collections/nlp/models/text_classification/text_classification_model.py in __init__(self, cfg, trainer)\r\n 58 \r\n 59 # init superclass\r\n---> 60 super().__init__(cfg=cfg, trainer=trainer)\r\n 61 \r\n 62 self.bert_model = get_lm_model(\r\n\r\n/usr/local/lib/python3.6/dist-packages/nemo/collections/nlp/models/nlp_model.py in __init__(self, cfg, trainer)\r\n 35 \r\n 36 def __init__(self, cfg: DictConfig, trainer: Trainer = None):\r\n---> 37 super().__init__(cfg, trainer)\r\n 38 self.bert_model = None # Pretrained BERT encoder\r\n 39 self.set_world_size(trainer)\r\n\r\n/usr/local/lib/python3.6/dist-packages/nemo/core/classes/modelPT.py in __init__(self, cfg, trainer)\r\n 97 if self._cfg is not None and not self.__is_model_being_restored():\r\n 98 if 'train_ds' in self._cfg and self._cfg.train_ds is not None:\r\n---> 99 self.setup_training_data(self._cfg.train_ds)\r\n 100 \r\n 101 if 'validation_ds' in self._cfg and self._cfg.validation_ds is not None:\r\n\r\n/usr/local/lib/python3.6/dist-packages/nemo/collections/nlp/models/text_classification/text_classification_model.py in setup_training_data(self, train_data_config)\r\n 206 self._test_dl = None\r\n 207 return\r\n--> 208 self._train_dl = self._setup_dataloader_from_config(cfg=train_data_config)\r\n 209 \r\n 210 def setup_validation_data(self, val_data_config: Optional[DictConfig]):\r\n\r\n/usr/local/lib/python3.6/dist-packages/nemo/collections/nlp/models/text_classification/text_classification_model.py in _setup_dataloader_from_config(self, cfg)\r\n 235 The label of the example is separated with TAB at the end of each line. \\n\\\r\n 236 Each line of the files should follow the format: \\n\\\r\n--> 237 [WORD][SPACE][WORD][SPACE][WORD][...][TAB][LABEL]'\r\n 238 )\r\n 239 \r\n\r\nFileNotFoundError: DATA_DIR/SST-2/train_nemo_format.tsv not found! The data should be be stored in TAB-separated files \r\n \"validation_ds.file_path\" and \"train_ds.file_path\" for train and evaluation respectively. \r\n Each line of the files contains text sequences, where words are separated with spaces. \r\n The label of the example is separated with TAB at the end of each line. \r\n Each line of the files should follow the format: \r\n [WORD][SPACE][WORD][SPACE][WORD][...][TAB][LABEL]\r\n```", "Did you create DATA_DIR/SST-2/train_nemo_format.tsv?", "I think we'd better use the new version to solve the problem , not to always use the older version 3.5 tranformers to solve it.", "try ”from transformers.models.bert.tokenization_bert import BasicTokenizer“ in new version.\r\n" ]

[]

[]

[ "@blisc Could you review the TTS side changes to `stft` and `torch.ifft`?", "trim_silence default in the model.transcribe method is still True!\r\nThis issue can be seen here:\r\ncollections/asr/models/ctc_models.py: _setup_transcribe_dataloader" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[]

[]

[]

[]

[]

[ { "login": "stasbel", "id": 12044462, "node_id": "MDQ6VXNlcjEyMDQ0NDYy", "avatar_url": "https://avatars.githubusercontent.com/u/12044462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stasbel", "html_url": "https://github.com/stasbel", "followers_url": "https://api.github.com/users/stasbel/followers", "following_url": "https://api.github.com/users/stasbel/following{/other_user}", "gists_url": "https://api.github.com/users/stasbel/gists{/gist_id}", "starred_url": "https://api.github.com/users/stasbel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stasbel/subscriptions", "organizations_url": "https://api.github.com/users/stasbel/orgs", "repos_url": "https://api.github.com/users/stasbel/repos", "events_url": "https://api.github.com/users/stasbel/events{/privacy}", "received_events_url": "https://api.github.com/users/stasbel/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "ping @stasbel ", "This pull request **introduces 2 alerts** when merging bb66ad0cb949eab426b3fd510525e4edcf0fdace into fc4017a08db4cf2aaad2288dd158e9c287f7107a - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-01fe481edaf7d6ac977150b56a2b758a568a4873)\n\n**new alerts:**\n\n* 1 for Unused import\n* 1 for Wrong name for an argument in a class instantiation", "got some arch mismatches with my pretrained models\r\ngoing to retrain in following days", "This pull request **introduces 2 alerts** when merging bb66ad0cb949eab426b3fd510525e4edcf0fdace into d7ad10435e97024c7c9fdbdd4228e0011dc9e432 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-40377bb52a1892ca08cd4ac249299434aa2636b2)\n\n**new alerts:**\n\n* 1 for Unused import\n* 1 for Wrong name for an argument in a class instantiation", "This pull request **introduces 2 alerts** when merging bb66ad0cb949eab426b3fd510525e4edcf0fdace into db5a787f460d67f0cd89b400cf81826fa2cc9ed6 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6a685435f18b4d1006d383dafd209b308356040a)\n\n**new alerts:**\n\n* 1 for Unused import\n* 1 for Wrong name for an argument in a class instantiation", "This is not going to RC1. Code freeze was far too long ago", "Please top resolving my comments by yourself" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "Hey @rbracco, thanks for pointing this out! I submitted a PR to patch this bug.", "Thank you for all that you do for the repo! " ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "Do you mean v1.0.0b2? I haven't seen a b3 version yet, but there is a branch called r1.0.0b3.", "Well, I assumed since there is [v1.0.0b3](https://github.com/NVIDIA/NeMo/releases/tag/v1.0.0b3) release, then is should be docker image for that version.", "Sorry, I missed the 1.0.0b3 release, you are correct! In the [v1.0.0b3 README](https://github.com/NVIDIA/NeMo/tree/v1.0.0b3) there appear to be updated instructions but it appears your command is correct so the docker container is indeed missing. I was unable to retrieve it as well. \r\n\r\n\r\n", "Try pulling `nvcr.io/nvidia/nemo:1.0.0b3`, it should be live now." ]

[]

[]

[]

[]

[]

[ "This pull request **fixes 9 alerts** when merging 4f9ad400d51c3fe596d79169394c70ad936cb80b into d01b7bbc3fdb1bbf14789f71b8f368cf0aa8f86b - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-80363198ef854198c67fd4639ab1230057dd89b0)\n\n**fixed alerts:**\n\n* 9 for Unused import", "This pull request **fixes 9 alerts** when merging 4bcae26d43c55ea4ee017c78054b68f554e13264 into 9da1d27ddd7f1d5d9b6cd75f7308787976680dd8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-baeae19bf39b2e47e8b566507936e07fac2cc74d)\n\n**fixed alerts:**\n\n* 9 for Unused import", "This pull request **fixes 9 alerts** when merging 3965be07e3101dea7d42ff0b27a6e9569ce54fe7 into 1c24a5d35a9680b7436f505a8e69dc8f8373f3c2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-7a19d7bc10ec9b44f6aa44d402b8649440267c3c)\n\n**fixed alerts:**\n\n* 9 for Unused import" ]

[]

[]

[]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[ { "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "Thanks for catching this bug. It should be fixed now" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[ { "login": "fayejf", "id": 36722593, "node_id": "MDQ6VXNlcjM2NzIyNTkz", "avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fayejf", "html_url": "https://github.com/fayejf", "followers_url": "https://api.github.com/users/fayejf/followers", "following_url": "https://api.github.com/users/fayejf/following{/other_user}", "gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}", "starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fayejf/subscriptions", "organizations_url": "https://api.github.com/users/fayejf/orgs", "repos_url": "https://api.github.com/users/fayejf/repos", "events_url": "https://api.github.com/users/fayejf/events{/privacy}", "received_events_url": "https://api.github.com/users/fayejf/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "Hi @diego-fustes Thanks for reporting this. \r\nYou don't need to include the parameter batch_size in the dict passed. [It's been set here.](https://github.com/NVIDIA/NeMo/blob/9da1d27ddd7f1d5d9b6cd75f7308787976680dd8/nemo/collections/asr/models/classification_models.py#L167) \r\nThere isn't a vad_infer.py in v1.0.0b2. Could you please try main branch and let me know if you still have this issue and share a demo manifests if possible? Thanks! ", "Hi @fayejf ,\r\n\r\nyou are right, I was running the script from the main branch, but my installed NeMo version was v1.0.0b2. Updating to the main branch fixed the issue. Many thanks!", "Thanks for letting me know :)" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[ { "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "@avikpal00 thank you for reporting the issue. PR #1558 should fix it, no need to change the transformers version.", "@ekmb I am still getting this error for the tutorial notebook [Token_Classification-BioMegatron.ipynb](https://colab.research.google.com/github/NVIDIA/NeMo/blob/r1.0.0b3/tutorials/nlp/Token_Classification-BioMegatron.ipynb) when I try to use \"biomegatron-bert-345m-cased\".\r\n\r\n<img width=\"1086\" alt=\"Screen Shot 2021-01-05 at 7 10 01 PM\" src=\"https://user-images.githubusercontent.com/7240751/103713149-9f7fd180-4f89-11eb-9ec5-b4170ab1773a.png\">\r\n" ]

[]

[ { "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "Can you share your training command? As well as the python file that you're using?", "Sorry, It is my fault. I found that I was not pass parameter correctly to trainer, so it use default configuration. And solved this problem. I saw the example in \"speech_to_text.py\" and found I should pass parameters separately not a config dictionary)\r\n\r\npl = trainer(configDict(params['trainer'])) ## original (wrong way)\r\n\r\npl = trainer(gpus=params['trainer']['gpus'], amp_level=params['trainer']['amp_level'], ...) ## correct way\r\n\r\n Thank you :)", "Does the default `trainer = pl.Trainer(**cfg.trainer)` not work for you? What happens if you do `pl = trainer(**params['trainer'])`?\r\n\r\nClosing for now as well since it seems to be resolved.", "Yes, I test it and the two way you mentioned does work if using hydra decorator on function. Because i need to do some pre-processing for script before training, I remove the decorator and need to pass all parameter separately. \r\n\r\nThanks :)" ]

[]

[]

[ "P.S.: I do not want to use docker since I have to implement modified training and inference into an app running locally on the Xavier...\r\n", "\"pip install nemo_toolkit[all]\" will install an OLD version without PTL (0.11).\r\n\r\nTry: \"pip install nemo_toolkit[all]=1.0.0b3\"\r\n\r\nAt the moment we do not do testing on Jetson.\r\nAlso, from the error description above it is hard to see why segfault happened.\r\n\r\nI guess, it's ok to see few tests fail on Jetson - for example, why would you do onnx export on Jetson.\r\nIf you only need ASR, try installing \"pip install nemo_toolkit[asr]==1.0.0b3\" \r\n\r\n", "1.0.0b3 installed flawlessly without error.\r\nAnyhow calling \"from nemo.collections.asr.models import EncDecCTCModel\" still gives \"segmentation fault (core dumped)\"", "This seg fault seems to be related to a pytorch dependency (detectron2). I eventually found that using torch 1.6.0 helped resolve the issue:\r\n```\r\npip install torch==1.6.0 torchvision==0.7.0\r\n```", "deinstalled torch and torchvision libraries and installed the 1.6.0. and 0.7.0 from nvidia prebuilt wheels.\r\n\r\n....sorry still exactly the same behavior.\r\n\r\npip3 list shows following python libraries installed - do you recognize any other incompatibilities?\r\n\r\nPackage Version\r\n----------------------------- -------------------\r\nabsl-py 0.10.0\r\nalabaster 0.7.12\r\nantlr4-python3-runtime 4.8\r\napex 0.1\r\nappdirs 1.4.4\r\napturl 0.5.2\r\nargon2-cffi 20.1.0\r\nasn1crypto 0.24.0\r\nattrdict 2.0.1\r\nattrs 20.1.0\r\naudioread 2.1.8\r\nBabel 2.8.0\r\nbackcall 0.2.0\r\nbeautifulsoup4 4.6.0\r\nblack 19.10b0\r\nbleach 3.1.5\r\nblinker 1.4\r\nboto3 1.14.54\r\nbotocore 1.17.54\r\nbraceexpand 0.1.5\r\nBrlapi 0.6.6\r\ncachetools 4.1.1\r\ncertifi 2020.6.20\r\ncffi 1.14.2\r\nchardet 3.0.4\r\nclick 7.1.2\r\nconfigparser 5.0.1\r\ncryptography 2.1.4\r\ncupshelpers 1.0\r\ncycler 0.10.0\r\nCython 0.29.21\r\ndataclasses 0.7\r\ndecorator 4.1.2\r\ndefer 1.0.6\r\ndefusedxml 0.6.0\r\nDistance 0.1.3\r\ndistro-info 0.18ubuntu0.18.04.1\r\ndocker-pycreds 0.4.0\r\ndocopt 0.6.2\r\ndocutils 0.15\r\neditdistance 0.5.3\r\nentrypoints 0.3\r\nfeedparser 5.2.1\r\nfilelock 3.0.12\r\nfrozendict 1.2\r\nfsspec 0.8.4\r\nfuture 0.18.2\r\ng2p-en 2.1.0\r\ngdown 3.12.2\r\ngitdb 4.0.5\r\nGitPython 3.1.11\r\ngoogle-auth 1.21.0\r\ngoogle-auth-oauthlib 0.4.1\r\ngraphsurgeon 0.4.5\r\ngrpcio 1.31.0\r\nh5py 2.10.0\r\nhtml2text 2020.1.16\r\nhtml5lib 0.999999999\r\nhttplib2 0.9.2\r\nhydra-core 1.0.4\r\nidna 2.6\r\nimagesize 1.2.0\r\nimportlib-metadata 1.7.0\r\nimportlib-resources 3.3.0\r\ninflect 4.1.0\r\niniconfig 1.0.1\r\nipdb 0.13.3\r\nipykernel 5.3.4\r\nipyparallel 6.3.0\r\nipython 7.16.1\r\nipython-genutils 0.2.0\r\nipywidgets 7.5.1\r\nisort 4.3.21\r\njedi 0.17.2\r\nJetson.GPIO 2.0.11\r\nJinja2 2.11.2\r\njmespath 0.10.0\r\njoblib 0.16.0\r\njson5 0.9.5\r\njsonschema 3.2.0\r\njupyter-client 6.1.7\r\njupyter-core 4.6.3\r\njupyterlab 2.2.6\r\njupyterlab-server 1.2.0\r\nkaldi-io 0.9.4\r\nkaldi-python-io 1.1.2\r\nkeyring 10.6.0\r\nkeyrings.alt 3.0\r\nkiwisolver 1.2.0\r\nlanguage-selector 0.1\r\nlatexcodec 2.0.1\r\nlaunchpadlib 1.10.6\r\nlazr.restfulclient 0.13.5\r\nlazr.uri 1.0.3\r\nlibrosa 0.7.2\r\nlinecache2 1.0.0\r\nllvmlite 0.31.0\r\nlouis 3.5.0\r\nlxml 4.2.1\r\nmacaroonbakery 1.1.3\r\nMako 1.0.7\r\nMarkdown 3.2.2\r\nMarkupSafe 1.0\r\nmarshmallow 3.7.1\r\nmatplotlib 3.3.3\r\nmegatron-lm 1.1.5\r\nmistune 0.8.4\r\nmore-itertools 8.5.0\r\nmsgpack 1.0.0\r\nmypy-extensions 0.4.3\r\nnbconvert 5.6.1\r\nnbformat 5.0.7\r\nnemo-toolkit 1.0.0b3\r\nnltk 3.5\r\nnose 1.3.7\r\nnotebook 6.1.3\r\nnum2words 0.5.10\r\nnumba 0.48.0\r\nnumpy 1.19.1\r\noauth 1.0.1\r\noauthlib 3.1.0\r\nobjectio 0.2.29\r\nomegaconf 2.0.5\r\nonboard 1.4.1\r\nonnx 1.7.0\r\nonnxruntime-gpu 1.4.0\r\noset 0.1.3\r\npackaging 20.4\r\npandas 0.22.0\r\npandocfilters 1.4.2\r\nparameterized 0.7.4\r\nparso 0.7.1\r\npathspec 0.8.0\r\npathtools 0.1.2\r\npbr 3.1.1\r\npesq 0.0.1\r\npexpect 4.8.0\r\npickleshare 0.7.5\r\nPillow 7.2.0\r\npip 20.3.1\r\npip-api 0.0.14\r\npipreqs 0.4.10\r\npluggy 0.13.1\r\nprogressbar 2.5\r\nprometheus-client 0.8.0\r\npromise 2.3\r\nprompt-toolkit 3.0.7\r\nprotobuf 3.14.0\r\npsutil 5.7.3\r\nptyprocess 0.6.0\r\npy 1.9.0\r\npyasn1 0.4.8\r\npyasn1-modules 0.2.8\r\npybind11 2.5.0\r\npybtex 0.22.2\r\npybtex-docutils 0.2.2\r\npycairo 1.16.2\r\npycparser 2.20\r\npycrypto 2.6.1\r\npycups 1.9.73\r\nPygments 2.6.1\r\npygobject 3.26.1\r\nPyJWT 1.5.3\r\npymacaroons 0.13.0\r\nPyNaCl 1.1.2\r\npyparsing 2.4.7\r\npypinyin 0.39.0\r\npyRFC3339 1.0\r\npyrsistent 0.16.0\r\nPySocks 1.7.1\r\npystoi 0.3.3\r\npytest 6.0.1\r\npytest-runner 5.2\r\npython-apt 1.6.5+ubuntu0.4\r\npython-dateutil 2.6.1\r\npython-debian 0.1.32\r\npytorch-lightning 1.0.8\r\npytz 2018.3\r\npyxdg 0.25\r\nPyYAML 5.3.1\r\npyzmq 19.0.2\r\nqtconsole 4.7.7\r\nQtPy 1.9.0\r\nrapidfuzz 0.11.1\r\nregex 2020.7.14\r\nrequests 2.24.0\r\nrequests-oauthlib 1.3.0\r\nrequests-unixsocket 0.1.5\r\nresampy 0.2.2\r\nrouge-score 0.0.4\r\nrsa 4.6\r\nruamel.yaml 0.16.10\r\nruamel.yaml.clib 0.2.0\r\ns3transfer 0.3.3\r\nsacremoses 0.0.43\r\nscikit-learn 0.23.2\r\nscipy 1.5.4\r\nSecretStorage 2.3.1\r\nsemantic-version 2.8.5\r\nSend2Trash 1.5.0\r\nsentencepiece 0.1.91\r\nsentry-sdk 0.19.4\r\nsetuptools 51.0.0\r\nsetuptools-rust 0.11.3\r\nshortuuid 1.0.1\r\nsimplejson 3.13.2\r\nsix 1.15.0\r\nsmmap 3.0.4\r\nsnowballstemmer 2.0.0\r\nSoundFile 0.10.3.post1\r\nsox 1.4.0\r\nSphinx 3.2.1\r\nsphinx-rtd-theme 0.5.0\r\nsphinxcontrib-applehelp 1.0.2\r\nsphinxcontrib-bibtex 1.0.0\r\nsphinxcontrib-devhelp 1.0.2\r\nsphinxcontrib-htmlhelp 1.0.3\r\nsphinxcontrib-jsmath 1.0.1\r\nsphinxcontrib-qthelp 1.0.3\r\nsphinxcontrib-serializinghtml 1.1.4\r\nssh-import-id 5.7\r\nsubprocess32 3.5.4\r\nsystem-service 0.3\r\nsystemd-python 234\r\ntensorboard 2.3.0\r\ntensorboard-plugin-wit 1.7.0\r\ntensorboardX 2.1\r\ntensorrt 7.1.3.0\r\nterminado 0.8.3\r\ntestpath 0.4.4\r\ntestresources 2.0.0\r\nthreadpoolctl 2.1.0\r\ntokenizers 0.9.3\r\ntoml 0.10.1\r\ntorch 1.6.0\r\ntorch-stft 0.1.4\r\ntorchtext 0.6.0\r\ntorchvision 0.7.0a0+78ed10c\r\ntornado 6.0.4\r\ntqdm 4.48.2\r\ntraceback2 1.4.0\r\ntraitlets 4.3.3\r\ntransformers 3.5.1\r\ntyped-ast 1.4.1\r\ntyper 0.3.2\r\ntyping-extensions 3.7.4.2\r\nubuntu-drivers-common 0.0.0\r\nuff 0.6.9\r\nUnidecode 1.1.1\r\nunittest2 1.1.0\r\nunity-scope-calculator 0.1\r\nunity-scope-chromiumbookmarks 0.1\r\nunity-scope-colourlovers 0.1\r\nunity-scope-devhelp 0.1\r\nunity-scope-firefoxbookmarks 0.1\r\nunity-scope-manpages 0.1\r\nunity-scope-openclipart 0.1\r\nunity-scope-texdoc 0.1\r\nunity-scope-tomboy 0.1\r\nunity-scope-virtualbox 0.1\r\nunity-scope-yelp 0.1\r\nunity-scope-zotero 0.1\r\nurllib3 1.22\r\nurwid 2.0.1\r\nvirtualenv 15.1.0\r\nwadllib 1.3.2\r\nwandb 0.10.12\r\nwatchdog 0.10.4\r\nwcwidth 0.2.5\r\nwebdataset 0.1.37\r\nwebencodings 0.5\r\nWerkzeug 1.0.1\r\nwget 3.2\r\nwheel 0.30.0\r\nwidgetsnbextension 3.5.1\r\nwrapt 1.12.1\r\nxkit 0.0.0\r\nyarg 0.1.9\r\nyoutokentome 1.0.6\r\nzipp 3.1.0\r\nzope.interface 4.3.2\r\n", "nothing pops out, but do you have cudatoolkit installed? other than that I don't know.", "calling nvcc --version gives:\r\n\r\nnvcc: NVIDIA (R) Cuda compiler driver\r\nCopyright (c) 2005-2019 NVIDIA Corporation\r\nBuilt on Wed_Oct_23_21:14:42_PDT_2019\r\nCuda compilation tools, release 10.2, V10.2.89\r\n\r\nwhich nvcc gives:\r\n/usr/local/cuda-10.2/bin/nvcc\r\n\r\nso cuda-toolkit seems to be installed.\r\nNevertheless nvidia-smi is not installed.\r\n\r\n", "I got the same error , when I \" import nemo\" it works well, and use nemo.core works too; But when I \"import nemo.collections.asr \" or \"import nemo.collections.nlp \" raise un error \"segmentation fault (core dumped)\" , Seems like only collections Class maybe have something wrong ?\r\n\r\nPython 3.6.9\r\npytorch 1.6.0\r\ncuda 10.2\r\nnemo 1.0.0b3", "proposed solution is to use these versions\r\nllvmlite-0.32.1\r\n#numba-0.49.1\r\ndoes it resolve your issue?\r\nhttps://forums.developer.nvidia.com/t/nemo-installation-done-performance-to-be-evaluated/112012/38", "> proposed solution is to use these versions\r\n> llvmlite-0.32.1\r\n> #numba-0.49.1\r\n> does it resolve your issue?\r\n> https://forums.developer.nvidia.com/t/nemo-installation-done-performance-to-be-evaluated/112012/38\r\n\r\n@AndreV84 many thanks for your advice , but it dosen't solve my issue . follow your advice I try reinstall llvmlite-0.32.1 and numba-0.49.1 , got an error **from numba.utils import total_ordering ImportError: cannot import name 'total_ordering’** seems like still version's problem , then i changed numba version to be 0.48.0 with this method https://github.com/librosa/librosa/issues/1103solved error **from numba.utils import total_ordering ImportError: cannot import name 'total_ordering’** but unfortunately return back to old problem **\"segmentation fault (core dumped)\"**again when i **import nemo.collection.asr as nemo_asr** .\r\n\r\nI used faulthandler catch the error feedback like this:\r\n------------------------------------------------------------------------------------\r\n```\r\nCurrent thread 0x0000007fa63d6010 (most recent call first):\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 922 in create_module\r\n File \"<frozen importlib._bootstrap>\", line 571 in module_from_spec\r\n File \"<frozen importlib._bootstrap>\", line 658 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/sentencepiece.py\", line 15 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/nemo/collections/common/tokenizers/sentencepiece_tokenizer.py\", line 19 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/nemo/collections/common/tokenizers/__init__.py\", line 17 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap>\", line 1023 in _handle_fromlist\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/nemo/collections/common/__init__.py\", line 16 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap>\", line 941 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/nemo/collections/asr/models/classification_models.py\", line 28 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/nemo/collections/asr/models/__init__.py\", line 16 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap>\", line 1023 in _handle_fromlist\r\n File \"/home/yipeng/.local/lib/python3.6/site-packages/nemo/collections/asr/__init__.py\", line 15 in <module>\r\n File \"<frozen importlib._bootstrap>\", line 219 in _call_with_frames_removed\r\n File \"<frozen importlib._bootstrap_external>\", line 678 in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 665 in _load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 955 in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 971 in _find_and_load\r\n File \"<stdin>\", line 1 in <module>\r\nSegmentation fault (core dumped)\r\n\r\n```\r\n--------------------------------------------------------------------------------------------------------------\r\n@okuchaiev Is there some successful exeperience test for running nemo on jetson nano/nx with https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/asr/01_ASR_with_NeMo.ipynb ?\r\nlooking forward to your solution really appreciate !\r\n", "yes, but the numba version needs to be 47\r\nI suggest to close the issue as it seems got resolved\r\n@yipenglinoe do you need the issue to remain open?", "> yes, but the numba version needs to be 47\r\n> I suggest to close the issue as it seems got resolved\r\n> @yipenglinoe do you need the issue to remain open?\r\nyes , for me no problem we can close it . thank you again @AndreV84 ", "Is there a documented way to use NeMo in full on Jetsons? This is something I'm interested in if it exists. I'm using the L4T base Docker image and virtualenvs within the image, so dependency conflicts with the base L4T image aren't a problem.", "@znmeb \r\nthere is nemo documentation \r\nhttps://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/\r\n however historically it was not targeted onto jetson devices but rather x86_64 as it seems to me\r\n\r\nspecifically for juetson there were released for voice:\r\nhttps://github.com/NVIDIA-AI-IOT/jetson-cloudnative-demo\r\nhttps://ngc.nvidia.com/catalog/containers/nvidia:jetson-voice", "@AndreV84 voice is quite close to my intended applications (algorithmic composition - digital sound synthesis) so I'll test those out. I have an RTX 3090 I can use for training. ;-)", ">> \"Is there a documented way to use NeMo in full on Jetsons? \"\r\n- This is a frequent ask, we don't have it at this point. " ]

[]

[]

[ "This pull request **introduces 1 alert** when merging 260e2af8a0d4ea45c2f7ce8cfec9f17fc52a3912 into d01b7bbc3fdb1bbf14789f71b8f368cf0aa8f86b - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-838abc09fd547a8fab60739d22febc15820ebfe7)\n\n**new alerts:**\n\n* 1 for Unused import", "@vladgets can you please fix CI on this PR?\r\n", "Correcting it. The problem was in the previous commits exp_manager was removed from testing my model in Jenkins file. And my code was relying for it to save the model." ]

[]

[]

[ "what is the task or example you were trying to run? Did you first run with internet data and then later without internet? Some examples where we fetch model from NGC needs to be run with the internet, probably your example got stuck there. " ]

[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" } ]

[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "Any word on this @titu1994? I'm curious if theres a specific reason. I'm starting to use CommonVoice English and it's 56GB when stored as MP3 so it will be unusable in wav format. Thank you!", "@vsl9 Any thoughts about this ? ", "Hi\r\n\r\ntorchaudio developer here. Recently [I am adding support for file-like object in torchaudio's I/O functions](https://github.com/pytorch/audio/pull/1158), and I am wondering what extra features would be required for NeMo to consider using `torchaudio.load`. In #1616, I see that tarfile support is one, which is working now. Do you have any other requirements? What about Windows support?\r\n\r\n", "@mthrok Sorry for the delay, just saw the previous #1616 conversation regarding this. wav, tarfiles via webdataset, and mp3 are currently supported, but it would be nice for torchaudio to also support FLAC if possible, since MLS dataset is in that format - http://www.openslr.org/94/. \r\n\r\nThe reason why we don't add torchaudio as an explicit dependency, and instead make it optional for certain modules, is the fact that torchaudio previously pinned it's version to a specific pytorch version. I am unsure of whether this is still the case. \r\n\r\nThis is generally fine for day to day use, but interferes with containers that utilize commit hash version of pytorch (Torchaudio pinning forces reinstallation of pytorch). This issue goes away by building torchaudio from main branch, but building torchaudio is a time-consuming process which we don't want to constantly do on the fly. \r\n\r\nOne way to alleviate this is to have the Nemo container build torchaudio, but our ci uses pytorch container and pip installs the Nemo library in order to simulate user workflow - and torchaudios pinned pytorch version interfered with this. \r\n\r\nWe would be very happy to add torch audio data loading as an option for various audio formats, but it will have to remain as an optional dependency for users until the pinned version issue is resolved. ", "Thanks for the explanation. Please note that torchaudio supports FLAC. (although we get the report that PySoundFile is faster and I think it makes sense as libsox does extra stuff in addition to loading.)\r\n\r\nRegarding the pinned versioning, I understand your constraints and unfortunately we cannot do much about it. torchaudio's extension module is coupled with PyTorch's C++ backend so torchaudio cannot be paired with arbitral version of PyTorch. And because torchaudio uses the latest extension mechanism PyTorch provides, often times torchaudio cannot be compiled with the previous release of PyTorch.\r\n\r\nIf you think of something torchaudio can help, please let us know. ", "FLAC is supported by default as it is part of soundfile library. MP3 is specially supported via pydub. We still recommend wav files when training for efficiency reasons - wav file is slightly faster to decode than flac or mp3" ]

[]

[]

[ "This pull request **introduces 9 alerts** when merging 1f4320a27481466e8223cf8c37375a6f529d7221 into 08d1ccc503e35796e2874b24eca677e9eebad71c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-95caec7dea0dda6c9d810101bc940f1b7fcbe7f0)\n\n**new alerts:**\n\n* 3 for Except block handles &#39;BaseException&#39;\n* 3 for Unused import\n* 2 for Unused local variable\n* 1 for Comparison of constants", "This pull request **introduces 4 alerts** when merging 8fcb060ad660afba3c0c18f66fadf19b6a591f33 into 08d1ccc503e35796e2874b24eca677e9eebad71c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-1caf3d54580f674d744a5163396a7f3dace0978b)\n\n**new alerts:**\n\n* 3 for Except block handles &#39;BaseException&#39;\n* 1 for Comparison of constants", "This pull request **introduces 4 alerts** when merging a5ac274b377cc86064482e431dd69ee9cb5c4c68 into 08d1ccc503e35796e2874b24eca677e9eebad71c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-e358af38a187868e9fee123f45c1a075333c6e29)\n\n**new alerts:**\n\n* 3 for Except block handles &#39;BaseException&#39;\n* 1 for Comparison of constants", "This pull request **introduces 4 alerts** when merging ba2af6f3b9111367b2513d5e2a84b02eb1db6dd5 into 08d1ccc503e35796e2874b24eca677e9eebad71c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-bf9d19eb66ac9a1ea3a08bd19df118bef5be049c)\n\n**new alerts:**\n\n* 3 for Except block handles &#39;BaseException&#39;\n* 1 for Comparison of constants", "This pull request **introduces 4 alerts** when merging ad0e8cdf9bea1c2db50eb33b1c61bb83a76a36e9 into 9da1d27ddd7f1d5d9b6cd75f7308787976680dd8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-0c0639bdacc1eba624c84b35486129114651b4b3)\n\n**new alerts:**\n\n* 3 for Except block handles &#39;BaseException&#39;\n* 1 for Comparison of constants", "This pull request **introduces 4 alerts** when merging be92477cd301a13ae6d223a09b490cf2a81508dd into 9aa4ada92b2e6ddd418704dc392e8576d44e5f41 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c6a60db3032019e55dea98b121d785892bd73fb5)\n\n**new alerts:**\n\n* 3 for Except block handles &#39;BaseException&#39;\n* 1 for Comparison of constants" ]

[]

[]

[ "Some details can be found here - https://arxiv.org/abs/2010.12715" ]

[]

[]

[ "Retrying building pytorch etc from source:\r\nUsing transformers==4.0.0:\r\npython\r\nimport nemo\r\nimport nemo.collections.asr as nemo_asr\r\nERROR .......\r\nsite-packages/transformers/trainer_pt_utils.py\", line 40, in <module>\r\n from torch.optim.lr_scheduler import SAVE_STATE_WARNING\r\nI believe SAVE_STATE_WARNING was removed from pytorch a few days ago.", "I can see this has been fixed in the source code (master branch) for transformers.\r\nI can now import nemo_asr without segmentation fault and without the SAVE_STATE_WARNING error.." ]

[]

[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[]

[]

[]

[ "Workaround for https://github.com/PyTorchLightning/pytorch-lightning/issues/5063" ]

[]

[]

[ "This pull request **introduces 1 alert** when merging 340f7482b74ee14f376e15450762888c0536e201 into 16055d86b0be550b87ee5d327e351a1562ce7eb2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2be8828844b45e4c518c59e6cf4c908a99fc228e)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull request **introduces 1 alert** when merging b7e4358cd6bd6e4a2428749fcbf569d393fdfefd into 1c24a5d35a9680b7436f505a8e69dc8f8373f3c2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-29672ebec67da7b0117c1d17394c488f86248496)\n\n**new alerts:**\n\n* 1 for Unused import" ]

[]

[]

[ "@vinchg could you rebase this PR with main? There was a fix this morning that we need to pass CI.", "@ericharper Yeah, PR has been rebased!" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "Fixed in main branch, thanks for pointing it out !" ]

[]

[]

[ "@purn3ndu please check the default names for the class names in the 3 configs" ]

[]

[]

[ "@VahidooX to discuss:\r\n1. should we make class_labels_file mandatory? and it so, then:\r\n2. could we get rid of num_classes and get it as len(labels) when loaded from class_labels_file?\r\n\r\nThe PR looks good and we can absorb it to TLT->JARVIS the way it is , but I am just thinking loud here...", "2nd set of thoughts:\r\n\r\n1) in fine-tuning we are effectively changing the dataset, hence should change the \"class labels\" too. We are using the `setup_*_ds` for that purpose. Do you think those methods should re-load/overwrite those sections in model?\r\n2) should we leverage that information in inference (`classifytext`) ?\r\n\r\n(in other words - should we move that part of \"post-processing\" from TLT inference to `model.classifytext`?)" ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "This pull request **introduces 1 alert** and **fixes 2** when merging 58871c29e0990a1d316eecda9ad54c8a2fc23c10 into 203633d43fc997c2b7d089d94a0e113ebf2e0381 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-cb8227a1d7c811a936f38ca9ad1de026d5f9a1b6)\n\n**new alerts:**\n\n* 1 for Unused import\n\n**fixed alerts:**\n\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import", "> \r\n> \r\n> Could you revert the changes related to WER for the time being? That needs further discussion and is not necessary for bug fixes to Conformer model itself. Everything else related to conformer modules looks good to me.\r\n\r\nDropped that part but keep in mind that predictions_len comes from the output of the decoder. So if a model return that, it is used otherwise it is ignored. For some models like encoder/decoder with cross attention it should return None for instance. So it would just used for the models who returns the valid length of their outputs.", "> Dropped that part but keep in mind that predictions_len comes from the output of the decoder. So if a model return that, it is used otherwise it is ignored. For some models like encoder/decoder with cross attention it should return None for instance. So it would just used for the models who returns the valid length of their outputs.\r\n\r\nAll CTC based encoders return this length value, which would affect WER calculations wrt QuartzNet/Jasper as well. In the future, yes we can add this but there needs to be a special flag passed by only certain models - say Attention based models - which then submits the lengths for masking to the WER decoding. This is so that unrelated models such as QN/Jasper are not affected by this masking during wer.", "This pull request **fixes 2 alerts** when merging 11007248b28ccfad5e63b1a8e75956a35abbb5c7 into 21a55cdb7a2150114a28b84e9521920ceb56181b - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-267ca61f8e59ff7c78621434ff4ba2b5c4e7af12)\n\n**fixed alerts:**\n\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import", "This pull request **fixes 2 alerts** when merging 206fe29d77d91cb3495cee49915e1528a0bea652 into 2ced0eaca3e8a781aee48548914c610c432764e3 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c6b142b51b4a9a190753cdbb46e9c83eea3f0867)\n\n**fixed alerts:**\n\n* 1 for Signature mismatch in overriding method\n* 1 for Unused import" ]

[]

[]

[]

[]

[]

[ "This pull request **introduces 1 alert** when merging 6b8bc699ec29a04c8be043eacebdfd0974c576e7 into 601b6789bcbfcd6721b9d27aee6008c9e44ba42f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c5dcb90b11d16b32e076d0ab25205640cc2cda01)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull request **introduces 1 alert** when merging 7b26b1f79ba86fcad8c583bd6c4bff77329b31de into 601b6789bcbfcd6721b9d27aee6008c9e44ba42f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-5247e13878060b391ad23279b875e0b3f8c171b9)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull request **introduces 1 alert** when merging f00dc0547561f2ec845f29f46429a1905a893a8a into 601b6789bcbfcd6721b9d27aee6008c9e44ba42f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-789113e3c8e5c194db43ce417b744d587b56b4be)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull request **introduces 1 alert** when merging eef3f5a703581dbc91c0165834e2aac6e7e3da3a into 601b6789bcbfcd6721b9d27aee6008c9e44ba42f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-0eae7364a7eef0ad12a12a9293f0b406e74d1311)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull request **introduces 1 alert** when merging 93e793f110ffbcea7529ced39aeb43c2187ccb20 into 601b6789bcbfcd6721b9d27aee6008c9e44ba42f - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-e6f88c94021589987c87e9507dd02046c7328ca2)\n\n**new alerts:**\n\n* 1 for Unused import" ]

[]

[]

[ "Thanks!" ]

[]

[]

[]

[]

[]

[]