url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/5353 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5353/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5353/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5353/events | https://github.com/NVIDIA/NeMo/pull/5353 | 1,440,459,230 | PR_kwDOC_bI7s5CcBS9 | 5,353 | Fix issues with PL 1.8 | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-08T15:51:25 | 2022-11-28T21:30:57 | 2022-11-28T21:30:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5353",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5353",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5353.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5353.patch",
"merged_at": "2022-11-28T21:30:54"
} | # What does this PR do ?
Attempts to fix all issues after many deprecations/lightning lite becoming the backbone for a lot of the underlying pytorch lightning code.
cc @titu1994
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5353/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5353/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5352 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5352/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5352/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5352/events | https://github.com/NVIDIA/NeMo/issues/5352 | 1,439,944,330 | I_kwDOC_bI7s5V086K | 5,352 | Unable to deploy nemo model to riva pipeline (after conversion to riva) | {
"login": "manchandasahil",
"id": 32937046,
"node_id": "MDQ6VXNlcjMyOTM3MDQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/32937046?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/manchandasahil",
"html_url": "https://github.com/manchandasahil",
"followers_url": "https://api.github.com/users/manchandasahil/followers",
"following_url": "https://api.github.com/users/manchandasahil/following{/other_user}",
"gists_url": "https://api.github.com/users/manchandasahil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/manchandasahil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/manchandasahil/subscriptions",
"organizations_url": "https://api.github.com/users/manchandasahil/orgs",
"repos_url": "https://api.github.com/users/manchandasahil/repos",
"events_url": "https://api.github.com/users/manchandasahil/events{/privacy}",
"received_events_url": "https://api.github.com/users/manchandasahil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-08T10:47:46 | 2022-12-17T01:54:19 | 2022-12-17T01:54:19 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Unable to deploy a fine-tuned Punctuation and Capitalization model to Riva pipeline
**Steps/Code to reproduce bug**
1. Fine tune a nemo punctuation and capitalization model.
2. Convert it to rive using this guide: https://docs.nvidia.com/deeplearning/riva/user-guide/docs/model-overview.html
3. Deploy it using nvcr.io/nvidia/riva/riva-speech:2.7.0 and it is giving an empty response.
Deploy command
NV_GPU=1 nvidia-docker run -ti --name riva_source -p 8008:8008 -p 50051:50051 -p 5800:8000 -p 58001:8001 -v <localtion_models>:/data/models -e MODEL_REPOSITORY="--model-repository /data/models" -e INTERIM_RESULTS="--interim-results" -e CUSTOM_ITN="--custom-itn" --shm-size=1g --ulimit memlock=-1 --ulimit stack=67108864 nvcr.io/nvidia/riva/riva-speech:2.4.0-server tritonserver --log-verbose=0 --strict-model-config=true --model-repository /data/models --cuda-memory-pool-byte-size=0:1000000000 --exit-on-error=false
This was working while using riva 1.10-beta server
A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.
My ourput logs have the following. Please note the output contents are empty
model_name: "riva-punctuation-en-US"
id: "1"
inputs {
name: "PIPELINE_INPUT"
datatype: "BYTES"
shape: 1
shape: 1
}
outputs {
name: "PIPELINE_OUTPUT"
}
raw_input_contents: "\372\000\000\000in a new password i can take it from here alrighty is there anything else i can help you with them thank you very much ms rostow it was my pleasure to assist you thank you for using optum r x and if you chose our survey it will be next okay thank you"
model_name: "riva-punctuation-en-US"
model_version: "1"
id: "1"
outputs {
name: "PIPELINE_OUTPUT"
datatype: "BYTES"
shape: 1
shape: 1
}
raw_output_contents: "\000\000\000\000"
[[b'']]
**Expected behavior**
Deploy the model correctly and output content is a punctuated input string
**Environment overview (please complete the following information)**
- Environment location: nvcr.io/nvidia/riva/riva-speech:2.4.0-server
- Method of NeMo install: install from source
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
nvcr.io/nvidia/riva/riva-speech:2.4.0-server
- OS version
- PyTorch version
- Python version
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5352/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5352/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5351 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5351/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5351/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5351/events | https://github.com/NVIDIA/NeMo/issues/5351 | 1,439,819,284 | I_kwDOC_bI7s5V0eYU | 5,351 | Unable to resume ASR training | {
"login": "shihabtechno",
"id": 107035118,
"node_id": "U_kgDOBmE57g",
"avatar_url": "https://avatars.githubusercontent.com/u/107035118?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shihabtechno",
"html_url": "https://github.com/shihabtechno",
"followers_url": "https://api.github.com/users/shihabtechno/followers",
"following_url": "https://api.github.com/users/shihabtechno/following{/other_user}",
"gists_url": "https://api.github.com/users/shihabtechno/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shihabtechno/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shihabtechno/subscriptions",
"organizations_url": "https://api.github.com/users/shihabtechno/orgs",
"repos_url": "https://api.github.com/users/shihabtechno/repos",
"events_url": "https://api.github.com/users/shihabtechno/events{/privacy}",
"received_events_url": "https://api.github.com/users/shihabtechno/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-08T09:31:44 | 2022-11-08T10:39:47 | 2022-11-08T10:39:47 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am trying to resume my training by running the training command,it pick the last checkpoint properly and while stat training it show this error
Environment details
OS version : Ubuntu 20.04 LTS
PyTorch version: 1.13.0a0+08820cb
Python version: 3.8.0
Nemo Version : 1.12.0
Additional context
I ran my model on 2 GPU's :
RTX 3090 and
24267MiB
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5351/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5351/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5350 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5350/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5350/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5350/events | https://github.com/NVIDIA/NeMo/pull/5350 | 1,439,698,427 | PR_kwDOC_bI7s5CZbMo | 5,350 | fix data loader with comma seperated manifest | {
"login": "twmht",
"id": 1567200,
"node_id": "MDQ6VXNlcjE1NjcyMDA=",
"avatar_url": "https://avatars.githubusercontent.com/u/1567200?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/twmht",
"html_url": "https://github.com/twmht",
"followers_url": "https://api.github.com/users/twmht/followers",
"following_url": "https://api.github.com/users/twmht/following{/other_user}",
"gists_url": "https://api.github.com/users/twmht/gists{/gist_id}",
"starred_url": "https://api.github.com/users/twmht/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/twmht/subscriptions",
"organizations_url": "https://api.github.com/users/twmht/orgs",
"repos_url": "https://api.github.com/users/twmht/repos",
"events_url": "https://api.github.com/users/twmht/events{/privacy}",
"received_events_url": "https://api.github.com/users/twmht/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-08T08:13:49 | 2022-12-07T02:01:42 | 2022-12-07T02:01:42 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5350",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5350",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5350.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5350.patch",
"merged_at": null
} | # What does this PR do ?
Fix #5349
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5350/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5350/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5349 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5349/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5349/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5349/events | https://github.com/NVIDIA/NeMo/issues/5349 | 1,439,572,684 | I_kwDOC_bI7s5VziLM | 5,349 | can't use dali with comma seperated manifest | {
"login": "twmht",
"id": 1567200,
"node_id": "MDQ6VXNlcjE1NjcyMDA=",
"avatar_url": "https://avatars.githubusercontent.com/u/1567200?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/twmht",
"html_url": "https://github.com/twmht",
"followers_url": "https://api.github.com/users/twmht/followers",
"following_url": "https://api.github.com/users/twmht/following{/other_user}",
"gists_url": "https://api.github.com/users/twmht/gists{/gist_id}",
"starred_url": "https://api.github.com/users/twmht/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/twmht/subscriptions",
"organizations_url": "https://api.github.com/users/twmht/orgs",
"repos_url": "https://api.github.com/users/twmht/repos",
"events_url": "https://api.github.com/users/twmht/events{/privacy}",
"received_events_url": "https://api.github.com/users/twmht/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-08T06:25:44 | 2022-12-18T01:56:03 | 2022-12-18T01:56:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | When using nvidia dali to train speech to text,
```python
cfg = copy.deepcopy(char_model.cfg)
"""
read cleaned manifest
"""
train_manifest_data = read_manifest(train_manifest_cleaned)
train_charset = get_charset(train_manifest_data)
dev_manifest_data = read_manifest(dev_manifest_cleaned)
dev_charset = get_charset(dev_manifest_data)
train_dev_set = set.union(set(train_charset.keys()), set(dev_charset.keys()))
# Setup train, validation, test configs
with open_dict(cfg):
# Train dataset (Concatenate train manifest cleaned and dev manifest cleaned)
cfg.train_ds.manifest_filepath = f'{train_manifest_cleaned},{dev_manifest_cleaned}'
cfg.train_ds.labels = list(train_dev_set)
cfg.train_ds.normalize_transcripts = False
cg.train_ds.batch_size = 32
cfg.train_ds.use_dali = True
cfg.train_ds.num_workers = 8
cfg.train_ds.pin_memory = True
cfg.train_ds.trim_silence = True
char_model.setup_training_data(cfg.train_ds)
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5349/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5349/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5348 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5348/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5348/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5348/events | https://github.com/NVIDIA/NeMo/pull/5348 | 1,439,393,435 | PR_kwDOC_bI7s5CYYnm | 5,348 | bugfix in volume loss for CTC models | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-11-08T03:14:18 | 2022-11-08T18:04:49 | 2022-11-08T18:04:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5348",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5348",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5348.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5348.patch",
"merged_at": "2022-11-08T18:04:42"
} | # What does this PR do ?
fixes bug in computation of volume loss
Add a one line overview of what this PR aims to accomplish.
fixes bug in computation of volume loss
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5348/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5348/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5347 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5347/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5347/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5347/events | https://github.com/NVIDIA/NeMo/pull/5347 | 1,439,237,117 | PR_kwDOC_bI7s5CX2ND | 5,347 | Pcla tutorial fixes | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-08T00:49:50 | 2022-11-08T02:54:30 | 2022-11-08T02:54:26 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5347",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5347",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5347.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5347.patch",
"merged_at": "2022-11-08T02:54:26"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5347/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5347/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5346 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5346/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5346/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5346/events | https://github.com/NVIDIA/NeMo/pull/5346 | 1,439,199,669 | PR_kwDOC_bI7s5CXt5n | 5,346 | added python and c++ alignment code | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-08T00:20:17 | 2022-11-15T17:42:48 | 2022-11-15T17:42:45 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5346",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5346",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5346.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5346.patch",
"merged_at": "2022-11-15T17:42:45"
} | Signed-off-by: Yang Zhang <[email protected]>
# What does this PR do ?
provides both python and c++ alignment
**Collection**: tools | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5346/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5346/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5345 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5345/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5345/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5345/events | https://github.com/NVIDIA/NeMo/pull/5345 | 1,439,031,544 | PR_kwDOC_bI7s5CXIyB | 5,345 | [DOC] added ipython dependency to support IPython.sphinxext extension | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T21:43:15 | 2022-11-08T19:31:36 | 2022-11-08T19:31:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5345",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5345",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5345.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5345.patch",
"merged_at": "2022-11-08T19:31:32"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
This is to fix the doc build error below,
```
Could not import extension IPython.sphinxext.ipython_console_highlighting (exception: No module named 'IPython')
```
[root-cause] Previously, TTS doc added a block `.. ipython::` to show the list of models (https://github.com/NVIDIA/NeMo/blob/main/docs/source/tts/checkpoints.rst), and added extension (https://github.com/NVIDIA/NeMo/blob/main/docs/source/conf.py#L113-L114).
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5345/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5345/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5344 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5344/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5344/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5344/events | https://github.com/NVIDIA/NeMo/pull/5344 | 1,439,011,962 | PR_kwDOC_bI7s5CXEei | 5,344 | [TTS] bugfix for the script of generating mels from fastpitch. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T21:28:01 | 2022-11-07T23:25:31 | 2022-11-07T23:25:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5344",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5344",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5344.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5344.patch",
"merged_at": "2022-11-07T23:25:28"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
Some YAML config may not use `use_beta_binomial_interpolator` explicitly so that the script would raise errors like below,
``` bash
pyxis: importing docker image ...
OMP: Info #276: omp_set_nested routine deprecated, please use omp_set_max_active_levels instead.
Traceback (most recent call last):
File "scripts/dataset_processing/tts/generate_mels_for_finetune_hifigan.py", line 177, in <module>
main()
File "scripts/dataset_processing/tts/generate_mels_for_finetune_hifigan.py", line 149, in main
use_beta_binomial_interpolator = spec_model.cfg.train_ds.dataset.use_beta_binomial_interpolator
File "/opt/conda/lib/python3.8/site-packages/omegaconf/dictconfig.py", line 357, in __getattr__
self._format_and_raise(key=key, value=None, cause=e)
File "/opt/conda/lib/python3.8/site-packages/omegaconf/base.py", line 190, in _format_and_raise
format_and_raise(
File "/opt/conda/lib/python3.8/site-packages/omegaconf/_utils.py", line 738, in format_and_raise
_raise(ex, cause)
File "/opt/conda/lib/python3.8/site-packages/omegaconf/_utils.py", line 716, in _raise
raise ex.with_traceback(sys.exc_info()[2]) # set end OC_CAUSE=1 for full backtrace
File "/opt/conda/lib/python3.8/site-packages/omegaconf/dictconfig.py", line 351, in __getattr__
return self._get_impl(key=key, default_value=_DEFAULT_MARKER_)
File "/opt/conda/lib/python3.8/site-packages/omegaconf/dictconfig.py", line 438, in _get_impl
node = self._get_node(key=key, throw_on_missing_key=True)
File "/opt/conda/lib/python3.8/site-packages/omegaconf/dictconfig.py", line 465, in _get_node
self._validate_get(key)
File "/opt/conda/lib/python3.8/site-packages/omegaconf/dictconfig.py", line 166, in _validate_get
self._format_and_raise(
File "/opt/conda/lib/python3.8/site-packages/omegaconf/base.py", line 190, in _format_and_raise
format_and_raise(
File "/opt/conda/lib/python3.8/site-packages/omegaconf/_utils.py", line 818, in format_and_raise
_raise(ex, cause)
File "/opt/conda/lib/python3.8/site-packages/omegaconf/_utils.py", line 716, in _raise
raise ex.with_traceback(sys.exc_info()[2]) # set end OC_CAUSE=1 for full backtrace
omegaconf.errors.ConfigAttributeError: Key 'use_beta_binomial_interpolator' is not in struct
full_key: train_ds.dataset.use_beta_binomial_interpolator
object_type=dict
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5344/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5344/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5343 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5343/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5343/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5343/events | https://github.com/NVIDIA/NeMo/pull/5343 | 1,438,931,583 | PR_kwDOC_bI7s5CWyvO | 5,343 | Megatron Export Update | {
"login": "Davood-M",
"id": 3964285,
"node_id": "MDQ6VXNlcjM5NjQyODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3964285?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Davood-M",
"html_url": "https://github.com/Davood-M",
"followers_url": "https://api.github.com/users/Davood-M/followers",
"following_url": "https://api.github.com/users/Davood-M/following{/other_user}",
"gists_url": "https://api.github.com/users/Davood-M/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Davood-M/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Davood-M/subscriptions",
"organizations_url": "https://api.github.com/users/Davood-M/orgs",
"repos_url": "https://api.github.com/users/Davood-M/repos",
"events_url": "https://api.github.com/users/Davood-M/events{/privacy}",
"received_events_url": "https://api.github.com/users/Davood-M/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T20:27:09 | 2023-02-23T01:57:32 | 2022-11-15T21:54:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5343",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5343",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5343.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5343.patch",
"merged_at": "2022-11-15T21:54:50"
} | Signed-off-by: David Mosallanezhad <[email protected]>
# What does this PR do ?
Updates export process for Megatron-based models
**Collection**: [Note which collection this PR will affect]
# Changelog
- Changed ORT optimization due to a bug in onnxruntime (https://github.com/microsoft/onnxruntime/issues/12579)
# Usage
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5343/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5343/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5342 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5342/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5342/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5342/events | https://github.com/NVIDIA/NeMo/pull/5342 | 1,438,887,799 | PR_kwDOC_bI7s5CWpQe | 5,342 | only log true validation loss not sanity check | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-07T19:52:23 | 2023-02-21T23:05:33 | 2022-11-30T02:02:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5342",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5342",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5342.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5342.patch",
"merged_at": null
} | Signed-off-by: arendu <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5342/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5342/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5341 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5341/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5341/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5341/events | https://github.com/NVIDIA/NeMo/pull/5341 | 1,438,880,351 | PR_kwDOC_bI7s5CWnrj | 5,341 | [STT] Add Ru ASR Conformer-CTC and Conformer-Transducer | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-07T19:44:44 | 2022-11-09T16:35:32 | 2022-11-07T21:18:25 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5341",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5341",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5341.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5341.patch",
"merged_at": "2022-11-07T21:18:25"
} | Signed-off-by: Sasha Meister <[email protected]>
# What does this PR do ?
[STT] Add Ru ASR Conformer-CTC and Conformer-Transducer
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5341/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5341/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5340 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5340/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5340/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5340/events | https://github.com/NVIDIA/NeMo/pull/5340 | 1,438,848,849 | PR_kwDOC_bI7s5CWhE5 | 5,340 | [STT] Add Ru ASR Conformer-CTC and Conformer-Transducer | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T19:14:36 | 2022-11-07T19:44:15 | 2022-11-07T19:44:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5340",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5340",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5340.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5340.patch",
"merged_at": "2022-11-07T19:44:15"
} | Signed-off-by: Sasha Meister <[email protected]>
# What does this PR do ?
[STT] Add Ru ASR Conformer-CTC and Conformer-Transducer
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5340/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5340/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5339 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5339/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5339/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5339/events | https://github.com/NVIDIA/NeMo/pull/5339 | 1,438,739,790 | PR_kwDOC_bI7s5CWJq- | 5,339 | Support for finetuning and finetuning inference with .ckpt files & batch size refactoring | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T17:43:21 | 2022-11-16T00:17:25 | 2022-11-16T00:17:20 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5339",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5339",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5339.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5339.patch",
"merged_at": "2022-11-16T00:17:20"
} | # What does this PR do ?
Adds support for the following:
1. To be able to do fine-tuning and fine-tuning eval with `.ckpt` files as well as `.nemo files.
2. Refactoring fine-tuning to allow for `check_val_every_n_epochs` > 1 and no more additional checks needed for `trainer.val_check_interval`. This also fixes the progress bar when grad acc > 1.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5339/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5339/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5338 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5338/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5338/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5338/events | https://github.com/NVIDIA/NeMo/pull/5338 | 1,438,405,571 | PR_kwDOC_bI7s5CVCTO | 5,338 | [STT] add Ru ASR conformers to models collections | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T13:54:17 | 2022-11-07T17:34:10 | 2022-11-07T17:34:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5338",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5338",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5338.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5338.patch",
"merged_at": null
} | Signed-off-by: ssh-meister <[email protected]>
Add Ru ASR Conformer-CTC Large and Conformer-Transducer Large to NeMo models collections
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5338/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5338/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5337 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5337/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5337/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5337/events | https://github.com/NVIDIA/NeMo/pull/5337 | 1,437,980,332 | PR_kwDOC_bI7s5CTnQv | 5,337 | [STT] add Ru ASR conformers to models collections | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T08:45:35 | 2022-11-07T08:48:26 | 2022-11-07T08:48:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5337",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5337",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5337.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5337.patch",
"merged_at": null
} | # What does this PR do ?
Add Ru ASR Conformer-CTC Large and Conformer-Transducer Large to NeMo models collections
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #5314
| {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5337/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5337/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5336 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5336/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5336/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5336/events | https://github.com/NVIDIA/NeMo/pull/5336 | 1,437,862,730 | PR_kwDOC_bI7s5CTOyJ | 5,336 | Fixing training/script issues for radtts, also removing grad from caches | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-07T07:01:15 | 2022-11-09T04:37:44 | 2022-11-09T04:37:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5336",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5336",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5336.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5336.patch",
"merged_at": null
} | Fixing training/script issues for radtts, also removing grad from constant/cache buffers
1. A view to the bias was cached as a buffer - that led to cpu/gpu mismatch on backward pass when training - also the caching was wrong - removed. That led to script() breaking for export - had to change script routine to do trace on PartialConv first.
2. Training had NaNs when using partial convolutions in mixed precision mode - had to increase epsilon for mask ratio to fit in float16 range.3.
3. While we are there, removed gradients from cache buffers in some other modules.
Signed-off-by: Boris Fomitchev <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5336/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5336/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5335 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5335/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5335/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5335/events | https://github.com/NVIDIA/NeMo/issues/5335 | 1,437,790,717 | I_kwDOC_bI7s5VsvH9 | 5,335 | RuntimeError "Tensors must have same number of dimensions: got 1 and 2" in Speaker Diarization inference example file. | {
"login": "Mascobot",
"id": 5958899,
"node_id": "MDQ6VXNlcjU5NTg4OTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5958899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Mascobot",
"html_url": "https://github.com/Mascobot",
"followers_url": "https://api.github.com/users/Mascobot/followers",
"following_url": "https://api.github.com/users/Mascobot/following{/other_user}",
"gists_url": "https://api.github.com/users/Mascobot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Mascobot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mascobot/subscriptions",
"organizations_url": "https://api.github.com/users/Mascobot/orgs",
"repos_url": "https://api.github.com/users/Mascobot/repos",
"events_url": "https://api.github.com/users/Mascobot/events{/privacy}",
"received_events_url": "https://api.github.com/users/Mascobot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-07T05:30:44 | 2022-12-30T01:57:28 | 2022-12-30T01:57:28 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | File ~/anaconda3/envs/hh/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_label.py:179, in _vad_frame_seq_collate_fn(self, batch)
177 start = torch.zeros(append_len_start)
178 end = torch.zeros(append_len_end)
--> 179 sig = torch.cat((start, sig, end))
180 sig_len += slice_length
182 if has_audio:
RuntimeError: Tensors must have same number of dimensions: got 1 and 2
Is anyone else seeing this error?
I am using the Pytorch version = 1.13.0 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5335/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5335/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5334 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5334/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5334/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5334/events | https://github.com/NVIDIA/NeMo/issues/5334 | 1,437,787,899 | I_kwDOC_bI7s5Vsub7 | 5,334 | RuntimeError Tensors must have same number of dimensions: got 1 and 2 | {
"login": "Mascobot",
"id": 5958899,
"node_id": "MDQ6VXNlcjU5NTg4OTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5958899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Mascobot",
"html_url": "https://github.com/Mascobot",
"followers_url": "https://api.github.com/users/Mascobot/followers",
"following_url": "https://api.github.com/users/Mascobot/following{/other_user}",
"gists_url": "https://api.github.com/users/Mascobot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Mascobot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mascobot/subscriptions",
"organizations_url": "https://api.github.com/users/Mascobot/orgs",
"repos_url": "https://api.github.com/users/Mascobot/repos",
"events_url": "https://api.github.com/users/Mascobot/events{/privacy}",
"received_events_url": "https://api.github.com/users/Mascobot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-11-07T05:26:36 | 2024-10-04T00:26:58 | 2022-11-07T05:31:30 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | File ~/anaconda3/envs/pyannotate/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_label.py:179, in _vad_frame_seq_collate_fn(self, batch)
177 start = torch.zeros(append_len_start)
178 end = torch.zeros(append_len_end)
--> 179 sig = torch.cat((start, sig, end))
180 sig_len += slice_length
182 if has_audio:
RuntimeError: Tensors must have same number of dimensions: got 1 and 2 | {
"login": "Mascobot",
"id": 5958899,
"node_id": "MDQ6VXNlcjU5NTg4OTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5958899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Mascobot",
"html_url": "https://github.com/Mascobot",
"followers_url": "https://api.github.com/users/Mascobot/followers",
"following_url": "https://api.github.com/users/Mascobot/following{/other_user}",
"gists_url": "https://api.github.com/users/Mascobot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Mascobot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mascobot/subscriptions",
"organizations_url": "https://api.github.com/users/Mascobot/orgs",
"repos_url": "https://api.github.com/users/Mascobot/repos",
"events_url": "https://api.github.com/users/Mascobot/events{/privacy}",
"received_events_url": "https://api.github.com/users/Mascobot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5334/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5334/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5333 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5333/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5333/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5333/events | https://github.com/NVIDIA/NeMo/pull/5333 | 1,437,329,598 | PR_kwDOC_bI7s5CRjm3 | 5,333 | add precommit hood to automatic sort entries in requirements. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-06T09:34:34 | 2022-11-06T17:45:21 | 2022-11-06T17:45:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5333",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5333",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5333.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5333.patch",
"merged_at": "2022-11-06T17:45:18"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
the files changes after running below,
``` bash
$ pre-commit run --all-files
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5333/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5333/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5332 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5332/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5332/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5332/events | https://github.com/NVIDIA/NeMo/pull/5332 | 1,437,321,491 | PR_kwDOC_bI7s5CRiAx | 5,332 | removed uninstall nemo_cv and nemo_simple_gan and relax numba version… | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-06T09:00:28 | 2022-11-22T00:51:45 | 2022-11-08T23:35:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5332",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5332",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5332.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5332.patch",
"merged_at": "2022-11-08T23:35:41"
} |
* removed nemo_cv and nemo_simple_gan in reinstall.sh.
* relaxed numba version limits.
* added tensorboard requirement to avoid any incpmpatible issue.
not quite sure why we should enforce `numba==0.55`. When I run `./reinstall.sh`, I got incompatible env issue below for `tensorboard` and `numba`.
``` bash
(nemo) xueyang@LOCAL:~/workspace/NeMo:(main)$ ./reinstall.sh
Uninstalling stuff
Found existing installation: nemo-toolkit 1.12.0rc0
Uninstalling nemo-toolkit-1.12.0rc0:
Successfully uninstalled nemo-toolkit-1.12.0rc0
Found existing installation: sacrebleu 2.2.1
Uninstalling sacrebleu-2.2.1:
Successfully uninstalled sacrebleu-2.2.1
WARNING: Skipping nemo_asr as it is not installed.
WARNING: Skipping nemo_nlp as it is not installed.
WARNING: Skipping nemo_tts as it is not installed.
WARNING: Skipping nemo_simple_gan as it is not installed.
WARNING: Skipping nemo_cv as it is not installed.
Requirement already satisfied: setuptools in /Users/xueyang/miniconda3/envs/nemo/lib/python3.8/site-packages (65.5.0)
Collecting setuptools
Downloading setuptools-65.5.1-py3-none-any.whl (1.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 12.1 MB/s eta 0:00:00
Installing collected packages: setuptools
Attempting uninstall: setuptools
Found existing installation: setuptools 65.5.0
Uninstalling setuptools-65.5.0:
Successfully uninstalled setuptools-65.5.0
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorboard 2.10.0 requires protobuf<3.20,>=3.9.2, but you have protobuf 3.20.1 which is incompatible.
numba 0.55.0 requires numpy<1.22,>=1.18, but you have numpy 1.23.3 which is incompatible.
```
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5332/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5332/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5331 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5331/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5331/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5331/events | https://github.com/NVIDIA/NeMo/issues/5331 | 1,436,837,126 | I_kwDOC_bI7s5VpGUG | 5,331 | How to do quantization on the ASR model | {
"login": "ifahim",
"id": 1225514,
"node_id": "MDQ6VXNlcjEyMjU1MTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1225514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ifahim",
"html_url": "https://github.com/ifahim",
"followers_url": "https://api.github.com/users/ifahim/followers",
"following_url": "https://api.github.com/users/ifahim/following{/other_user}",
"gists_url": "https://api.github.com/users/ifahim/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ifahim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ifahim/subscriptions",
"organizations_url": "https://api.github.com/users/ifahim/orgs",
"repos_url": "https://api.github.com/users/ifahim/repos",
"events_url": "https://api.github.com/users/ifahim/events{/privacy}",
"received_events_url": "https://api.github.com/users/ifahim/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-11-05T05:35:06 | 2022-11-09T09:22:56 | 2022-11-09T09:22:56 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I am trying to do Post training static quantization on ASR model, following example here: (https://pytorch.org/blog/introduction-to-quantization-on-pytorch/#post-training-static-quantization) but keeps on getting following error.
Two questions:
1) Is there a way to bypass this error and get this working?
2) How to know what is the input shape for "stt_en_conformer_ctc_xlarge" model? Is there any API through which I know the shape?
```
File "asr_ctc.py", line 20, in <module>
print(model.transcribe([audio_filepath], batch_size=1)[0])
---
----
---
NotImplementedError: Could not run 'quantized::conv2d.new' with arguments from the 'CPU' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build process (if using custom build). If you are a Facebook employee using PyTorch on mobile, please visit https://fburl.com/ptmfixes for possible resolutions. 'quantized::conv2d.new' is only available for these backends: [Negative, UNKNOWN_TENSOR_TYPE_ID, QuantizedXPU, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, SparseCPU, SparseCUDA, SparseHIP, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, SparseVE, UNKNOWN_TENSOR_TYPE_ID, NestedTensorCUDA, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID].
```
**Steps/Code to reproduce bug**
```
# Streaming with CTC based models
import torch
import nemo.collections.asr as nemo_asr
device = 'cpu'
model = nemo_asr.models.EncDecCTCModelBPE.from_pretrained("stt_en_conformer_ctc_xlarge", map_location=device)
model = model.to(device)
model.eval()
audio_filepath = './datasets/mini-dev-clean/LibriSpeech/dev-clean-2-processed/2428-83699-0042.wav'
model.qconfig = torch.quantization.get_default_qconfig()
torch.quantization.prepare(model, inplace=True)
torch.quantization.convert(model, inplace=True)
print("The transcribed speech is: ")
print(model.transcribe([audio_filepath], batch_size=1)[0])
```
**Expected behavior**
Expected transcribed output
**Environment overview (please complete the following information)**
- Environment location: [Bare-metal]
- Method of NeMo install: [pip install Nemo].
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- Ubuntu 22.04
- PyTorch = 1.12.1
- Python version = 3.8
**Additional context**
Add any other context about the problem here.
Example: CPU model
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5331/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5331/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5330 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5330/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5330/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5330/events | https://github.com/NVIDIA/NeMo/pull/5330 | 1,436,761,442 | PR_kwDOC_bI7s5CPv4c | 5,330 | Speed up HF data processing script for ASR | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-05T01:19:34 | 2022-11-05T01:20:27 | 2022-11-05T01:20:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5330",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5330",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5330.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5330.patch",
"merged_at": "2022-11-05T01:20:24"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [ASR]
# Changelog
- Add `num_proc` argument to HF to speed up processing
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5330/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5330/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5329 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5329/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5329/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5329/events | https://github.com/NVIDIA/NeMo/pull/5329 | 1,436,741,102 | PR_kwDOC_bI7s5CPr2o | 5,329 | Fixes bugs with loss averaging with `validation_drop_last=False` for Megatron GPT | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-05T00:08:26 | 2022-11-14T23:03:47 | 2022-11-14T23:03:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5329",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5329",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5329.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5329.patch",
"merged_at": "2022-11-14T23:03:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5329/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5329/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5328 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5328/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5328/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5328/events | https://github.com/NVIDIA/NeMo/pull/5328 | 1,436,693,527 | PR_kwDOC_bI7s5CPiFS | 5,328 | typo fix | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T22:18:07 | 2022-11-05T00:46:21 | 2022-11-05T00:46:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5328",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5328",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5328.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5328.patch",
"merged_at": "2022-11-05T00:46:18"
} | Signed-off-by: arendu <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5328/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5328/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5327 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5327/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5327/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5327/events | https://github.com/NVIDIA/NeMo/pull/5327 | 1,436,679,868 | PR_kwDOC_bI7s5CPfLJ | 5,327 | [TTS] update organization of model checkpoints and their pointers. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T21:54:35 | 2022-11-07T18:26:39 | 2022-11-07T18:26:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5327",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5327",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5327.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5327.patch",
"merged_at": "2022-11-07T18:26:26"
} | * added a column pointing correct checkpoint url.
* revised `#Spk` to real numbers.
Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
After the PR, it looks like,
[screenshot](https://drive.google.com/file/d/1ZbRCAZbf7vzuNsjfR5hHnZHHO8Eo373K/view?usp=sharing)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5327/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5327/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5326 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5326/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5326/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5326/events | https://github.com/NVIDIA/NeMo/pull/5326 | 1,436,573,184 | PR_kwDOC_bI7s5CPIPy | 5,326 | [DOC] add sphinx-copybutton requirement to copy button on code snippets. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T19:46:20 | 2022-11-04T20:18:32 | 2022-11-04T20:18:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5326",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5326",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5326.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5326.patch",
"merged_at": "2022-11-04T20:18:29"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5326/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5326/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5325 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5325/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5325/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5325/events | https://github.com/NVIDIA/NeMo/pull/5325 | 1,436,386,518 | PR_kwDOC_bI7s5COgvV | 5,325 | small bugfix for r1.13.0 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-04T17:05:36 | 2022-11-04T22:03:08 | 2022-11-04T22:03:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5325",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5325",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5325.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5325.patch",
"merged_at": "2022-11-04T22:03:05"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: ASR
# Changelog
- typo fix
- transcribe_partial_audio. https://github.com/NVIDIA/NeMo/pull/5253
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5325/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5325/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5324 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5324/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5324/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5324/events | https://github.com/NVIDIA/NeMo/issues/5324 | 1,435,900,464 | I_kwDOC_bI7s5Vlhow | 5,324 | Training interruption | {
"login": "Project-fil",
"id": 82889232,
"node_id": "MDQ6VXNlcjgyODg5MjMy",
"avatar_url": "https://avatars.githubusercontent.com/u/82889232?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Project-fil",
"html_url": "https://github.com/Project-fil",
"followers_url": "https://api.github.com/users/Project-fil/followers",
"following_url": "https://api.github.com/users/Project-fil/following{/other_user}",
"gists_url": "https://api.github.com/users/Project-fil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Project-fil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Project-fil/subscriptions",
"organizations_url": "https://api.github.com/users/Project-fil/orgs",
"repos_url": "https://api.github.com/users/Project-fil/repos",
"events_url": "https://api.github.com/users/Project-fil/events{/privacy}",
"received_events_url": "https://api.github.com/users/Project-fil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-11-04T11:03:17 | 2022-11-15T23:59:39 | 2022-11-15T23:59:39 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Learning starts and then stops at a certain point.
Termination of training without explanation, without logs.
Termination of training without explanation, without logs.
> import nemo
import nemo.collections.asr as nemo_asr
import pytorch_lightning as pl
from nemo.utils.exp_manager import exp_manager
from omegaconf import DictConfig, OmegaConf
> params = OmegaConf.load(model_conf_path)
> min_duration = 0.5
epochs = 15
gpus = 1
lr_optim = 0.001
> params.trainer.devices = gpus
params.trainer.max_epochs = epochs
params.model.optim.lr = lr_optim
params.model.train_ds.manifest_filepath = train_manifest_path
params.model.train_ds.min_duration = min_duration
params.model.validation_ds.manifest_filepath = validation_manifest_path
params.model.test_ds.manifest_filepath = test_manifest_path
params.exp_manager.exp_dir = "/path/to/save_tr_nemo/"
> trainer = pl.Trainer(**params.trainer)
model = nemo_asr.models.EncDecCTCModel(cfg=params.model, trainer=trainer)
exp_manager(trainer=trainer, cfg=params.exp_manager)
> trainer.fit(model)
trainer.test(model)
There is yaml config:
https://github.com/Project-fil/Project-fil/blob/ee79825609cca9e8b01a9c4eb43b564bb5c2b35d/quartznet_ru.yaml
Cuda version: 11.6
Python version: 3.9.12
Torch version: 1.13.0a0+git35563f4
Nemo version: 1.11.0rc0
OS - Ubuntu 20.04.5 LTS
Graphic card - Nvidia A40
What could be wrong?
https://github.com/NVIDIA/NeMo/issues/5324#tasklist-block-cccbe04f-c2c1-4b01-a878-bd03a164bbc4
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5324/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5324/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5323 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5323/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5323/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5323/events | https://github.com/NVIDIA/NeMo/pull/5323 | 1,435,766,393 | PR_kwDOC_bI7s5CMcJj | 5,323 | Force wav file format for audio_filepath | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T09:09:42 | 2022-11-04T09:09:50 | 2022-11-04T09:09:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5323",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5323",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5323.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5323.patch",
"merged_at": "2022-11-04T09:09:47"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Update the manifest filepath name of the audio_filepath
**Collection**: [ASR]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5323/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5323/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5322 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5322/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5322/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5322/events | https://github.com/NVIDIA/NeMo/issues/5322 | 1,435,764,690 | I_kwDOC_bI7s5VlAfS | 5,322 | tutorials/nlp/Information_Retrieval_MSMARCO.ipynb not found | {
"login": "hoangtnm",
"id": 35718590,
"node_id": "MDQ6VXNlcjM1NzE4NTkw",
"avatar_url": "https://avatars.githubusercontent.com/u/35718590?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hoangtnm",
"html_url": "https://github.com/hoangtnm",
"followers_url": "https://api.github.com/users/hoangtnm/followers",
"following_url": "https://api.github.com/users/hoangtnm/following{/other_user}",
"gists_url": "https://api.github.com/users/hoangtnm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hoangtnm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hoangtnm/subscriptions",
"organizations_url": "https://api.github.com/users/hoangtnm/orgs",
"repos_url": "https://api.github.com/users/hoangtnm/repos",
"events_url": "https://api.github.com/users/hoangtnm/events{/privacy}",
"received_events_url": "https://api.github.com/users/hoangtnm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-04T09:08:00 | 2023-11-08T13:33:35 | 2022-12-12T01:59:45 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I'm trying to follow [Information Retrieval document](https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/v1.12.0/nlp/information_retrieval.html), however, the link for its notebook cannot be found. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5322/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5322/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5321 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5321/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5321/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5321/events | https://github.com/NVIDIA/NeMo/pull/5321 | 1,435,688,312 | PR_kwDOC_bI7s5CMLqI | 5,321 | Update librosa signature in HF processing script | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T07:49:36 | 2022-11-04T07:49:50 | 2022-11-04T07:49:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5321",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5321",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5321.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5321.patch",
"merged_at": "2022-11-04T07:49:47"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Fix librosa issue in script
**Collection**: [ASR]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5321/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5321/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5320 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5320/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5320/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5320/events | https://github.com/NVIDIA/NeMo/pull/5320 | 1,435,456,671 | PR_kwDOC_bI7s5CLaTc | 5,320 | Remove onnx graphsurgery from Dockerfile | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T02:21:35 | 2022-11-04T06:11:42 | 2022-11-04T06:11:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5320",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5320",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5320.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5320.patch",
"merged_at": "2022-11-04T06:11:39"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Removes onnx graph surgery from Dockerfile
**Collection**: [Core]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5320/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5320/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5319 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5319/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5319/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5319/events | https://github.com/NVIDIA/NeMo/pull/5319 | 1,435,400,919 | PR_kwDOC_bI7s5CLPD2 | 5,319 | Fixing de-autocast | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-04T00:29:25 | 2022-11-08T02:37:55 | 2022-11-07T23:59:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5319",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5319",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5319.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5319.patch",
"merged_at": "2022-11-07T23:59:47"
} | Signed-off-by: Boris Fomitchev <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5319/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5319/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5318 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5318/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5318/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5318/events | https://github.com/NVIDIA/NeMo/pull/5318 | 1,435,281,185 | PR_kwDOC_bI7s5CK17m | 5,318 | [TTS] expand to support flexible dictionary entry formats in IPAG2P. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-03T21:31:06 | 2022-11-04T21:50:24 | 2022-11-04T21:50:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5318",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5318",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5318.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5318.patch",
"merged_at": "2022-11-04T21:50:21"
} | * expand to support flexible dictionary entry formats in IPAG2P.
* removed unused imports in test.collections.tts
* removed unused imports in nemo.collections.tts.modules
* removed unused imports in nemo_text_processing.text_normalization.zh
* updated unit tests with new cases
* renamed test function names because we only test IPAG2P rather than all classes in the `modules.py`.
Signed-off-by: Xuesong Yang <[email protected]>
```bash
$ pytest --cpu tests/nemo_text_processing/g2p/test_modules.py
A valid `test_data.tar.gz` test archive (10445891B) found in the `/Users/xueyang/workspace/NeMo/tests/.data` folder.
/Users/xueyang/miniconda3/envs/nemo/lib/python3.8/site-packages/torch/utils/tensorboard/__init__.py:4: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
if not hasattr(tensorboard, "__version__") or LooseVersion(
/Users/xueyang/miniconda3/envs/nemo/lib/python3.8/site-packages/torch/utils/tensorboard/__init__.py:6: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
) < LooseVersion("1.15"):
[NeMo W 2022-11-03 19:03:03 optimizers:55] Apex was not found. Using the lamb or fused_adam optimizer will error out.
Setting numba compat : True
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.8.13, pytest-7.1.2, pluggy-1.0.0 -- /Users/xueyang/miniconda3/envs/nemo/bin/python
cachedir: .pytest_cache
rootdir: /Users/xueyang/workspace/NeMo, configfile: setup.cfg
plugins: anyio-3.5.0, hydra-core-1.1.2
collected 13 items
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_normalize_dict_with_phonemes PASSED [ 7%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_normalize_dict_with_graphemes_and_phonemes PASSED [ 15%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call PASSED [ 23%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_with_file_or_object_dict_type PASSED [ 30%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_with_oov_word PASSED [ 38%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_with_oov_func PASSED [ 46%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_with_graphemes_uppercase PASSED [ 53%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_with_graphemes_lowercase PASSED [ 61%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_with_escaped_characters PASSED [ 69%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_instantiate_unsupported_locale PASSED [ 76%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_de_de PASSED [ 84%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_en_us PASSED [ 92%]
tests/nemo_text_processing/g2p/test_modules.py::TestIPAG2P::test_forward_call_es_es PASSED [100%]
===================================================================== slowest durations ======================================================================
(39 durations < 0.005s hidden. Use -vv to show these durations.)
===================================================================== 13 passed in 0.43s =====================================================================
```
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5318/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5318/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5317 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5317/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5317/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5317/events | https://github.com/NVIDIA/NeMo/issues/5317 | 1,435,167,931 | I_kwDOC_bI7s5Viuy7 | 5,317 | ValueError: NeMo ASR collection is not installed. when run ./normalize_with_audio.py | {
"login": "yujunlhz",
"id": 11738510,
"node_id": "MDQ6VXNlcjExNzM4NTEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11738510?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yujunlhz",
"html_url": "https://github.com/yujunlhz",
"followers_url": "https://api.github.com/users/yujunlhz/followers",
"following_url": "https://api.github.com/users/yujunlhz/following{/other_user}",
"gists_url": "https://api.github.com/users/yujunlhz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yujunlhz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yujunlhz/subscriptions",
"organizations_url": "https://api.github.com/users/yujunlhz/orgs",
"repos_url": "https://api.github.com/users/yujunlhz/repos",
"events_url": "https://api.github.com/users/yujunlhz/events{/privacy}",
"received_events_url": "https://api.github.com/users/yujunlhz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-11-03T19:35:16 | 2022-12-25T01:57:49 | 2022-12-25T01:57:49 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | When I run the following command
python ./normalize_with_audio.py --text=" Hold on one second. 429-020" --language=en --n_tagged=10 --cache_dir="cache_dir" --audio_data="./0001_00002.wav" --model="QuartzNet15x5Base-En" --verbose
I always get the error:
Traceback (most recent call last):
File "./normalize_with_audio.py", in <module>
raise ValueError("NeMo ASR collection is not installed.")
ValueError: NeMo ASR collection is not installed.
I have install nemo all
pip install nemo_toolkit[all]
**Environment details**
- OS version CentOS 7
- PyTorch version 1.10.2+cu113
- Python version Python 3.8.0
Thanks
Mark | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5317/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5317/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5316 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5316/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5316/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5316/events | https://github.com/NVIDIA/NeMo/pull/5316 | 1,435,155,249 | PR_kwDOC_bI7s5CKbIn | 5,316 | Add italian model checkpoints | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-03T19:23:01 | 2022-11-04T17:44:26 | 2022-11-04T17:44:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5316",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5316",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5316.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5316.patch",
"merged_at": "2022-11-04T17:44:26"
} | Signed-off-by: Igor Gitman <[email protected]>
# What does this PR do ?
The same as #5315 but based on the release branch.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5316/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5316/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5315 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5315/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5315/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5315/events | https://github.com/NVIDIA/NeMo/pull/5315 | 1,435,049,727 | PR_kwDOC_bI7s5CKEg7 | 5,315 | Add italian model checkpoints | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-03T17:47:20 | 2022-11-03T19:15:16 | 2022-11-03T19:15:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5315",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5315",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5315.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5315.patch",
"merged_at": "2022-11-03T19:15:16"
} | Signed-off-by: Igor Gitman <[email protected]>
# What does this PR do ?
Add italian model checkpoints to be available for download from NGC.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5315/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5315/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5314 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5314/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5314/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5314/events | https://github.com/NVIDIA/NeMo/pull/5314 | 1,434,580,401 | PR_kwDOC_bI7s5CIfNW | 5,314 | [STT] add Ru ASR conformers to models collections | {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-03T12:28:53 | 2022-11-07T13:31:19 | 2022-11-07T13:31:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5314",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5314",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5314.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5314.patch",
"merged_at": null
} | Signed-off-by: Aleksandr Meister [[email protected]](mailto:[email protected])
# What does this PR do ?
Add Ru ASR Conformer-CTC Large and Conformer-Transducer Large to NeMo models collections
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ssh-meister",
"id": 117230141,
"node_id": "U_kgDOBvzKPQ",
"avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssh-meister",
"html_url": "https://github.com/ssh-meister",
"followers_url": "https://api.github.com/users/ssh-meister/followers",
"following_url": "https://api.github.com/users/ssh-meister/following{/other_user}",
"gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions",
"organizations_url": "https://api.github.com/users/ssh-meister/orgs",
"repos_url": "https://api.github.com/users/ssh-meister/repos",
"events_url": "https://api.github.com/users/ssh-meister/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssh-meister/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5314/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5314/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5313 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5313/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5313/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5313/events | https://github.com/NVIDIA/NeMo/pull/5313 | 1,434,562,759 | PR_kwDOC_bI7s5CIbZA | 5,313 | Pcla tutorial fixes | {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-03T12:14:17 | 2022-11-08T00:51:11 | 2022-11-08T00:49:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5313",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5313",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5313.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5313.patch",
"merged_at": "2022-11-08T00:49:05"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5313/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5313/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5312 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5312/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5312/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5312/events | https://github.com/NVIDIA/NeMo/pull/5312 | 1,433,856,710 | PR_kwDOC_bI7s5CGEhq | 5,312 | add RNN-T loss implemented by PyTorch and test code | {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-11-02T22:12:43 | 2022-11-29T02:16:34 | 2022-11-29T02:08:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5312",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5312",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5312.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5312.patch",
"merged_at": "2022-11-29T02:08:59"
} | # What does this PR do ?
Add support for RNN-T loss implemented with PyTorch only that relies on PyTorch auto-grad for gradient computation.
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5312/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5312/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5311 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5311/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5311/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5311/events | https://github.com/NVIDIA/NeMo/pull/5311 | 1,433,783,621 | PR_kwDOC_bI7s5CF0sw | 5,311 | Update path to get_data.py in TTS tutorial | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-02T21:01:28 | 2022-11-02T22:27:08 | 2022-11-02T22:26:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5311",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5311",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5311.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5311.patch",
"merged_at": "2022-11-02T22:26:30"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Fix path to get_data.py since the directory was renamed
**Collection**: TTS
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5311/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5311/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5310 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5310/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5310/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5310/events | https://github.com/NVIDIA/NeMo/pull/5310 | 1,433,750,654 | PR_kwDOC_bI7s5CFtiO | 5,310 | small bugfix for r1.13.0 | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-02T20:30:56 | 2022-11-04T17:05:22 | 2022-11-04T17:04:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5310",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5310",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5310.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5310.patch",
"merged_at": "2022-11-04T17:04:42"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: ASR
# Changelog
- typo fix
- transcribe_partial_audio. https://github.com/NVIDIA/NeMo/pull/5253
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5310/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5310/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5309 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5309/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5309/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5309/events | https://github.com/NVIDIA/NeMo/pull/5309 | 1,433,562,478 | PR_kwDOC_bI7s5CFE0y | 5,309 | Fixes for Conformer-xl export | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-02T17:59:19 | 2022-11-02T20:05:47 | 2022-11-02T20:02:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5309",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5309",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5309.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5309.patch",
"merged_at": "2022-11-02T20:02:27"
} | # What does this PR do ?
Fixes for Conformer-xl model export:
1) Fixes ONNXRT error: Type parameter (Tind) of Optype (Slice) bound to different types (tensor(int32) and tensor(int64) in node (Slice_63).
2) Fixes 'runtime-check' crash on ONNX > 2GB
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5309/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5309/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5308 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5308/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5308/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5308/events | https://github.com/NVIDIA/NeMo/issues/5308 | 1,432,769,281 | I_kwDOC_bI7s5VZlMB | 5,308 | Running Token_Classification-BioMegatron notebook in colab, failed with apex error | {
"login": "guathwa",
"id": 53548997,
"node_id": "MDQ6VXNlcjUzNTQ4OTk3",
"avatar_url": "https://avatars.githubusercontent.com/u/53548997?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guathwa",
"html_url": "https://github.com/guathwa",
"followers_url": "https://api.github.com/users/guathwa/followers",
"following_url": "https://api.github.com/users/guathwa/following{/other_user}",
"gists_url": "https://api.github.com/users/guathwa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guathwa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guathwa/subscriptions",
"organizations_url": "https://api.github.com/users/guathwa/orgs",
"repos_url": "https://api.github.com/users/guathwa/repos",
"events_url": "https://api.github.com/users/guathwa/events{/privacy}",
"received_events_url": "https://api.github.com/users/guathwa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-02T09:15:05 | 2022-12-10T01:57:48 | 2022-12-10T01:57:47 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
01. Running this notebook in colab:
https://github.com/NVIDIA/NeMo/blob/main/tutorials/nlp/Token_Classification-BioMegatron.ipynb
02. encountered apex error. Follow the steps in readme file to install apex, successful.
Additional context:
user = False
home = None
root = None
prefix = None
Successfully installed apex-0.1
Removed build tracker: '/tmp/pip-req-tracker-k560_7qd'
03. continue running the codes and it fail at model training
import apex (this line no error)
model_ner = nemo_nlp.models.TokenClassificationModel(cfg=config.model, trainer=trainer)
error:
[NeMo W 2022-11-02 09:07:02 lm_utils:81] biomegatron345m_biovocab_30k_cased is not in get_pretrained_lm_models_list(include_external=False), will be using AutoModel from HuggingFace.
[NeMo I 2022-11-02 09:07:02 cloud:56] Found existing object /root/.cache/torch/NeMo/NeMo_1.13.0rc0/BioMegatron345m-biovocab-30k-cased/5885010653185bba59bf489ff757bf09/BioMegatron345m-biovocab-30k-cased.nemo.
[NeMo I 2022-11-02 09:07:02 cloud:62] Re-using file from: /root/.cache/torch/NeMo/NeMo_1.13.0rc0/BioMegatron345m-biovocab-30k-cased/5885010653185bba59bf489ff757bf09/BioMegatron345m-biovocab-30k-cased.nemo
[NeMo I 2022-11-02 09:07:02 common:911] Instantiating model from pre-trained checkpoint
[NeMo E 2022-11-02 09:07:07 common:504] Model instantiation failed!
Target class: nemo.collections.nlp.models.language_modeling.megatron_bert_model.MegatronBertModel
Error(s): Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt.
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/nemo/core/classes/common.py", line 483, in from_config_dict
instance = imported_cls(cfg=config, trainer=trainer)
File "/usr/local/lib/python3.7/dist-packages/nemo/collections/nlp/models/language_modeling/megatron_bert_model.py", line 56, in __init__
"Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt."
ImportError: Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt.
---------------------------------------------------------------------------
ImportError Traceback (most recent call last)
[<ipython-input-29-1f0d02a2ff61>](https://localhost:8080/#) in <module>
----> 1 model_ner = nemo_nlp.models.TokenClassificationModel(cfg=config.model, trainer=trainer)
2
3 #ImportError: Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt.
4 #Successfully installed apex-0.1
9 frames
[/usr/local/lib/python3.7/dist-packages/nemo/collections/nlp/models/language_modeling/megatron_bert_model.py](https://localhost:8080/#) in __init__(self, cfg, trainer)
54 if not HAVE_APEX:
55 raise ImportError(
---> 56 "Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt."
57 )
58 super().__init__(cfg, trainer=trainer, no_lm_init=False)
ImportError: Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt.
**Expected behavior**
Model training should be successful.
**Environment overview (please complete the following information)**
running tutorial notebook in colab.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5308/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5308/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5307 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5307/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5307/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5307/events | https://github.com/NVIDIA/NeMo/pull/5307 | 1,432,625,885 | PR_kwDOC_bI7s5CB57a | 5,307 | [TTS] replace obsolete torch_tts unit test marker with run_only_on('CPU') | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-02T07:20:58 | 2022-11-02T19:44:19 | 2022-11-02T19:44:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5307",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5307",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5307.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5307.patch",
"merged_at": "2022-11-02T19:44:15"
} |
Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
* we should remove the legacy unit test marker `torch_tts` and use the common `run_only_on('CPU')` marker. `torch_tts` marker was only used for testing `TTSDataset` on CPU.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5307/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5307/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5306 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5306/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5306/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5306/events | https://github.com/NVIDIA/NeMo/pull/5306 | 1,432,384,758 | PR_kwDOC_bI7s5CBGvp | 5,306 | Add speaker clustering arguments to forward function | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-02T02:41:38 | 2022-11-07T20:59:27 | 2022-11-07T20:59:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5306",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5306",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5306.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5306.patch",
"merged_at": "2022-11-07T20:59:26"
} | Signed-off-by: Taejin Park <[email protected]>
# What does this PR do ?
Move speaker clustering arguments to forward function
Also added scripting option.
Fixed type issues for torch scripting.
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
- Moved tunable parameters to forward function
- removed unnecessary class varialbes
- Moved clustering instance creation to the outside of for loop in speaker_utils.py
# Usage
If you want to export clustering script module, add the following line
`+diarizer.clustering.parameters.export_script_module=True`
```python
python clustering_diarizer/offline_diar_infer.py \
+diarizer.clustering.parameters.export_script_module=True \
diarizer.manifest_filepath=<path to manifest file> \
diarizer.out_dir='demo_output' \
diarizer.speaker_embeddings.parameters.save_embeddings=False \
diarizer.vad.model_path=<pretrained model name or path to .nemo> \
diarizer.speaker_embeddings.model_path=<pretrained speaker embedding model
'name or path to .nemo>
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5306/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5306/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5305 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5305/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5305/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5305/events | https://github.com/NVIDIA/NeMo/pull/5305 | 1,432,301,306 | PR_kwDOC_bI7s5CA1hq | 5,305 | Distributed optimizer support for BERT | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-02T00:53:27 | 2022-11-14T18:53:06 | 2022-11-14T18:53:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5305",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5305",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5305.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5305.patch",
"merged_at": "2022-11-14T18:53:06"
} | # What does this PR do ?
Add support for the distributed Adam optimizer to BERT.
**Collection**: NLP
# Changelog
- Add support for the Apex distributed Adam optimizer to BERT
# Usage
Set the optimizer to `distributed_fused_adam` in the config file:
https://github.com/NVIDIA/NeMo/blob/79a22eaee0813d5a0e4dc82ebd4a43071399c899/examples/nlp/language_modeling/conf/megatron_bert_config.yaml#L118
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
Pinging @shanmugamr1992.
# Additional Information
* Depends on https://github.com/NVIDIA/NeMo/pull/5293.
* BERT distopt support in this PR is basically identical to GPT and T5 distopt support in https://github.com/NVIDIA/NeMo/pull/5236.
| {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5305/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5305/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5304 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5304/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5304/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5304/events | https://github.com/NVIDIA/NeMo/pull/5304 | 1,432,243,749 | PR_kwDOC_bI7s5CApQC | 5,304 | [TTS] bugfix IPAG2P and refactor to remove duplicate process. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-01T23:35:40 | 2022-11-02T21:26:33 | 2022-11-02T20:52:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5304",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5304",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5304.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5304.patch",
"merged_at": "2022-11-02T20:52:58"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
1. fixed a bug for IPAG2P: the returned self.phoneme_dict mismatches between the one obtained from [self.parse_as_cmu_dict](https://github.com/NVIDIA/NeMo/blob/44de3950f0bf2f3e85d7df1a962eb24674f4fa4e/nemo_text_processing/g2p/modules.py#L320) and the one directly updated from a [dict obj](https://github.com/NVIDIA/NeMo/blob/44de3950f0bf2f3e85d7df1a962eb24674f4fa4e/nemo_text_processing/g2p/modules.py#L351). The former will return something like `{..., "WIRE": [["ˈ", "w", "a", "ɪ", "ɚ"], ["ˈ", "w", "a", "ɪ", "ɹ"]], ...}`, while the latter will return like `{..., "WIRE": ["ˈ", "w", "a", "ɪ", "ɚ"], ...}`.
2. refactored to remove duplicate processes for the case when the phoneme dict input is a dict object and for the case when the phoneme dict is a file.
3. added type hints and docstrings for the whole class `IPAG2P`.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5304/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5304/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5303 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5303/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5303/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5303/events | https://github.com/NVIDIA/NeMo/pull/5303 | 1,432,173,708 | PR_kwDOC_bI7s5CAaEw | 5,303 | Fix dialogue tutorial bug | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-11-01T22:16:23 | 2022-11-08T19:41:40 | 2022-11-08T19:41:25 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5303",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5303",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5303.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5303.patch",
"merged_at": "2022-11-08T19:41:25"
} | # What does this PR do ?
Set default value of num_prompt_tokens to 0 for huggingface GPT model (where virtual prompts do not exist).
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5303/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5303/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5302 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5302/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5302/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5302/events | https://github.com/NVIDIA/NeMo/pull/5302 | 1,432,119,329 | PR_kwDOC_bI7s5CAOPA | 5,302 | Upperbound PTL | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-01T21:23:52 | 2022-11-02T02:02:27 | 2022-11-01T23:26:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5302",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5302",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5302.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5302.patch",
"merged_at": "2022-11-01T23:26:23"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
UB PTL until we upgrade to it.
**Collection**: [Core]
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5302/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5302/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5301 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5301/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5301/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5301/events | https://github.com/NVIDIA/NeMo/pull/5301 | 1,432,110,174 | PR_kwDOC_bI7s5CAMO9 | 5,301 | Add ASR Blossoms test | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-01T21:15:03 | 2023-02-23T01:57:04 | 2022-11-10T22:28:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5301",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5301",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5301.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5301.patch",
"merged_at": null
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Starts port of ASR tests to Blossom
**Collection**: [ASR]
# Changelog
- Add asr test
- Add some checks to blossom ci main tests
# Usage
- `/blossom-ci`
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5301/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5301/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5298 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5298/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5298/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5298/events | https://github.com/NVIDIA/NeMo/pull/5298 | 1,431,975,482 | PR_kwDOC_bI7s5B_u3k | 5,298 | [TTS] Replace IPA lambda arguments with locale string | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-01T19:32:58 | 2022-11-03T23:17:51 | 2022-11-03T23:17:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5298",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5298",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5298.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5298.patch",
"merged_at": "2022-11-03T23:17:49"
} | # What does this PR do ?
Currently you cannot configure the IPATokenizer in .yaml config because there is no way to modify the lambda arguments. This PR replaces the lambda arguments with a locale string that maps to the correct behavior, which now just maps to English vs Non-English.
An alternative approach would be to replace the lambda arguments with a new class/interface, but we thought that was too complicated for now. And that having default configurations available that someone can control with just a language/locale string would be nice to have regardless.
**Collection**: [TTS]
# Changelog
- Replace IPA tokenizer lambda arguments with locale string that maps to English vs non-English IPA functions.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5298/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5298/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5297 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5297/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5297/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5297/events | https://github.com/NVIDIA/NeMo/pull/5297 | 1,431,937,037 | PR_kwDOC_bI7s5B_mcH | 5,297 | Fix dialogue tutorial bug | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-01T19:04:02 | 2022-11-01T22:15:59 | 2022-11-01T22:15:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5297",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5297",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5297.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5297.patch",
"merged_at": "2022-11-01T22:15:54"
} | # What does this PR do ?
Set default value of num_prompt_tokens to 0 for huggingface GPT model (where virtual prompts do not exist).
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5297/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5297/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5296 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5296/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5296/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5296/events | https://github.com/NVIDIA/NeMo/pull/5296 | 1,431,812,541 | PR_kwDOC_bI7s5B_K5d | 5,296 | diarization: add configurable parameters for clustering | {
"login": "virajkarandikar",
"id": 16838694,
"node_id": "MDQ6VXNlcjE2ODM4Njk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16838694?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/virajkarandikar",
"html_url": "https://github.com/virajkarandikar",
"followers_url": "https://api.github.com/users/virajkarandikar/followers",
"following_url": "https://api.github.com/users/virajkarandikar/following{/other_user}",
"gists_url": "https://api.github.com/users/virajkarandikar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/virajkarandikar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/virajkarandikar/subscriptions",
"organizations_url": "https://api.github.com/users/virajkarandikar/orgs",
"repos_url": "https://api.github.com/users/virajkarandikar/repos",
"events_url": "https://api.github.com/users/virajkarandikar/events{/privacy}",
"received_events_url": "https://api.github.com/users/virajkarandikar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-11-01T17:33:04 | 2022-11-04T12:05:28 | 2022-11-04T12:05:28 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5296",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5296",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5296.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5296.patch",
"merged_at": null
} | Signed-off-by: Viraj Karandikar <[email protected]>
Changes some of the clustering parameters from init time to run time.
**asr**
# Changelog
- Moves parameters like max_num_speaker, multiscale_weights, sparse_search_volume from init-time to run-time
# Usage
* Used when clustering is exported as torchscript model and some parameters need to be changed runtime.
# Before your PR is "Ready for review"
**Pre checks**:
- [*] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [*] Did you write any new necessary tests? - NA
- [*] Did you add or update any necessary documentation? - NA
- [*] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - No
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [*] New Feature (minor enhancement actually)
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "virajkarandikar",
"id": 16838694,
"node_id": "MDQ6VXNlcjE2ODM4Njk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16838694?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/virajkarandikar",
"html_url": "https://github.com/virajkarandikar",
"followers_url": "https://api.github.com/users/virajkarandikar/followers",
"following_url": "https://api.github.com/users/virajkarandikar/following{/other_user}",
"gists_url": "https://api.github.com/users/virajkarandikar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/virajkarandikar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/virajkarandikar/subscriptions",
"organizations_url": "https://api.github.com/users/virajkarandikar/orgs",
"repos_url": "https://api.github.com/users/virajkarandikar/repos",
"events_url": "https://api.github.com/users/virajkarandikar/events{/privacy}",
"received_events_url": "https://api.github.com/users/virajkarandikar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5296/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5296/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5293 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5293/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5293/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5293/events | https://github.com/NVIDIA/NeMo/pull/5293 | 1,430,622,889 | PR_kwDOC_bI7s5B7MtM | 5,293 | Pipeline paralleism in Bert | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-31T23:24:47 | 2022-11-09T20:57:28 | 2022-11-09T18:29:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5293",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5293",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5293.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5293.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5293/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5293/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5292 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5292/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5292/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5292/events | https://github.com/NVIDIA/NeMo/pull/5292 | 1,430,573,278 | PR_kwDOC_bI7s5B7CML | 5,292 | [Bugfix] Added rm -f / wget- nc command to avoid bash error in multispeaker sim notebook | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-31T22:21:41 | 2022-11-08T19:13:45 | 2022-11-08T19:13:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5292",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5292",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5292.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5292.patch",
"merged_at": "2022-11-08T19:13:45"
} | Signed-off-by: Taejin Park <[email protected]>
# What does this PR do ?
Fix minor bugs in multispeaker simulation tutorial notebook
https://github.com/NVIDIA/NeMo/blob/main/tutorials/tools/Multispeaker_Simulator.ipynb
Bugfix for
https://nvbugswb.nvidia.com/NvBugs5/SWBug.aspx?bugid=3848353
- rm throws out an error if there is no such file
**Collection**: [Note which collection this PR will affect]
# Changelog
added rm -f (try deleting only if file exists)
added wget -nc (no duplication)
# Usage
Please run the tutorial notebook
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
any one in ASR
# Additional Information
* Related to # (issue)
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5292/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5292/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5291 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5291/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5291/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5291/events | https://github.com/NVIDIA/NeMo/pull/5291 | 1,430,178,886 | PR_kwDOC_bI7s5B5srj | 5,291 | PCLA tutorial typo fix | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-31T17:03:03 | 2023-02-21T08:29:25 | 2022-10-31T19:24:55 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5291",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5291",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5291.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5291.patch",
"merged_at": "2022-10-31T19:24:55"
} | Signed-off-by: Matvei Novikov <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5291/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5291/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5290 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5290/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5290/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5290/events | https://github.com/NVIDIA/NeMo/issues/5290 | 1,430,177,764 | I_kwDOC_bI7s5VPsfk | 5,290 | AttributeError: 'dict' object has no attribute '_get_node_flag' | {
"login": "MLDeep16",
"id": 89720138,
"node_id": "MDQ6VXNlcjg5NzIwMTM4",
"avatar_url": "https://avatars.githubusercontent.com/u/89720138?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MLDeep16",
"html_url": "https://github.com/MLDeep16",
"followers_url": "https://api.github.com/users/MLDeep16/followers",
"following_url": "https://api.github.com/users/MLDeep16/following{/other_user}",
"gists_url": "https://api.github.com/users/MLDeep16/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MLDeep16/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MLDeep16/subscriptions",
"organizations_url": "https://api.github.com/users/MLDeep16/orgs",
"repos_url": "https://api.github.com/users/MLDeep16/repos",
"events_url": "https://api.github.com/users/MLDeep16/events{/privacy}",
"received_events_url": "https://api.github.com/users/MLDeep16/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-31T17:02:13 | 2022-11-01T16:51:07 | 2022-11-01T16:51:07 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | root/abc/venv/lib/python3.8/site-packages/omegaconf/omegaconf.py", line 670, in open_dict
prev_state = config._get_node_flag("struct")
AttributeError: 'dict' object has no attribute '_get_node_flag'
Thanks. | {
"login": "MLDeep16",
"id": 89720138,
"node_id": "MDQ6VXNlcjg5NzIwMTM4",
"avatar_url": "https://avatars.githubusercontent.com/u/89720138?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MLDeep16",
"html_url": "https://github.com/MLDeep16",
"followers_url": "https://api.github.com/users/MLDeep16/followers",
"following_url": "https://api.github.com/users/MLDeep16/following{/other_user}",
"gists_url": "https://api.github.com/users/MLDeep16/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MLDeep16/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MLDeep16/subscriptions",
"organizations_url": "https://api.github.com/users/MLDeep16/orgs",
"repos_url": "https://api.github.com/users/MLDeep16/repos",
"events_url": "https://api.github.com/users/MLDeep16/events{/privacy}",
"received_events_url": "https://api.github.com/users/MLDeep16/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5290/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5290/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5289 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5289/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5289/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5289/events | https://github.com/NVIDIA/NeMo/issues/5289 | 1,430,139,285 | I_kwDOC_bI7s5VPjGV | 5,289 | transcribe() outputting different results than validate() | {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-31T16:35:04 | 2022-11-02T08:21:12 | 2022-11-02T08:21:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I have fine-tuned the German Conformer Transducer on a subset of Mozilla Common Voice. The WER on the validation set decreases throughout the 20 training epochs. However, when I load the checkpoint and use the `transcribe` method, the model outputs weird predictions containing `??`. For example:
```
' ⁇ un müssen meines ⁇ rachtens konkrete und erkennbare ⁇ aßnahmen ergriffen werden ⁇ '
```
This does not occur when I use the pre-trained model offered by Nvidia. Only when I use the one I have fine-tuned myself. I have run another validation loop with the same checkpoint, and the WER is lower than for the model that is not fine-tuned.
I assume that there must be a difference between these two methods (`validate` and `transcribe`) that makes one work but not the other. Do you have any clue as to why this is? | {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5289/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5289/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5288 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5288/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5288/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5288/events | https://github.com/NVIDIA/NeMo/pull/5288 | 1,429,947,740 | PR_kwDOC_bI7s5B47iY | 5,288 | PCLA tutorial typo fix | {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-31T14:32:28 | 2022-10-31T17:02:27 | 2022-10-31T17:02:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5288",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5288",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5288.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5288.patch",
"merged_at": "2022-10-31T17:02:27"
} | Signed-off-by: Matvei Novikov <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5288/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5288/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5285 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5285/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5285/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5285/events | https://github.com/NVIDIA/NeMo/issues/5285 | 1,428,844,171 | I_kwDOC_bI7s5VKm6L | 5,285 | How to get asr result of audio with offset and duration | {
"login": "WangHelin1997",
"id": 49939413,
"node_id": "MDQ6VXNlcjQ5OTM5NDEz",
"avatar_url": "https://avatars.githubusercontent.com/u/49939413?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/WangHelin1997",
"html_url": "https://github.com/WangHelin1997",
"followers_url": "https://api.github.com/users/WangHelin1997/followers",
"following_url": "https://api.github.com/users/WangHelin1997/following{/other_user}",
"gists_url": "https://api.github.com/users/WangHelin1997/gists{/gist_id}",
"starred_url": "https://api.github.com/users/WangHelin1997/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WangHelin1997/subscriptions",
"organizations_url": "https://api.github.com/users/WangHelin1997/orgs",
"repos_url": "https://api.github.com/users/WangHelin1997/repos",
"events_url": "https://api.github.com/users/WangHelin1997/events{/privacy}",
"received_events_url": "https://api.github.com/users/WangHelin1997/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-30T14:58:55 | 2022-10-30T17:26:38 | 2022-10-30T17:26:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
I want to test an audio file that has a specific offset and duraion, how can I do this?
For example, I want to test from 20s to 40s. The below scripts can only give me the result of the whole audio.
```
import nemo
import nemo.collections.asr as nemo_asr
quartznet = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name="QuartzNet15x5Base-En")
files = [os.path.join(data_dir, 'an4/wav/an4_clstk/mgah/cen2-mgah-b.wav')]
for fname, transcription in zip(files, quartznet.transcribe(paths2audio_files=files)):
print(f"Audio in {fname} was recognized as: {transcription}")
``` | {
"login": "WangHelin1997",
"id": 49939413,
"node_id": "MDQ6VXNlcjQ5OTM5NDEz",
"avatar_url": "https://avatars.githubusercontent.com/u/49939413?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/WangHelin1997",
"html_url": "https://github.com/WangHelin1997",
"followers_url": "https://api.github.com/users/WangHelin1997/followers",
"following_url": "https://api.github.com/users/WangHelin1997/following{/other_user}",
"gists_url": "https://api.github.com/users/WangHelin1997/gists{/gist_id}",
"starred_url": "https://api.github.com/users/WangHelin1997/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WangHelin1997/subscriptions",
"organizations_url": "https://api.github.com/users/WangHelin1997/orgs",
"repos_url": "https://api.github.com/users/WangHelin1997/repos",
"events_url": "https://api.github.com/users/WangHelin1997/events{/privacy}",
"received_events_url": "https://api.github.com/users/WangHelin1997/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5285/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5285/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5282 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5282/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5282/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5282/events | https://github.com/NVIDIA/NeMo/issues/5282 | 1,428,651,509 | I_kwDOC_bI7s5VJ331 | 5,282 | Install error | {
"login": "kinfey",
"id": 93169410,
"node_id": "U_kgDOBY2nAg",
"avatar_url": "https://avatars.githubusercontent.com/u/93169410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kinfey",
"html_url": "https://github.com/kinfey",
"followers_url": "https://api.github.com/users/kinfey/followers",
"following_url": "https://api.github.com/users/kinfey/following{/other_user}",
"gists_url": "https://api.github.com/users/kinfey/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kinfey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kinfey/subscriptions",
"organizations_url": "https://api.github.com/users/kinfey/orgs",
"repos_url": "https://api.github.com/users/kinfey/repos",
"events_url": "https://api.github.com/users/kinfey/events{/privacy}",
"received_events_url": "https://api.github.com/users/kinfey/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-30T07:29:02 | 2022-12-08T01:59:56 | 2022-12-08T01:59:56 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I try to install from gihub repo
but it always show me
command: /anaconda/envs/azureml_py38/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"/NeMo/setup.py'"'"'; __file__='"'"'/NeMo/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
cwd: /mnt/batch/tasks/shared/LS_root/mounts/clusters/k80gpu/code/Users/lokinfey/NeMo/
Complete output (44 lines):
running develop
/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/command/easy_install.py:156: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/mnt/batch/tasks/shared/LS_root/mounts/clusters/k80gpu/code/Users/lokinfey/NeMo/setup.py", line 209, in <module>
setuptools.setup(
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/dist.py", line 984, in run_command
cmd_obj.ensure_finalized()
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/cmd.py", line 107, in ensure_finalized
self.finalize_options()
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/command/develop.py", line 52, in finalize_options
easy_install.finalize_options(self)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 268, in finalize_options
self._expand(
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 1344, in _expand
config_vars = self.get_finalized_command('install').config_vars
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/cmd.py", line 299, in get_finalized_command
cmd_obj.ensure_finalized()
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/cmd.py", line 107, in ensure_finalized
self.finalize_options()
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/command/install.py", line 45, in finalize_options
orig.install.finalize_options(self)
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/command/install.py", line 366, in finalize_options
self.set_undefined_options('build',
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/cmd.py", line 286, in set_undefined_options
src_cmd_obj = self.distribution.get_command_obj(src_cmd)
File "/anaconda/envs/azureml_py38/lib/python3.8/distutils/dist.py", line 857, in get_command_obj
klass = self.get_command_class(command)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/setuptools/dist.py", line 890, in get_command_class
self.cmdclass[command] = cmdclass = ep.load()
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2465, in load
return self.resolve()
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2471, in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'setuptools.command.build'
----------------------------------------
ERROR: Command errored out with exit status 1: /anaconda/envs/azureml_py38/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/mnt/batch/tasks/shared/LS_root/mounts/clusters/k80gpu/code/Users/lokinfey/NeMo/setup.py'"'"'; __file__='"'"'/mnt/batch/tasks/shared/LS_root/mounts/clusters/k80gpu/code/Users/lokinfey/NeMo/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.
can you help me | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5282/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5282/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5281 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5281/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5281/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5281/events | https://github.com/NVIDIA/NeMo/issues/5281 | 1,428,408,581 | I_kwDOC_bI7s5VI8kF | 5,281 | Question about RAM consumption increasing. | {
"login": "isaacvitor",
"id": 7494279,
"node_id": "MDQ6VXNlcjc0OTQyNzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/7494279?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/isaacvitor",
"html_url": "https://github.com/isaacvitor",
"followers_url": "https://api.github.com/users/isaacvitor/followers",
"following_url": "https://api.github.com/users/isaacvitor/following{/other_user}",
"gists_url": "https://api.github.com/users/isaacvitor/gists{/gist_id}",
"starred_url": "https://api.github.com/users/isaacvitor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/isaacvitor/subscriptions",
"organizations_url": "https://api.github.com/users/isaacvitor/orgs",
"repos_url": "https://api.github.com/users/isaacvitor/repos",
"events_url": "https://api.github.com/users/isaacvitor/events{/privacy}",
"received_events_url": "https://api.github.com/users/isaacvitor/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-29T18:59:39 | 2022-10-31T19:20:12 | 2022-10-31T19:20:12 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello everybody.
Forgive me for the stupid question but:
Is expected the RAM consumption to increase or have high usage values?
I've been using a `stt_en_conformer_ctc_large.nemo` in GPU without any problem, to be more specific I'm running two models in two child processes. After every transcription, `torch.cuda.empty_cache()` solve my problems with the GPU cache and so on.
But I noticed when these processes start, the RAM had a significantly increased consumption (basically starting from model size + other things) and increase transcription after transcription.
That is the way I'm loading the models:
```python
asr_model = nemo_asr.models.EncDecCTCModel.restore_from(_model_path)
asr_model.eval()
asr_model = asr_model.to(asr_model.device)
```
Is this normal behavior? Is there anything that I can do to solve it?
Thank you! | {
"login": "isaacvitor",
"id": 7494279,
"node_id": "MDQ6VXNlcjc0OTQyNzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/7494279?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/isaacvitor",
"html_url": "https://github.com/isaacvitor",
"followers_url": "https://api.github.com/users/isaacvitor/followers",
"following_url": "https://api.github.com/users/isaacvitor/following{/other_user}",
"gists_url": "https://api.github.com/users/isaacvitor/gists{/gist_id}",
"starred_url": "https://api.github.com/users/isaacvitor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/isaacvitor/subscriptions",
"organizations_url": "https://api.github.com/users/isaacvitor/orgs",
"repos_url": "https://api.github.com/users/isaacvitor/repos",
"events_url": "https://api.github.com/users/isaacvitor/events{/privacy}",
"received_events_url": "https://api.github.com/users/isaacvitor/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5281/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5281/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5280 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5280/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5280/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5280/events | https://github.com/NVIDIA/NeMo/pull/5280 | 1,428,006,303 | PR_kwDOC_bI7s5Byhav | 5,280 | Fix bug into Dialogue tutorial | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-29T01:26:25 | 2022-10-29T01:47:56 | 2022-10-29T01:47:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5280",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5280",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5280.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5280.patch",
"merged_at": "2022-10-29T01:47:53"
} | # What does this PR do ?
set find_unused_parameters=True to overcome RuntimeError of unused pooler layer for BERT model.
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5280/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5280/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5279 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5279/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5279/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5279/events | https://github.com/NVIDIA/NeMo/pull/5279 | 1,427,952,433 | PR_kwDOC_bI7s5ByWK5 | 5,279 | Add cpWER for evaluation of ASR with diarization | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T23:27:33 | 2022-11-19T00:53:55 | 2022-11-12T01:33:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5279",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5279",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5279.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5279.patch",
"merged_at": "2022-11-12T01:33:06"
} | # What does this PR do ?
This PR adds `cpWER` calculation feature to diarization-ASR pipeline.
`WDER` features are removed from `diarization_utils.py` to keep the code simple.
Additionally, docstrings are added to the functions in `diarization_utils.py`
From this PR on, NeMo multispeaker ASR or ASR-with-diarization will be evaluated by cpWER.
To evaluate cpWER value, corresponding CTM files are needed.
All diarization related evaluation (DER, cpWER) is now included in collections/utils/metric/der.py.
This is for reusability of the diarization evaluation code
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
- Added functions regarding `cpWER` calculation
- Added docstings in `diarization_utils.py`
- Changed variable names:
`total_riva_dict` -> `trans_info_dict`,
`riva_dict` -> `session_trans_dict`,
- Removed functions and imports regarding `WDER` and word-timestamp calculation.
- DER, cpWER are now included in collections/utils/metric/der.py.
# Usage
* You can potentially add a usage example below
```python
python offline_diar_with_asr_infer.py \
diarizer.manifest_filepath=<path to manifest file> \
diarizer.out_dir='demo_asr_output' \
diarizer.speaker_embeddings.model_path=<pretrained model name or path to .nemo> \
diarizer.asr.model_path=<pretrained model name or path to .nemo> \
diarizer.speaker_embeddings.parameters.save_embeddings=False \
diarizer.asr.parameters.asr_based_vad=True \
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5279/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5279/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5278 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5278/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5278/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5278/events | https://github.com/NVIDIA/NeMo/pull/5278 | 1,427,928,257 | PR_kwDOC_bI7s5ByQ0p | 5,278 | add label inference support to EncDecSpeakerLabel class | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T22:48:41 | 2022-11-07T17:30:50 | 2022-11-02T20:51:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5278",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5278",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5278.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5278.patch",
"merged_at": "2022-11-02T20:51:02"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Add label inference support for EncDecSpeakerLabel models
**Collection**: ASR
# Changelog
- Add new `infer_file` function which returns both logits and embeddings
- update existing `get_embedding` function to use `infer_file`
- add new `get_label` function that returns label automatically (based on trained model labels)
- update existing speaker inference scripts to use these functions
# Usage
* For getting label (for eg: langid)
```python
from nemo.collections.asr.models import EncDecSpeakerLabelModel
model = EncDecSpeakerLabelModel.from_pretrained('langid_ambernet')
lang = model.get_label(<path_to_audio_file>)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5278/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5278/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5277 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5277/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5277/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5277/events | https://github.com/NVIDIA/NeMo/pull/5277 | 1,427,904,477 | PR_kwDOC_bI7s5ByLrb | 5,277 | Fix bug into Dialogue tutorial | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T22:15:30 | 2022-10-29T01:26:00 | 2022-10-29T01:25:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5277",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5277",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5277.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5277.patch",
"merged_at": "2022-10-29T01:25:52"
} | # What does this PR do ?
set find_unused_parameters=True to overcome RuntimeError of unused pooler layer for BERT model.
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5277/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5277/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5276 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5276/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5276/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5276/events | https://github.com/NVIDIA/NeMo/pull/5276 | 1,427,859,942 | PR_kwDOC_bI7s5ByB6u | 5,276 | [TTS] fixed type of filepath and rename openslr. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T21:32:48 | 2022-10-29T19:23:28 | 2022-10-29T19:23:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5276",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5276",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5276.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5276.patch",
"merged_at": "2022-10-29T19:23:25"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
* rename openslr directory to openslr_95 for disambiguation.
* fixed wrong type of filepath.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5276/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5276/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5274 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5274/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5274/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5274/events | https://github.com/NVIDIA/NeMo/pull/5274 | 1,427,585,518 | PR_kwDOC_bI7s5BxF4d | 5,274 | Add SDP documentation | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T17:50:29 | 2022-11-09T19:44:19 | 2022-11-09T19:44:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5274",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5274",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5274.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5274.patch",
"merged_at": "2022-11-09T19:44:13"
} | Signed-off-by: Elena Rastorgueva <[email protected]>
# What does this PR do ?
Adds documentation to Speech Dataset Processor
**Collection**: [Note which collection this PR will affect]
tools/speech_dataset_processor
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5274/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5274/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5273 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5273/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5273/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5273/events | https://github.com/NVIDIA/NeMo/pull/5273 | 1,427,563,249 | PR_kwDOC_bI7s5BxBIz | 5,273 | Pcla tutorial fixes | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-28T17:33:03 | 2022-10-28T22:10:34 | 2022-10-28T22:10:31 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5273",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5273",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5273.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5273.patch",
"merged_at": "2022-10-28T22:10:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5273/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5273/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5272 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5272/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5272/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5272/events | https://github.com/NVIDIA/NeMo/pull/5272 | 1,427,543,834 | PR_kwDOC_bI7s5Bw9CX | 5,272 | Minor typo fixes in TTS tutorial | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-28T17:12:28 | 2022-10-28T18:30:10 | 2022-10-28T18:30:07 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5272",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5272",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5272.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5272.patch",
"merged_at": "2022-10-28T18:30:07"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Fixes some minor typos in the TTS intro tutorial. No code changes.
**Collection**: TTS | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5272/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5272/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5271 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5271/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5271/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5271/events | https://github.com/NVIDIA/NeMo/pull/5271 | 1,427,142,813 | PR_kwDOC_bI7s5Bvn-5 | 5,271 | Pcla tutorial fixes | {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T11:48:12 | 2022-10-28T17:32:32 | 2022-10-28T17:32:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5271",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5271",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5271.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5271.patch",
"merged_at": "2022-10-28T17:32:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5271/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5271/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5270 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5270/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5270/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5270/events | https://github.com/NVIDIA/NeMo/pull/5270 | 1,426,965,441 | PR_kwDOC_bI7s5BvCez | 5,270 | Add Gradio App to ASR Docs | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T09:24:15 | 2022-10-28T22:34:10 | 2022-10-28T22:34:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5270",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5270",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5270.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5270.patch",
"merged_at": "2022-10-28T22:34:03"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Adds a Gradio demo app embedded in the ASR Docs page
**Collection**: [ASR]
# Usage
Visit https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/asr/intro.html after PR merge on main branch
Example -
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5270/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5270/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5269 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5269/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5269/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5269/events | https://github.com/NVIDIA/NeMo/issues/5269 | 1,426,599,228 | I_kwDOC_bI7s5VCC08 | 5,269 | [Speaker Diarization] Confusion Error become worse after fine-tuning titanet-large with chinese data | {
"login": "triumph9989",
"id": 48488138,
"node_id": "MDQ6VXNlcjQ4NDg4MTM4",
"avatar_url": "https://avatars.githubusercontent.com/u/48488138?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/triumph9989",
"html_url": "https://github.com/triumph9989",
"followers_url": "https://api.github.com/users/triumph9989/followers",
"following_url": "https://api.github.com/users/triumph9989/following{/other_user}",
"gists_url": "https://api.github.com/users/triumph9989/gists{/gist_id}",
"starred_url": "https://api.github.com/users/triumph9989/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/triumph9989/subscriptions",
"organizations_url": "https://api.github.com/users/triumph9989/orgs",
"repos_url": "https://api.github.com/users/triumph9989/repos",
"events_url": "https://api.github.com/users/triumph9989/events{/privacy}",
"received_events_url": "https://api.github.com/users/triumph9989/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815561,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTYx",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/help%20wanted",
"name": "help wanted",
"color": "008672",
"default": true,
"description": "Extra attention is needed"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-28T03:24:33 | 2022-12-19T01:54:03 | 2022-12-19T01:54:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi, I used pretrain titanet-large on one audio of Alimeeting_Eval_far (Chinese), and its Confusion Error Rate (CER) is 0.0283
So I think if fine-tune titanet-large with Chinese data (CN-celeb2) it will have a better result.
However, the first result of CER is 0.1473 (learning rate: 1-e4), and the second one is 0.2120 (learning rate: 1-e6)
Do you have some suggestions?
**titanet-finetune.yaml**
```
name: &name "TitaNet-Finetune-cn2-300-30ep-lr1-e5"
sample_rate: &sample_rate 16000
init_from_pretrained_model:
speaker_tasks:
name: 'titanet_large'
include: ["preprocessor","encoder"]
exclude: ["decoder.final"] # Add specific layer names here to exlude or just ["decoder"] if to exclude all of decoder pretrained weights
model:
train_ds:
manifest_filepath: /home/ec5017b/media-lab/nemo/NeMo/examples/speaker_tasks/recognition/data/train.json
sample_rate: 16000
labels: null
batch_size: 64
shuffle: True
is_tarred: False
tarred_audio_filepaths: null
tarred_shard_strategy: "scatter"
augmentor:
speed:
prob: 0.3
sr: *sample_rate
resample_type: 'kaiser_fast'
min_speed_rate: 0.95
max_speed_rate: 1.05
validation_ds:
manifest_filepath: /home/ec5017b/media-lab/nemo/NeMo/examples/speaker_tasks/recognition/data/dev.json
sample_rate: 16000
labels: null
batch_size: 128
shuffle: False
model_defaults:
filters: 1024
repeat: 3
dropout: 0.1
separable: true
se: true
se_context_size: -1
kernel_size_factor: 1.0
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
normalize: "per_feature"
window_size: 0.025
sample_rate: *sample_rate
window_stride: 0.01
window: "hann"
features: &n_mels 80
n_fft: 512
frame_splicing: 1
dither: 0.00001
encoder:
_target_: nemo.collections.asr.modules.ConvASREncoder
feat_in: *n_mels
activation: relu
conv_mask: true
jasper:
- filters: ${model.model_defaults.filters}
repeat: 1
kernel: [3]
stride: [1]
dilation: [1]
dropout: 0.0
residual: false
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: ${model.model_defaults.filters}
repeat: ${model.model_defaults.repeat}
kernel: [7]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: ${model.model_defaults.filters}
repeat: ${model.model_defaults.repeat}
kernel: [11]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: ${model.model_defaults.filters}
repeat: ${model.model_defaults.repeat}
kernel: [15]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: &enc_feat_out 3072
repeat: 1
kernel: [1]
stride: [1]
dilation: [1]
dropout: 0.0
residual: false
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
decoder:
_target_: nemo.collections.asr.modules.SpeakerDecoder
feat_in: *enc_feat_out
num_classes: 299
pool_mode: 'attention'
emb_sizes: 192
angular: True
loss:
scale: 30
margin: 0.2
optim:
name: adamw
lr: 0.0001 #(original titanet-large was trained with 0.08 lr)
weight_decay: 0.0002
# scheduler setup
sched:
name: CosineAnnealing
warmup_ratio: 0.1
min_lr: 0.0
trainer:
devices: 1 # number of gpus (original titanet-large was trained on 4 nodes with 8 gpus each)
max_epochs: 30
max_steps: -1 # computed at runtime if not set
num_nodes: 1
accelerator: gpu
strategy: ddp
deterministic: True
enable_checkpointing: False
logger: False
log_every_n_steps: 1 # Interval of logging.
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
exp_manager:
exp_dir: null
name: *name
create_tensorboard_logger: True
create_checkpoint_callback: True
```
Add any other context about the problem here.
GV100GL [Tesla V100 PCIe 16GB] (rev a1)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5269/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5269/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5268 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5268/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5268/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5268/events | https://github.com/NVIDIA/NeMo/pull/5268 | 1,426,400,590 | PR_kwDOC_bI7s5BtNXd | 5,268 | created | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-28T00:09:05 | 2022-10-28T02:25:10 | 2022-10-28T02:25:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5268",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5268",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5268.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5268.patch",
"merged_at": "2022-10-28T02:25:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Adds the volume loss to CTC models
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
Added the new reduction to the ctc loss class
# Usage
In the config file, set
ctc_reduction: 'mean_volume'
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5268/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5268/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5267 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5267/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5267/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5267/events | https://github.com/NVIDIA/NeMo/pull/5267 | 1,426,389,172 | PR_kwDOC_bI7s5BtLFQ | 5,267 | Fix failing speaker counting for short audio samples | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T23:49:50 | 2022-10-28T18:32:12 | 2022-10-28T18:32:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5267",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5267",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5267.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5267.patch",
"merged_at": "2022-10-28T18:32:09"
} | # What does this PR do ?
From the previous PR (https://github.com/NVIDIA/NeMo/pull/5191/files),
Speaker clustering code is now fully jit-scriptable, but speaker counting algorithm for
short audio sample (less than 40s) was dropped.
In this PR, we are adding `getEnhancedSpeakerCount` function back and now tutorial notebooks are working correctly.
**Collection**: [Note which collection this PR will affect]
# Changelog
- added `getEnhancedSpeakerCount` function back that handles very short audio samples
- checked the python and torch.jit.script modes
# Usage
* You can potentially add a usage example below
```python
python neural_diarizer/multiscale_diar_decoder_infer.py \
diarizer.manifest_filepath=<path to manifest file> \
diarizer.out_dir='demo_output' \
diarizer.speaker_embeddings.parameters.save_embeddings=False \
diarizer.vad.model_path=<pretrained model name or path to .nemo> \
diarizer.speaker_embeddings.model_path=<pretrained speaker embedding model name or path to .nemo> \
diarizer.msdd_model.model_path=<pretrained MSDD model name or path .nemo> \
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5267/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5267/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5266 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5266/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5266/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5266/events | https://github.com/NVIDIA/NeMo/pull/5266 | 1,426,374,384 | PR_kwDOC_bI7s5BtID0 | 5,266 | Minor typo fixes in TTS tutorial | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T23:24:02 | 2022-10-28T17:12:01 | 2022-10-28T17:11:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5266",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5266",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5266.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5266.patch",
"merged_at": "2022-10-28T17:11:56"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Fixes some minor typos in the TTS intro tutorial. No code changes.
**Collection**: TTS | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5266/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5266/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5265 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5265/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5265/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5265/events | https://github.com/NVIDIA/NeMo/pull/5265 | 1,426,351,915 | PR_kwDOC_bI7s5BtDZZ | 5,265 | Text Memmap Parsing Improvements | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T22:48:18 | 2022-11-03T22:33:38 | 2022-11-03T22:33:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5265",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5265",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5265.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5265.patch",
"merged_at": "2022-11-03T22:33:32"
} | # What does this PR do ?
1. Fixed text-memmap issue when boundary (e.g., new-line) is missing from end of file.
2. Added support in custom index building method (determines how to split int data into samples) using `build_index_fn(fn, newline_int)` argument. The method can override default indexing of the file `fn`.
3. Added support in partial sample loading and alternative decoding by overriding `_fetch_sample_from_memmap(self, mdata, i, j)`.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5265/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5265/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5263 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5263/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5263/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5263/events | https://github.com/NVIDIA/NeMo/pull/5263 | 1,426,261,483 | PR_kwDOC_bI7s5BswU3 | 5,263 | Specifying audio signal dropout separately for the Conformer Encoder | {
"login": "shan18",
"id": 12576178,
"node_id": "MDQ6VXNlcjEyNTc2MTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shan18",
"html_url": "https://github.com/shan18",
"followers_url": "https://api.github.com/users/shan18/followers",
"following_url": "https://api.github.com/users/shan18/following{/other_user}",
"gists_url": "https://api.github.com/users/shan18/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shan18/subscriptions",
"organizations_url": "https://api.github.com/users/shan18/orgs",
"repos_url": "https://api.github.com/users/shan18/repos",
"events_url": "https://api.github.com/users/shan18/events{/privacy}",
"received_events_url": "https://api.github.com/users/shan18/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T21:01:28 | 2022-10-28T02:08:25 | 2022-10-28T02:08:24 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5263",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5263",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5263.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5263.patch",
"merged_at": "2022-10-28T02:08:24"
} | # What does this PR do ?
Adds the option to specify the audio signal dropout separately for a conformed encoder.
**Collection**: asr
# Changelog
- Updated the configs using conformed encoder
- Add new dropout_audio parameter in conformer_encoder.py
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the NeMo ASR team.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5263/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5263/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5262 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5262/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5262/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5262/events | https://github.com/NVIDIA/NeMo/pull/5262 | 1,425,954,074 | PR_kwDOC_bI7s5BruFD | 5,262 | [TTS] Create script for processing TTS training audio | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T16:50:40 | 2022-11-17T06:11:29 | 2022-11-17T06:11:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5262",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5262",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5262.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5262.patch",
"merged_at": "2022-11-17T06:11:26"
} | Signed-off-by: Ryan <[email protected]>
# What does this PR do ?
Add a script for doing audio preprocessing for TTS training.
**Collection**: [TTS]
# Changelog
- Created a "data" directory under nemo.collections.tts following the same convention as the ASR & NLP code.
- Added data_util class for generic operations like processing training manifest. Not sure of volume normalization should be there, but currently have no better place to put it.
- Added silence trimming implementations using energy and VAD based approaches.
- Added audio_preprocessing script for running the data processing logic over a training manifest, with example config files.
# Usage
```
HYDRA_FULL_ERROR=1 python /home/rlangman/Code/NeMo/scripts/dataset_processing/tts/audio_processing/preprocess_audio.py \
--config-path=/home/rlangman/Code/NeMo/scripts/dataset_processing/tts/audio_processing/config \
--config-name=preprocessing.yaml \
data_base_dir="/home/rlangman/Data/nemo_processing" \
config.num_workers=2 \
config.max_entries=100 \
trim=vad \
trim.device=cuda
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
# Additional Information
I manually tested the silence trimming using the openSLR Spanish data. For the 2 modes the dataset size decreases from:
Energy: 35 hours -> 28.8 hours
VAD: 35 hours -> 22.6 hours
This is because lots of the audio has noise in the long silences at the start and end of files. The VAD can differentiate the noise from speech while energy cannot.
Doing trimming on my workstation with the ~24k utterance dataset takes about 5 minutes with energy and 30 minutes with VAD.
More automated testing might be possible if we add CI tests that use actual audio, but I would leave that for a future PR as we do not yet have guidelines for TTS CI tests. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5262/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5262/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5261 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5261/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5261/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5261/events | https://github.com/NVIDIA/NeMo/pull/5261 | 1,425,918,360 | PR_kwDOC_bI7s5BrmL- | 5,261 | Fix links to speaker identification notebook | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-27T16:28:25 | 2022-10-27T16:28:54 | 2022-10-27T16:28:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5261",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5261",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5261.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5261.patch",
"merged_at": "2022-10-27T16:28:51"
} | # What does this PR do ?
Fixes #5259
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5261/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5261/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5260 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5260/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5260/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5260/events | https://github.com/NVIDIA/NeMo/pull/5260 | 1,425,914,281 | PR_kwDOC_bI7s5BrlTk | 5,260 | Fix links to speaker identification notebook | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T16:25:16 | 2022-10-27T16:27:53 | 2022-10-27T16:27:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5260",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5260",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5260.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5260.patch",
"merged_at": "2022-10-27T16:27:49"
} | # What does this PR do ?
Fixes #5259
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5260/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5260/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5259 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5259/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5259/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5259/events | https://github.com/NVIDIA/NeMo/pull/5259 | 1,425,589,468 | PR_kwDOC_bI7s5Bqe80 | 5,259 | Fix links to speaker identification notebook | {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T12:53:15 | 2022-10-27T16:34:33 | 2022-10-27T16:22:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5259",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5259",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5259.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5259.patch",
"merged_at": null
} | # What does this PR do ?
Fixes #5258
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "SeanNaren",
"id": 6707363,
"node_id": "MDQ6VXNlcjY3MDczNjM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6707363?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeanNaren",
"html_url": "https://github.com/SeanNaren",
"followers_url": "https://api.github.com/users/SeanNaren/followers",
"following_url": "https://api.github.com/users/SeanNaren/following{/other_user}",
"gists_url": "https://api.github.com/users/SeanNaren/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SeanNaren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SeanNaren/subscriptions",
"organizations_url": "https://api.github.com/users/SeanNaren/orgs",
"repos_url": "https://api.github.com/users/SeanNaren/repos",
"events_url": "https://api.github.com/users/SeanNaren/events{/privacy}",
"received_events_url": "https://api.github.com/users/SeanNaren/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5259/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5259/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5258 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5258/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5258/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5258/events | https://github.com/NVIDIA/NeMo/issues/5258 | 1,425,557,221 | I_kwDOC_bI7s5U-Ebl | 5,258 | Link is not working | {
"login": "SatenHarutyunyan",
"id": 21352981,
"node_id": "MDQ6VXNlcjIxMzUyOTgx",
"avatar_url": "https://avatars.githubusercontent.com/u/21352981?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SatenHarutyunyan",
"html_url": "https://github.com/SatenHarutyunyan",
"followers_url": "https://api.github.com/users/SatenHarutyunyan/followers",
"following_url": "https://api.github.com/users/SatenHarutyunyan/following{/other_user}",
"gists_url": "https://api.github.com/users/SatenHarutyunyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SatenHarutyunyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SatenHarutyunyan/subscriptions",
"organizations_url": "https://api.github.com/users/SatenHarutyunyan/orgs",
"repos_url": "https://api.github.com/users/SatenHarutyunyan/repos",
"events_url": "https://api.github.com/users/SatenHarutyunyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/SatenHarutyunyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-10-27T12:29:41 | 2022-10-28T03:01:00 | 2022-10-28T03:01:00 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | there is link that is not working
https://github.com/NVIDIA/NeMo/blob/main/tutorials/speaker_tasks/Speaker_Recognition_Verification.ipynb
link appears in NeMo/examples/speaker_tasks/recognition/speaker_reco.py nad in readmes | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5258/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5258/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5257 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5257/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5257/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5257/events | https://github.com/NVIDIA/NeMo/pull/5257 | 1,425,452,251 | PR_kwDOC_bI7s5BqBZT | 5,257 | Extend English ITN rules for cardinal to support hundreds | {
"login": "lociko",
"id": 24481703,
"node_id": "MDQ6VXNlcjI0NDgxNzAz",
"avatar_url": "https://avatars.githubusercontent.com/u/24481703?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lociko",
"html_url": "https://github.com/lociko",
"followers_url": "https://api.github.com/users/lociko/followers",
"following_url": "https://api.github.com/users/lociko/following{/other_user}",
"gists_url": "https://api.github.com/users/lociko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lociko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lociko/subscriptions",
"organizations_url": "https://api.github.com/users/lociko/orgs",
"repos_url": "https://api.github.com/users/lociko/repos",
"events_url": "https://api.github.com/users/lociko/events{/privacy}",
"received_events_url": "https://api.github.com/users/lociko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T11:05:17 | 2022-11-16T17:03:55 | 2022-11-16T17:03:55 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5257",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5257",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5257.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5257.patch",
"merged_at": null
} | Signed-off-by: Vasyl Spachynskyi <[email protected]>
# What does this PR do ?
Extend ITN rules for English (cardinals) to support hundreds, like:
- eleven hundred -> 1100
- twenty one hundred -> 2100
- ninety nine hundred and ninety nine -> 9999
**Collection**: [Text Processing]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5257/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5257/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5256 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5256/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5256/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5256/events | https://github.com/NVIDIA/NeMo/issues/5256 | 1,425,314,007 | I_kwDOC_bI7s5U9JDX | 5,256 | Issue with english WFST inverse text normalizer and "per cent" | {
"login": "laphang",
"id": 24724502,
"node_id": "MDQ6VXNlcjI0NzI0NTAy",
"avatar_url": "https://avatars.githubusercontent.com/u/24724502?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laphang",
"html_url": "https://github.com/laphang",
"followers_url": "https://api.github.com/users/laphang/followers",
"following_url": "https://api.github.com/users/laphang/following{/other_user}",
"gists_url": "https://api.github.com/users/laphang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laphang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laphang/subscriptions",
"organizations_url": "https://api.github.com/users/laphang/orgs",
"repos_url": "https://api.github.com/users/laphang/repos",
"events_url": "https://api.github.com/users/laphang/events{/privacy}",
"received_events_url": "https://api.github.com/users/laphang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4910680898,
"node_id": "LA_kwDOC_bI7s8AAAABJLMLQg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TN/ITN",
"name": "TN/ITN",
"color": "0052cc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-10-27T09:22:45 | 2023-01-27T01:59:06 | 2023-01-27T01:59:06 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
The english WFST inverse text normalizer fails to correctly tag "per cent".
**Steps/Code to reproduce bug**
```
from nemo_text_processing.inverse_text_normalization.inverse_normalize import InverseNormalizer
inverse_normalizer = InverseNormalizer(lang='en')
spoken = "The share price of BHP increased by eleven per cent"
un_normalized = inverse_normalizer.inverse_normalize(spoken, verbose=False)
print(un_normalized)
```
**Expected behavior**
I expect "The share price of BHP increased by 11 %".
The actual output behavior is an unchanged input - "The share price of BHP increased by eleven per cent"
NB: If I change the input to "... per cents", then I do get the expected output. There's an issue with how the plural / singular forms are handled in this case
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5256/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5256/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5255 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5255/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5255/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5255/events | https://github.com/NVIDIA/NeMo/pull/5255 | 1,424,918,261 | PR_kwDOC_bI7s5BoQEA | 5,255 | Update ASR Scores and Results | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-27T02:07:03 | 2022-10-27T02:07:46 | 2022-10-27T02:07:42 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5255",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5255",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5255.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5255.patch",
"merged_at": "2022-10-27T02:07:42"
} | # What does this PR do ?
Updates new models, results and configs
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5255/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5255/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5254 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5254/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5254/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5254/events | https://github.com/NVIDIA/NeMo/pull/5254 | 1,424,917,526 | PR_kwDOC_bI7s5BoP6U | 5,254 | Update ASR Scores and Results | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-27T02:05:40 | 2022-10-27T02:06:40 | 2022-10-27T02:06:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5254",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5254",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5254.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5254.patch",
"merged_at": "2022-10-27T02:06:35"
} | # What does this PR do ?
Updates new models, results and configs
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5254/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5254/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5253 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5253/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5253/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5253/events | https://github.com/NVIDIA/NeMo/pull/5253 | 1,424,807,009 | PR_kwDOC_bI7s5Bn4cS | 5,253 | fix hypotheses return | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-26T23:19:52 | 2022-10-26T23:46:30 | 2022-10-26T23:46:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5253",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5253",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5253.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5253.patch",
"merged_at": "2022-10-26T23:46:27"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Fix issue with transcriptions type
**Collection**: ASR
# Changelog
- Add return_hypothesis to stay consistent with rest of asr models for partial audio transcribe
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5253/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5253/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5252 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5252/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5252/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5252/events | https://github.com/NVIDIA/NeMo/pull/5252 | 1,424,798,741 | PR_kwDOC_bI7s5Bn2rK | 5,252 | [DO NOT MERGE] Add zarr as a dependency | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-26T23:05:34 | 2022-10-28T09:00:24 | 2022-10-26T23:47:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5252",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5252",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5252.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5252.patch",
"merged_at": null
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Check if zarr library has any contraindications with other libraries
**Collection**: [Core]
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5252/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5252/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5251 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5251/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5251/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5251/events | https://github.com/NVIDIA/NeMo/pull/5251 | 1,424,372,706 | PR_kwDOC_bI7s5BmZgh | 5,251 | Fix link to inference notebook | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-10-26T16:53:04 | 2022-10-26T17:57:32 | 2022-10-26T17:57:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5251",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5251",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5251.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5251.patch",
"merged_at": "2022-10-26T17:57:28"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Fixes the Inference_ModelSelect notebook link in the NeMo TTS Primer notebook.
**Collection**: TTS
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5251/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5251/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5250 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5250/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5250/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5250/events | https://github.com/NVIDIA/NeMo/issues/5250 | 1,423,682,584 | I_kwDOC_bI7s5U26wY | 5,250 | Floating point exception | {
"login": "Sasha-Bachynskyi",
"id": 93126453,
"node_id": "U_kgDOBYz_NQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93126453?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sasha-Bachynskyi",
"html_url": "https://github.com/Sasha-Bachynskyi",
"followers_url": "https://api.github.com/users/Sasha-Bachynskyi/followers",
"following_url": "https://api.github.com/users/Sasha-Bachynskyi/following{/other_user}",
"gists_url": "https://api.github.com/users/Sasha-Bachynskyi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sasha-Bachynskyi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sasha-Bachynskyi/subscriptions",
"organizations_url": "https://api.github.com/users/Sasha-Bachynskyi/orgs",
"repos_url": "https://api.github.com/users/Sasha-Bachynskyi/repos",
"events_url": "https://api.github.com/users/Sasha-Bachynskyi/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sasha-Bachynskyi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-10-26T09:04:24 | 2022-11-08T13:37:16 | 2022-11-08T13:37:16 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I installed all necessary dependencies and Nemo, but I got an issue when I tried to transcribe or diarize using Nemo
The exception is: **Floating point exception**, without any stacktrace, just this message
This exception occurred when the Nemo model was initialized
Dependencies:
> Cuda version: 11.2
> Python version: 3.8.10
> Torch version: 1.12.0+cu113
> Nemo version: 1.12.0 (I followed the steps for PIP in the readme)
> OS - Ubuntu 20.04.5 LTS
> Graphic card - Nvidia A40
I tried to use lower versions of PyTorch, it didn't help though.
Usage of PyTorch 1.9.0+cu111 and lower caused another exception: **OSError: libtorch_hip.so: cannot open shared object file**
I found a few topics where developers faced this issue and I even tried to fix it, but without success
If anyone knows how to handle this exception, I will appreciate any help in advance.
| {
"login": "Sasha-Bachynskyi",
"id": 93126453,
"node_id": "U_kgDOBYz_NQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93126453?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sasha-Bachynskyi",
"html_url": "https://github.com/Sasha-Bachynskyi",
"followers_url": "https://api.github.com/users/Sasha-Bachynskyi/followers",
"following_url": "https://api.github.com/users/Sasha-Bachynskyi/following{/other_user}",
"gists_url": "https://api.github.com/users/Sasha-Bachynskyi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sasha-Bachynskyi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sasha-Bachynskyi/subscriptions",
"organizations_url": "https://api.github.com/users/Sasha-Bachynskyi/orgs",
"repos_url": "https://api.github.com/users/Sasha-Bachynskyi/repos",
"events_url": "https://api.github.com/users/Sasha-Bachynskyi/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sasha-Bachynskyi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5250/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5250/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5249 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5249/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5249/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5249/events | https://github.com/NVIDIA/NeMo/issues/5249 | 1,423,550,273 | I_kwDOC_bI7s5U2adB | 5,249 | [ASR_with_SpeakerDiarization] Fine-Tuned TinaNet predicts only one speaker | {
"login": "Klassikcat",
"id": 67917719,
"node_id": "MDQ6VXNlcjY3OTE3NzE5",
"avatar_url": "https://avatars.githubusercontent.com/u/67917719?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Klassikcat",
"html_url": "https://github.com/Klassikcat",
"followers_url": "https://api.github.com/users/Klassikcat/followers",
"following_url": "https://api.github.com/users/Klassikcat/following{/other_user}",
"gists_url": "https://api.github.com/users/Klassikcat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Klassikcat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Klassikcat/subscriptions",
"organizations_url": "https://api.github.com/users/Klassikcat/orgs",
"repos_url": "https://api.github.com/users/Klassikcat/repos",
"events_url": "https://api.github.com/users/Klassikcat/events{/privacy}",
"received_events_url": "https://api.github.com/users/Klassikcat/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-10-26T07:16:56 | 2023-03-08T10:37:11 | 2022-10-28T11:26:57 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I've fine-tuned TitaNet-Large model 10 Epoch for Korean with 1,000,000 datas and 60 speaker dataset because NGC TitaNet(for English) only predict one token. I've checked loss has decreased not only in training step, but also in validation step(min loss was 0.0079).
However, the fine-tuned model only predict one token, <speaker 0>:
```
{'sample': ['1.8 2.16 speaker_0',
'2.32 2.52 speaker_0',
'2.92 3.4 speaker_0',
'4.16 5.0 speaker_0',
'7.44 8.08 speaker_0',
'8.88 9.16 speaker_0',
'9.48 9.84 speaker_0',
'12.76 13.08 speaker_0',
'13.48 13.68 speaker_0',
'14.76 15.24 speaker_0',
'15.8 16.400000000000002 speaker_0',
'16.88 17.04 speaker_0',
'17.2 18.24 speaker_0',
'20.4 20.72 speaker_0',
'20.88 21.24 speaker_0',
'25.2 25.68 speaker_0',
...]
```
Since label in the manifest file is integer, it seems it is a label-related issue. But there is a few reasons i can assume.
1. As I expected in the above, it is a label-related issue.
2. 1,000,000 data and 60 speakers are too small for fine-tuning TitaNet
3. There are problems in the Configuration yaml file.
4. The model is overfitted to training data
5. pre-trained Model weight is not initialized
** + Additional Information **
Diarization score is None in the below code(in the ASR_with_SpeakerDiarization.ipynb)
```python
diar_hyp, diar_score = asr_diar_offline.run_diarization(cfg, word_ts_hyp)
```
**Steps/Code to reproduce bug**
### Example of manifest file for training:
`{"audio_filepath":"\/home\/me\/datas\/speaker_tasks\/datas\/1.Training\/original\/call\/2021-12-16\/3544\/A0210-3544M2010-11020010-06897809.wav","label":3544,"offset":0,"duration":1.38}
`
### YAML Configuration for training
```python
cfg:
train_ds:
manifest_filepath: train_speakers.json
sample_rate: 16000
labels:
- 8
- 191
- 236
- 366
- 423
- 432
- 575
- 624
- 776
- 922
- 1053
- 1057
- 1123
- 1136
- 1221
- 1330
- 1347
- 1379
- 1462
- 1553
- 1625
- 1667
- 1718
- 1964
- 1989
- 2062
- 2104
- 2122
- 2131
- 2177
- 2254
- 2357
- 2556
- 2615
- 2662
- 2674
- 2704
- 2758
- 2805
- 2987
- 3007
- 3070
- 3093
- 3159
- 3499
- 3544
- 3548
- 3562
- 3573
- 3580
- 3604
- 3664
- 3715
- 3740
- 3775
- 3791
- 3858
- 3988
- 4055
- 9036
batch_size: 32
shuffle: true
is_tarred: false
tarred_audio_filepaths: null
tarred_shard_strategy: scatter
augmentor:
speed:
prob: 0.3
sr: 16000
resample_type: kaiser_fast
min_speed_rate: 0.95
max_speed_rate: 1.05
validation_ds:
manifest_filepath: eval_speakers.json
sample_rate: 16000
labels: null
batch_size: 32
shuffle: false
model_defaults:
filters: 1024
repeat: 3
dropout: 0.1
separable: true
se: true
se_context_size: -1
kernel_size_factor: 1.0
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
normalize: per_feature
window_size: 0.025
sample_rate: 16000
window_stride: 0.01
window: hann
features: 80
n_fft: 512
frame_splicing: 1
dither: 1.0e-05
spec_augment:
_target_: nemo.collections.asr.modules.SpectrogramAugmentation
freq_masks: 0
freq_width: 4
time_masks: 0
time_width: 0.03
encoder:
_target_: nemo.collections.asr.modules.ConvASREncoder
feat_in: 80
activation: relu
conv_mask: true
jasper:
- filters: 1024
repeat: 1
kernel:
- 3
stride:
- 1
dilation:
- 1
dropout: 0.0
residual: false
separable: true
se: true
se_context_size: -1
- filters: 1024
repeat: 3
kernel:
- 7
stride:
- 1
dilation:
- 1
dropout: 0.1
residual: true
separable: true
se: true
se_context_size: -1
- filters: 1024
repeat: 3
kernel:
- 11
stride:
- 1
dilation:
- 1
dropout: 0.1
residual: true
separable: true
se: true
se_context_size: -1
- filters: 1024
repeat: 3
kernel:
- 15
stride:
- 1
dilation:
- 1
dropout: 0.1
residual: true
separable: true
se: true
se_context_size: -1
- filters: 3072
repeat: 1
kernel:
- 1
stride:
- 1
dilation:
- 1
dropout: 0.0
residual: false
separable: true
se: true
se_context_size: -1
decoder:
_target_: nemo.collections.asr.modules.SpeakerDecoder
feat_in: 3072
num_classes: 60
pool_mode: attention
emb_sizes: 192
angular: false
loss:
scale: 30
margin: 0.2
optim:
name: sgd
lr: 0.006
weight_decay: 0.001
sched:
name: CosineAnnealing
warmup_ratio: 0.1
min_lr: 0.0
target: nemo.collections.asr.models.label_models.EncDecSpeakerLabelModel
nemo_version: 1.12.0
```
### YAML Configuration for prediction
```yaml
# This YAML file is created for all types of offline speaker diarization inference tasks in `<NeMo git root>/example/speaker_tasks/diarization` folder.
# The inference parameters for VAD, speaker embedding extractor, clustering module, MSDD module, ASR decoder are all included in this YAML file.
# All the keys under `diarizer` key (`vad`, `speaker_embeddings`, `clustering`, `msdd_model`, `asr`) can be selectively used for its own purpose and also can be ignored if the module is not used.
# The configurations in this YAML file is suitable for telephone recordings involving 2~8 speakers in a session and may not show the best performance on the other types of acoustic conditions or dialogues.
# An example line in an input manifest file (`.json` format):
# {"audio_filepath": "/path/to/audio_file", "offset": 0, "duration": null, "label": "infer", "text": "-", "num_speakers": null, "rttm_filepath": "/path/to/rttm/file", "uem_filepath": "/path/to/uem/file"}
name: &name "ClusterDiarizer"
num_workers: 4
sample_rate: 16000
batch_size: 64
diarizer:
manifest_filepath: '/home/me/codes/NeMo/input_manifest.json'
out_dir: ???
oracle_vad: False # If True, uses RTTM files provided in the manifest file to get speech activity (VAD) timestamps
collar: 0.25 # Collar value for scoring
ignore_overlap: True # Consider or ignore overlap segments while scoring
vad:
model_path: ??? # .nemo local model path or pretrained VAD model name
external_vad_manifest: null # This option is provided to use external vad and provide its speech activity labels for speaker embeddings extraction. Only one of model_path or external_vad_manifest should be set
parameters: # Tuned parameters for CH109 (using the 11 multi-speaker sessions as dev set)
window_length_in_sec: 0.15 # Window length in sec for VAD context input
shift_length_in_sec: 0.01 # Shift length in sec for generate frame level VAD prediction
smoothing: "median" # False or type of smoothing method (eg: median)
overlap: 0.5 # Overlap ratio for overlapped mean/median smoothing filter
onset: 0.1 # Onset threshold for detecting the beginning and end of a speech
offset: 0.1 # Offset threshold for detecting the end of a speech
pad_onset: 0.1 # Adding durations before each speech segment
pad_offset: 0 # Adding durations after each speech segment
min_duration_on: 0 # Threshold for small non_speech deletion
min_duration_off: 0.2 # Threshold for short speech segment deletion
filter_speech_first: True
speaker_embeddings:
model_path: /'home/insutil/codes/NeMo/nemo_experiments/TitaNet/2022-10-17_19-48-25/checkpoints/TitaNet.nemo' # .nemo local model path or pretrained model name (titanet_large, ecapa_tdnn or speakerverification_speakernet)
parameters:
window_length_in_sec: [1.5,1.25,1.0,0.75,0.5] # Window length(s) in sec (floating-point number). either a number or a list. ex) 1.5 or [1.5,1.0,0.5]
shift_length_in_sec: [0.75,0.625,0.5,0.375,0.25] # Shift length(s) in sec (floating-point number). either a number or a list. ex) 0.75 or [0.75,0.5,0.25]
multiscale_weights: [1,1,1,1,1] # Weight for each scale. should be null (for single scale) or a list matched with window/shift scale count. ex) [0.33,0.33,0.33]
save_embeddings: True # If True, save speaker embeddings in pickle format. This should be True if clustering result is used for other models, such as `msdd_model`.
clustering:
parameters:
oracle_num_speakers: False # If True, use num of speakers value provided in manifest file.
max_num_speakers: 2 # Max number of speakers for each recording. If an oracle number of speakers is passed, this value is ignored.
enhanced_count_thres: 80 # If the number of segments is lower than this number, enhanced speaker counting is activated.
max_rp_threshold: 0.25 # Determines the range of p-value search: 0 < p <= max_rp_threshold.
sparse_search_volume: 30 # The higher the number, the more values will be examined with more time.
maj_vote_spk_count: False # If True, take a majority vote on multiple p-values to estimate the number of speakers.
msdd_model:
model_path: ??? # .nemo local model path or pretrained model name for multiscale diarization decoder (MSDD)
parameters:
use_speaker_model_from_ckpt: True # If True, use speaker embedding model in checkpoint. If False, the provided speaker embedding model in config will be used.
infer_batch_size: 25 # Batch size for MSDD inference.
sigmoid_threshold: [0.7] # Sigmoid threshold for generating binarized speaker labels. The smaller the more generous on detecting overlaps.
seq_eval_mode: False # If True, use oracle number of speaker and evaluate F1 score for the given speaker sequences. Default is False.
split_infer: True # If True, break the input audio clip to short sequences and calculate cluster average embeddings for inference.
diar_window_length: 50 # The length of split short sequence when split_infer is True.
overlap_infer_spk_limit: 5 # If the estimated number of speakers are larger than this number, overlap speech is not estimated.
asr:
model_path: /home/me/codes/NeMo/checkpoints/conformer/Conformer-CTC-BPE.nemo # Provide NGC cloud ASR model name. stt_en_conformer_ctc_* models are recommended for diarization purposes.
parameters:
asr_based_vad: False # if True, speech segmentation for diarization is based on word-timestamps from ASR inference.
asr_based_vad_threshold: 0.05 # Threshold (in sec) that caps the gap between two words when generating VAD timestamps using ASR based VAD.
asr_batch_size: null # Batch size can be dependent on each ASR model. Default batch sizes are applied if set to null.
lenient_overlap_WDER: True # If true, when a word falls into speaker-overlappedregions, consider the word as a correctly diarized word.
decoder_delay_in_sec: null # Native decoder delay. null is recommended to use the default values for each ASR model.
word_ts_anchor_offset: null # Offset to set a reference point from the start of the word. Recommended range of values is [-0.05 0.2].
word_ts_anchor_pos: "start" # Select which part of the word timestamp we want to use. The options are: 'start', 'end', 'mid'.
fix_word_ts_with_VAD: False # Fix the word timestamp using VAD output. You must provide a VAD model to use this feature.
colored_text: False # If True, use colored text to distinguish speakers in the output transcript.
print_time: True # If True, the start and end time of each speaker turn is printed in the output transcript.
break_lines: False # If True, the output transcript breaks the line to fix the line width (default is 90 chars)
ctc_decoder_parameters: # Optional beam search decoder (pyctcdecode)
pretrained_language_model: null # KenLM model file: .arpa model file or .bin binary file.
beam_width: 32
alpha: 0.5
beta: 2.5
realigning_lm_parameters: # Experimental feature
arpa_language_model: null # Provide a KenLM language model in .arpa format.
min_number_of_words: 3 # Min number of words for the left context.
max_number_of_words: 10 # Max number of words for the right context.
logprob_diff_threshold: 1.2 # The threshold for the difference between two log probability values from two hypotheses.
### Training code
```python
from omegaconf import OmegaConf
import pytorch_lightning as pl
try:
from ruamel.yaml import YAML
except ModuleNotFoundError:
from ruamel_yaml import YAML
from nemo.core.config import hydra_runner
from nemo.utils import logging
from nemo.utils.exp_manager import exp_manager
import nemo.collections.asr as nemo_asr
@hydra_runner(config_path="../../model_cards/", config_name='config')
def __main__(cfg):
"""
Train a Speaker embedding model.
Args:
cfg: DictConfig contains model configurations.
"""
logging.info(f"hydra config: {OmegaConf.to_yaml(cfg)}")
trainer = pl.Trainer(**cfg.trainer)
exp_manager(trainer, cfg.get('exp_manager', None))
model = nemo_asr.models.label_models.EncDecSpeakerLabelModel(cfg=cfg)
model.setup_training_data(cfg.model.train_ds)
model.setup_validation_data(cfg.model.validation_ds)
model.setup_test_data(cfg.model.test_ds)
model.maybe_init_from_pretrained_checkpoint(cfg.init_from_pretrained_model)
trainer.fit(model)
if hasattr(cfg.model, 'test_ds') and cfg.model.test_ds.manifest_filepath is not None:
if model.prepare_test(trainer):
trainer.test(model)
```
prediction: Uses ASR_with_SpeakerDiarization.ipynb notebook in tutorials/speaker_tasks
**Expected behavior**
- Predict 2 speaker, <speaker 0> and <speaker 1>
**Environment overview (please complete the following information)**
- location: Bare-metal
- installation method: downloaded source code from repository.
- model ckpt method: downloaded from NGC, fine-tuned in the machine.
**Environment details**
- OS: Ubuntu 20.24
- GPU: Nvidia A40 * 2EA for training, A40 1EA for prediction
- pytorch version: 1.11.0
- CUDA Toolkit version: 11.3
| {
"login": "Klassikcat",
"id": 67917719,
"node_id": "MDQ6VXNlcjY3OTE3NzE5",
"avatar_url": "https://avatars.githubusercontent.com/u/67917719?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Klassikcat",
"html_url": "https://github.com/Klassikcat",
"followers_url": "https://api.github.com/users/Klassikcat/followers",
"following_url": "https://api.github.com/users/Klassikcat/following{/other_user}",
"gists_url": "https://api.github.com/users/Klassikcat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Klassikcat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Klassikcat/subscriptions",
"organizations_url": "https://api.github.com/users/Klassikcat/orgs",
"repos_url": "https://api.github.com/users/Klassikcat/repos",
"events_url": "https://api.github.com/users/Klassikcat/events{/privacy}",
"received_events_url": "https://api.github.com/users/Klassikcat/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5249/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5249/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/5248 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5248/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5248/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5248/events | https://github.com/NVIDIA/NeMo/pull/5248 | 1,423,270,790 | PR_kwDOC_bI7s5Biudi | 5,248 | Modernize RNNT ONNX export and add TS export | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-26T00:41:36 | 2022-10-27T08:20:06 | 2022-10-27T07:01:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5248",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5248",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5248.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5248.patch",
"merged_at": "2022-10-27T07:01:22"
} | # What does this PR do ?
Improve the script for onnx rnnt export and add support for torchscript export of rnnt
**Collection**: [ASR]
# Changelog
- Add support for pretrained checkpoint in onnx export
- Add GPU inference support with `onnxruntime-gpu` installed for RNNT models
- Add support for Torchscript exported RNNT model
- Add support for eval of torchscripted RNNT model on GPU
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5248/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5248/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5247 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5247/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5247/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5247/events | https://github.com/NVIDIA/NeMo/pull/5247 | 1,423,247,124 | PR_kwDOC_bI7s5Bipk7 | 5,247 | Fix link to inference notebook | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-26T00:01:20 | 2022-10-26T16:52:16 | 2022-10-26T16:52:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5247",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5247",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5247.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5247.patch",
"merged_at": "2022-10-26T16:52:13"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Fixes the Inference_ModelSelect notebook link in the NeMo TTS Primer notebook.
**Collection**: TTS
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5247/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5247/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5246 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5246/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5246/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5246/events | https://github.com/NVIDIA/NeMo/pull/5246 | 1,423,244,967 | PR_kwDOC_bI7s5BipIR | 5,246 | O2 style amp for gpt3 ptuning | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | null | 2022-10-25T23:57:27 | 2022-12-10T06:58:55 | 2022-12-10T06:58:54 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5246",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5246",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5246.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5246.patch",
"merged_at": "2022-12-10T06:58:54"
} | 1. Fixes a precision bug for ptuning which improves perf by ~25%
- If model is in bf16, Pytorch autocasting currently unnecessarily casts operations to be in fp16 from bf16, and casts the output back again to bf16
- This fix keeps the precision in bf16, removing many unnecessary casts
2. Implements amp O2 which improves convergence times
- O2 accumulates prompt encoder gradients in fp32 master weights, rather than in bf16 or fp16 currently
(validation loss of GPT3 530b on 7 nodes, O2 (orange) vs baseline (pink))
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5246/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5246/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5243 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5243/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5243/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5243/events | https://github.com/NVIDIA/NeMo/pull/5243 | 1,422,963,454 | PR_kwDOC_bI7s5BhsJC | 5,243 | Option to pad the last validation input sequence if its smaller than the encoder sequence length for MegatronGPT | {
"login": "anmolgupt",
"id": 14880251,
"node_id": "MDQ6VXNlcjE0ODgwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14880251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anmolgupt",
"html_url": "https://github.com/anmolgupt",
"followers_url": "https://api.github.com/users/anmolgupt/followers",
"following_url": "https://api.github.com/users/anmolgupt/following{/other_user}",
"gists_url": "https://api.github.com/users/anmolgupt/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anmolgupt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anmolgupt/subscriptions",
"organizations_url": "https://api.github.com/users/anmolgupt/orgs",
"repos_url": "https://api.github.com/users/anmolgupt/repos",
"events_url": "https://api.github.com/users/anmolgupt/events{/privacy}",
"received_events_url": "https://api.github.com/users/anmolgupt/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-25T19:28:35 | 2022-11-04T22:21:22 | 2022-11-04T22:13:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5243",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5243",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5243.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5243.patch",
"merged_at": "2022-11-04T22:13:05"
} | Option to pad the last validation input sequence if its smaller than the encoder sequence length for MegatronGPT
# What does this PR do ?
If validation_drop_last is set to False, the last input sample from the validation dataset will not be dropped if its smaller than the encode sequence length for MegatronGPT
**Collection**: [Note which collection this PR will affect]
nlp/language_modeling/megatron
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5243/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5243/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/5242 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/5242/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/5242/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/5242/events | https://github.com/NVIDIA/NeMo/pull/5242 | 1,422,791,527 | PR_kwDOC_bI7s5BhHK6 | 5,242 | Fixed the onnx bug in conformer for non-streaming models. | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-10-25T17:02:16 | 2022-10-25T21:52:30 | 2022-10-25T21:52:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/5242",
"html_url": "https://github.com/NVIDIA/NeMo/pull/5242",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/5242.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/5242.patch",
"merged_at": "2022-10-25T21:52:30"
} | Signed-off-by: Vahid <[email protected]>
# What does this PR do ?
Fixes a bug in exporting to ONNX for non-streaming conformer models.
**PR Type**:
- [ ] New Feature
- [x ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/5242/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/5242/timeline | null | null | true |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.