url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/4694 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4694/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4694/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4694/events | https://github.com/NVIDIA/NeMo/pull/4694 | 1,331,172,379 | PR_kwDOC_bI7s48xv4f | 4,694 | Fix bug intent slot classification tokenizer to dialogue | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-08T00:39:07 | 2022-08-08T01:40:27 | 2022-08-08T01:40:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4694",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4694",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4694.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4694.patch",
"merged_at": "2022-08-08T01:40:27"
} | # What does this PR do ?
Fix bug intent slot classification tokenizer to dialogue
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4694/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4694/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4693 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4693/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4693/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4693/events | https://github.com/NVIDIA/NeMo/pull/4693 | 1,331,163,231 | PR_kwDOC_bI7s48xt-R | 4,693 | Fix bug intent slot classification tokenizer to dialogue | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-08T00:14:00 | 2023-02-22T18:42:47 | 2022-08-08T00:39:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4693",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4693",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4693.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4693.patch",
"merged_at": null
} | # What does this PR do ?
Fix bug intent slot classification tokenizer to dialogue
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4693/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4693/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4692 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4692/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4692/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4692/events | https://github.com/NVIDIA/NeMo/pull/4692 | 1,330,890,998 | PR_kwDOC_bI7s48w5UH | 4,692 | Megatron encode function with RPE fix | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-07T02:03:08 | 2022-08-07T16:37:52 | 2022-08-07T16:33:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4692",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4692",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4692.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4692.patch",
"merged_at": "2022-08-07T16:33:15"
} | # What does this PR do ?
Fixes a bug with RPE and encode() in token_level_encoder_decoder.
**Collection**: NLP
# Changelog
- Adds `enc_self_attention_relative_position_bias` to the `self.encoder()` call in `megatron_encoder_decoder.py`
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4692/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4692/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4691 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4691/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4691/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4691/events | https://github.com/NVIDIA/NeMo/pull/4691 | 1,330,768,842 | PR_kwDOC_bI7s48wiKv | 4,691 | Fix typo (cartographic -> catastrophic) | {
"login": "miguelusque",
"id": 26169771,
"node_id": "MDQ6VXNlcjI2MTY5Nzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/26169771?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/miguelusque",
"html_url": "https://github.com/miguelusque",
"followers_url": "https://api.github.com/users/miguelusque/followers",
"following_url": "https://api.github.com/users/miguelusque/following{/other_user}",
"gists_url": "https://api.github.com/users/miguelusque/gists{/gist_id}",
"starred_url": "https://api.github.com/users/miguelusque/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miguelusque/subscriptions",
"organizations_url": "https://api.github.com/users/miguelusque/orgs",
"repos_url": "https://api.github.com/users/miguelusque/repos",
"events_url": "https://api.github.com/users/miguelusque/events{/privacy}",
"received_events_url": "https://api.github.com/users/miguelusque/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-08-06T14:39:17 | 2022-08-10T05:08:11 | 2022-08-10T05:08:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4691",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4691",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4691.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4691.patch",
"merged_at": null
} | Fix #4554. There is a typo. Instead of "cartographic", it should be "catastrophic".
# What does this PR do ?
Fix #4554. There is a typo. Instead of "cartographic", it should be "catastrophic".
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4691/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4691/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4690 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4690/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4690/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4690/events | https://github.com/NVIDIA/NeMo/pull/4690 | 1,330,577,779 | PR_kwDOC_bI7s48v8xB | 4,690 | TTS tokenizers moved to collections.common.tokenizers | {
"login": "AlexGrinch",
"id": 8689095,
"node_id": "MDQ6VXNlcjg2ODkwOTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AlexGrinch",
"html_url": "https://github.com/AlexGrinch",
"followers_url": "https://api.github.com/users/AlexGrinch/followers",
"following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions",
"organizations_url": "https://api.github.com/users/AlexGrinch/orgs",
"repos_url": "https://api.github.com/users/AlexGrinch/repos",
"events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}",
"received_events_url": "https://api.github.com/users/AlexGrinch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T23:48:47 | 2022-08-23T19:56:08 | 2022-08-23T19:56:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4690",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4690",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4690.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4690.patch",
"merged_at": "2022-08-23T19:56:07"
} | # What does this PR do ?
Move TTS tokenizers to collections.common.tokenizers so they can be used in cross-collections pipelines.
For implementing ASR/ST model training which generates samples on-the-fly with TTS, we need to use TTS tokenizers. Moving them to collections.common.tokenizers allows to write a wrapper which allows to use them directly in ASR and NLP datasets. New location also seems more logical as:
1) TTS tokenizers are the only tokenizers located outside of collections.common.tokenizers
2) TTS tokenizers are currently located in collections.tts.torch but the only torch function they use is torch.distributed
Ideally, I would recommend refactoring them around TokenizerSpec in the future to have unified implementation of all tokenizers.
**Collection**: [Note which collection this PR will affect]
collections.tts and collections.common.tokenizers
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "AlexGrinch",
"id": 8689095,
"node_id": "MDQ6VXNlcjg2ODkwOTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AlexGrinch",
"html_url": "https://github.com/AlexGrinch",
"followers_url": "https://api.github.com/users/AlexGrinch/followers",
"following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions",
"organizations_url": "https://api.github.com/users/AlexGrinch/orgs",
"repos_url": "https://api.github.com/users/AlexGrinch/repos",
"events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}",
"received_events_url": "https://api.github.com/users/AlexGrinch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4690/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4690/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4689 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4689/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4689/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4689/events | https://github.com/NVIDIA/NeMo/pull/4689 | 1,330,451,042 | PR_kwDOC_bI7s48vqZC | 4,689 | Prompt Learning Notebook Bug Fix | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T21:54:12 | 2022-08-10T23:52:35 | 2022-08-10T23:39:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4689",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4689",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4689.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4689.patch",
"merged_at": "2022-08-10T23:39:12"
} | Prompt Learning Notebook Bug Fix
Signed-off-by: Virginia Adams <[email protected]>
Adds back ability to handle dataset example dicts directly passed into the .generate method for prompt learning
**Collection**: NLP
# Changelog
- Updated GPTPromptLearningDataset class
- Updated GPTPromptLearningModel class's generate function
- Updated prompt learning unit test
# Usage
```python
test_examples = [
{"taskname": "intent_and_slot", "utterance": "tell me who will win the next presidential election"},
{"taskname": "intent_and_slot", "utterance": "i would like to pickup a veggie sub with a cookie from subway"},
{"taskname": "intent_and_slot", "utterance": "email happy new year to john"},
{"taskname": "intent_and_slot", "utterance": "set the alarm to seven am for work"},
{"taskname": "sentiment", "sentence": "The products have a low salt and fat content ."},
{"taskname": "sentiment", "sentence": "The agreement is valid for four years ."},
{"taskname": "sentiment", "sentence": "Diluted EPS rose to EUR3 .68 from EUR0 .50 ."},
{"taskname": "sentiment", "sentence": "The company is well positioned in Brazil and Uruguay ."},
{"taskname": "sentiment", "sentence": "Profit before taxes decreased by 9 % to EUR 187.8 mn in the first nine months of 2008 , compared to EUR 207.1 mn a year earlier ."},
]
response = model.generate(inputs=test_examples, length_params=None)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4689/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4689/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4687 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4687/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4687/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4687/events | https://github.com/NVIDIA/NeMo/pull/4687 | 1,330,311,364 | PR_kwDOC_bI7s48vPq6 | 4,687 | Adding support for models trained with full context for cache-aware streaming. | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T19:17:51 | 2022-08-22T19:48:36 | 2022-08-22T19:48:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4687",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4687",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4687.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4687.patch",
"merged_at": "2022-08-22T19:48:36"
} | # What does this PR do ?
Adding support for models trained with full context for cache-aware streaming.
**Collection**: ASR
# Changelog
Adding support for models trained with full context for cache-aware streaming.
**PR Type**:
- [x ] New Feature
- [ ] Bugfix
- [ ] Documentation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4687/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4687/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4686 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4686/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4686/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4686/events | https://github.com/NVIDIA/NeMo/pull/4686 | 1,330,256,026 | PR_kwDOC_bI7s48vDJ0 | 4,686 | Data Simulator | {
"login": "chooper1",
"id": 54963573,
"node_id": "MDQ6VXNlcjU0OTYzNTcz",
"avatar_url": "https://avatars.githubusercontent.com/u/54963573?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chooper1",
"html_url": "https://github.com/chooper1",
"followers_url": "https://api.github.com/users/chooper1/followers",
"following_url": "https://api.github.com/users/chooper1/following{/other_user}",
"gists_url": "https://api.github.com/users/chooper1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chooper1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chooper1/subscriptions",
"organizations_url": "https://api.github.com/users/chooper1/orgs",
"repos_url": "https://api.github.com/users/chooper1/repos",
"events_url": "https://api.github.com/users/chooper1/events{/privacy}",
"received_events_url": "https://api.github.com/users/chooper1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T18:32:48 | 2022-08-16T23:55:41 | 2022-08-16T23:55:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4686",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4686",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4686.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4686.patch",
"merged_at": "2022-08-16T23:55:41"
} | # What does this PR do ?
Adds a multispeaker audio session simulator and corresponding documentation and tutorials.
Collections: ASR, Tools
# Changelog
- Adds data simulator
- Adds a manifest_utils file and restructures speaker_utils
- Adds config files for simulating data as well as a tutorial and documentation
# Before your PR is "Ready for review"
**Pre checks**:
- [ x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ x] New Feature
- [ ] Bugfix
- [ x] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4686/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4686/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4685 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4685/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4685/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4685/events | https://github.com/NVIDIA/NeMo/pull/4685 | 1,330,198,293 | PR_kwDOC_bI7s48u2TP | 4,685 | Move trainer calls for ssl models to training and validation steps only | {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T17:37:13 | 2022-08-05T18:33:06 | 2022-08-05T18:33:06 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4685",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4685",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4685.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4685.patch",
"merged_at": "2022-08-05T18:33:06"
} | # What does this PR do ?
Move trainer calls for ssl models to training and validation steps only
**Collection**: ASR | {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4685/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4685/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4684 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4684/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4684/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4684/events | https://github.com/NVIDIA/NeMo/pull/4684 | 1,330,150,545 | PR_kwDOC_bI7s48usBC | 4,684 | [TTS] incremented the version number to 22.08 in tutorials. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T16:43:17 | 2022-08-05T18:41:57 | 2022-08-05T18:41:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4684",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4684",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4684.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4684.patch",
"merged_at": "2022-08-05T18:41:54"
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4684/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4684/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4683 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4683/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4683/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4683/events | https://github.com/NVIDIA/NeMo/pull/4683 | 1,330,015,932 | PR_kwDOC_bI7s48uPMu | 4,683 | [Chinese text normalization]PR for chinese TN part in text_normalization | {
"login": "mzxcpp",
"id": 59506191,
"node_id": "MDQ6VXNlcjU5NTA2MTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/59506191?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mzxcpp",
"html_url": "https://github.com/mzxcpp",
"followers_url": "https://api.github.com/users/mzxcpp/followers",
"following_url": "https://api.github.com/users/mzxcpp/following{/other_user}",
"gists_url": "https://api.github.com/users/mzxcpp/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mzxcpp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mzxcpp/subscriptions",
"organizations_url": "https://api.github.com/users/mzxcpp/orgs",
"repos_url": "https://api.github.com/users/mzxcpp/repos",
"events_url": "https://api.github.com/users/mzxcpp/events{/privacy}",
"received_events_url": "https://api.github.com/users/mzxcpp/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-08-05T14:31:25 | 2022-08-27T03:18:05 | 2022-08-27T03:18:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4683",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4683",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4683.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4683.patch",
"merged_at": null
} | # What does this PR do ?
new PR for previous chinese TN
**Collection**: [NeMo/norm_text_processing/text_normalization]
I think have covered the problems mentioned previously.And I make a new pr to make it clear. | {
"login": "mzxcpp",
"id": 59506191,
"node_id": "MDQ6VXNlcjU5NTA2MTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/59506191?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mzxcpp",
"html_url": "https://github.com/mzxcpp",
"followers_url": "https://api.github.com/users/mzxcpp/followers",
"following_url": "https://api.github.com/users/mzxcpp/following{/other_user}",
"gists_url": "https://api.github.com/users/mzxcpp/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mzxcpp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mzxcpp/subscriptions",
"organizations_url": "https://api.github.com/users/mzxcpp/orgs",
"repos_url": "https://api.github.com/users/mzxcpp/repos",
"events_url": "https://api.github.com/users/mzxcpp/events{/privacy}",
"received_events_url": "https://api.github.com/users/mzxcpp/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4683/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4683/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4682 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4682/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4682/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4682/events | https://github.com/NVIDIA/NeMo/pull/4682 | 1,329,711,519 | PR_kwDOC_bI7s48tMvl | 4,682 | [ASR] Add pretrained ASR models for Croatian | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T09:49:31 | 2022-08-24T04:02:52 | 2022-08-24T04:02:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4682",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4682",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4682.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4682.patch",
"merged_at": "2022-08-24T04:02:52"
} | Signed-off-by: Ante Jukić <[email protected]>
# What does this PR do ?
This PR adds pre-trained models for Croatian.
**Collection**: [ASR]
# Changelog
- updated `PretrainedModelInfo` and docs
- minor (cosmetic) modifications to `checkpoint_averaging.py`
# Usage
Tested with the following
```python
from nemo.collections.asr.models import ASRModel
for type in ['ctc', 'transducer']:
model = ASRModel.from_pretrained(f'stt_hr_conformer_{type}_large', map_location='cpu')
print(f'\nmodel_{type}.summarize()')
print(model.summarize())
print()
```
Pretrained models downloaded from NGC.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4682/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4682/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4681 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4681/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4681/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4681/events | https://github.com/NVIDIA/NeMo/issues/4681 | 1,329,625,866 | I_kwDOC_bI7s5PQHsK | 4,681 | What & where is the .nemo file? | {
"login": "camillebrl",
"id": 69735051,
"node_id": "MDQ6VXNlcjY5NzM1MDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/69735051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/camillebrl",
"html_url": "https://github.com/camillebrl",
"followers_url": "https://api.github.com/users/camillebrl/followers",
"following_url": "https://api.github.com/users/camillebrl/following{/other_user}",
"gists_url": "https://api.github.com/users/camillebrl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/camillebrl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/camillebrl/subscriptions",
"organizations_url": "https://api.github.com/users/camillebrl/orgs",
"repos_url": "https://api.github.com/users/camillebrl/repos",
"events_url": "https://api.github.com/users/camillebrl/events{/privacy}",
"received_events_url": "https://api.github.com/users/camillebrl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T08:32:20 | 2022-08-05T16:35:33 | 2022-08-05T16:35:33 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
I would like to run the train_kenlm.py file but I do not understand all the arguments it requires:
I read the documentation (https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/asr/asr_language_modeling.html and I ran install_beamsearch_decoders.sh as well, so I have the kenlm bin root but I have no idea how to get the root of the .nemo file and what it is about?
Thanks in advance! | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4681/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4681/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4680 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4680/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4680/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4680/events | https://github.com/NVIDIA/NeMo/pull/4680 | 1,329,481,157 | PR_kwDOC_bI7s48sbVc | 4,680 | Data Simulator | {
"login": "chooper1",
"id": 54963573,
"node_id": "MDQ6VXNlcjU0OTYzNTcz",
"avatar_url": "https://avatars.githubusercontent.com/u/54963573?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chooper1",
"html_url": "https://github.com/chooper1",
"followers_url": "https://api.github.com/users/chooper1/followers",
"following_url": "https://api.github.com/users/chooper1/following{/other_user}",
"gists_url": "https://api.github.com/users/chooper1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chooper1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chooper1/subscriptions",
"organizations_url": "https://api.github.com/users/chooper1/orgs",
"repos_url": "https://api.github.com/users/chooper1/repos",
"events_url": "https://api.github.com/users/chooper1/events{/privacy}",
"received_events_url": "https://api.github.com/users/chooper1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-05T05:51:04 | 2022-08-05T18:33:37 | 2022-08-05T18:33:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4680",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4680",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4680.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4680.patch",
"merged_at": null
} | # What does this PR do ?
Adds a multispeaker audio session simulator and corresponding documentation and tutorials.
Collections: ASR, Tools
# Changelog
- Adds data simulator
- Adds a manifest_utils file and restructures speaker_utils
- Adds config files for simulating data as well as a tutorial and documentation
# Before your PR is "Ready for review"
**Pre checks**:
- [ x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ x] New Feature
- [ ] Bugfix
- [ x] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "chooper1",
"id": 54963573,
"node_id": "MDQ6VXNlcjU0OTYzNTcz",
"avatar_url": "https://avatars.githubusercontent.com/u/54963573?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chooper1",
"html_url": "https://github.com/chooper1",
"followers_url": "https://api.github.com/users/chooper1/followers",
"following_url": "https://api.github.com/users/chooper1/following{/other_user}",
"gists_url": "https://api.github.com/users/chooper1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chooper1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chooper1/subscriptions",
"organizations_url": "https://api.github.com/users/chooper1/orgs",
"repos_url": "https://api.github.com/users/chooper1/repos",
"events_url": "https://api.github.com/users/chooper1/events{/privacy}",
"received_events_url": "https://api.github.com/users/chooper1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4680/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4680/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4679 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4679/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4679/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4679/events | https://github.com/NVIDIA/NeMo/pull/4679 | 1,329,210,785 | PR_kwDOC_bI7s48ri2x | 4,679 | [TTS] use consistent spline interpolation for fastpitch and hifigan. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-04T21:52:58 | 2022-08-05T23:33:15 | 2022-08-05T03:45:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4679",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4679",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4679.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4679.patch",
"merged_at": "2022-08-05T03:45:15"
} |
Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
Apply consistent spline interpolation when generating mel-spectrograms for finetuing hifigan.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4679/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4679/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4678 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4678/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4678/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4678/events | https://github.com/NVIDIA/NeMo/pull/4678 | 1,329,199,847 | PR_kwDOC_bI7s48rghh | 4,678 | [Speech Data Explorer] An option to explicitly specify the base dir | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-04T21:37:40 | 2022-08-30T03:32:30 | 2022-08-30T03:32:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4678",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4678",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4678.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4678.patch",
"merged_at": "2022-08-30T03:32:30"
} | [Speech Data Explorer] An option to explicitly specify the base dir for manifests with relative paths
**Collection**: Tools
# Changelog
- Use `args.audio_base_path` instead of `args.manifest`
- If `args.audio_base_path` is not provided (`None`), then default to the location (parent dir) of the manifest
# Usage
```python
python data_explorer.py /path/to/a/modified/manifest.json --audio-base-path /path/to/audio_data
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4678/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4678/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4677 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4677/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4677/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4677/events | https://github.com/NVIDIA/NeMo/pull/4677 | 1,329,106,261 | PR_kwDOC_bI7s48rMif | 4,677 | [TTS] fixed wrong pronunciations for r1.11. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-04T19:47:03 | 2022-08-04T20:49:21 | 2022-08-04T20:48:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4677",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4677",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4677.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4677.patch",
"merged_at": "2022-08-04T20:48:56"
} | # What does this PR do ?
Mirror the bugfix from https://github.com/NVIDIA/NeMo/pull/4669
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4677/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4677/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4676 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4676/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4676/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4676/events | https://github.com/NVIDIA/NeMo/pull/4676 | 1,329,025,459 | PR_kwDOC_bI7s48q78T | 4,676 | Fix Fastpitch Export | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-04T18:23:25 | 2022-08-04T19:25:37 | 2022-08-04T19:25:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4676",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4676",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4676.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4676.patch",
"merged_at": "2022-08-04T19:25:33"
} | # What does this PR do ?
Fix fastpitch export
**Collection**: TTS
# Changelog
- Fix fastpitch export
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4676/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4676/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4675 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4675/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4675/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4675/events | https://github.com/NVIDIA/NeMo/pull/4675 | 1,328,940,235 | PR_kwDOC_bI7s48qpyG | 4,675 | Fix for incorrect batch size issue while decoding | {
"login": "rilango",
"id": 1195618,
"node_id": "MDQ6VXNlcjExOTU2MTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/1195618?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rilango",
"html_url": "https://github.com/rilango",
"followers_url": "https://api.github.com/users/rilango/followers",
"following_url": "https://api.github.com/users/rilango/following{/other_user}",
"gists_url": "https://api.github.com/users/rilango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rilango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rilango/subscriptions",
"organizations_url": "https://api.github.com/users/rilango/orgs",
"repos_url": "https://api.github.com/users/rilango/repos",
"events_url": "https://api.github.com/users/rilango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rilango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-04T17:03:44 | 2022-08-04T22:02:13 | 2022-08-04T22:02:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4675",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4675",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4675.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4675.patch",
"merged_at": "2022-08-04T22:02:13"
} | Fix to incorrect batch size during decoding. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4675/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4675/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4674 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4674/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4674/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4674/events | https://github.com/NVIDIA/NeMo/pull/4674 | 1,328,216,260 | PR_kwDOC_bI7s48oN4a | 4,674 | Pynini dependency fix | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-04T07:51:55 | 2022-08-04T17:03:43 | 2022-08-04T17:03:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4674",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4674",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4674.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4674.patch",
"merged_at": "2022-08-04T17:03:39"
} | # What does this PR do ?
Switching to 2.1.5 pynini version, reverting to pynini install via conda, pip will still be used to Linux systems. Added guard to pytests to skip TN/ITN tests when pynini is not installed.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4674/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4674/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4672 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4672/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4672/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4672/events | https://github.com/NVIDIA/NeMo/pull/4672 | 1,327,888,168 | PR_kwDOC_bI7s48nJyl | 4,672 | upgrade to PTL 1.7 | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T23:34:13 | 2022-08-31T06:35:05 | 2022-08-11T15:20:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4672",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4672",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4672.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4672.patch",
"merged_at": "2022-08-11T15:20:29"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do?
Upgrade PTL version to 1.7.2
**Collection**: All
# Changelog
- Default max_steps is -1 now instead of None
- DDPPlugin has been moved from plugins to strategies and renamed as DDPStrategy -> renamed NLPDDPPlugin to NLPDDPStrategy
- override lightning module trainer property to make it compatible with our existing models, since it's been removed from PTL 1.7
- Following args have been removed from Trainer
> - prepare_data_per_node
> - checkpoint_callback - replaced with enable_checkpointing
> - process_position - now part of TQDMprogressbar callback
> - stochastic_weight_avg - now part of callback
> - flush_logs_every_n_steps
> - weights_summary - replaced with callback
> - terminate_on_nan
> - log_gpu_memory - part of DeviceGPUStats callback
> - Progressbar refresh rate - part of TQDMProgressbar callback
TODO:
- [x] remove Cuda override function, once https://github.com/Lightning-AI/lightning/pull/14128 was released as part of 1.7.2
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [x] Documentation | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4672/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4672/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4671 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4671/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4671/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4671/events | https://github.com/NVIDIA/NeMo/pull/4671 | 1,327,863,173 | PR_kwDOC_bI7s48nEbH | 4,671 | Removed trailing spaces in CI test | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T22:46:20 | 2022-08-04T05:02:54 | 2022-08-04T04:32:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4671",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4671",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4671.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4671.patch",
"merged_at": "2022-08-04T04:32:18"
} | Signed-off-by: Virginia Adams <[email protected]>
The T5 prompt learning CI test had some formatting errors keeping the CI tests from running. This should fix them
Add a one line overview of what this PR aims to accomplish.
**Collection**: NLP
# Changelog
- Updated Jenkins file
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4671/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4671/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4670 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4670/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4670/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4670/events | https://github.com/NVIDIA/NeMo/pull/4670 | 1,327,849,501 | PR_kwDOC_bI7s48nBfr | 4,670 | Remove type annotation | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T22:23:31 | 2022-08-03T23:06:51 | 2022-08-03T23:06:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4670",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4670",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4670.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4670.patch",
"merged_at": null
} | # What does this PR do ?
Remove type annotations in the `calc_length` function since it causes errors when scripting Conformer models.
**Collection**: ASR
This is the error:
```
[NeMo E 2022-08-03 11:47:46 exportable:116] jit.script() failed!\
Variable 'add_pad' is annotated with type float but is being assigned to a value of type Tensor:
File "/Users/allabana/.virtualenvs/meval/lib/python3.8/site-packages/nemo/collections/asr/parts/submodules/subsampling.py", line 149
def calc_length(lengths, padding, kernel_size, stride, ceil_mode, repeat_num=1):
""" Calculates the output length of a Tensor passed through a convolution or max pooling layer"""
add_pad: float = (padding * 2) - kernel_size
~~~~~~~ <--- HERE
one: float = 1.0
for i in range(repeat_num):
```
This is an example usage that causes the error:
```py
pre_trained_model_name = "stt_en_conformer_ctc_small"
model = EncDecCTCModelBPE.from_pretrained(pre_trained_model_name, map_location='cpu')
model.eval()
model.export(f"/tmp/{model._get_name()}.ts", check_trace=True, try_script=True)
```
# Changelog
- Remove type annotations for `add_pad`/`one` in `nemo.collections.asr.parts.submodules.subsampling.calc_length`
- Add type annotations to `calc_length` method args.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4670/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4670/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4669 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4669/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4669/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4669/events | https://github.com/NVIDIA/NeMo/pull/4669 | 1,327,816,209 | PR_kwDOC_bI7s48m6bc | 4,669 | [TTS] fixed wrong pronunciations. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T21:36:26 | 2022-08-04T20:49:20 | 2022-08-04T20:49:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4669",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4669",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4669.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4669.patch",
"merged_at": null
} | Signed-off-by: Xuesong Yang <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4669/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4669/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4668 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4668/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4668/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4668/events | https://github.com/NVIDIA/NeMo/pull/4668 | 1,327,788,457 | PR_kwDOC_bI7s48m0j- | 4,668 | [Add] SLURP models and examples | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T21:02:57 | 2022-10-06T13:11:14 | 2022-10-06T13:11:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4668",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4668",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4668.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4668.patch",
"merged_at": "2022-10-06T13:11:14"
} | The PR adds the new SOTA model we have for intent classification and slot filling for spoken language understanding.
- [x] Copy transformer modules from `nemo.collections.nlp.modules.common` to `nemo.collections.asr.modules`
- [x] Add models, loss and utils to nemo.collection.asr
- [x] Add example scripts for data downloading and processing
- [x] Add example scripts for training and evaluation
- [x] Refactor model to be independent of EncDecCTCBPE
- [x] Refactor to use built-in SmoothedCrossEntropyLoss
- [x] Write README for example
- [x] Upload model checkpoints to NGC and create model cards
- [x] Update Docs and list_available_models()
- [ ] Create tutorial. // Plan to add in later PR
The NGC model card is [here](https://ngc.nvidia.com/models/nvstaging:nemo:slu_conformer_transformer_large_slurp)
The HF model card is [here](https://huggingface.co/nvidia/slu_conformer_transformer_large_slurp) | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4668/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4668/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4667 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4667/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4667/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4667/events | https://github.com/NVIDIA/NeMo/pull/4667 | 1,327,549,243 | PR_kwDOC_bI7s48mC4i | 4,667 | update readme | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T17:07:59 | 2022-08-03T18:13:29 | 2022-08-03T18:12:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4667",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4667",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4667.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4667.patch",
"merged_at": "2022-08-03T18:12:41"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Update README docs
**Collection**: [Speaker Tasks]
# Changelog
- update docs on launching fine-tune script
# Usage
-
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4667/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4667/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4666 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4666/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4666/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4666/events | https://github.com/NVIDIA/NeMo/pull/4666 | 1,327,269,567 | PR_kwDOC_bI7s48lGVx | 4,666 | Fix apex for r1.11 | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T14:01:17 | 2022-08-03T16:28:53 | 2022-08-03T16:28:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4666",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4666",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4666.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4666.patch",
"merged_at": "2022-08-03T16:28:39"
} | Added installation of correct apex version.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4666/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4666/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4665 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4665/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4665/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4665/events | https://github.com/NVIDIA/NeMo/pull/4665 | 1,326,578,038 | PR_kwDOC_bI7s48iyJr | 4,665 | Add support for RNNT Char/Word Timestamp Calculation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-03T01:51:20 | 2022-11-30T03:08:52 | 2022-08-09T04:01:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4665",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4665",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4665.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4665.patch",
"merged_at": "2022-08-09T04:01:39"
} | # What does this PR do ?
Adds support for RNNT models to compute character level and word level timestamps using similar steps to CTC models.
**Collection**: [ASR]
# Changelog
- Adds char and word level timestamp calculation for character and subword models
# Usage
```python
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import pytorch_lightning as pl
from omegaconf import OmegaConf, open_dict
from nemo.collections.asr.models import ASRModel
def main():
trainer = pl.Trainer(gpus=[0], precision=32, logger=False)
# Char model
# path = "Path to char model"
# Subword model
path = "Path to subword model"
asr_model = ASRModel.restore_from(path, trainer=trainer, map_location='cpu') # type: EncDecRNNTModel
asr_model.eval()
asr_model.freeze()
asr_model.preprocessor.featurizer.dither = 0.0
asr_model.preprocessor.featurizer.pad_to = 0
decoding_cfg = OmegaConf.create({})
with open_dict(decoding_cfg):
decoding_cfg.strategy = "greedy_batch"
decoding_cfg.preserve_alignments = True
decoding_cfg.compute_timestamps = True
decoding_cfg.rnnt_timestamp_type = "all"
asr_model.change_decoding_strategy(decoding_cfg)
hyp, _ = asr_model.transcribe(['/test-other-processed/367-130732-0003.wav'],
batch_size=1, return_hypotheses=True)
print("Evaluating ---")
print()
print("Transcription: ", hyp[0].text)
print()
print("Total number of timesteps :", hyp[0].length)
print()
print("Character/Subword Time-Stamps :", hyp[0].timestep['char'])
print()
print("Word Time-Stamps :", hyp[0].timestep['word'])
print()
if __name__ == '__main__':
main()
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4665/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4665/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4664 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4664/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4664/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4664/events | https://github.com/NVIDIA/NeMo/issues/4664 | 1,326,577,543 | I_kwDOC_bI7s5PEfeH | 4,664 | Import Error | {
"login": "Hrithik2212",
"id": 94508892,
"node_id": "U_kgDOBaIXXA",
"avatar_url": "https://avatars.githubusercontent.com/u/94508892?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Hrithik2212",
"html_url": "https://github.com/Hrithik2212",
"followers_url": "https://api.github.com/users/Hrithik2212/followers",
"following_url": "https://api.github.com/users/Hrithik2212/following{/other_user}",
"gists_url": "https://api.github.com/users/Hrithik2212/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Hrithik2212/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Hrithik2212/subscriptions",
"organizations_url": "https://api.github.com/users/Hrithik2212/orgs",
"repos_url": "https://api.github.com/users/Hrithik2212/repos",
"events_url": "https://api.github.com/users/Hrithik2212/events{/privacy}",
"received_events_url": "https://api.github.com/users/Hrithik2212/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-08-03T01:50:17 | 2022-08-25T14:58:07 | 2022-08-25T14:58:06 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Unable to import ASR model from Nemo.Collections **
**import nemo.collections.asr as nemo_asr**
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
** Error Message
Error
ModuleNotFoundError Traceback (most recent call last)
in ()
3 # NeMo's ASR collection - this collections contains complete ASR models and
4 # building blocks (modules) for ASR
----> 5 import nemo.collections.asr as nemo_asr
17 frames
[/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py](https://localhost:8080/#) in ()
27 if _TORCHTEXT_AVAILABLE:
28 if _compare_version("torchtext", operator.ge, "0.9.0"):
---> 29 from torchtext.legacy.data import Batch
30 else:
31 from torchtext.data import Batch
ModuleNotFoundError: No module named 'torchtext.legacy'
**
- Environment location: Collab
- Method of NeMo install: pip install
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- PyTorch version - 1.12
- Python version - 3.7
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4664/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4664/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4663 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4663/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4663/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4663/events | https://github.com/NVIDIA/NeMo/pull/4663 | 1,326,504,419 | PR_kwDOC_bI7s48ii8Z | 4,663 | Megatron Encoder Decoder models with RPE and PP > 2 | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T23:26:21 | 2022-09-20T23:55:40 | 2022-08-26T17:59:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4663",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4663",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4663.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4663.patch",
"merged_at": "2022-08-26T17:59:46"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Adds support for Enc-Dec models with RPE and PP > 2
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* model.encoder.position_embedding_type="relative"
* model.decoder.position_embedding_type="relative"
* model.pipeline_model_parallel_size=4
* model.pipeline_model_parallel_split_rank=2
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4663/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4663/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4662 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4662/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4662/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4662/events | https://github.com/NVIDIA/NeMo/pull/4662 | 1,326,429,529 | PR_kwDOC_bI7s48iTOk | 4,662 | Improve mAES algorithm with patches | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T21:44:22 | 2022-08-03T01:47:28 | 2022-08-03T01:47:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4662",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4662",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4662.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4662.patch",
"merged_at": "2022-08-03T01:47:25"
} | # What does this PR do ?
Adds the fixes from https://github.com/espnet/espnet/pull/4312 for mAES RNNT beam search.
**Collection**: [ASR]
# Changelog
- Add deduplication checks
- Improve speed of mAES beam search
# Usage
```python
# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import pytorch_lightning as pl
from omegaconf import OmegaConf, open_dict
from nemo.collections.asr.models import EncDecRNNTBPEModel
def main():
trainer = pl.Trainer(gpus=[1], precision=16, logger=False)
# Model
# path = 'some model path'
asr_model = EncDecRNNTBPEModel.restore_from(path, trainer=trainer, map_location='cpu')
asr_model.eval()
asr_model.freeze()
asr_model.preprocessor.featurizer.dither = 0.0
asr_model.preprocessor.featurizer.pad_to = 0
cfg = asr_model.cfg
test_cfg = cfg.test_ds
test_cfg.manifest_filepath = "manifests/test_other.json"
test_cfg.batch_size = 256
asr_model.setup_multiple_test_data(test_cfg)
decoding_cfg = cfg.decoding
with open_dict(decoding_cfg):
decoding_cfg.strategy = "maes"
decoding_cfg.fused_batch_size = -1
decoding_cfg.beam.beam_size = 4
decoding_cfg.beam.tsd_max_sym_exp = 10
decoding_cfg.beam.alsd_max_target_len = 2.5
decoding_cfg.beam.maes_num_steps = 2
decoding_cfg.beam.maes_prefix_alpha = 1
decoding_cfg.beam.maes_expansion_beta = 2
decoding_cfg.beam.maes_expansion_gamma = 2.3
asr_model.change_decoding_strategy(decoding_cfg)
if asr_model.prepare_test(trainer):
trainer.test(asr_model)
if __name__ == '__main__':
main()
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4662/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4662/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4661 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4661/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4661/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4661/events | https://github.com/NVIDIA/NeMo/issues/4661 | 1,326,420,345 | I_kwDOC_bI7s5PD5F5 | 4,661 | Confidence score for each word in asr model | {
"login": "catalwaysright",
"id": 60195620,
"node_id": "MDQ6VXNlcjYwMTk1NjIw",
"avatar_url": "https://avatars.githubusercontent.com/u/60195620?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/catalwaysright",
"html_url": "https://github.com/catalwaysright",
"followers_url": "https://api.github.com/users/catalwaysright/followers",
"following_url": "https://api.github.com/users/catalwaysright/following{/other_user}",
"gists_url": "https://api.github.com/users/catalwaysright/gists{/gist_id}",
"starred_url": "https://api.github.com/users/catalwaysright/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catalwaysright/subscriptions",
"organizations_url": "https://api.github.com/users/catalwaysright/orgs",
"repos_url": "https://api.github.com/users/catalwaysright/repos",
"events_url": "https://api.github.com/users/catalwaysright/events{/privacy}",
"received_events_url": "https://api.github.com/users/catalwaysright/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-08-02T21:31:48 | 2024-11-06T08:03:42 | 2022-11-15T02:10:10 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi! I am trying `nvidia/stt_en_conformer_transducer_xlarge` for my ASR system and the performance is impressive. I noticed that there is an option in transcribe function that can support lm_score in output. I wonder if it is possible to generate confidence score for each word or where should I modify the code so that it can show the confidence score for each word. Thanks in advance,
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4661/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4661/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4660 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4660/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4660/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4660/events | https://github.com/NVIDIA/NeMo/pull/4660 | 1,326,278,754 | PR_kwDOC_bI7s48hyh9 | 4,660 | Pin lightning version to be < 1.7.0 | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T19:02:33 | 2022-08-02T19:04:16 | 2022-08-02T19:04:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4660",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4660",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4660.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4660.patch",
"merged_at": "2022-08-02T19:04:13"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Pins PTL version to be less than 1.7.0
**Collection**: All
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4660/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4660/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4659 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4659/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4659/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4659/events | https://github.com/NVIDIA/NeMo/pull/4659 | 1,326,240,259 | PR_kwDOC_bI7s48hqH_ | 4,659 | Add sentencepiece legacy arg to megatron tokenizer configs | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T18:29:02 | 2022-08-02T20:04:56 | 2022-08-02T20:04:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4659",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4659",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4659.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4659.patch",
"merged_at": "2022-08-02T20:04:53"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Makes the sentencepiece legacy arg configurable. This fixes GPT training with sentencepiece.
**Collection**: NLP
# Changelog
- Makes the sentencepiece legacy arg configurable.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4659/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4659/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4655 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4655/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4655/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4655/events | https://github.com/NVIDIA/NeMo/issues/4655 | 1,325,964,270 | I_kwDOC_bI7s5PCJvu | 4,655 | Testing a pre-trained model | {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T14:42:43 | 2022-08-05T10:36:10 | 2022-08-05T10:36:10 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I am trying to test a pre-trained conformer transducer, but the reported WER is around 100 %, whereas it is much lower when I use the `transcribe()` method of the model and compute the WER myself. What am I doing wrong?
Script:
```python
import yaml
from nemo.collections.asr.models.rnnt_bpe_models import EncDecRNNTBPEModel
import pytorch_lightning as pl
trainer = pl.Trainer(devices=1, accelerator="gpu", max_epochs=50)
config = yaml.load(open("./config/config.yaml"), Loader=yaml.FullLoader)
ct = EncDecRNNTBPEModel.from_pretrained("stt_de_conformer_transducer_large")
ct.setup_test_data(config["data"]["test_ds"])
trainer.test(ct, dataloaders=ct.test_dataloader())
```
Config file:
```yaml
data:
test_ds:
manifest_filepath: data/train_split/debug.txt
sample_rate: 48000
batch_size: 1
shuffle: false
num_workers: 0
pin_memory: true
use_start_end_token: false
``` | {
"login": "carlosfranzreb",
"id": 30505353,
"node_id": "MDQ6VXNlcjMwNTA1MzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30505353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/carlosfranzreb",
"html_url": "https://github.com/carlosfranzreb",
"followers_url": "https://api.github.com/users/carlosfranzreb/followers",
"following_url": "https://api.github.com/users/carlosfranzreb/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosfranzreb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/carlosfranzreb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosfranzreb/subscriptions",
"organizations_url": "https://api.github.com/users/carlosfranzreb/orgs",
"repos_url": "https://api.github.com/users/carlosfranzreb/repos",
"events_url": "https://api.github.com/users/carlosfranzreb/events{/privacy}",
"received_events_url": "https://api.github.com/users/carlosfranzreb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4655/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4655/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4654 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4654/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4654/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4654/events | https://github.com/NVIDIA/NeMo/issues/4654 | 1,325,757,753 | I_kwDOC_bI7s5PBXU5 | 4,654 | Sentence Piece tokenizer from script "process_asr_text_tokenizer" | {
"login": "sac-1999",
"id": 77016804,
"node_id": "MDQ6VXNlcjc3MDE2ODA0",
"avatar_url": "https://avatars.githubusercontent.com/u/77016804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sac-1999",
"html_url": "https://github.com/sac-1999",
"followers_url": "https://api.github.com/users/sac-1999/followers",
"following_url": "https://api.github.com/users/sac-1999/following{/other_user}",
"gists_url": "https://api.github.com/users/sac-1999/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sac-1999/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sac-1999/subscriptions",
"organizations_url": "https://api.github.com/users/sac-1999/orgs",
"repos_url": "https://api.github.com/users/sac-1999/repos",
"events_url": "https://api.github.com/users/sac-1999/events{/privacy}",
"received_events_url": "https://api.github.com/users/sac-1999/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-08-02T12:08:12 | 2022-10-10T02:13:23 | 2022-10-10T02:13:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I was finetuning pretrained citrinet 512 model (Encoder Freeze) for filipino language where i trained a custom tokenizer with vocab size - 1024 and replaced the pretrained citrinet tokenizer section with my custom tokenizer.
`data_dir = "."
!python3 ./scripts/process_asr_text_tokenizer.py
--manifest="{data_dir}/Filipino/train_manifest.json"
--data_root="{data_dir}/complete_tg/tokenizers/tokenizer_1/"
--vocab_size=1024
--tokenizer="spe"
--spe_type="bpe"
--spe_character_coverage=1.0
--log`
Sample vocab -:
▁
##a
##i
##o
##n
##t
##c
##e
##l
##r
##s
##p
##f
##g
##k
##m
##v
This script gives tokenizer.model and vocabulary, In vocab a special character "▁" is present. This is not a normal underscore which is "_".
Can someone explain me why i am getting this special token as due to this special character i am unable to deploy my asr in riva speech with flashlight decoder.
Error got during deployment with flashlight decoder -:
`I0712 13:32:15.565105 94 ctc-decoder-library.cc:23] TRITONBACKEND_ModelInstanceInitialize: nemo_asr_riva_pipeline_filipino-ctc-decoder-cpu-streaming_0 (device 0)
terminate called after throwing an instance of 'std::runtime_error'
what(): [LoadWords] Invalid line: ▁
> Riva waiting for Triton server to load all models...retrying in 1 second
/opt/riva/bin/start-riva: line 4: 94 Aborted (core dumped) tritonserver --log-verbose=0 --strict-model-config=true $model_repos --cuda-memory-pool-byte-size=0:1000000000`
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4654/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4654/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4653 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4653/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4653/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4653/events | https://github.com/NVIDIA/NeMo/pull/4653 | 1,325,419,458 | PR_kwDOC_bI7s48e47a | 4,653 | Fix installation issues in virtual environment | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T07:37:55 | 2022-08-26T12:02:31 | 2022-08-26T12:02:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4653",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4653",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4653.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4653.patch",
"merged_at": null
} | Fixes installation issues in a normal python virtual environment when conda is also present on the same system. Also remove double negation.
Signed-off-by: Anand Joseph <[email protected]>
# What does this PR do ?
Fixes installation issues in a normal python virtual environment when conda is also present on the same system.
# Changelog
- Check if "$CONDA_PREFIX" is set rather than check if "conda" is present.
- Replace double negation "! -z" with "-n" when checking for NVIDIA_PYTORCH_VERSION
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4653/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4653/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4652 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4652/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4652/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4652/events | https://github.com/NVIDIA/NeMo/pull/4652 | 1,325,399,072 | PR_kwDOC_bI7s48e0mV | 4,652 | Fixes installation issues in a normal python virtual environment when conda is also present on the same system. | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T07:19:06 | 2022-08-02T07:20:08 | 2022-08-02T07:20:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4652",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4652",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4652.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4652.patch",
"merged_at": null
} | # What does this PR do ?
Fixes installation issues in a normal python virtual environment when conda is also present on the same system.
# Changelog
- Check if "$CONDA_PREFIX" is set rather than check if "conda" is present.
- Replace double negation "! -z" with "-n" when checking for NVIDIA_PYTORCH_VERSION
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4652/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4652/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4651 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4651/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4651/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4651/events | https://github.com/NVIDIA/NeMo/pull/4651 | 1,325,381,625 | PR_kwDOC_bI7s48ew-C | 4,651 | Fix installation issues in virtual environment | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T07:02:46 | 2022-08-02T07:14:45 | 2022-08-02T07:14:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4651",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4651",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4651.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4651.patch",
"merged_at": null
} | Fixes installation issues in a normal python virtual environment when conda is also present on the same system. Also remove double negation.
# What does this PR do ?
This primarily resolves an issue when we are working in a standard python virtual environment and conda environment is also present but not used. Basically check if $CONDA_PREFIX is set instead of checking if conda is present.
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4651/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4651/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4650 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4650/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4650/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4650/events | https://github.com/NVIDIA/NeMo/pull/4650 | 1,325,217,575 | PR_kwDOC_bI7s48eOex | 4,650 | Mutiscale Diarization Decoder (MSDD) model and module files | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T02:59:10 | 2022-08-19T01:56:10 | 2022-08-17T20:49:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4650",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4650",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4650.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4650.patch",
"merged_at": "2022-08-17T20:49:21"
} | Signed-off-by: Taejin Park <[email protected]>
# What does this PR do ?
Add multiscale diarization decoder model module, and yaml files.
Additionally, yaml files are also uploaded.
- msdd_models.py
Three classes are included:
(1) ClusterEmbedding
This class is for taking care of cluster-average embeddings by launching clustering diarizer class.
The methods in this class read embedding vectors and clustering output that are written from clustering diarizer class.
(2) EncDecDiarLabelModel
MSDD model class.
(3) OverlapAwareDiarizer
A class that launches Clustering Diarizer and run MSDD infer then evaluate it.
It involves integration of pairwise inference from MSDD and split-infer that breaks down the input to
short sequences.
- msdd_diarizer.py
MSDD Neural model class.
- speaker_utils.py
audio_rttm_map() function is modified to deal with the uniq_id with duration information.
-audio_to_diar_label.py, collections.py
These are couple of very small points where it needs to be changed like: rttm_files -> audio_files
(We need to extract uniq_id when rtttm is not provided for evaluation)
- 4 x yaml files
msdd_5scl_15_05_50Povl_infer.yaml -> for inference
msdd_6scl_30_05_50Povl_infer.yaml -> for inference
msdd_5scl_15_05_50Povl_256x3x32x2.yaml -> for training
msdd_6scl_30_05_50Povl_256x3x32x2.yaml -> for training
The name of these files are up for debate.
* Tutorial and script for training data generation is excluded since it makes PR too big.
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* Use the following command to run MSDD.
```python
HYDRA_FULL_ERROR=1 python $BASEPATH/multiscale_diar_decoder_infer.py
--config-path='conf' --config-name='msdd_5scl_15_05_50Povl_infer.yaml' \
diarizer.manifest_filepath=<TEST_MANIFEST> \
diarizer.out_dir=<TEST_EMB_DIR> \
diarizer.msdd_model.model_path=<MSDD_MODEL_PATH>\
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests? - Added unitest for msdd_model. Will add unit-test for audio_to_diar_label once micro diarization dataset is ready.
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4650/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4650/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4649 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4649/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4649/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4649/events | https://github.com/NVIDIA/NeMo/pull/4649 | 1,325,133,038 | PR_kwDOC_bI7s48d9Vp | 4,649 | adding lang id to shard | {
"login": "bmwshop",
"id": 482416,
"node_id": "MDQ6VXNlcjQ4MjQxNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/482416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bmwshop",
"html_url": "https://github.com/bmwshop",
"followers_url": "https://api.github.com/users/bmwshop/followers",
"following_url": "https://api.github.com/users/bmwshop/following{/other_user}",
"gists_url": "https://api.github.com/users/bmwshop/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bmwshop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmwshop/subscriptions",
"organizations_url": "https://api.github.com/users/bmwshop/orgs",
"repos_url": "https://api.github.com/users/bmwshop/repos",
"events_url": "https://api.github.com/users/bmwshop/events{/privacy}",
"received_events_url": "https://api.github.com/users/bmwshop/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T00:32:02 | 2022-08-02T00:38:58 | 2022-08-02T00:38:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4649",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4649",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4649.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4649.patch",
"merged_at": "2022-08-02T00:38:53"
} | # What does this PR do ?
Adds / propagates language id when creating a tarred [multilingual] dataset from non-tarred
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
One line change in the convert_to_tarred_audio_dataset.py script
# Usage
* You can potentially add a usage example below
No change to user interface.
```python
# Add a code snippet demonstrating how to use this
```
python convert_to_tarred_audio_dataset.py <params>
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4649/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4649/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4648 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4648/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4648/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4648/events | https://github.com/NVIDIA/NeMo/pull/4648 | 1,325,124,960 | PR_kwDOC_bI7s48d7or | 4,648 | Correct branch name for github page source | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-02T00:16:29 | 2022-08-02T00:17:24 | 2022-08-02T00:17:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4648",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4648",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4648.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4648.patch",
"merged_at": "2022-08-02T00:17:21"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Updates URL of github page source to `gh-pages-src`.
# NOTE
Push all changes to docs to this branch only.
**Collection**: [Docs]
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4648/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4648/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4647 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4647/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4647/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4647/events | https://github.com/NVIDIA/NeMo/pull/4647 | 1,325,108,544 | PR_kwDOC_bI7s48d4MH | 4,647 | Force git config for doc build | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T23:45:48 | 2022-08-02T00:07:55 | 2022-08-02T00:04:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4647",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4647",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4647.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4647.patch",
"merged_at": "2022-08-02T00:04:42"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Try to force the github action to have adequate permissions | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4647/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4647/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4646 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4646/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4646/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4646/events | https://github.com/NVIDIA/NeMo/pull/4646 | 1,325,086,810 | PR_kwDOC_bI7s48dzdw | 4,646 | Empty commit | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T23:11:29 | 2022-08-01T23:15:05 | 2022-08-01T23:14:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4646",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4646",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4646.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4646.patch",
"merged_at": "2022-08-01T23:14:21"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Check if github page deployment works
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4646/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4646/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4645 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4645/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4645/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4645/events | https://github.com/NVIDIA/NeMo/pull/4645 | 1,325,036,328 | PR_kwDOC_bI7s48doSc | 4,645 | Add Github Action for auto webpage build | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T22:09:40 | 2022-08-01T23:02:27 | 2022-08-01T23:02:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4645",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4645",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4645.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4645.patch",
"merged_at": "2022-08-01T23:02:23"
} | # What does this PR do ?
Adds a github action to build the website for nvidia.github.io/NeMo/ on every push.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4645/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4645/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4644 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4644/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4644/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4644/events | https://github.com/NVIDIA/NeMo/pull/4644 | 1,325,022,574 | PR_kwDOC_bI7s48dlQv | 4,644 | Update NeMo github.io website | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-08-01T21:53:30 | 2022-08-01T22:06:42 | 2022-08-01T22:03:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4644",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4644",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4644.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4644.patch",
"merged_at": "2022-08-01T22:03:31"
} | # What does this PR do ?
Modernize and update NeMo Github.io website.
**Collection**: [Docs]
# Changelog
- Replace previous redirect with mkdocs for material based website
# Usage
- To build the website locally to see the contents, run `bash build_docs.sh` from the `gh-pages` branch.
- In order to add posts, follow the steps in the template inside `docs/blogs/template.md`
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4644/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4644/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4643 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4643/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4643/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4643/events | https://github.com/NVIDIA/NeMo/pull/4643 | 1,324,948,657 | PR_kwDOC_bI7s48dVFt | 4,643 | Add MuTransfer Capablity to RETRO model pretraining | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T20:32:24 | 2022-08-03T20:50:36 | 2022-08-03T20:50:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4643",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4643",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4643.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4643.patch",
"merged_at": "2022-08-03T20:50:28"
} | # What does this PR do ?
It adds the muTransfer capablity to do RETRO model pretraining.
1. Included the mutransfer codes from MS github.
2. Add shape calculation script.
3. Add the mutransfer pretraining script.
4. Make sure it uses fused_softmax padding mode because of the customized masks
5. Include a CI test to make sure the model training performance matches.
It also fix a bug that PTL grad sync is not called.
To use muTransfer for other models (GPT, T5, BERT etc), you can follow the same pattern.
1. register muadam or muadamw optimizer.
2. swap to use MuReadout to to convert model_d to logistics
3. Use the similar parameters init method in the mutransfer_pretrain file.
| {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4643/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4643/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4642 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4642/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4642/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4642/events | https://github.com/NVIDIA/NeMo/issues/4642 | 1,324,843,407 | I_kwDOC_bI7s5O94GP | 4,642 | Mixer-TTS-X Colab Training example | {
"login": "gedefet",
"id": 43994544,
"node_id": "MDQ6VXNlcjQzOTk0NTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/43994544?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gedefet",
"html_url": "https://github.com/gedefet",
"followers_url": "https://api.github.com/users/gedefet/followers",
"following_url": "https://api.github.com/users/gedefet/following{/other_user}",
"gists_url": "https://api.github.com/users/gedefet/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gedefet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gedefet/subscriptions",
"organizations_url": "https://api.github.com/users/gedefet/orgs",
"repos_url": "https://api.github.com/users/gedefet/repos",
"events_url": "https://api.github.com/users/gedefet/events{/privacy}",
"received_events_url": "https://api.github.com/users/gedefet/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-08-01T19:03:34 | 2022-08-03T17:48:26 | 2022-08-03T17:48:26 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello.
Is any script for training Mixer-TTS-X?
I've used it in the model select inference example, and I really like how it sounds. Better than FastPitch and MixerTTS, in my opinion. Also in the paper shows a higher MOS.
I think it would be extremely useful.
Thanks,
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4642/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4642/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4641 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4641/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4641/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4641/events | https://github.com/NVIDIA/NeMo/pull/4641 | 1,324,538,680 | PR_kwDOC_bI7s48b_nx | 4,641 | Update pynini library to fix MacOS build | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T14:42:52 | 2022-08-04T13:30:49 | 2022-08-04T13:30:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4641",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4641",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4641.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4641.patch",
"merged_at": null
} | # What does this PR do ?
Update pynini from `2.1.4` to `2.1.5` to fix MacOS build
**Collection**: [Text Processing]
# Changelog
- Update pynini from `2.1.4` to `2.1.5`
# Reason
Pynini 2.1.4 can't be installed on MacOS (Intel processor, Conda, python 3.8). Using version `2.1.5` fixes the issue.
```
Building wheels for collected packages: pynini
Building wheel for pynini (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [55 lines of output]
...
building '_pywrapfst' extension
creating build/temp.macosx-10.9-x86_64-3.8
creating build/temp.macosx-10.9-x86_64-3.8/extensions
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /<user_dir>/anaconda3/envs/ml38/include -fPIC -O2 -isystem /<user_dir>/anaconda3/envs/ml38/include -I/<user_dir>/anaconda3/envs/ml38/include/python3.8 -c extensions/_pywrapfst.cpp -o build/temp.macosx-10.9-x86_64-3.8/extensions/_pywrapfst.o -std=c++17 -Wno-register -Wno-deprecated-declarations -Wno-unused-function -Wno-unused-local-typedefs -funsigned-char -stdlib=libc++ -mmacosx-version-min=10.7
extensions/_pywrapfst.cpp:753:10: fatal error: 'fst/types.h' file not found
#include <fst/types.h>
^~~~~~~~~~~~~
1 error generated.
error: command 'clang' failed with exit status 1
[end of output]
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
@yzhang123
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4641/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4641/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4640 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4640/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4640/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4640/events | https://github.com/NVIDIA/NeMo/pull/4640 | 1,324,330,213 | PR_kwDOC_bI7s48bSiN | 4,640 | Fix/need different cache dirs for different datasets | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-08-01T12:19:47 | 2022-08-02T16:49:38 | 2022-08-02T16:49:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4640",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4640",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4640.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4640.patch",
"merged_at": "2022-08-02T16:49:11"
} | # What does this PR do ?
If several `ds_item`s are used for validation or testing and `cache_dir` is set, then pickled features for different features overwrite each other.
**Collection**: nlp
# Changelog
- if `cache_dir` is set, then an absolute path to dataset is appended to `cache_dir` to avoid collisions
- Both text and labels file names are incorporated into pickled features file name. This is done to avoid collisions in rare cases when there are different labels files for 1 input text file.
- I also changed token classification pickled features name
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4640/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4640/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4639 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4639/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4639/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4639/events | https://github.com/NVIDIA/NeMo/issues/4639 | 1,324,327,518 | I_kwDOC_bI7s5O76Je | 4,639 | Help with conformer single gpu configuration | {
"login": "ZurabDz",
"id": 34181252,
"node_id": "MDQ6VXNlcjM0MTgxMjUy",
"avatar_url": "https://avatars.githubusercontent.com/u/34181252?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ZurabDz",
"html_url": "https://github.com/ZurabDz",
"followers_url": "https://api.github.com/users/ZurabDz/followers",
"following_url": "https://api.github.com/users/ZurabDz/following{/other_user}",
"gists_url": "https://api.github.com/users/ZurabDz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ZurabDz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ZurabDz/subscriptions",
"organizations_url": "https://api.github.com/users/ZurabDz/orgs",
"repos_url": "https://api.github.com/users/ZurabDz/repos",
"events_url": "https://api.github.com/users/ZurabDz/events{/privacy}",
"received_events_url": "https://api.github.com/users/ZurabDz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T12:17:25 | 2022-09-01T19:16:22 | 2022-08-23T13:09:27 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello, so I have tried training conformer for a couple of times with different audio augmentations but the results seem the same. On training and test audio model performs well, but on my recording or any other audio which was not in the test/training set model performs horribly. I am using ffprobe for validating the encoding sample rate and a number of channels. all audios have Audio: pcm_s16le ([1][0][0][0] / 0x0001), 16000 Hz, 1 channels, s16, 256 kb/s this properties. My question is, am I doing something wrong or why does conformer lack **generalization**?
```
# It contains the default values for training a Conformer-CTC ASR model, large size (~120M) with CTC loss and sub-word encoding.
# Architecture and training config:
# Default learning parameters in this config are set for effective batch size of 2K. To train it with smaller effective
# batch sizes, you may need to re-tune the learning parameters or use higher accumulate_grad_batches.
# Here are the recommended configs for different variants of Conformer-CTC, other parameters are the same as in this config file.
# One extra layer (compared to original paper) is added to the medium and large variants to compensate for replacing the LSTM decoder with a linear one.
#
# +-------------+---------+---------+----------+------------+-----+
# | Model | d_model | n_heads | n_layers | time_masks | lr |
# +=============+=========+========+===========+============+=====+
# | Small (13M)| 176 | 4 | 16 | 5 | 5.0 |
# +-------------+---------+--------+-----------+------------+-----+
# | Medium (30M)| 256 | 4 | 18 | 5 | 5.0 |
# +-------------+---------+--------+-----------+------------+-----+
# | Large (121M)| 512 | 8 | 18 | 10 | 2.0 |
# +---------------------------------------------------------------+
#
# If you do not want to train with AMP, you may use weight decay of 0.0 or reduce the number of time maskings to 2
# with time_width=100. It may help when you want to train for fewer epochs and need faster convergence.
# With weight_decay=0.0, learning rate may need to get reduced to 2.0.
# You may find more info about Conformer-CTC here: https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/asr/models.html#conformer-ctc
# Pre-trained models of Conformer-CTC can be found here: https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/asr/results.html
# The checkpoint of the large model trained on LibriSpeech with this recipe can be found here: https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_large_ls
name: "Conformer-CTC-BPE"
model:
sample_rate: 16000
log_prediction: true # enables logging sample predictions in the output during training
ctc_reduction: 'mean_batch'
skip_nan_grad: false
train_ds:
augmentor:
white_noise:
prob: 0.3
min_level: -50
max_level: -10
impulse:
prob: 0.3
manifest_path: /home/ubuntu/ASR/NeMo/scripts/dataset_processing/RIR_DATA/processed/rir.json
shift:
prob: 0.3
min_shift_ms: -5.0
max_shift_ms: 5.0
#time_stretch:
#prob: 0.4
#min_speed_rate: 0.9
#max_speed_rate: 1.1
#num_rates: 5
#n_fft: 512
#gain:
#prob: 0.4
#min_gain_dbfs: -10
#max_gain_dbfs: 10
#========================
#transcode_aug:
#prob: 0.3
#speed:
#prob: 0.3
#resample_type: 'kaiser_best'
#num_rates: 5
#sr: 16000
manifest_filepath: ???
sample_rate: ${model.sample_rate}
batch_size: 32 # you may increase batch_size if your memory allows
shuffle: true
num_workers: 8
pin_memory: true
use_start_end_token: false
trim_silence: false
max_duration: 16.7 # it is set for LibriSpeech, you may need to update it for your dataset
min_duration: 0.1
# tarred datasets
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
# bucketing params
bucketing_strategy: "synced_randomized"
bucketing_batch_size: null
validation_ds:
manifest_filepath: ???
sample_rate: ${model.sample_rate}
batch_size: 32 # you may increase batch_size if your memory allows
shuffle: false
num_workers: 8
pin_memory: true
use_start_end_token: false
test_ds:
manifest_filepath: null
sample_rate: ${model.sample_rate}
batch_size: 16 # you may increase batch_size if your memory allows
shuffle: false
num_workers: 8
pin_memory: true
use_start_end_token: false
# recommend small vocab size of 128 or 256 when using 4x sub-sampling
# you may find more detail on how to train a tokenizer at: /scripts/tokenizers/process_asr_text_tokenizer.py
tokenizer:
dir: ??? # path to directory which contains either tokenizer.model (bpe) or vocab.txt (wpe)
type: bpe # Can be either bpe (SentencePiece tokenizer) or wpe (WordPiece tokenizer)
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
sample_rate: ${model.sample_rate}
normalize: "per_feature"
window_size: 0.025
window_stride: 0.01
window: "hann"
features: 80
n_fft: 512
log: true
frame_splicing: 1
dither: 0.00001
pad_to: 0
pad_value: 0.0
spec_augment:
_target_: nemo.collections.asr.modules.SpectrogramAugmentation
#rect_masks: 5 # Number of rectangles to cut from any given spectrogram
#rect_freq: 50 # Max cut of size 50 along the frequency dimension
#rect_time: 120 # Max cut of size 120 along the time dimension
# SpecAugment parameters
freq_masks: 2 # Cut two frequency bands
freq_width: 27 # ... of width 15 at maximum
time_masks: 5 # Cut out 10 time bands
time_width: 0.05 # ... of width 25 at maximum
encoder:
_target_: nemo.collections.asr.modules.ConformerEncoder
feat_in: ${model.preprocessor.features}
feat_out: -1 # you may set it if you need different output size other than the default d_model
n_layers: 16
d_model: 176
# Sub-sampling params
subsampling: striding # vggnet or striding, vggnet may give better results but needs more memory
subsampling_factor: 4 # must be power of 2
subsampling_conv_channels: -1 # -1 sets it to d_model
# Feed forward module's params
ff_expansion_factor: 4
# Multi-headed Attention Module's params
self_attention_model: rel_pos # rel_pos or abs_pos
n_heads: 4 # may need to be lower for smaller d_models
# [left, right] specifies the number of steps to be seen from left and right of each step in self-attention
att_context_size: [-1, -1] # -1 means unlimited context
xscaling: true # scales up the input embeddings by sqrt(d_model)
untie_biases: true # unties the biases of the TransformerXL layers
pos_emb_max_len: 5000
# Convolution module's params
conv_kernel_size: 31
conv_norm_type: 'batch_norm' # batch_norm or layer_norm
### regularization
dropout: 0.1 # The dropout used in most of the Conformer Modules
dropout_emb: 0.0 # The dropout used for embeddings
dropout_att: 0.1 # The dropout for multi-headed attention modules
decoder:
_target_: nemo.collections.asr.modules.ConvASRDecoder
feat_in: null
num_classes: -1
vocabulary: []
optim:
name: adamw
lr: 5.0
# optimizer arguments
betas: [0.9, 0.98]
# less necessity for weight_decay as we already have large augmentations with SpecAug
# you may need weight_decay for large models, stable AMP training, small datasets, or when lower augmentations are used
# weight decay of 0.0 with lr of 2.0 also works fine
weight_decay: 0
# scheduler setup
sched:
name: NoamAnnealing
d_model: ${model.encoder.d_model}
# scheduler config override
warmup_steps: 10000
warmup_ratio: null
min_lr: 1e-6
trainer:
devices: -1 # number of GPUs, -1 would use all available GPUs
num_nodes: 1
max_epochs: 1000
max_steps: null # computed at runtime if not set
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
accelerator: auto
strategy: ddp
accumulate_grad_batches: 16
gradient_clip_val: 0.0
precision: 32 # Should be set to 16 for O1 and O2 to enable the AMP.
log_every_n_steps: 10 # Interval of logging.
progress_bar_refresh_rate: 10
resume_from_checkpoint: null # The path to a checkpoint file to continue the training, restores the whole state including the epoch, step, LR schedulers, apex, etc.
num_sanity_val_steps: 0 # number of steps to perform validation steps for sanity check the validation process before starting the training, setting to 0 disables it
check_val_every_n_epoch: 1 # number of evaluations on validation every n epochs
sync_batchnorm: true
enable_checkpointing: False # Provided by exp_manager
logger: false # Provided by exp_manager
benchmark: false # needs to be false for models with variable-length speech input as it slows down training
exp_manager:
exp_dir: null
name: ${name}
create_tensorboard_logger: true
create_checkpoint_callback: true
checkpoint_callback_params:
# in case of multiple validation sets, first one is used
monitor: "val_wer"
mode: "min"
save_top_k: 5
always_save_nemo: True # saves the checkpoints as nemo files instead of PTL checkpoints
# you need to set these two to True to continue the training
resume_if_exists: false
resume_ignore_no_checkpoint: false
# You may use this section to create a W&B logger
create_wandb_logger: false
wandb_logger_kwargs:
name: null
project: null
```
```
tokenizer was trained like this:
python $NEMO_ROOT/scripts/tokenizers/process_asr_text_tokenizer.py \
--manifest=/home/ubuntu/data/train.ds \
--data_root="tokenizer/" \
--vocab_size=128 \
--tokenizer="spe" \
--no_lower_case \
--spe_type="unigram" \
--spe_character_coverage=1.0 \
--log
```
So I guess, what I am really asking is, with what configuration would the model generalize better on unseen data, because right now for some unknown reason for me model drastically overfits on training/ "training like" data and on any other audio it's impossible two get a single world right...
sidenotes: If I use 16 precision most of the time loss becomes non because of rir I guess otherwise it trains well but still has generalization issues. accumulate_grad_batches was increased cause I am training on only 1 gpu with 16 gigs of vram | {
"login": "ZurabDz",
"id": 34181252,
"node_id": "MDQ6VXNlcjM0MTgxMjUy",
"avatar_url": "https://avatars.githubusercontent.com/u/34181252?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ZurabDz",
"html_url": "https://github.com/ZurabDz",
"followers_url": "https://api.github.com/users/ZurabDz/followers",
"following_url": "https://api.github.com/users/ZurabDz/following{/other_user}",
"gists_url": "https://api.github.com/users/ZurabDz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ZurabDz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ZurabDz/subscriptions",
"organizations_url": "https://api.github.com/users/ZurabDz/orgs",
"repos_url": "https://api.github.com/users/ZurabDz/repos",
"events_url": "https://api.github.com/users/ZurabDz/events{/privacy}",
"received_events_url": "https://api.github.com/users/ZurabDz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4639/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4639/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4638 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4638/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4638/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4638/events | https://github.com/NVIDIA/NeMo/pull/4638 | 1,323,854,762 | PR_kwDOC_bI7s48Zrf_ | 4,638 | [chinese text normalization] PR for chinese TN part in text_normalization | {
"login": "mzxcpp",
"id": 59506191,
"node_id": "MDQ6VXNlcjU5NTA2MTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/59506191?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mzxcpp",
"html_url": "https://github.com/mzxcpp",
"followers_url": "https://api.github.com/users/mzxcpp/followers",
"following_url": "https://api.github.com/users/mzxcpp/following{/other_user}",
"gists_url": "https://api.github.com/users/mzxcpp/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mzxcpp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mzxcpp/subscriptions",
"organizations_url": "https://api.github.com/users/mzxcpp/orgs",
"repos_url": "https://api.github.com/users/mzxcpp/repos",
"events_url": "https://api.github.com/users/mzxcpp/events{/privacy}",
"received_events_url": "https://api.github.com/users/mzxcpp/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-08-01T05:41:22 | 2022-08-05T13:57:08 | 2022-08-05T13:57:07 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4638",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4638",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4638.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4638.patch",
"merged_at": null
} | # What does this PR do ?
PR for chinese TN part in text_normalization
**Collection**: NeMo/norm_text_processing/text_normalization
Chinese Text Normalization
1. How To Use
python normalize.py --lang "zh" --text "text to be normalized"
2. TN Pipeline
There are 3 components in TN pipeline:
pre-processing (before tagger)
non-standard word normalization
post-processing (after verbalizer)
2.1 Pre-Processing
Char Width Conversion (全角 -> 半角)
苹果ＣＥＯ宣布发布新ＩＰＨＯＮＥ -> 苹果CEO宣布发布新IPHONE
他说：“我们已经吃过了！”。 -> 他说:"我们已经吃过了!".
covers English letters, digits, punctuations and some symbols
the complete mapping table data/char/fullwidth_to_halfwidth.tsv
Blacklist (Removal)
Sometime you may want to remove certain things like interjections/fillers "啊", "呃" etc
呃这个呃啊我不知道 -> 这个我不知道
customizable via data/blacklist/interjections.tsv
2.2 Non-Standard-Words(NSW) normalization
Numbers
共465篇，约315万字 -> 共四百六十五篇，约三百一十五万字
共计6.42万人 -> 共计六点四二万人
同比升高0.6个百分点 -> 同比升高零点六个百分点
Fraction
总量的1/5以上 -> 总量的五分之一以上
相当于头发丝的1/16 -> 相当于头发丝的十六分之一
3/2是一个假分数 -> 二分之三是一个假分数
Percentage
同比增长6.3% -> 同比增长百分之六点三
增幅0.4% -> 增幅百分之零点四
Date
2002/01/28 -> 二零零二年一月二十八日
2002-01-28 -> 二零零二年一月二十八日
2002.01.28 -> 二零零二年一月二十八日
2002/01 -> 二零零二年一月
Time
8月16号12:00之前 -> 八月十六号十二点之前
我是5:02开始的 -> 我是五点零二分开始的
于5:35:36发射 -> 于五点三十五分三十六秒发射
8:00 a.m. 准时开会 -> 八点 a m 准时开会
Math
比分定格在78:96 -> 比分定格在七十八比九十六
计算-2的绝对值是2 -> 计算负二的绝对值是二
±2的平方都是4 -> 正负二的平方都是四
Money
价格是￥13.5 -> 价格是十三点五元
价格是$13.5 -> 价格是十三点五美元
价格是A$13.5 -> 价格是十三点五澳元
价格是HKD13.5 -> 价格是十三点五港元
Measure
重达25kg -> 二十五千克
最高气温38°C -> 最高气温三十八摄氏度
实际面积120m² -> 实际面积一百二十平方米
渲染速度10ms一帧 -> 渲染速度十毫秒一帧
Number series (phone, mobile numbers)
可以打我手机13501234567 -> 可以打我手机一三五零一二三四五六七
可以拨打12306来咨询 -> 可以拨打一二三零六来咨询
Erhua(儿化音) Removal
这儿有只鸟儿 -> 这有只鸟
这事儿好办 -> 这事好办
我儿子喜欢这地儿 -> 我儿子喜欢这地
erhua whitelist is customizable via data/erhua/whitelist.tsv
Whitelist(Replacement)
a set of user-defined hard mapping, i.e. exact-string matching & replacement
CEO -> C E O
GPU -> G P U
O2O -> O to O
B2B -> B to B
customizable via data/whitelist/default.tsv
2.3 Post-Processing
Punctuation Removal
If enabled, punctuations are removed.
Uppercase or Lowercase Conversion
If enabled, English letters are converted to uppercases / lowercases
Out-Of-Vocabulary(OOV) Tagger
If enabled, OOV chars are tagged with <oov> and </oov>, e.g.:
我们안녕 -> 我们<oov>안</oov><oov>녕</oov>
雪の花 -> 雪<oov>の</oov>花
default charset (national standard) [通用规范汉字表](https://zh.wikipedia.org/wiki/%E9%80%9A%E7%94%A8%E8%A7%84%E8%8C%83%E6%B1%89%E5%AD%97%E8%A1%A8)
you can extend charset via data/char/charset_extension.tsv
3. Credits
Author: Zhenxiang MA @ Tsinghua University
Advisors: [SpeechColab](https://github.com/SpeechColab) organization
The authors of this work would like to thank:
The authors of foundational libraries like OpenFst & Pynini
NeMo team and NeMo open-source community
| {
"login": "mzxcpp",
"id": 59506191,
"node_id": "MDQ6VXNlcjU5NTA2MTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/59506191?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mzxcpp",
"html_url": "https://github.com/mzxcpp",
"followers_url": "https://api.github.com/users/mzxcpp/followers",
"following_url": "https://api.github.com/users/mzxcpp/following{/other_user}",
"gists_url": "https://api.github.com/users/mzxcpp/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mzxcpp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mzxcpp/subscriptions",
"organizations_url": "https://api.github.com/users/mzxcpp/orgs",
"repos_url": "https://api.github.com/users/mzxcpp/repos",
"events_url": "https://api.github.com/users/mzxcpp/events{/privacy}",
"received_events_url": "https://api.github.com/users/mzxcpp/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4638/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4638/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4637 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4637/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4637/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4637/events | https://github.com/NVIDIA/NeMo/pull/4637 | 1,323,601,557 | PR_kwDOC_bI7s48Y0Zv | 4,637 | [WIP] Multilingual punctuation restoration, true casing, and sentence boundary detection | {
"login": "1-800-BAD-CODE",
"id": 50530592,
"node_id": "MDQ6VXNlcjUwNTMwNTky",
"avatar_url": "https://avatars.githubusercontent.com/u/50530592?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/1-800-BAD-CODE",
"html_url": "https://github.com/1-800-BAD-CODE",
"followers_url": "https://api.github.com/users/1-800-BAD-CODE/followers",
"following_url": "https://api.github.com/users/1-800-BAD-CODE/following{/other_user}",
"gists_url": "https://api.github.com/users/1-800-BAD-CODE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/1-800-BAD-CODE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/1-800-BAD-CODE/subscriptions",
"organizations_url": "https://api.github.com/users/1-800-BAD-CODE/orgs",
"repos_url": "https://api.github.com/users/1-800-BAD-CODE/repos",
"events_url": "https://api.github.com/users/1-800-BAD-CODE/events{/privacy}",
"received_events_url": "https://api.github.com/users/1-800-BAD-CODE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-31T23:02:40 | 2022-12-09T23:19:23 | 2022-12-09T23:19:22 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4637",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4637",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4637.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4637.patch",
"merged_at": null
} | # What does this PR do ?
This is a work-in-progress for a model and data set that performs multilingual punctuation restoration, true casing, and sentence boundary detection. See `Usage` below for a demo of what this PR does.
Some key features:
* Resolves most of the issues mentioned in #3819
* Emphasis on multi-lingual; data set handles the nuances of each language.
* Language-agnostic inference. Inputs do not need language labels, and batches can contain multiple languages. Text is processed in its native script (e.g., Chinese is processed without spaces, for Spanish we can predict inverted punctuation, etc.).
* User can train with plain-text files as input; all "art work" is done by the pre-processor at training time
**Collection**: NLP
# Changelog
No changes to existing NeMo code, only additions.
# Usage
See current example model on the [HF hub](https://huggingface.co/1-800-BAD-CODE/punct_cap_seg_22lang1pass_xlmr).
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to discussion #3819
| {
"login": "1-800-BAD-CODE",
"id": 50530592,
"node_id": "MDQ6VXNlcjUwNTMwNTky",
"avatar_url": "https://avatars.githubusercontent.com/u/50530592?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/1-800-BAD-CODE",
"html_url": "https://github.com/1-800-BAD-CODE",
"followers_url": "https://api.github.com/users/1-800-BAD-CODE/followers",
"following_url": "https://api.github.com/users/1-800-BAD-CODE/following{/other_user}",
"gists_url": "https://api.github.com/users/1-800-BAD-CODE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/1-800-BAD-CODE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/1-800-BAD-CODE/subscriptions",
"organizations_url": "https://api.github.com/users/1-800-BAD-CODE/orgs",
"repos_url": "https://api.github.com/users/1-800-BAD-CODE/repos",
"events_url": "https://api.github.com/users/1-800-BAD-CODE/events{/privacy}",
"received_events_url": "https://api.github.com/users/1-800-BAD-CODE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4637/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4637/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4636 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4636/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4636/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4636/events | https://github.com/NVIDIA/NeMo/pull/4636 | 1,323,519,684 | PR_kwDOC_bI7s48YkUz | 4,636 | Fix multiple dev/test datasets after restoring from checkpoint | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-31T16:59:23 | 2022-08-01T08:28:42 | 2022-08-01T08:28:40 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4636",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4636",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4636.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4636.patch",
"merged_at": "2022-08-01T08:28:40"
} | Signed-off-by: PeganovAnton <[email protected]>
# What does this PR do ?
When model was restored from checkpoint, several datasets were not working for testing and validation.
**Collection**: nlp
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4636/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4636/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4635 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4635/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4635/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4635/events | https://github.com/NVIDIA/NeMo/issues/4635 | 1,322,924,469 | I_kwDOC_bI7s5O2jm1 | 4,635 | Can't redefine method: __filter_banks_getter on class: __torch__.nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures | {
"login": "psydok",
"id": 47638600,
"node_id": "MDQ6VXNlcjQ3NjM4NjAw",
"avatar_url": "https://avatars.githubusercontent.com/u/47638600?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/psydok",
"html_url": "https://github.com/psydok",
"followers_url": "https://api.github.com/users/psydok/followers",
"following_url": "https://api.github.com/users/psydok/following{/other_user}",
"gists_url": "https://api.github.com/users/psydok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/psydok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/psydok/subscriptions",
"organizations_url": "https://api.github.com/users/psydok/orgs",
"repos_url": "https://api.github.com/users/psydok/repos",
"events_url": "https://api.github.com/users/psydok/events{/privacy}",
"received_events_url": "https://api.github.com/users/psydok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-30T07:22:38 | 2022-10-09T02:13:18 | 2022-10-09T02:13:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Steps/Code to reproduce bug**
I'm trying to repeat the model deployment [instruction ](https://github.com/pytorch/android-demo-app/blob/master/SpeechRecognition/create_wav2vec2.py) on Android.
```python
from torch.utils.mobile_optimizer import optimize_for_mobile
pretrained_model = nemo_asr.models.EncDecCTCModel.load_from_checkpoint(
"my_model.ckpt",
map_location="cpu"
)
pretrained_model.eval()
pretrained_model.encoder.freeze()
pretrained_model.decoder.freeze()
quantized_model = torch.quantization.quantize_dynamic(
pretrained_model, qconfig_spec={torch.nn.Linear}, dtype=torch.qint8, inplace=True
)
scripted_model = torch.jit.script(quantized_model)
# optimized_model = optimize_for_mobile(scripted_model)
```
But torch.jit.script returns an error:
> RuntimeError: Can't redefine method: __filter_banks_getter on class: __torch__.nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures (of Python compilation unit at: ...)
Can you advise how to fix this?
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4635/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4635/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4634 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4634/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4634/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4634/events | https://github.com/NVIDIA/NeMo/issues/4634 | 1,322,916,460 | I_kwDOC_bI7s5O2hps | 4,634 | looking for the VITS model for TTS task | {
"login": "sarasesar",
"id": 95332871,
"node_id": "U_kgDOBa6qBw",
"avatar_url": "https://avatars.githubusercontent.com/u/95332871?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sarasesar",
"html_url": "https://github.com/sarasesar",
"followers_url": "https://api.github.com/users/sarasesar/followers",
"following_url": "https://api.github.com/users/sarasesar/following{/other_user}",
"gists_url": "https://api.github.com/users/sarasesar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sarasesar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sarasesar/subscriptions",
"organizations_url": "https://api.github.com/users/sarasesar/orgs",
"repos_url": "https://api.github.com/users/sarasesar/repos",
"events_url": "https://api.github.com/users/sarasesar/events{/privacy}",
"received_events_url": "https://api.github.com/users/sarasesar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-30T06:35:48 | 2022-08-03T17:46:26 | 2022-08-03T17:46:25 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I am trying to train a TTS model. I was looking for the VITS model, but I couldn't find it in your repository. Do you intend to add the VITS model to the collection of TTS models? And if you intend to add this model, when will this process happen? | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4634/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4634/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4633 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4633/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4633/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4633/events | https://github.com/NVIDIA/NeMo/pull/4633 | 1,322,906,041 | PR_kwDOC_bI7s48Wk3l | 4,633 | NeMo Megatron Doc updates1 | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-30T05:28:23 | 2022-07-30T05:28:57 | 2022-07-30T05:28:54 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4633",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4633",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4633.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4633.patch",
"merged_at": "2022-07-30T05:28:54"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4633/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4633/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4632 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4632/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4632/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4632/events | https://github.com/NVIDIA/NeMo/issues/4632 | 1,322,669,844 | I_kwDOC_bI7s5O1lcU | 4,632 | WordTokenizer `build_vocab` constructs character-based vocab instead of words | {
"login": "gwarmstrong",
"id": 19470970,
"node_id": "MDQ6VXNlcjE5NDcwOTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/19470970?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gwarmstrong",
"html_url": "https://github.com/gwarmstrong",
"followers_url": "https://api.github.com/users/gwarmstrong/followers",
"following_url": "https://api.github.com/users/gwarmstrong/following{/other_user}",
"gists_url": "https://api.github.com/users/gwarmstrong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gwarmstrong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gwarmstrong/subscriptions",
"organizations_url": "https://api.github.com/users/gwarmstrong/orgs",
"repos_url": "https://api.github.com/users/gwarmstrong/repos",
"events_url": "https://api.github.com/users/gwarmstrong/events{/privacy}",
"received_events_url": "https://api.github.com/users/gwarmstrong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "AlexGrinch",
"id": 8689095,
"node_id": "MDQ6VXNlcjg2ODkwOTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AlexGrinch",
"html_url": "https://github.com/AlexGrinch",
"followers_url": "https://api.github.com/users/AlexGrinch/followers",
"following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions",
"organizations_url": "https://api.github.com/users/AlexGrinch/orgs",
"repos_url": "https://api.github.com/users/AlexGrinch/repos",
"events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}",
"received_events_url": "https://api.github.com/users/AlexGrinch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "AlexGrinch",
"id": 8689095,
"node_id": "MDQ6VXNlcjg2ODkwOTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AlexGrinch",
"html_url": "https://github.com/AlexGrinch",
"followers_url": "https://api.github.com/users/AlexGrinch/followers",
"following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions",
"organizations_url": "https://api.github.com/users/AlexGrinch/orgs",
"repos_url": "https://api.github.com/users/AlexGrinch/repos",
"events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}",
"received_events_url": "https://api.github.com/users/AlexGrinch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-29T20:56:14 | 2022-10-13T02:14:10 | 2022-10-13T02:14:10 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
`WordTokenizer` should construct a vocab out of the words in a string, e.g., ['A word here'] -> ['A','word','here']. Instead, in constructs a character-based vocabulary due to its re-use of the `CharTokenizer` code. Additionally, if a properly constructed vocab is attempted to be loaded, it fails due to the error checking that is again inherited from `CharTokenizer`.
**Steps/Code to reproduce bug**
For constructing vocab:
```python
>>> from nemo.collections.common.tokenizers import WordTokenizer
>>> WordTokenizer.build_vocab('/tmp/vocab-georgea0729.txt', 'A word goes here')
>>> with open('/tmp/vocab-georgea0729.txt') as fh:
... print(fh.readlines())
...
['{}\n', "' '\n", "'e'\n", "'o'\n", "'r'\n", "'A'\n", "'w'\n", "'d'\n", "'g'\n", "'s'\n", "'h'\n"]
>>> tokenizer = WordTokenizer('/tmp/vocab-georgea0729.txt')
>>> tokenizer.text_to_tokens('A word goes here')
['A', None, None, None]
>>> tokenizer.text_to_tokens('A e w o h')
['A', 'e', 'w', 'o', 'h']
```
For Loading vocab:
```python
>>> with open('/tmp/georgea-manual-vocab0729.txt', 'w') as fh:
... fh.write("{}\n'A'\n'word'\n'goes'\n'here'\n")
...
28
>>> tokenizer = WordTokenizer('/tmp/georgea-manual-vocab0729.txt')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/common/tokenizers/word_tokenizer.py", line 49, in __init__
super().__init__(
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/common/tokenizers/char_tokenizer.py", line 134, in __init__
self.check_token_from_file(token, vocab_file, i)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/common/tokenizers/char_tokenizer.py", line 241, in check_token_from_file
raise ValueError(
ValueError: Each line in vocabulary have to be a Python string literal containing 1 character. Encountered 'word' on line 1 in file /tmp/georgea-manual-vocab0729.txt.
>>>
```
**Expected behavior**
```python
>>> from nemo.collections.common.tokenizers import WordTokenizer
>>> WordTokenizer.build_vocab('/tmp/vocab-georgea0729.txt', 'A word goes here')
>>> with open('/tmp/vocab-georgea0729.txt') as fh:
... print(fh.readlines())
...
["{}\n", "'A'\n", "'word'\n", "'goes'\n", "'here'\n"]
>>> tokenizer = WordTokenizer('/tmp/vocab-georgea0729.txt')
>>> tokenizer.text_to_tokens('A word goes here')
['A', 'word', 'goes', 'here']
>>> tokenizer.text_to_tokens('A e w o h')
['A', None, None, None, None]
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4632/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4632/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4631 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4631/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4631/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4631/events | https://github.com/NVIDIA/NeMo/pull/4631 | 1,322,526,048 | PR_kwDOC_bI7s48VTzG | 4,631 | FIX special tokens in vocab to arguments of constructor | {
"login": "gwarmstrong",
"id": 19470970,
"node_id": "MDQ6VXNlcjE5NDcwOTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/19470970?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gwarmstrong",
"html_url": "https://github.com/gwarmstrong",
"followers_url": "https://api.github.com/users/gwarmstrong/followers",
"following_url": "https://api.github.com/users/gwarmstrong/following{/other_user}",
"gists_url": "https://api.github.com/users/gwarmstrong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gwarmstrong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gwarmstrong/subscriptions",
"organizations_url": "https://api.github.com/users/gwarmstrong/orgs",
"repos_url": "https://api.github.com/users/gwarmstrong/repos",
"events_url": "https://api.github.com/users/gwarmstrong/events{/privacy}",
"received_events_url": "https://api.github.com/users/gwarmstrong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-29T17:47:29 | 2022-08-02T13:33:47 | 2022-08-02T13:33:47 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4631",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4631",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4631.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4631.patch",
"merged_at": "2022-08-02T13:33:47"
} | # What does this PR do ?
This PR fixes #4627 by setting the initial vocab of `RegExTokenizer` to the supplied special tokens.
**Collection**: Common
# Changelog
- Sets the initial vocab of `RegExTokenier` to the supplied special tokens.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
@michalivne @titu1994
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4631/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4631/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4630 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4630/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4630/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4630/events | https://github.com/NVIDIA/NeMo/pull/4630 | 1,322,490,814 | PR_kwDOC_bI7s48VMbJ | 4,630 | Fix itn pt time | {
"login": "guidefloripa",
"id": 6698381,
"node_id": "MDQ6VXNlcjY2OTgzODE=",
"avatar_url": "https://avatars.githubusercontent.com/u/6698381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guidefloripa",
"html_url": "https://github.com/guidefloripa",
"followers_url": "https://api.github.com/users/guidefloripa/followers",
"following_url": "https://api.github.com/users/guidefloripa/following{/other_user}",
"gists_url": "https://api.github.com/users/guidefloripa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guidefloripa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guidefloripa/subscriptions",
"organizations_url": "https://api.github.com/users/guidefloripa/orgs",
"repos_url": "https://api.github.com/users/guidefloripa/repos",
"events_url": "https://api.github.com/users/guidefloripa/events{/privacy}",
"received_events_url": "https://api.github.com/users/guidefloripa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-29T17:05:15 | 2022-08-02T13:21:11 | 2022-08-02T08:58:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4630",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4630",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4630.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4630.patch",
"merged_at": "2022-08-02T08:58:29"
} | # What does this PR do ?
Fix ITN rules for Portuguese (time).
Fix the case when the text is "às três horas" (at three o'clock) to force to have "horas" (like o'clock) instead of "às três" (at three).
Collection: [Text Processing]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4630/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4630/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4629 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4629/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4629/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4629/events | https://github.com/NVIDIA/NeMo/issues/4629 | 1,322,211,540 | I_kwDOC_bI7s5Oz1jU | 4,629 | Computing word timestamps from start and end offsets of hypotheses object | {
"login": "raikarsagar",
"id": 22492323,
"node_id": "MDQ6VXNlcjIyNDkyMzIz",
"avatar_url": "https://avatars.githubusercontent.com/u/22492323?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/raikarsagar",
"html_url": "https://github.com/raikarsagar",
"followers_url": "https://api.github.com/users/raikarsagar/followers",
"following_url": "https://api.github.com/users/raikarsagar/following{/other_user}",
"gists_url": "https://api.github.com/users/raikarsagar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/raikarsagar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/raikarsagar/subscriptions",
"organizations_url": "https://api.github.com/users/raikarsagar/orgs",
"repos_url": "https://api.github.com/users/raikarsagar/repos",
"events_url": "https://api.github.com/users/raikarsagar/events{/privacy}",
"received_events_url": "https://api.github.com/users/raikarsagar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-07-29T12:48:15 | 2022-10-31T17:50:57 | 2022-08-01T17:10:37 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I am trying to compute word level timestamps with CTCBPEDecoder and able to get the Hypotheses with timestep dictionary. But the dictionary has start_offset and end_offset for each word. I would like to know the offset value and stride multplication factor for computing final timestamp. Formulation for it would be great.
Here is a sample hypothesis object with timestep dictionary:
`[Hypothesis(score=tensor(-1.0438), y_sequence=tensor([[-5.6491e+01, -1.8834e+01, -1.4659e+01, ..., -2.6665e+01,
-3.1068e+01, -2.8610e-06],
[-5.7072e+01, -1.8568e+01, -1.7445e+01, ..., -2.4695e+01,
-3.3793e+01, -5.9605e-07],
[-5.7386e+01, -1.8189e+01, -1.9202e+01, ..., -2.3949e+01,
-3.3627e+01, -8.3446e-07],
...,
[-5.5325e+01, -1.4839e+01, -1.9966e+01, ..., -2.1065e+01,
-3.3125e+01, -1.4305e-05],
[-5.6287e+01, -1.4943e+01, -2.2234e+01, ..., -2.3138e+01,
-3.3042e+01, -7.3909e-06],
[-5.2566e+01, -1.3785e+01, -2.1438e+01, ..., -2.2653e+01,
-2.8750e+01, -1.4543e-05]], device='cuda:0'), text="well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very like the old portrait", dec_out=None, dec_state=None, timestep={'timestep': [12, 15, 19, 21, 23, 24, 25, 27, 29, 30, 31, 33, 36, 37, 39, 41, 44, 46, 47, 50, 52, 56, 57, 59, 61, 63, 64, 66, 67, 68, 69, 70, 71, 72, 74, 83, 85, 87, 90, 92, 94, 96, 97, 100, 102, 105, 107, 110, 125, 130, 135, 136, 138, 140, 141, 143, 146, 148, 150, 152, 158, 161, 163, 164, 167, 169, 171, 172, 174, 176], 'char': [{'char': 'we', 'start_offset': 11, 'end_offset': 12}, {'char': 'll', 'start_offset': 12, 'end_offset': 15}, {'char': 'i', 'start_offset': 15, 'end_offset': 19}, {'char': 'do', 'start_offset': 19, 'end_offset': 21}, {'char': 'n', 'start_offset': 21, 'end_offset': 23}, {'char': "'", 'start_offset': 23, 'end_offset': 24}, {'char': 't', 'start_offset': 24, 'end_offset': 25}, {'char': 'w', 'start_offset': 25, 'end_offset': 27}, {'char': 'i', 'start_offset': 27, 'end_offset': 29}, {'char': 's', 'start_offset': 29, 'end_offset': 30}, {'char': 'h', 'start_offset': 30, 'end_offset': 31}, {'char': 'to', 'start_offset': 31, 'end_offset': 33}, {'char': 's', 'start_offset': 33, 'end_offset': 36}, {'char': 'e', 'start_offset': 36, 'end_offset': 37}, {'char': 'e', 'start_offset': 37, 'end_offset': 39}, {'char': 'it', 'start_offset': 39, 'end_offset': 41}, {'char': 'a', 'start_offset': 41, 'end_offset': 44}, {'char': 'n', 'start_offset': 44, 'end_offset': 46}, {'char': 'y', 'start_offset': 46, 'end_offset': 47}, {'char': 'mo', 'start_offset': 47, 'end_offset': 50}, {'char': 're', 'start_offset': 50, 'end_offset': 52}, {'char': 'o', 'start_offset': 52, 'end_offset': 56}, {'char': 'b', 'start_offset': 56, 'end_offset': 57}, {'char': 's', 'start_offset': 57, 'end_offset': 59}, {'char': 'er', 'start_offset': 59, 'end_offset': 61}, {'char': 've', 'start_offset': 61, 'end_offset': 63}, {'char': 'd', 'start_offset': 63, 'end_offset': 64}, {'char': 'p', 'start_offset': 64, 'end_offset': 66}, {'char': 'h', 'start_offset': 66, 'end_offset': 67}, {'char': 'o', 'start_offset': 67, 'end_offset': 69}, {'char': 'e', 'start_offset': 69, 'end_offset': 70}, {'char': 'b', 'start_offset': 70, 'end_offset': 72}, {'char': 'e', 'start_offset': 72, 'end_offset': 74}, {'char': 't', 'start_offset': 74, 'end_offset': 83}, {'char': 'ur', 'start_offset': 83, 'end_offset': 85}, {'char': 'n', 'start_offset': 85, 'end_offset': 87}, {'char': 'ing', 'start_offset': 87, 'end_offset': 90}, {'char': 'a', 'start_offset': 90, 'end_offset': 92}, {'char': 'w', 'start_offset': 92, 'end_offset': 94}, {'char': 'a', 'start_offset': 94, 'end_offset': 96}, {'char': 'y', 'start_offset': 96, 'end_offset': 97}, {'char': 'he', 'start_offset': 97, 'end_offset': 100}, {'char': 'r', 'start_offset': 100, 'end_offset': 102}, {'char': 'e', 'start_offset': 102, 'end_offset': 105}, {'char': 'y', 'start_offset': 105, 'end_offset': 107}, {'char': 'es', 'start_offset': 107, 'end_offset': 110}, {'char': 'it', 'start_offset': 110, 'end_offset': 125}, {'char': 'is', 'start_offset': 125, 'end_offset': 130}, {'char': 'c', 'start_offset': 130, 'end_offset': 135}, {'char': 'er', 'start_offset': 135, 'end_offset': 136}, {'char': 't', 'start_offset': 136, 'end_offset': 138}, {'char': 'a', 'start_offset': 138, 'end_offset': 140}, {'char': 'in', 'start_offset': 140, 'end_offset': 141}, {'char': 'ly', 'start_offset': 141, 'end_offset': 143}, {'char': '', 'start_offset': 143, 'end_offset': 146}, {'char': 'ver', 'start_offset': 146, 'end_offset': 148}, {'char': 'y', 'start_offset': 148, 'end_offset': 150}, {'char': 'like', 'start_offset': 150, 'end_offset': 152}, {'char': 'the', 'start_offset': 152, 'end_offset': 158}, {'char': 'o', 'start_offset': 158, 'end_offset': 161}, {'char': 'l', 'start_offset': 161, 'end_offset': 163}, {'char': 'd', 'start_offset': 163, 'end_offset': 164}, {'char': 'p', 'start_offset': 164, 'end_offset': 167}, {'char': 'or', 'start_offset': 167, 'end_offset': 169}, {'char': 't', 'start_offset': 169, 'end_offset': 171}, {'char': 'ra', 'start_offset': 171, 'end_offset': 174}, {'char': 'it', 'start_offset': 174, 'end_offset': 176}], 'word': [{'word': 'well', 'start_offset': 11, 'end_offset': 19}, {'word': 'i', 'start_offset': 19, 'end_offset': 21}, {'word': "don't", 'start_offset': 25, 'end_offset': 27}, {'word': 'wish', 'start_offset': 31, 'end_offset': 33}, {'word': 'to', 'start_offset': 33, 'end_offset': 36}, {'word': 'see', 'start_offset': 39, 'end_offset': 41}, {'word': 'it', 'start_offset': 41, 'end_offset': 44}, {'word': 'any', 'start_offset': 47, 'end_offset': 50}, {'word': 'more', 'start_offset': 52, 'end_offset': 56}, {'word': 'observed', 'start_offset': 64, 'end_offset': 66}, {'word': 'phoebe', 'start_offset': 74, 'end_offset': 83}, {'word': 'turning', 'start_offset': 90, 'end_offset': 92}, {'word': 'away', 'start_offset': 97, 'end_offset': 100}, {'word': 'her', 'start_offset': 102, 'end_offset': 105}, {'word': 'eyes', 'start_offset': 110, 'end_offset': 125}, {'word': 'it', 'start_offset': 125, 'end_offset': 130}, {'word': 'is', 'start_offset': 130, 'end_offset': 135}, {'word': 'certainly', 'start_offset': 143, 'end_offset': 146}, {'word': 'very', 'start_offset': 150, 'end_offset': 152}, {'word': 'like', 'start_offset': 152, 'end_offset': 158}, {'word': 'the', 'start_offset': 158, 'end_offset': 161}, {'word': 'old', 'start_offset': 164, 'end_offset': 167}, {'word': 'portrait', 'start_offset': 164, 'end_offset': 176}]}, alignments=tensor([[-5.6491e+01, -1.8834e+01, -1.4659e+01, ..., -2.6665e+01,
-3.1068e+01, -2.8610e-06],
[-5.7072e+01, -1.8568e+01, -1.7445e+01, ..., -2.4695e+01,
-3.3793e+01, -5.9605e-07],
[-5.7386e+01, -1.8189e+01, -1.9202e+01, ..., -2.3949e+01,
-3.3627e+01, -8.3446e-07],
...,
[-5.5325e+01, -1.4839e+01, -1.9966e+01, ..., -2.1065e+01,
-3.3125e+01, -1.4305e-05],
[-5.6287e+01, -1.4943e+01, -2.2234e+01, ..., -2.3138e+01,
-3.3042e+01, -7.3909e-06],
[-5.2566e+01, -1.3785e+01, -2.1438e+01, ..., -2.2653e+01,
-2.8750e+01, -1.4543e-05]], device='cuda:0'), length=tensor(186, dtype=torch.int32), y=None, lm_state=None, lm_scores=None, tokens=None, last_token=None)]`
Thanks in advance
Sagar
| {
"login": "raikarsagar",
"id": 22492323,
"node_id": "MDQ6VXNlcjIyNDkyMzIz",
"avatar_url": "https://avatars.githubusercontent.com/u/22492323?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/raikarsagar",
"html_url": "https://github.com/raikarsagar",
"followers_url": "https://api.github.com/users/raikarsagar/followers",
"following_url": "https://api.github.com/users/raikarsagar/following{/other_user}",
"gists_url": "https://api.github.com/users/raikarsagar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/raikarsagar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/raikarsagar/subscriptions",
"organizations_url": "https://api.github.com/users/raikarsagar/orgs",
"repos_url": "https://api.github.com/users/raikarsagar/repos",
"events_url": "https://api.github.com/users/raikarsagar/events{/privacy}",
"received_events_url": "https://api.github.com/users/raikarsagar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4629/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4629/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4628 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4628/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4628/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4628/events | https://github.com/NVIDIA/NeMo/pull/4628 | 1,321,670,459 | PR_kwDOC_bI7s48Sd6U | 4,628 | Fix HF check for model card info | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-29T02:03:29 | 2022-07-29T05:50:15 | 2022-07-29T05:50:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4628",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4628",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4628.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4628.patch",
"merged_at": "2022-07-29T05:50:03"
} | Signed-off-by: smajumdar <[email protected]>
Fix HF test where model card might not contain info
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Core]
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4628/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4628/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4627 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4627/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4627/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4627/events | https://github.com/NVIDIA/NeMo/issues/4627 | 1,321,581,569 | I_kwDOC_bI7s5OxbwB | 4,627 | RegexTokenizer: Default token arguments are not mapped to vocabulary index | {
"login": "gwarmstrong",
"id": 19470970,
"node_id": "MDQ6VXNlcjE5NDcwOTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/19470970?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gwarmstrong",
"html_url": "https://github.com/gwarmstrong",
"followers_url": "https://api.github.com/users/gwarmstrong/followers",
"following_url": "https://api.github.com/users/gwarmstrong/following{/other_user}",
"gists_url": "https://api.github.com/users/gwarmstrong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gwarmstrong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gwarmstrong/subscriptions",
"organizations_url": "https://api.github.com/users/gwarmstrong/orgs",
"repos_url": "https://api.github.com/users/gwarmstrong/repos",
"events_url": "https://api.github.com/users/gwarmstrong/events{/privacy}",
"received_events_url": "https://api.github.com/users/gwarmstrong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-28T23:10:35 | 2022-08-02T13:33:48 | 2022-08-02T13:33:48 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The ID's of the default special tokens in RegexTokenizer are set here:
https://github.com/NVIDIA/NeMo/blob/72d78d832c6332ccc7f44811fb777eb7044df1d8/nemo/collections/common/tokenizers/regex_tokenizer.py#L75-L82
However, the constructor, allows custom special tokens:
https://github.com/NVIDIA/NeMo/blob/72d78d832c6332ccc7f44811fb777eb7044df1d8/nemo/collections/common/tokenizers/regex_tokenizer.py#L42-L51
So this could cause issues (specifically extra unknowns) when text is converted to tokens, then to ids, then back. | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4627/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4627/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4626 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4626/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4626/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4626/events | https://github.com/NVIDIA/NeMo/pull/4626 | 1,321,476,188 | PR_kwDOC_bI7s48Rz1u | 4,626 | Update megatron t5 interface to dialogue | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-28T20:54:03 | 2023-02-22T18:42:40 | 2022-07-29T02:58:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4626",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4626",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4626.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4626.patch",
"merged_at": "2022-07-29T02:58:26"
} | # What does this PR do ?
Add inference support for Megatron T5 in Dialogue module
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4626/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4626/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4625 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4625/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4625/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4625/events | https://github.com/NVIDIA/NeMo/pull/4625 | 1,321,380,475 | PR_kwDOC_bI7s48RevC | 4,625 | Tiny VAD refactoring for postprocessing | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-28T19:25:04 | 2022-07-29T09:05:11 | 2022-07-29T09:05:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4625",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4625",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4625.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4625.patch",
"merged_at": "2022-07-29T09:05:06"
} | # What does this PR do ?
Small fix for ignoring overlap median filtering and use shift > 0.01 in generating speech segments efficiently.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4625/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4625/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4624 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4624/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4624/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4624/events | https://github.com/NVIDIA/NeMo/pull/4624 | 1,321,258,799 | PR_kwDOC_bI7s48RERs | 4,624 | [Text Processing] G2P for OOV and heteronyms | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-28T17:25:02 | 2022-07-29T21:08:34 | 2022-07-29T21:08:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4624",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4624",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4624.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4624.patch",
"merged_at": "2022-07-29T21:08:32"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Adds G2P models for OOV and heteronyms.
**Collection**: [Text Processing]
# Changelog
G2P models for OOV and heteronyms.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4624/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4624/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4623 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4623/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4623/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4623/events | https://github.com/NVIDIA/NeMo/pull/4623 | 1,321,181,081 | PR_kwDOC_bI7s48QzVQ | 4,623 | Fix ITN pt | {
"login": "guidefloripa",
"id": 6698381,
"node_id": "MDQ6VXNlcjY2OTgzODE=",
"avatar_url": "https://avatars.githubusercontent.com/u/6698381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guidefloripa",
"html_url": "https://github.com/guidefloripa",
"followers_url": "https://api.github.com/users/guidefloripa/followers",
"following_url": "https://api.github.com/users/guidefloripa/following{/other_user}",
"gists_url": "https://api.github.com/users/guidefloripa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guidefloripa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guidefloripa/subscriptions",
"organizations_url": "https://api.github.com/users/guidefloripa/orgs",
"repos_url": "https://api.github.com/users/guidefloripa/repos",
"events_url": "https://api.github.com/users/guidefloripa/events{/privacy}",
"received_events_url": "https://api.github.com/users/guidefloripa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-28T16:14:59 | 2022-07-29T16:40:08 | 2022-07-29T16:39:06 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4623",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4623",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4623.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4623.patch",
"merged_at": "2022-07-29T16:39:06"
} | # What does this PR do ?
Fix ITN rules for Portuguese (date and time).
In addiction, tests for these rules were added.
Collection: [Text Processing]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4623/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4623/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4622 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4622/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4622/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4622/events | https://github.com/NVIDIA/NeMo/pull/4622 | 1,320,940,809 | PR_kwDOC_bI7s48QBtW | 4,622 | [NLP/PC] add support for capitalization classes lower (L), upper (U), capitalize (C) | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-28T13:32:22 | 2022-11-07T02:11:50 | 2022-11-07T02:11:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4622",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4622",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4622.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4622.patch",
"merged_at": null
} | Signed-off-by: Iztok Lebar Bajec <[email protected]>
# What does this PR do ?
While waiting for #3819 to be finished, upgrade of current punctuation capitalization model with support for lowercasing, uppercasing, and capitalisation.
**Collection**: NLP/PC
# Changelog
Modified the capitalisation decision from pure capitalisation, as soon as `capit_label` differs from noop (`O`), to one where the operation is based on three classes: lowercase (`L`), uppercase (`U`) and capitalize (`C`).
Warning: Due to the `class_label` previously used for capitalisation (`U`) and the way the decision was implemented prior to this PR, this change becomes a breaking change. Models trained prior to this PR will result in returning `all caps` instead of `capitalising` selected words. A retrain will, however, provide additional functionality.
# Usage
* You can potentially add a usage example below
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
@PeganovAnton | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4622/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4622/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4620 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4620/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4620/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4620/events | https://github.com/NVIDIA/NeMo/issues/4620 | 1,319,232,793 | I_kwDOC_bI7s5OoeUZ | 4,620 | Extract tokeniser from .nemo file | {
"login": "evilc3",
"id": 19889717,
"node_id": "MDQ6VXNlcjE5ODg5NzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/19889717?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/evilc3",
"html_url": "https://github.com/evilc3",
"followers_url": "https://api.github.com/users/evilc3/followers",
"following_url": "https://api.github.com/users/evilc3/following{/other_user}",
"gists_url": "https://api.github.com/users/evilc3/gists{/gist_id}",
"starred_url": "https://api.github.com/users/evilc3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/evilc3/subscriptions",
"organizations_url": "https://api.github.com/users/evilc3/orgs",
"repos_url": "https://api.github.com/users/evilc3/repos",
"events_url": "https://api.github.com/users/evilc3/events{/privacy}",
"received_events_url": "https://api.github.com/users/evilc3/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-27T08:52:52 | 2024-03-29T08:30:46 | 2022-08-08T11:01:30 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Is it possible to extract the sentence_piece tokeniser (.model, .vocab) file from the .nemo format?
| {
"login": "evilc3",
"id": 19889717,
"node_id": "MDQ6VXNlcjE5ODg5NzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/19889717?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/evilc3",
"html_url": "https://github.com/evilc3",
"followers_url": "https://api.github.com/users/evilc3/followers",
"following_url": "https://api.github.com/users/evilc3/following{/other_user}",
"gists_url": "https://api.github.com/users/evilc3/gists{/gist_id}",
"starred_url": "https://api.github.com/users/evilc3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/evilc3/subscriptions",
"organizations_url": "https://api.github.com/users/evilc3/orgs",
"repos_url": "https://api.github.com/users/evilc3/repos",
"events_url": "https://api.github.com/users/evilc3/events{/privacy}",
"received_events_url": "https://api.github.com/users/evilc3/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4620/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4620/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4619 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4619/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4619/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4619/events | https://github.com/NVIDIA/NeMo/pull/4619 | 1,318,832,100 | PR_kwDOC_bI7s48JJ2_ | 4,619 | Support listing Hugging Face model info | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-26T23:02:03 | 2022-07-27T22:12:56 | 2022-07-27T22:12:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4619",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4619",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4619.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4619.patch",
"merged_at": "2022-07-27T22:12:54"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Add new apis to filter and obtain NeMo hugging face models via code.
**Collection**: [Core]
# Changelog
- Adds two methods `get_hf_model_filter()` and `search_huggingface_models(model_filter=None)` to ModelPT.
- First method returns a basic ModelFilter object, can be overridden by the user. Used as default to next method if nothing is provided.
- Add support for metadata attributes to the filter to modify the result list of ModelInfo.
- `list_available_models_on_hf()` lists the nemo models that satisfy the filter.
# Usage
```python
from nemo.core import ModelPT
# You can replace <DomainSubclass> with any subclass of ModelPT.
# Get default ModelFilter
filt = <DomainSubclass>.get_hf_model_filter()
# Make any modifications to the filter as necessary
filt.language = [...]
filt.task = ...
filt.tags = [...]
# Add any metadata to the filter as needed
filt.limit_results = 5
# Obtain model info
model_infos = <DomainSubclass>.search_huggingface_models(model_filter=filt)
# Browse through cards and select an appropriate one
card = model_infos[0]
# Restore model using `modelId` of the card.
model = ModelPT.from_pretrained(card.modelId)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4619/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4619/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4618 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4618/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4618/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4618/events | https://github.com/NVIDIA/NeMo/issues/4618 | 1,318,740,003 | I_kwDOC_bI7s5OmmAj | 4,618 | Cuda Out of memory | {
"login": "sepehr3pehr",
"id": 12605042,
"node_id": "MDQ6VXNlcjEyNjA1MDQy",
"avatar_url": "https://avatars.githubusercontent.com/u/12605042?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sepehr3pehr",
"html_url": "https://github.com/sepehr3pehr",
"followers_url": "https://api.github.com/users/sepehr3pehr/followers",
"following_url": "https://api.github.com/users/sepehr3pehr/following{/other_user}",
"gists_url": "https://api.github.com/users/sepehr3pehr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sepehr3pehr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sepehr3pehr/subscriptions",
"organizations_url": "https://api.github.com/users/sepehr3pehr/orgs",
"repos_url": "https://api.github.com/users/sepehr3pehr/repos",
"events_url": "https://api.github.com/users/sepehr3pehr/events{/privacy}",
"received_events_url": "https://api.github.com/users/sepehr3pehr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-26T20:51:59 | 2022-10-06T02:13:14 | 2022-10-06T02:13:14 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I am trying to train a conformer-transducer model on LibriSpeech but I am getting out of memory error. I am using the `conformer_transducer_bpe.yaml` config to initialize a `EncDecRNNTBPEModel` class (also tried the `char` version) with `batch_size=8` on a `NVIDIA K80 GPU` with 12GB of memory and this is the error I am getting:
`...
File "/home/ec2-user/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/modules/rnnt.py", line 992, in joint
res = self.joint_net(inp) # [B, T, U, V + 1]
File "/home/ec2-user/anaconda3/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/ec2-user/anaconda3/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/container.py", line 139, in forward
input = module(input)
File "/home/ec2-user/anaconda3/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/ec2-user/anaconda3/envs/nemo/lib/python3.8/site-packages/torch/nn/modules/linear.py", line 114, in forward
return F.linear(input, self.weight, self.bias)
Variable._execution_engine.run_backward( # Calls into the C++ engine to run the backward pass
RuntimeError: CUDA out of memory. Tried to allocate 2.16 GiB (GPU 0; 11.17 GiB total capacity; 8.88 GiB already allocated; 1.76 GiB free; 9.01 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation. See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF`
I managed to train a `EncDecCTCModelBPE` model with much larger number of parameters on the same dataset with a larger batch size but I am not sure why I am getting memory error for a smaller model. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4618/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4618/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4617 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4617/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4617/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4617/events | https://github.com/NVIDIA/NeMo/issues/4617 | 1,318,682,787 | I_kwDOC_bI7s5OmYCj | 4,617 | Using PyTorch Lightning Quantization Aware Training callback | {
"login": "yttuncel",
"id": 11933853,
"node_id": "MDQ6VXNlcjExOTMzODUz",
"avatar_url": "https://avatars.githubusercontent.com/u/11933853?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yttuncel",
"html_url": "https://github.com/yttuncel",
"followers_url": "https://api.github.com/users/yttuncel/followers",
"following_url": "https://api.github.com/users/yttuncel/following{/other_user}",
"gists_url": "https://api.github.com/users/yttuncel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yttuncel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yttuncel/subscriptions",
"organizations_url": "https://api.github.com/users/yttuncel/orgs",
"repos_url": "https://api.github.com/users/yttuncel/repos",
"events_url": "https://api.github.com/users/yttuncel/events{/privacy}",
"received_events_url": "https://api.github.com/users/yttuncel/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-26T19:48:27 | 2022-10-06T02:13:16 | 2022-10-06T02:13:16 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Can we use PL's QuantizationAwareTraining and ModelPruning callbacks during NeMo model training?
To quickly test this, I tried to add the QAT callback to the trainer in speech_to_text_ctc.py script to train a quick Quartznet5x5 model:
```
callbacks = [QuantizationAwareTraining(qconfig='qnnpack')]
trainer = pl.Trainer(callbacks=callbacks, **cfg.trainer)
```
and I get the following error:
```
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/ytuncel/.vscode-server/extensions/ms-python.python-2022.10.1/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in <module>
cli.main()
File "/home/ytuncel/.vscode-server/extensions/ms-python.python-2022.10.1/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main
run()
File "/home/ytuncel/.vscode-server/extensions/ms-python.python-2022.10.1/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file
runpy.run_path(target, run_name="__main__")
File "/home/ytuncel/.vscode-server/extensions/ms-python.python-2022.10.1/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 321, in run_path
return _run_module_code(code, init_globals, run_name,
File "/home/ytuncel/.vscode-server/extensions/ms-python.python-2022.10.1/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 135, in _run_module_code
_run_code(code, mod_globals, init_globals,
File "/home/ytuncel/.vscode-server/extensions/ms-python.python-2022.10.1/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 124, in _run_code
exec(code, run_globals)
File "/home/ytuncel/tiny_asr/src/tiny_asr/script.py", line 108, in <module>
main() # noqa pylint: disable=no-value-for-parameter
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/nemo/core/config/hydra_runner.py", line 104, in wrapper
_run_hydra(
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/_internal/utils.py", line 377, in _run_hydra
run_and_report(
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/_internal/utils.py", line 214, in run_and_report
raise ex
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/_internal/utils.py", line 211, in run_and_report
return func()
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/_internal/utils.py", line 378, in <lambda>
lambda: hydra.run(
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 111, in run
_ = ret.return_value
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/core/utils.py", line 233, in return_value
raise self._return_value
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/hydra/core/utils.py", line 160, in run_job
ret.return_value = task_function(task_cfg)
File "/home/ytuncel/tiny_asr/src/tiny_asr/script.py", line 103, in main
trainer.fit(asr_model)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 770, in fit
self._call_and_handle_interrupt(
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 723, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 811, in _fit_impl
results = self._run(model, ckpt_path=self.ckpt_path)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1236, in _run
results = self._run_stage()
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1323, in _run_stage
return self._run_train()
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1345, in _run_train
self._run_sanity_check()
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1413, in _run_sanity_check
val_loop.run()
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 154, in advance
dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 128, in advance
output = self._evaluation_step(**kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 226, in _evaluation_step
output = self.trainer._call_strategy_hook("validation_step", *kwargs.values())
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1765, in _call_strategy_hook
output = fn(*args, **kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/pytorch_lightning/strategies/strategy.py", line 344, in validation_step
return self.model.validation_step(*args, **kwargs)
File "/home/ytuncel/miniconda3/envs/asr/lib/python3.8/site-packages/nemo/collections/asr/models/ctc_models.py", line 621, in validation_step
log_probs, encoded_len, predictions = self.forward(input_signal=signal, input_signal_length=signal_len)
TypeError: wrapper() got an unexpected keyword argument 'input_signal'
```
Are there any examples that show how we can use the Pruning and QAT tools in pytorch with NeMo? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4617/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4617/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4616 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4616/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4616/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4616/events | https://github.com/NVIDIA/NeMo/pull/4616 | 1,318,674,071 | PR_kwDOC_bI7s48Iohl | 4,616 | [TTS] Fix off-by-1 bug in Beta Binomial Prior | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-26T19:38:30 | 2022-07-28T00:38:56 | 2022-07-28T00:38:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4616",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4616",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4616.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4616.patch",
"merged_at": "2022-07-28T00:38:38"
} | # What does this PR do ?
Fix a bug in the prior calculation used in the TTS aligner
**Collection**: [TTS]
# Changelog
- Fix off-by-1 bug in prior calculation
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
# Additional Information
The prior here is supposed to help the TTS model align by teaching it to place more weight on phonemes along the diagonal, with it always starting on the first phoneme and ending on the last phoneme.
The current logic produces a prior that looks like this, which awkwardly ends earlier than expected with maximum weight on the last phoneme before the end of the sequence:
After this change, the prior looks like this:
I think the intuition is that we model the attention as a binomial distribution (eg. coin flips with head being success, tail failure) where each success results in the attention moving on to the next phoneme. To reach the end of a sequence of N phonemes, you only need (N - 1) successes. | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4616/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4616/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4615 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4615/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4615/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4615/events | https://github.com/NVIDIA/NeMo/pull/4615 | 1,318,646,292 | PR_kwDOC_bI7s48Iite | 4,615 | LossMisconfigurationError | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-26T19:07:54 | 2022-10-13T02:14:13 | 2022-10-13T02:14:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4615",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4615",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4615.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4615.patch",
"merged_at": null
} | # What does this PR do ?
Add a LossMisconfigurationException that provides more context on how to fix certain issues that can occur during training.
**Collection**: ASR
# Changelog
- Add a `LossMisconfigurationException` for `ContrastiveLoss`
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [X] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #4587
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4615/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4615/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4614 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4614/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4614/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4614/events | https://github.com/NVIDIA/NeMo/pull/4614 | 1,318,643,927 | PR_kwDOC_bI7s48IiNP | 4,614 | Improve normalize_batch ValueError message | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-26T19:05:12 | 2022-07-27T00:19:42 | 2022-07-27T00:19:42 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4614",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4614",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4614.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4614.patch",
"merged_at": "2022-07-27T00:19:42"
} | # What does this PR do ?
Improve `normalize_batch` error message with suggestions on how to fix.
Sometimes audio files with zero/small duration sneak by as files with a non-zero duration field, causing this error.
**Collection**: ASR
# Changelog
* Improve `normalize_batch` `ValueError` message with suggestions on how to fix
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4614/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4614/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4613 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4613/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4613/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4613/events | https://github.com/NVIDIA/NeMo/pull/4613 | 1,318,458,993 | PR_kwDOC_bI7s48H7g9 | 4,613 | Add option to save VAD artifacts | {
"login": "findkim",
"id": 6362111,
"node_id": "MDQ6VXNlcjYzNjIxMTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/6362111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/findkim",
"html_url": "https://github.com/findkim",
"followers_url": "https://api.github.com/users/findkim/followers",
"following_url": "https://api.github.com/users/findkim/following{/other_user}",
"gists_url": "https://api.github.com/users/findkim/gists{/gist_id}",
"starred_url": "https://api.github.com/users/findkim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/findkim/subscriptions",
"organizations_url": "https://api.github.com/users/findkim/orgs",
"repos_url": "https://api.github.com/users/findkim/repos",
"events_url": "https://api.github.com/users/findkim/events{/privacy}",
"received_events_url": "https://api.github.com/users/findkim/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-26T16:06:22 | 2022-10-21T02:12:17 | 2022-10-21T02:12:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4613",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4613",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4613.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4613.patch",
"merged_at": null
} | # What does this PR do ?
* Adds utility option to save input and output tensors for VAD model inference useful for testing and comparison in isolation from pre/post processing
* Adds support to disable median filtering for VAD post processing, (`None`, `False`, `''`)
**Collection**: ASR
# Changelog
- Add VAD options to save artifacts and disable median filtering
# Usage
examples/asr/conf/vad/vad_inference_postprocessing.yaml
```yaml
vad:
parameters:
smoothing: None
save_artifacts: False
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4613/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4613/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4610 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4610/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4610/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4610/events | https://github.com/NVIDIA/NeMo/pull/4610 | 1,317,641,350 | PR_kwDOC_bI7s48FOYS | 4,610 | [TN] bug fix "hundred" in Audio-based, added method so split text in sentences | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-26T03:18:31 | 2022-07-29T19:13:41 | 2022-07-29T19:12:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4610",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4610",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4610.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4610.patch",
"merged_at": "2022-07-29T19:12:22"
} | # What does this PR do ?
Bug fix for Audio-based TN when "hundred" is optional, new method to split text into sentences before TN
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ X] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4610/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4610/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4609 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4609/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4609/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4609/events | https://github.com/NVIDIA/NeMo/pull/4609 | 1,317,502,133 | PR_kwDOC_bI7s48ExvB | 4,609 | [ASR] Adding Speech separation models to NeMo | {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-25T23:40:14 | 2022-10-12T02:33:01 | 2022-10-12T02:33:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4609",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4609",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4609.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4609.patch",
"merged_at": null
} | # What does this PR do ?
Adds speech separation model to NeMo.
**Collection**: ASR
# Changelog
- High level script for speech separation `examples/speech_tasks/separation/speech_separation.py`
- Sample config file `examples/speech_tasks/separation/conf/sep_transformer.yaml`
- Separation model `nemo/collections/asr/models/ss_model.py`
- Pre-processor `AudioToFeaturesConvPreprocessor` in `nemo/collections/asr/modules/audio_preprocessing.py`
- Decoder `nemo/collections/asr/modules/ss_decoder.py`
- Loss `nemo/collections/asr/losses/ss_losses/si_snr.py`
- Dataset `nemo/collections/asr/data/audio_to_audio.py`
- Inference `EncDecSpeechSeparationModel.extract_sources()` in `nemo/collections/asr/models/ss_model.py`
# Usage
```python
# load model
cfg = {'init_from_nemo_model': '<path_to_nemo_ckpt>'}
cfg = OmegaConf.create(cfg)
model_cfg = ASRModel.restore_from(restore_path=cfg.init_from_nemo_model, return_config=True)
sep_model = EncDecSpeechSeparationModel(cfg=model_cfg)
sep_model.maybe_init_from_pretrained_checkpoint(cfg, map_location='cpu')
# run inference
paths2audio_files=[<list_of_audio_mixtures_to_separate>]
sep_model.extract_sources(
paths2audio_files = paths2audio_files,
save_dir='<path_to_save_separated_sources>',
orig_sr=16000,
num_sources=2,
batch_size=1,
num_workers=1,
)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4609/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4609/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4608 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4608/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4608/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4608/events | https://github.com/NVIDIA/NeMo/pull/4608 | 1,317,500,608 | PR_kwDOC_bI7s48ExbG | 4,608 | Update Offline ASR with CTC Decoding | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T23:37:41 | 2022-07-26T22:14:07 | 2022-07-26T22:14:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4608",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4608",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4608.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4608.patch",
"merged_at": "2022-07-26T22:14:03"
} | # What does this PR do ?
Add support for subword time stamping using CTC decoding strategy.
**Collection**: [ASR]
# Changelog
- Fix mistake in selection of word boundaries for subword models
- Update tutorial with subword time stamp computation.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4608/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4608/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4607 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4607/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4607/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4607/events | https://github.com/NVIDIA/NeMo/pull/4607 | 1,317,482,667 | PR_kwDOC_bI7s48EtvX | 4,607 | Updating the default parameters in the example adapters config file | {
"login": "shan18",
"id": 12576178,
"node_id": "MDQ6VXNlcjEyNTc2MTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shan18",
"html_url": "https://github.com/shan18",
"followers_url": "https://api.github.com/users/shan18/followers",
"following_url": "https://api.github.com/users/shan18/following{/other_user}",
"gists_url": "https://api.github.com/users/shan18/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shan18/subscriptions",
"organizations_url": "https://api.github.com/users/shan18/orgs",
"repos_url": "https://api.github.com/users/shan18/repos",
"events_url": "https://api.github.com/users/shan18/events{/privacy}",
"received_events_url": "https://api.github.com/users/shan18/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T23:10:55 | 2022-07-26T18:54:55 | 2022-07-26T18:54:55 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4607",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4607",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4607.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4607.patch",
"merged_at": "2022-07-26T18:54:55"
} | # What does this PR do ?
Updates the default values of the warmup and the layer norm in the example adapter config file. It also adds the option to specify tags as well as offline logging of wandb.
**Collection**: asr
# Changelog
File modified: `examples/asr/conf/asr_adapters/asr_adaptation.yaml`
- Adapters now use pre-norm by default
- The default number of warmup steps is set to 10% of the training set
- Added two parameters: `offline` and `tags` within the `wandb_logger_kwargs` config to allow specifying offline logging and tags for each run respectively.
# Before your PR is “Ready for review”
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven’t finished some of the above items you can still open “Draft” PR.
## Who can review?
Anyone in NeMo ASR. | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4607/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4607/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4605 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4605/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4605/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4605/events | https://github.com/NVIDIA/NeMo/pull/4605 | 1,317,470,227 | PR_kwDOC_bI7s48ErGC | 4,605 | Updating the default parameters in the example adapters config file | {
"login": "shan18",
"id": 12576178,
"node_id": "MDQ6VXNlcjEyNTc2MTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shan18",
"html_url": "https://github.com/shan18",
"followers_url": "https://api.github.com/users/shan18/followers",
"following_url": "https://api.github.com/users/shan18/following{/other_user}",
"gists_url": "https://api.github.com/users/shan18/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shan18/subscriptions",
"organizations_url": "https://api.github.com/users/shan18/orgs",
"repos_url": "https://api.github.com/users/shan18/repos",
"events_url": "https://api.github.com/users/shan18/events{/privacy}",
"received_events_url": "https://api.github.com/users/shan18/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T22:55:12 | 2022-07-25T23:01:33 | 2022-07-25T23:01:33 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4605",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4605",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4605.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4605.patch",
"merged_at": null
} | # What does this PR do ?
Updates the default values of the warmup and the layer norm in the example adapter config file. It also adds the option to specify tags as well as offline logging of wandb.
**Collection**: asr
# Changelog
File modified: `examples/asr/conf/asr_adapters/asr_adaptation.yaml`
- Adapters now use pre-norm by default
- The default number of warmup steps is set to 10% of the training set
- Added two parameters: `offline` and `tags` within the `wandb_logger_kwargs` config to allow specifying offline logging and tags for each run respectively.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in NeMo ASR.
| {
"login": "shan18",
"id": 12576178,
"node_id": "MDQ6VXNlcjEyNTc2MTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shan18",
"html_url": "https://github.com/shan18",
"followers_url": "https://api.github.com/users/shan18/followers",
"following_url": "https://api.github.com/users/shan18/following{/other_user}",
"gists_url": "https://api.github.com/users/shan18/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shan18/subscriptions",
"organizations_url": "https://api.github.com/users/shan18/orgs",
"repos_url": "https://api.github.com/users/shan18/repos",
"events_url": "https://api.github.com/users/shan18/events{/privacy}",
"received_events_url": "https://api.github.com/users/shan18/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4605/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4605/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4604 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4604/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4604/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4604/events | https://github.com/NVIDIA/NeMo/pull/4604 | 1,317,469,706 | PR_kwDOC_bI7s48Eq_F | 4,604 | G2P Aligner | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T22:54:21 | 2022-07-29T04:19:13 | 2022-07-29T04:19:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4604",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4604",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4604.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4604.patch",
"merged_at": "2022-07-29T04:19:10"
} | # What does this PR do ?
Adds a script and a tutorial for using a trained RAD-TTS Aligner as a G2P disambiguation tool.
**Collection**: TTS
# Changelog
- Created the `aligner_g2p.py` script for disambiguating heteronym pronunciations
- Added a new TTS Aligner example tutorial, which includes visualizations and demonstration of how heteronym disambiguation works
# Usage
For the disambiguation script:
```
python aligner_g2p.py \
--model=<model_path> \
--manifest=<manifest_path> \
--out=<output_json_path> \
--confidence=0.02 \
--verbose
```
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [x] Documentation | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4604/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4604/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4603 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4603/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4603/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4603/events | https://github.com/NVIDIA/NeMo/pull/4603 | 1,317,459,219 | PR_kwDOC_bI7s48Eo0w | 4,603 | r1.10.0 MegaMolBART Compatibility | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T22:37:44 | 2022-08-04T18:08:19 | 2022-07-29T00:34:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4603",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4603",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4603.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4603.patch",
"merged_at": "2022-07-29T00:34:44"
} | # What does this PR do ?
1. Fixes RegExTokenizer missing attributes.
2. Fixes broken Megatron encoder-decoder LM model ability to receive directly encoder hiddens.
```
MegatronLMEncoderDecoderModel.forward(
self,
encoder_input_ids,
decoder_input_ids,
encoder_attn_mask,
decoder_attn_mask,
token_type_ids=None,
lm_labels=None,
# NEW API
enc_output=None,
enc_output_attn_mask=None,
# NEW API
output_enc_hidden_only=False,
enc_input=None,
):
```
3. Added MegatronLMEncoderDecoderModel.encode method.
4. Improved decoding speed.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4603/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4603/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4602 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4602/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4602/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4602/events | https://github.com/NVIDIA/NeMo/pull/4602 | 1,317,420,671 | PR_kwDOC_bI7s48EggC | 4,602 | Label Smoothing in VocabParallelCrossEntropy | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T21:57:24 | 2022-08-04T07:13:08 | 2022-08-04T07:13:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4602",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4602",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4602.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4602.patch",
"merged_at": "2022-08-04T07:13:05"
} | # What does this PR do ?
Adds label smoothing for VocabParallelCrossEntropy
**Collection**: [Note which collection this PR will affect]
# Changelog
- Adds the label smoothing arg to VocabParallelCrossEntropy
# Usage
* `model.label_smoothing=0.1`
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4602/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4602/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4601 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4601/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4601/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4601/events | https://github.com/NVIDIA/NeMo/issues/4601 | 1,317,407,192 | I_kwDOC_bI7s5OhgnY | 4,601 | Key Error when using conformer-transducer-bpe | {
"login": "sepehr3pehr",
"id": 12605042,
"node_id": "MDQ6VXNlcjEyNjA1MDQy",
"avatar_url": "https://avatars.githubusercontent.com/u/12605042?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sepehr3pehr",
"html_url": "https://github.com/sepehr3pehr",
"followers_url": "https://api.github.com/users/sepehr3pehr/followers",
"following_url": "https://api.github.com/users/sepehr3pehr/following{/other_user}",
"gists_url": "https://api.github.com/users/sepehr3pehr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sepehr3pehr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sepehr3pehr/subscriptions",
"organizations_url": "https://api.github.com/users/sepehr3pehr/orgs",
"repos_url": "https://api.github.com/users/sepehr3pehr/repos",
"events_url": "https://api.github.com/users/sepehr3pehr/events{/privacy}",
"received_events_url": "https://api.github.com/users/sepehr3pehr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T21:40:04 | 2022-07-25T21:47:09 | 2022-07-25T21:47:09 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I am trying to train a conformer-transducer ASR model with BERT tokenizer. I am using `conformer_transducer_bpe.yaml` as the base of my config with few changes to set the tokenizer. When running it, I get the following error:
```
raise ex.with_traceback(sys.exc_info()[2]) # set end OC_CAUSE=1 for full backtrace
omegaconf.errors.ConfigKeyError: Key 'num_classes' is not in struct
full_key: decoder.num_classes
object_type=dict
```
so I decided to set the decode.num_classes to -1 but then I get this error:
```
raise InstantiationException(msg) from e
hydra.errors.InstantiationException: Error in call to target 'nemo.collections.asr.modules.rnnt.RNNTDecoder':
TypeError("__init__() got an unexpected keyword argument 'num_classes'")
``` | {
"login": "sepehr3pehr",
"id": 12605042,
"node_id": "MDQ6VXNlcjEyNjA1MDQy",
"avatar_url": "https://avatars.githubusercontent.com/u/12605042?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sepehr3pehr",
"html_url": "https://github.com/sepehr3pehr",
"followers_url": "https://api.github.com/users/sepehr3pehr/followers",
"following_url": "https://api.github.com/users/sepehr3pehr/following{/other_user}",
"gists_url": "https://api.github.com/users/sepehr3pehr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sepehr3pehr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sepehr3pehr/subscriptions",
"organizations_url": "https://api.github.com/users/sepehr3pehr/orgs",
"repos_url": "https://api.github.com/users/sepehr3pehr/repos",
"events_url": "https://api.github.com/users/sepehr3pehr/events{/privacy}",
"received_events_url": "https://api.github.com/users/sepehr3pehr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4601/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4601/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4600 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4600/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4600/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4600/events | https://github.com/NVIDIA/NeMo/pull/4600 | 1,317,312,747 | PR_kwDOC_bI7s48EJnB | 4,600 | Dividing generative question-answering CI tests | {
"login": "ameyasm1154",
"id": 34514696,
"node_id": "MDQ6VXNlcjM0NTE0Njk2",
"avatar_url": "https://avatars.githubusercontent.com/u/34514696?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ameyasm1154",
"html_url": "https://github.com/ameyasm1154",
"followers_url": "https://api.github.com/users/ameyasm1154/followers",
"following_url": "https://api.github.com/users/ameyasm1154/following{/other_user}",
"gists_url": "https://api.github.com/users/ameyasm1154/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ameyasm1154/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ameyasm1154/subscriptions",
"organizations_url": "https://api.github.com/users/ameyasm1154/orgs",
"repos_url": "https://api.github.com/users/ameyasm1154/repos",
"events_url": "https://api.github.com/users/ameyasm1154/events{/privacy}",
"received_events_url": "https://api.github.com/users/ameyasm1154/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T20:10:08 | 2022-07-26T01:49:03 | 2022-07-26T01:48:54 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4600",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4600",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4600.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4600.patch",
"merged_at": "2022-07-26T01:48:54"
} | Signed-off-by: Ameya Mahabaleshwarkar <[email protected]>
# What does this PR do ?
Split CI tests for generative question-answering into multiple stages to reduce memory usage
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4600/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4600/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4599 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4599/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4599/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4599/events | https://github.com/NVIDIA/NeMo/pull/4599 | 1,317,232,903 | PR_kwDOC_bI7s48D450 | 4,599 | Testing lengths output from decoder for ragged batching. | {
"login": "anthonym225",
"id": 46829430,
"node_id": "MDQ6VXNlcjQ2ODI5NDMw",
"avatar_url": "https://avatars.githubusercontent.com/u/46829430?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anthonym225",
"html_url": "https://github.com/anthonym225",
"followers_url": "https://api.github.com/users/anthonym225/followers",
"following_url": "https://api.github.com/users/anthonym225/following{/other_user}",
"gists_url": "https://api.github.com/users/anthonym225/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anthonym225/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anthonym225/subscriptions",
"organizations_url": "https://api.github.com/users/anthonym225/orgs",
"repos_url": "https://api.github.com/users/anthonym225/repos",
"events_url": "https://api.github.com/users/anthonym225/events{/privacy}",
"received_events_url": "https://api.github.com/users/anthonym225/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-25T18:53:35 | 2022-10-06T02:13:20 | 2022-10-06T02:13:20 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4599",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4599",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4599.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4599.patch",
"merged_at": null
} | # What does this PR do ?
Trying to return model output with lengths is not exporting correctly.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4599/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4599/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4598 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4598/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4598/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4598/events | https://github.com/NVIDIA/NeMo/pull/4598 | 1,317,163,273 | PR_kwDOC_bI7s48DqYI | 4,598 | T0 model and dataset | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T17:45:17 | 2022-08-01T18:33:48 | 2022-08-01T18:33:45 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4598",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4598",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4598.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4598.patch",
"merged_at": "2022-08-01T18:33:45"
} | # What does this PR do ?
Adds the T0 Dataset and Model classes.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Adds the T0 dataset and model class files
- Repurposes the generic fine-tuning run script for T0
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4598/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4598/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4596 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4596/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4596/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4596/events | https://github.com/NVIDIA/NeMo/issues/4596 | 1,316,500,507 | I_kwDOC_bI7s5OeDQb | 4,596 | Does non-English TTS training work properly now? | {
"login": "aidosRepoint",
"id": 64583282,
"node_id": "MDQ6VXNlcjY0NTgzMjgy",
"avatar_url": "https://avatars.githubusercontent.com/u/64583282?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aidosRepoint",
"html_url": "https://github.com/aidosRepoint",
"followers_url": "https://api.github.com/users/aidosRepoint/followers",
"following_url": "https://api.github.com/users/aidosRepoint/following{/other_user}",
"gists_url": "https://api.github.com/users/aidosRepoint/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aidosRepoint/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aidosRepoint/subscriptions",
"organizations_url": "https://api.github.com/users/aidosRepoint/orgs",
"repos_url": "https://api.github.com/users/aidosRepoint/repos",
"events_url": "https://api.github.com/users/aidosRepoint/events{/privacy}",
"received_events_url": "https://api.github.com/users/aidosRepoint/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | true | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "aroraakshit",
"id": 30349184,
"node_id": "MDQ6VXNlcjMwMzQ5MTg0",
"avatar_url": "https://avatars.githubusercontent.com/u/30349184?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aroraakshit",
"html_url": "https://github.com/aroraakshit",
"followers_url": "https://api.github.com/users/aroraakshit/followers",
"following_url": "https://api.github.com/users/aroraakshit/following{/other_user}",
"gists_url": "https://api.github.com/users/aroraakshit/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aroraakshit/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aroraakshit/subscriptions",
"organizations_url": "https://api.github.com/users/aroraakshit/orgs",
"repos_url": "https://api.github.com/users/aroraakshit/repos",
"events_url": "https://api.github.com/users/aroraakshit/events{/privacy}",
"received_events_url": "https://api.github.com/users/aroraakshit/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-25T09:03:37 | 2022-07-25T23:10:53 | 2022-07-25T23:10:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi all!
I've come across this [issue](https://github.com/NVIDIA/NeMo/issues/234) from 2020, which clearly shows that non-English TTS had some issues at that time. Has the state of things changed since then?
I need to train Tacotron2 for Russian, but I face so many troubles in preprocessing stage. Mainly with text preprocessing. Unfortunately, I couldn't find any decent tutorials on how to train a model for a non-English dataset.
Can anyone help? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4596/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4596/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4595 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4595/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4595/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4595/events | https://github.com/NVIDIA/NeMo/pull/4595 | 1,316,443,286 | PR_kwDOC_bI7s48BQek | 4,595 | add kw asr models, add itn ru checkpoint (tagger-based) | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-25T08:15:15 | 2022-07-25T20:26:56 | 2022-07-25T20:26:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4595",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4595",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4595.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4595.patch",
"merged_at": "2022-07-25T20:26:53"
} | Signed-off-by: Alexandra Antonova <[email protected]>
# What does this PR do ?
Add two ASR models for Kinyarwanda (ctc and transducer large), add tagger-based ITN model for Russian
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4595/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4595/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4594 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4594/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4594/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4594/events | https://github.com/NVIDIA/NeMo/pull/4594 | 1,315,989,668 | PR_kwDOC_bI7s47_6Zf | 4,594 | A new fused softmax kernel function | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-07-24T19:28:58 | 2023-02-22T18:42:13 | 2022-09-30T21:44:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4594",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4594",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4594.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4594.patch",
"merged_at": null
} | # What does this PR do ?
Implemented the fused softmax GPU kernel that can be a drop-in replacement of the `apex`'s FusedScaleMaskSoftmax`. It addresses the following issues:
1. Removed the sequence length limitation. It works with tensor of any length.
2. Fix the `grad_input` modification issue https://github.com/NVIDIA/apex/issues/1430
3. Fix the problem when all keys are masked https://github.com/NVIDIA/apex/issues/1390
It uses the torch.cppextension to build the kernel dynamically like MegatronLM repo does. The kernels will be saved in the `/tmp` directory so it can be used in slurm with enroot clusters too.
It includes a unit test to cover a few cases.
The performance is comparable to the apex one. Here is a training step time graph when it is tested with training a RETRO model.
The blue curve is pytorch softmax. The bottom red curve is apex fused kernel and the middle red curve the fused kernel in this PR.
| {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4594/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4594/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4593 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4593/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4593/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4593/events | https://github.com/NVIDIA/NeMo/issues/4593 | 1,315,893,388 | I_kwDOC_bI7s5ObvCM | 4,593 | ASR for long audio files (streaming) with Beam Search/LM | {
"login": "Orelbabayoff",
"id": 25223931,
"node_id": "MDQ6VXNlcjI1MjIzOTMx",
"avatar_url": "https://avatars.githubusercontent.com/u/25223931?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Orelbabayoff",
"html_url": "https://github.com/Orelbabayoff",
"followers_url": "https://api.github.com/users/Orelbabayoff/followers",
"following_url": "https://api.github.com/users/Orelbabayoff/following{/other_user}",
"gists_url": "https://api.github.com/users/Orelbabayoff/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Orelbabayoff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Orelbabayoff/subscriptions",
"organizations_url": "https://api.github.com/users/Orelbabayoff/orgs",
"repos_url": "https://api.github.com/users/Orelbabayoff/repos",
"events_url": "https://api.github.com/users/Orelbabayoff/events{/privacy}",
"received_events_url": "https://api.github.com/users/Orelbabayoff/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | true | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-24T12:23:22 | 2022-07-25T17:35:35 | 2022-07-25T17:35:35 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi
Following older answers for closed issues: https://github.com/NVIDIA/NeMo/issues/2307 and the tutorial: https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Streaming_ASR.ipynb.
Any updates on Nemo supporting LM with long audio (streaming)?
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4593/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4593/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4592 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4592/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4592/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4592/events | https://github.com/NVIDIA/NeMo/pull/4592 | 1,315,773,247 | PR_kwDOC_bI7s47_RE- | 4,592 | Add DALI char dataset support to SSL model | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-24T00:21:03 | 2022-07-25T23:17:52 | 2022-07-25T23:17:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4592",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4592",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4592.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4592.patch",
"merged_at": "2022-07-25T23:17:52"
} | # What does this PR do ?
Use DALI pipelines as part of `ssl_models`
**Collection**: ASR
# Changelog
- Add DALI char dataset support to SSL model
**PR Type**:
- New Feature
Tested manually by running 1 validation step on a local dataset.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #4591
| {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4592/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4591 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4591/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4591/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4591/events | https://github.com/NVIDIA/NeMo/issues/4591 | 1,315,687,975 | I_kwDOC_bI7s5Oa84n | 4,591 | SpeechEncDecSelfSupervisedModel does not support Dali datasets | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-23T15:47:41 | 2022-07-25T23:18:44 | 2022-07-25T23:18:44 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
I noticed `SpeechEncDecSelfSupervisedModel`'s don't check if `use_dali` is set in their `_setup_dataloader_from_config()` method.
Is that intended? I noticed some performance improvements using Dali and the error traces it returns are much more helpful than the typical audio dataset ones.
**Describe the solution you'd like**
Just add
```py
device = 'gpu' if torch.cuda.is_available() else 'cpu'
if config.get('use_dali', False):
device_id = self.local_rank if device == 'gpu' else None
dataset = audio_to_text_dataset.get_dali_bpe_dataset(
config=config,
tokenizer=self.tokenizer,
shuffle=shuffle,
device_id=device_id,
global_rank=self.global_rank,
world_size=self.world_size,
preprocessor_cfg=self._cfg.preprocessor,
)
return dataset
```
to `_setup_dataloader_from_config` in `SpeechEncDecSelfSupervisedModel`.
I can open a PR if this if fine, but wanted to see if there was an explicit reason not to include it.
| {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4591/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4591/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4590 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4590/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4590/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4590/events | https://github.com/NVIDIA/NeMo/issues/4590 | 1,315,626,089 | I_kwDOC_bI7s5Oatxp | 4,590 | convert conformer to TRT | {
"login": "sarasesar",
"id": 95332871,
"node_id": "U_kgDOBa6qBw",
"avatar_url": "https://avatars.githubusercontent.com/u/95332871?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sarasesar",
"html_url": "https://github.com/sarasesar",
"followers_url": "https://api.github.com/users/sarasesar/followers",
"following_url": "https://api.github.com/users/sarasesar/following{/other_user}",
"gists_url": "https://api.github.com/users/sarasesar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sarasesar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sarasesar/subscriptions",
"organizations_url": "https://api.github.com/users/sarasesar/orgs",
"repos_url": "https://api.github.com/users/sarasesar/repos",
"events_url": "https://api.github.com/users/sarasesar/events{/privacy}",
"received_events_url": "https://api.github.com/users/sarasesar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-23T10:30:26 | 2022-09-08T17:44:54 | 2022-07-25T18:23:22 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi, I trained a conformer CTC BPE model. Now I wanna convert it to TensorRT.
Is it possible or not?
If yes, how can I do it?
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4590/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4590/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4589 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4589/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4589/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4589/events | https://github.com/NVIDIA/NeMo/issues/4589 | 1,315,519,173 | I_kwDOC_bI7s5OaTrF | 4,589 | Contrastive Loss: Runtime error for certain audio files when reshaping out_masked_only | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-23T01:16:57 | 2022-10-06T02:13:23 | 2022-10-06T02:13:23 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
After a few steps when pretraining a `SpeechEncDecSelfSupervisedModel`, training fails with the following error
```sh
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/models/ssl_models.py", line 468, in training_step
loss_value, loss_val_dict = self.decoder_loss_step(
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/models/ssl_models.py", line 450, in decoder_loss_step
current_loss_value = current_loss(
File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1129, in _call_impl
return forward_call(*input, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/core/classes/common.py", line 963, in __call__
outputs = wrapped(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/losses/ssl_losses/contrastive.py", line 187, in forward
out_masked_only = out_masked_only.reshape(bs, -1, out_masked_only.shape[-1])
RuntimeError: shape '[16, -1, 128]' is invalid for input of size 547712
```
**Steps/Code to reproduce bug**
I used the [speech_pre_training.py](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/speech_pretraining/speech_pre_training.py) script with the default configuration for the conformer [here](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/conf/ssl/conformer/conformer_ssl.yaml).
I only modified `train_ds.max_duration: 25.0`.
I also tried the config in the [Self_Supervised_Pre_Training.ipynb](https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Self_Supervised_Pre_Training.ipynb) notebook and I got the same error.
**Expected behavior**
Training should process normally and/or a more detailed explanation why the reshape failed and what parameters to change.
**Environment overview (please complete the following information)**
- Environment location: Docker (`nvcr.io/nvidia/pytorch:22.05-py3`)
- Method of NeMo install: `pip install 'nemo_toolkit[all]==1.10.0'`
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
```sh
docker run --rm -it --gpus all --ipc=host --env-file .env train
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4589/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4589/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4588 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4588/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4588/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4588/events | https://github.com/NVIDIA/NeMo/pull/4588 | 1,315,481,983 | PR_kwDOC_bI7s47-ZVQ | 4,588 | Fixed in_features dim if bidirectional is True | {
"login": "farisalasmary",
"id": 8818059,
"node_id": "MDQ6VXNlcjg4MTgwNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/8818059?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/farisalasmary",
"html_url": "https://github.com/farisalasmary",
"followers_url": "https://api.github.com/users/farisalasmary/followers",
"following_url": "https://api.github.com/users/farisalasmary/following{/other_user}",
"gists_url": "https://api.github.com/users/farisalasmary/gists{/gist_id}",
"starred_url": "https://api.github.com/users/farisalasmary/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/farisalasmary/subscriptions",
"organizations_url": "https://api.github.com/users/farisalasmary/orgs",
"repos_url": "https://api.github.com/users/farisalasmary/repos",
"events_url": "https://api.github.com/users/farisalasmary/events{/privacy}",
"received_events_url": "https://api.github.com/users/farisalasmary/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-22T23:12:59 | 2022-08-25T21:17:30 | 2022-08-25T21:17:30 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4588",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4588",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4588.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4588.patch",
"merged_at": "2022-08-25T21:17:30"
} | Signed-off-by: Faris Abdullah Alasmary <[email protected]>
# What does this PR do ?
Fix a bug in LSTM decoder while using bidirectional LSTM
**Collection**: ASR
# Changelog
- Adding one line of code to check if the argument `bidirectional` is True and multiply `lstm_hidden_size` by 2 since the output vector of both directions have the same size and they are concatenated to form the final output of the LSTM model.
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jbalam-nv",
"id": 4916480,
"node_id": "MDQ6VXNlcjQ5MTY0ODA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4916480?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbalam-nv",
"html_url": "https://github.com/jbalam-nv",
"followers_url": "https://api.github.com/users/jbalam-nv/followers",
"following_url": "https://api.github.com/users/jbalam-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/jbalam-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbalam-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbalam-nv/subscriptions",
"organizations_url": "https://api.github.com/users/jbalam-nv/orgs",
"repos_url": "https://api.github.com/users/jbalam-nv/repos",
"events_url": "https://api.github.com/users/jbalam-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbalam-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4588/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4588/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4587 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4587/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4587/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4587/events | https://github.com/NVIDIA/NeMo/issues/4587 | 1,315,308,651 | I_kwDOC_bI7s5OZgRr | 4,587 | RuntimeError for contrastive loss if audio duration is not long enough for num_negatives | {
"login": "piraka9011",
"id": 16828657,
"node_id": "MDQ6VXNlcjE2ODI4NjU3",
"avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/piraka9011",
"html_url": "https://github.com/piraka9011",
"followers_url": "https://api.github.com/users/piraka9011/followers",
"following_url": "https://api.github.com/users/piraka9011/following{/other_user}",
"gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}",
"starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions",
"organizations_url": "https://api.github.com/users/piraka9011/orgs",
"repos_url": "https://api.github.com/users/piraka9011/repos",
"events_url": "https://api.github.com/users/piraka9011/events{/privacy}",
"received_events_url": "https://api.github.com/users/piraka9011/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-22T18:36:21 | 2024-02-22T05:40:33 | 2022-10-06T02:13:24 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
If the duration of an audio file is <8s (unsure exactly, need further testing), then `sample_negatives` will throw the following error:
```sh
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/models/ssl_models.py", line 491, in validation_step
loss_value, _ = self.decoder_loss_step(spectrograms, spec_masks, encoded, encoded_len, targets, target_lengths)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/models/ssl_models.py", line 450, in decoder_loss_step
current_loss_value = current_loss(
File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1129, in _call_impl
return forward_call(*input, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/core/classes/common.py", line 963, in __call__
outputs = wrapped(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/losses/ssl_losses/contrastive.py", line 205, in forward
negatives, _ = self.sample_negatives(targets_masked_only, targets_masked_only.size(0)) # T'xBxC # T'
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/asr/losses/ssl_losses/contrastive.py", line 139, in sample_negatives
neg_idxs = torch.multinomial(torch.ones((num, high), device=y.device), self.num_negatives)
RuntimeError: cannot sample n_sample > prob_dist.size(-1) samples without replacement
```
If you haven't read the docs or understand the code/loss function, then it might not be clear that you need to adjust the `min_duration` or `num_negatives`
**Steps/Code to reproduce bug**
Run any of the examples in [`speech_pretraining`](https://github.com/NVIDIA/NeMo/tree/main/examples/asr/speech_pretraining) with `train/validation_ds.min_duration < 8.0`
**Expected behavior**
While this is expected to fail, I would like to propose that we catch this error and replace with something more...constructive.
I can open a PR, but wanted to see if the maintainers are open to the suggestion.
My suggestion is to re-raise with a `NeMoBaseException` (or make a new one? `LossMisconfigurationError`?) with the suggestion to either adjust `num_negative` or the `min_duration`.
Edit: I realized I opened this as a bug, but it should've been a feature suggestion. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4587/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4587/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4586 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4586/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4586/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4586/events | https://github.com/NVIDIA/NeMo/issues/4586 | 1,315,255,600 | I_kwDOC_bI7s5OZTUw | 4,586 | text normalization documentation should mention the 500 word limit | {
"login": "f4hy",
"id": 36440,
"node_id": "MDQ6VXNlcjM2NDQw",
"avatar_url": "https://avatars.githubusercontent.com/u/36440?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/f4hy",
"html_url": "https://github.com/f4hy",
"followers_url": "https://api.github.com/users/f4hy/followers",
"following_url": "https://api.github.com/users/f4hy/following{/other_user}",
"gists_url": "https://api.github.com/users/f4hy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/f4hy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/f4hy/subscriptions",
"organizations_url": "https://api.github.com/users/f4hy/orgs",
"repos_url": "https://api.github.com/users/f4hy/repos",
"events_url": "https://api.github.com/users/f4hy/events{/privacy}",
"received_events_url": "https://api.github.com/users/f4hy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
},
{
"id": 4910680898,
"node_id": "LA_kwDOC_bI7s8AAAABJLMLQg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TN/ITN",
"name": "TN/ITN",
"color": "0052cc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-07-22T17:29:27 | 2022-12-19T21:46:20 | 2022-08-10T20:14:37 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
normalize() has a `500` word limit per here: https://github.com/NVIDIA/NeMo/blob/main/nemo_text_processing/text_normalization/normalize.py#L255
This is not documented in the documentation pages as far as I can see.
**Describe the solution you'd like**
Documentation should make this requirement clear up front, so when developing a pipeline which uses nemo text normalization one is not surprised by crashes when are large input comes through. Instead developers could split into sentences knowing it is a requirement of this method.
Bonus: explain why there is a 500 word limit.
**Describe alternatives you've considered**
Seems like a text normalizer model would know where sentence bounds are to be able to operate, so the normalizer could split into sentences itself and process the sentences, removing this limitation. | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4586/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4586/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4585 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4585/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4585/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4585/events | https://github.com/NVIDIA/NeMo/pull/4585 | 1,315,219,137 | PR_kwDOC_bI7s479hBQ | 4,585 | Fix metric setup for finetuning without a test set | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-07-22T16:43:59 | 2022-07-28T20:38:21 | 2022-07-28T20:36:47 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4585",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4585",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4585.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4585.patch",
"merged_at": "2022-07-28T20:36:47"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Fixes a bug in setup_metric() when fine-tuning without a specified test set.
**Collection**: NLP
# Changelog
- Use the provided data_cfg to instantiate a metric rather than test_ds.
# Usage
* N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4585/timeline | null | null | true |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.