url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/4253 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4253/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4253/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4253/events | https://github.com/NVIDIA/NeMo/issues/4253 | 1,247,220,886 | I_kwDOC_bI7s5KVxSW | 4,253 | Fastpitch TTS in other languages | {
"login": "davidmartinrius",
"id": 16558194,
"node_id": "MDQ6VXNlcjE2NTU4MTk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16558194?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmartinrius",
"html_url": "https://github.com/davidmartinrius",
"followers_url": "https://api.github.com/users/davidmartinrius/followers",
"following_url": "https://api.github.com/users/davidmartinrius/following{/other_user}",
"gists_url": "https://api.github.com/users/davidmartinrius/gists{/gist_id}",
"starred_url": "https://api.github.com/users/davidmartinrius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidmartinrius/subscriptions",
"organizations_url": "https://api.github.com/users/davidmartinrius/orgs",
"repos_url": "https://api.github.com/users/davidmartinrius/repos",
"events_url": "https://api.github.com/users/davidmartinrius/events{/privacy}",
"received_events_url": "https://api.github.com/users/davidmartinrius/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "aroraakshit",
"id": 30349184,
"node_id": "MDQ6VXNlcjMwMzQ5MTg0",
"avatar_url": "https://avatars.githubusercontent.com/u/30349184?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aroraakshit",
"html_url": "https://github.com/aroraakshit",
"followers_url": "https://api.github.com/users/aroraakshit/followers",
"following_url": "https://api.github.com/users/aroraakshit/following{/other_user}",
"gists_url": "https://api.github.com/users/aroraakshit/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aroraakshit/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aroraakshit/subscriptions",
"organizations_url": "https://api.github.com/users/aroraakshit/orgs",
"repos_url": "https://api.github.com/users/aroraakshit/repos",
"events_url": "https://api.github.com/users/aroraakshit/events{/privacy}",
"received_events_url": "https://api.github.com/users/aroraakshit/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-24T23:22:23 | 2022-05-26T09:53:11 | 2022-05-26T09:53:10 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
I would like to train some models with fastpitch.
One model in Spanish and other model in Catalan.
Each language has its own alphabet, symbols, punctuations, tildes, phonemes, etc
1. How to define and set all of this properties to get started?
2. If there are other properties that need to be defined, which are?
Thank you!
David Martin Rius | {
"login": "davidmartinrius",
"id": 16558194,
"node_id": "MDQ6VXNlcjE2NTU4MTk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16558194?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmartinrius",
"html_url": "https://github.com/davidmartinrius",
"followers_url": "https://api.github.com/users/davidmartinrius/followers",
"following_url": "https://api.github.com/users/davidmartinrius/following{/other_user}",
"gists_url": "https://api.github.com/users/davidmartinrius/gists{/gist_id}",
"starred_url": "https://api.github.com/users/davidmartinrius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidmartinrius/subscriptions",
"organizations_url": "https://api.github.com/users/davidmartinrius/orgs",
"repos_url": "https://api.github.com/users/davidmartinrius/repos",
"events_url": "https://api.github.com/users/davidmartinrius/events{/privacy}",
"received_events_url": "https://api.github.com/users/davidmartinrius/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4253/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4253/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4252 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4252/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4252/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4252/events | https://github.com/NVIDIA/NeMo/issues/4252 | 1,247,208,558 | I_kwDOC_bI7s5KVuRu | 4,252 | Not sure how to train TTS model | {
"login": "davidmartinrius",
"id": 16558194,
"node_id": "MDQ6VXNlcjE2NTU4MTk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16558194?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmartinrius",
"html_url": "https://github.com/davidmartinrius",
"followers_url": "https://api.github.com/users/davidmartinrius/followers",
"following_url": "https://api.github.com/users/davidmartinrius/following{/other_user}",
"gists_url": "https://api.github.com/users/davidmartinrius/gists{/gist_id}",
"starred_url": "https://api.github.com/users/davidmartinrius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidmartinrius/subscriptions",
"organizations_url": "https://api.github.com/users/davidmartinrius/orgs",
"repos_url": "https://api.github.com/users/davidmartinrius/repos",
"events_url": "https://api.github.com/users/davidmartinrius/events{/privacy}",
"received_events_url": "https://api.github.com/users/davidmartinrius/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | true | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-24T22:58:57 | 2022-06-01T17:21:08 | 2022-06-01T17:21:08 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
In this post I would like to ask some questions.
As a premise I want to tell you what kind of machine I am working.
I have got an MSI Creator P100X -637
The specs are
GPU RTX 3080
64GB RAM
Intel Core i7-11700K
CPU 3.6 GHz
I work with trial an error and it is very confusing. Depending on the size of the dataset the GPU only accepts a limited max number in batch size.
For example, if I am going to train a dataset of 20 hours it will only accept a max batch size of 6. If I try a greater number it always raises an CUDA out of memory. (I supose it is the most common error when training)
On the other hand, if I am going to train a dataset of 5 hours aprox I can work with a batch size of 14 or 15.
### **Question 1/4.**
Is there a way to estimate the batch size previous to train?
Each time that I start training, if there is too much batch size it will crash. From I start training to crash it can pass like 15-20 minutes. This is because before start training the program needs to load all data previously. So i wasted a lot of time because until I don't find the good max batch size I can spend hours.
### **Question 2/4.**
Is there a way to estimate how many epochs to train a model based on the size of the dataset and the GPU batch size?
Now I set like 1000 epochs and I let the model training until the training loss is near to 0. But I am sure there is a cleaner way to do it.
### **Question 3/4.**
How to know how much time to train a model?
I supervised the trainings in tensorboard.
I deduced that I should evaluate the training loss of the model to know if is enough trained. But I am not sure of this.
### **Question 4/4.**
How to evaluate when a model is enough trained?
I spend a lots of hours trying to train a model without success. I am sure a lot of people that start with NeMo has this kind of doubts. Also I read a lot of discussions, issues, etc but I still did not solve this doubts.
So I would apreciate some help. I really want to train a TTS model with my own datasets.
Thank you! | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4252/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4252/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4251 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4251/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4251/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4251/events | https://github.com/NVIDIA/NeMo/pull/4251 | 1,247,104,541 | PR_kwDOC_bI7s44ZI4U | 4,251 | Refactored path to manifest | {
"login": "treacker",
"id": 36159472,
"node_id": "MDQ6VXNlcjM2MTU5NDcy",
"avatar_url": "https://avatars.githubusercontent.com/u/36159472?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/treacker",
"html_url": "https://github.com/treacker",
"followers_url": "https://api.github.com/users/treacker/followers",
"following_url": "https://api.github.com/users/treacker/following{/other_user}",
"gists_url": "https://api.github.com/users/treacker/gists{/gist_id}",
"starred_url": "https://api.github.com/users/treacker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/treacker/subscriptions",
"organizations_url": "https://api.github.com/users/treacker/orgs",
"repos_url": "https://api.github.com/users/treacker/repos",
"events_url": "https://api.github.com/users/treacker/events{/privacy}",
"received_events_url": "https://api.github.com/users/treacker/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-24T20:43:51 | 2022-06-08T05:28:13 | 2022-06-08T05:28:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4251",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4251",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4251.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4251.patch",
"merged_at": "2022-06-08T05:28:08"
} | Signed-off-by: Evgeniy Shabalin <[email protected]>
# What does this PR do ?
Updates various files with the new path for the LJSpeech whitelist file
**Collection**: TTS
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4251/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4251/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4250 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4250/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4250/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4250/events | https://github.com/NVIDIA/NeMo/pull/4250 | 1,247,041,189 | PR_kwDOC_bI7s44Y7QI | 4,250 | fixing bug 3642622 | {
"login": "pasandi20",
"id": 35242805,
"node_id": "MDQ6VXNlcjM1MjQyODA1",
"avatar_url": "https://avatars.githubusercontent.com/u/35242805?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pasandi20",
"html_url": "https://github.com/pasandi20",
"followers_url": "https://api.github.com/users/pasandi20/followers",
"following_url": "https://api.github.com/users/pasandi20/following{/other_user}",
"gists_url": "https://api.github.com/users/pasandi20/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pasandi20/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pasandi20/subscriptions",
"organizations_url": "https://api.github.com/users/pasandi20/orgs",
"repos_url": "https://api.github.com/users/pasandi20/repos",
"events_url": "https://api.github.com/users/pasandi20/events{/privacy}",
"received_events_url": "https://api.github.com/users/pasandi20/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T19:36:47 | 2022-05-24T21:43:29 | 2022-05-24T21:43:28 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4250",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4250",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4250.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4250.patch",
"merged_at": "2022-05-24T21:43:28"
} | Signed-off-by: Ghasem Pasandi <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4250/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4250/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4249 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4249/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4249/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4249/events | https://github.com/NVIDIA/NeMo/pull/4249 | 1,247,023,587 | PR_kwDOC_bI7s44Y3cd | 4,249 | Fixing bug #3642622 | {
"login": "pasandi20",
"id": 35242805,
"node_id": "MDQ6VXNlcjM1MjQyODA1",
"avatar_url": "https://avatars.githubusercontent.com/u/35242805?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pasandi20",
"html_url": "https://github.com/pasandi20",
"followers_url": "https://api.github.com/users/pasandi20/followers",
"following_url": "https://api.github.com/users/pasandi20/following{/other_user}",
"gists_url": "https://api.github.com/users/pasandi20/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pasandi20/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pasandi20/subscriptions",
"organizations_url": "https://api.github.com/users/pasandi20/orgs",
"repos_url": "https://api.github.com/users/pasandi20/repos",
"events_url": "https://api.github.com/users/pasandi20/events{/privacy}",
"received_events_url": "https://api.github.com/users/pasandi20/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T19:18:34 | 2022-05-24T20:12:40 | 2022-05-24T20:12:40 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4249",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4249",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4249.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4249.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4249/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4249/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4248 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4248/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4248/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4248/events | https://github.com/NVIDIA/NeMo/pull/4248 | 1,246,960,703 | PR_kwDOC_bI7s44Yp-0 | 4,248 | Fixes for Megatron Base Model Artifacts | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T18:14:59 | 2022-05-27T00:10:25 | 2022-05-27T00:10:21 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4248",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4248",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4248.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4248.patch",
"merged_at": "2022-05-27T00:10:21"
} | # What does this PR do ?
Fixes defaults for Megatron Base Model Artifacts.
**Collection**: NLP
# Changelog
- Changes defaults in megatron base model artifacts.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4248/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4248/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4247 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4247/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4247/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4247/events | https://github.com/NVIDIA/NeMo/pull/4247 | 1,246,653,936 | PR_kwDOC_bI7s44XoCN | 4,247 | Replace conditional imports in WFST based TN/ITN by importlib | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T14:32:41 | 2022-08-01T19:29:12 | 2022-08-01T19:29:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4247",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4247",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4247.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4247.patch",
"merged_at": null
} | # What does this PR do ?
Replace conditional imports in WFST based TN/ITN by importlib
Add support for
**Collection**: [Note which collection this PR will affect]
# Changelog
- Replace conditional imports in WFST based TN/ITN by importlib.
- Fix deleted support for lm and audio based text normalizer
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4247/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4247/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4246 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4246/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4246/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4246/events | https://github.com/NVIDIA/NeMo/pull/4246 | 1,246,218,867 | PR_kwDOC_bI7s44WNiS | 4,246 | Replace conditional imports in WFST based TN/ITN by importlib | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T08:54:16 | 2022-05-24T14:29:18 | 2022-05-24T14:29:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4246",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4246",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4246.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4246.patch",
"merged_at": null
} | Signed-off-by: Anand Joseph <[email protected]>
# What does this PR do ?
Replaces conditional imports in WFST based TN/ITN by importlib
**Collection**: [Note which collection this PR will affect]
# Changelog
- Replace conditional imports in normalize.py and inverse_normalize.py
**PR Type**:
- Code enhancement
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4246/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4246/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4245 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4245/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4245/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4245/events | https://github.com/NVIDIA/NeMo/issues/4245 | 1,246,184,374 | I_kwDOC_bI7s5KR0O2 | 4,245 | How to reduce the vocabulary for a QuartzNet model? | {
"login": "leonardltk",
"id": 22384973,
"node_id": "MDQ6VXNlcjIyMzg0OTcz",
"avatar_url": "https://avatars.githubusercontent.com/u/22384973?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/leonardltk",
"html_url": "https://github.com/leonardltk",
"followers_url": "https://api.github.com/users/leonardltk/followers",
"following_url": "https://api.github.com/users/leonardltk/following{/other_user}",
"gists_url": "https://api.github.com/users/leonardltk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/leonardltk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/leonardltk/subscriptions",
"organizations_url": "https://api.github.com/users/leonardltk/orgs",
"repos_url": "https://api.github.com/users/leonardltk/repos",
"events_url": "https://api.github.com/users/leonardltk/events{/privacy}",
"received_events_url": "https://api.github.com/users/leonardltk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-24T08:32:30 | 2022-06-04T22:21:54 | 2022-06-04T22:21:54 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | For a simple script like this:
```python
#!/usr/bin/env python
import nemo.collections.asr as nemo_asr
import ctc_decoders
import numpy as np
import librosa
import os, sys, pdb
## Instantiate model
DetailsDict = nemo_asr.models.EncDecCTCModel.list_available_models()
asr_model = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name='QuartzNet15x5Base-En', strict=False)
## Test audio clip
AUDIO_FILENAME = 'test.wav'
signal, sample_rate = librosa.load(AUDIO_FILENAME, sr=None)
## Convert our audio sample to text
files = [AUDIO_FILENAME]
transcript = asr_model.transcribe(paths2audio_files=files)[0]; print(f'Transcript: "{transcript}"')
```
It performs well
However if i change the problem of just predicting fixed number of words, for example `yes, no`
How should i augment the language model part of it ?
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4245/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4245/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4244 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4244/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4244/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4244/events | https://github.com/NVIDIA/NeMo/pull/4244 | 1,246,173,467 | PR_kwDOC_bI7s44WGYD | 4,244 | Replace conditional imports in WFST based TN/ITN with importlib | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T08:25:50 | 2022-05-24T08:30:54 | 2022-05-24T08:30:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4244",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4244",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4244.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4244.patch",
"merged_at": null
} | # What does this PR do ?
Replace conditional imports in WFST based TN/ITN with importlib
# Changelog
- Replace conditional imports in WFST based ITN with importlib in inverse_normalize.py .
- Replace conditional imports in WFST based TN with importlib in normalize.py .
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4244/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4244/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4243 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4243/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4243/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4243/events | https://github.com/NVIDIA/NeMo/pull/4243 | 1,246,146,987 | PR_kwDOC_bI7s44WBd6 | 4,243 | Replaces conditional imports in WFST TN/ITN with importlib | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T08:05:55 | 2022-05-24T08:16:55 | 2022-05-24T08:16:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4243",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4243",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4243.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4243.patch",
"merged_at": null
} | # What does this PR do ?
Replaces conditional imports in WFST TN/ITN with importlib
# Changelog
- Replaces conditional imports in WFST TN/ITN with importlib
- Support for en_in number system in ITN that supports both international as well as Indian (subcontinent) number system
# Usage
```python
from nemo_text_processing.inverse_text_normalization.inverse_normalize import InverseNormalizer
inverse_normalizer = InverseNormalizer(lang='en_in', overwrite_cache=True)
inverse_normalizer.inverse_normalize('twelve crores twenty five lakhs thirty nine thousand six hundred and eighty four', verbose=True)
```
**PR Type**:
- [*] New Feature
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4243/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4243/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4242 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4242/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4242/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4242/events | https://github.com/NVIDIA/NeMo/pull/4242 | 1,246,015,490 | PR_kwDOC_bI7s44Vl0v | 4,242 | Use importlib for TN/ITN languages | {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T05:42:57 | 2022-05-24T13:58:42 | 2022-05-24T07:39:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4242",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4242",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4242.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4242.patch",
"merged_at": null
} | # What does this PR do ?
Replaces the conditional imports in TN/ITN with importlib.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Added staticmethods in inverse_normalize.py and normalize.py to check if tagger/classifier exists for that language
- Delete all the language conditional imports
- Use importlib to load the taggers and classifiers for the specified language.
# Usage
* no change in usage
| {
"login": "anand-nv",
"id": 105917641,
"node_id": "U_kgDOBlAsyQ",
"avatar_url": "https://avatars.githubusercontent.com/u/105917641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anand-nv",
"html_url": "https://github.com/anand-nv",
"followers_url": "https://api.github.com/users/anand-nv/followers",
"following_url": "https://api.github.com/users/anand-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/anand-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anand-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anand-nv/subscriptions",
"organizations_url": "https://api.github.com/users/anand-nv/orgs",
"repos_url": "https://api.github.com/users/anand-nv/repos",
"events_url": "https://api.github.com/users/anand-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/anand-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4242/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4242/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4241 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4241/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4241/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4241/events | https://github.com/NVIDIA/NeMo/pull/4241 | 1,245,973,350 | PR_kwDOC_bI7s44Vcxh | 4,241 | [fastpitch][DE] HUI dataset preparation config and model training config on 44100 Hz audios. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T04:41:36 | 2022-06-21T23:32:21 | 2022-06-21T23:32:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4241",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4241",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4241.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4241.patch",
"merged_at": null
} | # What does this PR do ?
* created a dataset config for HUI-ACG.
* created a model config for fastpitch German.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```bash
# Download the dataset, normalize texts, create manifests for train/val/test splits.
$ python scripts/dataset_processing/tts/hui_acg/get_data.py \
--data-root /home/xueyang/datasets \
--set-type clean \
--speaker Friedrich
# save PITCH_MEAN and PITCH_STD from train split which will be printed in the console.
# PATH_WHERE_TO_SAVE_SUP_DATA should be general for train/val/test split.
$ python scripts/dataset_processing/tts/extract_sup_data.py \
--config-path hui_acg/ds_conf \
--config-name ds_for_fastpitch_align.yaml \
manifest_filepath=/home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean/train_manifest.json \
sup_data_path=/home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean/
# you would see the information in the terminal
/home/xueyang/miniconda3/envs/nemo/lib/python3.8/site-packages/apex/pyprof/__init__.py:5: FutureWarning: pyprof will be removed by the end of June, 2022
warnings.warn("pyprof will be removed by the end of June, 2022", FutureWarning)
################################################################################
### WARNING, path does not exist: KALDI_ROOT=/mnt/matylda5/iveselyk/Tools/kaldi-trunk
### (please add 'export KALDI_ROOT=<your_path>' in your $HOME/.profile)
### (or run as: KALDI_ROOT=<your_path> python <your_script>.py)
################################################################################
[NeMo W 2022-04-20 22:59:42 experimental:27] Module <class 'nemo.collections.nlp.data.language_modeling.megatron.megatron_batch_samplers.MegatronPretrainingRandomBatchSampler'> is experimental, not ready for production and is not fully supported. Use at your own risk.
[NeMo I 2022-04-20 22:59:42 tokenize_and_classify:87] Creating ClassifyFst grammars. This might take some time...
[NeMo I 2022-04-20 22:59:56 data:173] Loading dataset from /home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean/train_manifest.json.
9065it [00:00, 37982.47it/s]
[NeMo I 2022-04-20 22:59:56 data:207] Loaded dataset with 9065 files.
[NeMo I 2022-04-20 22:59:56 data:209] Dataset contains 18.92 hours.
[NeMo I 2022-04-20 22:59:56 data:297] Pruned 0 files. Final dataset contains 9065 files
[NeMo I 2022-04-20 22:59:56 data:299] Pruned 0.00 hours. Final dataset contains 18.92 hours.
Processing /home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean/train_manifest.json:
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 9065/9065 [3:15:29<00:00, 1.29s/it]
PITCH_MEAN, PITCH_STD = 119.04859924316406, 95.5344009399414
# you will see two new folders generated as well,
$ ls -lt
drwxrwxr-x 2 xueyang xueyang 786432 Apr 21 02:15 pitch
drwxrwxr-x 2 xueyang xueyang 802816 Apr 21 02:15 align_prior_matrix
-rw-rw-r-- 1 xueyang xueyang 87334 Apr 20 17:13 test_manifest.json
-rw-rw-r-- 1 xueyang xueyang 4014423 Apr 20 17:13 train_manifest.json
-rw-rw-r-- 1 xueyang xueyang 44681 Apr 20 17:13 val_manifest.json
# train FastPitch model
$ python examples/tts/fastpitch.py \
--config-path conf/de \
--config-name fastpitch_align_44100 \
model.train_ds.dataloader_params.num_workers=16 \
model.validation_ds.dataloader_params.num_workers=16 \
model.train_ds.dataloader_params.batch_size=24 \
model.validation_ds.dataloader_params.batch_size=24 \
train_dataset=/home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean/train_manifest_ngc.json \
validation_datasets=/home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean/val_manifest_ngc.json \
sup_data_path=/home/xueyang/datasets/HUI-Audio-Corpus-German/Friedrich_Clean \
pitch_mean=119.04859924316406 \
pitch_std=95.5344009399414 \
trainer.devices=2 \
trainer.num_nodes=1 \
trainer.precision=16 \
trainer.accumulate_grad_batches=2 \
trainer.log_every_n_steps=10 \
exp_manager.exp_dir=/home/xueyang/results/in_progress/fastpitch-de-Friedrich_hui_train_A100x2 \
exp_manager.resume_if_exists=True \
exp_manager.resume_ignore_no_checkpoint=True \
+exp_manager.create_wandb_logger=True \
+exp_manager.wandb_logger_kwargs.name=ml-model.fastpitch-de-Friedrich \
+exp_manager.wandb_logger_kwargs.project=GermanTTS
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4241/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4241/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4240 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4240/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4240/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4240/events | https://github.com/NVIDIA/NeMo/issues/4240 | 1,245,886,481 | I_kwDOC_bI7s5KQrgR | 4,240 | fine tuning in korean conformer-transducer | {
"login": "dykim3",
"id": 100189969,
"node_id": "U_kgDOBfjHEQ",
"avatar_url": "https://avatars.githubusercontent.com/u/100189969?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dykim3",
"html_url": "https://github.com/dykim3",
"followers_url": "https://api.github.com/users/dykim3/followers",
"following_url": "https://api.github.com/users/dykim3/following{/other_user}",
"gists_url": "https://api.github.com/users/dykim3/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dykim3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dykim3/subscriptions",
"organizations_url": "https://api.github.com/users/dykim3/orgs",
"repos_url": "https://api.github.com/users/dykim3/repos",
"events_url": "https://api.github.com/users/dykim3/events{/privacy}",
"received_events_url": "https://api.github.com/users/dykim3/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-24T02:12:44 | 2022-06-22T16:55:53 | 2022-06-22T16:55:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | How can I get a space(blank) it self in tokenizer vocab?
I am trying to finetune the stt_en_conformer_transducer_large model with grapheme in korean. I changed some code to load labels with chardataset.
in finetuning the prediction log shows blank in a unk tag. (??)
```
[NeMo I 2022-05-23 06:02:11 rnnt_wer_bpe:231] reference :그래서 ⁇ 내가 ⁇ 오글 ⁇ 막 ⁇ 이랬는데
[NeMo I 2022-05-23 06:02:11 rnnt_wer_bpe:232] predicted :그래서 ⁇ 다 ⁇ 얼 ⁇ 말인데
```
this is my tokenizer vocab.
```
<unk> 0
<b> 0
▁ -0.693147
ᄌ -4.18965
ᄀ -4.8828
ᄁ -4.8828
ᄂ -4.8828
ᄃ -4.8828
ᄄ -4.8828
ᄅ -4.8828
ᄆ -4.8828
ᄇ -4.8828
ᄈ -4.8828
ᄉ -4.8828
ᄊ -4.8828
ᄋ -4.8828
ᄍ -4.8828
ᄎ -4.8828
ᄏ -4.8828
ᄐ -4.8828
ᄑ -4.8828
ᄒ -4.8828
ᅡ -4.8828
ᅢ -4.8828
ᅣ -4.8828
ᅤ -4.8828
ᅥ -4.8828
ᅦ -4.8828
ᅧ -4.8828
ᅨ -4.8828
ᅩ -4.8828
ᅪ -4.8828
ᅫ -4.8828
ᅬ -4.8828
ᅭ -4.8828
ᅮ -4.8828
ᅯ -4.8828
ᅰ -4.8828
ᅱ -4.8828
ᅲ -4.8828
ᅳ -4.8828
ᅴ -4.8828
ᅵ -4.8828
ᆨ -4.8828
ᆩ -4.8828
ᆪ -4.8828
ᆫ -4.8828
ᆬ -4.8828
ᆭ -4.8828
ᆮ -4.8828
ᆯ -4.8828
ᆰ -4.8828
ᆱ -4.8828
ᆲ -4.8828
ᆴ -4.8828
ᆶ -4.8828
ᆷ -4.8828
ᆸ -4.8828
ᆹ -4.8828
ᆺ -4.8828
ᆻ -4.8828
ᆼ -4.8828
ᆽ -4.8828
ᆾ -4.8828
ᆿ -4.8828
ᇀ -4.8828
ᇁ -4.8828
ᇂ -4.8828
```
this is my config.
```
name: "Conformer-Transducer-BPE"
init_from_nemo_model:
model0:
path: ??
exclude: ["joint", "decoder"]
include: ["encoder"]
model:
sample_rate: &sample_rate 16000
compute_eval_loss: false # eval samples can be very long and exhaust memory. Disable computation of transducer loss during validation/testing with this flag.
log_prediction: true # enables logging sample predictions in the output during training
skip_nan_grad: false
change_vocab: True # added
use_cer: True # added
model_defaults:
enc_hidden: ${model.encoder.d_model}
pred_hidden: 640
joint_hidden: 640
train_ds:
manifest_filepath: ???
sample_rate: 16000 #${model.sample_rate}
batch_size: 16 # you may increase batch_size if your memory allows
shuffle: true
num_workers: 8
pin_memory: true
# use_start_end_token: True
trim_silence: false
max_duration: 16.7 # it is set for LibriSpeech, you may need to update it for your dataset
min_duration: 0.1
# tarred datasets
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
# bucketing params
bucketing_strategy: "synced_randomized"
bucketing_batch_size: null
use_char: true
unk_index: 0
validation_ds:
manifest_filepath: ???
sample_rate: 16000 #${model.sample_rate}
batch_size: 16
shuffle: false
num_workers: 8
pin_memory: true
use_char: true
unk_index: 0
# use_start_end_token: True
test_ds:
manifest_filepath: null
sample_rate: 16000 #${model.sample_rate}
batch_size: 16
shuffle: false
num_workers: 8
pin_memory: true
use_char: true
# use_start_end_token: True
# You may find more detail on how to train a tokenizer at: /scripts/tokenizers/process_asr_text_tokenizer.py
tokenizer:
dir: ??? # path to directory which contains either tokenizer.model (bpe) or vocab.txt (for wpe)
type: bpe # Can be either bpe (SentencePiece tokenizer) or wpe (WordPiece tokenizer)
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
sample_rate: *sample_rate
normalize: "per_feature"
window_size: 0.025
window_stride: 0.01
window: "hann"
features: 80
n_fft: 512
frame_splicing: 1
dither: 0.00001
pad_to: 0
spec_augment:
_target_: nemo.collections.asr.modules.SpectrogramAugmentation
freq_masks: 2 # set to zero to disable it
time_masks: 10 # set to zero to disable it
freq_width: 27
time_width: 0.05
encoder:
_target_: nemo.collections.asr.modules.ConformerEncoder
feat_in: ${model.preprocessor.features}
feat_out: -1 # you may set it if you need different output size other than the default d_model
n_layers: 17
d_model: 512
# Sub-sampling params
subsampling: striding # vggnet or striding
subsampling_factor: 4 # must be power of 2
subsampling_conv_channels: -1 # set to -1 to make it equal to the d_model
# Feed forward module's params
ff_expansion_factor: 4
# Multi-headed Attention Module's params
self_attention_model: rel_pos # rel_pos or abs_pos
n_heads: 8 # may need to be lower for smaller d_models
# [left, right] specifies the number of steps to be seen from left and right of each step in self-attention
att_context_size: [-1, -1] # -1 means unlimited context
xscaling: true # scales up the input embeddings by sqrt(d_model)
untie_biases: true # unties the biases of the TransformerXL layers
pos_emb_max_len: 5000
# Convolution module's params
conv_kernel_size: 31
conv_norm_type: 'batch_norm' # batch_norm or layer_norm
### regularization
dropout: 0.1 # The dropout used in most of the Conformer Modules
dropout_emb: 0.0 # The dropout used for embeddings
dropout_att: 0.1 # The dropout for multi-headed attention modules
decoder:
_target_: nemo.collections.asr.modules.RNNTDecoder
normalization_mode: null # Currently only null is supported for export.
random_state_sampling: false # Random state sampling: https://arxiv.org/pdf/1910.11455.pdf
blank_as_pad: true # This flag must be set in order to support exporting of RNNT models + efficient inference.
prednet:
pred_hidden: ${model.model_defaults.pred_hidden}
pred_rnn_layers: 1
t_max: null
dropout: 0.1
joint:
_target_: nemo.collections.asr.modules.RNNTJoint
log_softmax: null # 'null' would set it automatically according to CPU/GPU device
preserve_memory: false # dramatically slows down training, but might preserve some memory
# Fuses the computation of prediction net + joint net + loss + WER calculation
# to be run on sub-batches of size `fused_batch_size`.
# When this flag is set to true, consider the `batch_size` of *_ds to be just `encoder` batch size.
# `fused_batch_size` is the actual batch size of the prediction net, joint net and transducer loss.
# Using small values here will preserve a lot of memory during training, but will make training slower as well.
# An optimal ratio of fused_batch_size : *_ds.batch_size is 1:1.
# However, to preserve memory, this ratio can be 1:8 or even 1:16.
# Extreme case of 1:B (i.e. fused_batch_size=1) should be avoided as training speed would be very slow.
fuse_loss_wer: true
fused_batch_size: 16
jointnet:
joint_hidden: ${model.model_defaults.joint_hidden}
activation: "relu"
dropout: 0.1
decoding:
strategy: "greedy_batch" # can be greedy, greedy_batch, beam, tsd, alsd.
# greedy strategy config
greedy:
max_symbols: 30
# beam strategy config
beam:
beam_size: 2
return_best_hypothesis: False
score_norm: true
tsd_max_sym_exp: 50 # for Time Synchronous Decoding
alsd_max_target_len: 2.0 # for Alignment-Length Synchronous Decoding
loss:
loss_name: "default"
warprnnt_numba_kwargs:
# FastEmit regularization: https://arxiv.org/abs/2010.11148
# You may enable FastEmit to reduce the latency of the model for streaming
fastemit_lambda: 0.0 # Recommended values to be in range [1e-4, 1e-2], 0.001 is a good start.
clamp: -1.0 # if > 0, applies gradient clamping in range [-clamp, clamp] for the joint tensor only.
# Adds Gaussian noise to the gradients of the decoder to avoid overfitting
variational_noise:
start_step: 0
std: 0.0
optim:
name: adamw
lr: 5.0
# optimizer arguments
betas: [0.9, 0.98]
weight_decay: 1e-3
# scheduler setup
sched:
name: NoamAnnealing
d_model: ${model.encoder.d_model}
# scheduler config override
warmup_steps: 10000
warmup_ratio: null
min_lr: 1e-6
trainer:
devices: -1 # number of GPUs, -1 would use all available GPUs
num_nodes: 1
max_epochs: 500
max_steps: null # computed at runtime if not set
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
accelerator: auto
strategy: ddp
accumulate_grad_batches: 1
gradient_clip_val: 0.0
precision: 32 # Should be set to 16 for O1 and O2 to enable the AMP.
log_every_n_steps: 50 # Interval of logging.
progress_bar_refresh_rate: 10
resume_from_checkpoint: null # The path to a checkpoint file to continue the training, restores the whole state including the epoch, step, LR schedulers, apex, etc.
num_sanity_val_steps: 0 # number of steps to perform validation steps for sanity check the validation process before starting the training, setting to 0 disables it
check_val_every_n_epoch: 1 # number of evaluations on validation every n epochs
sync_batchnorm: true
enable_checkpointing: False # Provided by exp_manager
logger: false # Provided by exp_manager
exp_manager:
exp_dir: null
name: ${name}
create_tensorboard_logger: true
create_checkpoint_callback: true
checkpoint_callback_params:
# in case of multiple validation sets, first one is used
monitor: "val_wer"
mode: "min"
save_top_k: 1
always_save_nemo: True # saves the checkpoints as nemo files instead of PTL checkpoints
resume_if_exists: False
resume_ignore_no_checkpoint: false
create_wandb_logger: false
wandb_logger_kwargs:
name: null
project: null
```
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4240/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4240/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4239 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4239/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4239/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4239/events | https://github.com/NVIDIA/NeMo/pull/4239 | 1,245,827,782 | PR_kwDOC_bI7s44U-jN | 4,239 | Fixing bug 3642622 | {
"login": "pasandi20",
"id": 35242805,
"node_id": "MDQ6VXNlcjM1MjQyODA1",
"avatar_url": "https://avatars.githubusercontent.com/u/35242805?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pasandi20",
"html_url": "https://github.com/pasandi20",
"followers_url": "https://api.github.com/users/pasandi20/followers",
"following_url": "https://api.github.com/users/pasandi20/following{/other_user}",
"gists_url": "https://api.github.com/users/pasandi20/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pasandi20/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pasandi20/subscriptions",
"organizations_url": "https://api.github.com/users/pasandi20/orgs",
"repos_url": "https://api.github.com/users/pasandi20/repos",
"events_url": "https://api.github.com/users/pasandi20/events{/privacy}",
"received_events_url": "https://api.github.com/users/pasandi20/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T00:22:57 | 2022-05-24T19:07:57 | 2022-05-24T19:07:55 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4239",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4239",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4239.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4239.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pasandi20",
"id": 35242805,
"node_id": "MDQ6VXNlcjM1MjQyODA1",
"avatar_url": "https://avatars.githubusercontent.com/u/35242805?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pasandi20",
"html_url": "https://github.com/pasandi20",
"followers_url": "https://api.github.com/users/pasandi20/followers",
"following_url": "https://api.github.com/users/pasandi20/following{/other_user}",
"gists_url": "https://api.github.com/users/pasandi20/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pasandi20/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pasandi20/subscriptions",
"organizations_url": "https://api.github.com/users/pasandi20/orgs",
"repos_url": "https://api.github.com/users/pasandi20/repos",
"events_url": "https://api.github.com/users/pasandi20/events{/privacy}",
"received_events_url": "https://api.github.com/users/pasandi20/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4239/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4239/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4238 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4238/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4238/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4238/events | https://github.com/NVIDIA/NeMo/pull/4238 | 1,245,818,983 | PR_kwDOC_bI7s44U8sp | 4,238 | Prompt Learning Typo Fixes | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-24T00:05:42 | 2022-05-24T03:57:26 | 2022-05-24T03:57:23 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4238",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4238",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4238.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4238.patch",
"merged_at": "2022-05-24T03:57:23"
} | # What does this PR do ?
Fixes Typos in Prompt Learning notebook and documentation
**Collection**: BigNLP
# Changelog
- Prompt Learning Notebook
- Prompt Learning Docs
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue) https://nvbugs/3642570 [ML-NeMo][A30] Multitask_Prompt_and_PTuning.ipynb contains typos
| {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4238/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4238/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4237 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4237/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4237/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4237/events | https://github.com/NVIDIA/NeMo/pull/4237 | 1,245,745,452 | PR_kwDOC_bI7s44UtE8 | 4,237 | Save Virtual Prompt Weights Only | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T22:05:28 | 2022-05-26T22:23:13 | 2022-05-26T22:16:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4237",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4237",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4237.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4237.patch",
"merged_at": "2022-05-26T22:16:05"
} | Removes all GPT/Frozen model configs and weights from Prompt Learning Model's .nemo file. After training has ended, the prompt learning model now only saves prompt table parameters. During training, intermediate checkpoint files may also have prompt encoder parameters.
**Collection**: BigNLP
- Adds custom state_dict and load_state_dict methods for prompt learning model class
- Updates prompt learning inference example script
- Updates prompt learning documentation
# Usage
The final .nemo checkpoint file contains
1. model_config.yaml
2. model_weights.ckpt
where model_weights.ckpt only has prompt table params
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4237/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4237/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4236 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4236/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4236/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4236/events | https://github.com/NVIDIA/NeMo/pull/4236 | 1,245,692,010 | PR_kwDOC_bI7s44Uha7 | 4,236 | GPT config options | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T21:01:52 | 2022-09-22T17:12:18 | 2022-09-20T23:58:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4236",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4236",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4236.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4236.patch",
"merged_at": null
} | # What does this PR do ?
Adds missing configs to GPT pre-training.
**Collection**: NLP
# Changelog
- Upates the GPT pretraining yaml config and propages the args through to ParallelTransformer.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4236/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4236/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4235 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4235/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4235/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4235/events | https://github.com/NVIDIA/NeMo/pull/4235 | 1,245,672,616 | PR_kwDOC_bI7s44UdQJ | 4,235 | Fix JSON serialization problem | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T20:39:30 | 2022-05-23T22:03:10 | 2022-05-23T22:03:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4235",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4235",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4235.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4235.patch",
"merged_at": "2022-05-23T22:03:06"
} | It fixes the text generation server cannot `jsonify` the torch tensor object.
| {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4235/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4235/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4234 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4234/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4234/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4234/events | https://github.com/NVIDIA/NeMo/issues/4234 | 1,245,590,441 | I_kwDOC_bI7s5KPjOp | 4,234 | Speaker Diarization: Known Number of Speakers | {
"login": "naymaraq",
"id": 47416614,
"node_id": "MDQ6VXNlcjQ3NDE2NjE0",
"avatar_url": "https://avatars.githubusercontent.com/u/47416614?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/naymaraq",
"html_url": "https://github.com/naymaraq",
"followers_url": "https://api.github.com/users/naymaraq/followers",
"following_url": "https://api.github.com/users/naymaraq/following{/other_user}",
"gists_url": "https://api.github.com/users/naymaraq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/naymaraq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/naymaraq/subscriptions",
"organizations_url": "https://api.github.com/users/naymaraq/orgs",
"repos_url": "https://api.github.com/users/naymaraq/repos",
"events_url": "https://api.github.com/users/naymaraq/events{/privacy}",
"received_events_url": "https://api.github.com/users/naymaraq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T19:12:05 | 2022-06-13T20:06:11 | 2022-06-13T20:06:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello NeMo team
I evaluated NeMo clustering diarizer on VoxConverse dataset. And the results are wonderful. But when I am providing the actual number of speakers through manifest, results get worse. I noticed the same behavior for NIST SRE 2000 dataset too. I am wondering why is this happening? Is it something related to dataset (like overlap speech)?
<img width="873" alt="Screen Shot 2022-05-23 at 23 07 41" src="https://user-images.githubusercontent.com/47416614/169889294-ff7b4100-5f9c-4b58-b695-06a686c34c52.png">
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4234/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4234/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4233 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4233/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4233/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4233/events | https://github.com/NVIDIA/NeMo/pull/4233 | 1,245,510,843 | PR_kwDOC_bI7s44T61Z | 4,233 | Update TTS Configs from LAMB to AdamW | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T17:48:19 | 2022-05-24T22:12:29 | 2022-05-24T22:12:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4233",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4233",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4233.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4233.patch",
"merged_at": "2022-05-24T22:12:26"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Replaces LAMB optimizer (unstable, hangs during multi-GPU training) with AdamW for FastPitch and Mixer-TTS configs.
Second attempt based off of `main` instead of `r1.9.0` (see #4219)
**Collection**: TTS
# Changelog
- Replace LAMB defaults with AdamW
- Update `fastpitch.py` example script to use existing config
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4233/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4233/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4232 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4232/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4232/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4232/events | https://github.com/NVIDIA/NeMo/pull/4232 | 1,245,460,478 | PR_kwDOC_bI7s44TwD6 | 4,232 | NeMo Megatron: Add sequence parallelism and selective activation checkpointing | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T16:57:09 | 2022-09-20T23:56:13 | 2022-06-15T23:48:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4232",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4232",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4232.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4232.patch",
"merged_at": null
} | # What does this PR do ?
Add sequence parallelism and selective activation checkpointing.
**Collection**: NLP
# Changelog
- Update GPT config
- Update parallel_lm_logits
- Add CoreAttention
- This is the block that gets recomputed when using selective activation checkpointing
- Update ParallelAttention to work with CoreAttention
- Update ParallelTransformerLayer
- Layer norm calls to use sequence parallel
- Update ParallelTransformer
- Update args
- Update final layer norm
- Add rng contex to forward when using sequence parallel
- Remove transposes
- Update Pooler
- Gather from sequence parallel regions
- Update embedding
- Add sequence_parallel flag
- add transpose in forward
- scatter for dropout
- Update TransformerLanguageModel
- Update GPTModel
- Add transposes
- All-reduce layer norm params when using sequence parallel
- Add sequence parallel arg to apex calls
- Update configs and arg checking for activation checkpointing
# Usage
```
# enable sequence parallelism
model.sequence_parallel=True
# enable selective activation checkpointing
model.activations_checkpoint_granularity=selective
# all transformer layers have CoreAttention checkpointed when using selective
model.activations_checkpoint_method=null
model.activations_checkpoint_num_layers=null
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4232/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4232/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4230 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4230/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4230/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4230/events | https://github.com/NVIDIA/NeMo/pull/4230 | 1,245,146,334 | PR_kwDOC_bI7s44Sr11 | 4,230 | Update LJSpeech whitelist file path | {
"login": "treacker",
"id": 36159472,
"node_id": "MDQ6VXNlcjM2MTU5NDcy",
"avatar_url": "https://avatars.githubusercontent.com/u/36159472?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/treacker",
"html_url": "https://github.com/treacker",
"followers_url": "https://api.github.com/users/treacker/followers",
"following_url": "https://api.github.com/users/treacker/following{/other_user}",
"gists_url": "https://api.github.com/users/treacker/gists{/gist_id}",
"starred_url": "https://api.github.com/users/treacker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/treacker/subscriptions",
"organizations_url": "https://api.github.com/users/treacker/orgs",
"repos_url": "https://api.github.com/users/treacker/repos",
"events_url": "https://api.github.com/users/treacker/events{/privacy}",
"received_events_url": "https://api.github.com/users/treacker/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T13:10:06 | 2022-05-23T13:10:57 | 2022-05-23T13:10:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4230",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4230",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4230.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4230.patch",
"merged_at": null
} | Fixing wrong LJSpeech whitelist file path
| {
"login": "treacker",
"id": 36159472,
"node_id": "MDQ6VXNlcjM2MTU5NDcy",
"avatar_url": "https://avatars.githubusercontent.com/u/36159472?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/treacker",
"html_url": "https://github.com/treacker",
"followers_url": "https://api.github.com/users/treacker/followers",
"following_url": "https://api.github.com/users/treacker/following{/other_user}",
"gists_url": "https://api.github.com/users/treacker/gists{/gist_id}",
"starred_url": "https://api.github.com/users/treacker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/treacker/subscriptions",
"organizations_url": "https://api.github.com/users/treacker/orgs",
"repos_url": "https://api.github.com/users/treacker/repos",
"events_url": "https://api.github.com/users/treacker/events{/privacy}",
"received_events_url": "https://api.github.com/users/treacker/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4230/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4230/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4229 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4229/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4229/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4229/events | https://github.com/NVIDIA/NeMo/issues/4229 | 1,245,051,068 | I_kwDOC_bI7s5KNfi8 | 4,229 | Distributed training via Horovod does not make learning faster | {
"login": "EmreOzkose",
"id": 17765576,
"node_id": "MDQ6VXNlcjE3NzY1NTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/EmreOzkose",
"html_url": "https://github.com/EmreOzkose",
"followers_url": "https://api.github.com/users/EmreOzkose/followers",
"following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}",
"gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}",
"starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions",
"organizations_url": "https://api.github.com/users/EmreOzkose/orgs",
"repos_url": "https://api.github.com/users/EmreOzkose/repos",
"events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}",
"received_events_url": "https://api.github.com/users/EmreOzkose/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-23T11:57:20 | 2022-06-06T12:27:53 | 2022-06-06T12:27:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I run [text classification with bert example](https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/text_classification/text_classification_with_bert.py). Training is done well. I got approximately %90 accuracy after first epoch. Then I tried to run the same example with [horovod](https://github.com/horovod/horovod). My change is written below:
Change [line 116](https://github.com/NVIDIA/NeMo/blob/c03f87d47fc57abc89c0ebf859fccba397dd0f8e/examples/nlp/text_classification/text_classification_with_bert.py#L116):
`trainer = pl.Trainer(plugins=[NLPDDPPlugin()], **cfg.trainer)` to `trainer = pl.Trainer(strategy="horovod", **cfg.trainer)`.
Change [config file](https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/text_classification/conf/text_classification_config.yaml):
model.train_ds.file_path = path/to/train
model.validation_ds.file_path = path/to/test
model.train_ds.batch_size = 8
model.validation_ds.batch_size = 8
model.dataset.num_classes = 2
trainer.devices = 1
trainer.max_epochs = 1
Then I run 2 training with this commands:
`horovodrun -np 1 -H localhost:1 --verbose --start-timeout 300 python text_classification_with_bert.py`
and
`horovodrun -np 2 -H localhost:2 --verbose --start-timeout 300 python text_classification_with_bert.py`
For second one, I also changed `trainer.devices` to 2 in config file.
First training took 15:06 min and second training took 22:00 min.
**Expected behavior**
I expect that second training should take less time.
**Environment overview**
horovod: 0.24.3
pytorch-lightning: 1.6.3
pytorch: 1.11.0
nemo-toolkit: 1.8.2 | {
"login": "EmreOzkose",
"id": 17765576,
"node_id": "MDQ6VXNlcjE3NzY1NTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/EmreOzkose",
"html_url": "https://github.com/EmreOzkose",
"followers_url": "https://api.github.com/users/EmreOzkose/followers",
"following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}",
"gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}",
"starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions",
"organizations_url": "https://api.github.com/users/EmreOzkose/orgs",
"repos_url": "https://api.github.com/users/EmreOzkose/repos",
"events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}",
"received_events_url": "https://api.github.com/users/EmreOzkose/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4229/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4229/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4228 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4228/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4228/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4228/events | https://github.com/NVIDIA/NeMo/pull/4228 | 1,244,793,441 | PR_kwDOC_bI7s44RfJd | 4,228 | fix syntax error in ipynb-file | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T08:43:27 | 2022-05-23T16:25:00 | 2022-05-23T16:18:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4228",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4228",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4228.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4228.patch",
"merged_at": "2022-05-23T16:18:18"
} | Signed-off-by: Alexandra Antonova <[email protected]>
# What does this PR do ?
Fix syntax error in ipynb file
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4228/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4228/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4227 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4227/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4227/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4227/events | https://github.com/NVIDIA/NeMo/issues/4227 | 1,244,777,818 | I_kwDOC_bI7s5KMc1a | 4,227 | Correcting spellings for BPE CTC conformer Models. | {
"login": "evilc3",
"id": 19889717,
"node_id": "MDQ6VXNlcjE5ODg5NzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/19889717?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/evilc3",
"html_url": "https://github.com/evilc3",
"followers_url": "https://api.github.com/users/evilc3/followers",
"following_url": "https://api.github.com/users/evilc3/following{/other_user}",
"gists_url": "https://api.github.com/users/evilc3/gists{/gist_id}",
"starred_url": "https://api.github.com/users/evilc3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/evilc3/subscriptions",
"organizations_url": "https://api.github.com/users/evilc3/orgs",
"repos_url": "https://api.github.com/users/evilc3/repos",
"events_url": "https://api.github.com/users/evilc3/events{/privacy}",
"received_events_url": "https://api.github.com/users/evilc3/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-23T08:30:09 | 2022-06-04T22:22:06 | 2022-06-04T22:22:06 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi guys I fine-tuned a ctc large model on my custom dataset. Results are great but hv noticed some spellings issues.
- How do I solve the spelling issues?
- Do I need to use a lm for this?
- Is the tokeniser size the problem . Uses same spe, unigram model with 256 tokens (added punts + numbers from 0 - 9) | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4227/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4227/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4226 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4226/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4226/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4226/events | https://github.com/NVIDIA/NeMo/issues/4226 | 1,244,754,166 | I_kwDOC_bI7s5KMXD2 | 4,226 | Pretrained models url's not working | {
"login": "davidmartinrius",
"id": 16558194,
"node_id": "MDQ6VXNlcjE2NTU4MTk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16558194?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmartinrius",
"html_url": "https://github.com/davidmartinrius",
"followers_url": "https://api.github.com/users/davidmartinrius/followers",
"following_url": "https://api.github.com/users/davidmartinrius/following{/other_user}",
"gists_url": "https://api.github.com/users/davidmartinrius/gists{/gist_id}",
"starred_url": "https://api.github.com/users/davidmartinrius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidmartinrius/subscriptions",
"organizations_url": "https://api.github.com/users/davidmartinrius/orgs",
"repos_url": "https://api.github.com/users/davidmartinrius/repos",
"events_url": "https://api.github.com/users/davidmartinrius/events{/privacy}",
"received_events_url": "https://api.github.com/users/davidmartinrius/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-23T08:14:10 | 2022-06-22T16:53:39 | 2022-06-22T16:53:39 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
when I try to download any model it shows an error:
ValueError: Not able to download url right now, please try again.
I supose the server that store the models is not returning the models.
Could you check it out, please?
I share the full stack trace (in main branch and other branches)
[NeMo W 2022-05-23 10:10:06 nemo_logging:349] /home/pc/.local/lib/python3.8/site-packages/apex/pyprof/__init__.py:5: FutureWarning: pyprof will be removed by the end of June, 2022
warnings.warn("pyprof will be removed by the end of June, 2022", FutureWarning)
################################################################################
### WARNING, path does not exist: KALDI_ROOT=/mnt/matylda5/iveselyk/Tools/kaldi-trunk
### (please add 'export KALDI_ROOT=<your_path>' in your $HOME/.profile)
### (or run as: KALDI_ROOT=<your_path> python <your_script>.py)
################################################################################
2022-05-23 10:10:07.314427: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2022-05-23 10:10:07.314442: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
Input In [2], in <module>
16 from nemo.collections.tts.helpers.helpers import regulate_len
18 # Load the models from NGC
---> 19 fastpitch = FastPitchModel.from_pretrained("tts_en_fastpitch").eval().cuda()
20 hifigan = HifiGanModel.from_pretrained("tts_hifigan").eval().cuda()
21 sr = 22050
File ~/Downloads/NeMo/nemo/core/classes/common.py:682, in Model.from_pretrained(cls, model_name, refresh_cache, override_config_path, map_location, strict, return_config, trainer, save_restore_connector)
677 class_, nemo_model_file_in_cache = cls._get_hf_hub_pretrained_model_info(
678 model_name=model_name, refresh_cache=refresh_cache
679 )
680 else:
681 # NGC source
--> 682 class_, nemo_model_file_in_cache = cls._get_ngc_pretrained_model_info(
683 model_name=model_name, refresh_cache=refresh_cache
684 )
686 instance = class_.restore_from(
687 restore_path=nemo_model_file_in_cache,
688 override_config_path=override_config_path,
(...)
693 save_restore_connector=save_restore_connector,
694 )
695 return instance
File ~/Downloads/NeMo/nemo/core/classes/common.py:743, in Model._get_ngc_pretrained_model_info(cls, model_name, refresh_cache)
741 cache_subfolder = hashlib.md5((location_in_the_cloud + description).encode('utf-8')).hexdigest()
742 # if file exists on cache_folder/subfolder, it will be re-used, unless refresh_cache is True
--> 743 nemo_model_file_in_cache = maybe_download_from_cloud(
744 url=url, filename=filename, cache_dir=cache_dir, subfolder=cache_subfolder, refresh_cache=refresh_cache
745 )
747 logging.info("Instantiating model from pre-trained checkpoint")
749 if class_ is None:
File ~/Downloads/NeMo/nemo/utils/cloud.py:82, in maybe_download_from_cloud(url, filename, subfolder, cache_dir, refresh_cache)
80 sleep(0.05)
81 continue
---> 82 raise ValueError("Not able to download url right now, please try again.")
ValueError: Not able to download url right now, please try again.
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4226/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4226/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4225 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4225/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4225/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4225/events | https://github.com/NVIDIA/NeMo/issues/4225 | 1,244,596,277 | I_kwDOC_bI7s5KLwg1 | 4,225 | unable to train asr | {
"login": "supreetpr-kore",
"id": 103238851,
"node_id": "U_kgDOBidMww",
"avatar_url": "https://avatars.githubusercontent.com/u/103238851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/supreetpr-kore",
"html_url": "https://github.com/supreetpr-kore",
"followers_url": "https://api.github.com/users/supreetpr-kore/followers",
"following_url": "https://api.github.com/users/supreetpr-kore/following{/other_user}",
"gists_url": "https://api.github.com/users/supreetpr-kore/gists{/gist_id}",
"starred_url": "https://api.github.com/users/supreetpr-kore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/supreetpr-kore/subscriptions",
"organizations_url": "https://api.github.com/users/supreetpr-kore/orgs",
"repos_url": "https://api.github.com/users/supreetpr-kore/repos",
"events_url": "https://api.github.com/users/supreetpr-kore/events{/privacy}",
"received_events_url": "https://api.github.com/users/supreetpr-kore/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-23T05:19:55 | 2022-05-26T20:58:43 | 2022-05-23T05:44:02 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
trying to build an ASR with min-Libri speech data
**command**
python3 speech_to_text_ctc_bpe.py model.train_ds.manifest_filepath=data/mini_libri/train_clean_5.json model.validation_ds.manifest_filepath=data/mini_libri/dev_clean_2.json model.tokenizer.dir=data/tokenizer_libri/tokenizer_spe_bpe_v1024/ model.tokenizer.type="bpe" trainer.devices=-1 trainer.accelerator="gpu" trainer.strategy="ddp" trainer.max_epochs=100 model.optim.name="adamw" model.optim.lr=0.001 model.optim.betas=[0.9,0.999] model.optim.weight_decay=0.0001 model.optim.sched.warmup_steps=2000 exp_manager.create_wandb_logger=True exp_manager.wandb_logger_kwargs.name="Libri_1" exp_manager.wandb_logger_kwargs.project="Asr_demo"
**Error**
Traceback (most recent call last):
File "speech_to_text_ctc_bpe.py", line 95, in <module>
main()
File "/data/supreet/NeMo/nemo/core/config/hydra_runner.py", line 104, in wrapper
_run_hydra(
TypeError: _run_hydra() missing 1 required positional argument: 'args'
| {
"login": "supreetpr-kore",
"id": 103238851,
"node_id": "U_kgDOBidMww",
"avatar_url": "https://avatars.githubusercontent.com/u/103238851?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/supreetpr-kore",
"html_url": "https://github.com/supreetpr-kore",
"followers_url": "https://api.github.com/users/supreetpr-kore/followers",
"following_url": "https://api.github.com/users/supreetpr-kore/following{/other_user}",
"gists_url": "https://api.github.com/users/supreetpr-kore/gists{/gist_id}",
"starred_url": "https://api.github.com/users/supreetpr-kore/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/supreetpr-kore/subscriptions",
"organizations_url": "https://api.github.com/users/supreetpr-kore/orgs",
"repos_url": "https://api.github.com/users/supreetpr-kore/repos",
"events_url": "https://api.github.com/users/supreetpr-kore/events{/privacy}",
"received_events_url": "https://api.github.com/users/supreetpr-kore/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4225/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4225/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4224 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4224/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4224/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4224/events | https://github.com/NVIDIA/NeMo/issues/4224 | 1,244,370,798 | I_kwDOC_bI7s5KK5du | 4,224 | Trying to resume training `enc_dec_nmt` fails | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-22T21:24:16 | 2022-05-25T21:38:16 | 2022-05-25T21:38:16 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I used `enc_dec_nmt.py` to build a NLP/MT model based on `aayn_base.yml` (`nemo:1.8.2` based on `pytorch:22.04-py3`); training was interrupted before reaching the final epoch, now tying to resume training from the last checkpoint by passing
`+exp_manager.resume_if_exists=true` to the `enc_dec_nmt.py` call fails with the following trace
```python
Traceback (most recent call last):
File "examples/nlp/machine_translation/enc_dec_nmt.py", line 147, in <module>
main()
File "/workspace/nemo/nemo/core/config/hydra_runner.py", line 104, in wrapper
_run_hydra(
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 377, in _run_hydra
run_and_report(
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 214, in run_and_report
raise ex
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 211, in run_and_report
return func()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 378, in <lambda>
lambda: hydra.run(
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 111, in run
_ = ret.return_value
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/core/utils.py", line 233, in return_value
raise self._return_value
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/hydra/core/utils.py", line 160, in run_job
ret.return_value = task_function(task_cfg)
File "examples/nlp/machine_translation/enc_dec_nmt.py", line 140, in main
trainer.fit(mt_model)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 768, in fit
self._call_and_handle_interrupt(
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 721, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 809, in _fit_impl
results = self._run(model, ckpt_path=self.ckpt_path)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1234, in _run
results = self._run_stage()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1321, in _run_stage
return self._run_train()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1351, in _run_train
self.fit_loop.run()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/fit_loop.py", line 269, in advance
self._outputs = self.epoch_loop.run(self._data_fetcher)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 205, in run
self.on_advance_end()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 255, in on_advance_end
self._run_validation()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 309, in _run_validation
self.val_loop.run()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 211, in run
output = self.on_run_end()
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 187, in on_run_end
self._evaluation_epoch_end(self._outputs)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 309, in _evaluation_epoch_end
self.trainer._call_lightning_module_hook("validation_epoch_end", output_or_outputs)
File "/ceph/hpc/home/ilb/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1593, in _call_lightning_module_hook
output = fn(*args, **kwargs)
File "/workspace/nemo/nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py", line 493, in validation_epoch_end
self.eval_epoch_end(outputs, 'val', self.global_rank)
File "/workspace/nemo/nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py", line 407, in eval_epoch_end
if isinstance(outputs[0], dict):
IndexError: list index out of range
```
**Steps/Code to reproduce bug**
Train with `examples/enc_dec_nmt.py` long enough to produce at least one checkpoint, interrupt training and rerun with the `exp_manager.resume_if_exists` flag set.
**Expected behavior**
Training resumes from last checkpoint. This used to work in `nemo:1.3.0`.
**Environment overview (please complete the following information)**
pytorch:22.04-py3
nemo:1.8.2
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4224/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4224/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4223 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4223/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4223/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4223/events | https://github.com/NVIDIA/NeMo/pull/4223 | 1,244,085,145 | PR_kwDOC_bI7s44PPvF | 4,223 | fix load_from_checkpoint for MTEncDecModel | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-21T21:26:31 | 2022-06-03T13:27:40 | 2022-06-03T13:27:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4223",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4223",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4223.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4223.patch",
"merged_at": null
} | Signed-off-by: Iztok Lebar Bajec <[email protected]>
# What does this PR do ?
MTEncDecModel yaml configs do not declare `model.tokenizer`, hence without this fix restoring from a checkpoint will fail with
```
omegaconf.errors.ConfigAttributeError: Missing key tokenizer
full_key: cfg.tokenizer
object_type=dict
```
**Collection**: NLP/MT
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4223/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4223/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4222 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4222/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4222/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4222/events | https://github.com/NVIDIA/NeMo/pull/4222 | 1,243,997,175 | PR_kwDOC_bI7s44O-oH | 4,222 | Add 'relational positional embedding (RPE)' feature to T5 | {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-21T15:01:32 | 2022-05-24T22:51:03 | 2022-05-24T22:50:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4222",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4222",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4222.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4222.patch",
"merged_at": null
} | # What does this PR do ?
Add 'relative positional embedding (RPE)' feature to T5 model.
**Collection**: NLP
# Changelog
Adds an option to use 'relative positional embedding' other than 'absolute position embedding' or 'fixed position encoding'.
# Usage
In the 'megatron_t5_config.yaml' file change the 'position_embedding_type' option to 'relative'.
```python
python megatron_t5_pretraining.py
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "khcs",
"id": 5403167,
"node_id": "MDQ6VXNlcjU0MDMxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khcs",
"html_url": "https://github.com/khcs",
"followers_url": "https://api.github.com/users/khcs/followers",
"following_url": "https://api.github.com/users/khcs/following{/other_user}",
"gists_url": "https://api.github.com/users/khcs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khcs/subscriptions",
"organizations_url": "https://api.github.com/users/khcs/orgs",
"repos_url": "https://api.github.com/users/khcs/repos",
"events_url": "https://api.github.com/users/khcs/events{/privacy}",
"received_events_url": "https://api.github.com/users/khcs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4222/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4222/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4221 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4221/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4221/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4221/events | https://github.com/NVIDIA/NeMo/pull/4221 | 1,243,865,857 | PR_kwDOC_bI7s44OmJw | 4,221 | Dialogue tutorial fix | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-21T04:31:45 | 2022-05-21T06:19:04 | 2022-05-21T06:19:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4221",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4221",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4221.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4221.patch",
"merged_at": "2022-05-21T06:19:01"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4221/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4221/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4220 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4220/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4220/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4220/events | https://github.com/NVIDIA/NeMo/pull/4220 | 1,243,773,759 | PR_kwDOC_bI7s44OVMy | 4,220 | Add RETRO indexed dataset and `set_inference_key_value_memory` inference | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-20T23:07:54 | 2022-06-02T13:11:34 | 2022-06-02T13:11:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4220",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4220",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4220.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4220.patch",
"merged_at": "2022-06-02T13:11:23"
} | # What does this PR do ?
1. Added the RETRO index dataset for both data and retrieval data
2. Added the KNN Map index dataset
3. Added unit tests for all the index dataset
4. Added RETRO dataset that uses index dataset
5. Added the scripts to preprocess, build Faiss index and generate KNN map index for training
6. Added the `set_inference_key_value_memory` capability to RETRO modules so it can run inference efficiently
7. Added unit tests for efficient inference of all RETRO modules.
| {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4220/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4220/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4219 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4219/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4219/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4219/events | https://github.com/NVIDIA/NeMo/pull/4219 | 1,243,740,334 | PR_kwDOC_bI7s44OODs | 4,219 | Update configs from LAMB to AdamW | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-20T22:09:42 | 2022-05-24T17:54:07 | 2022-05-23T17:39:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4219",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4219",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4219.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4219.patch",
"merged_at": null
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Replaces LAMB optimizer (unstable, hangs during multi-GPU training) with AdamW for FastPitch and Mixer-TTS configs.
**Collection**: TTS
# Changelog
- Replace LAMB defaults with AdamW
- Update `fastpitch.py` example script to use existing config
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4219/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4219/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4218 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4218/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4218/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4218/events | https://github.com/NVIDIA/NeMo/pull/4218 | 1,243,434,846 | PR_kwDOC_bI7s44NKH1 | 4,218 | Dialogue tutorial fix | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-20T17:29:22 | 2022-05-21T04:23:42 | 2022-05-21T04:23:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4218",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4218",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4218.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4218.patch",
"merged_at": "2022-05-21T04:23:33"
} | # What does this PR do ?
Restore previously deleted files from conflicting PR
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4218/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4218/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4214 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4214/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4214/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4214/events | https://github.com/NVIDIA/NeMo/pull/4214 | 1,242,577,021 | PR_kwDOC_bI7s44KVsX | 4,214 | Dialogue tutorial fix | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-20T04:02:15 | 2022-05-20T04:16:05 | 2022-05-20T04:16:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4214",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4214",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4214.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4214.patch",
"merged_at": "2022-05-20T04:16:01"
} | # What does this PR do ?
Dialogue tutorial fix (path of a file has been shifted by a conflicting PR)
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4214/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4214/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4213 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4213/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4213/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4213/events | https://github.com/NVIDIA/NeMo/pull/4213 | 1,242,484,725 | PR_kwDOC_bI7s44KC5Q | 4,213 | Fuse bias with geglu in ParallelMLP | {
"login": "xrennvidia",
"id": 103958965,
"node_id": "U_kgDOBjJJtQ",
"avatar_url": "https://avatars.githubusercontent.com/u/103958965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xrennvidia",
"html_url": "https://github.com/xrennvidia",
"followers_url": "https://api.github.com/users/xrennvidia/followers",
"following_url": "https://api.github.com/users/xrennvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/xrennvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xrennvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xrennvidia/subscriptions",
"organizations_url": "https://api.github.com/users/xrennvidia/orgs",
"repos_url": "https://api.github.com/users/xrennvidia/repos",
"events_url": "https://api.github.com/users/xrennvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/xrennvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-20T01:14:20 | 2022-06-03T23:58:14 | 2022-06-03T23:58:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4213",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4213",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4213.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4213.patch",
"merged_at": "2022-06-03T23:58:14"
} | # What does this PR do ?
Fuse bias with geglu in ParallelMLP
# Changelog
fused bias with geglu using TorchScript, fused function is in the newly added file fused_bias_geglu.py
in ParallelMLP, changed bias_gelu_fusion to biad_activation_fusion for generality, also fixed the way of this arg is propagated
# Usage
By default, bias_activation_fusion=True. If you want to disable it, simply set it as False in your config file.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4213/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4213/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4212 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4212/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4212/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4212/events | https://github.com/NVIDIA/NeMo/pull/4212 | 1,242,468,224 | PR_kwDOC_bI7s44J_Wb | 4,212 | Prompt Learning Model Saving Changes | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-20T00:51:11 | 2022-05-20T22:53:28 | 2022-05-20T22:52:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4212",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4212",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4212.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4212.patch",
"merged_at": "2022-05-20T22:52:36"
} | Signed-off-by: Virginia Adams <[email protected]>
Save all gpt + model weights to the model_weight.ckpt file removing the gpt model's .nemo file artifact. Saves GPT model's config file as an artifact.
**Collection**: BigNLP
# Changelog
Updated PromptLearningModel
# Usage
* You can potentially add a usage example below
Same as before
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4212/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4212/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4211 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4211/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4211/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4211/events | https://github.com/NVIDIA/NeMo/pull/4211 | 1,242,408,354 | PR_kwDOC_bI7s44Jyrh | 4,211 | fix bugs for dialogue tutorial | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T22:54:52 | 2022-05-19T22:55:41 | 2022-05-19T22:55:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4211",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4211",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4211.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4211.patch",
"merged_at": "2022-05-19T22:55:19"
} | # What does this PR do ?
Fix typos in dialogue tutorial
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4211/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4211/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4210 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4210/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4210/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4210/events | https://github.com/NVIDIA/NeMo/pull/4210 | 1,242,370,324 | PR_kwDOC_bI7s44Jqby | 4,210 | MegaMolBART compatibility | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T21:56:17 | 2022-06-28T22:54:36 | 2022-06-28T22:54:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4210",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4210",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4210.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4210.patch",
"merged_at": null
} | # What does this PR do ?
1. Fixes RegExTokenizer missing attributes.
2. Fixes broken Megatron encoder-decoder LM model ability to receive directly encoder hiddens.
```
MegatronLMEncoderDecoderModel.forward(
self,
encoder_input_ids,
decoder_input_ids,
encoder_attn_mask,
decoder_attn_mask,
token_type_ids=None,
lm_labels=None,
# NEW API
enc_output=None,
enc_output_attn_mask=None,
# NEW API
output_enc_hidden_only=False,
enc_input=None,
):
```
3. Added MegatronLMEncoderDecoderModel.encode method.
4. Improved decoding speed.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4210/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4210/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4209 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4209/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4209/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4209/events | https://github.com/NVIDIA/NeMo/pull/4209 | 1,242,289,334 | PR_kwDOC_bI7s44JZFx | 4,209 | Tacotron2 1.9.0 bugfixes | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T20:27:22 | 2022-05-20T17:05:59 | 2022-05-20T17:05:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4209",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4209",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4209.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4209.patch",
"merged_at": "2022-05-20T17:05:56"
} | # What does this PR do ?
Update Tacotron2 training tutorial and config to work with r.1.9.0
**Collection**: TTS
# Changelog
- Updated 44kHz config to use TTSDataset (now matches with 22kHz config)
- Added file downloads necessary for training to the Tacotron2 notebook
- Minor bugfix to avoid device mismatch during training for the notebook
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4209/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4209/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4208 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4208/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4208/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4208/events | https://github.com/NVIDIA/NeMo/pull/4208 | 1,242,280,754 | PR_kwDOC_bI7s44JXPa | 4,208 | Updated to Prompt Learning Model to Use Distributed Sampler | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T20:18:57 | 2022-05-26T14:40:38 | 2022-05-19T21:50:28 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4208",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4208",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4208.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4208.patch",
"merged_at": "2022-05-19T21:50:28"
} | Signed-off-by: Virginia Adams <[email protected]>
# What does this PR do ?
Updates the prompt learning model to use pytorch's DistributedSampler and fixes an issue with trailing spaces at the end of some prompts during inference.
**Collection**: BigNLP
# Changelog
Updated PromptLearningDataset class
Updated PromptLearningModel class
# Usage
Same as before
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4208/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4208/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4207 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4207/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4207/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4207/events | https://github.com/NVIDIA/NeMo/pull/4207 | 1,242,053,032 | PR_kwDOC_bI7s44IoOE | 4,207 | Update ContextNet version | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T16:52:31 | 2022-06-16T20:01:19 | 2022-05-19T16:52:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4207",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4207",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4207.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4207.patch",
"merged_at": "2022-05-19T16:52:42"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Update ContextNet 1024 checkpoint on NeMo ASR Set 3.0
**Collection**: [ASR]
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4207/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4207/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4205 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4205/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4205/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4205/events | https://github.com/NVIDIA/NeMo/pull/4205 | 1,241,086,792 | PR_kwDOC_bI7s44FdOC | 4,205 | Support larger datasets for question answering | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T02:59:01 | 2022-06-06T22:11:06 | 2022-06-05T04:43:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4205",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4205",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4205.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4205.patch",
"merged_at": "2022-06-05T04:43:19"
} | # What does this PR do ?
Support larger datasets for question answering
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4205/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4205/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4204 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4204/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4204/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4204/events | https://github.com/NVIDIA/NeMo/pull/4204 | 1,240,897,553 | PR_kwDOC_bI7s44Ez7H | 4,204 | Fix cherrypicks | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-19T01:11:08 | 2022-05-19T18:38:04 | 2022-05-19T18:38:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4204",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4204",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4204.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4204.patch",
"merged_at": "2022-05-19T18:38:01"
} | # What does this PR do ?
Cherry pick some fixes from main to r1.9.0
**Collection**: [Core, ASR]
# Changelog
- Fix hydra.
- Fix mandarin checkpoint
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4204/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4204/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4203 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4203/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4203/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4203/events | https://github.com/NVIDIA/NeMo/pull/4203 | 1,240,715,258 | PR_kwDOC_bI7s44ELrs | 4,203 | Add special tokens to existing (trained) SentencePiece models | {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T23:28:46 | 2022-05-25T18:47:08 | 2022-05-25T18:47:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4203",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4203",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4203.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4203.patch",
"merged_at": "2022-05-25T18:47:05"
} | Signed-off-by: Abhinav Khattar <[email protected]>
# What does this PR do ?
Script to add special tokens to existing SentencePiece model. This can help in moving away from the legacy way of handling special tokens.
**Collection**: None
# Usage
`python edit_spt_model.py --input_file <input_model_dir> --output_file <output_model_dir> --tokens <space separated special tokens> `
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4203/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4203/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4202 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4202/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4202/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4202/events | https://github.com/NVIDIA/NeMo/pull/4202 | 1,240,613,753 | PR_kwDOC_bI7s44Dz7f | 4,202 | Patch Hydra | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T22:26:25 | 2022-05-18T23:42:24 | 2022-05-18T23:42:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4202",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4202",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4202.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4202.patch",
"merged_at": "2022-05-18T23:42:20"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Fix Hydra issue with hydra_runner
**Collection**: [Core]
# Changelog
- Update signature and lower bound to latest hydra
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4202/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4202/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4201 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4201/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4201/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4201/events | https://github.com/NVIDIA/NeMo/pull/4201 | 1,240,599,070 | PR_kwDOC_bI7s44Dwgw | 4,201 | added conformer mandarin model. | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T22:17:20 | 2022-05-18T23:04:05 | 2022-05-18T23:04:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4201",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4201",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4201.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4201.patch",
"merged_at": "2022-05-18T23:04:04"
} | Signed-off-by: Vahid <[email protected]>
# What does this PR do ?
Adding the checkpoint of a Mandarin ASR model trained with Conformer-Transducer to the pretrained model's list. It is trained on AIShell-2 dataset.
# Changelog
Added a Mandarin ASR model trained with Conformer-Transducer on AIShell-2.
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4201/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4201/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4200 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4200/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4200/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4200/events | https://github.com/NVIDIA/NeMo/pull/4200 | 1,240,569,513 | PR_kwDOC_bI7s44Dpv4 | 4,200 | Update Dialogue tutorial | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-18T21:56:37 | 2022-09-20T23:56:25 | 2022-05-19T23:09:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4200",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4200",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4200.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4200.patch",
"merged_at": null
} | # What does this PR do ?
Update typos in Dialogue Tutorial
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4200/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4200/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4199 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4199/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4199/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4199/events | https://github.com/NVIDIA/NeMo/pull/4199 | 1,240,563,099 | PR_kwDOC_bI7s44DoZg | 4,199 | Fix/punctuation/trainer required for setting test data | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "PeganovAnton",
"id": 10737305,
"node_id": "MDQ6VXNlcjEwNzM3MzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/10737305?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PeganovAnton",
"html_url": "https://github.com/PeganovAnton",
"followers_url": "https://api.github.com/users/PeganovAnton/followers",
"following_url": "https://api.github.com/users/PeganovAnton/following{/other_user}",
"gists_url": "https://api.github.com/users/PeganovAnton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PeganovAnton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PeganovAnton/subscriptions",
"organizations_url": "https://api.github.com/users/PeganovAnton/orgs",
"repos_url": "https://api.github.com/users/PeganovAnton/repos",
"events_url": "https://api.github.com/users/PeganovAnton/events{/privacy}",
"received_events_url": "https://api.github.com/users/PeganovAnton/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-18T21:47:24 | 2022-05-19T13:35:14 | 2022-05-19T13:35:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4199",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4199",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4199.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4199.patch",
"merged_at": "2022-05-19T13:35:11"
} | # What does this PR do ?
1. Previously `PunctuationCapitalizationModel.set_trainer()` was required before calling `PunctuationCapitalizatoinModel.set_{training,test,validation}_data()`. This is unexpected for users. Now `set_trainer()` call is not required and warnings are shown.
2. Training random seed for batching is now `current_epoch` instead of `global_step`.
3. Typo fix
4. Fix last cell in punctuation notebook tutorial.
**Collection**: nlp
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4199/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4199/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4198 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4198/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4198/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4198/events | https://github.com/NVIDIA/NeMo/pull/4198 | 1,240,562,427 | PR_kwDOC_bI7s44DoQD | 4,198 | Merge r1.9.0 main | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T21:46:27 | 2022-05-20T18:15:06 | 2022-05-20T18:15:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4198",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4198",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4198.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4198.patch",
"merged_at": "2022-05-20T18:15:02"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4198/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4198/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4197 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4197/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4197/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4197/events | https://github.com/NVIDIA/NeMo/pull/4197 | 1,240,511,668 | PR_kwDOC_bI7s44DdTS | 4,197 | Prompt tokenization bugfix | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T20:51:28 | 2022-05-19T19:51:56 | 2022-05-19T18:44:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4197",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4197",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4197.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4197.patch",
"merged_at": "2022-05-19T18:44:00"
} | # What does this PR do ?
1. adds <> around virtual prompt token string
2. Removes pseudo token configurability from the config file in favor of using a consistent pseudo token set by us
3. Makes PROMPT lowercase
**Collection**: BigNLP
# Changelog
Updated megatron_gpt_prompt_learning_model
Updated prompt learning dataset unit tests
Added Enum for virtual prompt token string
# Usage
Same as before
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4197/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4197/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4196 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4196/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4196/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4196/events | https://github.com/NVIDIA/NeMo/pull/4196 | 1,240,376,415 | PR_kwDOC_bI7s44DCpd | 4,196 | Fix the server key value problem in the notebook | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T18:55:17 | 2022-05-18T18:58:14 | 2022-05-18T18:57:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4196",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4196",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4196.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4196.patch",
"merged_at": "2022-05-18T18:57:36"
} | Fix the key error in Tabular Data generation caused by the change of default prompts. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4196/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4196/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4195 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4195/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4195/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4195/events | https://github.com/NVIDIA/NeMo/pull/4195 | 1,240,201,745 | PR_kwDOC_bI7s44CfrH | 4,195 | Pin omegaconf for r1.9.0 | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T16:21:15 | 2022-05-18T18:58:09 | 2022-05-18T18:58:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4195",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4195",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4195.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4195.patch",
"merged_at": "2022-05-18T18:58:06"
} | Signed-off-by: ericharper <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4195/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4195/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4193 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4193/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4193/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4193/events | https://github.com/NVIDIA/NeMo/issues/4193 | 1,239,789,804 | I_kwDOC_bI7s5J5bDs | 4,193 | training with horovod | {
"login": "EmreOzkose",
"id": 17765576,
"node_id": "MDQ6VXNlcjE3NzY1NTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/EmreOzkose",
"html_url": "https://github.com/EmreOzkose",
"followers_url": "https://api.github.com/users/EmreOzkose/followers",
"following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}",
"gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}",
"starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions",
"organizations_url": "https://api.github.com/users/EmreOzkose/orgs",
"repos_url": "https://api.github.com/users/EmreOzkose/repos",
"events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}",
"received_events_url": "https://api.github.com/users/EmreOzkose/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-18T11:02:44 | 2022-05-20T18:51:27 | 2022-05-20T18:51:27 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi, I am trying to use horovod for accelerator. Training steps:
1. cd NeMo/examples/nlp/text_classification
2. python text_classification_with_bert.py
This steps works without any problem. However when I try to use horovod:
1. cd NeMo/examples/nlp/text_classification
2.change pl Trainer:
pl.Trainer(plugins=[NLPDDPPlugin()], **cfg.trainer) to trainer = pl.Trainer(strategy="horovod", accelerator="gpu", devices=1, plugins=[NLPDDPPlugin()], **cfg.trainer) in `text_classification_with_bert.py`
3. horovodrun -np 1 -H server1:1 --verbose --start-timeout 300 python text_classification_with_bert.py
I got this error:
```
(nemo)$ horovodrun -np 1 -H server1:1 --verbose --start-timeout 300 python text_classification_with_bert.py
Filtering local host names.
Remote host found: server1
Checking ssh on all remote hosts.
SSH was successful into all the remote hosts.
Testing interfaces on all the hosts.
Launched horovod server.
Launching horovod task function: ssh -o PasswordAuthentication=no -o StrictHostKeyChecking=no server1 path/to/miniconda3/envs/nemo/bin/python -m horovod.runner.task_fn ...
Attempted to launch horovod task servers.
Waiting for the hosts to acknowledge.
Launching horovod task function was not successful:
bash: path/to/miniconda3/envs/nemo/bin/python: No such file or directory
```
**Environment overview**
PyTorch version: 1.11.0
CUDA used to build PyTorch: 10.2
OS: Ubuntu 18.04.3
Python version: 3.8.13
Is CUDA available: True
CUDA runtime version: 11.3.58
Versions of relevant libraries:
[pip3] numpy==1.21.5
[pip3] pytorch-lightning==1.6.1
[pip3] torch==1.11.0
[pip3] torch-stft==0.1.4
[pip3] torchaudio==0.11.0
[pip3] torchmetrics==0.8.0
[pip3] torchvision==0.12.0
[conda] pytorch 1.11.0 py3.8_cuda10.2_cudnn7.6.5_0 pytorch
[conda] pytorch-lightning 1.6.1 pypi_0 pypi
[conda] pytorch-mutex 1.0 cuda pytorch
[conda] torch-stft 0.1.4 pypi_0 pypi
[conda] torchaudio 0.11.0 py38_cu102 pytorch
[conda] torchmetrics 0.8.0 pypi_0 pypi
[conda] torchvision 0.12.0 py38_cu102 pytorch
Note: I run an [mnist example with Horovod](https://github.com/horovod/horovod/blob/master/examples/pytorch/pytorch_mnist.py) itself directly without a problem. | {
"login": "EmreOzkose",
"id": 17765576,
"node_id": "MDQ6VXNlcjE3NzY1NTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/EmreOzkose",
"html_url": "https://github.com/EmreOzkose",
"followers_url": "https://api.github.com/users/EmreOzkose/followers",
"following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}",
"gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}",
"starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions",
"organizations_url": "https://api.github.com/users/EmreOzkose/orgs",
"repos_url": "https://api.github.com/users/EmreOzkose/repos",
"events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}",
"received_events_url": "https://api.github.com/users/EmreOzkose/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4193/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4193/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4192 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4192/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4192/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4192/events | https://github.com/NVIDIA/NeMo/issues/4192 | 1,239,785,647 | I_kwDOC_bI7s5J5aCv | 4,192 | error running offline_diarization.py | {
"login": "RezaBi",
"id": 102900868,
"node_id": "U_kgDOBiIkhA",
"avatar_url": "https://avatars.githubusercontent.com/u/102900868?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RezaBi",
"html_url": "https://github.com/RezaBi",
"followers_url": "https://api.github.com/users/RezaBi/followers",
"following_url": "https://api.github.com/users/RezaBi/following{/other_user}",
"gists_url": "https://api.github.com/users/RezaBi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RezaBi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RezaBi/subscriptions",
"organizations_url": "https://api.github.com/users/RezaBi/orgs",
"repos_url": "https://api.github.com/users/RezaBi/repos",
"events_url": "https://api.github.com/users/RezaBi/events{/privacy}",
"received_events_url": "https://api.github.com/users/RezaBi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-18T10:58:50 | 2022-06-01T16:29:26 | 2022-05-20T18:52:30 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hi, I have previously run the code as stated in Usage description of the script. However, now I get this error by running the exact same code. This is the error messege.
Global seed set to 42
Traceback (most recent call last):
File "/content/NeMo/examples/speaker_tasks/diarization/offline_diarization.py", line 46, in <module>
main()
File "/usr/local/lib/python3.7/dist-packages/nemo/core/config/hydra_runner.py", line 108, in wrapper
config_name=config_name,
TypeError: _run_hydra() missing 1 required positional argument: 'args'
**Steps/Code to reproduce bug**
!python3 /content/NeMo/examples/speaker_tasks/diarization/offline_diarization.py \
diarizer.manifest_filepath='/content/input_manifest.json' \
diarizer.out_dir='demo_output' \
diarizer.speaker_embeddings.model_path='titanet_large' \
diarizer.oracle_vad=True
**Environment overview (please complete the following information)**
On Google colab
**Environment details**
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4192/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4192/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4191 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4191/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4191/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4191/events | https://github.com/NVIDIA/NeMo/pull/4191 | 1,239,396,687 | PR_kwDOC_bI7s43_0sx | 4,191 | Upperbound OmegaConf | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T03:59:08 | 2022-05-18T04:03:26 | 2022-05-18T04:03:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4191",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4191",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4191.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4191.patch",
"merged_at": "2022-05-18T04:03:22"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Try to fix omegaconf (again)
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4191/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4191/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4190 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4190/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4190/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4190/events | https://github.com/NVIDIA/NeMo/pull/4190 | 1,239,387,256 | PR_kwDOC_bI7s43_ywf | 4,190 | Upperbound OmegaConf | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T03:37:44 | 2022-05-18T03:38:03 | 2022-05-18T03:38:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4190",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4190",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4190.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4190.patch",
"merged_at": "2022-05-18T03:38:00"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Fix omegaconf incompatibility.
**Collection**: [Core]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
@ericharper | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4190/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4190/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4189 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4189/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4189/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4189/events | https://github.com/NVIDIA/NeMo/pull/4189 | 1,239,383,123 | PR_kwDOC_bI7s43_x53 | 4,189 | Add support for Decoder + Joint Adapters for ASR | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T03:29:23 | 2022-05-24T23:01:36 | 2022-05-24T23:01:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4189",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4189",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4189.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4189.patch",
"merged_at": "2022-05-24T23:01:33"
} | # What does this PR do ?
Add support for decoder + joint adapters, alongside encoder adapters. Supports CTC + RNNT decoders, RNNT Joint, RNNT Decoder + Joint adapter.
**Collection**: [ASR]
# Changelog
- Support CTC Decoder, RNNT Decoder, RNNT Joint adapter support (module level).
- Update tests to check new modules
- Add support for property that defines list of valid modules that support adapters.
# Usage
```python
# Add a code snippet demonstrating how to use this
model.add_adapter("decoder:<adapter_name>", cfg=...) # decoder only adapter; CTC/RNNT
model.add_adapter("joint:<adapter_name>", cfg=...) # joint only adapter; RNNT only
model.add_adapter("decoder+joint:<adapter_name>", cfg=...) # decoder + joint adapter; RNNT only
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4189/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4189/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4188 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4188/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4188/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4188/events | https://github.com/NVIDIA/NeMo/issues/4188 | 1,239,363,369 | I_kwDOC_bI7s5J3y8p | 4,188 | AN4 Dataset Not Found under ASR | {
"login": "machinelearningzuu",
"id": 41842488,
"node_id": "MDQ6VXNlcjQxODQyNDg4",
"avatar_url": "https://avatars.githubusercontent.com/u/41842488?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/machinelearningzuu",
"html_url": "https://github.com/machinelearningzuu",
"followers_url": "https://api.github.com/users/machinelearningzuu/followers",
"following_url": "https://api.github.com/users/machinelearningzuu/following{/other_user}",
"gists_url": "https://api.github.com/users/machinelearningzuu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/machinelearningzuu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/machinelearningzuu/subscriptions",
"organizations_url": "https://api.github.com/users/machinelearningzuu/orgs",
"repos_url": "https://api.github.com/users/machinelearningzuu/repos",
"events_url": "https://api.github.com/users/machinelearningzuu/events{/privacy}",
"received_events_url": "https://api.github.com/users/machinelearningzuu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-18T02:51:29 | 2022-05-18T03:11:22 | 2022-05-18T03:11:22 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
The provided link for AN4 dataset under [http://www.speech.cs.cmu.edu/databases/an4/](here) is not accessible. Please validate the URL. | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4188/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4188/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4187 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4187/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4187/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4187/events | https://github.com/NVIDIA/NeMo/pull/4187 | 1,239,333,082 | PR_kwDOC_bI7s43_nlU | 4,187 | Dataloader, collector, loss and metric for multiscale diarization decoder | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-18T01:52:47 | 2022-06-13T23:35:14 | 2022-06-13T23:35:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4187",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4187",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4187.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4187.patch",
"merged_at": "2022-06-13T23:35:13"
} | # What does this PR do ?
This PR adds dataloaders, collectors, loss functions and accuracy metric for multiscale diarization decoder to NeMo. Multiscale diarization decoder is a model that accepts cluster-average embedding and multiscale embeddings to infer diarization output. Before push the model files and inference scripts, these files better be reviewed and merged to reduce the bandwidth of PR review.
**Collection**: ASR (speaker tasks)
# Changelog
- `nemo/collections/asr/data/audio_to_label.py`
Added the following classes:
`AudioToSpeechDiarTrainDataset()`
`_AudioDiarTrainDataset()`
The above classes are built for diarization training and validation.
The input is raw audio waveform with segmentation timestamp information.
Diarization inference procedure involves clustering process for varying number of speakers.
Therefore, training is done only for two speaker dataset. For inference, we need
a separate dataloader that takes clustering results and cluster-average embedding as inputs.
`AudioToSpeechMSDDDataset()`
`_AudioMSDDDataset()`
The above classes are built for diarization inference. The input is speaker embeddings and cluster-average embeddings.
Added the following functions:
`get_scale_mapping_list()`
`_extract_seg_info_from_rttm()`
`_assign_frame_level_spk_vector()`
`_get_diar_target_labels()`
`_msdd_collate_fn()`
`_diar_train_collate_fn()`
- `nemo/collections/common/parts/preprocessing/collections.py`
The following functions are added to collect audio_filepath, rttm_filepath and number of speakers.
DiarizationSpeechLabel()
DiarizationLabel()
- `nemo/collections/asr/losses/bce_loss.py`
This file is newly created. Contains binary cross entropy loss that is needed for training overlap-aware diarization models since one unit timestep output vector should be able to contain more than one label.
- `nemo/collections/asr/metrics/multi_binary_acc.py`
Multi-binary accuracy that currently includes F1 accuracy. This file is named as "multi-binary accuracy" since other accuracy measures such as area under curve can be added in the future.
# Usage
These are newly added class and functions. The yaml file and inference script will be provided later when model files are uploaded.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in NeMo ASR.
# Additional Information
For more details about multiscale diarization decoder, check out the following paper:
https://arxiv.org/pdf/2203.15974.pdf
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4187/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4187/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4186 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4186/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4186/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4186/events | https://github.com/NVIDIA/NeMo/pull/4186 | 1,239,238,705 | PR_kwDOC_bI7s43_TuN | 4,186 | SSL Multi-loss Update | {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-17T22:52:07 | 2022-05-25T01:23:51 | 2022-05-25T01:23:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4186",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4186",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4186.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4186.patch",
"merged_at": "2022-05-25T01:23:51"
} | # What does this PR do ?
- adds multi-loss training to ssl, with corresponding list of decoders and losses defined through the ssl model config
- adds option to use pseudo-labels from quantization module of contrastive loss as targets for other losses
- adds option for ssl decoders to use outputs of non-final layer of encoder as input
- default ssl config is updated to use contrastive + mlm loss combination
- adds tests for ssl and maskedpatchaugmentation
- fixes sampling for tarred datasets with multiple utterances per file
**Collection**: ASR
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4186/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4186/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4185 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4185/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4185/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4185/events | https://github.com/NVIDIA/NeMo/pull/4185 | 1,238,831,154 | PR_kwDOC_bI7s4398Vs | 4,185 | Speakertasks manifest | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-17T15:39:46 | 2022-05-23T17:45:17 | 2022-05-23T17:45:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4185",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4185",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4185.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4185.patch",
"merged_at": "2022-05-23T17:45:15"
} | adding optional duration to manifest, so we can use it with speech explorer | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4185/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4185/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4184 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4184/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4184/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4184/events | https://github.com/NVIDIA/NeMo/pull/4184 | 1,238,261,231 | PR_kwDOC_bI7s438A85 | 4,184 | Implements the UL2 Dataset and config | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-17T08:21:48 | 2022-06-01T01:03:28 | 2022-06-01T01:03:26 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4184",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4184",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4184.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4184.patch",
"merged_at": "2022-06-01T01:03:26"
} | # What does this PR do ?
1. Implements the UL2 Dataset from https://arxiv.org/abs/2205.05131.
2. Adds a `megatron_ul2_config.yaml` to train an encoder-decoder model on this data using t5 pretraining script.
**Collection**: NLP
# Changelog
- UL2 dataset class that inherits from T5Dataset
- UL2 yaml config
- Minor refactor of LMAdaptedT5Dataset
# Usage
`python megatron_t5_pretraining.py -cn megatron_ul2_config`
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4184/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4184/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4183 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4183/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4183/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4183/events | https://github.com/NVIDIA/NeMo/issues/4183 | 1,238,085,125 | I_kwDOC_bI7s5Jy64F | 4,183 | Conformer Model Training Details. | {
"login": "evilc3",
"id": 19889717,
"node_id": "MDQ6VXNlcjE5ODg5NzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/19889717?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/evilc3",
"html_url": "https://github.com/evilc3",
"followers_url": "https://api.github.com/users/evilc3/followers",
"following_url": "https://api.github.com/users/evilc3/following{/other_user}",
"gists_url": "https://api.github.com/users/evilc3/gists{/gist_id}",
"starred_url": "https://api.github.com/users/evilc3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/evilc3/subscriptions",
"organizations_url": "https://api.github.com/users/evilc3/orgs",
"repos_url": "https://api.github.com/users/evilc3/repos",
"events_url": "https://api.github.com/users/evilc3/events{/privacy}",
"received_events_url": "https://api.github.com/users/evilc3/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-17T05:21:39 | 2023-03-29T15:32:19 | 2022-05-20T18:51:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi I am training a Conformer Model and need to know if thing about the training process.
My Training params :
- learning rate : 0.1,
- batch_size = 128
- max_epochs : 100
- warmup steps : 10000
The questions I had were.
1. What hardware was used to train the `ctc_conformer_large` and `ctc_conformers_medium` models. gpus and how long were they trained (hrs).
2. If my learning rate has reduced to 1e-6 will the model still continue learning or should I be stopping at this point.
asking becz using the noam scheduler the learning rate has decreased quite a bit in the first 2 epochs only and hv another 98 to go.
3. A curious question what happens if my batch size is 4 and a set up a really high grad accum like 16 will his work?
@titu1994
thanks
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4183/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4183/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4182 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4182/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4182/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4182/events | https://github.com/NVIDIA/NeMo/pull/4182 | 1,237,841,657 | PR_kwDOC_bI7s436nKr | 4,182 | [TTS] Fix Hifigan finetune tutorial | {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T23:10:50 | 2022-05-17T04:51:40 | 2022-05-17T04:51:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4182",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4182",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4182.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4182.patch",
"merged_at": "2022-05-17T04:51:28"
} | Signed-off-by: Subhankar Ghosh <[email protected]>
# What does this PR do ?
Fix Hifigan finetune tutorial
Solution to https://github.com/NVIDIA/NeMo/issues/4181
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #4181
| {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4182/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4182/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4181 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4181/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4181/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4181/events | https://github.com/NVIDIA/NeMo/issues/4181 | 1,237,775,966 | I_kwDOC_bI7s5JxvZe | 4,181 | Possible bug in the tutorial for fine-tuning hifi | {
"login": "Nistrian",
"id": 69087388,
"node_id": "MDQ6VXNlcjY5MDg3Mzg4",
"avatar_url": "https://avatars.githubusercontent.com/u/69087388?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Nistrian",
"html_url": "https://github.com/Nistrian",
"followers_url": "https://api.github.com/users/Nistrian/followers",
"following_url": "https://api.github.com/users/Nistrian/following{/other_user}",
"gists_url": "https://api.github.com/users/Nistrian/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Nistrian/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Nistrian/subscriptions",
"organizations_url": "https://api.github.com/users/Nistrian/orgs",
"repos_url": "https://api.github.com/users/Nistrian/repos",
"events_url": "https://api.github.com/users/Nistrian/events{/privacy}",
"received_events_url": "https://api.github.com/users/Nistrian/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T21:59:56 | 2022-05-16T23:19:41 | 2022-05-16T23:19:41 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello! I'm trying to fine-tune the HiFi according to your fastpitch_finetuning tutorial. I generated manifests in the same format as in the example. Then I launched the fine-tuning script by simply changing the paths. Despite the small number of changes, I constantly get an error. I tried to study the code to understand what I'm doing wrong. In the process of studying, I found a possible cause of my troubles and would like to ask you on whose side the error occurred. I think it would be more convenient to explain the essence of my question with screenshots.
You use the file path as the model.train_ds parameter:

Next, I went through the error traceback and found that at some point the parameter that was specified in the previous step is used. If I didn’t mix up anything, then we also just use the path to the file:

In the next traceback step, we send this path to the setup_data_loader_from_config function, where the error occurs. Looking inside the function, I found that our argument is checked for the presence of the word "dataset". It is at this point that the error occurs, since the path to my manifest does not contain this word. Although, apparently, it was assumed that the input of the function would not be a string containing the path to the manifest, but the config itself, which would contain the specified argument. The same thing can be observed in the two lines of code below, where the presence of dataloader_params is checked:

In this regard, I really hope for your help. Thanks in advance!
| {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4181/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4181/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4180 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4180/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4180/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4180/events | https://github.com/NVIDIA/NeMo/pull/4180 | 1,237,667,264 | PR_kwDOC_bI7s436AJm | 4,180 | small import name fix | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T20:17:08 | 2022-05-16T20:29:22 | 2022-05-16T20:29:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4180",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4180",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4180.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4180.patch",
"merged_at": "2022-05-16T20:29:14"
} | Signed-off-by: fayejf <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4180/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4180/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4179 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4179/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4179/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4179/events | https://github.com/NVIDIA/NeMo/pull/4179 | 1,237,665,404 | PR_kwDOC_bI7s435_u7 | 4,179 | Tiny import func name fix | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T20:15:33 | 2022-05-16T20:29:23 | 2022-05-16T20:15:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4179",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4179",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4179.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4179.patch",
"merged_at": null
} | # What does this PR do ?
import function name fix
**Collection**: ASE
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4179/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4179/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4177 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4177/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4177/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4177/events | https://github.com/NVIDIA/NeMo/pull/4177 | 1,237,552,499 | PR_kwDOC_bI7s435myG | 4,177 | [bugfix] consistent highfreq to both fastpitch and hifigan in their 44100 configs. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T18:35:47 | 2022-05-16T19:33:03 | 2022-05-16T19:33:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4177",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4177",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4177.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4177.patch",
"merged_at": "2022-05-16T19:33:00"
} | # What does this PR do ?
make highfreq consistent to both fastpitch and hifigan in their 44100 configs.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4177/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4177/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4176 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4176/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4176/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4176/events | https://github.com/NVIDIA/NeMo/issues/4176 | 1,237,288,521 | I_kwDOC_bI7s5Jv4ZJ | 4,176 | SpeakerDecoder weight normalization | {
"login": "maevdokimov",
"id": 43167887,
"node_id": "MDQ6VXNlcjQzMTY3ODg3",
"avatar_url": "https://avatars.githubusercontent.com/u/43167887?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maevdokimov",
"html_url": "https://github.com/maevdokimov",
"followers_url": "https://api.github.com/users/maevdokimov/followers",
"following_url": "https://api.github.com/users/maevdokimov/following{/other_user}",
"gists_url": "https://api.github.com/users/maevdokimov/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maevdokimov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maevdokimov/subscriptions",
"organizations_url": "https://api.github.com/users/maevdokimov/orgs",
"repos_url": "https://api.github.com/users/maevdokimov/repos",
"events_url": "https://api.github.com/users/maevdokimov/events{/privacy}",
"received_events_url": "https://api.github.com/users/maevdokimov/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-16T14:56:50 | 2022-06-04T22:23:51 | 2022-06-04T22:23:51 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi!
When reading SpeakerDecoder code I bumped into [this](https://github.com/NVIDIA/NeMo/blob/1d3eb3d0d045f7f57316217320b8d265bf3256ce/nemo/collections/asr/modules/conv_asr.py#L848) line. Looks like it is weight normalization for AAS loss. But why should it work?
```
>>> import torch.nn as nn
>>> import torch.nn.functional as F
>>> layer = nn.Linear(128, 100, bias=False)
>>> weight1 = layer.weight.data.clone()
>>> for W in layer.parameters():
... W = F.normalize(W, p=2, dim=1)
...
>>> weight2 = layer.weight.data.clone()
>>> weight1 == weight2
tensor([[True, True, True, ..., True, True, True],
[True, True, True, ..., True, True, True],
[True, True, True, ..., True, True, True],
...,
[True, True, True, ..., True, True, True],
[True, True, True, ..., True, True, True],
[True, True, True, ..., True, True, True]])
>>>
```
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4176/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4176/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4175 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4175/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4175/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4175/events | https://github.com/NVIDIA/NeMo/pull/4175 | 1,237,257,546 | PR_kwDOC_bI7s434m0U | 4,175 | let sox find wav duration when it is missing (None). | {
"login": "schaltung",
"id": 4131486,
"node_id": "MDQ6VXNlcjQxMzE0ODY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4131486?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/schaltung",
"html_url": "https://github.com/schaltung",
"followers_url": "https://api.github.com/users/schaltung/followers",
"following_url": "https://api.github.com/users/schaltung/following{/other_user}",
"gists_url": "https://api.github.com/users/schaltung/gists{/gist_id}",
"starred_url": "https://api.github.com/users/schaltung/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/schaltung/subscriptions",
"organizations_url": "https://api.github.com/users/schaltung/orgs",
"repos_url": "https://api.github.com/users/schaltung/repos",
"events_url": "https://api.github.com/users/schaltung/events{/privacy}",
"received_events_url": "https://api.github.com/users/schaltung/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-05-16T14:35:06 | 2022-10-07T02:13:45 | 2022-10-07T02:13:45 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4175",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4175",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4175.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4175.patch",
"merged_at": null
} | # What does this PR do ?
bug-fix. sox must find the wav duration when dur is None.
**Collection**: speaker_tasks
# Changelog
L135: this condition should be true when 'dur is None' because it allows sox to get the duration from the wav_file.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
python ../../../scripts/speaker_tasks/scp_to_manifest.py --scp voxceleb12.scp --id 8 --out TMP
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [] Did you write any new necessary tests?
- [] Did you add or update any necessary documentation?
- [] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4175/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4175/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4174 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4174/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4174/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4174/events | https://github.com/NVIDIA/NeMo/issues/4174 | 1,237,224,200 | I_kwDOC_bI7s5JvosI | 4,174 | TitaNet Small | {
"login": "naymaraq",
"id": 47416614,
"node_id": "MDQ6VXNlcjQ3NDE2NjE0",
"avatar_url": "https://avatars.githubusercontent.com/u/47416614?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/naymaraq",
"html_url": "https://github.com/naymaraq",
"followers_url": "https://api.github.com/users/naymaraq/followers",
"following_url": "https://api.github.com/users/naymaraq/following{/other_user}",
"gists_url": "https://api.github.com/users/naymaraq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/naymaraq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/naymaraq/subscriptions",
"organizations_url": "https://api.github.com/users/naymaraq/orgs",
"repos_url": "https://api.github.com/users/naymaraq/repos",
"events_url": "https://api.github.com/users/naymaraq/events{/privacy}",
"received_events_url": "https://api.github.com/users/naymaraq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-16T14:12:35 | 2023-06-15T22:46:26 | 2022-05-16T20:09:13 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi NeMo team,
Do you plan to release TitaNet-small (medium) model? | {
"login": "naymaraq",
"id": 47416614,
"node_id": "MDQ6VXNlcjQ3NDE2NjE0",
"avatar_url": "https://avatars.githubusercontent.com/u/47416614?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/naymaraq",
"html_url": "https://github.com/naymaraq",
"followers_url": "https://api.github.com/users/naymaraq/followers",
"following_url": "https://api.github.com/users/naymaraq/following{/other_user}",
"gists_url": "https://api.github.com/users/naymaraq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/naymaraq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/naymaraq/subscriptions",
"organizations_url": "https://api.github.com/users/naymaraq/orgs",
"repos_url": "https://api.github.com/users/naymaraq/repos",
"events_url": "https://api.github.com/users/naymaraq/events{/privacy}",
"received_events_url": "https://api.github.com/users/naymaraq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4174/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4174/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4173 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4173/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4173/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4173/events | https://github.com/NVIDIA/NeMo/pull/4173 | 1,236,874,554 | PR_kwDOC_bI7s433UrT | 4,173 | Add docs for Thutmose Tagger | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T09:27:43 | 2022-05-20T19:33:30 | 2022-05-20T19:33:25 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4173",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4173",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4173.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4173.patch",
"merged_at": "2022-05-20T19:33:25"
} | Signed-off-by: Alexandra Antonova <[email protected]>
# What does this PR do ?
Add docs for Thutmose Tagger model (ITN)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4173/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4173/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4172 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4172/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4172/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4172/events | https://github.com/NVIDIA/NeMo/pull/4172 | 1,236,867,871 | PR_kwDOC_bI7s433TRB | 4,172 | Thutmose tagger docs | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T09:22:06 | 2022-05-16T09:25:14 | 2022-05-16T09:25:14 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4172",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4172",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4172.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4172.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
Add docs for Thutmose Tagger model (ITN)
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4172/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4172/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4171 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4171/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4171/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4171/events | https://github.com/NVIDIA/NeMo/pull/4171 | 1,236,547,436 | PR_kwDOC_bI7s432PxS | 4,171 | set plugin to None when no apex | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-16T02:54:45 | 2022-05-16T19:00:00 | 2022-05-16T18:59:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4171",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4171",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4171.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4171.patch",
"merged_at": "2022-05-16T18:59:57"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4171/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4171/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4170 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4170/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4170/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4170/events | https://github.com/NVIDIA/NeMo/issues/4170 | 1,236,204,062 | I_kwDOC_bI7s5Jrvoe | 4,170 | k2 package conflict with NeMo | {
"login": "hamjam",
"id": 12621752,
"node_id": "MDQ6VXNlcjEyNjIxNzUy",
"avatar_url": "https://avatars.githubusercontent.com/u/12621752?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hamjam",
"html_url": "https://github.com/hamjam",
"followers_url": "https://api.github.com/users/hamjam/followers",
"following_url": "https://api.github.com/users/hamjam/following{/other_user}",
"gists_url": "https://api.github.com/users/hamjam/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hamjam/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hamjam/subscriptions",
"organizations_url": "https://api.github.com/users/hamjam/orgs",
"repos_url": "https://api.github.com/users/hamjam/repos",
"events_url": "https://api.github.com/users/hamjam/events{/privacy}",
"received_events_url": "https://api.github.com/users/hamjam/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-15T06:47:41 | 2022-05-20T18:47:23 | 2022-05-20T18:47:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I was examining `examples/asr/experimental/k2/align_speech_parallel.py` script as I wish to get speech alignments from my trained CTC-based ASR model. Somewhere, I was told that I have to install k2 package to use this script and its recommended method is by using `scripts/speech_recognition/k2/setup.sh`. However, when I executed the `setup.sh` script, its output is like this:
`ImportError: k2 was built using PyTorch 1.7.1+cu101
But you are using PyTorch 1.11.0+cu102 to run it
k2 installed with errors! Please check installation manually.`
As far as I know, NeMo needs Pytorch 1.10.0 or above to function but it seems that k2 has been built by PyTorch 1.7.1.
I know the k2 based scripts in NeMo are experimental for now, but is there any chance to bypass this? | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4170/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4170/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4169 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4169/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4169/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4169/events | https://github.com/NVIDIA/NeMo/issues/4169 | 1,235,945,689 | I_kwDOC_bI7s5JqwjZ | 4,169 | TTS removed models | {
"login": "amirrezam",
"id": 18347318,
"node_id": "MDQ6VXNlcjE4MzQ3MzE4",
"avatar_url": "https://avatars.githubusercontent.com/u/18347318?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amirrezam",
"html_url": "https://github.com/amirrezam",
"followers_url": "https://api.github.com/users/amirrezam/followers",
"following_url": "https://api.github.com/users/amirrezam/following{/other_user}",
"gists_url": "https://api.github.com/users/amirrezam/gists{/gist_id}",
"starred_url": "https://api.github.com/users/amirrezam/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amirrezam/subscriptions",
"organizations_url": "https://api.github.com/users/amirrezam/orgs",
"repos_url": "https://api.github.com/users/amirrezam/repos",
"events_url": "https://api.github.com/users/amirrezam/events{/privacy}",
"received_events_url": "https://api.github.com/users/amirrezam/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | true | null | [] | null | null | 2022-05-14T11:08:07 | 2022-05-16T19:01:38 | 2022-05-16T17:52:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
Why Some TTS model (MelGAN, TalkNet) are removed from main branch, while they are exist in 1.8.2 ?
Do you want to stop maintaining them ?
https://github.com/NVIDIA/NeMo/commit/c37786a9acb443b1d55d56636f00d3826ffc76d5 | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4169/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4169/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4168 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4168/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4168/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4168/events | https://github.com/NVIDIA/NeMo/pull/4168 | 1,235,826,771 | PR_kwDOC_bI7s430J87 | 4,168 | Add the PP2 GPT eval CI test | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-14T01:40:09 | 2022-05-14T15:33:40 | 2022-05-14T15:33:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4168",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4168",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4168.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4168.patch",
"merged_at": "2022-05-14T15:33:34"
} |
Add the PP2 GPT eval CI test. Also fix the `fake_initialize_model_parallel` | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4168/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4168/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4167 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4167/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4167/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4167/events | https://github.com/NVIDIA/NeMo/pull/4167 | 1,235,560,502 | PR_kwDOC_bI7s43zViA | 4,167 | [TTS] Add volume passthrough to fp for riva | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-13T18:31:59 | 2022-05-20T16:43:47 | 2022-05-20T16:43:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4167",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4167",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4167.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4167.patch",
"merged_at": "2022-05-20T16:43:44"
} | # What does this PR do ?
Add volume passthrough to fp for riva
**Collection**: TTS
# Changelog
- Add volume passthrough to fp for riva
**PR Type**:
- [x] New Feature
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4167/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4167/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4166 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4166/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4166/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4166/events | https://github.com/NVIDIA/NeMo/issues/4166 | 1,235,420,551 | I_kwDOC_bI7s5JowWH | 4,166 | how to get transcript from voice in nemo? | {
"login": "ali3assi",
"id": 16214827,
"node_id": "MDQ6VXNlcjE2MjE0ODI3",
"avatar_url": "https://avatars.githubusercontent.com/u/16214827?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ali3assi",
"html_url": "https://github.com/ali3assi",
"followers_url": "https://api.github.com/users/ali3assi/followers",
"following_url": "https://api.github.com/users/ali3assi/following{/other_user}",
"gists_url": "https://api.github.com/users/ali3assi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ali3assi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ali3assi/subscriptions",
"organizations_url": "https://api.github.com/users/ali3assi/orgs",
"repos_url": "https://api.github.com/users/ali3assi/repos",
"events_url": "https://api.github.com/users/ali3assi/events{/privacy}",
"received_events_url": "https://api.github.com/users/ali3assi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-13T15:55:21 | 2022-06-04T22:22:15 | 2022-06-04T22:22:15 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I have a voice file and I want to generate the text from the voices in the file.
Can you please refers me to the best tutorial about that? | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4166/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4166/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4165 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4165/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4165/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4165/events | https://github.com/NVIDIA/NeMo/issues/4165 | 1,235,112,897 | I_kwDOC_bI7s5JnlPB | 4,165 | TTS Tacotron training | {
"login": "sunasu91",
"id": 67078570,
"node_id": "MDQ6VXNlcjY3MDc4NTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67078570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sunasu91",
"html_url": "https://github.com/sunasu91",
"followers_url": "https://api.github.com/users/sunasu91/followers",
"following_url": "https://api.github.com/users/sunasu91/following{/other_user}",
"gists_url": "https://api.github.com/users/sunasu91/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sunasu91/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sunasu91/subscriptions",
"organizations_url": "https://api.github.com/users/sunasu91/orgs",
"repos_url": "https://api.github.com/users/sunasu91/repos",
"events_url": "https://api.github.com/users/sunasu91/events{/privacy}",
"received_events_url": "https://api.github.com/users/sunasu91/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-13T11:21:20 | 2022-06-22T17:06:24 | 2022-06-22T17:06:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I followed the [tacotron notebook](https://colab.research.google.com/github/NVIDIA/NeMo/blob/r1.0.0rc1/tutorials/tts/2_TTS_Tacotron2_Training.ipynb#scrollTo=Upv_LxBIsC51) and tried to train the nemo model. I end up getting stuck with this error. Can you please help?
`TypeError: Error instantiating 'nemo.collections.asr.data.audio_to_text.AudioToCharDataset' : __init__() got an unexpected keyword argument 'load_audio'
` | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4165/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4165/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4164 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4164/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4164/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4164/events | https://github.com/NVIDIA/NeMo/pull/4164 | 1,234,788,716 | PR_kwDOC_bI7s43wxiI | 4,164 | update speaker docs | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-13T06:18:46 | 2022-05-13T23:26:59 | 2022-05-13T23:26:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4164",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4164",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4164.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4164.patch",
"merged_at": "2022-05-13T23:26:56"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Update speaker docs related to recent script name change from scp_to_manifest.py to filelist_to_manifest.py
# Changelog
- Update docs
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4164/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4164/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4163 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4163/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4163/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4163/events | https://github.com/NVIDIA/NeMo/pull/4163 | 1,234,529,641 | PR_kwDOC_bI7s43v7dZ | 4,163 | rename folder VAD -> vad | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T22:11:24 | 2022-05-16T22:03:30 | 2022-05-16T22:03:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4163",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4163",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4163.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4163.patch",
"merged_at": "2022-05-16T22:03:15"
} | Signed-off-by: fayejf <[email protected]>
# What does this PR do ?
rename VAD folder in examples/asr/conf/ to vad and update files accordingly.
**Collection**:ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4163/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4163/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4162 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4162/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4162/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4162/events | https://github.com/NVIDIA/NeMo/pull/4162 | 1,234,475,978 | PR_kwDOC_bI7s43vwDz | 4,162 | Thutmose tagger bug fixes | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T20:59:07 | 2022-05-12T23:43:59 | 2022-05-12T23:43:56 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4162",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4162",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4162.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4162.patch",
"merged_at": "2022-05-12T23:43:56"
} | # What does this PR do ?
Bug fixes. Update tutorial. Add pretrained model to list_available_models
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4162/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4162/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4161 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4161/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4161/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4161/events | https://github.com/NVIDIA/NeMo/pull/4161 | 1,234,460,329 | PR_kwDOC_bI7s43vstD | 4,161 | Add 44KHz yaml file for Fastpitch training | {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T20:40:21 | 2022-05-13T19:48:39 | 2022-05-13T19:48:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4161",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4161",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4161.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4161.patch",
"merged_at": "2022-05-13T19:48:25"
} | Signed-off-by: Subhankar Ghosh <[email protected]>
# What does this PR do ?
Add 44KHz yaml file for Fastpitch training
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4161/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4161/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4160 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4160/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4160/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4160/events | https://github.com/NVIDIA/NeMo/issues/4160 | 1,234,211,805 | I_kwDOC_bI7s5JkJPd | 4,160 | Dialogue state tracking | {
"login": "MMatlacz",
"id": 7591689,
"node_id": "MDQ6VXNlcjc1OTE2ODk=",
"avatar_url": "https://avatars.githubusercontent.com/u/7591689?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MMatlacz",
"html_url": "https://github.com/MMatlacz",
"followers_url": "https://api.github.com/users/MMatlacz/followers",
"following_url": "https://api.github.com/users/MMatlacz/following{/other_user}",
"gists_url": "https://api.github.com/users/MMatlacz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MMatlacz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MMatlacz/subscriptions",
"organizations_url": "https://api.github.com/users/MMatlacz/orgs",
"repos_url": "https://api.github.com/users/MMatlacz/repos",
"events_url": "https://api.github.com/users/MMatlacz/events{/privacy}",
"received_events_url": "https://api.github.com/users/MMatlacz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-12T16:13:49 | 2022-07-23T19:19:03 | 2022-07-23T19:19:02 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | How do I run inference on SGDQA?
I see code for running training and evaluation on datasets, but how do I use this model interactively?
Is there any code for preprocessing utterance and schema and tracking state without providing information which should not be visible to model? | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4160/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4160/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4159 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4159/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4159/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4159/events | https://github.com/NVIDIA/NeMo/pull/4159 | 1,233,835,599 | PR_kwDOC_bI7s43tnEr | 4,159 | transcribe: scan directories recursively | {
"login": "virajkarandikar",
"id": 16838694,
"node_id": "MDQ6VXNlcjE2ODM4Njk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16838694?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/virajkarandikar",
"html_url": "https://github.com/virajkarandikar",
"followers_url": "https://api.github.com/users/virajkarandikar/followers",
"following_url": "https://api.github.com/users/virajkarandikar/following{/other_user}",
"gists_url": "https://api.github.com/users/virajkarandikar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/virajkarandikar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/virajkarandikar/subscriptions",
"organizations_url": "https://api.github.com/users/virajkarandikar/orgs",
"repos_url": "https://api.github.com/users/virajkarandikar/repos",
"events_url": "https://api.github.com/users/virajkarandikar/events{/privacy}",
"received_events_url": "https://api.github.com/users/virajkarandikar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T11:21:19 | 2022-05-17T07:04:09 | 2022-05-12T20:17:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4159",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4159",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4159.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4159.patch",
"merged_at": "2022-05-12T20:17:05"
} | # What does this PR do ?
Update transcribe script to scan directories recursively.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4159/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4159/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4158 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4158/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4158/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4158/events | https://github.com/NVIDIA/NeMo/pull/4158 | 1,233,535,998 | PR_kwDOC_bI7s43so8y | 4,158 | notebooks' link, typo and import fix | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T07:01:34 | 2022-05-16T00:24:57 | 2022-05-12T17:32:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4158",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4158",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4158.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4158.patch",
"merged_at": "2022-05-12T17:32:28"
} | # What does this PR do ?
bug fix for notebook
**Collection**:ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4158/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4158/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4157 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4157/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4157/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4157/events | https://github.com/NVIDIA/NeMo/issues/4157 | 1,233,512,188 | I_kwDOC_bI7s5Jheb8 | 4,157 | Speaker Diarization | {
"login": "kaustavb79",
"id": 29993931,
"node_id": "MDQ6VXNlcjI5OTkzOTMx",
"avatar_url": "https://avatars.githubusercontent.com/u/29993931?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kaustavb79",
"html_url": "https://github.com/kaustavb79",
"followers_url": "https://api.github.com/users/kaustavb79/followers",
"following_url": "https://api.github.com/users/kaustavb79/following{/other_user}",
"gists_url": "https://api.github.com/users/kaustavb79/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kaustavb79/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kaustavb79/subscriptions",
"organizations_url": "https://api.github.com/users/kaustavb79/orgs",
"repos_url": "https://api.github.com/users/kaustavb79/repos",
"events_url": "https://api.github.com/users/kaustavb79/events{/privacy}",
"received_events_url": "https://api.github.com/users/kaustavb79/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-05-12T06:33:55 | 2022-06-16T21:02:57 | 2022-05-20T18:56:00 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am trying to implement speaker diarization using __vad_marblenet__ and __titanet_large__ models.
# Issue
When I am trying to run on server/local machine .... the process either gets stuck or terminates due to CPU memory allocation error during clustering.
- __memory allocation issue__

- __execution halted__


## Environment:
- OS : Ubuntu 18.04.6 LTS (GNU/Linux 4.18.0-25-generic x86_64)
- Memory:

- Python: 3.7.13
- Installation : from source i.e. __(git clone ... & cd NeMo & ./reinstall.sh)__
# Reference
When executing on collab, it's working properly. It's giving proper diarization results.
- Link to notebook: https://colab.research.google.com/drive/1UgzoPHV1aByDDhygCUAiEaEIRGldrocK?usp=sharing
- Test audio file: https://drive.google.com/file/d/1ChLsVHTgH4SUgvqLP7ymtrbao-L0KKsj/view?usp=sharing
- Manifest file: https://drive.google.com/file/d/1SAeLmMIHGk-rc7ydHfYLywCkbMx7SbH6/view?usp=sharing
- Diarization yaml config file: https://drive.google.com/file/d/1lvYYg5Pd8hUceS2a-raO76huu-p0p39V/view?usp=sharing
- Test audio file result: https://drive.google.com/drive/folders/1FCH_UOFUFJZUQdxMHQfzXQII-bg6auaO?usp=sharing
## Environment:
- Installation on collab: from source i.e. __(git clone ... & cd NeMo & ./reinstall.sh)__
- Python: 3.7.13 | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4157/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4157/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4156 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4156/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4156/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4156/events | https://github.com/NVIDIA/NeMo/issues/4156 | 1,233,487,589 | I_kwDOC_bI7s5JhYbl | 4,156 | JSONDecodeError: Extra data: line 1 column 126 (char 125) | {
"login": "one1ine",
"id": 40920344,
"node_id": "MDQ6VXNlcjQwOTIwMzQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/40920344?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/one1ine",
"html_url": "https://github.com/one1ine",
"followers_url": "https://api.github.com/users/one1ine/followers",
"following_url": "https://api.github.com/users/one1ine/following{/other_user}",
"gists_url": "https://api.github.com/users/one1ine/gists{/gist_id}",
"starred_url": "https://api.github.com/users/one1ine/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/one1ine/subscriptions",
"organizations_url": "https://api.github.com/users/one1ine/orgs",
"repos_url": "https://api.github.com/users/one1ine/repos",
"events_url": "https://api.github.com/users/one1ine/events{/privacy}",
"received_events_url": "https://api.github.com/users/one1ine/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T06:04:52 | 2023-02-19T05:30:10 | 2022-05-12T08:53:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello, I am trying to train a custom model using the provided code. I've compiled my custom Cyrillic manifests according to the instruction with each line being:
{"audio_filepath": "/path/to/wav/file", "duration": float, "text": "transcript_in_cyrillic"}
However, when I setup the data i get the following error. I've double checked for any invisible characters and what not but my custom manifest is exactly like the one in the example.
---------------------------START------------------------------------------------
---------------------------------------------------------------------------
JSONDecodeError Traceback (most recent call last)
/nfs/home/create_manifest.ipynb Cell 14' in <cell line: 13>()
2 trainer = pl.Trainer(devices=1, accelerator='gpu', max_epochs=50)
3 #trainer = pl.Trainer(devices=1, accelerator='gpu', max_epochs=2)
4
5 #import copy
(...)
11
12 # Point to the data we'll use for fine-tuning as the training set
---> 13 quartznet_transfer_mon.setup_training_data(train_data_config=params['model']['train_ds'])
15 # Point to the new validation data for fine-tuning
16 quartznet_transfer_mon.setup_validation_data(val_data_config=params['model']['validation_ds'])
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/models/ctc_models.py:464, in EncDecCTCModel.setup_training_data(self, train_data_config)
461 # preserve config
462 self._update_dataset_config(dataset_name='train', config=train_data_config)
--> 464 self._train_dl = self._setup_dataloader_from_config(config=train_data_config)
466 # Need to set this because if using an IterableDataset, the length of the dataloader is the total number
467 # of samples rather than the number of batches, and this messes up the tqdm progress bar.
468 # So we set the number of steps manually (to the correct number) to fix this.
469 if 'is_tarred' in train_data_config and train_data_config['is_tarred']:
470 # We also need to check if limit_train_batches is already set.
471 # If it's an int, we assume that the user has set it to something sane, i.e. <= # training batches,
472 # and don't change it. Otherwise, adjust batches accordingly if it's a float (including 1.0).
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/models/ctc_models.py:426, in EncDecCTCModel._setup_dataloader_from_config(self, config)
423 logging.warning(f"Could not load dataset as `manifest_filepath` was None. Provided config : {config}")
424 return None
--> 426 dataset = audio_to_text_dataset.get_char_dataset(config=config, augmentor=augmentor)
428 if hasattr(dataset, 'collate_fn'):
429 collate_fn = dataset.collate_fn
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_text_dataset.py:86, in get_char_dataset(config, augmentor)
83 if 'labels' not in config:
84 logging.warning(f"dataset does not have explicitly defined labels")
---> 86 dataset = audio_to_text.AudioToCharDataset(
87 manifest_filepath=config['manifest_filepath'],
88 labels=config.get('labels', None),
89 sample_rate=config['sample_rate'],
90 int_values=config.get('int_values', False),
91 augmentor=augmentor,
92 max_duration=config.get('max_duration', None),
93 min_duration=config.get('min_duration', None),
94 max_utts=config.get('max_utts', 0),
95 blank_index=config.get('blank_index', -1),
96 unk_index=config.get('unk_index', -1),
97 normalize=config.get('normalize_transcripts', False),
98 trim=config.get('trim_silence', False),
99 parser=config.get('parser', 'en'),
100 return_sample_id=config.get('return_sample_id', False),
101 )
102 return dataset
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_text.py:388, in AudioToCharDataset.__init__(self, manifest_filepath, labels, sample_rate, int_values, augmentor, max_duration, min_duration, max_utts, blank_index, unk_index, normalize, trim, bos_id, eos_id, pad_id, parser, return_sample_id)
382 self.labels = labels
384 parser = parsers.make_parser(
385 labels=labels, name=parser, unk_id=unk_index, blank_id=blank_index, do_normalize=normalize
386 )
--> 388 super().__init__(
389 manifest_filepath=manifest_filepath,
390 parser=parser,
391 sample_rate=sample_rate,
392 int_values=int_values,
393 augmentor=augmentor,
394 max_duration=max_duration,
395 min_duration=min_duration,
396 max_utts=max_utts,
397 trim=trim,
398 bos_id=bos_id,
399 eos_id=eos_id,
400 pad_id=pad_id,
401 return_sample_id=return_sample_id,
402 )
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_text.py:274, in _AudioTextDataset.__init__(self, manifest_filepath, parser, sample_rate, int_values, augmentor, max_duration, min_duration, max_utts, trim, bos_id, eos_id, pad_id, return_sample_id)
271 if type(manifest_filepath) == str:
272 manifest_filepath = manifest_filepath.split(",")
--> 274 self.manifest_processor = ASRManifestProcessor(
275 manifest_filepath=manifest_filepath,
276 parser=parser,
277 max_duration=max_duration,
278 min_duration=min_duration,
279 max_utts=max_utts,
280 bos_id=bos_id,
281 eos_id=eos_id,
282 pad_id=pad_id,
283 )
284 self.featurizer = WaveformFeaturizer(sample_rate=sample_rate, int_values=int_values, augmentor=augmentor)
285 self.trim = trim
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/asr/data/audio_to_text.py:135, in ASRManifestProcessor.__init__(self, manifest_filepath, parser, max_duration, min_duration, max_utts, bos_id, eos_id, pad_id, index_by_file_id)
121 def __init__(
122 self,
123 manifest_filepath: str,
(...)
131 index_by_file_id: bool = False,
132 ):
133 self.parser = parser
--> 135 self.collection = collections.ASRAudioText(
136 manifests_files=manifest_filepath,
137 parser=parser,
138 min_duration=min_duration,
139 max_duration=max_duration,
140 max_number=max_utts,
141 index_by_file_id=index_by_file_id,
142 )
144 self.eos_id = eos_id
145 self.bos_id = bos_id
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/common/parts/preprocessing/collections.py:206, in ASRAudioText.__init__(self, manifests_files, *args, **kwargs)
196 """Parse lists of audio files, durations and transcripts texts.
197
198 Args:
(...)
202 **kwargs: Kwargs to pass to `AudioText` constructor.
203 """
205 ids, audio_files, durations, texts, offsets, speakers, orig_srs, langs = [], [], [], [], [], [], [], []
--> 206 for item in manifest.item_iter(manifests_files):
207 ids.append(item['id'])
208 audio_files.append(item['audio_file'])
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/common/parts/preprocessing/manifest.py:72, in item_iter(manifests_files, parse_func)
70 for line in f:
71 k += 1
---> 72 item = parse_func(line, manifest_file)
73 item['id'] = k
75 yield item
File ~/anaconda3/envs/nemo/lib/python3.8/site-packages/nemo/collections/common/parts/preprocessing/manifest.py:79, in __parse_item(line, manifest_file)
78 def __parse_item(line: str, manifest_file: str) -> Dict[str, Any]:
---> 79 item = json.loads(line)
81 # Audio file
82 if 'audio_filename' in item:
File ~/anaconda3/envs/nemo/lib/python3.8/json/__init__.py:357, in loads(s, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
352 del kw['encoding']
354 if (cls is None and object_hook is None and
355 parse_int is None and parse_float is None and
356 parse_constant is None and object_pairs_hook is None and not kw):
--> 357 return _default_decoder.decode(s)
358 if cls is None:
359 cls = JSONDecoder
File ~/anaconda3/envs/nemo/lib/python3.8/json/decoder.py:340, in JSONDecoder.decode(self, s, _w)
338 end = _w(s, end).end()
339 if end != len(s):
--> 340 raise JSONDecodeError("Extra data", s, end)
341 return obj
JSONDecodeError: Extra data: line 1 column 126 (char 125)
---------------------------------------------------END------------------------------------------------------- | {
"login": "one1ine",
"id": 40920344,
"node_id": "MDQ6VXNlcjQwOTIwMzQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/40920344?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/one1ine",
"html_url": "https://github.com/one1ine",
"followers_url": "https://api.github.com/users/one1ine/followers",
"following_url": "https://api.github.com/users/one1ine/following{/other_user}",
"gists_url": "https://api.github.com/users/one1ine/gists{/gist_id}",
"starred_url": "https://api.github.com/users/one1ine/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/one1ine/subscriptions",
"organizations_url": "https://api.github.com/users/one1ine/orgs",
"repos_url": "https://api.github.com/users/one1ine/repos",
"events_url": "https://api.github.com/users/one1ine/events{/privacy}",
"received_events_url": "https://api.github.com/users/one1ine/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4156/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4156/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/4155 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4155/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4155/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4155/events | https://github.com/NVIDIA/NeMo/pull/4155 | 1,233,433,365 | PR_kwDOC_bI7s43sTtQ | 4,155 | Freesound fixes | {
"login": "virajkarandikar",
"id": 16838694,
"node_id": "MDQ6VXNlcjE2ODM4Njk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16838694?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/virajkarandikar",
"html_url": "https://github.com/virajkarandikar",
"followers_url": "https://api.github.com/users/virajkarandikar/followers",
"following_url": "https://api.github.com/users/virajkarandikar/following{/other_user}",
"gists_url": "https://api.github.com/users/virajkarandikar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/virajkarandikar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/virajkarandikar/subscriptions",
"organizations_url": "https://api.github.com/users/virajkarandikar/orgs",
"repos_url": "https://api.github.com/users/virajkarandikar/repos",
"events_url": "https://api.github.com/users/virajkarandikar/events{/privacy}",
"received_events_url": "https://api.github.com/users/virajkarandikar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T04:37:07 | 2022-05-20T02:33:08 | 2022-05-20T02:31:57 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4155",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4155",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4155.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4155.patch",
"merged_at": "2022-05-20T02:31:57"
} | # What does this PR do ?
Fixes freesound-python git path and updates filename cleanup
**Collection**: [Note which collection this PR will affect]
# Changelog
- Update requirements.txt to use https instead of git to fix "The unauthenticated git protocol on port 9418 is no longer supported."
- Remove additional characters from filename
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4155/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4155/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4154 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4154/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4154/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4154/events | https://github.com/NVIDIA/NeMo/pull/4154 | 1,233,311,650 | PR_kwDOC_bI7s43r6gO | 4,154 | Fix Docs CSS: align docs left and increase width for large screens | {
"login": "nickolyamba",
"id": 8766167,
"node_id": "MDQ6VXNlcjg3NjYxNjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/8766167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nickolyamba",
"html_url": "https://github.com/nickolyamba",
"followers_url": "https://api.github.com/users/nickolyamba/followers",
"following_url": "https://api.github.com/users/nickolyamba/following{/other_user}",
"gists_url": "https://api.github.com/users/nickolyamba/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nickolyamba/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nickolyamba/subscriptions",
"organizations_url": "https://api.github.com/users/nickolyamba/orgs",
"repos_url": "https://api.github.com/users/nickolyamba/repos",
"events_url": "https://api.github.com/users/nickolyamba/events{/privacy}",
"received_events_url": "https://api.github.com/users/nickolyamba/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-12T00:47:08 | 2022-05-16T16:27:57 | 2022-05-16T16:27:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4154",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4154",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4154.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4154.patch",
"merged_at": "2022-05-16T16:27:57"
} | # What does this PR do ?
Align docs left and increase width for screens > 1200px
**Collection**: All
# Changelog
- Align docs left and increase width for screens > 1200px
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4154/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4154/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4153 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4153/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4153/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4153/events | https://github.com/NVIDIA/NeMo/pull/4153 | 1,233,086,683 | PR_kwDOC_bI7s43rKkR | 4,153 | fix wrong word error | {
"login": "sam-writer",
"id": 47401552,
"node_id": "MDQ6VXNlcjQ3NDAxNTUy",
"avatar_url": "https://avatars.githubusercontent.com/u/47401552?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam-writer",
"html_url": "https://github.com/sam-writer",
"followers_url": "https://api.github.com/users/sam-writer/followers",
"following_url": "https://api.github.com/users/sam-writer/following{/other_user}",
"gists_url": "https://api.github.com/users/sam-writer/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam-writer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam-writer/subscriptions",
"organizations_url": "https://api.github.com/users/sam-writer/orgs",
"repos_url": "https://api.github.com/users/sam-writer/repos",
"events_url": "https://api.github.com/users/sam-writer/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam-writer/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | null | 2022-05-11T19:23:18 | 2022-10-07T02:13:46 | 2022-10-07T02:13:46 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4153",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4153",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4153.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4153.patch",
"merged_at": null
} | # What does this PR do ?
The docs have an error where the word "cartographic" is used in place of "catastrophic"
**Collection**: ?
# Changelog
- `docs/source/nlp/prompt_learning.rst` fix word error
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4153/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4153/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4152 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4152/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4152/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4152/events | https://github.com/NVIDIA/NeMo/pull/4152 | 1,233,055,284 | PR_kwDOC_bI7s43rD6Z | 4,152 | Fix doc | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-11T18:51:45 | 2022-05-16T20:22:14 | 2022-05-16T20:22:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4152",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4152",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4152.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4152.patch",
"merged_at": "2022-05-16T20:22:12"
} | null | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4152/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4152/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4151 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4151/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4151/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4151/events | https://github.com/NVIDIA/NeMo/pull/4151 | 1,232,965,274 | PR_kwDOC_bI7s43qwzA | 4,151 | WaveGlow input type fixes | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-11T17:22:37 | 2022-05-11T20:42:15 | 2022-05-11T20:42:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4151",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4151",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4151.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4151.patch",
"merged_at": "2022-05-11T20:42:13"
} | Signed-off-by: Jocelyn Huang <[email protected]>
Fix WaveGlow input types to match what gets passed in during training and inference.
**Collection**: TTS
# Changelog
- Made `z` optional, as it's not passed in during training and inference, and only during export
- Removed extraneous inputs to the WaveGlow module in `convert_spectrogram_to_audio()`
- Added `sigma` to optional inputs for inference, since it is a default argument for the base `convert_spectrogram_to_audio()` function
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4151/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4151/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4150 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4150/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4150/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4150/events | https://github.com/NVIDIA/NeMo/pull/4150 | 1,232,909,593 | PR_kwDOC_bI7s43qlay | 4,150 | Megatron Perceiver with tensor and pipeline parallel | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-11T16:30:36 | 2022-06-06T20:52:42 | 2022-06-06T20:52:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4150",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4150",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4150.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4150.patch",
"merged_at": null
} | Signed-off-by: Micha Livne <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4150/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4150/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4149 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4149/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4149/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4149/events | https://github.com/NVIDIA/NeMo/pull/4149 | 1,231,801,030 | PR_kwDOC_bI7s43nAyT | 4,149 | Add ASR with Adapters Tutorial | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-10T23:18:06 | 2022-05-11T17:31:26 | 2022-05-11T16:09:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4149",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4149",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4149.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4149.patch",
"merged_at": "2022-05-11T16:09:17"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Adds a tutorial for ASR with adapters and sub-section for tutorials involving adapters.
**Collection**: [ASR]
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4149/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4149/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4148 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4148/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4148/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4148/events | https://github.com/NVIDIA/NeMo/pull/4148 | 1,231,720,414 | PR_kwDOC_bI7s43mvRD | 4,148 | [TTS] Fix 44KHz Fastpitch config | {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-05-10T21:25:33 | 2022-05-16T22:40:37 | 2022-05-12T18:36:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/4148",
"html_url": "https://github.com/NVIDIA/NeMo/pull/4148",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/4148.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/4148.patch",
"merged_at": null
} | # What does this PR do ?
The config to train Fastpitch at 44KHz was not updated according to the latest code changes in TTS. This PR adds the updated config to train Fastpitch at 44KHz.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4148/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4148/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/4147 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/4147/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/4147/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/4147/events | https://github.com/NVIDIA/NeMo/issues/4147 | 1,231,458,229 | I_kwDOC_bI7s5JZo-1 | 4,147 | Error when continuing training from checkpoint | {
"login": "gedefet",
"id": 43994544,
"node_id": "MDQ6VXNlcjQzOTk0NTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/43994544?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gedefet",
"html_url": "https://github.com/gedefet",
"followers_url": "https://api.github.com/users/gedefet/followers",
"following_url": "https://api.github.com/users/gedefet/following{/other_user}",
"gists_url": "https://api.github.com/users/gedefet/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gedefet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gedefet/subscriptions",
"organizations_url": "https://api.github.com/users/gedefet/orgs",
"repos_url": "https://api.github.com/users/gedefet/repos",
"events_url": "https://api.github.com/users/gedefet/events{/privacy}",
"received_events_url": "https://api.github.com/users/gedefet/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-05-10T17:14:16 | 2022-05-12T13:44:59 | 2022-05-10T18:14:35 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello. I'm having trouble when trying to resume training when doing it with FastPitch. I'm using FastPitch_Finetuning.ipynb in the last version (r1.8.2), with a custom dataset. The generated checkpoint is ok and I can do inference with it, but I cannot use it from resuming training. Here is the error:
```
Restored all states from the checkpoint file at /content/drive/MyDrive/TTS/CHECKPOINTS/checkpoints_dataset_mix_92-1_7hours_2_plus15_16/FastPitch/checkpoints/FastPitch--v_loss=1.8955-epoch=274-last.ckpt
Epoch 274: 0% 0/351 [00:00<00:00, -4587799.47it/s][NeMo W 2022-05-09 13:39:54 nemo_logging:349] /usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py:136: UserWarning: You're resuming from a checkpoint that ended before the epoch ended. This can cause unreliable results if further training is done. Consider using an end-of-epoch checkpoint or enabling fault-tolerant training: https://pytorch-lightning.readthedocs.io/en/stable/advanced/fault_tolerant_training.html
"You're resuming from a checkpoint that ended before the epoch ended. This can cause unreliable"
Epoch 275: 0% 0/342 [00:00<00:00, -72498.33it/s, loss=nan, v_num=3] [NeMo W 2022-05-09 13:40:53 nemo_logging:349] /usr/local/lib/python3.7/dist-packages/numba/np/ufunc/parallel.py:363: NumbaWarning: The TBB threading layer requires TBB version 2019.5 or later i.e., TBB_INTERFACE_VERSION >= 11005. Found TBB_INTERFACE_VERSION = 9107. The TBB threading layer is disabled.
warnings.warn(problem)
Epoch 275: 12% 40/342 [02:20<-1:58:31, -3.37it/s, loss=2.62, v_num=3]Error executing job with overrides: ['train_dataset=./train.json', 'validation_datasets=./val.json', 'sup_data_path=./fastpitch_sup_data', 'phoneme_dict_path=tts_dataset_files/cmudict-0.7b_nv22.01', 'heteronyms_path=tts_dataset_files/heteronyms-030921', 'whitelist_path=tts_dataset_files/lj_speech.tsv', 'exp_manager.exp_dir=/content/drive/MyDrive/TTS/CHECKPOINTS/checkpoints_dataset_mix_92-1_7hours_2_plus15_16', '+init_from_nemo_model=./tts_en_fastpitch_align.nemo', '+trainer.max_steps=430961', '~trainer.max_epochs', 'trainer.check_val_every_n_epoch=25', 'model.train_ds.dataloader_params.batch_size=24', 'model.validation_ds.dataloader_params.batch_size=24', 'model.n_speakers=2', 'model.pitch_mean=121.9', 'model.pitch_std=20', 'model.pitch_fmin=65', 'model.pitch_fmax=512', 'model.optim.lr=2e-4', '~model.optim.sched', 'model.optim.name=adam', 'trainer.devices=1', 'trainer.strategy=null', '+model.text_tokenizer.add_blank_at=true']
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 721, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 809, in _fit_impl
results = self._run(model, ckpt_path=self.ckpt_path)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 1234, in _run
results = self._run_stage()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 1321, in _run_stage
return self._run_train()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 1351, in _run_train
self.fit_loop.run()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/fit_loop.py", line 268, in advance
self._outputs = self.epoch_loop.run(self._data_fetcher)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 208, in advance
batch_output = self.batch_loop.run(batch, batch_idx)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/batch/training_batch_loop.py", line 88, in advance
outputs = self.optimizer_loop.run(split_batch, optimizers, batch_idx)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 207, in advance
self.optimizer_idx,
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 256, in _run_optimization
self._optimizer_step(optimizer, opt_idx, batch_idx, closure)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 378, in _optimizer_step
using_lbfgs=is_lbfgs,
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 1593, in _call_lightning_module_hook
output = fn(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/core/lightning.py", line 1644, in optimizer_step
optimizer.step(closure=optimizer_closure)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/core/optimizer.py", line 168, in step
step_output = self._strategy.optimizer_step(self._optimizer, self._optimizer_idx, closure, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/strategies/strategy.py", line 193, in optimizer_step
return self.precision_plugin.optimizer_step(model, optimizer, opt_idx, closure, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/plugins/precision/native_amp.py", line 85, in optimizer_step
closure_result = closure()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 148, in __call__
self._result = self.closure(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 143, in closure
self._backward_fn(step_output.closure_loss)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 311, in backward_fn
self.trainer._call_strategy_hook("backward", loss, optimizer, opt_idx)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 1763, in _call_strategy_hook
output = fn(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/strategies/strategy.py", line 168, in backward
self.precision_plugin.backward(self.lightning_module, closure_loss, *args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/plugins/precision/precision_plugin.py", line 80, in backward
model.backward(closure_loss, optimizer, *args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/core/lightning.py", line 1389, in backward
loss.backward(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/torch/_tensor.py", line 363, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
File "/usr/local/lib/python3.7/dist-packages/torch/autograd/__init__.py", line 175, in backward
allow_unreachable=True, accumulate_grad=True) # Calls into the C++ engine to run the backward pass
RuntimeError: cuDNN error: CUDNN_STATUS_INTERNAL_ERROR
You can try to repro this exception using the following code snippet. If that doesn't trigger the error, please include your original repro script when reporting this issue.
import torch
torch.backends.cuda.matmul.allow_tf32 = True
torch.backends.cudnn.benchmark = True
torch.backends.cudnn.deterministic = False
torch.backends.cudnn.allow_tf32 = True
data = torch.randn([24, 1, 1, 119], dtype=torch.half, device='cuda', requires_grad=True)
net = torch.nn.Conv2d(1, 384, kernel_size=[1, 3], padding=[0, 1], stride=[1, 1], dilation=[1, 1], groups=1)
net = net.cuda().half()
out = net(data)
out.backward(torch.randn_like(out))
torch.cuda.synchronize()
ConvolutionParams
data_type = CUDNN_DATA_HALF
padding = [0, 1, 0]
stride = [1, 1, 0]
dilation = [1, 1, 0]
groups = 1
deterministic = false
allow_tf32 = true
input: TensorDescriptor 0xebe7090
type = CUDNN_DATA_HALF
nbDims = 4
dimA = 24, 1, 1, 119,
strideA = 119, 119, 119, 1,
output: TensorDescriptor 0xfeaabcd0
type = CUDNN_DATA_HALF
nbDims = 4
dimA = 24, 384, 1, 119,
strideA = 45696, 119, 119, 1,
weight: FilterDescriptor 0x1b618ba0
type = CUDNN_DATA_HALF
tensor_format = CUDNN_TENSOR_NCHW
nbDims = 4
dimA = 384, 1, 1, 3,
Pointer addresses:
input: 0x7f6abdaa4200
output: 0x7f6b2b04a000
weight: 0x7f6a1adff600
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "fastpitch_finetune.py", line 37, in main
trainer.fit(model)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 769, in fit
self._fit_impl, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 736, in _call_and_handle_interrupt
self._teardown()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/trainer.py", line 1298, in _teardown
self.strategy.teardown()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/strategies/single_device.py", line 93, in teardown
super().teardown()
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/strategies/strategy.py", line 444, in teardown
optimizers_to_device(self.optimizers, torch.device("cpu"))
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/optimizer.py", line 27, in optimizers_to_device
optimizer_to_device(opt, device)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/optimizer.py", line 33, in optimizer_to_device
optimizer.state[p] = apply_to_collection(v, torch.Tensor, move_data_to_device, device)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py", line 108, in apply_to_collection
v, dtype, function, *args, wrong_dtype=wrong_dtype, include_none=include_none, **kwargs
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py", line 99, in apply_to_collection
return function(data, *args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py", line 354, in move_data_to_device
return apply_to_collection(batch, dtype=dtype, function=batch_to)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py", line 99, in apply_to_collection
return function(data, *args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py", line 347, in batch_to
data_output = data.to(device, **kwargs)
RuntimeError: CUDA error: an illegal memory access was encountered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
```
And this is the command:
```
!(python fastpitch_finetune.py --config-name=fastpitch_align_v1.05.yaml \
train_dataset=./train.json \
validation_datasets=./val.json \
sup_data_path=./fastpitch_sup_data \
phoneme_dict_path=tts_dataset_files/cmudict-0.7b_nv22.01 \
heteronyms_path=tts_dataset_files/heteronyms-030921 \
whitelist_path=tts_dataset_files/lj_speech.tsv \
exp_manager.exp_dir=$OUTPUT_CHEKPOINTS \
+init_from_nemo_model=./tts_en_fastpitch_align.nemo \
+trainer.max_steps=$max_steps ~trainer.max_epochs \
trainer.check_val_every_n_epoch=25 \
model.train_ds.dataloader_params.batch_size=24 model.validation_ds.dataloader_params.batch_size=24 \
model.n_speakers=2 model.pitch_mean=121.9 model.pitch_std=20 \
model.pitch_fmin=65 model.pitch_fmax=512 model.optim.lr=2e-4 \
~model.optim.sched model.optim.name=adam trainer.devices=1 trainer.strategy=null \
+model.text_tokenizer.add_blank_at=true \
)
```
It is worth noting that this didn't happen with version 1.6.x. Also, it seems that now training consumes more memory than before, as I had to decrease batch_size in order to keep training.
Thanks, | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/4147/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/4147/timeline | null | completed | false |
Subsets and Splits