url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/3697 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3697/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3697/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3697/events | https://github.com/NVIDIA/NeMo/issues/3697 | 1,141,015,319 | I_kwDOC_bI7s5EAoMX | 3,697 | Enquiry about the ASR "QuartzNet15x5Base-En" Model | {
"login": "claratang98",
"id": 90296566,
"node_id": "MDQ6VXNlcjkwMjk2NTY2",
"avatar_url": "https://avatars.githubusercontent.com/u/90296566?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/claratang98",
"html_url": "https://github.com/claratang98",
"followers_url": "https://api.github.com/users/claratang98/followers",
"following_url": "https://api.github.com/users/claratang98/following{/other_user}",
"gists_url": "https://api.github.com/users/claratang98/gists{/gist_id}",
"starred_url": "https://api.github.com/users/claratang98/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/claratang98/subscriptions",
"organizations_url": "https://api.github.com/users/claratang98/orgs",
"repos_url": "https://api.github.com/users/claratang98/repos",
"events_url": "https://api.github.com/users/claratang98/events{/privacy}",
"received_events_url": "https://api.github.com/users/claratang98/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-17T08:24:15 | 2022-02-17T10:05:28 | 2022-02-17T09:39:07 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi, just wondering if the QuartzNet15x5Base-En Model has been trained using the Singapore National Speech Corpus (NSC) and If so, which portions of the corpus was used to train the model.
Thanks. :-) | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3697/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3697/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3696 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3696/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3696/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3696/events | https://github.com/NVIDIA/NeMo/issues/3696 | 1,140,969,835 | I_kwDOC_bI7s5EAdFr | 3,696 | ModuleNotFoundError: No module named 'transformers.tokenization_bert' | {
"login": "eyujy",
"id": 79886108,
"node_id": "MDQ6VXNlcjc5ODg2MTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/79886108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/eyujy",
"html_url": "https://github.com/eyujy",
"followers_url": "https://api.github.com/users/eyujy/followers",
"following_url": "https://api.github.com/users/eyujy/following{/other_user}",
"gists_url": "https://api.github.com/users/eyujy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/eyujy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eyujy/subscriptions",
"organizations_url": "https://api.github.com/users/eyujy/orgs",
"repos_url": "https://api.github.com/users/eyujy/repos",
"events_url": "https://api.github.com/users/eyujy/events{/privacy}",
"received_events_url": "https://api.github.com/users/eyujy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-17T07:29:11 | 2022-02-17T19:53:28 | 2022-02-17T19:53:28 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello!
I am running 00_NeMo_Primer.
I was running this cell
```
import nemo.collections.asr as nemo_asr
import nemo.collections.tts as nemo_tts
import nemo.collections.nlp as nemo_nlp
```
And got the following error
```
[NeMo W 2022-02-17 15:16:17 experimental:27] Module <class 'nemo.collections.asr.losses.ctc.CTCLoss'> is experimental, not ready for production and is not fully supported. Use at your own risk.
[NeMo W 2022-02-17 15:16:18 experimental:27] Module <class 'nemo.collections.tts.losses.glow_tts_loss.GlowTTSLoss'> is experimental, not ready for production and is not fully supported. Use at your own risk.
[NeMo W 2022-02-17 15:16:18 experimental:27] Module <class 'nemo.collections.tts.modules.glow_tts.TextEncoder'> is experimental, not ready for production and is not fully supported. Use at your own risk.
[NeMo W 2022-02-17 15:16:18 experimental:27] Module <class 'nemo.collections.tts.modules.glow_tts.FlowSpecDecoder'> is experimental, not ready for production and is not fully supported. Use at your own risk.
---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
/var/folders/6p/q3vy70_j01x7j6tw4kzc_dy00000gp/T/ipykernel_5722/4141817862.py in <module>
1 import nemo.collections.asr as nemo_asr
2 import nemo.collections.tts as nemo_tts
----> 3 import nemo.collections.nlp as nemo_nlp
~/opt/anaconda3/lib/python3.9/site-packages/nemo/collections/nlp/__init__.py in <module>
13 # limitations under the License.
14
---> 15 from nemo.collections.nlp import data, models, modules
16 from nemo.package_info import __version__
17
~/opt/anaconda3/lib/python3.9/site-packages/nemo/collections/nlp/data/__init__.py in <module>
19 BertPretrainingPreprocessedDataloader,
20 )
---> 21 from nemo.collections.nlp.data.question_answering_squad.qa_dataset import SquadDataset
22 from nemo.collections.nlp.data.token_classification.token_classification_dataset import (
23 BertTokenClassificationDataset,
~/opt/anaconda3/lib/python3.9/site-packages/nemo/collections/nlp/data/question_answering_squad/qa_dataset.py in <module>
26
27 from nemo.collections.common.parts.utils import _compute_softmax
---> 28 from nemo.collections.nlp.data.question_answering_squad.qa_squad_processing import (
29 SquadProcessor,
30 apply_no_ans_threshold,
~/opt/anaconda3/lib/python3.9/site-packages/nemo/collections/nlp/data/question_answering_squad/qa_squad_processing.py in <module>
20
21 from tqdm import tqdm
---> 22 from transformers.tokenization_bert import BasicTokenizer
23
24 from nemo.collections.nlp.data.data_utils import DataProcessor, is_whitespace, normalize_answer
ModuleNotFoundError: No module named 'transformers.tokenization_bert'
```
The same error was faced by #1566
The suggested fix was to uninstall the latest transformer and revert to 3.5
```
!pip uninstall transformers
!pip install transformers==3.5
```
However, i met this issue when installing transformer 3.5
```
Collecting sentencepiece==0.1.91
Using cached sentencepiece-0.1.91.tar.gz (500 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [5 lines of output]
Package sentencepiece was not found in the pkg-config search path.
Perhaps you should add the directory containing `sentencepiece.pc'
to the PKG_CONFIG_PATH environment variable
No package 'sentencepiece' found
Failed to find sentencepiece pkgconfig
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
```
How do i proceed with the above, or is there another fix where i do not have to revert to transformer 3.5?
Thank you!
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3696/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3696/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3695 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3695/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3695/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3695/events | https://github.com/NVIDIA/NeMo/pull/3695 | 1,140,695,794 | PR_kwDOC_bI7s4y9RyX | 3,695 | Add slot filling into DST Generative model | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T23:33:49 | 2022-03-14T17:18:36 | 2022-03-14T17:18:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3695",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3695",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3695.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3695.patch",
"merged_at": "2022-03-14T17:18:35"
} | # What does this PR do ?
See Design Doc and Milestones for Overarching project at [Nvidia-only access Google Docs](https://docs.google.com/document/d/1IUerv_PLPLgzm5rLEgvHITz_RmK4cKdJKJCV7BXTJ9c/edit?usp=sharing)
Add slot filling prediction capabilities and metrics
**Collection**: NLP
# Changelog
- Integrated the capability of performing intent classification and slot filling jointly using a GPT-style model
- Include metrics for slot filling
- Edited dataset class to improve user customizability in using templates for generation
- Backported IntentSlotClassificationModel into DST module
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3695/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3695/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3694 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3694/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3694/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3694/events | https://github.com/NVIDIA/NeMo/pull/3694 | 1,140,614,996 | PR_kwDOC_bI7s4y9ArE | 3,694 | GEGLU activation for T5 | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T21:42:51 | 2022-02-18T02:30:17 | 2022-02-18T02:30:14 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3694",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3694",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3694.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3694.patch",
"merged_at": "2022-02-18T02:30:14"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Adds the GEGLU activation function for T5
**Collection**: NLP
# Changelog
- Updates ParallelMLP to instantiate a new linear layer if the activation is GEGLU.
- Applies the appropriate activation function based on the provided `activation` arg.
# Usage
* You can potentially add a usage example below
Set `model.activation=gelu` or `model.activation=geglu` in `megatron_t5_config.yaml`
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3694/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3694/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3693 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3693/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3693/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3693/events | https://github.com/NVIDIA/NeMo/pull/3693 | 1,140,596,711 | PR_kwDOC_bI7s4y882C | 3,693 | XNli benchmark | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T21:19:23 | 2022-02-18T21:21:45 | 2022-02-18T21:21:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3693",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3693",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3693.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3693.patch",
"merged_at": "2022-02-18T21:21:42"
} | # What does this PR do ?
Added an experiment to run fine-tuning on the MNLI dataset, use XNLI dev as validation dataset. The score on the XNLI test is reported.
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3693/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3693/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3692 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3692/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3692/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3692/events | https://github.com/NVIDIA/NeMo/pull/3692 | 1,140,478,970 | PR_kwDOC_bI7s4y8rfv | 3,692 | Megatron_LM checkpoint to NeMo checkpoint support | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T19:43:59 | 2022-02-18T03:38:40 | 2022-02-18T03:38:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3692",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3692",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3692.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3692.patch",
"merged_at": "2022-02-18T03:38:37"
} | # What does this PR do ?
Convert Megatron LM checkpoint to NeMo checkpoint. Copy over the weights, optimizer states, LR scheduler states.
Fix the issue of weight decay parameter group assignment.
Tested that the script converts the old Megatron GPT and BERT checkpoint to `.nemo` file fine.
Tested with 40B checkpoint file, the NeMo Megatron can resume from it and continue the training. Need to verify the training curve works fine.
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3692/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3692/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3691 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3691/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3691/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3691/events | https://github.com/NVIDIA/NeMo/pull/3691 | 1,140,448,291 | PR_kwDOC_bI7s4y8lBY | 3,691 | Jasper mask/export fix | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T19:11:19 | 2022-02-17T09:46:14 | 2022-02-17T09:46:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3691",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3691",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3691.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3691.patch",
"merged_at": "2022-02-17T09:46:14"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3691/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3691/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3690 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3690/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3690/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3690/events | https://github.com/NVIDIA/NeMo/pull/3690 | 1,140,425,553 | PR_kwDOC_bI7s4y8gTz | 3,690 | lower bound PTL to 1.5.10 and remove last ckpt patch fix | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T18:48:23 | 2022-02-16T22:29:18 | 2022-02-16T22:29:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3690",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3690",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3690.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3690.patch",
"merged_at": "2022-02-16T22:29:15"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
lower bound PTL to 1.5.10 and remove last ckpt patch fix in exp manager
**Collection**: core, exp_manager
# Changelog
- lower bound PTL to 1.5.10
- Remove `_save_last_checkpoint` function from exp_manager. PTL fixed issue in 1.5.10
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3690/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3690/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3688 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3688/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3688/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3688/events | https://github.com/NVIDIA/NeMo/issues/3688 | 1,140,376,150 | I_kwDOC_bI7s5D-MJW | 3,688 | TTS - Mixing datasets for FastPitch + HiFiGAN | {
"login": "gedefet",
"id": 43994544,
"node_id": "MDQ6VXNlcjQzOTk0NTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/43994544?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gedefet",
"html_url": "https://github.com/gedefet",
"followers_url": "https://api.github.com/users/gedefet/followers",
"following_url": "https://api.github.com/users/gedefet/following{/other_user}",
"gists_url": "https://api.github.com/users/gedefet/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gedefet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gedefet/subscriptions",
"organizations_url": "https://api.github.com/users/gedefet/orgs",
"repos_url": "https://api.github.com/users/gedefet/repos",
"events_url": "https://api.github.com/users/gedefet/events{/privacy}",
"received_events_url": "https://api.github.com/users/gedefet/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | true | null | [] | null | null | 2022-02-16T18:00:43 | 2022-04-06T00:06:42 | 2022-04-06T00:06:42 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | ### Discussed in https://github.com/NVIDIA/NeMo/discussions/3678
<div type='discussions-op-text'>
<sup>Originally posted by **gedefet** February 15, 2022</sup>
Hi All.
<br>
At the end of the FastPitch_Finetuning.ipynb tutorial:
https://github.com/NVIDIA/NeMo/blob/main/tutorials/tts/FastPitch_Finetuning.ipynb
<br>
it suggest two different ways to improve performance, one of which is:
<br>
_Mix new speaker data with old speaker data
We recommend to train fastpitch using both old speaker data (LJSpeech in this notebook) and the new speaker data. In this case, please modify the .json when finetuning fastpitch to include speaker information:_
<br>
but it isn't 100% clear how to do that.
<br>
I found another FastPitch_Finetuning.ipynb here:
https://colab.research.google.com/github/NVIDIA/NeMo/blob/stable/tutorials/tts/FastPitch_Finetuning.ipynb
<br>
Which is different than the other.
<br>
It seems that it has two functions defined to do the mixing, but it seems that this colab is abandoned. Nevertheless, I think that has very useful code, and that has tackled this part of mixing datasets.
<br>
Is this true? Or do I need something more that is not there?Why it is abandoned?
<br>
Thanks!</div> | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3688/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3688/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3687 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3687/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3687/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3687/events | https://github.com/NVIDIA/NeMo/issues/3687 | 1,140,363,230 | I_kwDOC_bI7s5D-I_e | 3,687 | fastpitch_finetuning.ipynb does not work from scratch | {
"login": "gedefet",
"id": 43994544,
"node_id": "MDQ6VXNlcjQzOTk0NTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/43994544?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gedefet",
"html_url": "https://github.com/gedefet",
"followers_url": "https://api.github.com/users/gedefet/followers",
"following_url": "https://api.github.com/users/gedefet/following{/other_user}",
"gists_url": "https://api.github.com/users/gedefet/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gedefet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gedefet/subscriptions",
"organizations_url": "https://api.github.com/users/gedefet/orgs",
"repos_url": "https://api.github.com/users/gedefet/repos",
"events_url": "https://api.github.com/users/gedefet/events{/privacy}",
"received_events_url": "https://api.github.com/users/gedefet/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-16T17:47:27 | 2022-02-28T06:11:42 | 2022-02-18T15:15:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi all.
The tutorial https://github.com/NVIDIA/NeMo/blob/main/tutorials/tts/FastPitch_Finetuning.ipynb does not work from scratch.
First, I have to replace NeMo for NVIDIA in the first setup cell for enable it to run:
```
!python -m pip install git+https://github.com/NeMo/NeMo.git@$BRANCH#egg=nemo_toolkit[all]
```
for
```
!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[all]
```
Then, I got the following error in the 11th cell:
First commands of the cell:
```
new_speaker_id = 6097
duration_mins = 5
mixing = False
original_speaker_id = "ljspeech"
_ ,last_ckpt = get_best_ckpt("./", new_speaker_id, duration_mins, mixing, original_speaker_id)
print(last_ckpt)
```
Error:
```
AttributeError Traceback (most recent call last)
[/usr/local/lib/python3.7/dist-packages/torch/serialization.py](https://localhost:8080/#) in _check_seekable(f)
307 try:
--> 308 f.seek(f.tell())
309 return True
AttributeError: 'NoneType' object has no attribute 'seek'
During handling of the above exception, another exception occurred:
AttributeError Traceback (most recent call last)
8 frames
[/usr/local/lib/python3.7/dist-packages/torch/serialization.py](https://localhost:8080/#) in raise_err_msg(patterns, e)
302 + " Please pre-load the data into a buffer like io.BytesIO and"
303 + " try to load from it instead.")
--> 304 raise type(e)(msg)
305 raise e
306
AttributeError: 'NoneType' object has no attribute 'seek'. You can only torch.load from a file that is seekable. Please pre-load the data into a buffer like io.BytesIO and try to load from it instead.
```
Best, | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3687/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3687/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3686 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3686/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3686/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3686/events | https://github.com/NVIDIA/NeMo/issues/3686 | 1,139,676,149 | I_kwDOC_bI7s5D7hP1 | 3,686 | [Question] What is the meaning of finite max_symbols_per_step parameter? | {
"login": "manneh",
"id": 42110229,
"node_id": "MDQ6VXNlcjQyMTEwMjI5",
"avatar_url": "https://avatars.githubusercontent.com/u/42110229?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/manneh",
"html_url": "https://github.com/manneh",
"followers_url": "https://api.github.com/users/manneh/followers",
"following_url": "https://api.github.com/users/manneh/following{/other_user}",
"gists_url": "https://api.github.com/users/manneh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/manneh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/manneh/subscriptions",
"organizations_url": "https://api.github.com/users/manneh/orgs",
"repos_url": "https://api.github.com/users/manneh/repos",
"events_url": "https://api.github.com/users/manneh/events{/privacy}",
"received_events_url": "https://api.github.com/users/manneh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T08:16:29 | 2022-02-16T18:36:39 | 2022-02-16T18:36:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | In the pretrained Transducer model, the greedy decoding strategy has a max_symbols_per_step parameter equal to 5. I was wondering why is it not "None" and shouldn't the transducer perform better without that parameter? | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3686/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3686/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3685 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3685/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3685/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3685/events | https://github.com/NVIDIA/NeMo/pull/3685 | 1,139,392,720 | PR_kwDOC_bI7s4y5NKH | 3,685 | Comment out numba in 22.01 release | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-16T01:09:58 | 2022-02-16T01:11:08 | 2022-02-16T01:10:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3685",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3685",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3685.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3685.patch",
"merged_at": "2022-02-16T01:10:59"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Comment out numba install in 22.01 release. It contains numba 0.53.1 which works with RNNT.
**Collection**: [ASR]
# Changelog
- Comment out numba due to numpy conflict.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3685/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3685/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3684 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3684/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3684/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3684/events | https://github.com/NVIDIA/NeMo/pull/3684 | 1,139,300,193 | PR_kwDOC_bI7s4y45Fn | 3,684 | Add pipeline support to eval methods | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T23:00:01 | 2022-02-17T18:32:22 | 2022-02-17T18:32:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3684",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3684",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3684.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3684.patch",
"merged_at": "2022-02-17T18:32:14"
} | # What does this PR do ?
Updates `.complete` and `.compute_logprobs` to work with pipeline parallelism.
**Collection**: [NLP]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
```
python megatron_gpt_eval.py \
--model_file /raid/nemo_files/gpt_126m_tf32_pp2_tp1/megatron_gpt.nemo \
--prompt "Four score and seven years ago our fathers brought forth on this continent, a new nation, conceived in Liberty, and dedicated to the proposition that all men" \
--tensor_model_parallel_size 1 \
--pipeline_model_parallel_size 2 \
--tokens_to_generate 64 \
--stop_after_sentence False --precision 32
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3684/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3684/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3683 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3683/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3683/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3683/events | https://github.com/NVIDIA/NeMo/issues/3683 | 1,139,190,954 | I_kwDOC_bI7s5D5qyq | 3,683 | [Question] nemo container on ngc | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | true | null | [] | null | null | 2022-02-15T20:37:38 | 2022-02-16T18:38:24 | 2022-02-16T18:38:24 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Is there any specific reason that the nemo:1.6.2 container is not yet available on ngc; (https://catalog.ngc.nvidia.com/orgs/nvidia/containers/nemo/tags). The info says the container was modified on Feb. 14, 2022, but the latest tag is still 1.5.1 from Dec. 15, 2021, even though 1.6.2 was released 11 days ago. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3683/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3683/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3682 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3682/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3682/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3682/events | https://github.com/NVIDIA/NeMo/pull/3682 | 1,139,081,294 | PR_kwDOC_bI7s4y4Mo7 | 3,682 | Update Librosa support to 0.9 | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T18:49:34 | 2022-02-16T00:08:46 | 2022-02-16T00:08:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3682",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3682",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3682.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3682.patch",
"merged_at": "2022-02-16T00:08:43"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Adds support for Librosa 0.9
**Collection**: [ASR, TTS]
# Changelog
- Update all librosa calls to required kwargs calls
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3682/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3682/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3681 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3681/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3681/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3681/events | https://github.com/NVIDIA/NeMo/pull/3681 | 1,139,050,761 | PR_kwDOC_bI7s4y4Gv7 | 3,681 | Test HF online for SGD-GEN only | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T18:19:52 | 2022-02-15T20:49:38 | 2022-02-15T20:49:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3681",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3681",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3681.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3681.patch",
"merged_at": "2022-02-15T20:49:35"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Sets `TRANSOFMERS_OFFLINE=0` for SGD-Gen tests only to avoid issues with model caching.
**Collection**: NLP
# Changelog
- Edited Jenkins CI tests to set `TRANSOFMERS_OFFLINE` appropriately.
# Usage
N/A
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3681/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3681/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3680 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3680/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3680/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3680/events | https://github.com/NVIDIA/NeMo/pull/3680 | 1,138,949,553 | PR_kwDOC_bI7s4y3yeh | 3,680 | [TTS] Update TTS tutorials, Simplification of testing Mixer-TTS and FastPitch | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T16:50:34 | 2022-02-16T16:23:28 | 2022-02-16T16:23:25 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3680",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3680",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3680.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3680.patch",
"merged_at": "2022-02-16T16:23:25"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [TTS]
# Changelog
- Update TTS tutorials
- Simplification of testing Mixer-TTS and FastPitch
- Small fix in FastPitch
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
Closes #3603 #3627 #3628 #3676 | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3680/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3680/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3679 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3679/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3679/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3679/events | https://github.com/NVIDIA/NeMo/pull/3679 | 1,138,754,005 | PR_kwDOC_bI7s4y3KSc | 3,679 | added num_workers param to all ASR conf files | {
"login": "Jorjeous",
"id": 37293288,
"node_id": "MDQ6VXNlcjM3MjkzMjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/37293288?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jorjeous",
"html_url": "https://github.com/Jorjeous",
"followers_url": "https://api.github.com/users/Jorjeous/followers",
"following_url": "https://api.github.com/users/Jorjeous/following{/other_user}",
"gists_url": "https://api.github.com/users/Jorjeous/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jorjeous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jorjeous/subscriptions",
"organizations_url": "https://api.github.com/users/Jorjeous/orgs",
"repos_url": "https://api.github.com/users/Jorjeous/repos",
"events_url": "https://api.github.com/users/Jorjeous/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jorjeous/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T14:16:32 | 2022-05-25T18:59:45 | 2022-05-25T18:59:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3679",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3679",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3679.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3679.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3679/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3679/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3676 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3676/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3676/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3676/events | https://github.com/NVIDIA/NeMo/issues/3676 | 1,138,638,215 | I_kwDOC_bI7s5D3j2H | 3,676 | TypeError: Error instantiating 'nemo.collections.tts.torch.data.TTSDataset' | {
"login": "godspirit00",
"id": 16176151,
"node_id": "MDQ6VXNlcjE2MTc2MTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/16176151?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/godspirit00",
"html_url": "https://github.com/godspirit00",
"followers_url": "https://api.github.com/users/godspirit00/followers",
"following_url": "https://api.github.com/users/godspirit00/following{/other_user}",
"gists_url": "https://api.github.com/users/godspirit00/gists{/gist_id}",
"starred_url": "https://api.github.com/users/godspirit00/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/godspirit00/subscriptions",
"organizations_url": "https://api.github.com/users/godspirit00/orgs",
"repos_url": "https://api.github.com/users/godspirit00/repos",
"events_url": "https://api.github.com/users/godspirit00/events{/privacy}",
"received_events_url": "https://api.github.com/users/godspirit00/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-15T12:40:14 | 2022-02-16T02:51:44 | 2022-02-16T02:51:44 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When I was trying to train Fastpitch from scratch using `fastpitch_align_v1.05.yaml` config, after it spending over 1 hour trying to `Loading dataset`, it threw the error:
```
Traceback (most recent call last):
File "examples/tts/fastpitch.py", line 28, in main
model = FastPitchModel(cfg=cfg.model, trainer=trainer)
File "/root/NeMo/nemo/collections/tts/models/fastpitch.py", line 81, in __init__
super().__init__(cfg=cfg, trainer=trainer)
File "/root/NeMo/nemo/core/classes/modelPT.py", line 138, in __init__
self.setup_training_data(self._cfg.train_ds)
File "/root/NeMo/nemo/collections/tts/models/fastpitch.py", line 453, in setup_training_data
self._train_dl = self.__setup_dataloader_from_config(cfg)
File "/root/NeMo/nemo/collections/tts/models/fastpitch.py", line 440, in __setup_dataloader_from_config
dataset = instantiate(
File "/root/miniconda3/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
return instantiate_node(config, *args, recursive=_recursive_, convert=_convert_)
File "/root/miniconda3/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 249, in instantiate_node
return _call_target(_target_, *args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 64, in _call_target
raise type(e)(
File "/root/miniconda3/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return _target_(*args, **kwargs)
File "/root/NeMo/nemo/collections/tts/torch/data.py", line 228, in __init__
librosa.filters.mel(
TypeError: Error instantiating 'nemo.collections.tts.torch.data.TTSDataset' : mel() takes 0 positional arguments but 2 positional arguments (and 3 keyword-only arguments) were given
```
**Steps/Code to reproduce bug**
` python examples/tts/fastpitch.py --config-name=fastpitch_align_v1.05.yaml train_dataset=/root/autodl-tmp/nancy_train.json validation_datasets=/root/autodl-tmp/nancy_val.json sup_data_path=/root/autodl-tmp/nemo-training/nancy_22k/sup_data exp_manager.exp_dir=/root/autodl-tmp/nemo-training/nancy_22k exp_manager.resume_if_exists=True exp_manager.resume_ignore_no_checkpoint=True model.train_ds.dataloader_params.batch_size=24 pitch_mean=199.37802124023438 pitch_std=55.59949493408203`
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
- Environment location: Cloud
- Method of NeMo install: from source
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: Ubuntu 20.04
- PyTorch version: 1.10
- Python version: 3.8
**Additional context**
Add any other context about the problem here.
Example: RTX 3090
| {
"login": "godspirit00",
"id": 16176151,
"node_id": "MDQ6VXNlcjE2MTc2MTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/16176151?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/godspirit00",
"html_url": "https://github.com/godspirit00",
"followers_url": "https://api.github.com/users/godspirit00/followers",
"following_url": "https://api.github.com/users/godspirit00/following{/other_user}",
"gists_url": "https://api.github.com/users/godspirit00/gists{/gist_id}",
"starred_url": "https://api.github.com/users/godspirit00/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/godspirit00/subscriptions",
"organizations_url": "https://api.github.com/users/godspirit00/orgs",
"repos_url": "https://api.github.com/users/godspirit00/repos",
"events_url": "https://api.github.com/users/godspirit00/events{/privacy}",
"received_events_url": "https://api.github.com/users/godspirit00/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3676/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3676/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3675 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3675/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3675/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3675/events | https://github.com/NVIDIA/NeMo/issues/3675 | 1,138,272,353 | I_kwDOC_bI7s5D2Khh | 3,675 | Need Confirmation | {
"login": "SonuKumari1690",
"id": 45452951,
"node_id": "MDQ6VXNlcjQ1NDUyOTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/45452951?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SonuKumari1690",
"html_url": "https://github.com/SonuKumari1690",
"followers_url": "https://api.github.com/users/SonuKumari1690/followers",
"following_url": "https://api.github.com/users/SonuKumari1690/following{/other_user}",
"gists_url": "https://api.github.com/users/SonuKumari1690/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SonuKumari1690/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SonuKumari1690/subscriptions",
"organizations_url": "https://api.github.com/users/SonuKumari1690/orgs",
"repos_url": "https://api.github.com/users/SonuKumari1690/repos",
"events_url": "https://api.github.com/users/SonuKumari1690/events{/privacy}",
"received_events_url": "https://api.github.com/users/SonuKumari1690/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-15T07:04:45 | 2022-02-17T20:44:41 | 2022-02-16T18:37:48 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Dear NVIDIA Team,
I need a small confirmation from your end, please confirm that with the below command the model which is restored is from best checkpoints, as after that I am using the loaded model for predictions with the second command
model = TextClassificationModel.restore_from(restore_path='./trained-model-text-nvidia.nemo')
predicted_class = model.classifytext(queries=config.model.infer_samples, batch_size=2, max_seq_length=511) | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3675/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3675/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3674 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3674/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3674/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3674/events | https://github.com/NVIDIA/NeMo/pull/3674 | 1,138,265,007 | PR_kwDOC_bI7s4y1hpn | 3,674 | Dialogue state tracking refactor/ SGDGEN patch 2 | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T06:55:38 | 2022-02-15T19:13:08 | 2022-02-15T18:18:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3674",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3674",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3674.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3674.patch",
"merged_at": "2022-02-15T18:18:30"
} | # What does this PR do ?
Fix bug that causes CI to break due to huggingface cache inconsistency by using local file location
**Collection**: NLP
# Changelog
Previous patch provide a lm_checkpoint location for model to restore_weights, but this method still calls `AutoModel.from_pretrained('gpt2')` before restoring local weights, which can sometimes require cache.
Current patch overcomes this by using `AutoModel.from_pretrained(<local_gpt2_weights_folder>)`, which means that it searches for the local folder directly.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3674/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3674/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3673 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3673/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3673/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3673/events | https://github.com/NVIDIA/NeMo/pull/3673 | 1,138,119,901 | PR_kwDOC_bI7s4y1Cpv | 3,673 | Fixing the bug in the stateful rnnt decoder. | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T03:12:39 | 2023-02-06T22:40:54 | 2022-02-15T22:33:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3673",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3673",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3673.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3673.patch",
"merged_at": "2022-02-15T22:33:51"
} | # What does this PR do ?
Fixing the bug in the stateful rnnt decoder. The current code does not keep the last token properly from partial hypothesis to the next hypothesis. If The latest decoding does not produce any tokens, it would not propagate the non-blank last token and just passes blank token to the next hypothesis which is wrong.
# Changelog
- Fixed the bug in the stateful rnnt decoder by keeping the last token and passing that along properly.
**PR Type**:
- [ ] New Feature
- [x ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3673/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3673/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3672 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3672/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3672/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3672/events | https://github.com/NVIDIA/NeMo/pull/3672 | 1,138,116,981 | PR_kwDOC_bI7s4y1CBU | 3,672 | Added speaker identification script with cosine and neural classifier… | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T03:08:22 | 2022-02-16T21:40:16 | 2022-02-16T21:40:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3672",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3672",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3672.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3672.patch",
"merged_at": "2022-02-16T21:40:13"
} | … backends
Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Added speaker identification script with cosine and neural classifier backends
**Collection**: speaker_tasks
# Changelog
- replaced speaker_reco_infer.py with speaker_identification_infer.py script
- added conf/speaker_identification_infer.yaml
- Updated documentation and README
# Usage
```bash
python speaker_identification_infer.py data.enrollment_manifest=<path/to/enrollment_manifest> data.test_manifest=<path/to/test_manifest> backend.backend_model=cosine_similarity
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3672/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3672/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3671 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3671/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3671/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3671/events | https://github.com/NVIDIA/NeMo/pull/3671 | 1,138,019,613 | PR_kwDOC_bI7s4y0tc3 | 3,671 | folder name update | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T00:44:53 | 2022-02-15T15:17:23 | 2022-02-15T15:17:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3671",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3671",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3671.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3671.patch",
"merged_at": "2022-02-15T15:17:20"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Fixes folder name for jenkins test.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3671/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3671/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3670 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3670/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3670/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3670/events | https://github.com/NVIDIA/NeMo/pull/3670 | 1,138,012,965 | PR_kwDOC_bI7s4y0sC9 | 3,670 | Parallel prompt tuning | {
"login": "vadam5",
"id": 78445382,
"node_id": "MDQ6VXNlcjc4NDQ1Mzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/78445382?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vadam5",
"html_url": "https://github.com/vadam5",
"followers_url": "https://api.github.com/users/vadam5/followers",
"following_url": "https://api.github.com/users/vadam5/following{/other_user}",
"gists_url": "https://api.github.com/users/vadam5/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vadam5/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vadam5/subscriptions",
"organizations_url": "https://api.github.com/users/vadam5/orgs",
"repos_url": "https://api.github.com/users/vadam5/repos",
"events_url": "https://api.github.com/users/vadam5/events{/privacy}",
"received_events_url": "https://api.github.com/users/vadam5/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-15T00:34:29 | 2022-02-18T00:00:22 | 2022-02-17T23:49:32 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3670",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3670",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3670.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3670.patch",
"merged_at": "2022-02-17T23:49:32"
} | # What does this PR do ?
This PR fixes prompt tuning to work with the updated pipeline parallel code. In this PR a user can also prompt tune using tensor parallel > 1. More work will need to be done for prompt tuning to be supported for pipeline parallel > 1.
**Collection**: [Note which collection this PR will affect]
BigNLP?
# Changelog
- prompt tuning with tp=1 and pp=1 works again with updated pipeline parallel code
- prompt tuning with tp > 1 works
- prompt tuning works with the updated complete and compute log probs methods
- Added a prompt tuning config file with prompting specific defaults set
- prompt tuning tests are add back
# Usage
```python
python examples/nlp/language_modeling/megatron_gpt_prompt_tuning.py \
--config-name=megatron_prompt_tuning_gpt \
restore_from_path='/prompt-tuning/megatron_gpt.nemo' \
trainer.val_check_interval=2 \
trainer.max_steps=5 \
model.new_prompt_tags=['Winogrande, BoolQ'] \
model.new_prompt_init_text=['logic choose person name, None'] \
model.new_prompt_init_methods=['text, random'] \
model.data.train_ds='/prompt-tuning/wino_bool_prompt_tuning_train.json' \
model.data.valid_ds='/prompt-tuning/wino_bool_prompt_tuning_val.json' \
+model.data.test_ds='/prompt-tuning/wino_bool_prompt_tuning_val.json' \
model.micro_batch_size=2 \
model.global_batch_size=4 \
model.optim.lr=2e-2 \
model.optim.sched.min_lr=2e-3 \
model.optim.sched.warmup_steps=2 \
model.optim.sched.constant_steps=8 \
model.encoder_seq_length=2048
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [X] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3670/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3670/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3669 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3669/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3669/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3669/events | https://github.com/NVIDIA/NeMo/pull/3669 | 1,137,980,705 | PR_kwDOC_bI7s4y0lMW | 3,669 | Add Buffered RNNT with LCS Merge algorithm | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T23:41:59 | 2022-05-18T23:50:28 | 2022-02-16T18:43:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3669",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3669",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3669.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3669.patch",
"merged_at": "2022-02-16T18:43:15"
} | Signed-off-by: smajumdar <[email protected]>
Adds an optional research notebook discussing the Longest Common Subsequence merge algorithm as used for Streaming/Buffered transducer inference.
**Collection**: [ASR]
# Changelog
- Add optional research notebook
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3669/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3669/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3668 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3668/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3668/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3668/events | https://github.com/NVIDIA/NeMo/pull/3668 | 1,137,980,172 | PR_kwDOC_bI7s4y0lFJ | 3,668 | Added export wrappers for LayerNorm and BatchNorm2d, cleanup | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T23:41:00 | 2022-02-17T20:45:00 | 2022-02-17T20:45:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3668",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3668",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3668.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3668.patch",
"merged_at": null
} | Signed-off-by: Boris Fomitchev <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3668/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3668/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3667 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3667/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3667/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3667/events | https://github.com/NVIDIA/NeMo/pull/3667 | 1,137,947,427 | PR_kwDOC_bI7s4y0d7p | 3,667 | Dialogue state tracking refactor | {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T22:59:57 | 2022-02-15T03:07:11 | 2022-02-15T03:07:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3667",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3667",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3667.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3667.patch",
"merged_at": "2022-02-15T03:07:11"
} | # What does this PR do ?
Unblock CI for SGDGEN by locally loading model checkpoint instead of calling from huggingface
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Zhilin123",
"id": 29811458,
"node_id": "MDQ6VXNlcjI5ODExNDU4",
"avatar_url": "https://avatars.githubusercontent.com/u/29811458?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Zhilin123",
"html_url": "https://github.com/Zhilin123",
"followers_url": "https://api.github.com/users/Zhilin123/followers",
"following_url": "https://api.github.com/users/Zhilin123/following{/other_user}",
"gists_url": "https://api.github.com/users/Zhilin123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Zhilin123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Zhilin123/subscriptions",
"organizations_url": "https://api.github.com/users/Zhilin123/orgs",
"repos_url": "https://api.github.com/users/Zhilin123/repos",
"events_url": "https://api.github.com/users/Zhilin123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Zhilin123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3667/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3667/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3666 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3666/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3666/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3666/events | https://github.com/NVIDIA/NeMo/pull/3666 | 1,137,941,025 | PR_kwDOC_bI7s4y0cjf | 3,666 | Megatron BART | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T22:50:23 | 2022-03-30T15:30:20 | 2022-03-30T15:30:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3666",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3666",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3666.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3666.patch",
"merged_at": "2022-03-30T15:30:20"
} | # What does this PR do ?
This PR adds support in BART Megatron model <https://arxiv.org/abs/1910.13461>.
**Collection**: `nemo.collections.nlp.models.language_modeling.megatron_bart_model`
# Usage
```
python /code/examples/nlp/language_modeling/megatron_bart_pretraining.py \
--config-path=/code/examples/nlp/language_modeling/conf \
--config-name=megatron_bart_config \
trainer.num_nodes=1 \
trainer.devices=1 \
trainer.max_epochs=null \
trainer.max_steps=${MAX_STEPS} \
trainer.val_check_interval=${VAL_CHECK_INTERVAL} \
trainer.accumulate_grad_batches=${ACCUMULATE_GRAD_BATCHES} \
trainer.precision=16 \
model.micro_batch_size=${MICRO_BATCH_SIZE} \
model.tensor_model_parallel_size=${TENSOR_MODEL_PARALLEL_SIZE} \
model.max_position_embeddings=${SEQ_LENGTH} \
model.seq_length=${SEQ_LENGTH} \
model.hidden_size=${HIDDEN_SIZE} \
model.num_layers=${NUM_LAYERS} \
model.num_attention_heads=${NUM_ATTENTION_HEADS} \
model.init_method_std=0.015 \
model.data.data_prefix=[1.0,/preproc_data/train/my-t5_test_bert_tokenizer_text_document] \
model.data.seq_length=${SEQ_LENGTH} \
``` | {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3666/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3666/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3665 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3665/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3665/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3665/events | https://github.com/NVIDIA/NeMo/pull/3665 | 1,137,842,074 | PR_kwDOC_bI7s4y0HLV | 3,665 | [NeMo Megatron] use worker processes for data preprocessing | {
"login": "crcrpar",
"id": 16191443,
"node_id": "MDQ6VXNlcjE2MTkxNDQz",
"avatar_url": "https://avatars.githubusercontent.com/u/16191443?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/crcrpar",
"html_url": "https://github.com/crcrpar",
"followers_url": "https://api.github.com/users/crcrpar/followers",
"following_url": "https://api.github.com/users/crcrpar/following{/other_user}",
"gists_url": "https://api.github.com/users/crcrpar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/crcrpar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/crcrpar/subscriptions",
"organizations_url": "https://api.github.com/users/crcrpar/orgs",
"repos_url": "https://api.github.com/users/crcrpar/repos",
"events_url": "https://api.github.com/users/crcrpar/events{/privacy}",
"received_events_url": "https://api.github.com/users/crcrpar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T21:05:31 | 2022-02-25T21:20:56 | 2022-02-25T20:00:03 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3665",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3665",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3665.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3665.patch",
"merged_at": "2022-02-25T20:00:03"
} | # What does this PR do ?
<!-- Add a one line overview of what this PR aims to accomplish. -->
Update Megatron style `BatchSampler`s and `GPTDataset` to prepare data samples in worker processes.
# Changelog
- BatchSamplers return a list of `num_micro_batch x micro_batch_size` indices: https://github.com/NVIDIA/NeMo/compare/main...crcrpar:megatron/update_data_loading?expand=1#diff-a78cf82731c4e37f487037ab45cab0183aac6216ee96e08d3b81ff111495d3caR36 and https://github.com/NVIDIA/NeMo/compare/main...crcrpar:megatron/update_data_loading?expand=1#diff-a78cf82731c4e37f487037ab45cab0183aac6216ee96e08d3b81ff111495d3caR106
- A new arguments of `eos_id` is added to `GPTDataset` in order to change the callsite of `get_ltor_masks_and_position_ids` to `GPTDataset`. [`eos_id`](url) is an attribute of a `Tokenizer` instance.
- `process_micro_batch` is removed in favor of updated `GPTDataset.__getitem__`: https://github.com/NVIDIA/NeMo/compare/main...crcrpar:megatron/update_data_loading?expand=1#diff-e93ccae74f4b67d341676afc9f3c7e2c50f751ec64df84eb3b2a86b62029ef76L456
- `NLPDataConnector` isn't needed thanks to the updated `GPTDataset` and `BatchSampler`s: https://github.com/NVIDIA/NeMo/compare/main...crcrpar:megatron/update_data_loading?expand=1#diff-424bb19c0b7c9dba2aebb3459972c5a8bf8c902dca48a8762f12bc5cde5fea5fL68
# Usage
To utilize worker processes, it'd be better to set `model.data.num_workers` > 0.
See https://pytorch.org/docs/stable/data.html#torch.utils.data.DataLoader.
<!--
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
-->
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3665/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3665/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3664 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3664/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3664/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3664/events | https://github.com/NVIDIA/NeMo/pull/3664 | 1,137,747,530 | PR_kwDOC_bI7s4yzy9_ | 3,664 | O2 style mixed precision training for T5 | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T19:32:10 | 2022-02-16T17:35:55 | 2022-02-16T17:35:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3664",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3664",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3664.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3664.patch",
"merged_at": "2022-02-16T17:35:50"
} | # What does this PR do ?
Adds support for O2-style mixed-precision training for Megatron LM Encoder-Decoder Models.
**Collection**: NLP
# Changelog
- This PR only changes `megatron_lm_encoder_decoder.py` to add O2 support based on the same changes for GPT.
# Usage
Set `megatron_amp_o2: True` in the `megatron_t5_config.yaml` file.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3664/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3664/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3663 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3663/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3663/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3663/events | https://github.com/NVIDIA/NeMo/pull/3663 | 1,137,656,025 | PR_kwDOC_bI7s4yzfTP | 3,663 | Fixed the bug in bucketing. | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T18:04:13 | 2022-02-14T20:26:08 | 2022-02-14T20:13:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3663",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3663",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3663.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3663.patch",
"merged_at": "2022-02-14T20:13:20"
} | # What does this PR do ?
Fix a bug in the bucketing which is caused by this PR: https://github.com/NVIDIA/NeMo/pull/3485
Training ASR models with bucketing feature were affected by this.
# Changelog
Changed the way the length of a dataset is retrieved to fix the bug in the bucketing.
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
| {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3663/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3663/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3662 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3662/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3662/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3662/events | https://github.com/NVIDIA/NeMo/pull/3662 | 1,137,642,576 | PR_kwDOC_bI7s4yzccJ | 3,662 | [TTS] Add speakerID to libritts/get_data.py | {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T17:51:14 | 2022-02-16T08:48:16 | 2022-02-16T08:48:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3662",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3662",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3662.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3662.patch",
"merged_at": "2022-02-16T08:48:15"
} | Signed-off-by: Subhankar Ghosh <[email protected]>
# What does this PR do ?
Adds SpeakerID to `process_transcript` method of libritts/get_data.py
# Changelog
Gets speakerID from the path because the path to every manifest has the speakerID.
Adds the speakerID to the entry as another (key,value) pair.
# Usage
Doesn't change how libritts/get_data.py will be called. The manifests will contain speaker field.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3662/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3662/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3661 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3661/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3661/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3661/events | https://github.com/NVIDIA/NeMo/issues/3661 | 1,137,386,435 | I_kwDOC_bI7s5DyyPD | 3,661 | Reached max decoder steps | {
"login": "davidmartinrius",
"id": 16558194,
"node_id": "MDQ6VXNlcjE2NTU4MTk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16558194?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmartinrius",
"html_url": "https://github.com/davidmartinrius",
"followers_url": "https://api.github.com/users/davidmartinrius/followers",
"following_url": "https://api.github.com/users/davidmartinrius/following{/other_user}",
"gists_url": "https://api.github.com/users/davidmartinrius/gists{/gist_id}",
"starred_url": "https://api.github.com/users/davidmartinrius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidmartinrius/subscriptions",
"organizations_url": "https://api.github.com/users/davidmartinrius/orgs",
"repos_url": "https://api.github.com/users/davidmartinrius/repos",
"events_url": "https://api.github.com/users/davidmartinrius/events{/privacy}",
"received_events_url": "https://api.github.com/users/davidmartinrius/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-14T14:29:11 | 2022-02-22T14:48:59 | 2022-02-22T14:48:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I'm training a model on Tacotron2. I tried little datasets, large datasets, but always I get the same messages.
Reached max decoder steps XXXX
By default there are 1000 steps. I tried the default configuration and also I tried greater values.
I thought it was caused because the labels property in tacotron2.yaml. But I grouped all the letters in my dataset and every letter is on the "labels" property.
Also I tried adding a dot at the end of each sentence. Absolutely all of the sentences are between 1 and 10 seconds.
The dataset is all in spanish. I tried to train minutes, hours, etc. I mean in the json file I tried from 10000 registers to 100 registers.
When training it always notice Reached max decoder steps XXXX
Do you know why is it happening? Do you know how to solve it?
Thank you!
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3661/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3661/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3660 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3660/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3660/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3660/events | https://github.com/NVIDIA/NeMo/pull/3660 | 1,136,793,438 | PR_kwDOC_bI7s4ywmWd | 3,660 | Asr noise data scripts | {
"login": "jbalam-nv",
"id": 4916480,
"node_id": "MDQ6VXNlcjQ5MTY0ODA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4916480?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbalam-nv",
"html_url": "https://github.com/jbalam-nv",
"followers_url": "https://api.github.com/users/jbalam-nv/followers",
"following_url": "https://api.github.com/users/jbalam-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/jbalam-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbalam-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbalam-nv/subscriptions",
"organizations_url": "https://api.github.com/users/jbalam-nv/orgs",
"repos_url": "https://api.github.com/users/jbalam-nv/repos",
"events_url": "https://api.github.com/users/jbalam-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbalam-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-14T05:27:16 | 2022-02-17T01:50:17 | 2022-02-17T01:50:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3660",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3660",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3660.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3660.patch",
"merged_at": "2022-02-17T01:50:14"
} | # What does this PR do ?
Adds scripts 1) download and prepare noise data from Demand database and 2) to add noise to an audio dataset at various SNRs
**Collection**: [ASR]
# Changelog
- Added script to download and prepare manifest for noise data from Demand noise database.
- Added script to add noise to an audio dataset at various SNRs
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3660/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3660/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3659 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3659/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3659/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3659/events | https://github.com/NVIDIA/NeMo/issues/3659 | 1,136,698,197 | I_kwDOC_bI7s5DwKNV | 3,659 | Can't download NVIDIA Models | {
"login": "claratang98",
"id": 90296566,
"node_id": "MDQ6VXNlcjkwMjk2NTY2",
"avatar_url": "https://avatars.githubusercontent.com/u/90296566?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/claratang98",
"html_url": "https://github.com/claratang98",
"followers_url": "https://api.github.com/users/claratang98/followers",
"following_url": "https://api.github.com/users/claratang98/following{/other_user}",
"gists_url": "https://api.github.com/users/claratang98/gists{/gist_id}",
"starred_url": "https://api.github.com/users/claratang98/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/claratang98/subscriptions",
"organizations_url": "https://api.github.com/users/claratang98/orgs",
"repos_url": "https://api.github.com/users/claratang98/repos",
"events_url": "https://api.github.com/users/claratang98/events{/privacy}",
"received_events_url": "https://api.github.com/users/claratang98/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-14T03:15:20 | 2022-02-18T04:22:32 | 2022-02-18T04:22:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am trying the NEMO_Primer from this GitHub repository. I have tried downloading the model on Google Colab however if I try to run the demo on Jupiter notebook locally, the model cant be downloaded. Please see image to see error. This error pops up when passing a pre-trained model name and instantiate a model directly from the cloud:
citrinet = nemo_asr.models.EncDecCTCModelBPE.from_pretrained('stt_en_citrinet_512')
or
quartznet = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name="stt_en_quartznet15x5")
<img width="972" alt="Screenshot 2022-02-14 at 11 10 41 AM" src="https://user-images.githubusercontent.com/90296566/153793932-26dc0258-0225-4542-9322-bc7a496b4059.png">
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3659/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3659/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3658 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3658/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3658/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3658/events | https://github.com/NVIDIA/NeMo/issues/3658 | 1,134,860,494 | I_kwDOC_bI7s5DpJjO | 3,658 | Numpy error | {
"login": "davidmartinrius",
"id": 16558194,
"node_id": "MDQ6VXNlcjE2NTU4MTk0",
"avatar_url": "https://avatars.githubusercontent.com/u/16558194?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmartinrius",
"html_url": "https://github.com/davidmartinrius",
"followers_url": "https://api.github.com/users/davidmartinrius/followers",
"following_url": "https://api.github.com/users/davidmartinrius/following{/other_user}",
"gists_url": "https://api.github.com/users/davidmartinrius/gists{/gist_id}",
"starred_url": "https://api.github.com/users/davidmartinrius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidmartinrius/subscriptions",
"organizations_url": "https://api.github.com/users/davidmartinrius/orgs",
"repos_url": "https://api.github.com/users/davidmartinrius/repos",
"events_url": "https://api.github.com/users/davidmartinrius/events{/privacy}",
"received_events_url": "https://api.github.com/users/davidmartinrius/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-13T00:24:29 | 2022-05-09T06:37:49 | 2022-02-16T09:06:36 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I Installed a clean Ubuntu 20.04, installed nvidia drivers 440 for RTX 3080. Then I followed the instructions to train a model with Tacotron2.
numpy fails with the next error:
valueerror: numpy.ndarray size changed, may indicate binary incompatibility. expected 96 from c header, got 88 from pyobject
I tried the default version of numpy and also I tried pip install --upgrade numpy==1.21.0
I really don'tknow how to solve the problem and I write this to ask for help.
Do you know how to solve it?
Thank you!
David
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3658/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3658/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3655 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3655/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3655/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3655/events | https://github.com/NVIDIA/NeMo/pull/3655 | 1,133,190,981 | PR_kwDOC_bI7s4yjfJb | 3,655 | adding guard | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T22:18:08 | 2022-02-14T23:05:17 | 2022-02-14T23:05:14 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3655",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3655",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3655.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3655.patch",
"merged_at": "2022-02-14T23:05:14"
} | added pynini installation guard | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3655/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3655/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3654 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3654/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3654/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3654/events | https://github.com/NVIDIA/NeMo/pull/3654 | 1,133,167,185 | PR_kwDOC_bI7s4yjZnw | 3,654 | LM adapted T5 dataset | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T22:03:51 | 2022-02-17T00:32:38 | 2022-02-17T00:32:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3654",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3654",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3654.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3654.patch",
"merged_at": "2022-02-17T00:32:35"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Adds the ability to use the prefix-LM objective for T5 which reuses the GPT dataset class that already exists.
**Collection**: NLP
# Changelog
- Adds at T5LMAdaptedDataset class that inherits from GPTDataset that just splits a text sequence into encoder and decoder components
- Re-uses the existing build_train_valid_test_datasets functions that exist for BERT and T5 for this class.
- Moves some dataset utils to a new file to prevent circular imports between gpt_dataset.py and dataset_utils.py.
# Usage
Add the `dataset_type` flag to either `t5` or `t5_prefix_lm` in `megatron_t5_config.yaml`.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3654/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3654/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3653 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3653/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3653/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3653/events | https://github.com/NVIDIA/NeMo/pull/3653 | 1,133,166,085 | PR_kwDOC_bI7s4yjZXY | 3,653 | Significantly speed up RNNT loss on CUDA | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T22:03:13 | 2022-02-15T03:13:29 | 2022-02-15T03:13:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3653",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3653",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3653.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3653.patch",
"merged_at": "2022-02-15T03:13:26"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Speed up CUDA RNNT loss
**Collection**: [ASR]
# Changelog
- Fix issue with data movement of costs tensor from llForward to pytorch data view in numba
- This alone costs a linear loop (scaling with batch size) that is roughly 10x the kernel costs themselves.
- Fix by writing a small kernel to copy the data and update the costs.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3653/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3653/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3652 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3652/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3652/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3652/events | https://github.com/NVIDIA/NeMo/pull/3652 | 1,133,131,914 | PR_kwDOC_bI7s4yjRdD | 3,652 | [TOOLS] fix number of channels>1 issue | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T21:42:48 | 2022-02-12T03:00:18 | 2022-02-12T03:00:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3652",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3652",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3652.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3652.patch",
"merged_at": "2022-02-12T03:00:14"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [X ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3652/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3652/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3651 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3651/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3651/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3651/events | https://github.com/NVIDIA/NeMo/pull/3651 | 1,133,095,475 | PR_kwDOC_bI7s4yjJdC | 3,651 | Add tutorial paths | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T21:07:29 | 2022-02-14T23:48:05 | 2022-02-14T23:48:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3651",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3651",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3651.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3651.patch",
"merged_at": "2022-02-14T23:48:02"
} | # What does this PR do ?
Update readme to include streaming inference directory for ASR.
**Collection**: [ASR]
# Changelog
- Update readme.md to contain link to streaming / buffered asr
- Update URL in tutorial for streaming / buffered transducer models
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3651/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3651/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3650 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3650/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3650/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3650/events | https://github.com/NVIDIA/NeMo/pull/3650 | 1,133,056,521 | PR_kwDOC_bI7s4yjA8r | 3,650 | add onnx support for speaker models | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T20:24:06 | 2022-02-15T17:22:49 | 2022-02-15T17:22:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3650",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3650",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3650.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3650.patch",
"merged_at": "2022-02-15T17:22:46"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
* adds onnx support for speaker models
**Collection**: [speaker_tasks]
# Changelog
- Added forward_for_export function
- Fixed previous asr onnx exportable tests
# Usage
To generate onnx speaker model from titanet nemo
```bash
python export.py <path/to/titanet-l.nemo> <path/to/titanet-l.onnx>
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3650/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3650/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3649 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3649/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3649/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3649/events | https://github.com/NVIDIA/NeMo/pull/3649 | 1,132,885,410 | PR_kwDOC_bI7s4yicDL | 3,649 | Add ssl tutorial to tutorial docs page | {
"login": "sam1373",
"id": 24465107,
"node_id": "MDQ6VXNlcjI0NDY1MTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/24465107?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sam1373",
"html_url": "https://github.com/sam1373",
"followers_url": "https://api.github.com/users/sam1373/followers",
"following_url": "https://api.github.com/users/sam1373/following{/other_user}",
"gists_url": "https://api.github.com/users/sam1373/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sam1373/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sam1373/subscriptions",
"organizations_url": "https://api.github.com/users/sam1373/orgs",
"repos_url": "https://api.github.com/users/sam1373/repos",
"events_url": "https://api.github.com/users/sam1373/events{/privacy}",
"received_events_url": "https://api.github.com/users/sam1373/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T17:22:45 | 2022-02-11T18:36:46 | 2022-02-11T18:36:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3649",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3649",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3649.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3649.patch",
"merged_at": "2022-02-11T18:36:46"
} | Signed-off-by: sam1373 <[email protected]>
# What does this PR do ?
Add ASR ssl tutorial to the tutorial docs page.
**Collection**: ASR
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3649/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3649/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3647 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3647/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3647/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3647/events | https://github.com/NVIDIA/NeMo/issues/3647 | 1,131,814,643 | I_kwDOC_bI7s5Ddh7z | 3,647 | .wav file contains data in an unknown format | {
"login": "claratang98",
"id": 90296566,
"node_id": "MDQ6VXNlcjkwMjk2NTY2",
"avatar_url": "https://avatars.githubusercontent.com/u/90296566?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/claratang98",
"html_url": "https://github.com/claratang98",
"followers_url": "https://api.github.com/users/claratang98/followers",
"following_url": "https://api.github.com/users/claratang98/following{/other_user}",
"gists_url": "https://api.github.com/users/claratang98/gists{/gist_id}",
"starred_url": "https://api.github.com/users/claratang98/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/claratang98/subscriptions",
"organizations_url": "https://api.github.com/users/claratang98/orgs",
"repos_url": "https://api.github.com/users/claratang98/repos",
"events_url": "https://api.github.com/users/claratang98/events{/privacy}",
"received_events_url": "https://api.github.com/users/claratang98/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T05:54:11 | 2022-02-18T04:22:41 | 2022-02-18T04:22:41 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am testing out the NVIDIA NeMo tutorial for ASR_with_Nemo.ipynb on google colab. The dataset in the demo from an4 works fine for me. However when I try to upload a .wav file from my local pc, the code returns an error "RuntimeError: Error opening '020010009.wav': File contains data in an unknown format." This is odd because I tried uploading a .sph file and use their code to convert the .sph file into a .wav file and it outputs the same error. I opened up the .sph file from the an4 dataset and opened up my .sph file and even though both are .sph files, the file content looks different. Seems like the demo only works on the an4 audio dataset and nothing else. Can anyone help? | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3647/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3647/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3646 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3646/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3646/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3646/events | https://github.com/NVIDIA/NeMo/pull/3646 | 1,131,525,654 | PR_kwDOC_bI7s4ydm93 | 3,646 | Changes to support mean n-gram size masking for T5 | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-11T02:39:42 | 2022-02-15T01:27:30 | 2022-02-15T01:27:26 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3646",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3646",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3646.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3646.patch",
"merged_at": "2022-02-15T01:27:26"
} | Signed-off-by: MaximumEntropy <[email protected]>
# What does this PR do ?
Allows configuring the mean n-gram size for T5 span masking when using a geometric distribution.
**Collection**: NLP
# Changelog
- Used the fact that the expectation of the geometric distribution is 1/p to set p appropriately for a given expected value of n-gram size.
# Usage
To get a mean n-gram size of 3 while masking (like suggested in the T5 paper), thee data configuration for T5 can look like this:
```
max_ngram_size: ${seq_length_dec}
mean_ngram_size: 3
geometric_dist: True
permutation: False
whole_work_masking: True
favor_longer_ngrams: False
```
```python
# N/A same run script as T5, just requires changing the yaml config like above.
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3646/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3646/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3645 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3645/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3645/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3645/events | https://github.com/NVIDIA/NeMo/pull/3645 | 1,131,233,335 | PR_kwDOC_bI7s4ycjFM | 3,645 | Update adobe analytics | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T23:29:14 | 2022-02-10T23:29:47 | 2022-02-10T23:29:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3645",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3645",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3645.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3645.patch",
"merged_at": "2022-02-10T23:29:44"
} | # What does this PR do ?
Update analytics code.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3645/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3645/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3644 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3644/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3644/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3644/events | https://github.com/NVIDIA/NeMo/pull/3644 | 1,131,202,886 | PR_kwDOC_bI7s4yccGe | 3,644 | Update adobe analytics | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T23:10:47 | 2022-02-10T23:28:00 | 2022-02-10T23:11:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3644",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3644",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3644.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3644.patch",
"merged_at": "2022-02-10T23:11:52"
} | # What does this PR do ?
Update adobe analytics code.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3644/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3644/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3643 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3643/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3643/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3643/events | https://github.com/NVIDIA/NeMo/pull/3643 | 1,130,750,402 | PR_kwDOC_bI7s4ya0ax | 3,643 | Add a function that writes cluster label in diarization pipeline | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T19:25:11 | 2022-04-14T23:26:26 | 2022-02-14T21:41:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3643",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3643",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3643.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3643.patch",
"merged_at": "2022-02-14T21:41:10"
} | # What does this PR do ?
This PR adds a function that writes cluster label. This cluster label (speaker label for each segment) is needed to provide estimated segment label for overlap-aware diarization module or target-speaker ASR.
**Collection**: asr (but actually speaker_tasks)
# Changelog
- Removed unnecessary line in speaker_utils.py
- Added a line that adds segment info and cluster label
- Added lines that write files to speaker_outputs.
# Usage
Please refer to [Diarization docs](https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/asr/speaker_diarization/datasets.html)
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3643/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3643/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3642 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3642/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3642/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3642/events | https://github.com/NVIDIA/NeMo/pull/3642 | 1,130,258,418 | PR_kwDOC_bI7s4yZGGA | 3,642 | Update citrinet_512.yaml | {
"login": "Jorjeous",
"id": 37293288,
"node_id": "MDQ6VXNlcjM3MjkzMjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/37293288?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jorjeous",
"html_url": "https://github.com/Jorjeous",
"followers_url": "https://api.github.com/users/Jorjeous/followers",
"following_url": "https://api.github.com/users/Jorjeous/following{/other_user}",
"gists_url": "https://api.github.com/users/Jorjeous/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jorjeous/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jorjeous/subscriptions",
"organizations_url": "https://api.github.com/users/Jorjeous/orgs",
"repos_url": "https://api.github.com/users/Jorjeous/repos",
"events_url": "https://api.github.com/users/Jorjeous/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jorjeous/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T15:08:30 | 2022-02-18T01:12:32 | 2022-02-18T01:12:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3642",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3642",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3642.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3642.patch",
"merged_at": "2022-02-18T01:12:32"
} | Added num workers, cause without that argument any training goes really slow
# What does this PR do ?
reduced training time
# Changelog
- Add specific line by line info of high level changes in this PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] Bugfix
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Found out that training on 1.6.0 starts with num workers == 0.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3642/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3642/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3641 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3641/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3641/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3641/events | https://github.com/NVIDIA/NeMo/pull/3641 | 1,130,098,503 | PR_kwDOC_bI7s4yYid- | 3,641 | [TTS] Update Aligner, add new methods to AlignmentEncoder | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T13:39:07 | 2022-02-11T14:57:03 | 2022-02-11T14:57:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3641",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3641",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3641.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3641.patch",
"merged_at": "2022-02-11T14:57:00"
} | Signed-off-by: Oktai Tatanov <[email protected]>
# What does this PR do ?
**Collection**: [tts]
# Changelog
- refactoring of Aligner code and config, replacing deprecated datasets with `TTSDataset`
- adding three methods to AlignmentEncoder which can be useful for Neural G2P research
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3641/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3641/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3638 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3638/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3638/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3638/events | https://github.com/NVIDIA/NeMo/pull/3638 | 1,129,640,601 | PR_kwDOC_bI7s4yW8f4 | 3,638 | Add a function that writes cluster label in diarization pipeline | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T08:37:01 | 2022-02-10T18:21:07 | 2022-02-10T18:21:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3638",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3638",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3638.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3638.patch",
"merged_at": null
} | Signed-off-by: Taejin Park <[email protected]>
This PR adds a function that writes cluster label. This cluster label (speaker label for each segment) is needed to provide estimated segment label for overlap-aware diarization module or target-speaker ASR. | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3638/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3638/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3637 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3637/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3637/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3637/events | https://github.com/NVIDIA/NeMo/pull/3637 | 1,129,584,289 | PR_kwDOC_bI7s4yWwZj | 3,637 | update torchaudio in Dockerfile to match torch version | {
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-10T07:43:50 | 2022-02-18T01:12:50 | 2022-02-18T01:12:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3637",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3637",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3637.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3637.patch",
"merged_at": "2022-02-18T01:12:50"
} | Signed-off-by: Aleksandr Laptev <[email protected]>
# What does this PR do ?
This PR fixes the version mismatch between torchaudio and torch (0.10 vs 1.11) in Dockerfile.
If the version of torchaudio does not match the version of torch, then it loses its CUDA backend and the following errors may occur:
```
NotImplementedError: Could not run 'torchaudio::rnnt_loss' with arguments from the 'CUDA' backend.
```
# Changelog
Dockerfile
- `--branch release/0.10` -> `--branch release/0.11`
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3637/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3637/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3636 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3636/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3636/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3636/events | https://github.com/NVIDIA/NeMo/issues/3636 | 1,129,490,866 | I_kwDOC_bI7s5DUqmy | 3,636 | About Korean ASR | {
"login": "eesungkim",
"id": 7551075,
"node_id": "MDQ6VXNlcjc1NTEwNzU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7551075?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/eesungkim",
"html_url": "https://github.com/eesungkim",
"followers_url": "https://api.github.com/users/eesungkim/followers",
"following_url": "https://api.github.com/users/eesungkim/following{/other_user}",
"gists_url": "https://api.github.com/users/eesungkim/gists{/gist_id}",
"starred_url": "https://api.github.com/users/eesungkim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eesungkim/subscriptions",
"organizations_url": "https://api.github.com/users/eesungkim/orgs",
"repos_url": "https://api.github.com/users/eesungkim/repos",
"events_url": "https://api.github.com/users/eesungkim/events{/privacy}",
"received_events_url": "https://api.github.com/users/eesungkim/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-10T05:51:41 | 2022-02-22T13:32:34 | 2022-02-22T13:32:34 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Thank you for sharing a great tool.
I'm wondering if I can make a contribution to Nemo sharing the pretrained models trained with Ksponspeech dataset which is an open-domain Korean dialog corpus with benchmark scores, configs, and related codes.
If so, please let me know how to share the pretrained models. | {
"login": "eesungkim",
"id": 7551075,
"node_id": "MDQ6VXNlcjc1NTEwNzU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7551075?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/eesungkim",
"html_url": "https://github.com/eesungkim",
"followers_url": "https://api.github.com/users/eesungkim/followers",
"following_url": "https://api.github.com/users/eesungkim/following{/other_user}",
"gists_url": "https://api.github.com/users/eesungkim/gists{/gist_id}",
"starred_url": "https://api.github.com/users/eesungkim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eesungkim/subscriptions",
"organizations_url": "https://api.github.com/users/eesungkim/orgs",
"repos_url": "https://api.github.com/users/eesungkim/repos",
"events_url": "https://api.github.com/users/eesungkim/events{/privacy}",
"received_events_url": "https://api.github.com/users/eesungkim/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3636/reactions",
"total_count": 5,
"+1": 5,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3636/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3634 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3634/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3634/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3634/events | https://github.com/NVIDIA/NeMo/issues/3634 | 1,128,681,472 | I_kwDOC_bI7s5DRlAA | 3,634 | Never mind sorry | {
"login": "catskillsresearch",
"id": 38082822,
"node_id": "MDQ6VXNlcjM4MDgyODIy",
"avatar_url": "https://avatars.githubusercontent.com/u/38082822?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/catskillsresearch",
"html_url": "https://github.com/catskillsresearch",
"followers_url": "https://api.github.com/users/catskillsresearch/followers",
"following_url": "https://api.github.com/users/catskillsresearch/following{/other_user}",
"gists_url": "https://api.github.com/users/catskillsresearch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/catskillsresearch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catskillsresearch/subscriptions",
"organizations_url": "https://api.github.com/users/catskillsresearch/orgs",
"repos_url": "https://api.github.com/users/catskillsresearch/repos",
"events_url": "https://api.github.com/users/catskillsresearch/events{/privacy}",
"received_events_url": "https://api.github.com/users/catskillsresearch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-09T15:23:19 | 2022-02-09T15:25:03 | 2022-02-09T15:25:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Never mind I was running with the wrong python.... | {
"login": "catskillsresearch",
"id": 38082822,
"node_id": "MDQ6VXNlcjM4MDgyODIy",
"avatar_url": "https://avatars.githubusercontent.com/u/38082822?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/catskillsresearch",
"html_url": "https://github.com/catskillsresearch",
"followers_url": "https://api.github.com/users/catskillsresearch/followers",
"following_url": "https://api.github.com/users/catskillsresearch/following{/other_user}",
"gists_url": "https://api.github.com/users/catskillsresearch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/catskillsresearch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catskillsresearch/subscriptions",
"organizations_url": "https://api.github.com/users/catskillsresearch/orgs",
"repos_url": "https://api.github.com/users/catskillsresearch/repos",
"events_url": "https://api.github.com/users/catskillsresearch/events{/privacy}",
"received_events_url": "https://api.github.com/users/catskillsresearch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3634/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3634/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3632 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3632/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3632/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3632/events | https://github.com/NVIDIA/NeMo/pull/3632 | 1,128,062,957 | PR_kwDOC_bI7s4yRrn3 | 3,632 | Tn es | {
"login": "bonham79",
"id": 36190463,
"node_id": "MDQ6VXNlcjM2MTkwNDYz",
"avatar_url": "https://avatars.githubusercontent.com/u/36190463?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bonham79",
"html_url": "https://github.com/bonham79",
"followers_url": "https://api.github.com/users/bonham79/followers",
"following_url": "https://api.github.com/users/bonham79/following{/other_user}",
"gists_url": "https://api.github.com/users/bonham79/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bonham79/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bonham79/subscriptions",
"organizations_url": "https://api.github.com/users/bonham79/orgs",
"repos_url": "https://api.github.com/users/bonham79/repos",
"events_url": "https://api.github.com/users/bonham79/events{/privacy}",
"received_events_url": "https://api.github.com/users/bonham79/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-09T05:12:31 | 2022-02-23T17:54:25 | 2022-02-23T17:04:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3632",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3632",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3632.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3632.patch",
"merged_at": "2022-02-23T17:04:00"
} | # What does this PR do ?
Adds Text Normalization for spanish language to nemo_text_normalization
**Collection**: Nemo Text Normalization
# Changelog
- Adds Text Normalization for Spanish language. Verbalizers and classifiers are available for following classes
- - Cardinal
- - Decimal
- - Ordinal
- - Fraction
- - Money
- - Measure
- - Date
- - Time
- - Electronic
- - Whitelist
Also includes a localization option of es-amer, which changes formatting rules to accommodate tendencies in Central American orthography. (e.g. Use of periods to group cardinals instead of commas - as is customary for other Spanish speaking locales.)
Includes updated es_pytests for text normalization and edits to export_grammar.sh and normalize.py to allow deployment. All tests have passed in nemo docker environment.
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [Y ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [Y ] Did you write any new necessary tests?
- [Y ] Did you add or update any necessary documentation?
- [ ]Y Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ Y] New Feature
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
- * N. B. Sparrowhawk deployment is altering white-space following periods, so TN is unable to manage both am/pm along with time zones. That is -> 10 a.m. est will cause an error. However, 10.00 h est is stable. This issue is Sparrowhawk related so have been unable to debug.
| {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3632/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3632/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3631 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3631/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3631/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3631/events | https://github.com/NVIDIA/NeMo/pull/3631 | 1,128,024,908 | PR_kwDOC_bI7s4yRj8J | 3,631 | [TTS] FastPitch training tutorial | {
"login": "subhankar-ghosh",
"id": 23703547,
"node_id": "MDQ6VXNlcjIzNzAzNTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23703547?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/subhankar-ghosh",
"html_url": "https://github.com/subhankar-ghosh",
"followers_url": "https://api.github.com/users/subhankar-ghosh/followers",
"following_url": "https://api.github.com/users/subhankar-ghosh/following{/other_user}",
"gists_url": "https://api.github.com/users/subhankar-ghosh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/subhankar-ghosh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/subhankar-ghosh/subscriptions",
"organizations_url": "https://api.github.com/users/subhankar-ghosh/orgs",
"repos_url": "https://api.github.com/users/subhankar-ghosh/repos",
"events_url": "https://api.github.com/users/subhankar-ghosh/events{/privacy}",
"received_events_url": "https://api.github.com/users/subhankar-ghosh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-09T04:05:38 | 2022-02-09T15:58:56 | 2022-02-09T15:58:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3631",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3631",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3631.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3631.patch",
"merged_at": "2022-02-09T15:58:52"
} | # Addition of FastPitch training tutorial
Please have one of the following:
* New feature: (short feature description) FastPitch training tutorial.
This PR adds FastPitch tutorial to the same notebook as MixerTTS as both generate spectrogram. This tutorial goes through the data download, preprocess, FastPitch import and training pipeline.
Tutorial was added with careful consideration to make minimal changes to MixerTTS tutorial.
## Before your PR is "Ready for review"
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or updated any necessary documentation?
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3631/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3631/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3630 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3630/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3630/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3630/events | https://github.com/NVIDIA/NeMo/pull/3630 | 1,127,802,874 | PR_kwDOC_bI7s4yQ3HZ | 3,630 | [TN] ranking lm | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-08T22:00:37 | 2022-08-03T07:15:46 | 2022-02-08T22:04:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3630",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3630",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3630.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3630.patch",
"merged_at": "2022-02-08T22:04:46"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3630/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3630/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3629 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3629/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3629/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3629/events | https://github.com/NVIDIA/NeMo/pull/3629 | 1,127,549,285 | PR_kwDOC_bI7s4yQCcB | 3,629 | Add tn options | {
"login": "yzhang123",
"id": 4204271,
"node_id": "MDQ6VXNlcjQyMDQyNzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yzhang123",
"html_url": "https://github.com/yzhang123",
"followers_url": "https://api.github.com/users/yzhang123/followers",
"following_url": "https://api.github.com/users/yzhang123/following{/other_user}",
"gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions",
"organizations_url": "https://api.github.com/users/yzhang123/orgs",
"repos_url": "https://api.github.com/users/yzhang123/repos",
"events_url": "https://api.github.com/users/yzhang123/events{/privacy}",
"received_events_url": "https://api.github.com/users/yzhang123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-08T17:28:19 | 2022-02-09T07:27:14 | 2022-02-09T07:27:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3629",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3629",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3629.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3629.patch",
"merged_at": "2022-02-09T07:27:11"
} | null | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3629/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3629/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3628 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3628/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3628/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3628/events | https://github.com/NVIDIA/NeMo/issues/3628 | 1,127,445,486 | I_kwDOC_bI7s5DM3Pu | 3,628 | Cannot fine-tune a Hifigan model | {
"login": "godspirit00",
"id": 16176151,
"node_id": "MDQ6VXNlcjE2MTc2MTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/16176151?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/godspirit00",
"html_url": "https://github.com/godspirit00",
"followers_url": "https://api.github.com/users/godspirit00/followers",
"following_url": "https://api.github.com/users/godspirit00/following{/other_user}",
"gists_url": "https://api.github.com/users/godspirit00/gists{/gist_id}",
"starred_url": "https://api.github.com/users/godspirit00/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/godspirit00/subscriptions",
"organizations_url": "https://api.github.com/users/godspirit00/orgs",
"repos_url": "https://api.github.com/users/godspirit00/repos",
"events_url": "https://api.github.com/users/godspirit00/events{/privacy}",
"received_events_url": "https://api.github.com/users/godspirit00/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-08T15:59:04 | 2023-06-02T14:34:01 | 2022-02-18T13:04:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I tried to fine tune the hifigan model according to `FastPitch_Finetuning.ipynb`, but I encountered the following error:
```
Traceback (most recent call last):
File "examples/tts/hifigan_finetune.py", line 28, in main
trainer.fit(model)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 740, in fit
self._call_and_handle_interrupt(
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 685, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 777, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1199, in _run
self._dispatch()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1279, in _dispatch
self.training_type_plugin.start_training(self)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 202, in start_training
self._results = trainer.run_stage()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1289, in run_stage
return self._run_train()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1311, in _run_train
self._run_sanity_check(self.lightning_module)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1375, in _run_sanity_check
self._evaluation_loop.run()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 110, in advance
dl_outputs = self.epoch_loop.run(dataloader, dataloader_idx, dl_max_batches, self.num_dataloaders)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 122, in advance
output = self._evaluation_step(batch, batch_idx, dataloader_idx)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 217, in _evaluation_step
output = self.trainer.accelerator.validation_step(step_kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 236, in validation_step
return self.training_type_plugin.validation_step(*step_kwargs.values())
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 444, in validation_step
return self.model(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 886, in forward
output = self.module(*inputs[0], **kwargs[0])
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/overrides/base.py", line 92, in forward
output = self.module.validation_step(*inputs, **kwargs)
File "/root/NeMo/nemo/collections/tts/models/hifigan.py", line 226, in validation_step
audio, audio_len, audio_mel = batch
ValueError: not enough values to unpack (expected 3, got 2)
```
**Steps/Code to reproduce bug**
Generate the mel files according to the notebook and run `python examples/tts/hifigan_finetune.py --config_name=hifigan.yaml model.train_ds.dataloader_params.batch_size=32 model.max_steps=1000 ~model.sched model.optim.lr=0.0001 train_dataset=./hifigan_train_ft.json validation_datasets=./hifigan_val_ft.json exp_manager.exp_dir=hifigan_ft +init_from_nemo_model=tts_hifigan.nemo trainer.check_val_every_n_epoch=10 model/train_ds=train_ds_finetune`
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- Environment location: Cloud: [AutoDL](https://www.autodl.com/)
- Method of NeMo install: From source, `git clone` and `pip install .[tts]`
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
PyTorch 1.10.0, Python 3.8, Cuda 11.3
**Additional context**
Add any other context about the problem here.
GPU: RTX 3090 * 2
VRAM: 24GB
CPU: 30 Cores AMD EPYC 7543 32-Core Processor
RAM: 160GB | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3628/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3628/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3627 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3627/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3627/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3627/events | https://github.com/NVIDIA/NeMo/issues/3627 | 1,127,049,718 | I_kwDOC_bI7s5DLWn2 | 3,627 | FastPitch fine-tunning using TDataset | {
"login": "mabajec",
"id": 16853936,
"node_id": "MDQ6VXNlcjE2ODUzOTM2",
"avatar_url": "https://avatars.githubusercontent.com/u/16853936?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mabajec",
"html_url": "https://github.com/mabajec",
"followers_url": "https://api.github.com/users/mabajec/followers",
"following_url": "https://api.github.com/users/mabajec/following{/other_user}",
"gists_url": "https://api.github.com/users/mabajec/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mabajec/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mabajec/subscriptions",
"organizations_url": "https://api.github.com/users/mabajec/orgs",
"repos_url": "https://api.github.com/users/mabajec/repos",
"events_url": "https://api.github.com/users/mabajec/events{/privacy}",
"received_events_url": "https://api.github.com/users/mabajec/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-08T10:15:00 | 2022-02-18T15:55:08 | 2022-02-18T15:55:08 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The tutorial on FastPitch fine-tunning (`NeMo/tutorials/tts/`) is based on the `fastpitch_align.yaml` and `AudioToCharWithPriorAndPitchDataset`, which will soon be deprecated. Is there any guidance how to finetune a pretrained FastPitch model based on the `fastpitch_align_v1.05.yaml` and thus `TDataset`? | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3627/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3627/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3626 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3626/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3626/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3626/events | https://github.com/NVIDIA/NeMo/pull/3626 | 1,126,808,389 | PR_kwDOC_bI7s4yNmsX | 3,626 | Remove compression from .nemo files | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-08T05:21:57 | 2022-02-08T17:16:13 | 2022-02-08T17:16:07 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3626",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3626",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3626.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3626.patch",
"merged_at": "2022-02-08T17:16:07"
} | # What does this PR do ?
This PR removes compression from .nemo files.
The compression is not desirable because:
* It takes awfully long to compress multi-billion parameter language models
* It does not actually save much space. For example a large CTC conformer uncompressed is 464Mb vs 431Mb compressed
This is a change to core save_to/restore_from functionality of all models.
**It is backwards compatible - older checkpoints (with compression) will still work**
# Usage
* Usage remains exactly the same.
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3626/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3626/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3625 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3625/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3625/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3625/events | https://github.com/NVIDIA/NeMo/pull/3625 | 1,126,686,779 | PR_kwDOC_bI7s4yNNrr | 3,625 | Remove @experimental decorator in diarization related files. | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-08T01:29:46 | 2022-02-08T10:16:51 | 2022-02-08T10:16:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3625",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3625",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3625.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3625.patch",
"merged_at": "2022-02-08T10:16:48"
} | Removes @experimental decorator in the diarization related files.
Signed-off-by: Taejin Park <[email protected]>
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3625/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3625/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3624 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3624/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3624/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3624/events | https://github.com/NVIDIA/NeMo/issues/3624 | 1,126,587,394 | I_kwDOC_bI7s5DJlwC | 3,624 | Please document whether NEMO file contains best or last CKPT file | {
"login": "catskillsresearch",
"id": 38082822,
"node_id": "MDQ6VXNlcjM4MDgyODIy",
"avatar_url": "https://avatars.githubusercontent.com/u/38082822?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/catskillsresearch",
"html_url": "https://github.com/catskillsresearch",
"followers_url": "https://api.github.com/users/catskillsresearch/followers",
"following_url": "https://api.github.com/users/catskillsresearch/following{/other_user}",
"gists_url": "https://api.github.com/users/catskillsresearch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/catskillsresearch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catskillsresearch/subscriptions",
"organizations_url": "https://api.github.com/users/catskillsresearch/orgs",
"repos_url": "https://api.github.com/users/catskillsresearch/repos",
"events_url": "https://api.github.com/users/catskillsresearch/events{/privacy}",
"received_events_url": "https://api.github.com/users/catskillsresearch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-07T22:51:47 | 2022-02-18T04:23:23 | 2022-02-18T04:23:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
With the following YAML:
```
exp_manager:
exp_dir: null
name: ContextNet-8x-Stride-RNNT
create_tensorboard_logger: true
create_checkpoint_callback: true
checkpoint_callback_params:
monitor: val_wer
mode: min
save_top_k: 3
always_save_nemo: true
create_wandb_logger: false
wandb_logger_kwargs:
name: null
project: null
entity: null
resume_if_exists: false
resume_ignore_no_checkpoint: false
```
NeMo saves both .ckpt files and a .nemo file.
It is not 100% clear whether the best .CKPT file is what is used to save the .NEMO file, or whether the last .CKPT is used.
I'm guessing from a perusal of [exp_manager.py](https://github.com/NVIDIA/NeMo/blob/ddcc2a6c4eabc74b6b5021da05ff67d6d38ccf68/nemo/utils/exp_manager.py) that it saves the best model as the .NEMO file, but I can't say for sure by looking at the code.
[This document ](https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/core/core.html#experiment-manager)is not clear and doesn't seem to mention all the keywords I see in the Python code.
**Describe the solution you'd like**
Please update the documentation to include all keywords related to exp_manager.py and which states clearly whether the best CKPT or last CKPT is saved in the training run's NEMO file.
**Hmmm**
I'm trying to verify this by comparing an element of the state dict of each of the CKPT files with the same element from the NEMO file and **none** of the CKPTs matches the NEMO file. Is this to be expected? So running
```
from glob import glob
ckpts=glob('./nemo_experiments/ContextNet-8x-Stride-RNNT/2022-02-07_18-13-37/checkpoints/*.ckpt')
model.restore_from('./nemo_experiments/ContextNet-8x-Stride-RNNT/2022-02-07_18-13-37/checkpoints/ContextNet-8x-Stride-RNNT.nemo')
sd1=model.state_dict();
for ckpt in ckpts:
print("=====================================================\n\n\n")
model2.load_from_checkpoint(ckpt);
sd2=model2.state_dict();
print(ckpt)
print('NEMO')
print(sd1['encoder.encoder.0.mconv.0.conv.weight'][0:3])
print('CKPT')
print(sd2['encoder.encoder.0.mconv.0.conv.weight'][0:3])
```
gives me (after deleting all the logging noise from NeMo):
```
./nemo_experiments/ContextNet-8x-Stride-RNNT/2022-02-07_18-13-37/checkpoints/ContextNet-8x-Stride-RNNT--val_wer=0.1228-epoch=1.ckpt
NEMO
tensor([[[-0.3809, -0.0407, 0.5199, 0.0178, -0.8887]],
[[-0.0082, -0.7741, 0.4612, -0.2517, -0.0893]],
[[-0.2904, -0.7611, -0.0239, 0.3230, 0.4082]]])
CKPT
tensor([[[ 0.2958, -0.5322, -0.6329, 0.0123, 0.5627]],
[[ 0.2680, 0.1954, 0.4858, 0.1461, -0.7119]],
[[ 0.7032, 0.3157, -0.5824, -0.7284, -0.6969]]])
=====================================================
./nemo_experiments/ContextNet-8x-Stride-RNNT/2022-02-07_18-13-37/checkpoints/ContextNet-8x-Stride-RNNT--val_wer=0.1735-epoch=19-last.ckpt
NEMO
tensor([[[-0.3809, -0.0407, 0.5199, 0.0178, -0.8887]],
[[-0.0082, -0.7741, 0.4612, -0.2517, -0.0893]],
[[-0.2904, -0.7611, -0.0239, 0.3230, 0.4082]]])
CKPT
tensor([[[ 0.2958, -0.5322, -0.6329, 0.0123, 0.5627]],
[[ 0.2680, 0.1954, 0.4858, 0.1461, -0.7119]],
[[ 0.7032, 0.3157, -0.5824, -0.7284, -0.6969]]])
=====================================================
./nemo_experiments/ContextNet-8x-Stride-RNNT/2022-02-07_18-13-37/checkpoints/ContextNet-8x-Stride-RNNT--val_wer=0.1306-epoch=0.ckpt
NEMO
tensor([[[-0.3809, -0.0407, 0.5199, 0.0178, -0.8887]],
[[-0.0082, -0.7741, 0.4612, -0.2517, -0.0893]],
[[-0.2904, -0.7611, -0.0239, 0.3230, 0.4082]]])
CKPT
tensor([[[ 0.2958, -0.5322, -0.6329, 0.0123, 0.5627]],
[[ 0.2680, 0.1954, 0.4858, 0.1461, -0.7119]],
[[ 0.7032, 0.3157, -0.5824, -0.7284, -0.6969]]])
=====================================================
./nemo_experiments/ContextNet-8x-Stride-RNNT/2022-02-07_18-13-37/checkpoints/ContextNet-8x-Stride-RNNT--val_wer=0.1365-epoch=2.ckpt
NEMO
tensor([[[-0.3809, -0.0407, 0.5199, 0.0178, -0.8887]],
[[-0.0082, -0.7741, 0.4612, -0.2517, -0.0893]],
[[-0.2904, -0.7611, -0.0239, 0.3230, 0.4082]]])
CKPT
tensor([[[ 0.2958, -0.5322, -0.6329, 0.0123, 0.5627]],
[[ 0.2680, 0.1954, 0.4858, 0.1461, -0.7119]],
[[ 0.7032, 0.3157, -0.5824, -0.7284, -0.6969]]])
Also a little odd that all of the CKPTs for this element are the same.
**PPS**
If I just run EVAL but not TRAIN on the best CKPT and the NEMO file, they come out the same, so even the weights under the hood aren't the same, I guess they are the same model. It would be nice to know why the weights above are different though. | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3624/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3624/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3623 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3623/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3623/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3623/events | https://github.com/NVIDIA/NeMo/pull/3623 | 1,126,555,295 | PR_kwDOC_bI7s4yMyfi | 3,623 | Generalized the P-tuning method to support various NLP tasks | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-07T22:10:26 | 2022-02-14T18:23:38 | 2022-02-14T18:23:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3623",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3623",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3623.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3623.patch",
"merged_at": "2022-02-14T18:23:35"
} | # What does this PR do ?
It generalizes the P-tuning method to support various NLP tasks including text-cls, NER, text summation, Q/A etc. It supports multiple task with one prompt encoder model. It also includes a tutorial notebook to show how to use it.
# Changelog
- Added the decoder for the p-tuning model so it can generate any length of text.
- The prompt encoder can be conditioned on the task-tags, so it supports multiple tasks simultaneously.
- Added the p-tune dataset. The user just need to write their own data processor to generate customized prompts for different tasks.
# Usage
Check the notebook `https://github.com/NVIDIA/NeMo/blob/generalized_gpt_ptuning/tutorials/nlp/PTune_multiple_NLP_tasks.ipynb`
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3623/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3623/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3622 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3622/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3622/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3622/events | https://github.com/NVIDIA/NeMo/pull/3622 | 1,126,540,469 | PR_kwDOC_bI7s4yMvea | 3,622 | Improve docs for finetuning | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-07T21:54:08 | 2022-02-07T21:54:19 | 2022-02-07T21:54:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3622",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3622",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3622.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3622.patch",
"merged_at": "2022-02-07T21:54:16"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Updates the documentation for fine-tuning an ASR model.
**Collection**: [Docs]
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3622/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3622/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3621 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3621/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3621/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3621/events | https://github.com/NVIDIA/NeMo/pull/3621 | 1,126,521,524 | PR_kwDOC_bI7s4yMrg6 | 3,621 | WIP: Megatron t0 | {
"login": "jpilaul",
"id": 614861,
"node_id": "MDQ6VXNlcjYxNDg2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/614861?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jpilaul",
"html_url": "https://github.com/jpilaul",
"followers_url": "https://api.github.com/users/jpilaul/followers",
"following_url": "https://api.github.com/users/jpilaul/following{/other_user}",
"gists_url": "https://api.github.com/users/jpilaul/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jpilaul/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jpilaul/subscriptions",
"organizations_url": "https://api.github.com/users/jpilaul/orgs",
"repos_url": "https://api.github.com/users/jpilaul/repos",
"events_url": "https://api.github.com/users/jpilaul/events{/privacy}",
"received_events_url": "https://api.github.com/users/jpilaul/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "jpilaul",
"id": 614861,
"node_id": "MDQ6VXNlcjYxNDg2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/614861?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jpilaul",
"html_url": "https://github.com/jpilaul",
"followers_url": "https://api.github.com/users/jpilaul/followers",
"following_url": "https://api.github.com/users/jpilaul/following{/other_user}",
"gists_url": "https://api.github.com/users/jpilaul/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jpilaul/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jpilaul/subscriptions",
"organizations_url": "https://api.github.com/users/jpilaul/orgs",
"repos_url": "https://api.github.com/users/jpilaul/repos",
"events_url": "https://api.github.com/users/jpilaul/events{/privacy}",
"received_events_url": "https://api.github.com/users/jpilaul/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "jpilaul",
"id": 614861,
"node_id": "MDQ6VXNlcjYxNDg2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/614861?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jpilaul",
"html_url": "https://github.com/jpilaul",
"followers_url": "https://api.github.com/users/jpilaul/followers",
"following_url": "https://api.github.com/users/jpilaul/following{/other_user}",
"gists_url": "https://api.github.com/users/jpilaul/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jpilaul/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jpilaul/subscriptions",
"organizations_url": "https://api.github.com/users/jpilaul/orgs",
"repos_url": "https://api.github.com/users/jpilaul/repos",
"events_url": "https://api.github.com/users/jpilaul/events{/privacy}",
"received_events_url": "https://api.github.com/users/jpilaul/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-07T21:32:07 | 2022-02-07T21:45:35 | 2022-02-07T21:44:32 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3621",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3621",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3621.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3621.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jpilaul",
"id": 614861,
"node_id": "MDQ6VXNlcjYxNDg2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/614861?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jpilaul",
"html_url": "https://github.com/jpilaul",
"followers_url": "https://api.github.com/users/jpilaul/followers",
"following_url": "https://api.github.com/users/jpilaul/following{/other_user}",
"gists_url": "https://api.github.com/users/jpilaul/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jpilaul/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jpilaul/subscriptions",
"organizations_url": "https://api.github.com/users/jpilaul/orgs",
"repos_url": "https://api.github.com/users/jpilaul/repos",
"events_url": "https://api.github.com/users/jpilaul/events{/privacy}",
"received_events_url": "https://api.github.com/users/jpilaul/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3621/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3621/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3620 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3620/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3620/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3620/events | https://github.com/NVIDIA/NeMo/issues/3620 | 1,125,496,894 | I_kwDOC_bI7s5DFbg- | 3,620 | CUDA error: an illegal memory access was encountered when training fastpitch | {
"login": "godspirit00",
"id": 16176151,
"node_id": "MDQ6VXNlcjE2MTc2MTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/16176151?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/godspirit00",
"html_url": "https://github.com/godspirit00",
"followers_url": "https://api.github.com/users/godspirit00/followers",
"following_url": "https://api.github.com/users/godspirit00/following{/other_user}",
"gists_url": "https://api.github.com/users/godspirit00/gists{/gist_id}",
"starred_url": "https://api.github.com/users/godspirit00/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/godspirit00/subscriptions",
"organizations_url": "https://api.github.com/users/godspirit00/orgs",
"repos_url": "https://api.github.com/users/godspirit00/repos",
"events_url": "https://api.github.com/users/godspirit00/events{/privacy}",
"received_events_url": "https://api.github.com/users/godspirit00/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-07T04:31:00 | 2022-02-18T15:55:53 | 2022-02-18T15:55:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When I tried to train / finetune FastPitch, the following error shows up:
```
Traceback (most recent call last):
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 685, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 777, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1199, in _run
self._dispatch()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1279, in _dispatch
self.training_type_plugin.start_training(self)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 202, in start_training
self._results = trainer.run_stage()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1289, in run_stage
return self._run_train()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1319, in _run_train
self.fit_loop.run()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/fit_loop.py", line 234, in advance
self.epoch_loop.run(data_fetcher)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 193, in advance
batch_output = self.batch_loop.run(batch, batch_idx)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/batch/training_batch_loop.py", line 88, in advance
outputs = self.optimizer_loop.run(split_batch, optimizers, batch_idx)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 215, in advance
result = self._run_optimization(
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 277, in _run_optimization
self.trainer.fit_loop.epoch_loop.batch_loop._update_running_loss(result.loss)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/batch/training_batch_loop.py", line 127, in _update_running_loss
self.accumulated_loss.append(current_loss)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py", line 78, in append
x = x.to(self.memory)
RuntimeError: CUDA error: an illegal memory access was encountered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "examples/tts/fastpitch_finetune.py", line 37, in main
trainer.fit(model)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 740, in fit
self._call_and_handle_interrupt(
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 698, in _call_and_handle_interrupt
self.training_type_plugin.reconciliate_processes(traceback.format_exc())
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 533, in reconciliate_processes
raise DeadlockDetectedException(f"DeadLock detected from rank: {self.global_rank} \n {trace}")
pytorch_lightning.utilities.exceptions.DeadlockDetectedException: DeadLock detected from rank: 0
Traceback (most recent call last):
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 685, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 777, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1199, in _run
self._dispatch()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1279, in _dispatch
self.training_type_plugin.start_training(self)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 202, in start_training
self._results = trainer.run_stage()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1289, in run_stage
return self._run_train()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1319, in _run_train
self.fit_loop.run()
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/fit_loop.py", line 234, in advance
self.epoch_loop.run(data_fetcher)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 193, in advance
batch_output = self.batch_loop.run(batch, batch_idx)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/batch/training_batch_loop.py", line 88, in advance
outputs = self.optimizer_loop.run(split_batch, optimizers, batch_idx)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 145, in run
self.advance(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 215, in advance
result = self._run_optimization(
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/optimization/optimizer_loop.py", line 277, in _run_optimization
self.trainer.fit_loop.epoch_loop.batch_loop._update_running_loss(result.loss)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/loops/batch/training_batch_loop.py", line 127, in _update_running_loss
self.accumulated_loss.append(current_loss)
File "/root/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/supporters.py", line 78, in append
x = x.to(self.memory)
RuntimeError: CUDA error: an illegal memory access was encountered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
```
**Steps/Code to reproduce bug**
I tried to train a FastPitch model on the Nancy Corpus, the above error showed up at first with the cmd: `examples/tts/fastpitch.py --config-name=fastpitch_align.yaml train_dataset=/root/autodl-tmp/nancy_train.json validation_datasets=/root/autodl-tmp/nancy_val.json prior_folder=/root/autodl-tmp/nemo-training/nancy_22k/prior exp_manager.exp_dir=/root/autodl-tmp/nemo-training/nancy_22k +exp_manager.resume_if_exists=True +exp_manager.resume_ignore_no_checkpoint=True model.train_ds.dataloader_params.batch_size=24 model.validation_ds.dataloader_params.batch_size=24`, then I changed the `exp_dir`
, it started training.
Then I tried to finetune the resulting model on my own dataset with cmd `python examples/tts/fastpitch_finetune.py --config-name=fastpitch_align.yaml train_dataset=/root/autodl-tmp/male-speakers--with--nancy_train.json validation_datasets=/root/autodl-tmp/male-speakers--with--nancy_val.json +init_from_nemo_model=/root/autodl-tmp/nemo-training/nancy_fastpitch.nemo prior_folder=/root/autodl-tmp/nemo-training/multi-males/prior_multi-males model.train_ds.dataloader_params.batch_size=24 model.validation_ds.dataloader_params.batch_size=24 exp_manager.exp_dir=/root/autodl-tmp/nemo-training/multi-males model.n_speakers=5 model.pitch_avg=121.9 model.pitch_std=37.1 model.pitch_fmin=30 model.pitch_fmax=512 model.optim.lr=2e-4 ~model.optim.sched`, the error showed up again, and this time changing `exp_dir` does not help.
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
- Environment location: Cloud: [AutoDL](https://www.autodl.com/)
- Method of NeMo install: From source, `git clone` and `pip install .[tts]`
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
PyTorch 1.10.0, Python 3.8, Cuda 11.3
**Additional context**
Add any other context about the problem here.
GPU: RTX 3090 * 2
VRAM: 24GB
CPU: 30 Cores AMD EPYC 7543 32-Core Processor
RAM: 160GB | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3620/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3620/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3619 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3619/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3619/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3619/events | https://github.com/NVIDIA/NeMo/issues/3619 | 1,125,310,731 | I_kwDOC_bI7s5DEuEL | 3,619 | nemo2riva tts_en_fastpitch fails if not using nemo:1.5.1 | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-06T20:37:25 | 2022-04-06T00:05:12 | 2022-04-06T00:05:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Bear with me, this is going to be a lengthy one :)
Riva: 1.8.0-beta
Nemo: 1.5.1, 1.6.2, head
Model: [tts_en_fastpitch_align.nemo](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/tts_en_fastpitch)
Related to #3613, could also be relevant for #3609, #3605 and #3567
Working example
- start off of `nvcr.io/nvidia/nemo:1.5.1`
- install the Riva toolset
- call `nemo2riva` to convert `tts_en_fastpitch_align.nemo` to `riva` format
Non working example 1:
- start off of `nvcr.io/nvidia/nemo:1.5.1`
- clone the NeMo repository, checkout tag `v1.6.2` or `1.7.0` and upgrade with `./reinstall.sh`
- install Riva toolset
- call `nemo2riva` to convert `tts_en_fastpitch_align.nemo` to `riva` format
crashes with
```
E0206 16:37:38.504896 140528981497664 cookbook.py:71] Export failed. Please make sure your NeMo model class (nemo.collections.tts.models.fastpitch.FastPitchModel) has working export() and that you have the latest NeMo package installed with [all] dependencies.
Traceback (most recent call last):
File "/opt/conda/bin/nemo2riva", line 8, in <module>
sys.exit(nemo2riva())
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/cli/nemo2riva.py", line 50, in nemo2riva
Nemo2Riva(args)
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/convert.py", line 65, in Nemo2Riva
save_archive(obj=model, save_path=riva_out, cfg=cfg, artifacts=artifacts, metadata=manifest['metadata'])
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/cookbook.py", line 76, in save_archive
raise e
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/cookbook.py", line 69, in save_archive
_, descriptions = obj.export(export_file, check_trace=cfg.args.runtime_check)
File "/opt/conda/lib/python3.8/site-packages/nemo/core/classes/exportable.py", line 179, in export
output_example = tuple(self.forward(*input_list, **input_dict))
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/models/fastpitch.py", line 497, in forward_for_export
return self.fastpitch.infer(text=text, pitch=pitch, pace=pace, speaker=speaker)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/modules/fastpitch.py", line 300, in infer
dec_out, _ = self.decoder(input=len_regulated, seq_lens=dec_lens)
File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
return forward_call(*input, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/modules/transformer.py", line 215, in forward
return self._forward(input, mask_from_lens(seq_lens).unsqueeze(2), conditioning)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/modules/transformer.py", line 223, in _forward
out = layer(out, mask=mask)
File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
return forward_call(*input, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/modules/transformer.py", line 171, in forward
output = self.dec_attn(dec_inp, attn_mask=~mask.squeeze(2))
File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
return forward_call(*input, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/modules/transformer.py", line 113, in forward
return self._forward(inp, attn_mask)
File "/opt/conda/lib/python3.8/site-packages/nemo/collections/tts/modules/transformer.py", line 142, in _forward
attn_prob = F.softmax(attn_score, dim=2)
File "/opt/conda/lib/python3.8/site-packages/torch/nn/functional.py", line 1779, in softmax
ret = input.softmax(dim)
RuntimeError: CUDA out of memory. Tried to allocate 9.30 GiB (GPU 0; 15.78 GiB total capacity; 12.18 GiB already allocated; 2.05 GiB free; 12.30 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation. See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
```
Non working example 2:
- clone the NeMo repository, checkout tag `v1.6.2`
- use nemo Dockerfile to create container
- install Riva toolset in container
- call `nemo2riva` to convert `tts_en_fastpitch_align.nemo` to `riva` format
crashes with the same error as example 1
Non working example 3:
- clone the NeMo repository
- use nemo Dockerfile to create container from head (as a difference to previous examples this time the container is based on pytorch:22.01)
- install Riva toolset in container (requires an upgrade to Numba=0.55)
- call `nemo2riva` to convert `tts_en_fastpitch_align.nemo` to `riva` format
crashes with
```
/opt/conda/lib/python3.8/site-packages/torch/_masked/__init__.py:223: UserWarning: Failed to initialize NumPy: module compiled against API version 0xf but this version of numpy is 0xe (Triggered internally at /opt/pytorch/pytorch/torch/csrc/utils/tensor_numpy.cpp:68.)
example_input = torch.tensor([[-3, -2, -1], [0, 1, 2]])
Traceback (most recent call last):
File "/opt/conda/bin/nemo2riva", line 5, in <module>
from nemo2riva.cli import nemo2riva
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/__init__.py", line 12, in <module>
from nemo2riva.convert import Nemo2Riva
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/convert.py", line 18, in <module>
from nemo2riva.cookbook import save_archive
File "/opt/conda/lib/python3.8/site-packages/nemo2riva/cookbook.py", line 10, in <module>
from nemo.core import Exportable, ModelPT
File "/opt/conda/lib/python3.8/site-packages/nemo/core/__init__.py", line 16, in <module>
from nemo.core.classes import *
File "/opt/conda/lib/python3.8/site-packages/nemo/core/classes/__init__.py", line 18, in <module>
import pytorch_lightning
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/__init__.py", line 20, in <module>
from pytorch_lightning.callbacks import Callback # noqa: E402
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/callbacks/__init__.py", line 14, in <module>
from pytorch_lightning.callbacks.base import Callback
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/callbacks/base.py", line 26, in <module>
from pytorch_lightning.utilities.types import STEP_OUTPUT
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/utilities/types.py", line 25, in <module>
from torchmetrics import Metric
File "/opt/conda/lib/python3.8/site-packages/torchmetrics/__init__.py", line 14, in <module>
from torchmetrics import functional # noqa: E402
File "/opt/conda/lib/python3.8/site-packages/torchmetrics/functional/__init__.py", line 14, in <module>
from torchmetrics.functional.audio.pit import permutation_invariant_training, pit, pit_permutate
File "/opt/conda/lib/python3.8/site-packages/torchmetrics/functional/audio/__init__.py", line 26, in <module>
from torchmetrics.functional.audio.pesq import perceptual_evaluation_speech_quality # noqa: F401
File "/opt/conda/lib/python3.8/site-packages/torchmetrics/functional/audio/pesq.py", line 20, in <module>
import pesq as pesq_backend
File "/opt/conda/lib/python3.8/site-packages/pesq/__init__.py", line 6, in <module>
from .cypesq import cypesq, cypesq_retvals, cypesq_error_message as pesq_error_message
File "pesq/cypesq.pyx", line 1, in init cypesq
ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
```
Googling for the UserWarning leads to https://github.com/numba/numba/issues/7754, but the installed numpy is 1.21.5.
What is behind all this ... We added support to `fastpitch.py` (based on the soon to be deprecated `fastpitch_align.yml` not `1.05`) for a non-English language that we are working with. Our starting point was `NeMo:1.6.0`, but after finishing and successfully training a model we discovered that if we want to deploy it using Riva, we first have to back port all of our changes. Since the old `yml` will become deprecated only in `NeMo:1.8.0`, it perhaps should still be supported for conversion to riva format.
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3619/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3619/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3617 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3617/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3617/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3617/events | https://github.com/NVIDIA/NeMo/issues/3617 | 1,125,220,497 | I_kwDOC_bI7s5DEYCR | 3,617 | Question: validation_ds for En Conformer-CTC Small LibriSpeech configuration. | {
"login": "june-oh",
"id": 58967612,
"node_id": "MDQ6VXNlcjU4OTY3NjEy",
"avatar_url": "https://avatars.githubusercontent.com/u/58967612?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/june-oh",
"html_url": "https://github.com/june-oh",
"followers_url": "https://api.github.com/users/june-oh/followers",
"following_url": "https://api.github.com/users/june-oh/following{/other_user}",
"gists_url": "https://api.github.com/users/june-oh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/june-oh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/june-oh/subscriptions",
"organizations_url": "https://api.github.com/users/june-oh/orgs",
"repos_url": "https://api.github.com/users/june-oh/repos",
"events_url": "https://api.github.com/users/june-oh/events{/privacy}",
"received_events_url": "https://api.github.com/users/june-oh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-06T14:38:55 | 2022-02-07T04:25:27 | 2022-02-07T04:25:27 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | this is a question about the pre-trained [model](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_conformer_ctc_small_ls).
I downloaded the model and used the following command to check the training-related conf.
```
import nemo.collections.asr as nemo_asr
asr_model = nemo_asr.models.EncDecCTCModelBPE.from_pretrained(model_name="<path_of_pretrained_model>")
asr_model._cfg
```
And I checked the following.
>{'sample_rate': 16000, 'log_prediction': True, 'ctc_reduction': 'mean_batch', 'train_ds': {'manifest_filepath': '/data/Librispeech_SP_Tarred/tarred_audio_manifest.json', 'sample_rate': 16000, 'batch_size': 32, 'shuffle': True, 'num_workers': 8, 'pin_memory': True, 'use_start_end_token': False, 'trim_silence': False, 'max_duration': 16.7, 'min_duration': 0.1, 'shuffle_n': 2048, 'is_tarred': True, 'tarred_audio_filepaths': '/data/Librispeech_SP_Tarred/audio__OP_0..511_CL_.tar'}, 'validation_ds': {'manifest_filepath': ['/manifests/librispeech/librivox-dev-other.json', '/manifests/librispeech/librivox-dev-clean.json', '/manifests/librispeech/librivox-test-other.json', '/manifests/librispeech/librivox-test-clean.json'], 'sample_rate': 16000, 'batch_size': 32, 'shuffle': False, 'num_workers': 8, 'pin_memory': True, 'use_start_end_token': False, 'is_tarred': False, 'tarred_audio_filepaths': '/data/LibriSpeech/eval__OP_0..1023_CL_.tar'}, 'test_ds': {'manifest_filepath': ['/manifests/librispeech/librivox-dev-other.json', '/manifests/librispeech/librivox-dev-clean.json', '/manifests/librispeech/librivox-test-other.json', '/manifests/librispeech/librivox-test-clean.json'], 'sample_rate': 16000, 'batch_size': 32, 'shuffle': False, 'num_workers': 8, 'pin_memory': True, 'use_start_end_token': False, 'is_tarred': False, 'tarred_audio_filepaths': '/data/LibriSpeech/eval__OP_0..1023_CL_.tar'}, 'tokenizer': {'dir': '/tokenizers/librispeech/experimental/tokenizer_spe_unigram_v128_max0/', 'type': 'bpe'}, 'preprocessor': {'_target_': 'nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor', 'sample_rate': 16000, 'normalize': 'per_feature', 'window_size': 0.025, 'window_stride': 0.01, 'window': 'hann', 'features': 80, 'n_fft': 512, 'log': True, 'frame_splicing': 1, 'dither': 1e-05, 'pad_to': 0, 'pad_value': 0.0}, 'spec_augment': {'_target_': 'nemo.collections.asr.modules.SpectrogramAugmentation', 'freq_masks': 2, 'time_masks': 5, 'freq_width': 27, 'time_width': 0.05}, 'encoder': {'_target_': 'nemo.collections.asr.modules.ConformerEncoder', 'feat_in': 80, 'feat_out': -1, 'n_layers': 16, 'd_model': 176, 'subsampling': 'striding', 'subsampling_factor': 4, 'subsampling_conv_channels': 176, 'ff_expansion_factor': 4, 'self_attention_model': 'rel_pos', 'n_heads': 4, 'att_context_size': [-1, -1], 'xscaling': True, 'untie_biases': True, 'pos_emb_max_len': 5000, 'conv_kernel_size': 31, 'dropout': 0.1, 'dropout_emb': 0.0, 'dropout_att': 0.1}, 'decoder': {'_target_': 'nemo.collections.asr.modules.ConvASRDecoder', 'feat_in': 176, 'num_classes': 128, 'vocabulary': ['<unk>', 'e', 's', '▁', 't', 'a', 'o', 'i', '▁the', 'd', 'l', 'n', '▁a', 'm', 'y', 'u', '▁s', 'p', 'ed', 'c', '▁and', 're', '▁to', '▁of', 'r', 'w', 'ing', '▁w', 'h', '▁p', '▁c', 'er', 'f', 'k', 'ar', '▁in', '▁f', '▁b', 'g', 'an', 'in', '▁i', 'en', '▁he', 'le', '▁g', 'or', 'll', 'b', '▁be', 'ro', 'st', 'on', '▁d', 'v', 'ly', 'ce', 'ur', 'es', '▁that', '▁o', 'us', '▁was', '▁it', '▁th', 've', 'ch', 'un', 'al', '▁t', '▁ma', 'ri', '▁you', '▁on', 'ver', 'ent', '▁for', '▁re', 'ra', "'", '▁his', 'ir', 'ter', '▁with', '▁her', 'it', 'th', '▁mo', '▁me', '▁ha', '▁e', '▁as', 'tion', '▁had', '▁not', '▁no', '▁do', 'ther', '▁but', '▁st', '▁she', '▁is', 'igh', '▁ho', '▁lo', 'ng', '▁him', '▁an', 'ck', 'j', 'ugh', '▁de', '▁li', '▁mi', '▁la', '▁my', '▁con', '▁have', '▁this', '▁which', 'q', '▁up', '▁said', '▁from', '▁who', '▁ex', 'x', 'z']}, 'optim': {'name': 'adamw', 'lr': 5.0, 'betas': [0.9, 0.98], 'weight_decay': 0.001, 'sched': {'name': 'NoamAnnealing', 'd_model': 176, 'warmup_steps': 10000, 'warmup_ratio': None, 'min_lr': 1e-06}}, 'target': 'nemo.collections.asr.models.ctc_bpe_models.EncDecCTCModelBPE'},
I paid attention to the next part.
>'validation_ds': {'manifest_filepath': ['/manifests/librispeech/librivox-dev-other.json', '/manifests/librispeech/librivox-dev-clean.json', '/manifests/librispeech/librivox-test-other.json', '/manifests/librispeech/librivox-test-clean.json'],
Did you use data other than LS-dev for LS training?
Or, is it a default value of the model not used in real training? | {
"login": "june-oh",
"id": 58967612,
"node_id": "MDQ6VXNlcjU4OTY3NjEy",
"avatar_url": "https://avatars.githubusercontent.com/u/58967612?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/june-oh",
"html_url": "https://github.com/june-oh",
"followers_url": "https://api.github.com/users/june-oh/followers",
"following_url": "https://api.github.com/users/june-oh/following{/other_user}",
"gists_url": "https://api.github.com/users/june-oh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/june-oh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/june-oh/subscriptions",
"organizations_url": "https://api.github.com/users/june-oh/orgs",
"repos_url": "https://api.github.com/users/june-oh/repos",
"events_url": "https://api.github.com/users/june-oh/events{/privacy}",
"received_events_url": "https://api.github.com/users/june-oh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3617/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3617/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3616 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3616/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3616/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3616/events | https://github.com/NVIDIA/NeMo/pull/3616 | 1,125,167,909 | PR_kwDOC_bI7s4yIU6X | 3,616 | Clarifying documentation | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-06T10:44:57 | 2022-02-07T18:50:51 | 2022-02-07T18:50:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3616",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3616",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3616.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3616.patch",
"merged_at": "2022-02-07T18:50:50"
} | # What does this PR do ?
Updated Optimizers & schedulers documentation.
**Collection**: all
# Changelog
- minor fix to documentation
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #3549
Signed-off-by: Iztok Lebar Bajec [email protected]
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3616/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3616/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3615 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3615/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3615/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3615/events | https://github.com/NVIDIA/NeMo/pull/3615 | 1,125,156,748 | PR_kwDOC_bI7s4yIS0w | 3,615 | [TTS] Fix UnivNet LibriTTS pretrained location | {
"login": "m-toman",
"id": 9433378,
"node_id": "MDQ6VXNlcjk0MzMzNzg=",
"avatar_url": "https://avatars.githubusercontent.com/u/9433378?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/m-toman",
"html_url": "https://github.com/m-toman",
"followers_url": "https://api.github.com/users/m-toman/followers",
"following_url": "https://api.github.com/users/m-toman/following{/other_user}",
"gists_url": "https://api.github.com/users/m-toman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/m-toman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/m-toman/subscriptions",
"organizations_url": "https://api.github.com/users/m-toman/orgs",
"repos_url": "https://api.github.com/users/m-toman/repos",
"events_url": "https://api.github.com/users/m-toman/events{/privacy}",
"received_events_url": "https://api.github.com/users/m-toman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-06T09:50:05 | 2022-02-08T12:52:40 | 2022-02-08T12:52:33 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3615",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3615",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3615.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3615.patch",
"merged_at": "2022-02-08T12:52:32"
} | # What does this PR do ?
Mini-PR :) - Fixes the NGC location of the UnivNet LibriTTS pretrained model.
**Collection**: TTS
# Changelog
- Fixes the NGC location of the UnivNet LibriTTS pretrained model.
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [X] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [X] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
| {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3615/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3615/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3614 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3614/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3614/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3614/events | https://github.com/NVIDIA/NeMo/pull/3614 | 1,125,037,574 | PR_kwDOC_bI7s4yH8sM | 3,614 | Update numba if NVIDIA_PYTORCH_VERSION not correct | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-05T21:42:30 | 2022-02-08T10:15:43 | 2022-02-08T10:15:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3614",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3614",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3614.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3614.patch",
"merged_at": "2022-02-08T10:15:43"
} | Update/install numba if `NVIDIA_PYTORCH_VERSION` is not equal to the one in `Dockerfile`. Resolves #3613
Signed-off-by: Iztok Lebar Bajec <[email protected]>
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3614/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3614/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3613 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3613/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3613/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3613/events | https://github.com/NVIDIA/NeMo/issues/3613 | 1,125,014,705 | I_kwDOC_bI7s5DDlyx | 3,613 | ./reinstall.sh crashes due to not being able to uninstall llvmlite | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-05T19:42:07 | 2022-02-08T10:15:43 | 2022-02-08T10:15:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Starting off of `nemo:1.5.1` container, cloning the NeMo repo to a folder inside of it and calling `./reinstall.sh` fails with
```
ERROR: Cannot uninstall 'llvmlite'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
```
`pip install -e` on the other hand succeeds installing `nemo:1.7.0rc0` and `numpy:1.22.2`, the rest of the packages remain untouched.
It seems that `./reinstall.sh` which used to work fine, a week or so ago when following the same procedure to upgrade to `nemo:1.6.0rc` redeveloped issue #841. The solution remains the same, first call
```
pip install --ignore-installed llvmlite
```
followed by `./reinstall.sh`. In this case, apart `llvml`, the following packages are updated
```
ftfy-6.0.3 nemo-toolkit-1.7.0rc0 numba-0.55.1 pytorch-lightning-1.5.9 sacrebleu-2.0.0 setuptools-59.5.0
```
Interestingly `numpy` in this case is left at `1.21.5`. | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3613/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3613/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3612 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3612/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3612/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3612/events | https://github.com/NVIDIA/NeMo/issues/3612 | 1,124,907,000 | I_kwDOC_bI7s5DDLf4 | 3,612 | using NGC containers [ NeMo/Riva] there is no nemo2riva | {
"login": "AndreV84",
"id": 16374873,
"node_id": "MDQ6VXNlcjE2Mzc0ODcz",
"avatar_url": "https://avatars.githubusercontent.com/u/16374873?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AndreV84",
"html_url": "https://github.com/AndreV84",
"followers_url": "https://api.github.com/users/AndreV84/followers",
"following_url": "https://api.github.com/users/AndreV84/following{/other_user}",
"gists_url": "https://api.github.com/users/AndreV84/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AndreV84/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AndreV84/subscriptions",
"organizations_url": "https://api.github.com/users/AndreV84/orgs",
"repos_url": "https://api.github.com/users/AndreV84/repos",
"events_url": "https://api.github.com/users/AndreV84/events{/privacy}",
"received_events_url": "https://api.github.com/users/AndreV84/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-05T11:35:04 | 2022-02-05T11:48:48 | 2022-02-05T11:48:48 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | ```
docker run --runtime=nvidia -it --rm -v --shm-size=16g -p 8888:8888 -p 6006:6006 --ulimit memlock=-1 --ulimit stack=67108864 nvcr.io/nvidia/nemo:1.5.1
```
```
oot@adbd9847582b:/workspace/nemo# pip3 install nvidia-pyindex
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Requirement already satisfied: nvidia-pyindex in /opt/conda/lib/python3.8/site-packages (1.0.9)
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
root@adbd9847582b:/workspace/nemo# pip3 install nemo2riva
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
ERROR: Could not find a version that satisfies the requirement nemo2riva (from versions: none)
ERROR: No matching distribution found for nemo2riva
root@adbd9847582b:/workspace/nemo# pip3 install nemo2riva-1.9.0-beta-py3-none-any.whl
WARNING: Requirement 'nemo2riva-1.9.0-beta-py3-none-any.whl' looks like a filename, but the file does not exist
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
ERROR: nemo2riva-1.9.0-beta-py3-none-any.whl is not a supported wheel on this platform.
```
where do I get the tool?
Also tried with
```
nvcr.io/nvidia/riva/riva-speech:1.8.0-beta-server
``` | {
"login": "AndreV84",
"id": 16374873,
"node_id": "MDQ6VXNlcjE2Mzc0ODcz",
"avatar_url": "https://avatars.githubusercontent.com/u/16374873?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AndreV84",
"html_url": "https://github.com/AndreV84",
"followers_url": "https://api.github.com/users/AndreV84/followers",
"following_url": "https://api.github.com/users/AndreV84/following{/other_user}",
"gists_url": "https://api.github.com/users/AndreV84/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AndreV84/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AndreV84/subscriptions",
"organizations_url": "https://api.github.com/users/AndreV84/orgs",
"repos_url": "https://api.github.com/users/AndreV84/repos",
"events_url": "https://api.github.com/users/AndreV84/events{/privacy}",
"received_events_url": "https://api.github.com/users/AndreV84/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3612/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3612/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3611 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3611/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3611/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3611/events | https://github.com/NVIDIA/NeMo/pull/3611 | 1,124,857,678 | PR_kwDOC_bI7s4yHcew | 3,611 | Update branch in notebooks to main | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-05T07:12:56 | 2022-02-05T07:13:23 | 2022-02-05T07:13:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3611",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3611",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3611.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3611.patch",
"merged_at": "2022-02-05T07:13:20"
} | Signed-off-by: ericharper <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3611/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3611/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3610 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3610/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3610/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3610/events | https://github.com/NVIDIA/NeMo/pull/3610 | 1,124,705,955 | PR_kwDOC_bI7s4yG-Jj | 3,610 | Fix wheel build | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-04T23:31:04 | 2022-02-05T01:47:19 | 2022-02-05T01:07:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3610",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3610",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3610.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3610.patch",
"merged_at": "2022-02-05T01:07:19"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Fix wheel build with new syntax.
**Collection**: [Bugfix]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3610/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3610/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3609 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3609/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3609/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3609/events | https://github.com/NVIDIA/NeMo/pull/3609 | 1,124,541,814 | PR_kwDOC_bI7s4yGcDY | 3,609 | fix failing tests inside of the 22.01 container in PR 3571 | {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-04T19:27:17 | 2022-02-17T01:31:07 | 2022-02-17T01:31:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3609",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3609",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3609.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3609.patch",
"merged_at": "2022-02-17T01:31:01"
} | Signed-off-by: fayejf <[email protected]>
# What does this PR do ?
Reproduce and fix failing tests inside of the 22.01 container in [PR 3571 ](https://github.com/NVIDIA/NeMo/pull/3571)
**Collection**: ASR label dataloader and tarred label dataset
# Changelog
- Fix failing tests due to 22.01 container upgrade
# Usage
* You can potentially add a usage example below
None
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to [# (issue in PR 3571 )](https://github.com/NVIDIA/NeMo/pull/3571)
| {
"login": "fayejf",
"id": 36722593,
"node_id": "MDQ6VXNlcjM2NzIyNTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fayejf",
"html_url": "https://github.com/fayejf",
"followers_url": "https://api.github.com/users/fayejf/followers",
"following_url": "https://api.github.com/users/fayejf/following{/other_user}",
"gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fayejf/subscriptions",
"organizations_url": "https://api.github.com/users/fayejf/orgs",
"repos_url": "https://api.github.com/users/fayejf/repos",
"events_url": "https://api.github.com/users/fayejf/events{/privacy}",
"received_events_url": "https://api.github.com/users/fayejf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3609/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3609/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3608 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3608/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3608/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3608/events | https://github.com/NVIDIA/NeMo/issues/3608 | 1,124,532,380 | I_kwDOC_bI7s5DBwCc | 3,608 | W&B Causing GPT3 Run to Crash | {
"login": "markelsanz14",
"id": 10426497,
"node_id": "MDQ6VXNlcjEwNDI2NDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/10426497?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/markelsanz14",
"html_url": "https://github.com/markelsanz14",
"followers_url": "https://api.github.com/users/markelsanz14/followers",
"following_url": "https://api.github.com/users/markelsanz14/following{/other_user}",
"gists_url": "https://api.github.com/users/markelsanz14/gists{/gist_id}",
"starred_url": "https://api.github.com/users/markelsanz14/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/markelsanz14/subscriptions",
"organizations_url": "https://api.github.com/users/markelsanz14/orgs",
"repos_url": "https://api.github.com/users/markelsanz14/repos",
"events_url": "https://api.github.com/users/markelsanz14/events{/privacy}",
"received_events_url": "https://api.github.com/users/markelsanz14/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-04T19:16:50 | 2022-09-01T21:47:34 | 2022-03-10T01:32:30 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Weights and Biases is causing some GPT-3 runs to fail. This seems to occur randomly. When launching multiple identical jobs, the first two can fail because of this and the third one works.
Traceback:
> Traceback (most recent call last):
File "/opt/conda/bin/wandb", line 8, in <module>
sys.exit(cli())
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1128, in __call__
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1053, in main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/wandb/cli/cli.py", line 86, in wrapper
return func(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/wandb/cli/cli.py", line 235, in login
wandb.login(relogin=relogin, key=key, anonymous=anon_mode, host=host, force=True)
File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_login.py", line 65, in login
configured = _login(**kwargs)
File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_login.py", line 268, in _login
wlogin.configure_api_key(key)
File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_login.py", line 154, in configure_api_key
apikey.write_key(self._settings, key)
File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/lib/apikey.py", line 223, in write_key
api.clear_setting("anonymous", globally=True, persist=True)
File "/opt/conda/lib/python3.8/site-packages/wandb/apis/internal.py", line 75, in clear_setting
return self.api.clear_setting(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/wandb/apis/internal.py", line 19, in api
self._api = InternalApi(*self._api_args, **self._api_kwargs)
File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/internal/internal_api.py", line 78, in __init__
self._settings = Settings(
File "/opt/conda/lib/python3.8/site-packages/wandb/old/settings.py", line 23, in __init__
self._global_settings.read([Settings._global_path()])
File "/opt/conda/lib/python3.8/configparser.py", line 697, in read
self._read(fp, filename)
File "/opt/conda/lib/python3.8/configparser.py", line 1082, in _read
raise MissingSectionHeaderError(fpname, lineno, line)
configparser.MissingSectionHeaderError: File contains no section headers.
file: '/root/.config/wandb/settings', line: 1
'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
wandb: Appending key for api.wandb.ai to your netrc file: /root/.netrc
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3608/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3608/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3607 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3607/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3607/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3607/events | https://github.com/NVIDIA/NeMo/pull/3607 | 1,124,519,087 | PR_kwDOC_bI7s4yGXPW | 3,607 | Add env variable to force transformers to run offline during CI | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-04T18:59:28 | 2022-02-04T20:18:22 | 2022-02-04T20:18:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3607",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3607",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3607.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3607.patch",
"merged_at": "2022-02-04T20:18:19"
} | # What does this PR do ?
Add env variable to force transformers to run offline during CI
**Collection**: [bugfix]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3607/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3607/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3606 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3606/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3606/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3606/events | https://github.com/NVIDIA/NeMo/issues/3606 | 1,124,487,063 | I_kwDOC_bI7s5DBk-X | 3,606 | nemo_asr grammar seems to be incorrect | {
"login": "burgil",
"id": 41600149,
"node_id": "MDQ6VXNlcjQxNjAwMTQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/41600149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/burgil",
"html_url": "https://github.com/burgil",
"followers_url": "https://api.github.com/users/burgil/followers",
"following_url": "https://api.github.com/users/burgil/following{/other_user}",
"gists_url": "https://api.github.com/users/burgil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/burgil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/burgil/subscriptions",
"organizations_url": "https://api.github.com/users/burgil/orgs",
"repos_url": "https://api.github.com/users/burgil/repos",
"events_url": "https://api.github.com/users/burgil/events{/privacy}",
"received_events_url": "https://api.github.com/users/burgil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-04T18:20:29 | 2022-02-04T23:19:23 | 2022-02-04T23:19:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
NeMo ASR grammar seems to be incorrect on any version except v1.4.0.
Besides the odd behavior with the grammar we can also notice that Punctuation takes much longer (100x~) in v1.4.0 compared to other versions that worked for my setup which leaves me with the only choice of using v1.4.0 for transcriptions and v1.6.0 for punctuation, eg:
```
NeMo Toolkit v1.4.0
Punctuation took: 13.06 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very like the old portrait."]
```
```
NeMo Toolkit v1.6.0
Punctuation took: 0.08 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
```
**Steps/Code to reproduce bug**
`pip install Cython`
```
pip install nemo_toolkit[all]==1.6.1
pip install nemo_toolkit[all]==1.6.0
pip install nemo_toolkit[all]==1.5.1
pip install nemo_toolkit[all]==1.4.0
```
I simply ran one of these every time I wanted to switch a version
**Expected behavior**
Let's inspect the debug log that I repeatedly tested multiple times on different versions of NeMo on the same wave file:
https://dldata-public.s3.us-east-2.amazonaws.com/2086-149220-0033.wav
If you will notice, only version 1.4.0 will get the word `like` right while all the others will sort of "make up" the word `likt` that doesn't really exists in any known dictionary, besides names, which I get the complexity of the manner, but am curios what "changed" or more like what got messed up so we can now see this behavior:
**NeMo Toolkit v1.4.0**
```
NeMo Toolkit v1.4.0
Init took: 27.58 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.14it/s]
Transcriptions took: 0.93 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very like the old portrait"]
Punctuation took: 13.77 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very like the old portrait."]
Everything took: 42.28 seconds
NeMo Toolkit v1.4.0
Init took: 29.06 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00, 1.15s/it]
Transcriptions took: 1.22 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very like the old portrait"]
Punctuation took: 12.90 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very like the old portrait."]
Everything took: 43.18 seconds
NeMo Toolkit v1.4.0
Init took: 28.26 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.29it/s]
Transcriptions took: 0.83 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very like the old portrait"]
Punctuation took: 12.20 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very like the old portrait."]
Everything took: 41.30 seconds
NeMo Toolkit v1.4.0
Init took: 27.88 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.16it/s]
Transcriptions took: 0.92 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very like the old portrait"]
Punctuation took: 13.06 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very like the old portrait."]
Everything took: 41.86 seconds
```
**NeMo Toolkit v1.5.1**
```
NeMo Toolkit v1.5.1
Init took: 24.72 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00, 1.00s/it]
Transcriptions took: 1.09 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 11.76batch/s]
Punctuation took: 0.10 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 25.91 seconds
NeMo Toolkit v1.5.1
Init took: 24.43 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.08it/s]
Transcriptions took: 1.01 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 11.36batch/s]
Punctuation took: 0.10 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 25.54 seconds
NeMo Toolkit v1.5.1
Init took: 24.63 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.06it/s]
Transcriptions took: 1.03 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 12.99batch/s]
Punctuation took: 0.09 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 25.76 seconds
NeMo Toolkit v1.5.1
Init took: 23.22 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.10it/s]
Transcriptions took: 0.99 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 14.29batch/s]
Punctuation took: 0.08 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 24.30 seconds
```
**NeMo Toolkit v1.6.0**
```
NeMo Toolkit v1.6.0
Init took: 22.43 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.27it/s]
Transcriptions took: 0.87 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 15.38batch/s]
Punctuation took: 0.07 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 23.37 seconds
NeMo Toolkit v1.6.0
Init took: 22.57 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.25it/s]
Transcriptions took: 0.88 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 15.38batch/s]
Punctuation took: 0.07 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 23.53 seconds
NeMo Toolkit v1.6.0
Init took: 22.14 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.22it/s]
Transcriptions took: 0.91 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 15.63batch/s]
Punctuation took: 0.07 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 23.12 seconds
NeMo Toolkit v1.6.0
Init took: 22.27 seconds
Transcribing: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 1.26it/s]
Transcriptions took: 0.88 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 15.15batch/s]
Punctuation took: 0.08 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 23.22 seconds
```
**NeMo Toolkit v1.6.1**
```
NeMo Toolkit v1.6.1
Init took: 37.51 seconds
Transcribing: 100%|██████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00, 1.30s/it]
Transcriptions took: 1.36 seconds
["well i don't wish to see it any more observed phoebe turning away her eyes it is certainly very likt the old portrait"]
100%|█████████████████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00, 1.54s/batch]
Punctuation took: 1.58 seconds
["Well, I don't wish to see it any more, observed Phoebe, turning away her eyes. It is certainly very likt the old portrait."]
Everything took: 40.45 seconds
```
**Environment overview**
- Environment location: Local
- Method of NeMo install: pip install. as can be seen above.
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: Latest
- PyTorch version: as required by each nemo package that I installed on a fresh machine using the commands above ^^
- Python version: 3.7.11 (also tested and got the same behavior on: 3.8.12 and 3.9.7)
- Python versions that didn't run it were: 2.7.18, 3.5.6, 3.6.13, 3.10.0
**Additional context**
I installed apex for cpu using:
```
pip install -v --disable-pip-version-check --no-cache-dir git+https://github.com/NVIDIA/apex
```
(TORCH_CUDA_ARCH_LIST="compute capability")
The following NeMo versions were not able to run at all using the same spec:
```
v1.3.0 and below (tested until v1.0.0)
v1.5.0
```
**Example Code:** (Fixed + added full snippet below)
```
import time
import nemo.collections.asr as nemo_asr
import nemo.collections.nlp as nemo_nlp
if __name__ == "__main__":
print("NeMo Toolkit vX.Y.Z")
start = time.time()
asr_model = nemo_asr.models.EncDecCTCModel.from_pretrained("stt_en_quartznet15x5")
punctuation = nemo_nlp.models.PunctuationCapitalizationModel.from_pretrained(model_name='punctuation_en_distilbert')
print("Init took: " + '%.2f' % (time.time() - start) + " seconds")
start = time.time()
transcriptions = asr_model.transcribe(['2086-149220-0033.wav'])
print("Transcription took: " + '%.2f' % (time.time() - start) + " seconds")
start = time.time()
res = punctuation.add_punctuation_capitalization(queries=transcriptions)
print("Punctuation took: " + '%.2f' % (time.time() - start) + " seconds")
print(transcriptions)
print(res)
``` | {
"login": "burgil",
"id": 41600149,
"node_id": "MDQ6VXNlcjQxNjAwMTQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/41600149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/burgil",
"html_url": "https://github.com/burgil",
"followers_url": "https://api.github.com/users/burgil/followers",
"following_url": "https://api.github.com/users/burgil/following{/other_user}",
"gists_url": "https://api.github.com/users/burgil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/burgil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/burgil/subscriptions",
"organizations_url": "https://api.github.com/users/burgil/orgs",
"repos_url": "https://api.github.com/users/burgil/repos",
"events_url": "https://api.github.com/users/burgil/events{/privacy}",
"received_events_url": "https://api.github.com/users/burgil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3606/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3606/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3605 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3605/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3605/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3605/events | https://github.com/NVIDIA/NeMo/pull/3605 | 1,124,484,886 | PR_kwDOC_bI7s4yGQFb | 3,605 | Add NeMo version to all new .nemo files | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-04T18:17:39 | 2022-02-08T03:23:09 | 2022-02-08T03:22:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3605",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3605",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3605.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3605.patch",
"merged_at": "2022-02-08T03:22:48"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Adds current nemo version to all nemo files generated.
# Note
The version will point to the *earliest* known version of NeMo that was compatible with this model. This does not preclude later versions being compatible/incompatible with the checkpoint, so it is up to the user to determine which version would work best, but it can be assumed that no version prior to the noted version will support the checkpoint.
**Collection**: [Core]
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3605/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3605/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3604 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3604/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3604/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3604/events | https://github.com/NVIDIA/NeMo/pull/3604 | 1,124,306,125 | PR_kwDOC_bI7s4yFrAX | 3,604 | Fix typo and update minimal version of scipy | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-04T15:08:33 | 2022-02-04T16:13:08 | 2022-02-04T16:13:05 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3604",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3604",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3604.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3604.patch",
"merged_at": "2022-02-04T16:13:05"
} | Signed-off-by: Oktai Tatanov <[email protected]>
**Collection**: [DOC]
# Changelog
- fix typo in README
- fix minimal version for SciPy (it is necessary to use `scipy.stats`
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3604/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3604/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3603 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3603/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3603/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3603/events | https://github.com/NVIDIA/NeMo/issues/3603 | 1,124,251,463 | I_kwDOC_bI7s5DArdH | 3,603 | Cannot run r1.6.1 fastpitch_finetune.ipynb from scratch using Colab | {
"login": "gedefet",
"id": 43994544,
"node_id": "MDQ6VXNlcjQzOTk0NTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/43994544?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gedefet",
"html_url": "https://github.com/gedefet",
"followers_url": "https://api.github.com/users/gedefet/followers",
"following_url": "https://api.github.com/users/gedefet/following{/other_user}",
"gists_url": "https://api.github.com/users/gedefet/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gedefet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gedefet/subscriptions",
"organizations_url": "https://api.github.com/users/gedefet/orgs",
"repos_url": "https://api.github.com/users/gedefet/repos",
"events_url": "https://api.github.com/users/gedefet/events{/privacy}",
"received_events_url": "https://api.github.com/users/gedefet/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-04T14:15:14 | 2022-02-16T16:23:25 | 2022-02-16T16:23:25 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Trying to run tts/tutorials/fastpitch_finetune.ipynb from Colab, the first cell give the following error:
`Collecting nemo_toolkit[tts]
Cloning https://github.com/NeMo/NeMo.git (to revision r1.6.1) to /tmp/pip-install-dikw_cg4/nemo-toolkit_dde310e4647c4385a9c5f59aa12c3537
Running command git clone -q https://github.com/NeMo/NeMo.git /tmp/pip-install-dikw_cg4/nemo-toolkit_dde310e4647c4385a9c5f59aa12c3537
fatal: could not read Username for 'https://github.com/': No such device or address
WARNING: Discarding git+https://github.com/NeMo/[email protected]#egg=nemo_toolkit[tts]. Command errored out with exit status 128: git clone -q https://github.com/NeMo/NeMo.git /tmp/pip-install-dikw_cg4/nemo-toolkit_dde310e4647c4385a9c5f59aa12c3537 Check the logs for full command output.
ERROR: Could not find a version that satisfies the requirement nemo-toolkit (unavailable) (from versions: 0.11.0b6.linux-x86_64, 0.8, 0.8.1, 0.8.2, 0.9.0, 0.10.0b0, 0.10.0b1, 0.10.0b2, 0.10.0b3, 0.10.0b4, 0.10.0b5, 0.10.0b6, 0.10.0b7, 0.10.0b8, 0.10.0b9, 0.10.0b10, 0.10.0, 0.10.1, 0.11.0b1, 0.11.0b2, 0.11.0b3, 0.11.0b4, 0.11.0b5, 0.11.0b8, 0.11.0b10, 0.11.0b11, 0.11.0b12, 0.11.0b14, 0.11.0, 1.0.0a4, 1.0.0b0, 1.0.0b1, 1.0.0b2, 1.0.0b3, 1.0.0rc1, 1.0.0, 1.0.1, 1.0.2, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.6.0, 1.6.1)
ERROR: No matching distribution found for nemo-toolkit (unavailable)`
In addition, I've been using fastpitch_finetune.ipynb with my own dataset since months ago (Branch Main), and now I cannot run it anymore **since 3 days ago**. It gives me an error when finetuning hifigan in line 32 (sorry for the long output):
`env: HYDRA_FULL_ERROR=1 [NeMo W 2022-02-04 14:08:27 optimizers:52] Apex was not found. Using the lamb or fused_adam optimizer will error out. ################################################################################ ### WARNING, path does not exist: KALDI_ROOT=/mnt/matylda5/iveselyk/Tools/kaldi-trunk ### (please add 'export KALDI_ROOT=<your_path>' in your $HOME/.profile) ### (or run as: KALDI_ROOT=<your_path> python <your_script>.py) ################################################################################ [NeMo W 2022-02-04 14:08:28 experimental:28] Module <function get_argmin_mat at 0x7f6324ecccb0> is experimental, not ready for production and is not fully supported. Use at your own risk. [NeMo W 2022-02-04 14:08:28 experimental:28] Module <function getMultiScaleCosAffinityMatrix at 0x7f6324eccd40> is experimental, not ready for production and is not fully supported. Use at your own risk. [NeMo W 2022-02-04 14:08:28 experimental:28] Module <function parse_scale_configs at 0x7f6324ecc950> is experimental, not ready for production and is not fully supported. Use at your own risk. [NeMo W 2022-02-04 14:08:28 experimental:28] Module <function get_embs_and_timestamps at 0x7f6324ecc290> is experimental, not ready for production and is not fully supported. Use at your own risk. [NeMo W 2022-02-04 14:08:28 nemo_logging:349] /usr/local/lib/python3.7/dist-packages/hydra/_internal/defaults_list.py:251: UserWarning: In 'hifigan.yaml': Defaults list is missing `_self_`. See https://hydra.cc/docs/upgrades/1.0_to_1.1/default_composition_order for more information warnings.warn(msg, UserWarning) Traceback (most recent call last): File "hifigan_finetune.py", line 32, in <module> main() # noqa pylint: disable=no-value-for-parameter File "/usr/local/lib/python3.7/dist-packages/nemo/core/config/hydra_runner.py", line 105, in wrapper config_name=config_name, File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/utils.py", line 378, in _run_hydra lambda: hydra.run( File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/utils.py", line 214, in run_and_report raise ex File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/utils.py", line 211, in run_and_report return func() File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/utils.py", line 381, in <lambda> overrides=args.overrides, File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/hydra.py", line 92, in run run_mode=RunMode.RUN, File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/hydra.py", line 563, in compose_config from_shell=from_shell, File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/config_loader_impl.py", line 145, in load_configuration from_shell=from_shell, File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/config_loader_impl.py", line 262, in _load_configuration_impl ConfigLoaderImpl._apply_overrides_to_config(config_overrides, cfg) File "/usr/local/lib/python3.7/dist-packages/hydra/_internal/config_loader_impl.py", line 342, in _apply_overrides_to_config f"Could not delete from config. '{override.key_or_group}' does not exist." hydra.errors.ConfigCompositionException: Could not delete from config. 'model.sched' does not exist.`
**Steps/Code to reproduce bug**
Simply trying to execute the latest tts/tutorials/fastpitch_finetune.ipynb.
**Environment details**
Google Colab and Colab PRO +
Any help on this will be appreciated.
Thanks! | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3603/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3603/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3602 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3602/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3602/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3602/events | https://github.com/NVIDIA/NeMo/pull/3602 | 1,123,886,880 | PR_kwDOC_bI7s4yETAE | 3,602 | Add initial support for Buffered RNNT Scripts | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-04T07:13:44 | 2022-02-10T22:03:16 | 2022-02-10T22:03:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3602",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3602",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3602.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3602.patch",
"merged_at": "2022-02-10T22:03:13"
} | # What does this PR do ?
This PR adds support for buffered RNNT evaluation, so that models can be evaluated on audio of any length by models which are normally restricted to small audio duration.
**Collection**: [ASR]
# Changelog
- Refactor the asr_chunked_inference into ctc and rnnt sub folders
- Add speech_to_text_buffered_infer_rnnt.py script to perform RNNT buffered inference using two approaches.
- "Middle token" algorithm
- "Longest common subsequence merge" algorithm
- Refactor RNNT greedy batched decoding to significantly improve decoding speed after training.
- This now is automatically applied right after performing `RNNTModel.change_decoding_strategy()`
# Usage
* You can potentially add a usage example below
```sh
Script to perform buffered inference using RNNT models.
# Middle Token merge algorithm
python speech_to_text_buffered_infer_rnnt.py \
--asr_model="<Path to a nemo model>" \
--test_manifest="<Path to a JSON manifest>" \
--model_stride=4 \
--output_path="." \
--total_buffer_in_secs=10.0 \
--chunk_len_in_ms=8000 \
--device="cuda:0" \
--batch_size=128
# Longer Common Subsequence (LCS) Merge algorithm
python speech_to_text_buffered_infer_rnnt.py \
--asr_model="<Path to a nemo model>" \
--test_manifest="<Path to a JSON manifest>" \
--model_stride=4 \
--output_path="." \
--use_lcs_merge \
--lcs_alignment_dir=<OPTIONAL: Some path to store the LCS alignments> \
--total_buffer_in_secs=10.0 \
--chunk_len_in_ms=8000 \
--device="cuda:0" \
--batch_size=128
# NOTE:
You can use `DEBUG=1 python speech_to_text_buffered_infer_rnnt.py ...` to print out the
ground truth text and predictions of the model.
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
# Additional Information
* Notebook explaining the parts of the script will be released shortly.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3602/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3602/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3599 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3599/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3599/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3599/events | https://github.com/NVIDIA/NeMo/pull/3599 | 1,123,587,141 | PR_kwDOC_bI7s4yDVDa | 3,599 | Correctly install NeMo wheel | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T21:45:59 | 2022-02-04T23:11:00 | 2022-02-04T23:10:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3599",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3599",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3599.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3599.patch",
"merged_at": "2022-02-04T23:10:56"
} | Signed-off-by: smajumdar <[email protected]>
# What does this PR do ?
Updates from old `python setup.py bdist_wheel` syntax to `pip build`.
**Collection**: [bugfix]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3599/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3599/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3598 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3598/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3598/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3598/events | https://github.com/NVIDIA/NeMo/issues/3598 | 1,123,523,322 | I_kwDOC_bI7s5C95r6 | 3,598 | MTEncDecModel preprocessing | {
"login": "1-800-BAD-CODE",
"id": 50530592,
"node_id": "MDQ6VXNlcjUwNTMwNTky",
"avatar_url": "https://avatars.githubusercontent.com/u/50530592?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/1-800-BAD-CODE",
"html_url": "https://github.com/1-800-BAD-CODE",
"followers_url": "https://api.github.com/users/1-800-BAD-CODE/followers",
"following_url": "https://api.github.com/users/1-800-BAD-CODE/following{/other_user}",
"gists_url": "https://api.github.com/users/1-800-BAD-CODE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/1-800-BAD-CODE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/1-800-BAD-CODE/subscriptions",
"organizations_url": "https://api.github.com/users/1-800-BAD-CODE/orgs",
"repos_url": "https://api.github.com/users/1-800-BAD-CODE/repos",
"events_url": "https://api.github.com/users/1-800-BAD-CODE/events{/privacy}",
"received_events_url": "https://api.github.com/users/1-800-BAD-CODE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
}
] | closed | false | {
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "MaximumEntropy",
"id": 9114321,
"node_id": "MDQ6VXNlcjkxMTQzMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MaximumEntropy",
"html_url": "https://github.com/MaximumEntropy",
"followers_url": "https://api.github.com/users/MaximumEntropy/followers",
"following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}",
"gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions",
"organizations_url": "https://api.github.com/users/MaximumEntropy/orgs",
"repos_url": "https://api.github.com/users/MaximumEntropy/repos",
"events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}",
"received_events_url": "https://api.github.com/users/MaximumEntropy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "aklife97",
"id": 16078071,
"node_id": "MDQ6VXNlcjE2MDc4MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aklife97",
"html_url": "https://github.com/aklife97",
"followers_url": "https://api.github.com/users/aklife97/followers",
"following_url": "https://api.github.com/users/aklife97/following{/other_user}",
"gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aklife97/subscriptions",
"organizations_url": "https://api.github.com/users/aklife97/orgs",
"repos_url": "https://api.github.com/users/aklife97/repos",
"events_url": "https://api.github.com/users/aklife97/events{/privacy}",
"received_events_url": "https://api.github.com/users/aklife97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | null | 2022-02-03T20:29:54 | 2022-07-23T19:14:35 | 2022-07-23T19:14:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | An issue with regard to preprocessing (Moses, Jieba, etc.) in the MTEncDecModel:
If the language code is supplied to `MTEncDecModel.translate()` , preprocessing will occur. On the other hand, if the language code is not supplied ('ignore'), the directional tokens ('\<es\>', etc.) cannot be appended. This makes it impossible to have a multilingual model that does not apply preprocessing, which is relatively slow.
It would be a sufficient workaround to refactor how this method decides to do preprocessing (e.g., `preprocess=False`), but it should probably be an attribute of the model itself whether preprocessing is needed. When using a model from NGC, how would a user know whether to use `source_lang="ignore"` or `source_lang="en"`?
It looks like there are a few other places in the model where pre- and post-processing are deeply-entrenched as well. It would be nice to see all of this separated so a user can instantiate a model with `pre_and_post_process=False` and take control of how the text is processed. | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3598/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3598/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3597 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3597/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3597/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3597/events | https://github.com/NVIDIA/NeMo/pull/3597 | 1,123,476,374 | PR_kwDOC_bI7s4yC9gy | 3,597 | [TTS] Convert entry from UTF-16 to UTF-8 | {
"login": "redoctopus",
"id": 4268876,
"node_id": "MDQ6VXNlcjQyNjg4NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/redoctopus",
"html_url": "https://github.com/redoctopus",
"followers_url": "https://api.github.com/users/redoctopus/followers",
"following_url": "https://api.github.com/users/redoctopus/following{/other_user}",
"gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions",
"organizations_url": "https://api.github.com/users/redoctopus/orgs",
"repos_url": "https://api.github.com/users/redoctopus/repos",
"events_url": "https://api.github.com/users/redoctopus/events{/privacy}",
"received_events_url": "https://api.github.com/users/redoctopus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T19:33:33 | 2022-02-03T22:17:58 | 2022-02-03T22:17:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3597",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3597",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3597.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3597.patch",
"merged_at": "2022-02-03T22:17:13"
} | Signed-off-by: Jocelyn Huang <[email protected]>
# What does this PR do ?
Updates the DÉJÀ entry in CMUdict to the correct encoding (UTF-8), as mentioned in #3594.
**Collection**: TTS
# Changelog
Bytes `D\xc9J\xc0` updated to `D\xc3\x89J\xc3\x80`.
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3597/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3597/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3596 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3596/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3596/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3596/events | https://github.com/NVIDIA/NeMo/issues/3596 | 1,123,291,220 | I_kwDOC_bI7s5C9BBU | 3,596 | Different Speakers Reciting Similar Lines | {
"login": "conceptofmind",
"id": 25208228,
"node_id": "MDQ6VXNlcjI1MjA4MjI4",
"avatar_url": "https://avatars.githubusercontent.com/u/25208228?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/conceptofmind",
"html_url": "https://github.com/conceptofmind",
"followers_url": "https://api.github.com/users/conceptofmind/followers",
"following_url": "https://api.github.com/users/conceptofmind/following{/other_user}",
"gists_url": "https://api.github.com/users/conceptofmind/gists{/gist_id}",
"starred_url": "https://api.github.com/users/conceptofmind/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/conceptofmind/subscriptions",
"organizations_url": "https://api.github.com/users/conceptofmind/orgs",
"repos_url": "https://api.github.com/users/conceptofmind/repos",
"events_url": "https://api.github.com/users/conceptofmind/events{/privacy}",
"received_events_url": "https://api.github.com/users/conceptofmind/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T16:26:27 | 2022-02-05T16:24:12 | 2022-02-05T16:24:12 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I have about 100 hours of pre-processed data for male and female speakers. There is some overlap in the lines the speakers are reciting.
I was wondering if having different speakers saying the same exact text would negatively impact the training of an automatic speech recognition model? Would I have to remove the audio and text files where the speakers say the same thing? Each speaker sounds quite different from the other.
Thank you,
Enrico | {
"login": "conceptofmind",
"id": 25208228,
"node_id": "MDQ6VXNlcjI1MjA4MjI4",
"avatar_url": "https://avatars.githubusercontent.com/u/25208228?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/conceptofmind",
"html_url": "https://github.com/conceptofmind",
"followers_url": "https://api.github.com/users/conceptofmind/followers",
"following_url": "https://api.github.com/users/conceptofmind/following{/other_user}",
"gists_url": "https://api.github.com/users/conceptofmind/gists{/gist_id}",
"starred_url": "https://api.github.com/users/conceptofmind/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/conceptofmind/subscriptions",
"organizations_url": "https://api.github.com/users/conceptofmind/orgs",
"repos_url": "https://api.github.com/users/conceptofmind/repos",
"events_url": "https://api.github.com/users/conceptofmind/events{/privacy}",
"received_events_url": "https://api.github.com/users/conceptofmind/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3596/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3596/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3595 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3595/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3595/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3595/events | https://github.com/NVIDIA/NeMo/pull/3595 | 1,123,284,839 | PR_kwDOC_bI7s4yCVWq | 3,595 | Port Variational Inference with Adversarial Learning (VITS) to NeMo TTS | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T16:20:52 | 2022-02-03T21:10:13 | 2022-02-03T21:10:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3595",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3595",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3595.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3595.patch",
"merged_at": null
} | # Overview
This change adds [Variational Inference with adversarial learning (VITS)](https://github.com/jaywalnut310/vits) to the collection of TTS models.
VITS uses the `monotonic_align` module, which requires Cython to be installed prior to building (i.e. run `pip install cython` before running `./reinstall.sh`). | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3595/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3595/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3594 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3594/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3594/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3594/events | https://github.com/NVIDIA/NeMo/pull/3594 | 1,123,221,183 | PR_kwDOC_bI7s4yCH5O | 3,594 | [TTS] Fix incorrect usage of TTSDataset in some files and fix one-line bug in NVIDIA's CMUDict | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T15:25:38 | 2022-02-03T20:30:55 | 2022-02-03T20:30:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3594",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3594",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3594.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3594.patch",
"merged_at": "2022-02-03T20:30:53"
} | Signed-off-by: Oktai Tatanov <[email protected]>
# What does this PR do ?
**Collection**: [tts]
# Changelog
- Fix bug in NVIDIA's CMUDict: word `INTERNATIONAL` used non-existent phoneme
- Fix incorrect usage of TTSDataset in some files
**PR Type**:
- [x] Bugfix
| {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3594/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3594/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3593 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3593/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3593/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3593/events | https://github.com/NVIDIA/NeMo/pull/3593 | 1,123,057,583 | PR_kwDOC_bI7s4yBlFJ | 3,593 | [TTS] Fix typo in FastPitch config (pitch_avg -> pitch_mean) | {
"login": "eyentei",
"id": 17596824,
"node_id": "MDQ6VXNlcjE3NTk2ODI0",
"avatar_url": "https://avatars.githubusercontent.com/u/17596824?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/eyentei",
"html_url": "https://github.com/eyentei",
"followers_url": "https://api.github.com/users/eyentei/followers",
"following_url": "https://api.github.com/users/eyentei/following{/other_user}",
"gists_url": "https://api.github.com/users/eyentei/gists{/gist_id}",
"starred_url": "https://api.github.com/users/eyentei/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eyentei/subscriptions",
"organizations_url": "https://api.github.com/users/eyentei/orgs",
"repos_url": "https://api.github.com/users/eyentei/repos",
"events_url": "https://api.github.com/users/eyentei/events{/privacy}",
"received_events_url": "https://api.github.com/users/eyentei/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T12:59:49 | 2022-02-03T13:53:59 | 2022-02-03T13:53:58 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3593",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3593",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3593.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3593.patch",
"merged_at": "2022-02-03T13:53:58"
} | # What does this PR do ?
Fixes a typo in fastpitch_align_v1.05 config that leads to high pitch loss values on validation.
**Collection**: TTS
**PR Type**:
- [x] Bugfix
| {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3593/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3593/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3592 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3592/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3592/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3592/events | https://github.com/NVIDIA/NeMo/pull/3592 | 1,122,670,915 | PR_kwDOC_bI7s4yATug | 3,592 | ITN: SH bug fixes for telephone | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T05:27:04 | 2022-02-03T18:51:56 | 2022-02-03T18:50:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3592",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3592",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3592.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3592.patch",
"merged_at": "2022-02-03T18:50:17"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3592/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3591 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3591/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3591/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3591/events | https://github.com/NVIDIA/NeMo/pull/3591 | 1,122,533,474 | PR_kwDOC_bI7s4x_3pv | 3,591 | apex quick fix | {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-03T00:43:20 | 2022-02-03T02:33:43 | 2022-02-03T02:33:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3591",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3591",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3591.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3591.patch",
"merged_at": "2022-02-03T02:33:40"
} | Signed-off-by: ekmb <[email protected]>
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3591/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3591/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3590 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3590/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3590/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3590/events | https://github.com/NVIDIA/NeMo/issues/3590 | 1,122,395,543 | I_kwDOC_bI7s5C5mWX | 3,590 | Script process_asr_text_tokenizer.py fails on unicode manifest | {
"login": "catskillsresearch",
"id": 38082822,
"node_id": "MDQ6VXNlcjM4MDgyODIy",
"avatar_url": "https://avatars.githubusercontent.com/u/38082822?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/catskillsresearch",
"html_url": "https://github.com/catskillsresearch",
"followers_url": "https://api.github.com/users/catskillsresearch/followers",
"following_url": "https://api.github.com/users/catskillsresearch/following{/other_user}",
"gists_url": "https://api.github.com/users/catskillsresearch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/catskillsresearch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catskillsresearch/subscriptions",
"organizations_url": "https://api.github.com/users/catskillsresearch/orgs",
"repos_url": "https://api.github.com/users/catskillsresearch/repos",
"events_url": "https://api.github.com/users/catskillsresearch/events{/privacy}",
"received_events_url": "https://api.github.com/users/catskillsresearch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | null | 2022-02-02T21:16:51 | 2022-02-02T21:41:25 | 2022-02-02T21:41:25 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | SORRY, not a bug, I had [ and ] in manifest file and it is not that kind of JSON file.... | {
"login": "catskillsresearch",
"id": 38082822,
"node_id": "MDQ6VXNlcjM4MDgyODIy",
"avatar_url": "https://avatars.githubusercontent.com/u/38082822?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/catskillsresearch",
"html_url": "https://github.com/catskillsresearch",
"followers_url": "https://api.github.com/users/catskillsresearch/followers",
"following_url": "https://api.github.com/users/catskillsresearch/following{/other_user}",
"gists_url": "https://api.github.com/users/catskillsresearch/gists{/gist_id}",
"starred_url": "https://api.github.com/users/catskillsresearch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catskillsresearch/subscriptions",
"organizations_url": "https://api.github.com/users/catskillsresearch/orgs",
"repos_url": "https://api.github.com/users/catskillsresearch/repos",
"events_url": "https://api.github.com/users/catskillsresearch/events{/privacy}",
"received_events_url": "https://api.github.com/users/catskillsresearch/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3590/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3590/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/3589 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3589/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3589/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3589/events | https://github.com/NVIDIA/NeMo/pull/3589 | 1,122,270,709 | PR_kwDOC_bI7s4x_AsM | 3,589 | upgrade PTL trainer flags | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-02T18:44:25 | 2022-02-23T22:01:35 | 2022-02-23T21:40:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3589",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3589",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3589.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3589.patch",
"merged_at": "2022-02-23T21:40:46"
} | Signed-off-by: nithinraok <[email protected]>
# What does this PR do ?
Upgrade pytorch_lightning trainer flags that are going to be deprecated in future
**Collection**: Core and All collections yaml files
# Changelog
- Update pytorch_lightning deprecated variables, namely:
> - accelerator to the trainer now takes the type of accelerator device than distributed type
> - distributed type is handled by strategy flag
> - previously: accelerator='ddp' now accelerator='gpu' strategy='ddp'
> - trainer flag checkpoint_callback is renamed to enable_checkpointing
> - ModelCheckpoint argument evert_n_val_epochs renamed to every_n_epochs
> - Update `trainer.gpus` to `trainer.devices` ( With this change setting devices=0 doesnt auto select gpu instead need to make accelerator='cpu' and also note accelerator=cpu now will only accept >0 as values for devices)
> - `examples/asr/transcribe_speech.py` script modified to remove cuda option. Script automatically searches for GPU and if its not present then falls back to CPU
> - `checkpointing_callback` -> `enable_checkpointing`
> - `flush_logs_every_n_steps` removed from trainer flags
> - `sync_batchnorm` and `num_nodes` removed from NLPDPPPlugins
# Usage
-
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [] Did you write any new necessary tests?
- [] Did you add or update any necessary documentation?
- [] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
-
| {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3589/reactions",
"total_count": 2,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 2,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3589/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3588 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3588/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3588/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3588/events | https://github.com/NVIDIA/NeMo/pull/3588 | 1,122,254,091 | PR_kwDOC_bI7s4x-9Ql | 3,588 | Upgrade ptl trainer flags | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-02T18:25:08 | 2022-02-02T18:26:22 | 2022-02-02T18:26:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3588",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3588",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3588.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3588.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3588/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3588/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3587 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3587/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3587/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3587/events | https://github.com/NVIDIA/NeMo/pull/3587 | 1,122,174,372 | PR_kwDOC_bI7s4x-sh5 | 3,587 | Merge r1.6.1 main | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-02T17:02:15 | 2022-02-02T22:08:51 | 2022-02-02T18:24:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3587",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3587",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3587.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3587.patch",
"merged_at": "2022-02-02T18:24:40"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Merge bugfixes from r1.6.1 into main.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3587/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3587/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3586 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3586/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3586/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3586/events | https://github.com/NVIDIA/NeMo/pull/3586 | 1,122,109,721 | PR_kwDOC_bI7s4x-e35 | 3,586 | [TTS] update waveglow export | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-02T16:03:42 | 2022-07-06T21:13:58 | 2022-07-06T21:13:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3586",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3586",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3586.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3586.patch",
"merged_at": null
} | # What does this PR do ?
Closes #3509 on the NeMo side. Requires a fix in Riva as well.
**Collection**: TTS
# Changelog
- There was a name collusion with audio that resulted in a onnx dynamic axes error
- input_example was changed to be compliant with the new spec of (return dict,) as opposed to the older return dict
**PR Type**:
- [x] Bugfix | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3586/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3586/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/3585 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/3585/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/3585/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/3585/events | https://github.com/NVIDIA/NeMo/pull/3585 | 1,121,734,757 | PR_kwDOC_bI7s4x9PrW | 3,585 | [TTS] Update UnivNet, HiFi-GAN and WaveGlow, small fixes in Mixer-TTS, FastPitch and Exportable | {
"login": "Oktai15",
"id": 17337773,
"node_id": "MDQ6VXNlcjE3MzM3Nzcz",
"avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oktai15",
"html_url": "https://github.com/Oktai15",
"followers_url": "https://api.github.com/users/Oktai15/followers",
"following_url": "https://api.github.com/users/Oktai15/following{/other_user}",
"gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions",
"organizations_url": "https://api.github.com/users/Oktai15/orgs",
"repos_url": "https://api.github.com/users/Oktai15/repos",
"events_url": "https://api.github.com/users/Oktai15/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oktai15/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | null | 2022-02-02T10:13:04 | 2022-02-02T17:22:54 | 2022-02-02T17:22:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/3585",
"html_url": "https://github.com/NVIDIA/NeMo/pull/3585",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/3585.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/3585.patch",
"merged_at": "2022-02-02T17:22:51"
} | **Collection**: [tts]
# Changelog
- refactoring of HiFi-GAN code and config, replacing deprecated datasets with `VocoderDataset`
- refactoring of UnivNet code and config, replacing deprecated datasets with `VocoderDataset`, add exportability (it works correctly only for TorchScript)
- refactoring of WaveGlow code and config, replacing deprecated datasets with `VocoderDataset`
- minor refactoring of FastPitch code
- minor refactoring of Mixer-TTS code
- fixing small bugs in Exportable
**PR Type**:
- [x] New Feature
- [x] Bugfix | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/3585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/3585/timeline | null | null | true |
Subsets and Splits