showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
we should remove openstack here	[ 0 ]
thanks for the catch done ah late night coding so easy to be so dumb	[ 0 ]
chris i think this key alue should be string string because of l sorry if i miss something	[ 0 ]
def delete zones self zone names activate active zone set false	[ 0 ]
Don't feel like you need to justify long comments, especially for obscure stuff like this :P I almost always prefer more verbosity, since it usually reduces [WTFs/min](http://www.osnews.com/story/19266/WTFs_m)	[ 1 ]
make the categories defines so you cant fuck up by doing a typo	[ 1 ]
@hardening damn, good catch, did want to write `_free`	[ 1 ]
tao clone replica should be deleted a left over from the previous implementation it was replaced by create replica test volume	[ 0 ]
is the syntax here dosym target link name a la ln google is oddly unhelpful	[ 0 ]
i will create a barbican subdirectory under etc security	[ 0 ]
seems reasonable should be discovery suspended system suspend in progress	[ 0 ]
Oh I'm really fucking dumb. I misread it. God I hate this stat shit sometimes.	[ 1 ]
oops deleted an extra test i will fix that too stupid rebase merge conflicts	[ 0 ]
Anti (Round about) posters, disgusting	[ 1 ]
all your class methods should be staticmethod	[ 0 ]
@jamesblasco Well it's more than a year after you submitted a PR so I apologize about the absurd slowness of this review but I finally got around to looking at the samples and the code and wow, this is really cool. I will look more closely at the code now but at a glance you seem to be doing all the right things.	[ 1 ]
why are you remving test test please keep it	[ 0 ]
useless braces	[ 0 ]
delete openstack baremetal	[ 0 ]
damn, indeed. thanks.	[ 1 ]
This is mostly so you don't get stuff like 'Urist McGreyshit throws Elder Atmosian Helmet' And instead displays as 'Urist McGreyshit throws the Elder Atmosian Helmet'	[ 1 ]
are these v endpoints	[ 0 ]
feel free to remove these comments some of us have been doing that as we come across them they re a pain to maintain and people should be using intellij parameter tooltips anyway	[ 0 ]
i would be great if you remove backslash and use parentheses here	[ 0 ]
method get keys has common cases you covered only two of them here is list of cases that should be covered by tests self extra specs is none and prefer resource data is true self extra specs is none and prefer resource data is false self extra specs is dict with data and prefer resource data is true self extra specs is dict with data and prefer resource data is false	[ 0 ]
apparently not i got compile errors by doing that as far as i understood what the fuck hashmap does nt support it	[ 0 ]
Hello, How to remove faggot and lesbian smiles from my messenger? Why you force me to see this immoral smiles every day and advertise this **** for all xabber users? Also I did not know that they are here and install xabber to my grandmother phone to chat with she. And what I must say her if she will find this immoral advertising of unconventional relationships? If some faggot want to use this then give him plugin with this. Why you force all to see this? Thanks	[ 1 ]
it's such a dirty fix	[ 1 ]
vim modelines should not be included in new code	[ 0 ]
you do not need this flag if you have a launchpad bug	[ 0 ]
Hell you could even use something like Arch if that was an option much better multilib packages and they tend to work well with pcsx2	[ 1 ]
wrong indentation level two white space righter	[ 0 ]
please consider os kill pre reload parent signal sighup	[ 0 ]
this test is called without all tenants so self assert called should be without all tenants	[ 0 ]
so i would suggest to probably shoot for try size body iter df verify bunch of args if size and not zbf for chunk in body iter rate limit business except dfnotexist return except dfquarantined as err self logger stuff i might even think it possible to do the close and raise quarantine stuff in a finally block in the iterator	[ 0 ]
i think it is safe to kill this right now this was francois s defense against pid reuse which we have headed off by now directly using a process handle here	[ 0 ]
"Sets the version strings for the default mods to the latest" reads weirdly anyway, IMO, so how about shortening it to "Sets the version strings for the default mods"?	[ 1 ]
Some kind of hovering mining cart that sucks up ores would be neato Anyway yeah I'm gonna leave it unchanged, trying to balance mining with this is like watering your plants while your house is on fire	[ 1 ]
the problem with this implementation which jenkins is showing is that now versionedobjectregistry cannot look up objects that are in children s registries so this kills a lot of the base infrastructure that o vo sets up	[ 0 ]
This have been flight tested and shall work. Plots: http://logs.uaventure.com/view/tcw4wSjdA88TufVx6chMFn Log: http://logs.uaventure.com/logmuncher/charts/tcw4wSjdA88TufVx6chMFn/logmuncher.log (The airspeed data is unfortunately again rubbish due to problems with the pitot tube but the logging itself shall be fine) Would be great to have it merged as soon as possible so we can do a subtree update and fly it on our system. @LorenzMeier	[ 1 ]
i still think something is off with these hooks the way it is now if you shutdown go to s and then boot the ap s then the sensors will still have the same odr range and res as they had last boot this does not make sense i think the goals here should be every time the ap boots we should have the same default sensor settings if the ap goes to suspend s and wakes back up s the settings shall not have changed in s and in s only sample specific sensors that are needed the last two goals are currently met but not the first i think you can fix it by changing clock chipset shutdown above to for i i motion sensor count i sensor motion sensors i sensor active sensor active s sensor state sensor not initialized sensor odr sensor default odr if sensor state sensor initialized sensor active mask sensor active sensor drv set data rate sensor	[ 0 ]
i think vblock is safely implied in these functions why do not we just call them vb get keyblock vb get preamble vb get body offset	[ 0 ]
This appears to only ever be used as a boolean, possibly it was BOOLEAN or the decompiler messed up it's size.	[ 1 ]
is this a bug in C++?	[ 1 ]
I'm starting to actually believe this is some kind of really wacky misbehavior caused by MSVC's debugger confusing two struct types as described above. But I've never quite seen anything like it. Either way, still haven't managed to repro after #17126	[ 1 ]
this oustringtoostring is all obsolete these days just use amsg	[ 0 ]
any thing about the armor one that shit is dumb with how awful the player base is.	[ 1 ]
i think it is better do this is mac address compatible port dict get address lower server profile mac lower	[ 0 ]
Shitposting? I want to remind people who see it on accident if it needs updating, that's all.	[ 1 ]
delta needs an brig overhaul though its fucking awful, only saving grace is its mercifully small maint exposure	[ 1 ]
Ah, but you see, I'd like to commit the idea that the sanctity of mail is one of the few standing galaxywide traditions, like how anyone would feel bad digging up a grave or eating something disgusting.	[ 1 ]
@xslendix force pushing in your own branch is fine in a lot of cases, I don't care to see a whole new commit for someone to change 1 character for a typo on a previous commit, and stuff like that... It doesn't "mess up" history, it rewrites history which shouldn't matter at all since it's your own personal branch not one that people are actively collaborating on, @binex-dsk is just being his regular self by saying silly nonsense.	[ 1 ]
I like neither, need to refactor this crap anyway to search for various locations where temp file could be placed.	[ 1 ]
i think this is too broad e g if you fat finger any of the code in that block you l be scratching your head think we should limit the exceptions we catch here and include the exception message in what we raise	[ 0 ]
this call here makes it seems like there is only one router snat port per network router but look at l it returns the port with ipv address on it shouldn t it be looking for the port that has a fixed ip on the given subnet id this makes me think that the code you added on l is just a band aid i tend to think that this call here is just plain wrong shouldn t we fix this by looking getting the csnat port here that matches the subnet we passed in	[ 0 ]
This is shit program get a job faggot	[ 1 ]
What in the ever loving heck is this crap.	[ 1 ]
make break this out so it is a bit cleaner to read q all then resolved reject function resolves function reject	[ 0 ]
in this case we do not need to record histograms so you do not need to pass the switch to the gpu process	[ 0 ]
Generate script uses alphabetical order. But it's weird MD5 is above. Ah no, it just use the first seen order.	[ 1 ]
hold the fuck up here m8 leave the arm blade itself in faggot	[ 1 ]
that s silly but i see no one else is reviewing this so fine	[ 0 ]
oh self sudo enabled will feel alone separated from self root helper o o just kidding	[ 0 ]
edit okay ignore that comment i am an idiot i somehow thought this was a file name guess you will need some platform specific translation logic then since board id support means you have to define a board id function which must return an integer so i guess that answers my question about generalizing that function as well	[ 0 ]
Indenting is screwy here. That last machine_profiling line should be back one tab.	[ 1 ]
put this after all the other middleware pieces that might fail as to minimize the waste of processing time put it after json body i think	[ 0 ]
remove white spaces	[ 0 ]
Or just Add a line that says that to their `examine()` and don't fuck with the `desc`	[ 1 ]
the purpose of debounce is not to wakeup chipset task when interrupt is not valid since chipset task produces messages power state s ix x d and this message prevents idles task from entering heavy sleep need at least min quiet no uart activity power handle state is called only when chipset tast wakes up to move s interrupt and it is deferred call to skylake c power update signal should be not static inside common c and defined in header file do you think if this change is ok to move s interrupt to skyale	[ 0 ]
If only, most of them are hella different... for some reason. Oh well, sliced up it is.	[ 1 ]
delete const here and in the interface in particular i would expect this to be non const in a stub implementation used by unit tests	[ 0 ]
yes none or insignificant if you prefer importlib or not you need to call shell commands to plug your interface like ovs vsctl in a shell	[ 0 ]
Oh damn, this was a refactor thing, not intentional. Definitely should be junk texture. Sorry! :P	[ 1 ]
Damn CSS convention :/ I guess it makes your task a bit less easy :/	[ 1 ]
Bumped down the thresholds a bit. "I'm too encumbered by normal clothes, this is bullshit" is a better incentive to start working on something than "neat, I can wear this with no downsides", after all.	[ 1 ]
silly me i thought that repo rebase was behaving like repo sync and continued to rebase and just list all errors but it stops on st error all good now	[ 0 ]
extra at end which our checkers do not like	[ 0 ]
this init needs to be removed	[ 0 ]
eh fuck it i dont want to benchmark it anymore	[ 1 ]
it became ugly a couple of lines will wrap if you add just a few chars going from readable to not so readable	[ 0 ]
you ve already included these keylayouts in the device git	[ 0 ]
This almost made me cry laughing, I can't believe .....() is a real thing in byond holy shit	[ 1 ]
please leave a line s worth of space here	[ 0 ]
afaik both fencing agent and python tasklib are built and install on slaves but they are completely useless i mean we do not use them we just install them this kind of legacy so you can set lower prio for moving them into gerrit	[ 0 ]
this file is missing i suppose	[ 0 ]
Yes, this was added a long time ago to prevent people from boosting their turrets to ridiculous fire rates too easily.	[ 1 ]
seems as a last step we should execute all ostf tests should not we	[ 0 ]
Damn. I got all excited there for a minute...	[ 1 ]
nit i would provide fake net as a fake network id contant	[ 0 ]
destroy	[ 0 ]
can you go away with it when the thing is god damn raw?	[ 1 ]
can the mocks use autospec true if possible	[ 0 ]
test shell mocks raw request and json request of httpclient because earlier sessionclient was httpclient child test shell tests self client for httpclient and sessionclient so now we need to mock sessionclient method too	[ 0 ]
oops now you just need to use your mockcpuinforeader here too	[ 0 ]
i believe the dump can fail if there is another dump with the same level of details in progress it s a separate thing to fix but maybe when there are multiple dump requests for the same level of details all requesters should get the result	[ 0 ]
now a better name for this field might be image url	[ 0 ]
Most C++ programmers probably don't know what unary plus does. Hell, I don't. Is it like abs? If so, please use that instead.	[ 1 ]
please remove backslashes where possible	[ 0 ]
here i am confusing we did os kill call first then invoke utils execute to issue kill command again can you help to understand here thank you	[ 0 ]
Kinda ridiculous that I have to keep firing up Git Bash just for this basic functionality from vim.	[ 1 ]

we should remove openstack here

[ 0 ]

thanks for the catch done ah late night coding so easy to be so dumb

[ 0 ]

chris i think this key alue should be string string because of l sorry if i miss something

[ 0 ]

def delete zones self zone names activate active zone set false

[ 0 ]

Don't feel like you need to justify long comments, especially for obscure stuff like this :P I almost always prefer more verbosity, since it usually reduces [WTFs/min](http://www.osnews.com/story/19266/WTFs_m)

[ 1 ]

make the categories defines so you cant fuck up by doing a typo

[ 1 ]

@hardening damn, good catch, did want to write `_free`

[ 1 ]

tao clone replica should be deleted a left over from the previous implementation it was replaced by create replica test volume

[ 0 ]

is the syntax here dosym target link name a la ln google is oddly unhelpful

[ 0 ]

i will create a barbican subdirectory under etc security

[ 0 ]

seems reasonable should be discovery suspended system suspend in progress

[ 0 ]

Oh I'm really fucking dumb. I misread it. God I hate this stat shit sometimes.

[ 1 ]

oops deleted an extra test i will fix that too stupid rebase merge conflicts

[ 0 ]

Anti (Round about) posters, disgusting

[ 1 ]

all your class methods should be staticmethod

[ 0 ]

@jamesblasco Well it's more than a year after you submitted a PR so I apologize about the absurd slowness of this review but I finally got around to looking at the samples and the code and wow, this is really cool. I will look more closely at the code now but at a glance you seem to be doing all the right things.

[ 1 ]

why are you remving test test please keep it

[ 0 ]

useless braces

[ 0 ]

delete openstack baremetal

[ 0 ]

damn, indeed. thanks.

[ 1 ]

This is mostly so you don't get stuff like 'Urist McGreyshit throws Elder Atmosian Helmet' And instead displays as 'Urist McGreyshit throws the Elder Atmosian Helmet'

[ 1 ]

are these v endpoints

[ 0 ]

feel free to remove these comments some of us have been doing that as we come across them they re a pain to maintain and people should be using intellij parameter tooltips anyway

[ 0 ]

i would be great if you remove backslash and use parentheses here

[ 0 ]

method get keys has common cases you covered only two of them here is list of cases that should be covered by tests self extra specs is none and prefer resource data is true self extra specs is none and prefer resource data is false self extra specs is dict with data and prefer resource data is true self extra specs is dict with data and prefer resource data is false

[ 0 ]

apparently not i got compile errors by doing that as far as i understood what the fuck hashmap does nt support it

[ 0 ]

Hello, How to remove faggot and lesbian smiles from my messenger? Why you force me to see this immoral smiles every day and advertise this **** for all xabber users? Also I did not know that they are here and install xabber to my grandmother phone to chat with she. And what I must say her if she will find this immoral advertising of unconventional relationships? If some faggot want to use this then give him plugin with this. Why you force all to see this? Thanks

[ 1 ]

it's such a dirty fix

[ 1 ]

vim modelines should not be included in new code

[ 0 ]

you do not need this flag if you have a launchpad bug

[ 0 ]

Hell you could even use something like Arch if that was an option much better multilib packages and they tend to work well with pcsx2

[ 1 ]

wrong indentation level two white space righter

[ 0 ]

please consider os kill pre reload parent signal sighup

[ 0 ]

this test is called without all tenants so self assert called should be without all tenants

[ 0 ]

so i would suggest to probably shoot for try size body iter df verify bunch of args if size and not zbf for chunk in body iter rate limit business except dfnotexist return except dfquarantined as err self logger stuff i might even think it possible to do the close and raise quarantine stuff in a finally block in the iterator

[ 0 ]

i think it is safe to kill this right now this was francois s defense against pid reuse which we have headed off by now directly using a process handle here

[ 0 ]

"Sets the version strings for the default mods to the latest" reads weirdly anyway, IMO, so how about shortening it to "Sets the version strings for the default mods"?

[ 1 ]

Some kind of hovering mining cart that sucks up ores would be neato Anyway yeah I'm gonna leave it unchanged, trying to balance mining with this is like watering your plants while your house is on fire

[ 1 ]

the problem with this implementation which jenkins is showing is that now versionedobjectregistry cannot look up objects that are in children s registries so this kills a lot of the base infrastructure that o vo sets up

[ 0 ]

This have been flight tested and shall work. Plots: http://logs.uaventure.com/view/tcw4wSjdA88TufVx6chMFn Log: http://logs.uaventure.com/logmuncher/charts/tcw4wSjdA88TufVx6chMFn/logmuncher.log (The airspeed data is unfortunately again rubbish due to problems with the pitot tube but the logging itself shall be fine) Would be great to have it merged as soon as possible so we can do a subtree update and fly it on our system. @LorenzMeier

[ 1 ]

i still think something is off with these hooks the way it is now if you shutdown go to s and then boot the ap s then the sensors will still have the same odr range and res as they had last boot this does not make sense i think the goals here should be every time the ap boots we should have the same default sensor settings if the ap goes to suspend s and wakes back up s the settings shall not have changed in s and in s only sample specific sensors that are needed the last two goals are currently met but not the first i think you can fix it by changing clock chipset shutdown above to for i i motion sensor count i sensor motion sensors i sensor active sensor active s sensor state sensor not initialized sensor odr sensor default odr if sensor state sensor initialized sensor active mask sensor active sensor drv set data rate sensor

[ 0 ]

i think vblock is safely implied in these functions why do not we just call them vb get keyblock vb get preamble vb get body offset

[ 0 ]

This appears to only ever be used as a boolean, possibly it was BOOLEAN or the decompiler messed up it's size.

[ 1 ]

is this a bug in C++?

[ 1 ]

I'm starting to actually believe this is some kind of really wacky misbehavior caused by MSVC's debugger confusing two struct types as described above. But I've never quite seen anything like it. Either way, still haven't managed to repro after #17126

[ 1 ]

this oustringtoostring is all obsolete these days just use amsg

[ 0 ]

any thing about the armor one that shit is dumb with how awful the player base is.

[ 1 ]

i think it is better do this is mac address compatible port dict get address lower server profile mac lower

[ 0 ]

Shitposting? I want to remind people who see it on accident if it needs updating, that's all.

[ 1 ]

delta needs an brig overhaul though its fucking awful, only saving grace is its mercifully small maint exposure

[ 1 ]

Ah, but you see, I'd like to commit the idea that the sanctity of mail is one of the few standing galaxywide traditions, like how anyone would feel bad digging up a grave or eating something disgusting.

[ 1 ]

@xslendix force pushing in your own branch is fine in a lot of cases, I don't care to see a whole new commit for someone to change 1 character for a typo on a previous commit, and stuff like that... It doesn't "mess up" history, it rewrites history which shouldn't matter at all since it's your own personal branch not one that people are actively collaborating on, @binex-dsk is just being his regular self by saying silly nonsense.

[ 1 ]

I like neither, need to refactor this crap anyway to search for various locations where temp file could be placed.

[ 1 ]

i think this is too broad e g if you fat finger any of the code in that block you l be scratching your head think we should limit the exceptions we catch here and include the exception message in what we raise

[ 0 ]

this call here makes it seems like there is only one router snat port per network router but look at l it returns the port with ipv address on it shouldn t it be looking for the port that has a fixed ip on the given subnet id this makes me think that the code you added on l is just a band aid i tend to think that this call here is just plain wrong shouldn t we fix this by looking getting the csnat port here that matches the subnet we passed in

[ 0 ]

This is shit program get a job faggot

[ 1 ]

What in the ever loving heck is this crap.

[ 1 ]

make break this out so it is a bit cleaner to read q all then resolved reject function resolves function reject

[ 0 ]

in this case we do not need to record histograms so you do not need to pass the switch to the gpu process

[ 0 ]

Generate script uses alphabetical order. But it's weird MD5 is above. Ah no, it just use the first seen order.

[ 1 ]

hold the fuck up here m8 leave the arm blade itself in faggot

[ 1 ]

that s silly but i see no one else is reviewing this so fine

[ 0 ]

oh self sudo enabled will feel alone separated from self root helper o o just kidding

[ 0 ]

edit okay ignore that comment i am an idiot i somehow thought this was a file name guess you will need some platform specific translation logic then since board id support means you have to define a board id function which must return an integer so i guess that answers my question about generalizing that function as well

[ 0 ]

Indenting is screwy here. That last machine_profiling line should be back one tab.

[ 1 ]

put this after all the other middleware pieces that might fail as to minimize the waste of processing time put it after json body i think

[ 0 ]

remove white spaces

[ 0 ]

Or just Add a line that says that to their `examine()` and don't fuck with the `desc`

[ 1 ]

the purpose of debounce is not to wakeup chipset task when interrupt is not valid since chipset task produces messages power state s ix x d and this message prevents idles task from entering heavy sleep need at least min quiet no uart activity power handle state is called only when chipset tast wakes up to move s interrupt and it is deferred call to skylake c power update signal should be not static inside common c and defined in header file do you think if this change is ok to move s interrupt to skyale

[ 0 ]

If only, most of them are hella different... for some reason. Oh well, sliced up it is.

[ 1 ]

delete const here and in the interface in particular i would expect this to be non const in a stub implementation used by unit tests

[ 0 ]

yes none or insignificant if you prefer importlib or not you need to call shell commands to plug your interface like ovs vsctl in a shell

[ 0 ]

Oh damn, this was a refactor thing, not intentional. Definitely should be junk texture. Sorry! :P

[ 1 ]

Damn CSS convention :/ I guess it makes your task a bit less easy :/

[ 1 ]

Bumped down the thresholds a bit. "I'm too encumbered by normal clothes, this is bullshit" is a better incentive to start working on something than "neat, I can wear this with no downsides", after all.

[ 1 ]

silly me i thought that repo rebase was behaving like repo sync and continued to rebase and just list all errors but it stops on st error all good now

[ 0 ]

extra at end which our checkers do not like

[ 0 ]

this init needs to be removed

[ 0 ]

eh fuck it i dont want to benchmark it anymore

[ 1 ]

it became ugly a couple of lines will wrap if you add just a few chars going from readable to not so readable

[ 0 ]

you ve already included these keylayouts in the device git

[ 0 ]

This almost made me cry laughing, I can't believe .....() is a real thing in byond holy shit

[ 1 ]

please leave a line s worth of space here

[ 0 ]

afaik both fencing agent and python tasklib are built and install on slaves but they are completely useless i mean we do not use them we just install them this kind of legacy so you can set lower prio for moving them into gerrit

[ 0 ]

this file is missing i suppose

[ 0 ]

Yes, this was added a long time ago to prevent people from boosting their turrets to ridiculous fire rates too easily.

[ 1 ]

seems as a last step we should execute all ostf tests should not we

[ 0 ]

Damn. I got all excited there for a minute...

[ 1 ]

nit i would provide fake net as a fake network id contant

[ 0 ]

destroy

[ 0 ]

can you go away with it when the thing is god damn raw?

[ 1 ]

can the mocks use autospec true if possible

[ 0 ]

test shell mocks raw request and json request of httpclient because earlier sessionclient was httpclient child test shell tests self client for httpclient and sessionclient so now we need to mock sessionclient method too

[ 0 ]

oops now you just need to use your mockcpuinforeader here too

[ 0 ]

i believe the dump can fail if there is another dump with the same level of details in progress it s a separate thing to fix but maybe when there are multiple dump requests for the same level of details all requesters should get the result

[ 0 ]

now a better name for this field might be image url

[ 0 ]

Most C++ programmers probably don't know what unary plus does. Hell, I don't. Is it like abs? If so, please use that instead.

[ 1 ]

please remove backslashes where possible

[ 0 ]

here i am confusing we did os kill call first then invoke utils execute to issue kill command again can you help to understand here thank you

[ 0 ]

Kinda ridiculous that I have to keep firing up Git Bash just for this basic functionality from vim.

[ 1 ]