showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
these alignments are off	[ 0 ]
hang on is not is sensitive just to logcat let us get rid of is sensitive and just rename to logcat to something like is allowed in logcat	[ 0 ]
\U0001f440\U0001f440\U0001f440, loyalty implants blocking conversion? Real shit.	[ 1 ]
speed or stamina damage boost, choose one. Otherwise, this is just "middle click 2 do more damage lol". Hell, even with that it is	[ 1 ]
maybe should be cluster dvswitch cluster dvswitch	[ 0 ]
they are useless but heat config heat api cert file will not be in the catalog if that does not matter i can remove it	[ 0 ]
kill this blank line	[ 0 ]
this is yet another example of why I detest baycode chemistry holy shitballs was it so hard for them to to OOP shit properly	[ 1 ]
why are you buffing this? it's designed for multiz shit, not just lavaland	[ 1 ]
ofport self del fdb flow br port lvm cleanup tunnel port br ofport lvm network type add above two lines which could finish the garbage collection before add eliminating a separate fdb delete rpc	[ 0 ]
html last updated fmt subprocess popen git cmd stdout subprocess pipe communicate	[ 0 ]
it has problem if gtest cannot parse the arguments and dump the help information so i change it to fgets	[ 0 ]
dumb question do you need to free this after it is non null	[ 0 ]
why delete hosts here and in the main sync thread get rid of this	[ 0 ]
Darn, thanks for pointing that out!	[ 1 ]
probably a dumb question but why do we have unreleased series	[ 0 ]
please set up lower bounds	[ 0 ]
yo're gay, yo're code gay lol	[ 1 ]
oh god my messing around has done some weird commit spam crap crap crap I'll redo this pull give me amoment sorry @Substance455 , @spoonylove, @Caboozles	[ 1 ]
useless braces	[ 0 ]
ah i would forgotten about the disabled by file part of the middlware i guess the difference between a graceful shutdown and using the middleware is that one is event driven where the other one requires you to pick a long time and assume that after that there are no requests being handled which would work but the code to implement the graceful shutdown could be pretty easy potentially just a few lines of code so might be worth thinking about it s probably just a matter of changing these functions in wsgi py def wait on children self while self running try pid status os wait if os wifexited status or os wifsignaled status self remove children pid self verify and respawn children pid status except oserror as err if err errno not in errno eintr errno echild raise except keyboardinterrupt log info li caught keyboard interrupt exiting break except exception sighupinterrupt self reload continue eventlet greenio shutdown safe self sock self sock close log debug exited def run child self def child hup args shuts down child processes existing requests are handled signal signal signal sighup signal sig ign eventlet wsgi is accepting false self sock close pid os fork if pid signal signal signal sighup child hup signal signal signal sigterm signal sig dfl to look like this def wait on children self while self running try pid status os wait if os wifexited status or os wifsignaled status self remove children pid self verify and respawn children pid status except oserror as err if err errno not in errno eintr errno echild raise except keyboardinterrupt log info li caught keyboard interrupt exiting break except exception sighupinterrupt self reload continue except exception sigstopinterrupt self graceful shutdown continue eventlet greenio shutdown safe self sock self sock close log debug exited def run child self def child hup args shuts down child processes existing requests are handled signal signal signal sighup signal sig ign eventlet wsgi is accepting false self sock close def child stop args shuts down child processes existing requests are handled signal signal signal sigstop signal sig ign eventlet wsgi is accepting false self sock close pid os fork if pid signal signal signal sighup child hup signal signal signal sigstop child stop signal signal signal sigterm signal sig dfl and add this one line function def graceful shutdown self send signal to child processes to handle current requests then exit os killpg self pgid signal sigstop i have not tested the above i think it might be sufficient because the existing code will do the accounting of the number of children and exit when self children hits zero but it would need testing you d do kill s stop glance parent process pid	[ 0 ]
should be a boolopt instead of stropt	[ 0 ]
i would prefer self dscp ress self dscp res s	[ 0 ]
"Exactly one" is weird English.	[ 1 ]
please remove trailing white space	[ 0 ]
done i ll discuss with joel and find a way to check the pid in pidfile is instalog or not	[ 0 ]
Yeah, that stuff was already there. This diff sucks.	[ 1 ]
you will need to fix those empty whitespaces	[ 0 ]
yup, that definitely makes more sense mom :)	[ 1 ]
Because I shitcoded FireProjectiles (gun pr fixes it I swear) you'll probably want this under FireProjectiles instead given for example shotgun shells might shoot out multiple times.	[ 1 ]
the beauty of neutron community is that whatever you write you always get a bike shed comment if you do it the dumb way you get smth like last ip net last net version suggested	[ 0 ]
instead of logging an error and silently returning i would suggest throwing an illegalargumentexception for invalid uris	[ 0 ]
this fucking retarded extention breaks every fucking time i make a thread	[ 1 ]
fuck webeditor has me slippin	[ 1 ]
Is this constructor used? It's a bit scary.	[ 1 ]
skip ovs install trueorfalse false skip ovs install	[ 0 ]
and this check is useless because you used it before to move to this method	[ 0 ]
You also need to make it not save if its been fucked with, what for not fucking up the rest of the saved data.	[ 1 ]
shit+confusing argument name.	[ 1 ]
Just an update - I will be getting around to this in a few days (ETA Wednesday/Thursday). It's been a ridiculous past few weeks for me :)	[ 1 ]
can you chk if we have any negative tests with ttl iirc we do not have any but in case we do can you remove them	[ 0 ]
should be s b b b b b b	[ 0 ]
@lognaturel the merge for this is pretty horrific. A bit stuck but hopefully be done this afternoon!	[ 1 ]
useless	[ 0 ]
Like I said before, this should be the LEAST common effect, not the most. This makes the tesla absolutely rip the station in half, like what the hell.	[ 1 ]
i wrote a test on host use posix madvise posix madv dontneed can still access the memory use madvise madv dontneed will make process aborted with next access	[ 0 ]
remove all this and just use device information statics below	[ 0 ]
note that is precisely what it already does it creates cbuildbot jobs dump where cbuildbot is the root hierarchy and jobs contains pid numbers of the running root processes	[ 0 ]
i added comments on this issue previously i made changes to make sure the notbuild and aborted status are not supported thus not changing the old behavior	[ 0 ]
how about we just retain the socket self socket eventlet listen and then	[ 0 ]
Oh man, just spent several hours on this nonsense... \U0001f926\u200d\u2642	[ 1 ]
damn, i totally didn't think of that, nice one!	[ 1 ]
Damn, you are right again \U0001f605	[ 1 ]
i think you need hit test region state input region	[ 0 ]
that is good bit of info to know actually. hell i wish we knew about that bit about a month ago.	[ 1 ]
Sevtug is a very snarky asshole	[ 1 ]
warning message should be wrapped by lw	[ 0 ]
only a stub info are in the wadl file	[ 0 ]
nit: Was this just some git weirdness? Seems like if you git some resetting and rebasing you could get rid of this diff (and maybe keep the blame record in-tact)	[ 1 ]
@warunalakshitha do we need to escape the dots?	[ 1 ]
not sure i think mso said line breaks are haram or was it kor fuck	[ 1 ]
> github tests why > > (it didn't fail locally, I'm hoping it's just another one of those wacky erroneous fails) test is just wack dw	[ 1 ]
feels like splitting hairs the point is we have precedent for telling devs if you want to develop against this driver have the driver present locally	[ 0 ]
richard this change does not directly relate to state i think it fits best here and aligns with the nova and neutron approach stupid error on the neutron fixing	[ 0 ]
Even in a fix I manage to fuck something up goddamn	[ 1 ]
imo if we do not return here we need to return in case of malformed uuid	[ 0 ]
Agree about `[ "fire", -1 ]`. Also a lot of recipes like that require more tuning. x4 multiplier to achieve a more common volume of diesel production, so it can make sense. It's nonsense if you spend 8 hours to make a cup of diesel, to drive your car a few tiles on that fuel. Usually people making diesel in about a 20 liter tanks.	[ 1 ]
pls docstring	[ 0 ]
i told you that i am dumb in naming did not i please suggest any it is absolutely above my imagination	[ 0 ]
indentation issue remove these blank spaces	[ 0 ]
Yuck, `links` changed :vomiting_face: .	[ 1 ]
I'd honestly consider this paranoid code more than something essential, since I was having weird issues of both spawn and putting shoes on another person not updating properly.	[ 1 ]
wtf is this regexp, why OR two brackets instead of just `[a-z0-9]`?	[ 1 ]
just to set level to warning for requests lib it prints garbage without it	[ 0 ]
i would prefer using notfoundexception instead of creationg new one and this is not required field at all	[ 0 ]
you re going to crash jenkins sending all those gbs d	[ 0 ]
Nothing looks horrifically stupid to me. :) Anything in particular you want us to look at?	[ 1 ]
if ap get configuration success chaos constants config success	[ 0 ]
Godot must have screwed that while renaming files	[ 1 ]
i think we should drop the hardware from option name	[ 0 ]
you really do not need a function and even less a closure here c mon	[ 0 ]
you should be able to get rid of this and create a fake sysroot	[ 0 ]
Damn AndroidStudio is reformatting it\u2026	[ 1 ]
you already add it to dirs below do you really have to add it here	[ 0 ]
They aren't fat fucks, that's the point, they're literally a stomach with legs that instantly turns food into rads.	[ 1 ]
gross	[ 0 ]
holy fuck no make this like 4 or 5, this is 30 seconds of stun	[ 1 ]
Why do you keep greyscaling things and making them look awful?	[ 1 ]
oh awesome would there be single pdf so it could be given to some build engineer for reading btw shall we merge it today	[ 0 ]
now you have sys types h killing this and the blank line below would move us closer to upstream	[ 0 ]
Be it "absurd", "ridiculous" or "stupid". I do not see the value int his PR, as @linki explained before that we can and will not test all branches in https://github.com/opf/openproject/pull/1362#issuecomment-44685415. So, :-1: from me.	[ 1 ]
not sure which is going to land first but will include once honey lands	[ 0 ]
iirc @AnturK is working on other shit in other languages. I know python uses colons and such, so it's probably just force of habit.	[ 1 ]
God damn it. No you're right, checking the returned gasmix is cleaner. The temp thing really doesn't need to exist tho	[ 1 ]
add dark mode because faggot	[ 1 ]
this comment is useless	[ 0 ]
done	[ 0 ]
use cow system metadata image disk format qcow	[ 0 ]
nit add a brief comment here something like sessions favicon images favicon tracking are noisy data types whose invalidations are not enabled by default on android	[ 0 ]
There IS a distinct lack of an appropriately named _DEFINE to put shit like this in, though	[ 1 ]

these alignments are off

[ 0 ]

hang on is not is sensitive just to logcat let us get rid of is sensitive and just rename to logcat to something like is allowed in logcat

[ 0 ]

\U0001f440\U0001f440\U0001f440, loyalty implants blocking conversion? Real shit.

[ 1 ]

speed or stamina damage boost, choose one. Otherwise, this is just "middle click 2 do more damage lol". Hell, even with that it is

[ 1 ]

maybe should be cluster dvswitch cluster dvswitch

[ 0 ]

they are useless but heat config heat api cert file will not be in the catalog if that does not matter i can remove it

[ 0 ]

kill this blank line

[ 0 ]

this is yet another example of why I detest baycode chemistry holy shitballs was it so hard for them to to OOP shit properly

[ 1 ]

why are you buffing this? it's designed for multiz shit, not just lavaland

[ 1 ]

ofport self del fdb flow br port lvm cleanup tunnel port br ofport lvm network type add above two lines which could finish the garbage collection before add eliminating a separate fdb delete rpc

[ 0 ]

html last updated fmt subprocess popen git cmd stdout subprocess pipe communicate

[ 0 ]

it has problem if gtest cannot parse the arguments and dump the help information so i change it to fgets

[ 0 ]

dumb question do you need to free this after it is non null

[ 0 ]

why delete hosts here and in the main sync thread get rid of this

[ 0 ]

Darn, thanks for pointing that out!

[ 1 ]

probably a dumb question but why do we have unreleased series

[ 0 ]

please set up lower bounds

[ 0 ]

yo're gay, yo're code gay lol

[ 1 ]

oh god my messing around has done some weird commit spam crap crap crap I'll redo this pull give me amoment sorry @Substance455 , @spoonylove, @Caboozles

[ 1 ]

useless braces

[ 0 ]

ah i would forgotten about the disabled by file part of the middlware i guess the difference between a graceful shutdown and using the middleware is that one is event driven where the other one requires you to pick a long time and assume that after that there are no requests being handled which would work but the code to implement the graceful shutdown could be pretty easy potentially just a few lines of code so might be worth thinking about it s probably just a matter of changing these functions in wsgi py def wait on children self while self running try pid status os wait if os wifexited status or os wifsignaled status self remove children pid self verify and respawn children pid status except oserror as err if err errno not in errno eintr errno echild raise except keyboardinterrupt log info li caught keyboard interrupt exiting break except exception sighupinterrupt self reload continue eventlet greenio shutdown safe self sock self sock close log debug exited def run child self def child hup args shuts down child processes existing requests are handled signal signal signal sighup signal sig ign eventlet wsgi is accepting false self sock close pid os fork if pid signal signal signal sighup child hup signal signal signal sigterm signal sig dfl to look like this def wait on children self while self running try pid status os wait if os wifexited status or os wifsignaled status self remove children pid self verify and respawn children pid status except oserror as err if err errno not in errno eintr errno echild raise except keyboardinterrupt log info li caught keyboard interrupt exiting break except exception sighupinterrupt self reload continue except exception sigstopinterrupt self graceful shutdown continue eventlet greenio shutdown safe self sock self sock close log debug exited def run child self def child hup args shuts down child processes existing requests are handled signal signal signal sighup signal sig ign eventlet wsgi is accepting false self sock close def child stop args shuts down child processes existing requests are handled signal signal signal sigstop signal sig ign eventlet wsgi is accepting false self sock close pid os fork if pid signal signal signal sighup child hup signal signal signal sigstop child stop signal signal signal sigterm signal sig dfl and add this one line function def graceful shutdown self send signal to child processes to handle current requests then exit os killpg self pgid signal sigstop i have not tested the above i think it might be sufficient because the existing code will do the accounting of the number of children and exit when self children hits zero but it would need testing you d do kill s stop glance parent process pid

[ 0 ]

should be a boolopt instead of stropt

[ 0 ]

i would prefer self dscp ress self dscp res s

[ 0 ]

"Exactly one" is weird English.

[ 1 ]

please remove trailing white space

[ 0 ]

done i ll discuss with joel and find a way to check the pid in pidfile is instalog or not

[ 0 ]

Yeah, that stuff was already there. This diff sucks.

[ 1 ]

you will need to fix those empty whitespaces

[ 0 ]

yup, that definitely makes more sense mom :)

[ 1 ]

Because I shitcoded FireProjectiles (gun pr fixes it I swear) you'll probably want this under FireProjectiles instead given for example shotgun shells might shoot out multiple times.

[ 1 ]

the beauty of neutron community is that whatever you write you always get a bike shed comment if you do it the dumb way you get smth like last ip net last net version suggested

[ 0 ]

instead of logging an error and silently returning i would suggest throwing an illegalargumentexception for invalid uris

[ 0 ]

this fucking retarded extention breaks every fucking time i make a thread

[ 1 ]

fuck webeditor has me slippin

[ 1 ]

Is this constructor used? It's a bit scary.

[ 1 ]

skip ovs install trueorfalse false skip ovs install

[ 0 ]

and this check is useless because you used it before to move to this method

[ 0 ]

You also need to make it not save if its been fucked with, what for not fucking up the rest of the saved data.

[ 1 ]

shit+confusing argument name.

[ 1 ]

Just an update - I will be getting around to this in a few days (ETA Wednesday/Thursday). It's been a ridiculous past few weeks for me :)

[ 1 ]

can you chk if we have any negative tests with ttl iirc we do not have any but in case we do can you remove them

[ 0 ]

should be s b b b b b b

[ 0 ]

@lognaturel the merge for this is pretty horrific. A bit stuck but hopefully be done this afternoon!

[ 1 ]

useless

[ 0 ]

Like I said before, this should be the LEAST common effect, not the most. This makes the tesla absolutely rip the station in half, like what the hell.

[ 1 ]

i wrote a test on host use posix madvise posix madv dontneed can still access the memory use madvise madv dontneed will make process aborted with next access

[ 0 ]

remove all this and just use device information statics below

[ 0 ]

note that is precisely what it already does it creates cbuildbot jobs dump where cbuildbot is the root hierarchy and jobs contains pid numbers of the running root processes

[ 0 ]

i added comments on this issue previously i made changes to make sure the notbuild and aborted status are not supported thus not changing the old behavior

[ 0 ]

how about we just retain the socket self socket eventlet listen and then

[ 0 ]

Oh man, just spent several hours on this nonsense... \U0001f926\u200d\u2642

[ 1 ]

damn, i totally didn't think of that, nice one!

[ 1 ]

Damn, you are right again \U0001f605

[ 1 ]

i think you need hit test region state input region

[ 0 ]

that is good bit of info to know actually. hell i wish we knew about that bit about a month ago.

[ 1 ]

Sevtug is a very snarky asshole

[ 1 ]

warning message should be wrapped by lw

[ 0 ]

only a stub info are in the wadl file

[ 0 ]

nit: Was this just some git weirdness? Seems like if you git some resetting and rebasing you could get rid of this diff (and maybe keep the blame record in-tact)

[ 1 ]

@warunalakshitha do we need to escape the dots?

[ 1 ]

not sure i think mso said line breaks are haram or was it kor fuck

[ 1 ]

> github tests why > > (it didn't fail locally, I'm hoping it's just another one of those wacky erroneous fails) test is just wack dw

[ 1 ]

feels like splitting hairs the point is we have precedent for telling devs if you want to develop against this driver have the driver present locally

[ 0 ]

richard this change does not directly relate to state i think it fits best here and aligns with the nova and neutron approach stupid error on the neutron fixing

[ 0 ]

Even in a fix I manage to fuck something up goddamn

[ 1 ]

imo if we do not return here we need to return in case of malformed uuid

[ 0 ]

Agree about `[ "fire", -1 ]`. Also a lot of recipes like that require more tuning. x4 multiplier to achieve a more common volume of diesel production, so it can make sense. It's nonsense if you spend 8 hours to make a cup of diesel, to drive your car a few tiles on that fuel. Usually people making diesel in about a 20 liter tanks.

[ 1 ]

pls docstring

[ 0 ]

i told you that i am dumb in naming did not i please suggest any it is absolutely above my imagination

[ 0 ]

indentation issue remove these blank spaces

[ 0 ]

Yuck, `links` changed :vomiting_face: .

[ 1 ]

I'd honestly consider this paranoid code more than something essential, since I was having weird issues of both spawn and putting shoes on another person not updating properly.

[ 1 ]

wtf is this regexp, why OR two brackets instead of just `[a-z0-9]`?

[ 1 ]

just to set level to warning for requests lib it prints garbage without it

[ 0 ]

i would prefer using notfoundexception instead of creationg new one and this is not required field at all

[ 0 ]

you re going to crash jenkins sending all those gbs d

[ 0 ]

Nothing looks horrifically stupid to me. :) Anything in particular you want us to look at?

[ 1 ]

if ap get configuration success chaos constants config success

[ 0 ]

Godot must have screwed that while renaming files

[ 1 ]

i think we should drop the hardware from option name

[ 0 ]

you really do not need a function and even less a closure here c mon

[ 0 ]

you should be able to get rid of this and create a fake sysroot

[ 0 ]

Damn AndroidStudio is reformatting it\u2026

[ 1 ]

you already add it to dirs below do you really have to add it here

[ 0 ]

They aren't fat fucks, that's the point, they're literally a stomach with legs that instantly turns food into rads.

[ 1 ]

gross

[ 0 ]

holy fuck no make this like 4 or 5, this is 30 seconds of stun

[ 1 ]

Why do you keep greyscaling things and making them look awful?

[ 1 ]

oh awesome would there be single pdf so it could be given to some build engineer for reading btw shall we merge it today

[ 0 ]

now you have sys types h killing this and the blank line below would move us closer to upstream

[ 0 ]

Be it "absurd", "ridiculous" or "stupid". I do not see the value int his PR, as @linki explained before that we can and will not test all branches in https://github.com/opf/openproject/pull/1362#issuecomment-44685415. So, :-1: from me.

[ 1 ]

not sure which is going to land first but will include once honey lands

[ 0 ]

iirc @AnturK is working on other shit in other languages. I know python uses colons and such, so it's probably just force of habit.

[ 1 ]

God damn it. No you're right, checking the returned gasmix is cleaner. The temp thing really doesn't need to exist tho

[ 1 ]

add dark mode because faggot

[ 1 ]

this comment is useless

[ 0 ]

done

[ 0 ]

use cow system metadata image disk format qcow

[ 0 ]

nit add a brief comment here something like sessions favicon images favicon tracking are noisy data types whose invalidations are not enabled by default on android

[ 0 ]

There IS a distinct lack of an appropriately named _DEFINE to put shit like this in, though

[ 1 ]