showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
again we should define config coderam arch for mec if it is crashing for some reason then let us investigate that not add this hack	[ 0 ]
why do we need a deepcopy here why not mock response json return value test constants v fake port	[ 0 ]
why not use selectedRows? would spare you all that /4 crap wouldn't it?	[ 1 ]
The sweets universally look horrific and disgusting, both sprite-wise and color-wise.	[ 1 ]
these c l functions are all defined in terms of others so they are actually portable between ld and ld	[ 0 ]
hvmap is a dict contains hypervisor object	[ 0 ]
ignore the stupid question let us pretend like this did not happen	[ 0 ]
danger name can be none so typeerror can be raised	[ 0 ]
django is not a supported environment of icehouse release i wonder why it needs to be backported	[ 0 ]
maybe a dumb question but why do not we just use processlauncher to spawn a single worker and reuse any additional services provided to us by service module like that systemd notification	[ 0 ]
This is ridiculous, how has this not been resolved by now	[ 1 ]
all these weird shifts are a cool trick to wrap angles to +/- 180 degrees	[ 1 ]
use datatableview instead of multitableview	[ 0 ]
I want to point out how fucking stupid this code is. For global cinematics (ie literally all of them) watchers === GLOB.mob_list.	[ 1 ]
localdomwindow is a subclass of domwindow so it is obvious that local dom window h includes dom window h i am fine with this include though	[ 0 ]
Wait, I really fucked this up	[ 1 ]
for a safer selection of ciphersuites you probably want to crib from the puppet openstackid vhost once the machine is using something to terminate tls that supports ecdhe then this should be edited to remove the rsa aesgcm rsa aes so that pfs only is guarenteed sslciphersuite ecdh aesgcm dh aesgcm ecdh aes dh aes ecdh aes dh aes rsa aesgcm rsa aes aes anull enull md dss psk srp sslhonorcipherorder on	[ 0 ]
tegra grhost aperture tegra fb start mem start	[ 0 ]
vmarko i asked him the same and still believe his answer is bogus	[ 0 ]
same thing with fk contstraint	[ 0 ]
@MegaphoneJon the test fail relates sadly as I would love to merge this given it rips out old rubbish & adds a test and bonus fixes a bug	[ 1 ]
Thank you, I swear I double checked that, maybe the lint tool messed with it?	[ 1 ]
WJ YOU DO NOT DARE ADD THAT TAG OKAY SIMPLE ANIMAL XENOS ARE PATHETIC AND A DISGRACE TO XENOS BESIDES THIS IS EVEN BETTER NOW BECAUSE THERE ARE NOW WIZARDS TRYING TO MURDER THE SCIENTISTS	[ 1 ]
those mocks were the reason the regression happened in the first place we needed to test that they are actually doing the right thing which we now do by looking at the mock array	[ 0 ]
why? typefucking for no reason makes bad code.	[ 1 ]
let s eradicate the black magic stdout stderr utils execute chroot chroot dpkg query w f package version pkgver list stdout split	[ 0 ]
hmm are you sure it is correct to use an std atomic like this	[ 0 ]
not addressed sine patchset	[ 0 ]
If it's that awful there's no need, was simply an idea.	[ 1 ]
should this be a fk to a user	[ 0 ]
Is that [JSFuck](https://en.wikipedia.org/wiki/JSFuck)? ;) Or a fish emoji? :P	[ 1 ]
This is too big for the movable lighting system, it has a limit of ~5-6 before it getes weird because of the way it works	[ 1 ]
As opposed to? How would you handle this otherwise? Also, the cuffs will likely be used A Fucking Ton considering beepskies and borgs use them, so it warrants a snowflake check.	[ 1 ]
at the end of execution we should clenaup openstack and admin clients	[ 0 ]
if we remove ironic driver from extra specs this should be removed too	[ 0 ]
i think d should be s because obj id is uuid	[ 0 ]
instance proper t ies are you running unittests before submitting	[ 0 ]
ovs git tag d ced de d c d e bcd	[ 0 ]
Oh shit, I didn't mean to leave that in, that was for testing :sweat:	[ 1 ]
looking back geremy said the rule originated from valgrind accessing proc pid files so maybe the two bugs above are for different issues	[ 0 ]
ok let us punish them the best punishment is to let them keep using format to so logging code is totally unreadable	[ 0 ]
this one is true false the next one is i find this a little confusing	[ 0 ]
classname spand can be moved to getdefaultprops	[ 0 ]
this is redundant slug is always initialized below	[ 0 ]
accessing mavalue needs to be protected against data races	[ 0 ]
damn it. pre commit hook only let me commit like this ... Is this because of clang 7.0 ? (what I have locally installed (I think))	[ 1 ]
please mock this properly rather than manually monkey patching	[ 0 ]
Same shit again, please make it readible.	[ 1 ]
@rbetts thanks - our problem is that where we have something that injects enormous cardinality (which means somebody screwed up on our side), we often either cant start the database, or it takes an absurd amount of time to start and run any SHOW commands. This is better in 1.4 but I believe still not something totally solved (to be fair, i've not tested with pathological cardinality under very recent commits).	[ 1 ]
if you are fixing nits anyway s a	[ 0 ]
what if, it's a witch? fucking fix it no seriously use \\his	[ 1 ]
Goddamit I ll fix that We definitely need a simple way to iterate over all droids, this is ridiculous	[ 1 ]
sorry is this is dumb not very familiar with this code but why self port and not port	[ 0 ]
@scottaddie We're removing almost all boxes - they are too obnoxious. We're going to simple text.	[ 1 ]
s destoryed destroyed	[ 0 ]
after testing the stop command would be more robust if it went ahead and deleted the tr api pid tr cond pid and tr tmgr pid similar to how stop deps is deleting all the pid files this would allow a user to debug individual trove services in screen and also still call redstack stop to kill them all and start to start them back up	[ 0 ]
good question that was a real head scratcher for me it looks very specific so i did not want to change it even though i agree we should probably clean up on any exception sounds like both of you would be in favor of that change and me would make three so i will fix that up	[ 0 ]
seems that populate quantum extension values is redundant with the refresh quantum extensions cache method of the bellow has port binding extension	[ 0 ]
use err here or if we are going to abort anyway die	[ 0 ]
That's one hella query xD gonna test	[ 1 ]
john garbutt you re right i will remove them	[ 0 ]
does this need to be a mock ie why cannot we use the regular downloaditem here generally mocks confuse and frighten me	[ 0 ]
extra white space should be removed	[ 0 ]
stupid ass trait system, shoudl be datums so you can register signals to the trait to generate the mood events	[ 1 ]
hugepage size hugepages get size if hugepage size	[ 0 ]
either query ceilometer you or query the ceilometer api you	[ 0 ]
This hack kinda sucks, but I couldn't think of anything better - @joeloff @dougbu @JunTaoLuo any ideas?	[ 1 ]
simon is a femboy simon is a femboy	[ 1 ]
tenant id must be nullable false	[ 0 ]
Speaking of that, how do you even use the damn thing?	[ 1 ]
for z size t you should need only zconf h	[ 0 ]
i somehow cannot see when this occurs i see that sorted row find is similar to one on python docs page but without valueerror	[ 0 ]
bouyah you just killed me	[ 0 ]
Darn it, didn't even notice there were tabs and spaces in this file... sigh. -[Unknown]	[ 1 ]
this logic seems odd the only way to reach here seems to be if self stack domain is unset i think you are missing a self stack domain cfg conf stack user domain in the else case above	[ 0 ]
yeah let us kill this bit now	[ 0 ]
Needs comment. WTF does this do? Why and for whom?	[ 1 ]
are these thunks still needed after this cl or could they be removed	[ 0 ]
gah fuck, it was the colon	[ 1 ]
check triggers abort internally when matched which might be a bit too aggressive i just verified that all inputs on framework side are coming from internal sources so we might be okay with the daemon being kicked and restarted	[ 0 ]
ec timeout usec old timeout	[ 0 ]
this methos these methods	[ 0 ]
done called dalvik vm lib i also then removed the adding in each runtime lib default mk to product property overrides and just did it in one place in product config mk like this product property overrides persist sys dalvik vm lib dalvik vm lib that seems better right	[ 0 ]
I'm not gonna go through and get anal about every place with this but generally it's more idiomatic to use camelCase for js var names.	[ 1 ]
Holy fuck linebreak this	[ 1 ]
the chdir should also be removed	[ 0 ]
the entire proc is called `koraintshitwho()`, it's <i>all memes</i>	[ 1 ]
this should be like the others below new entity user entity format role data user	[ 0 ]
Actually I don't care too much about this eslint rule, you're welcome to remove it. Just consider whether it makes sense to get rid of `PackageType` and apply both types of transformations for every package (i.e. without `switch`-ing). This can simplify code branches and can help to avoid writing ridiculous test cases just for making our code coverage checks pass.	[ 1 ]
you think that is best i do not really want to clutter the code here because of bogus apks	[ 0 ]
idfk, the image code will be cleaned up when 509 stops crashing on me, because I can use its shit to remove the snowflake for sprite rotation	[ 1 ]
yeah people can also download it or build the rom on their on for other distros see the note below	[ 0 ]
the enclosing class is not public these methods do not need to be public either	[ 0 ]
please use target out intermediates and target nd arch var prefix target out intermediates to take care of both obj and obj arm in case of multilib bulid	[ 0 ]
@kd0aij yes let's get everything synced up in this branch. Once I get the generated serialization code working well I'll strip out all the changes working around alignment nonsense.	[ 1 ]
this file has the weirdest fucking formatting	[ 1 ]
is a thinko worst than a mere typo like someone actually thought about it first	[ 0 ]
I honestly cannot comprehend what the fuck this line hoped to achieve	[ 1 ]
Absolutely fucking not	[ 1 ]
this will remove all the whitespaces together with eols and converts output to the very very long line of numbers maybe you forgot some kind of filter like grep or awk	[ 0 ]

again we should define config coderam arch for mec if it is crashing for some reason then let us investigate that not add this hack

[ 0 ]

why do we need a deepcopy here why not mock response json return value test constants v fake port

[ 0 ]

why not use selectedRows? would spare you all that /4 crap wouldn't it?

[ 1 ]

The sweets universally look horrific and disgusting, both sprite-wise and color-wise.

[ 1 ]

these c l functions are all defined in terms of others so they are actually portable between ld and ld

[ 0 ]

hvmap is a dict contains hypervisor object

[ 0 ]

ignore the stupid question let us pretend like this did not happen

[ 0 ]

danger name can be none so typeerror can be raised

[ 0 ]

django is not a supported environment of icehouse release i wonder why it needs to be backported

[ 0 ]

maybe a dumb question but why do not we just use processlauncher to spawn a single worker and reuse any additional services provided to us by service module like that systemd notification

[ 0 ]

This is ridiculous, how has this not been resolved by now

[ 1 ]

all these weird shifts are a cool trick to wrap angles to +/- 180 degrees

[ 1 ]

use datatableview instead of multitableview

[ 0 ]

I want to point out how fucking stupid this code is. For global cinematics (ie literally all of them) watchers === GLOB.mob_list.

[ 1 ]

localdomwindow is a subclass of domwindow so it is obvious that local dom window h includes dom window h i am fine with this include though

[ 0 ]

Wait, I really fucked this up

[ 1 ]

for a safer selection of ciphersuites you probably want to crib from the puppet openstackid vhost once the machine is using something to terminate tls that supports ecdhe then this should be edited to remove the rsa aesgcm rsa aes so that pfs only is guarenteed sslciphersuite ecdh aesgcm dh aesgcm ecdh aes dh aes ecdh aes dh aes rsa aesgcm rsa aes aes anull enull md dss psk srp sslhonorcipherorder on

[ 0 ]

tegra grhost aperture tegra fb start mem start

[ 0 ]

vmarko i asked him the same and still believe his answer is bogus

[ 0 ]

same thing with fk contstraint

[ 0 ]

@MegaphoneJon the test fail relates sadly as I would love to merge this given it rips out old rubbish & adds a test and bonus fixes a bug

[ 1 ]

Thank you, I swear I double checked that, maybe the lint tool messed with it?

[ 1 ]

WJ YOU DO NOT DARE ADD THAT TAG OKAY SIMPLE ANIMAL XENOS ARE PATHETIC AND A DISGRACE TO XENOS BESIDES THIS IS EVEN BETTER NOW BECAUSE THERE ARE NOW WIZARDS TRYING TO MURDER THE SCIENTISTS

[ 1 ]

those mocks were the reason the regression happened in the first place we needed to test that they are actually doing the right thing which we now do by looking at the mock array

[ 0 ]

why? typefucking for no reason makes bad code.

[ 1 ]

let s eradicate the black magic stdout stderr utils execute chroot chroot dpkg query w f package version pkgver list stdout split

[ 0 ]

hmm are you sure it is correct to use an std atomic like this

[ 0 ]

not addressed sine patchset

[ 0 ]

If it's that awful there's no need, was simply an idea.

[ 1 ]

should this be a fk to a user

[ 0 ]

Is that [JSFuck](https://en.wikipedia.org/wiki/JSFuck)? ;) Or a fish emoji? :P

[ 1 ]

This is too big for the movable lighting system, it has a limit of ~5-6 before it getes weird because of the way it works

[ 1 ]

As opposed to? How would you handle this otherwise? Also, the cuffs will likely be used A Fucking Ton considering beepskies and borgs use them, so it warrants a snowflake check.

[ 1 ]

at the end of execution we should clenaup openstack and admin clients

[ 0 ]

if we remove ironic driver from extra specs this should be removed too

[ 0 ]

i think d should be s because obj id is uuid

[ 0 ]

instance proper t ies are you running unittests before submitting

[ 0 ]

ovs git tag d ced de d c d e bcd

[ 0 ]

Oh shit, I didn't mean to leave that in, that was for testing :sweat:

[ 1 ]

looking back geremy said the rule originated from valgrind accessing proc pid files so maybe the two bugs above are for different issues

[ 0 ]

ok let us punish them the best punishment is to let them keep using format to so logging code is totally unreadable

[ 0 ]

this one is true false the next one is i find this a little confusing

[ 0 ]

classname spand can be moved to getdefaultprops

[ 0 ]

this is redundant slug is always initialized below

[ 0 ]

accessing mavalue needs to be protected against data races

[ 0 ]

damn it. pre commit hook only let me commit like this ... Is this because of clang 7.0 ? (what I have locally installed (I think))

[ 1 ]

please mock this properly rather than manually monkey patching

[ 0 ]

Same shit again, please make it readible.

[ 1 ]

@rbetts thanks - our problem is that where we have something that injects enormous cardinality (which means somebody screwed up on our side), we often either cant start the database, or it takes an absurd amount of time to start and run any SHOW commands. This is better in 1.4 but I believe still not something totally solved (to be fair, i've not tested with pathological cardinality under very recent commits).

[ 1 ]

if you are fixing nits anyway s a

[ 0 ]

what if, it's a witch? fucking fix it no seriously use \\his

[ 1 ]

Goddamit I ll fix that We definitely need a simple way to iterate over all droids, this is ridiculous

[ 1 ]

sorry is this is dumb not very familiar with this code but why self port and not port

[ 0 ]

@scottaddie We're removing almost all boxes - they are too obnoxious. We're going to simple text.

[ 1 ]

s destoryed destroyed

[ 0 ]

after testing the stop command would be more robust if it went ahead and deleted the tr api pid tr cond pid and tr tmgr pid similar to how stop deps is deleting all the pid files this would allow a user to debug individual trove services in screen and also still call redstack stop to kill them all and start to start them back up

[ 0 ]

good question that was a real head scratcher for me it looks very specific so i did not want to change it even though i agree we should probably clean up on any exception sounds like both of you would be in favor of that change and me would make three so i will fix that up

[ 0 ]

seems that populate quantum extension values is redundant with the refresh quantum extensions cache method of the bellow has port binding extension

[ 0 ]

use err here or if we are going to abort anyway die

[ 0 ]

That's one hella query xD gonna test

[ 1 ]

john garbutt you re right i will remove them

[ 0 ]

does this need to be a mock ie why cannot we use the regular downloaditem here generally mocks confuse and frighten me

[ 0 ]

extra white space should be removed

[ 0 ]

stupid ass trait system, shoudl be datums so you can register signals to the trait to generate the mood events

[ 1 ]

hugepage size hugepages get size if hugepage size

[ 0 ]

either query ceilometer you or query the ceilometer api you

[ 0 ]

This hack kinda sucks, but I couldn't think of anything better - @joeloff @dougbu @JunTaoLuo any ideas?

[ 1 ]

simon is a femboy simon is a femboy

[ 1 ]

tenant id must be nullable false

[ 0 ]

Speaking of that, how do you even use the damn thing?

[ 1 ]

for z size t you should need only zconf h

[ 0 ]

i somehow cannot see when this occurs i see that sorted row find is similar to one on python docs page but without valueerror

[ 0 ]

bouyah you just killed me

[ 0 ]

Darn it, didn't even notice there were tabs and spaces in this file... sigh. -[Unknown]

[ 1 ]

this logic seems odd the only way to reach here seems to be if self stack domain is unset i think you are missing a self stack domain cfg conf stack user domain in the else case above

[ 0 ]

yeah let us kill this bit now

[ 0 ]

Needs comment. WTF does this do? Why and for whom?

[ 1 ]

are these thunks still needed after this cl or could they be removed

[ 0 ]

gah fuck, it was the colon

[ 1 ]

check triggers abort internally when matched which might be a bit too aggressive i just verified that all inputs on framework side are coming from internal sources so we might be okay with the daemon being kicked and restarted

[ 0 ]

ec timeout usec old timeout

[ 0 ]

this methos these methods

[ 0 ]

done called dalvik vm lib i also then removed the adding in each runtime lib default mk to product property overrides and just did it in one place in product config mk like this product property overrides persist sys dalvik vm lib dalvik vm lib that seems better right

[ 0 ]

I'm not gonna go through and get anal about every place with this but generally it's more idiomatic to use camelCase for js var names.

[ 1 ]

Holy fuck linebreak this

[ 1 ]

the chdir should also be removed

[ 0 ]

the entire proc is called `koraintshitwho()`, it's <i>all memes</i>

[ 1 ]

this should be like the others below new entity user entity format role data user

[ 0 ]

Actually I don't care too much about this eslint rule, you're welcome to remove it. Just consider whether it makes sense to get rid of `PackageType` and apply both types of transformations for every package (i.e. without `switch`-ing). This can simplify code branches and can help to avoid writing ridiculous test cases just for making our code coverage checks pass.

[ 1 ]

you think that is best i do not really want to clutter the code here because of bogus apks

[ 0 ]

idfk, the image code will be cleaned up when 509 stops crashing on me, because I can use its shit to remove the snowflake for sprite rotation

[ 1 ]

yeah people can also download it or build the rom on their on for other distros see the note below

[ 0 ]

the enclosing class is not public these methods do not need to be public either

[ 0 ]

please use target out intermediates and target nd arch var prefix target out intermediates to take care of both obj and obj arm in case of multilib bulid

[ 0 ]

@kd0aij yes let's get everything synced up in this branch. Once I get the generated serialization code working well I'll strip out all the changes working around alignment nonsense.

[ 1 ]

this file has the weirdest fucking formatting

[ 1 ]

is a thinko worst than a mere typo like someone actually thought about it first

[ 0 ]

I honestly cannot comprehend what the fuck this line hoped to achieve

[ 1 ]

Absolutely fucking not

[ 1 ]

this will remove all the whitespaces together with eols and converts output to the very very long line of numbers maybe you forgot some kind of filter like grep or awk

[ 0 ]