Add compatibility with Sentence Transformers v3.2.0
#45
by
tomaarsen
HF staff
- opened
Hello!
Pull Request overview
- Add **kwargs to Transformer to avoid issues when ST adds new arguments
Details
The Sentence Transformers v3.2.0 release added a backend keyword to its Transformer module, which your custom module didn't expect. I've added **kwargs to avoid future issues.
- Tom Aarsen
wow lightning Tom
thank you!
thanks @tomaarsen ! will you publish this branch and make it ready to review?
bwang0911
changed pull request status to
open
Apologies, I didn't realise that I didn't already publish it. It should be ready for review.
merged, thanks @tomaarsen and thanks @botkop for reporting! I'll close both discussions!
bwang0911
changed pull request status to
merged
fastest fix I ever came across
cheers to both!