Update app.py

app.py

@@ -104,43 +104,105 @@ def get_ai_story_continuation(story_context, level):
         response = openai.ChatCompletion.create(
             model="gpt-4o-mini",
             messages=[
-                {"role": "system", "content": f"""You are helping a {level} level English student write a story. 
-                Follow these rules strictly:
-                1. Read the story context carefully
-                2. Continue the story logically from the last sentence
-                3. Never repeat the exact same sentence
-                4. Make sure each continuation adds new information
-                5. Suggest vocabulary that fits the current story context
-                
-                Provide a JSON response with:
-                1. continuation: A new sentence that continues the story logically
-                2. creative_prompt: A specific question about possible next events
-                3. vocabulary_suggestions: 3 relevant words that could be used next
-                4. translation: Thai translation of your continuation sentence"""},
-                {"role": "user", "content": f"""Current story context: {story_context}
-                Continue the story and ensure it connects with what happened before."""}
+                {"role": "system", "content": f"""You are a creative storyteller helping a {level} level English student write a story. 
+
+                Rules:
+                1. READ the story context carefully
+                2. ADD meaningful story elements (new events, character development, dialogue)
+                3. AVOID generic transitions like 'suddenly' or 'then'
+                4. ENSURE story progression and character development
+                5. USE vocabulary appropriate for {level} level
+
+                Current story elements:
+                - Characters introduced: {extract_characters(story_context)}
+                - Current setting: {extract_setting(story_context)}
+                - Recent events: {extract_recent_events(story_context)}
+
+                Provide JSON response with:
+                1. continuation: Create an interesting next story event (1-2 sentences)
+                2. creative_prompt: Ask about specific details/choices for the next part
+                3. vocabulary_suggestions: 3 contextual words for the next part
+                4. translation: Thai translation of continuation
+                5. story_elements: New elements introduced (characters/places/objects)"""},
+                {"role": "user", "content": f"Story context: {story_context}\nContinue the story creatively and maintain narrative flow."}
             ],
             temperature=0.7
         )
         
-        # Validate the response
         result = json.loads(response.choices[0].message.content)
         
-        # Check if continuation is not too similar to previous content
-        if story_context and result['continuation'].lower() in story_context.lower():
-            # Try to get a new response
+        # Validate story continuation
+        if is_generic_response(result['continuation']):
             return get_ai_story_continuation(story_context, level)
             
         return result
         
     except Exception as e:
         st.error(f"Error with AI response: {e}")
-        return {
-            "continuation": "Suddenly, something unexpected happened...",
-            "creative_prompt": "What did our character discover?",
-            "vocabulary_suggestions": ["discover", "surprise", "mystery"],
-            "translation": "ทันใดนั้น บางสิ่งที่ไม่คาดคิดก็เกิดขึ้น..."
-        }
+        return create_fallback_response(story_context)
+
+def extract_characters(story_context):
+    """Extract character information from story"""
+    try:
+        char_response = openai.ChatCompletion.create(
+            model="gpt-4o-mini",
+            messages=[
+                {"role": "system", "content": "List all characters mentioned in the story."},
+                {"role": "user", "content": story_context}
+            ]
+        )
+        return char_response.choices[0].message.content
+    except:
+        return "Unknown characters"
+
+def extract_setting(story_context):
+    """Extract setting information from story"""
+    try:
+        setting_response = openai.ChatCompletion.create(
+            model="gpt-4o-mini",
+            messages=[
+                {"role": "system", "content": "Describe the current setting of the story."},
+                {"role": "user", "content": story_context}
+            ]
+        )
+        return setting_response.choices[0].message.content
+    except:
+        return "Unknown setting"
+
+def extract_recent_events(story_context):
+    """Extract recent events from story"""
+    try:
+        events_response = openai.ChatCompletion.create(
+            model="gpt-4o-mini",
+            messages=[
+                {"role": "system", "content": "Summarize the most recent events in the story."},
+                {"role": "user", "content": story_context}
+            ]
+        )
+        return events_response.choices[0].message.content
+    except:
+        return "Unknown events"
+
+def is_generic_response(continuation):
+    """Check if the response is too generic"""
+    generic_phrases = [
+        "suddenly", "then", "something happened",
+        "unexpectedly", "the story continues"
+    ]
+    return any(phrase in continuation.lower() for phrase in generic_phrases)
+
+def create_fallback_response(story_context):
+    """Create contextual fallback response"""
+    # Extract last event or setting from story_context
+    last_event = story_context.split('.')[-2] if len(story_context.split('.')) > 1 else story_context
+    
+    return {
+        "continuation": f"The characters decided to explore further into the story.",
+        "creative_prompt": "What interesting detail should we add to the scene?",
+        "vocabulary_suggestions": ["explore", "adventure", "discover"],
+        "translation": "ตัวละครตัดสินใจสำรวจเรื่องราวต่อไป",
+        "story_elements": {"new_elements": ["exploration"]}
+    }
 
 def validate_story_quality(story_context, new_continuation):
     """Validate that the story maintains quality and coherence"""
@@ -254,26 +316,46 @@ def main():
         with st.container():
             st.markdown('<div class="box-container story-box">', unsafe_allow_html=True)
             st.write("### 📖 Our Story So Far:")
+            
             for entry in st.session_state.story:
+                # แสดงเนื้อเรื่อง
                 css_class = "ai-text" if entry['author'] == 'AI' else "player-text"
-                
-                # แสดงข้อความหลัก
                 st.markdown(f'<div class="story-text {css_class}">{entry["text"]}</div>', 
                            unsafe_allow_html=True)
                 
-                # ถ้าเป็น AI response ให้แสดงคำแปลและ prompt
+                # ถ้าเป็น AI response
                 if entry['author'] == 'AI':
+                    # แสดงคำแปล
                     if 'translation' in entry:
-                        st.markdown(f'<div class="prompt-text">🇹🇭 {entry["translation"]}</div>', 
-                                  unsafe_allow_html=True)
+                        st.markdown(f'''
+                            <div class="translation-box">
+                                🇹🇭 {entry["translation"]}
+                            </div>
+                        ''', unsafe_allow_html=True)
+                    
+                    # แสดงคำถามกระตุ้นความคิด
                     if 'prompt' in entry:
-                        st.markdown(f'<div class="prompt-text">🤔 {entry["prompt"]}</div>', 
-                                  unsafe_allow_html=True)
+                        st.markdown(f'''
+                            <div class="prompt-box">
+                                💭 {entry["prompt"]}
+                            </div>
+                        ''', unsafe_allow_html=True)
+                    
+                    # แสดงคำศัพท์แนะนำ
                     if 'vocabulary' in entry:
-                        vocab_text = ", ".join(entry["vocabulary"])
-                        st.markdown(f'<div class="prompt-text">📚 Suggested words: {vocab_text}</div>', 
-                                  unsafe_allow_html=True)
-            st.markdown('</div>', unsafe_allow_html=True)
+                        st.markdown(f'''
+                            <div class="vocabulary-box">
+                                📚 Try using: {', '.join(entry["vocabulary"])}
+                            </div>
+                        ''', unsafe_allow_html=True)
+                    
+                    # แสดงองค์ประกอบใหม่ในเรื่อง
+                    if 'story_elements' in entry:
+                        st.markdown(f'''
+                            <div class="elements-box">
+                                🎭 New elements: {', '.join(entry["story_elements"]["new_elements"])}
+                            </div>
+                        ''', unsafe_allow_html=True)
 
         # Box 2: Writing Area
         if st.session_state.current_turn == 'Player':