Spaces:
Running
on
CPU Upgrade
Await playback of samples before allowing to vote
"To avoid a bias to hearing the bias of just their favored TTS, I suggest making the vote buttons non-interactive until the playback of both samples is finished." - #43
Had created #43 beforehand because I misunderstood HF saying that discussions and pull requests are nearly the same thing. So I thought a commit to #43 would make it into a pull request.
A way to fix #43
Implemented in cloned Arena Space:
๐คhttps://huggingface.co/spaces/Pendrokar/TTS-Spaces-Arena
lgtm
Seems there are two issues:
- Crashes when pressing Next Round button, as clear_stuff() needs to send back two extra outputs for the two State components: https://huggingface.co/spaces/Pendrokar/TTS-Spaces-Arena/blob/main/app.py#L864
- After the initial unlock, finishing playback of a single sample unlocks voting (Probably a gr.State issue)
Revert the PR for now @mrfakename . I have some rebasing to do. HF Space dev is cumbersome when I seemingly cannot tell a HF Space to use a different Git Branch and I can only really test it on PR #30 as that supports HF spaces. ๐
If only if I could tell my cloned HF Space to use a different Git branch rather than main. ๐ค