No description provided.

just saw the tweet from @lvwerra , thought dark mode would be great to add --long report hurts my eyes in the long run.

uses darkreader api, added a toggle button, placed top-left. looks nice imo!

serhany changed pull request status to open
This comment has been hidden
Nanotron Research org

Wow that’s really amazing cc @nouamanetazi @lvwerra

We’ll take a look very soon!

thanks a lot!

Nanotron Research org
edited 3 days ago

@serhany nice job! im afraid some figures dont render properly, do you have an idea how to fix them?
Nevermind I think it just took longer to load first time
image.png

Nanotron Research org

@serhany some figures dont render properly :/ , can we maybe keep them in their original state if they're hard to fix?
image.png

hi @nouamanetazi ! thanks for pointing this out. the problem occurs since these figures have transparent backgrounds, and black text won't show clearly on a dark bg.

to fix this I took your advice and just added white bg to the affected .svg, .png and .gif files. that way they look like their original state.

let me know what you think! here's the space link, I can create a new PR if this looks good: https://huggingface.co/spaces/serhany/ultrascale-playbook-dark-mode

image.png

hi again! @nouamanetazi

the original space was updated (.pdf version added) so I updated mine too. also better aligned the dark mode toggle, no longer moves the navbar to the side.

see the final version here: https://huggingface.co/spaces/serhany/ultrascale-playbook-dark-updated
(created another space because the sync space function on hf was returning a 404 error)

Ready to merge
This branch is ready to get merged automatically.

Sign up or log in to comment