issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
βŒ€
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.46B
issue_number
int64
1
127k
[ "chakra-core", "ChakraCore" ]
WASM - Enable int64 const prop (5d)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3475/comments
1
2017-08-03T22:12:14Z
2017-08-03T22:24:35Z
https://github.com/chakra-core/ChakraCore/issues/3475
247,850,369
3,475
[ "chakra-core", "ChakraCore" ]
WASM - Tail recursion (2w)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3474/comments
1
2017-08-03T22:06:17Z
2018-02-27T19:34:13Z
https://github.com/chakra-core/ChakraCore/issues/3474
247,849,105
3,474
[ "chakra-core", "ChakraCore" ]
#3420 removes tzdata sync calls from xplat DateTime interface due to 10X performance penalty and other concerns mentioned in the same PR. Please read the discussion made under https://github.com/Microsoft/ChakraCore/pull/3420 ( Thanks to @MSLaguana @dilijev for their valuable contributions there) /cc @bterlson
xplat: ChakraCore doesn't update process tzdata if system timezone changes
https://api.github.com/repos/chakra-core/ChakraCore/issues/3467/comments
0
2017-08-02T16:24:05Z
2017-08-02T16:24:32Z
https://github.com/chakra-core/ChakraCore/issues/3467
247,447,681
3,467
[ "chakra-core", "ChakraCore" ]
When the generator object is created we save the interpreterstackframe in it. If we dynamically attach a debugger to it, both the offset and register allocation in the bytecode may defer from the previous values. This will cause issues when we try to continue after an yield from the saved offset. This needs to be fixed for yield resume scenarios.
Fix the dynamic attach scenario for generators
https://api.github.com/repos/chakra-core/ChakraCore/issues/3453/comments
1
2017-07-29T06:40:54Z
2019-06-07T18:34:30Z
https://github.com/chakra-core/ChakraCore/issues/3453
246,503,821
3,453
[ "chakra-core", "ChakraCore" ]
> The reserved immediate to the current_memory and grow_memory operators is for future πŸ¦„ use and must be 0 in the MVP. The call_indirect operator takes a list of function arguments and as the last operand the index into the table. Its reserved immediate is for future πŸ¦„ use and must be 0 in the MVP. Currently we just ignore the reserved immediate, we need to validate that they're 0
WASM: Reserved immediate
https://api.github.com/repos/chakra-core/ChakraCore/issues/3450/comments
0
2017-07-28T18:27:43Z
2017-08-03T17:27:56Z
https://github.com/chakra-core/ChakraCore/issues/3450
246,424,551
3,450
[ "chakra-core", "ChakraCore" ]
https://github.com/tc39/proposal-regexp-lookbehind
Implement RegExp lookbehind assertions
https://api.github.com/repos/chakra-core/ChakraCore/issues/3448/comments
2
2017-07-28T07:42:02Z
2018-11-21T17:17:50Z
https://github.com/chakra-core/ChakraCore/issues/3448
246,271,248
3,448
[ "chakra-core", "ChakraCore" ]
I've been noticing this for years and I think I reported an old connect bug along these lines, but if you take some method heavy JS and run it in different engines, Chakra always seems to come out the worst for wear and you generally need to manually inline along the hot paths to normalize performance. I was trying to evaluate the different performance of various setter/getter techniques the other day and was struck by this again: https://jsperf.com/different-setter-getter-methods-2 In this benchmark having a super simple "get" method which should be easily inlined (presumably) performs 80% slower than a direct property read in Edge (latest stable). And this kind of disparity has existed in edge/IE for years. Meanwhile if you run the same benchmark for Chrome/Safari/FF the results are much closer, and identical in some cases, seeming to indicate the method has been entirely optimized away.
Chakra doesn't seem to inline very well compared to other JS jit implementations.
https://api.github.com/repos/chakra-core/ChakraCore/issues/3442/comments
1
2017-07-27T16:41:44Z
2017-08-10T23:54:35Z
https://github.com/chakra-core/ChakraCore/issues/3442
246,101,225
3,442
[ "chakra-core", "ChakraCore" ]
Hello, I've developed COM component based on chakra engine. I'm building it one a machine where IE11 is installed. I link with jsrt.lib When I'm running it on another machine with IE11 installed it works fine, but when I come to register it on a machine with IE10 I get the following Error "The Procedure entry point JsStringToPointer could not be located in JSCRIPT9.dll" Doesn't IE10 engine support that? Is it something else? Any assistance would be appreciated. Best, Ofer
Got a message JSStringToPointer could not be located in jscript9
https://api.github.com/repos/chakra-core/ChakraCore/issues/3441/comments
3
2017-07-27T06:55:06Z
2017-08-10T23:55:57Z
https://github.com/chakra-core/ChakraCore/issues/3441
245,942,854
3,441
[ "chakra-core", "ChakraCore" ]
This may be a spec issue. However, showing 2 calls corresponding to one call in the user code might be misleading. Run the following with "ch -Intl -debugLaunch" ```js var options = { ca: "gregory", hour12: true, timeZone:"UTC" }; var dateFormat1 = new Intl.DateTimeFormat("en-US", options); /**bp:resume('step_over');locals();**/ WScript.Echo(""); var date1 = new Date(2000, 1, 1); var date2 = dateFormat1.format(date1); /**bp:resume('step_over');locals();**/ WScript.Echo(""); ``` **Actual output:** "functionCallsReturn": { "[get format returned]": "function <large string>", "[Intl.DateTimeFormat.prototype.format returned]": "string β€Ž2β€Ž/β€Ž1β€Ž/β€Ž2000" **Expected output:** "functionCallsReturn": { "[Intl.DateTimeFormat.prototype.format returned]": "string β€Ž2β€Ž/β€Ž1β€Ž/β€Ž2000"
For some Intl function calls where getters are fired, debugger shows 2 calls.
https://api.github.com/repos/chakra-core/ChakraCore/issues/3439/comments
5
2017-07-27T01:32:52Z
2017-09-07T00:38:04Z
https://github.com/chakra-core/ChakraCore/issues/3439
245,900,663
3,439
[ "chakra-core", "ChakraCore" ]
It seems an internal anonymous function call during the constructor's execution is being shown in the debugger output. Run the following with "ch -Intl -debugLaunch" ```js var options = { ca: "gregory", hour12: true, timeZone:"UTC" }; var dateFormat1 = new Intl.DateTimeFormat("en-US", options); /**bp:resume('step_over');locals();**/ WScript.Echo(""); ``` **Actual output:** "functionCallsReturn": { "[Anonymous function returned]": "undefined undefined", "[Intl.DateTimeFormat returned]": "Object {...}" **Expected output:** "functionCallsReturn": { "[Intl.DateTimeFormat returned]": "Object {...}"
Intl.js: when the outer function of Intl.js is called (Intl lazy-init), it appears in the debugger dump
https://api.github.com/repos/chakra-core/ChakraCore/issues/3438/comments
3
2017-07-27T01:23:05Z
2017-07-28T22:11:33Z
https://github.com/chakra-core/ChakraCore/issues/3438
245,899,418
3,438
[ "chakra-core", "ChakraCore" ]
Repro: build chakracore on linux: ./build.sh --cc=/usr/bin/clang --cxx=/usr/bin/clang++ --arch=amd64 --debug --static -j 8 --sanitize=address,undefined,signed-integer-overflow run `./ch -` from `/out/Debug/bin/ch` output: ==67392==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60200000eec4 at pc 0x7f4ec99064bf bp 0x7ffcc6c0ab30 sp 0x7ffcc6c0ab28 READ of size 2 at 0x60200000eec4 thread T0 #0 0x7f4ec99064be in PAL_wcslen /home/chakraut/ChakraCore/pal/src/cruntime/wchar.cpp:1212:12 #1 0x7f4ec9845b78 in Helpers::CreateTTDDirectoryAsNeeded(unsigned long*, char*, char const*, char16_t const*) /home/chakraut/ChakraCore/bin/ch/Helpers.cpp:440:41 #2 0x7f4ec98462a0 in Helpers::GetTTDDirectory(char16_t const*, unsigned long*, char*, unsigned long) /home/chakraut/ChakraCore/bin/ch/Helpers.cpp:499:5 #3 0x7f4ec9834a79 in main /home/chakraut/ChakraCore/bin/ch/ch.cpp:986:13 #4 0x7f4ec776c2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0) #5 0x7f4ec975cf79 in _start (/home/chakraut/ChakraCore/out/Debug/bin/ch/ch+0xb60f79) 0x60200000eec4 is located 12 bytes to the left of 10-byte region [0x60200000eed0,0x60200000eeda) allocated by thread T0 here: #0 0x7f4ec97fb578 in __interceptor_malloc (/home/chakraut/ChakraCore/out/Debug/bin/ch/ch+0xbff578) #1 0x7f4ec98cc577 in CorUnix::InternalMalloc(unsigned long) /home/chakraut/ChakraCore/pal/src/cruntime/malloc.cpp:114:20 #2 0x7f4ec98cc544 in PAL_malloc /home/chakraut/ChakraCore/pal/src/cruntime/malloc.cpp:98:12 #3 0x7f4ec9839204 in utf8::malloc_allocator::allocate(unsigned long) /home/chakraut/ChakraCore/lib/Common/Codex/Utf8Helper.h:128:53 #4 0x7f4ec9838cc6 in int utf8::NarrowStringToWide<void* (*)(unsigned long)>(void* (*)(unsigned long), char const*, unsigned long, char16_t**, unsigned long*, unsigned long*) /home/chakraut/ChakraCore/lib/Common/Codex/Utf8Helper.h:72:37 #5 0x7f4ec9838c4e in int utf8::NarrowStringToWide<utf8::malloc_allocator>(char const*, unsigned long, char16_t**, unsigned long*, unsigned long*) /home/chakraut/ChakraCore/lib/Common/Codex/Utf8Helper.h:122:16 #6 0x7f4ec98373a1 in utf8::NarrowStringToWideDynamic(char const*, char16_t**) /home/chakraut/ChakraCore/lib/Common/Codex/Utf8Helper.h:142:16 #7 0x7f4ec9834422 in main /home/chakraut/ChakraCore/bin/ch/ch.cpp:900:9 #8 0x7f4ec776c2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0) SUMMARY: AddressSanitizer: heap-buffer-overflow /home/chakraut/ChakraCore/pal/src/cruntime/wchar.cpp:1212:12 in PAL_wcslen Shadow bytes around the buggy address: 0x0c047fff9d80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c047fff9d90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c047fff9da0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c047fff9db0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c047fff9dc0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa =>0x0c047fff9dd0: fa fa fa fa fa fa 04 fa[fa]fa 00 02 fa fa 00 00 0x0c047fff9de0: fa fa 00 00 fa fa 06 fa fa fa 02 fa fa fa 02 fa 0x0c047fff9df0: fa fa fd fd fa fa 00 fa fa fa 04 fa fa fa 00 fa 0x0c047fff9e00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c047fff9e10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c047fff9e20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Heap right redzone: fb Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack partial redzone: f4 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==67392==ABORTING
Heap overflow in CreateTTDDirectoryAsNeeded
https://api.github.com/repos/chakra-core/ChakraCore/issues/3434/comments
6
2017-07-26T01:25:00Z
2017-08-22T15:10:04Z
https://github.com/chakra-core/ChakraCore/issues/3434
245,579,455
3,434
[ "chakra-core", "ChakraCore" ]
From ``Microsoft.ChakraCore.props``, before copying the dorrect dll to the build output, it seems that the it checks if a `packages.config` exists, which is not the case if your project is using a `project.json` file.
Nuget package Microsoft.ChakraCore doesn't work with solution that uses project.json
https://api.github.com/repos/chakra-core/ChakraCore/issues/3431/comments
1
2017-07-25T21:39:02Z
2018-05-31T00:31:57Z
https://github.com/chakra-core/ChakraCore/issues/3431
245,543,420
3,431
[ "chakra-core", "ChakraCore" ]
This commit https://github.com/Microsoft/ChakraCore/commit/9020556559a551daccc5df885cfd19f34a4716f5 added new code which casts string literal to 'uint16 *'. This is not allowed by the standard and /permissive- will catch it: JsRTApiTest.cpp(2151): error C2440: 'reinterpret_cast': cannot convert from 'const wchar_t [9]' to 'uint16_t *' The fix is (JsCreateStringUtf16 accepts 'const uint16_t *'): JsCreateStringUtf16(reinterpret_cast<uint16_t*>(_u("0\x10\x80\xa9\uabcd\U000104377")), -> JsCreateStringUtf16(reinterpret_cast<const uint16_t*>(_u("0\x10\x80\xa9\uabcd\U000104377")),
Issues found when building with MSVC + /permissive- - 3
https://api.github.com/repos/chakra-core/ChakraCore/issues/3430/comments
0
2017-07-25T19:23:04Z
2018-05-31T00:31:57Z
https://github.com/chakra-core/ChakraCore/issues/3430
245,508,191
3,430
[ "chakra-core", "ChakraCore" ]
See: https://github.com/Microsoft/ChakraCore/issues/3204#issuecomment-313806817 The current spec (and proposed, see [proposal](https://tc39.github.io/Function-prototype-toString-revision/#sec-function.prototype.tostring) also linked from the comment above) require that a the toString of a built-in function object matches the NativeFunction grammar, which states that the function name is optional (can be blank) or "the portion of the returned String that would be matched by IdentifierName must be the initial value of the name property of func" Currently, we omit the name. But I would maintain that it would be a better developer experience if we included the name. Additionally, all the Intl constructors report their name while all (AFAICT) functions omit their name from the toString. @bterlson: opinions? /cc @atulkatti
Include function name in built-in function toString (Intl functions)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3427/comments
0
2017-07-25T02:39:30Z
2018-08-28T15:50:50Z
https://github.com/chakra-core/ChakraCore/issues/3427
245,269,191
3,427
[ "chakra-core", "ChakraCore" ]
```javascript class B { set x(v) { print("B.prototype.set x"); this._x = v; } get x() { print("B.prototype.get x"); return this._x; } } class A extends B { set x(v) { print("A.prototype.set x"); super.x = v + 100; } get x() { print("A.prototype.get x"); return super.x; } } var a = new A(); a.x = 100; print(a.x); var a1 = new A(); a1.x = 100; print(a1.x); ``` Expected: ``` A.prototype.set x B.prototype.set x A.prototype.get x B.prototype.get x 200 A.prototype.set x B.prototype.set x A.prototype.get x B.prototype.get x 200 ``` Actual ``` A.prototype.set x B.prototype.set x A.prototype.get x B.prototype.get x 200 A.prototype.set x ASSERTION 15068: (lib\runtime\Language/InlineCache.inl, line 356) setterValue == nullptr || setterValue == function Failure: (setterValue == nullptr || setterValue == function) FATAL ERROR: ch.exe failed due to exception code c0000420 ```
Repeated calls to class setter triggers assertion
https://api.github.com/repos/chakra-core/ChakraCore/issues/3423/comments
2
2017-07-24T22:36:58Z
2017-08-11T18:13:32Z
https://github.com/chakra-core/ChakraCore/issues/3423
245,229,838
3,423
[ "chakra-core", "ChakraCore" ]
CCRobot found an issue on master branch; command line; ``` out/Test/ch -WERExceptionSupport -ExtendedErrorStackForTestHost -BaselineMode -forceNative -off:simpleJit -bgJitDelay:0 -dynamicprofileinput:profile.dpl.2047 -force:deferparse -args summary -endargs /home/helixbot/dotnetbuild/work/f4c635b9-0126-4e05-bca5-b9d29a52af95test/es6/default-splitscope.js ``` Output: ``` ---------------------------- ---------------------------- exit code: -11 ``` It is hard to repro. The bug possibly introduced into master branch late last week.
crash: es6/default-splitscope.js crashes randomly [master]
https://api.github.com/repos/chakra-core/ChakraCore/issues/3419/comments
2
2017-07-23T18:35:50Z
2018-05-31T00:31:57Z
https://github.com/chakra-core/ChakraCore/issues/3419
244,927,682
3,419
[ "chakra-core", "ChakraCore" ]
Both IE and Edge is missing `tooShort` property of `validity` property. See [ValidityState specification](https://www.w3.org/TR/html5/forms.html#validitystate) and [compare with MSDN](https://msdn.microsoft.com/en-us/library/hh772951(v=vs.85).aspx). Meaning of `tooShort` from spec: > Suffering from being too short > > When a control has a value that is too short for the form control `minlength` attribute (input `minlength`, textarea `minlength`).
validity property of type ValidityState is missing tooShort property
https://api.github.com/repos/chakra-core/ChakraCore/issues/3410/comments
3
2017-07-20T23:45:18Z
2017-07-31T23:18:50Z
https://github.com/chakra-core/ChakraCore/issues/3410
244,527,008
3,410
[ "chakra-core", "ChakraCore" ]
There are a number of cases that are currently not working properly, for example: ```js function foo(a = function () { }) { return a; } print(foo().name); ``` Expected: 'a' Actual: '' This appears to be fixed with the ES6FunctionName flag - we should consider enabling this. Anyone know why this isn't yet enabled?
Enable ES6 function name inference
https://api.github.com/repos/chakra-core/ChakraCore/issues/3407/comments
6
2017-07-20T22:03:18Z
2020-03-25T17:13:13Z
https://github.com/chakra-core/ChakraCore/issues/3407
244,509,733
3,407
[ "chakra-core", "ChakraCore" ]
The proposal is stage 3 and will very likely be in ES2018. Object rest and spread are very useful tools (especially in some ecosystems like React) and idioms from it are becoming more common (eg. shallow copy via `let copy = { ... otherObj };`) Specification text: https://github.com/tc39/proposal-object-rest-spread
Implement Object Rest & Spread
https://api.github.com/repos/chakra-core/ChakraCore/issues/3406/comments
19
2017-07-20T21:44:10Z
2019-07-01T19:16:30Z
https://github.com/chakra-core/ChakraCore/issues/3406
244,505,438
3,406
[ "chakra-core", "ChakraCore" ]
```js let x; eval('var x'); ``` Expected: early syntax error when doing EvalDeclarationInstantiation Actual: Runtime Let/Const Redeclaration error.
Direct eval variable declaration with same name as outer lexical binding should be early syntax error
https://api.github.com/repos/chakra-core/ChakraCore/issues/3405/comments
0
2017-07-20T21:34:31Z
2019-06-07T18:26:25Z
https://github.com/chakra-core/ChakraCore/issues/3405
244,503,400
3,405
[ "chakra-core", "ChakraCore" ]
```js Object.defineProperty(this, 'f', { enumerable: true, writable: true, configurable: false }); print(JSON.stringify(Object.getOwnPropertyDescriptor(this, 'f'))); eval('function f() { return 2222; }'); print(JSON.stringify(Object.getOwnPropertyDescriptor(this, 'f'))); ``` Expected: descriptor doesn't change Actual: descriptor changes from configurable false to configurable true
Global declarations created inside eval should not change configurability of existing properties
https://api.github.com/repos/chakra-core/ChakraCore/issues/3404/comments
0
2017-07-20T21:29:46Z
2018-08-01T00:41:52Z
https://github.com/chakra-core/ChakraCore/issues/3404
244,502,374
3,404
[ "chakra-core", "ChakraCore" ]
String properties should be enumerated in creation order. For classes, this should be `length`, `prototype`, string-based static keys of the class, and finally `name`.
Enumeration order of class properties is incorrect
https://api.github.com/repos/chakra-core/ChakraCore/issues/3396/comments
0
2017-07-19T21:58:52Z
2019-06-07T19:08:50Z
https://github.com/chakra-core/ChakraCore/issues/3396
244,186,771
3,396
[ "chakra-core", "ChakraCore" ]
Given something of the form: ```js { function foo() { } function foo() { } } ``` where either function might be a regular function, generator, async function, or class: Expected: error (static semantics contains duplicate lexical declaration) Actual: no error
Declarations (other than var) within the same block should throw in all modes
https://api.github.com/repos/chakra-core/ChakraCore/issues/3395/comments
0
2017-07-19T21:35:00Z
2019-06-07T18:43:26Z
https://github.com/chakra-core/ChakraCore/issues/3395
244,181,472
3,395
[ "chakra-core", "ChakraCore" ]
```js function foo(a) { Object.defineProperty(arguments, "0", {configurable: false}); var args = arguments; (function() { "use strict"; delete args[0]; })(); } foo(1); ``` Expected: TypeError, deleting non-configurable property in strict mode Actual: No error
Arguments object properties should throw an error when non-configurable
https://api.github.com/repos/chakra-core/ChakraCore/issues/3394/comments
2
2017-07-19T21:02:00Z
2019-06-07T18:43:18Z
https://github.com/chakra-core/ChakraCore/issues/3394
244,172,989
3,394
[ "chakra-core", "ChakraCore" ]
The spec does not require that these are present as of ES2017 (see the [final note](https://tc39.github.io/ecma262/#sec-arguments-exotic-objects) of this clause).
Remove strict mode poisoning of 'caller' from arguments object
https://api.github.com/repos/chakra-core/ChakraCore/issues/3393/comments
2
2017-07-19T20:23:59Z
2017-07-28T17:12:18Z
https://github.com/chakra-core/ChakraCore/issues/3393
244,162,917
3,393
[ "chakra-core", "ChakraCore" ]
Seems this option was added after Dev12 (compiler toolchain used by the legacy configuration). `cl : Command line warning D9002: ignoring unknown option '-Zc:implicitNoexcept-'` See: https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.6/job/daily_dev12_x86_debug/36
[Legacy config] cl : Command line warning D9002: ignoring unknown option '-Zc:implicitNoexcept-'
https://api.github.com/repos/chakra-core/ChakraCore/issues/3388/comments
1
2017-07-18T21:24:41Z
2018-03-01T05:00:10Z
https://github.com/chakra-core/ChakraCore/issues/3388
243,856,090
3,388
[ "chakra-core", "ChakraCore" ]
https://github.com/Microsoft/ChakraCore/wiki/Build-Status-%28release-1.6%29#legacy-builds https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.6/job/daily_dev12_x86_debug/ ``` D:\j\workspace\daily_dev12_x---006604c1\lib\Runtime\Language\i386\AsmJsJitTemplate.cpp(534): error C2220: warning treated as error - no 'object' file generated [D:\j\workspace\daily_dev12_x---006604c1\lib\Runtime\Language\Chakra.Runtime.Language.vcxproj] 06:16:41 D:\j\workspace\daily_dev12_x---006604c1\lib\Runtime\Language\i386\AsmJsJitTemplate.cpp(534): warning C4189: 'simdConstCount' : local variable is initialized but not referenced [D:\j\workspace\daily_dev12_x---006604c1\lib\Runtime\Language\Chakra.Runtime.Language.vcxproj] 06:16:41 D:\j\workspace\daily_dev12_x---006604c1\lib\Runtime\Language\i386\AsmJsJitTemplate.cpp(540): warning C4189: 'simdByteOffset' : local variable is initialized but not referenced [D:\j\workspace\daily_dev12_x---006604c1\lib\Runtime\Language\Chakra.Runtime.Language.vcxproj] ``` Starting in: https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.6/job/daily_dev12_x86_debug/36/ See: https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.6/job/daily_dev12_x86_debug/changes Remove SIMD tests (commit: 2b923b6) β€” saagarwa / githubweb Remove Simd.js code from ChakraCore - Part 1 (ifdef out) (commit: 00fc551) β€” saagarwa / githubweb
[Legacy x86 debug 1.6, 1.7, master] Build failure (warn as error: unused variable) related to SIMD code removal
https://api.github.com/repos/chakra-core/ChakraCore/issues/3387/comments
0
2017-07-18T21:16:56Z
2017-07-19T01:00:12Z
https://github.com/chakra-core/ChakraCore/issues/3387
243,854,199
3,387
[ "chakra-core", "ChakraCore" ]
```js 'use strict'; var \u0079ield = 1 ``` Expected: SyntaxError (yield is a reserved identifier) Actual: No Error
Yield created with an escape sequence should be an error in strict mode
https://api.github.com/repos/chakra-core/ChakraCore/issues/3376/comments
0
2017-07-17T18:32:31Z
2017-07-21T18:55:12Z
https://github.com/chakra-core/ChakraCore/issues/3376
243,485,781
3,376
[ "chakra-core", "ChakraCore" ]
```js (0, eval)('function f() { }'); print(JSON.stringify(Object.getOwnPropertyDescriptor(this, 'f'))); ``` Expected: {"writable":true,"enumerable":true,"configurable":true} Actual: {"writable":true,"enumerable":true,"configurable": *false*} See [EDI](https://tc39.github.io/ecma262/#sec-evaldeclarationinstantiation)'s exclusive use of CreateMutableBinding.
Properties of the global object created from function declarations in indirect eval should be configurable
https://api.github.com/repos/chakra-core/ChakraCore/issues/3375/comments
1
2017-07-17T18:24:29Z
2018-05-31T00:31:57Z
https://github.com/chakra-core/ChakraCore/issues/3375
243,483,648
3,375
[ "chakra-core", "ChakraCore" ]
Eshost Repro: ```js Object.defineProperty( this, 'data1', { configurable: false, value: 0, writable: true, enumerable: false } ); let cmpn = $.evalScript(` var x; function data1() { } `); print(cmpn.type); ``` Expected: throw (of a TypeError per [GDI](https://tc39.github.io/ecma262/#sec-globaldeclarationinstantiation)) Actual: Normal, function shadowing is allowed.
Function declarations should not shadow non-enumerable non-configurable properties of the global object
https://api.github.com/repos/chakra-core/ChakraCore/issues/3374/comments
1
2017-07-17T18:10:54Z
2018-06-06T18:44:26Z
https://github.com/chakra-core/ChakraCore/issues/3374
243,480,003
3,374
[ "chakra-core", "ChakraCore" ]
It is presently a reference error. Other identifier names appear to throw the proper error. ```js let undefined; ``` Actual: ReferenceError Expected: SyntaxError (normal let-const redecl error)
Lexical declaration of `undefined` in global scope should result in SyntaxError
https://api.github.com/repos/chakra-core/ChakraCore/issues/3373/comments
0
2017-07-17T17:57:58Z
2018-06-27T23:09:41Z
https://github.com/chakra-core/ChakraCore/issues/3373
243,476,609
3,373
[ "chakra-core", "ChakraCore" ]
```js Object.preventExtensions(this); $.evalScript(`let foo = 1`); print(foo); ``` Expected: 1 Actual: `undefined` or an error depending on strictness.
Lexical declarations should be shared when global object is non-extensible
https://api.github.com/repos/chakra-core/ChakraCore/issues/3372/comments
0
2017-07-17T17:53:15Z
2018-07-23T18:51:19Z
https://github.com/chakra-core/ChakraCore/issues/3372
243,475,303
3,372
[ "chakra-core", "ChakraCore" ]
Is presently a runtime reference error. `super()` has the proper error, however. ```js super.foo ``` Expected: Early syntax error Actual: Runtime reference error
Super property reference in global scope should be an early syntax error
https://api.github.com/repos/chakra-core/ChakraCore/issues/3371/comments
2
2017-07-17T17:36:10Z
2020-03-31T16:03:21Z
https://github.com/chakra-core/ChakraCore/issues/3371
243,470,833
3,371
[ "chakra-core", "ChakraCore" ]
[test.zip](https://github.com/Microsoft/ChakraCore/files/1153306/test.zip) Open the attached test.html Expected: you should see message `Complete without errors`. Actual: the message `Error in pass ????: if-condition is true instead of false` is shown. This comparison of two constants occasionally evaluates to `true` instead of `false`: `if ((UNSIGNED32 >>> 0) !== (SIGNED32 >>> 0))`
The >>> operator returns incorrect result
https://api.github.com/repos/chakra-core/ChakraCore/issues/3370/comments
1
2017-07-17T16:34:57Z
2017-07-21T00:30:05Z
https://github.com/chakra-core/ChakraCore/issues/3370
243,454,457
3,370
[ "chakra-core", "ChakraCore" ]
run `Symbol.species.toString()` expected result: **Symbol(Symbol.species)** ChakraCore-release-1.6 result: **Symbol([Symbol.species])** run `Symbol.match.toString();` or `Symbol.replace.toString();` or `Symbol.search.toString();` or `Symbol.split.toString();` expected result: **Symbol(Symbol.match)** ... ChakraCore-release-1.6 result: **TypeError: Unable to get property 'toString' of undefined or null reference at Global code**
Incorrect realization of Symbol.xxx.toString()
https://api.github.com/repos/chakra-core/ChakraCore/issues/3368/comments
2
2017-07-17T13:49:03Z
2017-07-21T18:55:51Z
https://github.com/chakra-core/ChakraCore/issues/3368
243,401,496
3,368
[ "chakra-core", "ChakraCore" ]
Hello, the documentation for _FetchImportedModuleFromScriptCallBack_ is copy and pasted from _NotifyModuleReadyCallback_. Could this be fixed with correct documentation? This would be very helpful. You can check yourself: https://github.com/Microsoft/ChakraCore/blob/master/lib/Jsrt/ChakraCore.h#L70-L83
Jsrt documentation is incorrect
https://api.github.com/repos/chakra-core/ChakraCore/issues/3367/comments
5
2017-07-16T16:00:07Z
2018-01-23T01:19:09Z
https://github.com/chakra-core/ChakraCore/issues/3367
243,248,622
3,367
[ "chakra-core", "ChakraCore" ]
I think in https://stackoverflow.com/questions/45122823/is-there-any-reason-why-edge-returns-true-for-xml-i-testxml-version I have found a bug with the regular expression `test` method in the Javascript engine of Edge 40.15063.0.0. ``` var xml = '<?'; var regex = /^.+<\?/i; var test = regex.test(xml); ``` As there is no character at all before the `<` less-than sign in the input string the match `^.+` should not match anything and therefore that `test` call should return `false` and not `true` as it does in the cited Edge version.
/^.+<\?/i.test('<?') gives true in Edge 40.15063.0.0 but false in other browsers/engines
https://api.github.com/repos/chakra-core/ChakraCore/issues/3366/comments
4
2017-07-16T09:22:09Z
2017-07-20T23:53:04Z
https://github.com/chakra-core/ChakraCore/issues/3366
243,228,052
3,366
[ "chakra-core", "ChakraCore" ]
```html <!DOCTYPE html> <html> <head> </head> <body> <script type="module"> import; // expected: syntax error, actual: Exception thrown and not caught console.log(test); </script> </body> </html> ``` ```html <!DOCTYPE html> <html> <head> </head> <body> <script type="module"> import test from "./test.js"; // expected: syntax error, actual: silent failure console.log(test); </script> </body> </html> ``` ```javascript // test.js var a = 0; export { a as default }; import; // line with syntax error ```
Module syntax errors not showing properly
https://api.github.com/repos/chakra-core/ChakraCore/issues/3357/comments
5
2017-07-14T20:48:58Z
2020-03-31T15:58:10Z
https://github.com/chakra-core/ChakraCore/issues/3357
243,108,596
3,357
[ "chakra-core", "ChakraCore" ]
I am encountering a lot of problems when trying to use WScript.LoadModule, mostly due to very different behavior between jshost and ch. ### ch.exe - [ ] Memory leak on Syntax error with multiple modules ```js WScript.LoadModule(``); WScript.LoadModule(`//as`); WScript.LoadModule(`const a = () -> {};`); ``` ### Jshost.exe - [ ] Assert, nullptr A/V when trying to load the same script twice ```js WScript.LoadModule(""); WScript.LoadModule(""); ``` - [ ] Doesn't support giving a filename as third argument for subsequent imports ```js WScript.LoadModule(`export default 5;`, "self", "mod1.js"); WScript.LoadModule(` import mod1 from "mod1.js"; console.log(\`First Module result: \${mod1}\`); `); ```
WScript.LoadModule inconsistencies
https://api.github.com/repos/chakra-core/ChakraCore/issues/3356/comments
0
2017-07-14T19:24:06Z
2019-06-07T18:52:48Z
https://github.com/chakra-core/ChakraCore/issues/3356
243,088,867
3,356
[ "chakra-core", "ChakraCore" ]
Currently asm.js has numerous problems in es6 modules. - [ ] Support reparsing without asm.js on validation error (currently throws) ```js WScript.LoadModule(` function asmModule() { "use asm" function x(v) { v = v | 0; return v | 0; } }`); ``` - [ ] Add support for asm.js module in default export ```js WScript.LoadModule(` export default function AsmDefaultExport() { "use asm" function x(v) { v = v | 0; return v | 0; } return x; }`) ``` - [ ] Fix nullptr A/V in JSRT api when trying to use asm.js in module (can repro with `ch` or `jshost -jsrt`) ```js WScript.LoadModule(` function AsmModule() { "use asm" function x(v) { v = v | 0; return v | 0; } return x; }`) ```
Fix asm.js in ES6 Modules
https://api.github.com/repos/chakra-core/ChakraCore/issues/3355/comments
2
2017-07-14T19:08:56Z
2018-05-31T00:31:57Z
https://github.com/chakra-core/ChakraCore/issues/3355
243,085,300
3,355
[ "chakra-core", "ChakraCore" ]
I compiled ChakraCore using the official build guide. On ubuntu 16.04, ch crashes with the following test case. I also noticed that if we slightly change the code (using a proper indentation), the Seg fault will be gone. The hashtag of my chakracore build is commit cb9c8271c8c9e2a0daec635504b5279168d92f1b $ ~/chakracore/ChakraCore/out/Release/ch abc.js Segmentation fault (core dumped) $ cat abc.js ``` function run () {} WScript.Attach(run) WScript . Detach ( run ) ```
xplat: Enable JIT for debugging
https://api.github.com/repos/chakra-core/ChakraCore/issues/3352/comments
1
2017-07-14T06:33:20Z
2018-01-03T21:16:06Z
https://github.com/chakra-core/ChakraCore/issues/3352
242,909,772
3,352
[ "chakra-core", "ChakraCore" ]
Once #3341 is merged and ported to release/1.6. Re-enable test `test/wasm/params.js`. A functional bug was preventing this test from running correctly in release/1.5 which was fixed in release/1.6.
Re-enable test in release/1.6 after 17-07 servicing release
https://api.github.com/repos/chakra-core/ChakraCore/issues/3344/comments
0
2017-07-13T17:55:34Z
2017-07-17T16:46:15Z
https://github.com/chakra-core/ChakraCore/issues/3344
242,781,630
3,344
[ "chakra-core", "ChakraCore" ]
It is similar to the second issue in https://github.com/Microsoft/ChakraCore/issues/2862. ch.cpp(877): error C2362: initialization of 'initRpcServer' is skipped by 'goto cleanup' Revision https://github.com/Microsoft/ChakraCore/commit/e8f31729a0e8f04a68269698680657698e918053#diff-9aa417ac81c06da693354e50d1edd449 introduces 'goto', but this skips the local variable 'initRpcServer' and is ill-formed. Either use RAII or put the variable into a separate scope. @xiaoyinl
Issues found when building with MSVC + /permissive- - 2
https://api.github.com/repos/chakra-core/ChakraCore/issues/3343/comments
0
2017-07-13T17:44:13Z
2017-07-13T22:37:16Z
https://github.com/chakra-core/ChakraCore/issues/3343
242,778,750
3,343
[ "chakra-core", "ChakraCore" ]
```javascript class c1 { Β Β Β  constructor() { Β Β Β Β Β Β Β  return { }; Β Β Β  } }; class c2 extends c1 { Β Β Β  constructor(a = 1, b = () => { a; super(); }) { Β Β Β Β Β Β Β  super(); Β Β Β Β Β Β Β  b(); // Should throw Β Β Β Β Β Β Β  return {}; Β Β Β  } } new c2(); ```
Should throw a TypeError when super is called through a lambda defined in param scope after super is called in the body
https://api.github.com/repos/chakra-core/ChakraCore/issues/3335/comments
1
2017-07-13T00:26:00Z
2017-10-04T19:54:10Z
https://github.com/chakra-core/ChakraCore/issues/3335
242,552,706
3,335
[ "chakra-core", "ChakraCore" ]
We are correct according to the spec (both current and proposed), but all other engines include the name of the function in the toString, whereas we do not. /cc @bterlson ``` > eshost -h d8,node,sm,jsc,ch-dev-che3 -its .\test.js ## Source print('' + Intl.DateTimeFormat.supportedLocalesOf); print('' + Intl.getCanonicalLocales); β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” β”‚ d8 β”‚ function supportedLocalesOf() { [native code] } β”‚ β”‚ node β”‚ function getCanonicalLocales() { [native code] } β”‚ β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€ β”‚ jsc β”‚ function supportedLocalesOf() { β”‚ β”‚ sm β”‚ [native code] β”‚ β”‚ β”‚ } β”‚ β”‚ β”‚ function getCanonicalLocales() { β”‚ β”‚ β”‚ [native code] β”‚ β”‚ β”‚ } β”‚ β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€ β”‚ ch-dev-che3 β”‚ function() { β”‚ β”‚ β”‚ [native code] β”‚ β”‚ β”‚ } β”‚ β”‚ β”‚ function() { β”‚ β”‚ β”‚ [native code] β”‚ β”‚ β”‚ } β”‚ β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜ ``` https://github.com/Microsoft/ChakraCore/issues/3204#issuecomment-313806817: > See https://tc39.github.io/Function-prototype-toString-revision/#sec-function.prototype.tostring for a revision to the relevant spec text. > > The gist is: in both old and new spec text, the function name is optional. Old: name can be anything. New: if included, the name must match the actual name of the function. The following two options (and variations of whitespace therein) are allowed: > > ``` > function() { > [native code] > } > > function name() { > [native code] > } > ```
Native function toString is inconsistent with other engines
https://api.github.com/repos/chakra-core/ChakraCore/issues/3332/comments
1
2017-07-13T00:02:46Z
2020-03-31T16:00:23Z
https://github.com/chakra-core/ChakraCore/issues/3332
242,549,552
3,332
[ "chakra-core", "ChakraCore" ]
* Move to `tools/*/<scripts>` * Reduce duplication. See https://github.com/Microsoft/ChakraCore/pull/3323#discussion_r127020344
Refactor bytecode regen scripts
https://api.github.com/repos/chakra-core/ChakraCore/issues/3330/comments
2
2017-07-12T22:33:16Z
2021-02-01T08:51:04Z
https://github.com/chakra-core/ChakraCore/issues/3330
242,535,363
3,330
[ "chakra-core", "ChakraCore" ]
``` auto str = "function test(){}" auto fn = JsRun str JsValueRef info = JS_INVALID_REFERENCE auto result = JsDiagGetFunctionPosition fn, &info ``` is ok. ``` auto str = "function test(){ console.log(""); console.log(""); console.log(""); console.log(""); ... repeat 200 ...// need more in your computer maybe console.log(""); } auto fn = JsRun str JsValueRef info = JS_INVALID_REFERENCE auto result = JsDiagGetFunctionPosition fn, &info ``` assert at FunctionBody:1757 of ChakraCore Release 1.5.2 Assert(IsFunctionBody()); 0x00007FFE610D72F8 (ChakraCore.dll) test.exe 0xC0000420: Assertion Failure。
about JsDiagGetFunctionPosition. This maybe a bug.
https://api.github.com/repos/chakra-core/ChakraCore/issues/3325/comments
1
2017-07-12T07:04:32Z
2019-06-07T19:13:29Z
https://github.com/chakra-core/ChakraCore/issues/3325
242,279,665
3,325
[ "chakra-core", "ChakraCore" ]
WScriptJsrt uses global states to store sourceContext and maps for moduleRecords, etc.. Changes must be made to support cross-thread scenarios: 1) Module-related maps must be per JsContext to provide isolation between threads 2) Module-related maps have the same lifetime as JsContext 3) Code that updates sourceContext must be locked with critical sections
ch.exe's global states (e.g. sourceContext, module*Map) need to change to work cross-thread
https://api.github.com/repos/chakra-core/ChakraCore/issues/3319/comments
0
2017-07-11T17:44:40Z
2018-03-17T00:33:21Z
https://github.com/chakra-core/ChakraCore/issues/3319
242,129,127
3,319
[ "chakra-core", "ChakraCore" ]
```javascript // mod0.js console.log("mod0"); ``` ```javascript // bug0.js // expected: mod0 // actual: ASSERTION (bin\ch\WScriptJsrt.h, line 83) false Unexpected JsErrorCode: JsErrorWrongThread WScript.LoadScript(`WScript.LoadScriptFile("./mod0.js", "module");`, "crossthread"); ``` ```javascript // bug1.js // expected: mod0 // actual: ASSERTION 256420: (e:\sdxgit3\inetcore\jscript\core\lib\common\Memory/Recycler.inl, line 53) Allocating from the recycler can only be done on the main thread WScript.LoadScript(`import("./mod0.js");`, "crossthread"); ```
ch.exe doesn't support module load cross-thread
https://api.github.com/repos/chakra-core/ChakraCore/issues/3318/comments
3
2017-07-11T17:11:26Z
2018-03-17T00:33:21Z
https://github.com/chakra-core/ChakraCore/issues/3318
242,120,147
3,318
[ "chakra-core", "ChakraCore" ]
Hit this bug while working on #3257. To check in fix as part of #3284. ```javascript // bug.js WScript.LoadScriptFile("./mod0.js", "module"); WScript.LoadScriptFile("./script0.js"); ``` ```javascript // mod0.js import './mod1.js'; import './mod2.js'; console.log("mod0"); ``` ```javascript // mod1.js import './mod2.js'; console.log("mod1"); ``` ```javascript // mod2.js import './mod0.js'; console.log("mod2"); ``` ```javascript // script0.js console.log("script0"); import('./mod1.js'); import('./mod2.js'); ``` Expected: ```javascript script0 mod2 mod1 mod0 ``` Actual ```javascript script0 ASSERTION 179256: (lib\Runtime\Language\SourceTextModuleRecord.cpp, line 817) moduleRecord->WasParsed() Failure: (moduleRecord->WasParsed()) FATAL ERROR: ch.exe failed due to exception code c0000420 ```
Module: premature instantiation of dynamic import modules
https://api.github.com/repos/chakra-core/ChakraCore/issues/3306/comments
0
2017-07-08T01:53:33Z
2017-07-11T23:37:13Z
https://github.com/chakra-core/ChakraCore/issues/3306
241,416,708
3,306
[ "chakra-core", "ChakraCore" ]
Discovered in #3303 Restoring the .gitattributes caused a bunch of tests to start failing -- probably baselines which were checked in since .gitattributes changed. See: https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.6/job/x64_debug_prtest/341/ See https://github.com/dilijev/ChakraCore/tree/gitattr for the commit to restore .gitattributes. /cc @tcare
.gitattributes missing
https://api.github.com/repos/chakra-core/ChakraCore/issues/3305/comments
2
2017-07-07T22:29:55Z
2017-07-10T23:22:14Z
https://github.com/chakra-core/ChakraCore/issues/3305
241,396,378
3,305
[ "chakra-core", "ChakraCore" ]
```js // Dynamic functions var x = "function(a, b, c) { console.log('hello'); }"; var func = new Function(x); ``` Today, for above code, we [create a pid hash table](https://github.com/Microsoft/ChakraCore/blob/master/lib/Parser/Parse.cpp#L11287-L11289) while validating syntax for formals (`(a,b,c)`) and for function body (`return a+b+c;`) [here](https://github.com/Microsoft/ChakraCore/blob/master/lib/Runtime/Library/JavascriptFunction.cpp#L217-L229). Finally we do the actual parsing of dynamic function (`function anonymous(a,b,c ) {return a+b+c; }`) and generate bytecode. We can avoid creating separate hash table for each validation/parsing and just have single instance of Parser doing these validation and parsing. With that we can save 50% of allocation / free of CRT heap. Below ETW profile shows the impacting size for creating these hash tables by `ValidateSyntax` method. As seen below, if we just have 1 hash table for parsing and validating formals , function body, we can reduce memory allocation/freeing by 50%. So it should give some speed-up because of less malloc/free calls. ![image](https://user-images.githubusercontent.com/12488060/27971893-3b8b0282-6309-11e7-9c03-a2fc45c5d67a.png) Above screen shot doesn't show impacting size for actual entries that are inserted in hash table. Once we share hash tables, we will also avoid allocation for these entries repeatedly. Other scenarios for which similar code path is hit are: ```js // async functions var AsyncFunction = Object.getPrototypeOf(async function () { }).constructor; var af = new AsyncFunction('return await Promise.resolve(0);'); // generator function var GeneratorFunction = Object.getPrototypeOf(function* () { }).constructor; var gf = new GeneratorFunction('yield 1; return 0;'); ```
Reuse of pid hashtable of parser for DynamicFunction
https://api.github.com/repos/chakra-core/ChakraCore/issues/3302/comments
0
2017-07-07T18:44:45Z
2017-08-15T21:33:58Z
https://github.com/chakra-core/ChakraCore/issues/3302
241,347,809
3,302
[ "chakra-core", "ChakraCore" ]
Hi, We found an failed assertion in the ChakraCore interpreter (ch) when you run the following test case: ``` WScript = {}; WScript.Echo = console.log; $ERROR = console.log; assert = {}; assert.sameValue = function (x ,y ,z) { return x == y; }; assert.notSameValue = function (x,y,z) { return not(x == y); }; assert.throws = function (x,f) { f(); }; testOption = function (x) { }; assert.sameValue(Function.prototype[Symbol.hasInstance].call(0) ,false); assert.sameValue(Function.prototype[Symbol.hasInstance].call({}) ,false); ``` It was tested in Ubuntu 16.04 using the git revision 52dfe7bc146b70b326ed6e9f521bffa9f902bb2b. To reproduce: ``` $ gdb --args ./ch test.js ... ASSERTION 19687: (/home/gustavo/repos/ChakraCore/lib/Jsrt/../Runtime/Types/RecyclableObject.inl, line 29) Ensure instance is a RecyclableObject Failure: (Is(aValue)) Thread 1 "ch" received signal SIGILL, Illegal instruction. 0x000055555644937c in Js::RecyclableObject::FromVar (aValue=0x1000000000000) at /home/gustavo/repos/ChakraCore/lib/Jsrt/../Runtime/Types/RecyclableObject.inl:29 29 AssertMsg(Is(aValue), "Ensure instance is a RecyclableObject"); (gdb) bt #0 0x000055555644937c in Js::RecyclableObject::FromVar (aValue=0x1000000000000) at /home/gustavo/repos/ChakraCore/lib/Jsrt/../Runtime/Types/RecyclableObject.inl:29 #1 0x00005555579cafb0 in Js::JavascriptFunction::EntrySymbolHasInstance (function=0x7ffff0744b80, callInfo=...) at /home/gustavo/repos/ChakraCore/lib/Runtime/Library/JavascriptFunction.cpp:3296 #2 0x0000555557ea102e in amd64_CallFunction () at /home/gustavo/repos/ChakraCore/lib/Runtime/Library/amd64/JavascriptFunctionA.S:100 #3 0x00005555579ce314 in Js::JavascriptFunction::CallFunction<true> (function=0x7ffff0744b80, entryPoint=0x5555579ca8e0 <Js::JavascriptFunction::EntrySymbolHasInstance(Js::RecyclableObject*, Js::CallInfo, ...)>, args=...) at /home/gustavo/repos/ChakraCore/lib/Runtime/Library/JavascriptFunction.cpp:1353 #4 0x00005555579b92e7 in Js::JavascriptFunction::EntryCall (function=0x7ffff0744a40, callInfo=...) at /home/gustavo/repos/ChakraCore/lib/Runtime/Library/JavascriptFunction.cpp:649 #5 0x0000555557ea102e in amd64_CallFunction () at /home/gustavo/repos/ChakraCore/lib/Runtime/Library/amd64/JavascriptFunctionA.S:100 #6 0x00005555579ce314 in Js::JavascriptFunction::CallFunction<true> (function=0x7ffff0744a40, entryPoint=0x5555579b8740 <Js::JavascriptFunction::EntryCall(Js::RecyclableObject*, Js::CallInfo, ...)>, args=...) at /home/gustavo/repos/ChakraCore/lib/Runtime/Library/JavascriptFunction.cpp:1353 #7 0x00005555576441e7 in Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > > (this=0x7fffffffadc0, playout=0x7ffff07200ac, function=0x7ffff0744a40, flags=2, spreadIndices=0x0) at /home/gustavo/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:3904 #8 0x0000555557643663 in Js::InterpreterStackFrame::OP_ProfileCallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > > (this=0x7fffffffadc0, playout=0x7ffff07200ac, function=0x7ffff0744a40, flags=0, profileId=1, inlineCacheIndex=9, spreadIndices=0x0) at /home/gustavo/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:3928 #9 0x00005555575a6321 in Js::InterpreterStackFrame::OP_ProfiledCallIWithICIndex<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > (this=0x7fffffffadc0, playout=0x7ffff07200ac, flags=0) at /home/gustavo/repos/ChakraCore/lib/Runtime/./Language/InterpreterStackFrame.h:460 #10 0x00005555572b75a1 in Js::InterpreterStackFrame::ProcessProfiled (this=0x7fffffffadc0) at /home/gustavo/repos/ChakraCore/lib/Runtime/Language/InterpreterHandler.inl:86 #11 0x0000555557202aa9 in Js::InterpreterStackFrame::Process (this=0x7fffffffadc0) at /home/gustavo/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:3454 #12 0x0000555557201184 in Js::InterpreterStackFrame::InterpreterHelper (function=0x7ffff272c2a0, args=..., returnAddress=0x7ffff0700fa2, addressOfReturnAddress=0x7fffffffb988, isAsmJs=false) at /home/gustavo/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:2054 #13 0x00005555571ff224 in Js::InterpreterStackFrame::InterpreterThunk (layout=0x7fffffffb9a0) at /home/gustavo/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:1789 #14 0x00007ffff0700fa2 in ?? () ``` This issue was found using QuickFuzz. Regards, Gustavo.
Assertion failed at lib/Runtime/Types/RecyclableObject.inl
https://api.github.com/repos/chakra-core/ChakraCore/issues/3299/comments
1
2017-07-07T13:38:22Z
2017-07-12T01:34:13Z
https://github.com/chakra-core/ChakraCore/issues/3299
241,266,544
3,299
[ "chakra-core", "ChakraCore" ]
I can't find any examples of how to use JsConstructObject in the ChakraSamples repo. In particular, I'm curious what the arguments array needs to look like.... can I pass any object as the first argument, or does it need to be a newly created one that the constructor can fill by referring to 'this'?
[Question] JsConstructObject, examples of use?
https://api.github.com/repos/chakra-core/ChakraCore/issues/3293/comments
14
2017-07-06T02:27:45Z
2018-04-27T22:22:17Z
https://github.com/chakra-core/ChakraCore/issues/3293
240,827,174
3,293
[ "chakra-core", "ChakraCore" ]
I am trying to build x64 Debug ChakraCore from source, here's my setup: - Windows 10.0.14393 - Visual Studio 2015 Pro 14.0.25431.01 Update 3 - Windows SDK 10.0.15063.468 - I've checkout the most recent source using git in the folder P:\dev\ChakraCore (_Note that I have build ChakraCore on this machine successfully before, but that was just over a month ago. Because the build failed, and I was unable to fix it, I deleted all the files in ChakraCore source folder and downloaded them again using git. After it still failed, I try "repairing" my Visual Studio install and removed and reinstalled the Windows SDK. Despite all this, I am still unable to build._) For brevity, I will only include the first error I see: ``` 1>------ Build started: Project: Chakra.JITIDL, Configuration: Debug x64 ------ 2>------ Build started: Project: CoreManifests, Configuration: Debug x64 ------ 3>------ Build started: Project: wabt, Configuration: Debug x64 ------ 4>------ Build started: Project: Chakra.Common.Codex, Configuration: Debug x64 ------ 5>------ Build started: Project: Chakra.Common.Util, Configuration: Debug x64 ------ 6>------ Build started: Project: Chakra.Common.Exceptions, Configuration: Debug x64 ------ 7>------ Skipped Build: Project: pal, Configuration: Debug x64 ------ 7>Project not selected to build for this solution configuration 8>------ Build started: Project: rl, Configuration: Debug x64 ------ 1>Build started 04-07-2017 18:05:54. 1> 1> 1>InitializeBuildStatus: 1> Touching "P:\dev\ChakraCore\Build\VcBuild\obj\x64_debug\Chakra.JITIDL\Chakra.JITIDL.tlog\unsuccessfulbuild". 2>Build started 04-07-2017 18:05:55. 1> 1> 1>TRACKER : error TRK0005: Failed to locate: "midl.exe". The system cannot find the file specified. ``` It appears that midl.exe cannot be found. This is part of the Windows SDK and can be found on my computer in the following locations: ``` C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\arm64\midl.exe C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x64\midl.exe C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x86\midl.exe ``` I have no idea why it cannot find this file; can anybody explain why it would not be able to find it even though it is right there in the location where you would expect it to be?
Windows: Cannot build
https://api.github.com/repos/chakra-core/ChakraCore/issues/3287/comments
9
2017-07-04T16:12:42Z
2017-09-10T13:56:50Z
https://github.com/chakra-core/ChakraCore/issues/3287
240,461,089
3,287
[ "chakra-core", "ChakraCore" ]
Hi, We found an failed assertion in the ChakraCore interpreter (ch) when you run the following test case: ``` function foo() { var x = "bp A"; x; x = "Hit loc B"; x; x = "bp C, BUG"; x; x = "bp D, BUG"; x; x = "bp D"; x; } WScript.Attach(foo); WScript.Detach(foo); WScript.Attach(foo); WScript.Echo("pass"); ``` It was tested in Ubuntu 16.04 using the last git revision (52dfe7bc146b70b326ed6e9f521bffa9f902bb2b). To reproduce: ``` $ gdb --args ./ch test.js ... 0x00005555568a6b2a in Js::EntryPointInfo::GetNativeThrowSpanSequence (this=0x7ffff0624420) at /home/gustavo/repos/ChakraCore/lib/Runtime/./Base/FunctionBody.h:874 874 Assert(this->GetState() != CleanedUp); (gdb) bt #0 0x00005555568a6b2a in Js::EntryPointInfo::GetNativeThrowSpanSequence (this=0x7ffff0624420) at /home/gustavo/repos/ChakraCore/lib/Runtime/./Base/FunctionBody.h:874 #1 0x0000555556840c9e in Js::FunctionBody::RecordNativeThrowMap (this=0x7ffff077dc00, iter=..., nativeOffset=932, statementIndex=10, entryPoint=0x7ffff0624420, loopNum=4294967295) at /home/gustavo/repos/ChakraCore/lib/Runtime/Base/FunctionBody.cpp:1333 #2 0x0000555558b585f1 in Encoder::Encode (this=0x7ff7ebffc660) at /home/gustavo/repos/ChakraCore/lib/Backend/Encoder.cpp:316 #3 0x0000555558beb453 in Func::TryCodegen (this=0x7ff7ebffcd00) at /home/gustavo/repos/ChakraCore/lib/Backend/Func.cpp:523 #4 0x0000555558be9acf in Func::Codegen (alloc=0x7ff7ebffd700, workItem=0x7ffff05b1030, threadContextInfo=0x62300000e178, scriptContextInfo=0x62200001b158, outputData=0x7ff7ebffd610, epInfo=0x7ffff0624420, runtimeInfo=0x0, polymorphicInlineCacheInfo=0x7ffff063c640, codeGenAllocators=0x61a0000198d8, codeGenProfiler=0x0, isBackgroundJIT=true) at /home/gustavo/repos/ChakraCore/lib/Backend/Func.cpp:296 #5 0x00005555586a4790 in NativeCodeGenerator::CodeGen (this=0x61300000d458, pageAllocator=0x61500000dcf8, workItem=0x612000009c98, foreground=false) at /home/gustavo/repos/ChakraCore/lib/Backend/NativeCodeGenerator.cpp:953 #6 0x00005555586aab37 in NativeCodeGenerator::Process (this=0x61300000d458, job=0x612000009ca0, threadData=0x61500000dcd8) at /home/gustavo/repos/ChakraCore/lib/Backend/NativeCodeGenerator.cpp:1827 #7 0x000055555877b96a in JsUtil::BackgroundJobProcessor::Process (this=0x61300000d998, job=0x612000009ca0, threadData=0x61500000dcd8) at /home/gustavo/repos/ChakraCore/lib/Common/Common/Jobs.cpp:986 #8 0x000055555877c421 in JsUtil::BackgroundJobProcessor::Run (this=0x61300000d998, threadData=0x61500000dcd8) at /home/gustavo/repos/ChakraCore/lib/Common/Common/Jobs.cpp:1078 #9 0x0000555558775c00 in JsUtil::BackgroundJobProcessor::StaticThreadProc (lpParam=0x61500000dcd8) at /home/gustavo/repos/ChakraCore/lib/Common/Common/Jobs.cpp:1254 #10 0x0000555556358d62 in CorUnix::CPalThread::ThreadEntry (pvParam=0x61c00000e080) at /home/gustavo/repos/ChakraCore/pal/src/thread/pal_thread.cpp:1624 #11 0x00007ffff7bc16ba in start_thread (arg=0x7ff7ebfff700) at pthread_create.c:333 #12 0x00007ffff6c383dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 ``` Regards, Gustavo.
Failed assertion at lib/Runtime/Base/FunctionBody.h
https://api.github.com/repos/chakra-core/ChakraCore/issues/3285/comments
1
2017-07-03T23:38:21Z
2017-12-01T09:06:01Z
https://github.com/chakra-core/ChakraCore/issues/3285
240,281,712
3,285
[ "chakra-core", "ChakraCore" ]
`RecyclerWeakReference` data structure is a data structure used to store weak reference to strong reference mapping inside recycler. Internally it uses hash table with chaining to save the mapped entries. [HashKeyToBucket](https://github.com/Microsoft/ChakraCore/blob/master/lib/Common/Memory/RecyclerWeakReference.h#L285-L289) calculates the hash key from `strongReference` address and adds an entry into appropriate bucket. The assumption here is that chain length can rarely be greater than 1 and hence the [resize policy](https://github.com/Microsoft/ChakraCore/blob/master/lib/Common/Memory/RecyclerWeakReference.h#L335-L344) is that every time we add as many entries as size of hash-table array, we resize the hash-table to newSize which is next prime no. greater than `oldSize*2`. However, in a crawler experiment that I conducted for 2 days on 5 machines, I found out that whenever we resize, **35%** of the buckets are empty i.e. their chain length is 0. **38%** of the buckets has chain length 1 and **18%** of buckets has chain length 2. We should tweak the hashing function to get distributed hash key so that we have higher no. of buckets that has chain-length 1. With that we can avoid subsequent re-sizes.
Re-evaluate hash function for RecyclerWeakReference
https://api.github.com/repos/chakra-core/ChakraCore/issues/3282/comments
6
2017-07-03T19:50:08Z
2019-06-07T18:25:39Z
https://github.com/chakra-core/ChakraCore/issues/3282
240,253,089
3,282
[ "chakra-core", "ChakraCore" ]
```javascript 1337in{1337:1} ``` Expected: Syntax error. In operator cannot follow number. Actual: true Firefox, Chrome and Safari all throw exceptions.
In operator allowed to follow a number
https://api.github.com/repos/chakra-core/ChakraCore/issues/3281/comments
1
2017-07-03T12:20:36Z
2017-09-08T00:57:25Z
https://github.com/chakra-core/ChakraCore/issues/3281
240,156,110
3,281
[ "chakra-core", "ChakraCore" ]
Hi, We found an failed assertion in the ChakraCore interpreter (ch) when you run the following test case: ``` foo.prototype = new Array(1 ,2 ,3); function foo() { } var f = new foo(); f.length /= null; var callCnt = 0; function cb() { callCnt++; } var i = f.forEach(cb); assert.sameValue(callCnt ,0 ,"callCnt"); ``` It was tested in Ubuntu 16.04 using the last git revision (52dfe7bc146b70b326ed6e9f521bffa9f902bb2b). To reproduce: ``` $ gdb --args ./ch test.js ... ASSERTION 19837: (/home/g/repos/ChakraCore/lib/Common/Memory/HeapBlock.cpp, line 1363) (ObjectInfo(objectIndex) & NewTrackBit) == 0 Failure: ((ObjectInfo(objectIndex) & NewTrackBit) == 0) Thread 1 "ch" received signal SIGILL, Illegal instruction. 0x00005555565a48dd in Memory::SmallHeapBlockT<SmallAllocationBlockAttributes>::SweepObjects<(Memory::SweepMode)0> (this=0x61a00015bc30, recycler=0x633000000858) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBlock.cpp:1363 1363 Assert((ObjectInfo(objectIndex) & NewTrackBit) == 0); (gdb) bt #0 0x00005555565a48dd in Memory::SmallHeapBlockT<SmallAllocationBlockAttributes>::SweepObjects<(Memory::SweepMode)0> (this=0x61a00015bc30, recycler=0x633000000858) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBlock.cpp:1363 #1 0x00005555565a237b in Memory::SmallHeapBlockT<SmallAllocationBlockAttributes>::Sweep (this=0x61a00015bc30, recyclerSweep=..., queuePendingSweep=false, allocable=true, finalizeCount=341, hasPendingDispose=false) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBlock.cpp:1276 #2 0x00005555567a04ee in Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>::Sweep (this=0x61a00015bc30, recyclerSweep=..., queuePendingSweep=false, allocable=true) at /home/g/repos/ChakraCore/lib/Common/Memory/SmallFinalizableHeapBlock.cpp:268 #3 0x0000555556645908 in Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepHeapBlockList(Memory::RecyclerSweep&, Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, bool)::{lambda(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*)#1}::operator()(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*) const (this=0x7fffffff2340, heapBlock=0x61a00015bc30) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.cpp:977 #4 0x0000555556645788 in Memory::HeapBlockList::ForEachEditing<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>, Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepHeapBlockList(Memory::RecyclerSweep&, Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, bool)::{lambda(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*)#1}>(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>, Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepHeapBlockList(Memory::RecyclerSweep&, Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, bool)::{lambda(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*)#1}) (list=0x61a00015bc30, tail=0x0, fn=...) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBlock.h:811 #5 0x00005555565fc0e3 in Memory::HeapBlockList::ForEachEditing<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>, Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepHeapBlockList(Memory::RecyclerSweep&, Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, bool)::{lambda(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*)#1}>(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepHeapBlockList(Memory::RecyclerSweep&, Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*, bool)::{lambda(Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes>*)#1}) (list=0x61a00015bc30, fn=...) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBlock.h:801 #6 0x00005555565fb86b in Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepHeapBlockList ( this=0x633000006328, recyclerSweep=..., heapBlockList=0x61a00015bc30, allocable=true) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.cpp:972 #7 0x00005555565fb1c2 in Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepBucket (this=0x633000006328, recyclerSweep=...) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.cpp:1147 #8 0x00005555567ade72 in Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SweepBucket<Memory::SmallFinalizableHeapBucketBaseT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::Sweep(Memory::RecyclerSweep&)::{lambda(Memory::RecyclerSweep&)#1}>(Memory::RecyclerSweep&, Memory::SmallFinalizableHeapBucketBaseT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::Sweep(Memory::RecyclerSweep&)::{lambda(Memory::RecyclerSweep&)#1}) (this=0x633000006328, recyclerSweep=..., sweepFn=...) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.h:310 #9 0x00005555567adc9d in Memory::SmallFinalizableHeapBucketBaseT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::Sweep ( this=0x633000006328, recyclerSweep=...) at /home/g/repos/ChakraCore/lib/Common/Memory/SmallFinalizableHeapBucket.cpp:110 #10 0x00005555565de85e in Memory::HeapBucketGroup<SmallAllocationBlockAttributes>::SweepFinalizableObjects (this=0x6330000061a8, recyclerSweep=...) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.cpp:1653 #11 0x0000555556672303 in Memory::HeapInfo::SweepBuckets (this=0x633000005910, recyclerSweep=..., concurrent=true) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapInfo.cpp:865 #12 0x000055555667281a in Memory::HeapInfo::Sweep (this=0x633000005910, recyclerSweep=..., concurrent=true) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapInfo.cpp:945 #13 0x0000555556723361 in Memory::Recycler::SweepHeap (this=0x633000000858, concurrent=true, recyclerSweep=...) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3187 #14 0x0000555556722ae6 in Memory::Recycler::Sweep (this=0x633000000858, rescanRootBytes=50680, concurrent=true, adjustPartialHeuristics=true) ---Type <return> to continue, or q <return> to quit--- at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3019 #15 0x000055555672abbe in Memory::Recycler::PartialCollect (this=0x633000000858, concurrent=true) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:4068 #16 0x0000555556729071 in Memory::Recycler::DoCollect (this=0x633000000858, flags=Memory::CollectOnAllocation) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3885 #17 0x0000555556706fe7 in Memory::DefaultRecyclerCollectionWrapper::ExecuteRecyclerCollectionFunction (this=0x62300000e158, recycler=0x633000000858, function= (BOOL (Memory::Recycler::*)(Memory::Recycler * const, Memory::CollectionFlags)) 0x555556727af0 <Memory::Recycler::DoCollect(Memory::CollectionFlags)>, flags=Memory::CollectOnAllocation) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:94 #18 0x0000555556a0686b in ThreadContext::ExecuteRecyclerCollectionFunctionCommon (this=0x62300000e158, recycler=0x633000000858, function= (BOOL (Memory::Recycler::*)(Memory::Recycler * const, Memory::CollectionFlags)) 0x555556727af0 <Memory::Recycler::DoCollect(Memory::CollectionFlags)>, flags=Memory::CollectOnAllocation) at /home/g/repos/ChakraCore/lib/Runtime/Base/ThreadContext.cpp:1941 #19 0x0000555556a08b2e in ThreadContext::ExecuteRecyclerCollectionFunction (this=0x62300000e158, recycler=0x633000000858, function= (BOOL (Memory::Recycler::*)(Memory::Recycler * const, Memory::CollectionFlags)) 0x555556727af0 <Memory::Recycler::DoCollect(Memory::CollectionFlags)>, flags=Memory::CollectOnAllocation) at /home/g/repos/ChakraCore/lib/Runtime/Base/ThreadContext.cpp:2140 #20 0x00005555567279a2 in Memory::Recycler::DoCollectWrapped (this=0x633000000858, flags=Memory::CollectOnAllocation) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3737 #21 0x000055555675f643 in Memory::Recycler::Collect<(Memory::CollectionFlags)404819971> (this=0x633000000858) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3697 #22 0x000055555675eed6 in Memory::Recycler::CollectWithHeuristic<(Memory::CollectionFlags)404819971> (this=0x633000000858) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3620 #23 0x00005555567525e3 in Memory::Recycler::CollectInternal<(Memory::CollectionFlags)404819971> (this=0x633000000858) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3579 #24 0x0000555556749c45 in Memory::Recycler::CollectNow<(Memory::CollectionFlags)404819971> (this=0x633000000858) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.cpp:3507 #25 0x00005555565f7129 in Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::SnailAlloc (this=0x633000006328, recycler=0x633000000858, allocator=0x633000006358, sizeCat=48, size=42, attributes=420, nothrow=false) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.cpp:584 #26 0x0000555556a41ced in Memory::HeapBucketT<Memory::SmallFinalizableHeapBlockT<SmallAllocationBlockAttributes> >::RealAlloc<(Memory::ObjectInfoBits)420, false> (this=0x633000006328, recycler=0x633000000858, sizeCat=48, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapBucket.inl:19 #27 0x0000555556a41b0d in Memory::HeapInfo::RealAlloc<(Memory::ObjectInfoBits)420, false> (this=0x633000005910, recycler=0x633000000858, sizeCat=48, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/HeapInfo.h:504 #28 0x0000555556a4144e in Memory::Recycler::RealAllocFromBucket<(Memory::ObjectInfoBits)420, true, false> (this=0x633000000858, heap=0x633000005910, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.inl:320 #29 0x0000555556a4124e in Memory::Recycler::RealAlloc<(Memory::ObjectInfoBits)420, false> (this=0x633000000858, heap=0x633000005910, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.inl:395 #30 0x0000555556a40f35 in Memory::Recycler::AllocWithAttributesInlined<(Memory::ObjectInfoBits)164, false> (this=0x633000000858, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.inl:101 #31 0x0000555556a405dd in Memory::Recycler::AllocWithAttributes<(Memory::ObjectInfoBits)164, false> (this=0x633000000858, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.h:1466 #32 0x0000555556a30cad in Memory::Recycler::AllocFinalizedLeaf (this=0x633000000858, size=42) at /home/g/repos/ChakraCore/lib/Common/Memory/Recycler.h:1269 #33 0x00005555564bef0d in operator new<Memory::Recycler> (byteSize=24, alloc=0x633000000858, AllocFunc= (char *(Memory::Recycler::*)(Memory::Recycler * const, size_t)) 0x555556a30c90 <Memory::Recycler::AllocFinalizedLeaf(unsigned long)>, plusSize=18) at /home/g/repos/ChakraCore/lib/Common/Memory/Allocator.h:513 ---Type <return> to continue, or q <return> to quit--- #34 0x00005555569fe844 in ThreadContext::UncheckedAddPropertyId (this=0x62300000e158, propertyName=..., bind=false, isSymbol=false) at /home/g/repos/ChakraCore/lib/Runtime/Base/ThreadContext.cpp:1057 #35 0x0000555556a01109 in ThreadContext::GetOrAddPropertyRecordImpl (this=0x62300000e158, propertyName=..., bind=false) at /home/g/repos/ChakraCore/lib/Runtime/Base/ThreadContext.cpp:1228 #36 0x0000555556a3167f in ThreadContext::GetOrAddPropertyRecord (this=0x62300000e158, propertyName=...) at /home/g/repos/ChakraCore/lib/Runtime/./Base/ThreadContext.h:1131 #37 0x0000555556a00ed5 in ThreadContext::GetOrAddPropertyId (this=0x62300000e158, propertyName=..., propRecord=0x7fffffff5600) at /home/g/repos/ChakraCore/lib/Runtime/Base/ThreadContext.cpp:1213 #38 0x0000555556a00d6b in ThreadContext::GetOrAddPropertyId (this=0x62300000e158, propertyName=0x7fffffff54c0 u"476023", propertyNameLength=6, propertyRecord=0x7fffffff5600) at /home/g/repos/ChakraCore/lib/Runtime/Base/ThreadContext.cpp:1207 #39 0x0000555556913b71 in Js::ScriptContext::GetOrAddPropertyRecord (this=0x62200001c958, propertyName=0x7fffffff54c0 u"476023", propertyNameLength=6, propertyRecord=0x7fffffff5600) at /home/g/repos/ChakraCore/lib/Runtime/Base/ScriptContext.cpp:854 #40 0x0000555557698028 in Js::JavascriptOperators::GetPropertyIdForInt (value=476023, scriptContext=0x62200001c958, propertyRecord=0x7fffffff5600) at /home/g/repos/ChakraCore/lib/Runtime/Language/JavascriptOperators.cpp:8537 #41 0x00005555578c22e6 in Js::JavascriptArray::TemplatedGetItem<Js::RecyclableObject> (obj=0x7ffff27800f0, index=476023, element=0x7fffffff57c0, scriptContext=0x62200001c958, checkHasItem=true) at /home/g/repos/ChakraCore/lib/Runtime/Library/JavascriptArray.cpp:3937 #42 0x0000555557957f67 in Js::JavascriptArray::TryTemplatedGetItem<Js::RecyclableObject, unsigned long> (arr=0x7ffff27800f0, index=476023, element=0x7fffffff57c0, scriptContext=0x62200001c958, checkHasItem=true) at /home/g/repos/ChakraCore/lib/Runtime/./Library/JavascriptArray.h:634 #43 0x00005555578e6231 in Js::JavascriptArray::TemplatedForEachItemInRange<true, Js::RecyclableObject, unsigned long, Js::JavascriptArray::EntryForEach(Js::RecyclableObject*, Js::CallInfo, ...)::$_8>(Js::RecyclableObject*, unsigned long, unsigned long, Js::ScriptContext*, Js::JavascriptArray::EntryForEach(Js::RecyclableObject*, Js::CallInfo, ...)::$_8) (arr=0x7ffff27800f0, startIndex=0, limitIndex=9007199254740991, scriptContext=0x62200001c958, fn=...) at /home/g/repos/ChakraCore/lib/Runtime/./Library/JavascriptArray.h:669 #44 0x00005555578e55fa in Js::JavascriptArray::EntryForEach (function=0x7ffff0744fc0, callInfo=...) at /home/g/repos/ChakraCore/lib/Runtime/Library/JavascriptArray.cpp:8759 #45 0x0000555557ea102e in amd64_CallFunction () at /home/g/repos/ChakraCore/lib/Runtime/Library/amd64/JavascriptFunctionA.S:100 #46 0x00005555579ce314 in Js::JavascriptFunction::CallFunction<true> (function=0x7ffff0744fc0, entryPoint=0x5555578e40f0 <Js::JavascriptArray::EntryForEach(Js::RecyclableObject*, Js::CallInfo, ...)>, args=...) at /home/g/repos/ChakraCore/lib/Runtime/Library/JavascriptFunction.cpp:1353 #47 0x00005555576441e7 in Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > > (this=0x7fffffffad80, playout=0x7ffff07200a4, function=0x7ffff0744fc0, flags=2, spreadIndices=0x0) at /home/g/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:3904 #48 0x0000555557643663 in Js::InterpreterStackFrame::OP_ProfileCallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > > (this=0x7fffffffad80, playout=0x7ffff07200a4, function=0x7ffff0744fc0, flags=0, profileId=2, inlineCacheIndex=3, spreadIndices=0x0) at /home/g/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:3928 #49 0x00005555575a6321 in Js::InterpreterStackFrame::OP_ProfiledCallIWithICIndex<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > (this=0x7fffffffad80, playout=0x7ffff07200a4, flags=0) at /home/g/repos/ChakraCore/lib/Runtime/./Language/InterpreterStackFrame.h:460 #50 0x00005555572b75a1 in Js::InterpreterStackFrame::ProcessProfiled (this=0x7fffffffad80) at /home/g/repos/ChakraCore/lib/Runtime/Language/InterpreterHandler.inl:86 #51 0x0000555557202aa9 in Js::InterpreterStackFrame::Process (this=0x7fffffffad80) at /home/g/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:3454 #52 0x0000555557201184 in Js::InterpreterStackFrame::InterpreterHelper (function=0x7ffff272c240, args=..., returnAddress=0x7ffff0700fa2, addressOfReturnAddress=0x7fffffffb948, isAsmJs=false) at /home/g/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:2054 #53 0x00005555571ff224 in Js::InterpreterStackFrame::InterpreterThunk (layout=0x7fffffffb960) at /home/g/repos/ChakraCore/lib/Runtime/Language/InterpreterStackFrame.cpp:1789 ---Type <return> to continue, or q <return> to quit--- #54 0x00007ffff0700fa2 in ?? () #55 0x00007fffffffb970 in ?? () #56 0x0000555557ea102e in amd64_CallFunction () at /home/g/repos/ChakraCore/lib/Runtime/Library/amd64/JavascriptFunctionA.S:100 Backtrace stopped: frame did not save the PC ``` This issue was found using QuickFuzz. Regards, Gustavo.
Failed assertion at lib/Common/Memory/HeapBlock.cpp
https://api.github.com/repos/chakra-core/ChakraCore/issues/3280/comments
4
2017-07-03T12:14:47Z
2017-12-09T00:56:22Z
https://github.com/chakra-core/ChakraCore/issues/3280
240,154,877
3,280
[ "chakra-core", "ChakraCore" ]
Jitted code for setting an element to a typed array checks if the length is greater than 0. If not, it just bypasses the set. We set the length of the typed array to 0 if its array buffer was detached, so bypassing the set if the length is 0 prevents us from writing to detached buffer, but it also means that we won't throw the "Array buffer detached" exception.
Jitted code doesn't throw ArrayBuffer detached exception
https://api.github.com/repos/chakra-core/ChakraCore/issues/3277/comments
0
2017-06-30T23:55:51Z
2019-06-07T19:00:15Z
https://github.com/chakra-core/ChakraCore/issues/3277
239,912,342
3,277
[ "chakra-core", "ChakraCore" ]
Not documented on the [header](https://github.com/Microsoft/ChakraCore/blob/d3b6d103bbfa6207d18b74cbf77ca9a48455b8e6/lib/Jsrt/ChakraCommon.h#L694), but if it's the same as `JsCallFunction` then `arguments[0]` should be `this`. The behavior only seems right if in strict mode. Is this a bug or intended? ```cpp #define _JSRT_ #include "ChakraCore.h" #include <assert.h> #include <string> #include <iostream> using namespace std; void setCallback(JsValueRef object, const wchar_t *propertyName, JsNativeFunction callback, void *callbackState) { JsPropertyIdRef propertyId; JsGetPropertyIdFromName(propertyName, &propertyId); JsValueRef function; JsCreateFunction(callback, callbackState, &function); JsSetProperty(object, propertyId, function, true); } JsValueRef CALLBACK func(JsValueRef callee, bool isConstructCall, JsValueRef *arguments, unsigned short argumentCount, void *callbackState) { JsValueRef undefined, global; JsGetUndefinedValue(&undefined); JsGetGlobalObject(&global); assert(arguments[0] == undefined); // SUCCESS assert(arguments[0] == global); // FAIL return JS_INVALID_REFERENCE; } int main() { JsRuntimeHandle runtime; JsContextRef context; JsValueRef result; unsigned currentSourceContext = 0; JsCreateRuntime(JsRuntimeAttributeNone, nullptr, &runtime); JsCreateContext(runtime, &context); JsSetCurrentContext(context); JsValueRef g; JsGetGlobalObject(&g); setCallback(g, L"func", func, nullptr); wstring script = L"func()"; JsRunScript(script.c_str(), currentSourceContext++, L"", &result); return 0; } ```
[JSRT] JsNativeFunction arguments[0] yields undefined instead of globalObj when called as property of globalObj
https://api.github.com/repos/chakra-core/ChakraCore/issues/3276/comments
5
2017-06-30T22:28:01Z
2017-07-03T20:41:13Z
https://github.com/chakra-core/ChakraCore/issues/3276
239,902,565
3,276
[ "chakra-core", "ChakraCore" ]
```js let a = 1; eval('function a() { };'); ``` Expected: SyntaxError per https://tc39.github.io/ecma262/#sec-evaldeclarationinstantiation 5.a.i.1 Actual: no syntax error, function is assigned to let variable. ```js (function () { let a = 1; eval('function a() { }'); })(); ``` Expected: SyntaxError per https://tc39.github.io/ecma262/#sec-evaldeclarationinstantiation 5.d.ii.2.a.i Actual: no syntax error, function is assigned to let variable. Note 1: The order of the lexical declaration and eval are not important - it should be the same error in either case. Note 2: annex B semantics don't come in to play here
Eval containing a function declaration with a same-named lexical declaration in outer scope should throw
https://api.github.com/repos/chakra-core/ChakraCore/issues/3275/comments
0
2017-06-30T19:23:14Z
2018-05-01T22:41:15Z
https://github.com/chakra-core/ChakraCore/issues/3275
239,867,694
3,275
[ "chakra-core", "ChakraCore" ]
Part 1 (#3273) of this change is to ifdef the code to not build. Once we figure out what can be reused for WASM simd we should remove rest of the code
Remove Simd.js code from ChakraCore - Part 2 (Remove)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3274/comments
0
2017-06-30T18:07:05Z
2018-02-21T18:29:23Z
https://github.com/chakra-core/ChakraCore/issues/3274
239,850,722
3,274
[ "chakra-core", "ChakraCore" ]
simd.js is no longer planned for in its current form. V8 has already removed it and ChakraCore should also remove it. Since some code of simd.js can be reused for WASM simd. In first part of change try to ifdef out simd.js specific code to not build and then in second part remove code which is not needed for WASM simd.
Remove Simd.js code from ChakraCore - Part 1 (ifdef out)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3273/comments
4
2017-06-30T18:04:41Z
2017-07-24T19:32:03Z
https://github.com/chakra-core/ChakraCore/issues/3273
239,850,194
3,273
[ "chakra-core", "ChakraCore" ]
when i run ./build.sh --arch=arm --target=android on linux i get this error of pal error: typedef redefinition with different types ('char' vs '__int8_t' (aka 'signed char')) typedef __int8 int8_t;
build.sh --arch=arm --target=android typedef redefinition with different types
https://api.github.com/repos/chakra-core/ChakraCore/issues/3272/comments
4
2017-06-30T16:50:40Z
2018-03-17T00:33:20Z
https://github.com/chakra-core/ChakraCore/issues/3272
239,833,712
3,272
[ "chakra-core", "ChakraCore" ]
```javascript eval('_'+String.fromCharCode(1320)+'_=alert(1)') ``` Expected: alert function to be called and variable assigned Actual: Invalid character exception Every other browser treats the characters as a valid variable part. The following characters are also treated incorrectly. 895,1320,1321,1322,1323,1324,1325,1326,1327,2209,2221,2222,2223,2224,2225,2226,2303,2424,2432,3072,3124,3201,3329,3558,3559,3560,3561,3562,3563,3564,3565,3566,3567,5873,5874,5875,5876,5877,5878,5879,5880,6158,6429,6430,6832,6833,6834,6835,6836,6837,6838,6839,6840,6841,6842,6843,6844,6845,7416,7417,7655,7656,7657,7658,7659,7660,7661,7662,7663,7664,7665,7666,7667,7668,7669,42648,42649,42650,42651,42652,42653,42900,42901,42902,42903,42904,42905,42906,42907,42908,42909,42910,42911,42923,42924,42925,42928,42929,42999,43488,43489,43490,43491,43492,43493,43494,43495,43496,43497,43498,43499,43500,43501,43502,43503,43504,43505,43506,43507,43508,43509,43510,43511,43512,43513,43514,43515,43516,43517,43518,43644,43645,43646,43647,43824,43825,43826,43827,43828,43829,43830,43831,43832,43833,43834,43835,43836,43837,43838,43839,43840,43841,43842,43843,43844,43845,43846,43847,43848,43849,43850,43851,43852,43853,43854,43855,43856,43857,43858,43859,43860,43861,43862,43863,43864,43865,43866,43868,43869,43870,43871,43876,43877,65063,65064,65065,65066,65067,65068,65069
Multiple characters not treated as valid variable part
https://api.github.com/repos/chakra-core/ChakraCore/issues/3271/comments
2
2017-06-30T08:39:59Z
2017-07-11T22:26:49Z
https://github.com/chakra-core/ChakraCore/issues/3271
239,713,470
3,271
[ "chakra-core", "ChakraCore" ]
Does ChakraCore have a build for android, is it really efficient and works well for android without bugs or performace? Well I would very much like to use this engine in a desktop / android project, but I have this doubt, because in the case of the controller I would have to choose either v8 or JavaScriptCore.
ChakraCore on android is viable ?
https://api.github.com/repos/chakra-core/ChakraCore/issues/3270/comments
1
2017-06-30T06:22:47Z
2017-11-30T23:39:14Z
https://github.com/chakra-core/ChakraCore/issues/3270
239,687,752
3,270
[ "chakra-core", "ChakraCore" ]
We encountered an issue that on a hello world scenario with ChakraCore, Linux Skylake server generates a segmentation fault. This issue only happens on Skylake server, not on Haswell server, not on Skylake client system either. It only happens on Linux, not on Windows. Following is hello world test case and call stack info when the segmentation fault happens: /home/git/ttt/ChakraCore/out/Debug$ cat hello.js console.log("hello"); /home/git/ttt/ChakraCore/out/Debug$ ./ch hello.js Segmentation fault (core dumped) /home/git/ttt/ChakraCore/out/Debug$ lldb ch hello.js (lldb) target create "ch" Current executable set to 'ch' (x86_64). (lldb) settings set -- target.run-args "hello.js" (lldb) br set -n NewThunkBlock Breakpoint 1: no locations (pending). WARNING: Unable to resolve breakpoint to any actual locations. (lldb) r Process 238376 launched: '/home/git/ttt/ChakraCore/out/Debug/ch' (x86_64) 1 location added to breakpoint 1 Process 238376 stopped * thread #1: tid = 238376, 0x00007ffff4b14248 libChakraCore.so`InterpreterThunkEmitter::NewThunkBlock(this=0x00005555558ba3a8) + 24 at InterpreterThunkEmitter.cpp:328, name = 'ch', stop reason = breakpoint 1.1 frame #0: 0x00007ffff4b14248 libChakraCore.so`InterpreterThunkEmitter::NewThunkBlock(this=0x00005555558ba3a8) + 24 at InterpreterThunkEmitter.cpp:328 325 } 326 #endif 327 -> 328 Assert(this->thunkCount == 0); 329 BYTE* buffer; 330 331 EmitBufferAllocation<VirtualAllocWrapper, PreReservedVirtualAllocWrapper> * allocation = emitBufferManager.AllocateBuffer(BlockSize, &buffer); (lldb) continue Process 238376 resuming Process 238376 stopped * thread #1: tid = 238376, 0x00007ffff7126d80 libgcc_s.so.1`__register_frame, name = 'ch', stop reason = signal SIGSEGV frame #0: 0x00007ffff7126d80 libgcc_s.so.1`__register_frame libgcc_s.so.1`__register_frame: -> 0x7ffff7126d80 <+0>: movl (%rdi), %eax 0x7ffff7126d82 <+2>: testl %eax, %eax 0x7ffff7126d84 <+4>: jne 0x7ffff7126d90 ; <+16> 0x7ffff7126d86 <+6>: rep (lldb) bt * thread #1: tid = 238376, 0x00007ffff7126d80 libgcc_s.so.1`__register_frame, name = 'ch', stop reason = signal **SIGSEGV** * frame #0: 0x00007ffff7126d80 libgcc_s.so.1`__register_frame frame #1: 0x00007ffff4c3ac5c libChakraCore.so`PDataManager::RegisterPdata(pdataStart=0x00007ffff0290fc0, functionStart=140737222606848, functionEnd=140737222610864, pdataTable=0x00007fffffffcd38, entryCount=1, maxEntryCount=1) + 44 at PDataManager.cpp:67 frame #2: 0x00007ffff4b14469 libChakraCore.so`InterpreterThunkEmitter::NewThunkBlock(this=0x00005555558ba3a8) + 569 at InterpreterThunkEmitter.cpp:372 frame #3: 0x00007ffff4b13f9d libChakraCore.so`InterpreterThunkEmitter::GetNextThunk(this=0x00005555558ba3a8, ppDynamicInterpreterThunk=0x00007ffff02ec048) + 413 at InterpreterThunkEmitter.cpp:274 frame #4: 0x00007ffff4e8cfa4 libChakraCore.so`Js::ScriptContext::GetNextDynamicInterpreterThunk(this=0x00005555558a9c78, ppDynamicInterpreterThunk=0x00007ffff02ec048) + 36 at ScriptContext.cpp:5117 frame #5: 0x00007ffff4e33706 libChakraCore.so`Js::FunctionBody::GenerateDynamicInterpreterThunk(this=0x00007ffff02ec000) + 134 at FunctionBody.cpp:3644 frame #6: 0x00007ffff4e33c51 libChakraCore.so`Js::FunctionBody::EnsureDynamicInterpreterThunk(this=0x00007ffff02ec000, entryPointInfo=0x00007ffff02b0000) + 1265 at FunctionBody.cpp:3695 frame #7: 0x00007ffff5278ef7 libChakraCore.so`Js::InterpreterStackFrame::EnsureDynamicInterpreterThunk(function=0x00007ffff032c1e0) + 215 at InterpreterStackFrame.cpp:1734 frame #8: 0x00007ffff553b78c libChakraCore.so`Js::InterpreterStackFrame::DelayDynamicInterpreterThunk(Js::RecyclableObject*, Js::CallInfo, ...) + 12 at amd64_Thunks.S:32 frame #9: 0x00007ffff5909dce libChakraCore.so`amd64_CallFunction + 78 at JavascriptFunctionA.S:100 frame #10: 0x00007ffff562683d libChakraCore.so`void* Js::JavascriptFunction::CallFunction<true>(function=0x00007ffff032c1e0, entryPoint=(libChakraCore.so`NativeCodeGenerator::CheckCodeGenThunk(Js::RecyclableObject*, Js::CallInfo, ...)), args=Arguments @ 0x00007fffffffd308)(Js::RecyclableObject*, Js::CallInfo, ...), Js::Arguments) + 189 at JavascriptFunction.cpp:1353 frame #11: 0x00007ffff561d58d libChakraCore.so`Js::JavascriptFunction::CallRootFunctionInternal(obj=0x00007ffff032c1e0, args=Arguments @ 0x00007fffffffd380, scriptContext=0x00005555558a9c78, inScript=true) + 365 at JavascriptFunction.cpp:742 frame #12: 0x00007ffff561d36c libChakraCore.so`Js::JavascriptFunction::CallRootFunction(obj=0x00007ffff032c1e0, args=<unavailable>, scriptContext=0x00005555558a9c78, inScript=true) + 76 at JavascriptFunction.cpp:689 frame #13: 0x00007ffff561d314 libChakraCore.so`Js::JavascriptFunction::CallRootFunction(this=0x00007ffff032c1e0, args=<unavailable>, scriptContext=0x00005555558a9c78, inScript=true) + 68 at JavascriptFunction.cpp:797 frame #14: 0x00007ffff47d8c3d libChakraCore.so`RunScriptCore(this=0x00007fffffffd790, scriptContext=0x00005555558a9c78, _actionEntryPopper=0x00007fffffffd770)::$_77::operator()(Js::ScriptContext*, TTD::TTDJsRTActionResultAutoRecorder&) const + 1181 at Jsrt.cpp:3099 frame #15: 0x00007ffff47d8797 libChakraCore.so`_JsErrorCode ContextAPIWrapper<false, RunScriptCore(void*, unsigned char const*, unsigned long, LoadScriptFlag, unsigned long, char16_t const*, bool, _JsParseScriptAttributes, bool, void**)::$_77>(this=0x00007fffffffd728, scriptContext=0x00005555558a9c78)::$_77)::{lambda(Js::ScriptContext*)#1}::operator()(Js::ScriptContext*) const + 39 at JsrtInternal.h:216 frame #16: 0x00007ffff47d8109 libChakraCore.so`_JsErrorCode ContextAPIWrapper_Core<false, _JsErrorCode ContextAPIWrapper<false, RunScriptCore(void*, unsigned char const*, unsigned long, LoadScriptFlag, unsigned long, char16_t const*, bool, _JsParseScriptAttributes, bool, void**)::$_77>(RunScriptCore(void*, unsigned char const*, unsigned long, LoadScriptFlag, unsigned long, char16_t const*, bool, _JsParseScriptAttributes, bool, void**)::$_77)::{lambda(Js::ScriptContext*)#1}>(fn=(anonymous class) @ 0x00007fffffffd728)::$_77>(RunScriptCore(void*, unsigned char const*, unsigned long, LoadScriptFlag, unsigned long, char16_t const*, bool, _JsParseScriptAttributes, bool, void**)::$_77)::{lambda(Js::ScriptContext*)#1}) + 233 at JsrtInternal.h:171 frame #17: 0x00007ffff47aa6b6 libChakraCore.so`_JsErrorCode ContextAPIWrapper<false, RunScriptCore(void*, unsigned char const*, unsigned long, LoadScriptFlag, unsigned long, char16_t const*, bool, _JsParseScriptAttributes, bool, void**)::$_77>(fn=(anonymous class) @ 0x00007fffffffd790)::$_77) + 54 at JsrtInternal.h:214 frame #18: 0x00007ffff47aa5c7 libChakraCore.so`RunScriptCore(scriptSource=0x00007ffff02e4000, script="console.log(\"hello\");\n", cb=22, loadScriptFlag=320, sourceContext=0, sourceUrl=u"/home/wosskltest/git/ttt/chakracore/out/debug/hello.js", parseOnly=false, parseAttributes=JsParseScriptAttributeNone, isSourceModule=false, result=0x0000000000000000) + 487 at Jsrt.cpp:3050 frame #19: 0x00007ffff47acdfe libChakraCore.so`::JsRun(JsValueRef, JsSourceContext, JsValueRef, JsParseScriptAttributes, JsValueRef *) [inlined] CompileRun(scriptVal=0x00007ffff02e4000, sourceContext=0, sourceUrl=0x00007ffff0388f20, parseAttributes=JsParseScriptAttributeNone, result=0x0000000000000000, parseOnly=false) + 179 at Jsrt.cpp:4355 frame #20: 0x00007ffff47acd4b libChakraCore.so`::JsRun(scriptVal=0x00007ffff02e4000, sourceContext=0, sourceUrl=0x00007ffff0388f20, parseAttributes=JsParseScriptAttributeNone, result=0x0000000000000000) + 379 at Jsrt.cpp:4377 frame #21: 0x000055555555f4ae ch`ChakraRTInterface::JsRun(script=0x00007ffff02e4000, sourceContext=0, sourceUrl=0x00007ffff0388f20, parseAttributes=JsParseScriptAttributeNone, result=0x0000000000000000) + 62 at ChakraRtInterface.h:395 frame #22: 0x000055555555d0ea ch`RunScript(fileName="hello.js", fileContents="console.log(\"hello\");\n", fileContentsFinalizeCallback=(ch`WScriptJsrt::FinalizeFree(void*) at WScriptJsrt.cpp:164), bufferValue=0x0000000000000000, fullPath="/home/wosskltest/git/ttt/chakracore/out/debug/hello.js")(void*), void*, char*) + 1978 at ch.cpp:450 frame #23: 0x000055555555e41e ch`ExecuteTest(fileName="hello.js") + 3150 at ch.cpp:744 frame #24: 0x000055555555e4ec ch`ExecuteTestWithMemoryCheck(fileName="hello.js") + 28 at ch.cpp:794 frame #25: 0x000055555555edc2 ch`main(argc=2, c_argv=0x00007fffffffe4e8) + 2162 at ch.cpp:1084 frame #26: 0x00007ffff6d6b830 libc.so.6`__libc_start_main(main=(ch`main at ch.cpp:895), argc=2, argv=0x00007fffffffe4e8, init=<unavailable>, fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffffffe4d8) + 240 at libc-start.c:291 frame #27: 0x000055555555bd09 ch`_start + 41 (lldb) f 2 frame #2: 0x00007ffff4b14469 libChakraCore.so`InterpreterThunkEmitter::NewThunkBlock(this=0x00005555558ba3a8) + 569 at InterpreterThunkEmitter.cpp:372 369 auto block = this->thunkBlocks.PrependNode(allocator, buffer, count); 370 #if PDATA_ENABLED 371 void* pdataTable; -> 372 PDataManager::RegisterPdata((PRUNTIME_FUNCTION)pdataStart, (ULONG_PTR)buffer, (ULONG_PTR)epilogEnd, &pdataTable); 373 block->SetPdata(pdataTable); 374 #else 375 Unused(block); We have found root cause of the issue and will submit pull request shortly.
ChakraCore hello scenario generates segmentation fault on Linux Skylake server
https://api.github.com/repos/chakra-core/ChakraCore/issues/3262/comments
0
2017-06-29T18:02:33Z
2017-07-11T12:02:37Z
https://github.com/chakra-core/ChakraCore/issues/3262
239,564,485
3,262
[ "chakra-core", "ChakraCore" ]
```javascript eval('\0'); ``` Expected: Illegal character exception Actual: undefined Multiple NULL characters throw an exception however it's possible to call a function before the NULL. E.g ```javascript eval('alert(1)\0'); ```
NULL character ignored and exception is not thrown
https://api.github.com/repos/chakra-core/ChakraCore/issues/3261/comments
0
2017-06-29T12:50:31Z
2017-07-28T17:13:03Z
https://github.com/chakra-core/ChakraCore/issues/3261
239,467,940
3,261
[ "chakra-core", "ChakraCore" ]
what's the relationship between chakracore and edge js engine chakra?Can I guess which version of chakracore is used by chakra engine based on the version of chakra.dll?
releationship between chakracore and chakra.dll?
https://api.github.com/repos/chakra-core/ChakraCore/issues/3260/comments
3
2017-06-29T08:29:39Z
2017-11-30T23:40:18Z
https://github.com/chakra-core/ChakraCore/issues/3260
239,402,613
3,260
[ "chakra-core", "ChakraCore" ]
Currently, all imports are relative to CWD. It should instead be relative to the module doing the import.
Module imports in ch.exe/jshost.exe should be relative to the current module
https://api.github.com/repos/chakra-core/ChakraCore/issues/3257/comments
0
2017-06-28T21:54:35Z
2017-07-11T23:37:13Z
https://github.com/chakra-core/ChakraCore/issues/3257
239,309,242
3,257
[ "chakra-core", "ChakraCore" ]
```js // some module.js if (false) export default null; ``` Actual: no error Expected: early syntax error This also applies to (at least) the else block, the body of loop constructs, and labels.
Module import/export should not be allowed in the statement of an if/else/while/etc.
https://api.github.com/repos/chakra-core/ChakraCore/issues/3256/comments
0
2017-06-28T21:50:30Z
2017-07-10T23:17:37Z
https://github.com/chakra-core/ChakraCore/issues/3256
239,308,282
3,256
[ "chakra-core", "ChakraCore" ]
```js // some module.js return; ``` Actual: bails out of the module (kind of handy actually) Expected: Early syntax error
Modules should not allow `return` at top level
https://api.github.com/repos/chakra-core/ChakraCore/issues/3255/comments
0
2017-06-28T21:45:01Z
2017-07-10T23:17:52Z
https://github.com/chakra-core/ChakraCore/issues/3255
239,307,016
3,255
[ "chakra-core", "ChakraCore" ]
```js var f; function f() {} ``` Actual: No Error Expected: Early Syntax Error (redeclaration of f).
Duplicate VarDeclaredName and LexicallyDeclaredName is always an error in Modules
https://api.github.com/repos/chakra-core/ChakraCore/issues/3254/comments
0
2017-06-28T21:42:40Z
2019-06-07T18:52:38Z
https://github.com/chakra-core/ChakraCore/issues/3254
239,306,497
3,254
[ "chakra-core", "ChakraCore" ]
```js // bug-dep.js import * as ns from './bug-dep.js'; print(Object.prototype.hasOwnProperty.call(ns, Symbol.iterator)); ``` Actual: true Expected: false ([spec changed](https://github.com/tc39/ecma262/commit/814463f4819f30fe2bc2db56a00b63e3f76167af))
Module namespace objects should not have Symbol.iterator property
https://api.github.com/repos/chakra-core/ChakraCore/issues/3252/comments
0
2017-06-28T21:38:51Z
2017-07-10T23:18:21Z
https://github.com/chakra-core/ChakraCore/issues/3252
239,305,641
3,252
[ "chakra-core", "ChakraCore" ]
```js import * as ns from './bug-dep.js'; print(ns.local1); export let local1 = 23; ``` Actual: undefined Expected: TDZ error on access of ns.local1
Modules do not throw TDZ errors for accessing imported TDZ'd bindings
https://api.github.com/repos/chakra-core/ChakraCore/issues/3251/comments
3
2017-06-28T21:33:28Z
2019-06-23T22:45:41Z
https://github.com/chakra-core/ChakraCore/issues/3251
239,304,393
3,251
[ "chakra-core", "ChakraCore" ]
```js // bug.js WScript.LoadModule(`import "bug-dep.js"`); // bug-dep.js import * as ns from './bug-dep.js'; export let c_localUninit1; export { c_localUninit1 as f_indirectUninit } from './bug-dep2.js'; var stringKeys = Object.getOwnPropertyNames(ns); print(JSON.stringify(stringKeys)); // bug-dep2.js export * from "./bug-dep.js"; ``` Actual: crash Expected: ["c_localUninit1","f_indirectUninit"]
Module crash in circular import case
https://api.github.com/repos/chakra-core/ChakraCore/issues/3250/comments
0
2017-06-28T21:27:41Z
2017-08-16T17:04:23Z
https://github.com/chakra-core/ChakraCore/issues/3250
239,302,978
3,250
[ "chakra-core", "ChakraCore" ]
```js // bug-dep.js import * as ns from './bug-dep.js'; print(JSON.stringify(Object.getOwnPropertyDescriptor(ns, Symbol.toStringTag))); ``` Actual: writable true, enumerable true Expected: writable false, enumerable false ([spec](https://tc39.github.io/ecma262/#sec-@@tostringtag))
Module namespace object's Symbol.toStringTag has incorrect attributes
https://api.github.com/repos/chakra-core/ChakraCore/issues/3249/comments
0
2017-06-28T21:25:16Z
2017-07-14T23:22:53Z
https://github.com/chakra-core/ChakraCore/issues/3249
239,302,411
3,249
[ "chakra-core", "ChakraCore" ]
```js import * as ns from './bug-dep.js'; export let x = 1; export { x as renamed } from "./bug-dep.js"; var stringKeys = Object.getOwnPropertyNames(ns); print(JSON.stringify(stringKeys)); ``` Actual: ['x'] Expected: ['renamed', 'x']
Module namespace object not populated with bindings exported and renamed from self
https://api.github.com/repos/chakra-core/ChakraCore/issues/3248/comments
1
2017-06-28T21:20:24Z
2017-07-24T23:24:08Z
https://github.com/chakra-core/ChakraCore/issues/3248
239,301,255
3,248
[ "chakra-core", "ChakraCore" ]
```js // bug.js WScript.LoadModule(`import "bug-dep.js"`); // bug-dep.js import './bug-dep.js'; print('eval'); ``` Actual: eval printed twice Expected: eval printed once
Modules evaluated twice when referenced circularly
https://api.github.com/repos/chakra-core/ChakraCore/issues/3247/comments
0
2017-06-28T21:14:24Z
2017-07-11T23:37:13Z
https://github.com/chakra-core/ChakraCore/issues/3247
239,299,526
3,247
[ "chakra-core", "ChakraCore" ]
When constructing a module namespace object, the keys [should be ordered](https://tc39.github.io/ecma262/#sec-modulenamespacecreate) as if passed to Array.prototype.sort with the default comparator. ```js // root.js WScript.LoadModule(`import "bug-dep.js"`); // bug-dep.js var x; export { x as Ο€ }; // u03c0 export { x as az }; export { x as __ }; export { x as za }; export { x as Z }; export { x as \u03bc }; export { x as z }; export { x as zz }; export { x as a }; export { x as A }; export { x as aa } export { x as Ξ» }; // u03bb export { x as _ }; export { x as $$ }; export { x as $ }; export default null; import * as ns from './bug-dep.js'; var stringKeys = Object.getOwnPropertyNames(ns); print(JSON.stringify(stringKeys)); ``` Actual: ["default","$","$$","\_","?","aa","A","a","zz","z","?","Z","za","\_\_","az","?"] (reverse order?) Expected: ["$","$$","A","Z","\_","__","a","aa","az","default","z","za","zz","?","?","?"] (declaration order) (Note: ?'s above are due to console output, in expected output the ordering is \u03bb, \u03bc, \u03c0)
Module namespace entries are not sorted properly
https://api.github.com/repos/chakra-core/ChakraCore/issues/3246/comments
0
2017-06-28T20:43:52Z
2017-07-14T23:26:48Z
https://github.com/chakra-core/ChakraCore/issues/3246
239,290,502
3,246
[ "chakra-core", "ChakraCore" ]
```js WScript.LoadModule(` export default function f() {} if (true) { }; `); ``` Actual: Syntax error, expected `;` Expected: No syntax error Examining the syntax for [export forms](https://tc39.github.io/ecma262/#prod-ExportDeclaration), some do not require a semicolon to follow them.
Semicolon should not be required after certain module export forms
https://api.github.com/repos/chakra-core/ChakraCore/issues/3245/comments
0
2017-06-28T20:30:54Z
2017-08-16T19:37:25Z
https://github.com/chakra-core/ChakraCore/issues/3245
239,286,648
3,245
[ "chakra-core", "ChakraCore" ]
```js Function('1=1') ``` Expected: ReferenceError ([spec](https://tc39.github.io/ecma262/#sec-createdynamicfunction)) Actual: No error until the function is invoked V8 and SM throw this error.
Function constructor should throw when it contains an invalid LHS assignment
https://api.github.com/repos/chakra-core/ChakraCore/issues/3242/comments
3
2017-06-28T16:48:28Z
2018-06-04T19:27:43Z
https://github.com/chakra-core/ChakraCore/issues/3242
239,227,255
3,242
[ "chakra-core", "ChakraCore" ]
When invoking toString() on a native method, I would think one generally expects to see something like the following, if the function were called 'foo': "function foo() { [native code] }" If a function is created via JsCreateNamedFunction, however, invoking toString() on it only gives back: "foo" Was this by any chance intended behavior? Is there some other way to generate a native code method that still shows its name when its toString() method is called?
Question/bug: functions created by JsCreateNamedFunction when converted to string simply show the function name
https://api.github.com/repos/chakra-core/ChakraCore/issues/3241/comments
1
2017-06-28T05:22:19Z
2017-06-28T22:21:45Z
https://github.com/chakra-core/ChakraCore/issues/3241
239,055,683
3,241
[ "chakra-core", "ChakraCore" ]
Response apis have changed name since it was first implemented. https://github.com/WebAssembly/design/blob/master/Web.md#additional-web-embedding-api Need to rename
WASM - Response api rename
https://api.github.com/repos/chakra-core/ChakraCore/issues/3231/comments
0
2017-06-27T01:08:44Z
2017-06-28T16:41:55Z
https://github.com/chakra-core/ChakraCore/issues/3231
238,710,728
3,231
[ "chakra-core", "ChakraCore" ]
I have a Wordpress Website (formen.co.il) In which I use a page builder. The page builder for some odd reason adds `<br>` tags to buttons added with it. To remove these added br tags with Js, I added a custom.js file, to which I added the following Js code: ``` for (const element of document.querySelectorAll(".elementor-button-link br")) { element.style.display = "none"; } ``` I have tested the site from latest Chrome, Firefox and from **Edge 40.15063.0.0** as well. In my Chrome and Firefox check it seems the code works and remove the br tags but in Edge they keep appear: The buttons are still "taller" because of them and they appear in DOM. You could test this yourself, for example, in [](http://formen.co.il/beard-clearing/), if you navigate to the footer of the site "Χ¦Χ•Χ¨ Χ§Χ©Χ¨" and "ΧœΧ§Χ¨Χ™ΧΧͺ Χ”ΧͺΧ§Χ Χ•ΧŸ". ![1](https://user-images.githubusercontent.com/13021900/27565409-cdd9586c-5ae6-11e7-8908-a85e6b1f478f.PNG) ![2](https://user-images.githubusercontent.com/13021900/27565411-d0481a52-5ae6-11e7-86d7-d424e7d93de5.PNG)
FOR OF loop works on Chrome and Firefox but not on Microsoft Edge 40.15063.0.0
https://api.github.com/repos/chakra-core/ChakraCore/issues/3229/comments
1
2017-06-27T00:19:06Z
2017-07-11T18:44:41Z
https://github.com/chakra-core/ChakraCore/issues/3229
238,704,593
3,229
[ "chakra-core", "ChakraCore" ]
Implement non-trapping float-to-int conversions https://github.com/WebAssembly/design/pull/1089
WASM - Non-trapping float-to-int conversion (3d)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3228/comments
1
2017-06-26T23:48:20Z
2018-04-26T02:03:14Z
https://github.com/chakra-core/ChakraCore/issues/3228
238,700,375
3,228
[ "chakra-core", "ChakraCore" ]
Repro: ``` <pre id="log"></pre> <script> function log(msg) { document.getElementById('log').textContent += msg + '\n'; } function Base() {} function Derived() {} Derived.prototype = Object.create(Base.prototype); // OPTIONAL log(new Base() instanceof Derived); // correctly logs 'false' Reflect.construct(Base, [], Derived); log(new Base() instanceof Derived); // from now on, logs 'true'! </script> ``` This bug is pretty elusive - if you ever open the developer tools (even just for a second) everything goes back to normal, and the `Base` constructor again constructs `Base` objects (hence the HTML logging). It's also irrelevant whether `Derived` is a prototypal subclass of `Base`. Fun fact: if the `Object.create` call is left out, then in the broken state, `new Base() instanceof Base` actually returns false! This seems to be a one-way switch: calling `Reflect.construct(Base, [], Other)` afterwards does *not* switch `new Base()` from creating `Derived`s to creating `Other`s. But it also doesn't work to try to workaround the issue with a proactive `Reflect.construct(Base, [], Base)`, since a future call to `Reflect.construct(Base, [], Derived)` will still cause problems. EDIT: Also, this bug only triggers if the base class has been instantiated at least once before calling `Reflect.construct`: so if the first log statement is removed then the second one logs 'false'.
Reflect.construct permanently corrupts the invoked constructor
https://api.github.com/repos/chakra-core/ChakraCore/issues/3217/comments
0
2017-06-23T21:21:26Z
2017-07-21T23:09:54Z
https://github.com/chakra-core/ChakraCore/issues/3217
238,256,759
3,217
[ "chakra-core", "ChakraCore" ]
We have been successfully using Chakra in our application for over 2 years (before it was even open sourced). It is a great JS engine. Today we released some work via the Windows store, and apps that work fine on our workstations, fail at runtime with the following error: ``` System.TypeLoadException: Unresolved P/Invoke method 'JsCreateExternalArrayBuffer!Chakra.dll' in assembly 'EclipseSource.Tabris.JavaScript, Version=0.1.0.0, Culture=neutral, PublicKeyToken=null' because it is not available in UWP applications. Please either use an another API , or use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP application APIs. ``` It appears this particular API is not available. Is that expected? Is `JsCreateExternalArrayBuffer` considered *public*, and do you know what version of Chakra core this API was introduced in? This might not be the best forum for asking this question, but I can't seem to find another suitable place. Also, this may also raise a _meta issue_, how do developers know what version of Chakra ships with Windows UWP.
Unresolved P/Invoke method 'JsCreateExternalArrayBuffer!Chakra.dll'
https://api.github.com/repos/chakra-core/ChakraCore/issues/3216/comments
1
2017-06-23T19:44:19Z
2018-02-13T23:45:32Z
https://github.com/chakra-core/ChakraCore/issues/3216
238,236,246
3,216
[ "chakra-core", "ChakraCore" ]
There are some FncFlags in ptree.h that are unsused right now. We should clean up those to free up some space and also shold change sxFnc.flags to use type FncFlags instead of uint to help debugging. Unused flags found so far - [x] kFunctionDoesNotEscape - [x] kFunctionHasThisStmt - [x] kFunctionHasNewTargetReference
Remove unused FncFlags
https://api.github.com/repos/chakra-core/ChakraCore/issues/3212/comments
0
2017-06-23T00:33:37Z
2017-08-16T23:21:10Z
https://github.com/chakra-core/ChakraCore/issues/3212
238,009,902
3,212
[ "chakra-core", "ChakraCore" ]
In "Test" builds of ChakraCore, we can see that with specific frameworks and libraries there are higher incidences of functions that eventually get JIT compiled to native code, but then get un-JITd. I'd like to be able to have a Test build of ChakraCore output some JSON that I can feed into a Release build that lists functions to blacklist so cycles and memory are not spent JIT compiling code that will be thrown away. (My app CI could even compare the generated JSON file with the one that's checked in to make sure the blacklist gets updated when JS packages or ChakraCore are improved.) It's possible that are improvements to be made to ChakraCore's heuristics on both judging what to JIT and how to keep JIT'd functions from falling back to interpreter. Even so, I'd like to be able to squeeze more performance out of an existing ChakraCore release while waiting for those improvements. I drove some implementation of this at a previous company that was using JSC and v8 on ARM SoC for complex pure JS user interfaces that needed to have fast launch times *and* hit 60fps. This was a low-risk change to our local fork on those runtimes that had a measurable impact on both of those user-visible performance metrics.
Allow for user-defined blacklists so JIT is not attempted on specific functions
https://api.github.com/repos/chakra-core/ChakraCore/issues/3209/comments
8
2017-06-22T18:16:30Z
2017-09-06T20:50:05Z
https://github.com/chakra-core/ChakraCore/issues/3209
237,929,948
3,209
[ "chakra-core", "ChakraCore" ]
For every script (`Utf8SourceInfo`) a global function contains `boundPropertyRecords` map which is a hash set of `propertyId` to `ProperytRecord*`. All the functions of that script share this map and add entries of property it finds during bytecodegen of that function. This map is at global function level because multiple functions can have same property referred and it is wise to have their entries once in this map instead of having separate map for every function. However now we redefer parse a function, there can be a case where property record entries added by re-deferred function are unique to that function and can be safely removed from the global map. Evaluate if there is a better way where we can optimize how we save bound property records.
Possibility of optimizing memory of BoundpropertyRecordList
https://api.github.com/repos/chakra-core/ChakraCore/issues/3206/comments
0
2017-06-22T05:51:46Z
2017-08-15T21:34:26Z
https://github.com/chakra-core/ChakraCore/issues/3206
237,738,591
3,206
[ "chakra-core", "ChakraCore" ]
``` print(Intl.DateTimeFormat.supportedLocalesOf); print(Intl.getCanonicalLocales); ``` ``` function() { [native code] } function CanonicalizeLocaleList() { [native code] } ``` Should do something similar here to hide name of the implementing function as we did for `supportedLocalesOf`.
Name of function `Intl.getCanonicalLocales` is incorrectly `CanonicalizeLocaleList` -- should be hidden.
https://api.github.com/repos/chakra-core/ChakraCore/issues/3204/comments
3
2017-06-22T01:30:28Z
2017-07-20T20:44:17Z
https://github.com/chakra-core/ChakraCore/issues/3204
237,708,219
3,204
[ "chakra-core", "ChakraCore" ]
For example: ``` new Intl.DateTimeFormat.supportedLocalesOf(); ``` outputs: ``` TypeError: Function 'Intl.DateTimeFormat.supportedLocalesOf' is not a constructor at Global code (e:\work\intl-icu-xplat\test\iswellformedlanguagetag.js:2:1) ``` Similar should happen for ``` new Intl.getCanonicalLocales(); ``` Instead, an object is constructed.
`new Intl.getCanonicalLocales()` should fail with `not a constructor`
https://api.github.com/repos/chakra-core/ChakraCore/issues/3203/comments
0
2017-06-22T01:23:42Z
2017-07-20T20:44:17Z
https://github.com/chakra-core/ChakraCore/issues/3203
237,707,375
3,203
[ "chakra-core", "ChakraCore" ]
In the following test case ```js function foo() { return function bar(a) { a = 4; console.log(arguments[0]) } } foo()(2); ``` In the parser (Parse.cpp:1710), when we defer parse `foo` (or -force:deferparse) it looks like we incorrectly set `m_currentNodeFunc->sxFnc.SetHasAnyWriteToFormals(true);` to `foo`. I am not entirely sure of the implication of this. It looks like we use that flag to do `arguments` optimization. Maybe we are missing some optimization opportunities because of this.
HasAnyWriteToFormals in deferparse
https://api.github.com/repos/chakra-core/ChakraCore/issues/3194/comments
1
2017-06-20T19:02:12Z
2018-05-31T00:31:56Z
https://github.com/chakra-core/ChakraCore/issues/3194
237,312,215
3,194
[ "chakra-core", "ChakraCore" ]
I'd like some method to remove my non-null promise continuation callback from the JavaScriptContext. However, I get a ``JavaScriptErrorCode.NullArgument`` if I call ``JavaScriptContext.SetPromiseContinuationCallback(null, IntPtr.Zero)`` I presume the argument validation is too strict?
can't cleanup after JsSetPromiseContinuationCallback
https://api.github.com/repos/chakra-core/ChakraCore/issues/3192/comments
2
2017-06-20T15:54:21Z
2017-07-19T19:11:18Z
https://github.com/chakra-core/ChakraCore/issues/3192
237,260,789
3,192
[ "chakra-core", "ChakraCore" ]
https://stackoverflow.com/a/44637643/646551 ### Steps to reproduce Run the following code using ch.exe: ``` // var earlyDateString = new Date().toLocaleString(); Map = {}; var dateString = new Date().toLocaleString(); ``` ### Expected result dateString contains something like "β€Ž20β€Ž/β€Ž06β€Ž/β€Ž2017β€Ž β€Ž5β€Ž:β€Ž46β€Ž:β€Ž36β€Ž β€ŽPM" ### Actual result ``` TypeError: Intl is not available. at Global code (e:\my downloads\cc_windows_1_5_2\bin\x64_release\test.js:3:1) ``` ### Workaround Uncomment the first line so Intl is initialised before Map is overridden. ### Other browsers Google Chrome: Not affected Mozilla Firefox: Not affected
Date locale functions fail if Map is overridden
https://api.github.com/repos/chakra-core/ChakraCore/issues/3189/comments
3
2017-06-20T07:57:15Z
2017-06-20T22:02:20Z
https://github.com/chakra-core/ChakraCore/issues/3189
237,123,169
3,189
[ "chakra-core", "ChakraCore" ]
Hello, The following code behaves incorrectly (inconsistent with the standard and other engines) in Chakra due to incorrect realization of SetItems() functions: ``` var y = 0; var t = [1,2,3]; var mp = new Proxy([], { get: function (oTarget, sKey) { print("get " + sKey.toString()); y = y + 1; print("y = " + y); if(y == 2){ var temp = []; t.length = 20; for (var i=0; i<20; i++) t[i] = 0x10; return 5; } if(y > 2) { return oTarget[sKey]; } return oTarget[sKey] || undefined; //return oTarget[sKey] || oTarget.getItem(sKey) || undefined; }, set: function (oTarget, sKey, vValue) { print("set " + sKey); if (sKey in oTarget) { return false; } return oTarget[sKey] = vValue; }, }); function f(a){ print(a); } t.length = 4; t.__proto__ = mp; f(...t); ``` the 't[i] = 0x10;' in get() should call set() when i is undefined, however, in Chakra, t[i] is assigned directly.
Incorrect realization of SetItem() functions
https://api.github.com/repos/chakra-core/ChakraCore/issues/3187/comments
10
2017-06-20T01:49:01Z
2019-06-07T19:10:02Z
https://github.com/chakra-core/ChakraCore/issues/3187
237,070,090
3,187
[ "chakra-core", "ChakraCore" ]
Turn on WasmMathExFilter and cover the case for `rem_s(min_int , -1)` where we need to resume after the exception and set RDX to 0
WASM - Turn on -WasmMathExFilter
https://api.github.com/repos/chakra-core/ChakraCore/issues/3182/comments
0
2017-06-19T18:29:57Z
2018-05-07T22:19:28Z
https://github.com/chakra-core/ChakraCore/issues/3182
236,979,784
3,182
[ "chakra-core", "ChakraCore" ]
Lower TrapIfTruncOverflow independently of the conversion. If we deadstore the conversion we still have the checks to trap
WASM - Lower TrapIfTruncOverflow (2d)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3180/comments
0
2017-06-19T18:22:35Z
2018-05-07T22:19:43Z
https://github.com/chakra-core/ChakraCore/issues/3180
236,977,784
3,180