issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.46B
issue_number
int64
1
127k
[ "chakra-core", "ChakraCore" ]
i tried `--arch=arm` and `--target=ios`, neither works are there any roadmap for building for IOS ?
How can i build ChakraCore for IOS?
https://api.github.com/repos/chakra-core/ChakraCore/issues/3179/comments
5
2017-06-19T16:13:56Z
2018-06-17T11:57:40Z
https://github.com/chakra-core/ChakraCore/issues/3179
236,943,975
3,179
[ "chakra-core", "ChakraCore" ]
`PrintChakraCoreVersion()` in `bin/ch/ch.cpp` uses ANSI version of Windows APIs, like `GetModuleFileNameA`, `GetFileVersionInfoA`, etc., so if the current path contains non-ascii characters and the current code page doesn't support these characters, `GetFileVersionInfoA` fails even though the file is there. ![unicodetest](https://user-images.githubusercontent.com/16713498/27271829-fd8e24e6-5494-11e7-8036-115e268dcb04.png) Maybe related to #2712.
ch.exe -v doesn't work correctly if path contains non-ascii characters
https://api.github.com/repos/chakra-core/ChakraCore/issues/3178/comments
1
2017-06-19T06:15:33Z
2017-10-14T02:29:03Z
https://github.com/chakra-core/ChakraCore/issues/3178
236,789,475
3,178
[ "chakra-core", "ChakraCore" ]
Extracted from #3159 _wfopen_s's implementation [here](https://github.com/Microsoft/ChakraCore/blob/master/pal/src/cruntime/file.cpp#L358) limits the mode to 10 chars - so calling _wfopen with "r, ccs=UNICODE" fails since the mode string is longer than 10 chars.
PAL: wfopen support longer mode strings and improve compatibility
https://api.github.com/repos/chakra-core/ChakraCore/issues/3176/comments
1
2017-06-17T12:00:43Z
2018-06-06T18:45:49Z
https://github.com/chakra-core/ChakraCore/issues/3176
236,656,605
3,176
[ "chakra-core", "ChakraCore" ]
Hello, The Intl collator object doesn't handle Tibetan / Dzongkha collation correctly. I've setup a small test on http://eroux.fr/locales.html and the output of Edge 15 on Windows 10 is ![bugck](https://user-images.githubusercontent.com/60868/27252235-523782b8-5359-11e7-84f4-719ceb6a22ee.png) May or may not be related to http://bugs.icu-project.org/trac/ticket/13224
Intl: Tibetan / Dzongkha collation not working
https://api.github.com/repos/chakra-core/ChakraCore/issues/3175/comments
2
2017-06-17T10:35:05Z
2017-11-08T00:45:51Z
https://github.com/chakra-core/ChakraCore/issues/3175
236,653,170
3,175
[ "chakra-core", "ChakraCore" ]
Hi, We have built with emscripten [libavcodec](https://github.com/FFmpeg/FFmpeg/tree/master/libavcodec) to JS. Everything works fine with Chrome or Firefox but with Edge I get a crash as soon as video starts to be decoded by libavcodec.js. There is no other information that just one "access violation" report. Following the step to reproduce it (crash always!). 1. Unzip [MonaTiny.zip](http://jazzmatazz.free.fr/MonaTiny.zip) 2. Run MonaTiny.exe 3. Open in microsoft edge [http://localhost/player/live.html](http://localhost/player/live.html) Try with Firefox or Chrome, everything is fine. We hope with impatiente a solution. Thanks
Wasm/Asm.js, libavcodec port crash
https://api.github.com/repos/chakra-core/ChakraCore/issues/3165/comments
6
2017-06-15T12:19:44Z
2017-06-22T11:37:35Z
https://github.com/chakra-core/ChakraCore/issues/3165
236,172,432
3,165
[ "chakra-core", "ChakraCore" ]
In lib\Runtime\Language\AsmJsByteCodeGenerator.cpp's AsmJSByteCodeGenerator::EmitCall, we do a c-cast of an AsmJsFunctionDeclaration to AsmJsMathFunction. This can potentially lead to incorrect (but not unsafe) behavior. The relevant code is below: ```c++ if (IsFRound((AsmJsMathFunction*)sym)) { expectedType = AsmJsRetType::Float; } ``` Thanks to @Cellule and @MikeHolman for earlier review and analysis of the issue.
AsmJsByteCodeGenerator incorrect cast (potentially incorrect)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3151/comments
0
2017-06-13T18:56:12Z
2017-06-14T20:59:34Z
https://github.com/chakra-core/ChakraCore/issues/3151
235,656,068
3,151
[ "chakra-core", "ChakraCore" ]
investigate $262test failure and re-enable test
https://api.github.com/repos/chakra-core/ChakraCore/issues/3149/comments
0
2017-06-13T17:00:33Z
2017-06-28T23:39:58Z
https://github.com/chakra-core/ChakraCore/issues/3149
235,621,938
3,149
[ "chakra-core", "ChakraCore" ]
There was a previous discussion regarding this (#2092), when marshalling fields between contexts had just become more permissive, but I still had some questions that remained. **Baseline**: to what extent do contexts on the same thread and runtime share data? - Do values share the reference count? - Are all types of values shareable? - Can I reuse script results between contexts? - Are there any gotchas? Perhaps it's easier the name the things that are not shared? Since `JsCreateSharedArrayBufferWithSharedContent` was recently implemented, I can only assume there are some limitations. The catalyst for this discussion stems from [chakracore-rs#14](https://github.com/darfink/chakracore-rs/issues/14) — how to manage `JsRelease` in destructors. `JsRelease` requires an active context, and this cannot be ensured in destructors with `chakracore-rs` current implementation. Therefore I was contemplating whether a default context could be used to support `JsRelease` (for cases when the user no longer have any active contexts).
Isolation and sharing between contexts
https://api.github.com/repos/chakra-core/ChakraCore/issues/3148/comments
3
2017-06-13T12:11:14Z
2017-06-20T20:27:57Z
https://github.com/chakra-core/ChakraCore/issues/3148
235,532,571
3,148
[ "chakra-core", "ChakraCore" ]
std::uncaught_exception() is deprecated in C++17, which is breaking builds by msvc with ‘/std:c++latest’ option on Windows. Even I /D _SILENCE_CXX17_UNCAUGHT_EXCEPTION_DEPRECATION_WARNING to avoid the warning, but Chakra need address the issue since it affects all users. https://github.com/Microsoft/ChakraCore/blob/master/bin/External/catch.hpp#L7915 D:\Chakra\src\bin\External\catch.hpp(7915): error C2220: warning treated as error - no 'object' file generated (compiling source file NativeTests.cpp) D:\Chakra\src\bin\External\catch.hpp(7915): warning C4996: 'std::uncaught_exception': warning STL4006: std::uncaught_exception() is deprecated in C++17. It is superseded by std::uncaught_exceptions(), plural. You can define _SILENCE_CXX17_UNCAUGHT_EXCEPTION_DEPRECATION_WARNING or _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to acknowledge that you have received this warning. (compiling source file NativeTests.cpp)
Msvc with ‘/std:c++latest’: std::uncaught_exception() is deprecated in C++17
https://api.github.com/repos/chakra-core/ChakraCore/issues/3147/comments
3
2017-06-13T07:00:41Z
2018-01-09T23:02:12Z
https://github.com/chakra-core/ChakraCore/issues/3147
235,454,496
3,147
[ "chakra-core", "ChakraCore" ]
```js function foo() { try { return 1; } finally { return 0; } } ``` Today we bailout with `BailOnEarlyExit` indefinitely for function `foo`.
Too many bailouts for BailOnEarlyExit
https://api.github.com/repos/chakra-core/ChakraCore/issues/3143/comments
1
2017-06-12T22:32:14Z
2017-06-13T20:14:38Z
https://github.com/chakra-core/ChakraCore/issues/3143
235,384,917
3,143
[ "chakra-core", "ChakraCore" ]
https://ci.dot.net/job/Microsoft_ChakraCore/job/master/job/daily_slow_x64_test/156/consoleFull#18131162893c95c4dd-a7e3-4a01-8f84-41941e4287c5Z ``` interpreted\rl.results.log:wasm (limits.js ( -wasm -args --no-verbose --end 4 -endargs) exe) -- failed : exec time=300 ```
test/wasm/limits.js - Slow test timeout >300s
https://api.github.com/repos/chakra-core/ChakraCore/issues/3142/comments
0
2017-06-12T22:11:33Z
2017-06-13T01:48:49Z
https://github.com/chakra-core/ChakraCore/issues/3142
235,380,842
3,142
[ "chakra-core", "ChakraCore" ]
When inlining the call to "test(A2, N);", we should propagate the profile data for A2 into test(). Instead, we seem to use the profile data of the inline, which is more conservative in this case. We end up with: s74[LikelyPrimitive].var = LdElemI_A [s118[**Array_NoMissingValues**][seg: s126][segLen: s127][><].var+s124(s72).u32].var #0015 Func # (#1.1), #2 Bailout: #0015 Func (#1.1), #2 (BailOutOnArrayAccessHelperCall) While I'd expect: s120(s74).f64 = LdElemI_A [s118[**NativeFloatArray_NoMissingValues**][seg: s128][segLen: s129][><].var+s126(s72).u32].var #0015 Func # (#1.1), #2 Bailout: #0015 Func (#1.1), #2 (BailOutConventionalNativeArrayAccessOnly | BailOutOnArrayAccessHelperCall) This is the culprit code in OptSrc() in globopt.cpp: ``` if (valueType.IsLikelyNativeArray() && !valueType.IsObject() && instr->IsProfiledInstr()) { // See if we have profile data for the array type IR::ProfiledInstr *const profiledInstr = instr->AsProfiledInstr(); ValueType profiledArrayType; switch(instr->m_opcode) { case Js::OpCode::LdElemI_A: if(instr->GetSrc1()->IsIndirOpnd() && opnd == instr->GetSrc1()->AsIndirOpnd()->GetBaseOpnd()) { profiledArrayType = profiledInstr->u.ldElemInfo->GetArrayType(); } break; case Js::OpCode::StElemI_A: case Js::OpCode::StElemI_A_Strict: case Js::OpCode::StElemC: if(instr->GetDst()->IsIndirOpnd() && opnd == instr->GetDst()->AsIndirOpnd()->GetBaseOpnd()) { profiledArrayType = profiledInstr->u.stElemInfo->GetArrayType(); } break; case Js::OpCode::LdLen_A: if(instr->GetSrc1()->IsRegOpnd() && opnd == instr->GetSrc1()) { profiledArrayType = profiledInstr->u.ldElemInfo->GetArrayType(); } break; } if(profiledArrayType.IsLikelyObject() && profiledArrayType.GetObjectType() == valueType.GetObjectType() && (profiledArrayType.HasVarElements() || (valueType.HasIntElements() && profiledArrayType.HasFloatElements()))) { // Merge array type we pulled from profile with type propagated by dataflow. valueType = valueType.Merge(profiledArrayType).SetHasNoMissingValues(valueType.HasNoMissingValues()); ChangeValueType(this->currentBlock, CurrentBlockData()->FindValue(opnd->AsRegOpnd()->m_sym), valueType, false); } } ``` I do not understand why this code was added in the first place. Try deleting it, and running all perf and correctness tests. Here is the repro code: ```js function test(arr, N) { var count = 0; var i = 0; var x = 100; while(i < x) { count += arr[i]; i++; } return count; } function foo(N) { for (var i = 0; i < 100; i++) { test(A1, N); } var start = new Date(); for (var i = 0; i < 100000; i++) { test(A2, N); } var end = new Date(); print(end-start + "ms"); } let A1 = new Array(1000); for (var i = 0; i < A1.length; i++) { A1[i] = i+""; } let A2 = new Array(1000); for (var i = 0; i < A2.length; i++) { A2[i] = i+0.1; } for (var i = 0; i < 10; i++) { foo(2); } ```
Profile data should get propagated from inliner to inlinees
https://api.github.com/repos/chakra-core/ChakraCore/issues/3140/comments
1
2017-06-12T18:59:28Z
2017-08-15T17:48:02Z
https://github.com/chakra-core/ChakraCore/issues/3140
235,333,292
3,140
[ "chakra-core", "ChakraCore" ]
ChakraCore could soon support, after 16215+ these wonderful codes for attaching event handlers export function setEvent(selector, event, callBack){ [...document.querySelectorAll(selector)].forEach(function(element){ element.addEventListener(event, callBack); }); } and export function setEvent2(selector, event, callBack){ for(let element of document.querySelectorAll(selector)){ element.addEventListener(event , callBack, false); } } More than one good way to replace JQuery $(selector) .on(event, function(){})
support for [...document.querySelectorAll(selector)].forEach() and for(let element of document.querySelectorAll(selector)){}
https://api.github.com/repos/chakra-core/ChakraCore/issues/3139/comments
4
2017-06-11T00:01:59Z
2017-07-21T14:34:10Z
https://github.com/chakra-core/ChakraCore/issues/3139
235,033,902
3,139
[ "chakra-core", "ChakraCore" ]
See #3120 Could work around this by normalizing indentation in `test/UnitTestFramework/TrimStackTracePath.js`
Investigate why -ExtendedErrorStackForTestHost inserts tabs at the beginning of some frames
https://api.github.com/repos/chakra-core/ChakraCore/issues/3130/comments
1
2017-06-08T18:36:52Z
2018-06-27T23:37:12Z
https://github.com/chakra-core/ChakraCore/issues/3130
234,618,502
3,130
[ "chakra-core", "ChakraCore" ]
Right now if we bailout on not NativeArray we don't properly update the profile info which causes to rejit with the same type and bailout infinitely. We have a workaround that caps the number of rejits to 50, but still doesn't solve the source of the problem. Repro case for loop body case: `ch.exe -mic:1 -off:simplejit -bgjit- -wasm -args --start 2 --end 4 -endargs test/wasm/limits.js` for function case: `ch.exe -mic:1 -off:simplejit -bgjit- -wasm -off:jitloopbodies -args --start 2 --end 4 -endargs test/wasm/limits.js`
Bail on not NativeArray Inifinite rejit
https://api.github.com/repos/chakra-core/ChakraCore/issues/3127/comments
3
2017-06-08T01:50:18Z
2018-06-06T18:47:09Z
https://github.com/chakra-core/ChakraCore/issues/3127
234,389,296
3,127
[ "chakra-core", "ChakraCore" ]
Follow up from #3120 and #3122 (https://github.com/Microsoft/ChakraCore/pull/3122#discussion_r120764836)
[Disabled Tests] test/inlining/rlexe.xml: tests marked as exclude_arm
https://api.github.com/repos/chakra-core/ChakraCore/issues/3124/comments
1
2017-06-07T23:41:06Z
2017-12-05T02:18:29Z
https://github.com/chakra-core/ChakraCore/issues/3124
234,372,885
3,124
[ "chakra-core", "ChakraCore" ]
[Disabled Test] test/es5/es5array_arrayproto_opt.js: fix and re-enable
https://api.github.com/repos/chakra-core/ChakraCore/issues/3121/comments
0
2017-06-07T22:16:22Z
2017-06-07T23:50:34Z
https://github.com/chakra-core/ChakraCore/issues/3121
234,358,909
3,121
[ "chakra-core", "ChakraCore" ]
Looks like they just need baseline updates.
[Disabled Tests] test/inlining/linenumber*.js: fix and re-enable
https://api.github.com/repos/chakra-core/ChakraCore/issues/3120/comments
2
2017-06-07T22:13:52Z
2017-06-12T19:36:44Z
https://github.com/chakra-core/ChakraCore/issues/3120
234,358,438
3,120
[ "chakra-core", "ChakraCore" ]
Adding `-bgjit` (to cancel out default `-bgjit-`) causes the output of this test to match the baseline. Fails as written. ``` <test> <default> <files>oom.js</files> <baseline>oom.baseline</baseline> <!-- Investigate: adding -bgjit makes this test pass --> <!-- <compile-flags>-forcefragmentaddressspace:8000000 -bgjit</compile-flags> --> <compile-flags>-forcefragmentaddressspace:8000000</compile-flags> <tags>exclude_amd64,fail</tags> </default> </test> ```
[Disabled Test] test/Miscellaneous/oom.js: fix and re-enable
https://api.github.com/repos/chakra-core/ChakraCore/issues/3119/comments
0
2017-06-07T21:59:53Z
2018-05-31T00:31:56Z
https://github.com/chakra-core/ChakraCore/issues/3119
234,355,684
3,119
[ "chakra-core", "ChakraCore" ]
It appears that these tests are intended to fail, but the "fail" tag causes them to be excluded from all test runs. They should be updated (probably to use the UnitTestFramework and/or baseline files) to detect that they fail as expected, and the "fail" tag should be removed so that these tests run. ``` test/Error/rlexe.xml-62- <default> test/Error/rlexe.xml-63- <files>sourceInfo_00.js</files> test/Error/rlexe.xml-64- <baseline>sourceInfo_00.baseline</baseline> test/Error/rlexe.xml:65: <tags>fail</tags> test/Error/rlexe.xml-66- </default> test/Error/rlexe.xml-67- </test> test/Error/rlexe.xml-68- <test> test/Error/rlexe.xml-69- <default> test/Error/rlexe.xml-70- <files>sourceInfo_01.js</files> test/Error/rlexe.xml-71- <baseline>sourceInfo_01.baseline</baseline> test/Error/rlexe.xml:72: <tags>fail</tags> test/Error/rlexe.xml-73- </default> test/Error/rlexe.xml-74- </test> test/Error/rlexe.xml-75- <test> test/Error/rlexe.xml-76- <default> test/Error/rlexe.xml-77- <files>sourceInfo_10.js</files> test/Error/rlexe.xml-78- <baseline>sourceInfo_10.baseline</baseline> test/Error/rlexe.xml:79: <tags>fail</tags> test/Error/rlexe.xml-80- </default> test/Error/rlexe.xml-81- </test> test/Error/rlexe.xml-82- <test> test/Error/rlexe.xml-83- <default> test/Error/rlexe.xml-84- <files>sourceInfo_11.js</files> test/Error/rlexe.xml-85- <baseline>sourceInfo_11.baseline</baseline> test/Error/rlexe.xml:86: <tags>fail</tags> test/Error/rlexe.xml-87- </default> test/Error/rlexe.xml-88- </test> test/Error/rlexe.xml-89- <test> test/Error/rlexe.xml-90- <default> test/Error/rlexe.xml-91- <files>sourceInfo_12.js</files> test/Error/rlexe.xml-92- <baseline>sourceInfo_12.baseline</baseline> test/Error/rlexe.xml:93: <tags>fail</tags> test/Error/rlexe.xml-94- </default> test/Error/rlexe.xml-95- </test> test/Error/rlexe.xml-96- <test> test/Error/rlexe.xml-97- <default> test/Error/rlexe.xml-98- <files>sourceInfo_13.js</files> test/Error/rlexe.xml-99- <baseline>sourceInfo_13.baseline</baseline> test/Error/rlexe.xml:100: <tags>fail</tags> test/Error/rlexe.xml-101- </default> test/Error/rlexe.xml-102- </test> test/Error/rlexe.xml-103- <test> test/Error/rlexe.xml-104- <default> test/Error/rlexe.xml-105- <files>sourceInfo_20.js</files> test/Error/rlexe.xml-106- <baseline>sourceInfo_20.baseline</baseline> test/Error/rlexe.xml:107: <tags>fail</tags> test/Error/rlexe.xml-108- </default> test/Error/rlexe.xml-109- </test> test/Error/rlexe.xml-110- <test> ```
[Disabled Tests] test/Error/rlexe.xml: tests tagged "fail" should be fixed and re-enabled
https://api.github.com/repos/chakra-core/ChakraCore/issues/3118/comments
0
2017-06-07T20:44:30Z
2017-08-03T22:25:07Z
https://github.com/chakra-core/ChakraCore/issues/3118
234,336,523
3,118
[ "chakra-core", "ChakraCore" ]
### Browser: Microsoft Edge 38.14393.1066.0 Microsoft EdgeHTML 14.14393 ### Steps to reproduce: 1. Open https://jsfiddle.net/batka/4sobxw6t/ 2. Inspect `Title` element #### Current result: Extra css property `border-image: none;` has been added to `style` attribute. ![screen shot 2017-06-07 at 09 26 18](https://user-images.githubusercontent.com/12029308/26866993-da180f02-4b63-11e7-98d6-e1101a9ecb4e.png) #### Expected result: No extra css properties in `style` attribute.
Additional css property added to style attribute after using removeProperty()
https://api.github.com/repos/chakra-core/ChakraCore/issues/3114/comments
1
2017-06-07T07:32:43Z
2017-06-07T08:03:38Z
https://github.com/chakra-core/ChakraCore/issues/3114
234,117,498
3,114
[ "chakra-core", "ChakraCore" ]
I want to dump the jit-code generated by Chakracore for security research. I read that Chakracore has two compilers which are SimpleJIT and FullJIT. Currently, i can dump the code generated by FullJIT, when i insert a hook into Func::Codegen() just after line 297. However, i cannot dump the jit-code generated by SimpleJIT because i failed to find this compiler! So i want to know whether this code base provides this SimpleJIT compiler? If this is true, could you tell me where it is. Thanks! By the way, my modification is based on branch release/2.0 whose latest commit is 039006b8f4b62eb9d4812241377cf6a38e3c073e.
Where is the simplejit compiler
https://api.github.com/repos/chakra-core/ChakraCore/issues/3106/comments
5
2017-06-05T06:58:04Z
2017-06-13T00:55:34Z
https://github.com/chakra-core/ChakraCore/issues/3106
233,509,392
3,106
[ "chakra-core", "ChakraCore" ]
To support multiple versions of WinGlob and ICU (#2919), make expected output for Intl tests more general by perhaps matching to a RegExp of expected outputs. /cc @tcare (if there's already an open issue for this I couldn't find it)
Intl tests are too specific about output format
https://api.github.com/repos/chakra-core/ChakraCore/issues/3100/comments
1
2017-06-02T22:58:28Z
2017-06-02T22:59:58Z
https://github.com/chakra-core/ChakraCore/issues/3100
233,321,787
3,100
[ "chakra-core", "ChakraCore" ]
It appears that there is some linking problem. I got errors like this when using gold or LLD. I am compiling with clang trunk ``` /usr/bin/ld: error: duplicate symbol: BVUnitT<unsigned long>::ShiftValue >>> defined at /home/prazek/devirtualization-results/ChakraCore/bin/GCStress/GCStress.cpp >>> bin/GCStress/CMakeFiles/GCStress.dir/GCStress.cpp.o:(BVUnitT<unsigned long>::ShiftValue) >>> defined at /home/prazek/devirtualization-results/ChakraCore/lib/Common/Memory/HeapAllocator.cpp >>> HeapAllocator.cpp.o:(.rodata+0x4) in archive lib/libChakraCoreStatic.a ```
multiple definition of 'BVUnitT<unsigned int>::ShiftValue'
https://api.github.com/repos/chakra-core/ChakraCore/issues/3097/comments
3
2017-06-02T16:23:12Z
2017-07-21T14:32:58Z
https://github.com/chakra-core/ChakraCore/issues/3097
233,234,238
3,097
[ "chakra-core", "ChakraCore" ]
[test1.txt](https://github.com/Microsoft/ChakraCore/files/1047865/test1.txt) Options aren't handled properly. (And bug reporting should allow .js files?)
Intl: Date.toLocaleString doesn't handle 'timeZoneName' option correctly
https://api.github.com/repos/chakra-core/ChakraCore/issues/3096/comments
19
2017-06-02T14:00:37Z
2017-11-30T21:19:23Z
https://github.com/chakra-core/ChakraCore/issues/3096
233,192,393
3,096
[ "chakra-core", "ChakraCore" ]
Mirrored from: https://github.com/nodejs/node-chakracore/issues/281 Microsoft Windows [Version 10.0.14393 { http_parser: '2.7.0', node: '7.0.0-pre8', chakra: '11.0.14393.1198', uv: '1.9.1', zlib: '1.2.8', ares: '1.10.1-DEV', modules: '48', openssl: '1.0.2h' } As per below toLocalDateString() is returning the 0x200e character instead of the space character var dd = new Date().toLocaleDateString() for(var dc of dd) console.log(dc.charCodeAt().toString(16)) 200e 36 200e 2f 200e 31 200e 2f 200e 32 30 31 37
new Date().toLocaleDateString() invalid result
https://api.github.com/repos/chakra-core/ChakraCore/issues/3091/comments
24
2017-06-01T22:41:10Z
2017-06-20T18:47:56Z
https://github.com/chakra-core/ChakraCore/issues/3091
233,030,770
3,091
[ "chakra-core", "ChakraCore" ]
It is valuable for the user to have ability to set a specific environment variable to prevent all build optimizations. Chakra Core should allow this.
Environment variable OptimizedBuild=false should prevent build optimizations
https://api.github.com/repos/chakra-core/ChakraCore/issues/3085/comments
0
2017-06-01T00:21:36Z
2017-06-05T20:51:39Z
https://github.com/chakra-core/ChakraCore/issues/3085
232,733,235
3,085
[ "chakra-core", "ChakraCore" ]
The following code causes an assert: ``` function shouldBe(actual, expected) { } { let target = {}; let handlers = { get: function(theTarget, propName, receiver) { shouldBe(receiver, 1); return 42; } }; let proxy = new Proxy(target, handlers); shouldBe(Reflect.get(proxy, 0, 0x777777), 42); } ``` The incorrectly casted value is never used, so this doesn't cause a crash in release. ASSERTION 22521: (/home/user/test_everywhere/ChakraCore/lib/Jsrt/../Runtime/Types/RecyclableObject.inl, line 29) Ensure instance is a RecyclableObject Failure: (Is(aValue)) Illegal instruction (core dumped) [proxy.txt](https://github.com/Microsoft/ChakraCore/files/1042844/proxy.txt)
Assertion failure when calling reflect with Proxy target
https://api.github.com/repos/chakra-core/ChakraCore/issues/3077/comments
1
2017-05-31T20:30:33Z
2017-06-02T03:35:37Z
https://github.com/chakra-core/ChakraCore/issues/3077
232,686,588
3,077
[ "chakra-core", "ChakraCore" ]
The attached file causes an assert to fire in the Debug build. [parseassert.txt](https://github.com/Microsoft/ChakraCore/files/1042546/parseassert.txt) ChakraCore/out/Debug/ch parseassert.txt ASSERTION 8981: (/home/user/test_everywhere/ChakraCore/lib/Parser/Parse.cpp, line 722) !this->m_deferringAST Failure: (!this->m_deferringAST) Illegal instruction (core dumped)
Assertion Failure in Parsing
https://api.github.com/repos/chakra-core/ChakraCore/issues/3076/comments
5
2017-05-31T18:36:38Z
2017-06-06T17:01:03Z
https://github.com/chakra-core/ChakraCore/issues/3076
232,656,720
3,076
[ "chakra-core", "ChakraCore" ]
I used the following code to dump a constant table just right after a Func instance is created, but got an assertion failure `Assert(varConst != nullptr);` when feeding CH with bigfib.cpp.js. ``` --- a/lib/Backend/Func.cpp +++ b/lib/Backend/Func.cpp @@ -295,6 +295,7 @@ Func::Codegen(JitArenaAllocator *alloc, JITTimeWorkItem * workItem, { func.TryCodegen(); rejit = false; + Js::FunctionBody *fbody = (Js::FunctionBody*)(func.GetJITFunctionBody()->GetAddr()); + Js::ByteCodeDumper::DumpConstantTable(fbody); } ``` How can i fix this problem? Thanks!
Assertion fails when dump constant table.
https://api.github.com/repos/chakra-core/ChakraCore/issues/3069/comments
3
2017-05-31T03:32:13Z
2017-06-04T15:19:59Z
https://github.com/chakra-core/ChakraCore/issues/3069
232,443,729
3,069
[ "chakra-core", "ChakraCore" ]
The length property of a generator is configurable if you call get OwnPropertyDescriptor, but if you configure the property with a getter and setter, only the setter gets called. If the property is accessed, the read-only length value is returned, even if the setter has been called. This is because the generator class overrides GetProperty for the length property, but not SetProperty. I believe the standard says that this property be configurable, but regardless it should be consistent (either configurable is true, and you can set the getter and setter, or it is false and you can't). ``` The following code shows the problem: function getSloppyGenerator() { return function* f(x) {}; } function test(testFunction) { testFunction(getSloppyGenerator()); } function testReconfigureAsAccessorProperty(f) { print(f.length); var length = 2; print(Object.getOwnPropertyDescriptor(f, "length").configurable) Object.defineProperty(f, 'length', { get: function() { return length; }, set: function(v) { print("in set"); length = v; } }); print("set"); f.length = 3; print("get " + f.length); } test(testReconfigureAsAccessorProperty); ``` This prints: 1 true set in set get 1 So configurable is true, the setter gets called, but the getter doesn't. It also triggers an assert in the Debug build: ASSERTION 5843: (/home/user/test_everywhere/ChakraCore/lib/Runtime/./Language/CacheOperators.inl, line 362) objectWithProperty->IsWritable(propertyId) || (isRoot && RootObjectBase::FromVar(objectWithProperty)->IsLetConstGlobal(propertyId)) || JavascriptFunction::IsBuiltinProperty(objectWithProperty, propertyId) Failure: ( objectWithProperty->IsWritable(propertyId) || (isRoot && RootObjectBase::FromVar(objectWithProperty)->IsLetConstGlobal(propertyId)) || JavascriptFunction::IsBuiltinProperty(objectWithProperty, propertyId))
Generator length property is inconsistently configurable (+ assert failure in debug build)
https://api.github.com/repos/chakra-core/ChakraCore/issues/3065/comments
1
2017-05-30T19:57:39Z
2017-07-26T00:00:52Z
https://github.com/chakra-core/ChakraCore/issues/3065
232,363,993
3,065
[ "chakra-core", "ChakraCore" ]
The following code behaves incorrectly (inconsistent with the standard and other engines) in Chakra due to a missing cache update: ``` function Base() { } Base.prototype = { f() { return "Base " + this.toString(); }, x: 15, toString() { return "this is Base"; } }; function Derived() { this.derivedDataProperty = "xxx"; } Derived.prototype = { __proto__: Base.prototype, toString() { return "this is Derived"; }, x: 27, f() { var a = super.x; print(this.x); return "Derived"; } }; print(new Base().f()); print(new Derived().f()); ``` It should print 27 as the value of Derived.x, but instead prints 15. This code hits an assert in the debug build: ASSERTION 5639: (/home/user/test_everywhere/ChakraCore/lib/Runtime/Types/TypePropertyCache.cpp, line 277) *propertyValue == JavascriptOperators::GetProperty(propertyObject, propertyId, requestContext) Failure: (*propertyValue == JavascriptOperators::GetProperty(propertyObject, propertyId, requestContext)) Illegal instruction (core dumped)
Caching Error in Chakra
https://api.github.com/repos/chakra-core/ChakraCore/issues/3064/comments
2
2017-05-30T19:49:27Z
2017-08-11T18:13:11Z
https://github.com/chakra-core/ChakraCore/issues/3064
232,361,988
3,064
[ "chakra-core", "ChakraCore" ]
@mjsabby suggested this a long time ago but it was never tracked so it got dropped off our radar 😞 - basically the ask is to update the ChakraCore PDBs in a release distribution using GitLink so that VS can download the sources on the fly. For embedders, this makes debugging a released distribution of ChakraCore a lot easier. cc @boingoing @MSLaguana @dilijev
Run ChakraCore binaries being released through GitLink
https://api.github.com/repos/chakra-core/ChakraCore/issues/3061/comments
2
2017-05-30T01:09:21Z
2018-06-27T23:34:58Z
https://github.com/chakra-core/ChakraCore/issues/3061
232,119,964
3,061
[ "chakra-core", "ChakraCore" ]
If I call JsRun on a script that defines a named function, and then I later call JsRun on a script that attempts to convert that identifier to a string via the functions toString() method, the resulting string is nonsense more often than not. Perhaps I am doing something wrong here, but I cannot imagine what. The program I am encountering this with is not any more complex than a simple read-eval-print loop. If I first have a script like "function a() { return 1; }" and then later have a script like "a.toString()", more often than not, the resulting string will not contain the body of the function. Having a script which calls a named function works entirely normally, even if the toString() call with the same function produces garbage. The only apparent side effect is that the body of the function is not being converted properly to a string, but given that this can sometimes cause a crash, the issue is probably quite serious. If I call the named function's toString() method within the same script that defined it, then the issue does not ever arise. Of course, if it turns out that I'm just doing something wrong or have made a bad assumption, then I'm quite happy to try and fix my own code. When built as a Debug library, it fails catastrophically on a line in the code that reads: `Assert(pFuncBody->IsEval());` Here is the crashlog: ``` Js::ScriptFunction::FormatToString (this=0x7ffff7eacd20, inputString=0x7ffff7e89dc0) Js::ScriptFunction::EnsureSourceString (this=0x7ffff7eacd20) Js::JavascriptFunction::EntryToString (function=0x7ffff7e9a040, callInfo={Count = 1, Flags = Js::CallFlags::CallFlags_Value, unused = 0, static ksizeofCount = 24, static ksizeofCallFlags = 8, static kMaxCountArgs = 16777215}) amd64_CallFunction () Js::JavascriptFunction::CallFunction<true> (function=0x7ffff7e9a040, entryPoint=0xd337a0 <Js::JavascriptFunction::EntryToString(Js::RecyclableObject*, Js::CallInfo, ...)>, args={Info = {Count = 1, Flags = Js::CallFlags::CallFlags_Value, unused = 0, static ksizeofCount = 24, static ksizeofCallFlags = 8, static kMaxCountArgs = 16777215}, Values = 0x7fffffffccf8}) Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > > (this=0x7fffffffcb80, playout=0x7ffff7fa50f1, function=0x7ffff7e9a040, flags=2, spreadIndices=0x0) Js::InterpreterStackFrame::OP_CallI<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<(Js::LayoutSize)0> > > > (this=0x7fffffffcb80, playout=0x7ffff7fa50f1, flags=0) Js::InterpreterStackFrame::ProcessUnprofiled (this=0x7fffffffcb80) Js::InterpreterStackFrame::Process (this=0x7fffffffcb80) Js::InterpreterStackFrame::InterpreterHelper (function=0x7ffff7eacd80, args={<Js::Arguments> = {Info = {Count = 0, Flags = Js::CallFlags::CallFlags_None, unused = 0, static ksizeofCount = 24, static ksizeofCallFlags = 8, static kMaxCountArgs = 16777215}, Values = 0x7fffffffd1c0}, <No data fields>}, returnAddress=0x7ffff4a40f02, addressOfReturnAddress=0x7fffffffd198, isAsmJs=false) Js::InterpreterStackFrame::InterpreterThunk (layout=0x7fffffffd1b0) ?? () ?? () amd64_CallFunction () ``` First I ran a script with JsRun containing "function a() { return 1 }", and then later, in the same context, a script that caused the crash when executing with JsRun just contained "a.toString()"
using jsrt api, defining a named function in one script and calling the function's toString() in another script produces garbage
https://api.github.com/repos/chakra-core/ChakraCore/issues/3060/comments
2
2017-05-28T00:08:46Z
2017-05-31T18:34:16Z
https://github.com/chakra-core/ChakraCore/issues/3060
231,836,324
3,060
[ "chakra-core", "ChakraCore" ]
While one can attach external data to a context, it would be convenient if one could also define a finalizer callback function that would be invoked when the context is no longer needed by a runtime (or when its owning runtime has been disposed) as well as examine to see if a finalize callback is set for a context. The incentive for this request comes from when I tried adding an external object with a finalize callback to the context's global object, and when the runtime was disposed, its finalizer callback was never invoked... but I imagine this has something to do with it being off of the global object, although this may also be a bug. #
Finalizer callback for context
https://api.github.com/repos/chakra-core/ChakraCore/issues/3059/comments
4
2017-05-27T19:19:46Z
2018-06-27T23:38:18Z
https://github.com/chakra-core/ChakraCore/issues/3059
231,822,254
3,059
[ "chakra-core", "ChakraCore" ]
```cpp #include "stdafx.h" #include <stdint.h> #include "ChakraCore.h" #include <string> using namespace std; void check(JsErrorCode code) { if (JsNoError == code) return; bool hasexp; JsErrorCode ec = JsHasException(&hasexp); if (hasexp || code == JsErrorInExceptionState) { JsValueRef err; if (JsNoError != (ec = JsGetAndClearException(&err))) throw logic_error("JsGetAndClearException != JsNoError, Code:" + to_string(ec)); throw logic_error("final error"); } } JsValueRef config; // JSON.parse JsValueRef parse(const string& jsonstr) { JsValueRef value = JS_INVALID_REFERENCE; JsValueRef result = JS_INVALID_REFERENCE; JsPropertyIdRef pid = JS_INVALID_REFERENCE; JsValueRef go = JS_INVALID_REFERENCE; JsValueRef json = JS_INVALID_REFERENCE; JsValueRef parse = JS_INVALID_REFERENCE; JsPropertyIdRef jsonobj_pid = JS_INVALID_REFERENCE; JsPropertyIdRef parse_pid = JS_INVALID_REFERENCE; check(JsGetGlobalObject(&go)); check(JsCreatePropertyId("JSON", 4, &jsonobj_pid)); check(JsCreatePropertyId("parse", 5, &parse_pid)); check(JsGetProperty(go, jsonobj_pid, &json)); check(JsGetProperty(json, parse_pid, &parse)); check(JsCreateString(jsonstr.c_str(), jsonstr.length(), &value)); JsValueRef args[] = { json, value }; check(JsCallFunction(parse, args, 2, &result)); return result; } // JSON.stringify() string stringify(JsValueRef value) { JsValueRef result = JS_INVALID_REFERENCE; JsPropertyIdRef pid = JS_INVALID_REFERENCE; JsValueRef go = JS_INVALID_REFERENCE; check(JsGetGlobalObject(&go)); JsValueRef json = JS_INVALID_REFERENCE; JsValueRef stringify = JS_INVALID_REFERENCE; JsPropertyIdRef jsonobj_id = JS_INVALID_REFERENCE; JsPropertyIdRef stringify_id = JS_INVALID_REFERENCE; check(JsCreatePropertyId("JSON", 4, &jsonobj_id)); check(JsCreatePropertyId("stringify", 9, &stringify_id)); check(JsGetProperty(go, jsonobj_id, &json)); check(JsGetProperty(json, stringify_id, &stringify)); JsValueRef args[] = { go, value }; check(JsCallFunction(stringify, args, 2, &result)); //auto ret = JsCreatePropertyId("__y", 3, &pid); //JsValueRef val = JS_INVALID_REFERENCE; //check(JsCreateString("JSON.stringify(__y)", 19, &val)); //check(JsSetProperty(go, pid, value, false)); //check(JsRun(val, JS_SOURCE_CONTEXT_NONE, val, JsParseScriptAttributeNone, &result)); return "";// call JSON.stringify only } int main() { JsRuntimeHandle handle; JsContextRef context; check(JsCreateRuntime(JsRuntimeAttributeNone, 0, &handle)); check(JsCreateContext(handle, &context)); check(JsSetCurrentContext(context)); config = parse("{\"anykey\":111}"); for (auto i = 0; i < 100000; ++i) { JsPropertyIdRef pid = JS_INVALID_REFERENCE; JsValueRef result = JS_INVALID_REFERENCE; check(JsCreatePropertyId("other", 5, &pid)); check(JsGetProperty(config, pid, &result)); stringify(result); } return 0; } ``` environment: win10,vs2017,debug,x64 I see chinese in your team.so in zh-cn: 这个是我剥离出来的代码,我封装的怕看起来太费劲。我查这个问题用了三天了,特别奇怪。我觉得很大原因在stringify这个函数里,如果不调用它,就不会有问题。 也许是我不会调用,不了解Chakra的规则。
Crash at Jsrt.cpp:1376 JsGetProperty
https://api.github.com/repos/chakra-core/ChakraCore/issues/3057/comments
8
2017-05-26T02:04:29Z
2017-05-27T06:09:49Z
https://github.com/chakra-core/ChakraCore/issues/3057
231,506,763
3,057
[ "chakra-core", "ChakraCore" ]
For more context, see https://github.com/Microsoft/ChakraCore/issues/2862. In 'src\lib\Common\CommonPal.h', I see this code: // MSVC2015 does not support C++11 semantics for `typename QualifiedName` declarations // outside of template code. #define _TYPENAME However, '_TYPENAME' is used in both inside and outside of template context. In the former, 'typename' keyword is required (for example, in 'src\lib\backend\GlobHashTable.h'). MSVC 2015 Update 1 starts to allow 'typename' inside non-template context, so the above logic can be put under test like: #if _MSC_VER < 1910 BTW, names like '_TYPENAME' are reserved by the compiler and the standard library. The user code is not supposed to use them.
Issues found when building with MSVC + /permissive- - 2
https://api.github.com/repos/chakra-core/ChakraCore/issues/3055/comments
0
2017-05-25T22:12:18Z
2017-12-05T22:11:19Z
https://github.com/chakra-core/ChakraCore/issues/3055
231,474,326
3,055
[ "chakra-core", "ChakraCore" ]
The following code causes a null pointer crash in Chakra and the current version of Edge. class A{ constructor() { } } class B extends A { constructor() { super(); } } var observer = new Proxy(A, {}); Reflect.construct(B, [], observer); This code is valid JavaScript that should construct an object correctly. This issue occurs because JavascriptOperators::NewScObjectHostDispatchOrProxy is called by JavascriptOperators::NewScObjectNoCtor when creating the superconstructor's this object. JavascriptOperators::NewScObjectHostDispatchOrProxy returns null as the create object if the provided function is a Proxy. It should return a new object.
NULL pointer crash when calling constructor with Proxy new_target
https://api.github.com/repos/chakra-core/ChakraCore/issues/3054/comments
0
2017-05-25T22:07:45Z
2017-06-05T17:43:42Z
https://github.com/chakra-core/ChakraCore/issues/3054
231,473,453
3,054
[ "chakra-core", "ChakraCore" ]
```javascript ັັັalert(ັັັ'LOL Edge'ັັັ)ັັັ ``` Expected: Invalid token Actual: alert function is called. This behaviour only seems to happen before or after an identifier or object. If you place the characters inside identifier they will be treated differently. Test case: ```javascript eval(String.fromCharCode(1468)+'alert(1)'+String.fromCharCode(1468)); ``` Many more characters exhibit this behaviour 768,769,770,771,772,773,774,775,776,777,778,779,780,781,782,783,784,785,786,787,788,789,790,791,792,793,794,795,796,797,798,799,800,801,802,803,804,805,806,807,808,809,810,811,812,813,814,815,816,817,818,819,820,821,822,823,824,825,826,827,828,829,830,831,832,833,834,835,836,837,838,839,840,841,842,843,844,845,846,847,848,849,850,851,852,853,854,855,856,857,858,859,860,861,862,863,864,865,866,867,868,869,870,871,872,873,874,875,876,877,878,879,1155,1156,1157,1158,1159,1425,1426,1427,1428,1429,1430,1431,1432,1433,1434,1435,1436,1437,1438,1439,1440,1441,1442,1443,1444,1445,1446,1447,1448,1449,1450,1451,1452,1453,1454,1455,1456,1457,1458,1459,1460,1461,1462,1463,1464,1465,1466,1467,1468,1469,1471,1473,1474,1476,1477,1479,1552,1553,1554,1555,1556,1557,1558,1559,1560,1561,1562,1611,1612,1613,1614,1615,1616,1617,1618,1619,1620,1621,1622,1623,1624,1625,1626,1627,1628,1629,1630,1631,1648,1750,1751,1752,1753,1754,1755,1756,1759,1760,1761,1762,1763,1764,1767,1768,1770,1771,1772,1773,1809,1840,1841,1842,1843,1844,1845,1846,1847,1848,1849,1850,1851,1852,1853,1854,1855,1856,1857,1858,1859,1860,1861,1862,1863,1864,1865,1866,1958,1959,1960,1961,1962,1963,1964,1965,1966,1967,1968,2027,2028,2029,2030,2031,2032,2033,2034,2035,2070,2071,2072,2073,2075,2076,2077,2078,2079,2080,2081,2082,2083,2085,2086,2087,2089,2090,2091,2092,2093,2137,2138,2139,2276,2277,2278,2279,2280,2281,2282,2283,2284,2285,2286,2287,2288,2289,2290,2291,2292,2293,2294,2295,2296,2297,2298,2299,2300,2301,2302,2304,2305,2306,2307,2362,2363,2364,2366,2367,2368,2369,2370,2371,2372,2373,2374,2375,2376,2377,2378,2379,2380,2381,2382,2383,2385,2386,2387,2388,2389,2390,2391,2402,2403,2433,2434,2435,2492,2494,2495,2496,2497,2498,2499,2500,2503,2504,2507,2508,2509,2519,2530,2531,2561,2562,2563,2620,2622,2623,2624,2625,2626,2631,2632,2635,2636,2637,2641,2672,2673,2677,2689,2690,2691,2748,2750,2751,2752,2753,2754,2755,2756,2757,2759,2760,2761,2763,2764,2765,2786,2787,2817,2818,2819,2876,2878,2879,2880,2881,2882,2883,2884,2887,2888,2891,2892,2893,2902,2903,2914,2915,2946,3006,3007,3008,3009,3010,3014,3015,3016,3018,3019,3020,3021,3031,3073,3074,3075,3134,3135,3136,3137,3138,3139,3140,3142,3143,3144,3146,3147,3148,3149,3157,3158,3170,3171,3202,3203,3260,3262,3263,3264,3265,3266,3267,3268,3270,3271,3272,3274,3275,3276,3277,3285,3286,3298,3299,3330,3331,3390,3391,3392,3393,3394,3395,3396,3398,3399,3400,3402,3403,3404,3405,3415,3426,3427,3458,3459,3530,3535,3536,3537,3538,3539,3540,3542,3544,3545,3546,3547,3548,3549,3550,3551,3570,3571,3633,3636,3637,3638,3639,3640,3641,3642,3655,3656,3657,3658,3659,3660,3661,3662,3761,3764,3765,3766,3767,3768,3769,3771,3772,3784,3785,3786,3787,3788,3789,3864,3865,3893,3895,3897,3902,3903,3953,3954,3955,3956,3957,3958,3959,3960,3961,3962,3963,3964,3965,3966,3967,3968,3969,3970,3971,3972,3974,3975,3981,3982,3983,3984,3985,3986,3987,3988,3989,3990,3991,3993,3994,3995,3996,3997,3998,3999,4000,4001,4002,4003,4004,4005,4006,4007,4008,4009,4010,4011,4012,4013,4014,4015,4016,4017,4018,4019,4020,4021,4022,4023,4024,4025,4026,4027,4028,4038,4139,4140,4141,4142,4143,4144,4145,4146,4147,4148,4149,4150,4151,4152,4153,4154,4155,4156,4157,4158,4182,4183,4184,4185,4190,4191,4192,4194,4195,4196,4199,4200,4201,4202,4203,4204,4205,4209,4210,4211,4212,4226,4227,4228,4229,4230,4231,4232,4233,4234,4235,4236,4237,4239,4250,4251,4252,4253,4957,4958,4959,5906,5907,5908,5938,5939,5940,5970,5971,6002,6003,6068,6069,6070,6071,6072,6073,6074,6075,6076,6077,6078,6079,6080,6081,6082,6083,6084,6085,6086,6087,6088,6089,6090,6091,6092,6093,6094,6095,6096,6097,6098,6099,6109,6155,6156,6157,6158,6313,6432,6433,6434,6435,6436,6437,6438,6439,6440,6441,6442,6443,6448,6449,6450,6451,6452,6453,6454,6455,6456,6457,6458,6459,6576,6577,6578,6579,6580,6581,6582,6583,6584,6585,6586,6587,6588,6589,6590,6591,6592,6600,6601,6679,6680,6681,6682,6683,6741,6742,6743,6744,6745,6746,6747,6748,6749,6750,6752,6753,6754,6755,6756,6757,6758,6759,6760,6761,6762,6763,6764,6765,6766,6767,6768,6769,6770,6771,6772,6773,6774,6775,6776,6777,6778,6779,6780,6783,6912,6913,6914,6915,6916,6964,6965,6966,6967,6968,6969,6970,6971,6972,6973,6974,6975,6976,6977,6978,6979,6980,7019,7020,7021,7022,7023,7024,7025,7026,7027,7040,7041,7042,7073,7074,7075,7076,7077,7078,7079,7080,7081,7082,7083,7084,7085,7142,7143,7144,7145,7146,7147,7148,7149,7150,7151,7152,7153,7154,7155,7204,7205,7206,7207,7208,7209,7210,7211,7212,7213,7214,7215,7216,7217,7218,7219,7220,7221,7222,7223,7376,7377,7378,7380,7381,7382,7383,7384,7385,7386,7387,7388,7389,7390,7391,7392,7393,7394,7395,7396,7397,7398,7399,7400,7405,7410,7411,7412,7616,7617,7618,7619,7620,7621,7622,7623,7624,7625,7626,7627,7628,7629,7630,7631,7632,7633,7634,7635,7636,7637,7638,7639,7640,7641,7642,7643,7644,7645,7646,7647,7648,7649,7650,7651,7652,7653,7654,7676,7677,7678,7679,8255,8256,8276,8400,8401,8402,8403,8404,8405,8406,8407,8408,8409,8410,8411,8412,8417,8421,8422,8423,8424,8425,8426,8427,8428,8429,8430,8431,8432,11503,11504,11505,11647,11744,11745,11746,11747,11748,11749,11750,11751,11752,11753,11754,11755,11756,11757,11758,11759,11760,11761,11762,11763,11764,11765,11766,11767,11768,11769,11770,11771,11772,11773,11774,11775,12330,12331,12332,12333,12334,12335,12441,12442,42607,42612,42613,42614,42615,42616,42617,42618,42619,42620,42621,42655,42736,42737,43010,43014,43019,43043,43044,43045,43046,43047,43136,43137,43188,43189,43190,43191,43192,43193,43194,43195,43196,43197,43198,43199,43200,43201,43202,43203,43204,43232,43233,43234,43235,43236,43237,43238,43239,43240,43241,43242,43243,43244,43245,43246,43247,43248,43249,43302,43303,43304,43305,43306,43307,43308,43309,43335,43336,43337,43338,43339,43340,43341,43342,43343,43344,43345,43346,43347,43392,43393,43394,43395,43443,43444,43445,43446,43447,43448,43449,43450,43451,43452,43453,43454,43455,43456,43561,43562,43563,43564,43565,43566,43567,43568,43569,43570,43571,43572,43573,43574,43587,43596,43597,43643,43696,43698,43699,43700,43703,43704,43710,43711,43713,43755,43756,43757,43758,43759,43765,43766,44003,44004,44005,44006,44007,44008,44009,44010,44012,44013,64286,65024,65025,65026,65027,65028,65029,65030,65031,65032,65033,65034,65035,65036,65037,65038,65039,65056,65057,65058,65059,65060,65061,65062,65075,65076,65101,65102,65103,65343. I've sorted them into ranges if this helps: 768-879,1155-1159,1425-1469,1471,1473-1474,1476-1477,1479,1552-1562,1611-1631,1648,1750-1756,1759-1764,1767-1768,1770-1773,1809,1840-1866,1958-1968,2027-2035,2070-2073,2075-2083,2085-2087,2089-2093,2137-2139,2276-2302,2304-2307,2362-2364,2366-2383,2385-2391,2402-2403,2433-2435,2492,2494-2500,2503-2504,2507-2509,2519,2530-2531,2561-2563,2620,2622-2626,2631-2632,2635-2637,2641,2672-2673,2677,2689-2691,2748,2750-2757,2759-2761,2763-2765,2786-2787,2817-2819,2876,2878-2884,2887-2888,2891-2893,2902-2903,2914-2915,2946,3006-3010,3014-3016,3018-3021,3031,3073-3075,3134-3140,3142-3144,3146-3149,3157-3158,3170-3171,3202-3203,3260,3262-3268,3270-3272,3274-3277,3285-3286,3298-3299,3330-3331,3390-3396,3398-3400,3402-3405,3415,3426-3427,3458-3459,3530,3535-3540,3542,3544-3551,3570-3571,3633,3636-3642,3655-3662,3761,3764-3769,3771-3772,3784-3789,3864-3865,3893,3895,3897,3902-3903,3953-3972,3974-3975,3981-3991,3993-4028,4038,4139-4158,4182-4185,4190-4192,4194-4196,4199-4205,4209-4212,4226-4237,4239,4250-4253,4957-4959,5906-5908,5938-5940,5970-5971,6002-6003,6068-6099,6109,6155-6158,6313,6432-6443,6448-6459,6576-6592,6600-6601,6679-6683,6741-6750,6752-6780,6783,6912-6916,6964-6980,7019-7027,7040-7042,7073-7085,7142-7155,7204-7223,7376-7378,7380-7400,7405,7410-7412,7616-7654,7676-7679,8255-8256,8276,8400-8412,8417,8421-8432,11503-11505,11647,11744-11775,12330-12335,12441-12442,42607,42612-42621,42655,42736-42737,43010,43014,43019,43043-43047,43136-43137,43188-43204,43232-43249,43302-43309,43335-43347,43392-43395,43443-43456,43561-43574,43587,43596-43597,43643,43696,43698-43700,43703-43704,43710-43711,43713,43755-43759,43765-43766,44003-44010,44012-44013,64286,65024-65039,65056-65062,65075-65076,65101-65103,65343
Unicode: Many characters incorrectly treated as whitespace
https://api.github.com/repos/chakra-core/ChakraCore/issues/3050/comments
17
2017-05-25T07:07:07Z
2018-06-06T18:48:06Z
https://github.com/chakra-core/ChakraCore/issues/3050
231,258,644
3,050
[ "chakra-core", "ChakraCore" ]
When eval references this, OP_GetThisScoped casts each link in the scope chain to a DynamicObject to look for the correct this object. However, if eval is called inside a with statement, the scope chain could contain a WithObject, which is not a Dynamic object. This causes an assert to fire, and could cause incorrect functionality. To reproduce the issue, use the following script: var arrowInsideWithEval; with ({}) { arrowInsideWithEval = (s) => eval(s); arrowInsideWithEval("this"); }
Incorrect cast and assert when calling eval in a with statement
https://api.github.com/repos/chakra-core/ChakraCore/issues/3049/comments
1
2017-05-25T01:57:30Z
2017-07-06T06:52:54Z
https://github.com/chakra-core/ChakraCore/issues/3049
231,219,270
3,049
[ "chakra-core", "ChakraCore" ]
We've moved our release notes from [Release Notes](https://github.com/Microsoft/ChakraCore/wiki/Release-Notes) to [Roadmap](https://github.com/Microsoft/ChakraCore/wiki/Roadmap#release-notes). Point to [Roadmap](https://github.com/Microsoft/ChakraCore/wiki/Roadmap#release-notes) instead for all occurrences of ```<releaseNotes>https://github.com/Microsoft/ChakraCore/wiki/Release-Notes</releaseNotes>``` in this [query](https://github.com/Microsoft/ChakraCore/search?utf8=%E2%9C%93&q=https%3A%2F%2Fgithub.com%2FMicrosoft%2FChakraCore%2Fwiki%2FRelease-Notes&type=).
Point to the roadmap wiki for release notes in nuspec files
https://api.github.com/repos/chakra-core/ChakraCore/issues/3047/comments
3
2017-05-24T22:54:25Z
2017-06-20T01:02:19Z
https://github.com/chakra-core/ChakraCore/issues/3047
231,194,162
3,047
[ "chakra-core", "ChakraCore" ]
The following script (a v8 test case) throws an assert when I run it with Chakra: load("test/mjsunit/wasm/wasm-constants.js"); load("test/mjsunit/wasm/wasm-module-builder.js"); (function() { "use asm"; var builder = new WasmModuleBuilder(); builder.addFunction("regression_702460", kSig_i_v) .addBody([ kExprI32Const, 0x52, kExprI32Const, 0x41, kExprI32Const, 0x3c, kExprI32Const, 0xdc, 0x01, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprSetLocal, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprGrowMemory, 0x00, kExprS128LoadMem, 0x00, 0x40, kExprUnreachable, kExprGrowMemory, 0x00 ]).exportFunc(); assertThrows(() => builder.instantiate()); })(); It would be preferable if this did not throw an assert unless it puts Chakra in a bad state, as it makes testing more difficult
Function parsing throws an assert
https://api.github.com/repos/chakra-core/ChakraCore/issues/3046/comments
4
2017-05-24T22:49:40Z
2017-05-25T20:35:25Z
https://github.com/chakra-core/ChakraCore/issues/3046
231,193,214
3,046
[ "chakra-core", "ChakraCore" ]
According to the spec : https://tc39.github.io/ecma262/#sec-forbidden-extensions `Array.prototype.push.hasOwnProperty('arguments')` `Array.prototype.push.hasOwnProperty('caller')` must return false. It actually returns true. Also `Array.prototype.push.arguments === undefined` `Array.prototype.push.caller === undefined` must be equal to true. Arguments is actually equal to "null object".
`arguments` and `caller` own properties should not exist on built-in functions
https://api.github.com/repos/chakra-core/ChakraCore/issues/3043/comments
1
2017-05-24T19:56:24Z
2017-12-08T23:14:02Z
https://github.com/chakra-core/ChakraCore/issues/3043
231,153,415
3,043
[ "chakra-core", "ChakraCore" ]
```js 1,class extends[]/print(1){} ``` Expected: Syntax error unexpected token `/` Actual: prints 1, complains about the class not having a valid prototype value.
Incorrect parsing of class expression
https://api.github.com/repos/chakra-core/ChakraCore/issues/3040/comments
0
2017-05-24T15:51:19Z
2017-10-05T22:43:00Z
https://github.com/chakra-core/ChakraCore/issues/3040
231,087,705
3,040
[ "chakra-core", "ChakraCore" ]
```js x=>{}/print(1)/+print(2) ``` Actual: prints 1 and 2 Expected: Syntax Error (arrow function is not allowed syntactically in this position) Also has this nice ASI hazard that is maybe more worrying: ```js x=>{} /print(1)/+print(2) ``` Actual: Prints 1 and 2 Expected: Just print 2 (`/print(1)/` gets parsed as a regexp literal)
Incorrect parsing of arrow function followed by a division
https://api.github.com/repos/chakra-core/ChakraCore/issues/3039/comments
1
2017-05-24T14:21:24Z
2017-11-29T21:51:00Z
https://github.com/chakra-core/ChakraCore/issues/3039
231,057,076
3,039
[ "chakra-core", "ChakraCore" ]
``` <!-- Below test fails with difference in space. Investigate the cause and re-enable them <test> <default> <files>crossthread.js</files> <baseline>crossthread_es6.baseline</baseline> <tags>typedarray,exclude_arm,exclude_chk</tags> </default> </test> --> ```
[Disabled Test] test/typedarray/rlexe.xml: crossthread.js fails with difference in space
https://api.github.com/repos/chakra-core/ChakraCore/issues/3038/comments
3
2017-05-24T09:25:20Z
2019-06-07T18:52:09Z
https://github.com/chakra-core/ChakraCore/issues/3038
230,974,857
3,038
[ "chakra-core", "ChakraCore" ]
Either remove or fix/update these tests.
[Disabled Tests] test/switchStatement/rlexe.xml: Disabled -testtrace cases to eliminate maintenance headache
https://api.github.com/repos/chakra-core/ChakraCore/issues/3037/comments
2
2017-05-24T09:01:14Z
2017-07-11T00:26:42Z
https://github.com/chakra-core/ChakraCore/issues/3037
230,968,199
3,037
[ "chakra-core", "ChakraCore" ]
``` <!-- too slow (Microsoft/ChakraCore#3036) <test> <default> <files>testResizeLoadStore-2.js</files> <baseline>testResizeLoadStore-2-noAsmjs.baseline</baseline> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-bgjit- -simdjs -asmjs- -simd128typespec -off:simplejit -mic:1 -lic:1</compile-flags> </default> </test> --> ``` ``` <!-- too slow (Microsoft/ChakraCore#3036) <test> <default> <files>testResizeLoadStore.js</files> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-bgjit- -simdjs -asmjs- -simd128typespec -off:simplejit -mic:1 -lic:1</compile-flags> </default> </test> --> ```
[Disabled Tests] test/SIMD.int32x4.asmjs/rlexe.xml: testResizeLoadStore*.js -off:simplejit disabled: "too slow"
https://api.github.com/repos/chakra-core/ChakraCore/issues/3036/comments
0
2017-05-24T08:35:45Z
2017-06-02T02:15:37Z
https://github.com/chakra-core/ChakraCore/issues/3036
230,961,260
3,036
[ "chakra-core", "ChakraCore" ]
In some cases an object removed from an array with `Array.splice` is still allocated in memory, even though it is not seen in a heap dump. This results in IE(11.0.42) and Edge(38.14393) running out of memory in Windows in our web app. Chrome(58) does not have this issue. Array.splice is a common way to remove entries in arrays. If it leaks I believe it is a huge issue for Edge. I've created a small example. It creates an array with a large objects, and then removes the object with `splice(0,1)`. Running this for a few seconds takes both IE and Edge to a memory consumption of more than 1GB, which is never freed. An inspection shows only empty arrays. Example at https://jsfiddle.net/aefxf0v9/ ``` // create 80kb Object function createLargeObject(){ var temparray = []; for(var i=0;i<10000;i++){ temparray[i]=i; } return { obj:temparray }; } function leak() { globalarray = []; for(var i=0;i<20000;i++) { globalarray[i]=[]; var innerarray = globalarray[i]; var largeObj = createLargeObject(); innerarray[0] = largeObj ; //innerarray[0] = null; // Adding this will fix the problem innerarray.splice( 0, 1 ); } } ``` Setting the array entry to null before removing it with splice fixes the problem. I have made a shim for our project, but would very much like to see a solution.
Memory leak in Array.splice()
https://api.github.com/repos/chakra-core/ChakraCore/issues/3035/comments
6
2017-05-24T08:24:58Z
2017-06-26T20:06:59Z
https://github.com/chakra-core/ChakraCore/issues/3035
230,958,519
3,035
[ "chakra-core", "ChakraCore" ]
``` <!-- Fix and re-enable or remove (Microsoft/ChakraCore#3034) <test> <default> <files>testShuffle.js</files> <baseline>testShuffle.baseline</baseline> <compile-flags>-bgjit- -simdjs -simd128typespec -off:simplejit -mic:1 -lic:1</compile-flags> </default> </test> --> ```
[Disabled Test] test/SIMD.int32x4/rlexe.xml: Fix and re-enable or remove disabled test
https://api.github.com/repos/chakra-core/ChakraCore/issues/3034/comments
0
2017-05-24T08:17:32Z
2017-06-02T23:50:37Z
https://github.com/chakra-core/ChakraCore/issues/3034
230,956,610
3,034
[ "chakra-core", "ChakraCore" ]
``` <!-- Disabled due to bug in TypeSpec (Microsoft/ChakraCore#3033) <test> <default> <files>testResizeLoadStore-2.js</files> <baseline>testResizeLoadStore-2-noAsmJs.baseline</baseline> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-bgjit- -simdjs -asmjs- -simd128typespec -off:simplejit -mic:1 -lic:1</compile-flags> </default> </test> --> ```
[Disabled Test] test/SIMD.float32x4.asmjs/rlexe.xml: test disabled "due to bug in TypeSpec"
https://api.github.com/repos/chakra-core/ChakraCore/issues/3033/comments
0
2017-05-24T05:18:08Z
2017-06-02T02:15:37Z
https://github.com/chakra-core/ChakraCore/issues/3033
230,923,100
3,033
[ "chakra-core", "ChakraCore" ]
``` <!-- currently too slow. Enable with globOpt support. (Microsoft/ChakraCore#3032) <test> <default> <files>testLoadStore-2.js</files> <baseline>testLoadStore-2.baseline</baseline> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-bgjit- -on:asmjs -simdjs -testtrace:asmjs -AsmJsStopOnError</compile-flags> </default> </test> <test> <default> <files>testLoadStore-2.js</files> <baseline>testLoadStore-2.baseline</baseline> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-bgjit- -on:asmjs -simdjs -testtrace:asmjs -AsmJsStopOnError</compile-flags> </default> </test> --> ```
[Disabled Tests] test/SIMD.float32x4.asmjs/rlexe.xml: test disabled with "too slow. Enable with globOpt support."
https://api.github.com/repos/chakra-core/ChakraCore/issues/3032/comments
0
2017-05-24T05:15:38Z
2017-06-02T23:50:37Z
https://github.com/chakra-core/ChakraCore/issues/3032
230,922,835
3,032
[ "chakra-core", "ChakraCore" ]
It is peculiar that these tests are `-off:fulljit -off:backend` and also includes a remark about being too slow to run in interpreter. Example: ``` <test> <default> <files>testLoadStore-2.js</files> <baseline>testLoadStore-2.baseline</baseline> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-bgjit- -on:asmjs -simdjs -testtrace:asmjs -AsmJsStopOnError -lic:1</compile-flags> </default> </test> <!-- too slow to run in interpreter <test> <default> <files>testLoadStore-2.js</files> <baseline>testLoadStore-2.baseline</baseline> <tags>exclude_dynapogo,exclude_ship</tags> <compile-flags>-on:asmjs -simdjs -testtrace:asmjs -AsmJsStopOnError -on:AsmJsInterpreter -off:fulljit -off:backend</compile-flags> </default> </test> --> ``` Please update or remove these tests. Are they too slow to run even under `Slow` configuration? Maybe they should be enabled for `Slow` with a suitable timeout?
[Disabled Tests] test/SIMD.float32x4.asmjs/rlexe.xml: tests disabled with "too slow to run in interpreter"
https://api.github.com/repos/chakra-core/ChakraCore/issues/3031/comments
0
2017-05-24T05:13:20Z
2017-06-02T23:50:37Z
https://github.com/chakra-core/ChakraCore/issues/3031
230,922,556
3,031
[ "chakra-core", "ChakraCore" ]
* [x] First pass: Enable tests on some platform (perhaps Win 10), even if they still don't work on 2012 R2. Add exclude_* for other platforms. * [ ] Second pass: Fix failures on 2012 R2 and re-enable tests, or determine that they cannot run on 2012 R2 by design. Note: Tests involve `toLocaleString` which is Intl-related. Update 2018-06-28: Re-evaluate needs based on OS versions we use in CI.
[Disabled Tests] test/Object/rlexe.xml: disabled tests due to failures on Windows Server 2012 R2
https://api.github.com/repos/chakra-core/ChakraCore/issues/3030/comments
0
2017-05-24T04:52:23Z
2019-06-07T19:04:52Z
https://github.com/chakra-core/ChakraCore/issues/3030
230,920,002
3,030
[ "chakra-core", "ChakraCore" ]
It is never defined and should be eliminated.
Unused "JD_PRIVATE" conditional compilation macro is mentioned in the sources
https://api.github.com/repos/chakra-core/ChakraCore/issues/3024/comments
4
2017-05-23T22:31:25Z
2017-05-24T01:09:40Z
https://github.com/chakra-core/ChakraCore/issues/3024
230,868,277
3,024
[ "chakra-core", "ChakraCore" ]
Various versions of WinGlob across supported Windows OS's as well as supporting ICU (#2919) could fracture these tests further with different implementation-specific expected outputs. For example, formatting a number as a `percent` could have either a regular space (`\x20`), NON-BREAKING SPACE (`\u00a0`) or no space at all. The goal of Intl tests is to ensure the output is reasonable, not that the output matches specifically a spec-defined template (because no such template exists, the spec allows implementation-defined behavior). Therefore it makes sense to capture various reasonable possibilities (as output by the various implementations we support) via a RegExp match or something similar. For example we could change expected output like `12,300${NON_BREAKING_SPACE}%` to a test against the RegExp `/12,300[\x20\u00a0]?%/`. /cc @tcare @jianchun
test/Intl/NumberFormat*.js: Make expected output more general to support different implementations
https://api.github.com/repos/chakra-core/ChakraCore/issues/3014/comments
0
2017-05-22T19:32:37Z
2017-07-06T23:28:14Z
https://github.com/chakra-core/ChakraCore/issues/3014
230,495,507
3,014
[ "chakra-core", "ChakraCore" ]
See `test/DebuggerCommon/rlexe.xml` test `attachdetach-delaycapture.js` comment: `<!-- xplat-todo: enable back - investigate [background job thread fails] (Microsoft/ChakraCore#3012) -->`
[Disabled Test] test/DebuggerCommon/attachdetach-delaycapture.js - background job thread fails
https://api.github.com/repos/chakra-core/ChakraCore/issues/3012/comments
0
2017-05-22T19:16:00Z
2018-02-09T23:49:28Z
https://github.com/chakra-core/ChakraCore/issues/3012
230,491,489
3,012
[ "chakra-core", "ChakraCore" ]
Fix and re-enable test in JIT mode, or document as by-design and create a JIT-specific test. See `test\Error\rlexe.xml` for `CallNonFunction.js` test tagged `exclude_native`
[Disabled Test] test/Error/rlexe.xml: CallNonFunction.js: Error difference between interpreter and JIT
https://api.github.com/repos/chakra-core/ChakraCore/issues/3011/comments
0
2017-05-22T19:02:08Z
2017-08-18T23:02:57Z
https://github.com/chakra-core/ChakraCore/issues/3011
230,488,086
3,011
[ "chakra-core", "ChakraCore" ]
See `test\Date\rlexe.xml` `test/Date/xplatInterval.js` is marked `exclude_jenkins` with no explanation. It does use `Date` but it doesn't seem to be timezone sensitive at first glance. Is this another instance of #319 or something else? Please update the test so that it can run in Jenkins or explain in a comment in the `rlexe.xml` why it cannot.
[Disabled Test] test/Date/xplatInterval.js disabled in Jenkins. Is this by design?
https://api.github.com/repos/chakra-core/ChakraCore/issues/3010/comments
1
2017-05-22T18:51:21Z
2017-07-11T11:04:22Z
https://github.com/chakra-core/ChakraCore/issues/3010
230,485,551
3,010
[ "chakra-core", "ChakraCore" ]
See `test/Basics/rlexe.xml`: Test files: ``` Enumerator-deprecated.js Enumerator-WebViewHost.js ```
[Disabled Tests] Fix and re-enable tests in test/Basics/rlexe.xml
https://api.github.com/repos/chakra-core/ChakraCore/issues/3009/comments
0
2017-05-22T18:43:24Z
2017-07-20T20:58:12Z
https://github.com/chakra-core/ChakraCore/issues/3009
230,483,642
3,009
[ "chakra-core", "ChakraCore" ]
Search for `name: "class constructor test"` Search for `Microsoft/ChakraCore#3008` in the test source (PR incoming).
[Disabled Test] Fix and re-enable test case in test/Basics/ScriptFunctionToStrings.js
https://api.github.com/repos/chakra-core/ChakraCore/issues/3008/comments
0
2017-05-22T18:41:45Z
2017-07-14T23:21:57Z
https://github.com/chakra-core/ChakraCore/issues/3008
230,483,221
3,008
[ "chakra-core", "ChakraCore" ]
While I can see that there is JsEquals and JsStrictEquals for comparing two js values for equality, I can't find any mechanism in the jsrt api for comparing two values' magnitude, either lexicographically or numerically, as applicable to the underlying type. Without resorting to writing a one-liner function in javascript and calling it from the native language each time I require it, how can I compare two js values in ways other than simply equality?
[Question] Is there a JSRT api for comparing magnitude of js values?
https://api.github.com/repos/chakra-core/ChakraCore/issues/3005/comments
1
2017-05-21T16:47:43Z
2017-06-07T01:38:29Z
https://github.com/chakra-core/ChakraCore/issues/3005
230,232,749
3,005
[ "chakra-core", "ChakraCore" ]
Not able to extend Node types. Got a runtime crash when calling the parent constructor (`super()`) ```javascript class SubNode extends Node { constructor() { super(); //<- breaks here: "invalid use of the super keyword" } } class SubComment extends Comment{ constructor() { super(); //<- breaks here: "invalid use of the super keyword" } } ```
ES2015, Cannot subclass Comment
https://api.github.com/repos/chakra-core/ChakraCore/issues/2999/comments
6
2017-05-19T19:25:32Z
2017-07-21T14:35:32Z
https://github.com/chakra-core/ChakraCore/issues/2999
230,068,246
2,999
[ "chakra-core", "ChakraCore" ]
ES2015 CustomEvent subclass doesn't show newly defined properties. ```typescript class MyCustomEvent extends CustomEvent{ constructor(args){ super('myohmy', { detail: args }); } // this property doesn't show up while debugging a MyCustomEvent instance get foo(){ return this.detail.foo; } } ```
CustomEvent ES2015 Subclass
https://api.github.com/repos/chakra-core/ChakraCore/issues/2997/comments
4
2017-05-19T15:19:08Z
2017-07-21T14:35:20Z
https://github.com/chakra-core/ChakraCore/issues/2997
230,007,171
2,997
[ "chakra-core", "ChakraCore" ]
https://tc39.github.io/ecma402/#sec-canonicalizelocalelist step 7.b. Object pretending to be an array via getters, with a hole at 0: ``` eshost -h d8,sm,ch-intl-gcl,node -is Intl-gcl-weird.js ## Source class x { // get 0() { return 'en'; } // culture[0] is a hole get 1() { return 'en'; } get length() { return 2; } } let culture = new x(); print(Intl.getCanonicalLocales(culture)[0]); #### d8, sm, node en #### ch-intl-gcl TypeError: Locale is not an object or a string ``` Which reduces to problems with arrays with holes: ``` eshost -h d8,sm,ch-intl-gcl,node -is intl-gcl-array-with-holes.js ## Source let a = []; a[1] = "en"; print(Intl.getCanonicalLocales(a)[0]); #### d8, sm, node en #### ch-intl-gcl TypeError: Locale is not an object or a string ``` @bterlson
Intl: CanonicalizeLocaleList incorrectly errs when holes are present in input array
https://api.github.com/repos/chakra-core/ChakraCore/issues/2987/comments
0
2017-05-18T05:31:49Z
2017-09-14T03:56:55Z
https://github.com/chakra-core/ChakraCore/issues/2987
229,559,597
2,987
[ "chakra-core", "ChakraCore" ]
Follow-up from #2367 At time of writing, Unicode 9.0 is the latest published standard. However, according to [the Unicode website](http://www.unicode.org/versions/Unicode10.0.0/), Unicode 10.0 is scheduled to be published in June 2017, and we should be prepared to update as necessary.
Update CaseInsensitive table to Unicode 10.0
https://api.github.com/repos/chakra-core/ChakraCore/issues/2984/comments
1
2017-05-17T21:01:38Z
2019-06-07T19:07:39Z
https://github.com/chakra-core/ChakraCore/issues/2984
229,485,784
2,984
[ "chakra-core", "ChakraCore" ]
```js let map = new WeakMap(); map.set(window.location, '1'); // TypeError: WeakMap.prototype.set: 'key' is not an object ``` source: https://github.com/emberjs/ember.js/issues/15249 cc @jdalton / @nolanlawson
WeakMap + HostObject === Sadness (TypeError when using HostObject with WeakMap)
https://api.github.com/repos/chakra-core/ChakraCore/issues/2983/comments
5
2017-05-17T20:49:39Z
2017-08-18T00:38:15Z
https://github.com/chakra-core/ChakraCore/issues/2983
229,482,633
2,983
[ "chakra-core", "ChakraCore" ]
Follow-on to #2981. As seen in #2604 it is possible that an i18n library can reject a tag even if it is correct according to https://tools.ietf.org/html/rfc5646#section-2.1 In that case, a fallback "stock canonicalization" should be applied according to ECMA 402 CanonicalizeLanguageTag(https://tc39.github.io/ecma402/#sec-canonicalizelanguagetag) (i.e. RFC 5646 section 4.5), to ensure that the tag returned from `Intl.getCanonicalLocales` is in canonical form, even if a subsequent lookup via e.g. `Intl.DateTimeFormat.supportedLocalesOf` would show that the tag is not supported. No error should be thrown in the case of a grammatically correct language tag.
Intl.js fallback canonicalization of language tags
https://api.github.com/repos/chakra-core/ChakraCore/issues/2982/comments
1
2017-05-17T20:45:01Z
2018-02-15T17:32:08Z
https://github.com/chakra-core/ChakraCore/issues/2982
229,481,451
2,982
[ "chakra-core", "ChakraCore" ]
Add RegExp in Intl.js to high-level test for invalid language tags (according to grammar in RFC 5646 Section 2.1): https://tools.ietf.org/html/rfc5646#section-2.1 This work item pertains to fixing two open issues: * i18n-library-agnostic (ILA) fix for #2604 * part of an ILA fix for #2961 (which pertains to an additional contraint on language tags as defined in ECMA 402 -- see issue for details). No error should be thrown in the case of a grammatically correct language tag. ILA fixes for as many issues as possible is preferred because we will have support for two different libs upon completion of #2919.
Intl.js: Add RegExp to high-level test for valid language tags (according to grammar in RFC 5646 Section 2.1)
https://api.github.com/repos/chakra-core/ChakraCore/issues/2981/comments
0
2017-05-17T20:36:59Z
2017-09-13T23:00:54Z
https://github.com/chakra-core/ChakraCore/issues/2981
229,479,360
2,981
[ "chakra-core", "ChakraCore" ]
# Build log ``` $ ./build.sh --cxx=/usr/local/bin/clang++-4.0 --cc=/usr/local/bin/clang-4.0 --valgrind --lto-thin -j=1 -n lto: ranlib disabled Custom CXX /usr/local/bin/clang++-4.0 Custom CC /usr/local/bin/clang-4.0 Build path: ./out/Release -- ./bin/ch/DbgController.js.h is up to date. skipping. Compile Target : System Default Generating Release makefiles -- Configuring done -- Generating done -- Build files have been written to: /home/yumetodo/ドキュメント/ChakraCore/out/Release [1/309] Building CXX object lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o FAILED: /usr/local/bin/clang++-4.0 -DBIT64=1 -DCAN_BUILD_WABT -DCLANG_HAS_DISABLE_TAIL_CALLS=1 -DENABLE_VALGRIND=1 -DFEATURE_PAL -DHAS_REAL_ICU=1 -DLINUX64 -DNO_PAL_MINMAX -DPAL_STDCPP_COMPAT -DPLATFORM_UNIX=1 -DSTACK_ALIGN=16 -DUNICODE -D_AMD64_ -D_M_AMD64 -D_M_X64 -D_M_X64_OR_ARM64 -D_SAFECRT_USE_CPP_OVERLOADS=1 -D__LINUX__=1 -D__STDC_WANT_LIB_EXT1__=1 -I../../. -I../../lib/Common -I../../lib/Common/PlaceHolder -I../../pal -I../../pal/inc -I../../pal/inc/rt -I../../lib/Runtime/. -I../../lib/Runtime/../JITIDL -I../../lib/Runtime/../Common -I../../lib/Runtime/../Backend -I../../lib/Runtime/../Parser -I../../lib/Runtime/../WasmReader -I../../lib/Runtime/ByteCode -I../../lib/Runtime/PlatformAgnostic -I../../lib/Runtime/Math -Werror -Wno-ignored-attributes -Wno-deprecated-declarations -Wno-parentheses-equality -Wno-missing-braces -Wno-reorder -Wno-microsoft -Wno-unused-value -Wno-int-to-void-pointer-cast -Wno-invalid-offsetof -Wno-undefined-inline -Wno-inconsistent-missing-override -Wno-c++14-extensions -Wno-macro-redefined -Wno-pragmas -Wno-invalid-token-paste -Wno-format -Wno-invalid-noreturn -Wno-null-arithmetic -Wno-tautological-constant-out-of-range-compare -Wno-tautological-undefined-compare -Wno-address-of-temporary -Wno-null-conversion -Wno-return-type -Wno-switch -Wno-implicit-function-declaration -Wno-int-to-pointer-cast -fno-omit-frame-pointer -fdelayed-template-parsing -O3 -DNDEBUG -fdiagnostics-color=always -msse4.2 -fasm-blocks -fms-extensions -fwrapv -flto=thin -O3 -fPIC -std=gnu++11 -MMD -MT lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o -MF lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o.d -o lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o -c ../../lib/Runtime/ByteCode/ByteCodeSerializer.cpp clang-4.0: /home/yumetodo/clang_build/llvm/tools/clang/lib/AST/ItaniumMangle.cpp:4496: void {anonymous}::CXXNameMangler::addSubstitution(uintptr_t): Assertion `!Substitutions.count(Ptr) && "Substitution already exists!"' failed. #0 0x0000000001f6c148 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x1f6c148) #1 0x0000000001f69b5e llvm::sys::RunSignalHandlers() (/usr/local/llvm-4.0.0/bin/clang-4.0+0x1f69b5e) #2 0x0000000001f69f62 SignalHandler(int) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x1f69f62) #3 0x00007f57ac83d390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390) #4 0x00007f57ab5b0428 gsignal /build/glibc-9tT8Do/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0 #5 0x00007f57ab5b202a abort /build/glibc-9tT8Do/glibc-2.23/stdlib/abort.c:91:0 #6 0x00007f57ab5a8bd7 __assert_fail_base /build/glibc-9tT8Do/glibc-2.23/assert/assert.c:92:0 #7 0x00007f57ab5a8c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82) #8 0x00000000037e5070 (anonymous namespace)::CXXNameMangler::addSubstitution(unsigned long) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37e5070) #9 0x00000000037ed239 (anonymous namespace)::CXXNameMangler::mangleType(clang::QualType) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37ed239) #10 0x00000000037efb3d (anonymous namespace)::CXXNameMangler::mangleTemplateArg(clang::TemplateArgument) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37efb3d) #11 0x00000000037effe9 (anonymous namespace)::CXXNameMangler::mangleTemplateArgs(clang::TemplateArgumentList const&) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37effe9) #12 0x00000000037f01ab (anonymous namespace)::CXXNameMangler::manglePrefix(clang::DeclContext const*, bool) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37f01ab) #13 0x00000000037f089f (anonymous namespace)::CXXNameMangler::mangleNestedName(clang::NamedDecl const*, clang::DeclContext const*, llvm::SmallVector<llvm::StringRef, 4u> const*, bool) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37f089f) #14 0x00000000037e8a67 (anonymous namespace)::CXXNameMangler::mangleNameWithAbiTags(clang::NamedDecl const*, llvm::SmallVector<llvm::StringRef, 4u> const*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37e8a67) #15 0x00000000037e67d5 (anonymous namespace)::CXXNameMangler::mangleName(clang::NamedDecl const*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37e67d5) #16 0x00000000037e8bc1 (anonymous namespace)::CXXNameMangler::mangleFunctionEncoding(clang::FunctionDecl const*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37e8bc1) #17 0x00000000037ea234 (anonymous namespace)::ItaniumMangleContextImpl::mangleCXXDtor(clang::CXXDestructorDecl const*, clang::CXXDtorType, llvm::raw_ostream&) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x37ea234) #18 0x00000000021a45a9 clang::CodeGen::CodeGenModule::getMangledName(clang::GlobalDecl) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x21a45a9) #19 0x00000000021bf1cc clang::CodeGen::CodeGenModule::EmitGlobal(clang::GlobalDecl) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x21bf1cc) #20 0x00000000021f0065 (anonymous namespace)::ItaniumCXXABI::EmitCXXConstructors(clang::CXXConstructorDecl const*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x21f0065) #21 0x00000000021bf924 clang::CodeGen::CodeGenModule::EmitTopLevelDecl(clang::Decl*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x21bf924) #22 0x00000000027e58c7 (anonymous namespace)::CodeGeneratorImpl::HandleTopLevelDecl(clang::DeclGroupRef) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x27e58c7) #23 0x00000000027dc943 clang::BackendConsumer::HandleTopLevelDecl(clang::DeclGroupRef) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x27dc943) #24 0x0000000003278a35 clang::Sema::InstantiateFunctionDefinition(clang::SourceLocation, clang::FunctionDecl*, bool, bool, bool) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x3278a35) #25 0x00000000032778fc clang::Sema::PerformPendingInstantiations(bool) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x32778fc) #26 0x0000000002e0973c clang::Sema::ActOnEndOfTranslationUnit() (/usr/local/llvm-4.0.0/bin/clang-4.0+0x2e0973c) #27 0x0000000002bf6696 clang::Parser::ParseTopLevelDecl(clang::OpaquePtr<clang::DeclGroupRef>&) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x2bf6696) #28 0x0000000002bed29b clang::ParseAST(clang::Sema&, bool, bool) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x2bed29b) #29 0x00000000027dd868 clang::CodeGenAction::ExecuteAction() (/usr/local/llvm-4.0.0/bin/clang-4.0+0x27dd868) #30 0x00000000024a5d46 clang::FrontendAction::Execute() (/usr/local/llvm-4.0.0/bin/clang-4.0+0x24a5d46) #31 0x000000000247269e clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x247269e) #32 0x0000000002533f1d clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0x2533f1d) #33 0x0000000000af4b28 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/usr/local/llvm-4.0.0/bin/clang-4.0+0xaf4b28) #34 0x0000000000a7d34d main (/usr/local/llvm-4.0.0/bin/clang-4.0+0xa7d34d) #35 0x00007f57ab59b830 __libc_start_main /build/glibc-9tT8Do/glibc-2.23/csu/../csu/libc-start.c:325:0 #36 0x0000000000af0df9 _start (/usr/local/llvm-4.0.0/bin/clang-4.0+0xaf0df9) Stack dump: 0. Program arguments: /usr/local/llvm-4.0.0/bin/clang-4.0 -cc1 -triple x86_64-unknown-linux-gnu -emit-llvm-bc -flto=thin -disable-free -main-file-name ByteCodeSerializer.cpp -mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu x86-64 -target-feature +sse4.2 -momit-leaf-frame-pointer -dwarf-column-info -debugger-tuning=gdb -coverage-notes-file /home/yumetodo/ドキュメント/ChakraCore/out/Release/lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.gcno -resource-dir /usr/local/llvm-4.0.0/bin/../lib/clang/4.0.0 -dependency-file lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o.d -MT lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o -D BIT64=1 -D CAN_BUILD_WABT -D CLANG_HAS_DISABLE_TAIL_CALLS=1 -D ENABLE_VALGRIND=1 -D FEATURE_PAL -D HAS_REAL_ICU=1 -D LINUX64 -D NO_PAL_MINMAX -D PAL_STDCPP_COMPAT -D PLATFORM_UNIX=1 -D STACK_ALIGN=16 -D UNICODE -D _AMD64_ -D _M_AMD64 -D _M_X64 -D _M_X64_OR_ARM64 -D _SAFECRT_USE_CPP_OVERLOADS=1 -D __LINUX__=1 -D __STDC_WANT_LIB_EXT1__=1 -I ../../. -I ../../lib/Common -I ../../lib/Common/PlaceHolder -I ../../pal -I ../../pal/inc -I ../../pal/inc/rt -I ../../lib/Runtime/. -I ../../lib/Runtime/../JITIDL -I ../../lib/Runtime/../Common -I ../../lib/Runtime/../Backend -I ../../lib/Runtime/../Parser -I ../../lib/Runtime/../WasmReader -I ../../lib/Runtime/ByteCode -I ../../lib/Runtime/PlatformAgnostic -I ../../lib/Runtime/Math -D NDEBUG -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/x86_64-linux-gnu/c++/5.4.0 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/x86_64-linux-gnu/c++/5.4.0 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/backward -internal-isystem /usr/local/include -internal-isystem /usr/local/llvm-4.0.0/bin/../lib/clang/4.0.0/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O3 -Werror -Wno-ignored-attributes -Wno-deprecated-declarations -Wno-parentheses-equality -Wno-missing-braces -Wno-reorder -Wno-microsoft -Wno-unused-value -Wno-int-to-void-pointer-cast -Wno-invalid-offsetof -Wno-undefined-inline -Wno-inconsistent-missing-override -Wno-c++14-extensions -Wno-macro-redefined -Wno-pragmas -Wno-invalid-token-paste -Wno-format -Wno-invalid-noreturn -Wno-null-arithmetic -Wno-tautological-constant-out-of-range-compare -Wno-tautological-undefined-compare -Wno-address-of-temporary -Wno-null-conversion -Wno-return-type -Wno-switch -Wno-implicit-function-declaration -Wno-int-to-pointer-cast -std=gnu++11 -fdeprecated-macro -fdebug-compilation-dir /home/yumetodo/ドキュメント/ChakraCore/out/Release -ferror-limit 19 -fmessage-length 0 -fwrapv -fms-extensions -fdelayed-template-parsing -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -fcolor-diagnostics -fasm-blocks -vectorize-loops -vectorize-slp -o lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/ByteCodeSerializer.cpp.o -x c++ ../../lib/Runtime/ByteCode/ByteCodeSerializer.cpp 1. <eof> parser at end of file 2. ../../lib/Common/DataStructures/BufferBuilder.h:213:9: instantiating function definition 'Js::ConstantSizedBufferBuilderOf<__unaligned Js::SerializedVarArray>::ConstantSizedBufferBuilderOf' 3. ../../lib/Common/DataStructures/BufferBuilder.h:213:9: LLVM IR generation of declaration 'Js::ConstantSizedBufferBuilderOf<__unaligned Js::SerializedVarArray>::ConstantSizedBufferBuilderOf' clang-4.0: error: unable to execute command: Aborted (core dumped) clang-4.0: error: clang frontend command failed due to signal (use -v to see invocation) clang version 4.0.0 (http://llvm.org/git/clang.git 559aa046fe3260d8640791f2249d7b0d458b5700) (http://llvm.org/git/llvm.git 4423e351176a92975739dd4ea43c2ff5877236ae) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/local/bin clang-4.0: note: diagnostic msg: PLEASE submit a bug report to http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and associated run script. clang-4.0: note: diagnostic msg: ******************** PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT: Preprocessed source(s) and associated run script(s) are located at: clang-4.0: note: diagnostic msg: /tmp/ByteCodeSerializer-8f9b6c.cpp clang-4.0: note: diagnostic msg: /tmp/ByteCodeSerializer-8f9b6c.sh clang-4.0: note: diagnostic msg: ******************** ninja: build stopped: subcommand failed. See error details above. Exit code was 1 ``` # Environment ``` $ uname -a Linux yumetodo-desktop 4.4.0-75-generic #96-Ubuntu SMP Thu Apr 20 09:56:33 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.2 LTS" $ gcc --version gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ /usr/local/bin/clang-4.0 --version clang version 4.0.0 (http://llvm.org/git/clang.git 559aa046fe3260d8640791f2249d7b0d458b5700) (http://llvm.org/git/llvm.git 4423e351176a92975739dd4ea43c2ff5877236ae) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/local/bin $ git log -n 1 | cat commit 357fe4c954d776a2d40c6a9ac65931ec31585f46 Merge: 7f5755f 82ff317 Author: Meghana Gupta <[email protected]> Date: Tue May 16 18:36:00 2017 -0700 [MERGE #2954 @meg-gupta] Enable globopt for functions with try finally Merge pull request #2954 from meg-gupta:tryfinallypr This change enables globopt on functions with try finally. We transform the flowgraph such that we have 2 flow edges - try to a excepting finally region and try to non excepting finally region. This enables us to optimize the function on the non exception path. We bailout on the exception path. Special handling is needed when there are early exits (break, continue, return) within the tryfinally. We need to execute the finally block on early exit, currently we bailout on early exit. We transform the flow graph from (eh region -> early exit) to have an edge from (eh region -> finally) and (finally -> early exit) This transformation can be done only after the regions are assigned in FlowGraph. So the flowgraph builder now has the following order of phase: - build flow graph -> add the excepting and non excepting finallys alongside - remove unreachable blocks - assign regions - identify early exits and add edges (does region info update when required) - break blocks removal (does region info update when required) ```
[Linux][Build][Itanium] Abort build in clang 4.0.0
https://api.github.com/repos/chakra-core/ChakraCore/issues/2980/comments
11
2017-05-17T20:27:22Z
2018-03-17T00:33:20Z
https://github.com/chakra-core/ChakraCore/issues/2980
229,476,935
2,980
[ "chakra-core", "ChakraCore" ]
I uses the latest code in `release/2.0` branch. Commit id: ``` commit 34c3ab15197056f15ec2aaac7c4843ba5855e13f Merge: 796a580c fb42d22b Author: Rajat Dua <[email protected]> Date: Tue May 16 14:04:44 2017 -0700 [MERGE #2976 @rajatd] Fix linux builds in 2.0 Merge pull request #2976 from rajatd:fix-linux-build-2.0 ``` I didn't find anything about how to create a js object(JsValueRef) from JSON string through ChakraCore API. There is an API in spidermonkey, v8, javascriptcore to achieve that, but I could not find anything in ChakraCore. Am I missing something? In SpiderMonkey, we get: ```c++ JS_PUBLIC_API(bool) JS_ParseJSON(JSContext* cx, JS::HandleString str, JS::MutableHandleValue vp); ``` In V8, we have: ```c++ static V8_WARN_UNUSED_RESULT MaybeLocal<Value> Parse( Local<Context> context, Local<String> json_string); ``` In JavascriptCore, there is: ```c++ JS_EXPORT JSValueRef JSValueMakeFromJSONString(JSContextRef ctx, JSStringRef string) CF_AVAILABLE(10_7, 7_0); ``` But how to do it in `ChakraCore`? Is there a API for doing this? Currently, a workaround is: * Getting a global `JSON` object * Getting the `parse` property of `JSON` object * Passing json string to `JsCallFunction` and return the result But unfortunately, I got crash in `Type::GetLibrary`, the crash stack is: ![screen shot 2017-05-17 at 15 41 49](https://cloud.githubusercontent.com/assets/493372/26143410/654f8cc4-3b17-11e7-85f1-46cb0069a513.png) ![screen shot 2017-05-17 at 15 41 23](https://cloud.githubusercontent.com/assets/493372/26143414/6944c2cc-3b17-11e7-97da-4fe9e4b16481.png)
Is there a way to create js object (JsValueRef) from JSON string through ChakraCore API?
https://api.github.com/repos/chakra-core/ChakraCore/issues/2978/comments
2
2017-05-17T07:43:04Z
2017-06-07T01:38:47Z
https://github.com/chakra-core/ChakraCore/issues/2978
229,263,992
2,978
[ "chakra-core", "ChakraCore" ]
Fix and re-enable SIMD Test: `test/Array/memset_simd.js` (see `test/Array/rlexe.xml`) If the test cannot be fixed, remove it. Disabled in 91e0e9128
[Disabled Test] Fix and re-enable SIMD Test: test/Array/memset_simd.js
https://api.github.com/repos/chakra-core/ChakraCore/issues/2977/comments
1
2017-05-16T21:32:16Z
2017-08-16T20:58:31Z
https://github.com/chakra-core/ChakraCore/issues/2977
229,175,371
2,977
[ "chakra-core", "ChakraCore" ]
Some signed/unsigned operation are getting cse'd together resulting in invalid code. See test in `wasm/unsigned.js` added in #2956
WASM: int32 unsigned cse
https://api.github.com/repos/chakra-core/ChakraCore/issues/2975/comments
0
2017-05-16T02:04:37Z
2017-06-08T02:36:34Z
https://github.com/chakra-core/ChakraCore/issues/2975
228,894,734
2,975
[ "chakra-core", "ChakraCore" ]
As illustrated below, Chakra does not handle invalid \c the same as other browsers. However, this area is underspecified. Below I link to efforts to standardize on the near-consensus behavior. ``` eshost test-regexp.js -tsi ## Source print(/^[\c]$/.test("\\")); print(/^[\c%]$/.test("c")); print(/[\c%]/.test("\x05")); ┌─────────────────────┬───────┐ │ d8 │ true │ │ d8 harmony │ true │ │ sm │ false │ │ jsc │ │ │ node │ │ ├─────────────────────┼───────┤ │ chakra-es6 │ false │ │ chakra-experimental │ false │ │ chakra │ true │ └─────────────────────┴───────┘ ``` * The following issues have the context: https://github.com/tc39/ecma262/issues/863, https://bugs.chromium.org/p/v8/issues/detail?id=6201 * The following PR proposes standardizing on the near-consensus behavior: https://github.com/tc39/ecma262/pull/864. I don't see a problem changing our behavior here - speak up if you do!
[RegExp] Difference with other engines in handling of invalid \c
https://api.github.com/repos/chakra-core/ChakraCore/issues/2973/comments
0
2017-05-15T22:17:48Z
2018-07-17T17:11:40Z
https://github.com/chakra-core/ChakraCore/issues/2973
228,862,343
2,973
[ "chakra-core", "ChakraCore" ]
### Introduction > Decorators offer a convenient declarative syntax to modify the shape of class declarations. This capability can be used for myriad purposes including modifying the descriptor of the declared member (@nonconfigurable/@enumerable), adding metadata (as used by Angular), and more. [Source](http://tc39.github.io/proposal-decorators/) _**Example**_: ```javascript @frozen class Foo { @configurable(false) @enumerable(true) method() { //do something } } ``` __Current Stage__ : 2 __Latest spec__: https://tc39.github.io/proposal-decorators/
[Feature] Class and Property Decorators
https://api.github.com/repos/chakra-core/ChakraCore/issues/2970/comments
3
2017-05-14T16:53:29Z
2018-03-12T15:59:16Z
https://github.com/chakra-core/ChakraCore/issues/2970
228,553,696
2,970
[ "chakra-core", "ChakraCore" ]
This proposal is currently at Stage 3 and seeking implementations: https://github.com/tc39/proposal-regexp-unicode-property-escapes Tests: https://github.com/tc39/test262/tree/master/test/built-ins/RegExp/property-escapes
[Feature] Implement RegExp Unicode property escapes
https://api.github.com/repos/chakra-core/ChakraCore/issues/2969/comments
2
2017-05-13T09:39:00Z
2018-06-27T23:30:16Z
https://github.com/chakra-core/ChakraCore/issues/2969
228,461,920
2,969
[ "chakra-core", "ChakraCore" ]
I am trying to use ChakraCore on a C# .netcore console app on the Mac. So I built ChakraCore on OSX as dynamic library (libChakraCore.dylib) but got an error when calling the API `JsRunScript`. Looking a Jsrt.cpp the API `JsRunScript` (and some related ones) are within a _WIN32 preprocessor `ifdef`. Out of curiosity I moved the API out of the ifdef. Not only does it find the API now, it even successfully executes the javascript :). What is the reason `JsRunScript` is only enabled for windows? As side question, I was not able to load the static lib (libChakraCoreStatic.a). Where should the static lib be placed and what should DllImport specify?
JsRunScript not available on OSX build
https://api.github.com/repos/chakra-core/ChakraCore/issues/2965/comments
6
2017-05-12T03:58:30Z
2017-05-12T16:23:11Z
https://github.com/chakra-core/ChakraCore/issues/2965
228,181,856
2,965
[ "chakra-core", "ChakraCore" ]
CanonicalizeLocaleList is an internal operation used by many Intl APIs and exposed more or less directly through `Intl.getCanonicalLocales`. https://tc39.github.io/ecma402/#sec-canonicalizelocalelist https://tc39.github.io/ecma402/#sec-intl.getcanonicallocales See test cases with multiple possible outputs added in https://github.com/Microsoft/ChakraCore/pull/2818
Intl: Investigate different behavior between engines on CanonicalizeLocaleList
https://api.github.com/repos/chakra-core/ChakraCore/issues/2964/comments
4
2017-05-12T01:08:10Z
2018-05-09T22:08:35Z
https://github.com/chakra-core/ChakraCore/issues/2964
228,161,928
2,964
[ "chakra-core", "ChakraCore" ]
See: https://tc39.github.io/ecma402/#sec-isstructurallyvalidlanguagetag > The IsStructurallyValidLanguageTag abstract operation verifies that the locale argument... > * ... > * does not include duplicate variant subtags... ``` >es -is -h ch-dev,d8,sm,node,node-ch -e "Intl.DateTimeFormat.supportedLocalesOf(['de-gregory-gregory'])" ## Source print(Intl.DateTimeFormat.supportedLocalesOf(['de-gregory-gregory'])) #### d8, node RangeError: Invalid language tag: de-gregory-gregory #### sm RangeError: invalid language tag: de-gregory-gregory #### node-ch [ 'de' ] #### ch-dev de ``` Expect to throw: `RangeError: Invalid language tag: de-gregory-gregory`
Intl: We do not correctly reject duplicate variant subtags in language tags.
https://api.github.com/repos/chakra-core/ChakraCore/issues/2961/comments
3
2017-05-11T23:25:07Z
2018-02-15T01:12:28Z
https://github.com/chakra-core/ChakraCore/issues/2961
228,148,475
2,961
[ "chakra-core", "ChakraCore" ]
I was collecting a system-wide trace using PerfView, and this assertion fails Assert(!jobProcessorCS || !jobProcessorCS->IsLocked()); with this call stack: > ChakraCore.dll!Js::FunctionProxy::GetAuxPtrWithLock(Js::FunctionProxy::AuxPointerType e) Line 116 C++ ChakraCore.dll!Js::FunctionBody::GetLoopHeaderArrayWithLock() Line 3020 C++ ChakraCore.dll!Js::FunctionBody::GetLoopNumberWithLock(const Js::LoopHeader * loopHeader) Line 3837 C++ ChakraCore.dll!JsLoopBodyCodeGen::GetDisplayName(wchar_t * displayName, unsigned int sizeInChars) Line 289 C++ ChakraCore.dll!CodeGenWorkItem::OnAddToJitQueue() Line 133 C++ ChakraCore.dll!NativeCodeGenerator::AddToJitQueue(CodeGenWorkItem * const codeGenWorkItem, bool prioritize, bool lock, void * function) Line 3396 C++ ChakraCore.dll!NativeCodeGenerator::GenerateLoopBody(Js::FunctionBody * fn, Js::LoopHeader * loopHeader, Js::EntryPointInfo * entryPoint, unsigned int localCount, void * * localSlots) Line 687 C++ ChakraCore.dll!GenerateLoopBody(NativeCodeGenerator * nativeCodeGen, Js::FunctionBody * fn, Js::LoopHeader * loopHeader, Js::EntryPointInfo * info, unsigned int localCount, void * * localSlots) Line 83 C++ ChakraCore.dll!Js::InterpreterStackFrame::DoLoopBodyStart(unsigned int loopNumber, Js::LayoutSize layoutSize, const bool doProfileLoopCheck, bool isFirstIteration) Line 6129 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProfiledLoopBodyStart<0,1>(unsigned int loopNumber, Js::LayoutSize layoutSize, bool isFirstIteration) Line 5776 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_ProfiledLoopBodyStart<0,1>(const unsigned char * ip) Line 5749 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessProfiled() Line 51 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3512 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterHelper(Js::ScriptFunction * function, Js::ArgumentReader args, void * returnAddress, void * addressOfReturnAddress, const bool isAsmJs) Line 2029 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterThunk(Js::JavascriptCallStackLayout * layout) Line 1766 C++ ChakraCore.dll!Js::LocalCallFunction(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args, bool doStackProbe) Line 1348 C++ ChakraCore.dll!Js::JavascriptFunction::CallFunction<1>(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args) Line 1364 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > * playout, Js::RecyclableObject * function, unsigned int flags, const Js::AuxArray<unsigned int> * spreadIndices) Line 3914 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallI<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > * playout, unsigned int flags) Line 446 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessUnprofiled() Line 83 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3487 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_TryCatch(const Js::OpLayoutBr * playout) Line 6568 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessUnprofiled() Line 373 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3487 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterHelper(Js::ScriptFunction * function, Js::ArgumentReader args, void * returnAddress, void * addressOfReturnAddress, const bool isAsmJs) Line 2029 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterThunk(Js::JavascriptCallStackLayout * layout) Line 1766 C++ ChakraCore.dll!Js::LocalCallFunction(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args, bool doStackProbe) Line 1348 C++ ChakraCore.dll!Js::JavascriptFunction::CallFunction<1>(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args) Line 1364 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > * playout, Js::RecyclableObject * function, unsigned int flags, const Js::AuxArray<unsigned int> * spreadIndices) Line 3903 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallI<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > * playout, unsigned int flags) Line 446 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessUnprofiled() Line 83 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3487 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterHelper(Js::ScriptFunction * function, Js::ArgumentReader args, void * returnAddress, void * addressOfReturnAddress, const bool isAsmJs) Line 2029 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterThunk(Js::JavascriptCallStackLayout * layout) Line 1766 C++ ChakraCore.dll!Js::LocalCallFunction(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args, bool doStackProbe) Line 1348 C++ ChakraCore.dll!Js::JavascriptFunction::CallFunction<1>(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args) Line 1364 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > * playout, Js::RecyclableObject * function, unsigned int flags, const Js::AuxArray<unsigned int> * spreadIndices) Line 3903 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallI<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > * playout, unsigned int flags) Line 446 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessUnprofiled() Line 86 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3487 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterHelper(Js::ScriptFunction * function, Js::ArgumentReader args, void * returnAddress, void * addressOfReturnAddress, const bool isAsmJs) Line 2029 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterThunk(Js::JavascriptCallStackLayout * layout) Line 1766 C++ ChakraCore.dll!Js::LocalCallFunction(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args, bool doStackProbe) Line 1348 C++ ChakraCore.dll!Js::JavascriptFunction::CallFunction<1>(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args) Line 1364 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > * playout, Js::RecyclableObject * function, unsigned int flags, const Js::AuxArray<unsigned int> * spreadIndices) Line 3914 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallI<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallIWithICIndex<Js::LayoutSizePolicy<0> > > * playout, unsigned int flags) Line 446 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessUnprofiled() Line 86 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3487 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterHelper(Js::ScriptFunction * function, Js::ArgumentReader args, void * returnAddress, void * addressOfReturnAddress, const bool isAsmJs) Line 2029 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterThunk(Js::JavascriptCallStackLayout * layout) Line 1766 C++ ChakraCore.dll!Js::LocalCallFunction(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args, bool doStackProbe) Line 1348 C++ ChakraCore.dll!Js::JavascriptFunction::CallFunction<1>(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args) Line 1364 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallCommon<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > * playout, Js::RecyclableObject * function, unsigned int flags, const Js::AuxArray<unsigned int> * spreadIndices) Line 3914 C++ ChakraCore.dll!Js::InterpreterStackFrame::OP_CallI<Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > >(const Js::OpLayoutDynamicProfile<Js::OpLayoutT_CallI<Js::LayoutSizePolicy<0> > > * playout, unsigned int flags) Line 446 C++ ChakraCore.dll!Js::InterpreterStackFrame::ProcessUnprofiled() Line 83 C++ ChakraCore.dll!Js::InterpreterStackFrame::Process() Line 3487 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterHelper(Js::ScriptFunction * function, Js::ArgumentReader args, void * returnAddress, void * addressOfReturnAddress, const bool isAsmJs) Line 2029 C++ ChakraCore.dll!Js::InterpreterStackFrame::InterpreterThunk(Js::JavascriptCallStackLayout * layout) Line 1766 C++ ChakraCore.dll!Js::LocalCallFunction(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args, bool doStackProbe) Line 1348 C++ ChakraCore.dll!Js::JavascriptFunction::CallFunction<1>(Js::RecyclableObject * function, void *(*)(Js::RecyclableObject *, Js::CallInfo) entryPoint, Js::Arguments args) Line 1364 C++ ChakraCore.dll!Js::JavascriptFunction::CallRootFunctionInternal(Js::Arguments args, Js::ScriptContext * scriptContext, bool inScript) Line 730 C++ ChakraCore.dll!Js::JavascriptFunction::CallRootFunction(Js::Arguments args, Js::ScriptContext * scriptContext, bool inScript) Line 693 C++ ChakraCore.dll!JsCallFunction::__l2::<lambda>(Js::ScriptContext * scriptContext, TTD::TTDJsRTActionResultAutoRecorder & _actionEntryPopper) Line 2255 C++ ChakraCore.dll!ContextAPIWrapper::__l2::<lambda>(Js::ScriptContext * scriptContext) Line 217 C++ ChakraCore.dll!ContextAPIWrapper_Core<1,_JsErrorCode <lambda>(Js::ScriptContext *) >(ContextAPIWrapper::__l2::_JsErrorCode <lambda>(Js::ScriptContext *) fn) Line 171 C++ ChakraCore.dll!ContextAPIWrapper<1,_JsErrorCode <lambda>(Js::ScriptContext *, TTD::TTDJsRTActionResultAutoRecorder &) >(JsCallFunction::__l2::_JsErrorCode <lambda>(Js::ScriptContext *, TTD::TTDJsRTActionResultAutoRecorder &) fn) Line 214 C++ ChakraCore.dll!JsCallFunction(void * function, void * * args, unsigned short cargs, void * * result) Line 2271 C++
jobProcessorCS assertion failure while collecting PerfView trace
https://api.github.com/repos/chakra-core/ChakraCore/issues/2955/comments
3
2017-05-10T19:39:38Z
2017-05-18T21:41:47Z
https://github.com/chakra-core/ChakraCore/issues/2955
227,788,175
2,955
[ "chakra-core", "ChakraCore" ]
I followed the wiki page (https://github.com/Microsoft/ChakraCore/wiki/Building-ChakraCore) to build a static library for macOS. But after my app launched, it crashed in like which in https://github.com/Microsoft/ChakraCore/pull/1173 . Therefore, I had to build it to shared library. But I got another crash in `JsCreateContext`. The full crash stack is: ![screen shot 2017-05-10 at 16 41 21](https://cloud.githubusercontent.com/assets/493372/25890290/8b866e58-359f-11e7-901d-b66caa7e4d7b.png) ![screen shot 2017-05-10 at 16 41 44](https://cloud.githubusercontent.com/assets/493372/25890301/949f098c-359f-11e7-8d2c-60e80aa3860a.png) My mac device is: macOS sierra 10.12.14, MacBook Pro (Retina, 15-inch, Early 2013) I uses the source in `release/1.4` branch and build it as shared library in DEBUG mode. Could you help me to resolve this issue? Thanks.
[macOS] Crash while invoking JsCreateContext
https://api.github.com/repos/chakra-core/ChakraCore/issues/2953/comments
6
2017-05-10T08:43:50Z
2017-05-19T03:16:09Z
https://github.com/chakra-core/ChakraCore/issues/2953
227,607,027
2,953
[ "chakra-core", "ChakraCore" ]
Run the following code: [promiseVoidModule.zip](https://github.com/Microsoft/ChakraCore/files/988285/promiseVoidModule.zip) Get this output: script start script after ASSERTION 8052: (Repos\ChakraCore\lib\Runtime\Language\JavascriptOperators.cpp, line 6939) size > ScopeSlots::FirstSlotIndex Failure: (size > ScopeSlots::FirstSlotIndex) FATAL ERROR: ch.exe failed due to exception code c0000420
assertion "size > ScopeSlots::FirstSlotIndex" failure - modules with Promise.resolve
https://api.github.com/repos/chakra-core/ChakraCore/issues/2949/comments
4
2017-05-09T23:31:30Z
2018-02-09T20:52:26Z
https://github.com/chakra-core/ChakraCore/issues/2949
227,527,146
2,949
[ "chakra-core", "ChakraCore" ]
I downloaded some sample code from Chakra Samples (Edge) from [Chakra Samples](https://github.com/Microsoft/Chakra-Samples/tree/master/Chakra%20Samples/JSRT%20Win32%20Hosting%20Samples/Edge%20JSRT%20Samples/C%23) I wrote up a simple function to test, but I am running into a strange issue. If, in my function, I use toFixed(2) in my computation, the function result is showing up as undefined. If I remove the toFixed(2), the function seems to run fine and the returned result is also OK, I can convert the returned value to double. What could I be doing wrong? ``` shiftValue = Math.pow(10,6); function convert( amount, // string value of the amount sourceToUSDRate, // ex USD to USD rate, 1.0000000 targetToUSDRate, // ex. CAD to USD rate ) { host.echo(amount, sourceToUSDRate, targetToUSDRate); unrounded = amount * (sourceToUSDRate/targetToUSDRate); host.echo("Converted unrounded", unrounded); rounded = ((Math.round(shiftValue * unrounded)+1) / shiftValue); host.echo("Converted rounded", rounded); return rounded.toFixed(2); } ``` and I am calling like this ``` public static double callFunction(string function, double[] arguments) { double reusultVal; try { // Get function id JavaScriptValue global; Native.JsGetGlobalObject(out global); JavaScriptPropertyId id; if (Native.JsGetPropertyIdFromName(function, out id) != JavaScriptErrorCode.NoError) return -1; // Is this the same as global.GetProperty(id)? JavaScriptValue jsFunc; Native.JsGetProperty(global, id, out jsFunc); // convert args JavaScriptValue[] jsArguments = new JavaScriptValue[arguments.Length + 1]; jsArguments[0] = global; int i = 1; foreach (double arg in arguments) { jsArguments[i] = JavaScriptValue.FromDouble(arg); i += 1; } // JavaScriptValue result; JavaScriptErrorCode err = Native.JsCallFunction( jsFunc, jsArguments, (ushort)jsArguments.Length, out result); if (err != JavaScriptErrorCode.NoError) return -1; reusultVal = result.ToDouble(); } catch (Exception e) { return -1; } return reusultVal; } ``` ` double x = JavaScriptContext.callFunction("convert", new double[] { 220, 1.000000000d, 0.7375991148811d });`
using toFixed(2) in function shows the function result as undefined
https://api.github.com/repos/chakra-core/ChakraCore/issues/2946/comments
1
2017-05-09T05:37:31Z
2017-05-09T06:20:40Z
https://github.com/chakra-core/ChakraCore/issues/2946
227,255,648
2,946
[ "chakra-core", "ChakraCore" ]
I'm seeing that some typedarray UTs are often timing out, especially on OSX (e.g. test/typedarray/Int8Array2.js). @Penguinwizzard and I looked at this and we are hitting infinite bailout/rejit issue. @pleath I believe this is related to your change to handle conversion of src operand on store to a typed array. In case we are storing a LikelyString into a typed array, we will bailout every time and keep rejitting the same code.
typedarray UT timeouts
https://api.github.com/repos/chakra-core/ChakraCore/issues/2945/comments
2
2017-05-09T02:55:37Z
2017-05-18T23:25:05Z
https://github.com/chakra-core/ChakraCore/issues/2945
227,234,047
2,945
[ "chakra-core", "ChakraCore" ]
As shown in #2937, this isn't currently tested in our CI, so I'm going to add a test case for it (and any infra support needed for that)
Add testing for no-arg invocation of ch
https://api.github.com/repos/chakra-core/ChakraCore/issues/2944/comments
3
2017-05-09T01:27:53Z
2018-05-17T03:17:56Z
https://github.com/chakra-core/ChakraCore/issues/2944
227,221,095
2,944
[ "chakra-core", "ChakraCore" ]
It is possible to avoid this, for a cleaner result.
add_msbuild_path.cmd adds quotes to the PATH environment variable
https://api.github.com/repos/chakra-core/ChakraCore/issues/2942/comments
1
2017-05-09T00:21:02Z
2017-05-10T21:57:26Z
https://github.com/chakra-core/ChakraCore/issues/2942
227,212,200
2,942
[ "chakra-core", "ChakraCore" ]
[This](https://github.com/Microsoft/ChakraCore/commit/b78d9eed0ca0731bd70f09979fdf7cf9d74439bd#diff-9aa417ac81c06da693354e50d1edd449R848) makes ch to free a pointer that is not allocated. Before this commit we create and initilize argInfo in same place, but in this commit we initilize argInfo at top of the function. Which introduce problems later. ``` [navid@workstation ChakraCore]$ git status HEAD detached at b78d9ee You are currently bisecting, started from branch 'master'. (use "git bisect reset" to get back to the original branch) nothing to commit, working tree clean [navid@workstation ChakraCore]$ ./out/Debug/ch Usage: ch [-v|-version] [-h|-help] [-?] [flaglist] <source file> -v|-version Displays version info -h|-help Displays this help message -? Displays this help message with complete [flaglist] info *** Error in `./out/Debug/ch': free(): invalid pointer: 0x0000555fe1efb609 *** ======= Backtrace: ========= /lib64/libc.so.6(+0x791fb)[0x7f83d857e1fb] /lib64/libc.so.6(+0x8288a)[0x7f83d858788a] /lib64/libc.so.6(cfree+0x4c)[0x7f83d858b2bc] ./out/Debug/ch(+0x1f155)[0x555fe1f13155] ./out/Debug/ch(+0x1f175)[0x555fe1f13175] ./out/Debug/ch(+0xba0c)[0x555fe1effa0c] ./out/Debug/ch(+0xa5f7)[0x555fe1efe5f7] /lib64/libc.so.6(__libc_start_main+0xf1)[0x7f83d8525401] ./out/Debug/ch(+0x767a)[0x555fe1efb67a] ======= Memory map: ======== 555fe1ef4000-555fe1fc8000 r-xp 00000000 00:27 6162383 /home/navid/development/ChakraCore/out/Debug/ch 555fe21c8000-555fe21c9000 r-xp 000d4000 00:27 6162383 /home/navid/development/ChakraCore/out/Debug/ch 555fe21c9000-555fe21ca000 rwxp 000d5000 00:27 6162383 /home/navid/development/ChakraCore/out/Debug/ch 555fe21ca000-555fe21cf000 rwxp 00000000 00:00 0 555fe21cf000-555fe21d0000 rwxp 00000000 00:00 0 555fe21d0000-555fe21d1000 rwxp 00000000 00:00 0 555fe2ca8000-555fe2cda000 rwxp 00000000 00:00 0 [heap] 7f83d0000000-7f83d0021000 rwxp 00000000 00:00 0 7f83d0021000-7f83d4000000 ---p 00000000 00:00 0 7f83d7d04000-7f83d7d05000 ---p 00000000 00:00 0 7f83d7d05000-7f83d8505000 rwxp 00000000 00:00 0 7f83d8505000-7f83d86c2000 r-xp 00000000 00:27 331092 /usr/lib64/libc-2.24.so 7f83d86c2000-7f83d88c1000 ---p 001bd000 00:27 331092 /usr/lib64/libc-2.24.so 7f83d88c1000-7f83d88c5000 r-xp 001bc000 00:27 331092 /usr/lib64/libc-2.24.so 7f83d88c5000-7f83d88c7000 rwxp 001c0000 00:27 331092 /usr/lib64/libc-2.24.so 7f83d88c7000-7f83d88cb000 rwxp 00000000 00:00 0 7f83d88cb000-7f83d88e1000 r-xp 00000000 00:27 250150 /usr/lib64/libgcc_s-6.3.1-20161221.so.1 7f83d88e1000-7f83d8ae0000 ---p 00016000 00:27 250150 /usr/lib64/libgcc_s-6.3.1-20161221.so.1 7f83d8ae0000-7f83d8ae1000 r-xp 00015000 00:27 250150 /usr/lib64/libgcc_s-6.3.1-20161221.so.1 7f83d8ae1000-7f83d8ae2000 rwxp 00016000 00:27 250150 /usr/lib64/libgcc_s-6.3.1-20161221.so.1 7f83d8ae2000-7f83d8bea000 r-xp 00000000 00:27 331098 /usr/lib64/libm-2.24.so 7f83d8bea000-7f83d8de9000 ---p 00108000 00:27 331098 /usr/lib64/libm-2.24.so 7f83d8de9000-7f83d8dea000 r-xp 00107000 00:27 331098 /usr/lib64/libm-2.24.so 7f83d8dea000-7f83d8deb000 rwxp 00108000 00:27 331098 /usr/lib64/libm-2.24.so 7f83d8deb000-7f83d8f63000 r-xp 00000000 00:27 250160 /usr/lib64/libstdc++.so.6.0.22 7f83d8f63000-7f83d9163000 ---p 00178000 00:27 250160 /usr/lib64/libstdc++.so.6.0.22 7f83d9163000-7f83d916d000 r-xp 00178000 00:27 250160 /usr/lib64/libstdc++.so.6.0.22 7f83d916d000-7f83d916f000 rwxp 00182000 00:27 250160 /usr/lib64/libstdc++.so.6.0.22 7f83d916f000-7f83d9173000 rwxp 00000000 00:00 0 7f83d9173000-7f83d9176000 r-xp 00000000 00:27 331096 /usr/lib64/libdl-2.24.so 7f83d9176000-7f83d9375000 ---p 00003000 00:27 331096 /usr/lib64/libdl-2.24.so 7f83d9375000-7f83d9376000 r-xp 00002000 00:27 331096 /usr/lib64/libdl-2.24.so 7f83d9376000-7f83d9377000 rwxp 00003000 00:27 331096 /usr/lib64/libdl-2.24.so 7f83d9377000-7f83d938f000 r-xp 00000000 00:27 331108 /usr/lib64/libpthread-2.24.so 7f83d938f000-7f83d958f000 ---p 00018000 00:27 331108 /usr/lib64/libpthread-2.24.so 7f83d958f000-7f83d9590000 r-xp 00018000 00:27 331108 /usr/lib64/libpthread-2.24.so 7f83d9590000-7f83d9591000 rwxp 00019000 00:27 331108 /usr/lib64/libpthread-2.24.so 7f83d9591000-7f83d9595000 rwxp 00000000 00:00 0 7f83d9595000-7f83d95ba000 r-xp 00000000 00:27 331085 /usr/lib64/ld-2.24.so 7f83d9751000-7f83d9796000 rwxp 00000000 00:00 0 7f83d97b7000-7f83d97ba000 rwxp 00000000 00:00 0 7f83d97ba000-7f83d97bb000 r-xp 00025000 00:27 331085 /usr/lib64/ld-2.24.so 7f83d97bb000-7f83d97bc000 rwxp 00026000 00:27 331085 /usr/lib64/ld-2.24.so 7f83d97bc000-7f83d97bd000 rwxp 00000000 00:00 0 7ffd07abb000-7ffd07adc000 rwxp 00000000 00:00 0 [stack] 7ffd07b30000-7ffd07b32000 r--p 00000000 00:00 0 [vvar] 7ffd07b32000-7ffd07b34000 r-xp 00000000 00:00 0 [vdso] ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] Aborted (core dumped) [navid@workstation ChakraCore]$ ``` In commit before that one, everything is okay : ``` [navid@workstation ChakraCore]$ ./out/Debug/ch Usage: ch [-v|-version] [-h|-help] [-?] [flaglist] <source file> -v|-version Displays version info -h|-help Displays this help message -? Displays this help message with complete [flaglist] info [navid@workstation ChakraCore]$ git status HEAD detached at 779d569 You are currently bisecting, started from branch 'master'. (use "git bisect reset" to get back to the original branch) nothing to commit, working tree clean [navid@workstation ChakraCore]$ ``` It seems clang and gcc do not zero out uninitialized variables. I added constructor to the ArgInfo and fixed the problem for myself. bin/ch/ChakraRtInterface.h ``` struct ArgInfo { int argc; LPWSTR* argv; HostPrintUsageFuncPtr hostPrintUsage; char* filename; ArgInfo() : argc{0}, argv{nullptr}, hostPrintUsage{nullptr}, filename{nullptr} {} ArgInfo(int argc, LPWSTR* argv, HostPrintUsageFuncPtr hostPrintUsage, char* filename) : argc{argc}, argv{argv}, hostPrintUsage{hostPrintUsage}, filename{filename} {} ~ArgInfo() { if (filename != nullptr) { free(filename); } } }; ``` It seems in this line : ``` ChakraRTInterface::ArgInfo argInfo; ``` After it does create argInfo, its filename is not null. So when at the end after it returns from main in ch.cpp deconstructor runs. It will free filename (which is not allocated at all) and it is not null. Because of that get s SIGFAULT at pal/src/cruntime/malloc.cpp ``` void CorUnix::InternalFree( void *pvMem ) { free(pvMem); } ``` I thought before sending any PR, I would report here. p.s. If anyone has anyway faster than "git bisect" I appreciate a lot if he/she can help me. git bisect was kind of like torture for finding this bug. This is clang version I use ``` [navid@workstation ~]$ clang --version clang version 3.9.1 (tags/RELEASE_391/final) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/bin ```
Double freeing pointer in Ch
https://api.github.com/repos/chakra-core/ChakraCore/issues/2932/comments
3
2017-05-08T18:13:50Z
2017-05-09T03:18:08Z
https://github.com/chakra-core/ChakraCore/issues/2932
227,128,837
2,932
[ "chakra-core", "ChakraCore" ]
Currently storing ES6 `moduleId` in `SRCINFO->moduleID`. For example, in `SourceTextModuleRecord::ParseSource()`: ```C++ this->parser = (Parser*)AllocatorNew(ArenaAllocator, allocator, Parser, scriptContext); srcInfo->moduleID = moduleId; ``` This may not be appropriate and needs investigation.
Usage of SRCINFO->moduleID for ES6 moduleId may not be appropriate
https://api.github.com/repos/chakra-core/ChakraCore/issues/2931/comments
0
2017-05-08T07:32:47Z
2017-09-29T17:56:34Z
https://github.com/chakra-core/ChakraCore/issues/2931
226,962,022
2,931
[ "chakra-core", "ChakraCore" ]
It seems not many Jenkins CI users are using 14.04 anymore so we're paying an extra cost (style check throughput as well as CI cost) to use that OS as we wait for VMs to be provisioned. There's no reason to have the style checks depend on 14.04. It was just the latest Ubuntu LTS available when we set up the checks. Switch the style checks to use 16.04 like the Linux CI checks we use for testing ChakraCore on Linux. This way we are using the same pool of VMs across all of our checks, and will share that pool with more other users of the CI (which means there will more likely already be a VM available and VMs are not as likely to be decommissioned/recommissioned due to changes in our load). Using OS name "Ubuntu" defaults to 14.04: https://github.com/dotnet/dotnet-ci/blob/master/jobs/generation/Utilities.groovy#L119 See our usage of Ubuntu OS's: * https://github.com/Microsoft/ChakraCore/blob/master/netci.groovy#L23 * https://github.com/Microsoft/ChakraCore/blob/master/netci.groovy#L218 (14.04 used for style checks) * https://github.com/Microsoft/ChakraCore/blob/master/netci.groovy#L299 (16.04 for Linux xplat checks) /cc @MSLaguana @boingoing @mmitche
Jenkins: Style Checks depend on Ubuntu14.04 for no good reason, update to 16.04
https://api.github.com/repos/chakra-core/ChakraCore/issues/2928/comments
0
2017-05-06T00:19:08Z
2017-05-10T20:15:03Z
https://github.com/chakra-core/ChakraCore/issues/2928
226,721,356
2,928
[ "chakra-core", "ChakraCore" ]
Windows Globalization does not work on xplat targets, so we will re-implement Intl using ICU to allow Intl to work on xplat. Additionally, a compilation option will make this implementation available as an option on Windows as well. (I've referred to this work item on other issues, but only now realized we didn't have an issue tracking it. So, here it is!) This meta-task and all subtasks are being tracked in the [Intl Project](https://github.com/Microsoft/ChakraCore/projects/2).
[Meta-Task] Implement Intl using ICU (enables Intl on xplat) and provide a compilation option
https://api.github.com/repos/chakra-core/ChakraCore/issues/2919/comments
1
2017-05-05T00:26:56Z
2018-02-15T17:31:11Z
https://github.com/chakra-core/ChakraCore/issues/2919
226,444,193
2,919
[ "chakra-core", "ChakraCore" ]
```js new Date("1986-06-13T15:31:28-04:00").toLocaleString("en", {hour: "numeric", hour12: false}); ``` Actual: 12:00 Expected: Truth about what time it is (12:31?) Other browsers give me 12 for this case.
Incorrect time reported by Date#toLocaleString
https://api.github.com/repos/chakra-core/ChakraCore/issues/2916/comments
9
2017-05-04T23:38:07Z
2017-09-06T08:39:38Z
https://github.com/chakra-core/ChakraCore/issues/2916
226,437,503
2,916
[ "chakra-core", "ChakraCore" ]
```js new Date("1986-06-13T15:31:28-04:00").toLocaleString("en", {minute: "numeric", hour12: false}); ``` Chakra: ‎6‎/‎13‎/‎1986‎ ‎12‎:‎31‎:‎28‎ ‎PM Chrome: 31 Expected: at least something that doesn't include the date which was not asked for.
Intl: Poor format template choice when specifying hour12 and minute with DateTimeFormatter
https://api.github.com/repos/chakra-core/ChakraCore/issues/2915/comments
7
2017-05-04T23:19:21Z
2017-11-08T00:46:47Z
https://github.com/chakra-core/ChakraCore/issues/2915
226,434,737
2,915
[ "chakra-core", "ChakraCore" ]
Based on my local test: ``` > es -is -h d8,node,ch-master,sm -e "({['f']() {}, g () {}}).f.toString()" ## Source print(({['f']() {}, g () {}}).f.toString()) #### d8, node () {} #### sm ['f']() {} #### ch-master f() {} ``` @bterlson added that JSC also disagreed: ``` #### jsc function () {} ``` @bterlson details his spec dive here: https://twitter.com/bterlson/status/859915022218035200 Paraphrasing the tweets: * Based on the old spec, everyone but v8 was equally correct: https://tc39.github.io/ecma262/#sec-function.prototype.tostring * SM wins based on the [upcoming spec text](https://tc39.github.io/Function-prototype-toString-revision/#sec-runtime-semantics-definemethod) -- the toString of a function should be its method definition. ([Proposals](https://github.com/tc39/proposals), [`Function.prototype.toString` revision](https://github.com/tc39/Function-prototype-toString-revision)) * v8 has recently fixed their behavior ([CL](https://chromium-review.googlesource.com/c/466226/)) and now conforms with SM. ChakraCore should conform with the latest spec text (and thereby match SM's output above).
Incorrect Function toString for methods declared with string in brackets
https://api.github.com/repos/chakra-core/ChakraCore/issues/2914/comments
1
2017-05-04T19:45:15Z
2018-07-17T22:02:49Z
https://github.com/chakra-core/ChakraCore/issues/2914
226,388,373
2,914
[ "chakra-core", "ChakraCore" ]
When running templatized jit without `-simdjs` we incorrectly calculate the stack size required. `int32 stackSize = asmInfo->GetTotalSizeinBytes();` returns `0` in `FunctionEntry::ApplyTemplate`. Since we don't ship templatized jit it's not urgent, but we should fix this.
AsmJs Templatized jit broken without -simdjs
https://api.github.com/repos/chakra-core/ChakraCore/issues/2905/comments
1
2017-05-03T22:02:54Z
2017-09-07T04:29:02Z
https://github.com/chakra-core/ChakraCore/issues/2905
226,127,866
2,905
[ "chakra-core", "ChakraCore" ]
Ref #2658 ``` ## Source print(x) ┌───────────┬──────────────────────────────────┐ │ d8 │ │ │ sm │ ReferenceError: x is not defined │ │ node │ │ ├───────────┼──────────────────────────────────┤ │ node-ch │ │ │ ch-2.0 │ ReferenceError: 'x' is undefined │ │ ch-master │ │ └───────────┴──────────────────────────────────┘ ```
Error message for not defined identifiers is confusing (uses the term undefined)
https://api.github.com/repos/chakra-core/ChakraCore/issues/2901/comments
0
2017-05-02T18:41:11Z
2017-05-10T01:03:04Z
https://github.com/chakra-core/ChakraCore/issues/2901
225,784,177
2,901
[ "chakra-core", "ChakraCore" ]
What I am hoping to do is add assorted JsRefs that I want to be keep around for a while into an array that I have done a JsAddRef on, with the theory that since the array will not be garbage collected, none of the JsRef's stored in it will get garbage collected, but then when I want to release them all, I just need to do a JsRelease on the array, and I don't have to set up a separate tracking system for those things. and do a JsAddRef/JsRelaseon on each of them individually. Since ContextRefs and JsPropertyIdRefs are not JsValueRefs however (although they typedef to the same type), I am not sure if it is possible to safely store them in an array.
[Question] Can JsContextRefs and JsPropertyIdRefs be safely stored in an JsArray??
https://api.github.com/repos/chakra-core/ChakraCore/issues/2900/comments
2
2017-05-02T14:56:32Z
2017-05-17T21:26:17Z
https://github.com/chakra-core/ChakraCore/issues/2900
225,721,753
2,900
[ "chakra-core", "ChakraCore" ]
See https://github.com/nodejs/node-chakracore/issues/223 [Last case](https://github.com/nodejs/node-chakracore/issues/223#issuecomment-298456449) was tested under `node-chakracore 8.0.0-nightly20170429a043cb86fe`
bugs with non-lazy operators
https://api.github.com/repos/chakra-core/ChakraCore/issues/2899/comments
15
2017-05-02T04:08:32Z
2018-04-17T04:17:13Z
https://github.com/chakra-core/ChakraCore/issues/2899
225,585,934
2,899
[ "chakra-core", "ChakraCore" ]
Hi, The code fails to compile with new clang (I think after 4.0) with error like: In file included from ../../pal/src/include/pal/thread.hpp:24: In file included from ../../pal/src/include/pal/corunix.hpp:25: In file included from ../../pal/src/include/pal/palinternal.h:323: ../../pal/inc/pal.h:6244:22: error: definition of builtin function '_rotl' unsigned int __cdecl _rotl(unsigned int value, int shift) ^ ../../pal/inc/pal.h:6267:28: error: definition of builtin function '_rotl64' unsigned long long __cdecl _rotl64(unsigned long long value, int shift) ^ ../../pal/inc/pal.h:6285:22: error: definition of builtin function '_rotr' unsigned int __cdecl _rotr(unsigned int value, int shift) ^ ../../pal/inc/pal.h:6303:28: error: definition of builtin function '_rotr64' unsigned long long __cdecl _rotr64(unsigned long long value, int shift) This is because Clang-4.0 supports some of the microsoft intrinsics. Probably fixes like this: https://github.com/dotnet/coreclr/pull/11226/files will be required
intrinsic redefinition with Clang-4.0
https://api.github.com/repos/chakra-core/ChakraCore/issues/2892/comments
2
2017-04-29T11:53:47Z
2017-05-08T19:44:38Z
https://github.com/chakra-core/ChakraCore/issues/2892
225,252,229
2,892
[ "chakra-core", "ChakraCore" ]
Hi, LLVM linker doesn't support "--no-keep-memory" option, so the build fails.
Can't compile with ld.lld
https://api.github.com/repos/chakra-core/ChakraCore/issues/2891/comments
0
2017-04-29T10:04:01Z
2017-06-01T10:32:40Z
https://github.com/chakra-core/ChakraCore/issues/2891
225,247,115
2,891
[ "chakra-core", "ChakraCore" ]
Completion value should be empty for ClassDeclaration statements. [Spec](https://tc39.github.io/ecma262/#sec-class-definitions-runtime-semantics-evaluation) Test: ```js eval(`1; class C {}`) ``` Expected: `1` Actual: `C`
Incorrect Completion Value for ClassDeclaration statement
https://api.github.com/repos/chakra-core/ChakraCore/issues/2890/comments
5
2017-04-29T08:34:00Z
2019-06-07T19:10:50Z
https://github.com/chakra-core/ChakraCore/issues/2890
225,243,174
2,890