Datasets:

---

DanielPFlorian

/

Transformers-Github-Issues

like 0

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6521?src=pr&el=h1) Report\n> Merging [#6521](https://codecov.io/gh/huggingface/transformers/pull/6521?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/fe61c05b85f98846779bb490a747875e7d54ec2a&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6521?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6521 +/- ##\n=======================================\n Coverage 80.59% 80.59% \n=======================================\n Files 156 156 \n Lines 28058 28058 \n=======================================\n Hits 22612 22612 \n Misses 5446 5446 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6521?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6521?src=pr&el=footer). Last update [2060181...4032ff5](https://codecov.io/gh/huggingface/transformers/pull/6521?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Not sure what you mean here. Can you please post the traceback and the code that resulted in the error ?", "This is what I got:\r\n```\r\nKeyError Traceback (most recent call last)\r\n\r\n<ipython-input-18-eb1fb8795ed4> in <module>()\r\n 2 from transformers import AutoTokenizer, AutoModelWithLMHead\r\n 3 \r\n----> 4 tokenizer = AutoTokenizer.from_pretrained(\"google/pegasus-multi_news\")\r\n 5 \r\n 6 cla = AutoModelWithLMHead.from_pretrained(\"google/pegasus-multi_news\")\r\n\r\n1 frames\r\n\r\n/usr/local/lib/python3.6/dist-packages/transformers/tokenization_auto.py in from_pretrained(cls, pretrained_model_name_or_path, *inputs, **kwargs)\r\n 204 config = kwargs.pop(\"config\", None)\r\n 205 if not isinstance(config, PretrainedConfig):\r\n--> 206 config = AutoConfig.from_pretrained(pretrained_model_name_or_path, **kwargs)\r\n 207 \r\n 208 if \"bert-base-japanese\" in str(pretrained_model_name_or_path):\r\n\r\n/usr/local/lib/python3.6/dist-packages/transformers/configuration_auto.py in from_pretrained(cls, pretrained_model_name_or_path, **kwargs)\r\n 204 \r\n 205 if \"model_type\" in config_dict:\r\n--> 206 config_class = CONFIG_MAPPING[config_dict[\"model_type\"]]\r\n 207 return config_class.from_dict(config_dict, **kwargs)\r\n 208 else:\r\n\r\nKeyError: 'pegasus'\r\n```", "Yep, I've got this too.\r\n\r\n", "@HenryDashwood , @Kejia I can load both of these models on master branch.\r\n\r\nWhat version of transformers are you using, try doing this with master as it's not available in 3.0.2 release.\r\n\r\n`pip install -U git+https://github.com/huggingface/transformers.git`", "Ah of course. Cheers!", "@patil-suraj I tried installing the master version using the shared URL but still it wasn't updated to master version.\r\nCan you share more details for installing Transformers Master version?", "Sorry, typo. should be `-U` and not `-u`\r\n\r\n`pip install -U git+https://github.com/huggingface/transformers.git`", "I can't load the `PegasusTokenizer` for the checkpoint `google/pegasus-pubmed`:\r\n```Python\r\ntokenizer = PegasusTokenizer.from_pretrained(\"google/pegasus-pubmed\")\r\n```\r\nError:\r\n```\r\nTraceback (most recent call last):\r\n File \"src/download_model.py\", line 17, in <module>\r\n tokenizer = PegasusTokenizer.from_pretrained(config['model_name'])\r\n File \"/home/rafael/miniconda3/envs/torch/lib/python3.8/site-packages/transformers/tokenization_utils_base.py\", line 1584, in from_pretrained\r\n raise EnvironmentError(\r\nOSError: Model name 'google/pegasus-pubmed' was not found in tokenizers model name list (google/pegasus-xsum). We assumed 'google/pegasus-pubmed' was a path, a model identifier, or url to a directory containing vocabulary files named ['spiece.model'] but couldn't find such vocabulary files at this path or url.\r\n```\r\n\r\nWhen using the `AutoTokenizer`:\r\n```\r\ntokenizer = AutoTokenizer.from_pretrained(\"google/pegasus-pubmed\")\r\nTraceback (most recent call last):\r\n File \"/home/rafael/miniconda3/envs/torch/lib/python3.8/site-packages/transformers/configuration_utils.py\", line 368, in get_config_dict\r\n resolved_config_file = cached_path(\r\n File \"/home/rafael/miniconda3/envs/torch/lib/python3.8/site-packages/transformers/file_utils.py\", line 957, in cached_path\r\n raise EnvironmentError(\"file {} not found\".format(url_or_filename))\r\nOSError: file google/pegasus-pubmed/config.json not found\r\n```\r\n\r\nping @sshleifer \r\n\r\nI just installed it from master, still not working for me.\r\n\r\nEnvironment Info:\r\n- `transformers` version: 3.4.0\r\n- Platform: Linux-5.4.0-51-generic-x86_64-with-glibc2.10\r\n- Python version: 3.8.5\r\n- PyTorch version (GPU?): 1.6.0 (True)\r\n- Tensorflow version (GPU?): not installed (NA)\r\n- Using GPU in script?: no\r\n- Using distributed or parallel set-up in script?: no", "Can't replicate on master. Please post `transformers-cli env` info when having download issues, and try solutions above in the thread before posting.", "Ok I solved my issue. \r\n**FYI:** The problem was that I saved the loaded model in the directory `google/pegesus-pubmed` once in an invalid way and from now on the `from_pretrained` method tried to load it from the local path first which did not work. Sorry for bothering you!" ]

[]

[]

[ "Hey @Groskilled - I added a couple of comments. Let's try to first make the torch tests pass. Let me know if you need more help after implementing the comments.", "Closing PR due to inactivity" ]

[]

[]

[ "Feels more like a false positive failure?" ]

[]

[]

[ "Hey @saareliad, \r\ncan you try:\r\n```python\r\nt5 = transformers.T5ForConditionalGeneration.from_pretrained('t5-11b', use_cdn = False)\r\n```\r\n\r\nAlso, see: https://github.com/huggingface/transformers/issues/5423\r\n\r\nBut the model cannot really be run before we take a closer look at: https://github.com/huggingface/transformers/pull/3578.", "@patrickvonplaten mind adding a big disclaimer to the model card for this particular checkpoint? About what you just said (CDN limitation + model parallelism)", "Thanks @patrickvonplaten ,\nOur work successfully adds (several types of) model parallellism and trains T5 and several other large transformers and is integrated with HF for quite a while.\n\nWill opensource it soon :)" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Thank you, @JetRunner and @polm.\r\n\r\nI've fixed the test-related issues and it should be OK now." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Hey @dvirginz,\r\n\r\nCan you post a code snippet here so that we can reproduce your results or at least see what might have been falsely configured?", "@patrickvonplaten Hi!\r\nI'm sorry to have troubled you, the problem was with how I initialized and loaded the weights for the model.\r\nIt is now working, Thanks!" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=h1) Report\n> Merging [#6512](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9cbc0350deaa7e146a8c8dbb6ad4dc9bd6afc4f&el=desc) will **decrease** coverage by `0.89%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6512 +/- ##\n==========================================\n- Coverage 80.37% 79.48% -0.90% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22552 22302 -250 \n- Misses 5506 5756 +250 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.59% <ø> (ø)` | |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `85.46% <ø> (-1.01%)` | :arrow_down: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <ø> (ø)` | |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `24.55% <0.00%> (-72.36%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.31% <0.00%> (-0.98%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.42% <0.00%> (+0.16%)` | :arrow_up: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.94% <0.00%> (+0.25%)` | :arrow_up: |\n| ... and [4 more](https://codecov.io/gh/huggingface/transformers/pull/6512/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=footer). Last update [24107c2...ca9b5e9](https://codecov.io/gh/huggingface/transformers/pull/6512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=h1) Report\n> Merging [#6511](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9cbc0350deaa7e146a8c8dbb6ad4dc9bd6afc4f&el=desc) will **decrease** coverage by `0.43%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6511 +/- ##\n==========================================\n- Coverage 80.37% 79.94% -0.44% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22552 22431 -121 \n- Misses 5506 5627 +121 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `95.91% <ø> (-0.69%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.21% <ø> (-0.26%)` | :arrow_down: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <ø> (ø)` | |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `22.58% <0.00%> (-72.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/tokenization\\_pegasus.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcGVnYXN1cy5weQ==) | `45.31% <0.00%> (-50.00%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `66.66% <0.00%> (-32.50%)` | :arrow_down: |\n| [src/transformers/tokenization\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcmVmb3JtZXIucHk=) | `51.66% <0.00%> (-30.00%)` | :arrow_down: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `95.55% <0.00%> (-2.23%)` | :arrow_down: |\n| ... and [10 more](https://codecov.io/gh/huggingface/transformers/pull/6511/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=footer). Last update [24107c2...78bd9e3](https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=h1) Report\n> Merging [#6510](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/84d33317aec4e07ff2bc60721c81c9d519cefd3a&el=desc) will **increase** coverage by `2.74%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6510 +/- ##\n==========================================\n+ Coverage 77.77% 80.52% +2.74% \n==========================================\n Files 156 156 \n Lines 28094 28094 \n==========================================\n+ Hits 21850 22622 +772 \n+ Misses 6244 5472 -772 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/tokenization\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `28.84% <0.00%> (-58.66%)` | :arrow_down: |\n| [src/transformers/modeling\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190NS5weQ==) | `83.71% <0.00%> (+0.18%)` | :arrow_up: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `87.35% <0.00%> (+0.19%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.40% <0.00%> (+0.40%)` | :arrow_up: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <0.00%> (+0.83%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+1.25%)` | :arrow_up: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.59% <0.00%> (+1.36%)` | :arrow_up: |\n| [src/transformers/modeling\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19kaXN0aWxiZXJ0LnB5) | `97.82% <0.00%> (+1.63%)` | :arrow_up: |\n| [src/transformers/modelcard.py](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGNhcmQucHk=) | `85.18% <0.00%> (+2.46%)` | :arrow_up: |\n| ... and [8 more](https://codecov.io/gh/huggingface/transformers/pull/6510/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=footer). Last update [84d3331...bd93fc8](https://codecov.io/gh/huggingface/transformers/pull/6510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Yes, it does. Please let me know if it's a problem for future PRs. It surely adds to the reviewer's efforts I can see :(\r\n\r\nThere must be a way to configure github ui to ignore whitespace difference in diff, right?\r\n\r\nOn user side this can be done via adding &w=1:\r\nhttps://github.com/huggingface/transformers/pull/6510/files?diff=split&w=1\r\nor via UI: https://stackoverflow.com/a/51755490/9201239\r\n\r\nIt doesn't look as if there is a project-wide setting to do that. I looked but I don't see this option.\r\n\r\nIt looks like it was discussed here https://github.com/sindresorhus/refined-github/issues/191, but hasn't been resolved to a completion, only providing a UI to remove whitespace manually for each PR.\r\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=h1) Report\n> Merging [#6509](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9cbc0350deaa7e146a8c8dbb6ad4dc9bd6afc4f&el=desc) will **decrease** coverage by `1.16%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6509 +/- ##\n==========================================\n- Coverage 80.37% 79.21% -1.17% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22552 22225 -327 \n- Misses 5506 5833 +327 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `95.91% <ø> (-0.69%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `83.95% <ø> (-2.51%)` | :arrow_down: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <ø> (ø)` | |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `22.58% <0.00%> (-72.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `66.66% <0.00%> (-32.50%)` | :arrow_down: |\n| [src/transformers/tokenization\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZ3B0Mi5weQ==) | `87.50% <0.00%> (-9.73%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| ... and [13 more](https://codecov.io/gh/huggingface/transformers/pull/6509/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=footer). Last update [24107c2...bd1f4c5](https://codecov.io/gh/huggingface/transformers/pull/6509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Good to go thanks. (side-note: we tend to default to two underscores for links as otherwise, sphinx will always associate the description to the same link).", "> side-note: we tend to default to two underscores for links as otherwise, sphinx will always associate the description to the same link\r\n\r\nI will know now - thank you: fixed here https://github.com/huggingface/transformers/pull/6541" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=h1) Report\n> Merging [#6508](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9cbc0350deaa7e146a8c8dbb6ad4dc9bd6afc4f&el=desc) will **increase** coverage by `0.16%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6508 +/- ##\n==========================================\n+ Coverage 80.37% 80.54% +0.16% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n+ Hits 22552 22599 +47 \n+ Misses 5506 5459 -47 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `95.91% <ø> (-0.69%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <ø> (ø)` | |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <ø> (ø)` | |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `53.15% <0.00%> (-4.51%)` | :arrow_down: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `95.55% <0.00%> (-2.23%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.94% <0.00%> (+0.25%)` | :arrow_up: |\n| ... and [2 more](https://codecov.io/gh/huggingface/transformers/pull/6508/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=footer). Last update [24107c2...76e7b5c](https://codecov.io/gh/huggingface/transformers/pull/6508?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "I don't see how you preprocessed your dataset. From the code you pasted, there is no point where you actually tokenize the elements of `french_squad_train` and `french_squad_dev` (assuming `load_dataset` comes from the nlp library?)", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=h1) Report\n> Merging [#6505](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/895ed8f4511ce9f2d1475e7f11c776dab87461d1&el=desc) will **decrease** coverage by `0.44%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6505 +/- ##\n==========================================\n- Coverage 80.38% 79.93% -0.45% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22554 22428 -126 \n- Misses 5504 5630 +126 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `22.58% <0.00%> (-72.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <0.00%> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.58% <0.00%> (-7.19%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `95.55% <0.00%> (-2.23%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `80.96% <0.00%> (-1.30%)` | :arrow_down: |\n| ... and [9 more](https://codecov.io/gh/huggingface/transformers/pull/6505/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=footer). Last update [24107c2...be6a262](https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=h1) Report\n> Merging [#6504](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/895ed8f4511ce9f2d1475e7f11c776dab87461d1&el=desc) will **decrease** coverage by `2.17%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6504 +/- ##\n==========================================\n- Coverage 80.38% 78.20% -2.18% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22554 21943 -611 \n- Misses 5504 6115 +611 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/optimization.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb24ucHk=) | `25.55% <0.00%> (-70.00%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `26.26% <0.00%> (-53.69%)` | :arrow_down: |\n| [src/transformers/optimization\\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb25fdGYucHk=) | `33.33% <0.00%> (-24.33%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9hdXRvLnB5) | `48.79% <0.00%> (-18.08%)` | :arrow_down: |\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `13.76% <0.00%> (-14.38%)` | :arrow_down: |\n| [src/transformers/modeling\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hdXRvLnB5) | `64.36% <0.00%> (-14.37%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `65.68% <0.00%> (-6.16%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `66.00% <0.00%> (-3.06%)` | :arrow_down: |\n| [src/transformers/modelcard.py](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGNhcmQucHk=) | `82.71% <0.00%> (-2.47%)` | :arrow_down: |\n| ... and [9 more](https://codecov.io/gh/huggingface/transformers/pull/6504/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=footer). Last update [24107c2...8dda746](https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "it works when I use \"this is a test.\" as the input text because it results in 7 tokens. \r\nnow the question is why the model expects a fixed number, which is 7, of tokens as input? ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "@Zhen-hao sees I meet the same problem. does your problem have been fixed? ", "> @Zhen-hao sees I meet the same problem. does your problem have been fixed?\r\n\r\nI didn't fix it. also didn't check with the last released version. \r\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "What was your training command?\r\n", "I used the `finetune_tiny_bart.sh` script in the seq2seq examples. @sshleifer \r\n\r\nIf that helps to figure out the source of the problem, as I know the position_embeddings of bart-large-cnn model is 1026 (with addition of SOS, and EOS tokens). Since my task is long summarization, I changed it to 2050, and let the model learn the whole on my custom dataset; Additionally, as I mentioned earlier, I have also increased the `min_length` and `max_length` in the BART config class. But the problem still remains.", "I've never really trained with such large length parameters, but we have been seeing similar problems for many models. I think these are the lines causing the issue, will try to get a fix soon.\r\nhttps://github.com/huggingface/transformers/blob/master/examples/seq2seq/finetune.py#L144", "I have been facing this issue in the new versions of finetune.sh as well... even for T5...\r\neg.\r\nIn only the first quarter century after the breakup of the Soviet Union, Azerbaijan has impressed the Caucasus region and the world with its progress. Although it still must work diligently to enhance citizen inputs into its governance structures, continue to expand its productive capacity beyond the energy sectors, and distribute its new wealth equitably among its entire population, the country has faced the complex challenges of independence with a mostly steady hand. Much has been achieved in rediscovery of a proud national identity, new resource abundance, sound transportation infrastructure, and a thriving capital city that is now a vibrant modern regional hub. Among the most important next steps for policy priority over the coming decades will be in sustaining the progress already made with continuing \"greener\" approaches to development, and increasing diversification of the economy beyond just the oil and natural gas sectors. Initiatives already in place have started along this road, but will need to be strengthened over", "I would love to replicate (need data) or have one of you test on the branch with my proposed fix:\r\n\r\nhttps://github.com/huggingface/transformers/pull/6654\r\n\r\n```bash\r\ngit fetch\r\ngit checkout batch-parity-cleaner\r\n```", "That branch is broken right now, I will comment when it's fixed.", "Should work now!", "Hey,\r\nWas trying out your branch, the earlier version atleast ran fine.\r\nAfter pulling the latest like you mentioned...getting back this:\r\n f\"Mbart is using sequence lengths {self.max_source_length}, {self.max_target_length}. \"\r\nValidation sanity check: 0it [00:00, ?it/s]Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\nKeyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n\r\nI assume this has to do with the translation code? Any suggestions how to get around this?", "Fixed on the branch, sorry about that!", "So...should I try now?", "Yah!", "Still the same :(", "OK. Which dataset are you using? I can't really debug without being able to see what a batch looks like when it goes into the model.", "I am using a custom dataset but you can try with BillSum as well and you should be able to reproduce the issue.\r\nAnd btw here I was talking about this particular issue:\r\n> Hey,\r\n> Was trying out your branch, the earlier version atleast ran fine.\r\n> After pulling the latest like you mentioned...getting back this:\r\n> f\"Mbart is using sequence lengths {self.max_source_length}, {self.max_target_length}. \"\r\n> Validation sanity check: 0it [00:00, ?it/s]Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> Keyword arguments {'src_lang': None, 'tgt_lang': None} not recognized.\r\n> \r\n> I assume this has to do with the translation code? Any suggestions how to get around this?\r\n\r\nI am not able to start training itself with your branch.\r\nLet me know if you need anymore info.", "Yes a training command I can paste into my terminal to run on billsum and reproduce your failure.", "I just tried this and got the same:\r\n`./finetune.sh \\\r\n --data_dir \"../../../BillSum\"\r\n --train_batch_size=2 \r\n --eval_batch_size=8 \r\n --output_dir=\"/content/models/t5_narrative_512/\" \r\n --num_train_epochs 2 \r\n --model_name_or_path=\"t5-base\" --n_val 1000 \r\n --val_check_interval 0.5 \r\n --max_source_length=512 --max_target_length=150 --val_max_target_length=150 --test_max_target_length=150 `", "@patil-suraj we think these should be fixed both for t5 and bart, right?", "Yes, AFAIK these issues are fixed now. @amanpreet692 could you try this with the latest master branch ?", "I used distilbart:\r\n\r\n`tokenizer_dbart = BartTokenizer.from_pretrained('sshleifer/distilbart-cnn-6-6')`\r\n`model_dbart = BartForConditionalGeneration.from_pretrained('sshleifer/distilbart-cnn-6-6')`\r\n\r\nThe last sentence of the summary obtained from the model is sometimes truncated.\r\n\r\nIs this expected? @sshleifer ", "@patil-suraj Sorry I got back to this only now, I checked out the latest from repo today and ran finetune.sh for finetuning and could still see this issue,\r\neg. \r\nResearch on inventory risk management based on abc analysis. The traditional ABC analysis is a kind of management method from the ABC curve. ABC curve is also called Pareto (Pareto) curve. The basic idea is, \" vital few and the majority of the general \". In all the inventory, the cumulative percentage of species ranged from 5% to 15% and the average amount of funds occupied the cumulative percentages of 60% ~ 80% items identified as A class; the cumulative proportion of funds is 20% ~ 30% of the goods, identified as B class; and the rest as class C. The different objects use different management methods and means. In the China's enterprises,\r\n\r\nThe command I used is the same as above, only I removed the fp16 parameter from the script.", "Hi @amanpreet692,\r\nCould you post the arguments you are passing to `generate` ? for ex. `num_beams, max_length, length_penalty` etc\r\n", "Hey, I haven't tinker with the arguments to generate so I guess they should be the same as in config for distilbart:\r\n\"early_stopping\": true,\r\n\"length_penalty\": 2.0,\r\n\"max_length\": 142,\r\n\"min_length\": 56,\r\n\"no_repeat_ngram_size\": 3,\r\n\"num_beams\": 4\r\nLet me know if you need anything else.\r\n\r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "well BERT can only generate up to 512 tokens and both models are Autoencoding models and usually not used for causal language generation (Autoregressive models are used for this). You can check out the difference here: https://huggingface.co/transformers/model_summary.html." ]

[]

[]

[]

[]

[]

[]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Sorry for the format of the two codes. I have modified them and posted them here:\r\n\r\n1. \r\n```python\r\nfrom transformers import TFBertModel, BertConfig\r\nimport tensorflow as tf\r\ndef single_bert():\r\n id = Input((128,), dtype=tf.int32)\r\n mask = Input((128,), dtype=tf.int32)\r\n atn = Input((128,), dtype=tf.int32)\r\n bert_config = BertConfig.from_pretrained('bert-base-uncased', output_hidden_states=True)\r\n bert_model = TFBertModel.from_pretrained('bert-base-uncased', config = bert_config)\r\n embedding = bert_model(id, attention_mask=mask, token_type_ids=atn)[2]\r\n model = tf.keras.Model(inputs=[id, mask, atn], outputs=embedding)\r\n return model\r\nmodel = single_bert()\r\nmodel.summary()\r\n```\r\n2. \r\n```python\r\nfrom transformers import TFBertModel, BertConfig\r\nimport tensorflow as tf\r\ndef single_bert():\r\n id = Input((128,), dtype=tf.int32)\r\n mask = Input((128,), dtype=tf.int32)\r\n atn = Input((128,), dtype=tf.int32)\r\n bert_model = TFBertModel.from_pretrained('bert-base-uncased')\r\n embedding = bert_model(id, attention_mask=mask, token_type_ids=atn, output_hidden_states=True)[2]\r\n model = tf.keras.Model(inputs=[id, mask, atn], outputs=embedding)\r\n return model\r\nmodel = single_bert()\r\nmodel.summary()\r\n```", "I have ran your code with minor edits:\r\n\r\nembedding = bert_model(id, attention_mask=mask, token_type_ids=atn, output_hidden_states=True)\r\n\r\nFor the variable embedding, it only output 2 element in a tuple\r\n(<tf.Tensor 'tf_bert_model/Identity:0' shape=(None, 128, 768) dtype=float32>,\r\n <tf.Tensor 'tf_bert_model/Identity_1:0' shape=(None, 768) dtype=float32>)\r\n\r\nSo I think you would want to extract the last embedding layer index -1 or just 1 instead of index 2 (non-existent). \r\nI have seen other people with index 2 (such as : [https://github.com/huggingface/transformers/issues/4048](url) ), but of course their tuple has length more than 2, you should investigate more in your code. I even tried to have your code structured like theirs \r\n\r\n` embedding = bert_model(input = [id, atn])`\r\n\r\nBut it gives out the same output, may be it's just because of the different pre-trained model itself that give out different tuple length, so try to investigate more \r\n\r\n", "Hello!\r\n\r\nThere are three possibilities to use `TFBertModel` either with a list, a dic or positional argumentst:\r\n1) With list: you have to explicitely give a list of size 10 corresponding to `[input_ids, attention_mask, token_type_ids, position_ids, head_mask, inputs_embeds, output_attentions, output_hidden_states, return_dict, training]`\r\n2) With a dict. This is the recommended way, as you can specify only the keys you need.\r\n3) With positional arguments (as proposed by @vuhluu)", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[ "Commenting for visibility - is this available now ? can't seem to find it, would love to use this for a question-answering project i'm working on! ", "I'd also like to see this model incorporated into the core list of supported models. I did note that you can download it from the community models here though: https://huggingface.co/SpanBERT/spanbert-base-cased", "Are there any translations of the above repository (https://github.com/mandarjoshi90/coref) into the awesome HuggingFace API ? That would be very cool to test :D !", "I would like to work on this...but will need some guidance" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=h1) Report\n> Merging [#6496](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9cbc0350deaa7e146a8c8dbb6ad4dc9bd6afc4f&el=desc) will **increase** coverage by `0.06%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6496 +/- ##\n==========================================\n+ Coverage 80.37% 80.44% +0.06% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n+ Hits 22552 22571 +19 \n+ Misses 5506 5487 -19 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.59% <ø> (ø)` | |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <ø> (+0.25%)` | :arrow_up: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <ø> (ø)` | |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.47% <0.00%> (-34.36%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.42% <0.00%> (+0.16%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6496/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `98.38% <0.00%> (+29.31%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=footer). Last update [24107c2...a9ce8ff](https://codecov.io/gh/huggingface/transformers/pull/6496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "The files are there: https://cdn.huggingface.co/german-nlp-group/electra-base-german-uncased/tokenizer_config.json\r\n\r\nBut it simply does not show up...", "Maybe related to #6478", "Having the same problem here. Uploaded a new model (`salti/xlm-roberta-large-arabic_qa`) earlier this morning and it doesn't show up in the model hub, although I can download it and use it using the `from_pretrained` method.", "@julien-c @Pierrci ", "Maybe some sync service just needs a restart? :-)", "Not a sync service, but a (uncaught) user error :)\r\n\r\nFixed: https://huggingface.co/german-nlp-group/electra-base-german-uncased#german-electra-uncased" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=h1) Report\n> Merging [#6494](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/895ed8f4511ce9f2d1475e7f11c776dab87461d1&el=desc) will **increase** coverage by `0.17%`.\n> The diff coverage is `31.81%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6494 +/- ##\n==========================================\n+ Coverage 80.38% 80.55% +0.17% \n==========================================\n Files 156 156 \n Lines 28058 28079 +21 \n==========================================\n+ Hits 22554 22619 +65 \n+ Misses 5504 5460 -44 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6494/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/testing\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6494/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90ZXN0aW5nX3V0aWxzLnB5) | `48.80% <33.33%> (-3.13%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6494/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6494/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.69% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6494/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.42% <0.00%> (+0.16%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6494/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `98.38% <0.00%> (+29.31%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=footer). Last update [24107c2...f695e5f](https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=h1) Report\n> Merging [#6493](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/895ed8f4511ce9f2d1475e7f11c776dab87461d1&el=desc) will **increase** coverage by `0.21%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6493 +/- ##\n==========================================\n+ Coverage 80.38% 80.59% +0.21% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n+ Hits 22554 22613 +59 \n+ Misses 5504 5445 -59 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6493/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6493/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6493/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.69% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6493/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.42% <0.00%> (+0.16%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6493/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6493/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `98.38% <0.00%> (+29.31%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=footer). Last update [24107c2...057a225](https://codecov.io/gh/huggingface/transformers/pull/6493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Thanks!" ]

[]

[]

[ "Also, the CI wants you to run `make style` :)", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=h1) Report\n> Merging [#6492](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9cbc0350deaa7e146a8c8dbb6ad4dc9bd6afc4f&el=desc) will **decrease** coverage by `1.18%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6492 +/- ##\n==========================================\n- Coverage 80.37% 79.19% -1.19% \n==========================================\n Files 156 156 \n Lines 28058 28059 +1 \n==========================================\n- Hits 22552 22221 -331 \n- Misses 5506 5838 +332 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `95.91% <ø> (-0.69%)` | :arrow_down: |\n| [src/transformers/data/processors/glue.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvZ2x1ZS5weQ==) | `48.91% <0.00%> (-0.18%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `83.20% <ø> (-3.26%)` | :arrow_down: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <ø> (ø)` | |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `22.58% <0.00%> (-72.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `66.66% <0.00%> (-32.50%)` | :arrow_down: |\n| [src/transformers/tokenization\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZ3B0Mi5weQ==) | `87.50% <0.00%> (-9.73%)` | :arrow_down: |\n| ... and [13 more](https://codecov.io/gh/huggingface/transformers/pull/6492/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=footer). Last update [24107c2...29e9a98](https://codecov.io/gh/huggingface/transformers/pull/6492?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Would be a great improvement :+1: \r\n\r\nHere's btw. the commit that introduced WWM in BERT:\r\n\r\nhttps://github.com/google-research/bert/commit/0fce551b55caabcfba52c61e18f34b541aef186a", "BERT using wordpiece tokenizer, however, roberta uses byte-piece tokenizer. I think the implementations may be slightly different, if not starkly different (due to different start token indicators).", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "@sgugger do you think it would be a good idea to add more fine-tuning info for MBart, since it requires input processed in a different way than other models as it is multilingual model ?", "@sshleifer ,@sgugger added DPR in readme. ", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=h1) Report\n> Merging [#6490](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/895ed8f4511ce9f2d1475e7f11c776dab87461d1&el=desc) will **decrease** coverage by `0.46%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6490 +/- ##\n==========================================\n- Coverage 80.38% 79.91% -0.47% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22554 22423 -131 \n- Misses 5504 5635 +131 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_mbart.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19tYmFydC5weQ==) | `100.00% <ø> (ø)` | |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `22.58% <0.00%> (-72.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <0.00%> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.58% <0.00%> (-7.19%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `95.55% <0.00%> (-2.23%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `84.96% <0.00%> (-1.51%)` | :arrow_down: |\n| ... and [9 more](https://codecov.io/gh/huggingface/transformers/pull/6490/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=footer). Last update [895ed8f...e1c522b](https://codecov.io/gh/huggingface/transformers/pull/6490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Great! Thanks for the PR." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=h1) Report\n> Merging [#6489](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/fe61c05b85f98846779bb490a747875e7d54ec2a&el=desc) will **decrease** coverage by `1.47%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6489 +/- ##\n==========================================\n- Coverage 80.59% 79.11% -1.48% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22612 22198 -414 \n- Misses 5446 5860 +414 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9lbGVjdHJhLnB5) | `25.13% <0.00%> (-73.83%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9vcGVuYWkucHk=) | `22.58% <0.00%> (-72.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `48.80% <0.00%> (-46.43%)` | :arrow_down: |\n| [src/transformers/tokenization\\_mbart.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWJhcnQucHk=) | `56.25% <0.00%> (-39.07%)` | :arrow_down: |\n| [src/transformers/tokenization\\_ctrl.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fY3RybC5weQ==) | `78.64% <0.00%> (-17.48%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `90.24% <0.00%> (-3.53%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `85.99% <0.00%> (-1.31%)` | :arrow_down: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `80.96% <0.00%> (-1.30%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.21% <0.00%> (-0.26%)` | :arrow_down: |\n| ... and [5 more](https://codecov.io/gh/huggingface/transformers/pull/6489/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=footer). Last update [fe61c05...26634da](https://codecov.io/gh/huggingface/transformers/pull/6489?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "@julien-c 🤔" ]

[]

[]

[]

[]

[]

[ "Hi @jungwhank \r\nfor Bert2Bert, `pad_token` is used as `decoder_start_token_id` and the `input_ids` and `labels` begin with `cls_token_id` (`[CLS]` for bert ) and end with `sep_token_id` (`[SEP]` for bert).\r\n\r\nFor training all you need to do is \r\n```python3\r\ninput_text = \"some input text\"\r\ntarget_text = \"some target text\"\r\ninput_ids = tokenizer(input_text, add_special_tokens=True, return_tensors=\"pt\")[\"input_ids\"]\r\ntarget_ids = tokenizer(target_text, add_special_tokens=True, return_tensors=\"pt\")[\"input_ids\"]\r\nmodel(input_ids=input_ids, decoder_input_ids=target_ids, labels=target_ids)\r\n```\r\nThe EncoderDecoderModel class takes care adding `pad_token` to the `decoder_input_ids`.\r\n\r\nfor inference \r\n```python3\r\nmodel.generate(input_ids, decoder_start_token_id=model.config.decoder.pad_token_id)\r\n```\r\n\r\nHope this clarifies your question. Also pinging @patrickvonplaten for more info.", "Hi, @patil-suraj \r\nThanks for answering.\r\nis it same for BartForConditionalGeneration?\r\nActually, I wanna do kind of translation task and is it same `decoder_inputs_ids` and `labels`?", "@patil-suraj's answer is correct! For the `EncoderDecoder` framework, one should set `model.config.decoder_start_token_id` to the BOS token (which in BERT's case does not exist so that we simply use CLS token).\r\n\r\nBart is a bit different:\r\n- if you want to generate from a pretrained model, all you have to do is: `model.generate(input_ids)`. `input_ids` always refer to the encoder input tokens for Seq2Seq models and it depends on you if you want to add special tokens or not - this is not done automatically in the generate function.\r\n- if you want to have more control and just do one forward pass, you should define both `input_ids` and `decoder_input_ids` and in this case the `decoder_input_ids` should start with Bart's `decoder_start_token_id` `model.config.decoder_start_token_id`:\r\n\r\n`model(input_ids, decoder_input_ids=decoder_input_ids)`", "@patrickvonplaten \r\nthanks for answering!\r\nBut I have a question that Is there `decoder_start_token_id` in BartConfig?\r\nShould I just make my `decoder_input_ids` start with Bart's `model.config.bos_token_id` or set `model.config.decoder_start_token_id` = token_id?", "I think I solved the problem. Thanks\r\n", "@jungwhank Great ! Consider joining the awesome[ HF forum ](https://discuss.huggingface.co/), if you haven't already :) It's the best place to ask such questions. The whole community is there to help you and your questions will also help the community." ]

[]

[]

[ "Hello! This is probably an error with your network. Are you behind a firewall? Does it work on any other machine on the same network?", "Many thanks for a quick response. It is possible. It works on another machine on another network. Is there any way to debug what it tries to download and why it fails? Any idea why the downloads work in pytorch_transformers but not in transformers?", "Hi @sadaszewski ,\r\n\r\nI think you can use the following script for just making a get request to the xlnet configuration file:\r\n\r\n```python\r\nimport requests\r\n\r\nr = requests.get(\"https://s3.amazonaws.com/models.huggingface.co/bert/xlnet-base-cased-config.json\")\r\n\r\nprint(r.text)\r\n```\r\n\r\nwould be interesting to see the response then :)", "Well but doesn't it seem like that's the only file it actually **manages** to get? As you can see in the printout it shows the config of the model... It fails loading weights I guess. How do I check those?", "Oh, I can remember a recent location/CDN change. So the json configuration is loaded from the s3 link, but the model weight is located at `https://cdn.huggingface.co/xlnet-large-cased-pytorch_model.bin` -> could you check if you have access to this file?", "And in `pytorch-transformers` the model was downloaded from:\r\n\r\n```bash\r\nhttps://s3.amazonaws.com/models.huggingface.co/bert/xlnet-base-cased-pytorch_model.bin\r\n```", "I can confirm that it was a problem specific to my setup with trusted certificate for cdn.huggingface.co. Now fixed by specifying REQUESTS_CA_BUNDLE. Nevertheless it was nowhere to be found in the exception thrown by transformers that ultimately it has been caused by requests TLS handshake error. It would be very helpful if you considered adding exception chaining - https://www.python.org/dev/peps/pep-3134/ . Thanks for all your speedy replies!" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=h1) Report\n> Merging [#6485](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9a8c168f56fe3c0e21d554a577ac03beb004ef89&el=desc) will **increase** coverage by `0.58%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6485 +/- ##\n==========================================\n+ Coverage 80.03% 80.61% +0.58% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n+ Hits 22456 22620 +164 \n+ Misses 5602 5438 -164 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `28.84% <0.00%> (-58.66%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.84% <0.00%> (-23.17%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.69% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.59% <0.00%> (+0.68%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.29% <0.00%> (+0.97%)` | :arrow_up: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `82.25% <0.00%> (+1.29%)` | :arrow_up: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `97.77% <0.00%> (+2.22%)` | :arrow_up: |\n| [src/transformers/tokenization\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcmVmb3JtZXIucHk=) | `95.00% <0.00%> (+13.33%)` | :arrow_up: |\n| [src/transformers/tokenization\\_mbart.py](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWJhcnQucHk=) | `95.31% <0.00%> (+39.06%)` | :arrow_up: |\n| ... and [2 more](https://codecov.io/gh/huggingface/transformers/pull/6485/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=footer). Last update [b5ba758...66f97dd](https://codecov.io/gh/huggingface/transformers/pull/6485?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This may be due to an embedding dimension issue, but may also be due to a CUDA OOM error earlier that has been misreported in my experience. To verify that it is an embedding dimension issue, can you try using the `--no_cuda` flag?", "Sure - let me give it a shot. The one issue is that the data is large so featurizing the inputs takes a long time (and isn't cached), so it may take several hours to report back.", "@LysandreJik I confirmed it was indeed an embedding issue:\r\n\r\n```log\r\nTraceback (most recent call last):\r\n File \"run_language_modeling.py\", line 281, in <module>\r\n main()\r\n File \"run_language_modeling.py\", line 245, in main\r\n trainer.train(model_path=model_path)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/transformers/trainer.py\", line 499, in train\r\n tr_loss += self._training_step(model, inputs, optimizer)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/transformers/trainer.py\", line 622, in _training_step\r\n outputs = model(**inputs)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 722, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/transformers/modeling_roberta.py\", line 239, in forward\r\n output_hidden_states=output_hidden_states,\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 722, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/transformers/modeling_bert.py\", line 753, in forward\r\n input_ids=input_ids, position_ids=position_ids, token_type_ids=token_type_ids, inputs_embeds=inputs_embeds\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 722, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/transformers/modeling_roberta.py\", line 68, in forward\r\n input_ids, token_type_ids=token_type_ids, position_ids=position_ids, inputs_embeds=inputs_embeds\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/transformers/modeling_bert.py\", line 179, in forward\r\n position_embeddings = self.position_embeddings(position_ids)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/torch/nn/modules/module.py\", line 722, in _call_impl\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/torch/nn/modules/sparse.py\", line 126, in forward\r\n self.norm_type, self.scale_grad_by_freq, self.sparse)\r\n File \"/home/erippeth/miniconda3/envs/myBERT/lib/python3.6/site-packages/torch/nn/functional.py\", line 1814, in embedding\r\n return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)\r\nIndexError: index out of range in self\r\n```\r\n\r\nWhat's not immediately clear is _why_ it's happening. My understanding is the process goes...\r\n\r\n1. Load the tokenizer.\r\n2. Encode each line (forcing the indices to necessarily fall in the range of |vocab|)\r\n3. Train", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ " Hi,\r\nI am running example given in README.md of language_modeling using following command:\r\nexport TRAIN_FILE=/path/to/dataset/wiki.train.raw\r\nexport TEST_FILE=/path/to/dataset/wiki.test.raw\r\n\r\npython run_language_modeling.py \\\r\n --output_dir=output \\\r\n --model_type=gpt2 \\\r\n --model_name_or_path=gpt2 \\\r\n --do_train \\\r\n --train_data_file=$TRAIN_FILE \\\r\n --do_eval \\\r\n --eval_data_file=$TEST_FILE\r\n\r\nIt has started training but it is not using GPU (TITAN X) at all, when I see throug nvidia-smi command \r\nI am new to this So Can you please let me know if I'm missing anything here.\r\n\r\nThanks.", "This is probably because torch doesn't detect that you have a GPU. Can you try launching a python console and running the following?\r\n\r\n```py\r\nimport torch\r\nprint(torch.cuda.is_available())\r\n```", "Yeah, I also found out about it later after posting this issue.\r\nI had to install cuda 9.1 and reboot the server then it worked.\r\nThank You for your reply :)" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "A question that might be of interest to @patrickvonplaten :)", "Hey @PrudhviRaj12, \r\nmy best answer would be to try it out :-) If can definitely work if you have enough GPU RAM. \r\nMy best guess would be that in the scenario described by you above the Longformer version would require ca. `num_chunks` * `required_gpu_ram_for_roberta` and `num_chunks` in your case would be 4096 / 256 = 16. So you would need a lot of RAM to run `batch_size=64` and `max_length=4096` with Longformer, most likely not enough for one GPU (even if fp16).", "I would also suggest adding gradient_checkpointing=True when you load your model with from_pretrained. This recent addition to the HF code base allowed me to go from using BERT with a max sequence length of 128-256 before running out of memory to now being able to use Longformer with a max seq length of up to 4096 on the same GPU setup!\r\n\r\nThis thread helped me and may also help you:\r\nhttps://github.com/allenai/longformer/issues/80", "Thanks @patrickvonplaten - I misunderstood the paper then. @HugToDebug thanks for your suggestion - I tried that but I am getting this warning \r\n\r\n```\r\nNone of the inputs have requires_grad=True. Gradients will be None\r\nwarnings.warn(\"None of the inputs have requires_grad=True. Gradients will be None\"\r\n```\r\n\r\nwhen calling model.forward(sequence inputs, attention masks) with any model (be it longformer or bert or roberta) and the performance of the model is completely off of the same batch experimental setting with and without gradient checkpointing. Probably I am doing something wrong, I'll check that thread. \r\n\r\nI am only training the last N layers of the bert/roberta for my task, and I am setting requires grad = False for all the other layers and I am getting that warning. When I remove that condition of setting requires grad = False for some layers and leaving them true for all, I am not getting that warning. Any idea how to get around that issue?", "Update: I was able to get rid of that warning by making one of the embedding weight matrices trainable (in my case - Roberta, token type embedding). It was only adding 768 more trainable parameters, but I am getting OOM. I had to cut down the batch size 4x to get it running on one gpu without OOM. Not sure why adding just 768 trainable params had that of an impact.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Hey @policeme, fair point they seem to be exactly the same. There is a logical difference though `TFBertOutput` is the output of a `TFBertLayer` while `TFBertSelfOutput` is the output a `TFBertAtteniton` (Self-attention -> thus \"SelfOutput\"). \r\nBut yeah this might seem a bit confusing at first." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=h1) Report\n> Merging [#6480](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9a8c168f56fe3c0e21d554a577ac03beb004ef89&el=desc) will **decrease** coverage by `0.06%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6480 +/- ##\n==========================================\n- Coverage 80.03% 79.96% -0.07% \n==========================================\n Files 156 156 \n Lines 28058 28058 \n==========================================\n- Hits 22456 22437 -19 \n- Misses 5602 5621 +19 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `69.06% <0.00%> (-29.32%)` | :arrow_down: |\n| [src/transformers/tokenization\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdDUucHk=) | `71.83% <0.00%> (-23.95%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.84% <0.00%> (-23.17%)` | :arrow_down: |\n| [src/transformers/modeling\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ194bG5ldC5weQ==) | `60.53% <0.00%> (-22.78%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.26% <0.00%> (-0.17%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.59% <0.00%> (+0.68%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.29% <0.00%> (+0.97%)` | :arrow_up: |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `82.25% <0.00%> (+1.29%)` | :arrow_up: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `97.77% <0.00%> (+2.22%)` | :arrow_up: |\n| ... and [4 more](https://codecov.io/gh/huggingface/transformers/pull/6480/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=footer). Last update [9a8c168...ab9eb7f](https://codecov.io/gh/huggingface/transformers/pull/6480?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "We should wait for @jplu to come back from holiday for this, since he wrote that part of the code.", "Good catch @maurice-g!!\r\n\r\nIt is my fault, I did that part in a hury and I should have been more careful. This will be fixed in a next PR (currently doing it)\r\n\r\n`n_replicas` is important here because we have to get the number of tuple (features, labels) corresponding to the batch size per GPU and `self.args.train_batch_size` gives the total batch size (batch size per GPU * number of replicas).", "Should be fixed in https://github.com/huggingface/transformers/pull/6713 :+1: ", "thanks for looking into this @jplu\r\n\r\nOne further remark on your PR #6713: The code now works _iff_ the features are a dict, but does not anymore if the features are a raw tensor (which worked before). IMO this should work for both, therefore there needs to be a conditional check on the type and then both situations should be handled. Or do you think that's not a relevant case?", "Keeping open until @jplu answers your question @maurice-g ", "You are right, it is not working anymore with list/tuple/raw tensors. This is on purpose because I'm gonna push the usage of dictionaries only in TF at some point. Is it a big issue for you to use dictionaries?", "Ok, works for me, just wanted to point it out." ]

[]

[]

[ "The model is also not listed on your [page ](https://huggingface.co/mrm8488). Can you try re-uploading ?", "If you load it in your code ```mrm8488/t5-base-finetuned-boolq``` it works! Maybe a problem indexing it.", "cc @julien-c ", "Hi everyone, has there been a way fix this? I also uploaded a model (t5-podcast-summarisation) that hasn't shown up on the model hub. I am able to load it in my code using `paulowoicho/t5-podcast-summarisation` though", "Fixed:\r\n- https://huggingface.co/mrm8488/t5-base-finetuned-boolq\r\n- https://huggingface.co/paulowoicho/t5-podcast-summarisation" ]

[]

[]

[]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Hi @JamesHujy , yes when training BART you need to shift `labels` and `decoder_input_ids`.\r\n\r\n```python3\r\ntarget_text = \"some target text\"\r\nenc = tokenizer(target_text , return_tensors=\"pt\")\r\ntarget_ids = enc[\"input_ids\"]\r\ndecoder_input_ids = target_ids[:, :-1].contiguous()\r\nlabels = target_ids[:, 1:].clone() \r\n```", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=h1) Report\n> Merging [#6475](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/05810cd80a5ca83065e0dbe5335c030c4a435ddb&el=desc) will **decrease** coverage by `1.12%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6475 +/- ##\n==========================================\n- Coverage 80.55% 79.42% -1.13% \n==========================================\n Files 153 153 \n Lines 28001 28001 \n==========================================\n- Hits 22556 22241 -315 \n- Misses 5445 5760 +315 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6475/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `24.55% <0.00%> (-72.36%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6475/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `84.21% <0.00%> (-2.26%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6475/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.31% <0.00%> (-0.98%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6475/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.94% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6475/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.01% <0.00%> (+23.16%)` | :arrow_up: |\n| [src/transformers/tokenization\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6475/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `87.50% <0.00%> (+58.65%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=footer). Last update [05810cd...646a7dc](https://codecov.io/gh/huggingface/transformers/pull/6475?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Agreed, thanks for the fix!" ]

[]

[ { "login": "stefan-it", "id": 20651387, "node_id": "MDQ6VXNlcjIwNjUxMzg3", "avatar_url": "https://avatars.githubusercontent.com/u/20651387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stefan-it", "html_url": "https://github.com/stefan-it", "followers_url": "https://api.github.com/users/stefan-it/followers", "following_url": "https://api.github.com/users/stefan-it/following{/other_user}", "gists_url": "https://api.github.com/users/stefan-it/gists{/gist_id}", "starred_url": "https://api.github.com/users/stefan-it/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stefan-it/subscriptions", "organizations_url": "https://api.github.com/users/stefan-it/orgs", "repos_url": "https://api.github.com/users/stefan-it/repos", "events_url": "https://api.github.com/users/stefan-it/events{/privacy}", "received_events_url": "https://api.github.com/users/stefan-it/received_events", "type": "User", "site_admin": false } ]

[ "Pinging @stefan-it ", "Hi @wangxinyu0922 ,\r\n\r\nthe models are only trained on the corresponding training data sets, that means development data was not used for training :)", "That's great! Thank you!", "> \r\n> \r\n> Hi @wangxinyu0922 ,\r\n> \r\n> the models are only trained on the corresponding training data sets, that means development data was not used for training :)\r\n\r\n@stefan-it \r\nBy the way, what is the accuracy of the model on the four datasets? The models are trained on document context or sentence context? I believe different context will affect the performance." ]

[]

[]

[]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "I think you will have to tweak the model here a bit to make it work. Before you pass arguments to the model's call function, can you add this line:\r\n```python\r\nmodel.output_hidden_states = False\r\n```\r\n\r\nand see whether the error persists", "Same issue here. Problem is not solved after setting\r\n'''\r\nmodel.output_hidden_states = False\r\n'''", "Solved by upgrading transformers" ]

[]

[]

[ "Our @JetRunner has already gone and proposed a fix using hashes: https://github.com/huggingface/transformers/pull/6475\r\n\r\nI think #6475 makes sense but your proposals also resonate with me, especially the 1.5. Using `tempfile.TemporaryDirectory` seems cleaner to me than manually removing the folder afterwards. The hardcoded paths are already set-up thanks to @JetRunner's hashes, but it does make it harder to debug as hashes are not understandable from a human point of view.\r\n\r\n@JetRunner, would love your input on @stas00's proposals!", "Thanks @stas00 and @LysandreJik!\r\nBoth idea 1 and 1.5 look good to me! Idea 2 is not flexible enough and I am worried about using the same temp dir for all test cases (if my understanding is right). Maybe idea 1 is good enough and idea 1.5 seems to be a little over complicated since people can just quickly change the directory name from `tmp_dir.name` to their local path for debugging and then do some cleaning themselves.\r\nYes, I agree `temporary_dir` looks much better than `rmtree`. `rmtree` looks super scary. \r\nAlso I wonder how can you trace the temp dir if the test is interrupted? Will it still be cleaned?", "Thank you for looking at my suggestions!\r\n\r\n> Our @JetRunner has already gone and proposed a fix using hashes: #6475\r\n\r\nNeat! A few notes:\r\n- it hasn't solved the problem of guaranteed cleanup. if the test asserts half way the clean up will not be run.\r\n- I like that it ends up with the same dir name for a given test all the time\r\n- it doesn't tell me what that `output_dir` is, have to take extra steps to figure it out - e.g. `ls -lt` \r\n- it's a bit too much copy-n-paste - the scaffolding is starting to dominate the test. It can be made into a function in testing_utils and there is no need to manually push `--output_dir` into `testargs`, could just use f\" .... {output_dir}\" into the existing list of `testargs`\r\n\r\n> it does make it harder to debug as hashes are not understandable from a human point of view.\r\n\r\nI concur. Though `tempfile`'s output is cryptic too: `/tmp/tmp0vpwv7ok`\r\n", "> Idea 2 is not flexible enough and I am worried about using the same temp dir for all test cases (if my understanding is right).\r\n\r\nRight. That approach is problematic if you have concurrent tests running with `pytest -n 2+`. Good observation! It could be easily fixed though by for example using the test name as a unique string or a hash of it.\r\n\r\nWhile idea 2 is super-smooth - no changes to the test! It's too far removed from where things happen from the perspective of the developer working on the test.\r\n\r\n> Maybe idea 1 is good enough and idea 1.5 seems to be a little over complicated since people can just quickly change the directory name from tmp_dir.name to their local path for debugging and then do some cleaning themselves.\r\n\r\nYou will have to comment out the `with ` line and re-indent the rest of the code (or replace with `if 1:`) if you want to switch to local path, since `tempfile` doesn't support such override - it's not debug-needs-friendly.\r\n\r\n> Yes, I agree temporary_dir looks much better than rmtree. rmtree looks super scary.\r\n\r\nI'm glad we both find it scary\r\n\r\n> Also I wonder how can you trace the temp dir if the test is interrupted? Will it still be cleaned?\r\n\r\nI'm not sure what you mean by 'trace'.\r\n\r\nIt does the right thing wrt guaranteed cleanup. Testing In ipython:\r\n```\r\nimport tempfile\r\ntry:\r\n with tempfile.TemporaryDirectory() as tmp_dir:\r\n print(f\"{tmp_dir} will be removed at the end of the test\")\r\n !ls -l $tmp_dir\r\n assert False\r\nexcept: \r\n pass \r\nfinally:\r\n !ls -l $tmp_dir\r\n```\r\n```\r\n/tmp/tmp0vpwv7ok will be removed at the end of the test\r\ntotal 0\r\nls: cannot access '/tmp/tmp0vpwv7ok': No such file or directory\r\n```\r\n\r\nit looks like it stringified `tmp_dir` and didn't need `tmp_dir.name`.\r\n\r\nWhat I don't like the most about idea 1, is that it'll constantly change the path, so you have to print it out all the time - and it's not an easy feat to find out that print out with the huge dump of std streams and then you have to copy-n-paste the unique string - very inefficient debug-wise. I'd say quite terrible. but as we said replacing it with:\r\n\r\n```\r\n- with tempfile.TemporaryDirectory() as tmp_dir:\r\n+ if 1:\r\n tmp_dir=\"./local/path\"\r\n```\r\nwill do the trick. hence the idea 1.5, which will do this for you. plus let you control whether to delete or not.\r\n\r\n-----\r\n\r\nOne more cons of pre-creating a temp dir, regardless of how it is done is that it'll lead to not testing script's capacity to correctly create a non-existing dir for its outputs.\r\n", "> > Yes, I agree temporary_dir looks much better than rmtree. rmtree looks super scary.\r\n> \r\n> I'm glad we both find it scary\r\n\r\nIf we end up using it in a context manager I wonder whether it'd be a smart idea to protect the developer from wiping out parts of their system, by refusing to delete that dir unless it was created by the context manager - i.e. it'll assert if the dir already exists. And, of course, provide a flag `i_know_what_I_am_doing_dammit=True` which will bypass the baby-gate.\r\n\r\nI don't know. This isn't great either - it will interfere with testing - I just don't like `rm -r` happening anywhere where I don't explicitly see it, including what it's deleting.\r\n", "I am okay with all these solutions and they have their own pros and cons! \n\nFor Idea 1.5, I still think if the user (i.e., developer in this case) wants to use their own directory, we should not handle the cleaning part. On one hand, cleaning may have a risk of deleting parts of the user's file system by mistake; on the other hand, I don't think it's a good idea to make this function too complicated.\n\nIdea 2 LGTM too as long as you solve the contradiction in directory and rmtree is considered acceptable.", "If we aren't cleaning up automatically the hardcoded path, then it defeats the purpose of 1.5 completely, i.e. best then to use 1.0 - i.e. use generic ` tempfile.TemporaryDirectory`.\r\n\r\nSo we start using:\r\n```\r\nfrom tempfile import TemporaryDirectory\r\n[...]\r\n with TemporaryDirectory() as tmp_dir:\r\n print(f\"{tmp_dir} will be removed at the end of the test\")\r\n```\r\nand the developer working on the test and wanting a fixed path, will have to re-write this with:\r\n```\r\nfrom tempfile import TemporaryDirectory\r\n[...]\r\n\r\n # with TemporaryDirectory() as tmp_dir:\r\n if 1:\r\n tmp_dir=\"./local/path\"\r\n print(f\"{tmp_dir} will be removed at the end of the test\")\r\n import shutil\r\n shutil.rmtree(tmp_dir, ignore_errors=True)\r\n```\r\nThat's a lot to type :(\r\n", "But with 1.5 we don't have to bother to reindent, right?", "You mean, as in:\r\n```\r\n with temp_dir_ctx() as tmp_dir:\r\n do_something_with(tmp_dir.name)\r\n```\r\nvs:\r\n```\r\n with temp_dir_ctx(path=\"/use/my/path\") as tmp_dir:\r\n do_something_with(tmp_dir.name)\r\n```\r\nno need to reindent indeed, but it'll be very confusing as it will behave differently if `path` is passed (no clean up)", "Moreover, if we do tell the dev to use `shutil.rmtree(tmp_dir, ignore_errors=True)` we are back at square one - it won't be run if assert will happen before it, so the next test run will be \"contaminated\".\r\n\r\nI was thinking that in this particular situation, we actually need to wipe the dir out **before** the test is run. i.e. this is the real need. It's much easier to ensure it happens, because we can do it first things first, so no assert to expect.\r\n\r\nThe after test clean up is a different need.", "Fair enough! I don't really have a preference here so let's go with what you think makes the most sense!", "It's clear that I want to have the cake and eat it too. I want a super-safe solution, yet, with minimal coding inside the test. I think that perhaps I have to choose one or the other. I just feel uncomfortable to take responsibility for creating a gun that someone might shoot their foot with (could be mine). If I were a robot my positronic brain would have melted right now.", "Haha don't worry. All these solutions are better than what we have right now (#6475)", "OK, I thought of something.\r\n\r\nWe use 1.5 as originally proposed in the first comment, but in addition we require that the hardcoded path is a subdir of the cwd dir . Assert if it is not. Then in the worst case scenario something unwanted will get wiped under the cloned git dir, but the system is safe.", "I agree. And we can listen to the community when the PR is done.", "# Idea 2.5\r\n```\r\nclass ExamplesTests(TestsWithTempDir):\r\n[...]\r\n def test_whatever(self):\r\n tmp_dir = self.remove_at_teardown(\"./tmp/dir\")\r\n # code whatever, and nothing else to write, no extra indent/scope needed\r\n```\r\n\r\nThis will require subclassing `unittest.TestCase`, to facilitate registry of one or more dirs to clean up via a new method `remove_at_teardown`, and the clean up of those dirs will get run automatically via its `def tearDown(self)`method which will do all the work (needs to be written).\r\n\r\nThis is even simpler and solves most of the deficiencies of the previous ideas.\r\n\r\n- we still require a sub-dir for safety, will be validated at registry time.\r\n- this idea drops the use of temp dir as it's not user-friendly debug wise. So we go back to hardcoded paths.\r\n- it's flexible, you can add several tmp dirs to remove.\r\n- if you want to keep the dir, just comment out the registry call\r\n\r\nif we want to ensure the dir is clean from the get-go, we can use another method that will attempt to delete at addition time and during teardown. `self.remove_now_and_at_teardown` or a flag `remove_at_teardown(now=True)`.\r\n\r\nThoughts?", "Cool. However, it is not practical to prevent others from copying and pasting the code fragment and the same path will be a problem for parallel testing (as we discussed). In this case, I believe you can use a hash (like #6475). However, temporary dir is still a cool idea that I don't want to give up. Good to hear from @sshleifer @sgugger ", "I agree. I will code something that will support both, so by default we will use a unique tmp dir but for debug it'll allow for a hardcoded path. I will send a PR soonish.\r\n\r\nThank you for the wonderful practical feedback, @JetRunner ", "Done: https://github.com/huggingface/transformers/pull/6494", "Thanks for taking care of it! Closing this as resolved." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=h1) Report\n> Merging [#6470](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/05810cd80a5ca83065e0dbe5335c030c4a435ddb&el=desc) will **decrease** coverage by `0.17%`.\n> The diff coverage is `96.73%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6470 +/- ##\n==========================================\n- Coverage 80.55% 80.37% -0.18% \n==========================================\n Files 153 156 +3 \n Lines 28001 28058 +57 \n==========================================\n- Hits 22556 22552 -4 \n- Misses 5445 5506 +61 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2JhcnQucHk=) | `93.87% <ø> (-0.36%)` | :arrow_down: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.59% <ø> (ø)` | |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <ø> (ø)` | |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `100.00% <ø> (+4.05%)` | :arrow_up: |\n| [src/transformers/modeling\\_encoder\\_decoder.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbmNvZGVyX2RlY29kZXIucHk=) | `91.66% <87.50%> (+0.64%)` | :arrow_up: |\n| [src/transformers/tokenization\\_mbart.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWJhcnQucHk=) | `95.31% <95.31%> (ø)` | |\n| [src/transformers/modeling\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19ncHQyLnB5) | `86.68% <97.87%> (+0.71%)` | :arrow_up: |\n| [src/transformers/\\_\\_init\\_\\_.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9fX2luaXRfXy5weQ==) | `99.28% <100.00%> (+0.01%)` | :arrow_up: |\n| [src/transformers/configuration\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2F1dG8ucHk=) | `93.47% <100.00%> (+0.14%)` | :arrow_up: |\n| [src/transformers/configuration\\_mbart.py](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX21iYXJ0LnB5) | `100.00% <100.00%> (ø)` | |\n| ... and [11 more](https://codecov.io/gh/huggingface/transformers/pull/6470/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=footer). Last update [05810cd...d9cbc03](https://codecov.io/gh/huggingface/transformers/pull/6470?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=h1) Report\n> Merging [#6469](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/6e0b1dc8954b87c18f77a82000e81e02683b8eb1&el=desc) will **increase** coverage by `0.76%`.\n> The diff coverage is `87.43%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6469 +/- ##\n==========================================\n+ Coverage 79.77% 80.53% +0.76% \n==========================================\n Files 148 153 +5 \n Lines 27214 28001 +787 \n==========================================\n+ Hits 21710 22552 +842 \n+ Misses 5504 5449 -55 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3JlZm9ybWVyLnB5) | `100.00% <ø> (ø)` | |\n| [src/transformers/data/test\\_generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Rlc3RfZ2VuZXJhdGlvbl91dGlscy5weQ==) | `0.00% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19tYXJpYW4ucHk=) | `90.00% <ø> (-0.91%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `87.35% <ø> (ø)` | |\n| [src/transformers/trainer\\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3RmLnB5) | `12.25% <0.00%> (-0.13%)` | :arrow_down: |\n| [src/transformers/testing\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90ZXN0aW5nX3V0aWxzLnB5) | `51.92% <28.57%> (-20.81%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <37.50%> (-0.18%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `98.38% <50.00%> (+1.79%)` | :arrow_up: |\n| [src/transformers/data/data\\_collator.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL2RhdGFfY29sbGF0b3IucHk=) | `90.90% <52.94%> (-5.68%)` | :arrow_down: |\n| [src/transformers/modeling\\_encoder\\_decoder.py](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbmNvZGVyX2RlY29kZXIucHk=) | `91.02% <66.66%> (-1.19%)` | :arrow_down: |\n| ... and [61 more](https://codecov.io/gh/huggingface/transformers/pull/6469/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=footer). Last update [7bc0056...1e75c22](https://codecov.io/gh/huggingface/transformers/pull/6469?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Thanks!" ]

[]

[]

[ "my model is \r\n```python\r\nclass TFBertForMultiClassification(TFBertPreTrainedModel):\r\n '''BERT Model class for multi-label classification using a softmax output layer '''\r\n\r\n def __init__(self, config, *inputs, **kwargs):\r\n super(TFBertForMultiClassification, self).__init__(config, *inputs, **kwargs)\r\n self.num_labels = config.num_labels\r\n self.bert = TFBertMainLayer(config, name='bert')\r\n self.bert.trainable = False\r\n self.dropout = tf.keras.layers.Dropout(config.hidden_dropout_prob)\r\n self.classifier = tf.keras.layers.Dense(config.num_labels,\r\n kernel_initializer=get_initializer(config.initializer_range),\r\n name='classifier',\r\n activation='sigmoid')\r\n self.config = config\r\n \r\n def get_config(self):\r\n return self.config\r\n\r\n def call(self, inputs, **kwargs):\r\n outputs = self.bert(inputs, **kwargs)\r\n pooled_output = outputs[1]\r\n pooled_output = self.dropout(pooled_output, training=kwargs.get('training', False))\r\n logits = self.classifier(pooled_output)\r\n logits = tf.keras.backend.expand_dims(logits, axis=-1)\r\n outputs = (logits,) + outputs[2:] # add hidden states and attention if they are here\r\n return outputs # logits, (hidden_states), (attentions)\r\n```", "created a smaller example to reproduce the problem.\r\nhttps://github.com/huggingface/transformers/issues/6503" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "same problem", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=h1) Report\n> Merging [#6466](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/6e0b1dc8954b87c18f77a82000e81e02683b8eb1&el=desc) will **decrease** coverage by `1.34%`.\n> The diff coverage is `83.53%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6466 +/- ##\n==========================================\n- Coverage 79.77% 78.42% -1.35% \n==========================================\n Files 148 153 +5 \n Lines 27214 28001 +787 \n==========================================\n+ Hits 21710 21960 +250 \n- Misses 5504 6041 +537 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3JlZm9ybWVyLnB5) | `100.00% <ø> (ø)` | |\n| [src/transformers/data/test\\_generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Rlc3RfZ2VuZXJhdGlvbl91dGlscy5weQ==) | `0.00% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19tYXJpYW4ucHk=) | `90.00% <ø> (-0.91%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `87.15% <ø> (-0.20%)` | :arrow_down: |\n| [src/transformers/trainer\\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3RmLnB5) | `12.25% <0.00%> (-0.13%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `25.63% <4.00%> (-54.16%)` | :arrow_down: |\n| [src/transformers/optimization.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb24ucHk=) | `25.55% <7.14%> (-70.00%)` | :arrow_down: |\n| [src/transformers/testing\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90ZXN0aW5nX3V0aWxzLnB5) | `51.92% <28.57%> (-20.81%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `37.84% <37.50%> (-0.18%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `98.38% <50.00%> (+1.79%)` | :arrow_up: |\n| ... and [72 more](https://codecov.io/gh/huggingface/transformers/pull/6466/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=footer). Last update [7bc0056...31ea640](https://codecov.io/gh/huggingface/transformers/pull/6466?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Don't mind the failing test, it's been fixed on `master`." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Error(s) in loading state_dict for RobertaLongForMaskedLM:\r\nsize mismatch for embeddings.position_ids: copying a param with shape torch.Size([1, 512]) from checkpoint, the shape in current model is torch.Size([1, 4096]).", "Hey @Maybewuss,\r\n\r\nThis is a community notebook, so we don't really plan on maintaining this notebook with current library changes. \r\nRegarding your question I would suggest to post it on https://discuss.huggingface.co/ and/or to contact the author @ibeltagy - maybe he can help you.\r\n\r\nBefore that it would be nice if you can create a notebook which can be used to re-create your error (replacing RoBERTA with BERT in the above notebook)", "@patrickvonplaten Is there a way of converting existing 'short' models to Longformer? The notebook above (from allennlp) seem not to be useful since you can't automatically convert their 'long' model to Longformer Huggingface's class. The only way I see is to manually remap nodes.", "Yeah, it is not straight-forward to convert *any* HF model to its \"long\" version. You will need to write some special code for this yourself I think. The notebook should work more as an example for how it can be done with a model like Roberta", "I faced the same error with roberta. Size mismatch was in the position embedding and position ids. Adding the following lines to `create_long_model` helped:\r\n```{python}\r\nmodel.roberta.embeddings.position_embeddings.weight.data = new_pos_embed # add after this line\r\nmodel.roberta.embeddings.position_embeddings.num_embeddings = len(new_pos_embed.data)\r\n# first, check that model.roberta.embeddings.position_embeddings.weight.data.shape is correct — has to be 4096 (default) of your desired length\r\nmodel.roberta.embeddings.position_ids = torch.arange(\r\n 0, model.roberta.embeddings.position_embeddings.num_embeddings\r\n)[None]\r\n```\r\n\r\nFor some reason number of embeddings didn't change after adding new weight tensor, so we fix it and also add new position ids.\r\nI use torch==1.6.0 and transformers==3.4.0", "@NadiaRom Been trying this implementation, but the forward pass in `RobertaLongSelfAttention` gets too many inputs in the forward pass. \r\n\r\n```python\r\nclass RobertaLongSelfAttention(LongformerSelfAttention):\r\n def forward(\r\n self,\r\n hidden_states,\r\n attention_mask=None,\r\n head_mask=None,\r\n encoder_hidden_states=None,\r\n encoder_attention_mask=None,\r\n output_attentions=False,\r\n ):\r\n return super().forward(hidden_states, attention_mask=attention_mask, output_attentions=output_attentions)\r\n\r\n```\r\n\r\nAnd doesnt work with the current implementation in the transformer library [of the forward pass](https://github.com/huggingface/transformers/blob/c89bdfbe720bc8f41c7dc6db5473a2cb0955f224/src/transformers/models/longformer/modeling_longformer.py#L415)\r\n\r\nAny thought on how to solve this and use the conversion script in the current transformers release (3.5.1)?", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "This issue has been automatically marked as stale and been closed because it has not had recent activity. Thank you for your contributions.\n\nIf you think this still needs to be addressed please comment on this thread.", "@MarkusSagen, were you able to solve the `forward()` issue? ", "@versae I only looked at it for a couple of hours and decided it was easier to roll back to an earlier version of transformers. If anyone implements a fix, I would be very interested to hear 😊👌", "@MarkusSagen, [this PR makes it work for 4.2.0](https://github.com/allenai/longformer/pull/166/), and with a couple of changes it also works for 4.9.0." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=h1) Report\n> Merging [#6464](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/54c687e97c92efe6eba9e537bd98b47d9005a279&el=desc) will **decrease** coverage by `2.57%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6464 +/- ##\n==========================================\n- Coverage 79.91% 77.33% -2.58% \n==========================================\n Files 153 153 \n Lines 28005 28005 \n==========================================\n- Hits 22379 21657 -722 \n- Misses 5626 6348 +722 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `97.72% <100.00%> (ø)` | |\n| [src/transformers/optimization.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb24ucHk=) | `25.55% <0.00%> (-70.00%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `34.11% <0.00%> (-63.30%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `26.26% <0.00%> (-53.69%)` | :arrow_down: |\n| [src/transformers/optimization\\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb25fdGYucHk=) | `33.33% <0.00%> (-24.33%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9hdXRvLnB5) | `48.79% <0.00%> (-18.08%)` | :arrow_down: |\n| [src/transformers/modeling\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19hdXRvLnB5) | `64.16% <0.00%> (-14.46%)` | :arrow_down: |\n| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `13.76% <0.00%> (-14.38%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `65.68% <0.00%> (-6.16%)` | :arrow_down: |\n| [src/transformers/modelcard.py](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGNhcmQucHk=) | `82.71% <0.00%> (-2.47%)` | :arrow_down: |\n| ... and [12 more](https://codecov.io/gh/huggingface/transformers/pull/6464/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=footer). Last update [a442f87...c1b241e](https://codecov.io/gh/huggingface/transformers/pull/6464?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=h1) Report\n> Merging [#6463](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/54c687e97c92efe6eba9e537bd98b47d9005a279&el=desc) will **increase** coverage by `0.18%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6463 +/- ##\n==========================================\n+ Coverage 79.91% 80.09% +0.18% \n==========================================\n Files 153 153 \n Lines 28005 28005 \n==========================================\n+ Hits 22379 22431 +52 \n+ Misses 5626 5574 -52 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6463/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `97.72% <100.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6463/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.20%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6463/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.42% <0.00%> (+0.16%)` | :arrow_up: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6463/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.44% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6463/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `96.58% <0.00%> (+27.51%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=footer). Last update [54c687e...7f1278b](https://codecov.io/gh/huggingface/transformers/pull/6463?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Thanks!" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=h1) Report\n> Merging [#6461](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9d94aecd516c7540a94b9d781ef28d7375a796bc&el=desc) will **decrease** coverage by `0.47%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6461 +/- ##\n==========================================\n- Coverage 80.09% 79.62% -0.48% \n==========================================\n Files 153 153 \n Lines 28005 28005 \n==========================================\n- Hits 22430 22298 -132 \n- Misses 5575 5707 +132 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6461/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.40% <100.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6461/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9lbGVjdHJhLnB5) | `25.13% <0.00%> (-70.95%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6461/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.97% <0.00%> (-0.33%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6461/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.44% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6461/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `94.72% <0.00%> (+22.87%)` | :arrow_up: |\n| [src/transformers/tokenization\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6461/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `87.50% <0.00%> (+58.65%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=footer). Last update [9d94aec...dfb7549](https://codecov.io/gh/huggingface/transformers/pull/6461?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I've actually switched in the last version of transformers from a `set` to a `list` for the same reason (not deterministic for `nlp`). Are you sure this really solve the problem @lhoestq ?\r\nAlso regarding backward compatibility, I'm fine with changing this from a list to a set @sgugger ", "Maybe we should rather have a sorted list?", "`sorted` should solves the issue.\r\n\r\nI just tested and a `set` doesn't solve it actually. I'll change to `sorted`, thanks @thomwolf ", "This is such an important use-case (and potential source of regression) for us that we may want to add a test on that in `nlp` or `transformers` in a not too far future.", "Yes definitely. Not sure how to test consistency across sessions in the CI though.\r\nI guess we could have tests with hardcoded hashes for some tokenizers but I'm not sure that's ideal.\r\n\r\nOr maybe there's a way to do two CI jobs in a row: one to generate the hashes in a first session, and one to verify that they're the same in another session." ]

[]

[ { "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "site_admin": false }, { "login": "sgugger", "id": 35901082, "node_id": "MDQ6VXNlcjM1OTAxMDgy", "avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sgugger", "html_url": "https://github.com/sgugger", "followers_url": "https://api.github.com/users/sgugger/followers", "following_url": "https://api.github.com/users/sgugger/following{/other_user}", "gists_url": "https://api.github.com/users/sgugger/gists{/gist_id}", "starred_url": "https://api.github.com/users/sgugger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sgugger/subscriptions", "organizations_url": "https://api.github.com/users/sgugger/orgs", "repos_url": "https://api.github.com/users/sgugger/repos", "events_url": "https://api.github.com/users/sgugger/events{/privacy}", "received_events_url": "https://api.github.com/users/sgugger/received_events", "type": "User", "site_admin": false } ]

[]

[]

[]

[ "Hi @pratikdk thank you for reporting this! Just made a PR, will be fixed soon. Till then you can use `LongformerTokenizerFast` class" ]

[]

[]

[ "Hello! this task is only available on the `master` branch as of now. You can install it as such: `pip install git+https://github.com/huggingface/transformers`.\r\n\r\nIt will be in the next release!", "This is still happening on Databricks even though I re-installed the package several times today. Any thoughts?", "@Tolga28A Can you document which exact command(s) you run on Databricks (and how)?", "pip install git+https://github.com/huggingface/transformers\r\nfrom transformers import pipeline\r\nclassifier = pipeline('zero-shot-classification')\r\n\r\nand the output is:\r\n\r\n\r\nKeyError: \"Unknown task zero-shot-classification, available tasks are ['feature-extraction', 'sentiment-analysis', 'ner', 'question-answering', 'fill-mask', 'summarization', 'translation_en_to_fr', 'translation_en_to_de', 'translation_en_to_ro', 'text-generation']\"\r\n---------------------------------------------------------------------------\r\nKeyError Traceback (most recent call last)\r\n<command-2362828626522668> in <module>\r\n----> 1 classifier = pipeline('zero-shot-classification')\r\n\r\n/local_disk0/.ephemeral_nfs/envs/pythonEnv-a6d3a5c1-2f0b-495b-828f-f792f8695d17/lib/python3.7/site-packages/transformers/pipelines.py in pipeline(task, model, config, tokenizer, framework, **kwargs)\r\n 1819 # Retrieve the task\r\n 1820 if task not in SUPPORTED_TASKS:\r\n-> 1821 raise KeyError(\"Unknown task {}, available tasks are {}\".format(task, list(SUPPORTED_TASKS.keys())))\r\n 1822 \r\n 1823 framework = framework or get_framework(model)\r\n\r\nKeyError: \"Unknown task zero-shot-classification, available tasks are ['feature-extraction', 'sentiment-analysis', 'ner', 'question-answering', 'fill-mask', 'summarization', 'translation_en_to_fr', 'translation_en_to_de', 'translation_en_to_ro', 'text-generation']\"", "Start from a brand new venv or uninstall transformers before re-installing?" ]

[]

[]

[ "Hi @vblagoje , thanks for adding this :+1: \r\n\r\nGermEval dataset is currently not available - it seems that they've relaunched the shared task website. This dataset removal will also affect libraries such as Flair or `nlp` so I will try to find another mirror, thanks for reporting it!\r\n\r\nFor PoS tagging it would be awesome if you could also report/output accuracy after training - just import `accuracy_score` from the `seqeval` package :)", "Thanks for the review @stefan-it Let me know if there are any additional suggestions. Perhaps we can add appropriate URLs for the GermEval dataset and remove the chunking example if needed. ", "This looks great, thanks! Note that there is a big rework of the examples to use the nlp library and Trainer in the pipeline. We're polishing the APIs before we start converting every script. I'll tag you when we get to this one to make sure we don't break anything.\r\n\r\nIn the meantime, could you take care of the styling issue so we can merge?", "Ok @sgugger please do ping me and I'll make sure that all token classification examples work as expected, perhpas I can help with the transition. I am not sure why CI fails for styling, more specifically isort `ERROR: examples/token-classification/tasks.py Imports are incorrectly sorted.` It passes both on my working laptop and training machine. Could you please tell me how imports are incorrectly sorted in [tasks.py](https://github.com/vblagoje/transformers/blob/token_classification_examples/examples/token-classification/tasks.py) ?", "It may be because of the dep you're adding to examples. It should probably be added in the `known_third_party` list [here](https://github.com/huggingface/transformers/blob/master/setup.cfg).", "Ok @sgugger `check_code_quality` passes now, but there are other new failures. On a first look, they seem transient/unrelated to this PR? ", "Looks flaky, re-triggered the CI" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null }, { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]