Datasets:

---

DanielPFlorian

/

Transformers-Github-Issues

like 0

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=h1) Report\n> Merging [#6321](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c72f9c90a160e74108d50568fa71e1f216949846&el=desc) will **decrease** coverage by `0.25%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6321 +/- ##\n==========================================\n- Coverage 79.52% 79.27% -0.26% \n==========================================\n Files 148 148 \n Lines 27194 27194 \n==========================================\n- Hits 21627 21559 -68 \n- Misses 5567 5635 +68 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <0.00%> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.43% <0.00%> (-7.42%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.07% <0.00%> (-0.45%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.00% <0.00%> (-0.41%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.18% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6321/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=footer). Last update [c72f9c9...6505a38](https://codecov.io/gh/huggingface/transformers/pull/6321?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Hey @elsanns - thanks a lot for your notebook! It looks great :-) \r\n\r\nAlso cc @LysandreJik, you might be interested in this!", "Thank you;)" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "encountered the same issue", "I think @patrickvonplaten might have some ideas." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This is related: https://github.com/huggingface/transformers/pull/6877", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Here is another gem - PR to remove a single comment from a test file https://github.com/huggingface/transformers/pull/6338 - guess what codecov's report was - it will increase coverage by 0.32%! Sounds like its output would make a pretty good RNG.", "Pinging @thomasrockhu\r\n\r\nWe've seen such reports for a while now, could you explain why these diffs in coverage happen, or provide a link that explains why? Thank you!", "I took at look at #6338 because that is extremely strange.\r\n\r\n-- Codecov --\r\nFirst, I took a look at the commits to make sure we were comparing against the right commits SHAs here: https://codecov.io/gh/huggingface/transformers/pull/6338/commits\r\n\r\n\r\n\r\nwhich matches roughly to the commit stack on `master` (merging commits changes the SHA, I'm fairly sure, but the commit messages are consistent) https://github.com/huggingface/transformers/commits/master?after=3f071c4b6e36c4f2d4aee35d76fd2196f82b7936+34&branch=master\r\n\r\n\r\n\r\nSo, I thought that maybe we read the coverage reports wrong. I focused on this file `src/transformers/modeling_tf_electra.py`, because it had the most changes. Going into the build tab of the [base commit](https://codecov.io/gh/huggingface/transformers/commit/1f8e8265188de8b76f5c28539056d6eb772e4e0f/build) and the [head commit](https://codecov.io/gh/huggingface/transformers/commit/8721f03d83b58c52db266be1f10bc0de2dea5a10/build), I noticed that the coverage reports uploaded to `Codecov` show different coverages\r\n\r\n**Base commit**\r\n\r\n\r\n**Head commit**\r\n\r\n\r\nTo further confirm, I went into the CircleCI builds and compared the coverage generated by running `python -m pytest -n 8 --dist=loadfile -s ./tests/ --cov | tee output.txt`\r\n\r\n**Base commit**\r\nhttps://app.circleci.com/pipelines/github/huggingface/transformers/10177/workflows/c12a8e4b-4ec1-4c7c-be7a-e54b0d6b9835/jobs/70077\r\n\r\n\r\n**Head commit**\r\nhttps://app.circleci.com/pipelines/github/huggingface/transformers/10180/workflows/90610a5f-d9b1-4468-8c80-fcbd874dbe22/jobs/70104\r\n\r\n\r\nI don't know the codebase well enough here, but my suspicion is that your test suite is not idempotent", "As for notifications, could I get some more details here? One thing to note is `target` and `threshold` are not the same. `Target` is the coverage percentage to hit (like 80% of the total project), while `threshold` is the \"wiggle\" room (if set to 1%, it allows a 1% drop from the `target` to be considered acceptable)", "> As for notifications, could I get some more details here?\r\n\r\nMy thinking was that the project could set a threshold so that when it's crossed codecov makes itself heard, say -1% decrease would raise a flag. That way codecov becomes a useful ally and not something that most start ignoring because it's always there. but that's just IMHO.\r\n\r\n", "> To further confirm, I went into the CircleCI builds and compared the coverage generated by running python -m pytest -n 8 --dist=loadfile -s ./tests/ --cov | tee output.txt\r\n\r\nThank you for pointing out how we could use coverage data to explain this discrepancy, @thomasrockhu \r\n\r\n> I don't know the codebase well enough here, but my suspicion is that your test suite is not idempotent\r\n\r\nIs there a tool, that can narrow down which tests cause the idempotent behavior? Other then doing a binary search, which often fails in such complex situation of many tests.\r\n\r\nThank you!\r\n", "If you are talking about a `notification` not in `GitHub` ([comments](https://docs.codecov.io/docs/pull-request-comments) and [status checks](https://docs.codecov.io/docs/commit-status)), you could do something like this in the [codecov.yml](https://github.com/huggingface/transformers/blob/master/codecov.yml) file\r\n```\r\ncoverage:\r\n notify:\r\n {{ notification_provider (e.g. slack) }}:\r\n default:\r\n threshold: 1%\r\n```\r\n\r\nThis should only notify in cases of a 1% drop. (https://docs.codecov.io/docs/notifications#threshold)", "> Is there a tool, that can narrow down which tests cause the idempotent behavior? Other then doing a binary search, which often fails in such complex situation of many tests.\r\n\r\nUnfortunately, if there is one, we are not aware of it. I wish we could be a little more helpful here right now.", "> > Is there a tool, that can narrow down which tests cause the idempotent behavior? Other then doing a binary search, which often fails in such complex situation of many tests.\r\n> \r\n> Unfortunately, if there is one, we are not aware of it. I wish we could be a little more helpful here right now.\r\n\r\nSo, the brute force approach would be to run groups of tests on the same code base, comparing the coverage before and after, narrowing it down to the smallest group of tests that cause the coverage to vary - Am I correct? \r\n\r\nProbably to make an intelligent guess instead of the brute force, I'd look at the covebot reports for PRs that had no changes in code and yet wild swings were reported in some files. And from those files, consistently reported at the top, deduct the suspect tests.\r\n\r\nedit: I looked a bit and most likely this issue has to do with TF tests, as most of the time the large coverage changes get reported in `src/transformers/modeling_tf_*py`, when the changes have nothing to do with TF.\r\n", "@thomasrockhu, I run and re-run a bunch of tests, comparing the coverage reports and I can't reproduce the suggested possible lack of idempotency in the test suite. \r\n\r\nHowever, if I look at for example https://codecov.io/gh/huggingface/transformers/pull/6505 it says it doesn't have a base to compare to, yet it produces a (invalid) codecov report https://github.com/huggingface/transformers/pull/6505#issuecomment-674440545. So to me it tells that something else is broken. i.e. it's not comparing that PR to the base, but comparing it to some totally unrelated nearest code branch that codecov happened to have the coverage file for. Does it make sense?", "Hi @stas00, basically what that's saying is that in this [PR](https://github.com/huggingface/transformers/pull/6505), GitHub told us the parent was `24107c2` (https://codecov.io/gh/huggingface/transformers/pull/6505/commits). Unfortunately, we did not receive coverage reports or the CI might have failed. So we took the next parent from the `master` branch\r\n\r\n\r\n\r\nThis is an unfortunate consequence of not having coverage for a base commit.", "Thank you for confirming that, @thomasrockhu. \r\n\r\n> Unfortunately, we did not receive coverage reports or the CI might have failed. So we took the next parent from the master branch\r\n\r\nGiven that the report is misleading then, would it be possible to let the user configure codecov to not provide any report in such situation or a note that a report couldn't be generated? And perhaps make that the default?\r\n\r\nOr, perhaps, there should be a special internal action triggered that will go back to the base hash, run a CI on it, generate the coverage report, and now codecov can compare the 2 reports it was awesomely designed for. If that is possible at all.\r\n\r\nIt oddly seems to happen a lot, here is just a sample of a few recent PRs.\r\n\r\n- https://codecov.io/gh/huggingface/transformers/pull/6494?src=pr&el=desc\r\n- https://codecov.io/gh/huggingface/transformers/pull/6505?src=pr&el=desc\r\n- https://codecov.io/gh/huggingface/transformers/pull/6504?src=pr&el=desc\r\n- https://codecov.io/gh/huggingface/transformers/pull/6511?src=pr&el=desc\r\n\r\nI did find a few recent ones that were fine, i.e. there was a base coverage report.", "> Given that the report is misleading then, would it be possible to let the user configure codecov to not provide any report in such situation or a note that a report couldn't be generated? And perhaps make that the default?\r\n\r\n@stas00, unfortunately this is not possible in the Codecov UI. It is possible on the comments sent by Codecov in PRs via [require_base](https://docs.codecov.io/docs/pull-request-comments#configuration).\r\n\r\n> Or, perhaps, there should be a special internal action triggered that will go back to the base hash, run a CI on it, generate the coverage report, and now codecov can compare the 2 reports it was awesomely designed for. If that is possible at all.\r\n\r\nWe depend on users to make this determination. We often find that users will use [blocking status checks](https://docs.codecov.io/docs/commit-status#target) to enforce a failed commit which would imply that Codecov receives a coverage report.\r\n\r\n> It oddly seems to happen a lot, here is just a sample of a few recent PRs.\r\n\r\nLooking at these PRs, they all depend on the same commit `24107c2c83e79d195826f18f66892feab6b000e9` as their base, so it makes sense that it would be breaking for those PRs.", "Thank you very much, @thomasrockhu! Going to try to fix this issue by adding `require_base=yes` as you suggested: https://github.com/huggingface/transformers/pull/6553\r\n\r\nThank you for your awesome support!\r\n", "For sure, let me know if there's anything else I can do to help!", "@thomasrockhu, could you please have another look at the situation of this project? \r\n\r\nAfter applying https://github.com/huggingface/transformers/pull/6553 it should now not generate invalid reports when the base is missing - this is good.\r\n\r\nHowever, the problem of code coverage diff when there should be none is still there. e.g. here are some recent examples of pure non-code changes:\r\n\r\n- https://codecov.io/gh/huggingface/transformers/pull/6650/changes \r\n- https://codecov.io/gh/huggingface/transformers/pull/6650/changes\r\n- https://codecov.io/gh/huggingface/transformers/pull/6629/changes\r\n- https://codecov.io/gh/huggingface/transformers/pull/6649/changes\r\n\r\nI did multiple experiments and tried hard to get the test suite to behave in a non-idempotent way, but I couldn't get any such results other than very minor 1-line differences in coverage. This was done on the same machine. I'm not sure how to approach this issue - perhaps CI ends up running different PRs on different types of hardware/different libraries - which perhaps could lead to significant discrepancies in coverage.\r\n\r\nIf changes in hardware and system software libraries could cause such an impact, is there some way of doing a fingerprinting of the host setup so that we know the report came from the same type of setup?\r\n\r\nThank you!\r\n", "Apologies here @stas00 this got lost. Do you have a more recent pull request to take a look at so I can dig into the logs?", "Yes, of course, @thomasrockhu.\r\n\r\nHere is a fresh one: https://codecov.io/gh/huggingface/transformers/pull/6852 (no code change)\r\n\r\nLet me know if it'd help to have a few.", "@stas00 this is really strange. I was focusing in on `src/transformers/trainer.py`\r\n\r\nMost recently on `master`, [this commit](https://codecov.io/gh/huggingface/transformers/src/367235ee52537ff7cada5e1c5c41cdd78731f092/src/transformers/trainer.py) is showing much lower coverage than normal (13.55% vs ~50%)\r\n\r\nI'm comparing it to the commit [right after](https://codecov.io/gh/huggingface/transformers/commit/a497dee6f52f3b8f308675a50601added7e738c3)\r\n\r\nThe [CI build](https://app.circleci.com/pipelines/github/huggingface/transformers/11349/workflows/9ba002b6-c63e-4078-96d0-0feb988b304f/jobs/79674/steps) for the first, shows that there are fewer tests run by 1\r\n\r\n\r\nCompared to the `a497de` [run](https://app.circleci.com/pipelines/github/huggingface/transformers/11356/workflows/1ba4518f-e8d0-4970-9ef6-b8bba290f9bb/jobs/79726).\r\n\r\n\r\nMaybe there's something here?", "Thank you, @thomasrockhu!\r\nThis is definitely a great find. I'm requesting to add `-rA` to `pytest` runs https://github.com/huggingface/transformers/pull/6861\r\nthen we can easily diff which tests aren't being run. I will follow up once this is merged and we have new data to work with.", "OK, the `-rA` report is active now, so we can see and diff the exact tests that were run and skipped.\r\n\r\nHave a look at these recent ones with no code changes:\r\n\r\n- https://github.com/huggingface/transformers/pull/6861\r\n- https://github.com/huggingface/transformers/pull/6867\r\n\r\nI double checked that same number of tests were run in both, but codecov report is reporting huge coverage differences.\r\n\r\nThis is odd:\r\n- https://codecov.io/gh/huggingface/transformers/pull/6861/changes\r\n- https://codecov.io/gh/huggingface/transformers/pull/6867/changes\r\n\r\nIt seems to be reporting a huge number of changes, which mostly cancel each other.\r\n\r\n", "@thomasrockhu? Please, let me know when you can have a look at it - otherwise your logs will be gone again and the provided examples per your request will be unusable again. Thanks.", "Hi @stas00, apologies I took a look a few days ago, but I really couldn't find a good reason or another step to figure out what is going on in your testing setup. I'll take a look again today.", "@thomasrockhu, thank you for all your attempts so far. As you originally correctly guessed `transformers` tests suite is not idempotent. I finally was able to reproduce that first in a large sub-set of randomly run tests and then reduced it to a very small sub-set. So from here on it's totally up to us to either sort it out or let `codecov` go.\r\n\r\n# reproducing the problem\r\n\r\nnote: this is not the only guilty sub-test, there are others (I have more sub-groups that I haven't reduced to a very small sub-set yet), but it's good to enough to demonstrate the problem and see if we can find a solution.\r\n\r\n## Step 1. prep\r\n\r\n```\r\npip install pytest-flakefinder pytest-randomly\r\n```\r\nnote: make sure you `pip uninstall pytest-randomly` when you're done here, since it'll randomize your tests w/o asking you - i.e. no flags to enable it - you installed it, all your tests suites are now random.\r\n\r\n**why randomize? because `pytest -n auto` ends up running tests somewhat randomly across the many processors**\r\n\r\n`flakefinder` is the only pytest plugin that I know of that allows repetition of unittests, but this one you can leave around - it doesn't do anything on its own, unless you tell it to.\r\n\r\n## Case 1. multiprocess\r\n\r\nWe will run 2 sub-tests in a random order:\r\n```\r\nexport TESTS=\"tests/test_benchmark_tf.py::TFBenchmarkTest::test_inference_encoder_decoder_with_configs \\ \r\ntests/test_benchmark_tf.py::TFBenchmarkTest::test_trace_memory\"\r\npytest $TESTS --cov --flake-finder --flake-runs=5 | tee k1; \\\r\npytest $TESTS --cov --flake-finder --flake-runs=5 | tee k2; \\\r\ndiff -u k1 k2 | egrep \"^(\\-|\\+)\"\r\n```\r\nand we get:\r\n```\r\n--- k1 2020-09-11 20:00:32.246210967 -0700\r\n+++ k2 2020-09-11 20:01:31.778468283 -0700\r\n-Using --randomly-seed=1418403633\r\n+Using --randomly-seed=1452350401\r\n-src/transformers/benchmark/benchmark_tf.py 152 62 59%\r\n-src/transformers/benchmark/benchmark_utils.py 401 239 40%\r\n+src/transformers/benchmark/benchmark_tf.py 152 50 67%\r\n+src/transformers/benchmark/benchmark_utils.py 401 185 54%\r\n-src/transformers/configuration_t5.py 32 16 50%\r\n+src/transformers/configuration_t5.py 32 4 88%\r\n-src/transformers/modeling_tf_t5.py 615 526 14%\r\n+src/transformers/modeling_tf_t5.py 615 454 26%\r\n-src/transformers/modeling_tf_utils.py 309 214 31%\r\n+src/transformers/modeling_tf_utils.py 309 212 31%\r\n-TOTAL 32394 24146 25%\r\n+TOTAL 32394 23994 26%\r\n-================== 10 passed, 3 warnings in 71.87s (0:01:11) ===================\r\n+======================= 10 passed, 3 warnings in 58.82s ========================\r\n```\r\nWhoah! Non-Idempotent test suite it is! A whooping 1% change in coverage over no change in code.\r\n\r\nSaving the seeds I'm now able to reproduce this at will by adding the specific seeds of the first run:\r\n\r\n```\r\nexport TESTS=\"tests/test_benchmark_tf.py::TFBenchmarkTest::test_inference_encoder_decoder_with_configs \\ \r\ntests/test_benchmark_tf.py::TFBenchmarkTest::test_trace_memory\"\r\npytest $TESTS --cov --flake-finder --flake-runs=5 --randomly-seed=1418403633 | tee k1; \\\r\npytest $TESTS --cov --flake-finder --flake-runs=5 --randomly-seed=1452350401 | tee k2; \\\r\ndiff -u k1 k2 | egrep \"^(\\-|\\+)\"\r\n```\r\ngetting the same results.\r\n\r\n## Case 2. randomization issue\r\n\r\nHere are some other tests with the same problem, but the cause is different - randomization\r\n\r\n```\r\nCUDA_VISIBLE_DEVICES=\"\" pytest -n 3 --dist=loadfile tests/test_data_collator.py --cov | tee c1; \\\r\nCUDA_VISIBLE_DEVICES=\"\" pytest -n 3 --dist=loadfile tests/test_data_collator.py --cov | tee c2; \\\r\ndiff -u c1 c2 | egrep \"^(\\-|\\+)\"\r\n```\r\nthis time w/o using flake-finder, but instead relying on `-n 3` + randomly.\r\n\r\n```\r\n--- c1 2020-09-11 19:00:00.259221772 -0700\r\n+++ c2 2020-09-11 19:00:14.103276713 -0700\r\n-Using --randomly-seed=4211396884\r\n+Using --randomly-seed=3270809055\r\n-src/transformers/data/datasets/language_modeling.py 168 23 86%\r\n+src/transformers/data/datasets/language_modeling.py 168 25 85%\r\n-src/transformers/tokenization_utils_base.py 750 321 57%\r\n+src/transformers/tokenization_utils_base.py 750 316 58%\r\n-TOTAL 32479 23282 28%\r\n+TOTAL 32479 23279 28%\r\n-======================= 9 passed, 13 warnings in 13.10s ========================\r\n+======================= 9 passed, 13 warnings in 13.44s ========================\r\n```\r\na much smaller diff, but a diff nevertheless\r\n\r\nNext is to try to resolve this or give up codecov.\r\n\r\nThe preliminary reading points the blaming finger to `multiprocessing` (`Pool`, and others). \r\n\r\nThank you for reading.\r\n", "@stas00 this is absolutely incredible. I'll admit that I wouldn't be able to have found this myself, you've done a hell of an investigation here. How can I be useful?", "Thank you for the kind words, @thomasrockhu. I have a solution for the random issue (need to set a fixed seed before the test), but not yet for the multiproc. It's all the tools that fork sub-processes that are the issue potentially, as they don't all get accounted for consistently. I need more time staring at the screen doing experiments.\r\n\r\nBut I do need your help here: https://codecov.io/gh/huggingface/transformers/pull/7067/changes\r\n\r\nWhat does it mean? If you look at +X/-X - they all are identical numbers, and should add up to 0. Yet, we get 2.41% diff in coverage. How does that get calculated and why are those identical numbers but flipped up - clearly there is something off there, not sure if it's related to coverage as they are perfectly complementary. \r\n\r\nI did see many others cases where they weren't complementary, but in this case it's 100% so. Ideas?\r\n\r\nOr perhaps if I rephrase this: how on that screen can I see the 2.41% difference if I look at it as a black box. I imagine the numbers are the same, but perhaps they are not the same lines in the code, hence the difference. But it's impossible to see that from that presentation. Clicking on the specific diff makes no sense to me. it's just one screen of one type/color - I can't see the actual diff.", "@thomasrockhu? Could you please have a look that issue mentioned in my last comment? Thank you.", "@stas00 apologies will take a look today/tomorrow", "@stas00, so the +X/-X are actually showing coverage change for that file. So as an example, \r\n\r\n\r\nyou see -1 -> +1. This means in total, one line that was not covered is now covered (this is not always a zero-sum game if a line is removed). You can see that two lines have added coverage (red to green) and one line has no coverage (green to red).\r\n\r\nSo taking the total over all those changes actually leads to a -777 line coverage drop. You can see that in the commits of this PR \r\n\r\nbase -> https://codecov.io/gh/huggingface/transformers/tree/8fcbe486e1592321e868f872545c8fd9d359a515\r\n\r\n\r\nhead -> https://codecov.io/gh/huggingface/transformers/tree/a4dd71ef19033ec8e059a0a76c7141a8a5840e66\r\n\r\n\r\nDoes this make more sense?", "The case you're are showing makes total sense. I'm absolutely clear on that one.\r\n\r\nBut your example doesn't work for https://codecov.io/gh/huggingface/transformers/pull/7067/changes\r\n\r\nLet's pick a small one: `Changes in src/transformers/modelcard.py`\r\n\r\n\r\n\r\nAs you can see there is only addition, I don't see any subtraction. i.e I only see red lines - where are the green ones? If it's +2/-2 I'd expect to see 2 in red and 2 in green. Does it make sense which parts of the reports I'm struggling to understand?\r\n" ]

[]

[]

[ "+1.\r\n\r\nI suppose it should not be difficult to add additional argument to ```self.args``` specifying number of workers to use and to use it as:\r\n```\r\nreturn DataLoader(\r\n self.train_dataset,\r\n batch_size=self.args.train_batch_size,\r\n sampler=train_sampler,\r\n collate_fn=self.data_collator,\r\n drop_last=self.args.dataloader_drop_last,\r\n num_workers=self.args.num_workers\r\n )\r\n```\r\n\r\nIs there any particular reason why this was not yet implemented? ", "+1", "+1", "No particular reason why it was not implemented, would welcome a PR!" ]

[]

[]

[ "I had to update all the files since n_gpu seems like a common param.", "You could create an issue, suggesting to use `n_gpu` everywhere instead, supporting it with some stats that would be in favor of this naming. As long as it's consistent across the project either way works, IMHO." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=h1) Report\n> Merging [#6314](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/be1520d3a3c09d729649c49fa3163bd938b6a238&el=desc) will **decrease** coverage by `0.85%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6314 +/- ##\n==========================================\n- Coverage 79.93% 79.08% -0.86% \n==========================================\n Files 153 153 \n Lines 27888 27888 \n==========================================\n- Hits 22293 22054 -239 \n- Misses 5595 5834 +239 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `66.66% <0.00%> (-32.50%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `69.06% <0.00%> (-27.52%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `71.21% <0.00%> (-12.88%)` | :arrow_down: |\n| [src/transformers/tokenization\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZ3B0Mi5weQ==) | `87.50% <0.00%> (-9.73%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `92.08% <0.00%> (-1.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iZXJ0LnB5) | `88.26% <0.00%> (-0.17%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `97.41% <0.00%> (+32.94%)` | :arrow_up: |\n| [src/transformers/tokenization\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6314/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `87.50% <0.00%> (+58.65%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=footer). Last update [be1520d...6321287](https://codecov.io/gh/huggingface/transformers/pull/6314?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "How do we know this works?", "> How do we know this works?\r\n\r\nI described what it did in the first comment:\r\n1. use public API instead of digging into PL internals\r\n2. restoring bits removed by https://github.com/huggingface/transformers/pull/6027 you have to compare against the original (pre-6027) see the second to last part of the diff: https://github.com/huggingface/transformers/pull/6027/files#diff-6cf9887b73b621b2d881039a61ccfa5fR47\r\n```\r\n # tensorboard_logs = {\"loss\": loss, \"rate\": self.lr_scheduler.get_last_lr()[-1]}\r\n tensorboard_logs = {\"loss\": loss}\r\n```\r\nwhy `rate` was removed?\r\n\r\ni.e. this PR is restoring, not changing anything. PR6027 did change behavior w/o testing the change.", "note: This does not effect seq2seq/ because of `Seq2SeqLoggingCallback`", "Thanks @stas00 !" ]

[]

[]

[ "Hi @brian8128 , `SquadDataset` was added after the 3.0.2 release. You'll need to install from source to use it", "Thanks! It's working now. You guys have written some code around this stuff!" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=h1) Report\n> Merging [#6312](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0eecaceac7a2cb3c067a435a7571a2ee0de619b9?el=desc) will **increase** coverage by `0.24%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6312 +/- ##\n==========================================\n+ Coverage 79.72% 79.96% +0.24% \n==========================================\n Files 157 157 \n Lines 28586 28586 \n==========================================\n+ Hits 22790 22859 +69 \n+ Misses 5796 5727 -69 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9lbGVjdHJhLnB5) | `25.13% <0.00%> (-73.83%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `32.20% <0.00%> (-66.95%)` | :arrow_down: |\n| [src/transformers/modeling\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19tYXJpYW4ucHk=) | `60.00% <0.00%> (-30.00%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/activations.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9hY3RpdmF0aW9ucy5weQ==) | `85.00% <0.00%> (-5.00%)` | :arrow_down: |\n| [src/transformers/tokenization\\_auto.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYXV0by5weQ==) | `95.55% <0.00%> (-2.23%)` | :arrow_down: |\n| [src/transformers/configuration\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3V0aWxzLnB5) | `96.00% <0.00%> (-0.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `95.06% <0.00%> (-0.35%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.97% <0.00%> (-0.33%)` | :arrow_down: |\n| [src/transformers/generation\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3V0aWxzLnB5) | `96.94% <0.00%> (+0.27%)` | :arrow_up: |\n| ... and [11 more](https://codecov.io/gh/huggingface/transformers/pull/6312/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=footer). Last update [0eecace...5871cac](https://codecov.io/gh/huggingface/transformers/pull/6312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Here is a potential idea of how to keep all the common cl arg definitions in `BaseTransformer` and then let each example subclass tell which ones it wants to support, w/o needing to duplicate the same thing everywhere.\r\n```\r\nimport argparse\r\n\r\n# removes an option from the parser after parser.add_argument's are all done\r\n#https://stackoverflow.com/a/49753634/9201239\r\ndef remove_option(parser, arg):\r\n for action in parser._actions:\r\n if (vars(action)['option_strings']\r\n and vars(action)['option_strings'][0] == arg) \\\r\n or vars(action)['dest'] == arg:\r\n parser._remove_action(action)\r\n\r\n for action in parser._action_groups:\r\n vars_action = vars(action)\r\n var_group_actions = vars_action['_group_actions']\r\n for x in var_group_actions:\r\n if x.dest == arg:\r\n var_group_actions.remove(x)\r\n return\r\n\r\n# another way to remove an arg, but perhaps incomplete\r\n#parser._handle_conflict_resolve(None, [('--bar',parser._actions[2])])\r\n\r\n# tell the parser which args to keep (the rest will be removed)\r\ndef keep_arguments(parser, supported_args):\r\n for act in parser._actions:\r\n arg = act.dest\r\n if not arg in supported_args:\r\n remove_option(parser, arg)\r\n\r\nparser = argparse.ArgumentParser()\r\n\r\n# superclass can register all kinds of options\r\nparser.add_argument('--foo', help='foo argument', required=False)\r\nparser.add_argument('--bar', help='bar argument', required=False)\r\nparser.add_argument('--tar', help='bar argument', required=False)\r\n\r\n# then a subclass can choose which of them it wants/can support\r\nsupported_args = ('foo bar'.split()) # no --tar please\r\n\r\nkeep_arguments(parser, supported_args)\r\n\r\nargs = parser.parse_args()\r\n```\r\n\r\nGranted, there is no public API to remove args once registered. This idea uses a hack that taps into an internal API.\r\n\r\n----\r\n\r\nAlternatively, `BaseTransformer` could maintain a dict of all the common args with help/defaults/etc w/o registering any of them, and then the subclass can just tell it which cl args it wants to be registered. This will be just a matter of formatting the dict and then a subclass would call:\r\n\r\n```\r\n# a potential new function to be called by a subclass \r\nregister_arguments(parser, 'foo bar'.split())\r\n```\r\nor if no abstraction is desired it could go as explicit as:\r\n```\r\ndefs = self.args_def() # non-existing method fetching the possible args\r\nparser.add_argument(defs['foo'])\r\nparser.add_argument(defs['bar'])\r\n```\r\nbut this probably defeats the purpose, just as well copy the whole thing.\r\n\r\n---\r\n\r\n\r\nOne thing to consider in either solution is that a subclass may want to have different defaults, so the new API could provide for defaults override as well.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=h1) Report\n> Merging [#6309](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/175cd45e13b2e33d1efec9e2ac217cba99f6ae58&el=desc) will **increase** coverage by `0.07%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6309 +/- ##\n==========================================\n+ Coverage 79.44% 79.52% +0.07% \n==========================================\n Files 148 148 \n Lines 27193 27193 \n==========================================\n+ Hits 21604 21625 +21 \n+ Misses 5589 5568 -21 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6309/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.20%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6309/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `60.56% <0.00%> (-35.22%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6309/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+1.00%)` | :arrow_up: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6309/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `57.65% <0.00%> (+4.50%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6309/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `97.41% <0.00%> (+32.94%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=footer). Last update [175cd45...6337bdf](https://codecov.io/gh/huggingface/transformers/pull/6309?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I am strongly in favor." ]

[]

[]

[ "The documentation of `debug` clearly points out this parameter is only used for TPU-training:\r\n```\r\ndebug (:obj:`bool`, `optional`, defaults to :obj:`False`):\r\n When training on TPU, whether to print debug metrics or not.\r\n```\r\nIt's called simply debug (and not `tpu_debug`) for harmonization with `TFTrainer`.", "Ah, my bad for not fully reading the documentation. Would you be open to a PR with a guard or more-specific error message for this scenario?", "Sure!", "closed by #6390 " ]

[]

[]

[ "The merged https://github.com/huggingface/transformers/pull/6027 broke `examples/seq2seq/test_seq2seq_examples.py::test_finetune_lr_shedulers` - which I think was flagged by failing CI of that PR.\r\n\r\nyeah, PL already has `--gpus` - so it conflicts with the one added by 6027. So I will look at how to rework that need in a different way.\r\n\r\nAdded skip for now for the failing test. Will fix once we discussed how to proceed.", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=h1) Report\n> Merging [#6307](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/ffceef2042d5a1f2a2d70c8a0606551147dd6f8d&el=desc) will **increase** coverage by `0.26%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6307 +/- ##\n==========================================\n+ Coverage 79.14% 79.41% +0.26% \n==========================================\n Files 148 148 \n Lines 27193 27193 \n==========================================\n+ Hits 21521 21594 +73 \n+ Misses 5672 5599 -73 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.20%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-5.17%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `84.21% <0.00%> (-2.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.40% <0.00%> (+0.40%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.51% <0.00%> (+0.44%)` | :arrow_up: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `84.09% <0.00%> (+1.51%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `94.28% <0.00%> (+2.14%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.84% <0.00%> (+7.41%)` | :arrow_up: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `98.63% <0.00%> (+21.91%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/huggingface/transformers/pull/6307/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=footer). Last update [ffceef2...0a83f75](https://codecov.io/gh/huggingface/transformers/pull/6307?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "> The merged #6027 broke `examples/seq2seq/test_seq2seq_examples.py::test_finetune_lr_shedulers` - which I think was flagged by failing CI of that PR - I will sort it out.\r\n> \r\n> yeah, PL already has `--gpus` - so it conflicts with the one added by 6027. So I will look at how to rework that need in a different way.\r\n\r\nI think we can remove the --gpus argument from the run_pl.sh file it does not have to be there for the example. But it has to be in the generic_arguments.\r\n\r\nI agree on the shuffle. Thank you for this!", "Please merge this asap, since master CI is currently breaking!\r\n\r\nLet's continue the discussion here: https://github.com/huggingface/transformers/issues/6310", "> I think we can remove the --gpus argument from the run_pl.sh file it does not have to be there for the example. But it has to be in the generic_arguments.\r\n\r\nno, the problem is elsewhere, see https://github.com/huggingface/transformers/issues/6310\r\n\r\n> I agree on the shuffle. Thank you for this!\r\n\r\nthank you for the kind words." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Confirming the warning started to appear since I did a conda upgrade (for pytorch 1.6.0), never got the error here.", "> Confirming the warning started to appear since I did a conda upgrade (for pytorch 1.6.0)\r\n\r\nThank you for validating this.\r\n\r\nThe warning is kind of like an error, since it's noisy, so there is no quick way to see if all is clean before committing.\r\n\r\n> never got the error here.\r\n\r\nYou probably happened to have a newer `flake8`, hence suggesting a minimum requirement.\r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "this has been resolved." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=h1) Report\n> Merging [#6305](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/118ecfd4273b5381aeeb65476a01678c7a96ae3e&el=desc) will **increase** coverage by `0.57%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6305 +/- ##\n==========================================\n+ Coverage 78.15% 78.72% +0.57% \n==========================================\n Files 148 148 \n Lines 27193 27193 \n==========================================\n+ Hits 21252 21407 +155 \n+ Misses 5941 5786 -155 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6305/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6305/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.84% <0.00%> (-22.88%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6305/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6305/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.18% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6305/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+2.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6305/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `94.63% <0.00%> (+70.08%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=footer). Last update [118ecfd...31ae60c](https://codecov.io/gh/huggingface/transformers/pull/6305?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Thanks for contributing!" ]

[]

[]

[ "should be fixed on master, let me know if not." ]

[]

[]

[ "fixed on master, let me know if not." ]

[]

[]

[]

[ { "id": 1108649053, "node_id": "MDU6TGFiZWwxMTA4NjQ5MDUz", "url": "https://api.github.com/repos/huggingface/transformers/labels/Help%20wanted", "name": "Help wanted", "color": "008672", "default": false, "description": "Extra attention is needed, help appreciated" } ]

[]

[ "Great catch! Feel free to PR a fix!" ]

[]

[]

[ "Good to merge for me.", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=h1) Report\n> Merging [#6300](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/2f2aa0c89cab9a77560e6845578f917a61081c67&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6300 +/- ##\n=======================================\n Coverage 79.14% 79.15% \n=======================================\n Files 148 148 \n Lines 27191 27191 \n=======================================\n+ Hits 21521 21522 +1 \n+ Misses 5670 5669 -1 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6300/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19yZWZvcm1lci5weQ==) | `95.68% <100.00%> (ø)` | |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6300/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+0.25%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=footer). Last update [2f2aa0c...f029d86](https://codecov.io/gh/huggingface/transformers/pull/6300?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=h1) Report\n> Merging [#6298](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/31da35cc8939e19a292cb7f15cad5c9a1ddf7f23&el=desc) will **decrease** coverage by `0.00%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6298 +/- ##\n==========================================\n- Coverage 79.64% 79.64% -0.01% \n==========================================\n Files 147 147 \n Lines 27120 27121 +1 \n==========================================\n Hits 21600 21600 \n- Misses 5520 5521 +1 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6298/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbGVjdHJhLnB5) | `82.13% <ø> (+0.57%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6298/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9hbGJlcnQucHk=) | `81.74% <100.00%> (+6.45%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6298/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.47% <0.00%> (-32.95%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6298/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6298/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `94.70% <0.00%> (+22.94%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6298/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=footer). Last update [31da35c...2cfe35e](https://codecov.io/gh/huggingface/transformers/pull/6298?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Hi ZLK, we're trying to keep Github issues on our repo strictly related to code. [Our forum](https://discuss.huggingface.co) is a much better place for general questions like yours, and the people over there will better be able to answer it! Cheers" ]

[]

[]

[ "Ignore the failing test, will be patched by https://github.com/huggingface/transformers/pull/6287", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=h1) Report\n> Merging [#6296](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d5bc32ce92ace9aaec7752e0b89d51ba18903a1b&el=desc) will **decrease** coverage by `0.64%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6296 +/- ##\n==========================================\n- Coverage 79.56% 78.91% -0.65% \n==========================================\n Files 147 147 \n Lines 27125 27128 +3 \n==========================================\n- Hits 21581 21409 -172 \n- Misses 5544 5719 +175 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2dwdDIucHk=) | `97.29% <100.00%> (+0.07%)` | :arrow_up: |\n| [src/transformers/modeling\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19ncHQyLnB5) | `85.96% <100.00%> (+0.04%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.84% <100.00%> (+0.08%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `71.21% <0.00%> (-12.88%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+5.76%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6296/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=footer). Last update [d5bc32c...becd6aa](https://codecov.io/gh/huggingface/transformers/pull/6296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "> Good for me in general.\r\n> Think naming can be improved:\r\n> Would prefer the name to be either `intermediate_size` as in `BertConfig` or `feed_forward_size` as in `ReformerConfig`.\r\n\r\nAs discussed with @patrickvonplaten in the real world, since gpt2 already doesn't have the same names as the other models, might as well have a name that's consistent with the other gpt2 parameters." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=h1) Report\n> Merging [#6293](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d5bc32ce92ace9aaec7752e0b89d51ba18903a1b&el=desc) will **decrease** coverage by `0.55%`.\n> The diff coverage is `0.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6293 +/- ##\n==========================================\n- Coverage 79.56% 79.00% -0.56% \n==========================================\n Files 147 147 \n Lines 27125 27127 +2 \n==========================================\n- Hits 21581 21433 -148 \n- Misses 5544 5694 +150 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6293/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `66.95% <0.00%> (-26.85%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6293/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6293/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.44% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6293/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+5.76%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6293/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=footer). Last update [d5bc32c...ea610f8](https://codecov.io/gh/huggingface/transformers/pull/6293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "thanks for the nit!" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "It is tied to the input layer, see https://github.com/huggingface/transformers/issues/3799 or the docs here: https://huggingface.co/transformers/model_doc/gpt2.html#transformers.GPT2LMHeadModel. ", "If you want to know more about how to fine-tune the model, maybe this helps: https://github.com/huggingface/transformers/issues/1816 or you could ask a question in the forum: https://discuss.huggingface.co/" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=h1) Report\n> Merging [#6290](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d5bc32ce92ace9aaec7752e0b89d51ba18903a1b&el=desc) will **decrease** coverage by `0.36%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6290 +/- ##\n==========================================\n- Coverage 79.56% 79.20% -0.37% \n==========================================\n Files 147 147 \n Lines 27125 27125 \n==========================================\n- Hits 21581 21483 -98 \n- Misses 5544 5642 +98 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.47% <0.00%> (-32.95%)` | :arrow_down: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <0.00%> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_ctrl.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fY3RybC5weQ==) | `78.64% <0.00%> (-17.48%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.43% <0.00%> (-7.42%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.07% <0.00%> (-0.45%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.00% <0.00%> (-0.41%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+6.01%)` | :arrow_up: |\n| ... and [2 more](https://codecov.io/gh/huggingface/transformers/pull/6290/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=footer). Last update [d5bc32c...b765e0b](https://codecov.io/gh/huggingface/transformers/pull/6290?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Hi, is there any reason why this function not merged into the generate function? Hope to use this functionality to incorporate with reinforcement learning in my work.", "Hey @ngoquanghuy99,\r\n\r\nSorry to answer only now. It is already possible to output probabilities as shown here: https://discuss.huggingface.co/t/generation-probabilities-how-to-compute-probabilities-of-output-scores-for-gpt2/3175/15?u=patrickvonplaten" ]

[]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=h1) Report\n> Merging [#6288](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d5bc32ce92ace9aaec7752e0b89d51ba18903a1b&el=desc) will **decrease** coverage by `0.29%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6288 +/- ##\n==========================================\n- Coverage 79.56% 79.26% -0.30% \n==========================================\n Files 147 147 \n Lines 27125 27125 \n==========================================\n- Hits 21581 21500 -81 \n- Misses 5544 5625 +81 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.47% <0.00%> (-32.95%)` | :arrow_down: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <0.00%> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.43% <0.00%> (-7.42%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.07% <0.00%> (-0.45%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.00% <0.00%> (-0.41%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+5.76%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/huggingface/transformers/pull/6288/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=footer). Last update [d5bc32c...c70d376](https://codecov.io/gh/huggingface/transformers/pull/6288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "There seems to be a flaky test for run_examples. (I had a few errors with pip install step. Invalid hash... quite worrying)" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=h1) Report\n> Merging [#6287](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d89acd07cc42a2352cca18c8facefb9442fd08ab&el=desc) will **increase** coverage by `0.77%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6287 +/- ##\n==========================================\n+ Coverage 79.68% 80.45% +0.77% \n==========================================\n Files 146 146 \n Lines 26595 26595 \n==========================================\n+ Hits 21192 21397 +205 \n+ Misses 5403 5198 -205 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.05% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `57.65% <0.00%> (+4.50%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+5.76%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.31% <0.00%> (+23.43%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6287/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=footer). Last update [d89acd0...f3776aa](https://codecov.io/gh/huggingface/transformers/pull/6287?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "> If the cache works well enough, I'll include `~/.cache/torch` in the cache, so that all the downloads done during the tests are saved in the cache as well. This should prevent other flaky tests from happening due to missing models on the S3.\r\n\r\nIf the model is missing on S3, it should be reported as a failure, shouldn't it?\r\n\r\nI wouldn't include `~/.cache/torch` in the cache because layering multiple caches (files are already behind a CDN) tends to lead to hard to debug bugs", "@julien-c These flaky failing tests are saying that the model is missing on S3, while it isn't. It's available, but since CircleCI has connection issues it reports those with an error. I'll link such a failing test here when there is one." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Sorry for the long delay on this one - I hope to be able to take a look in the next two weeks :-) ", "And thanks a lot for the very in-detail description here!", "Any update on this task?", "Hi all, in case it is helpful Noam recently wrote up a maybe-exhaustive list of the differences between T5.1.1 and a vanilla Transformer. Copying it here:\r\n\r\n> Here are the main differences between t5.1.1.* and most other Transformer implementations.\r\nHope I have not forgotten anything. Please add where appropriate.\r\n> ## No positional embedding \r\n> (relies on relative attention - see below)\r\n> ## FFN Layers\r\n> No biases\r\n> version t5.1.1.* (but not t5.1.0.*) uses Gated-GELU activation \r\n> two input projections, approximate-gelu activation on one of them, then multiply componentwise, and apply the output projection\r\n> Approximate GELU: \r\n> ```\r\n> cdf = 0.5 * (1.0 + tanh((np.sqrt(2 / np.pi) * (x + 0.044715 * x * x * x))))\r\n> return x * cdf\r\n> ```\r\n> ## Attention Layers\r\n> \"relative position bias\" - This is a simplified form of relative attention, due to the fact that other relative attention algorithms are slow on TPU. This is present in the encoder self-attention layers and decoder self-attention layers, but not the encoder-decoder attention layers.\r\n> A learned \"bias\" value is added to the attention logit. The bias is different by bucketed relative position. The biases are different across attention heads, but shared across different attention layers in the same stack. \r\n> relative_position = memory_position - query_position\r\nbucket(relative_position) is determined by the function here: https://github.com/tensorflow/mesh/blob/5f802ae5492fd9207fd506a7ced189f6dbc38f2c/mesh_tensorflow/transformer/transformer_layers.py#L996\r\n> bidirectional=True for the encoder and False for the decoder.\r\n> The variables representing the four linear transformations have their num_heads and d_kv dimensions combined. This caused the code to run faster on TPU for some unknown reason.\r\n> No biases on the input and output linear transformations.\r\n> No explicit scaling of the logits by d_kv^-0.5 . This is folded into the initializers of the linear transformations. With Adafactor, it's equivalent.\r\n> Not in any of the t5.1 configs, but may be in other configs: \"extra logit\" - This is equivalent to appending a 0 to the set of logits prior to softmax, and truncating it after the softmax. This allows for attending to nothing, if all of the logits are much less than zero. It's not clear whether this is an improvement or just a stumbling block for compatibility.\r\n> ## Embeddings\r\n> Encoder vocab embedding shared with decoder vocab embedding\r\n> in t5.1.0.* (but not in t5.1.1.*) this variable is also shared with the classifier layer. In that case, it is multiplied by d_model**-0.5 for use in the classifer.\r\n> ## Residuals, etc. \r\n> Before layer stack, apply dropout\r\n> For each layer apply \r\n> Y = X + dropout(F(rms_norm(X))\r\n> F is the core layer function, i.e. feed-forward, attention, etc.\r\n> RMS norm is a simplified version of layer norm.\r\n> After layer stack, apply rms_norm, then droupout.", "Hi @patrickvonplaten \r\n\r\nAny updates on this? It's exciting to be able to use the T5 v1.1 models in huggingface! Thanks!", "Hi Patrick,\r\nThere are newly released T5.1.1 checkpoints which give SOTA on natural question for non-retrieval models which I posted a \r\n[discussion here](https://discuss.huggingface.co/t/convert-new-t5-checkpoints-released-from-google-naturalquestion-dataset/1579) . Maybe it's a bit more encouragement to integrate T5.1.1 into HF :D ", "@craffel Thanks for your clarification about T5.1.1 . \r\nHowever, I could not find any source code of T5.1.1 , is it possible to provide the link to the source ?", "Hi, the source is all in the mesh TF transformer codebase\r\nhttps://github.com/tensorflow/mesh/tree/master/mesh_tensorflow/transformer\r\nHere is the gin config for t5.1.1.base\r\nhttps://github.com/google-research/text-to-text-transfer-transformer/blob/master/t5/models/gin/models/t5.1.1.base.gin", "Multilingual t5 (mt5) has been released \r\nhttps://github.com/google-research/multilingual-t5\r\nhttps://arxiv.org/abs/2010.11934\r\n\r\nit looks like use same implementation method as T5 v1.1\r\nreally look forward to be able use it on huggingface library\r\n", "@julien-c thanks for your amazing nlp lib.\r\nWhen do you plan to support mT5 ?\r\nWhen #6285 will be release ?\r\nCheers\r\nPhilippe", "Hey guys,\r\n\r\nI will start adding mT5 next week", "@patrickvonplaten : waiting for mt5 :)", "Yep will start working on it this week :-) ", "Think a reasonable estimate for official release is in ~2 weeks: https://github.com/huggingface/transformers/pull/8488", "T5 V1.1 and MT5 have the same architecture. I'm struggling a bit with finding a good name for the library. \r\n\r\nNot sure if I like the names `T5V1_1Model` and `T5V1_1ForConditionalGeneration`, maybe `T5v2Model` is better? \r\n`MT5Model` will be aliased to the new model architecture. \r\n\r\n=> Going for `T5v2Model` and `T5v2ForConditionalGeneration` now. `MT5Model` will be aliased to it. If someone has better name suggestions please add a comment :-) Names are easy to change before integration. ", "Hi @patrickvonplaten , thanks again ! \r\nI think T5v2 is a nicer name. However, \"if\" somebody releases the official T5v2 in the future (like GPT GPT-2 GPT-3), maybe it will cause confusion. Can it be T5v11 (no '_') ? ", "Yeah good point @ratthachat! \r\n\r\n@craffel - We decided internally that we will make a new model file for T5v1.1 / mT5 as it's more in line with the libraries' philosophy. The best name that I can think of at the moment is `T5V2Model` and `T5V2ForConditionalGeneration` respectively - IMO it's better than `T5v1p1Model`, ... However, if you guys would release a `T5v2` the naming would be a bit awkward. \r\n\r\nWould be super interested in hearing your opinion about it! Or better name suggestions in case you have some :-) ", "It might be confusing to refer to T5.1.1 as T5 v2 since it would result in an inconsistent versioning system. I think T511Model is probably ok, but I defer to you all as to what HF's naming convention should be.", "I would either suggest:\r\n1. Follow @craffel suggestion.\r\n2. To just have one version and adjust the json file to load the correct configuration. Since most of the code is exactly the same except few changes.", "If possible and not cause any harm I support @agemagician choice 2. above.", "I haven't reproduce benchmark performance (such as glue cola, mrpc, etc.) with PyTorch T5.1.1 so far. Is anyone else trying this?", "> I haven't reproduce benchmark performance (such as glue cola, mrpc, etc.) with PyTorch T5.1.1 so far. Is anyone else trying this?\r\n\r\nI have reproduced mT5-small model by finetuning XNLI benchmark task now. It seems to work." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=h1) Report\n> Merging [#6284](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c67d1a0259cbb3aef31952b4f37d4fee0e36f134&el=desc) will **decrease** coverage by `0.00%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6284 +/- ##\n==========================================\n- Coverage 79.19% 79.18% -0.01% \n==========================================\n Files 147 147 \n Lines 27120 27120 \n==========================================\n- Hits 21478 21476 -2 \n- Misses 5642 5644 +2 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6284/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbGVjdHJhLnB5) | `81.55% <100.00%> (ø)` | |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6284/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `81.70% <0.00%> (-5.02%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6284/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9lbGVjdHJhLnB5) | `94.24% <0.00%> (+4.71%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=footer). Last update [c67d1a0...1c5c550](https://codecov.io/gh/huggingface/transformers/pull/6284?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I would like to use `TFElectraForSequenceClassification`\r\n\r\nI assume I would need to install from source.\r\nAny info on when the next release to pypi will be ? \r\n\r\nThanks!", "@nemani It will be available in the next few days " ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=h1) Report\n> Merging [#6281](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d89acd07cc42a2352cca18c8facefb9442fd08ab&el=desc) will **increase** coverage by `0.01%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6281 +/- ##\n==========================================\n+ Coverage 79.68% 79.69% +0.01% \n==========================================\n Files 146 146 \n Lines 26595 26596 +1 \n==========================================\n+ Hits 21192 21197 +5 \n+ Misses 5403 5399 -4 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6281/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ194bG0ucHk=) | `91.02% <100.00%> (+0.01%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6281/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `60.56% <0.00%> (-35.22%)` | :arrow_down: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6281/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `57.65% <0.00%> (+4.50%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6281/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+6.01%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=footer). Last update [d89acd0...bf40418](https://codecov.io/gh/huggingface/transformers/pull/6281?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "As mentioned in #6277, this will be problematic since Reformer fails on pytorch < 1.6.0.", "Indeed, this will be a problem. The issue with keeping torch 1.6.0 for these tests is that the error is indecipherable. It can't be reproduced on CPU, and on GPU fails 1/4 times when only a few tests are selected, with untrackable CUDA errors. Pinging @patrickvonplaten for discussion.", "> Indeed, this will be a problem. The issue with keeping torch 1.6.0 for these tests is that the error is indecipherable. It can't be reproduced on CPU, and on GPU fails 1/4 times when only a few tests are selected, with untrackable CUDA errors. Pinging @patrickvonplaten for discussion.\r\n\r\nAs discussed internally, I guess we can revert the PR causing #6277 ", "> As mentioned in #6277, this will be problematic since Reformer fails on pytorch < 1.6.0.\r\n\r\nhttps://github.com/huggingface/transformers/pull/6300 This should fix it for PyTorch < 1.6 and PyTorch == 1.6.. Wolud be great if you can review and merge if OK.", "Great, thanks a lot @patrickvonplaten !" ]

[]

[]

[ "Strange CI problem with checksum of Torch:\r\n```\r\nERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.\r\n torch from https://files.pythonhosted.org/packages/38/53/914885a93a44b96c0dd1c36f36ff10afe341f091230aad68f7228d61db1e/torch-1.6.0-cp36-cp36m-manylinux1_x86_64.whl#sha256=7669f4d923b5758e28b521ea749c795ed67ff24b45ba20296bc8cff706d08df8 (from transformers==3.0.2):\r\n Expected sha256 7669f4d923b5758e28b521ea749c795ed67ff24b45ba20296bc8cff706d08df8\r\n Got 8188c461d0b762aa4ae6e72105b3c3a01f7bb2863b46a392ff8537a0854e8967\r\n```", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=h1) Report\n> Merging [#6280](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/31da35cc8939e19a292cb7f15cad5c9a1ddf7f23&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6280 +/- ##\n=======================================\n Coverage 79.64% 79.64% \n=======================================\n Files 147 147 \n Lines 27120 27125 +5 \n=======================================\n+ Hits 21600 21605 +5 \n Misses 5520 5520 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6280/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.51% <100.00%> (+0.19%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=footer). Last update [31da35c...547df96](https://codecov.io/gh/huggingface/transformers/pull/6280?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "You can ignore the HASH errors, we're working on solving these but they're unrelated to your PR.", "This is ready to be merged IMO. 😁", "Wow - this was really fast from first commit to merge. Many thanks to the contributors. This makes open source development twice as much fun. " ]

[]

[]

[ "Hey @yxu02, we are trying to move questions on how to use transformer models to https://discuss.huggingface.co/. Would you mind posting it there again? :-) " ]

[]

[]

[]

[]

[]

[ "yes! I think the change #6244 is also only necessary in PyTorch 1.6 -> maybe we can even hard-code `torch.__version__` in the code and use the appropriate functions accordingly. Think this is also very much related to the previous bug: https://github.com/pytorch/pytorch/issues/33546", "#6300 should fix it." ]

[]

[]

[]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Hello,\r\nI'd hate to keep bother you on this, but could you quickly tell me how I should adjust `model_RobertaForMultipleChoice.modules()` to only return those parameters that pertains to the uppermost layer of `roberta-large` pre-trained model?\r\n\r\nI know how to convert the HuggingFace Transformers into Pyro models now - for this, I just need to add a dummy parameter after converting the Transformer into a Pyro model, and then define `svi` and do `svi.step()` for training. But the problem I am facing now is that the Transformer, when converted into a Pyro model, causes memory leak and my EC2 instance can't handle the amount of analysis needed for the Pyro model. So now I am trying to convert only the 24th layer of the `roberta-large` model into a Pyro layer, and see if my instance can handle it at that capacity.\r\n\r\nHow should I adjust the statement `model_RobertaForMultipleChoice.modules()` to only return those parameters that pertains to the uppermost layer (24th layer) of the `roberta-large` pre-trained model? Thank you,", "I think you can leverage the variable `m._pyro_name`. For example running this code:\r\n```python\r\nfrom transformers import RobertaForMultipleChoice, RobertaConfig\r\nimport pyro.distributions as dist\r\nimport pyro.nn.module as module\r\n\r\n# get the pre-trained HuggingFace RobertaForMultipleChoice and resize the token embeddings\r\n# after adding the special token\r\nmodel_RobertaForMultipleChoice = RobertaForMultipleChoice(RobertaConfig())\r\n\r\n# convert the HuggingFace model into a pyro model\r\nmodule.to_pyro_module_(model_RobertaForMultipleChoice)\r\n\r\nfor m in model_RobertaForMultipleChoice.modules():\r\n for name, value in list(m.named_parameters(recurse=False)):\r\n if \"roberta.encoder.layer.11\" in m._pyro_name:\r\n print(f\"Set weights for: {m._pyro_name}\")\r\n setattr(m, name, module.PyroSample(prior=dist.Normal(0, 1).expand(value.shape).to_event(value.dim())))\r\n```\r\n\r\nwould only set the weights of the 11th layer to a `PyroSample`.\r\nRunning the code above gives the following output:\r\n```\r\nSet weights for: roberta.encoder.layer.11.attention.self.query\r\nSet weights for: roberta.encoder.layer.11.attention.self.query\r\nSet weights for: roberta.encoder.layer.11.attention.self.key\r\nSet weights for: roberta.encoder.layer.11.attention.self.key\r\nSet weights for: roberta.encoder.layer.11.attention.self.value\r\nSet weights for: roberta.encoder.layer.11.attention.self.value\r\nSet weights for: roberta.encoder.layer.11.attention.output.dense\r\nSet weights for: roberta.encoder.layer.11.attention.output.dense\r\nSet weights for: roberta.encoder.layer.11.attention.output.LayerNorm\r\nSet weights for: roberta.encoder.layer.11.attention.output.LayerNorm\r\nSet weights for: roberta.encoder.layer.11.intermediate.dense\r\nSet weights for: roberta.encoder.layer.11.intermediate.dense\r\nSet weights for: roberta.encoder.layer.11.output.dense\r\nSet weights for: roberta.encoder.layer.11.output.dense\r\nSet weights for: roberta.encoder.layer.11.output.LayerNorm\r\nSet weights for: roberta.encoder.layer.11.output.LayerNorm\r\n```\r\n\r\nLet me know if this works for you. Also, if you manage to get a Bayesian Neural Network using `transformers` it would be amazing if you can share some code or add a notebook :-) " ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=h1) Report\n> Merging [#6274](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c67d1a0259cbb3aef31952b4f37d4fee0e36f134&el=desc) will **increase** coverage by `0.33%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6274 +/- ##\n==========================================\n+ Coverage 79.19% 79.53% +0.33% \n==========================================\n Files 147 147 \n Lines 27120 27120 \n==========================================\n+ Hits 21478 21569 +91 \n+ Misses 5642 5551 -91 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.20%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `68.14% <0.00%> (-25.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `66.66% <0.00%> (-23.43%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.40% <0.00%> (+0.40%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.32% <0.00%> (+0.45%)` | :arrow_up: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `84.09% <0.00%> (+1.51%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `94.28% <0.00%> (+2.14%)` | :arrow_up: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `42.48% <0.00%> (+3.75%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.84% <0.00%> (+7.41%)` | :arrow_up: |\n| ... and [3 more](https://codecov.io/gh/huggingface/transformers/pull/6274/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=footer). Last update [c67d1a0...bdaee57](https://codecov.io/gh/huggingface/transformers/pull/6274?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Hi @bmichele , \r\nThe `/examples/token-classification` is pretty generic, you won't need to add new example. If you process the data in the format expected by the example the you can pass the `bert-base-finnish-cased-v1` model using the model_name_or_path argument.\r\n\r\nHope this helps.", "Hi @patil-suraj , thank you for your input.\r\n\r\nAs I mentioned in the issue, the example for Finnish is already implemented in this branch:\r\nhttps://github.com/bmichele/transformers/tree/finnish-ner\r\n\r\nThe branch contains the scripts necessary to\r\n * download and preprocess the FiNER dataset\r\n * perform the fine-tuning\r\n\r\nMoreover, I added the results in the readme file:\r\nhttps://github.com/bmichele/transformers/blob/finnish-ner/examples/ner/README.md\r\n\r\nI see that few months ago the WNUT’17 example was added, my question is if there is interest in merging also the Finnish example. If this is the case, I will take care of updating it so that it can be merged without conflicts and create a PR.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=h1) Report\n> Merging [#6269](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/bd0eab351a338175053998ddfc059f1cb6424ab4&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6269 +/- ##\n=======================================\n Coverage 79.29% 79.29% \n=======================================\n Files 146 146 \n Lines 26684 26684 \n=======================================\n+ Hits 21158 21160 +2 \n+ Misses 5526 5524 -2 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=footer). Last update [bd0eab3...02faea5](https://codecov.io/gh/huggingface/transformers/pull/6269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Looks innocuous to me, is there some test this allows us to enable for jit and T5?", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=h1) Report\n> Merging [#6268](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9f57e39f7165fa8bd6ac911852221a76d4b79ebe&el=desc) will **decrease** coverage by `1.28%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6268 +/- ##\n==========================================\n- Coverage 79.79% 78.50% -1.29% \n==========================================\n Files 148 148 \n Lines 27196 27196 \n==========================================\n- Hits 21701 21351 -350 \n- Misses 5495 5845 +350 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `95.76% <ø> (ø)` | |\n| [src/transformers/modeling\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190NS5weQ==) | `84.46% <ø> (+1.13%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `24.55% <0.00%> (-70.09%)` | :arrow_down: |\n| [src/transformers/tokenization\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdDUucHk=) | `71.83% <0.00%> (-23.95%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `71.21% <0.00%> (-12.88%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.44% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `57.65% <0.00%> (+4.50%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6268/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `87.73% <0.00%> (+63.19%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=footer). Last update [9f57e39...ac001c4](https://codecov.io/gh/huggingface/transformers/pull/6268?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "After digging a bit deeper why Bart tests fail, I think the reason is that the Bart cache/`past_key_value` data structure is not compatible with torchscript. For now the Bart tests pass because returning the cache/`past_key_vaule` is disabled - see https://github.com/huggingface/transformers/blob/ac001c48b8df1f5aadcc8cf2c71d7c1116c05250/tests/test_modeling_common.py#L252. \r\n\r\nA bug was filed for this problem: https://github.com/huggingface/transformers/issues/6348.", "PR should be good for merge IMO. @LysandreJik @sshleifer @sgugger - would be great if you can take a quick second look.", "Putting this on hold for now as it introduces a breaking change.", "Any updates on this?", "The problem is that it breaks backwards compatibility in a sense that the positional arguments of Bart and T5 are changed. At the moment this is the only option to make torch tracing work for Bart and T5 though...there might be a possiblity to trace a wrapper around the model though - see https://github.com/pytorch/pytorch/issues/14455 . But this currently leads to another problem which is probably related to our PyTorch models not being scriptable at the moment." ]

[]

[ { "login": "julien-c", "id": 326577, "node_id": "MDQ6VXNlcjMyNjU3Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/326577?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-c", "html_url": "https://github.com/julien-c", "followers_url": "https://api.github.com/users/julien-c/followers", "following_url": "https://api.github.com/users/julien-c/following{/other_user}", "gists_url": "https://api.github.com/users/julien-c/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-c/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-c/subscriptions", "organizations_url": "https://api.github.com/users/julien-c/orgs", "repos_url": "https://api.github.com/users/julien-c/repos", "events_url": "https://api.github.com/users/julien-c/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-c/received_events", "type": "User", "site_admin": false }, { "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "site_admin": false } ]

[ "Fixed now. \r\n\r\nhttps://huggingface.co/shrugging-grace/tweetclassifier?text=I+like+you.+I+love+you\r\n\r\nYou should add a label map to get the correct labels displayed in the widget.\r\n\r\nThanks!", "Thank you! Really appreciate the help and prompt response. " ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null }, { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Thanks a lot for open this @agemagician ! I think we should be able to adapt `modeling_bert.py` to be compatible with this model.\r\nFor model parallelism one could take a look at this PR: https://github.com/huggingface/transformers/pull/3578.\r\nRegarding \"relative attention encoding\" does this just correspond to these lines: https://github.com/tensorflow/mesh/blob/d46ff8751f387cf37d732fa0fb968cc0d1de7cc2/mesh_tensorflow/bert/bert.py#L252 ? \r\n\r\nAnd could you also add a link to the weights here? \r\n\r\nI think it should be relatively straight-forward to implement this model. In a first step probably without model parallelism.\r\n@agemagician also don't hesitate to give implementing it a try if you feel like it :-) ", "Thanks @patrickvonplaten for considering this modified Bert model.\r\nI believe it is very important model as it allows new Bert SOT results with larger Bert models.\r\nFurthermore, as your team familiar with T5 model it should be easy to integrate it, because most of this Bert model code overlap with T5 as both of them use mesh Tensorflow as a backend during training.\r\n\r\nRegarding your questions/feedback:\r\n\r\n1) For model parallelism one could take a look at this PR: #3578.\r\nYes, this is a good way to support model parallelism feature for all transformers models .\r\nHowever, you could replicate the same T5 block code for Bert, if you think it will be faster:\r\nhttps://github.com/huggingface/transformers/blob/master/src/transformers/modeling_tf_t5.py#L541\r\nlater, you could implement a general modelling for model parallelism, but it is your call.\r\n\r\n2) Regarding \"relative attention encoding\" does this just correspond to these lines: https://github.com/tensorflow/mesh/blob/d46ff8751f387cf37d732fa0fb968cc0d1de7cc2/mesh_tensorflow/bert/bert.py#L252 ?\r\nYes, this is correct, if I am not mistaken, it should be a replica of T5 code:\r\nhttps://github.com/huggingface/transformers/blob/master/src/transformers/modeling_tf_t5.py#L141\r\n\r\n3) And could you also add a link to the weights here?\r\nWe didn't publish Bert-XL yet, as we still testing them.\r\nI have sent you an email with private access to the model.\r\nLater, we will publish them on our official repo:\r\nhttps://github.com/agemagician/ProtTrans\r\n\r\n4) One more difference that I have noticed is the \"residual_structure\" flag.\r\nhttps://github.com/tensorflow/mesh/blob/ff0ef65f0ffb9c9c1d77564e63dd3ec2b9011436/mesh_tensorflow/bert/bert.py#L275\r\nThey either normalize the input before adding it to the previous layer output or after adding it. \r\n\r\n-----\r\n\r\nPS: We want to thank your team in the acknowledgement section of our paper, for making our models more accessible to researchers: \r\nhttps://www.biorxiv.org/content/10.1101/2020.07.12.199554v2.full.pdf\r\n\r\nCould you please let me know if the following draft format fits:\r\nFrom Huggingface, we would like to deeply thank both Patrick and Julien for making the new T5 and Bert models easily accessible to researcher through transformers project.", "Super will take a look soon :-) Thanks for sending me the weights! Regarding the acknowledgment, it would be very nice if you can include our transformers paper: https://arxiv.org/abs/1910.03771 and I guess a sentence like \"We would like to deeply thank the HuggingFace team for making T5 and Bert accessible to researcher by means of transformers [Citation]\" would be awesome :-)", "Thanks a lot @patrickvonplaten for looking into this model.\r\n\r\nSure, it will be our great pleasure to include this acknowledgement into our next paper version.\r\n\r\nLooking forward to hear good news from you soon.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "@patrickvonplaten any updates on implementing mesh Bert ?", "@agemagician - didn't find time yet sadly.... :-/ Hope to have a bit more time in ~2 weeks. Don't hesitate to ping me on it though ;-) \r\n", "Thanks, I will ping you after 2 weeks :)", "@patrickvonplaten Any update on this issue ?\r\nWe are over half way of finishing the training of a 2 Billion Bert model.\r\nWe are planing afterwards to train a 8 Billion Bert model, but we have to make sure that everything runs perfectly for the 2 Billion model using mesh tensorflow + huggingface.\r\n", "Having thought about this a bit more, we would have to add a new BertModel class for this. Given that this will be quite time-consuming (mesh tensorflow debugging) and that this is not an official and much-requested model, I don't think I'll be able to take time to add it. Sorry @agemagician! If it's very important for you, I think you will have to take a stab at it yourself (shouldn't be too difficult though)", "Thanks @patrickvonplaten for your consideration.\r\nIn this case, I will start debugging and I will make a pull request if I made it work.\r\n\r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=h1) Report\n> Merging [#6265](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9149f00d1a4650bafa7e1cd73e10398193c852c&el=desc) will **decrease** coverage by `0.14%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6265 +/- ##\n==========================================\n- Coverage 78.45% 78.31% -0.15% \n==========================================\n Files 146 146 \n Lines 26595 26596 +1 \n==========================================\n- Hits 20866 20829 -37 \n- Misses 5729 5767 +38 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6265/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `95.76% <100.00%> (+<0.01%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6265/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.40% <0.00%> (-34.39%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6265/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6265/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=footer). Last update [d9149f0...ad31ee8](https://codecov.io/gh/huggingface/transformers/pull/6265?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Multiple issues may be related to this.\r\n[My finetuned gpt2 model is taking wayy too long to generate samples, like 5-8 minutes] \r\nhttps://github.com/huggingface/transformers/issues/6173\r\n[[Benchmark] TFGPT2LMHeadModel is five times slower than GPT2LMHeadModel]\r\nhttps://github.com/huggingface/transformers/issues/5604\r\n[tensorflow2_gpt2 Slow speed]\r\nhttps://github.com/huggingface/transformers/issues/4634\r\n[In Tensorflow the serving is very slow]\r\nhttps://github.com/huggingface/transformers/issues/5341\r\n\r\nDo we plan to solve this problem with a higher priority? Thanks. @patrickvonplaten \r\n\r\nCan we add a new linear layer instead of using wte with matmul? Like `self.lm_head = nn.Linear(config.n_embd, config.vocab_size, bias=False)` in pytorch?\r\nSince tf.matmul in CPU seems quite slow and moreover we have a `transpose_b` in the current TF implementation. ", "Thanks a lot for posting the issue and linking everything together - this is extremely useful! I will try to take a deeper look into it early next week! ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "I met the same situation with the env info:\r\ntransformer version:4.12.5\r\ntensorflow-gpu:2.8.0\r\ntf-serving:2.6.0\r\nlinux, gpu-machine:P100, test script with the batch_size 1, max_len:20\r\n\r\ngoogle's bert inference takes about 12-13ms per query, but TF-Bert takes about 45~58ms with or without xla_cpu_compilation_enabled, 3-5x slower.\r\n\r\nHas the problem been solved? Or some ideas to improve the TF-Pretrained-Model performemce?" ]

[]

[]

[ "I'm getting the same issue. Curious how did you solve yours? @mt324010 ", "> I'm getting the same issue. Curious how did you solve yours? @mt324010\r\nI was using another embedding and the index was out of the given range. \r\nI think it's better to double check your code\r\n", "Yeah, you're right. I had problem with tokenizer length in my case.", "I am getting the same error. I am trying to update the token_type_embeddings by having 4 types instead of 2. \r\n\r\n```\r\nmodel.config.type_vocab_size = 4\r\n \r\ntoken_embed = nn.Embedding(model.config.type_vocab_size, model.config.hidden_size)\r\n\r\ntoken_embed.weight.data.uniform_(-1,1)\r\n \r\nmodel.bert.embeddings.token_type_embeddings = token_embed\r\n```\r\n\r\n\r\n@vdabravolski as for the tokenizer, I added special tokens and updated the length of the tokenizer and resized the model token_embeddings:\r\n```\r\n tokenizer.add_special_tokens(SPECIAL_TOKENS_DICT) \r\n \r\n model.resize_token_embeddings(len(tokenizer))\r\n```\r\n", "> I had problem with tokenizer length in my case. \r\n\r\nCould you elaborate on this? ", "Try removing/deleting the cached .lock files and run again\r\n", "I think one of the possible reasons is that your padding token for token_type_id is out of range. Say you have four extra token_type_ids, then ’pad‘ , 'cls' and 'unk' may follow your tokenizer setting. BERT uses a large number for pad(100 something), then if your token_type_embedding is initialized to be only 4 class, it will result in similar error. So you might increase your token type vocabulary to consider special tokens and manually set them to 0,1,2 etc. Hope it helps.\r\n", "I had not given my model the vocab size of my tokenizer when I initialized it, which gave me this error. Running the model on the CPU (as suggested here https://github.com/huggingface/transformers/issues/3090) gave me a better error message that let me figure this out, so that's a more general tip if you get this error I guess. ", "> Try removing/deleting the cached .lock files and run again\r\n\r\nThanks @manalabssas \r\nI'm getting the same issue. I try to delete all cache files, and it works.\r\nThanks for your sharing. ", "> > Try removing/deleting the cached .lock files and run again\r\n> \r\n> Thanks @manalabssas I'm getting the same issue. I try to delete all cache files, and it works. Thanks for your sharing.\r\n\r\nHello how did you delete all cache files ? I ma getting the same problem ? ", "I changed `return_token_type_ids` True->False in tokenizer\r\n```python\r\nreturn_token_type_ids=False\r\n```", "> I had not given my model the vocab size of my tokenizer when I initialized it, which gave me this error. Running the model on the CPU (as suggested here #3090) gave me a better error message that let me figure this out, so that's a more general tip if you get this error I guess.\r\n\r\nThis helped me solve my issue. I had initialized different versions of the `from_pretrained` with the tokenizer vs the model (e.g. `from_pretrained('bert-large-uncased')` and `from_pretrained('bert-large-cased')`).", "> I think one of the possible reasons is that your padding token for token_type_id is out of range. Say you have four extra token_type_ids, then ’pad‘ , 'cls' and 'unk' may follow your tokenizer setting. BERT uses a large number for pad(100 something), then if your token_type_embedding is initialized to be only 4 class, it will result in similar error. So you might increase your token type vocabulary to consider special tokens and manually set them to 0,1,2 etc. Hope it helps.\r\n\r\nYes, this is my case. I got it solved.", "> > I think one of the possible reasons is that your padding token for token_type_id is out of range. Say you have four extra token_type_ids, then ’pad‘ , 'cls' and 'unk' may follow your tokenizer setting. BERT uses a large number for pad(100 something), then if your token_type_embedding is initialized to be only 4 class, it will result in similar error. So you might increase your token type vocabulary to consider special tokens and manually set them to 0,1,2 etc. Hope it helps.\r\n> \r\n> Yes, this is my case. I got it solved.\r\n\r\nHi @tonywenuon , may I know how did you increase your token type vocabulary?", "> Try removing/deleting the cached .lock files and run again\r\n\r\nvery useful!~", "I solved it by reducing batch _ size.", "In my case, I had to use `device=\"cuda:8\"` to specify a GPU core other than the default `0`.", "I had the same error. But later I found it is because that the CUDA driver didn't load as expected. Restart the OS resolved this problem", "In my case, a simple **notebook restart** helped for some odd reason. " ]

[]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Thanks for this catch and detailed report. Feel free to chime in on the Linked pull request #6293 !\r\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=h1) Report\n> Merging [#6261](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9149f00d1a4650bafa7e1cd73e10398193c852c&el=desc) will **increase** coverage by `0.91%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6261 +/- ##\n==========================================\n+ Coverage 78.45% 79.37% +0.91% \n==========================================\n Files 146 146 \n Lines 26595 26595 \n==========================================\n+ Hits 20866 21109 +243 \n+ Misses 5729 5486 -243 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/optimization.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb24ucHk=) | `96.05% <ø> (ø)` | |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.40% <0.00%> (-34.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.87% <0.00%> (-23.44%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `66.66% <0.00%> (-23.43%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `71.21% <0.00%> (-12.88%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `79.19% <0.00%> (-7.27%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `96.75% <0.00%> (+73.16%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=footer). Last update [d9149f0...8f0d29c](https://codecov.io/gh/huggingface/transformers/pull/6261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Hmm, looks like `isort` and `flake` are in conflict with each other. `make style` reformatted the code to:\r\n```\r\n result = DictAttr({\"sequence_output\": sequence_output.numpy(), \"pooled_output\": pooled_output.numpy(),})\r\n```\r\nand flake complains:\r\n```\r\ntests/test_modeling_tf_albert.py:139:110: E231 missing whitespace after ','\r\n```\r\nif I add the desired by `flake` whitespace, `isort` removes it.\r\n\r\nHow do I resolve such conflict?\r\n\r\n**edit**: found a workaround, by removing the trailing comma:\r\n\r\n```\r\nperl -pi -e 's|\\),\\}\\)|)})|' tests/test_modeling_tf* templates/adding_a_new_model/tests/test_modeling_tf_xxx.py\r\n```", "\r\n\r\n99% of this PR has been facilitated by running:\r\n\r\n```\r\nperl -0777 -pi -e 's#self.parent.assertListEqual\\(\r\n[\\s\\n]*\r\nlist\\((result\\w*)\\[\" ([^\"]+) \"\\].(?:shape|size\\(\\))\\),[\\s\\n]+\\[ ( [^\\]]* ) \\],?\r\n[\\s\\n]*\r\n\\)\r\n#self.parent.assertEqual($1.$2.shape, ($3))#xmsg' tests/test*py templates/adding_a_new_model/tests/test_modeling_tf_xxx.py\r\n\r\nperl -0777 -pi -e 's#\r\nresult\\s=\\s\\{\r\n([^}]+)\r\n\\}\r\n#result = DictAttr({$1}) #xmsg' tests/test*py templates/adding_a_new_model/tests/test_modeling_tf_xxx.py\r\n\r\nperl -pi -e 's|^(from transformers.testing_utils import .*?)$|$1, DictAttr|' tests/test_modeling_tf_albert.py tests/test_modeling_tf_bert.py tests/test_modeling_tf_ctrl.py tests/test_modeling_tf_distilbert.py tests/test_modeling_tf_electra.py tests/test_modeling_tf_flaubert.py tests/test_modeling_tf_gpt2.py tests/test_modeling_tf_mobilebert.py tests/test_modeling_tf_openai_gpt.py tests/test_modeling_tf_roberta.py tests/test_modeling_tf_t5.py tests/test_modeling_tf_transfo_xl.py tests/test_modeling_tf_xlm.py tests/test_modeling_tf_xlnet.py test_modeling_transfo_xl.py templates/adding_a_new_model/tests/test_modeling_tf_xxx.py\r\n\r\nmake style\r\n# remove trailing comma that breaks flake\r\nperl -pi -e 's|\\),\\}\\)|)})|' tests/test_modeling_tf* templates/adding_a_new_model/tests/test_modeling_tf_xxx.py\r\n```", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=h1) Report\n> Merging [#6260](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0735def8e1200ed45a2c33a075bc1595b12ef56a&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6260 +/- ##\n=======================================\n Coverage 80.08% 80.08% \n=======================================\n Files 153 153 \n Lines 27984 27984 \n=======================================\n Hits 22412 22412 \n Misses 5572 5572 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6260/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.47% <0.00%> (-32.95%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6260/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.44% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6260/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `94.72% <0.00%> (+22.87%)` | :arrow_up: |\n| [src/transformers/tokenization\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6260/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `87.50% <0.00%> (+58.65%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=footer). Last update [0735def...d3380ba](https://codecov.io/gh/huggingface/transformers/pull/6260?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Hi @stas00. I'm in the process of changing all model outputs of TF models to the same as PyTorch and updated all the tests. This is in #6247 that I expect to merge today (once merge conflicts are handled and I've added the templates).\r\n\r\nCould you wait a tiny bit and then apply the same PERL commands you did in #6196 ?", "Oh, that's even better - yes, of course, I will wait, @sgugger! If you remember please ping me when this is done. Thank you! \r\n\r\nCould you also check on this one?\r\nhttps://github.com/huggingface/transformers/blob/master/tests/test_modeling_transfo_xl.py#L94\r\nIt's the only remaining torch test with `results` dict.", "For the slow test, we can use `outputs1[\"last_hidden_state\"]` and so forth in the asserts after. I went for the quickest fixes in the tests.", "> For the slow test, we can use `outputs1[\"last_hidden_state\"]` and so forth in the asserts after. I went for the quickest fixes in the tests.\r\n\r\nPart of this rewrite was replacing `results[\"key\"]` with `results.key` as specified. So this one would be different. There are two constructors in `test_modeling_transfo_xl.py` that do that. All other tests have or will follow the latter style once you finish your work and I will update mine. ", "The outputs PR has been merged, so pinging you @stas00 ", "I will rework this PR to match @sgugger changes.", "@sgugger, after your merge, these 3 tf tests are still using the old style it seems:\r\n```\r\nFAILED tests/test_modeling_tf_transfo_xl.py::TFTransfoXLModelTest::test_transfo_xl_lm_head - AttributeError: 'dict' object has no attribute 'lm_logits_1'\r\nFAILED tests/test_modeling_tf_transfo_xl.py::TFTransfoXLModelTest::test_transfo_xl_model - AttributeError: 'dict' object has no attribute 'hidden_states_1'\r\nFAILED tests/test_modeling_tf_xlnet.py::TFXLNetModelTest::test_xlnet_lm_head - AttributeError: 'dict' object has no attribute 'all_logits_1'\r\n```\r\nI reverted to the `[\"key\"]` style for these for now.", "> I guess we can deal with the 4 remaining tests (one PT, 3 TF) in a separate PR.\r\n\r\nYes. Could you please instruct me on how to proceed with those or will you take care of them?", "I think just using the result1/result2 in the assers instead of grouping everything in a dict should be fine.", "please re-run CI - unrelated failure - thank you.", "If there is any more cleanup you'd like to see send me the before and after code snippets." ]

[]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Any idea?", "You are correct. It will be fixed in the blenderbot PR if not sooner." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "> Another observation: while checkpointing, the model's training speed also increases considerably which is totally odd to what I have learned from gradient checkpointing. Is there any problem with the implementation? or have I done any part wrong?\r\n\r\nfrom torch docs\r\n> Checkpointing works by trading compute for memory. Rather than storing all intermediate activations of the entire computation graph for computing backward, the checkpointed part does not save intermediate activations, and instead recomputes them in backward pass. It can be applied on any part of a model.\r\n\r\nAs the mode; needs to recompute the activations during backward pass it adds up training time considerably.", "@patil-suraj Thx for your answer. I totally agree with you and, of course, the doc :). The problem is that while monitoring the training process, I see that the model's training **speed** increases considerably, resulting in faster training (decreasing training time) which is unconventional to the concept of Gradient Checkpointing. That's what made me skeptical about the code snippet (above) that I wrote to use gradient checkpointing. In addition, when comparing checkpointed with non-checkpointed model, I see quite different performance. I'm wondering if there is/are some other considerations that I need to take to make it work...\r\n\r\nWhat I expect with the checkpointed model: I expect that it adds up training time (i.e., lower training speed) due to the recomputation of activation functions during the backward pass, and achieve the same performance/scores as to the non-checkpointed model. ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=h1) Report\n> Merging [#6257](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d9149f00d1a4650bafa7e1cd73e10398193c852c&el=desc) will **increase** coverage by `0.42%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6257 +/- ##\n==========================================\n+ Coverage 78.45% 78.88% +0.42% \n==========================================\n Files 146 146 \n Lines 26595 26595 \n==========================================\n+ Hits 20866 20980 +114 \n+ Misses 5729 5615 -114 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX3hsbmV0LnB5) | `94.33% <ø> (ø)` | |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `68.14% <0.00%> (-25.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.87% <0.00%> (-23.44%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `85.21% <0.00%> (-1.26%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6257/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `96.75% <0.00%> (+73.16%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=footer). Last update [d9149f0...aa36993](https://codecov.io/gh/huggingface/transformers/pull/6257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Hey @Weilin37 , sorry to answer so late - this looks like a difficult bug. Let's start with this:\r\nCan you check if your code works on this branch: `try_if_works_for_longformer_mult_gpu` . The changes I did to the branch can be seen here: https://github.com/huggingface/transformers/pull/6607. Since the pooler is not needed for Sequence Classification it can simply be deleted.\r\n\r\nAll you have to do is:\r\n\r\n```git pull upstream && git checkout try_if_works_for_longformer_mult_gpu``` (assuming you named the official repo remote \"upstream\". Then it would be great if you can check your code again.\r\n\r\nLet me know if this helps.", "#6607 fixed the exception for me. Thanks!", "@ndronen - thanks for checking! @Weilin37 - can you confirm as well? ", "Hi, I think it works for me now too!", "Ok great, I think we should actually completely decouple Bert from Longformer to merge this into master. Will add it to projects", "I have a similar issue with XLNetForQuestionAnswering. @patrickvonplaten I saw your pull request (https://github.com/huggingface/transformers/pull/7272) but this is not fixed for XLNet and I wonder why? Could you please let me know?", "Hey @dheeraj7596 - could you please open a new issue for your problem?" ]