Datasets:

---

DanielPFlorian

/

Transformers-Github-Issues

like 0

[]

[]

[]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "From what I can see, test failures are because of the usage of `typing.Literal`, which is available starting on Python3.8.\r\n\r\nThe `typing_extensions` (from mypy devs) package backports such features into older versions of Python. If it's ok with the devs to add it to `setup.py`, I can do so. Otherwise, we can make the annotations less specific as to avoid `Literal` types.", "I'd avoid adding a new dependency or pinning us on python 3.8. I'd also avoid using `overload` type annotations to keep the code readable. I think we can have less specific type annotations, and detail what the kwargs are if needed to be able to type-annotate them (which will be useful for tab-completion in an IDE anyways).\r\n\r\nFor instance, the first:\r\n```\r\n@overload\r\n @classmethod\r\n def from_pretrained(\r\n cls,\r\n pretrained_model_name_or_path: str,\r\n *,\r\n return_unused_kwargs: Literal[True],\r\n cache_dir: Optional[str] = None,\r\n force_download: bool = False,\r\n resume_download: bool = False,\r\n proxies: Optional[Dict[str, str]] = None,\r\n **kwargs: Any\r\n ) -> Tuple[PretrainedConfig, Dict[str, str]]:\r\n ...\r\n\r\n @overload\r\n @classmethod\r\n def from_pretrained(\r\n cls,\r\n pretrained_model_name_or_path: str,\r\n *,\r\n return_unused_kwargs: Literal[False] = False,\r\n cache_dir: Optional[str] = None,\r\n force_download: bool = False,\r\n resume_download: bool = False,\r\n proxies: Optional[Dict[str, str]] = None,\r\n **kwargs: Any\r\n ) -> PretrainedConfig:\r\n ...\r\n```\r\ncould be written like this in the main definition:\r\n```\r\ndef from_pretrained(\r\n cls,\r\n pretrained_model_name_or_path: str,\r\n *,\r\n return_unused_kwargs: bool = False,\r\n cache_dir: Optional[str] = None,\r\n force_download: bool = False,\r\n resume_download: bool = False,\r\n proxies: Optional[Dict[str, str]] = None,\r\n **kwargs: Any\r\n ) -> Union[PretrainedConfig, Tuple[PretrainedConfig, Dict[str, str]]]:\r\n```\r\nand then the body of the function can be updated.", "Sounds good. I'll get around to removing usages of `Literal` and `overload` tomorrow.", "Thinking a bit more about this, if you really need some types in `typing_extensions`, we can add this as a dep.", "The types in this PR that need `typing_extensions` in py<3.8 are `Literal` and `Protocol`.\r\n1. There's only one usage of `Literal` in the PR that is not in conjunction with `@overload`. The other usages of `Literal` are to specify overloading signatures. If we avoid `@overload`, the use of `Literal` is much less justified.\r\n2. `Protocol` was used to replace\r\n```py\r\nDataClass = NewType(\"DataClass\", Any)\r\nDataClassType = NewType(\"DataClassType\", Any)\r\n```\r\nwith\r\n```py\r\nclass DataClassProtocol(Protocol):\r\n def __init__(self, *args: Any, **kwargs: Any) -> None: pass\r\n# And DataClassType would be replaced with Type[DataClassProtocol] in the rest of the code\r\n```\r\nThe benefit of this is that `mypy` complains that dataclasses are in fact not compatible with `DataClass` when using the first definition. \r\n\r\nI really like static type checking, so I'm for adding `typing_extensions`, but do the devs think the above usages are worth it, is the question ...", "Personally I'd love to use `Literal`s and I'd be in favor of adding the dependency just for this, but I'll let others chime in.\r\n\r\nFor the `DataClassProtocol`, I'm not convinced, given that this type won't lead to a lot of inference type checking anyways... I feel like the current `DataClass` and `DataClassType` are pretty much just documentation.", "Slightly off topic, but @davidatbu do you have experience on Pyright vs. mypy? (in particular in the context of vscode)\r\n\r\nI've been wanting to dig in for a long time.", "@julien-c , \r\n\r\n> For the DataClassProtocol, I'm not convinced, given that this type won't lead to a lot of inference type checking anyways... I feel like the current DataClass and DataClassType are pretty much just documentation.\r\n\r\nYes, this won't lead to inference of the actual dataclass passed in the current mypy implementation(it might if mypy ever supports [variadic generics](https://github.com/python/typing/issues/193), and we make `HfArgumentParser` generic). However, using `DataClass` as previously defined leads mypy to *raise errors* about passing perfectly legal dataclasses to `HfArgumentParser`. Using `DataClassProtocol` doesn't. I use mypy a lot, so I might be the only one that this bothers.\r\n\r\n\r\n> Do you have experience on Pyright vs. mypy? (in particular in the context of vscode)\r\n\r\nI've used only mypy so far. (And I find it so helpful that I'm willing to create PRs for type annotation :) )Also, I use Vim with plugins, so wouldn't be able to comment on the vscode aspect either.\r\n\r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "@davidatbu I noticed you referenced [python/typing#193](https://github.com/python/typing/issues/193) on variadic generics in this thread. Heads up that we've been working on a draft of a PEP for this in [PEP 646](https://www.python.org/dev/peps/pep-0646/). If this is something you still care about, take a read and let us know any feedback in [this thread](https://mail.python.org/archives/list/[email protected]/thread/WFV5K2LK3LFQSO63X2KUOCK3VVLAQ374/) in typing-sig. Thanks!" ]

[]

[]

[ "From previous PR:\r\n\r\n\r\n\r\n**LysandreJik 4 hours ago Member**\r\nShouldn't the bert-based-case and bertBasedCase be bert-base-cased and bertBaseCased?\r\n\r\nBy the way, why is this model specific? Are we using these values somewhere?\r\n\r\n\r\n\r\n**zcain117 19 minutes ago Author**\r\nFixed that typo.\r\n\r\nThe local bertBasedCase is just a name of that jsonnet variable, it just needs to be a unique string but several punctuation marks are not allowed in variable names. We recommend 1 variable like this per test. On our team we have 1 file per \"family\" of tests, e.g. 1 file for pytorch resnet50 where the file contains [short test, long test] X [v2-8 TPU, v3-8 TPU, v100 GPU(s)] for the same model on the same ML framework.\r\n\r\nThe modelName and frameworkPrefix are just used in generating the name of the GKE job. For example, a recent run was named: hf-bert-based-case-example-v3-8-vtgrj. Future runs will look like hf-bert-base-cased-example-v3-8-xxxxx", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=h1) Report\n> Merging [#6219](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/6695450a23545bc9d5416f39ab39609c7811c653&el=desc) will **decrease** coverage by `0.10%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6219 +/- ##\n==========================================\n- Coverage 78.54% 78.44% -0.11% \n==========================================\n Files 148 146 -2 \n Lines 27196 26586 -610 \n==========================================\n- Hits 21361 20855 -506 \n+ Misses 5835 5731 -104 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.51%)` | :arrow_down: |\n| [src/transformers/trainer\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3V0aWxzLnB5) | `85.71% <0.00%> (-14.29%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9hbGJlcnQucHk=) | `76.73% <0.00%> (-5.02%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.05% <0.00%> (-2.14%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `23.58% <0.00%> (-0.97%)` | :arrow_down: |\n| [src/transformers/modeling\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbGVjdHJhLnB5) | `81.55% <0.00%> (-0.58%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.36% <0.00%> (-0.43%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.97% <0.00%> (-0.33%)` | :arrow_down: |\n| [src/transformers/modeling\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19yZWZvcm1lci5weQ==) | `95.49% <0.00%> (-0.20%)` | :arrow_down: |\n| [src/transformers/training\\_args.py](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmluZ19hcmdzLnB5) | `80.19% <0.00%> (-0.20%)` | :arrow_down: |\n| ... and [34 more](https://codecov.io/gh/huggingface/transformers/pull/6219/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=footer). Last update [6695450...6e4a41b](https://codecov.io/gh/huggingface/transformers/pull/6219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "@LysandreJik let me know if there's anything else you can think of here" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "My main reason for not using PyTorch's `max_memory_resevered` function is that there is some GPU memory that is used, but not accounted for.", "> One can see that the difference is always 856 MB (besides one exception where it is 868 MB)\r\n\r\nI won't be surprised if the delta of 856MB that you reported - is the size of cudnn kernel (loaded). Could you please run a test to measure `torch.ones((1, 1)).cuda()` - if that's what you get then pytorch's tool should work just fine and w/o any complicated polling or potential conflicts - say 2 tests using the benchmarking framework happen to run at the same time on the same GPU - won't it fail in this scenario?\r\n\r\nI have and old Titan X card so it's around 600MB, the novel Tesla T4 is ~1GB, so your being 856MB fits into the ballpark of it.\r\n", "Yeah taking your code: \r\n\r\n```python\r\n#!/usr/bin/env python3\r\nfrom transformers import is_torch_available\r\nimport torch\r\n\r\nif is_torch_available():\r\n from transformers import (\r\n PyTorchBenchmarkArguments,\r\n PyTorchBenchmark\r\n )\r\n\r\nMODEL_ID = \"facebook/bart-base\"\r\nss = 8\r\nbs = 1\r\n\r\nbenchmark_args = PyTorchBenchmarkArguments(\r\n models=[MODEL_ID],\r\n training=False,\r\n no_inference=False,\r\n sequence_lengths=[ss],\r\n batch_sizes=[bs],\r\n no_multi_process=False,\r\n no_cuda=False,\r\n no_speed=False,\r\n)\r\nbenchmark = PyTorchBenchmark(benchmark_args)\r\n\r\n# measure cudnn kernel memory consumption\r\n# now we have a baseline that can be subtracted from all the other usages\r\n\r\n\r\ndef run_cuda_kernel_load():\r\n torch.ones((1, 1)).cuda()\r\n\r\n\r\nmem, _ = benchmark._measure_memory(run_cuda_kernel_load)\r\nmem_load = mem.bytes\r\nprint(f\"Mem on load: {mem_load >> 20}MB\")\r\n```\r\n\r\ngives me a result of 796 MB -> so we still have 60MB which is different from CUDA/CUDNN kernel loading + PyTorch's `max_memory_reseverd` vs. `py3nvml` that are not accounted for, but this is negligible IMO .", "So we have two options here:\r\n\r\n1) Leave the functionality as it is and add: \r\n\r\n```python\r\ndef run_cuda_kernel_load():\r\n torch.ones((1, 1)).cuda()\r\n```\r\nto measure CUDA/CUDNN kernel loading. \r\n\r\nThe advantage is that we can leave the same functionality for TF\r\n\r\n2) Change to `torch.cuda.max_memory_reserved` + `py3nvml` or another tool to measure CUDA/CUDNN kernel loading. \r\nThis option seems a bit safer and this way multiple processes could be run on the same GPU. Because measuring CUDA/CUDNN kernel loading cannot be done with `torch.cuda.max_memory_reserved` and relies on `py3nvml` or similar, I think we would run into the same problem here in that the result will not be correct if other processes run on the GPU. Or do you know how this can be measured without conflicting with another measurement on the same GPU at the same time? \r\n\r\n\r\nI guess 2) is the better option though -> it seems safer and 2 measurements can be done at once. Maybe we should also only return this result as a default and optionally let the user decide if he / she wants to return the MB required to load CUDA/CUDNN. In the graphs on the model pages we would then include the MB required to load the CUDA/CUDNN kernel.\r\n\r\nAfter thinking a bit more about RAM measurements when running on GPU - I think it makes actually more sense to only do this in combination with the new torch profiler: https://pytorch.org/docs/stable/autograd.html#profiler . I tried out the profiler and it gives very in-detail measurements for both CPU and GPU time and memory. For me this profiler is very useful for analysis of the code, e.g. which layer consumes how much memory / time, how much time / gpu is spent on CPU / GPU\r\n\r\nSo overall, IMO it would be nice to have 2 use cases: \r\n\r\na) Run peak memory usage (either on GPU or CPU) -> get one number for CPU, get one number for GPU (default to `torch.cuda.max_memory_reserved` and optionally add GPU CUDA/CUDNN kernel loading mem requirement). Here, I don't think we need to report CPU mem usage when model is run on GPU IMO. This would be very useful for ML engineers that want to use `transformers` in production.\r\n\r\nb) Do in detail analysis -> run the new torch profiler: https://pytorch.org/docs/stable/autograd.html#profiler. For PyTorch this can replace the line-by-line tracing completely IMO and cover the case when the user wants to track CPU *as well as* GPU usage when running on GPU. We would require PyTorch 1.6 for this, but this is ok IMO. This use case would also be more interesting for researcher and \"experts\" and less more ML \"engineers\" with less research background. \r\n\r\nI think the default should be to run only a), where as the user could optionally turn on b) to in-depth analysis.\r\n\r\nSince TF does not (yet) have these tools, we will still have to rely on what we currently have for TF, but for PyTorch I'm happy to switch more to actual \"Pytorch\" tools to track memory since it seems to give very similar/equal results as `py3nvml`.\r\n\r\nAlso looping in @LysandreJik @julien-c and @sshleifer here to hear their opinions on that.\r\n", "Same thing goes for `speed` I guess:\r\n\r\na) Leave functionality as it is for general overall speed (maybe change 30 averaging to 10 + some warmup) -> return one number\r\nb) Use PyTorch profiler for in-detail profiling of CPU / GPU time. User can optionally turn this on.\r\n\r\n", "BTW, the new profiler can be run like this: \r\n\r\n```python \r\n!/usr/bin/env python3\r\nfrom transformers import is_torch_available\r\nimport torch\r\n\r\nif is_torch_available():\r\n from transformers import (\r\n BertModel\r\n )\r\n\r\ndef run_model():\r\n model = BertModel.from_pretrained(\"bert-base-cased\")\r\n model.cuda()\r\n outputs = model(torch.tensor(32 * [128 * [0]]).cuda())\r\n return outputs\r\n\r\n\r\nwith torch.autograd.profiler.profile(use_cuda=True, profile_memory=True) as prof:\r\n run_model()\r\n\r\nprint(prof.table())\r\n```", "> gives me a result of 796 MB -> so we still have 60MB which is different from CUDA/CUDNN kernel loading + PyTorch's `max_memory_reseverd` vs. `py3nvml` that are not accounted for, but this is negligible IMO .\r\n\r\nAs I mentioned earlier, I'm not sure \"reserved\" is the right function, as it involves caching. Try `torch.cuda.memory_allocated` (and for peak `torch.cuda.max_memory_allocated`) instead.", "I'd say option #2, plus the code from option #1, so a user can still know the overhead of the cudnn kernel load.\r\n\r\nThank you for mentioning the profiler and the sample code - let me study and experiment with it and then I will be able to comment on your suggestions.", "> Same thing goes for `speed` I guess:\r\n> \r\n> a) Leave functionality as it is for general overall speed (maybe change 30 averaging to 10 + some warmup) -> return one number\r\n\r\nPlus, I'd suggest to make `n_repeats` configurable, with a sensible default. e.g. when developing code I'd want to run `n_repeats`=1 - e.g. currently a large model takes a really long time to `__init__` when it's run 30 times.", "Wrt returns, as we discussed, my suggestion is to have a full API that returns rich outputs, and then design shortcut wrappers that return just single specific bits, so that it makes test writing much less cluttered. i.e., removing a need for writing code like this as we have to do now:\r\n```\r\nmem, _ = benchmark._measure_memory(func)\r\nmem = mem.bytes\r\n```\r\nit should be possible to do:\r\n```\r\nmem = benchmark._measure_memory_bytes(func)\r\n```\r\nno unpacking, no retrieving.\r\n\r\n`_measure_memory_bytes` is just a possible name - we could think of something else.", "Ah, one more thing we discussed - we need to return general RAM when the benchmark is run on GPU. Memory leaks mainly happen in general RAM. So the main API should include measuring and returning this data too, and flags/shortcuts to enable/disable the calculation and retrieval of this data.", "2 more things to consider:\r\n\r\n1. Should we control these:\r\n```\r\ntorch.backends.cudnn.benchmark = True\r\ntorch.backends.cudnn.enabled = True\r\n```\r\nas these settings should impact peformance\r\n\r\n2. allow a fixed seed arg?", "> BTW, the new profiler can be run like this:\r\n\r\nIt appears that profiler has been around for quite some time. Of course, its table dump is huge and is difficult to work with, and there are almost no examples of the profiler use out there.\r\n\r\nHere is what I came up with so far:\r\n\r\n```\r\nimport torch\r\nfrom transformers import BertModel\r\n\r\ndef run_model():\r\n model = BertModel.from_pretrained(\"bert-base-cased\")\r\n model.cuda()\r\n model(torch.tensor(32 * [128 * [0]]).cuda())\r\n\r\nwith torch.autograd.profiler.profile(use_cuda=True, profile_memory=True) as prof:\r\n _=run_model()\r\n\r\ncpu_time = sum([e.cpu_time_total for e in prof.key_averages()]) / 1000\r\ncuda_time = sum([e.cuda_time_total for e in prof.key_averages()]) / 1000\r\ncpu_mem = sum([e.cpu_memory_usage for e in prof.key_averages()]) >> 20\r\ncuda_mem = sum([e.cuda_memory_usage for e in prof.key_averages()]) >> 20 \r\n\r\nprint(f\"Device | Mem MB | Speed ms\")\r\nprint(f\"CPU | { cpu_mem:8} | {cpu_time:8.2f}\")\r\nprint(f\"GPU | {cuda_mem:8} | {cuda_time:8.2f}\")\r\n```\r\ngives\r\n```\r\nDevice | Mem MB | Speed ms\r\nCPU | 1 | 1835.97\r\nGPU | 13258 | 1846.77\r\n```\r\nI'm not sure yet whether any of this is correct - need to correlate with our profiling functions.\r\n\r\nFigured out the self vs. total (the profiler results has a set of `self_` attributes, in addition to `total_`) :\r\n* Total CPU: calls to the function, and functions called by the function,\r\n* Self CPU: calls to the function in the selected time range, excluding functions called by the function.\r\n\r\nSo we only care about total then.\r\n\r\nIf I add for comparison the measurements from our benchmark tools, I get mostly very different results - I run these on T4, unlike the ones above that were run on TitanX:\r\n\r\n```\r\nDevice: Tesla T4\r\nModel: bert-base-cased\r\n\r\ninit\r\nDevice | Mem MB | Speed ms\r\nCPU | 500 | 3339.74\r\nGPU | 0 | 3339.54\r\nOurs | 914 | 3289.81\r\n\r\nfwd\r\nDevice | Mem MB | Speed ms\r\nCPU | 0 | 97.47\r\nGPU | 27 | 105.76\r\nOurs | 920 | 12.34\r\n\r\nfwd-bwd\r\nDevice | Mem MB | Speed ms\r\nCPU | 0 | 193.97\r\nGPU | 1723 | 211.86\r\nOurs | 1540 | 24.95\r\n```\r\nThe last row labelled as **Ours** is benchmark's gpu `measure_memory` + `measure_speed` results. And the first two rows are from `torch.autograd.profiler.profile` as shown before.\r\n\r\nAs you can see only speed measurements for `init` match, the rest is dramatically different... \r\n\r\nIf anybody wants to continue experimenting, this is a WIP colab nb:\r\nhttps://colab.research.google.com/drive/1i-_lxUCuuTKn5Nhe4ENMJd5RgHVeMSZP?usp=sharing\r\n\r\nIt has a bunch of other experiments, but if you run all - just watch the results of the last cell. Warning: the code is unpolished.\r\n\r\n", "One additional potential caveat for speed measurements is async code returning too early?\r\ni.e. needing to run: `torch.cuda.synchronize()` before finishing the speed measurements? Most likely since it's a separate process it's of no need.", "Thanks for posting this! Yes, I think we should maybe stick to our code for now regarding the total time and memory. \r\nA while ago, @LysandreJik made some speed expeirements: https://docs.google.com/spreadsheets/d/1sryqufw2D0XlUH4sq3e9Wnxu5EAQkaohzrJbd5HdQ_w/edit which match the results given my `PyTorchBenchmark` very nicely, so I'm quite positive that the speed measurements are correct.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=h1) Report\n> Merging [#6217](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/06f1692b023a701ab2bb443fa4f0bdd58c6bd234&el=desc) will **decrease** coverage by `0.64%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6217 +/- ##\n==========================================\n- Coverage 79.53% 78.88% -0.65% \n==========================================\n Files 146 146 \n Lines 26586 26586 \n==========================================\n- Hits 21145 20973 -172 \n- Misses 5441 5613 +172 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_outputs.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vdXRwdXRzLnB5) | `100.00% <ø> (ø)` | |\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `68.14% <0.00%> (-25.67%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `57.65% <0.00%> (+4.50%)` | :arrow_up: |\n| [src/transformers/tokenization\\_ctrl.py](https://codecov.io/gh/huggingface/transformers/pull/6217/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fY3RybC5weQ==) | `96.11% <0.00%> (+17.47%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=footer). Last update [b6b2f22...8a7c591](https://codecov.io/gh/huggingface/transformers/pull/6217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I'd personally leave the first two tricks (users may have their custom script for padding and BERT is not good at language generation). For the third, as discussed, I agree.\r\nThe docstrings of `BaseModelOutputWithPooling` should be changed accordingly, but I can take care of that in a separate PR.", "@sgugger I've restored tips no.1 and updated tips no.2. Also took care of `BaseModelOutputWithPooling`." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=h1) Report\n> Merging [#6216](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/06f1692b023a701ab2bb443fa4f0bdd58c6bd234&el=desc) will **decrease** coverage by `0.25%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6216 +/- ##\n==========================================\n- Coverage 79.53% 79.27% -0.26% \n==========================================\n Files 146 146 \n Lines 26586 26586 \n==========================================\n- Hits 21145 21076 -69 \n- Misses 5441 5510 +69 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZ3B0Mi5weQ==) | `97.22% <ø> (ø)` | |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <ø> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.43% <0.00%> (-7.42%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `90.86% <0.00%> (-0.46%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.00% <0.00%> (-0.41%)` | :arrow_down: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `57.65% <0.00%> (+4.50%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/huggingface/transformers/pull/6216/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=footer). Last update [b6b2f22...ba68ac7](https://codecov.io/gh/huggingface/transformers/pull/6216?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "I've just openned a pull request that handles this for GPT2TokenizerFast and RobertaTokenizerFast", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=h1) Report\n> Merging [#6214](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9996f697e3ed7a0d6fe4348953723ad6b9d51477&el=desc) will **decrease** coverage by `0.17%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6214 +/- ##\n==========================================\n- Coverage 79.66% 79.48% -0.18% \n==========================================\n Files 146 146 \n Lines 26582 26584 +2 \n==========================================\n- Hits 21176 21131 -45 \n- Misses 5406 5453 +47 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl90NS5weQ==) | `90.95% <100.00%> (+0.03%)` | :arrow_up: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `68.14% <0.00%> (-25.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.05% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+1.25%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6214/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=footer). Last update [9996f69...30e2c28](https://codecov.io/gh/huggingface/transformers/pull/6214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=h1) Report\n> Merging [#6213](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/9996f697e3ed7a0d6fe4348953723ad6b9d51477&el=desc) will **decrease** coverage by `0.38%`.\n> The diff coverage is `50.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6213 +/- ##\n==========================================\n- Coverage 79.66% 79.27% -0.39% \n==========================================\n Files 146 146 \n Lines 26582 26583 +1 \n==========================================\n- Hits 21176 21075 -101 \n- Misses 5406 5508 +102 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/data/data\\_collator.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL2RhdGFfY29sbGF0b3IucHk=) | `96.58% <50.00%> (-0.84%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.40% <0.00%> (-34.39%)` | :arrow_down: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `76.71% <0.00%> (-21.92%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `86.43% <0.00%> (-7.42%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `38.73% <0.00%> (-3.76%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_fast.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfZmFzdC5weQ==) | `92.14% <0.00%> (-2.15%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `82.57% <0.00%> (-1.52%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `90.86% <0.00%> (-0.46%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.00% <0.00%> (-0.41%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.05% <0.00%> (-0.26%)` | :arrow_down: |\n| ... and [3 more](https://codecov.io/gh/huggingface/transformers/pull/6213/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=footer). Last update [9996f69...a0d4291](https://codecov.io/gh/huggingface/transformers/pull/6213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Thanks @sgugger for theses helpful suggestions!. Will keep these in mind for future PRs.", "@sgugger , can you help me with the build_doc failure ? Thanks! ", "Fixed, you needed to have the beginning of the docstrings on a new line for sphinx to understand the indentation.", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=h1) Report\n> Merging [#6212](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/8edfaaa81b9995cedea2f8805e4c18c2b6cb5bfc&el=desc) will **increase** coverage by `0.05%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6212 +/- ##\n==========================================\n+ Coverage 78.29% 78.35% +0.05% \n==========================================\n Files 146 146 \n Lines 26607 26619 +12 \n==========================================\n+ Hits 20832 20856 +24 \n+ Misses 5775 5763 -12 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `96.38% <100.00%> (+0.61%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `23.38% <0.00%> (-73.39%)` | :arrow_down: |\n| [src/transformers/data/processors/utils.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvdXRpbHMucHk=) | `27.63% <0.00%> (+1.31%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `90.09% <0.00%> (+1.80%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+2.25%)` | :arrow_up: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `98.63% <0.00%> (+2.73%)` | :arrow_up: |\n| [src/transformers/training\\_args.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmluZ19hcmdzLnB5) | `81.00% <0.00%> (+14.00%)` | :arrow_up: |\n| [src/transformers/data/processors/glue.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvZ2x1ZS5weQ==) | `49.09% <0.00%> (+17.09%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.32% <0.00%> (+23.67%)` | :arrow_up: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.14% <0.00%> (+24.04%)` | :arrow_up: |\n| ... and [5 more](https://codecov.io/gh/huggingface/transformers/pull/6212/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=footer). Last update [8edfaaa...b05ee8f](https://codecov.io/gh/huggingface/transformers/pull/6212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "> Fixed, you needed to have the beginning of the docstrings on a new line for sphinx to understand the indentation.\r\n\r\nThanks @sgugger !", "Hi @LysandreJik \r\n> and not the fast tokenizer, is there a reason for that?\r\n\r\nNo, just forgot to add that.\r\n\r\nUpstream will be useful but we will need handle few cases differently for each seq2seq model i.e in case of t5 we manually need to add the deocder_start_token_id as T5 don't have a `bos` token. Also `eos' needs to be added manually. In case of mBart, it needs the language code as prefix token etc. And also AFAIK lot of people seem to be unfamiliar with the processors API", "hi @sshleifer , @LysandreJik any update ?", "@sshleifer updated the docs.", "@LysandreJik I will add this for fast tokenizer too once this PR is merged.", "Sounds good!", "@LysandreJik , doc error is fixed, not sure if current failure is related to this PR." ]

[]

[]

[ "Hi @antocapp thank you for reporting this. ignore index (-100) shouldn't be set when `pad_token_id` is `None`, which is the case with GPT-2 ", "Hi @patil-suraj , thanks for the answer! Where should I set this parameter?\r\n\r\nedit: Never mind, just saw the fix you merged. Thanks!" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "~Someone mentioned that it could be due to the label indices being swapped for Roberta, but it seems there is already some [code](https://github.com/huggingface/transformers/blob/57eb1cb68d1c567b25ac256444e5c1a77b8817a7/src/transformers/data/datasets/glue.py#L100) to deal with that.~ Tested Roberta and it works fine.", "Tried running `run_xnli.py` with `xlm-roberta-base` and got this error (seems like it could be related?):\r\n```\r\n08/06/2020 06:12:56 - INFO - transformers.data.processors.glue - *** Example ***\r\n08/06/2020 06:12:56 - INFO - transformers.data.processors.glue - guid: train-5\r\n08/06/2020 06:12:56 - INFO - transformers.data.processors.glue - features: InputFeatures(input_ids=[0, 152725, 17, 14192, 398, 2367, 21208, 2174, 398, 738, 27167, 3060, 111, 8382, 69686, 148100, 17, 831, 1957, 15400, 5036, 398, 3714, 1836, 242, 107, 20949, 1257, 23, 70, 75281, 15437, 37457, 2, 2, 581, 69686, 148100, 765, 10, 37457, 111, 112034, 6, 5, 2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1], attention_mask=[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], token_type_ids=None, label=2)\r\n08/06/2020 06:12:56 - INFO - __main__ - Saving features into cached file /export/data/cached_train_xlm-roberta-base_128_xnli_en\r\nTraceback (most recent call last):\r\n File \"transformers/examples/text-classification/run_xnli.py\", line 617, in <module>\r\n main()\r\n File \"transformers/examples/text-classification/run_xnli.py\", line 570, in main\r\n train_dataset = load_and_cache_examples(args, args.task_name, tokenizer, evaluate=False)\r\n File \"transformers/examples/text-classification/run_xnli.py\", line 343, in load_and_cache_examples\r\n all_token_type_ids = torch.tensor([f.token_type_ids for f in features], dtype=torch.long)\r\nTypeError: an integer is required (got type NoneType)\r\n```\r\n\r\n@LysandreJik any idea what could be going wrong with XLM-R?", "I don't think XLM-R is handled by the XLNI script. We should update it to the new trainer API and make these few lines model-agnostic.\r\n\r\nhttps://github.com/huggingface/transformers/blob/45e26125de1b9fbae46837856b1f518a4b56eb65/examples/text-classification/run_xnli.py#L269-L273", "I see, any idea what's going on with the GLUE/MNLI script? It seems to be using the new trainer API.", "`run_pl_glue.py` has a similar issue in the dataloader.\r\n```\r\n File \"/export/multilingual-morpheus-analysis/transformers/examples/text-classification/lightning_base.py\", line 155, in setup\r\n dataloader = self.get_dataloader(\"train\", train_batch_size)\r\n File \"text-classification/run_pl_glue.py\", line 89, in get_dataloader\r\n all_token_type_ids = torch.tensor([f.token_type_ids for f in features], dtype=torch.long)\r\nTypeError: an integer is required (got type NoneType)\r\n```", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "@samsontmr\r\nHi, i have the same problem with `xlm-roberta-large` on MNLI using the official script. `xlm-roberta-large` has extremely low accuracy. any suggestion?" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "@aiscientist \r\nWhy would you need to use `model.fit()` method? I think it is a more low level way to train your model. There's an easy way to train HuggingFace models with `TFTrainer`. All you need to do, is to initialize pretrained config, tokenizer and model, create your own Dataset class for NER data, and just pass it to the trainer. It will do all the rest.", "> @aiscientist\r\n> Why would you need to use `model.fit()` method? I think it is a more low level way to train your model. There's an easy way to train HuggingFace models with `TFTrainer`. All you need to do, is to initialize pretrained config, tokenizer and model, create your own Dataset class for NER data, and just pass it to the trainer. It will do all the rest.\r\n\r\nYes, I need to finish this job using model.fit() following from the TensorFlow guideline (Like Keras Style), but for NER task it's kinda hard to manage loss because of model.fit(). Using Pytorch is easier but, I need to use model.fit for this task because of several reasons. I just want to know that it is possible to use TF Token Classifier on model.fit(). If not, I need to discuss with my co-workers and find another way to do it.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Closing in favor of #6214 " ]

[]

[ { "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "site_admin": false } ]

[ "Hey!\r\n\r\nSorry for the inconvenience, there are actually some issues with saved model, but we are currently working on several fix in this PR https://github.com/huggingface/transformers/pull/5468", "Thanks for quick response!\r\nWill wait for this PR to complete :-) ", "The PR has been merged in master, can you retry and let us know if it is really fixed please? Otherwise I will work on it ^^", "Just pulled the latest code from master & now the SavedModel export is working fine for Electra 👍. \r\nThanks a lot for your quick help!\r\nClosing the issue now.", "@nirajkale Hi, i find ur model's: ahotrod/electra_large_discriminator_squad2_512\"\". Is this model a finetune model, i mean you already used electra_large to finetune a model with your task right. thanks for your reply." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=h1) Report\n> Merging [#6205](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/82a0e2b67ec94d28b20e24b3393644002bbd0d4b&el=desc) will **increase** coverage by `0.07%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6205 +/- ##\n==========================================\n+ Coverage 79.65% 79.73% +0.07% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n+ Hits 21194 21214 +20 \n+ Misses 5413 5393 -20 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6205/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6205/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `81.70% <0.00%> (+1.00%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6205/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=footer). Last update [82a0e2b...f39a67f](https://codecov.io/gh/huggingface/transformers/pull/6205?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null }, { "id": 2139563322, "node_id": "MDU6TGFiZWwyMTM5NTYzMzIy", "url": "https://api.github.com/repos/huggingface/transformers/labels/cleanup", "name": "cleanup", "color": "e7fc49", "default": false, "description": "" } ]

[]

[ "I will experiment. Thank you!\r\n", "See: https://github.com/huggingface/transformers/pull/6430", "So I guess we can close this one, since the experiment wasn't accepted.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "I have this issue too, reported to pl https://github.com/PyTorchLightning/pytorch-lightning/issues/2673 \r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Hi - it looks like the memory blowup occurs during beam search (presumably during eval).\r\n\r\nIn `_generative_step` in `fine_tune.py`, feel free to play around with the `num_beams` parameter in the `self.model.generate` call. I can confirm that explicitly setting `num_beams=1` works on a V100 16GB. I believe the default is 5. beam search is very memory & computation intensive. Maybe for your final model evaluations, you can find a bigger GPU or just do on CPU. Greedy decoding should be OK during model development.\r\n\r\nAlso, if you look at the available distilled BART models (https://huggingface.co/sshleifer/distilbart-xsum-12-1), you'll see some options with fewer params than distilbart-cnn-12-6 (i.e., distilbart-cnn-12-1)\r\n\r\nplease let me know if this works!", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=h1) Report\n> Merging [#6201](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/82a0e2b67ec94d28b20e24b3393644002bbd0d4b&el=desc) will **decrease** coverage by `0.06%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6201 +/- ##\n==========================================\n- Coverage 79.65% 79.58% -0.07% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n- Hits 21194 21176 -18 \n- Misses 5413 5431 +18 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.18% <0.00%> (-34.62%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/tokenization\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZ3B0Mi5weQ==) | `87.50% <0.00%> (-9.73%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.55% <0.00%> (-0.29%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+5.76%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6201/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=footer). Last update [82a0e2b...e752ac3](https://codecov.io/gh/huggingface/transformers/pull/6201?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=h1) Report\n> Merging [#6198](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/82a0e2b67ec94d28b20e24b3393644002bbd0d4b&el=desc) will **decrease** coverage by `0.80%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6198 +/- ##\n==========================================\n- Coverage 79.65% 78.85% -0.81% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n- Hits 21194 20981 -213 \n- Misses 5413 5626 +213 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6198/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6198/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.18% <0.00%> (-34.62%)` | :arrow_down: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6198/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `68.14% <0.00%> (-25.67%)` | :arrow_down: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6198/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6198/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=footer). Last update [82a0e2b...937eea4](https://codecov.io/gh/huggingface/transformers/pull/6198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=h1) Report\n> Merging [#6196](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/82a0e2b67ec94d28b20e24b3393644002bbd0d4b&el=desc) will **decrease** coverage by `1.15%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6196 +/- ##\n==========================================\n- Coverage 79.65% 78.49% -1.16% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n- Hits 21194 20886 -308 \n- Misses 5413 5721 +308 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6196/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `23.38% <0.00%> (-73.39%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6196/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6196/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+5.76%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6196/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.32% <0.00%> (+23.67%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6196/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=footer). Last update [82a0e2b...f559e11](https://codecov.io/gh/huggingface/transformers/pull/6196?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "I added one more `check_loss_output` that was missing, no changes otherwise.\r\n\r\nCI is randomly failing again..." ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=h1) Report\n> Merging [#6195](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d8dbf3b75d58667e2ecaf42b4aa076e83d034d26&el=desc) will **increase** coverage by `0.32%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6195 +/- ##\n==========================================\n+ Coverage 79.47% 79.80% +0.32% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n+ Hits 21146 21233 +87 \n+ Misses 5461 5374 -87 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/configuration\\_encoder\\_decoder.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2VuY29kZXJfZGVjb2Rlci5weQ==) | `100.00% <ø> (ø)` | |\n| [src/transformers/modeling\\_encoder\\_decoder.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbmNvZGVyX2RlY29kZXIucHk=) | `92.20% <ø> (ø)` | |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.98%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `90.09% <0.00%> (+23.42%)` | :arrow_up: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `93.80% <0.00%> (+25.66%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6195/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `98.79% <0.00%> (+34.61%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=footer). Last update [d8dbf3b...4a03156](https://codecov.io/gh/huggingface/transformers/pull/6195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "@afcruzs - thanks a lot for your PR. I changed the examples a bit trying to make sure:\r\n1) Examples in `config` only concern the EncoderDecoderConfig\r\n2) Examples in `model` only concern the EncoderDecoderModel\r\n\r\nsorry for meddling in your PR.", "Thanks for improving the examples! I've fixed the whitespace issue" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "@patrickvonplaten please see. if relevant ", "Hi @manishiitg , can you post the command/code you used to run this example ? Won't be able to re-produce from the stack-trace.", "Thanks for answering @patil-suraj . As @patil-suraj said, we need some code and also the environment info (it's empty above) to better answer here :-) ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "Hello! These warnings are not important, as these weights are not necessary (the position IDs is a buffer that is initialized if not defined, and the lm head decoder bias already exists in the lm head decoder linear layer).\r\n\r\nOn the `master` branch we've updated the warnings to only list those that could have an impact, so running your code on the current master branch results in:\r\n\r\n```py\r\nWARNING:transformers.modeling_utils:Some weights of RobertaForMaskedLM were not initialized from the model checkpoint at roberta-base and are newly initialized: ['lm_head.decoder.bias']\r\nYou should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.\r\n```\r\n\r\nSo nothing wrong here! Did you make sure you were using the exact same implementation of perplexity calculation than Fairseq?", "Thanks for the clarification! The difference in `fairseq` and `transformers` ppl is coming from different implementation - `e^cross_entropy` ([in transformers](https://github.com/huggingface/transformers/blob/master/examples/language-modeling/run_language_modeling.py#L274)) vs `2^cross_entropy` ([in fairseq](https://github.com/pytorch/fairseq/blob/master/fairseq/utils.py#L418)). Nothing wrong here! : )", "@LysandreJik \r\nHi, did not understand \"the lm head decoder bias already exists in the lm head decoder linear layer\", but it still warnings that lm_head.decoder.bias is newly initialized? I'm confused, sorry. Could you elaborate more about why this is not a problem?", "Hi @cloudygoose, I recommend you take a look at the following class: https://github.com/huggingface/transformers/blob/b8462b5b2ac84f63293900ae168dbde039443a22/src/transformers/models/roberta/modeling_roberta.py#L1065-L1087\r\n\r\nThe error tells you that the following weight: `lm_head.decoder.bias` was not initialized from the model checkpoint: the model checkpoint did not contain that weight.\r\n\r\nHowever, the weight `lm_head.bias` isn't in the error because it was correctly initialized. If you take a look at the last line of the initialization of the class above, you'll see:\r\n\r\n```py\r\n # Need a link between the two variables so that the bias is correctly resized with `resize_token_embeddings` \r\n self.decoder.bias = self.bias \r\n```\r\n\r\nTherefore, the `lm_head.decoder.bias` weight that was not initialized is now set to the value of `self.bias`, which is correctly initialized.\r\n\r\nLet me know if something isn't clear.", "Hi @LysandreJik,\r\n\r\nI am trying to make a custom model based on Roberta. I use `RobertaModel` internally.\r\n\r\nThe warning is:\r\n```bash\r\nSome weights of the model checkpoint at roberta-large were not used when initializing RobertaModelForTokenAndSpans: ['lm_head.bias', 'lm_head.dense.weight', 'lm_head.dense.bias', 'lm_head.layer_norm.weight', 'lm_head.layer_norm.bias', 'lm_head.decoder.weight']\r\n- This IS expected if you are initializing RobertaModelForTokenAndSpans from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).\r\n- This IS NOT expected if you are initializing RobertaModelForTokenAndSpans from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).\r\nSome weights of RobertaModelForTokenAndSpans were not initialized from the model checkpoint at roberta-large and are newly initialized: ['roberta.embeddings.position_ids', 'classifier.weight', 'classifier.bias', 'qa_outputs.weight', 'qa_outputs.bias']\r\n```\r\n\r\n`classifier` and `qa_outputs` are my own layers. I assume from the previous release (4.2.2), this warning has not been removed?\r\nWill having `roberta.embeddings.position_ids` not initialized from roberta affect things in any way?", "This warning shouldn't be removed, it's telling you what it initializes randomly, and what isn't used. Apparently it's not an issue in your case since you're aware of it, so that's great!\r\n\r\nNot an issue for the position IDs, this warning should have been removed in version v4.3.2, though!", "I meant the warning about for position IDs.\r\nThanks a lot @LysandreJik :)", "Happy to help!" ]

[]

[]

[ "Hi @vibhavagarwal5 , you can safely ignore this warning, that issue is resolved in this PR #5922 .\r\n\r\nDo you think you can post the stack-trace after the crash, and also the version and memory of the GPU used", "**GPU DETAILS:** NVIDIA 2080 TI (12GB)\r\n\r\nNVIDIA-SMI 440.95.01\r\nDriver Version: 440.95.01\r\nCUDA Version: 10.2\r\n\r\n**STACK TRACE:**\r\n```\r\nEpoch: 0%| | 0/3 [00:00<?, ?it/sTraceback (most recent call last): | 0/87472 [00:00<?, ?it/s]\r\n File \"finetune_lm.py\", line 553, in <module>\r\n main()\r\n File \"finetune_lm.py\", line 507, in main\r\n global_step, tr_loss = train(args, train_dataset, model, tokenizer)\r\n File \"finetune_lm.py\", line 157, in train\r\n loss.backward()\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/tensor.py\", line 198, in backward\r\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/autograd/__init__.py\", line 100, in backward\r\n allow_unreachable=True) # allow_unreachable flag\r\nRuntimeError: CUDA error: CUBLAS_STATUS_ALLOC_FAILED when calling `cublasCreate(handle)` (createCublasHandle at /opt/conda/conda-bld/pytorch_1587428266983/work/aten/src/ATen/cuda/CublasHandlePool.cpp:8)\r\nframe #0: c10::Error::Error(c10::SourceLocation, std::string const&) + 0x4e (0x7f6cca012b5e in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libc10.so)\r\nframe #1: <unknown function> + 0xdba405 (0x7f6ccaff9405 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #2: at::cuda::getCurrentCUDABlasHandle() + 0x94c (0x7f6ccaffa1ec in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #3: <unknown function> + 0xdafb01 (0x7f6ccafeeb01 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #4: <unknown function> + 0x1263db7 (0x7f6ccb4a2db7 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #5: THCudaTensor_addmm + 0x5c (0x7f6ccb4a84ac in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #6: <unknown function> + 0xea5f28 (0x7f6ccb0e4f28 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #7: <unknown function> + 0xdc92e8 (0x7f6ccb0082e8 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cuda.so)\r\nframe #8: <unknown function> + 0xe224d0 (0x7f6cf5c264d0 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #9: <unknown function> + 0x29f9d0e (0x7f6cf77fdd0e in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #10: <unknown function> + 0xe224d0 (0x7f6cf5c264d0 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #11: at::Tensor::mm(at::Tensor const&) const + 0xf0 (0x7f6cf57ea180 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #12: <unknown function> + 0x264517c (0x7f6cf744917c in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #13: torch::autograd::generated::MmBackward::apply(std::vector<at::Tensor, std::allocator<at::Tensor> >&&) + 0x151 (0x7f6cf7449f81 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #14: <unknown function> + 0x2ae8215 (0x7f6cf78ec215 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #15: torch::autograd::Engine::evaluate_function(std::shared_ptr<torch::autograd::GraphTask>&, torch::autograd::Node*, torch::autograd::InputBuffer&) + 0x16f3 (0x7f6cf78e9513 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #16: torch::autograd::Engine::thread_main(std::shared_ptr<torch::autograd::GraphTask> const&, bool) + 0x3d2 (0x7f6cf78ea2f2 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #17: torch::autograd::Engine::thread_init(int) + 0x39 (0x7f6cf78e2969 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so)\r\nframe #18: torch::autograd::python::PythonEngine::thread_init(int) + 0x38 (0x7f6cfac29558 in /home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/lib/libtorch_python.so)\r\nframe #19: <unknown function> + 0xc819d (0x7f6d1200b19d in /mnt/c7cfa338-89cd-4d15-b0b9-f1befc9a2c68/vibhav/anaconda3/envs/vesnli/bin/../lib/libstdc++.so.6)\r\nframe #20: <unknown function> + 0x76db (0x7f6d269a16db in /lib/x86_64-linux-gnu/libpthread.so.0)\r\nframe #21: clone + 0x3f (0x7f6d266caa3f in /lib/x86_64-linux-gnu/libc.so.6)\r\n```", "Seems like memory error, you can try running with batch size 1 and see if it still crashes.", "Nope not a memory error. Still crashing with batch size 1", "Which GPT-2 model are you using ? ", "Tried both 'gpt2' and 'gpt2-medium'. Same issue", "Could you run it in on CPU, erros will be more readable.", "```\r\nraceback (most recent call last): | 0/174944 [00:00<?, ?it/s]\r\n File \"finetune_lm.py\", line 553, in <module>\r\n main()\r\n File \"finetune_lm.py\", line 507, in main\r\n global_step, tr_loss = train(args, train_dataset, model, tokenizer)\r\n File \"finetune_lm.py\", line 144, in train\r\n outputs = model(inputs, labels=labels)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 550, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/transformers/modeling_gpt2.py\", line 601, in forward\r\n output_hidden_states=output_hidden_states,\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 550, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/transformers/modeling_gpt2.py\", line 469, in forward\r\n inputs_embeds = self.wte(input_ids)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 550, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/nn/modules/sparse.py\", line 114, in forward\r\n self.norm_type, self.scale_grad_by_freq, self.sparse)\r\n File \"/home/hdd1/vibhav/anaconda3/envs/vesnli/lib/python3.7/site-packages/torch/nn/functional.py\", line 1724, in embedding\r\n return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)\r\nIndexError: index out of range in self\r\n```", "So looks like error is form the embedding layer, what's the shape of your `inputs`", "bs x seq_len (4x63 or 4*52 ... anything)", "could you be more specific, what is your seq_len ? ", "Input:\r\n```\r\ntorch.Size([4, 47])\r\nPremise: Children smiling and waving at camera Hypothesis: There are children present [EXP] The children must be present to see them smiling and waving. [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS] [EOS]\r\n```\r\nlabel:\r\n```\r\ntorch.Size([4, 47])\r\n[None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, 'The', 'Ġchildren', 'Ġmust', 'Ġbe', 'Ġpresent', 'Ġto', 'Ġsee', 'Ġthem', 'Ġsmiling', 'Ġand', 'Ġwaving', '.', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]', '[EOS]']\r\n```", "Did you add any new tokens to the tokenizer ?\r\n\r\nget the shape of embeddings using `model.transformer.wte.weight.shape` the first dim of shape and len of tokenizer should match. See if this asserts is True\r\n```python3\r\nassert modle.transformer.wte.weight.shape[0] == len(tokenizer)\r\n```\r\n\r\nif not then that means, your vocab size and embed input size are not matching. If you added new tokens to the vocab, you'll need to resize the token embeddings of the model. You can resize it using\r\n\r\n```python3\r\nmodel.resize_token_embeddings(len(tokenizer))\r\n```\r\n\r\n", "I'm doing this already..\r\n\r\n```python\r\ntokenizer.add_special_tokens(SPECIAL_TOKENS_DICT)\r\nmodel.resize_token_embeddings(len(tokenizer))\r\n```", "I was able to reprouce the bug only when embedding size and vocab len didn't match. \r\n\r\n`assert modle.transformer.wte.weight.shape[0] == len(tokenizer)` did this assert result in `False` ?", "No, its True because I did the model.resize so this should have anyways asserted True.", "For whatever reason, `transformers v2.3` is working and the latest `3.x`", "Hi @vibhavagarwal5, could you provide a sample script so that we may reproduce on our side? Something with a sample text that makes it crash would be wonderful, if you have one.", "I figured it out, it was due to the change in ignore_index=-100 instead of -1 in the cross entropy loss which was causing the issue. I'll close this. ", "Glad you could find the source of the issue!" ]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "please let me know how this progresses I am also interested in doing this", "Hello,\r\nWould it be possible for your team to also work on GPT2LMHeadModel on this same issue?\r\n\r\nThank you,", "Hey @h56cho - did you find a solution here? Would be great if you can post code :-) ", "Likewise, would be very interested in what came of this." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "mfuntowicz", "id": 2241520, "node_id": "MDQ6VXNlcjIyNDE1MjA=", "avatar_url": "https://avatars.githubusercontent.com/u/2241520?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mfuntowicz", "html_url": "https://github.com/mfuntowicz", "followers_url": "https://api.github.com/users/mfuntowicz/followers", "following_url": "https://api.github.com/users/mfuntowicz/following{/other_user}", "gists_url": "https://api.github.com/users/mfuntowicz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mfuntowicz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mfuntowicz/subscriptions", "organizations_url": "https://api.github.com/users/mfuntowicz/orgs", "repos_url": "https://api.github.com/users/mfuntowicz/repos", "events_url": "https://api.github.com/users/mfuntowicz/events{/privacy}", "received_events_url": "https://api.github.com/users/mfuntowicz/received_events", "type": "User", "site_admin": false } ]

[ "is there any workaround for this? i'm seeing the `Token indices sequence length is longer than the specified maximum sequence length for this model (... > 512). Running this sequence through the model will result in indexing errors` when using TextClassificationPipeline.\r\n\r\n(This is preventing me from upgrading to 3.x.)", "routing this to @mfuntowicz @LysandreJik ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "+1 on this", "Hi, even though this has been closed as stale, without comment or supposed fix, it seems that in recent versions you can in fact pass both `truncation` and `padding` arguments to the pipeline's `__call__` method, and it will correctly use them when tokenizing. I've tested it with long texts that fail without the truncation argument, and it seems to work as expected. " ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=h1) Report\n> Merging [#6189](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/8edfaaa81b9995cedea2f8805e4c18c2b6cb5bfc&el=desc) will **increase** coverage by `1.42%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6189 +/- ##\n==========================================\n+ Coverage 78.29% 79.71% +1.42% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n+ Hits 20832 21210 +378 \n+ Misses 5775 5397 -378 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.98%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `80.70% <0.00%> (-3.51%)` | :arrow_down: |\n| [src/transformers/data/processors/utils.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvdXRpbHMucHk=) | `27.63% <0.00%> (+1.31%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `90.09% <0.00%> (+1.80%)` | :arrow_up: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `98.63% <0.00%> (+2.73%)` | :arrow_up: |\n| [src/transformers/training\\_args.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmluZ19hcmdzLnB5) | `81.00% <0.00%> (+14.00%)` | :arrow_up: |\n| [src/transformers/data/processors/glue.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvZ2x1ZS5weQ==) | `49.09% <0.00%> (+17.09%)` | :arrow_up: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.14% <0.00%> (+24.04%)` | :arrow_up: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `93.80% <0.00%> (+25.66%)` | :arrow_up: |\n| ... and [5 more](https://codecov.io/gh/huggingface/transformers/pull/6189/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=footer). Last update [8edfaaa...6a2d21e](https://codecov.io/gh/huggingface/transformers/pull/6189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "~It seems to work? What's happening on your end?~ Indeed, the generated text seems to be truncated.", "@ksjae, I can't seem to make that model work in my environment, without relying on the inference API. \r\n\r\n```py\r\nfrom transformers import AutoModelWithLMHead, pipeline\r\nfrom transformers import GPT2Tokenizer\r\n\r\ntokenizer = GPT2Tokenizer.from_pretrained(\"taeminlee/kogpt2\", do_lower_case=False)\r\n\r\nprint(tokenizer.tokenize(\"제 이름은 홍길동\"))\r\n# ['ì', 'ł', 'ľ', 'Ġ', 'ì', 'Ŀ', '´', 'ë', '¦', 'Ħ', 'ì', 'Ŀ', 'Ģ', 'Ġ', 'í', 'Ļ', 'į', 'ê', '¸', '¸', 'ë', 'ı', 'Ļ'] # probably not what we're looking for\r\n\r\nprint(tokenizer.decode(tokenizer.encode(\"제 이름은 홍길동\")))\r\n# <unk><unk><unk><unk><unk><unk><unk><unk><unk><unk><unk><unk><unk><unk>�<unk><unk><unk><unk><unk><unk><unk><unk>\r\n# Definitely not what we're looking for\r\n```\r\n\r\nDo you know the author?", "No, I don't.\r\nI'll try to add a new one(in training right now) though.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[ { "login": "JetRunner", "id": 22514219, "node_id": "MDQ6VXNlcjIyNTE0MjE5", "avatar_url": "https://avatars.githubusercontent.com/u/22514219?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JetRunner", "html_url": "https://github.com/JetRunner", "followers_url": "https://api.github.com/users/JetRunner/followers", "following_url": "https://api.github.com/users/JetRunner/following{/other_user}", "gists_url": "https://api.github.com/users/JetRunner/gists{/gist_id}", "starred_url": "https://api.github.com/users/JetRunner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JetRunner/subscriptions", "organizations_url": "https://api.github.com/users/JetRunner/orgs", "repos_url": "https://api.github.com/users/JetRunner/repos", "events_url": "https://api.github.com/users/JetRunner/events{/privacy}", "received_events_url": "https://api.github.com/users/JetRunner/received_events", "type": "User", "site_admin": false } ]

[ "> @sshleifer Is there anything else needed to do in order to make ProphetNet work with your seq2seq example?\r\n> \r\n> Also @mfuntowicz for pipelines\r\n\r\nI tried examples/seq2seq/finetune.py and it works with python finetune.py --do_train and --do_predict.", "I will try to complete document and unit test by this week", "@patrickvonplaten Thanks for your review! I learned a lot, too.\r\n\r\n@qiweizhen Please be free to contact me for discussion via WeChat if you have trouble understanding Patrick's comments or you want to have another person to double-check! Thanks for your great work!" ]

[]

[]

[ "Fixed with #6280" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=h1) Report\n> Merging [#6185](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/a39dfe4fb122c11be98a563fb8ca43b322e01036&el=desc) will **increase** coverage by `1.25%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6185 +/- ##\n==========================================\n+ Coverage 78.34% 79.59% +1.25% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n+ Hits 20844 21178 +334 \n+ Misses 5763 5429 -334 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6185/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydC5weQ==) | `91.32% <ø> (ø)` | |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6185/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.98%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_bert.py](https://codecov.io/gh/huggingface/transformers/pull/6185/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9iZXJ0LnB5) | `70.32% <0.00%> (-26.66%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6185/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6185/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `98.79% <0.00%> (+34.61%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6185/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `96.77% <0.00%> (+73.38%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=footer). Last update [a39dfe4...f44324f](https://codecov.io/gh/huggingface/transformers/pull/6185?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=h1) Report\n> Merging [#6184](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/8edfaaa81b9995cedea2f8805e4c18c2b6cb5bfc&el=desc) will **increase** coverage by `0.20%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6184 +/- ##\n==========================================\n+ Coverage 78.29% 78.50% +0.20% \n==========================================\n Files 146 146 \n Lines 26607 26607 \n==========================================\n+ Hits 20832 20887 +55 \n+ Misses 5775 5720 -55 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `23.38% <0.00%> (-73.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.98%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.30% <0.00%> (+0.25%)` | :arrow_up: |\n| [src/transformers/data/processors/utils.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvdXRpbHMucHk=) | `27.63% <0.00%> (+1.31%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `90.09% <0.00%> (+1.80%)` | :arrow_up: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+2.50%)` | :arrow_up: |\n| [src/transformers/tokenization\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fcm9iZXJ0YS5weQ==) | `98.63% <0.00%> (+2.73%)` | :arrow_up: |\n| [src/transformers/training\\_args.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmluZ19hcmdzLnB5) | `81.00% <0.00%> (+14.00%)` | :arrow_up: |\n| [src/transformers/data/processors/glue.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvZ2x1ZS5weQ==) | `49.09% <0.00%> (+17.09%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.32% <0.00%> (+23.67%)` | :arrow_up: |\n| ... and [7 more](https://codecov.io/gh/huggingface/transformers/pull/6184/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=footer). Last update [8edfaaa...566b357](https://codecov.io/gh/huggingface/transformers/pull/6184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Investigating the issues 🤓 ", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=h1) Report\n> Merging [#6183](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/b25cec13c57656941aac3b920eeb488c1915df18&el=desc) will **increase** coverage by `0.57%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6183 +/- ##\n==========================================\n+ Coverage 79.08% 79.66% +0.57% \n==========================================\n Files 149 147 -2 \n Lines 27685 26603 -1082 \n==========================================\n- Hits 21894 21192 -702 \n+ Misses 5791 5411 -380 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/file\\_io.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX2lvLnB5) | `100.00% <100.00%> (ø)` | |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.71% <100.00%> (-0.14%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.51%)` | :arrow_down: |\n| [src/transformers/tokenization\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxuZXQucHk=) | `66.66% <0.00%> (-23.43%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.65% <0.00%> (-23.08%)` | :arrow_down: |\n| [src/transformers/trainer\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3V0aWxzLnB5) | `85.71% <0.00%> (-14.29%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `71.21% <0.00%> (-12.88%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9hbGJlcnQucHk=) | `76.47% <0.00%> (-11.88%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.05% <0.00%> (-2.14%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `85.21% <0.00%> (-1.51%)` | :arrow_down: |\n| ... and [54 more](https://codecov.io/gh/huggingface/transformers/pull/6183/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=footer). Last update [cdf1f7e...d159584](https://codecov.io/gh/huggingface/transformers/pull/6183?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Looks much better now 🎉\n\n@n1t0 @thomwolf could you please take a glance? :)", "I did a bit of refactoring to have load/dump methods reusable across the library. \r\n\r\n\r\nThese changes introduce a new scope for the common File IO methods (like json pickle load/dump). Although there is an already existing `file_utils` scope, I believe it's not supposed to contain the common IO operations as the docs say (`Utilities for working with the local dataset cache.`).\r\n\r\n@LysandreJik, could you please review the changes? :)", "It looks like #6026 fixed the issue. But nevertheless this PR is still relevant since it guarantees tokenizers saving/loading with objects of arbitrary types. ", "Hi, thanks a lot for your contribution! Unfortunately we're very strict about adding new dependencies, and this doesn't really change the existing behavior. I'm not sure I see the pros of introducing this new scope vs the cons of integrating a new dependencies + updating existing code.", "Hi, thanks for replying! I respect your policy regarding the third-party dependencies, this makes sense. Anyway, the current approaches compromise tokenizers (de)serialization with introducing new objects to include (besides `AddedToken` instances). This might be a subject of future improvements once new types are introduced into the tokenizer configs, but I think it makes sense to consider generalizing the behavior.\r\n\r\nIf it makes sense, I could wrap saving/loading configs into the new scope without a third-party library, though it's far from generalizing, at least adding new cases to handle will be easier. What do you think? :)", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[ { "login": "mfuntowicz", "id": 2241520, "node_id": "MDQ6VXNlcjIyNDE1MjA=", "avatar_url": "https://avatars.githubusercontent.com/u/2241520?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mfuntowicz", "html_url": "https://github.com/mfuntowicz", "followers_url": "https://api.github.com/users/mfuntowicz/followers", "following_url": "https://api.github.com/users/mfuntowicz/following{/other_user}", "gists_url": "https://api.github.com/users/mfuntowicz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mfuntowicz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mfuntowicz/subscriptions", "organizations_url": "https://api.github.com/users/mfuntowicz/orgs", "repos_url": "https://api.github.com/users/mfuntowicz/repos", "events_url": "https://api.github.com/users/mfuntowicz/events{/privacy}", "received_events_url": "https://api.github.com/users/mfuntowicz/received_events", "type": "User", "site_admin": false } ]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[]

[]

[]

[ "Yes indeed!\r\nSomehow, I was sure it was corrected on the master but I guess it was only on my private branch.\r\nLet me open a PR, thanks for pointing that out @HanGuo97!", "Great, appreciate the help!" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Hey @mchari, could you please post your environment information and a code sample that we can run to reproduce your error?", "@patrickvonplaten , thanks for your reply.\r\n\r\ni am using transformers 3.0.2 that i got from a pip install. \r\nHere is the code \r\n`\r\nfrom transformers import RobertaTokenizer, RobertaForQuestionAnswering\r\nimport torch\r\nimport tensorflow\r\n\r\ntokenizer = RobertaTokenizer.from_pretrained('roberta-base')\r\nprint(\"Loaded tokenizer !!!\")\r\nmodel = RobertaForQuestionAnswering.from_pretrained('roberta-base')\r\n\r\nprint(\"Loaded QA model !!!\")\r\n\r\nquestion = \"Who was Jim Henson?\"\r\ncontext = \"Jim Henson was a nice puppet\"\r\n\r\ninput_text = \"[CLS] \" + question + \" [SEP] \" + context + \" [SEP]\"\r\n#input_text = question + \" [SEP] \" + context\r\n#print(tokenizer(input_text))\r\n\r\ninput_ids = tokenizer.encode(input_text)\r\nstart_scores, end_scores = model(torch.tensor([input_ids]))\r\nprint(input_ids)\r\n\r\ntoken_type_ids = [0 if i <= input_ids.index(102) else 1 for i in range(len(input_ids))] \r\nstart_scores, end_scores = model(torch.tensor([input_ids]), token_type_ids=torch.tensor([token_type_ids]))\r\nall_tokens = tokenizer.convert_ids_to_tokens(input_ids) \r\nprint(' '.join(all_tokens[torch.argmax(start_scores) : torch.argmax(end_scores)+1]))\r\n`", "i was able to workaround the issue by using the following code that doesn't look for id 102...\r\nnot sure if it is equivalent....\r\n\r\n\r\nencoding = tokenizer.encode_plus(question,context)\r\ninput_ids, attention_mask = encoding[\"input_ids\"], encoding[\"attention_mask\"]\r\nstart_scores, end_scores = model(torch.tensor([input_ids]), attention_mask=torch.tensor([attention_mask]))", "your workaround is correct. The link you posted above points to a very old example. Please take a look at the example of the updated model of `BertForQuestionAnswering` : https://huggingface.co/transformers/model_doc/bert.html#transformers.BertForQuestionAnswering" ]

[]

[]

[ "@LysandreJik Will do! When I run `make style` it makes corrections to many other files, and also (for example) changes the import sort order on code that I didn't touch in the code that I am editing. Am I doing something wrong? Or should I commit those changes (in the files I am editing)?", "Sounds weird, maybe you're missing some packages in your environment. Let me know when you're finished and I'll push the styling on your branch.", "@sgugger Should have all of the review comments addressed. Thanks to everyone!", "Great, thanks for iterating @dsblank!", "You're welcome, and thanks for all of the work on this project! Looking forward to productive ML!" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=h1) Report\n> Merging [#6175](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d951c14ae46ee36b76981588ed6d03ab353ad766&el=desc) will **increase** coverage by `0.00%`.\n> The diff coverage is `100.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6175 +/- ##\n=======================================\n Coverage 79.51% 79.52% \n=======================================\n Files 146 146 \n Lines 26607 26618 +11 \n=======================================\n+ Hits 21156 21167 +11 \n Misses 5451 5451 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6175/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.79% <100.00%> (+0.42%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6175/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `84.52% <0.00%> (-10.72%)` | :arrow_down: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6175/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `92.71% <0.00%> (-1.13%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6175/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `80.05% <0.00%> (-0.26%)` | :arrow_down: |\n| [src/transformers/tokenization\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6175/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdDUucHk=) | `95.77% <0.00%> (+23.94%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=footer). Last update [d951c14...1ec7448](https://codecov.io/gh/huggingface/transformers/pull/6175?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[]

[]

[ { "login": "patrickvonplaten", "id": 23423619, "node_id": "MDQ6VXNlcjIzNDIzNjE5", "avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickvonplaten", "html_url": "https://github.com/patrickvonplaten", "followers_url": "https://api.github.com/users/patrickvonplaten/followers", "following_url": "https://api.github.com/users/patrickvonplaten/following{/other_user}", "gists_url": "https://api.github.com/users/patrickvonplaten/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickvonplaten/subscriptions", "organizations_url": "https://api.github.com/users/patrickvonplaten/orgs", "repos_url": "https://api.github.com/users/patrickvonplaten/repos", "events_url": "https://api.github.com/users/patrickvonplaten/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickvonplaten/received_events", "type": "User", "site_admin": false } ]

[ "Hi @Krish-Nerkar , [this](https://discuss.huggingface.co/t/speeding-up-gpt2-generation/470) might help", "@patil-suraj Thanks Alot! will check those methods out\r\n\r\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Hi @monologg , yes toke_type_ids should be there for electra,\r\n\r\neasy fix would be somethin like\r\n```python3\r\nif self.config.model_type not in [\"xlm\", \"roberta\", \"distilbert\", \"camembert\", \"longformer\"]:\r\n inputs[\"token_type_ids\"] = batch[2] \r\n```\r\n\r\nThis is how it's done in the squad dataset\r\n\r\n@LysandreJik , if yes, I can open a PR", "@patil-suraj, I also think that is the best to way to fix this issue:)\r\n\r\nhttps://github.com/huggingface/transformers/blob/838dc06ff5a438159ac25f531d622e8f344476f5/examples/text-classification/run_pl_glue.py#L98-L102\r\n\r\nAnd not only in `training_step()`, also `validation_step()` has to be fixed.", "Yes, totally forgot about that, thanks! ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Hello! What do you want to do with this PR?", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=h1) Report\n> Merging [#6171](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c0b93a1c7a961e30b30d02d641c9d22120ef5d73&el=desc) will **decrease** coverage by `0.05%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6171 +/- ##\n==========================================\n- Coverage 79.82% 79.76% -0.06% \n==========================================\n Files 146 146 \n Lines 26597 26597 \n==========================================\n- Hits 21231 21216 -15 \n- Misses 5366 5381 +15 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6171/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.18% <0.00%> (-34.62%)` | :arrow_down: |\n| [src/transformers/tokenization\\_dpr.py](https://codecov.io/gh/huggingface/transformers/pull/6171/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fZHByLnB5) | `53.15% <0.00%> (-4.51%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6171/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.71% <0.00%> (+1.50%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6171/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6171/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=footer). Last update [c0b93a1...37a803b](https://codecov.io/gh/huggingface/transformers/pull/6171?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "> Hello! What do you want to do with this PR?\r\n\r\nHi! The original code has the following problems:\r\n\r\n\r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "`j`", "Y", "Grgj6r", "Yes mi bro", "Yes mi bro ", "K", "J" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=h1) Report\n> Merging [#6169](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c0b93a1c7a961e30b30d02d641c9d22120ef5d73&el=desc) will **decrease** coverage by `0.87%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6169 +/- ##\n==========================================\n- Coverage 79.82% 78.94% -0.88% \n==========================================\n Files 146 146 \n Lines 26597 26597 \n==========================================\n- Hits 21231 20997 -234 \n- Misses 5366 5600 +234 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/tokenization\\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `16.26% <0.00%> (-66.67%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.18% <0.00%> (-34.62%)` | :arrow_down: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `71.21% <0.00%> (-12.88%)` | :arrow_down: |\n| [src/transformers/tokenization\\_transfo\\_xl.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdHJhbnNmb194bC5weQ==) | `33.56% <0.00%> (-8.93%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+1.25%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6169/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=footer). Last update [c0b93a1...ea1f76a](https://codecov.io/gh/huggingface/transformers/pull/6169?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "Thanks @kolk!" ]

[]

[]

[ "@sgugger @LysandreJik thanks for the advice, will update soon!", "Great, let us know when this PR is ready to review again!", "@LysandreJik @sgugger Ready for reviewing again! Thanks for all the suggestions. \r\nI noticed that the check_code_quality test is failed however I can't see the actual failing part, please let me know if this matters.\r\nAnd also please let me know if there are addition modification required, thanks guys!", "@LysandreJik @sgugger tests added and style check modification were done. Please help me to review this if got time, thanks!\r\n\r\nBesides, I did black reformat all the check_code_quality required files. However it could not pass the tests in CI, have no idea why this happen.\r\n\r\n```\r\nblack --line-length 119 --target-version py35 src/transformers/data/datasets/language_modeling.py\r\nAll done! ✨ 🍰 ✨\r\n1 file left unchanged.\r\n```", "This is because your black/isort versions aren't up to date. This is not a problem, I just pushed to your branch with the fix, but there's a remaining issue with flake8 that you will have to fix:\r\n\r\n```\r\nsrc/transformers/data/data_collator.py:253:13: F841 local variable 'attention_padding_mask' is assigned to but never used\r\nsrc/transformers/data/datasets/language_modeling.py:153:21: F541 f-string is missing placeholders\r\n```", "Thanks for adding the test, it's great!", "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=h1) Report\n> Merging [#6168](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/ed71c21d6afcbfa2d8e5bb03acbb88ae0e0ea56a?el=desc) will **decrease** coverage by `0.38%`.\n> The diff coverage is `96.58%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6168 +/- ##\n==========================================\n- Coverage 79.51% 79.13% -0.39% \n==========================================\n Files 164 164 \n Lines 31022 31137 +115 \n==========================================\n- Hits 24668 24641 -27 \n- Misses 6354 6496 +142 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/\\_\\_init\\_\\_.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9fX2luaXRfXy5weQ==) | `99.31% <ø> (ø)` | |\n| [...rc/transformers/data/datasets/language\\_modeling.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL2RhdGFzZXRzL2xhbmd1YWdlX21vZGVsaW5nLnB5) | `92.94% <95.23%> (+2.13%)` | :arrow_up: |\n| [src/transformers/data/data\\_collator.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL2RhdGFfY29sbGF0b3IucHk=) | `93.18% <100.00%> (+0.88%)` | :arrow_up: |\n| [src/transformers/data/datasets/\\_\\_init\\_\\_.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL2RhdGFzZXRzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |\n| [src/transformers/modeling\\_tf\\_longformer.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9sb25nZm9ybWVyLnB5) | `16.37% <0.00%> (-82.31%)` | :arrow_down: |\n| [src/transformers/modeling\\_longformer.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19sb25nZm9ybWVyLnB5) | `19.71% <0.00%> (-72.34%)` | :arrow_down: |\n| [src/transformers/configuration\\_longformer.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2xvbmdmb3JtZXIucHk=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |\n| [src/transformers/modeling\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190NS5weQ==) | `76.70% <0.00%> (-6.07%)` | :arrow_down: |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `86.66% <0.00%> (-0.55%)` | :arrow_down: |\n| [src/transformers/file\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.41% <0.00%> (-0.26%)` | :arrow_down: |\n| ... and [7 more](https://codecov.io/gh/huggingface/transformers/pull/6168/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=footer). Last update [ed71c21...911b5b4](https://codecov.io/gh/huggingface/transformers/pull/6168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "> This is because your black/isort versions aren't up to date. This is not a problem, I just pushed to your branch with the fix, but there's a remaining issue with flake8 that you will have to fix:\r\n> \r\n> ```\r\n> src/transformers/data/data_collator.py:253:13: F841 local variable 'attention_padding_mask' is assigned to but never used\r\n> src/transformers/data/datasets/language_modeling.py:153:21: F541 f-string is missing placeholders\r\n> ```\r\n\r\nresolved. @LysandreJik \r\nPlease help to review again, thanks!", "Thanks for all your efforts on this!", "> Thanks for all your efforts on this!\r\n\r\nthanks for reviewing!", "> Very cool, I updated the style again.\r\n> \r\n> Thanks for iterating!\r\n\r\nthanks for your help!", "First of all I have to admit, I am new here, so still trying to understand how different modalities work in hugging face.\r\nGoing through the documents, it seems that the modifications proposed by @yl-to are only for PyTorch. Right ?\r\nPretraining of ALBERT with TF is still not supported ? ", "That is correct @UmarSpa! However, models trained in PyTorch can easily be ported to TensorFlow if you're looking to serve a model using TensorFlow." ]

[]

[]

[ "Nope. They appear again, 2 paras later.\r\n\r\nMoreover, the 2 deleted instructions are themselves a problem as they are identical ;)" ]

[ { "id": 1108649053, "node_id": "MDU6TGFiZWwxMTA4NjQ5MDUz", "url": "https://api.github.com/repos/huggingface/transformers/labels/Help%20wanted", "name": "Help wanted", "color": "008672", "default": false, "description": "Extra attention is needed, help appreciated" }, { "id": 2206883508, "node_id": "MDU6TGFiZWwyMjA2ODgzNTA4", "url": "https://api.github.com/repos/huggingface/transformers/labels/lightning", "name": "lightning", "color": "a707bc", "default": false, "description": "" } ]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=h1) Report\n> Merging [#6166](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/c0b93a1c7a961e30b30d02d641c9d22120ef5d73&el=desc) will **decrease** coverage by `1.38%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6166 +/- ##\n==========================================\n- Coverage 79.82% 78.44% -1.39% \n==========================================\n Files 146 146 \n Lines 26597 26597 \n==========================================\n- Hits 21231 20863 -368 \n- Misses 5366 5734 +368 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6166/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `23.38% <0.00%> (-73.39%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6166/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.18% <0.00%> (-34.62%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6166/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+1.25%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6166/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.32% <0.00%> (+23.67%)` | :arrow_up: |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6166/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `95.77% <0.00%> (+35.21%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6166/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=footer). Last update [c0b93a1...68319f0](https://codecov.io/gh/huggingface/transformers/pull/6166?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[ "Hello !\r\n\r\nWhich tests do not pass precisely? They are all green for me.\r\n\r\nFor the log that is not displayed this is because no logger is set in `benchmark_test.py`. I will review that for later, thanks!", "> Which tests do not pass precisely? They are all green for me.\r\n\r\nMost (all?) tests. Try:\r\n```\r\npip install tensorflow==2.0.1\r\npytest -ra tests/test_benchmark.py \r\n```\r\n\r\nBut unrelated to tests if the runtime requires `foo>=x.y.z`, then the requirements/setup need to require that exact version. A user may (1) already have `foo` installed and then runtime fails (2) a different package may require a lower version of `foo` and thus `pip` won't upgrade it to the latest version available.\r\n\r\n> For the log that is not displayed this is because no logger is set in `benchmark_test.py`. I will review that for later, thanks!\r\n\r\nThat was just an example, as I said most, if not all tests fail with the same cryptic error.", "OK, I see better now. Thanks!!\n\nI have fixed this in another PR by updating the piece of code you raised by an assert inside the `__init__` of the TFTrainer and now your example works fine. We do not want to fix the TensorFlow version for the entire lib but only for the trainer, at least for now.", "I understand.\r\n\r\nPlease let me know which PR if you'd like me to re-test, or when it gets merged and I will re-test then.\r\n\r\nThank you, @jplu ", "Now the fix is merged :)", "Thank you for remembering to ping me. I re-tested with master and the tests now work with tensorflow==2.0.1 - thank you very much, @jplu " ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Seems to be an edge case from cleaning up tokenization on decoding :\r\n\r\nhttps://github.com/huggingface/transformers/blob/c0b93a1c7a961e30b30d02d641c9d22120ef5d73/src/transformers/tokenization_utils_base.py#L2688\r\n\r\n---\r\n\r\nFor this specific case, a work-around can be :\r\n\r\n`ss = tokenizer.decode(input_ids, skip_special_tokens=True, clean_up_tokenization_spaces=False)`\r\n\r\n---\r\n\r\nBut I think it's a bug. Is there any way to improve `clean_up_tokenization()` function ? \r\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=h1) Report\n> Merging [#6163](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/a2f6d521c1d7ebd7e079bc62bee014c8d00b2547&el=desc) will **increase** coverage by `1.02%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6163 +/- ##\n==========================================\n+ Coverage 78.59% 79.61% +1.02% \n==========================================\n Files 146 146 \n Lines 26597 26597 \n==========================================\n+ Hits 20904 21176 +272 \n+ Misses 5693 5421 -272 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/benchmark/benchmark\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9iZW5jaG1hcmsvYmVuY2htYXJrX3V0aWxzLnB5) | `69.50% <ø> (ø)` | |\n| [src/transformers/tokenization\\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmFydC5weQ==) | `60.56% <0.00%> (-35.22%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `64.18% <0.00%> (-34.62%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `71.65% <0.00%> (-23.68%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `81.70% <0.00%> (-4.77%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `88.19% <0.00%> (+63.97%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6163/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `96.77% <0.00%> (+73.38%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=footer). Last update [a2f6d52...4d3f303](https://codecov.io/gh/huggingface/transformers/pull/6163?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[]

[]

[]

[]

[ { "login": "mfuntowicz", "id": 2241520, "node_id": "MDQ6VXNlcjIyNDE1MjA=", "avatar_url": "https://avatars.githubusercontent.com/u/2241520?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mfuntowicz", "html_url": "https://github.com/mfuntowicz", "followers_url": "https://api.github.com/users/mfuntowicz/followers", "following_url": "https://api.github.com/users/mfuntowicz/following{/other_user}", "gists_url": "https://api.github.com/users/mfuntowicz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mfuntowicz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mfuntowicz/subscriptions", "organizations_url": "https://api.github.com/users/mfuntowicz/orgs", "repos_url": "https://api.github.com/users/mfuntowicz/repos", "events_url": "https://api.github.com/users/mfuntowicz/events{/privacy}", "received_events_url": "https://api.github.com/users/mfuntowicz/received_events", "type": "User", "site_admin": false } ]

[ "This issue also applies to the `truncation` parameter.\r\n\r\nI assumed the enums are supposed to be used directly because the release notes (https://github.com/huggingface/transformers/releases/tag/v3.0.0) explicitly mention the `TensorType` enum, which is defined right below the `PaddingStrategy` and `TruncationStrategy` enums.\r\n\r\nI agree that this is a problem that should be fixed, if the enums are meant to be used.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "I think we should fix this, wdyt @LysandreJik ?", "I believe this was already fixed by https://github.com/huggingface/transformers/pull/7610", "Nice, thanks!" ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "The model assign correctness probability to every answer it produce. if this probability crossing the threshold it means that the model predict their is no answer to the question. The threshold is picked as the threshold that achieve the best f1/exact score on the dev set. The best f1/exact is the result achieved with the best threshold found.\r\n\r\nUnfortunately, their is a [bug](https://github.com/huggingface/transformers/pull/7319) in run_squad.py code which was used for the training and evaluation of most of the models in the library and the results you see in their model cards are incorrect. ", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "This issue has been automatically marked as stale and been closed because it has not had recent activity. Thank you for your contributions.\n\nIf you think this still needs to be addressed please comment on this thread." ]

[ { "id": 1314768611, "node_id": "MDU6TGFiZWwxMzE0NzY4NjEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": null } ]

[]

[ "Hi! Do you mind pasting your environment information here so that we may take a look?", "Try to delete cache directory files.", "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n", "Hey, I trained my model on GPT2-small but I am not able to load it! It gives off the following error:\r\n\r\n Unable to load weights from pytorch checkpoint file for '{pretrained_model_name_or_path}' OSError: Unable to load weights \r\n from pytorch checkpoint file for '/mounted/models/train-on-test1/' at '/mounted/models/train-on-test1/pytorch_model.bin' If you \r\n tried to load a PyTorch model from a TF 2.0 checkpoint, please set from_tf=True.\r\n\r\n@leeivan @LysandreJik ", "Please open a new issue with your specific problem, alongside all the information related to your environment as asked in the template. Thank you.", "Same as <https://github.com/huggingface/transformers/issues/6620>, i guess it is because the checkpoint file is not a true checkpoint file: such as a git lfs file.", "#6159, #6970, #6620 are all same issue. \r\nIn my case I cloned the checkpoint file using git lfs and issue was resolved. Earlier I had used pointer to avoid git lfs however it gave this error. \r\nFor some changing torch, transformer, tokenizer versions helped. \r\nAlso you can go through the docs and check some from_pretrained parameters like force_download, from_tf and try.", "For futuer visitors: [check this](https://discuss.pytorch.org/t/getting-an-error-unpicklingerror-invalid-load-key-v-in-pytorch-model-deploying-in-streamlit/107768/4)" ]

[ { "id": 1838412367, "node_id": "MDU6TGFiZWwxODM4NDEyMzY3", "url": "https://api.github.com/repos/huggingface/transformers/labels/model%20card", "name": "model card", "color": "92d5f4", "default": false, "description": "Related to pretrained model cards" } ]

[ { "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "site_admin": false } ]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=h1) Report\n> Merging [#6158](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/ec0267475c16a1913e64cb4f81fd54d153e3d815&el=desc) will **decrease** coverage by `1.02%`.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6158 +/- ##\n==========================================\n- Coverage 79.38% 78.36% -1.03% \n==========================================\n Files 146 146 \n Lines 26454 26454 \n==========================================\n- Hits 21001 20730 -271 \n- Misses 5453 5724 +271 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_tf\\_mobilebert.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9tb2JpbGViZXJ0LnB5) | `23.38% <0.00%> (-73.39%)` | :arrow_down: |\n| [src/transformers/generation\\_tf\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9nZW5lcmF0aW9uX3RmX3V0aWxzLnB5) | `86.46% <0.00%> (+0.75%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.60% <0.00%> (+1.16%)` | :arrow_up: |\n| [src/transformers/tokenization\\_xlm\\_roberta.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtX3JvYmVydGEucHk=) | `95.23% <0.00%> (+10.71%)` | :arrow_up: |\n| [src/transformers/tokenization\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fb3BlbmFpLnB5) | `84.09% <0.00%> (+12.87%)` | :arrow_up: |\n| [src/transformers/tokenization\\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fbWFyaWFuLnB5) | `93.80% <0.00%> (+25.66%)` | :arrow_up: |\n| [src/transformers/modeling\\_tf\\_gpt2.py](https://codecov.io/gh/huggingface/transformers/pull/6158/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9ncHQyLnB5) | `95.32% <0.00%> (+29.90%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=footer). Last update [ec02674...a662ce9](https://codecov.io/gh/huggingface/transformers/pull/6158?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "`check_code_quality` failed with:\r\n\r\n```\r\n torch from https://files.pythonhosted.org/packages/38/53/914885a93a44b96c0dd1c36f36ff10afe341f091230aad68f7228d61db1e/torch-1.6.0-cp36-cp36m-manylinux1_x86_64.whl#sha256=7669f4d923b5758e28b521ea749c795ed67ff24b45ba20296bc8cff706d08df8 (from transformers==3.0.2):\r\n Expected sha256 7669f4d923b5758e28b521ea749c795ed67ff24b45ba20296bc8cff706d08df8\r\n Got 36bbf4ab202de410d764b9156f3925b7d7037ad046f20690e576725a3826a2ac\r\n```\r\n\r\nI don't see how this latest commit could have caused this. I'll retry later", "See https://github.com/huggingface/transformers/pull/6219" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=h1) Report\n> Merging [#6157](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/ec0267475c16a1913e64cb4f81fd54d153e3d815&el=desc) will **increase** coverage by `0.40%`.\n> The diff coverage is `67.47%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6157 +/- ##\n==========================================\n+ Coverage 79.38% 79.79% +0.40% \n==========================================\n Files 146 146 \n Lines 26454 26607 +153 \n==========================================\n+ Hits 21001 21230 +229 \n+ Misses 5453 5377 -76 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/\\_\\_init\\_\\_.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9fX2luaXRfXy5weQ==) | `99.24% <ø> (ø)` | |\n| [src/transformers/benchmark/benchmark\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9iZW5jaG1hcmsvYmVuY2htYXJrX3V0aWxzLnB5) | `69.50% <ø> (ø)` | |\n| [src/transformers/modeling\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `87.35% <ø> (ø)` | |\n| [src/transformers/tokenization\\_bert\\_japanese.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYmVydF9qYXBhbmVzZS5weQ==) | `32.05% <0.00%> (+1.56%)` | :arrow_up: |\n| [src/transformers/trainer\\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3RmLnB5) | `13.09% <ø> (-3.05%)` | :arrow_down: |\n| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.14% <23.94%> (-1.83%)` | :arrow_down: |\n| [src/transformers/pipelines.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9waXBlbGluZXMucHk=) | `79.36% <84.34%> (+0.86%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHMucHk=) | `90.40% <88.88%> (+0.44%)` | :arrow_up: |\n| [src/transformers/hf\\_argparser.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9oZl9hcmdwYXJzZXIucHk=) | `69.23% <100.00%> (+2.96%)` | :arrow_up: |\n| [src/transformers/tokenization\\_utils\\_base.py](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fdXRpbHNfYmFzZS5weQ==) | `93.83% <100.00%> (+1.39%)` | :arrow_up: |\n| ... and [11 more](https://codecov.io/gh/huggingface/transformers/pull/6157/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=footer). Last update [603cd81...d95e283](https://codecov.io/gh/huggingface/transformers/pull/6157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]

[ { "id": 1108649053, "node_id": "MDU6TGFiZWwxMTA4NjQ5MDUz", "url": "https://api.github.com/repos/huggingface/transformers/labels/Help%20wanted", "name": "Help wanted", "color": "008672", "default": false, "description": "Extra attention is needed, help appreciated" }, { "id": 2009457320, "node_id": "MDU6TGFiZWwyMDA5NDU3MzIw", "url": "https://api.github.com/repos/huggingface/transformers/labels/translation", "name": "translation", "color": "b2d2f4", "default": false, "description": "machine translation utilities and models" } ]

[ { "login": "sshleifer", "id": 6045025, "node_id": "MDQ6VXNlcjYwNDUwMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6045025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sshleifer", "html_url": "https://github.com/sshleifer", "followers_url": "https://api.github.com/users/sshleifer/followers", "following_url": "https://api.github.com/users/sshleifer/following{/other_user}", "gists_url": "https://api.github.com/users/sshleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/sshleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sshleifer/subscriptions", "organizations_url": "https://api.github.com/users/sshleifer/orgs", "repos_url": "https://api.github.com/users/sshleifer/repos", "events_url": "https://api.github.com/users/sshleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/sshleifer/received_events", "type": "User", "site_admin": false } ]

[ "Hi @sshleifer, I'd like to contribute and help out here if still needed. My thinking is to remove ```decoder_start_token_id``` from run_eval.py and generation_utils.py and change the following code:\r\n\r\nhttps://github.com/huggingface/transformers/blob/6028ed92bd9e5471e6f8a1d23cfd95a3a63018fb/src/transformers/generation_utils.py#L403-L409\r\n\r\nto:\r\n\r\n input_ids = torch.full(\r\n (effective_batch_size * num_beams, 1),\r\n 250020,\r\n dtype=torch.long,\r\n device=next(self.parameters()).device,\r\n )", "I dont think that change will do anything since decoder_start_token_id = 250020.\r\n\r\nWhat I would do is change the 250020 to a bos_token_id (0, I think) or a pad_token_id (1) and see what the BLEU score is. \r\n", "Ah yes that makes sense. I tried those two and the eos_token_id and got the following results:\r\n\r\nID | BLEU Score\r\n-- | --\r\neos_token_id (2) | 28.22\r\ndecoder_start_token_id (250020) | 28.06\r\npad_token_id (1) | 26.79\r\nbos_token_id (0) | 26.01\r\n\r\n", "Super interesting, thanks for running that. It seems like I should change decoder_start_token_id in the mbart-large-en-ro config to 2. Do you have opinions on mbart-large-cc25?", "No problem! Yes I think configuring decoder_start_token_id to 2 is a good idea. Unfortunately, I'm getting the same issues you're getting with mbart-large-cc25 (output's in English not Romanian and missing the first word when I use bos_token_id or 250020 and gibberish with eos/pad_token_id) and don't understand why that's the case. I'll investigate and post any useful findings.\r\n\r\n\r\n", "I think I fixed this another way in #6526 \r\non master\r\n```\r\npython run_eval.py facebook/mbart-large-en-ro $ENRO_DIR/test.source eos_baseline_enro_test_generations.txt \\\r\n--reference_path $ENRO_DIR/test.target \\\r\n--score_path baseline_test_bleu_eos.json --bs 32 --task translation --fp16\r\n```\r\n=> {'bleu': 26.81}\r\n\r\n\r\n```\r\npython run_eval.py facebook/mbart-large-en-ro $ENRO_DIR/test.source \\\r\neos_baseline_enro_test_generations.txt --reference_path $ENRO_DIR/test.target \\\r\n--score_path baseline_test_bleu_eos.json --bs 32 --task translation --fp16 \\\r\n--decoder_start_token_id 2\r\n```\r\n{'bleu': 11.57} (and takes 40 mins!)\r\n\r\nin the original fairseq I get 26.83.", "Gunna close this since the score is now basically the same as fairseq. Thanks for your help!" ]

[]

[]

[ "# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=h1) Report\n> Merging [#6155](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/91cb95461e438dc57555c4f57f8ce95a56328036&el=desc) will **increase** coverage by `0.10%`.\n> The diff coverage is `75.00%`.\n\n[](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #6155 +/- ##\n==========================================\n+ Coverage 78.35% 78.46% +0.10% \n==========================================\n Files 146 146 \n Lines 26454 26454 \n==========================================\n+ Hits 20729 20758 +29 \n+ Misses 5725 5696 -29 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/transformers/modeling\\_encoder\\_decoder.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbmNvZGVyX2RlY29kZXIucHk=) | `92.20% <ø> (ø)` | |\n| [src/transformers/modeling\\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `82.25% <66.66%> (-0.38%)` | :arrow_down: |\n| [src/transformers/modeling\\_reformer.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19yZWZvcm1lci5weQ==) | `95.49% <100.00%> (-0.21%)` | :arrow_down: |\n| [src/transformers/modeling\\_tf\\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.22% <0.00%> (-63.98%)` | :arrow_down: |\n| [src/transformers/modeling\\_longformer.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19sb25nZm9ybWVyLnB5) | `89.21% <0.00%> (-2.24%)` | :arrow_down: |\n| [src/transformers/modeling\\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19lbGVjdHJhLnB5) | `81.55% <0.00%> (-0.29%)` | :arrow_down: |\n| [src/transformers/modeling\\_t5.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190NS5weQ==) | `83.71% <0.00%> (ø)` | |\n| [src/transformers/modeling\\_xlnet.py](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ194bG5ldC5weQ==) | `81.75% <0.00%> (ø)` | |\n| ... and [5 more](https://codecov.io/gh/huggingface/transformers/pull/6155/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=footer). Last update [91cb954...33ebdb9](https://codecov.io/gh/huggingface/transformers/pull/6155?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n" ]