id
int64
1
6.5k
bug_id
int64
2.03k
426k
summary
stringlengths
9
251
description
stringlengths
1
32.8k
report_time
stringlengths
19
19
report_timestamp
int64
1B
1.39B
status
stringclasses
6 values
commit
stringlengths
7
9
commit_timestamp
int64
1B
1.39B
files
stringlengths
25
32.8k
project_name
stringclasses
6 values
210
54,198
Bug 54198 Improve HttpServletResponse#sendError(int) JavaDoc description
This methods calls sendError(int, null) internally. Thus generating a HTML page without a message. This is not mentioned in the docs. One could assume that the response will be empty. One could duplicate the first paragraph of the sendError(int,String) method and alter it to "The server defaults to creating the response to look like an HTML-formatted server error page with any specific message, setting the content type to "text/html",..." further "If an error-page declaration has been made for the web application corresponding to the status code passed in, it will be served back." (Might need improvement in this case, I am not a native speaker). Moreover, I would add "This method is effectively the same as calling sendError(int, null)". Plus add @see #sendError(int,String). Though the JavaDocs seems to be a verbatim copy of Oracle's Servlet API, it does not reveal this information explicitly. Should I provide a patch if that doc is available in svn.apache.org?
2012-11-23 22:33:12
1,353,730,000
resolved fixed
3c13e90
1,353,930,000
java/javax/servlet/http/HttpServletResponse.java
Tomcat
211
54,144
Bug 54144 Processing of java.io.Reader in "Out" tagplugin
null
2012-11-14 08:38:29
1,352,900,000
resolved fixed
7c4a841
1,353,110,000
java/org/apache/jasper/tagplugins/jstl/Util.java java/org/apache/jasper/tagplugins/jstl/core/Out.java test/org/apache/jasper/tagplugins/jstl/core/TestOut.java
Tomcat
212
54,143
Bug 54143 Add display of PermGen memory pool usage to the Status page of the Manager webapp
null
2012-11-13 22:39:44
1,352,860,000
resolved fixed
9998c80
1,352,850,000
java/org/apache/catalina/manager/StatusTransformer.java
Tomcat
213
54,141
Bug 54141 Configuration does not allow Realms to be nested more than 2 levels deep
null
2012-11-13 01:55:35
1,352,790,000
resolved fixed
2ed3d7d
1,352,820,000
java/org/apache/catalina/startup/RealmRuleSet.java
Tomcat
214
54,087
Bug 54087 HTTP Connector incorrectly throws Exception on Invalid If-Modified-Since Header
null
2012-11-01 16:10:42
1,351,800,000
resolved fixed
810732d
1,352,720,000
java/javax/servlet/http/HttpServlet.java
Tomcat
215
54,115
Bug 54115 Minor enhancements to HttpClient test helper class
null
2012-11-07 17:10:11
1,352,330,000
resolved fixed
8f53c89
1,352,680,000
test/org/apache/catalina/startup/SimpleHttpClient.java
Tomcat
216
54,124
Bug 54124 wrong javax.servlet.async.request_uri information and javax.servlet.async.path_info is missing
As it is clearly shown that org.apache.catalina.core.AsyncContextImpl.dispatch(ServletContext, String) @Override public void dispatch(ServletContext context, String path) { if (log.isDebugEnabled()) { logDebug("dispatch "); } check(); if (request.getAttribute(ASYNC_REQUEST_URI)==null) { request.setAttribute(ASYNC_REQUEST_URI, request.getRequestURI()+"?"+request.getQueryString()); request.setAttribute(ASYNC_CONTEXT_PATH, request.getContextPath()); request.setAttribute(ASYNC_SERVLET_PATH, request.getServletPath()); request.setAttribute(ASYNC_QUERY_STRING, request.getQueryString()); } .... } the value of ASYNC_REQUEST_URI is not the same as request.getRequestURI(). They must be equal to each other as defined by Servlet 3.0, 9.7.2 Dispatched Request Parameters. And ASYNC_PATH_INFO is missing.
2012-11-09 10:42:29
1,352,480,000
resolved fixed
76f84eb
1,352,680,000
java/org/apache/catalina/core/AsyncContextImpl.java
Tomcat
217
54,123
Bug 54123 servlet 3.0 spec violation in async timeout processing
null
2012-11-09 10:30:48
1,352,480,000
resolved fixed
14637ef
1,352,680,000
java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/StandardHostValve.java java/org/apache/coyote/AsyncStateMachine.java test/org/apache/catalina/core/TestAsyncContextImpl.java
Tomcat
218
54,127
Bug 54127 WsOutbound is missing a ping method
null
2012-11-09 20:23:13
1,352,510,000
resolved fixed
8fea85c
1,352,490,000
java/org/apache/catalina/websocket/WsOutbound.java
Tomcat
219
54,096
Bug 54096 env-entry rejects legal types
In servlet 3.0 the type in an env-entry can be any type which has a public constructor taking a single String (or character) as an argument. Tomcat only accepts a fixed list of types (see NamingContextListener from line 813). This is legal in web.xml but not accepted by tomcat: <env-entry> <env-entry-name>location</env-entry-name> <env-entry-type>java.io.File</env-entry-type> <env-entry-value>/var/lib/tomcat</env-entry-value> </env-entry>
2012-11-04 18:43:14
1,352,070,000
resolved fixed
48314f9
1,352,490,000
java/org/apache/catalina/core/NamingContextListener.java test/org/apache/catalina/core/TestNamingContextListener.java
Tomcat
220
54,076
Bug 54076 SPNEGO authenticator's stateless-ness incompatible with stateful clients
null
2012-10-30 13:49:27
1,351,620,000
resolved fixed
9f65875
1,351,980,000
java/org/apache/catalina/authenticator/SpnegoAuthenticator.java
Tomcat
221
54,068
Bug 54068 Web fragment sorting incorrectly detects circular reference
null
2012-10-30 05:30:27
1,351,590,000
resolved fixed
07d343a
1,351,720,000
java/org/apache/catalina/deploy/WebXml.java test/org/apache/catalina/deploy/TestWebXmlOrdering.java
Tomcat
222
54,067
Bug 54067 Upgrade Response with Transfer-Encoding: chunked invalid
null
2012-10-29 17:23:09
1,351,550,000
resolved fixed
9308b3f
1,351,540,000
java/org/apache/coyote/http11/AbstractHttp11Processor.java
Tomcat
223
53,867
Bug 53867 Performance tuning solution for PageContextImpl.XmlEscape
null
2012-09-13 13:33:48
1,347,560,000
resolved fixed
c40ca99
1,351,460,000
java/org/apache/jasper/runtime/PageContextImpl.java test/org/apache/jasper/runtime/TesterPageContextImpl.java
Tomcat
224
54,054
Bug 54054 2 CGIServlet's with different Parameter passShellEnvironment
null
2012-10-26 07:24:33
1,351,250,000
resolved fixed
05fe671
1,351,280,000
java/org/apache/catalina/servlets/CGIServlet.java
Tomcat
225
54,022
Bug 54022 CometEvent.END event is not sent on a suspended socket disconnect when running with Tomcat Native (tcnative-1.dll) on Windows Vista / Windows Server 2008 or newer.
null
2012-10-17 18:18:23
1,350,510,000
resolved fixed
874c332
1,351,200,000
java/org/apache/coyote/AbstractProtocol.java
Tomcat
226
54,017
Bug 54017 new String instance is generated for constant string in Generator.convertString
If the target class is "Object.class", the generator generates "new String(" + quoted + ")"; as attribute value for Tag Handler. How about using quoted directly same as when the target class is "Object.class"? Creating a String instance will cause some overhead from memory allocation and hash code recaluation when it is used as a key on HashMap. Here is the detail code, /* * @param c The target class to which to coerce the given string @param * s The string value @param attrName The name of the attribute whose * value is being supplied @param propEditorClass The property editor * for the given attribute @param isNamedAttribute true if the given * attribute is a named attribute (that is, specified using the * jsp:attribute standard action), and false otherwise */ private String convertString(Class<?> c, String s, String attrName, Class<?> propEditorClass, boolean isNamedAttribute) { String quoted = s; if (!isNamedAttribute) { quoted = quote(s); } if (propEditorClass != null) { String className = c.getCanonicalName(); return "(" + className + ")org.apache.jasper.runtime.JspRuntimeLibrary.getValueFromBeanInfoPropertyEditor(" + className + ".class, \"" + attrName + "\", " + quoted + ", " + propEditorClass.getCanonicalName() + ".class)"; } else if (c == String.class) { return quoted; } else if (c == boolean.class) { return JspUtil.coerceToPrimitiveBoolean(s, isNamedAttribute); } else if (c == Boolean.class) { return JspUtil.coerceToBoolean(s, isNamedAttribute); } else if (c == byte.class) { return JspUtil.coerceToPrimitiveByte(s, isNamedAttribute); } else if (c == Byte.class) { return JspUtil.coerceToByte(s, isNamedAttribute); } else if (c == char.class) { return JspUtil.coerceToChar(s, isNamedAttribute); } else if (c == Character.class) { return JspUtil.coerceToCharacter(s, isNamedAttribute); } else if (c == double.class) { return JspUtil.coerceToPrimitiveDouble(s, isNamedAttribute); } else if (c == Double.class) { return JspUtil.coerceToDouble(s, isNamedAttribute); } else if (c == float.class) { return JspUtil.coerceToPrimitiveFloat(s, isNamedAttribute); } else if (c == Float.class) { return JspUtil.coerceToFloat(s, isNamedAttribute); } else if (c == int.class) { return JspUtil.coerceToInt(s, isNamedAttribute); } else if (c == Integer.class) { return JspUtil.coerceToInteger(s, isNamedAttribute); } else if (c == short.class) { return JspUtil.coerceToPrimitiveShort(s, isNamedAttribute); } else if (c == Short.class) { return JspUtil.coerceToShort(s, isNamedAttribute); } else if (c == long.class) { return JspUtil.coerceToPrimitiveLong(s, isNamedAttribute); } else if (c == Long.class) { return JspUtil.coerceToLong(s, isNamedAttribute); } else if (c == Object.class) { return "new String(" + quoted + ")"; } else { String className = c.getCanonicalName(); return "(" + className + ")org.apache.jasper.runtime.JspRuntimeLibrary.getValueFromPropertyEditorManager(" + className + ".class, \"" + attrName + "\", " + quoted + ")"; } }
2012-10-17 08:47:42
1,350,480,000
resolved fixed
095a403
1,351,170,000
java/org/apache/jasper/compiler/Generator.java
Tomcat
227
54,012
Bug 54012 No "pageContext" in tag files' generated java code when using code generation by JSTL tagplugin "Set"
null
2012-10-16 09:01:56
1,350,390,000
resolved fixed
a0ff3f9
1,351,170,000
java/org/apache/jasper/compiler/Compiler.java java/org/apache/jasper/compiler/PageInfo.java java/org/apache/jasper/compiler/TagPluginManager.java java/org/apache/jasper/compiler/tagplugin/TagPluginContext.java java/org/apache/jasper/tagplugins/jstl/core/Set.java
Tomcat
228
54,045
Bug 54045 ReplicatedMap don't like TcpFailureDetector in static configuration
Tribes stack using: * TcpPingInterceptor * TcpFailureDetector * MessageDispatchInterceptor * StaticMembershipInterceptor Do not work well in static cluster. First side (ie one thread): * call to TcpFailureDetector.heartbeat() * call to checkMembers(false) * call to performBasicCheck() in synchronized(membership) * in performBasicCheck, for a missing static node: * add "missing" member to membership with membership.memberAlive(m) * HERE THE SECOND THREAD HAVE SOME TIME TO WORK * check it with memberAlive(m) * remove it since if it doesn't exist Second side (ie another thread): * some call to channel.getMembers() like what the done by AbstractReplicatedMap * this call will call the TcpFailureDetector.getMembers() * this one could return a wrong value since it can contains unavailable nodes Note: * synchronize on membership isn't use by TcpFailureDetector in getMember(), getMembers(), hasMembers(), neither in Membership equivalent method (maybe because it's too heavy to lock every thread while the TcpFailureDetector check if node are alive). It must not be an issue for AbstractReplicatedMap since with or without TcpFailureDetector a node could disapear while replicated map try to use it. But ReplicatedMap use always Channel.SEND_OPTIONS_DEFAULT where the value is Channel.SEND_OPTIONS_USE_ACK. So a message sent to a missing node will fail with an exception. Personnaly I override TcpFailureDetector.heartbeat() to avoid performBasicCheck() if I use a static configuration (TcpPingInterceptor call performForcedCheck()). But this doesn't fix ReplicatedMap issue. Better fix could avoid adding missing member to membership list: * Add a method like memberAlive(MemberImpl) to Membership without side effect (add the member) * in TcpFailureDetector.performBasicCheck(): check this new method before adding the node This doesn't fix the AbstractReplicatedMap issue which work always with acknoledge from other nodes. Same code for Tomcat 6. best regards F.Arnoud
2012-10-23 16:03:53
1,351,020,000
resolved fixed
d2b41b5
1,351,170,000
java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
Tomcat
229
54,010
Bug 54010 Suggestion for code improvement (avoiding potential bug)
In connectors/jk/java/org/apache/jk/common/HandlerRequest.java coyote.Request's schemeMB is assigned in 2 places. 1st place: 400 boolean isSSL = msg.getByte() != 0; 401 if( isSSL ) { 402 // XXX req.setSecure( true ); 403 req.scheme().setString("https"); 404 } 2nd place: 518 case AjpConstants.SC_A_SSL_CERT : 519 req.scheme().setString( "https" ); and similar assignments for SC_A_SSL_CIPHER and SC_A_SSL_SESSION cases below. It seems they do not make sense because the packet's 8-bit field is designated for telling whether it's SSL or not. So the 1st place is enough. Adding the 2nd place may pose potential bug in that a packet with the 8-bit SSL field being 0 and suffixes of SC_A_SSL_* key-value pairs can later incorrect trigger a wrong redirection message pointing to a https location. A simple correction is to honor the 8-bit SSL-field in packet and delete the 3 lines of 2nd place assigning "https". Even though the chances of such spurious packet is low, but it's best we can have threat-free, semantic-correct tomcat code. The same lines of code remain in 6.0 and 7.0. But maybe I misunderstand the code, in which case please kindly point out. Thanks.
2012-10-16 02:20:47
1,350,370,000
resolved fixed
9f04094
1,350,950,000
java/org/apache/coyote/ajp/AbstractAjpProcessor.java
Tomcat
230
53,993
Bug 53993 NPE in AccessLogValve
During a load test of tomcat 7.0.30, we occasionally see NPEs from the AccessLogValve. Some of the requests that are being executed as part of the load test call HttpSession.invalidate. I mention this because the code in question appears to be susceptible to multithreaded manipulation of the session. I think the fix should be as simple as a check for null on the return value of request.getSessionInternal. Of course, our access log pattern includes logging the session id. java.lang.NullPointerException org.apache.catalina.valves.AccessLogValve$SessionIdElement.addElement(AccessLogValve.java:1733) org.apache.catalina.valves.AccessLogValve.log(AccessLogValve.java:955) org.apache.catalina.core.AccessLogAdapter.log(AccessLogAdapter.java:51) org.apache.catalina.core.StandardEngine.logAccess(StandardEngine.java:332) org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1270) org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1270) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:441) org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1002) org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585) org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) java.lang.Thread.run(Thread.java:722) existing code for convenience: protected static class SessionIdElement implements AccessLogElement { @Override public void addElement(StringBuilder buf, Date date, Request request, Response response, long time) { if (request != null) { if (request.getSession(false) != null) { buf.append(request.getSessionInternal(false) // LINE 1733 .getIdInternal()); } else { buf.append('-'); } } else { buf.append('-'); } } } possible fix: ... if (request.getSession(false) != null) { Session internalSession = request.getSessionInternal(false); if (internalSession != null) { buf.append(internalSession.getIdInternal()); } else { buf.append('-'); } } else { buf.append('-'); }
2012-10-11 19:56:38
1,350,000,000
resolved fixed
39c4270
1,350,140,000
java/org/apache/catalina/valves/AccessLogValve.java
Tomcat
231
53,986
Bug 53986 Comment end tag preceded directly by a dash causes JSP fail compilation
null
2012-10-09 18:40:08
1,349,820,000
resolved fixed
88d8dd5
1,349,880,000
java/org/apache/jasper/compiler/JspReader.java test/org/apache/jasper/compiler/TestJspReader.java
Tomcat
232
53,854
Bug 53854 DefaultServlet directory listings for aliased directories do not seem to work
null
2012-09-11 20:28:09
1,347,410,000
resolved fixed
a3e0f09
1,349,030,000
java/org/apache/naming/resources/BaseDirContext.java java/org/apache/naming/resources/FileDirContext.java java/org/apache/naming/resources/WARDirContext.java
Tomcat
233
53,863
Bug 53863 Unable to override default servlet when using Tomcat in embedded mode
An implementation of ServletContainerInitializer can't add a mapping to "/" because the default servlet is loaded first, as first reported in 51278: public final class SampleServletContainerInitializer implements ServletContainerInitializer { public void onStartup(final Set<Class<?>> c, final ServletContext ctx) throws ServletException { final XmlWebApplicationContext appCtx = new XmlWebApplicationContext(); appCtx.setConfigLocation("/WEB-INF/DispatcherServlet-servlet.xml"); final ServletRegistration.Dynamic dispatcher = ctx.addServlet("DispatcherServlet", new DispatcherServlet(appCtx)); dispatcher.setLoadOnStartup(1); final Set<String> conflictSet = dispatcher.addMapping("/"); for (final String conflict : conflictSet) out.println(conflict); // prints "/" } } A test case follows attached.
2012-09-13 03:44:28
1,347,520,000
resolved fixed
7f6f99e
1,347,820,000
java/org/apache/catalina/startup/Tomcat.java
Tomcat
234
52,777
Bug 52777 Automatically shut down old versions in parallel deployment
Under parallel deployment, when an older version in an application has zero sessions, shut it down automatically to release tomcat and JVM resources. Christopher Schultz suggested these approaches might be possible (on the Tomcat user list): 1. Modify the parallel deployment code to register an MBean NotificationListener that filters for useful events (such as expiring session notifications on the outgoing webapp). 2. When the listener receives a notification, check the current state (e.g. session count=0; or, I suppose you could make this a part of your filter in step #1). If session count = 0, start a new thread that stops the outgoing webapp and de-registers the listener. Or. 1. Install a SessionEventListener that counts-down the sessions (you'll have to get the count from JMX, I suppose) until they equal 0, then starts a new thread that ... etc. Or. 1. Install a Timer thread that polls at intervals (1 minute?) to see if all the sessions are dead and then starts a thread ... etc. The first idea seems the cleanest, though Tomcat might not actually fire MBean events for things like session count changing.
2012-02-27 03:30:27
1,330,330,000
resolved fixed
97cefcc
1,347,140,000
java/org/apache/catalina/Host.java java/org/apache/catalina/core/StandardHost.java java/org/apache/catalina/startup/HostConfig.java
Tomcat
235
53,713
Bug 53713 Performance tuning solution for JspReader
null
2012-08-14 06:28:58
1,344,940,000
resolved fixed
5fccf68
1,346,880,000
java/org/apache/jasper/compiler/JspReader.java java/org/apache/jasper/compiler/Mark.java
Tomcat
236
53,828
Bug 53828 StreamInbound.closeOutboundConnection(WsFrame) closes with an opcode instead of status
201 private void closeOutboundConnection(WsFrame frame) throws IOException { 202 try { 203 getWsOutbound().close(frame); 204 } finally { 205 doOnClose(Constants.OPCODE_CLOSE); 206 } 207 } Line 205 uses the close opcode instead of a valid status (Constants.STATUS_*). Not sure of the exact context of this called but it seems to only be called when the last frame from the client was a close frame, thus a Constants.STATUS_NORMAL may be in order. If not, the frame's opcode could be inspected and mapped to an appropriate status (normal, shutdown, etc...). Thanks, Michael
2012-09-04 16:55:42
1,346,790,000
resolved fixed
a81d941
1,346,790,000
java/org/apache/catalina/websocket/StreamInbound.java
Tomcat
237
53,801
Bug 53801 Nondeterministic behaviour of security constraints
null
2012-08-30 09:14:42
1,346,330,000
resolved fixed
95d7a0f
1,346,370,000
java/org/apache/catalina/realm/RealmBase.java
Tomcat
238
53,800
Bug 53800 Infinte loop cause by FileDirContext in a CDI/Weld project when using Eclipse's "Server modules without publishing"
null
2012-08-30 06:19:19
1,346,320,000
resolved fixed
44eabba
1,346,310,000
java/org/apache/naming/resources/FileDirContext.java
Tomcat
239
53,793
Bug 53793 Change webapp links in Manager to point to /appname/ instead of /appname
The first column of the table that lists Web Applications in Tomcat Manager webapp contains links to those applications, e.g. <a href="/examples">/examples</a> When the link is clicked and browser navigates to "/examples", it results in 302 redirect to "/examples/". It would be better to change that link to point directly to "/examples/". <a href="/examples/">/examples</a> I am changing the link address only, but not the text on it. That is because the "Path" of the web application displayed in that column (and used in Manager commands elsewhere) does not have the additional '/'.
2012-08-28 21:50:21
1,346,210,000
resolved fixed
fcc3d65
1,346,190,000
java/org/apache/catalina/manager/HTMLManagerServlet.java
Tomcat
240
42,181
Bug 42181 ArrayIndexOutOfBoundsException in parseChunkHeader
Apr 22, 2007 11:53:32 AM org.apache.coyote.http11.Http11Processor process SEVERE: Error finishing request java.lang.ArrayIndexOutOfBoundsException: -28 at org.apache.coyote.http11.filters.ChunkedInputFilter.parseChunkHeader(ChunkedInputFilter.java:256) at org.apache.coyote.http11.filters.ChunkedInputFilter.doRead(ChunkedInputFilter.java:129) at org.apache.coyote.http11.filters.ChunkedInputFilter.end(ChunkedInputFilter.java:179) at org.apache.coyote.http11.InternalInputBuffer.endRequest(InternalInputBuffer.java:368) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:894) at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595)
2007-04-21 22:48:21
1,177,210,000
resolved fixed
cd05aa1
1,346,110,000
java/org/apache/coyote/http11/filters/ChunkedInputFilter.java java/org/apache/tomcat/util/buf/HexUtils.java test/org/apache/tomcat/util/buf/TestHexUtils.java
Tomcat
241
53,783
Bug 53783 Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found
null
2012-08-27 13:32:16
1,346,090,000
resolved fixed
6b934d8
1,346,090,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
242
53,758
Bug 53758 Dynamic Filter Registration mapping logic inverted
In the class org.apache.catalina.core.ApplicationFilterRegistration, the methods addMappingForServletNames and addMappingForUrlPatterns have inverted logic on how to register the filter to the context. If the parameter isMatchAfter is passed as true, the filter is placed in the context using the addFilterMapBefore method. if (isMatchAfter) { context.addFilterMapBefore(filterMap); } else { context.addFilterMap(filterMap); } The logic should ultimate be (in both methods): if (!isMatchAfter) { context.addFilterMapBefore(filterMap); } else { context.addFilterMap(filterMap); } or if (isMatchAfter) { context.addFilterMap(filterMap); } else { context.addFilterMapBefore(filterMap); } svn rev on trunk is 1375614
2012-08-21 19:59:03
1,345,590,000
resolved fixed
8f169e4
1,346,020,000
java/org/apache/catalina/core/ApplicationFilterRegistration.java
Tomcat
243
53,725
Bug 53725 Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
null
2012-08-15 18:28:36
1,345,070,000
resolved fixed
3dff241
1,345,930,000
java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java
Tomcat
244
53,714
Bug 53714 misleading log output when jarsToSkip cointains web-fragments
I have a jar which contains a web-fragment and no TLDs. When starting the server I get the Message: org.apache.jasper.compiler.TldLocationsCache tldScanJar INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time. so far so good. When adding it to the tomcat.util.scan.DefaultJarScanner.jarsToSkip property the web-fragment won't be scanned either. The log message should only be printed when no TLDs and web-fragments could be found in the jar.
2012-08-14 09:13:38
1,344,950,000
resolved fixed
15e8d8e
1,345,840,000
java/org/apache/catalina/startup/Constants.java java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/TldConfig.java java/org/apache/jasper/Constants.java java/org/apache/jasper/compiler/TldLocationsCache.java
Tomcat
245
53,697
Bug 53697 java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277)
I hit tomcat with ~20 different urls in ~2 seconds, test some functionality, wait ~3 minutes, then do it again and I always get this exception and then I get (intermitent) connection interrupted messages in the browser. Here's the full trace: Aug 10, 2012 6:33:14 PM org.apache.catalina.connector.CoyoteAdapter event SEVERE: null Aug 10, 2012 6:33:14 PM org.apache.catalina.connector.CoyoteAdapter event java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:846) at org.apache.coyote.Response.action(Response.java:172) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:229) at org.apache.coyote.http11.Http11AprProcessor.event(Http11AprProcessor.java:133) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:581) at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1770) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Aug 10, 2012 6:33:14 PM org.apache.coyote.http11.Http11AprProcessor event SEVERE: Error processing request java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:846) at org.apache.coyote.Request.action(Request.java:346) at org.apache.catalina.connector.Request.getRemoteAddr(Request.java:1281) at org.apache.catalina.connector.Request.getRemoteHost(Request.java:1296) at org.apache.catalina.valves.AccessLogValve$HostElement.addElement(AccessLogValve.java:1327) at org.apache.catalina.valves.AccessLogValve.log(AccessLogValve.java:953) at org.apache.catalina.core.AccessLogAdapter.log(AccessLogAdapter.java:51) at org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1263) at org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1270) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:250) at org.apache.coyote.http11.Http11AprProcessor.event(Http11AprProcessor.java:133) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:581) at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1770) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Additional information: - hp Proliant DL360 with two 3ghz processors - CentOS 6.3 - One app runs websockets under bleading edge Atmosphere and Grails - the 20 urls come from chrome and firefox, simulatneously
2012-08-11 08:33:54
1,344,690,000
resolved fixed
6c13431
1,345,070,000
java/org/apache/coyote/http11/AbstractHttp11Processor.java java/org/apache/coyote/http11/Http11NioProcessor.java
Tomcat
246
53,702
Bug 53702 Only the last url-pattern from jsp-property-group is processed
null
2012-08-12 14:54:17
1,344,800,000
resolved fixed
e38a097
1,345,060,000
java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java java/org/apache/catalina/deploy/JspPropertyGroup.java java/org/apache/catalina/deploy/WebXml.java java/org/apache/catalina/startup/WebRuleSet.java
Tomcat
247
53,654
Bug 53654 JSP file is always recompiled for using file based TLD URL
Now, in Jasper codes, it only supports jar URL and relative URL, that may be enough for common web applications. While, it is possible that the third-party uses other protocol URL, like file: protocol based URL. So, the JSP files will be always recompiled for each access for the target page. The codes are located in Compiler.isOutDated() method. Is it possible to provide more generic handlering for the URL ?
2012-08-05 14:47:43
1,344,190,000
resolved fixed
1efc23d
1,345,050,000
java/org/apache/jasper/compiler/Compiler.java
Tomcat
248
53,624
Bug 53624 sendRedirect doesn't work after a dispatch through the AsyncContext
null
2012-07-30 19:07:39
1,343,690,000
resolved fixed
e37b01e
1,344,980,000
java/org/apache/catalina/core/ApplicationDispatcher.java
Tomcat
249
53,701
Bug 53701 Javadoc fixes
null
2012-08-12 12:25:04
1,344,790,000
resolved fixed
2a3b42d
1,344,970,000
java/javax/servlet/ServletInputStream.java java/javax/servlet/ServletOutputStream.java java/javax/servlet/jsp/JspException.java java/org/apache/catalina/Executor.java java/org/apache/catalina/Manager.java java/org/apache/catalina/tribes/ErrorHandler.java java/org/apache/naming/SelectorContext.java java/org/apache/tomcat/util/http/fileupload/FileItem.java webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java
Tomcat
250
53,700
Bug 53700 InternalNioOutputBuffer unused (debug?) code
The class InternalNioOutputBuffer includes the field: int total = 0; This is currently defined at line 227, which is between the Javadoc and method body to which the Javadoc applies, i.e. private synchronized int writeToSocket. This invalidates the method Javadoc. The field is used to keep a running total of bytes written by the method; however the field is not actually referenced - the System.out.println statement is commented out. The field and associated code shcould probably be deleted. If the field is to be kept, it should be private, and it should probably be changed to long, and of course should be moved so it does not invalidate the method Javadoc.
2012-08-12 11:17:07
1,344,780,000
resolved fixed
a2ca744
1,344,970,000
java/org/apache/coyote/http11/InternalNioOutputBuffer.java
Tomcat
251
53,574
Bug 53574 metadata-complete="true" and servlet defined as jsp not working
We have a servlet defined as <servlet> <servlet-name>VersionInfoServlet</servlet-name> <jsp-file>/WEB-INF/svnrevision.jsp</jsp-file> </servlet> and mapped as <servlet-mapping> <servlet-name>VersionInfoServlet</servlet-name> <url-pattern>/svnrevision</url-pattern> </servlet-mapping> It worked fine. Then we changed metadata-complete to "true", and from now on we receive INFO: Marking servlet VersionInfoServlet as unavailable lip 20, 2012 11:05:36 AM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Allocate exception for servlet VersionInfoServlet javax.servlet.ServletException: No servlet class has been specified for servlet VersionInfoServlet at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1130) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:857) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:136) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.ajp.AjpNioProcessor.process(AjpNioProcessor.java:184) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722)
2012-07-20 09:35:23
1,342,790,000
resolved fixed
f9b0182
1,344,710,000
java/org/apache/catalina/startup/ContextConfig.java test/org/apache/catalina/startup/TestContextConfig.java
Tomcat
252
53,545
Bug 53545 jsp:forward action to static resources causes IllegalStateException when inside classic custom tag
null
2012-07-13 07:53:20
1,342,180,000
resolved fixed
5a6b27b
1,344,680,000
java/org/apache/jasper/runtime/PageContextImpl.java test/org/apache/jasper/runtime/TestPageContextImpl.java test/org/apache/tomcat/unittest/tags/Bug53545.java
Tomcat
253
53,541
Bug 53541 Bug in virtual webapp feature. Custom tags badly supported. Error is "org.apache.jasper.JasperException: The absolute uri: http://java.sun.com/jsp/jstl/core cannot be resolved in either web.xml or the jar files deployed with this application
null
2012-07-12 18:16:08
1,342,130,000
resolved fixed
432bd0f
1,344,630,000
java/org/apache/naming/resources/VirtualDirContext.java
Tomcat
254
53,481
Bug 53481 Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder
null
2012-06-28 14:27:30
1,340,910,000
resolved fixed
82e5dce
1,344,530,000
java/org/apache/coyote/http11/Http11AprProtocol.java java/org/apache/tomcat/util/net/AprEndpoint.java
Tomcat
255
53,641
Bug 53641 Wrong websocket's subprotocol implementation
According to RFC6455 Section 4.3. the handling of subprotocol requests is not correct. It must be checked for "Sec-WebSocket-Protocol" instead of "Sec-WebSocket-Protocol-Client" in WebSocketServlet class.
2012-08-02 12:52:08
1,343,930,000
resolved fixed
af45441
1,344,380,000
java/org/apache/catalina/websocket/WebSocketServlet.java
Tomcat
256
53,607
Bug 53607 No message set for PING: TcpPingInterceptor fail with NullPointerException in ChannelData.getDataPackageLength()
I added data.setMessage(new XByteBuffer(TCP_PING_DATA, false)); to TcpPingInterceptor send ping message function by: protected void sendPingMessage(Member[] members) { if ( members == null || members.length == 0 ) return; ChannelData data = new ChannelData(true);//generates a unique Id data.setAddress(getLocalMember(false)); data.setTimestamp(System.currentTimeMillis()); data.setOptions(getOptionFlag()); data.setMessage(new XByteBuffer(TCP_PING_DATA, false)); try { super.sendMessage(members, data, null); }catch (ChannelException x) { log.warn("Unable to send TCP ping.",x); } } error also for Tomcat 6 regards fred
2012-07-26 18:33:54
1,343,340,000
resolved fixed
57b56f2
1,343,720,000
java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Tomcat
257
53,606
Bug 53606 NullPointerException in TcpPingInterceptor
start(int) method initializes failureDetector (resp. staticMembers) only if TcpFailureDetector (resp. StaticMembershipInterceptor) was found in channel interceptors stack. Without TcpFailureDetector (resp. StaticMembershipInterceptor), futur calls to sendPing() will fail because failureDetector (resp. staticMembers) wasn't initialized at least to new WeakReference<StaticMembershipInterceptor>(null). Fix: v1) initializes weak references containers: Replace: WeakReference<TcpFailureDetector> failureDetector = null; WeakReference<StaticMembershipInterceptor> staticMembers = null; for: WeakReference<TcpFailureDetector> failureDetector = new WeakReference<TcpFailureDetector>(); WeakReference<StaticMembershipInterceptor> staticMembers = new WeakReference<StaticMembershipInterceptor>(); v2) checks field before dereferencing it: sendPing becomes: protected void sendPing() { if (failureDetector!=null && failureDetector.get()!=null) { //we have a reference to the failure detector //piggy back on that dude failureDetector.get().checkMembers(true); }else { if (staticOnly && staticMembers!=null && staticMembers.get()!=null) { sendPingMessage(staticMembers.get().getMembers()); } else { sendPingMessage(getMembers()); } } } affect also tomcat 6 regards fred arnoud
2012-07-26 16:15:05
1,343,330,000
resolved fixed
eb9f94e
1,343,600,000
java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Tomcat
258
53,535
Bug 53535 Out of memory while performing ContextConfig.webConfig
null
2012-07-11 10:29:10
1,342,020,000
resolved fixed
7db08d3
1,343,600,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
259
53,469
Bug 53469 possible bug in Response.normalize(CharChunk cc)
The Response.normalize(CharChunk cc) introduced in 7.0.28 introduced a bug. See Bug ID 53062 The URL that is being encoded is: ../../resources/org.apache.wicket.markup.html.WicketEventReference/wicket-event.js?w:lm=1340711670 which causes a IllegalArgumentException in this method java.lang.IllegalArgumentException at org.apache.catalina.connector.Response.normalize(Response.java:1799) at org.apache.catalina.connector.Response.toAbsolute(Response.java:1732) at org.apache.catalina.connector.Response.encodeURL(Response.java:1242) at org.apache.catalina.connector.ResponseFacade.encodeURL(ResponseFacade.java:406) at org.apache.wicket.protocol.http.WebResponse.encodeURL(WebResponse.java:149) at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.encode(WebRequestCodingStrategy.java:387) Running the same application in tomcat 7.0.27 and 6.0.18 works without issue
2012-06-26 12:45:09
1,340,730,000
resolved fixed
9a80d06
1,343,590,000
java/org/apache/catalina/connector/Response.java test/org/apache/catalina/connector/TestResponse.java
Tomcat
260
53,529
Bug 53529 Call interrupt() after InterruptedException instead interrupted()
In class: org\apache\catalina\tribes\group\GroupChannel.java line 692 org\apache\catalina\tribes\group\interceptors\NonBlockingCoordinator.java line 228 org\apache\catalina\tribes\group\interceptors\TcpPingInterceptor.java line 173 org\apache\catalina\tribes\membership\McastServiceImpl.java line 542 org\apache\juli\AsyncFileHandler.java line 124 line 146 org\apache\tomcat\util\net\AprEndpoint.java line 640 org\apache\tomcat\util\net\NioBlockingSelector.java line 112 line 177 org\apache\tomcat\util\threads\ThreadPoolExecutor.java line 187 Affect 7.0.29 (and previous release) but affect also Tomcat 6.
2012-07-10 11:27:42
1,341,930,000
resolved fixed
3ea8285
1,343,430,000
java/org/apache/catalina/tribes/group/GroupChannel.java java/org/apache/catalina/tribes/group/interceptors/NonBlockingCoordinator.java java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java java/org/apache/catalina/tribes/membership/McastServiceImpl.java java/org/apache/juli/AsyncFileHandler.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/NioBlockingSelector.java java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java
Tomcat
261
53,526
Bug 53526 .ConnectionPool.terminateTransaction unsafe == check of Boolean
The method ConnectionPool.terminateTransaction(PooledConnection con) uses == to check the value of a Boolean, viz: if (con.getPoolProperties().getDefaultAutoCommit()==Boolean.FALSE) { This is not 100% safe - if the user sets the property as follows: String value; // e.g. derived from property file ... setDefaultAutoCommit(new Boolean(value)); then the condition will never be true, even if value="false". Although it is better to use Boolean.valueOf(value), which would not have the same problem, the code ought to work regardless.
2012-07-09 20:08:39
1,341,880,000
resolved fixed
eac6366
1,341,930,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Tomcat
262
53,523
Bug 53523 rollbackOnReturn/commitOnReturn does not work without defaultAutoCommit=false
Hi, The properties rollbackOnReturn and commitOnReturn, which are critical for cleaning up connections after they are used and returned to the pool, does not work when the defaultAutoCommit property is not set or when it is set to true. The code segment at ConnectionPool class has this, protected boolean terminateTransaction(PooledConnection con) { try { if (con.getPoolProperties().getDefaultAutoCommit()==Boolean.FALSE) { .... The full logic is wrapped in that first if statement, and as I see, that is not correct. Because, the actual default auto commit value when we don't set this property can either be autoCommit true or false, which depends on the database driver. And also, even when we have a default setting provided, the user has the freedom to change the autoCommit flag to either true or false at the beginning when they get the connection from the pool. So we should not be reading the pool properties in this place, but just check the current live connection's autoCommit value and act accordingly. So I suppose the fix should be to simply remove the outer if statement. Cheers, Anjana.
2012-07-09 11:21:38
1,341,850,000
resolved wontfix
f54bb45
1,341,860,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java
Tomcat
263
53,513
Bug 53513 Race condition / out of order operation in session replication at node startup
My configuration: 2 nodes running Tomcat 7.0.26 Using a custom session manager, which extends the DeltaManager My startInternal() method first calls super.startInternal(), then performs a few additional initializations. I reviewed the code of DeltaManager.startInternal(), and it calls getAllClusterSessions() which in turn calls waitForSendAllSessions(), which requires either getStateTransfered() to return true, or a timeout. So by this, I should be able to trust that as the second node starts, the initial sync up of all session data from the first node has completed prior to the startInternal() method exiting (and thus prior to my initializations). This is, however, not the case! I can confirm this by repeatedly logging the value of findSessions().length during my inializations, and see that number going up! There appears to be a race condition between the processing of the message containing the actual session data & the "transfer complete" message. After tracing this through a little further, I see the stateTransfered is set to true in the handleALL_SESSION_TRANSFERCOMPLETE() callback method. And that callback is being called PRIOR to the session data itself even being received! Here is the debug logging output (slightly scrubbed) which shows this out of order messaging: Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager getAllClusterSessions INFO: Manager [wwwtest#], requesting session state from org.apache.catalina.tribes.membership.MemberImpl[...]. This operation will timeout if no session state has been received within 60 seconds. Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager messageReceived FINE: Manager [wwwtest#]: Received SessionMessage of type=(SESSION-STATE-TRANSFERED) from [org.apache.catalina.tribes.membership.MemberImpl[...] Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager handleALL_SESSION_TRANSFERCOMPLETE FINE: Manager [wwwtest#] received from node [[B@6789b939:4,000] session state transfered. Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager messageReceived FINE: Manager [wwwtest#]: Received SessionMessage of type=(ALL-SESSION-DATA) from [org.apache.catalina.tribes.membership.MemberImpl[...] Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager handleALL_SESSION_DATA FINE: Manager [wwwtest#]: received session state data
2012-07-05 21:56:22
1,341,540,000
resolved fixed
4c03dff
1,341,830,000
java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
Tomcat
264
53,498
Bug 53498 Atomicity violation bugs because of misusing concurrent collections
null
2012-07-02 21:19:45
1,341,280,000
resolved fixed
4aef8e3
1,341,440,000
java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/ha/context/ReplicatedContext.java
Tomcat
265
45,995
Bug 45995 RFE - MIME type extension not case sensitive
Hi, On the dev-tomcat list I described in the topic "Byte Serving and PDFs with the DefaultServlet" an issue that I had with Tomcat to serve PDFs. Analysing the answers I could find that the matter was related to the case of the file extension. Today Tomcat is case sensitive for MIME type extensions. So the solution for me was enter two MIME specifications on the web.xml file. One is for "pdf" and another one for "PDF". This way I would like to ask for and request for enhancement to make Tomcat be able to, due a setup on configuration file, consider or not case for MIME type extensions. Regards, Vitor
2008-10-13 04:32:38
1,223,890,000
resolved fixed
f8e173b
1,341,220,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
266
52,135
Bug 52135 Global error page is not handled
The new Servlet 3.0 global error page <error-page> <location>/error.jsp</location> </error-page> is not handled in Tomcat 7. On Glassfish 3 for example, it works fine.
2011-11-04 14:15:58
1,320,430,000
resolved fixed
6213b38
1,341,060,000
java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/StandardHostValve.java java/org/apache/catalina/deploy/ErrorPage.java test/org/apache/catalina/core/TestStandardHostValve.java
Tomcat
267
53,467
Bug 53467 7.0.28 will no longer accept our jsp filenames
null
2012-06-25 21:56:46
1,340,680,000
resolved fixed
4de4325
1,340,820,000
java/org/apache/catalina/core/ApplicationContext.java test/org/apache/catalina/core/TestApplicationContext.java
Tomcat
268
53,416
Bug 53416 Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException
Deploy two different web applications onto Tomcat. Each web application has a resource that: * uses the Use Tomcat JDBC Connection Pool * has an identical name to the other one <Resource name="jdbc/collision" factory="org.apache.tomcat.jdbc.pool.DataSourceFactory" ... /> When starting the server you get a non fatal error in the logs InstanceAlreadyExistsException. Both applications appear to still work OK ERROR org.apache.tomcat.jdbc.pool.DataSource - Unable to register JDBC pool with JMX javax.management.InstanceAlreadyExistsException: tomcat.jdbc:name="jdbc/soscvuk",context=/,type=ConnectionPool,host=localhost,class=org.apache.tomcat.jdbc.pool. DataSource at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:453) ~[na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.internal_addObject(DefaultMBeanServerInterceptor.java:1484) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:963) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:917) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:312) [na:1.6.0_32] at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:482) [na:1.6.0_32] at org.apache.tomcat.jdbc.pool.DataSource.registerJmx(DataSource.java:135) [tomcat-jdbc.jar:na] at org.apache.tomcat.jdbc.pool.DataSource.preRegister(DataSource.java:102) [tomcat-jdbc.jar:na] at org.apache.tomcat.util.modeler.BaseModelMBean.preRegister(BaseModelMBean.java:1132) [tomcat-coyote.jar:7.0.27] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.preRegisterInvoke(DefaultMBeanServerInterceptor.java:1010) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:938) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:917) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:312) [na:1.6.0_32] at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:482) [na:1.6.0_32] at org.apache.tomcat.util.modeler.Registry.registerComponent(Registry.java:742) [tomcat-coyote.jar:7.0.27] at org.apache.catalina.core.NamingContextListener.addResource(NamingContextListener.java:1062) [catalina.jar:7.0.27] at org.apache.catalina.core.NamingContextListener.createNamingContext(NamingContextListener.java:671) [catalina.jar:7.0.27] at org.apache.catalina.core.NamingContextListener.lifecycleEvent(NamingContextListener.java:270) [catalina.jar:7.0.27] at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) [catalina.jar:7.0.27] at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) [catalina.jar:7.0.27] at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) [catalina.jar:7.0.27] at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) [catalina.jar:7.0.27] at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:895) [catalina.jar:7.0.27] at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:871) [catalina.jar:7.0.27] at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:615) [catalina.jar:7.0.27] at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:649) [catalina.jar:7.0.27] at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1585) [catalina.jar:7.0.27] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) [na:1.6.0_32] at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) [na:1.6.0_32] at java.util.concurrent.FutureTask.run(FutureTask.java:138) [na:1.6.0_32] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [na:1.6.0_32] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [na:1.6.0_32] at java.lang.Thread.run(Thread.java:662) [na:1.6.0_32]
2012-06-14 13:37:06
1,339,700,000
resolved fixed
ff9a272
1,340,820,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java
Tomcat
269
53,465
Bug 53465 mapped-name is read when in @Resource, but not when in web.xml
null
2012-06-25 20:31:48
1,340,670,000
resolved fixed
7ecd402
1,340,750,000
java/org/apache/catalina/startup/WebRuleSet.java test/org/apache/naming/resources/TestNamingContext.java
Tomcat
270
53,460
Bug 53460 Use error handling when TooManyActiveSessionsException happens in JSP
null
2012-06-23 14:02:41
1,340,470,000
resolved fixed
294c52b
1,340,740,000
java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/runtime/JspFactoryImpl.java
Tomcat
271
53,445
Bug 53445 Support consistent Jmx object naming strategy across managed resources
Tomcat JDBC Pool Versions tested: 7.0.27 & 7.0.28 More of an inquiry. Let me preface by saying we have recently adopted this pool and are very pleased so far. Currently, Jmx managed resources like ConnectionPool and SlowQueryReportJmx are registered under the same domain (i.e. tomcat.jdbc). Some users may want to employ an alternate object naming strategy. With DataSource#createObjectName it is relatively easy to change the ConnectionPool ObjectName (i.e. subclass). However, with SlowQueryReportJmx, due to a static getObjectName method, it requires overriding additional methods which is less desirable. It appears that ConnectionPool has a constant POOL_JMX_TYPE_PREFIX. SlowQueryReportJmx appears to use this but DataSource does not? Is there any reason that the SlowQueryReportJmx#getObjectName method is static? What about registering an object naming strategy with the pool that the various components would use, facilitating consistency? This would mitigate the need to override just to alter the ObjectName. Reference: Spring MBean exporters and their ObjectNamingStrategy interface. Thanks.
2012-06-20 19:20:53
1,340,230,000
resolved fixed
4e010fc
1,340,740,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java
Tomcat
272
53,430
Bug 53430 JVM crash at startup if TC-Native version is too old
null
2012-06-17 10:16:07
1,339,940,000
resolved fixed
553259c
1,340,630,000
java/org/apache/catalina/connector/Connector.java java/org/apache/coyote/AbstractProtocol.java java/org/apache/coyote/ProtocolHandler.java java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/http11/Http11AprProtocol.java
Tomcat
273
53,421
Bug 53421 BeanELResolver's inner class BeanProperty throws incorrect message while PropertyNotFound
BeanELResolver's inner class BeanProperty(line: 264) has two methods (write, read) that will throw PropertyNotFoundException. And there current implementation are wrong: throw new PropertyNotFoundException(message(ctx, "propertyNotWritable", new Object[] { type.getName(), descriptor.getName() })); it should use owner.getName() instead of type.getName() because the assembled message will be: Property '[descriptor.getName()]' not readable on type [type.getName()] Here the descriptor.getName() means the property name, type.getName() means the property type's name and the owner.getName() means the property owner - bean's type name. Of course we developer would prefer to receive a message that tells us which bean type doesn't contain such property because this is a PropertyNotFoundException.
2012-06-15 13:54:17
1,339,780,000
resolved fixed
8a13b39
1,340,460,000
java/javax/el/BeanELResolver.java test/javax/el/TestBeanELResolver.java
Tomcat
274
53,450
Bug 53450 Deployment of an application with 'ROOT' context hangs forever
Hi, The scenario is the following: - I have running Tomcat 7.0.28 - I deploy an application with 'ROOT' context - The deployment hangs forever. When taking a tread dump, the following is suspicious: "localhost-startStop-2" daemon prio=6 tid=0x0000000006607800 nid=0x2560 waiting on condition [0x0000000009ebf000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00000007d80f0108> (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:158) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:811) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:842) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1178) at java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:807) at org.apache.catalina.core.ContainerBase.removeContainerListener(ContainerBase.java:1071) at org.apache.catalina.core.StandardEngine$AccessLogListener.uninstall(StandardEngine.java:463) at org.apache.catalina.core.StandardEngine$AccessLogListener.containerEvent(StandardEngine.java:505) at org.apache.catalina.core.ContainerBase.fireContainerEvent(ContainerBase.java:1431) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:907) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:875) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:618) at org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1100) at org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1618) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) As you can see - A read lock is acquired at org.apache.catalina.core.ContainerBase.fireContainerEvent(ContainerBase.java:1425) - Then every listener is invoked to process the container event - Then AccessLogListener is invoked org.apache.catalina.core.StandardEngine$AccessLogListener.uninstall(StandardEngine.java:463) - The latter causes a call for a write lock org.apache.catalina.core.ContainerBase.removeContainerListener(ContainerBase.java:1071) - Unfortunately in the ReentrantReadWriteLock it is stated that upgrade from read to write lock is not possible "Reentrancy also allows downgrading from the write lock to a read lock, by acquiring the write lock, then the read lock and then releasing the write lock. However, upgrading from a read lock to the write lock is not possible." Regards Violeta Georgieva
2012-06-21 18:22:10
1,340,320,000
resolved fixed
91a13d2
1,340,310,000
java/org/apache/catalina/core/ContainerBase.java
Tomcat
275
53,406
Bug 53406 Stack overflow in connector
found against trunk on Jun 18, 2012 SEVERE: java.lang.StackOverflowError at org.apache.catalina.core.StandardContextValve.event(StandardContextValve.java:128) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:204) at org.apache.catalina.core.StandardHostValve.event(StandardHostValve.java:223) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:204) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:204) at org.apache.catalina.core.StandardEngineValve.event(StandardEngineValve.java:110) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:209) at org.apache.coyote.http11.Http11NioProcessor.event(Http11NioProcessor.java:124) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:569) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
2012-06-13 03:51:40
1,339,570,000
resolved fixed
ce24a10
1,339,600,000
java/org/apache/coyote/http11/Http11AprProcessor.java java/org/apache/coyote/http11/Http11NioProcessor.java
Tomcat
276
52,954
Bug 52954 Allowing for broken android HTTP DIGEST support
null
2012-03-21 06:53:16
1,332,330,000
resolved fixed
bf41254
1,339,510,000
java/org/apache/catalina/authenticator/DigestAuthenticator.java
Tomcat
277
53,266
Bug 53266 ServletContainerInitializer will crash catalina if dependcy is not present.
When using a ServletContainerInitializer with a HandlesTypes annotation if any of the classes specified in the HandlesTypes annotation are not available due to a missing jar file catalina will crash with a "java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy". Caused by: java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy at sun.reflect.annotation.AnnotationParser.parseClassArray(AnnotationParser.java:653) at sun.reflect.annotation.AnnotationParser.parseArray(AnnotationParser.java:460) at sun.reflect.annotation.AnnotationParser.parseMemberValue(AnnotationParser.java:286) at sun.reflect.annotation.AnnotationParser.parseAnnotation(AnnotationParser.java:222) at sun.reflect.annotation.AnnotationParser.parseAnnotations2(AnnotationParser.java:69) at sun.reflect.annotation.AnnotationParser.parseAnnotations(AnnotationParser.java:52) at java.lang.Class.initAnnotationsIfNecessary(Class.java:3070) at java.lang.Class.getAnnotation(Class.java:3029) at org.apache.catalina.startup.ContextConfig.processServletContainerInitializers(ContextConfig.java:1546) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1222) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:855) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:345) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) ... 7 more Line where exception is thrown: "HandlesTypes ht = sci.getClass().getAnnotation(HandlesTypes.class);"
2012-05-20 14:32:34
1,337,540,000
resolved fixed
37e8c59
1,339,450,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
278
53,398
Bug 53398 Incorrect tag on XML response when calling 'manager/status?XML=true'
null
2012-06-11 16:39:14
1,339,450,000
resolved fixed
2bf1556
1,339,450,000
java/org/apache/catalina/manager/StatusTransformer.java
Tomcat
279
52,955
Bug 52955 Add a ThreadFactory implementation to the ExecutorService used to deploy applications
null
2012-03-21 07:55:31
1,332,330,000
resolved fixed
d73c07a
1,339,250,000
java/org/apache/catalina/core/ContainerBase.java
Tomcat
280
53,374
Bug 53374 DataSourceFactory does not support commitOnReturn property
DataSourceFactory does not support commitOnReturn property. DataSourceFactory.ALL_PROPERTIES and DataSourceFactory.parsePoolProperties() omit commitOnReturn property.
2012-06-06 20:56:47
1,339,030,000
resolved fixed
0290e57
1,339,160,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
Tomcat
281
53,373
Bug 53373 Allow whitespace around delimiters in <Context> aliases for readability
null
2012-06-06 20:01:27
1,339,030,000
resolved fixed
cf703d2
1,339,010,000
java/org/apache/naming/resources/BaseDirContext.java test/org/apache/naming/resources/TestNamingContext.java
Tomcat
282
53,367
Bug 53367 Database failure may cause pool to hang
during the con.connect(); call in the method protected PooledConnection borrowConnection(long now, PooledConnection con, String username, String password) in ConnectionPool.java There is no counting down the size of the pool. This means, if a connection failure happens here, the pool size remains the same. This means that 'size' will show the pool as full, but in reality the pool is empty
2012-06-06 01:01:10
1,338,960,000
resolved fixed
1412935
1,338,940,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Tomcat
283
53,032
Bug 53032 Ant Jasper task fails to run when using XML namespaces; no output; no errors
null
2012-04-03 21:41:35
1,333,500,000
resolved fixed
957d33b
1,338,940,000
java/org/apache/jasper/JspC.java
Tomcat
284
53,230
Bug 53230 Allow custom error mapping when Manager's maxActiveSessions is exceeded
null
2012-05-14 17:09:13
1,337,030,000
resolved fixed
ea77dfb
1,338,930,000
java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/session/TooManyActiveSessionsException.java
Tomcat
285
53,354
Bug 53354 <filter-mapping> doesn't find the @WebFilter(filterName)
As it's not possible to specify the invocation order in a @WebFilter, users are forced to explicitly specify <filter-mapping> in web.xml. This works in combination with a @WebFilter(filterName) in Glassfish and JBoss AS as follows: @WebFilter(filterName="filter1") public class Filter1 implements Filter {} @WebFilter(filterName="filter2") public class Filter2 implements Filter {} with <filter-mapping> <filter-name>filter1</filter-name> <url-pattern>/url1/*</url-pattern> </filter-mapping> <filter-mapping> <filter-name>filter2</filter-name> <url-pattern>/url2/*</url-pattern> </filter-mapping> However it fails in Tomcat 7.0.27 with the following confusing exception (the <url-pattern> *is* been set) Caused by: java.lang.IllegalArgumentException: Filter mapping must specify either a <url-pattern> or a <servlet-name> at org.apache.catalina.core.StandardContext.validateFilterMap(StandardContext.java:3009) at org.apache.catalina.core.StandardContext.addFilterMap(StandardContext.java:2968) at org.apache.catalina.deploy.WebXml.configureContext(WebXml.java:1207) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1294) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:855) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:345) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) ... 7 more
2012-06-03 19:16:25
1,338,770,000
resolved fixed
b82c47e
1,338,760,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
286
53,339
Bug 53339 ClassNotFoundException when using WebSocketServlet
I'm trying to do a JNDI lookup inside the "onOpen" method of my StreamInbound class, but it gives me the exception below. The code works if I move my JNP JARs to the server lib instead of the webapp lib. The code also works fine from anywhere else, like in the "doGet" method. ERROR http-bio-8080-exec-3 Test javax.naming.NoInitialContextException: Cannot instantiate class: org.jnp.interfaces.NamingContextFactory [Root exception is java.lang.ClassNotFoundException: org.jnp.interfaces.NamingContextFactory] at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:657) at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:288) at javax.naming.InitialContext.init(InitialContext.java:223) at javax.naming.InitialContext.<init>(InitialContext.java:197) at Test$TestStreamInbound.onOpen(Test.java:103) at org.apache.catalina.websocket.StreamInbound.onUpgradeComplete(StreamInbound.java:180) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:307) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662)
2012-05-31 18:20:53
1,338,500,000
resolved fixed
d713894
1,338,750,000
java/org/apache/catalina/websocket/StreamInbound.java test/org/apache/catalina/websocket/TestWebSocket.java
Tomcat
287
53,008
Bug 53008 New test case for Basic Authenticator
null
2012-03-30 12:21:42
1,333,120,000
resolved fixed
a1c6165
1,338,740,000
test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java
Tomcat
288
53,337
Bug 53337 IllegalStateException when trying to render a JSP after startAsync
null
2012-05-31 17:06:36
1,338,500,000
resolved fixed
c6b691d
1,338,740,000
java/org/apache/catalina/core/ApplicationDispatcher.java test/org/apache/catalina/core/TestAsyncContextImpl.java
Tomcat
289
53,301
Bug 53301 Servlet init method called twice with embedded Tomcat
When using embedded Tomcat, the servlet init method is called twice by the container. This has been seen with an Apache DirectMemory unit test. I have checked with a normal Tomcat launched by the Tomcat Maven plugin (mvn tomcat7:run) and in this case, the init method is correctly called once.
2012-05-26 21:36:56
1,338,080,000
resolved fixed
6ce3128
1,338,550,000
java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java
Tomcat
290
53,285
Bug 53285 Web app configuration fails when security-role-ref does not contain role-link
null
2012-05-24 04:52:55
1,337,850,000
resolved fixed
ad3b503
1,338,540,000
java/org/apache/catalina/deploy/ServletDef.java java/org/apache/catalina/startup/WebRuleSet.java
Tomcat
291
53,342
Bug 53342 If starting immediately after Tomcat stop fail, BindException will throw.
e.g. When Context#stop throw LifecycleException, the main thread stops, but startStopThreads of Host/Engine will remain for a while. Because, startStopThreads is not a demon thread. As a result, even if a main thread stops, Acceptor Threads of 8080/8009 is not stopped. keepAliveTime for 10 seconds is set up now. === startStopExecutor = new ThreadPoolExecutor( getStartStopThreadsInternal(), getStartStopThreadsInternal(), 10, TimeUnit.SECONDS, startStopQueue); === Therefore, in order to avoid BindException, the waiting for 10 seconds is required. I think that I need to make startStopThreads into a demon thread. Best Regards.
2012-06-01 09:34:18
1,338,560,000
resolved fixed
84342f5
1,338,540,000
java/org/apache/catalina/core/ContainerBase.java
Tomcat
292
53,225
Bug 53225 IllegalStateException "zip file closed" with resource from webfragment jar if JreMemoryLeakPreventionListener is removed
null
2012-05-12 20:32:50
1,336,870,000
resolved fixed
e90cd4b
1,338,460,000
java/org/apache/tomcat/util/scan/FileUrlJar.java
Tomcat
293
53,169
Bug 53169 [patch] don't do chunking with Connection: close
null
2012-05-01 09:35:06
1,335,880,000
resolved fixed
280beac
1,338,390,000
java/org/apache/coyote/http11/AbstractHttp11Processor.java test/org/apache/coyote/http11/TestAbstractHttp11Processor.java
Tomcat
294
53,322
Bug 53322 Odd decapitalization when inferring JavaBean property from setter name for an injection target
null
2012-05-30 01:22:25
1,338,360,000
resolved fixed
13100e9
1,338,340,000
java/org/apache/catalina/core/DefaultInstanceManager.java
Tomcat
295
53,180
Bug 53180 DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method
null
2012-05-02 20:27:25
1,336,000,000
resolved fixed
39c8e18
1,338,300,000
java/org/apache/catalina/core/DefaultInstanceManager.java
Tomcat
296
53,081
Bug 53081 WebappClassLoader causes java.lang.OutOfMemoryError in findResourceInternal()
null
2012-04-13 21:46:53
1,334,370,000
resolved fixed
5d12129
1,338,300,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
297
53,090
Bug 53090 Servlet superclass injection targets are ignored
null
2012-04-17 08:07:14
1,334,660,000
resolved fixed
de1f763
1,338,240,000
java/org/apache/catalina/core/DefaultInstanceManager.java
Tomcat
298
53,074
Bug 53074 [websocket] java.net.SocketTimeoutException: Read timed caused by server.xml' connectTimeout
The default connectTimeout value is set to 20000 and cause issue with WebSocket connection java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:129) at org.apache.coyote.http11.upgrade.UpgradeBioProcessor.read(UpgradeBioProcessor.java:75) at org.apache.catalina.websocket.WsFrame.nextFrame(WsFrame.java:213) at org.apache.catalina.websocket.WsInputStream.nextFrame(WsInputStream.java:68) at org.apache.catalina.websocket.StreamInbound.onData(StreamInbound.java:143) at org.apache.coyote.http11.upgrade.UpgradeProcessor.upgradeDispatch(UpgradeProcessor.java:83) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:563) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:307) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) Increasing the value delay the issue (but the timeout should not occurs)
2012-04-13 13:45:11
1,334,340,000
resolved fixed
098a647
1,337,960,000
java/org/apache/catalina/websocket/StreamInbound.java java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/http11/Http11AprProtocol.java java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java java/org/apache/coyote/http11/upgrade/UpgradeBioProcessor.java java/org/apache/coyote/http11/upgrade/UpgradeInbound.java java/org/apache/coyote/http11/upgrade/UpgradeNioProcessor.java java/org/apache/tomcat/util/net/AprEndpoint.java
Tomcat
299
53,254
Bug 53254 Support for purging connection pool
It is a common function of a connection pool to support "purging" the pool of all current connections and getting all fresh connections. Oracle UCP and Websphere pools are two such examples. It would be great if this pool supported such an operation as well. It would be useful if the operation were exposed through JMX too.
2012-05-17 17:59:28
1,337,290,000
resolved fixed
f170929
1,337,360,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPoolMBean.java modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolPurgeTest.java
Tomcat
300
53,067
Bug 53067 WebSocket implementation issue with wrapped requests
null
2012-04-12 17:56:58
1,334,270,000
resolved fixed
111dc8e
1,336,860,000
java/org/apache/catalina/websocket/WebSocketServlet.java
Tomcat
301
53,063
Bug 53063 Inconsistency in documentation regarding Connector's maxConnections property
null
2012-04-11 13:14:14
1,334,160,000
resolved fixed
be365e5
1,336,680,000
java/org/apache/tomcat/util/net/AbstractEndpoint.java java/org/apache/tomcat/util/net/JIoEndpoint.java
Tomcat
302
53,087
Bug 53087 BackupManager does not replicate session access time.
null
2012-04-17 05:44:46
1,334,660,000
resolved fixed
48b9153
1,334,640,000
java/org/apache/catalina/ha/session/DeltaSession.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java
Tomcat
303
53,056
Bug 53056 Add APR version number to tcnative version INFO log message
When tcnative starts, it emits information like this to catalina.out: pr 10, 2012 4:54:55 PM org.apache.catalina.core.AprLifecycleListener init INFO: Loaded APR based Apache Tomcat Native library 1.1.23. Apr 10, 2012 4:54:55 PM org.apache.catalina.core.AprLifecycleListener init INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false], random [true]. It would be nice if the APR version in use could also be displayed as well as the tcnative version. Maybe the OpenSSL version, too.
2012-04-10 20:58:50
1,334,110,000
resolved fixed
df88ecb
1,334,090,000
java/org/apache/catalina/core/AprLifecycleListener.java
Tomcat
304
50,864
Bug 50864 Reconfigure pool on the fly using JMX
null
2011-03-03 11:15:31
1,299,170,000
resolved fixed
518662f
1,334,080,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
Tomcat
305
52,998
Bug 52998 Performance issue with ExpressionFactory.newInstance()
null
2012-03-28 21:16:03
1,332,980,000
resolved fixed
7da5fa9
1,333,140,000
java/javax/el/ExpressionFactory.java
Tomcat
306
53,001
Bug 53001 Behaviour of ResourceBundleELResolver
null
2012-03-29 09:41:39
1,333,030,000
resolved fixed
1aced29
1,333,130,000
test/javax/el/TestResourceBundleELResolver.java
Tomcat
307
52,974
Bug 52974 NameNotFoundException is thrown when field/method is annotated with @Resource annotation
null
2012-03-22 20:43:20
1,332,460,000
resolved fixed
67a926c
1,332,880,000
java/org/apache/catalina/startup/WebAnnotationSet.java
Tomcat
308
52,833
Bug 52833 NPE with 7.0.26
Upgrading the maven plugin 7.0.26, the goal which runs tomcat with a conf dir (not the embed version) generate the following NPE Log: at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:141) at org.apache.catalina.startup.Catalina.start(Catalina.java:645) at org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:679) at org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:365) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:544) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:197) at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
2012-03-05 23:28:06
1,331,010,000
resolved fixed
6a8e480
1,332,870,000
java/org/apache/catalina/core/StandardServer.java
Tomcat
309
52,066
Bug 52066 ConnectionPool.borrowConnection swallows interrupt state.
In this code snippet starting on line 6.15 of ConnectionPool.java version 7.0.22 try { //retrieve an existing connection con = idle.poll(timetowait, TimeUnit.MILLISECONDS); } catch (InterruptedException ex) { Thread.interrupted();//clear the flag, and bail out SQLException sx = new SQLException("Pool wait interrupted."); sx.initCause(ex); throw sx; } finally { waitcount.decrementAndGet(); } The line marked '//clear the flag, and bail out' is wrong, because after that there is no way for calling code to find out that the thread has been interrupted. The correct behavior should be Thread.currentThread( ).interrupt( ); Here is the excerpt from the Biran Goetz's "Java Concurrency in Practice" chapter 5.4. <!START QUOTATION> For library code there are basically two choices: -- Propagate the InterruptedException. This is often the most sensible policy if you can get away with it -- just propagate the InterruptedException to your caller. This could involve not catching InterruptedException, or catching it and throwing it again after performing some brief activity-specific cleanup. -- Restore the interrupt. Sometimes you cannot throw InterruptedException, for instance when your code is part of a Runnable. In these situations, you must catch InterruptedException and restore the interrupted status by calling interrupt on the current thread, so that code higher up the call stack can see that an interrupt was issued. <!END QUOTATION> In the case of borrowConnection, #1 is not really a choice, as it is running in the confines of JDBC interface. But it can definitely restore the interrupt status of the thread.
2011-10-20 19:28:24
1,319,150,000
resolved fixed
fe16ac2
1,332,870,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
Tomcat