id
int64 1
6.5k
| bug_id
int64 2.03k
426k
| summary
stringlengths 9
251
| description
stringlengths 1
32.8k
⌀ | report_time
stringlengths 19
19
| report_timestamp
int64 1B
1.39B
| status
stringclasses 6
values | commit
stringlengths 7
9
| commit_timestamp
int64 1B
1.39B
| files
stringlengths 25
32.8k
| project_name
stringclasses 6
values |
|---|---|---|---|---|---|---|---|---|---|---|
310 | 52,957 | Bug 52957 ClassCastException while removing Valve | null | 2012-03-21 12:47:49 | 1,332,350,000 | resolved fixed | d5cee34 | 1,332,430,000 | java/org/apache/catalina/core/StandardPipeline.java | Tomcat |
311 | 52,839 | Bug 52839 New unit test for DigestAuthenticator and SingleSignOn | null | 2012-03-06 16:12:53 | 1,331,070,000 | resolved fixed | c0f1bb9 | 1,332,280,000 | test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java | Tomcat |
312 | 50,860 | Bug 50860 In case of invalid or empty slqQuery connection are always invalidated without usefull information | The code is (in PooledConnection.java#validate(int validateAction,String sql) ) Statement stmt = null; try { stmt = connection.createStatement(); stmt.execute(query); stmt.close(); this.lastValidated = now; return true; } catch (Exception ignore) { if (log.isDebugEnabled()) log.debug("Unable to validate object:",ignore); if (stmt!=null) try { stmt.close();} catch (Exception ignore2){/*NOOP*/} } return false; So in the case of null or invalid query (connection is always invalidated : seems normal :-) ). But without any usefull message (except if you use debug : but seems complicated in a production env). So IMHO adding a log.warning in case of null query could be usefull. | 2011-03-03 06:51:14 | 1,299,150,000 | resolved fixed | e092870 | 1,332,260,000 | modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java | Tomcat |
313 | 51,893 | Bug 51893 JMX notification/Exception for empty/exhausted connection pool | Currently, if there is an error getting a connection from the pool, a generic SQLException is thrown. The only way to determine if the problem is a result of the connection pool being exhausted is to catch the SQLException and parse the message (i.e. look for "Pool empty" in ex.getMessage()). Would like to see the following: 1) A subclass of SQLException thrown in the case of an empty pool 2) A JMX notification sent in the case of an empty pool (e.g. [POOL EXHAUSTED]) | 2011-09-26 14:49:49 | 1,317,060,000 | resolved fixed | 9d687eb | 1,332,260,000 | modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java | Tomcat |
314 | 51,237 | Bug 51237 SlowQueryReport interceptor does not log anything | null | 2011-05-20 22:01:35 | 1,305,940,000 | resolved fixed | 0eb38b8 | 1,332,250,000 | modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java | Tomcat |
315 | 52,926 | Bug 52926 NPE in processSocket | We have sporadic issues triggering 502 proxy errors using the NIO connector behind Nginx, caused by dropped connections/end of streams in Tomcat. The Tomcat log shows: SEVERE: Error allocating socket processor java.lang.NullPointerException at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:721) at org.apache.tomcat.util.net.NioEndpoint$Poller.cancelledKey(NioEndpoint.java:1048) at org.apache.tomcat.util.net.NioEndpoint$Poller.timeout(NioEndpoint.java:1392) at org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1174) at java.lang.Thread.run(Thread.java:662) Looking at the code in processSocket I see the line in NioEndpoint(721): attachment.setCometNotify(false); //will get reset upon next reg Attachment is fetched in line 720: KeyAttachment attachment = (KeyAttachment)socket.getAttachment(false); Looking at socket.getAttachement() method I see that this method is indeed capable of returning null, but no null-check for this is done (although it is in multiple other locations, so it seems inconsistent). | 2012-03-16 08:19:25 | 1,331,900,000 | resolved fixed | dcb8808 | 1,332,240,000 | java/org/apache/tomcat/util/net/NioEndpoint.java | Tomcat |
316 | 52,723 | Bug 52723 An incomplete fix for the resource leak bugs in StandardManager.java | null | 2012-02-21 10:22:02 | 1,329,840,000 | resolved wontfix | 9f8c8d6 | 1,331,330,000 | java/org/apache/catalina/session/StandardManager.java | Tomcat |
317 | 52,850 | Bug 52850 Various miscellaneous fixes to Tomcat Memory Leak Detection code | Problem Description - ---------------------- Tomcat memory leak detection has the following issues - Most of the detection and fixing code has been tested ONLY on Sun JVMs. A lot of the reflection based code does not work with the IBM JDK. - Tests in tomcat7.source\test\org\apache\catalina\loader do not seem to run successfully and are incomplete for all the protection that Tomcat provides for classloader memory leaks. - For some categories of threadlocal memory leaks the key and value are not displayed correctly in the warning messages; particularly ones dealing with indirect references to threadlocals - org.apache.catalina.loader.WebappClassLoader.loadedByThisOrChild(Object) incorrectly traverses the object classloader hierarchy instead of the current (this) classloader hierarchy Problem Conclusion - -------------------- - After extensive testing with the IBM JDKs, I have cleaned up and sanitized some of the reflection code to stop executors, timers, threads etc on the IBM JDK - Added new tests for detecting threadlocal leaks and thread leaks - Better ThreadLocal leak reporting with corrected loadedByThisOrChild method and addition of expungeStaleEntries method - Make code more resilient in certain leak detection scenarios. | 2012-03-07 14:57:15 | 1,331,150,000 | resolved fixed | adbf442 | 1,331,320,000 | java/org/apache/catalina/loader/WebappClassLoader.java test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java | Tomcat |
318 | 52,776 | Bug 52776 Generator's JspFragment.invoke implementation does not reset ELContext[JspContext.class] | If a developer captures a JspFragment themselves and calls invoke on it, the JspContext.class attribute in the enclosing pageContext's ELContext is set by the generated JspFragment subclass, but not reset to its original value afterwards. Therefore after invoking a JspContext any EL expressions will be searching the wrong jspContext for attribute values. org.apache.jasper.compiler.Generator is responsible for creating the JspFragment subclass to represent the compiled fragment. The generatePostamble() method emits generated code to set the JspContext attribute in the ELContext: out.printil("this.jspContext.getELContext().putContext(javax.servlet.jsp.JspContext.class,this.jspContext);"); However it doesn't later put back the original value. If you are using the <jsp:invoke> tag to invoke the fragment (which is undoubtedly what most people are doing) then the code generated by visit(Node.InvokeAction n) in Generator explicitly restores the EL context: out.printil("jspContext.getELContext().putContext(javax.servlet.jsp.JspContext.class,getJspContext());"); However if you call invoke(Writer) on the JspFragment yourself you don't get that tidy up code. I suggest the resolution is to have the JspFragment.invoke method tidy up after itself. It "puts" the change to the JspContext.class attribute so it should also re"put" it. Then there shouldn't be any need to restore the EL context in the generated <jsp:invoke> code. I have tested this solution successfully. | 2012-02-27 00:46:22 | 1,330,320,000 | resolved fixed | faf26da | 1,331,290,000 | java/org/apache/jasper/compiler/Generator.java | Tomcat |
319 | 52,500 | Bug 52500 Improve client certificate authentication | null | 2012-01-23 13:02:04 | 1,327,340,000 | resolved fixed | 401c703 | 1,331,230,000 | java/org/apache/catalina/realm/RealmBase.java java/org/apache/catalina/realm/X509SubjectDnRetriever.java java/org/apache/catalina/realm/X509UsernameRetriever.java | Tomcat |
320 | 52,719 | Bug 52719 An incomplete fix for the resource leak bug in WebappClassLoader.java | null | 2012-02-21 09:37:53 | 1,329,840,000 | resolved fixed | 78c02a7 | 1,331,160,000 | java/org/apache/catalina/loader/WebappClassLoader.java | Tomcat |
321 | 52,792 | Bug 52792 Incomplete error message when lookup a resource that is not bound in the naming | null | 2012-02-28 20:30:12 | 1,330,480,000 | resolved fixed | 7cec4ff | 1,331,150,000 | java/org/apache/naming/NamingContext.java | Tomcat |
322 | 52,772 | Bug 52772 JspC : checking uriRoot option validness | In org.apache.jasper.JspC#execute() method, if uriRoot is not null, it scans all jsp files under uriRoot, and then checks if uriRoot is a directory. It should be more desirable to check if uriRoot is a directory or not first and then scanning it. Here are my suggestion. if (uriRoot == null) { throw new JasperException( Localizer.getMessage("jsp.error.jspc.no_uriroot")); } File uriRootF = new File(uriRoot); if (!uriRootF.exists() || !uriRootF.isDirectory()) { throw new JasperException( Localizer.getMessage("jsp.error.jspc.uriroot_not_dir")); } if( context==null ) { initServletContext(); } // No explicit pages, we'll process all .jsp in the webapp if (pages.size() == 0) { scanFiles(uriRootF); } | 2012-02-26 07:41:43 | 1,330,260,000 | resolved fixed | 35958df | 1,331,130,000 | java/org/apache/jasper/JspC.java | Tomcat |
323 | 52,770 | Bug 52770 Potential Bug or Inconsistency in NioBlockingSelector.java | This is Ken Cheung, a Computer Science M.Phil. student. I observed some code clones in Tomcat and found inconsistent code: /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 103 try { 104 if ( att.getWriteLatch()==null || att.getWriteLatch().getCount()==0) att.startWriteLatch(1); 105 poller.add(att,SelectionKey.OP_WRITE,reference); 106 att.awaitWriteLatch(writeTimeout,TimeUnit.MILLISECONDS); 107 }catch (InterruptedException ignore) { 108 Thread.interrupted(); 109 } 110 if ( att.getWriteLatch()!=null && att.getWriteLatch().getCount()> 0) { 111 //we got interrupted, but we haven't received notification from the poller. 112 keycount = 0; 113 }else { 114 //latch countdown has happened 115 keycount = 1; 116 att.resetWriteLatch(); 117 } 118 119 if (writeTimeout > 0 && (keycount == 0)) 120 timedout = (System.currentTimeMillis() - time) >= writeTimeout; /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 164 try { 165 if ( att.getReadLatch()==null || att.getReadLatch().getCount()==0) att.startReadLatch(1); 166 poller.add(att,SelectionKey.OP_READ, reference); 167 if (readTimeout < 0) { 168 att.awaitReadLatch(Long.MAX_VALUE, TimeUnit.MILLISECONDS); 169 } else { 170 att.awaitReadLatch(readTimeout, TimeUnit.MILLISECONDS); 171 } 172 }catch (InterruptedException ignore) { 173 Thread.interrupted(); 174 } 175 if ( att.getReadLatch()!=null && att.getReadLatch().getCount()> 0) { 176 //we got interrupted, but we haven't received notification from the poller. 177 keycount = 0; 178 }else { 179 //latch countdown has happened 180 keycount = 1; 181 att.resetReadLatch(); 182 } 183 if (readTimeout >= 0 && (keycount == 0)) 184 timedout = (System.currentTimeMillis() - time) >= readTimeout; Quick description of the inconsistency Two code snippets are very similar code, but as you see, the first code does not check "if (readTimeout < 0)" while the second code has the checker. We thought it could be a potential bug or inconsistency. Hope this helps. | 2012-02-25 15:04:31 | 1,330,200,000 | resolved fixed | 4f75b2d | 1,331,130,000 | java/org/apache/tomcat/util/net/NioBlockingSelector.java | Tomcat |
324 | 52,767 | Bug 52767 Potential Bug or Inconsistency in JDBCRealm.java and JDBCAccessLogValve.java | This is Ken Cheung, a Computer Science M.Phil. student. I observed some code clones in Tomcat and found inconsistent code: /tomcat/trunk/java/org/apache/catalina/realm/JDBCRealm.java 676 if (driver == null) { 677 try { 678 Class<?> clazz = Class.forName(driverName); 679 driver = (Driver) clazz.newInstance(); 680 } catch (Throwable e) { 681 ExceptionUtils.handleThrowable(e); 682 throw new SQLException(e.getMessage(), e); 683 } 684 } 685 686 // Open a new connection 687 Properties props = new Properties(); 688 if (connectionName != null) 689 props.put("user", connectionName); 690 if (connectionPassword != null) 691 props.put("password", connectionPassword); 692 dbConnection = driver.connect(connectionURL, props); /tomcat/trunk/java/org/apache/catalina/valves/JDBCAccessLogValve.java 566 if (driver == null) { 567 try { 568 Class<?> clazz = Class.forName(driverName); 569 driver = (Driver) clazz.newInstance(); 570 } catch (Throwable e) { 571 ExceptionUtils.handleThrowable(e); 572 throw new SQLException(e.getMessage(), e); 573 } 574 } 575 576 // Open a new connection 577 Properties props = new Properties(); 578 props.put("autoReconnect", "true"); 579 if (connectionName != null) { 580 props.put("user", connectionName); 581 } 582 if (connectionPassword != null) { 583 props.put("password", connectionPassword); 584 } 585 conn = driver.connect(connectionURL, props); Quick description of the inconsistency Two code snippets are very similar code, but as you see, in JDBCRealm.java does not use "props.put("autoReconnect", "true")" while JDBCAccessLogValve.java has. We thought it could be a potential bug or inconsistency. Hope this helps. | 2012-02-25 14:32:33 | 1,330,200,000 | resolved fixed | 1f4663d | 1,331,130,000 | java/org/apache/catalina/valves/JDBCAccessLogValve.java | Tomcat |
325 | 52,846 | Bug 52846 Programmatic login using UserDatabaseRealm returns 403 error. | IMHO,HttpServletRequest#login does not need to define a <login-config>. NonLoginAuthenticator is used when <login-config> is not specified in HttpServletRequest#login. When UserDatabaseRealm is used, not GenericPrincipal but Memory User is set to a session. In AuthenticatorBase#invoke, principal registered into a session is set to a request. Because MemoryUser is set to a request as principal, RealmBase#hasRole always returns false. As a result, 403 error is returned. | 2012-03-07 08:40:46 | 1,331,130,000 | resolved fixed | a01418d | 1,331,110,000 | java/org/apache/catalina/authenticator/NonLoginAuthenticator.java | Tomcat |
326 | 52,732 | Bug 52732 An incomplete fix for the resource leak bug in ExpressionFactory.java | null | 2012-02-21 12:22:44 | 1,329,840,000 | resolved fixed | 6399c83 | 1,331,070,000 | java/javax/el/ExpressionFactory.java | Tomcat |
327 | 52,731 | Bug 52731 An incomplete fix for the resource leak bug in JDTCompiler.java | null | 2012-02-21 12:16:28 | 1,329,840,000 | resolved fixed | 2b1d195 | 1,331,070,000 | java/org/apache/jasper/compiler/JDTCompiler.java | Tomcat |
328 | 52,729 | Bug 52729 An incomplete fix for the resource leak bug in CometConnectionManagerValve.java | null | 2012-02-21 12:01:25 | 1,329,840,000 | resolved fixed | 683d5c1 | 1,331,070,000 | java/org/apache/catalina/valves/CometConnectionManagerValve.java | Tomcat |
329 | 52,727 | Bug 52727 An incomplete fix for the resource leak bug in HostConfig.java | null | 2012-02-21 11:58:35 | 1,329,840,000 | resolved fixed | 8293a6e | 1,331,070,000 | java/org/apache/catalina/startup/HostConfig.java | Tomcat |
330 | 52,726 | Bug 52726 An incomplete fix for the resource leak bug in MemoryUserDatabase.java | null | 2012-02-21 11:50:36 | 1,329,840,000 | resolved fixed | a30ce07 | 1,331,070,000 | java/org/apache/catalina/users/MemoryUserDatabase.java | Tomcat |
331 | 52,725 | Bug 52725 org.apache.jasper.compiler.JspUtil#getTagHandlerClassName() does not use org.apache.jasper.Constants.TAG_FILE_PACKAGE_NAME | In the class org.apache.jasper.compiler.JspUtil, its method public static String getTagHandlerClassName(String path, String urn, ErrorDispatcher err) throws JasperException { ... } uses the string constants directly like "org.apache.jsp.tag.web.", "org.apache.jsp.tag.meta.". But you know there is TAG_FILE_PACKAGE_NAME field in the class org.apache.jasper.Constants. The code should be adjusted like below : Constants.TAG_FILE_PACKAGE_NAME + ".web" Constants.TAG_FILE_PACKAGE_NAME + ".meta" | 2012-02-21 11:28:46 | 1,329,840,000 | resolved fixed | bf0287e | 1,330,980,000 | java/org/apache/jasper/compiler/JspUtil.java | Tomcat |
332 | 52,724 | Bug 52724 An incomplete fix for the resource leak bugs in Catalina.java | null | 2012-02-21 10:35:32 | 1,329,840,000 | resolved fixed | 7c51f61 | 1,330,980,000 | java/org/apache/catalina/startup/Catalina.java | Tomcat |
333 | 52,804 | Bug 52804 Make PoolProperties implement Cloneable. | It would be very useful to have the PoolProperties class implement the java.lang.Cloneable interface. We have many databases that share the same schema, username, password, configuration etc but differ only in their URL. Implementing a routing datasource based on something like org.springframework.jdbc.datasource.AbstractDataSource can then just clone a PoolProperties object and set the one or two properties that differ in the clone. In a spring project the properties that are common across all the datasources are only supplied once. | 2012-03-01 17:18:03 | 1,330,640,000 | resolved fixed | 55baca6 | 1,330,630,000 | modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java | Tomcat |
334 | 52,760 | Bug 52760 Mime type for javascript incorrect in documentation | null | 2012-02-24 13:35:39 | 1,330,110,000 | resolved fixed | 833e6b1 | 1,330,260,000 | java/org/apache/catalina/filters/ExpiresFilter.java | Tomcat |
335 | 52,758 | Bug 52758 Jasper illegally implements org.eclipse.jdt.internal.compiler.env.ICompilationUnit from Eclipse | null | 2012-02-24 04:21:56 | 1,330,080,000 | resolved fixed | 2e7f5ab | 1,330,080,000 | java/org/apache/jasper/compiler/JDTCompiler.java | Tomcat |
336 | 52,671 | Bug 52671 NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet | null | 2012-02-15 11:47:03 | 1,329,320,000 | resolved fixed | 3fe64a5 | 1,329,340,000 | java/org/apache/catalina/mbeans/MBeanDumper.java | Tomcat |
337 | 52,669 | Bug 52669 Annotation processing, in WEB-INF/classes, for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios | null | 2012-02-14 21:39:46 | 1,329,270,000 | resolved fixed | 34b1a7e | 1,329,340,000 | java/org/apache/catalina/startup/ContextConfig.java | Tomcat |
338 | 52,666 | Bug 52666 EL should coerce String to Integer in equals operation | null | 2012-02-14 12:55:34 | 1,329,240,000 | resolved fixed | bf9bf39 | 1,329,320,000 | java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java | Tomcat |
339 | 52,607 | Bug 52607 It is not well defined how "Dependencies on extensions" mechanism can be used in Tomcat | null | 2012-02-05 22:19:35 | 1,328,500,000 | resolved fixed | 4b6d583 | 1,328,740,000 | java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/util/ExtensionValidator.java | Tomcat |
340 | 52,606 | Bug 52606 FORM authentication POST replay broken for AJP | null | 2012-02-05 18:10:19 | 1,328,480,000 | resolved fixed | 6f766be | 1,328,720,000 | java/org/apache/coyote/ajp/AbstractAjpProcessor.java | Tomcat |
341 | 52,591 | Bug 52591 UnsupportedOperationException logged when fetching BasicDataSource 'loginTimeout' | With a BasicDataSource configured (using a <Resource>), simply list the available MBeans and this exception will be emitted to stdout: SEVERE: Error getting attribute Catalina:type=DataSource,context=/context,host=localhost,class=javax.sql.DataSource,name="jdbc/myDataSource" loginTimeout javax.management.RuntimeOperationsException: Exception invoking method loginTimeout at org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:197) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:666) at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638) at org.apache.catalina.mbeans.MBeanDumper.dumpBeans(MBeanDumper.java:81) at org.apache.catalina.manager.JMXProxyServlet.listBeans(JMXProxyServlet.java:166) at org.apache.catalina.manager.JMXProxyServlet.doGet(JMXProxyServlet.java:121) at javax.servlet.http.HttpServlet.service(HttpServlet.java:621) [...] Caused by: java.lang.UnsupportedOperationException: Not supported by BasicDataSource at org.apache.tomcat.dbcp.dbcp.BasicDataSource.getLoginTimeout(BasicDataSource.java:1083) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) This exception does not cause the request to fail, but definitely puts an ugly stack trace in catalina.out. It might be better to catch UnsupportedOperationException and emit a one-line error message -- one that isn't SEVERE. | 2012-02-03 14:43:28 | 1,328,300,000 | resolved fixed | fbf9166 | 1,328,710,000 | java/org/apache/catalina/mbeans/MBeanDumper.java | Tomcat |
342 | 52,586 | Bug 52586 When requests are forwarded, the request attribute javax.servlet.forward.path_info is assigned an incorrect value. | As per the servlet spec, the values for: javax.servlet.forward.request_uri javax.servlet.forward.context javax.servlet.forward.servlet_path javax.servlet.forward.path_info javax.servlet.forward.query_string MUST be set to the values from the very first servlet that serviced the current request. However, it seems that Tomcat is populating path_info with the value of the LAST path_info serviced in the request (i.e. the final servlet that serviced the request). It's possible the other value assignments are afflicted by similar defects, I've not explicitly tested for this. Because of this issue, it's impossible to correctly reconstruct the original request's URI piecemeal by concatenating context+servlet_path+path_info+?+query_string, since path_info will contain the path to another servlet and thus this concatenation will produce a probably invalid URI target. Therefore, creating "click here to retry" links is impossible without workaround code. The critical issue here is the deviation from the servlet spec, which spells out the behavior of those attributes. | 2012-02-02 18:49:59 | 1,328,230,000 | resolved fixed | 660513c | 1,328,480,000 | java/org/apache/catalina/core/StandardHostValve.java | Tomcat |
343 | 52,577 | Bug 52577 Response output written in filter can be truncated | Due to changes 1229726, 1229727 and 1229728 output written to response in the filter can be truncated up to 8192 bytes. Consider the following scenario: - you have a filter that invoke getWriter() before chain.doFilter(request, responseWrapper) - responseWrapper overrides getWriter() method and returns some buffered writer, not the real one - during execution of chain.doFilter there is a forward Before the forward ApplicationDispather calls resetBuffer on response, which in turn calls reset() on OutputBuffer, which sets gotEnc field to false. This field is initialized in the setConverter() method which is called from response.getWriter(), but since our wrapperResponse overrides getWriter(), OutputBuffer.setConverter() never called and OutputBuffer still has gotEnc = false. Response's close() and flushBuffer() methods call OutputBuffer's flush(), but since gotEnc == false, conv.flushBuffer() is not called: if (gotEnc && conv != null) { conv.flushBuffer(); } A workaround for us is to implement getWriter() method in responseWrapper like this: public Writer getWriter() { Writer originalWriter = originalResponse.getWriter();//save for future processing return ourWriter; } Maybe you should change flushing to something like that: if (conv != null) { conv.flushBuffer(); } because you invoke conv.convert() without any checks in the write*() methods and it seems like conv is never null. | 2012-02-02 07:45:44 | 1,328,190,000 | resolved fixed | 2fd117b | 1,328,480,000 | java/org/apache/catalina/connector/OutputBuffer.java java/org/apache/catalina/connector/Response.java test/org/apache/catalina/connector/TestOutputBuffer.java | Tomcat |
344 | 52,587 | Bug 52587 NPE in authenticator when no realm/resource is defined | When no Realm is available to authenticate against, an NPE is thrown. STR: 1. Start with a stock 7.0.25 and modify server.xml: 2. Comment-out <Resource> in <GlobalNamingResources> 3. Comment-out <Realm> in <Engine> 4. Deploy manager app and try to log in java.lang.NullPointerException org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:340) org.apache.catalina.authenticator.BasicAuthenticator.authenticate(BasicAuthenticator.java:158) org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:544) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:987) org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579) org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1600) java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) java.lang.Thread.run(Thread.java:680) Clearly, this is a pathological setup, but it might be nice to get a decent error message instead of an NPE. | 2012-02-02 20:00:01 | 1,328,230,000 | resolved fixed | 49a52cb | 1,328,470,000 | java/org/apache/catalina/core/StandardEngine.java | Tomcat |
345 | 52,444 | Bug 52444 Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times | See 52326 for background, noting particularly the following: "As long as SCI processing involves expensive classloading, larger applications will suffer from long startup times and thus be encouraged to "shut off" this functionality via metadata-complete='true'." This issue, then, is intended to address classloading-based approach to @HandlesTypes processing by replacing it with something faster and generally less problematic. ASM would be one way to get it done. | 2012-01-09 17:11:12 | 1,326,150,000 | resolved fixed | f4896de | 1,327,920,000 | java/org/apache/catalina/startup/ContextConfig.java java/org/apache/tomcat/util/bcel/classfile/JavaClass.java test/org/apache/catalina/startup/TestContextConfigAnnotation.java | Tomcat |
346 | 52,547 | Bug 52547 incorrect byeswritten log after completed async request under http1.0 | null | 2012-01-27 19:43:42 | 1,327,710,000 | resolved fixed | f2edc92 | 1,327,780,000 | java/org/apache/coyote/http11/AbstractOutputBuffer.java | Tomcat |
347 | 52,543 | Bug 52543 Exception | SEVERE: Error finishing response java.lang.ArrayIndexOutOfBoundsException at java.lang.System.arraycopy(Native Method) at org.apache.coyote.http11.AbstractOutputBuffer.write(AbstractOutputBuffer.java:495) at org.apache.coyote.http11.AbstractOutputBuffer.sendStatus(AbstractOutputBuffer.java:337) at org.apache.coyote.http11.AbstractHttp11Processor.prepareResponse(AbstractHttp11Processor.java:1418) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:756) at org.apache.coyote.Response.action(Response.java:168) at org.apache.coyote.http11.AbstractOutputBuffer.endRequest(AbstractOutputBuffer.java:310) at org.apache.coyote.http11.InternalOutputBuffer.endRequest(InternalOutputBuffer.java:158) at org.apache.coyote.http11.AbstractHttp11Processor.endRequest(AbstractHttp11Processor.java:1586) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1022) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:307) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) big application i dont know why its happens may be due to the fact that twice as add some cookie | 2012-01-27 11:18:09 | 1,327,680,000 | resolved fixed | ee0562d | 1,327,780,000 | java/org/apache/coyote/http11/AbstractOutputBuffer.java | Tomcat |
348 | 52,511 | Bug 52511 Exception logged in annotation scanning for web apps without /WEB-INF/classes | null | 2012-01-23 21:02:08 | 1,327,370,000 | resolved fixed | 3277494 | 1,327,700,000 | java/org/apache/catalina/startup/ContextConfig.java | Tomcat |
349 | 52,474 | Bug 52474 Do not load listeners declared with blank spaces on tld file. | null | 2012-01-17 05:41:49 | 1,326,800,000 | resolved fixed | 2dd8a40 | 1,327,090,000 | java/org/apache/catalina/startup/TldRuleSet.java | Tomcat |
350 | 51,408 | Bug 51408 String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales | There seem to be rather a lot of instances where Strings and bytes are cconverted using the default charset. Since the default charset is unknown, its behaviour cannot be relied on. | 2011-06-21 15:47:16 | 1,308,690,000 | resolved fixed | 9722128 | 1,326,990,000 | java/org/apache/catalina/ant/AbstractCatalinaTask.java java/org/apache/catalina/authenticator/DigestAuthenticator.java java/org/apache/catalina/realm/JNDIRealm.java java/org/apache/catalina/realm/RealmBase.java java/org/apache/catalina/servlets/WebdavServlet.java java/org/apache/catalina/util/RequestUtil.java java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/SSLValve.java java/org/apache/coyote/http11/filters/BufferedInputFilter.java java/org/apache/coyote/http11/filters/ChunkedInputFilter.java java/org/apache/coyote/http11/filters/IdentityInputFilter.java java/org/apache/coyote/http11/filters/VoidInputFilter.java java/org/apache/jasper/Constants.java java/org/apache/jasper/compiler/SmapUtil.java java/org/apache/naming/resources/Constants.java java/org/apache/naming/resources/ProxyDirContext.java java/org/apache/tomcat/util/buf/MessageBytes.java | Tomcat |
351 | 52,480 | Bug 52480 TC7 + AntCompiler problems with whitespace in pathname | null | 2012-01-18 00:28:00 | 1,326,860,000 | resolved fixed | b553519 | 1,326,890,000 | java/org/apache/catalina/loader/WebappLoader.java | Tomcat |
352 | 38,216 | Bug 38216 Extend Jmxproxy to allow call of MBean Operations | Currently one can only query Beans or set/get Attributes of them. It would be good if a certain operation of a MBean could be called by the Jmxproxy Servlet. | 2006-01-10 18:01:22 | 1,136,930,000 | resolved fixed | bd478e5 | 1,326,660,000 | java/org/apache/catalina/manager/JMXProxyServlet.java | Tomcat |
353 | 52,461 | Bug 52461 java.lang.IllegalArgumentException: URI scheme is not "file" is thrown in ContextConfig.getDefaultWebXmlFragment | null | 2012-01-12 20:34:28 | 1,326,420,000 | resolved fixed | 53615e5 | 1,326,490,000 | java/org/apache/catalina/startup/ContextConfig.java | Tomcat |
354 | 52,445 | Bug 52445 Methodexpression with arguments fails on nested properties | null | 2012-01-10 03:25:21 | 1,326,180,000 | resolved fixed | 3c8f40f | 1,326,490,000 | java/org/apache/el/parser/AstValue.java test/org/apache/el/TestMethodExpressionImpl.java | Tomcat |
355 | 52,443 | Bug 52443 Tomcat#defaultRealm shares Realm instance between web applications, resulting in INFO log message from lifecycle | null | 2012-01-09 16:43:35 | 1,326,150,000 | resolved fixed | c38ed95 | 1,326,400,000 | java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/mbeans/TestRegistration.java | Tomcat |
356 | 52,245 | Bug 52245 Add detection of EL Jar to WebappClassLoader | The EL API is not currently detected by the code in WebappClassLoader. Applications containing el-api.jar will not start. (patch to follow). | 2011-11-25 15:13:41 | 1,322,250,000 | resolved fixed | ee2a461 | 1,326,400,000 | java/org/apache/catalina/loader/WebappClassLoader.java | Tomcat |
357 | 52,440 | Bug 52440 Wrong getValueReference behaviour with Facelets parameter expressions | ValueExpression method getValueReference should return base object and property. But it returns null if ValueExpression is Facelets parameter. Example: someVar = #{concreteObject.property} ValueExpression for #{someVar} return null from method getValueReference (guess because it is simple expression #{someVar}), but logicaly it should return parent expressions ValueReference (need hierachical ValueReference lookup). I made workaround with Java Reflect API in my code and it illustrates problem: ELContext elContext = FacesContext.getCurrentInstance().getELContext(); ValueReference reference = exp.getValueReference(elContext); if (reference == null && exp instanceof TagValueExpressionUEL) { ValueExpressionImpl origExp = (ValueExpressionImpl) ((TagValueExpressionUEL) exp).getWrapped(); // TODO: JR: find better way to get base and property. ! Code is not portable because uses Tomcat EL implementation details. ! Field field = ReflectionUtils.findField(origExp.getClass(), EL_IMPL_VAR_PROPERTY); field.setAccessible(true); VariableMapper varMapper = (VariableMapper) ReflectionUtils.getField(field, origExp); field = ReflectionUtils.findField(origExp.getClass(), EL_IMPL_NODE_PROPERTY); field.setAccessible(true); SimpleNode node = (SimpleNode) ReflectionUtils.getField(field, origExp); if (varMapper != null && node != null) { ValueExpression parentExp = varMapper.resolveVariable(node.getImage()); if (parentExp != null) { try { reference = parentExp.getValueReference(elContext); if (reference == null) { reference = getValueReference(parentExp); } } catch (PropertyNotFoundException e) { LOG.warn("Property not found: " + e.getMessage()); } } } } | 2012-01-09 09:11:20 | 1,326,120,000 | resolved fixed | f277b14 | 1,326,400,000 | java/org/apache/el/parser/AstIdentifier.java test/org/apache/el/TestValueExpressionImpl.java | Tomcat |
358 | 52,328 | Bug 52328 Massive garbage production observed when using the response writer | In our application we used to use Tomcat 5, by writing our content directly to the response writer in our servlet: Writer w = response.getWriter(); w.append(...) We have regularly measured performance of our application under stress with multiple simultaneous requests per second. We recently upgraded to Tomcat 7, and immediately observed a performance degradation of 10% on the request roundtrip on the same machine and the same tests, compared to our application deployed on Tomcat 5. Profiling with JProfiler showed that we got massive amount of transient objects {{java.nio.HeapCharBuffer}} produced - 400Mb+ within a few minutes. The way we are writing the response is by multiple statements of {{append}} of small strings or single chars, which used to work properly. For experiment, we wrapped the response writer with a {{BufferedWriter}} with a buffer of 64k. This brought our application's performance back to normal. We see this as either a: - anti-pattern usage since Tomcat 6/7, in which case please provide some documentation about that. - bug in the C2BConverter that is applied per every call to the CoyoteWriter write methods, which generates the garbage buffers per every call. We know that the response stream has a 8k buffer by default. Nevertheless, this buffer comes after the encoding step and as such it is too late to help with the garbage. Perhaps Tomcat can buffer before it encodes? Still, so much transient objects for just a pattern of eligible use of the servlet API seems a bug to me. | 2011-12-14 11:03:38 | 1,323,880,000 | resolved fixed | 9c7ec4c | 1,326,230,000 | java/org/apache/catalina/connector/OutputBuffer.java | Tomcat |
359 | 52,387 | Bug 52387 org.catalina.tomcat.startup.Tomcat#silence method doesn't use the host where we add the applications | null | 2011-12-27 01:48:16 | 1,324,970,000 | resolved fixed | 3787242 | 1,325,330,000 | java/org/apache/catalina/startup/Tomcat.java | Tomcat |
360 | 52,326 | Bug 52326 Lower log level for failed class loading | null | 2011-12-13 18:47:41 | 1,323,820,000 | resolved fixed | addd522 | 1,325,190,000 | java/org/apache/catalina/startup/ContextConfig.java | Tomcat |
361 | 52,316 | Bug 52316 AccessLog does not log size for files sent with sendfile | null | 2011-12-09 22:23:47 | 1,323,490,000 | resolved fixed | 9f52382 | 1,325,110,000 | java/org/apache/catalina/valves/AccessLogValve.java | Tomcat |
362 | 52,303 | Bug 52303 NonLoginAuthenticator does not honour session timeout with SingleSignOn Valve | null | 2011-12-08 09:35:59 | 1,323,360,000 | resolved fixed | 8b6d341 | 1,325,020,000 | java/org/apache/catalina/authenticator/NonLoginAuthenticator.java | Tomcat |
363 | 52,384 | Bug 52384 URL parameter without value should be parsed successfully when logging level = DEBUG | null | 2011-12-24 18:16:23 | 1,324,770,000 | resolved fixed | 34b011b | 1,324,860,000 | java/org/apache/tomcat/util/http/Parameters.java | Tomcat |
364 | 52,356 | Bug 52356 Prevent potential data races on "org.apache.catalina.tribes.transport.bio.util.FastQueue.size". | null | 2011-12-18 23:41:25 | 1,324,270,000 | resolved fixed | 6f3cafe | 1,324,680,000 | java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java | Tomcat |
365 | 52,354 | Bug 52354 Protect concurrent accesses to field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove" | null | 2011-12-18 23:04:53 | 1,324,270,000 | resolved fixed | 8983419 | 1,324,670,000 | java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java | Tomcat |
366 | 52,213 | Bug 52213 Field "org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" should be volatile. | null | 2011-11-18 23:29:32 | 1,321,680,000 | resolved fixed | d69fb8e | 1,324,670,000 | java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java | Tomcat |
367 | 52,293 | Bug 52293 antiResourceLocking and unpackWARs | null | 2011-12-06 18:54:27 | 1,323,220,000 | resolved fixed | 33e48db | 1,324,500,000 | java/org/apache/catalina/startup/ContextConfig.java | Tomcat |
368 | 52,321 | Bug 52321 coda/prelude order not respected | null | 2011-12-13 00:13:28 | 1,323,750,000 | resolved fixed | 22e7e15 | 1,323,810,000 | java/org/apache/catalina/core/ApplicationJspConfigDescriptor.java java/org/apache/catalina/deploy/WebXml.java | Tomcat |
369 | 52,208 | Bug 52208 NullPointerException in tribes.transport.nio.NioReceiver.listen() in test run | null | 2011-11-18 10:37:32 | 1,321,630,000 | resolved fixed | 9403e4f | 1,323,380,000 | java/org/apache/catalina/tribes/transport/nio/NioReceiver.java | Tomcat |
370 | 52,028 | Bug 52028 Embeded Tomcat using a Connector with a random port (port 0) | null | 2011-10-14 12:27:22 | 1,318,610,000 | resolved fixed | 63f708a | 1,322,520,000 | java/org/apache/catalina/connector/Connector.java java/org/apache/coyote/AbstractProtocol.java java/org/apache/tomcat/util/net/AbstractEndpoint.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/JIoEndpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java test/org/apache/catalina/authenticator/TestFormAuthenticator.java test/org/apache/catalina/connector/TestConnector.java test/org/apache/catalina/connector/TestRequest.java test/org/apache/catalina/core/TestStandardContext.java test/org/apache/catalina/core/TestSwallowAbortedUploads.java test/org/apache/catalina/filters/TestExpiresFilter.java test/org/apache/catalina/filters/TestRemoteIpFilter.java test/org/apache/catalina/mbeans/TestRegistration.java test/org/apache/catalina/servlets/TestDefaultServlet.java test/org/apache/catalina/startup/SimpleHttpClient.java test/org/apache/catalina/startup/TomcatBaseTest.java test/org/apache/coyote/http11/TestAbstractHttp11Processor.java test/org/apache/coyote/http11/TestInternalInputBuffer.java test/org/apache/coyote/http11/filters/TestChunkedInputFilter.java test/org/apache/tomcat/util/http/TestCookiesAllowEquals.java test/org/apache/tomcat/util/http/TestCookiesAllowHttpSeps.java test/org/apache/tomcat/util/http/TestCookiesAllowNameOnly.java test/org/apache/tomcat/util/http/TestCookiesDisallowEquals.java test/org/apache/tomcat/util/net/TestXxxEndpoint.java | Tomcat |
371 | 52,225 | Bug 52225 Adding Alias for existing host on running Tomcat causes ClassCastException | null | 2011-11-22 07:14:09 | 1,321,960,000 | resolved fixed | f3a7cd9 | 1,321,950,000 | java/org/apache/tomcat/util/http/mapper/Mapper.java test/org/apache/tomcat/util/http/mapper/TestMapper.java | Tomcat |
372 | 52,173 | Bug 52173 Add a drop of additional clarification to doc on the delegate setting of the WebappClassLoader | null | 2011-11-13 14:59:57 | 1,321,210,000 | resolved fixed | 574af73 | 1,321,310,000 | java/org/apache/catalina/loader/WebappClassLoader.java | Tomcat |
373 | 50,570 | Bug 50570 Allow explicit use of FIPS mode in APR lifecycle listener | null | 2011-01-11 12:27:44 | 1,294,770,000 | resolved fixed | c2001ce | 1,320,870,000 | java/org/apache/catalina/core/AprLifecycleListener.java java/org/apache/tomcat/jni/SSL.java | Tomcat |
374 | 52,156 | Bug 52156 ServletContext.getResource(path) doesn't accept ".." anymore | null | 2011-11-08 18:59:53 | 1,320,800,000 | resolved fixed | b7f5c7e | 1,320,790,000 | java/org/apache/catalina/core/ApplicationContext.java | Tomcat |
375 | 52,113 | Bug 52113 Tomcat reports missing context xml at wrong location on JMX deployment | Hello, I'm using Tomcat JMX interface to deploy apps as follows: 1) call MBeanFactory#createStandardContext, where MBeanFactory is "Catalina:type=MBeanFactory", with parameters: parent = "Catalina:type=Host,host=localhost", path = "/w1", docBase = <my path to the app> 2) call <my app>#start, where <my app> is "Catalina:j2eeType=WebModule,name=//localhost/w1,J2EEApplication=none,J2EEServer=none" As result, my app _is succesfully deployed (its context is available)_, but nevertheless I see the following exceptions in the server console (full stacktraces are skipped, to be attached next comment): 31 ???? 2011 14:05:53 org.apache.catalina.startup.ContextConfig processContextConfig SEVERE: Missing context.xml: file:/C:/<my Tomcat base folder>/conf/Catalina/localhost/w1.xml java.io.FileNotFoundException: C:\<my Tomcat base folder>\conf\Catalina\localhost\w1.xml 31 ???? 2011 14:05:53 org.apache.catalina.startup.ContextConfig processContextConfig SEVERE: Parse error in context.xml for /w1 java.io.FileNotFoundException: C:\<my Tomcat base folder>\conf\Catalina\localhost\w1.xml 31 ???? 2011 14:05:53 org.apache.catalina.startup.ContextConfig configureStart SEVERE: Marking this application unavailable due to previous error(s) 31 ???? 2011 14:05:53 org.apache.catalina.core.StandardContext startInternal SEVERE: Error getConfigured 31 ???? 2011 14:05:53 org.apache.catalina.core.StandardContext startInternal SEVERE: Context [/w1] startup failed due to previous errors The exceptions looks strange to me, since I don't understand why Tomcat searches for a context xml file during the jmx deploy. Do I do something wrong in the deployment workflow? Regards, Michael | 2011-10-31 14:09:21 | 1,320,080,000 | resolved fixed | d7af36d | 1,320,180,000 | java/org/apache/catalina/mbeans/MBeanFactory.java | Tomcat |
376 | 52,051 | Bug 52051 NullPointerException when Jasper tries to compile a directory | null | 2011-10-18 19:33:51 | 1,318,980,000 | resolved fixed | 62ff013 | 1,319,040,000 | java/org/apache/jasper/JspCompilationContext.java java/org/apache/jasper/compiler/JspUtil.java | Tomcat |
377 | 52,009 | Bug 52009 NPE exception in org.apache.catalina.connector.CoyoteAdapter.service | null | 2011-10-11 08:06:49 | 1,318,330,000 | resolved fixed | b90c0a1 | 1,318,630,000 | java/org/apache/catalina/connector/CoyoteAdapter.java test/org/apache/catalina/comet/TestCometProcessor.java | Tomcat |
378 | 51,972 | Bug 51972 sendRedirect does not support protocol relative URLs | null | 2011-10-05 21:31:50 | 1,317,860,000 | resolved fixed | e70797e | 1,318,250,000 | java/org/apache/catalina/connector/Response.java | Tomcat |
379 | 51,952 | Bug 51952 IllegalStateException using CompressionFilter with Tomcat 7.0.21/22 | null | 2011-10-04 15:36:57 | 1,317,760,000 | resolved fixed | 3ab3757 | 1,318,020,000 | java/org/apache/catalina/Context.java java/org/apache/catalina/connector/Response.java java/org/apache/catalina/core/StandardContext.java | Tomcat |
380 | 51,956 | Bug 51956 RemoteAddrFilter uses remote host (not address) in doFilterEvent | public void doFilterEvent(CometEvent event, CometFilterChain chain) throws IOException, ServletException { processCometEvent(event.getHttpServletRequest().getRemoteHost(), event, chain); } Use of getRemoteHost should be getRemoteAddr. | 2011-10-04 21:58:18 | 1,317,780,000 | resolved fixed | d6d1c6f | 1,317,770,000 | java/org/apache/catalina/filters/RemoteAddrFilter.java | Tomcat |
381 | 51,630 | Bug 51630 java.lang.IllegalStateException: Calling [asyncComplete()] | example: webapps\examples\WEB-INF\classes\async\Async0.java log file: logs\localhost.2011-08-07.log ============================================= java.lang.IllegalStateException: Calling [asyncComplete()] is not valid for a request with Async state [DISPATCHED] at org.apache.coyote.AsyncStateMachine.asyncComplete(AsyncStateMachine.java:221) at org.apache.coyote.http11.Http11Processor.actionInternal(Http11Processor.java:525) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:773) at org.apache.coyote.Request.action(Request.java:344) at org.apache.catalina.core.AsyncContextImpl.complete(AsyncContextImpl.java:89) at async.Async0.service(Async0.java:42) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:684) at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:593) at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:530) at org.apache.catalina.core.AsyncContextImpl$1.run(AsyncContextImpl.java:173) at org.apache.catalina.core.AsyncContextImpl.doInternalDispatch(AsyncContextImpl.java:314) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:219) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:462) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:851) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:296) at org.apache.coyote.http11.AbstractHttp11Processor.asyncDispatch(AbstractHttp11Processor.java:1220) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:511) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) | 2011-08-07 02:34:08 | 1,312,700,000 | resolved fixed | b080c7e | 1,317,670,000 | webapps/examples/WEB-INF/classes/async/Async0.java | Tomcat |
382 | 51,910 | Bug 51910 NPE in comet processing when shutting down Tomcat | null | 2011-09-28 12:05:19 | 1,317,230,000 | resolved fixed | a450d2c | 1,317,480,000 | java/org/apache/catalina/core/StandardWrapperValve.java | Tomcat |
383 | 51,905 | Bug 51905 Infinite loop when shutting down AprEndpoint | null | 2011-09-28 09:20:16 | 1,317,220,000 | resolved fixed | 136097e | 1,317,200,000 | java/org/apache/tomcat/util/net/AprEndpoint.java | Tomcat |
384 | 51,872 | Bug 51872 request.getRemoteAddr() sometimes returning IP address from the previous request | request.getRemoteAddr() sometimes returning IP address from the previous request. We have compared the IP address returned from the getRemoteHost() and from the headers with getRemoteAddr() and getRemoteAddr is returning wrong IP address. We believe that this may come from the "pooled" request objects where it is sometimes sees the previous value of the remote IP. The problem doesn't occur all the time. We are heavily relying on the getRemoteAddr to verify the remote client for some of our authentication. Can this be fixed? 2011-09-22 16:49:55,713 DEBUG [yjava.tomcat.valves.YahooConnectionValve] THREADID:1262 YahooConnectionValve invoked 2011-09-22 16:49:55,826 DEBUG [yjava.tomcat.valves.YahooConnectionValve] THREADID:1262 YahooConnectionValve request.getInfo(): org.apache.coyote.catalina.CoyoteRequest/1.0 2011-09-22 16:49:56,013 DEBUG [yjava.tomcat.valves.YahooConnectionValve] THREADID:1262 YahooConnectionValve request.getRemoteAddr(): 98.138.85.230 2011-09-22 16:49:56,014 DEBUG [yjava.tomcat.valves.YahooConnectionValve] THREADID:1262 YahooConnectionValve request.getRemoteHost(): web120016.mail.ne1.yahoo.com [][~]$ nslookup web120016.mail.ne1.yahoo.com Server: 10.72.226.8 Address: 10.72.226.8#53 Name: web120016.mail.ne1.yahoo.com Address: 98.138.85.143 2011-09-22 16:49:56,014 DEBUG [yjava.tomcat.valves.YahooConnectionValve] THREADID:1262 YahooConnectionValve request.getRequestedSessionId(): null 2011-09-22 16:49:56,015 DEBUG [yjava.tomcat.valves.YahooConnectionValve] THREADID:1262 YahooConnectionValve request.getHeader(): accept:*/* host:ls100.mail.vip.ne1.yahoo.com:4080 content-type:application/x-ypy yahoo-app-auth:v=1;a=yahoo.mail.acl.yca.lsg-prod;h=98.138.85.143;t=1319282225; content-length:574 2011-09-22 16:49:56,015 DEBUG [yjava.filter.address.RemoteIPTranslator] THREADID:1262 Got remote address '98.138.85.230' and port '46663' | 2011-09-22 17:52:57 | 1,316,730,000 | resolved fixed | 18792f4 | 1,317,150,000 | java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/coyote/ajp/AbstractAjpProcessor.java java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpNioProcessor.java java/org/apache/coyote/ajp/AjpProcessor.java java/org/apache/coyote/http11/AbstractHttp11Processor.java | Tomcat |
385 | 51,887 | Bug 51887 Speedup sessionid generation when running testsuite | null | 2011-09-24 14:09:54 | 1,316,890,000 | resolved fixed | 73a6e56 | 1,316,880,000 | test/org/apache/catalina/startup/FastNonSecureRandom.java test/org/apache/catalina/startup/TomcatBaseTest.java | Tomcat |
386 | 51,860 | Bug 51860 HTTP/SSL with NIO won't work | null | 2011-09-21 10:03:38 | 1,316,610,000 | resolved fixed | 66f2d5b | 1,316,610,000 | java/org/apache/tomcat/util/net/jsse/JSSEKeyManager.java | Tomcat |
387 | 51,852 | Bug 51852 BeanELResolver varargs handling is broken in multiple ways | null | 2011-09-20 19:16:07 | 1,316,560,000 | resolved fixed | bfabec5 | 1,316,610,000 | java/javax/el/BeanELResolver.java test/javax/el/TestBeanELResolverVarargsInvocation.java | Tomcat |
388 | 51,580 | Bug 51580 Severe error deploying WAR application (ExpandWar error) | null | 2011-07-28 22:41:57 | 1,311,910,000 | resolved fixed | feff880 | 1,316,550,000 | java/org/apache/catalina/startup/ExpandWar.java | Tomcat |
389 | 51,687 | Bug 51687 Improve JreMemoryLeakPreventionListener against leak caused by sun.java2d.Disposer | The sun.java2d.Disposer class, when loaded, starts an endless daemon thread that can inherit the WebappClassLoader as its context loader. This will cause a leak when the webapp is unloaded. It would be useful if JreMemoryLeakPreventionListener could load this class to prevent the leak. | 2011-08-19 14:41:36 | 1,313,780,000 | resolved fixed | 423fd89 | 1,316,550,000 | java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java | Tomcat |
390 | 51,811 | Bug 51811 SSL configuration property name illegal | null | 2011-09-14 14:57:22 | 1,316,030,000 | resolved fixed | 9425437 | 1,316,350,000 | java/org/apache/coyote/http11/AbstractHttp11JsseProtocol.java test/org/apache/tomcat/util/net/TestCustomSsl.java | Tomcat |
391 | 51,794 | Bug 51794 Race condition in NioEndpoint$Poller causes socket to not be read until selectorTimeout | I'm seeing an occasional race condition that happens between NioEndpoint$Poller#run and Http11NioProtocol finishing an event. What happens is that there is a race condition upon waking up the Selector that can cause a SelectionKey to not be marked with InterestOps.READ as soon as it could. The race is on Poller.wakeupCounter. These steps can occur which causes my SelectionKey to not have its interest ops reset soon and the Selector to not have wakeup() called on it. 1. Poller0 - Starts processing its run loop and calls events(). 2. Poller0 - Checks the wakeupCounter.get() > 0 which evaluates to false (wakeupCounter is 0). 3. Worker1 - Finishes an event and calls in to Poller#addEvent 4. Worker1 - Enqueues the PollerEvent that will reset the interest ops. 5. Worker1 - Calls wakeupCounter.incrementAndGet to increment and get wakeupCounter to 1. This fails the check to call selector.wakeup(); 6. Poller0 - Calls wakeupCounter.set(-1) 7. Poller0 - Calls selector.select(selectorTimeout) and blocks for either the full time out or until another unrelated SelectionKey is polled. 8. Poller0 - Ultimately gets around to calling events() again which now resets the interest ops for the SelectionKey that was processed by Worker1. The simple fix for this is to change this code: if (wakeupCounter.get() > 0) { //if we are here, means we have other stuff to do //do a non blocking select keyCount = selector.selectNow(); } else { wakeupCounter.set(-1); keyCount = selector.select(selectorTimeout); } to this if (wakeupCounter.getAndSet(-1) > 0) { //if we are here, means we have other stuff to do //do a non blocking select keyCount = selector.selectNow(); } else { keyCount = selector.select(selectorTimeout); } | 2011-09-09 18:51:35 | 1,315,610,000 | resolved fixed | 58429a8 | 1,316,010,000 | java/org/apache/tomcat/util/net/NioEndpoint.java | Tomcat |
392 | 51,698 | Bug 51698 ajp CPing/Forward-Request packet forgery, is a design decision? or a security vulnerability? | null | 2011-08-20 07:54:08 | 1,313,840,000 | resolved fixed | a2538ce | 1,314,650,000 | java/org/apache/coyote/ajp/AbstractAjpProcessor.java java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpNioProcessor.java java/org/apache/coyote/ajp/AjpProcessor.java | Tomcat |
393 | 51,739 | Bug 51739 If landingpage is a XHTML (JSF/CDI), nullpointer exception. | null | 2011-08-29 13:47:09 | 1,314,640,000 | resolved fixed | 3513acc | 1,314,640,000 | java/org/apache/catalina/authenticator/FormAuthenticator.java | Tomcat |
394 | 51,712 | Bug 51712 Regression in cache-control headers for requests with security-constraints | null | 2011-08-23 20:55:25 | 1,314,150,000 | resolved fixed | 196a8f5 | 1,314,630,000 | java/org/apache/catalina/authenticator/AuthenticatorBase.java | Tomcat |
395 | 51,736 | Bug 51736 Make rpcTimeout configurable in BackupManager. | Default rpcTimeout that BackupManager sets to AbstractReplicatedMap is 15000 msec. This is not configurable. When receiving MapMessage.MSG_START (and after a new member is added), publishEntryInfo is called for all sessions where primary and backup node are not included. And, the backup node is set to the session. When only one Tomcat starts in cluster, publishEntryInfo will be called for all sessions. As a result, the RPC message has the possibility of the timeout. When acquiring session from restarting Tomcat, warning of "Unable to retrieve remote object for key:XXX" is logged. And the session cannot be continued. I make rpcTimeout configurable in BackupManager. Additionally, if RPC message timeouted in AbstractReplicatedMap#broadcast, add warning message. Best Regards. | 2011-08-29 10:26:09 | 1,314,630,000 | resolved fixed | 87a32d6 | 1,314,610,000 | java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java | Tomcat |
396 | 51,704 | Bug 51704 Dubious use of mkdirs() return code in juli FileHandler | null | 2011-08-22 13:17:27 | 1,314,030,000 | resolved fixed | 4587f13 | 1,314,380,000 | java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/loader/WebappClassLoader.java java/org/apache/catalina/loader/WebappLoader.java java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/manager/host/HostManagerServlet.java java/org/apache/catalina/servlets/CGIServlet.java java/org/apache/catalina/session/FileStore.java java/org/apache/catalina/startup/ExpandWar.java java/org/apache/catalina/startup/HostConfig.java java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/jasper/JspCompilationContext.java java/org/apache/juli/FileHandler.java test/org/apache/catalina/connector/TestCoyoteAdapter.java test/org/apache/catalina/core/TestAsyncContextImpl.java test/org/apache/catalina/core/TestStandardContext.java test/org/apache/catalina/servlets/TestDefaultServlet.java test/org/apache/catalina/startup/TomcatBaseTest.java | Tomcat |
397 | 51,558 | Bug 51558 Tomcat Embedded: using tomcat.addWebapp always overrides programmatic context-settings with default values for the context at start of tomcat server | when i deploy an webapp with a tomcat server, i use the Function "tomcat.addWebapp". I looked into the code of this function and it makes the following call: ctx.addLifecycleListener(new DefaultWebXmlListener()); When i start tomcat, this DefaultWebXmlListener is activated automatically, and always does the following code, so the manager i set for my context gets overriden with this code: public static void initWebappDefaults(Context ctx) { ... // Sessions ctx.setManager( new StandardManager()); ctx.setSessionTimeout(30); ... } so when i set a StandardManager programatically, it gets overriden by this code. The workaround i used, is to unregister the DefaultWebXmlListener, and than add my own context.xml specific settings, like a custom manager for deactivating session persistance: Context warContext = tomcat.addWebapp(warContextPath, warLocation); LifecycleListener[] lclisteners = warContext.findLifecycleListeners(); LifecycleListener defaultWebXMLListener = null; for (int i=0; i < lclisteners.length; i++){ if (lclisteners[i] instanceof DefaultWebXmlListener){ defaultWebXMLListener = lclisteners[i]; } } warContext.removeLifecycleListener(defaultWebXMLListener); ... StandardManager manager = new StandardManager(); manager.setPathname(null); // disable session persistance: //manager.setPathname("SESSIONS.ser"); warContext.setCookies(true); warContext.setCrossContext(true); warContext.setManager(manager); i think its a bug that using the "tomcat.addWebapp" method makes it impossible to set context.xml specific settings programmatically, because they always get overriden by default values at the tomcat start. | 2011-07-26 10:11:48 | 1,311,690,000 | resolved fixed | 25f02b4 | 1,314,370,000 | java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java | Tomcat |
398 | 51,713 | Bug 51713 Bad Connector protocol causes NullPointerException when using Executor | Under the following configuration, an NPE is thrown because _setExecutor() calls con.getProtocolHandler().getClass() when the protocol handler is null. It would be nice to report a bad configuration instead of suffering an NPE. server.xml: <Executor name="tomcatThreadPool" namePrefix="catalina-exec-" maxThreads="150" minSpareThreads="4"/> <Connector port="12345" redirectPort="443" protocol="HTTP" secure="true" scheme="https" proxyPort="80" URIEncoding="UTF-8" executor="tomcatThreadPool" /> catalina.out: Aug 23, 2011 5:18:30 PM org.apache.catalina.connector.Connector <init> SEVERE: Protocol handler instantiation failed Aug 23, 2011 5:18:30 PM org.apache.tomcat.util.digester.Digester startElement SEVERE: Begin event threw exception java.lang.NullPointerException at org.apache.catalina.startup.ConnectorCreateRule._setExecutor(ConnectorCreateRule.java:69) at org.apache.catalina.startup.ConnectorCreateRule.begin(ConnectorCreateRule.java:63) at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1276) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:501) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:179) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1537) at org.apache.catalina.startup.Catalina.load(Catalina.java:555) at org.apache.catalina.startup.Catalina.load(Catalina.java:596) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:281) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:449) Aug 23, 2011 5:18:30 PM org.apache.catalina.startup.Catalina load WARNING: Catalina.start using conf/server.xml: Error at (104, 66) : null Aug 23, 2011 5:18:30 PM org.apache.catalina.connector.Connector <init> SEVERE: Protocol handler instantiation failed Aug 23, 2011 5:18:30 PM org.apache.tomcat.util.digester.Digester startElement SEVERE: Begin event threw exception java.lang.NullPointerException at org.apache.catalina.startup.ConnectorCreateRule._setExecutor(ConnectorCreateRule.java:69) at org.apache.catalina.startup.ConnectorCreateRule.begin(ConnectorCreateRule.java:63) at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1276) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:501) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:179) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1537) at org.apache.catalina.startup.Catalina.load(Catalina.java:555) at org.apache.catalina.startup.Catalina.start(Catalina.java:609) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:322) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:450) Aug 23, 2011 5:18:31 PM org.apache.catalina.startup.Catalina load WARNING: Catalina.start using conf/server.xml: Error at (104, 66) : null Aug 23, 2011 5:18:31 PM org.apache.catalina.startup.Catalina start SEVERE: Cannot start server. Server instance is not configured. | 2011-08-23 21:44:53 | 1,314,150,000 | resolved fixed | 517fd9b | 1,314,230,000 | java/org/apache/catalina/connector/Connector.java | Tomcat |
399 | 51,688 | Bug 51688 JreMemoryLeakPreventionListener should protect against AWT thread creation | Any webapp that calls java.awt.Toolkit.getDefaultToolkit will launch a new thread (AWT-Windows, AWT-XAWT, etc.) which will capture the ContextClassLoader, pinning the webapp in memory after an undeploy/redeploy. A simple addition to JreMemoryLeakPreventionListener can alleviate this condition. | 2011-08-19 14:49:17 | 1,313,780,000 | resolved fixed | 0cdbfa6 | 1,314,220,000 | java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java | Tomcat |
400 | 49,683 | Bug 49683 Separate keep-alive and connection timeout with APR/native connector | null | 2010-08-01 15:40:53 | 1,280,690,000 | resolved fixed | bf4a544 | 1,313,520,000 | java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/http11/Http11AprProtocol.java java/org/apache/tomcat/util/net/AprEndpoint.java | Tomcat |
401 | 51,658 | Bug 51658 Potential NPE in CoyoteAdapter.log | null | 2011-08-13 11:10:19 | 1,313,250,000 | resolved fixed | 5d55842 | 1,313,480,000 | java/org/apache/catalina/connector/CoyoteAdapter.java | Tomcat |
402 | 51,654 | Bug 51654 NullPointerException in startup (org.apache.catalina.startup.HostConfig.filterAppPaths) due to missing app base | A hard-to-diagnose NullPointerException at startup which can be bettered with an appropriate error message: INFO: Starting Servlet Engine: Apache Tomcat/7.0.19 java.lang.NullPointerException at org.apache.catalina.startup.HostConfig.filterAppPaths(HostConfig.java:493) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:466) at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1322) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:311) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:89) Ok, what's this about? In "protected String[] filterAppPaths(String[] unfilteredAppPaths)" the exception is raised at for (String appPath : unfilteredAppPaths) Which means the "unfilteredAppPaths" passed in is null. filterAppPaths does not check for that (shouldn't there be an assertion at least) The problems comes from "deployApps()": protected void deployApps() { File appBase = appBase(); File configBase = configBase(); String[] filteredAppPaths = filterAppPaths(appBase.list()); <---- // Deploy XML descriptors from configBase deployDescriptors(configBase, configBase.list()); // Deploy WARs, and loop if additional descriptors are found deployWARs(appBase, filteredAppPaths); // Deploy expanded folders deployDirectories(appBase, filteredAppPaths); } Where "appBase.list()" returns null. This must be because "appBase" does not actually denote a directory (A-HA!) Indeed, the server.xml points to a nonexisting appBase. Suggesting to add a check to "deployApps": protected void deployApps() { File appBase = appBase(); File configBase = configBase(); if (!appBase.exists() || appBase.list()==null) { throw new IllegalArgumentException("The appBase " + appBase + " does not exist or cannot be listed"); } String[] filteredAppPaths = filterAppPaths(appBase.list()); <---- // Deploy XML descriptors from configBase deployDescriptors(configBase, configBase.list()); // Deploy WARs, and loop if additional descriptors are found deployWARs(appBase, filteredAppPaths); // Deploy expanded folders deployDirectories(appBase, filteredAppPaths); } This probably violates some I18N requirement though. | 2011-08-12 10:36:54 | 1,313,160,000 | resolved fixed | c4d1631 | 1,313,430,000 | java/org/apache/catalina/startup/HostConfig.java | Tomcat |
403 | 51,650 | Bug 51650 possible nullpointer exception in RequestUtil.parseParameters | null | 2011-08-11 17:03:48 | 1,313,100,000 | resolved fixed | 7562fc1 | 1,313,140,000 | java/org/apache/catalina/util/RequestUtil.java | Tomcat |
404 | 41,673 | Bug 41673 Jasper output the message of compiling error using LF(\n) on ANY OS. | Jasper output the message of compiling error using LF(\n) on ANY OS. This cannot be correctly displayed with Windows notepad. I think the line feed code along OS would be better, though I know other text editor solves this. | 2007-02-21 17:37:02 | 1,172,100,000 | resolved fixed | 841e9fc | 1,313,000,000 | java/org/apache/jasper/compiler/DefaultErrorHandler.java java/org/apache/jasper/compiler/ErrorDispatcher.java | Tomcat |
405 | 51,644 | Bug 51644 Unable to deploy applications with the name a#b.xml | When I try to deploy a context with the name "a#b.xml" I get the following exception. SEVERE: Unable to process JNDI URL [jndi:/localhost/sample/one/WEB-INF/classes] for annotations java.io.FileNotFoundException: jndi:/localhost/sample/one/WEB-INF/classes at org.apache.naming.resources.DirContextURLConnection.list(DirContextUR LConnection.java:452) at org.apache.catalina.startup.ContextConfig.processAnnotationsJndi(Cont extConfig.java:1901) at org.apache.catalina.startup.ContextConfig.processAnnotationsUrl(Conte xtConfig.java:1828) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.jav a:1295) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfi g.java:896) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfi g.java:322) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(Lifecycl eSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBa se.java:89) at org.apache.catalina.core.StandardContext.startInternal(StandardContex t.java:5103) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:145) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase .java:812) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:78 7) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:607) at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.ja va:633) at org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.j ava:558) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:468 ) at org.apache.catalina.startup.HostConfig.check(HostConfig.java:1363) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java :294) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(Lifecycl eSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBa se.java:89) at org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBas e.java:1233) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.p rocessChildren(ContainerBase.java:1391) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.p rocessChildren(ContainerBase.java:1401) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.r un(ContainerBase.java:1380) at java.lang.Thread.run(Thread.java:619) I would have expected the application to be available in the URI a/b. The bug seems to be in the "list()" method "of DirContextURLConnection.java. The method assumes that context name does not have any "/" characters in it. See the developer note just before the "if" block. I have added the "else if" condition that seems to have solved the problem for me. try { String file = getURL().getFile(); // This will be of the form /<hostname>/<contextpath>/file name // if <contextpath> is not empty otherwise this will be of the // form /<hostname>/file name // Strip off the hostname and the contextpath int start; if(context instanceof ProxyDirContext && "".equals(((ProxyDirContext)context).getContextPath())){ start = file.indexOf('/',1); } else if(context instanceof ProxyDirContext){ start="/".length() +((ProxyDirContext)context).getHostName().length() +((ProxyDirContext)context).getContextPath().length(); /* * Seems like a bug in Tomcat. below was the code in Tomcat. * How can it handle contextpath like "/sample/one". It cannot */ //start = file.indexOf('/', file.indexOf('/', 1) + 1); } else start = file.indexOf('/', file.indexOf('/', 1) + 1); NamingEnumeration<NameClassPair> enumeration = context.list(file.substring(start)); while (enumeration.hasMoreElements()) { NameClassPair ncp = enumeration.nextElement(); result.addElement(ncp.getName()); } } catch (NamingException e) { | 2011-08-10 10:00:36 | 1,312,980,000 | resolved fixed | bb7072c | 1,313,000,000 | java/org/apache/naming/resources/DirContextURLConnection.java | Tomcat |
406 | 51,640 | Bug 51640 clearReferencesJdbc seems to be causing leaks with com.oracle.ojdbc5 driver | null | 2011-08-10 00:21:38 | 1,312,950,000 | resolved fixed | cd2fecd | 1,312,980,000 | java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java | Tomcat |
407 | 51,641 | Bug 51641 Http11NioProcessor not correct release | org.apache.coyote.http11.Http11NioProtocol.Http11ConnectionHandler code segment: ================================== @Override public void release(SocketWrapper<NioChannel> socket) { Http11NioProcessor processor = connections.remove(socket); if (processor != null) { processor.recycle(); recycledProcessors.offer(processor); } } ================================== should be: ================================== @Override public void release(SocketWrapper<NioChannel> socket) { Http11NioProcessor processor = connections.remove(socket.getSocket()); if (processor != null) { processor.recycle(); recycledProcessors.offer(processor); } } ================================== type of connections is ConcurrentHashMap<NioChannel, Http11NioProcessor> , not ConcurrentHashMap<SocketWrapper<NioChannel>, Http11NioProcessor>. | 2011-08-10 03:37:44 | 1,312,960,000 | resolved fixed | 7ffca5b | 1,312,980,000 | java/org/apache/coyote/http11/Http11NioProtocol.java | Tomcat |
408 | 51,615 | Bug 51615 Line 267 of "org.apache.tomcat.jdbc.pool.PooledConnection": double assignment typo | Nothing bad here, but my compiler lights up: connection = connection = driver.connect(driverURL, properties); Clearly, to be fixed. | 2011-08-04 19:14:11 | 1,312,500,000 | resolved fixed | 8c41e9c | 1,312,560,000 | modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java | Tomcat |
409 | 51,610 | Bug 51610 Context fails to reload after an error in web.xml was corrected | With current trunk. Steps to reproduce: 1. Start Tomcat 7 2. Go to webapps/examples/WEB-INF/web.xml and uncomment <filter-mapping> for "Timing Filter" (line 75). 3. Wait several seconds. The examples webapp is reloaded, but fails to start. This happens because there is a typo. The <filter-name> value should be s/Timing Filter/Timing filter/. There is stack trace in the logs: [[[ 04.08.2011 8:09:39 org.apache.catalina.startup.HostConfig checkResources WARNING: Error during context [/examples] restart java.lang.IllegalArgumentException: Filter mapping specifies an unknown filter name Timing Filter at org.apache.catalina.core.StandardContext.validateFilterMap(StandardContext.java:2950) at org.apache.catalina.core.StandardContext.addFilterMap(StandardContext.java:2915) at org.apache.catalina.deploy.WebXml.configureContext(WebXml.java:1206) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1343) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:896) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:322) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:89) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5103) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:145) at org.apache.catalina.startup.HostConfig.checkResources(HostConfig.java:1279) at org.apache.catalina.startup.HostConfig.check(HostConfig.java:1360) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:294) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:89) at org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1240) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1398) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1408) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1387) at java.lang.Thread.run(Thread.java:662) ]]] 4. Go to web.xml and edit it once again. E.g. re-comment the mapping, or correct the typo. 5. Wait several seconds. Here is an issue: EXPECTED: The examples webapp should reload successfully. ACTUAL: Reload fails. The following is printed in the logs: 04.08.2011 8:09:59 org.apache.catalina.startup.HostConfig checkResources INFO: Reloading context [/examples] 04.08.2011 8:09:59 org.apache.catalina.util.LifecycleBase start INFO: The start() method was called on component [StandardEngine[Catalina].StandardHost[localhost].StandardContext[/examples]] after start() had already been called. The second call will be ignored. 6. Stop Tomcat. Here is the second issue: EXPECTED: Successful shutdown ACTUAL: [[[ 04.08.2011 8:14:10 org.apache.catalina.startup.Catalina stop SEVERE: Catalina.stop org.apache.catalina.LifecycleException: An invalid Lifecycle transition was attempted ([before_stop]) for component [StandardEngine[Catalina].StandardHost[localhost].StandardContext[/examples]] in state [STARTING_PREP] at org.apache.catalina.util.LifecycleBase.invalidTransition(LifecycleBase.java:387) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:212) at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:1072) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:225) at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:1072) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:225) at org.apache.catalina.core.StandardService.stopInternal(StandardService.java:502) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:225) at org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:748) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:225) at org.apache.catalina.startup.Catalina.stop(Catalina.java:694) at org.apache.catalina.startup.Catalina$CatalinaShutdownHook.run(Catalina.java:847) ]]] This exception at shutdown happens only if examples webapp was correct when Tomcat started, but was broken afterwards. If it was already broken at startup time, nothing happens. 7. Here is the third issue: when the above happens the shutdown sequence is apparently aborted abnormally. EXPECTED: "INFO: Stopping ProtocolHandler ["http-bio-8080"]" etc. messages ACTUAL: There are no messages after the "SEVERE: Catalina.stop" one that I cited above. | 2011-08-04 04:28:49 | 1,312,450,000 | resolved fixed | ed0588b | 1,312,560,000 | java/org/apache/catalina/util/LifecycleBase.java | Tomcat |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.