Datasets:
Partha117
/
apache_bug_reports

Dataset card Data Studio Files Community
1
id
int64
1
6.5k
bug_id
int64
2.03k
426k
summary
stringlengths
9
251
description
stringlengths
1
32.8k
⌀
report_time
stringlengths
19
19
report_timestamp
int64
1B
1.39B
status
stringclasses
6 values
commit
stringlengths
7
9
commit_timestamp
int64
1B
1.39B
files
stringlengths
25
32.8k
project_name
stringclasses
6 values
510
46,819
Bug 46819 Remove redundant object instantiations in JspRuntimeLibrary
null
2009-03-07 23:30:10
1,236,490,000
resolved fixed
20ace41
1,296,260,000
java/org/apache/jasper/runtime/JspRuntimeLibrary.java
Tomcat
511
50,680
Bug 50680 NPE in TagFileProcessor when tag file is in an expanded directory "jar"
null
2011-01-28 09:03:07
1,296,220,000
resolved fixed
af4549f
1,296,250,000
java/org/apache/jasper/compiler/TagFileProcessor.java
Tomcat
512
50,679
Bug 50679 FarmDeployer doesn't support parallel deployment
Version: Tomcat 7.0.6 Component: Catalina OS: Windows 7 64bit Overview: Parallel deployment works like a charm in a non-clustered environment. But when deploying a versioned app (APPNAME##VERSION.war) to a farm deployer directory, it seems that the filename encoding of the ## delimiter is not translated correctly to identify the war file on the file system: ## is translated to %23%23 Reproduce: 1. Create a version app file 2. Deploy file to watched farm deployer directory Expected result: - Versioned app is copyied to cluster members and deployed Actual result: - Versioned app is NOT copyied to cluster members. catalina.log displays the following error messages: [ContainerBackgroundProcessor[StandardEngine[Catalina]]] INFO org.apache.catalina.ha.deploy.FarmWarDeployer- Installing webapp[/Shop##201101261] from C:\Apache\Tomcat7\cluster\webapps\Shop##201101261.war [ContainerBackgroundProcessor[StandardEngine[Catalina]]] INFO org.apache.catalina.ha.deploy.FarmWarDeployer- Cluster wide remove of web app /Shop##201101261 [ContainerBackgroundProcessor[StandardEngine[Catalina]]] ERROR org.apache.catalina.ha.deploy.FarmWarDeployer- Unable to install WAR file java.io.FileNotFoundException: C:\Apache\Tomcat7\cluster\webapps\Shop%23%23201101261.war (Das System kann die angegebene Datei nicht finden) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.<init>(FileInputStream.java:106) at org.apache.catalina.ha.deploy.FileMessageFactory.<init>(FileMessageFactory.java:152) at org.apache.catalina.ha.deploy.FileMessageFactory.getInstance(FileMessageFactory.java:175) at org.apache.catalina.ha.deploy.FarmWarDeployer.install(FarmWarDeployer.java:372) at org.apache.catalina.ha.deploy.FarmWarDeployer.fileModified(FarmWarDeployer.java:468) at org.apache.catalina.ha.deploy.WarWatcher.check(WarWatcher.java:95) at org.apache.catalina.ha.deploy.FarmWarDeployer.backgroundProcess(FarmWarDeployer.java:591) at org.apache.catalina.ha.tcp.SimpleTcpCluster.backgroundProcess(SimpleTcpCluster.java:627) at org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1200) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1393) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1403) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1382) at java.lang.Thread.run(Thread.java:662) [ContainerBackgroundProcessor[StandardEngine[Catalina]]] INFO org.apache.catalina.startup.HostConfig- Deploying web application archive Shop##201101261.war Relevant configuration in server.xml: ... <Host name="sbwebapp1" appBase="${catalina.base}/cluster/webapps" unpackWARs="true" autoDeploy="true"> <Cluster className="org.apache.catalina.ha.tcp.SimpleTcpCluster" channelSendOptions="8"> <Manager className="org.apache.catalina.ha.session.DeltaManager" expireSessionsOnShutdown="true" notifyListenersOnReplication="false" stateTransferTimeout="5"/> <Channel className="org.apache.catalina.tribes.group.GroupChannel"> <Membership className="org.apache.catalina.tribes.membership.McastService" address="228.0.0.4" port="45564" frequency="500" dropTime="3000"/> <Receiver className="org.apache.catalina.tribes.transport.nio.NioReceiver" address="192.168.222.220" port="4000" autoBind="100" selectorTimeout="5000" maxThreads="6"/> <Sender className="org.apache.catalina.tribes.transport.ReplicationTransmitter"> <Transport className="org.apache.catalina.tribes.transport.nio.PooledParallelSender"/> </Sender> <Interceptor className="org.apache.catalina.tribes.group.interceptors.TcpFailureDetector"/> <Interceptor className="org.apache.catalina.tribes.group.interceptors.MessageDispatch15Interceptor"/> <Interceptor className="org.apache.catalina.tribes.group.interceptors.ThroughputInterceptor"/> </Channel> <Valve className="org.apache.catalina.ha.tcp.ReplicationValve" filter=".*\.gif;.*\.js;.*\.jpg;.*\.png;.*\.htm;.*\.html;.*\.css;.*\.txt;.*\.swf;.*\.flv;"/> <Valve className="org.apache.catalina.ha.session.JvmRouteBinderValve"/> <ClusterListener className="org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener"/> <ClusterListener className="org.apache.catalina.ha.session.ClusterSessionListener"/> <Deployer className="org.apache.catalina.ha.deploy.FarmWarDeployer" tempDir="${catalina.base}/cluster/temp/" deployDir="${catalina.base}/cluster/webapps/" watchDir="${catalina.base}/cluster/deploy/" watchEnabled="true"/> </Cluster> <!-- Access log processes all example. Documentation at: /docs/config/valve.html Note: The pattern used is equivalent to using pattern="common" --> <Valve className="org.apache.catalina.valves.AccessLogValve" directory="logs" prefix="ajp_access_" suffix=".log" pattern="%h %l %u %t &quot;%r&quot; %s %b" resolveHosts="false"/> </Host> ...
2011-01-28 03:22:33
1,296,200,000
resolved fixed
2377f51
1,296,250,000
java/org/apache/catalina/ha/ClusterDeployer.java java/org/apache/catalina/ha/deploy/FarmWarDeployer.java java/org/apache/catalina/ha/deploy/FileMessage.java java/org/apache/catalina/ha/deploy/FileMessageFactory.java java/org/apache/catalina/ha/deploy/UndeployMessage.java
Tomcat
513
50,642
Bug 50642 keepAliveProtection doesn't work
null
2011-01-24 10:45:14
1,295,880,000
resolved fixed
5c13d8c
1,296,220,000
java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/loader/WebappClassLoader.java java/org/apache/catalina/loader/WebappLoader.java
Tomcat
514
50,646
Bug 50646 Tribes ByteMessage will get corrupted if message size exceeds the underlying buffer size
The Tribes ByteMessage class is used to transfer byte payloads in the context of the tribes communication framework. Due to how the message is deserialized, there will be data loss (and hence corruption) if the message size exceeds the underlying buffer size. The solution is to replace an ObjectInput#read(byte[]) call by ObjectInput#readFully(byte[]). Fix is attached.
2011-01-25 07:08:10
1,295,960,000
resolved fixed
0119483
1,296,070,000
java/org/apache/catalina/tribes/ByteMessage.java
Tomcat
515
50,629
Bug 50629 Make the bindThread/unbindThread method protected
In the latest Tomcat codes, I saw that a new thread is created for listener start, filter start and loadOnStartup. But the two methods bindThread and unbindThread is marked as private, how about making those methods protected ? So that other containers could use those two methods for their own initialization works. Thanks.
2011-01-21 07:23:54
1,295,610,000
resolved fixed
3898ed0
1,295,620,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
516
50,620
Bug 50620 Session related errors prevent clean recycle of Request and Response objects by CoyoteAdapter
null
2011-01-19 15:54:38
1,295,470,000
resolved fixed
fbd0110
1,295,550,000
java/org/apache/catalina/connector/Request.java
Tomcat
517
50,606
Bug 50606 Error running CGI executable in Tomcat 6.0.30
null
2011-01-18 02:26:41
1,295,340,000
resolved fixed
c0cd721
1,295,550,000
java/org/apache/catalina/servlets/CGIServlet.java
Tomcat
518
50,613
Bug 50613 ConnectionPool.size corruption when evictions enabled:
When (the various forms of) eviction run on the connection pool, ConnectionPool.size goes negative. This appears to be a concurrency problem. Attached is a unit test that illustrates the issue.
2011-01-18 17:33:53
1,295,390,000
resolved fixed
5cb0b7a
1,295,470,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestSizePreservation.java
Tomcat
519
50,601
Bug 50601 Redundant null checks before instanceof in equals()
null
2011-01-17 08:54:21
1,295,270,000
resolved fixed
d95db3f
1,295,460,000
java/org/apache/catalina/core/ApplicationTaglibDescriptor.java java/org/apache/catalina/deploy/LoginConfig.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java java/org/apache/el/parser/SimpleNode.java java/org/apache/naming/NamingEntry.java java/org/apache/tomcat/util/net/URL.java
Tomcat
520
50,598
Bug 50598 Sample build.xml uses wrong manager.url
null
2011-01-16 14:08:25
1,295,200,000
resolved fixed
de188ad
1,295,280,000
java/org/apache/catalina/ant/AbstractCatalinaTask.java
Tomcat
521
50,597
Bug 50597 Class.newInstance is used for Dynamic instance filters causing InstantiationException
Class.newInstance is called even when the following method ServletContext.addFilter method is called: javax.servlet.FilterRegistration.Dynamic addFilter(java.lang.String s, javax.servlet.Filter filter); This leads to an InstantiationException at runtime if there is no no-args constructor for the filter (pasted below). I'll supply a simple patch that fixes the issue for me. SEVERE: Exception starting filter testFilter java.lang.InstantiationException: test.TestFilter at java.lang.Class.newInstance0(Class.java:340) at java.lang.Class.newInstance(Class.java:308) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultIn stanceManager.java:119) at org.apache.catalina.core.ApplicationFilterConfig.getFilter(Applicatio nFilterConfig.java:252) at org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(Applica tionFilterConfig.java:372) at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFi lterConfig.java:98) at org.apache.catalina.core.StandardContext.filterStart(StandardContext. java:4382) at org.apache.catalina.core.StandardContext$2.call(StandardContext.java: 5040) at org.apache.catalina.core.StandardContext$2.call(StandardContext.java:5035) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662)
2011-01-16 12:25:24
1,295,200,000
resolved fixed
30468b7
1,295,280,000
java/org/apache/catalina/core/ApplicationFilterConfig.java
Tomcat
522
50,600
Bug 50600 ConcurrentModificationException removing WAR via FarmWarDeployer
The following exception was reported via $work WARNING: Exception processing cluster org.apache.catalina.ha.tcp.SimpleTcpCluster@68e4e358 background process java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:810) at java.util.HashMap$EntryIterator.next(HashMap.java:851) at java.util.HashMap$EntryIterator.next(HashMap.java:849) at org.apache.catalina.ha.deploy.WarWatcher.check(WarWatcher.java:87) at org.apache.catalina.ha.deploy.FarmWarDeployer.backgroundProcess(FarmWarDeployer.java:609) at org.apache.catalina.ha.tcp.SimpleTcpCluster.backgroundProcess(SimpleTcpCluster.java:596) at org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1302) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1601) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1610) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1590) at java.lang.Thread.run(Thread.java:636) The root cause is removing the entry directly from the Map rather than from the iterator. I have a patch that I'll apply shortly.
2011-01-17 06:20:11
1,295,260,000
resolved fixed
d269ce3
1,295,260,000
java/org/apache/catalina/ha/deploy/WarWatcher.java
Tomcat
523
50,582
Bug 50582 Small JSPs do not set Content-Length (and use chunked encoding) if AccessLogValve is configured
null
2011-01-14 02:16:41
1,294,990,000
resolved fixed
35a84d1
1,295,180,000
java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/JDBCAccessLogValve.java java/org/apache/coyote/http11/AbstractOutputBuffer.java
Tomcat
524
50,591
Bug 50591 NPE in ReplicationValve in 7.0.6
null
2011-01-15 12:33:11
1,295,110,000
resolved fixed
d8f8be1
1,295,110,000
java/org/apache/catalina/ha/tcp/ReplicationValve.java
Tomcat
525
18,797
Bug 18797 MemoryUserRule doesn't validate user attributes
The implementation of org.apache.catalina.realm.MemoryRuleSet.begin dosen't validate the attribute values before adding a user to the MemoryRealm. If username or name are not present then a null username is used which can cause odd problems later on. Basically the method should check that parameters passed to MemoryRealm.addUser are not null before calling the method.
2003-04-08 06:33:14
1,049,800,000
resolved fixed
51650a1
1,294,940,000
java/org/apache/catalina/users/MemoryUserDatabase.java
Tomcat
526
18,462
Bug 18462 System.err gets overriden to output to System.out
I am using Eclipse to do my development and I am running tomcat 4.1.24 from within eclipse. One of the nice features of eclipse is that anything you display with System.out comes out in blue and anything you send to System.err is displayed in red. However when tomcat is running Catalina overrides System.err and makes it point to System.out. This is very inconvinient because its much harder to search for severe error messages in a list of millions of trivial ones.
2003-03-28 12:35:32
1,048,870,000
resolved fixed
164fd40
1,294,880,000
java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/Embedded.java
Tomcat
527
15,688
Bug 15688 full-qualified names instead of imports
Hi, Jasper generated *.java-files that are compiled. The template for those files is very "unaesthetic". I could demonstrate nice side-effects using a simple <%@ page import="mypackage.Jspfactory" %> You should use full qualified names instead of a bunch of import-staments. For example _jspxFactory = JspFactory.getDefaultFactory(); would become _jspxFactory = javax.servlet.jsp.JspFactory.getDefaultFactory(); and if you don't already do, you should use the this-reference where possible. I don't know what the spec says about that conflict, but it shouldn't be a bad idea to use full-qualified names instead of imports.
2002-12-27 22:30:47
1,041,050,000
resolved fixed
e69347b
1,294,830,000
java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/compiler/JspUtil.java
Tomcat
528
50,333
Bug 50333 IllegalArgumentException occurs when setting maxActive to smaller than 1.
null
2010-11-25 00:22:29
1,290,660,000
resolved fixed
0ccff07
1,294,680,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Tomcat
529
49,953
Bug 49953 Missing @Override annotations
null
2010-09-17 14:00:04
1,284,750,000
resolved wontfix
fd990a4
1,294,680,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
Tomcat
530
21,157
Bug 21157 CookieExample is setting cookie after writing data
A servlet can not set the headers and cookies after writing data to the servlet's output stream. Once the servlet writes data, headers are committed. However CookieExample writes some data first before doing addCookie on the response. The reason why this code works at all even with the above bug is: The CookieExample is only writing a small amount of data before doing response.addCookie. That data is still held in buffer and not yet sent over the wire. Hence the headers are not yet committed. So it is pure luck that this example works. You can easily expose the bug by writing say 20K characters in this example before response.addCookie is called. You will see that the cookies that are adding to response are not actually sent back to client. Fix is simple. Move up the response.addCookie() before response.getWriter()
2003-06-27 23:12:00
1,056,770,000
resolved fixed
4ce656a
1,294,530,000
webapps/examples/WEB-INF/classes/CookieExample.java
Tomcat
531
50,552
Bug 50552 Ant Tasks give a null pointer exception when an error occurs, masking true error
null
2011-01-06 12:39:49
1,294,340,000
resolved fixed
a6b37af
1,294,400,000
java/org/apache/catalina/ant/BaseRedirectorHelperTask.java
Tomcat
532
50,554
Bug 50554 Bad use of getClass() could potentially lead to concurrency bugs in future
null
2011-01-06 14:38:25
1,294,340,000
resolved fixed
06b8609
1,294,400,000
java/org/apache/naming/java/javaURLContextFactory.java
Tomcat
533
50,477
Bug 50477 If you set 0 to initialSize, can't obtain Connection by using getConnectionAsync method.
null
2010-12-15 04:40:32
1,292,410,000
resolved fixed
869c6f4
1,294,360,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
Tomcat
534
49,543
Bug 49543 Request for a "shared" datasource configuration as in DBCP
The ability to configure the datasource at the server level and have it shared amongst all applications on that server with each application supplying their own credentials for the datasource. This type of configuration is supported by DBCP and is called a "shared" datasource configuration.
2010-07-02 15:07:50
1,278,100,000
resolved fixed
3560f39
1,294,340,000
java/org/apache/naming/factory/DataSourceLinkFactory.java
Tomcat
535
50,550
Bug 50550 PropFind 404 error after MkCol succes
null
2011-01-06 09:11:12
1,294,320,000
resolved fixed
5c2742c
1,294,340,000
java/org/apache/naming/resources/ProxyDirContext.java
Tomcat
536
47,319
Bug 47319 With APR, getRemoteHost() returns NULL for unknown clients
null
2009-06-05 05:11:52
1,244,190,000
resolved fixed
ce64f9b
1,294,330,000
java/org/apache/coyote/http11/Http11AprProcessor.java
Tomcat
537
50,547
Bug 50547 The CHANGE_SESSION_ID message that received during cluster session synchronization is dropped.
Neither CHANGE_SESSION_ID message nor SESSION_EXPIRED message set timestamp. If these messages are received during cluster sessions synchronization in DeltaManager startup, because the timestamp is not set, they are dropped. I made a patch that add timestamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. Best Regards.
2011-01-06 03:48:03
1,294,300,000
resolved fixed
a0ef3e6
1,294,310,000
java/org/apache/catalina/ha/session/DeltaManager.java
Tomcat
538
50,453
Bug 50453 Multiple X-Forwarded-For headers not handled by RemoteIP valve
null
2010-12-10 09:29:39
1,291,990,000
resolved fixed
3541fc6
1,294,240,000
java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java test/org/apache/catalina/filters/TestRemoteIpFilter.java test/org/apache/catalina/valves/TestRemoteIpValve.java
Tomcat
539
50,467
Bug 50467 Occasional NIO connector lockups on high load
We've been running Tomcat 6.0.29 on FC8 2.6.21 with tens of thousands of long polling threads which usually work fine. Every few days though we will experience a sudden lockup of the NIO connector and it has to be restarted. These have been seen to be accompanied by the following stack trace: Exception in thread "http-8082-ClientPoller-0" java.lang.NullPointerException at org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1620) at java.lang.Thread.run(Thread.java:662) Looking at the source it seems the issue is likely to be a race condition where access() is called on a null attachment, probably while it's in the process of being cancelled: while (iterator != null && iterator.hasNext()) { SelectionKey sk = (SelectionKey) iterator.next(); KeyAttachment attachment = (KeyAttachment)sk.attachment(); /*NPE*/ attachment.access(); iterator.remove(); processKey(sk, attachment); }//while
2010-12-13 14:02:35
1,292,270,000
resolved fixed
688e61e
1,294,240,000
java/org/apache/tomcat/util/net/NioEndpoint.java
Tomcat
540
50,541
Bug 50541 JNDIRealm: support configuring LDAP sizeLimit (countLimit in SearchControls)
null
2011-01-04 11:35:07
1,294,160,000
resolved fixed
76b6415
1,294,160,000
java/org/apache/catalina/realm/JNDIRealm.java
Tomcat
541
50,500
Bug 50500 EL evaluation of floating-point String value vs BigInteger loses precision
According to the EL spec ch.1.7.1, the A+B,A-B,A*B expressions when A is a "String containing ., e, or E" and B is a BigInteger have to be evaluated as follows: "coerce both A and B to BigDecimal and apply operator" The actual implementation though, instead of coercing A as String -> BigDecimal, does two coercions: String -> Double -> BigDecimal, which produces a different result. To reproduce, run the following JSP page: <% pageContext.setAttribute("a", "1.1"); pageContext.setAttribute("b", new java.math.BigInteger("1000000000000000000000")); // "c" is used to explicitly coerce arguments to BigDecimal pageContext.setAttribute("c", new java.math.BigDecimal("0")); %>${a + b}<br> ${(a+c) + (b+c)}<br> ${a - b}<br> ${(a+c) - (b+c)}<br> ${a * b}<br> ${(a+c) * (b+c)} Actual result: 1000000000000000000001.100000000000000088817841970012523233890533447265625 1000000000000000000001.1 -999999999999999999998.899999999999999911182158029987476766109466552734375 -999999999999999999998.9 1100000000000000088817.841970012523233890533447265625000000000000000000000 1100000000000000000000.0 Expected result: 1000000000000000000001.1 1000000000000000000001.1 -999999999999999999998.9 -999999999999999999998.9 1100000000000000000000.0 1100000000000000000000.0 I think it is a minor issue, though. This is reproducible in the current tc6.0.x as well. Maybe o.a.el.lang.ELArithmetic#add(Object, Object) should delegate to BIGDECIMAL instead of DOUBLE with these types of arguments.
2010-12-19 19:00:53
1,292,800,000
resolved fixed
b19fb3b
1,294,150,000
java/org/apache/el/lang/ELArithmetic.java test/org/apache/el/lang/TestELArithmetic.java
Tomcat
542
50,025
Bug 50025 getConnection method in class DataSourceProxy is ignoring credentials
null
2010-09-29 09:48:26
1,285,770,000
resolved fixed
59b17c1
1,294,090,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/driver/Connection.java modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/driver/Driver.java
Tomcat
543
50,503
Bug 50503 Engine level Clustering does not work correctly if the web application has a version.
In Engine level clustering, the name of the cluster manager is "HostName#contextName". SimpleTcpCluster#getManagerName(String, Manager) is as follows. ==== public String getManagerName(String name, Manager manager) { String clusterName = name ; if ( clusterName == null ) clusterName = manager.getContainer().getName(); if(getContainer() instanceof Engine) { Container context = manager.getContainer() ; if(context != null && context instanceof Context) { Container host = ((Context)context).getParent(); if(host != null && host instanceof Host && clusterName!=null && !(clusterName.indexOf("#")>=0)) clusterName = host.getName() +"#" + clusterName ; } } return clusterName; } ==== In this method, clusterName.indexOf("#") >= 0 is checked. Because the context name becomes contextName##version if the web application has a version, the name of the cluster manager doesn't become a format of "HostName#contextName". As a result, Engine level Clustering doesn't work correctly. Best regards.
2010-12-21 01:42:21
1,292,910,000
resolved fixed
701d5dc
1,292,910,000
java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
Tomcat
544
13,731
Bug 13731 Final request, response, session and other variables.
Provide a capability to declare request, response, session and other variables in jspService function as final. As tunable feature, just like others, in tomcat`s web.xml file. Why need this feature? To use request, response, session variables in anonymous implementations of classes. For example - declaration of iterator through elements, which includes some other JSP file (statically). And usage of this iterator in other JSP file.
2002-10-17 13:23:42
1,034,880,000
resolved fixed
73531cb
1,292,540,000
java/org/apache/jasper/compiler/Generator.java
Tomcat
545
10,972
Bug 10972 <Realm> without className in server.xml produces NullPointerException
If the className attribute is not included with the <Realm> tag in server.xml, the server dies with a cryptic NullPointerException. It would be nice if it produced a more meaningful error message (like "Missing className attribute for <Realm> tag").
2002-07-19 02:30:07
1,027,060,000
resolved fixed
71ad1bd
1,292,440,000
java/org/apache/catalina/startup/Catalina.java java/org/apache/tomcat/util/digester/Digester.java java/org/apache/tomcat/util/digester/ObjectCreateRule.java
Tomcat
546
10,526
Bug 10526 Authenticators do not always cache the Principal
Once a user is authenticated a Principal object is supposed to be cached for the duration of the user's session. This is especially important when using JDBCRealm or JNDIRealm to reduce the load on external authentication services. Most authenticators (BasicAuthenticator, SSLAuthenticator and DigestAuthenticator) call AuthenticatorBase.register()to cache the Principal. However register() does nothing if a session object does not already exist, so caching does not occur when the application does not create a session object itself. The problem can be seen by setting a security constraint on tomcat-docs and then browsing the Tomcat documentation - the external authentication service is hit on every request. The problem does not occur with form based login, because FormAuthenticator caches the Principal itself and creates a new session if necessary to do it. Probably the best fix would be to change AuthenticatorBase.register() to create a new session by calling getSession(request, true) instead of getSession (request, false). However, perhaps there is a reason why this is not being done - though if so I cannot see what it is. An alternative is to change the concrete authentication classes to make sure a session exists before calling register(), e.g. --- BasicAuthenticator.java 23 Mar 2002 17:52:16 -0000 1.12 +++ BasicAuthenticator.java 6 Jul 2002 12:46:30 -0000 @@ -160,6 +160,7 @@ String password = parsePassword(authorization); principal = context.getRealm().authenticate(username, password); if (principal != null) { + Session session = getSession(request, true); register(request, response, principal, Constants.BASIC_METHOD, username, password); return (true); Similar patches would be required for SSLAuthenticator and DigestAuthenticator of course.
2002-07-06 13:11:40
1,025,980,000
resolved fixed
ca34a30
1,292,430,000
java/org/apache/catalina/authenticator/AuthenticatorBase.java
Tomcat
547
49,125
Bug 49125 toString on byte[] array probably is not correct
Two examples of using toString() on a byte[] array, which is unlikely to produce the desired output: ha.deploy.FileMessageFactory.writeMessage() log message uses toString on msg.getData() which is a byte[] array coyote.ajp.AjpMessage.dump use toString on "msg" which is of type byte[]
2010-04-14 18:54:35
1,271,290,000
resolved fixed
5614817
1,292,360,000
java/org/apache/catalina/ha/deploy/FileMessageFactory.java java/org/apache/coyote/ajp/AjpMessage.java java/org/apache/tomcat/util/buf/HexUtils.java
Tomcat
548
50,460
Bug 50460 First access to a jspx page causes classloader leak in JspDocumentParser
null
2010-12-11 21:33:47
1,292,120,000
resolved fixed
345e6b5
1,292,200,000
java/org/apache/jasper/compiler/JspDocumentParser.java java/org/apache/naming/resources/ImmutableNameNotFoundException.java
Tomcat
549
50,448
Bug 50448 StandardSession.expire causes IllegalStateException: getCreationTime: Session already invalidated
Hi, when verifying the fix for #50360 I ran into an issue with expired sessions during processExpires: Dec 10, 2010 12:59:32 AM org.apache.catalina.core.ContainerBase backgroundProcess WARNING: Exception processing manager de.javakaffee.web.msm.MemcachedBackupSessionManager[/] background process java.lang.IllegalStateException: getCreationTime: Session already invalidated at org.apache.catalina.session.StandardSession.getCreationTime(StandardSession.java:1096) at org.apache.catalina.session.ManagerBase.remove(ManagerBase.java:802) at org.apache.catalina.session.StandardSession.expire(StandardSession.java:840) at org.apache.catalina.session.StandardSession.isValid(StandardSession.java:655) at org.apache.catalina.session.ManagerBase.processExpires(ManagerBase.java:609) at org.apache.catalina.session.ManagerBase.backgroundProcess(ManagerBase.java:594) at de.javakaffee.web.msm.MemcachedBackupSessionManager.backgroundProcess(MemcachedBackupSessionManager.java:1130) at org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1214) AFAICS in MemcachedBackupSessionManager I could override remove(Session session, boolean update) with calling super.remove(session, false) for invalid sessions. Another option would be to change StandardSession.expire(StandardSession.java:840) so that it does not invoke manager.remove(this, true) but manager.remove(this, false). Or even better: change ManagerBase.remove(ManagerBase.java:802) to invoke some session.getCreationTimeInternal() which skips validation. What do you think? Cheers, Martin
2010-12-09 19:23:29
1,291,940,000
resolved fixed
4117b78
1,291,990,000
java/org/apache/catalina/Session.java java/org/apache/catalina/manager/DummyProxySession.java java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/session/StandardSession.java
Tomcat
550
50,408
Bug 50408 Scoped EL variable in methodexpression is treated as Object
Consider following example: <dl> <c:forEach items="${pageContext.response.headerNames}" var="name"> <c:forEach items="${pageContext.response.getHeaders(name)}" var="value"> <dt>${name}</dt><dd>${value}</dd> </c:forEach> </c:forEach> </dl> The ${name} is a String. The ${name.class.name} also proves that. The getHeaders(name) call however results in: org.apache.jasper.el.JspELException: /test.jsp(23,12) '${pageContext.response.getHeaders(name)}' java.lang.NoSuchMethodException: org.apache.catalina.connector.ResponseFacade.getHeaders(java.lang.Object) Another example which also results in NoSuchMethodException which suggests that an Object is been passed as argument: <c:set var="name" value="test" /> ${pageContext.response.getHeader(name)} This works all fine on Glassfish v3.
2010-12-03 12:37:00
1,291,400,000
resolved fixed
4ed7b7e
1,291,410,000
java/javax/el/CompositeELResolver.java test/javax/el/TestCompositeELResolver.java
Tomcat
551
48,692
Bug 48692 Provide option to parse application/x-www-form-urlencoded PUT requests
Provide an option to treat application/x-www-form-urlencoded encoded parameters in a PUT request in a similar manner to application/x-www-form-urlencoded parameters in a POST request
2010-02-07 02:41:33
1,265,530,000
resolved fixed
e34b164
1,291,390,000
java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/connector/Request.java test/org/apache/catalina/connector/TestRequest.java
Tomcat
552
50,358
Bug 50358 Embedded.stopInternal sets state to STARTING, should be STOPPING
null
2010-11-28 18:13:10
1,290,990,000
resolved fixed
07b72f1
1,291,040,000
java/org/apache/catalina/startup/Embedded.java
Tomcat
553
49,142
Bug 49142 Missing serialVersionUIDs
org.apache.catalina.ha.ClusterMessageBase is Serializable; consider declaring a serialVersionUID Similarly for: org.apache.catalina.ha.session.ReplicatedSession org.apache.catalina.ha.session.SerializablePrincipal org.apache.catalina.session.StandardSession org.apache.catalina.tribes.tipis.AbstractReplicatedMap.MapMessage org.apache.tomcat.util.modeler.ManagedBean
2010-04-16 21:25:34
1,271,470,000
resolved fixed
4cbb52f
1,290,640,000
java/javax/servlet/GenericServlet.java java/javax/servlet/ServletContextAttributeEvent.java java/javax/servlet/ServletContextEvent.java java/javax/servlet/ServletException.java java/javax/servlet/ServletRequestAttributeEvent.java java/javax/servlet/ServletRequestEvent.java java/javax/servlet/UnavailableException.java java/javax/servlet/http/HttpServlet.java java/javax/servlet/http/HttpSessionBindingEvent.java java/javax/servlet/http/HttpSessionEvent.java java/javax/servlet/jsp/JspException.java java/javax/servlet/jsp/JspTagException.java java/javax/servlet/jsp/SkipPageException.java java/javax/servlet/jsp/el/ELException.java java/javax/servlet/jsp/el/ELParseException.java java/javax/servlet/jsp/tagext/TagSupport.java java/org/apache/catalina/ha/deploy/FileMessage.java java/org/apache/catalina/ha/deploy/UndeployMessage.java java/org/apache/catalina/manager/StatusManagerServlet.java java/org/apache/catalina/session/StandardSession.java java/org/apache/catalina/ssi/SSIServlet.java java/org/apache/catalina/ssi/SSIStopProcessingException.java java/org/apache/catalina/tribes/ChannelException.java java/org/apache/catalina/tribes/RemoteProcessException.java java/org/apache/catalina/tribes/UniqueId.java java/org/apache/catalina/tribes/io/ChannelData.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java java/org/apache/catalina/tribes/tipis/ReplicatedMap.java java/org/apache/catalina/tribes/util/ExecutorFactory.java java/org/apache/catalina/util/ParameterMap.java java/org/apache/catalina/util/ResourceSet.java java/org/apache/jasper/JasperException.java java/org/apache/jasper/compiler/JspDocumentParser.java java/org/apache/jasper/runtime/HttpJspBase.java java/org/apache/juli/logging/LogConfigurationException.java java/org/apache/naming/EjbRef.java java/org/apache/naming/HandlerRef.java java/org/apache/naming/JndiPermission.java java/org/apache/naming/ResourceEnvRef.java java/org/apache/naming/ResourceLinkRef.java java/org/apache/naming/ServiceRef.java java/org/apache/naming/TransactionRef.java java/org/apache/tomcat/util/buf/CharChunk.java java/org/apache/tomcat/util/buf/MessageBytes.java java/org/apache/tomcat/util/modeler/BaseAttributeFilter.java java/org/apache/tomcat/util/modeler/FixedNotificationFilter.java java/org/apache/tomcat/util/modeler/ManagedBean.java java/org/apache/tomcat/util/net/URL.java test/org/apache/catalina/tribes/demos/MapDemo.java webapps/examples/WEB-INF/jsp/applet/Clock2.java
Tomcat
554
48,837
Bug 48837 Memory leaks protection does not detect leaks triggered by JSP pages code
null
2010-03-01 18:51:11
1,267,490,000
resolved fixed
ddbbfc1
1,290,630,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
555
50,108
Bug 50108 Add missing setter/getter to AbstractXXXProtocol
null
2010-10-18 03:22:19
1,287,390,000
resolved fixed
5a84fdb
1,290,630,000
java/org/apache/coyote/ajp/AbstractAjpProtocol.java java/org/apache/coyote/http11/AbstractHttp11Protocol.java
Tomcat
556
50,207
Bug 50207 CometProcessor async timeout events are not being fired
This is reproducible using the the default chat example (ie: ChatServlet, /examples/jsp/chat) and the following additional changes: 1) Enabled Http11Nio in conf/server.xml: <Connector address="0.0.0.0" port="8080" protocol="org.apache.coyote.http11.Http11NioProtocol" connectionTimeout="20000" enableLookups="false" acceptCount="100" disableUploadTimeout="true" maxThreads="15" minSpareThreads="15" maxSpareThreads="15" RECYCLE_FACADES="true"/> 2) Enabled the comet valve in conf/context.xml: <Valve className="org.apache.catalina.valves.CometConnectionManagerValve" /> The problem is CometEvent.EventType.ERROR (and subtype TIMEOUT) and CometEvent.EventType.END are never being fired. This can be confirmed in the logs; the messages for these events are never printed. This worked on Tomcat 6.0.29. As an aside, what is the most complete/robust way to do async IO in tomcat 7 today, Servlet 3.0 or CometProcessor?
2010-11-03 14:52:32
1,288,810,000
resolved fixed
46e7d1e
1,290,530,000
java/org/apache/coyote/http11/Http11NioProtocol.java java/org/apache/tomcat/util/net/NioEndpoint.java
Tomcat
557
50,316
Bug 50316 Minor glitch with display of negative TTL on sessionDetail.jsp
null
2010-11-22 11:29:24
1,290,440,000
resolved fixed
278a36a
1,290,460,000
java/org/apache/catalina/manager/JspHelper.java java/org/apache/catalina/manager/StatusTransformer.java
Tomcat
558
50,308
Bug 50308 Call to AsyncContext.dispatch() in the onTimeout callback throws exception
When dispatch() method is called inside the onTimeout() function of the AsyncListener, the exception is thrown: SEVERE: An exception or error occurred in the container during the request processing java.lang.IllegalStateException: Calling [dispatchAsync()] is not valid for a request with Async state [TIMING_OUT] at org.apache.coyote.AsyncStateMachine.asyncDispatch(AsyncStateMachine.java:220) at org.apache.coyote.http11.Http11NioProcessor.actionInternal(Http11NioProcessor.java:672) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:937) at org.apache.coyote.Request.action(Request.java:348) at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:173) at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:135) at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:130) at com.juriy.snowball.SnowServlet$1.onTimeout(SnowServlet.java:23) at org.apache.catalina.core.AsyncListenerWrapper.fireOnTimeout(AsyncListenerWrapper.java:45) at org.apache.catalina.core.AsyncContextImpl.timeout(AsyncContextImpl.java:109) at org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:270) at org.apache.coyote.http11.Http11NioProcessor.asyncDispatch(Http11NioProcessor.java:232) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.event(Http11NioProtocol.java:305) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1526) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) The sample code is below: protected void service(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { AsyncContext context = request.startAsync(); context.setTimeout(3000); context.addListener(new AsyncListener() { public void onComplete(AsyncEvent asyncEvent) throws IOException {} public void onTimeout(AsyncEvent asyncEvent) throws IOException { System.out.println("HITTING TIMEOUT"); asyncEvent.getAsyncContext().dispatch(); } public void onError(AsyncEvent asyncEvent) throws IOException {} public void onStartAsync(AsyncEvent asyncEvent) throws IOException {} }); } It looks like the Servlet 3.0 specification allows to do such call, here's the quotation that explicitly states the flow of the timeouted async contexts (page 18): "In the event that an asynchronous operation times out, the container must run through the following steps: Invoke the AsyncListener.onTimeout method on all the AsyncListener instances registered with the ServletRequest on which the asynchronous operation was initiated. If none of the listeners called AsyncContext.complete() or any of the AsyncContext.dispatch methods, perform an error dispatch with a status code equal to HttpServletResponse.SC_INTERNAL_SERVER_ERROR. If no matching error page was found, or the error page did not call AsyncContext.complete() or any of the AsyncContext.dispatch methods, the container MUST call AsyncContext.complete()" Second step assumes that the call to dispatch in onTimeout() is allowed.
2010-11-20 11:00:06
1,290,270,000
resolved fixed
991702c
1,290,440,000
java/org/apache/coyote/AsyncStateMachine.java test/org/apache/catalina/core/TestAsyncContextImpl.java
Tomcat
559
50,310
Bug 50310 Manager detailed status page does not display servlets
To reproduce: 1. Login to the Manager webapp 2. Click "Server Status" and then "Complete Server Status" links. In TC6 the "Complete Server Status" page lists servlets for each deployed application. In the current TC7 it does not list them. Only summary information on each webapp is displayed. Looking at the StatusManagerServlet and StatusTransformer classes, the code to iterate over servlets is still there, but probably the JMX names have changed and are not working any more.
2010-11-21 21:08:35
1,290,390,000
resolved fixed
ade20d2
1,290,430,000
java/org/apache/catalina/core/StandardWrapper.java
Tomcat
560
50,293
Bug 50293 javax.el.CompositeELResolver synchronization issue
null
2010-11-18 16:58:18
1,290,120,000
resolved fixed
7b89af8
1,290,190,000
java/javax/el/CompositeELResolver.java
Tomcat
561
50,192
Bug 50192 performance issue after revision 746425
null
2010-11-01 15:17:42
1,288,640,000
resolved fixed
e075c4b
1,289,590,000
java/org/apache/jasper/el/ELContextImpl.java java/org/apache/jasper/el/ELResolverImpl.java
Tomcat
562
50,230
Bug 50230 Recursive dependency between the tomcat-catalina-ha and tomcat-catalina
null
2010-11-07 21:04:22
1,289,180,000
resolved fixed
96020cb
1,289,510,000
java/org/apache/catalina/DistributedManager.java java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/manager/HTMLManagerServlet.java
Tomcat
563
50,252
Bug 50252 ClassCastException occurs if context.xml contains <ResourceLink>.
null
2010-11-11 01:08:11
1,289,460,000
resolved fixed
7e7283d
1,289,480,000
java/org/apache/naming/NamingContext.java
Tomcat
564
50,183
Bug 50183 [Tribes] Bio Sender is not scheduling the task to the excecutors
null
2010-10-29 16:55:40
1,288,390,000
resolved fixed
84efb0a
1,289,480,000
java/org/apache/catalina/tribes/transport/bio/BioReceiver.java java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java
Tomcat
565
50,169
Bug 50169 Trying to register wrapper and welcomeFile to Mapper before context is registered on Mapper.
null
2010-10-28 03:21:29
1,288,250,000
resolved fixed
476921f
1,289,480,000
java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/StandardWrapper.java
Tomcat
566
50,222
Bug 50222 JreMemoryLeakPreventionListener should speculatively cause memory leaks using the system ClassLoader
JreMemoryLeakPreventionListener intentionally invokes methods known to pin the context ClassLoader in memory in order to avoid having a WebappClassLoader unintentionally pin itself. This may cause undesirable behavior in embedded environments. Instead, JMLPL could use a security context to temporarily set the current context ClassLoader to be the system ClassLoader and solve the embedded situation without the client having to remember to take this care.
2010-11-05 11:00:08
1,288,970,000
resolved fixed
4ca3db3
1,289,390,000
java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
Tomcat
567
50,184
Bug 50184 RpcChannel sends the answer without requesting an ACK
null
2010-10-29 17:12:34
1,288,390,000
resolved fixed
afdc055
1,289,320,000
java/org/apache/catalina/tribes/group/RpcChannel.java
Tomcat
568
50,232
Bug 50232 org.apache.catalina.session.StoreBase has a hidden dependency on PersistentManager
null
2010-11-08 05:09:39
1,289,210,000
resolved fixed
b5c24f9
1,289,320,000
java/org/apache/catalina/session/StoreBase.java
Tomcat
569
50,168
Bug 50168 destory method is called twice while the child is destoryed directly
While calling the method destory() on the StandardContext directly, it seems that the method destoryInternal() is called twice in the LifecycleMBeanBase, the two stacktraces are below : a. LifecycleMBeanBase.unregister(ObjectName) line: 191 LifecycleMBeanBase.destroyInternal() line: 73 ContainerBase.destroyInternal() line: 1109 StandardContext.destroyInternal() line: 5114 LifecycleBase.destroy() line: 271 ContainerBase.removeChild(Container) line: 963 ContainerBase.destroyInternal() line: 1106 StandardContext.destroyInternal() line: 5114 LifecycleBase.destroy() line: 271 ... b. LifecycleMBeanBase.unregister(ObjectName) line: 191 LifecycleMBeanBase.destroyInternal() line: 73 ContainerBase.destroyInternal() line: 1109 StandardContext.destroyInternal() line: 5114 LifecycleBase.destroy() line: 271 ...
2010-10-27 22:47:42
1,288,230,000
resolved fixed
6eae969
1,288,910,000
java/org/apache/catalina/Lifecycle.java java/org/apache/catalina/LifecycleState.java java/org/apache/catalina/core/AprLifecycleListener.java java/org/apache/catalina/core/ContainerBase.java java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/util/LifecycleBase.java
Tomcat
570
50,127
Bug 50127 Possible NPEs in SimpleTCPCluster
null
2010-10-20 19:31:02
1,287,620,000
resolved fixed
f77368f
1,288,900,000
java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
Tomcat
571
49,180
Bug 49180 Add option to disable log rotation in FileHandler.
Small enhancement to FileHandler.java which allow susers to disable log rotation by setting the .rotation attribute to "false".
2010-04-24 13:34:58
1,272,130,000
resolved fixed
7184011
1,288,630,000
java/org/apache/juli/FileHandler.java
Tomcat
572
50,157
Bug 50157 a lot of MapperListener is registered as ContainerListener of StandardContext
null
2010-10-26 03:28:12
1,288,080,000
resolved fixed
53c5d85
1,288,130,000
java/org/apache/catalina/connector/MapperListener.java java/org/apache/catalina/mbeans/ContainerMBean.java
Tomcat
573
50,129
Bug 50129 ContextConfig - unnecessary null checks
null
2010-10-20 19:48:00
1,287,620,000
resolved fixed
509ab5d
1,287,930,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
574
50,138
Bug 50138 Lack of synchronization in org.apache.catalina.security.SecurityUtil
Symptom: all processor threads spin madly in: ============== "tomcat-processor-20" daemon prio=10 tid=0x09210800 nid=0x51fb runnable [0x61b76000] java.lang.Thread.State: RUNNABLE at java.util.HashMap.getEntry(HashMap.java:347) at java.util.HashMap.containsKey(HashMap.java:335) at org.apache.catalina.security.SecurityUtil.doAsPrivilege(SecurityUtil.java:227) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230) at org.apache.catalina.core.ApplicationFilterChain.access$000(ApplicationFilterChain.java:56) at org.apache.catalina.core.ApplicationFilterChain$1.run(ApplicationFilterChain.java:189) at java.security.AccessController.doPrivileged(Native Method) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:185) ... ============== Cause: org.apache.catalina.security.SecurityUtil.objectCache is a HashMap, but access to it is not synchronized. The javadoc for HashMap says: ============= Note that this implementation is not synchronized. If multiple threads access a hash map concurrently, and at least one of the threads modifies the map structurally, it must be synchronized externally. ============= Proposed solution: change objectCache to ConcurrentHashMap;
2010-10-21 09:22:56
1,287,670,000
resolved fixed
9d955f4
1,287,680,000
java/org/apache/catalina/security/SecurityUtil.java
Tomcat
575
50,107
Bug 50107 StandardPipeline is destroyed two times.
null
2010-10-18 03:05:40
1,287,390,000
resolved fixed
44f568f
1,287,490,000
java/org/apache/catalina/mbeans/MBeanFactory.java
Tomcat
576
50,105
Bug 50105 Violation of JSP-EL spec version 2.1 when coerce Enum to String
null
2010-10-17 05:26:20
1,287,310,000
resolved fixed
e6c1d55
1,287,490,000
java/org/apache/el/parser/AstCompositeExpression.java test/org/apache/el/TestValueExpressionImpl.java test/org/apache/el/TesterEnum.java
Tomcat
577
49,426
Bug 49426 Manager app wrongly localized
null
2010-06-11 03:26:07
1,276,240,000
resolved fixed
7357867
1,287,260,000
java/org/apache/catalina/manager/HTMLManagerServlet.java java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/tomcat/util/res/StringManager.java
Tomcat
578
50,087
Bug 50087 When metadata-complete="false" throw illegal JVM_CONSTANT_Class name
When metadata-complete="false" and add groovy-all-1.7.2.jar to app lib throw java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:290) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:418) Caused by: java.lang.ClassFormatError: groovy/jmx/builder/package-info : illegal JVM_CONSTANT_Class name: groovy/jmx/builder/package-info at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClassCond(ClassLoader.java:632) at java.lang.ClassLoader.defineClass(ClassLoader.java:616) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141) at org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:2804) at org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:1144) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1639) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1517) at org.apache.catalina.startup.ContextConfig.checkHandlesTypes(ContextConfig.java:1952) at org.apache.catalina.startup.ContextConfig.processAnnotationsStream(ContextConfig.java:1915) at org.apache.catalina.startup.ContextConfig.processAnnotationsJar(ContextConfig.java:1802) at org.apache.catalina.startup.ContextConfig.processAnnotationsUrl(ContextConfig.java:1761) at org.apache.catalina.startup.ContextConfig.processAnnotations(ContextConfig.java:1747) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1252) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:881) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:315) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:89) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4700) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1028) at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:773) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1028) at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:278) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140) at org.apache.catalina.core.StandardService.startInternal(StandardService.java:429) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140) at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:662) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:140) at org.apache.catalina.startup.Catalina.start(Catalina.java:592) ... 6 more
2010-10-13 09:36:12
1,286,980,000
resolved fixed
9e7ce59
1,287,070,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
579
50,066
Bug 50066 Cannot compile recursive tag with ant if it uses a class from the webapp
null
2010-10-09 09:49:32
1,286,630,000
resolved fixed
79cf689
1,286,730,000
java/org/apache/jasper/compiler/TagFileProcessor.java
Tomcat
580
50,063
Bug 50063 Latest trunck can't configure context when metadata-complete is true and version is 3.0
null
2010-10-08 22:59:40
1,286,590,000
resolved fixed
4d7f111
1,286,700,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
581
50,027
Bug 50027 NullPointerException if context.xml is present with <Resource>
If you deploy a WAR with contex.xml in META-INF and the context.xml has <Resource> tag, Tomcat don t boot and gives this error: java.lang.NullPointerException at org.apache.catalina.core.StandardContext.getObjectKeyPropertiesNameOnly(StandardContext.java:5570) at org.apache.catalina.core.StandardContext.setNamingResources(StandardContext.java:1757) at org.apache.catalina.core.StandardContext.getNamingResources(StandardContext.java:1735) at org.apache.catalina.startup.SetNextNamingRule.end(SetNextNamingRule.java:99) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1058) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:601) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:180) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1544) at org.apache.catalina.startup.Catalina.load(Catalina.java:524) at org.apache.catalina.startup.Catalina.load(Catalina.java:560) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414) 29/09/2010 13:50:37 org.apache.catalina.startup.Catalina load AVISO: Catalina.start using conf/server.xml: java.lang.NullPointerException at org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2688) at org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2714) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1061) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:601) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:180) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1544) at org.apache.catalina.startup.Catalina.load(Catalina.java:524) at org.apache.catalina.startup.Catalina.load(Catalina.java:560) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414) Caused by: java.lang.NullPointerException at org.apache.catalina.core.StandardContext.getObjectKeyPropertiesNameOnly(StandardContext.java:5570) at org.apache.catalina.core.StandardContext.setNamingResources(StandardContext.java:1757) at org.apache.catalina.core.StandardContext.getNamingResources(StandardContext.java:1735) at org.apache.catalina.startup.SetNextNamingRule.end(SetNextNamingRule.java:99) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1058) ... 20 more 29/09/2010 13:50:37 org.apache.tomcat.util.digester.SetPropertiesRule begin AVISO: [SetPropertiesRule]{Server/Service/Engine/Host/Context} Setting property 'source' to 'org.eclipse.jst.jee.server:bestforkprime' did not find a matching property. 29/09/2010 13:50:37 org.apache.tomcat.util.digester.Digester endElement GRAVE: End event threw exception java.lang.NullPointerException at org.apache.catalina.core.StandardContext.getObjectKeyPropertiesNameOnly(StandardContext.java:5570) at org.apache.catalina.core.StandardContext.setNamingResources(StandardContext.java:1757) at org.apache.catalina.core.StandardContext.getNamingResources(StandardContext.java:1735) at org.apache.catalina.startup.SetNextNamingRule.end(SetNextNamingRule.java:99) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1058) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:601) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:180) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1544) at org.apache.catalina.startup.Catalina.load(Catalina.java:524) at org.apache.catalina.startup.Catalina.start(Catalina.java:573) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:288) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:415) 29/09/2010 13:50:37 org.apache.catalina.startup.Catalina load AVISO: Catalina.start using conf/server.xml: java.lang.NullPointerException at org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2688) at org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2714) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1061) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:601) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:180) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1544) at org.apache.catalina.startup.Catalina.load(Catalina.java:524) at org.apache.catalina.startup.Catalina.start(Catalina.java:573) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:288) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:415) Caused by: java.lang.NullPointerException at org.apache.catalina.core.StandardContext.getObjectKeyPropertiesNameOnly(StandardContext.java:5570) at org.apache.catalina.core.StandardContext.setNamingResources(StandardContext.java:1757) at org.apache.catalina.core.StandardContext.getNamingResources(StandardContext.java:1735) at org.apache.catalina.startup.SetNextNamingRule.end(SetNextNamingRule.java:99) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1058) ... 20 more 29/09/2010 13:50:37 org.apache.catalina.startup.Catalina start GRAVE: Cannot start server. Server instance is not configured. Here is my contex.xml OBS: some values were replaced with XXXX <?xml version="1.0" encoding="UTF-8"?> <Context privileged="true" reloadable="true"> <WatchedResource>WEB-INF/web.xml</WatchedResource> <WatchedResource>META-INF/context.xml</WatchedResource> <Resource name="jdbc/bestfork" auth="Container" type="com.mchange.v2.c3p0.ComboPooledDataSource" factory="org.apache.naming.factory.BeanFactory" user="xxx" password="xxxx" driverClass="org.postgresql.Driver" jdbcUrl="jdbc:postgresql://localhost:5432/xxxxx" minPoolSize="5" maxPoolSize="30" acquireIncrement="5" idleConnectionTestPeriod="100" maxIdleTime="30"/> <Resource name="mail/Session" auth="Container" type="javax.mail.Session" mail.smtp.host="xxxx" mail.smtp.auth="true" username="xxx" password="xxx" mail.user="xxxx" mail.password="xxxx" mail.smtp.port="587" mail.transport.protocol="smtp" mail.debug="true" /> <Realm className="org.apache.catalina.realm.JDBCRealm" driverName="org.postgresql.Driver" connectionURL="jdbc:postgresql://localhost:5432/xxxx" connectionName="xxxx" connectionPassword="xxxx" userTable="usuario" userNameCol="usuario_cpf" userCredCol="usuario_senha" userRoleTable="usuario_papel" roleNameCol="papel_nome" digest="MD5" /> </Context>
2010-09-29 13:02:53
1,285,780,000
resolved fixed
6ce21f4
1,286,570,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
582
50,059
Bug 50059 Resources are not served from /WEB-INF/lib/{*.jar}/META-INF/resources if metadata-complete="true" is set in web.xml
null
2010-10-08 07:57:25
1,286,540,000
resolved fixed
da36bd1
1,286,570,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
583
50,017
Bug 50017 Make private immutable fields final
null
2010-09-27 20:27:07
1,285,630,000
resolved fixed
c4a3427
1,286,550,000
java/javax/el/ValueReference.java java/javax/servlet/AsyncEvent.java java/javax/servlet/HttpConstraintElement.java java/javax/servlet/HttpMethodConstraintElement.java java/javax/servlet/MultipartConfigElement.java java/javax/servlet/ServletContextAttributeEvent.java java/javax/servlet/ServletRequestAttributeEvent.java java/javax/servlet/ServletRequestEvent.java java/javax/servlet/ServletSecurityElement.java java/javax/servlet/UnavailableException.java java/javax/servlet/http/HttpSessionBindingEvent.java java/javax/servlet/jsp/ErrorData.java java/javax/servlet/jsp/tagext/BodyContent.java java/javax/servlet/jsp/tagext/FunctionInfo.java java/javax/servlet/jsp/tagext/TagAttributeInfo.java java/javax/servlet/jsp/tagext/TagData.java java/javax/servlet/jsp/tagext/TagExtraInfo.java java/javax/servlet/jsp/tagext/TagFileInfo.java java/javax/servlet/jsp/tagext/TagVariableInfo.java java/javax/servlet/jsp/tagext/ValidationMessage.java java/javax/servlet/jsp/tagext/VariableInfo.java
Tomcat
584
50,016
Bug 50016 bad division of responsibility around isUserInRole and new Request login and logout methods
null
2010-09-27 16:56:39
1,285,620,000
resolved fixed
469a916
1,286,550,000
java/org/apache/catalina/Authenticator.java java/org/apache/catalina/Realm.java java/org/apache/catalina/authenticator/AuthenticatorBase.java java/org/apache/catalina/authenticator/BasicAuthenticator.java java/org/apache/catalina/authenticator/DigestAuthenticator.java java/org/apache/catalina/authenticator/FormAuthenticator.java java/org/apache/catalina/authenticator/NonLoginAuthenticator.java java/org/apache/catalina/authenticator/SSLAuthenticator.java java/org/apache/catalina/connector/Request.java java/org/apache/catalina/realm/RealmBase.java java/org/apache/catalina/realm/UserDatabaseRealm.java
Tomcat
585
49,987
Bug 49987 Data race in ApplicationContext
null
2010-09-23 10:16:06
1,285,250,000
resolved fixed
2db864e
1,286,490,000
java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java
Tomcat
586
49,986
Bug 49986 Double-check locking. Possible data-race in JspServletWrapper
null
2010-09-23 09:31:03
1,285,250,000
resolved fixed
2570d6ff
1,286,460,000
java/org/apache/jasper/servlet/JspServletWrapper.java
Tomcat
587
49,972
Bug 49972 Double-check idiom. Possible data-race.
null
2010-09-22 04:44:02
1,285,150,000
resolved fixed
0ae33cb
1,286,460,000
java/org/apache/tomcat/util/http/FastHttpDateFormat.java
Tomcat
588
50,054
Bug 50054 When the AJP connector is used, minSpareThreads cannot be used.
I found following warnning messages. == Oct 7, 2010 2:25:27 PM org.apache.catalina.startup.SetAllPropertiesRule begin WARNING: [SetAllPropertiesRule]{Server/Service/Connector} Setting property 'minSpareThreads' to '31' did not find a matching property. == The AJP connector's configs are the following. <Connector port="8009" protocol="AJP/1.3" redirectPort="8443" minSpareThreads="100"/> When I used the Http connector, minSpareThreads was able to be used. org.apache.coyote.ajp.AjpProtocol doesn't set the minSpareThreads to org.apache.tomcat.util.net.JIoEndpoint. I made a patch. This patch was made based on AbstractHttp11Protocol. Best regards.
2010-10-07 04:22:51
1,286,440,000
resolved fixed
654c964
1,286,440,000
java/org/apache/coyote/ajp/AbstractAjpProtocol.java java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/ajp/AjpProtocol.java
Tomcat
589
49,956
Bug 49956 @Resource(name=) Normalization of JNDI Name
null
2010-09-17 20:15:03
1,284,770,000
resolved fixed
0e71157
1,286,400,000
java/org/apache/catalina/core/DefaultInstanceManager.java
Tomcat
590
49,952
Bug 49952 ServletContainerInitializer can't actually add listeners
null
2010-09-17 13:49:20
1,284,750,000
resolved fixed
937227a
1,286,400,000
java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/startup/TestListener.java
Tomcat
591
49,937
Bug 49937 Problems with AsyncListener and resource injection
null
2010-09-16 01:49:41
1,284,620,000
resolved fixed
cf4e575
1,286,140,000
java/org/apache/catalina/core/AsyncContextImpl.java
Tomcat
592
49,985
Bug 49985 Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString
null
2010-09-23 08:55:42
1,285,250,000
resolved fixed
b893eee
1,286,050,000
java/org/apache/el/parser/AstFloatingPoint.java java/org/apache/el/parser/AstInteger.java java/org/apache/el/parser/AstString.java
Tomcat
593
49,915
Bug 49915 [Patch] o.a.c.c.StandardServer swallows error on storeConfig.
When o.a.c.c.StandardServer#storeConfig is called all exceptions were getting swallowed. This lead to the impresssion it was working correctly when saved either through the manager application /manager/save or through jconsole. I've removed the catch throwable block and thrown an exception upon not finding the registerd MBean.
2010-09-10 19:35:43
1,284,160,000
resolved fixed
5eb3851
1,285,950,000
java/org/apache/catalina/core/StandardServer.java
Tomcat
594
49,905
Bug 49905 In cluster, when using DeltaManager memory leak can occur
null
2010-09-09 07:22:00
1,284,030,000
resolved fixed
2c858be
1,285,950,000
java/org/apache/catalina/tribes/group/interceptors/MessageDispatch15Interceptor.java java/org/apache/catalina/tribes/util/TcclThreadFactory.java
Tomcat
595
49,890
Bug 49890 Nio Selector issue on linux platform
null
2010-09-07 09:17:54
1,283,870,000
resolved wontfix
f4de5ab
1,285,940,000
java/org/apache/tomcat/util/net/NioEndpoint.java
Tomcat
596
49,861
Bug 49861 Log format of RMI ports can be improved, remove ","
null
2010-09-02 04:42:55
1,283,420,000
resolved fixed
00cc8c6
1,285,930,000
java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java
Tomcat
597
49,667
Bug 49667 JdbcLeakPrevention class can register unregistered JCBC Driver
null
2010-07-29 09:31:33
1,280,410,000
resolved fixed
dc754cc
1,285,930,000
java/org/apache/catalina/loader/JdbcLeakPrevention.java
Tomcat
598
49,856
Bug 49856 Connector/ThreadPool link to Executor not exposed via JMX
When viewing either Connector objects or ThreadPool objects via JMX the name of the executor is not shown. It would be helpful if this were exposed via JMX so the links between Connectors/ThreadPools and Executors could be determined.
2010-09-01 03:24:08
1,283,330,000
resolved fixed
167829c
1,285,880,000
java/org/apache/catalina/connector/Connector.java
Tomcat
599
49,730
Bug 49730 Race condition in StandardThreadExecutor : requests are sometimes enqueued instead of creating new threads
In tomcat 6, I often configure an Executor with minSpareThreads=0 to work around memory leak issues upon redeployment. Sometimes (especially in development), when I refresh a page of my webapp with Safari, Chrome or Firefox, some resources of the page take several seconds (>10s) to be served though they are static resources and should come in less than 50ms. For instance, over 15 requests for a page (1 for html, the others for resources like js, css, images...), I sometimes have 1 or 2 that take >10s. After analysis, I found that in org.apache.catalina.core.StandardThreadExecutor.TaskQueue.offer(Runnable) the statement if (parent.getActiveCount()<(parent.getPoolSize())) is sometimes true unexpectedly. Here is the scenario : - ThreadPoolExecutor is empty - the user refreshes the page (or accesses it with an empty cache) in his web browser for a page that uses a more than 10-15 resources - the browser establishes one TCP connection and a new Thread is created - after the browser receives the response, it decides to load as many resources as possible in parallel. For this it establishes up to 6 TCP connections (in my tests) - The Acceptor thread calls StandardThreadExecutor.execute to process each incoming connection. - For each call, StandardThreadExecutor.TaskQueue.offer(Runnable) is being called - if you study the sources of Java 6 ThreadPoolExecutor, you can see that there's a small delay between the time a new Thread is created (thus increasing poolSize) and the time it starts working on its first task (increasing the activeCount) - Since in my case connections are established in a rapid burst, the calls to TaskQueue.offer() are sometimes faster than this small delay, so that we do have parent.getActiveCount()<parent.getPoolSize() and thus the task is enqueued instead of forcing the creation of a thread to serve it. - Since Keep-Alive is enabled and tomcat 6 threads take care of only one TCP connection at a time, the requests in the queue must wait for the keep-alive timeout so that a Thread is returned to the pool to serve pending tasks. - With 25s keepAliveTimeOut, it means that some requests take more than 25s to be served eventhough the pool was never full and the server quite idle!!! Other facts about this issue : - Although my test case starts with an empty pool, it can occur even on a loaded server. The thing that triggers the issue is the burst of new TCP connections. - The problem is less severe with a lower keepAliveTimeout, or if keepalive is disabled. In any case, it also depends on the time taken to serve current requests. - The issue also affects tomcat 7 but is less severe because tc7 threads are returned to the pool after each http request, even if the TCP connection is kept alive. The impact would the same as with tc6 with keepAlive disabled.
2010-08-09 16:16:04
1,281,380,000
resolved fixed
2bfc300
1,285,870,000
java/org/apache/tomcat/util/threads/TaskQueue.java java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java
Tomcat
600
50,021
Bug 50021 ExceptionUtils class missing from bootstrap.jar
o.a.c.startup.Bootstrap uses o.a.jasper.util.ExceptionUtils, but this class is not placed in bootstrap.jar, causing rather nasty failures if anything goes wrong during initial bootstrapping. This should be a fairly simple matter of updating build.xml to include it, but I wasn't sure whether including Jasper classes in the bootstrap was the done thing. There's an o.a.tomcat.util.ExceptionUtils that is identical, but that too looks like the wrong thing to grab.
2010-09-29 03:43:11
1,285,750,000
resolved fixed
6c22816
1,285,760,000
java/org/apache/catalina/startup/Bootstrap.java
Tomcat
601
50,018
Bug 50018 Javadoc corrections
null
2010-09-27 20:47:45
1,285,630,000
resolved fixed
2f8a27c
1,285,750,000
java/org/apache/jasper/compiler/ParserController.java java/org/apache/jasper/compiler/TagFileProcessor.java
Tomcat
602
49,195
Bug 49195 Using -1 as shutdown port with Windows service works, but prints error message
1. Install Tomcat as a service on Windows 2. Specify <Server port="-1" in server.xml 3. Start the service, and then stop the service. 4. The following is printed in the catalina.2010-04-27.log: 27.04.2010 17:49:13 org.apache.catalina.startup.Catalina stopServer SEVERE: No shutdown port configured. Shut down server through OS signal. Server not shut down. It is just a message. Tomcat stops regardless of it: After printing the message Catalina#stopServer() performs System.exit(1) which results in Tomcat shutdown. I think that when service launcher stops Tomcat, Catalina#server is not null. That can be used to differentiate the two use cases. There could be improvements on how to stop Tomcat. E.g., to call Catalina.stop(). If that is the case, it would be better to use wait(10000) instead of sleep(10000) in StandardServer.await(), so that it could be woken by a notifyAll() call, or use interrupt() call to wake it up (if we know the thread). System.exit(0) would work regardless of all that. I suppose that jsvc may show the same behaviour, but I have not tried.
2010-04-27 10:22:54
1,272,380,000
resolved fixed
7c6b1a5
1,285,710,000
java/org/apache/catalina/startup/Catalina.java
Tomcat
603
49,665
Bug 49665 When file not found error occurs it does not tell you which file caused the error.
null
2010-07-29 05:08:43
1,280,390,000
resolved fixed
7b24ed5
1,285,690,000
java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/compiler/JspDocumentParser.java java/org/apache/jasper/compiler/Parser.java java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
Tomcat
604
49,625
Bug 49625 Tomcat doesn't send Vary consistently when gzip enabled
HTTP requires that the Vary response header be sent consistently for all responses if they change based upon different aspects of the request. My pages has both compressed and uncompressed variants available, negotiated by the Accept-Encoding request header, but it sends different Vary headers for each; "accept-encoding" when the response is compressed, and "" when it is not. This can cause problems for downstream caches, because they cannot consistently determine what the cache key for a given URI is. My server.xml content: <Service name="Catalina"> <Connector port="8080" proxyPort="80" maxHttpHeaderSize="8192" protocol="org.apache.coyote.http11.Http11Protocol" maxThreads="200" minSpareThreads="25" maxPostSize="8" maxSpareThreads="75" enableLookups="false" keepAliveTimeout="3000" maxKeepAliveRequests="100" redirectPort="8443" acceptCount="100" connectionTimeout="8000" disableUploadTimeout="true" compression="on" compressionMinSize="2048" compressableMimeType="text/html,text/xml,text/javascript,text/css" /> <Engine name="Catalina" defaultHost="localhost"> <Host name="localhost" appBase="webapps" unpackWARs="false" autoDeploy="false" debug="0" xmlValidation="false" xmlNamespaceAware="false"> </Host> </Engine> </Service>
2010-07-21 03:11:07
1,279,700,000
resolved fixed
7435fa9
1,285,680,000
java/org/apache/coyote/http11/AbstractHttp11Processor.java
Tomcat
605
49,209
Bug 49209 AccessControlException when undeploying application
When running Tomcat with a SecurityManager, an AccessControlException is thrown during undeployment. Stack trace: Caused by: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader) at java.security.AccessControlContext.checkPermission(AccessControlContext.java:323) at java.security.AccessController.checkPermission(AccessController.java:546) at java.lang.SecurityManager.checkPermission(SecurityManager.java:532) at java.lang.Class.getClassLoader(Class.java:594) at org.apache.catalina.loader.JdbcLeakPrevention.clearJdbcDriverRegistrations(JdbcLeakPrevention.java:49) I assume the default catalina.policy should be updated, to take this case into account.
2010-04-28 07:30:12
1,272,450,000
resolved fixed
d0d4c75
1,285,630,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
606
49,102
Bug 49102 coyote.ajp.Constants - 3 "constant" arrays are mutable
The class coyote.ajp.Constants contains 3 public static non-empty String[] arrays: methodTransArray responseTransArray headerTransArray responseTransArray only appears to be locally, so could be made private. The others are used in index lookups, so get(index) methods could be used to protect them.
2010-04-12 16:11:37
1,271,100,000
resolved fixed
fb5a3e7
1,285,240,000
java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpProcessor.java java/org/apache/coyote/ajp/Constants.java
Tomcat
607
49,909
Bug 49909 jstl 1.2 not support
null
2010-09-10 06:20:26
1,284,110,000
resolved fixed
8dc0306
1,284,720,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
608
49,924
Bug 49924 When non-primary node changes into a primary node, isPrimarySession is not changed to true.
If BackupManager is used, when a primary node is switched, DeltaSession#isPrimarySession is not changed to true. Non-primary node changes into a primary node when a primary node is stopped or we get a non-primary session. If a primary node is stopped, a primary node is switched. In AbstractReplicatedMap, when a primary node is switched, MapOwner(BackupManager)#objectMadePrimay is called. However, isPrimarySession does not change to true in this method. =====BackupManager#objectMadePrimay===== public void objectMadePrimay(Object key, Object value) { if (value!=null && value instanceof DeltaSession) { DeltaSession session = (DeltaSession)value; synchronized (session) { session.access(); session.endAccess(); } } } ===== If we get a non-primary session, a primary node is switched. However, isPrimarySession does not change to true. It is only a change of primary node. I made a patch. It contains the following. isPrimarySession is set to true in BackupManager#objectMadePrimay. When get() is called in non-primary node, MapOwner#objectMadePrimay is called. Best regards.
2010-09-14 03:23:07
1,284,450,000
resolved fixed
b255697
1,284,450,000
java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Tomcat
609
49,234
Bug 49234 JMX Descriptor Modifications
null
2010-04-30 00:17:34
1,272,600,000
resolved fixed
e0182ef
1,284,250,000
java/org/apache/catalina/Server.java java/org/apache/catalina/Service.java java/org/apache/catalina/core/StandardEngine.java java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/core/StandardService.java java/org/apache/catalina/mbeans/ContainerMBean.java java/org/apache/catalina/mbeans/ContextMBean.java java/org/apache/catalina/mbeans/ServiceMBean.java java/org/apache/catalina/startup/Catalina.java
Tomcat