id
int64
1
6.5k
bug_id
int64
2.03k
426k
summary
stringlengths
9
251
description
stringlengths
1
32.8k
report_time
stringlengths
19
19
report_timestamp
int64
1B
1.39B
status
stringclasses
6 values
commit
stringlengths
7
9
commit_timestamp
int64
1B
1.39B
files
stringlengths
25
32.8k
project_name
stringclasses
6 values
610
49,892
Bug 49892 Wrong JNDI Name for Method Resource Injections
Method based JNDI env. injections not worked correctly. Patch is attached. See Java EE 6 specification section, EE. 5.2.5 Annotations and Injections. Patch is provided that solves problem.
2010-09-07 10:44:49
1,283,870,000
resolved fixed
94147b2
1,283,980,000
java/org/apache/catalina/core/DefaultInstanceManager.java
Tomcat
611
49,831
Bug 49831 Issue with closing XAConnections on MSSQL
When using XAConnections with MSSQL it has been noticed that the physical connections are not being closed when DataSourceProxy.close(boolean all) is called. This method invokes org.apache.tomcat.jdbc.pool.PooledConnection.disconnent() which calls connection.close(). However, when used with SQLServer, the connection attribute is a proxy object (type com.microsoft.sqlserver.jdbc.SQLServerConnectionPoolProxy) which wraps the physical connection (of type com.microsoft.sqlserver.jdbc.SQLServerConnection). Calling close() on the proxy object only notifies the pool manager that the Connection is released back to the pool; it does not close the underlying physical connection. This is what the PooledConnection.disconnent() implementation currently reads: private void disconnect(boolean finalize) { if (isDiscarded()) { return; } setDiscarded(true); if (connection != null) { try { connection.close(); }catch (Exception ignore) { if (log.isDebugEnabled()) { log.debug("Unable to close underlying SQL connection",ignore); } } } connection = null; xaConnection = null; lastConnected = -1; if (finalize) parent.finalize(this); } If the logic was changed to the following, it would properly closed the XAConnection with the MSSQL. private void disconnect(boolean finalize) { if (isDiscarded()) { return; } setDiscarded(true); if (connection != null) { try { if (xaConnection != null) { xaConnection.close(); } else { connection.close(); } }catch (Exception ignore) { if (log.isDebugEnabled()) { log.debug("Unable to close underlying SQL connection",ignore); } } } connection = null; xaConnection = null; lastConnected = -1; if (finalize) parent.finalize(this); }
2010-08-26 11:08:08
1,282,840,000
resolved fixed
64a8346
1,283,960,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Tomcat
612
49,883
Bug 49883 java.lang.UnsupportedOperationException: The getName() method should never be called
null
2010-09-04 22:58:52
1,283,660,000
resolved fixed
a9f0fd5
1,283,720,000
java/org/apache/catalina/realm/CombinedRealm.java
Tomcat
613
49,802
Bug 49802 Shutdown of AJP Connector do not work
null
2010-08-23 05:59:48
1,282,560,000
resolved fixed
cd7263e
1,283,720,000
java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/core/StandardService.java java/org/apache/coyote/ProtocolHandler.java java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/ajp/AjpProcessor.java java/org/apache/coyote/ajp/AjpProtocol.java java/org/apache/coyote/http11/AbstractHttp11Protocol.java java/org/apache/coyote/http11/Http11AprProcessor.java java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/coyote/http11/Http11Processor.java java/org/apache/tomcat/util/net/AbstractEndpoint.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/JIoEndpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java
Tomcat
614
49,876
Bug 49876 correcting generics related compile warning in org/apache/tomcat/util/bcel/classfile files
Explanation: Several files have compile time generics related warnings displayed for org/apache/tomcat/util/bcel/classfile. This patch cleans up several of those warnings.
2010-09-03 08:17:45
1,283,520,000
resolved fixed
6155a8b
1,283,540,000
java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java java/org/apache/tomcat/util/bcel/classfile/Attribute.java java/org/apache/tomcat/util/bcel/classfile/JavaClass.java java/org/apache/tomcat/util/bcel/classfile/Unknown.java java/org/apache/tomcat/util/bcel/classfile/Utility.java
Tomcat
615
49,869
Bug 49869 Javadoc for WebAppClassLoader constructor has copy/paste error
The constructor that takes a parent class loader has a copy of the doc string from the constructor that does not take a parent class loader.
2010-09-02 18:26:13
1,283,470,000
resolved fixed
a6620cb
1,283,500,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
616
48,967
Bug 48967 Externalize Strings "catalina.base" and "catalina.home"
null
2010-03-23 14:19:02
1,269,370,000
resolved fixed
bcb994c
1,283,440,000
java/org/apache/catalina/Globals.java java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/ha/deploy/FarmWarDeployer.java java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/manager/host/HostManagerServlet.java java/org/apache/catalina/realm/JAASMemoryLoginModule.java java/org/apache/catalina/realm/MemoryRealm.java java/org/apache/catalina/startup/Bootstrap.java java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/CatalinaProperties.java java/org/apache/catalina/startup/Embedded.java java/org/apache/catalina/startup/ExpandWar.java java/org/apache/catalina/startup/HostConfig.java java/org/apache/catalina/startup/Tomcat.java java/org/apache/catalina/startup/Tool.java java/org/apache/catalina/users/MemoryUserDatabase.java java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/jasper/compiler/AntCompiler.java java/org/apache/tomcat/util/net/AbstractEndpoint.java java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Tomcat
617
49,749
Bug 49749 SSO cookie should be added as HttpOnly
SSO cookies should be made HttpOnly by default. In org.apache.catalina.authenticator.AuthenticatorBase#register(), 798- response.addCookie(cookie); 798+ response.addCookieInternal(cookie, true);
2010-08-13 19:18:22
1,281,740,000
resolved fixed
e641f20
1,282,740,000
java/org/apache/catalina/authenticator/AuthenticatorBase.java
Tomcat
618
48,738
Bug 48738 [PATCH]Allow GzipOutputFilter to send partial result when flushBuffer() is called
null
2010-02-13 23:28:26
1,266,120,000
resolved fixed
526f4ac
1,282,640,000
java/org/apache/coyote/http11/AbstractOutputBuffer.java java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java java/org/apache/coyote/http11/filters/GzipOutputFilter.java test/org/apache/coyote/http11/TestGzipOutputFilter.java
Tomcat
619
49,670
Bug 49670 org.apache.catalina.authenticator.SingleSignOn valve does not function
I have two web applications; neither declare a realm in the context.xml and both are configured for authentication in the web.xml using standard tomcat authentication methods. I have enabled the tomcat valve in the host and have added a realm to the host as well. <Host name="localhost" appBase="webapps" unpackWARs="true" autoDeploy="true"> <Realm className="org.apache.catalina.realm.JAASRealm" appName="SSO" userClassNames="a.b.c" roleClassNames="a.b.c" useContextClassLoader="false"/> <!-- SingleSignOn valve, share authentication between web applications Documentation at: /docs/config/valve.html --> <Valve className="org.apache.catalina.authenticator.SingleSignOn"/> <!-- Access log processes all example. Documentation at: /docs/config/valve.html --> <!-- <Valve className="org.apache.catalina.valves.AccessLogValve" directory="logs" prefix="localhost_access_log." suffix=".txt" pattern="common" resolveHosts="false"/> --> I have added a jaas configuration for the SSO app in the jaas.conf file for the server. I am certain that the realm, jaas.conf are all configured properly as the web applications do require a user to authenticate before accessing the application, but if I have authenticated to one application I still am required to authenticate before accessing the other application. I have this exact same configuration working on a tomcat 6 environment, but an identical configuration will not operate on a tomcat 7 server.
2010-07-29 10:43:35
1,280,410,000
resolved fixed
e2f0b9b
1,282,590,000
java/org/apache/catalina/authenticator/AuthenticatorBase.java
Tomcat
620
49,721
Bug 49721 Fail to access the resources such as jsp files from a jar file which is supported by servlet 3.0
I put a jsp file in a jar file and test whether tomcat 7 supports it by viewing it from the browser and failed.
2010-08-06 21:52:37
1,281,150,000
resolved fixed
187eed8
1,282,590,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
621
49,726
Bug 49726 JSP 2.2 new configuration element <default-content-type> under <jsp-property-group> works incorrectly on tomcat trunk
null
2010-08-09 02:07:45
1,281,330,000
resolved fixed
42c226f
1,282,590,000
java/org/apache/jasper/compiler/Compiler.java test/org/apache/jasper/compiler/TestCompiler.java
Tomcat
622
49,750
Bug 49750 WebappClassLoader.validate(name) does not validate javax.servlet.
The method does not validate the class name as described in the method documentation. "Validate a classname. As per SRV.9.7.2, we must restrict loading of classes from J2SE (java.*) and classes of the servlet API (javax.servlet.*) "
2010-08-15 11:06:54
1,281,880,000
resolved fixed
6fce7d7
1,282,580,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
623
49,758
Bug 49758 [Patch] Generics warnings - rawtypes
null
2010-08-16 13:20:09
1,281,980,000
resolved fixed
c05cb94
1,282,520,000
java/javax/annotation/Resource.java java/javax/ejb/EJB.java java/javax/el/BeanELResolver.java java/javax/el/ELContext.java java/javax/el/ResourceBundleELResolver.java java/javax/servlet/ServletRequestWrapper.java java/javax/servlet/ServletResponseWrapper.java java/javax/servlet/annotation/HandlesTypes.java java/javax/servlet/jsp/el/ExpressionEvaluator.java java/javax/servlet/jsp/el/ImplicitObjectELResolver.java java/javax/servlet/jsp/tagext/TagSupport.java java/javax/xml/ws/WebServiceRef.java java/org/apache/el/lang/EvaluationContext.java java/org/apache/el/parser/AstValue.java java/org/apache/jasper/el/ELContextWrapper.java java/org/apache/jasper/el/ExpressionEvaluatorImpl.java java/org/apache/naming/resources/DirContextURLConnection.java
Tomcat
624
49,757
Bug 49757 correcting some generics related warnings
Patch attached. Thanks
2010-08-16 13:13:12
1,281,980,000
resolved fixed
d446678
1,282,490,000
java/org/apache/catalina/manager/JMXProxyServlet.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Tomcat
625
49,714
Bug 49714 The annotation process of Jar should not impact distributable of web.xml.
Even if < distributable/> is set to web.xml(servlet3.0), distributable is changed from true to false by the annotation process of JAR. ContextConfig#processAnnotations is as follows. ===ContextConfig#processAnnotations protected void processAnnotations(Set<WebXml> fragments) { for(WebXml fragment : fragments) { if (!fragment.isMetadataComplete()) { WebXml annotations = new WebXml(); URL url = fragment.getURL(); processAnnotationsUrl(url, annotations); Set<WebXml> set = new HashSet<WebXml>(); set.add(annotations); // Merge annotations into fragment - fragment takes priority fragment.merge(set); } } } === distributable of "annotations" created by new WebXml() is false (default). If "annotations" is merged with "fragment", distributable of "fragment" becomes false. Because "fragment" is merged with web.xml of the web application, even if < distributable/> is set to web.xml, distributable is changed from true to false. The following are necessary. annotations.setDistributable(true); Best regards.
2010-08-05 22:06:15
1,281,060,000
resolved fixed
f4a10ec
1,281,060,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
626
49,655
Bug 49655 ExpressionFactoryImpl.createMethodExpression() is not EL 2.2 Spec conform
null
2010-07-27 10:32:48
1,280,240,000
resolved fixed
96a99ce
1,280,700,000
test/org/apache/el/TestMethodExpressionImpl.java
Tomcat
627
49,407
Bug 49407 backup manager reports too few current sessions
With 100 sessions shared across 4 nodes (i.e. 25 active sessions per node), the delta manager reports 100 current sessions per node (25 active and the copies of the sessions from the other nodes). The back manager reports 25. For consistency it should report 50. The 25 active sessions plus the 25 (or so) that are backed up on that node.
2010-06-08 15:58:58
1,276,030,000
resolved fixed
d21b105
1,280,430,000
java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Tomcat
628
49,613
Bug 49613 Request.getAttributeNames() slows down some applications
null
2010-07-19 06:23:09
1,279,530,000
resolved fixed
5f1ad13
1,279,810,000
java/org/apache/catalina/connector/Request.java
Tomcat
629
49,567
Bug 49567 when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated
null
2010-07-07 09:22:22
1,278,510,000
resolved fixed
2357fb5
1,279,790,000
java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/Request.java java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/coyote/http11/Http11Processor.java test/org/apache/catalina/core/TestAsyncContextImpl.java
Tomcat
630
49,617
Bug 49617 Fix ExpiresFilter docs (remove remaining ExpiresActive reference)
Remove the last references to the removed configuration parameter ExpiresActive.
2010-07-19 17:44:38
1,279,580,000
resolved fixed
dfbd8aa
1,279,730,000
java/org/apache/catalina/filters/ExpiresFilter.java test/org/apache/catalina/filters/TestExpiresFilter.java
Tomcat
631
48,998
Bug 48998 Proposal : port mod_expires in java as ExpiresFilter Servlet Filter
null
2010-03-26 16:38:18
1,269,640,000
resolved fixed
7963a16
1,279,150,000
java/org/apache/catalina/filters/ExpiresFilter.java test/org/apache/catalina/filters/TestExpiresFilter.java
Tomcat
632
49,127
Bug 49127 SimpleTcpReplicationManager.startInternal() ignores Exception
ha.session.SimpleTcpReplicationManager.startInternal() ignores Exception when invoking Thread.sleep() - it only needs to ignore InterruptedException.
2010-04-14 19:05:06
1,271,290,000
resolved fixed
eca4ed9
1,279,140,000
java/org/apache/catalina/ha/session/SimpleTcpReplicationManager.java
Tomcat
633
49,128
Bug 49128 loader.WebappClassLoader.start() ignores Exception
catalina.loader.WebappClassLoader.start() ignores Exception. However, it probably only needs to ignore SecurityException
2010-04-14 19:06:21
1,271,290,000
resolved fixed
e8245ef
1,279,140,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
634
48,960
Bug 48960 SSI Servlet should support safe configuration
The current configuration of the SSI module is "All" or "None". The "ALL" option will expose all the legacy Apache SSI directive (echo, printenv, if, exec, ...). As documented, allowing SSI will allow execution of arbitrary programs using the "exec". As a result, there is no safe way to expose sites/projects containing SSI directive, without taking a security risk, or reviewing of every file. The "exec" directive, with the cmd option is a major risk. Even for Apache, you have the option to allowing the "safe" include (includeNoExec). The includeNoExec allow pages to be served, even when the content is not reviewed, or when users are allowed to upload content to the site. I have a big site which need to be converted into JSP. I would like to use the SSI servlet to allow for transition over time. The extra risk from ( from exec cmd) make it impossible to deploy the SSI. My request: Modify the configuration of SSI as follow: By default, it will only allow "safe" directive (no exec cmd=...). This will eliminate the risk from arbitrary execution of commands ("del *.*"). It will also remove many potentail load problems. The cmd= should only be allowed using a directive like "allowUnsafeExec", which will default to false. I think that the change will make it easier to use the SSI feature, without exposing the server to big risk. The risk associated with the "safer" version of SSI is similar to the risk from running JSP pages.
2010-03-22 16:37:48
1,269,290,000
resolved fixed
a36b0c0
1,279,060,000
java/org/apache/catalina/ssi/SSIFilter.java java/org/apache/catalina/ssi/SSIProcessor.java java/org/apache/catalina/ssi/SSIServlet.java
Tomcat
635
49,442
Bug 49442 Make StringManager fields final
null
2010-06-15 05:41:37
1,276,590,000
resolved fixed
4159093
1,278,800,000
java/org/apache/tomcat/util/res/StringManager.java
Tomcat
636
49,478
Bug 49478 Add encoding parameter to AddDefaultCharSetFilter
AddDefaultCharSetFilter adds a default charset to each request. It assumes ISO-8859-1 as the default charset. The attached patch makes it configurable by introducing an "encoding" parameter. This parameter can take one of two special values "default" or "system". Every other value will be interpreted as a name of an character set, e.g "utf-8". The meaning of the two special values are as follows: default: use ISO-8859-1. This value will also be used, if no parameter was specified, or if it is empty system: the jvm will be asked for the default charset. This charset will usually be set by system locale. Together with this functional change, there are two minor changes and one bigger changes hidden. First use of annotation "Override" at overriden methods. Second use of keyword "static" for the ResponseWrapper, since it has no reference to outer class. The third and somewhat bigger change is use of HttpServletResponse#setCharacterEncoding(encoding) instead of manipulating the content-type.
2010-06-21 05:43:57
1,277,110,000
resolved fixed
d6766f1
1,278,800,000
java/org/apache/catalina/filters/AddDefaultCharsetFilter.java test/org/apache/catalina/filters/TestAddCharSetFilter.java
Tomcat
637
49,570
Bug 49570 The CompressionFilter example should support HTTP proxies to cache gzipped content better by sending Vary: Accept-Encoding header
null
2010-07-08 02:11:36
1,278,570,000
resolved fixed
c191152
1,278,780,000
webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java
Tomcat
638
49,503
Bug 49503 Connectors do not bind to their ports in Catalina.load(), but only later in start()
null
2010-06-25 11:22:41
1,277,480,000
resolved fixed
a90b576
1,278,600,000
java/org/apache/catalina/connector/Connector.java
Tomcat
639
49,551
Bug 49551 When setting absolute path to default context.xml, in ContextConfig.contextConfig() it cannot be found
null
2010-07-05 07:41:23
1,278,330,000
resolved fixed
dca6dd1
1,278,360,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
640
49,550
Bug 49550 [PATCH] Response class fix isSpace (deprecated) => isWhiteSpace
null
2010-07-05 07:23:31
1,278,330,000
resolved fixed
7b9630b
1,278,360,000
java/org/apache/catalina/connector/Response.java
Tomcat
641
49,530
Bug 49530 Context is not correctly stopped at shutdown
null
2010-06-30 10:08:43
1,277,910,000
resolved fixed
3bd4bcb
1,278,090,000
java/org/apache/catalina/core/ContainerBase.java
Tomcat
642
49,536
Bug 49536 If no webapps deployed, accessing a URL returns 200 OK with no content instead of 404
null
2010-07-01 04:07:11
1,277,970,000
resolved fixed
4e34898
1,278,020,000
java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/MapperListener.java java/org/apache/catalina/connector/Request.java java/org/apache/tomcat/util/http/mapper/Mapper.java
Tomcat
643
49,525
Bug 49525 IE8: Unabled to store data in HttpSession (root context)
Environment: Tomcat 7.0.0 Beta IE8 A simplest webapp only have a test.jsp below: <%=request.getSession().getId()%> this app installed as root context the test.jsp works fine in firefox but when using IE8 there is always a different session id where refresh the test page. BTW: the test.jsp works find in Tomcat 6.x
2010-06-29 22:22:03
1,277,860,000
resolved fixed
0b8a9a8
1,278,010,000
java/org/apache/catalina/core/ApplicationSessionCookieConfig.java
Tomcat
644
49,522
Bug 49522 Complete Server status (status/all) causes stack trace
type Exception report message description The server encountered an internal error () that prevented it from fulfilling this request. exception javax.servlet.ServletException: javax.management.AttributeNotFoundException: Cannot find attribute startTime for org.apache.catalina.deploy.NamingResources@d1c778 org.apache.catalina.manager.StatusManagerServlet.doGet(StatusManagerServlet.java:292) javax.servlet.http.HttpServlet.service(HttpServlet.java:621) javax.servlet.http.HttpServlet.service(HttpServlet.java:722) root cause javax.management.AttributeNotFoundException: Cannot find attribute startTime for org.apache.catalina.deploy.NamingResources@d1c778 org.apache.tomcat.util.modeler.ManagedBean.getGetter(ManagedBean.java:493) org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:180) com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:666) com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638) org.apache.catalina.manager.StatusTransformer.writeContext(StatusTransformer.java:656) org.apache.catalina.manager.StatusTransformer.writeDetailedState(StatusTransformer.java:590) org.apache.catalina.manager.StatusManagerServlet.doGet(StatusManagerServlet.java:287) javax.servlet.http.HttpServlet.service(HttpServlet.java:621) javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
2010-06-29 10:41:51
1,277,820,000
resolved fixed
3c88f07
1,278,010,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
645
49,476
Bug 49476 Cannot expire selected session in Manager webapp
null
2010-06-20 11:47:00
1,277,050,000
resolved fixed
a0159a3
1,277,370,000
java/org/apache/catalina/filters/CsrfPreventionFilter.java java/org/apache/catalina/manager/HTMLManagerServlet.java
Tomcat
646
49,443
Bug 49443 RemoteIpValve : remoteIpHeader vs remoteIPHeader
null
2010-06-15 07:38:37
1,276,600,000
resolved fixed
27091e7
1,276,860,000
java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java
Tomcat
647
49,445
Bug 49445 After session ID is changed on authentication, the session replication does not work.
After r889716, session ID is changed on authentication. (default of changeSessionIdOnAuthentication is true. ) But DeltaManager doesn't notify other cluster nodes. Therefore, non-primary node keeps having old session ID. And, can not replicate of change of session attribute notified by new session ID. The workaround is ... override changeSessionId method, and notify to change session ID. BackupManager is OK. This problem is DeltaManager only. Best regards.
2010-06-16 05:08:02
1,276,680,000
resolved fixed
4f990f1
1,276,690,000
java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/SessionMessage.java java/org/apache/catalina/ha/session/SessionMessageImpl.java
Tomcat
648
49,376
Bug 49376 Minor corrections to info properties.
The static info properties appear to contain legacy packages.
2010-06-03 07:33:13
1,275,560,000
resolved fixed
e119b5b
1,275,860,000
java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java java/org/apache/catalina/ha/session/ClusterSessionListener.java
Tomcat
649
48,971
Bug 48971 memory leak protection : stopping TimeThreads should be optional and disabled by default
null
2010-03-23 22:56:08
1,269,400,000
resolved fixed
ac8a5ba
1,275,410,000
java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/loader/WebappClassLoader.java java/org/apache/catalina/loader/WebappLoader.java
Tomcat
650
49,360
Bug 49360 Context class reload fails for PersistentManager
On context class reload tomcat fails with LifecycleException: An invalid Lifecycle transition was attempted ([before_start]) for component [org.apache.catalina.session.PersistentManager[/xxx]] in state [DESTROYED]
2010-05-29 17:45:06
1,275,170,000
resolved fixed
ac22dd8
1,275,330,000
java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/session/PersistentManagerBase.java
Tomcat
651
49,340
Bug 49340 Webapp unavailable after deploy then stop then start
Occurs with tomcat 7.0 RC3 but not with 6.0.26 Using the manager/html : - deploy a war - test one of its page, it should be deployed properly - stop the webapp - start the webapp - test one of its page : FAILURE : tomcat returns a 404. Notes : - if using "reload" instead of stop/start it's OK, but it does not fix the unavailability - if the webapp is present when tomcat is started, then the stop/start works normally - The work around is to undeploy the webapp and redeploy it.
2010-05-25 17:45:19
1,274,820,000
resolved fixed
0f669e3
1,275,080,000
java/org/apache/catalina/connector/MapperListener.java
Tomcat
652
49,299
Bug 49299 Servlet 3.0 ch.7.1.1 says that custom cookie name affects URL rewriting
null
2010-05-15 17:38:08
1,273,960,000
resolved fixed
9369636
1,274,050,000
java/org/apache/catalina/Globals.java java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/Request.java java/org/apache/catalina/connector/Response.java java/org/apache/catalina/core/ApplicationSessionCookieConfig.java java/org/apache/catalina/realm/RealmBase.java test/org/apache/catalina/connector/TestCoyoteAdaptor.java
Tomcat
653
49,290
Bug 49290 Using a JarScanner with scanAllDirectories=true causes Tomcat 7 not to start
null
2010-05-14 10:26:11
1,273,850,000
resolved fixed
a7b96d0
1,273,960,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
654
49,221
Bug 49221 javax.servlet.http.Cookie.setDomain uses default charset
javax.servlet.http.Cookie.setDomain(String pattern) has the following code: domain = pattern.toLowerCase(); The result of this depends on the default Locale; it would be safer to use a fixed locale, e.g. Local.ENGLISH.
2010-04-29 09:40:27
1,272,550,000
resolved fixed
05810ee
1,273,660,000
java/javax/servlet/http/Cookie.java
Tomcat
655
49,224
Bug 49224 NullPointerException in PooledConnection when username or password are null
I'm using jdbc-pool (version 1.0.8.5) to connect to a DataSource requiring no authentication. Unless I explicitly set the username and password in the PoolProperties object to empty String (as opposed to leaving them null), a NullPointerException is thrown on lines 215 or 216 of PooledConnection.connectUsingDriver().
2010-04-29 11:15:49
1,272,550,000
resolved fixed
4fff6c0
1,273,660,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Tomcat
656
49,226
Bug 49226 toLowerCase()/toUpperCase() may not work OK in all Locales
null
2010-04-29 11:29:18
1,272,560,000
resolved fixed
5ad9ecd
1,273,610,000
java/org/apache/catalina/core/ApplicationPart.java java/org/apache/catalina/core/StandardEngine.java java/org/apache/catalina/core/StandardHost.java java/org/apache/catalina/deploy/FilterMap.java java/org/apache/catalina/manager/HTMLManagerServlet.java java/org/apache/catalina/manager/util/SessionUtils.java java/org/apache/catalina/servlets/CGIServlet.java java/org/apache/catalina/servlets/WebdavServlet.java java/org/apache/catalina/ssi/ResponseIncludeWrapper.java java/org/apache/catalina/ssi/SSIMediator.java java/org/apache/catalina/ssi/SSIProcessor.java java/org/apache/catalina/ssi/SSIServlet.java java/org/apache/catalina/ssi/SSIServletExternalResolver.java java/org/apache/catalina/startup/ClassLoaderFactory.java java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/HostConfig.java java/org/apache/catalina/util/ExtensionValidator.java java/org/apache/catalina/util/MIME2Java.java java/org/apache/tomcat/util/buf/MessageBytes.java java/org/apache/tomcat/util/http/AcceptLanguage.java java/org/apache/tomcat/util/http/fileupload/FileItemHeadersImpl.java java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java java/org/apache/tomcat/util/http/fileupload/ParameterParser.java java/org/apache/tomcat/util/http/fileupload/ServletFileUpload.java java/org/apache/tomcat/util/modeler/OperationInfo.java java/org/apache/tomcat/util/net/URL.java java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java webapps/examples/WEB-INF/classes/examples/ShowSource.java webapps/examples/WEB-INF/classes/jsp2/examples/el/Functions.java
Tomcat
657
49,227
Bug 49227 toLowerCase()/toUpperCase() may not work OK in all Locales
null
2010-04-29 11:30:31
1,272,560,000
resolved fixed
09abffb
1,273,610,000
java/org/apache/coyote/http11/Http11AprProcessor.java java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/coyote/http11/Http11Processor.java
Tomcat
658
49,228
Bug 49228 toLowerCase()/toUpperCase() may not work OK in all Locales
null
2010-04-29 11:31:40
1,272,560,000
resolved fixed
a954806
1,273,590,000
java/org/apache/jasper/compiler/Validator.java java/org/apache/jasper/tagplugins/jstl/Util.java
Tomcat
659
49,235
Bug 49235 ServletContainerInitializer onStartup(Set<Class<?>> classSet is not expect class
null
2010-04-30 03:08:29
1,272,610,000
resolved fixed
4a581aa
1,273,590,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
660
49,240
Bug 49240 Error thrown during detection of ServletContainerInitializer's
ContextConfig.checkHandlesTypes() throws a NoClassDefFoundError, which isn't caught, when the class being analysed is initialised if the class, or a class that it references(?), is not present in the classpath. E.g. When a mysql connector/j jar (v5.x) is scanned, an attempt to load the following class occurs: com.mchange.v2.c3p0.QueryConnectionTester java.lang.NoClassDefFoundError: com/mchange/v2/c3p0/QueryConnectionTester at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:698) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) at java.net.URLClassLoader.access$000(URLClassLoader.java:56) at java.net.URLClassLoader$1.run(URLClassLoader.java:195) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:188) at java.lang.ClassLoader.loadClass(ClassLoader.java:315) at java.lang.ClassLoader.loadClass(ClassLoader.java:250) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:398) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:247) Also Class.forName is used here, referencing the WebappClassLoader, instead of calling WebappClassLoader.loadClass() directly.
2010-05-01 07:46:16
1,272,710,000
resolved fixed
f24ed2d
1,273,570,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
661
49,269
Bug 49269 Shouldn't see maxIdle > maxActive message with default props
In PoolProperties, the default value for maxIdle is Integer.MAX_VALUE and the default for maxActive is 100. This results in a warning message being logged and the value for maxIdle set to match maxActive on lines 393/394 of ConnectionPool. The default for maxIdle should match that of maxActive.
2010-05-10 14:32:07
1,273,520,000
resolved fixed
27a3909
1,273,560,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Tomcat
662
49,241
Bug 49241 DataSourceFactory.parsePoolProperties() doesn't look for "suspectTimeout"
If you call the DataSourceFactory.parsePoolProperties() method, passing in a Properties object with the "suspectTimeout" property set, that key/value pair is never passed on to the PoolProperties.setSuspectTimeout() method.
2010-05-01 21:01:46
1,272,760,000
resolved fixed
b75b021
1,272,910,000
modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java
Tomcat
663
49,092
Bug 49092 util.IntrospectionUtils.PATH_SEPARATOR should be final
The field org.apache.tomcat.util.IntrospectionUtils.PATH_SEPARATOR should be final.
2010-04-11 22:37:12
1,271,040,000
resolved fixed
616bd68
1,272,730,000
test/org/apache/catalina/tribes/demos/IntrospectionUtils.java
Tomcat
664
49,207
Bug 49207 Filter name not set when dynamically added
When dynamically adding a Filter the name is not set when calling the method "addMappingForUrlPatterns" in ApplicationFilterRegistration.java. java.lang.IllegalArgumentException: Filter mapping specifies an unknown filter name null at org.apache.catalina.core.StandardContext.validateFilterMap(StandardContext.java:2650) at org.apache.catalina.core.StandardContext.addFilterMapBefore(StandardContext.java:2622) at org.apache.catalina.core.ApplicationFilterRegistration.addMappingForUrlPatterns(ApplicationFilterRegistration.java:102) at org.pidster.tomcat.test7.dyn.TestDynamicsListener.contextInitialized(TestDynamicsListener.java:105)
2010-04-28 05:40:52
1,272,450,000
resolved fixed
3396917
1,272,470,000
java/org/apache/catalina/core/ApplicationFilterRegistration.java
Tomcat
665
49,184
Bug 49184 Index out of bounds exception thrown when dynamically adding Filter
When dynamically adding a filter to a context an exception is thrown. java.lang.ArrayIndexOutOfBoundsException at java.lang.System.arraycopy(Native Method) at org.apache.catalina.core.StandardContext.addFilterMapBefore(StandardContext.java:2629) at org.apache.catalina.core.ApplicationFilterRegistration.addMappingForServletNames(ApplicationFilterRegistration.java:75)
2010-04-25 08:54:34
1,272,200,000
resolved fixed
3f4a241
1,272,270,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
666
48,689
Bug 48689 Jar abstraction for Jasper
Jasper can load TLD files through the ServletContext or from a Jar file. To load TLDs from Jar file, an URL to a Jar file must be passed. However, in some environments (e.g. in OSGi) it might not be easy to provide an URL to a jar file. It would be nice to abstract the way Jasper is looking up the embedded TLDs so that different ways of looking up TLDs within Jar files or Bundles or whatever could be used.
2010-02-05 12:30:40
1,265,390,000
resolved fixed
efd418b
1,272,200,000
java/org/apache/jasper/JspCompilationContext.java java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java java/org/apache/jasper/compiler/JarResource.java java/org/apache/jasper/compiler/JarURLResource.java java/org/apache/jasper/compiler/JspDocumentParser.java java/org/apache/jasper/compiler/Parser.java java/org/apache/jasper/compiler/ParserController.java java/org/apache/jasper/compiler/TagFileProcessor.java java/org/apache/jasper/compiler/TagLibraryInfoImpl.java java/org/apache/jasper/compiler/TldLocation.java java/org/apache/jasper/compiler/TldLocationsCache.java java/org/apache/jasper/servlet/JspServletWrapper.java
Tomcat
667
49,140
Bug 49140 Inefficient use of keySet() iterator in StandardContext.java
null
2010-04-16 21:14:48
1,271,470,000
resolved fixed
b30fc95
1,272,040,000
java/org/apache/catalina/connector/Request.java java/org/apache/catalina/core/ApplicationHttpRequest.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java java/org/apache/catalina/ha/session/ClusterSessionListener.java java/org/apache/catalina/startup/ContextConfig.java
Tomcat
668
49,143
Bug 49143 Possible incorrect lazy initialisations
Incorrect lazy initialization of static field: org.apache.catalina.realm.RealmBase.md5Helper org.apache.catalina.session.StandardSession.sessionContext org.apache.catalina.startup.TldConfig.noTldJars org.apache.catalina.util.ExtensionValidator.containerAvailableExtensions org.apache.tomcat.util.modeler.modules.MbeansDescriptorsDigesterSource.digester fields should probably all be made volatile
2010-04-16 21:44:52
1,271,470,000
resolved fixed
a6092d7
1,272,030,000
java/org/apache/catalina/realm/RealmBase.java java/org/apache/catalina/session/StandardSession.java java/org/apache/catalina/startup/TldConfig.java java/org/apache/catalina/util/ExtensionValidator.java java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDigesterSource.java
Tomcat
669
49,144
Bug 49144 Incorrect lazy initialization and update of static fields?
Incorrect lazy initialization and update of static fields: org.apache.catalina.startup.Bootstrap.daemon org.apache.catalina.startup.ContextConfig.contextDigester Findbugs says: This method contains an unsynchronized lazy initialization of a static field. After the field is set, the object stored into that location is further updated or accessed. The setting of the field is visible to other threads as soon as it is set. If the futher accesses in the method that set the field serve to initialize the object, then you have a very serious multithreading bug, unless something else prevents any other thread from accessing the stored object until it is fully initialized. Even if you feel confident that the method is never called by multiple threads, it might be better to not set the static field until the value you are setting it to is fully populated/initialized.
2010-04-16 21:47:20
1,271,470,000
resolved fixed
fd7ed83
1,272,030,000
java/org/apache/catalina/startup/Bootstrap.java
Tomcat
670
49,164
Bug 49164 junit test ignores failures in threads
null
2010-04-21 14:08:24
1,271,870,000
resolved fixed
aa758d8
1,272,030,000
test/org/apache/catalina/tribes/test/interceptors/TestOrderInterceptor.java
Tomcat
671
49,171
Bug 49171 Avoid raw type warning in TagSupport
null
2010-04-22 07:10:06
1,271,930,000
resolved fixed
8bd4d7a
1,272,030,000
java/javax/servlet/jsp/tagext/TagSupport.java
Tomcat
672
49,170
Bug 49170 Transmission of duplicated session in DeltaManager#handleGET_ALL_SESSIONS.
null
2010-04-22 06:54:01
1,271,930,000
resolved fixed
f61100d
1,271,930,000
java/org/apache/catalina/ha/session/DeltaManager.java
Tomcat
673
43,642
Bug 43642 Add prestartminSpareThreads attribute for Executor
The attached patch adds the boolean attribute prestartminSpareThreads to the Executor element. This allows the admin to prestart minspareThreads for this Executor during the start of Tomcat. The default value is false which is the old behaviour. A documentation patch for executor.xml can be created if there is interest in committing this patch.
2007-10-17 08:00:46
1,192,620,000
resolved fixed
e7fb8fa
1,271,850,000
java/org/apache/catalina/core/StandardThreadExecutor.java
Tomcat
674
49,141
Bug 49141 Impossible cast in naming.factory.SendMailFactory.getObjectInstance
naming.factory.SendMailFactory.getObjectInstance contains an impossible cast from javax.mail.internet.MimeMessage to javax.mail.internet.MimePart [Findbugs]
2010-04-16 21:21:03
1,271,470,000
resolved fixed
7205c74
1,271,790,000
java/javax/mail/internet/MimeMessage.java
Tomcat
675
49,151
Bug 49151 ClassCastException in BackupManager#stopInternal.
In BackupManager#startInternal, When constructor of LazyReplicatedMap throws exception, sessions is not LazyReplicatedMap. Actually, AbstractReplicatedMap#init has the possibility of throwing RuntimeException. In BackupManager#stopInternal ClassCastException is thrown because AbstractReplicatedMap#breakdown is executed regardless of the type of sessions. should be changed as follows to avoid ClassCastException. === skip. if (sessions instanceof LazyReplicatedMap) { LazyReplicatedMap map = (LazyReplicatedMap)sessions; if ( map!=null ) { map.breakdown(); } } skip. === This problem exists in Tomcat7.0 and 6.0. Best Regards.
2010-04-19 05:02:32
1,271,670,000
resolved fixed
fcb9861
1,271,670,000
java/org/apache/catalina/ha/session/BackupManager.java
Tomcat
676
49,150
Bug 49150 All primary sessions are deleted at BackupManager#stopInternal.
BackupManager#stopInternal is as follows. ===== protected synchronized void stopInternal() throws LifecycleException { super.stopInternal(); LazyReplicatedMap map = (LazyReplicatedMap)sessions; if ( map!=null ) { map.breakdown(); } cluster.removeManager(this); } ===== In Tomcat 7.0.0 RC1, super#stopInternal() is called first. In StandardManager#stopInternal() of the super class, The session is stored, and expire all active sessions. Storing session is unnecessary in BackupManager. and When the session expired, the session is deleted from all cluster nodes. As a Result, All primary sessions (of own node has) are deleted from all cluster nodes. For instance, Node1 : sessionA(primary), sessionB(proxy), sessionC(backup) Node2 : sessionA(backup), sessionB(primary), sessionC(proxy) Node3 : sessionA(proxy), sessionB(backup), sessionC(primary) If Node1 is stopped, it becomes the following. Node1 : stopped Node2 : sessionB(primary), sessionC(backup) Node3 : sessionB(backup), sessionC(primary) sessionA is expired. It should be the following. Node1 : stopped Node2 : sessionA(primary), sessionB(primary), sessionC(backup) Node3 : sessionA(backup), sessionB(backup), sessionC(primary) There is no problem in Tomcat6.0.x, because it executes super.stop() after LazyReplicatedMap#breakdown() . I made a patch against trunk. Best Regards.
2010-04-19 03:37:08
1,271,660,000
resolved fixed
09f4e25
1,271,670,000
java/org/apache/catalina/ha/session/BackupManager.java
Tomcat
677
49,129
Bug 49129 DigestAuthenticator.md5Helper - possible incorrect lazy initialisation
Findbugs says: "This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem."
2010-04-14 19:09:31
1,271,290,000
resolved fixed
867605f
1,271,290,000
java/org/apache/catalina/authenticator/DigestAuthenticator.java
Tomcat
678
49,118
Bug 49118 Inefficient use of String concatenation in loop
null
2010-04-14 05:40:15
1,271,240,000
resolved fixed
95a2eb8
1,271,290,000
java/javax/servlet/http/HttpServlet.java
Tomcat
679
49,110
Bug 49110 runtime.JspFactoryImpl$PageContextPool needs to be static
Findbugs says: Bug: org.apache.jasper.runtime.JspFactoryImpl$PageContextPool needs to be _static_ to avoid a deadly embrace with org.apache.jasper.runtime.JspFactoryImpl.localPool Pattern id: SIC_THREADLOCAL_DEADLY_EMBRACE, type: SIC, category: CORRECTNESS This class is an inner class, but should probably be a static inner class. As it is, there is a serious danger of a deadly embrace between the inner class and the thread local in the outer class. Because the inner class isn't static, it retains a reference to the outer class. If the thread local contains a reference to an instance of the inner class, the inner and outer instance will both be reachable and not eligible for garbage collection.
2010-04-12 19:50:48
1,271,120,000
resolved fixed
b027259
1,271,290,000
java/org/apache/jasper/runtime/JspFactoryImpl.java
Tomcat
680
49,109
Bug 49109 RealmBase.authenticate uses toString on byte array
catalina.realm.RealmBase.authenticate(String username, byte[] credentials) has the following code: return (authenticate(username, credentials.toString())); This looks wrong, as credentials is a byte array. It should probably be: return (authenticate(username, new String(credentials[,charset])));
2010-04-12 19:36:53
1,271,120,000
resolved fixed
bcf0a01
1,271,280,000
java/org/apache/catalina/Realm.java java/org/apache/catalina/realm/CombinedRealm.java java/org/apache/catalina/realm/LockOutRealm.java java/org/apache/catalina/realm/RealmBase.java
Tomcat
681
49,106
Bug 49106 Unused imports
null
2010-04-12 19:01:41
1,271,110,000
resolved fixed
f8d3565
1,271,280,000
java/org/apache/catalina/realm/JNDIRealm.java
Tomcat
682
49,105
Bug 49105 Javadoc corrections
null
2010-04-12 19:00:58
1,271,110,000
resolved fixed
ead3997
1,271,280,000
java/javax/el/ExpressionFactory.java java/javax/servlet/HttpConstraintElement.java java/javax/servlet/ServletContext.java java/org/apache/catalina/Context.java java/org/apache/catalina/Host.java java/org/apache/catalina/Lifecycle.java java/org/apache/catalina/Session.java java/org/apache/catalina/authenticator/FormAuthenticator.java java/org/apache/catalina/connector/Request.java java/org/apache/catalina/core/ApplicationSessionCookieConfig.java java/org/apache/catalina/core/ContainerBase.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/session/StandardSession.java java/org/apache/catalina/tribes/ChannelListener.java java/org/apache/catalina/tribes/group/RpcChannel.java java/org/apache/el/parser/AstValue.java java/org/apache/jasper/compiler/Node.java webapps/examples/WEB-INF/classes/chat/ChatServlet.java webapps/examples/WEB-INF/classes/filters/ExampleFilter.java webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java
Tomcat
683
49,104
Bug 49104 Fix up some raw types
null
2010-04-12 18:59:00
1,271,110,000
resolved fixed
5be4f29
1,271,280,000
java/org/apache/coyote/ajp/AjpProtocol.java java/org/apache/coyote/http11/Http11Protocol.java java/org/apache/tomcat/util/net/JIoEndpoint.java
Tomcat
684
49,103
Bug 49103 Missing annotations
null
2010-04-12 18:57:56
1,271,110,000
resolved fixed
1018cd7
1,271,280,000
java/org/apache/coyote/http11/Http11NioProtocol.java java/org/apache/coyote/http11/Http11Protocol.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
Tomcat
685
49,045
Bug 49045 JMX Enhancement- Provision of MBeanFactory createStandardService
Currently MBeanFactory doesn't have a method for creating a new StandardService MBean. This would become an issue for future enhancements of JMX support in Tomcat. As per discussions with Mark, this enhancement is suggested as a starting point for possible future enhancements in JMX support.
2010-04-04 05:40:57
1,270,370,000
resolved fixed
32046eb
1,271,250,000
java/org/apache/catalina/mbeans/MBeanFactory.java
Tomcat
686
49,089
Bug 49089 ChannelData.USE_SECURE_RANDOM_FOR_UUID public static mutable field
catalina.tribes.io.ChannelData.USE_SECURE_RANDOM_FOR_UUID is a mutable public static field. It's only used by an instance method, so there's no need for it to be static. Probably no need for it to be public either; it could be a private field with a setter - or better a final field set by the constructor.
2010-04-11 22:24:38
1,271,040,000
resolved fixed
cb0b029
1,271,240,000
java/org/apache/catalina/tribes/io/ChannelData.java
Tomcat
687
49,116
Bug 49116 Memory leak by HttpSession.
When session is stored in StandardManager#doUnload method, an invalid session is stored. For instance, If HttpSession#invalidate is executed while executing StandardManager#doUnload, session of "isValid=false" is stored. The session of isValid=false is restored in StandardManager#doLoad, and it registers in session map (sessions). However, no one can invalidate this session. If isValid is false, StandardSession#invalidate() and StandardSession#isValid() can not expire session. They are throws IllegalStateException or return immediately. Consequently, the session of isValid=false is never deleted from the session map(sessions). I made a patch. If session is already invalid, expire session to prevent memory leak. Best Regards. Keiichi.
2010-04-14 04:43:30
1,271,230,000
resolved fixed
bddfc0a
1,271,230,000
java/org/apache/catalina/session/StandardManager.java
Tomcat
688
49,086
Bug 49086 Addition of Javadoc for Servlet 3.0 annotations
null
2010-04-11 16:43:49
1,271,020,000
resolved fixed
6fc4360
1,271,070,000
java/javax/servlet/annotation/HandlesTypes.java java/javax/servlet/annotation/HttpConstraint.java java/javax/servlet/annotation/HttpMethodConstraint.java java/javax/servlet/annotation/MultipartConfig.java java/javax/servlet/annotation/ServletSecurity.java java/javax/servlet/annotation/WebFilter.java java/javax/servlet/annotation/WebInitParam.java java/javax/servlet/annotation/WebListener.java java/javax/servlet/annotation/WebServlet.java
Tomcat
689
49,091
Bug 49091 Util.specialCharactersRepresentation should be private
jasper.tagplugins.jstl.Util.specialCharactersRepresentation is a mutable public static array; it is not used outside the class as far as I can tell and so should be made private
2010-04-11 22:31:35
1,271,040,000
resolved fixed
1ecfaa9
1,271,070,000
java/org/apache/jasper/tagplugins/jstl/Util.java
Tomcat
690
49,075
Bug 49075 protected Class User doesn't check argument roles for null
null
2010-04-08 18:15:55
1,270,760,000
resolved fixed
e59ba8f
1,270,810,000
java/org/apache/catalina/realm/JNDIRealm.java
Tomcat
691
49,018
Bug 49018 Timeout argument misprocessed when expiring sessions from Tomcat Manager
Steps to reproduce: 1. Login to the Tomcat Manager Application 2. Select a web application that has several sessions that are inactive for more than 2 minutes 3. In the text field next to the "Expire sessions" button print "2" 4. Press "Expire sessions" 5. Sample observed result: OK - Session information for application at context path /myapp Default maximum session inactive interval 30 minutes <1 minutes:16 sessions 1 - <2 minutes:2 sessions 2 - <3 minutes:5 sessions 3 - <4 minutes:1 sessions 4 - <5 minutes:2 sessions 5 - <6 minutes:1 sessions 6 - <7 minutes:2 sessions 9 - <10 minutes:1 sessions 8 minutes:expired 0 sessions Actually some sessions were expired (even if the above message prints "0"). Expected result: All sessions with idle time > 2 minutes had to be expired. The bug is in the following lines of ManagerServlet#sessions(PrintWriter, String, int): Lines 1176-1179 if (idle >= 0 && time >= idle*60) { sessions[i].expire(); idle++; } The patch would be to replace "idle++" with "expired++", because "idle" is the time (in minutes) as submitted from the web form and "expired" is the counter.
2010-03-29 15:18:35
1,269,890,000
resolved fixed
155e3f8
1,270,610,000
java/org/apache/catalina/manager/ManagerServlet.java
Tomcat
692
48,648
Bug 48648 Blank page (dropped connection) when running TC7 with TCnative (APR)
null
2010-01-31 17:58:11
1,264,980,000
resolved fixed
216352a
1,270,400,000
java/org/apache/tomcat/util/net/AprEndpoint.java
Tomcat
693
49,014
Bug 49014 Add RemoteIpFilter test case
null
2010-03-29 00:17:51
1,269,840,000
resolved fixed
d9330a9
1,270,380,000
test/org/apache/catalina/filters/TestRemoteIpFilter.java
Tomcat
694
48,983
Bug 48983 Enhance RemoteIpValve and RemoteIpFilter logging
null
2010-03-24 23:15:14
1,269,490,000
resolved fixed
9a42719
1,270,380,000
java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java
Tomcat
695
48,895
Bug 48895 WebAppClassLoader.clearThreadLocalMap() concurrency issues
I think that the memory leak protection of WebAppClassLoader.clearReferencesThreadLocals() which detects and clears ThreadLocals that would prevent GC the WebAppClassLoader instance has issues regarding concurrency : - It enumerates Threads and looks into internal structures of the Thread class, but there are no "memory barrier" that would ensure a consistent state of the ThreadLocalMap being examined. So, it is theoretically possible that a ThreadLocal in Thread A was properly cleaned up by the application, but the current thread B (that is undeploying the application) does not see the up to date state because there's no synchronization between those threads. - Much more severe : after detecting such a leak, it invokes java.lang.ThreadLocal.ThreadLocalMap.remove(ThreadLocal) on Thread A's ThreadLocalMap instance but the invocation is done by Thread B (the thread that undeploys the app). The remove() method is not thread safe at all, and nor is the expungeStaleEntries() method which may also be invoked in clearThreadLocalMap(). So, if a webapp is being undeployed while other applications continue to receive a heavy load of requests, this could corrupt the internal structures of the ThreadLocalMap instance ! I propose to keep the detection of leaks as it is, but to make the actual clearing optional (and disabled by default) to avoid encountering big problems in production. Idea to improve the clearing in a safe way : if the thread that is "provoking" the leak is one of tomcat's worker threads, we could mark it as "dirty", and then have a background task that would end such threads (renew those threads in the pool).
2010-03-11 22:20:01
1,268,360,000
resolved fixed
ae6fcf5
1,269,870,000
java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/loader/WebappClassLoader.java java/org/apache/catalina/loader/WebappLoader.java
Tomcat
696
48,717
Bug 48717 Session listeners not called on cluster node start
null
2010-02-09 17:43:14
1,265,760,000
resolved fixed
39d3082
1,269,800,000
java/org/apache/catalina/ha/session/DeltaManager.java
Tomcat
697
48,662
Bug 48662 context.xml expansion on deployment improvements
Two parts: 1. Log a warning/info message if Tomcat ignores a bundled context.xml in favour of one in CATALINA_BASE/<engine name>/<host name> 2. Make the extraction/copying of context.xml configurable, probably via a new attribute extractXml on the host
2010-02-02 22:44:07
1,265,170,000
resolved fixed
83226d9
1,269,780,000
java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/StandardHost.java java/org/apache/catalina/mbeans/MBeanFactory.java java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/HostConfig.java
Tomcat
698
48,934
Bug 48934 Cluster's regression. When replication fails once, replication can be never done again.
null
2010-03-18 11:09:23
1,268,920,000
resolved fixed
fc66705
1,268,920,000
java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java java/org/apache/catalina/tribes/transport/nio/PooledParallelSender.java
Tomcat
699
44,265
Bug 44265 Improve JspWriterImpl performance with "inline" sub method
As you know, the JspWriterImpl.write method was always invoked in JSP file frequently. But I found its performance is poor because too many sub method were invoked as well. After copying two sub method's code to write method, the performance was improved observably.
2008-01-18 02:51:47
1,200,640,000
resolved fixed
9113574
1,268,330,000
java/org/apache/jasper/runtime/JspWriterImpl.java
Tomcat
700
48,760
Bug 48760 Tomcat breaks in serving large files (>=1.8MB) under high load and high threading.
null
2010-02-17 20:44:37
1,266,460,000
resolved fixed
f1760d8
1,268,140,000
java/org/apache/naming/resources/FileDirContext.java java/org/apache/naming/resources/WARDirContext.java
Tomcat
701
48,737
Bug 48737 JspCompilationContext assumes that tagfile with a path starting with META-INF are in jars without checking
null
2010-02-13 18:19:03
1,266,100,000
resolved fixed
6ac5036
1,268,140,000
java/org/apache/jasper/JspCompilationContext.java
Tomcat
702
48,729
Bug 48729 JNDIRealm.java not parsing roles correctly
null
2010-02-11 17:27:55
1,265,930,000
resolved fixed
4cf35b8
1,268,140,000
java/org/apache/catalina/realm/JNDIRealm.java
Tomcat
703
48,661
Bug 48661 inconsistent error page behavior
There seems to be a bug or at least an inconsistency in how tomcat handles the error page. In Tomcat 6.0.20, if I define my error page like this in web.xml: <error-page> <exception-type>java.lang.Exception</exception-type> <location>/unexpectedErrors.jsp</location> </error-page> Then, if the response has already been committed, Tomcat does this on the system console: Feb 1, 2010 5:59:04 PM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Servlet.service() for servlet jsp threw exception java.lang.NullPointerException at org.apache.jsp.cpe_jsp._jspService(cpe_jsp.java:693) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at com.eaglecreektech.expedience.provisioning.web.servletFilters.AuthFilter.doFilter(AuthFilter.java:133) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at com.eaglecreektech.expedience.provisioning.web.servletFilters.RequestVolumeFilter.doFilter(RequestVolumeFilter.java:141) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at com.eaglecreektech.expedience.provisioning.web.servletFilters.StartupCheckFilter.doFilter(StartupCheckFilter.java:65) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Thread.java:619) Feb 1, 2010 5:59:04 PM org.apache.catalina.core.StandardHostValve custom SEVERE: Exception Processing ErrorPage[exceptionType=java.lang.Exception, location=/unexpectedErrors.jsp] java.lang.IllegalStateException: Cannot reset buffer after response has been committed at org.apache.catalina.connector.Response.resetBuffer(Response.java:691) at org.apache.catalina.core.StandardHostValve.custom(StandardHostValve.java:409) at org.apache.catalina.core.StandardHostValve.throwable(StandardHostValve.java:271) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:142) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Thread.java:619) And it doesn't put any error text into the broken page - the page just shows how ever far it got before it encountered the error. This behavior doesn't seem correct - it seems like it should at least behave the same way as it does when the error page is defined in a jsp page: <%@ page errorPage="unexpectedErrors.jsp" %> If the response has already been committed, then it just appends the error page onto the end of the response (not ideal, but nothing else can be done, as far as I know) If the response has not been committed, it clears the buffer and writes the error page (which looks nice and pretty , like it should) I'd suggest that the error handling code for the error page as defined in web.xml should check if the response has been committed, and not try to clear the buffer if it is already committed - just append to the end, the same way that the jsp error handler does.
2010-02-02 15:07:25
1,265,140,000
resolved fixed
1ec5ca7
1,268,070,000
java/org/apache/catalina/core/StandardHostValve.java
Tomcat
704
48,582
Bug 48582 JspServletWrapper.getServletContext() throws NullPointerException
null
2010-01-20 13:25:03
1,264,010,000
resolved fixed
7301a10
1,266,320,000
java/org/apache/jasper/servlet/JspServletWrapper.java
Tomcat
705
48,580
Bug 48580 6.0.24: AccessControlException in ProtectedFunctionMapper on first access to certain JSP
null
2010-01-20 11:54:45
1,264,010,000
resolved fixed
9e55819
1,266,310,000
java/org/apache/jasper/security/SecurityClassLoad.java
Tomcat
706
48,498
Bug 48498 6.0.22RC: ArrayIndexOutOfBoundsException from Jasper when compilation error inside a CDATA block
null
2010-01-06 19:40:54
1,262,820,000
resolved fixed
789ac1e
1,266,280,000
java/org/apache/jasper/compiler/JavacErrorDetail.java
Tomcat
707
48,384
Bug 48384 globalXsltFile parameter for the DefaultServlet
When overriding the DefaultServlet for a given application, the globalXsltFile path need to be relative to Tomcat root. for example: <init-param> <param-name>globalXsltFile</param-name> <param-value>webapps/quercus/WEB-INF/listing.xsl</param-value> </init-param> it would be nice if the path could be relative to the application context.
2009-12-13 16:24:30
1,260,740,000
resolved fixed
0e595cf
1,266,090,000
java/org/apache/catalina/servlets/DefaultServlet.java
Tomcat
708
48,371
Bug 48371 addWebXmlMappings does not place servlet tags correctly
If there is a commented-out <security-constraint> or commented-out <servlet> tag and addWebXmlMappings="true", the JSP's servlet and servlet-mapping tags are placed incorrectly and Tomcat will not start due to "--" being inside a comment. Basically, it seems the web.xml is not parsed correctly when using addWebXmlMappings and you cannot have above tags commented out, or new servlet tags will be placed incorrectly and comment tags not respected.
2009-12-10 18:16:34
1,260,490,000
resolved fixed
563e315
1,266,090,000
java/org/apache/jasper/JspC.java
Tomcat
709
48,318
Bug 48318 WebDAV servlet returns 500 if files not readable
If a directory contains a file that is not readable by the Tomcat process (eg file permissions, dangling symlink) then Tomcat throws a NullPointerException and returns a 500 Internal Server Error to the client. Throwing NPE in these circumstances is certainly wrong. Returning 500 with no further information is unhelpful behavior and should be fixed. Generally, interfaces of this type at least list inaccessible files (Windows Explorer, UNIX ls(1), BSD FTP client, ...) and only return an error when one attempts to access such a file. markt suggests an alternative of simply ignoring inaccessible files but notes that "could cause issues if a user tries to upload a file of that name" and suggests better error reporting. Stack: SEVERE: Servlet.service() for servlet webdav threw exception java.lang.NullPointerException at org.apache.catalina.servlets.WebdavServlet.parseProperties(Unknown Source) at org.apache.catalina.servlets.WebdavServlet.doPropfind(Unknown Source) at org.apache.catalina.servlets.WebdavServlet.service(Unknown Source) at javax.servlet.http.HttpServlet.service(Unknown Source) ... Method parseProperties() is in java/org/apache/catalina/servlets/WebdavServlet.java.org and the NPE happens when cacheEntry.attributes is null (case FIND_BY_PROPERTY in my testing and possibly in other cases too). Following the breadcrumbs via: cacheEntry = resources.lookupCache(path); leads eventually to java/org/apache/naming/resources/FileDirContext.java: public Attributes getAttributes(String name, String[] attrIds) throws NamingException { // Building attribute list File file = file(name); if (file == null) throw new NamingException (sm.getString("resources.notFound", name)); ... protected File file(String name) { File file = new File(base, name); if (file.exists() && file.canRead()) { ... // do useful stuff } else { return null; // ouch }
2009-12-01 07:07:07
1,259,670,000
resolved fixed
da42e44
1,266,010,000
java/org/apache/catalina/servlets/WebdavServlet.java
Tomcat