issue_id
int64
2.03k
426k
title
stringlengths
9
251
body
stringlengths
1
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
2
187
file_content
stringlengths
0
368k
17,598
Bug 17598 Source->Generate Getter and Setter enabled for read only file
F1 This action is enabled for read-only files. Executing it shows a dialog saying that the file is read-only. The action should be disabled since all other source actions are disabled as well.
verified fixed
6b03c57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T16:51:22Z
2002-05-24T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/AddGetterSetterAction.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; import java.util.List; import java.util.Map; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.dialogs.CheckedTreeSelectionDialog; import org.eclipse.ui.dialogs.ISelectionStatusValidator; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaElementImageDescriptor; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaElementSorter; import org.eclipse.jdt.internal.corext.codemanipulation.AddGetterSetterOperation; import org.eclipse.jdt.internal.corext.codemanipulation.CodeGenerationSettings; import org.eclipse.jdt.internal.corext.codemanipulation.GetterSetterUtil; import org.eclipse.jdt.internal.corext.codemanipulation.IRequestQuery; import org.eclipse.jdt.internal.corext.codemanipulation.NameProposer; import org.eclipse.jdt.internal.corext.refactoring.util.JavaElementUtil; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.actions.WorkbenchRunnableAdapter; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.preferences.CodeGenerationPreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; /** * Create Getter and Setter for selected fields. * Will open the parent compilation unit in the editor. * The result is unsaved, so the user can decide if the * changes are acceptable. * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class AddGetterSetterAction extends SelectionDispatchAction { private CompilationUnitEditor fEditor; private static final String dialogTitle= ActionMessages.getString("AddGetterSetterAction.error.title"); //$NON-NLS-1$ /** * Creates a new <code>AddGetterSetterAction</code>. * * @param site the site providing context information for this action */ public AddGetterSetterAction(IWorkbenchSite site) { super(site); setText(ActionMessages.getString("AddGetterSetterAction.label")); //$NON-NLS-1$ setDescription(ActionMessages.getString("AddGetterSetterAction.description")); //$NON-NLS-1$ setToolTipText(ActionMessages.getString("AddGetterSetterAction.tooltip")); //$NON-NLS-1$ WorkbenchHelp.setHelp(this, IJavaHelpContextIds.GETTERSETTER_ACTION); } /** * Creates a new <code>AddGetterSetterAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public AddGetterSetterAction(CompilationUnitEditor editor) { this(editor.getEditorSite()); fEditor= editor; } //---- Structured Viewer ----------------------------------------------------------- /* (non-Javadoc) * Method declared on SelectionDispatchAction */ protected void selectionChanged(IStructuredSelection selection) { try { setEnabled(canEnable(selection)); } catch (JavaModelException e) { JavaPlugin.log(e); setEnabled(false); } } /* (non-Javadoc) * Method declared on SelectionDispatchAction */ protected void run(IStructuredSelection selection) { try { IField[] selectedFields= getSelectedFields(selection); if (canEnableOn(selectedFields)){ run(selectedFields[0].getDeclaringType(), selectedFields); return; } Object firstElement= selection.getFirstElement(); if (firstElement instanceof IType) run((IType)firstElement, new IField[0]); else if (firstElement instanceof ICompilationUnit) run(JavaElementUtil.getMainType((ICompilationUnit)firstElement), new IField[0]); } catch (CoreException e) { JavaPlugin.log(e.getStatus()); showError(ActionMessages.getString("AddGetterSetterAction.error.actionfailed")); //$NON-NLS-1$ } } private boolean canEnable(IStructuredSelection selection) throws JavaModelException{ if (canEnableOn(getSelectedFields(selection))) return true; if ((selection.size() == 1) && (selection.getFirstElement() instanceof IType)) return canEnableOn((IType)selection.getFirstElement()); if ((selection.size() == 1) && (selection.getFirstElement() instanceof ICompilationUnit)) return canEnableOn(JavaElementUtil.getMainType((ICompilationUnit)selection.getFirstElement())); return false; } private static boolean canEnableOn(IType type) throws JavaModelException { if (type == null) return false; if (type.getFields().length == 0) return false; if (type.getCompilationUnit() == null) return false; if (JavaModelUtil.isEditable(type.getCompilationUnit())) return true; return false; } private static boolean canEnableOn(IField[] fields) throws JavaModelException { return fields != null && fields.length > 0 && JavaModelUtil.isEditable(fields[0].getCompilationUnit()); } private void run(IType type, IField[] preselected) throws CoreException{ ILabelProvider lp= new AddGetterSetterLabelProvider(createNameProposer()); Map entries= createGetterSetterMapping(type); if (entries.isEmpty()){ MessageDialog.openInformation(getShell(), dialogTitle, "The type contains no fields or all fields have getters/setters already."); return; } ITreeContentProvider cp= new AddGetterSetterContentProvider(entries); CheckedTreeSelectionDialog dialog= new CheckedTreeSelectionDialog(getShell(), lp, cp); dialog.setSorter(new JavaElementSorter()); dialog.setTitle(dialogTitle); String message= ActionMessages.getFormattedString("AddGetterSetterAction.dialog.title", JavaElementUtil.createSignature(type));//$NON-NLS-1$ dialog.setMessage(message); dialog.setValidator(createValidator()); dialog.setContainerMode(true); dialog.setSize(60, 18); dialog.setInput(type); dialog.setExpandedElements(type.getFields()); dialog.setInitialSelections(preselected); dialog.open(); Object[] result= dialog.getResult(); if (result == null) return; IField[] getterFields= getGetterFields(result); IField[] setterFields= getSetterFields(result); generate(getterFields, setterFields); } private static ISelectionStatusValidator createValidator() { return new ISelectionStatusValidator(){ public IStatus validate(Object[] selection) { int count= countSelectedMethods(selection); if (count == 0) return new StatusInfo(IStatus.ERROR, ""); //$NON-NLS-1$ if (count == 1) return new StatusInfo(IStatus.INFO, ActionMessages.getString("AddGetterSetterAction.one_selected")); //$NON-NLS-1$ String message= ActionMessages.getFormattedString("AddGetterSetterAction.methods_selected", String.valueOf(count));//$NON-NLS-1$ return new StatusInfo(IStatus.INFO, message); } }; } private static int countSelectedMethods(Object[] selection){ int count= 0; for (int i = 0; i < selection.length; i++) { if (selection[i] instanceof GetterSetterEntry) count++; } return count; } private static IField[] getGetterFields(Object[] result){ Collection list= new ArrayList(0); for (int i = 0; i < result.length; i++) { Object each= result[i]; if ((each instanceof GetterSetterEntry)){ GetterSetterEntry entry= (GetterSetterEntry)each; if (entry.isGetterEntry) list.add(entry.field); } } return (IField[]) list.toArray(new IField[list.size()]); } private static IField[] getSetterFields(Object[] result){ Collection list= new ArrayList(0); for (int i = 0; i < result.length; i++) { Object each= result[i]; if ((each instanceof GetterSetterEntry)){ GetterSetterEntry entry= (GetterSetterEntry)each; if (! entry.isGetterEntry) list.add(entry.field); } } return (IField[]) list.toArray(new IField[list.size()]); } private static NameProposer createNameProposer(){ return new NameProposer(getGetterSetterPrefixes(), getGetterSetterSuffixes()); } private static String[] getGetterSetterPrefixes(){ return CodeGenerationPreferencePage.getGetterStetterPrefixes(); } private static String[] getGetterSetterSuffixes(){ return CodeGenerationPreferencePage.getGetterStetterSuffixes(); } private void generate(IField[] getterFields, IField[] setterFields) throws CoreException{ if (getterFields.length == 0 && setterFields.length == 0) return; ICompilationUnit cu= null; if (getterFields.length != 0) cu= getterFields[0].getCompilationUnit(); else cu= setterFields[0].getCompilationUnit(); //open the editor, forces the creation of a working copy IEditorPart editor= EditorUtility.openInEditor(cu); IField[] workingCopyGetterFields= getWorkingCopyFields(getterFields); IField[] workingCopySetterFields= getWorkingCopyFields(setterFields); if (workingCopyGetterFields != null && workingCopySetterFields != null) run(workingCopyGetterFields, workingCopySetterFields, editor); } private IField[] getWorkingCopyFields(IField[] fields) throws CoreException{ if (fields.length == 0) return new IField[0]; ICompilationUnit cu= fields[0].getCompilationUnit(); ICompilationUnit workingCopyCU; IField[] workingCopyFields; if (cu.isWorkingCopy()) { workingCopyCU= cu; workingCopyFields= fields; } else { workingCopyCU= EditorUtility.getWorkingCopy(cu); if (workingCopyCU == null) { showError(ActionMessages.getString("AddGetterSetterAction.error.actionfailed")); //$NON-NLS-1$ return null; } workingCopyFields= new IField[fields.length]; for (int i= 0; i < fields.length; i++) { IField field= fields[i]; IField workingCopyField= (IField) JavaModelUtil.findMemberInCompilationUnit(workingCopyCU, field); if (workingCopyField == null) { showError(ActionMessages.getFormattedString("AddGetterSetterAction.error.fieldNotExisting", field.getElementName())); //$NON-NLS-1$ return null; } workingCopyFields[i]= workingCopyField; } } return workingCopyFields; } //---- Java Editior -------------------------------------------------------------- /* (non-Javadoc) * Method declared on SelectionDispatchAction */ protected void selectionChanged(ITextSelection selection) { setEnabled(fEditor != null); } /* (non-Javadoc) * Method declared on SelectionDispatchAction */ protected void run(ITextSelection selection) { try { IJavaElement[] elements= SelectionConverter.codeResolve(fEditor); if (elements.length == 1 && (elements[0] instanceof IField)) { IField field= (IField)elements[0]; if (! checkCu(field)) return; run(field.getDeclaringType(), new IField[] {field}); return; } IJavaElement element= SelectionConverter.getElementAtOffset(fEditor); if (element != null){ IType type= (IType)element.getAncestor(IJavaElement.TYPE); if (type != null){ if (! checkCu(type)) return; //dialog already shown - just return if (type.getFields().length > 0){ run(type, new IField[0]); return; } } } MessageDialog.openInformation(getShell(), dialogTitle, ActionMessages.getString("AddGetterSetterAction.not_applicable")); //$NON-NLS-1$ } catch (CoreException e) { JavaPlugin.log(e.getStatus()); showError(ActionMessages.getString("AddGetterSetterAction.error.actionfailed")); //$NON-NLS-1$ } } private boolean checkCu(IMember member) throws JavaModelException{ if (JavaModelUtil.isEditable(member.getCompilationUnit())) return true; MessageDialog.openInformation(getShell(), dialogTitle, ActionMessages.getFormattedString("AddGetterSetterAction.read_only", member.getElementName())); //$NON-NLS-1$ return false; } //---- Helpers ------------------------------------------------------------------- private void run(IField[] getterFields, IField[] setterFields, IEditorPart editor) { try{ AddGetterSetterOperation op= createAddGetterSetterOperation(getterFields, setterFields); new ProgressMonitorDialog(getShell()).run(false, true, new WorkbenchRunnableAdapter(op)); IMethod[] createdMethods= op.getCreatedAccessors(); if (createdMethods.length > 0) { EditorUtility.revealInEditor(editor, createdMethods[0]); } } catch (InvocationTargetException e) { JavaPlugin.log(e); showError(ActionMessages.getString("AddGetterSetterAction.error.actionfailed")); //$NON-NLS-1$ } catch (InterruptedException e) { // operation cancelled } } private AddGetterSetterOperation createAddGetterSetterOperation(IField[] getterFields, IField[] setterFields) { IRequestQuery skipSetterForFinalQuery= skipSetterForFinalQuery(); IRequestQuery skipReplaceQuery= skipReplaceQuery(); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); return new AddGetterSetterOperation(getterFields, setterFields, createNameProposer(), settings, skipSetterForFinalQuery, skipReplaceQuery); } private IRequestQuery skipSetterForFinalQuery() { return new IRequestQuery() { public int doQuery(IMember field) { int[] returnCodes= {IRequestQuery.YES, IRequestQuery.NO, IRequestQuery.YES_ALL, IRequestQuery.CANCEL}; String[] options= {IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.YES_TO_ALL_LABEL, IDialogConstants.CANCEL_LABEL}; String fieldName= JavaElementLabels.getElementLabel(field, 0); String formattedMessage= ActionMessages.getFormattedString("AddGetterSetterAction.SkipSetterForFinalDialog.message", fieldName); //$NON-NLS-1$ return showQueryDialog(formattedMessage, options, returnCodes); } }; } private IRequestQuery skipReplaceQuery() { return new IRequestQuery() { public int doQuery(IMember method) { int[] returnCodes= {IRequestQuery.YES, IRequestQuery.NO, IRequestQuery.YES_ALL, IRequestQuery.CANCEL}; String skipLabel= ActionMessages.getString("AddGetterSetterAction.SkipExistingDialog.skip.label"); //$NON-NLS-1$ String replaceLabel= ActionMessages.getString("AddGetterSetterAction.SkipExistingDialog.replace.label"); //$NON-NLS-1$ String skipAllLabel= ActionMessages.getString("AddGetterSetterAction.SkipExistingDialog.skipAll.label"); //$NON-NLS-1$ String[] options= { skipLabel, replaceLabel, skipAllLabel, IDialogConstants.CANCEL_LABEL}; String methodName= JavaElementLabels.getElementLabel(method, JavaElementLabels.M_PARAMETER_TYPES); String formattedMessage= ActionMessages.getFormattedString("AddGetterSetterAction.SkipExistingDialog.message", methodName); //$NON-NLS-1$ return showQueryDialog(formattedMessage, options, returnCodes); } }; } private int showQueryDialog(final String message, final String[] buttonLabels, int[] returnCodes) { final Shell shell= getShell(); if (shell == null) { JavaPlugin.logErrorMessage("AddGetterSetterAction.showQueryDialog: No active shell found"); //$NON-NLS-1$ return IRequestQuery.CANCEL; } final int[] result= { MessageDialog.CANCEL }; shell.getDisplay().syncExec(new Runnable() { public void run() { String title= ActionMessages.getString("AddGetterSetterAction.QueryDialog.title"); //$NON-NLS-1$ MessageDialog dialog= new MessageDialog(shell, title, null, message, MessageDialog.QUESTION, buttonLabels, 0); result[0]= dialog.open(); } }); int returnVal= result[0]; return returnVal < 0 ? IRequestQuery.CANCEL : returnCodes[returnVal]; } private void showError(String message) { MessageDialog.openError(getShell(), dialogTitle, message); } /* * Returns fields in the selection or <code>null</code> if the selection is * empty or not valid. */ private IField[] getSelectedFields(IStructuredSelection selection) { List elements= selection.toList(); int nElements= elements.size(); if (nElements > 0) { IField[] res= new IField[nElements]; ICompilationUnit cu= null; for (int i= 0; i < nElements; i++) { Object curr= elements.get(i); if (curr instanceof IField) { IField fld= (IField)curr; if (i == 0) { // remember the cu of the first element cu= fld.getCompilationUnit(); if (cu == null) { return null; } } else if (!cu.equals(fld.getCompilationUnit())) { // all fields must be in the same CU return null; } try { if (fld.getDeclaringType().isInterface()) { // no setters/getters for interfaces return null; } } catch (JavaModelException e) { JavaPlugin.log(e); return null; } res[i]= fld; } else { return null; } } return res; } return null; } private static class GetterSetterEntry { public final IField field; public final boolean isGetterEntry; GetterSetterEntry(IField field, boolean isGetterEntry){ this.field= field; this.isGetterEntry= isGetterEntry; } } private static class AddGetterSetterLabelProvider extends JavaElementLabelProvider{ private final NameProposer fNameProposer; private static final Image IMAGE= new JavaElementImageProvider().getImageLabel(new JavaElementImageDescriptor(JavaPluginImages.DESC_MISC_PUBLIC, 0, JavaElementImageProvider.BIG_SIZE)); AddGetterSetterLabelProvider(NameProposer nameProposer){ fNameProposer= nameProposer; } /* * @see ILabelProvider#getText(Object) */ public String getText(Object element) { try { if (! (element instanceof GetterSetterEntry)) return super.getText(element); GetterSetterEntry entry= (GetterSetterEntry)element; if (entry.isGetterEntry) return fNameProposer.proposeGetterSignature(entry.field); else return fNameProposer.proposeSetterSignature(entry.field); } catch (JavaModelException e) { return ""; //$NON-NLS-1$ } } /* * @see ILabelProvider#getImage(Object) */ public Image getImage(Object element) { if (element instanceof GetterSetterEntry) return IMAGE; return super.getImage(element); } } /** * @return map IField -> GetterSetterEntry[] */ private static Map createGetterSetterMapping(IType type) throws JavaModelException{ IField[] fields= type.getFields(); Map result= new HashMap(); String[] prefixes= AddGetterSetterAction.getGetterSetterPrefixes(); String[] suffixes= AddGetterSetterAction.getGetterSetterSuffixes(); for (int i= 0; i < fields.length; i++) { List l= new ArrayList(2); if (GetterSetterUtil.getGetter(fields[i], prefixes, suffixes) == null) l.add(new GetterSetterEntry(fields[i], true)); if (GetterSetterUtil.getSetter(fields[i], prefixes, suffixes) == null) l.add(new GetterSetterEntry(fields[i], false)); if (! l.isEmpty()) result.put(fields[i], (GetterSetterEntry[]) l.toArray(new GetterSetterEntry[l.size()])); } return result; } private static class AddGetterSetterContentProvider implements ITreeContentProvider{ private static final Object[] EMPTY= new Object[0]; private Map fGetterSetterEntries; public AddGetterSetterContentProvider(Map entries) throws JavaModelException { fGetterSetterEntries= entries; } /* * @see ITreeContentProvider#getChildren(Object) */ public Object[] getChildren(Object parentElement) { if (parentElement instanceof IField) return (Object[])fGetterSetterEntries.get(parentElement); return EMPTY; } /* * @see ITreeContentProvider#getParent(Object) */ public Object getParent(Object element) { if (element instanceof IMember) return ((IMember)element).getDeclaringType(); if (element instanceof GetterSetterEntry) return ((GetterSetterEntry)element).field; return null; } /* * @see ITreeContentProvider#hasChildren(Object) */ public boolean hasChildren(Object element) { return getChildren(element).length > 0; } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { try { IType type= (IType)inputElement; IField[] fields= type.getFields(); List fieldList= new ArrayList(fields.length); for (int i = 0; i < fields.length; i++) { if (fGetterSetterEntries.containsKey(fields[i])) fieldList.add(fields[i]); } return (IField[]) fieldList.toArray(new IField[fieldList.size()]); } catch (JavaModelException e) { return EMPTY; } } /* * @see IContentProvider#dispose() */ public void dispose() { fGetterSetterEntries.clear(); fGetterSetterEntries= null; } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } } }
17,598
Bug 17598 Source->Generate Getter and Setter enabled for read only file
F1 This action is enabled for read-only files. Executing it shows a dialog saying that the file is read-only. The action should be disabled since all other source actions are disabled as well.
verified fixed
6b03c57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T16:51:22Z
2002-05-24T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/GenerateActionGroup.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.part.Page; import org.eclipse.ui.texteditor.ConvertLineDelimitersAction; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.AddBookmarkAction; import org.eclipse.jdt.internal.ui.javaeditor.AddImportOnSelectionAction; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.AddTaskAction; import org.eclipse.jdt.ui.IContextMenuConstants; /** * Action group that adds the source and generate actions to a context menu and * action bar. * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class GenerateActionGroup extends ActionGroup { private boolean fEditorIsOwner; private IWorkbenchSite fSite; private String fGroupName= IContextMenuConstants.GROUP_SOURCE; private List fRegisteredSelectionListeners; private AddImportOnSelectionAction fAddImport; private OverrideMethodsAction fOverrideMethods; private AddGetterSetterAction fAddGetterSetter; private AddUnimplementedConstructorsAction fAddUnimplementedConstructors; private AddJavaDocStubAction fAddJavaDocStub; private AddBookmarkAction fAddBookmark; private AddTaskAction fAddTaskAction; private ExternalizeStringsAction fExternalizeStrings; private FindStringsToExternalizeAction fFindStringsToExternalize; private SurroundWithTryCatchAction fSurroundWithTryCatch; private OrganizeImportsAction fOrganizeImports; private ConvertLineDelimitersAction fConvertToWindows; private ConvertLineDelimitersAction fConvertToUNIX; private ConvertLineDelimitersAction fConvertToMac; /** * Creates a new <code>GenerateActionGroup</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public GenerateActionGroup(CompilationUnitEditor editor, String groupName) { fSite= editor.getSite(); fEditorIsOwner= true; fGroupName= groupName; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fAddImport= new AddImportOnSelectionAction(editor); fAddImport.setActionDefinitionId(IJavaEditorActionDefinitionIds.ADD_IMPORT); fAddImport.update(); editor.setAction("AddImport", fAddImport); //$NON-NLS-1$ fOrganizeImports= new OrganizeImportsAction(editor); fOrganizeImports.setActionDefinitionId(IJavaEditorActionDefinitionIds.ORGANIZE_IMPORTS); fOrganizeImports.editorStateChanged(); editor.setAction("OrganizeImports", fOrganizeImports); //$NON-NLS-1$ fOverrideMethods= new OverrideMethodsAction(editor); fOverrideMethods.setActionDefinitionId(IJavaEditorActionDefinitionIds.OVERRIDE_METHODS); fOverrideMethods.editorStateChanged(); editor.setAction("OverrideMethods", fOverrideMethods); //$NON-NLS-1$ fAddGetterSetter= new AddGetterSetterAction(editor); fAddUnimplementedConstructors= new AddUnimplementedConstructorsAction(editor); fAddUnimplementedConstructors.setActionDefinitionId(IJavaEditorActionDefinitionIds.ADD_UNIMPLEMENTED_CONTRUCTORS); fAddUnimplementedConstructors.editorStateChanged(); editor.setAction("AddUnimplementedConstructors", fAddUnimplementedConstructors); //$NON-NLS-1$ fAddJavaDocStub= new AddJavaDocStubAction(editor); fAddJavaDocStub.editorStateChanged(); fSurroundWithTryCatch= new SurroundWithTryCatchAction(editor); fSurroundWithTryCatch.setActionDefinitionId(IJavaEditorActionDefinitionIds.SURROUND_WITH_TRY_CATCH); fSurroundWithTryCatch.update(selection); provider.addSelectionChangedListener(fSurroundWithTryCatch); editor.setAction("SurroundWithTryCatch", fSurroundWithTryCatch); //$NON-NLS-1$ fExternalizeStrings= new ExternalizeStringsAction(editor); fExternalizeStrings.setActionDefinitionId(IJavaEditorActionDefinitionIds.EXTERNALIZE_STRINGS); fExternalizeStrings.editorStateChanged(); editor.setAction("ExternalizeStrings", fExternalizeStrings); //$NON-NLS-1$ fConvertToWindows= new ConvertLineDelimitersAction(editor, "\r\n"); //$NON-NLS-1$ fConvertToWindows.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_WINDOWS); editor.setAction("ConvertLineDelimitersToWindows", fConvertToWindows); //$NON-NLS-1$ fConvertToUNIX= new ConvertLineDelimitersAction(editor, "\n"); //$NON-NLS-1$ fConvertToUNIX.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_UNIX); editor.setAction("ConvertLineDelimitersToUNIX", fConvertToUNIX); //$NON-NLS-1$ fConvertToMac= new ConvertLineDelimitersAction(editor, "\r"); //$NON-NLS-1$ fConvertToMac.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_MAC); editor.setAction("ConvertLineDelimitersToMac", fConvertToMac); //$NON-NLS-1$ } /** * Creates a new <code>GenerateActionGroup</code>. * * @param page the page that owns this action group */ public GenerateActionGroup(Page page) { this(page.getSite()); } /** * Creates a new <code>GenerateActionGroup</code>. * * @param part the view part that owns this action group */ public GenerateActionGroup(IViewPart part) { this(part.getSite()); } private GenerateActionGroup(IWorkbenchSite site) { fSite= site; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fOverrideMethods= new OverrideMethodsAction(site); fAddGetterSetter= new AddGetterSetterAction(site); fAddUnimplementedConstructors= new AddUnimplementedConstructorsAction(site); fAddJavaDocStub= new AddJavaDocStubAction(site); fAddBookmark= new AddBookmarkAction(site.getShell()); fAddTaskAction= new AddTaskAction(site); fExternalizeStrings= new ExternalizeStringsAction(site); fFindStringsToExternalize= new FindStringsToExternalizeAction(site); fOrganizeImports= new OrganizeImportsAction(site); fOverrideMethods.update(selection); fAddGetterSetter.update(selection); fAddUnimplementedConstructors.update(selection); fAddJavaDocStub.update(selection); fExternalizeStrings.update(selection); fFindStringsToExternalize.update(selection); fAddTaskAction.update(selection); fOrganizeImports.update(selection); if (selection instanceof IStructuredSelection) { IStructuredSelection ss= (IStructuredSelection)selection; fAddBookmark.selectionChanged(ss); } else { fAddBookmark.setEnabled(false); } registerSelectionListener(provider, fOverrideMethods); registerSelectionListener(provider, fAddGetterSetter); registerSelectionListener(provider, fAddUnimplementedConstructors); registerSelectionListener(provider, fAddJavaDocStub); registerSelectionListener(provider, fAddBookmark); registerSelectionListener(provider, fExternalizeStrings); registerSelectionListener(provider, fFindStringsToExternalize); registerSelectionListener(provider, fOrganizeImports); registerSelectionListener(provider, fAddTaskAction); } private void registerSelectionListener(ISelectionProvider provider, ISelectionChangedListener listener) { if (fRegisteredSelectionListeners == null) fRegisteredSelectionListeners= new ArrayList(12); provider.addSelectionChangedListener(listener); fRegisteredSelectionListeners.add(listener); } /** * The state of the editor owning this action group has changed. * This method does nothing if the group's owner isn't an * editor. * <p> * Note: This method is for internal use only. Clients should not call this method. * </p> */ public void editorStateChanged() { Assert.isTrue(fEditorIsOwner); fAddImport.update(); fExternalizeStrings.editorStateChanged(); fOrganizeImports.editorStateChanged(); fOverrideMethods.editorStateChanged(); fAddUnimplementedConstructors.editorStateChanged(); fAddJavaDocStub.editorStateChanged(); fSurroundWithTryCatch.editorStateChanged(); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillActionBars(IActionBars actionBar) { super.fillActionBars(actionBar); setGlobalActionHandlers(actionBar); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillContextMenu(IMenuManager menu) { super.fillContextMenu(menu); IMenuManager target= menu; IMenuManager generateMenu= null; if (fEditorIsOwner) { generateMenu= new MenuManager(ActionMessages.getString("SourceMenu.label")); //$NON-NLS-1$ generateMenu.add(new GroupMarker(fGroupName)); target= generateMenu; } int added= 0; if (fEditorIsOwner) added+= appendToGroup(target, fAddImport); added+= appendToGroup(target, fOrganizeImports); if (fEditorIsOwner) added+= appendToGroup(target, fSurroundWithTryCatch); added+= appendToGroup(target, fOverrideMethods); added+= appendToGroup(target, fAddGetterSetter); added+= appendToGroup(target, fAddUnimplementedConstructors); added+= appendToGroup(target, fAddJavaDocStub); added+= appendToGroup(target, fAddBookmark); if (fEditorIsOwner) added+= appendToGroup(target, fExternalizeStrings); if (generateMenu != null && added > 0) menu.appendToGroup(fGroupName, generateMenu); } /* (non-Javadoc) * Method declared in ActionGroup */ public void dispose() { if (fRegisteredSelectionListeners != null) { ISelectionProvider provider= fSite.getSelectionProvider(); for (Iterator iter= fRegisteredSelectionListeners.iterator(); iter.hasNext();) { ISelectionChangedListener listener= (ISelectionChangedListener) iter.next(); provider.removeSelectionChangedListener(listener); } } super.dispose(); } private void setGlobalActionHandlers(IActionBars actionBar) { actionBar.setGlobalActionHandler(JdtActionConstants.ADD_IMPORT, fAddImport); actionBar.setGlobalActionHandler(JdtActionConstants.SURROUND_WITH_TRY_CATCH, fSurroundWithTryCatch); actionBar.setGlobalActionHandler(JdtActionConstants.OVERRIDE_METHODS, fOverrideMethods); actionBar.setGlobalActionHandler(JdtActionConstants.GENERATE_GETTER_SETTER, fAddGetterSetter); actionBar.setGlobalActionHandler(JdtActionConstants.ADD_CONSTRUCTOR_FROM_SUPERCLASS, fAddUnimplementedConstructors); actionBar.setGlobalActionHandler(JdtActionConstants.ADD_JAVA_DOC_COMMENT, fAddJavaDocStub); actionBar.setGlobalActionHandler(IWorkbenchActionConstants.BOOKMARK, fAddBookmark); actionBar.setGlobalActionHandler(IWorkbenchActionConstants.ADD_TASK, fAddTaskAction); actionBar.setGlobalActionHandler(JdtActionConstants.EXTERNALIZE_STRINGS, fExternalizeStrings); actionBar.setGlobalActionHandler(JdtActionConstants.FIND_STRINGS_TO_EXTERNALIZE, fFindStringsToExternalize); actionBar.setGlobalActionHandler(JdtActionConstants.ORGANIZE_IMPORTS, fOrganizeImports); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_WINDOWS, fConvertToWindows); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_UNIX, fConvertToUNIX); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_MAC, fConvertToMac); } private int appendToGroup(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) { menu.appendToGroup(fGroupName, action); return 1; } return 0; } private void addAction(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) menu.add(action); } }
17,598
Bug 17598 Source->Generate Getter and Setter enabled for read only file
F1 This action is enabled for read-only files. Executing it shows a dialog saying that the file is read-only. The action should be disabled since all other source actions are disabled as well.
verified fixed
6b03c57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T16:51:22Z
2002-05-24T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/IJavaEditorActionDefinitionIds.java
package org.eclipse.jdt.ui.actions; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.ui.texteditor.ITextEditorActionDefinitionIds; /** * Defines the definition IDs for the java editor actions. */ public interface IJavaEditorActionDefinitionIds extends ITextEditorActionDefinitionIds { // edit public static final String SELECT_ENCLOSING= "org.eclipse.jdt.ui.edit.text.java.select.enclosing"; //$NON-NLS-1$ public static final String SELECT_NEXT= "org.eclipse.jdt.ui.edit.text.java.select.next"; //$NON-NLS-1$ public static final String SELECT_PREVIOUS= "org.eclipse.jdt.ui.edit.text.java.select.previous"; //$NON-NLS-1$ public static final String SELECT_LAST= "org.eclipse.jdt.ui.edit.text.java.select.last"; //$NON-NLS-1$ public static final String CORRECTION_ASSIST_PROPOSALS= "org.eclipse.jdt.ui.edit.text.java.correction.assist.proposals"; //$NON-NLS-1$ public static final String CONTENT_ASSIST_PROPOSALS= "org.eclipse.jdt.ui.edit.text.java.content.assist.proposals"; //$NON-NLS-1$ public static final String CONTENT_ASSIST_CONTEXT_INFORMATION= "org.eclipse.jdt.ui.edit.text.java.content.assist.context.information"; //$NON-NLS-1$ public static final String SHOW_JAVADOC= "org.eclipse.jdt.ui.edit.text.java.show.javadoc"; //$NON-NLS-1$ // source public static final String COMMENT= "org.eclipse.jdt.ui.edit.text.java.comment"; //$NON-NLS-1$ public static final String UNCOMMENT= "org.eclipse.jdt.ui.edit.text.java.uncomment"; //$NON-NLS-1$ public static final String FORMAT= "org.eclipse.jdt.ui.edit.text.java.format"; //$NON-NLS-1$ public static final String ADD_IMPORT= "org.eclipse.jdt.ui.edit.text.java.add.import"; //$NON-NLS-1$ public static final String ORGANIZE_IMPORTS= "org.eclipse.jdt.ui.edit.text.java.organize.imports"; //$NON-NLS-1$ public static final String SURROUND_WITH_TRY_CATCH= "org.eclipse.jdt.ui.edit.text.java.surround.with.try.catch"; //$NON-NLS-1$ public static final String OVERRIDE_METHODS= "org.eclipse.jdt.ui.edit.text.java.override.methods"; //$NON-NLS-1$ public static final String ADD_UNIMPLEMENTED_CONTRUCTORS= "org.eclipse.jdt.ui.edit.text.java.add.unimplemented.constructors"; //$NON-NLS-1$ public static final String EXTERNALIZE_STRINGS= "org.eclipse.jdt.ui.edit.text.java.externalize.strings"; //$NON-NLS-1$ public static final String SHOW_NEXT_PROBLEM= "org.eclipse.jdt.ui.edit.text.java.show.next.problem"; //$NON-NLS-1$ public static final String SHOW_PREVIOUS_PROBLEM= "org.eclipse.jdt.ui.edit.text.java.show.previous.problem"; //$NON-NLS-1$ // refactor public static final String PULL_UP= "org.eclipse.jdt.ui.edit.text.java.pull.up"; //$NON-NLS-1$ public static final String RENAME_ELEMENT= "org.eclipse.jdt.ui.edit.text.java.rename.element"; //$NON-NLS-1$ public static final String MODIFY_METHOD_PARAMETERS= "org.eclipse.jdt.ui.edit.text.java.modify.method.parameters"; //$NON-NLS-1$ public static final String MOVE_ELEMENT= "org.eclipse.jdt.ui.edit.text.java.move.element"; //$NON-NLS-1$ public static final String EXTRACT_LOCAL_VARIABLE= "org.eclipse.jdt.ui.edit.text.java.extract.local.variable"; //$NON-NLS-1$ public static final String INLINE_LOCAL_VARIABLE= "org.eclipse.jdt.ui.edit.text.java.inline.local.variable"; //$NON-NLS-1$ public static final String SELF_ENCAPSULATE_FIELD= "org.eclipse.jdt.ui.edit.text.java.self.encapsulate.field"; //$NON-NLS-1$ public static final String EXTRACT_METHOD= "org.eclipse.jdt.ui.edit.text.java.extract.method"; //$NON-NLS-1$ // navigate public static final String OPEN_EDITOR= "org.eclipse.jdt.ui.edit.text.java.open.editor"; //$NON-NLS-1$ public static final String OPEN_SUPER_IMPLEMENTATION= "org.eclipse.jdt.ui.edit.text.java.open.super.implementation"; //$NON-NLS-1$ public static final String OPEN_EXTERNAL_JAVADOC= "org.eclipse.jdt.ui.edit.text.java.open.external.javadoc"; //$NON-NLS-1$ public static final String OPEN_TYPE_HIERARCHY= "org.eclipse.jdt.ui.edit.text.java.open.type.hierarchy"; //$NON-NLS-1$ public static final String SHOW_IN_PACKAGE_VIEW= "org.eclipse.jdt.ui.edit.text.java.show.in.package.view"; //$NON-NLS-1$ public static final String SHOW_IN_NAVIGATOR_VIEW= "org.eclipse.jdt.ui.edit.text.java.show.in.navigator.view"; //$NON-NLS-1$ // search public static final String SEARCH_REFERENCES_IN_WORKSPACE= "org.eclipse.jdt.ui.edit.text.java.search.references.in.workspace"; //$NON-NLS-1$ public static final String SEARCH_REFERENCES_IN_HIERARCHY= "org.eclipse.jdt.ui.edit.text.java.search.references.in.hierarchy"; //$NON-NLS-1$ public static final String SEARCH_REFERENCES_IN_WORKING_SET= "org.eclipse.jdt.ui.edit.text.java.search.references.in.working.set"; //$NON-NLS-1$ public static final String SEARCH_READ_ACCESS_IN_WORKSPACE= "org.eclipse.jdt.ui.edit.text.java.search.read.access.in.workspace"; //$NON-NLS-1$ public static final String SEARCH_READ_ACCESS_IN_HIERARCHY= "org.eclipse.jdt.ui.edit.text.java.search.read.access.in.hierarchy"; //$NON-NLS-1$ public static final String SEARCH_READ_ACCESS_IN_WORKING_SET= "org.eclipse.jdt.ui.edit.text.java.search.read.access.in.working.set"; //$NON-NLS-1$ public static final String SEARCH_WRITE_ACCESS_IN_WORKSPACE= "org.eclipse.jdt.ui.edit.text.java.search.write.access.in.workspace"; //$NON-NLS-1$ public static final String SEARCH_WRITE_ACCESS_IN_HIERARCHY= "org.eclipse.jdt.ui.edit.text.java.search.write.access.in.hierarchy"; //$NON-NLS-1$ public static final String SEARCH_WRITE_ACCESS_IN_WORKING_SET= "org.eclipse.jdt.ui.edit.text.java.search.write.access.in.working.set"; //$NON-NLS-1$ public static final String SEARCH_DECLARATIONS_IN_WORKSPACE= "org.eclipse.jdt.ui.edit.text.java.search.declarations.in.workspace"; //$NON-NLS-1$ public static final String SEARCH_DECLARATIONS_IN_HIERARCHY= "org.eclipse.jdt.ui.edit.text.java.search.declarations.in.hierarchy"; //$NON-NLS-1$ public static final String SEARCH_DECLARATIONS_IN_WORKING_SET= "org.eclipse.jdt.ui.edit.text.java.search.declarations.in.working.set"; //$NON-NLS-1$ public static final String SEARCH_IMPLEMENTORS_IN_WORKSPACE= "org.eclipse.jdt.ui.edit.text.java.search.implementors.in.workspace"; //$NON-NLS-1$ public static final String SEARCH_IMPLEMENTORS_IN_WORKING_SET= "org.eclipse.jdt.ui.edit.text.java.seach.implementors.in.working.set"; //$NON-NLS-1$ // miscellaneous public static final String TOGGLE_PRESENTATION= "org.eclipse.jdt.ui.edit.text.java.toggle.presentation"; //$NON-NLS-1$ public static final String TOGGLE_TEXT_HOVER= "org.eclipse.jdt.ui.edit.text.java.toggle.text.hover"; //$NON-NLS-1$ }
17,149
Bug 17149 Libraries-Path in Java Build Path gets broken
eclipse-version: F1, linux-gtk bug: "Libraries-Path" of external JARs in "Java Build Path" gets broken I observed the following bug: 1) Call the "Java Build Path"-Dialog via selecting a project, "Properties" via right mouse button and then "Java Build Path". 2) Enter a library path via "Add External JARs..." and press "OK" Everything is ok so far. 3) Call the "Java Build Path"-Dialog again: The path to the library I entered before is broken and eclipse does not find the library any more. The path in the project's .classpath-file is ok. example: I created the project "dummy". Tried to add the external JAR "jdom.jar" to the Library-Path. jdom.jar resides in the directory "/home/mike/java/workspace/jdom/build". I selected the path as an "external JAR" . The path is shown correctly in the libraries-list. When I called the "Java Build Path"-Dialog again the path listed in the "Java Build Path"-Dialog / "Libraries" is changed to "home/mike/java/workspace/jdom/build/jdom.jar" (without the first slash). When selecting this entry and clicking on "Edit" the path shown in the "Edit Class Folder"-dialog is "mike/java/workspace/jdom/build/jdom.jar" (without "/home/"). After trying to correct the path manually in the "Edit Class Folder"-dialog the path shown in "Java Build Path"-Dialog / "Libraries" is "dummy/home/mike/java/workspace/jdom/build/jdom.jar". My workaround so far is to create variables for each library and to enter the library paths as variables.
verified fixed
59a1d0a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T16:52:06Z
2002-05-23T07:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/BuildPathsBlock.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.net.URL; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IProjectDescription; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Widget; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.ISharedImages; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.ui.dialogs.ISelectionStatusValidator; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.launching.JavaRuntime; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.CoreUtility; import org.eclipse.jdt.internal.ui.util.PixelConverter; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; import org.eclipse.jdt.internal.ui.viewsupport.ImageDisposer; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.CheckedListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; public class BuildPathsBlock { public static interface IRemoveOldBinariesQuery { /** * Do the callback. Returns <code>true</code> if .class files should be removed from the * old output location. */ boolean doQuery(IPath oldOutputLocation) throws InterruptedException; } private IWorkspaceRoot fWorkspaceRoot; private CheckedListDialogField fClassPathList; private StringButtonDialogField fBuildPathDialogField; private StatusInfo fClassPathStatus; private StatusInfo fBuildPathStatus; private IJavaProject fCurrJProject; private IPath fOutputLocationPath; private IStatusChangeListener fContext; private Control fSWTWidget; private boolean fShowSourceFolderPage; private SourceContainerWorkbookPage fSourceContainerPage; private ProjectsWorkbookPage fProjectsPage; private LibrariesWorkbookPage fLibrariesPage; private BuildPathBasePage fCurrPage; public BuildPathsBlock(IWorkspaceRoot root, IStatusChangeListener context, boolean showSourceFolders) { fWorkspaceRoot= root; fContext= context; fShowSourceFolderPage= showSourceFolders; fSourceContainerPage= null; fLibrariesPage= null; fProjectsPage= null; fCurrPage= null; BuildPathAdapter adapter= new BuildPathAdapter(); String[] buttonLabels= new String[] { /* 0 */ NewWizardMessages.getString("BuildPathsBlock.classpath.up.button"), //$NON-NLS-1$ /* 1 */ NewWizardMessages.getString("BuildPathsBlock.classpath.down.button"), //$NON-NLS-1$ /* 2 */ null, /* 3 */ NewWizardMessages.getString("BuildPathsBlock.classpath.checkall.button"), //$NON-NLS-1$ /* 4 */ NewWizardMessages.getString("BuildPathsBlock.classpath.uncheckall.button") //$NON-NLS-1$ }; fClassPathList= new CheckedListDialogField(null, buttonLabels, new CPListLabelProvider()); fClassPathList.setDialogFieldListener(adapter); fClassPathList.setLabelText(NewWizardMessages.getString("BuildPathsBlock.classpath.label")); //$NON-NLS-1$ fClassPathList.setUpButtonIndex(0); fClassPathList.setDownButtonIndex(1); fClassPathList.setCheckAllButtonIndex(3); fClassPathList.setUncheckAllButtonIndex(4); fBuildPathDialogField= new StringButtonDialogField(adapter); fBuildPathDialogField.setButtonLabel(NewWizardMessages.getString("BuildPathsBlock.buildpath.button")); //$NON-NLS-1$ fBuildPathDialogField.setDialogFieldListener(adapter); fBuildPathDialogField.setLabelText(NewWizardMessages.getString("BuildPathsBlock.buildpath.label")); //$NON-NLS-1$ fBuildPathStatus= new StatusInfo(); fClassPathStatus= new StatusInfo(); fCurrJProject= null; } // -------- UI creation --------- public Control createControl(Composite parent) { fSWTWidget= parent; PixelConverter converter= new PixelConverter(parent); Composite composite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginWidth= 0; layout.numColumns= 1; composite.setLayout(layout); TabFolder folder= new TabFolder(composite, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); folder.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { tabChanged(e.item); } }); ImageRegistry imageRegistry= JavaPlugin.getDefault().getImageRegistry(); TabItem item; fSourceContainerPage= new SourceContainerWorkbookPage(fWorkspaceRoot, fClassPathList, fBuildPathDialogField); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.source")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_PACKFRAG_ROOT)); item.setData(fSourceContainerPage); item.setControl(fSourceContainerPage.getControl(folder)); IWorkbench workbench= JavaPlugin.getDefault().getWorkbench(); Image projectImage= workbench.getSharedImages().getImage(ISharedImages.IMG_OBJ_PROJECT); fProjectsPage= new ProjectsWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.projects")); //$NON-NLS-1$ item.setImage(projectImage); item.setData(fProjectsPage); item.setControl(fProjectsPage.getControl(folder)); fLibrariesPage= new LibrariesWorkbookPage(fWorkspaceRoot, fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.libraries")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_LIBRARY)); item.setData(fLibrariesPage); item.setControl(fLibrariesPage.getControl(folder)); // a non shared image Image cpoImage= JavaPluginImages.DESC_TOOL_CLASSPATH_ORDER.createImage(); composite.addDisposeListener(new ImageDisposer(cpoImage)); ClasspathOrderingWorkbookPage ordpage= new ClasspathOrderingWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.order")); //$NON-NLS-1$ item.setImage(cpoImage); item.setData(ordpage); item.setControl(ordpage.getControl(folder)); if (fCurrJProject != null) { fSourceContainerPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); } Composite editorcomp= new Composite(composite, SWT.NONE); DialogField[] editors= new DialogField[] { fBuildPathDialogField }; LayoutUtil.doDefaultLayout(editorcomp, editors, true, 0, 0); int maxFieldWidth= converter.convertWidthInCharsToPixels(40); LayoutUtil.setWidthHint(fBuildPathDialogField.getTextControl(null), maxFieldWidth); LayoutUtil.setHorizontalGrabbing(fBuildPathDialogField.getTextControl(null)); editorcomp.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); if (fShowSourceFolderPage) { folder.setSelection(0); fCurrPage= fSourceContainerPage; } else { folder.setSelection(3); fCurrPage= ordpage; fClassPathList.selectFirstElement(); } WorkbenchHelp.setHelp(composite, IJavaHelpContextIds.BUILD_PATH_BLOCK); return composite; } private Shell getShell() { if (fSWTWidget != null) { return fSWTWidget.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } /** * Initializes the classpath for the given project. Multiple calls to init are allowed, * but all existing settings will be cleared and replace by the given or default paths. * @param project The java project to configure. Does not have to exist. * @param outputLocation The output location to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project- the * output location of the existing project * @param classpathEntries The classpath entries to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project - the * classpath entries of the existing project */ public void init(IJavaProject jproject, IPath outputLocation, IClasspathEntry[] classpathEntries) { fCurrJProject= jproject; boolean projectExists= false; List newClassPath= null; try { IProject project= fCurrJProject.getProject(); projectExists= (project.exists() && project.getFile(".classpath").exists()); //$NON-NLS-1$ if (projectExists) { if (outputLocation == null) { outputLocation= fCurrJProject.getOutputLocation(); } if (classpathEntries == null) { classpathEntries= fCurrJProject.getRawClasspath(); } } if (outputLocation == null) { outputLocation= getDefaultBuildPath(jproject); } if (classpathEntries != null) { newClassPath= getExistingEntries(classpathEntries); } } catch (CoreException e) { JavaPlugin.log(e); } if (newClassPath == null) { newClassPath= getDefaultClassPath(jproject); } List exportedEntries = new ArrayList(); for (int i= 0; i < newClassPath.size(); i++) { CPListElement curr= (CPListElement) newClassPath.get(i); if (curr.isExported() || curr.getEntryKind() == IClasspathEntry.CPE_SOURCE) { exportedEntries.add(curr); } } // inits the dialog field fBuildPathDialogField.setText(outputLocation.makeRelative().toString()); fClassPathList.setElements(newClassPath); fClassPathList.setCheckedElements(exportedEntries); if (fSourceContainerPage != null) { fSourceContainerPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); } doStatusLineUpdate(); } private ArrayList getExistingEntries(IClasspathEntry[] classpathEntries) { ArrayList newClassPath= new ArrayList(); boolean projectExists= fCurrJProject.exists(); for (int i= 0; i < classpathEntries.length; i++) { IClasspathEntry curr= classpathEntries[i]; IPath path= curr.getPath(); // get the resource IResource res= null; boolean isMissing= false; switch (curr.getEntryKind()) { case IClasspathEntry.CPE_CONTAINER: res= null; try { isMissing= (JavaCore.getClasspathContainer(path, fCurrJProject) == null); } catch (JavaModelException e) { isMissing= true; } break; case IClasspathEntry.CPE_VARIABLE: IPath resolvedPath= JavaCore.getResolvedVariablePath(path); res= null; isMissing= fWorkspaceRoot.findMember(resolvedPath) == null && !resolvedPath.toFile().isFile(); break; case IClasspathEntry.CPE_LIBRARY: res= fWorkspaceRoot.findMember(path); if (res == null) { if (!ArchiveFileFilter.isArchivePath(path)) { if (fWorkspaceRoot.getWorkspace().validatePath(path.toString(), IResource.FOLDER).isOK()) { res= fWorkspaceRoot.getFolder(path); } } isMissing= !path.toFile().isFile(); // look for external JARs } case IClasspathEntry.CPE_SOURCE: res= fWorkspaceRoot.findMember(path); if (res == null) { if (fWorkspaceRoot.getWorkspace().validatePath(path.toString(), IResource.FOLDER).isOK()) { res= fWorkspaceRoot.getFolder(path); } isMissing= true; } break; case IClasspathEntry.CPE_PROJECT: res= fWorkspaceRoot.findMember(path); isMissing= (res == null); break; } boolean isExported= curr.isExported(); CPListElement elem= new CPListElement(fCurrJProject, curr.getEntryKind(), path, res, curr.getSourceAttachmentPath(), curr.getSourceAttachmentRootPath(), isExported); if (projectExists) { elem.setIsMissing(isMissing); } newClassPath.add(elem); } return newClassPath; } // -------- public api -------- /** * Returns the Java project. Can return <code>null<code> if the page has not * been initialized. */ public IJavaProject getJavaProject() { return fCurrJProject; } /** * Returns the current output location. Note that the path returned must not be valid. */ public IPath getOutputLocation() { return new Path(fBuildPathDialogField.getText()).makeAbsolute(); } /** * Returns the current class path (raw). Note that the entries returned must not be valid. */ public IClasspathEntry[] getRawClassPath() { List elements= fClassPathList.getElements(); int nElements= elements.size(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= 0; i < nElements; i++) { CPListElement currElement= (CPListElement) elements.get(i); entries[i]= currElement.getClasspathEntry(); } return entries; } // -------- evaluate default settings -------- private List getDefaultClassPath(IJavaProject jproj) { List list= new ArrayList(); IResource srcFolder; if (JavaBasePreferencePage.useSrcAndBinFolders()) { String sourceFolderName= JavaBasePreferencePage.getSourceFolderName(); srcFolder= jproj.getProject().getFolder(sourceFolderName); } else { srcFolder= jproj.getProject(); } list.add(new CPListElement(jproj, IClasspathEntry.CPE_SOURCE, srcFolder.getFullPath(), srcFolder)); IPath libPath= new Path(JavaRuntime.JRELIB_VARIABLE); IPath attachPath= new Path(JavaRuntime.JRESRC_VARIABLE); IPath attachRoot= new Path(JavaRuntime.JRESRCROOT_VARIABLE); CPListElement elem= new CPListElement(jproj, IClasspathEntry.CPE_VARIABLE, libPath, null, attachPath, attachRoot, false); list.add(elem); return list; } private IPath getDefaultBuildPath(IJavaProject jproj) { if (JavaBasePreferencePage.useSrcAndBinFolders()) { String outputLocationName= JavaBasePreferencePage.getOutputLocationName(); return jproj.getProject().getFullPath().append(outputLocationName); } else { return jproj.getProject().getFullPath(); } } private class BuildPathAdapter implements IStringButtonAdapter, IDialogFieldListener { // -------- IStringButtonAdapter -------- public void changeControlPressed(DialogField field) { buildPathChangeControlPressed(field); } // ---------- IDialogFieldListener -------- public void dialogFieldChanged(DialogField field) { buildPathDialogFieldChanged(field); } } private void buildPathChangeControlPressed(DialogField field) { if (field == fBuildPathDialogField) { IContainer container= chooseContainer(); if (container != null) { fBuildPathDialogField.setText(container.getFullPath().toString()); } } } private void buildPathDialogFieldChanged(DialogField field) { if (field == fClassPathList) { updateClassPathStatus(); updateBuildPathStatus(); } else if (field == fBuildPathDialogField) { updateBuildPathStatus(); } doStatusLineUpdate(); } // -------- verification ------------------------------- private void doStatusLineUpdate() { IStatus res= findMostSevereStatus(); fContext.statusChanged(res); } private IStatus findMostSevereStatus() { return StatusUtil.getMoreSevere(fClassPathStatus, fBuildPathStatus); } /** * Validates the build path. */ private void updateClassPathStatus() { fClassPathStatus.setOK(); List elements= fClassPathList.getElements(); boolean entryMissing= false; IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); boolean isChecked= fClassPathList.isChecked(currElement); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (!isChecked) { fClassPathList.setCheckedWithoutUpdate(currElement, true); } } else { currElement.setExported(isChecked); } entries[i]= currElement.getClasspathEntry(); entryMissing= entryMissing || currElement.isMissing(); } if (entryMissing) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.EntryMissing")); //$NON-NLS-1$ } if (fCurrJProject.hasClasspathCycle(entries)) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.CycleInClassPath")); //$NON-NLS-1$ } } /** * Validates output location & build path. */ private void updateBuildPathStatus() { fOutputLocationPath= null; String text= fBuildPathDialogField.getText(); if ("".equals(text)) { //$NON-NLS-1$ fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.EnterBuildPath")); //$NON-NLS-1$ return; } IPath path= getOutputLocation(); IResource res= fWorkspaceRoot.findMember(path); if (res != null) { // if exists, must be a folder or project if (res.getType() == IResource.FILE) { fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.InvalidBuildPath")); //$NON-NLS-1$ return; } } fOutputLocationPath= path; List elements= fClassPathList.getElements(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; boolean outputFolderAlsoSourceFolder= false; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); entries[i]= currElement.getClasspathEntry(); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE && fOutputLocationPath.equals(currElement.getPath())) { outputFolderAlsoSourceFolder= true; } } IStatus status= JavaConventions.validateClasspath(fCurrJProject, entries, path); if (!status.isOK()) { fBuildPathStatus.setError(status.getMessage()); return; } if (res != null && res.exists() && fCurrJProject.exists()) { try { IPath oldOutputLocation= fCurrJProject.getOutputLocation(); if (!oldOutputLocation.equals(fOutputLocationPath) && !outputFolderAlsoSourceFolder) { if (((IContainer)res).members().length > 0) { fBuildPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.OutputFolderNotEmpty")); //$NON-NLS-1$ return; } } } catch (CoreException e) { JavaPlugin.log(e); } } fBuildPathStatus.setOK(); } // -------- creation ------------------------------- public static void createProject(IProject project, IPath locationPath, IProgressMonitor monitor) throws CoreException { // create the project try { if (!project.exists()) { IProjectDescription desc= project.getWorkspace().newProjectDescription(project.getName()); if (Platform.getLocation().equals(locationPath)) { locationPath= null; } desc.setLocation(locationPath); project.create(desc, monitor); monitor= null; } if (!project.isOpen()) { project.open(monitor); monitor= null; } } finally { if (monitor != null) { monitor.done(); } } } public static void addJavaNature(IProject project, IProgressMonitor monitor) throws CoreException { if (!project.hasNature(JavaCore.NATURE_ID)) { IProjectDescription description = project.getDescription(); String[] prevNatures= description.getNatureIds(); String[] newNatures= new String[prevNatures.length + 1]; System.arraycopy(prevNatures, 0, newNatures, 0, prevNatures.length); newNatures[prevNatures.length]= JavaCore.NATURE_ID; description.setNatureIds(newNatures); project.setDescription(description, monitor); } } public void configureJavaProject(IProgressMonitor monitor) throws CoreException, InterruptedException { if (monitor == null) { monitor= new NullProgressMonitor(); } monitor.beginTask(NewWizardMessages.getString("BuildPathsBlock.operationdesc"), 10); //$NON-NLS-1$ try { Shell shell= null; if (fSWTWidget != null && !fSWTWidget.getShell().isDisposed()) { shell= fSWTWidget.getShell(); } internalConfigureJavaProject(fClassPathList.getElements(), getOutputLocation(), shell, monitor); } finally { monitor.done(); } } /** * Creates the Java project and sets the configured build path and output location. * If the project already exists only build paths are updated. */ private void internalConfigureJavaProject(List classPathEntries, IPath outputLocation, Shell shell, IProgressMonitor monitor) throws CoreException, InterruptedException { // 10 monitor steps to go IRemoveOldBinariesQuery reorgQuery= null; if (shell != null) { reorgQuery= getRemoveOldBinariesQuery(shell); } // remove old .class files if (reorgQuery != null) { IPath oldOutputLocation= fCurrJProject.getOutputLocation(); if (!outputLocation.equals(oldOutputLocation)) { IResource res= fWorkspaceRoot.findMember(oldOutputLocation); if (res instanceof IContainer && hasClassfiles(res)) { if (reorgQuery.doQuery(oldOutputLocation)) { removeOldClassfiles(res); } } } } // create and set the output path first if (!fWorkspaceRoot.exists(outputLocation)) { IFolder folder= fWorkspaceRoot.getFolder(outputLocation); CoreUtility.createFolder(folder, true, true, null); } monitor.worked(2); int nEntries= classPathEntries.size(); IClasspathEntry[] classpath= new IClasspathEntry[nEntries]; // create and set the class path for (int i= 0; i < nEntries; i++) { CPListElement entry= ((CPListElement)classPathEntries.get(i)); IResource res= entry.getResource(); if ((res instanceof IFolder) && !res.exists()) { CoreUtility.createFolder((IFolder)res, true, true, null); } classpath[i]= entry.getClasspathEntry(); // set javadoc location URL javadocLocation= entry.getJavadocLocation(); if (javadocLocation != null) { IPath path= entry.getPath(); if (entry.getEntryKind() == IClasspathEntry.CPE_VARIABLE) { path= JavaCore.getResolvedVariablePath(path); } if (path != null) { JavaDocLocations.setLibraryJavadocLocation(path, javadocLocation); } } } monitor.worked(1); fCurrJProject.setRawClasspath(classpath, outputLocation, new SubProgressMonitor(monitor, 7)); } public static boolean hasClassfiles(IResource resource) throws CoreException { if (resource.isDerived() && "class".equals(resource.getFileExtension())) { //$NON-NLS-1$ return true; } if (resource instanceof IContainer) { IResource[] members= ((IContainer) resource).members(); for (int i= 0; i < members.length; i++) { if (hasClassfiles(members[i])) { return true; } } } return false; } public static void removeOldClassfiles(IResource resource) throws CoreException { if (resource.isDerived() && "class".equals(resource.getFileExtension())) { //$NON-NLS-1$ resource.delete(false, null); } if (resource instanceof IContainer) { IResource[] members= ((IContainer) resource).members(); for (int i= 0; i < members.length; i++) { removeOldClassfiles(members[i]); } } } public static IRemoveOldBinariesQuery getRemoveOldBinariesQuery(final Shell shell) { return new IRemoveOldBinariesQuery() { public boolean doQuery(final IPath oldOutputLocation) throws InterruptedException { final int[] res= new int[] { 1 }; shell.getDisplay().syncExec(new Runnable() { public void run() { String title= NewWizardMessages.getString("BuildPathsBlock.RemoveBinariesDialog.title"); //$NON-NLS-1$ String message= NewWizardMessages.getFormattedString("BuildPathsBlock.RemoveBinariesDialog.description", oldOutputLocation.toString()); //$NON-NLS-1$ MessageDialog dialog= new MessageDialog(shell, title, null, message, MessageDialog.QUESTION, new String[] { IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }, 2); res[0]= dialog.open(); } }); if (res[0] == 0) { return true; } else if (res[0] == 1) { return false; } throw new InterruptedException(); } }; } // ---------- util method ------------ private IContainer chooseContainer() { Class[] acceptedClasses= new Class[] { IProject.class, IFolder.class }; ISelectionStatusValidator validator= new TypedElementSelectionValidator(acceptedClasses, false); IProject[] allProjects= fWorkspaceRoot.getProjects(); ArrayList rejectedElements= new ArrayList(allProjects.length); IProject currProject= fCurrJProject.getProject(); for (int i= 0; i < allProjects.length; i++) { if (!allProjects[i].equals(currProject)) { rejectedElements.add(allProjects[i]); } } ViewerFilter filter= new TypedViewerFilter(acceptedClasses, rejectedElements.toArray()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); IResource initSelection= null; if (fOutputLocationPath != null) { initSelection= fWorkspaceRoot.findMember(fOutputLocationPath); } ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setTitle(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.title")); //$NON-NLS-1$ dialog.setValidator(validator); dialog.setMessage(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(fWorkspaceRoot); dialog.setInitialSelection(initSelection); if (dialog.open() == dialog.OK) { return (IContainer)dialog.getFirstResult(); } return null; } // -------- tab switching ---------- private void tabChanged(Widget widget) { if (widget instanceof TabItem) { BuildPathBasePage newPage= (BuildPathBasePage) ((TabItem) widget).getData(); if (fCurrPage != null) { List selection= fCurrPage.getSelection(); if (!selection.isEmpty()) { newPage.setSelection(selection); } } fCurrPage= newPage; } } }
17,171
Bug 17171 Quickfix: no proposal for wrong inst var initialization
- create the following code: public class Test { int fFoo= 1.2; } - a Quickfix bulb and a wiggly line appears for fFoo. However, pressing Cntr-1 does not show any proposals but the .log contains: java.lang.ClassCastException: org.eclipse.jdt.core.dom.FieldDeclaration at org.eclipse.jdt.internal.ui.text.correction.LocalCorrectionsSubProcessor.addCast Proposals(LocalCorrectionsSubProcessor.java:90) at org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor.collectCorre ctions(JavaCorrectionProcessor.java:193) at org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor.computeCompl etionProposals(JavaCorrectionProcessor.java:127) at org.eclipse.jface.text.contentassist.ContentAssistant.computeCompletionProposals (ContentAssistant.java:1205) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.computeProposals (CompletionProposalPopup.java:104) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.access$3 (CompletionProposalPopup.java:103) at org.eclipse.jface.text.contentassist.CompletionProposalPopup$1.run (CompletionProposalPopup.java:72) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:56) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.showProposals (CompletionProposalPopup.java:67) at org.eclipse.jface.text.contentassist.ContentAssistant.showPossibleCompletions (ContentAssistant.java:1140) at org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer.doOperati on(JavaCorrectionSourceViewer.java:47) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor$AdaptedSourceViewer .doOperation(CompilationUnitEditor.java:217) at org.eclipse.ui.texteditor.TextOperationAction.run (TextOperationAction.java:88) at org.eclipse.ui.texteditor.RetargetTextEditorAction.run (RetargetTextEditorAction.java:127) at org.eclipse.jface.action.Action.runWithEvent(Action.java:590) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:462) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:200) at org.eclipse.core.launcher.Main.run(Main.java:643) at org.eclipse.core.launcher.Main.main(Main.java:476)
verified fixed
1fee925
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T17:44:19Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/LocalCorrectionsSubProcessor.java
package org.eclipse.jdt.internal.ui.text.correction; import java.util.ArrayList; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.text.IDocument; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.core.dom.AST; import org.eclipse.jdt.core.dom.ASTNode; import org.eclipse.jdt.core.dom.Assignment; import org.eclipse.jdt.core.dom.BodyDeclaration; import org.eclipse.jdt.core.dom.CompilationUnit; import org.eclipse.jdt.core.dom.Expression; import org.eclipse.jdt.core.dom.ITypeBinding; import org.eclipse.jdt.core.dom.MethodDeclaration; import org.eclipse.jdt.core.dom.ReturnStatement; import org.eclipse.jdt.core.dom.SimpleName; import org.eclipse.jdt.core.dom.Statement; import org.eclipse.jdt.core.dom.Type; import org.eclipse.jdt.core.dom.VariableDeclarationFragment; import org.eclipse.jdt.core.dom.VariableDeclarationStatement; import org.eclipse.jdt.internal.corext.codemanipulation.CodeGenerationSettings; import org.eclipse.jdt.internal.corext.codemanipulation.ImportEdit; import org.eclipse.jdt.internal.corext.codemanipulation.StubUtility; import org.eclipse.jdt.internal.corext.dom.GenericVisitor; import org.eclipse.jdt.internal.corext.refactoring.changes.CompilationUnitChange; import org.eclipse.jdt.internal.corext.refactoring.nls.NLSRefactoring; import org.eclipse.jdt.internal.corext.refactoring.surround.SurroundWithTryCatchRefactoring; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter; import org.eclipse.jdt.internal.ui.refactoring.nls.ExternalizeWizard; /** */ public class LocalCorrectionsSubProcessor { public static void addCastProposals(ProblemPosition problemPos, ArrayList proposals) throws CoreException { String[] args= problemPos.getArguments(); if (args.length != 2) { return; } ICompilationUnit cu= problemPos.getCompilationUnit(); String castDestType= args[1]; CompilationUnit astRoot= AST.parseCompilationUnit(cu, false); ASTNode selectedNode= ASTResolving.findSelectedNode(astRoot, problemPos.getOffset(), problemPos.getLength()); int pos= problemPos.getOffset(); if (selectedNode != null && selectedNode.getParent() != null) { int parentNodeType= selectedNode.getParent().getNodeType(); if (parentNodeType == ASTNode.ASSIGNMENT) { Assignment assign= (Assignment) selectedNode.getParent(); if (selectedNode.equals(assign.getLeftHandSide())) { pos= assign.getRightHandSide().getStartPosition(); } } else if (parentNodeType == ASTNode.VARIABLE_DECLARATION_FRAGMENT) { VariableDeclarationFragment frag= (VariableDeclarationFragment) selectedNode.getParent(); if (selectedNode.equals(frag.getName())) { pos= frag.getInitializer().getStartPosition(); } } } String simpleCastDestType= Signature.getSimpleName(castDestType); String cast= '(' + simpleCastDestType + ')'; String formatted= StubUtility.codeFormat(cast + 'x', 0, ""); //$NON-NLS-1$ if (formatted.charAt(formatted.length() - 1) == 'x') { cast= formatted.substring(0, formatted.length() - 1); } String label= CorrectionMessages.getFormattedString("LocalCorrectionsSubProcessor.addcast.description", castDestType); //$NON-NLS-1$ InsertCorrectionProposal proposal= new InsertCorrectionProposal(label, cu, pos, cast, 1); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); ImportEdit edit= new ImportEdit(cu, settings); edit.addImport(castDestType); proposal.getCompilationUnitChange().addTextEdit("import", edit); //$NON-NLS-1$ proposals.add(proposal); if (selectedNode != null && selectedNode.getParent() instanceof VariableDeclarationFragment) { VariableDeclarationFragment fragment= (VariableDeclarationFragment) selectedNode.getParent(); VariableDeclarationStatement statement= (VariableDeclarationStatement) fragment.getParent(); if (statement.fragments().size() == 1) { String castType= args[0]; String simpleCastType= Signature.getSimpleName(castType); Type type= statement.getType(); label= CorrectionMessages.getFormattedString("LocalCorrectionsSubProcessor.addcast_var.description", simpleCastType); //$NON-NLS-1$ ReplaceCorrectionProposal varProposal= new ReplaceCorrectionProposal(label, cu, type.getStartPosition(), type.getLength(), simpleCastType, 1); edit= new ImportEdit(cu, settings); edit.addImport(castType); varProposal.getCompilationUnitChange().addTextEdit("import", edit); //$NON-NLS-1$ proposals.add(varProposal); } } } public static void addUncaughtExceptionProposals(ProblemPosition problemPos, ArrayList proposals) throws CoreException { ICompilationUnit cu= problemPos.getCompilationUnit(); CompilationUnit astRoot= AST.parseCompilationUnit(cu, true); ASTNode selectedNode= ASTResolving.findSelectedNode(astRoot, problemPos.getOffset(), problemPos.getLength()); if (selectedNode == null) { return; } while (selectedNode != null && !(selectedNode instanceof Statement)) { selectedNode= selectedNode.getParent(); } if (selectedNode != null) { CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); SurroundWithTryCatchRefactoring refactoring= new SurroundWithTryCatchRefactoring(cu, selectedNode.getStartPosition(), selectedNode.getLength(), settings, null); refactoring.setSaveChanges(false); if (refactoring.checkActivationBasics(astRoot, null).isOK()) { String label= CorrectionMessages.getString("LocalCorrectionsSubProcessor.surroundwith.description"); //$NON-NLS-1$ CUCorrectionProposal proposal= new CUCorrectionProposal(label, (CompilationUnitChange) refactoring.createChange(null), 0); proposals.add(proposal); } } BodyDeclaration decl= ASTResolving.findParentBodyDeclaration(selectedNode); if (decl instanceof MethodDeclaration) { String uncaughtName= problemPos.getArguments()[0]; MethodDeclaration methodDecl= (MethodDeclaration) decl; SimpleName name= methodDecl.getName(); int pos= name.getStartPosition() + name.getLength(); StringBuffer insertString= new StringBuffer(); if (methodDecl.thrownExceptions().isEmpty()) { insertString.append(" throws "); //$NON-NLS-1$ } else { insertString.append(", "); //$NON-NLS-1$ } insertString.append(Signature.getSimpleName(uncaughtName)); String label= CorrectionMessages.getString("LocalCorrectionsSubProcessor.addthrows.description"); //$NON-NLS-1$ InsertCorrectionProposal proposal= new InsertCorrectionProposal(label, cu, pos, insertString.toString(), 0); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); ImportEdit edit= new ImportEdit(cu, settings); edit.addImport(uncaughtName); proposal.getCompilationUnitChange().addTextEdit("import", edit); //$NON-NLS-1$ proposals.add(proposal); } } public static void addMethodWithConstrNameProposals(ProblemPosition problemPos, ArrayList proposals) throws CoreException { ICompilationUnit cu= problemPos.getCompilationUnit(); CompilationUnit astRoot= AST.parseCompilationUnit(cu, false); ASTNode selectedNode= ASTResolving.findSelectedNode(astRoot, problemPos.getOffset(), problemPos.getLength()); if (selectedNode instanceof SimpleName && selectedNode.getParent() instanceof MethodDeclaration) { MethodDeclaration declaration= (MethodDeclaration) selectedNode.getParent(); int start= declaration.getReturnType().getStartPosition(); int end= declaration.getName().getStartPosition(); String label= CorrectionMessages.getString("LocalCorrectionsSubProcessor.constrnamemethod.description"); //$NON-NLS-1$ ReplaceCorrectionProposal proposal= new ReplaceCorrectionProposal(label, cu, start, end - start, "", 0); //$NON-NLS-1$ proposals.add(proposal); } } public static void addVoidMethodReturnsProposals(ProblemPosition problemPos, ArrayList proposals) throws CoreException { ICompilationUnit cu= problemPos.getCompilationUnit(); CompilationUnit astRoot= AST.parseCompilationUnit(cu, true); ASTNode selectedNode= ASTResolving.findSelectedNode(astRoot, problemPos.getOffset(), problemPos.getLength()); if (selectedNode != null) { if (selectedNode.getParent() instanceof ReturnStatement) { ReturnStatement returnStatement= (ReturnStatement) selectedNode.getParent(); Expression expr= returnStatement.getExpression(); if (expr != null) { ITypeBinding binding= expr.resolveTypeBinding(); if (binding != null) { if ("null".equals(binding.getName())) { //$NON-NLS-1$ binding= selectedNode.getAST().resolveWellKnownType("java.lang.Object"); //$NON-NLS-1$ } BodyDeclaration decl= ASTResolving.findParentBodyDeclaration(returnStatement); if (decl instanceof MethodDeclaration) { ASTNode returnType= ((MethodDeclaration) decl).getReturnType(); String label= CorrectionMessages.getString("LocalCorrectionsSubProcessor.voidmethodreturns.description") + binding.getName(); //$NON-NLS-1$ ReplaceCorrectionProposal proposal= new ReplaceCorrectionProposal(label, cu, returnType.getStartPosition(), returnType.getLength(), binding.getName(), 0); proposals.add(proposal); } } } } } } public static void addMissingReturnTypeProposals(ProblemPosition problemPos, ArrayList proposals) throws CoreException { ICompilationUnit cu= problemPos.getCompilationUnit(); CompilationUnit astRoot= AST.parseCompilationUnit(cu, true); ASTNode selectedNode= ASTResolving.findSelectedNode(astRoot, problemPos.getOffset(), problemPos.getLength()); if (selectedNode != null) { BodyDeclaration decl= ASTResolving.findParentBodyDeclaration(selectedNode); if (decl instanceof MethodDeclaration) { final ITypeBinding[] res= new ITypeBinding[1]; res[0]= null; decl.accept(new GenericVisitor() { public boolean visit(ReturnStatement node) { if (res[0] == null) { Expression expr= node.getExpression(); if (expr != null) { ITypeBinding binding= expr.resolveTypeBinding(); if (binding != null) { res[0]= binding; } else { res[0]= node.getAST().resolveWellKnownType("java.lang.Object"); //$NON-NLS-1$ } } else { res[0]= node.getAST().resolveWellKnownType("void"); //$NON-NLS-1$ } } return false; } }); ITypeBinding type= res[0]; if (type == null) { type= decl.getAST().resolveWellKnownType("void"); //$NON-NLS-1$ } String str= type.getName() + " "; //$NON-NLS-1$ int pos= ((MethodDeclaration) decl).getName().getStartPosition(); String label= CorrectionMessages.getFormattedString("LocalCorrectionsSubProcessor.missingreturntype.description", type.getName()); //$NON-NLS-1$ InsertCorrectionProposal proposal= new InsertCorrectionProposal(label, cu, pos, str, 1); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); ImportEdit edit= new ImportEdit(problemPos.getCompilationUnit(), settings); edit.addImport(type.getName()); proposal.getCompilationUnitChange().addTextEdit("import", edit); //$NON-NLS-1$ proposals.add(proposal); } } } public static void addNLSProposals(ProblemPosition problemPos, ArrayList proposals) throws CoreException { final ICompilationUnit cu= problemPos.getCompilationUnit(); String name= CorrectionMessages.getString("LocalCorrectionsSubProcessor.externalizestrings.description"); //$NON-NLS-1$ ChangeCorrectionProposal proposal= new ChangeCorrectionProposal(name, null, 0) { public void apply(IDocument document) { try { NLSRefactoring refactoring= new NLSRefactoring(cu); ExternalizeWizard wizard= new ExternalizeWizard(refactoring); String dialogTitle= CorrectionMessages.getString("LocalCorrectionsSubProcessor.externalizestrings.dialog.title"); //$NON-NLS-1$ new RefactoringStarter().activate(refactoring, wizard, dialogTitle, true); } catch (JavaModelException e) { JavaPlugin.log(e); } } }; proposals.add(proposal); } }
17,020
Bug 17020 Refactor move class not updating imports
Build 20020521 (Freeze 1) This is the strangest error. Follow these steps very closely to reproduce. Package names must be exactly the same... 1) Create a java project 2) Add the swt.jar to the project build path 3) Create two packages, "test.package1" and "test.package2". 4) In "test.package1", define two classes: --- start A.java -------- package test.package1; import org.eclipse.swt.SWT; import org.eclipse.swt.events.PaintEvent; import org.eclipse.swt.events.PaintListener; import org.eclipse.swt.graphics.*; import org.eclipse.swt.widgets.*; public class A { B b; } --- end A.java ----------- --- start B.java -------- package test.package1; public class B { } --- end B.java ----------- 5) In the packages view, drag and drop B.java into package "test.package2". 6) When it prompts you, choose "Preview" to preview the changes 7) Note in the preview dialog, it shows "A.java" in the list, but the compare panes at the bottom don't show any changes 8) Click finish. There is now a compile error in A.java. It failed to update the imports when B was moved. Some very subtle changes will make this test case no longer work. For example, if you remove the SWT imports, it correctly refactors the code.
verified fixed
827665f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T17:55:46Z
2002-05-22T20:40:00Z
org.eclipse.jdt.ui/core
17,020
Bug 17020 Refactor move class not updating imports
Build 20020521 (Freeze 1) This is the strangest error. Follow these steps very closely to reproduce. Package names must be exactly the same... 1) Create a java project 2) Add the swt.jar to the project build path 3) Create two packages, "test.package1" and "test.package2". 4) In "test.package1", define two classes: --- start A.java -------- package test.package1; import org.eclipse.swt.SWT; import org.eclipse.swt.events.PaintEvent; import org.eclipse.swt.events.PaintListener; import org.eclipse.swt.graphics.*; import org.eclipse.swt.widgets.*; public class A { B b; } --- end A.java ----------- --- start B.java -------- package test.package1; public class B { } --- end B.java ----------- 5) In the packages view, drag and drop B.java into package "test.package2". 6) When it prompts you, choose "Preview" to preview the changes 7) Note in the preview dialog, it shows "A.java" in the list, but the compare panes at the bottom don't show any changes 8) Click finish. There is now a compile error in A.java. It failed to update the imports when B was moved. Some very subtle changes will make this test case no longer work. For example, if you remove the SWT imports, it correctly refactors the code.
verified fixed
827665f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T17:55:46Z
2002-05-22T20:40:00Z
extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportsStructure.java
16,858
Bug 16858 Preceding space in package compression pattern sometimes ignored
(In the following discussion, all patterns were entered without the enclosing quote marks.) The pattern "1 " causes one character of each package name to be displayed with a single space separator between them. The pattern " 1 " causes one space to precede the first single-character package name and two spaces to appear between each one. Both of the above cases were expected. However, if you set the patttern to " 1" (i.e. space before, but no space after), no spaces are displayed in the result.
verified fixed
90d99d6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T18:01:49Z
2002-05-22T15:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementLabels.java
package org.eclipse.jdt.internal.ui.viewsupport; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.ui.model.IWorkbenchAdapter; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.IInitializer; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; public class JavaElementLabels { /** * Method names contain parameter types. * e.g. <code>foo(int)</code> */ public final static int M_PARAMETER_TYPES= 1 << 0; /** * Method names contain parameter names. * e.g. <code>foo(index)</code> */ public final static int M_PARAMETER_NAMES= 1 << 1; /** * Method names contain thrown exceptions. * e.g. <code>foo throws IOException</code> */ public final static int M_EXCEPTIONS= 1 << 2; /** * Method names contain return type (appended) * e.g. <code>foo : int</code> */ public final static int M_APP_RETURNTYPE= 1 << 3; /** * Method names contain return type (appended) * e.g. <code>int foo</code> */ public final static int M_PRE_RETURNTYPE= 1 << 4; /** * Method names are fully qualified. * e.g. <code>java.util.Vector.size</code> */ public final static int M_FULLY_QUALIFIED= 1 << 5; /** * Method names are post qualified. * e.g. <code>size - java.util.Vector</code> */ public final static int M_POST_QUALIFIED= 1 << 6; /** * Initializer names are fully qualified. * e.g. <code>java.util.Vector.{ ... }</code> */ public final static int I_FULLY_QUALIFIED= 1 << 7; /** * Type names are post qualified. * e.g. <code>{ ... } - java.util.Map</code> */ public final static int I_POST_QUALIFIED= 1 << 8; /** * Field names contain the declared type (appended) * e.g. <code>int fHello</code> */ public final static int F_APP_TYPE_SIGNATURE= 1 << 9; /** * Field names contain the declared type (prepended) * e.g. <code>fHello : int</code> */ public final static int F_PRE_TYPE_SIGNATURE= 1 << 10; /** * Fields names are fully qualified. * e.g. <code>java.lang.System.out</code> */ public final static int F_FULLY_QUALIFIED= 1 << 11; /** * Fields names are post qualified. * e.g. <code>out - java.lang.System</code> */ public final static int F_POST_QUALIFIED= 1 << 12; /** * Type names are fully qualified. * e.g. <code>java.util.Map.MapEntry</code> */ public final static int T_FULLY_QUALIFIED= 1 << 13; /** * Type names are type container qualified. * e.g. <code>Map.MapEntry</code> */ public final static int T_CONTAINER_QUALIFIED= 1 << 14; /** * Type names are post qualified. * e.g. <code>MapEntry - java.util.Map</code> */ public final static int T_POST_QUALIFIED= 1 << 15; /** * Declarations (import container / declarartion, package declarartion) are qualified. * e.g. <code>java.util.Vector.class/import container</code> */ public final static int D_QUALIFIED= 1 << 16; /** * Declarations (import container / declarartion, package declarartion) are post qualified. * e.g. <code>import container - java.util.Vector.class</code> */ public final static int D_POST_QUALIFIED= 1 << 17; /** * Class file names are fully qualified. * e.g. <code>java.util.Vector.class</code> */ public final static int CF_QUALIFIED= 1 << 18; /** * Class file names are post qualified. * e.g. <code>Vector.class - java.util</code> */ public final static int CF_POST_QUALIFIED= 1 << 19; /** * Compilation unit names are fully qualified. * e.g. <code>java.util.Vector.java</code> */ public final static int CU_QUALIFIED= 1 << 20; /** * Compilation unit names are post qualified. * e.g. <code>Vector.java - java.util</code> */ public final static int CU_POST_QUALIFIED= 1 << 21; /** * Package names are qualified. * e.g. <code>MyProject/src/java.util</code> */ public final static int P_QUALIFIED= 1 << 22; /** * Package names are post qualified. * e.g. <code>java.util - MyProject/src</code> */ public final static int P_POST_QUALIFIED= 1 << 23; /** * Package Fragment Roots contain variable name if from a variable. * e.g. <code>JRE_LIB - c:\java\lib\rt.jar</code> */ public final static int ROOT_VARIABLE= 1 << 24; /** * Package Fragment Roots contain the project name if not an archive (prepended). * e.g. <code>MyProject/src</code> */ public final static int ROOT_QUALIFIED= 1 << 25; /** * Package Fragment Roots contain the project name if not an archive (appended). * e.g. <code>src - MyProject</code> */ public final static int ROOT_POST_QUALIFIED= 1 << 26; /** * Add root path to all elements except Package Fragment Roots and Java projects. * e.g. <code>java.lang.Vector - c:\java\lib\rt.jar</code> * Option only applies to getElementLabel */ public final static int APPEND_ROOT_PATH= 1 << 27; /** * Add root path to all elements except Package Fragment Roots and Java projects. * e.g. <code>java.lang.Vector - c:\java\lib\rt.jar</code> * Option only applies to getElementLabel */ public final static int PREPEND_ROOT_PATH= 1 << 28; /** * Package names are compressed. * e.g. <code>o*.e*.search</code> */ public final static int P_COMPRESSED= 1 << 29; /** * Qualify all elements */ public final static int ALL_FULLY_QUALIFIED= F_FULLY_QUALIFIED | M_FULLY_QUALIFIED | I_FULLY_QUALIFIED | T_FULLY_QUALIFIED | D_QUALIFIED | CF_QUALIFIED | CU_QUALIFIED | P_QUALIFIED | ROOT_QUALIFIED; /** * Post qualify all elements */ public final static int ALL_POST_QUALIFIED= F_POST_QUALIFIED | M_POST_QUALIFIED | I_POST_QUALIFIED | T_POST_QUALIFIED | D_POST_QUALIFIED | CF_POST_QUALIFIED | CU_POST_QUALIFIED | P_POST_QUALIFIED | ROOT_POST_QUALIFIED; /** * Default options (M_PARAMETER_TYPES enabled) */ public final static int ALL_DEFAULT= M_PARAMETER_TYPES; /** * Default qualify options (All except Root and Package) */ public final static int DEFAULT_QUALIFIED= F_FULLY_QUALIFIED | M_FULLY_QUALIFIED | I_FULLY_QUALIFIED | T_FULLY_QUALIFIED | D_QUALIFIED | CF_QUALIFIED | CU_QUALIFIED; /** * Default post qualify options (All except Root and Package) */ public final static int DEFAULT_POST_QUALIFIED= F_POST_QUALIFIED | M_POST_QUALIFIED | I_POST_QUALIFIED | T_POST_QUALIFIED | D_POST_QUALIFIED | CF_POST_QUALIFIED | CU_POST_QUALIFIED; private final static String CONCAT_STRING= JavaUIMessages.getString("JavaElementLabels.concat_string"); // " - "; //$NON-NLS-1$ private final static String COMMA_STRING= JavaUIMessages.getString("JavaElementLabels.comma_string"); // ", "; //$NON-NLS-1$ private final static String DECL_STRING= JavaUIMessages.getString("JavaElementLabels.declseparator_string"); // " "; // use for return type //$NON-NLS-1$ /* * Package name compression */ private static String fgPkgNamePattern= ""; //$NON-NLS-1$ private static String fgPkgNamePrefix; private static String fgPkgNamePostfix; private static int fgPkgNameChars; private static int fgPkgNameLength; private JavaElementLabels() { } private static boolean getFlag(int flags, int flag) { return (flags & flag) != 0; } public static String getTextLabel(Object obj, int flags) { if (obj instanceof IJavaElement) { return getElementLabel((IJavaElement) obj, flags); } else if (obj instanceof IAdaptable) { IWorkbenchAdapter wbadapter= (IWorkbenchAdapter) ((IAdaptable)obj).getAdapter(IWorkbenchAdapter.class); if (wbadapter != null) { return wbadapter.getLabel(obj); } } return ""; //$NON-NLS-1$ } /** * Returns the label for a Java element. Flags as defined above. */ public static String getElementLabel(IJavaElement element, int flags) { StringBuffer buf= new StringBuffer(); getElementLabel(element, flags, buf); return buf.toString(); } /** * Returns the label for a Java element. Flags as defined above. */ public static void getElementLabel(IJavaElement element, int flags, StringBuffer buf) { int type= element.getElementType(); IPackageFragmentRoot root= null; if (type != IJavaElement.JAVA_MODEL && type != IJavaElement.JAVA_PROJECT && type != IJavaElement.PACKAGE_FRAGMENT_ROOT) root= JavaModelUtil.getPackageFragmentRoot(element); if (root != null && getFlag(flags, PREPEND_ROOT_PATH)) { getPackageFragmentRootLabel(root, ROOT_QUALIFIED, buf); buf.append(CONCAT_STRING); } switch (type) { case IJavaElement.METHOD: getMethodLabel((IMethod) element, flags, buf); break; case IJavaElement.FIELD: getFieldLabel((IField) element, flags, buf); break; case IJavaElement.INITIALIZER: getInitializerLabel((IInitializer) element, flags, buf); break; case IJavaElement.TYPE: getTypeLabel((IType) element, flags, buf); break; case IJavaElement.CLASS_FILE: getClassFileLabel((IClassFile) element, flags, buf); break; case IJavaElement.COMPILATION_UNIT: getCompilationUnitLabel((ICompilationUnit) element, flags, buf); break; case IJavaElement.PACKAGE_FRAGMENT: getPackageFragmentLabel((IPackageFragment) element, flags, buf); break; case IJavaElement.PACKAGE_FRAGMENT_ROOT: getPackageFragmentRootLabel((IPackageFragmentRoot) element, flags, buf); break; case IJavaElement.IMPORT_CONTAINER: case IJavaElement.IMPORT_DECLARATION: case IJavaElement.PACKAGE_DECLARATION: getDeclararionLabel(element, flags, buf); break; case IJavaElement.JAVA_PROJECT: case IJavaElement.JAVA_MODEL: buf.append(element.getElementName()); break; default: buf.append(element.getElementName()); } if (root != null && getFlag(flags, APPEND_ROOT_PATH)) { buf.append(CONCAT_STRING); getPackageFragmentRootLabel(root, ROOT_QUALIFIED, buf); } } /** * Appends the label for a method to a StringBuffer. Considers the M_* flags. */ public static void getMethodLabel(IMethod method, int flags, StringBuffer buf) { try { // return type if (getFlag(flags, M_PRE_RETURNTYPE) && method.exists() && !method.isConstructor()) { buf.append(Signature.getSimpleName(Signature.toString(method.getReturnType()))); buf.append(' '); } // qualification if (getFlag(flags, M_FULLY_QUALIFIED)) { getTypeLabel(method.getDeclaringType(), T_FULLY_QUALIFIED, buf); buf.append('.'); } buf.append(method.getElementName()); // parameters if (getFlag(flags, M_PARAMETER_TYPES | M_PARAMETER_NAMES)) { buf.append('('); String[] types= getFlag(flags, M_PARAMETER_TYPES) ? method.getParameterTypes() : null; String[] names= (getFlag(flags, M_PARAMETER_NAMES) && method.exists()) ? method.getParameterNames() : null; int nParams= types != null ? types.length : names.length; for (int i= 0; i < nParams; i++) { if (i > 0) { buf.append(COMMA_STRING); //$NON-NLS-1$ } if (types != null) { buf.append(Signature.getSimpleName(Signature.toString(types[i]))); } if (names != null) { if (types != null) { buf.append(' '); } buf.append(names[i]); } } buf.append(')'); } if (getFlag(flags, M_EXCEPTIONS) && method.exists()) { String[] types= method.getExceptionTypes(); if (types.length > 0) { buf.append(" throws "); //$NON-NLS-1$ for (int i= 0; i < types.length; i++) { if (i > 0) { buf.append(COMMA_STRING); } buf.append(Signature.getSimpleName(Signature.toString(types[i]))); } } } if (getFlag(flags, M_APP_RETURNTYPE) && method.exists() && !method.isConstructor()) { buf.append(DECL_STRING); buf.append(Signature.getSimpleName(Signature.toString(method.getReturnType()))); } // post qualification if (getFlag(flags, M_POST_QUALIFIED)) { buf.append(CONCAT_STRING); getTypeLabel(method.getDeclaringType(), T_FULLY_QUALIFIED, buf); } } catch (JavaModelException e) { JavaPlugin.log(e); // NotExistsException will not reach this point } } /** * Appends the label for a field to a StringBuffer. Considers the F_* flags. */ public static void getFieldLabel(IField field, int flags, StringBuffer buf) { try { if (getFlag(flags, F_PRE_TYPE_SIGNATURE) && field.exists()) { buf.append(Signature.toString(field.getTypeSignature())); buf.append(' '); } // qualification if (getFlag(flags, F_FULLY_QUALIFIED)) { getTypeLabel(field.getDeclaringType(), T_FULLY_QUALIFIED, buf); buf.append('.'); } buf.append(field.getElementName()); if (getFlag(flags, F_APP_TYPE_SIGNATURE) && field.exists()) { buf.append(DECL_STRING); buf.append(Signature.toString(field.getTypeSignature())); } // post qualification if (getFlag(flags, F_POST_QUALIFIED)) { buf.append(CONCAT_STRING); getTypeLabel(field.getDeclaringType(), T_FULLY_QUALIFIED, buf); } } catch (JavaModelException e) { JavaPlugin.log(e); // NotExistsException will not reach this point } } /** * Appends the label for a initializer to a StringBuffer. Considers the I_* flags. */ public static void getInitializerLabel(IInitializer initializer, int flags, StringBuffer buf) { // qualification if (getFlag(flags, I_FULLY_QUALIFIED)) { getTypeLabel(initializer.getDeclaringType(), T_FULLY_QUALIFIED, buf); buf.append('.'); } buf.append(JavaUIMessages.getString("JavaElementLabels.initializer")); //$NON-NLS-1$ // post qualification if (getFlag(flags, I_POST_QUALIFIED)) { buf.append(CONCAT_STRING); getTypeLabel(initializer.getDeclaringType(), T_FULLY_QUALIFIED, buf); } } /** * Appends the label for a type to a StringBuffer. Considers the T_* flags. */ public static void getTypeLabel(IType type, int flags, StringBuffer buf) { if (getFlag(flags, T_FULLY_QUALIFIED)) { buf.append(JavaModelUtil.getFullyQualifiedName(type)); } else if (getFlag(flags, T_CONTAINER_QUALIFIED)) { buf.append(JavaModelUtil.getTypeQualifiedName(type)); } else { buf.append(type.getElementName()); } // post qualification if (getFlag(flags, T_POST_QUALIFIED)) { buf.append(CONCAT_STRING); IType declaringType= type.getDeclaringType(); if (declaringType != null) { buf.append(JavaModelUtil.getFullyQualifiedName(declaringType)); } else { getPackageFragmentLabel(type.getPackageFragment(), 0, buf); } } } /** * Appends the label for a declaration to a StringBuffer. Considers the D_* flags. */ public static void getDeclararionLabel(IJavaElement declaration, int flags, StringBuffer buf) { if (getFlag(flags, D_QUALIFIED)) { IJavaElement openable= (IJavaElement) declaration.getOpenable(); if (openable != null) { buf.append(getElementLabel(openable, CF_QUALIFIED | CU_QUALIFIED)); buf.append('/'); } } if (declaration.getElementType() == IJavaElement.IMPORT_CONTAINER) { buf.append(JavaUIMessages.getString("JavaElementLabels.import_container")); //$NON-NLS-1$ } else { buf.append(declaration.getElementName()); } // post qualification if (getFlag(flags, D_POST_QUALIFIED)) { IJavaElement openable= (IJavaElement) declaration.getOpenable(); if (openable != null) { buf.append(CONCAT_STRING); buf.append(getElementLabel(openable, CF_QUALIFIED | CU_QUALIFIED)); } } } /** * Appends the label for a class file to a StringBuffer. Considers the CF_* flags. */ public static void getClassFileLabel(IClassFile classFile, int flags, StringBuffer buf) { if (getFlag(flags, CF_QUALIFIED)) { IPackageFragment pack= (IPackageFragment) classFile.getParent(); if (!pack.isDefaultPackage()) { buf.append(pack.getElementName()); buf.append('.'); } } buf.append(classFile.getElementName()); if (getFlag(flags, CF_POST_QUALIFIED)) { buf.append(CONCAT_STRING); getPackageFragmentLabel((IPackageFragment) classFile.getParent(), 0, buf); } } /** * Appends the label for a compilation unit to a StringBuffer. Considers the CU_* flags. */ public static void getCompilationUnitLabel(ICompilationUnit cu, int flags, StringBuffer buf) { if (getFlag(flags, CU_QUALIFIED)) { IPackageFragment pack= (IPackageFragment) cu.getParent(); if (!pack.isDefaultPackage()) { buf.append(pack.getElementName()); buf.append('.'); } } buf.append(cu.getElementName()); if (getFlag(flags, CU_POST_QUALIFIED)) { buf.append(CONCAT_STRING); getPackageFragmentLabel((IPackageFragment) cu.getParent(), 0, buf); } } /** * Appends the label for a package fragment to a StringBuffer. Considers the P_* flags. */ public static void getPackageFragmentLabel(IPackageFragment pack, int flags, StringBuffer buf) { if (getFlag(flags, P_QUALIFIED)) { getPackageFragmentRootLabel((IPackageFragmentRoot) pack.getParent(), ROOT_QUALIFIED, buf); buf.append('/'); } refreshPackageNamePattern(); if (pack.isDefaultPackage()) { buf.append(JavaUIMessages.getString("JavaElementLabels.default_package")); //$NON-NLS-1$ } else if (getFlag(flags, P_COMPRESSED) && fgPkgNameLength >= 0) { String name= pack.getElementName(); int start= 0; int dot= name.indexOf('.', start); while (dot > 0) { if (dot - start > fgPkgNameLength-1) { buf.append(fgPkgNamePrefix); if (fgPkgNameChars > 0) buf.append(name.substring(start, Math.min(start+ fgPkgNameChars, dot))); buf.append(fgPkgNamePostfix); } else buf.append(name.substring(start, dot + 1)); start= dot + 1; dot= name.indexOf('.', start); } buf.append(name.substring(start)); } else { buf.append(pack.getElementName()); } if (getFlag(flags, P_POST_QUALIFIED)) { buf.append(CONCAT_STRING); getPackageFragmentRootLabel((IPackageFragmentRoot) pack.getParent(), ROOT_QUALIFIED, buf); } } /** * Appends the label for a package fragment root to a StringBuffer. Considers the ROOT_* flags. */ public static void getPackageFragmentRootLabel(IPackageFragmentRoot root, int flags, StringBuffer buf) { if (root.isArchive() && getFlag(flags, ROOT_VARIABLE)) { try { IClasspathEntry rawEntry= root.getRawClasspathEntry(); if (rawEntry != null) { if (rawEntry.getEntryKind() == IClasspathEntry.CPE_VARIABLE) { buf.append(rawEntry.getPath().makeRelative()); buf.append(CONCAT_STRING); } } } catch (JavaModelException e) { JavaPlugin.log(e); // problems with class path } } if (root.isExternal()) { // external jars have path == name // no qualification for external roots buf.append(root.getPath().toOSString()); } else { if (getFlag(flags, ROOT_QUALIFIED)) { buf.append(root.getPath().makeRelative().toString()); } else { buf.append(root.getElementName()); } if (getFlag(flags, ROOT_POST_QUALIFIED)) { buf.append(CONCAT_STRING); buf.append(root.getParent().getElementName()); } } } private static void refreshPackageNamePattern() { String pattern= AppearancePreferencePage.getPkgNamePatternForPackagesView(); if (pattern.equals(fgPkgNamePattern)) return; else if (pattern.equals("")) { //$NON-NLS-1$ fgPkgNameLength= -1; return; } fgPkgNamePattern= pattern; int i= 0; fgPkgNameChars= 0; fgPkgNamePrefix= ""; //$NON-NLS-1$ fgPkgNamePostfix= ""; //$NON-NLS-1$ while (i < pattern.length()) { char ch= pattern.charAt(i); if (Character.isDigit(ch)) { fgPkgNameChars= ch-48; if (i > 0 && i < pattern.length() - 1) fgPkgNamePrefix= pattern.substring(0, i); if (i >= 0 && i < pattern.length()) fgPkgNamePostfix= pattern.substring(i+1); fgPkgNameLength= fgPkgNamePrefix.length() + fgPkgNameChars + fgPkgNamePostfix.length(); return; } i++; } fgPkgNamePrefix= pattern; fgPkgNameLength= pattern.length(); } }
16,733
Bug 16733 Builder pref - Cannot exclude folder from resource copying
Build 20020521 - F1 UI builder pref page currently prevents enter a folder name for the resource copy exclusion filter (folder is specified with a '/' suffix). Since 20020521, JDT/Core now supports excluding folders: The setting allowing for filtering resource copy now also supports folder filtering. Folder names are recognized by their '/' suffix, e.g. "META-INF/" specifies filtering out all folder named 'META-INF' (and their contents)
verified fixed
a189576
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T18:07:32Z
2002-05-22T09:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaBuilderPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.lang.reflect.InvocationTargetException; import java.util.Hashtable; import java.util.StringTokenizer; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.IncrementalProjectBuilder; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; public class JavaBuilderPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { private StringDialogField fResourceFilterField; private StatusInfo fResourceFilterStatus; private SelectionButtonDialogField fAbortInvalidClasspathField; private Hashtable fWorkingValues; private static final String PREF_RESOURCE_FILTER= JavaCore.CORE_JAVA_BUILD_RESOURCE_COPY_FILTER; private static final String PREF_BUILD_INVALID_CLASSPATH= JavaCore.CORE_JAVA_BUILD_INVALID_CLASSPATH; private static final String ABORT= JavaCore.ABORT; private static final String IGNORE= JavaCore.IGNORE; private static String[] getAllKeys() { return new String[] { PREF_RESOURCE_FILTER, PREF_BUILD_INVALID_CLASSPATH }; } public JavaBuilderPreferencePage() { setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("JavaBuilderPreferencePage.description")); //$NON-NLS-1$ fWorkingValues= JavaCore.getOptions(); IDialogFieldListener listener= new IDialogFieldListener() { public void dialogFieldChanged(DialogField field) { updateValues(); } }; fResourceFilterField= new StringDialogField(); fResourceFilterField.setLabelText(JavaUIMessages.getString("JavaBuilderPreferencePage.filter.label")); //$NON-NLS-1$ fAbortInvalidClasspathField= new SelectionButtonDialogField(SWT.CHECK); fAbortInvalidClasspathField.setDialogFieldListener(listener); fAbortInvalidClasspathField.setLabelText(JavaUIMessages.getString("JavaBuilderPreferencePage.abortinvalidprojects.label")); //$NON-NLS-1$ updateControls(); fResourceFilterField.setDialogFieldListener(listener); fAbortInvalidClasspathField.setDialogFieldListener(listener); } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { initializeDialogUnits(parent); GridLayout layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; Composite composite= new Composite(parent, SWT.NONE); composite.setLayout(layout); DialogField resourceFilterLabel= new DialogField(); resourceFilterLabel.setLabelText(JavaUIMessages.getString("JavaBuilderPreferencePage.filter.description")); //$NON-NLS-1$ resourceFilterLabel.doFillIntoGrid(composite, 2); LayoutUtil.setWidthHint(resourceFilterLabel.getLabelControl(null), convertWidthInCharsToPixels(80)); fResourceFilterField.doFillIntoGrid(composite, 2); LayoutUtil.setHorizontalGrabbing(fResourceFilterField.getTextControl(null)); LayoutUtil.setWidthHint(fResourceFilterField.getTextControl(null), convertWidthInCharsToPixels(50)); fAbortInvalidClasspathField.doFillIntoGrid(composite, 2); return composite; } /** * Initializes the current options (read from preference store) */ public static void initDefaults(IPreferenceStore store) { } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) { } /* * @see IPreferencePage#performOk() */ public boolean performOk() { String[] allKeys= getAllKeys(); // preserve other options // store in JCore and the preferences Hashtable actualOptions= JavaCore.getOptions(); boolean hasChanges= false; for (int i= 0; i < allKeys.length; i++) { String key= allKeys[i]; String val= (String) fWorkingValues.get(key); String oldVal= (String) actualOptions.get(key); hasChanges= hasChanges | !val.equals(oldVal); actualOptions.put(key, val); } if (hasChanges) { String title= JavaUIMessages.getString("JavaBuilderPreferencePage.needsbuild.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("JavaBuilderPreferencePage.needsbuild.message"); //$NON-NLS-1$ MessageDialog dialog= new MessageDialog(getShell(), title, null, message, MessageDialog.QUESTION, new String[] { IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }, 2); int res= dialog.open(); if (res != 0 && res != 1) { JavaPlugin.getDefault().savePluginPreferences(); return false; } JavaCore.setOptions(actualOptions); if (res == 0) { doFullBuild(); } } JavaPlugin.getDefault().savePluginPreferences(); return super.performOk(); } private void updateValues() { IStatus status= validateResourceFilters(); fWorkingValues.put(PREF_BUILD_INVALID_CLASSPATH, fAbortInvalidClasspathField.isSelected() ? ABORT : IGNORE); updateStatus(status); } private String[] getFilters(String text) { StringTokenizer tok= new StringTokenizer(text, ","); //$NON-NLS-1$ int nTokens= tok.countTokens(); String[] res= new String[nTokens]; for (int i= 0; i < res.length; i++) { res[i]= tok.nextToken().trim(); } return res; } private IStatus validateResourceFilters() { IWorkspace workspace= ResourcesPlugin.getWorkspace(); String text= fResourceFilterField.getText(); String[] filters= getFilters(text); for (int i= 0; i < filters.length; i++) { String fileName= filters[i].replace('*', 'x'); IStatus status= workspace.validateName(fileName, IResource.FILE); if (status.matches(IStatus.ERROR)) { String message= JavaUIMessages.getFormattedString("JavaBuilderPreferencePage.filter.invalidsegment.error", status.getMessage()); //$NON-NLS-1$ return new StatusInfo(IStatus.ERROR, message); } } StringBuffer buf= new StringBuffer(); for (int i= 0; i < filters.length; i++) { if (i > 0) { buf.append(','); } buf.append(filters[i]); } fWorkingValues.put(PREF_RESOURCE_FILTER, buf.toString()); return new StatusInfo(); } private void updateStatus(IStatus status) { setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } private void doFullBuild() { ProgressMonitorDialog dialog= new ProgressMonitorDialog(getShell()); try { dialog.run(true, true, new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException { try { JavaPlugin.getWorkspace().build(IncrementalProjectBuilder.FULL_BUILD, monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }); } catch (InterruptedException e) { // cancelled by user } catch (InvocationTargetException e) { String title= JavaUIMessages.getString("JavaBuilderPreferencePage.builderror.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("JavaBuilderPreferencePage.builderror.message"); //$NON-NLS-1$ ExceptionHandler.handle(e, getShell(), title, message); } } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fWorkingValues= JavaCore.getDefaultOptions(); updateControls(); updateValues(); super.performDefaults(); } private void updateControls() { // update the UI String[] filters= getFilters((String) fWorkingValues.get(PREF_RESOURCE_FILTER)); StringBuffer buf= new StringBuffer(); for (int i= 0; i < filters.length; i++) { if (i > 0) { buf.append(", "); //$NON-NLS-1$ } buf.append(filters[i]); } fResourceFilterField.setText(buf.toString()); String build= (String) fWorkingValues.get(PREF_BUILD_INVALID_CLASSPATH); fAbortInvalidClasspathField.setSelection(ABORT.equals(build)); } }
17,618
Bug 17618 Changing output location should delete all derived resources
F1 1) create a project (autobuild on) 2) import Java sources and resources 3) change output folder to project/bin ->all class files are removed (fine) 4) change output folder back to be the project -> all class files are removed (fine) 5) open project/bin -> all resources are still there Note: When opening the properties dialog on such a resource it is tagged as "Derived". Thus, it should be possible to remove all derived resources as long as they have been created by the Java builder.
verified fixed
bf1a15f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T18:25:28Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/BuildPathsBlock.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.net.URL; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IProjectDescription; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Widget; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.ISharedImages; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.ui.dialogs.ISelectionStatusValidator; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.launching.JavaRuntime; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.CoreUtility; import org.eclipse.jdt.internal.ui.util.PixelConverter; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; import org.eclipse.jdt.internal.ui.viewsupport.ImageDisposer; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.CheckedListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; public class BuildPathsBlock { public static interface IRemoveOldBinariesQuery { /** * Do the callback. Returns <code>true</code> if .class files should be removed from the * old output location. */ boolean doQuery(IPath oldOutputLocation) throws InterruptedException; } private IWorkspaceRoot fWorkspaceRoot; private CheckedListDialogField fClassPathList; private StringButtonDialogField fBuildPathDialogField; private StatusInfo fClassPathStatus; private StatusInfo fBuildPathStatus; private IJavaProject fCurrJProject; private IPath fOutputLocationPath; private IStatusChangeListener fContext; private Control fSWTWidget; private boolean fShowSourceFolderPage; private SourceContainerWorkbookPage fSourceContainerPage; private ProjectsWorkbookPage fProjectsPage; private LibrariesWorkbookPage fLibrariesPage; private BuildPathBasePage fCurrPage; public BuildPathsBlock(IWorkspaceRoot root, IStatusChangeListener context, boolean showSourceFolders) { fWorkspaceRoot= root; fContext= context; fShowSourceFolderPage= showSourceFolders; fSourceContainerPage= null; fLibrariesPage= null; fProjectsPage= null; fCurrPage= null; BuildPathAdapter adapter= new BuildPathAdapter(); String[] buttonLabels= new String[] { /* 0 */ NewWizardMessages.getString("BuildPathsBlock.classpath.up.button"), //$NON-NLS-1$ /* 1 */ NewWizardMessages.getString("BuildPathsBlock.classpath.down.button"), //$NON-NLS-1$ /* 2 */ null, /* 3 */ NewWizardMessages.getString("BuildPathsBlock.classpath.checkall.button"), //$NON-NLS-1$ /* 4 */ NewWizardMessages.getString("BuildPathsBlock.classpath.uncheckall.button") //$NON-NLS-1$ }; fClassPathList= new CheckedListDialogField(null, buttonLabels, new CPListLabelProvider()); fClassPathList.setDialogFieldListener(adapter); fClassPathList.setLabelText(NewWizardMessages.getString("BuildPathsBlock.classpath.label")); //$NON-NLS-1$ fClassPathList.setUpButtonIndex(0); fClassPathList.setDownButtonIndex(1); fClassPathList.setCheckAllButtonIndex(3); fClassPathList.setUncheckAllButtonIndex(4); fBuildPathDialogField= new StringButtonDialogField(adapter); fBuildPathDialogField.setButtonLabel(NewWizardMessages.getString("BuildPathsBlock.buildpath.button")); //$NON-NLS-1$ fBuildPathDialogField.setDialogFieldListener(adapter); fBuildPathDialogField.setLabelText(NewWizardMessages.getString("BuildPathsBlock.buildpath.label")); //$NON-NLS-1$ fBuildPathStatus= new StatusInfo(); fClassPathStatus= new StatusInfo(); fCurrJProject= null; } // -------- UI creation --------- public Control createControl(Composite parent) { fSWTWidget= parent; PixelConverter converter= new PixelConverter(parent); Composite composite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginWidth= 0; layout.numColumns= 1; composite.setLayout(layout); TabFolder folder= new TabFolder(composite, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); folder.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { tabChanged(e.item); } }); ImageRegistry imageRegistry= JavaPlugin.getDefault().getImageRegistry(); TabItem item; fSourceContainerPage= new SourceContainerWorkbookPage(fWorkspaceRoot, fClassPathList, fBuildPathDialogField); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.source")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_PACKFRAG_ROOT)); item.setData(fSourceContainerPage); item.setControl(fSourceContainerPage.getControl(folder)); IWorkbench workbench= JavaPlugin.getDefault().getWorkbench(); Image projectImage= workbench.getSharedImages().getImage(ISharedImages.IMG_OBJ_PROJECT); fProjectsPage= new ProjectsWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.projects")); //$NON-NLS-1$ item.setImage(projectImage); item.setData(fProjectsPage); item.setControl(fProjectsPage.getControl(folder)); fLibrariesPage= new LibrariesWorkbookPage(fWorkspaceRoot, fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.libraries")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_LIBRARY)); item.setData(fLibrariesPage); item.setControl(fLibrariesPage.getControl(folder)); // a non shared image Image cpoImage= JavaPluginImages.DESC_TOOL_CLASSPATH_ORDER.createImage(); composite.addDisposeListener(new ImageDisposer(cpoImage)); ClasspathOrderingWorkbookPage ordpage= new ClasspathOrderingWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.order")); //$NON-NLS-1$ item.setImage(cpoImage); item.setData(ordpage); item.setControl(ordpage.getControl(folder)); if (fCurrJProject != null) { fSourceContainerPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); } Composite editorcomp= new Composite(composite, SWT.NONE); DialogField[] editors= new DialogField[] { fBuildPathDialogField }; LayoutUtil.doDefaultLayout(editorcomp, editors, true, 0, 0); int maxFieldWidth= converter.convertWidthInCharsToPixels(40); LayoutUtil.setWidthHint(fBuildPathDialogField.getTextControl(null), maxFieldWidth); LayoutUtil.setHorizontalGrabbing(fBuildPathDialogField.getTextControl(null)); editorcomp.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); if (fShowSourceFolderPage) { folder.setSelection(0); fCurrPage= fSourceContainerPage; } else { folder.setSelection(3); fCurrPage= ordpage; fClassPathList.selectFirstElement(); } WorkbenchHelp.setHelp(composite, IJavaHelpContextIds.BUILD_PATH_BLOCK); return composite; } private Shell getShell() { if (fSWTWidget != null) { return fSWTWidget.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } /** * Initializes the classpath for the given project. Multiple calls to init are allowed, * but all existing settings will be cleared and replace by the given or default paths. * @param project The java project to configure. Does not have to exist. * @param outputLocation The output location to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project- the * output location of the existing project * @param classpathEntries The classpath entries to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project - the * classpath entries of the existing project */ public void init(IJavaProject jproject, IPath outputLocation, IClasspathEntry[] classpathEntries) { fCurrJProject= jproject; boolean projectExists= false; List newClassPath= null; try { IProject project= fCurrJProject.getProject(); projectExists= (project.exists() && project.getFile(".classpath").exists()); //$NON-NLS-1$ if (projectExists) { if (outputLocation == null) { outputLocation= fCurrJProject.getOutputLocation(); } if (classpathEntries == null) { classpathEntries= fCurrJProject.getRawClasspath(); } } if (outputLocation == null) { outputLocation= getDefaultBuildPath(jproject); } if (classpathEntries != null) { newClassPath= getExistingEntries(classpathEntries); } } catch (CoreException e) { JavaPlugin.log(e); } if (newClassPath == null) { newClassPath= getDefaultClassPath(jproject); } List exportedEntries = new ArrayList(); for (int i= 0; i < newClassPath.size(); i++) { CPListElement curr= (CPListElement) newClassPath.get(i); if (curr.isExported() || curr.getEntryKind() == IClasspathEntry.CPE_SOURCE) { exportedEntries.add(curr); } } // inits the dialog field fBuildPathDialogField.setText(outputLocation.makeRelative().toString()); fClassPathList.setElements(newClassPath); fClassPathList.setCheckedElements(exportedEntries); if (fSourceContainerPage != null) { fSourceContainerPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); } doStatusLineUpdate(); } private ArrayList getExistingEntries(IClasspathEntry[] classpathEntries) { ArrayList newClassPath= new ArrayList(); boolean projectExists= fCurrJProject.exists(); for (int i= 0; i < classpathEntries.length; i++) { IClasspathEntry curr= classpathEntries[i]; IPath path= curr.getPath(); // get the resource IResource res= null; boolean isMissing= false; switch (curr.getEntryKind()) { case IClasspathEntry.CPE_CONTAINER: res= null; try { isMissing= (JavaCore.getClasspathContainer(path, fCurrJProject) == null); } catch (JavaModelException e) { isMissing= true; } break; case IClasspathEntry.CPE_VARIABLE: IPath resolvedPath= JavaCore.getResolvedVariablePath(path); res= null; isMissing= fWorkspaceRoot.findMember(resolvedPath) == null && !resolvedPath.toFile().isFile(); break; case IClasspathEntry.CPE_LIBRARY: res= fWorkspaceRoot.findMember(path); if (res == null) { if (!ArchiveFileFilter.isArchivePath(path)) { if (fWorkspaceRoot.getWorkspace().validatePath(path.toString(), IResource.FOLDER).isOK()) { res= fWorkspaceRoot.getFolder(path); } } isMissing= !path.toFile().isFile(); // look for external JARs } break; case IClasspathEntry.CPE_SOURCE: res= fWorkspaceRoot.findMember(path); if (res == null) { if (fWorkspaceRoot.getWorkspace().validatePath(path.toString(), IResource.FOLDER).isOK()) { res= fWorkspaceRoot.getFolder(path); } isMissing= true; } break; case IClasspathEntry.CPE_PROJECT: res= fWorkspaceRoot.findMember(path); isMissing= (res == null); break; } boolean isExported= curr.isExported(); CPListElement elem= new CPListElement(fCurrJProject, curr.getEntryKind(), path, res, curr.getSourceAttachmentPath(), curr.getSourceAttachmentRootPath(), isExported); if (projectExists) { elem.setIsMissing(isMissing); } newClassPath.add(elem); } return newClassPath; } // -------- public api -------- /** * Returns the Java project. Can return <code>null<code> if the page has not * been initialized. */ public IJavaProject getJavaProject() { return fCurrJProject; } /** * Returns the current output location. Note that the path returned must not be valid. */ public IPath getOutputLocation() { return new Path(fBuildPathDialogField.getText()).makeAbsolute(); } /** * Returns the current class path (raw). Note that the entries returned must not be valid. */ public IClasspathEntry[] getRawClassPath() { List elements= fClassPathList.getElements(); int nElements= elements.size(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= 0; i < nElements; i++) { CPListElement currElement= (CPListElement) elements.get(i); entries[i]= currElement.getClasspathEntry(); } return entries; } // -------- evaluate default settings -------- private List getDefaultClassPath(IJavaProject jproj) { List list= new ArrayList(); IResource srcFolder; if (JavaBasePreferencePage.useSrcAndBinFolders()) { String sourceFolderName= JavaBasePreferencePage.getSourceFolderName(); srcFolder= jproj.getProject().getFolder(sourceFolderName); } else { srcFolder= jproj.getProject(); } list.add(new CPListElement(jproj, IClasspathEntry.CPE_SOURCE, srcFolder.getFullPath(), srcFolder)); IPath libPath= new Path(JavaRuntime.JRELIB_VARIABLE); IPath attachPath= new Path(JavaRuntime.JRESRC_VARIABLE); IPath attachRoot= new Path(JavaRuntime.JRESRCROOT_VARIABLE); CPListElement elem= new CPListElement(jproj, IClasspathEntry.CPE_VARIABLE, libPath, null, attachPath, attachRoot, false); list.add(elem); return list; } private IPath getDefaultBuildPath(IJavaProject jproj) { if (JavaBasePreferencePage.useSrcAndBinFolders()) { String outputLocationName= JavaBasePreferencePage.getOutputLocationName(); return jproj.getProject().getFullPath().append(outputLocationName); } else { return jproj.getProject().getFullPath(); } } private class BuildPathAdapter implements IStringButtonAdapter, IDialogFieldListener { // -------- IStringButtonAdapter -------- public void changeControlPressed(DialogField field) { buildPathChangeControlPressed(field); } // ---------- IDialogFieldListener -------- public void dialogFieldChanged(DialogField field) { buildPathDialogFieldChanged(field); } } private void buildPathChangeControlPressed(DialogField field) { if (field == fBuildPathDialogField) { IContainer container= chooseContainer(); if (container != null) { fBuildPathDialogField.setText(container.getFullPath().toString()); } } } private void buildPathDialogFieldChanged(DialogField field) { if (field == fClassPathList) { updateClassPathStatus(); updateBuildPathStatus(); } else if (field == fBuildPathDialogField) { updateBuildPathStatus(); } doStatusLineUpdate(); } // -------- verification ------------------------------- private void doStatusLineUpdate() { IStatus res= findMostSevereStatus(); fContext.statusChanged(res); } private IStatus findMostSevereStatus() { return StatusUtil.getMoreSevere(fClassPathStatus, fBuildPathStatus); } /** * Validates the build path. */ private void updateClassPathStatus() { fClassPathStatus.setOK(); List elements= fClassPathList.getElements(); boolean entryMissing= false; IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); boolean isChecked= fClassPathList.isChecked(currElement); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (!isChecked) { fClassPathList.setCheckedWithoutUpdate(currElement, true); } } else { currElement.setExported(isChecked); } entries[i]= currElement.getClasspathEntry(); entryMissing= entryMissing || currElement.isMissing(); } if (entryMissing) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.EntryMissing")); //$NON-NLS-1$ } if (fCurrJProject.hasClasspathCycle(entries)) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.CycleInClassPath")); //$NON-NLS-1$ } } /** * Validates output location & build path. */ private void updateBuildPathStatus() { fOutputLocationPath= null; String text= fBuildPathDialogField.getText(); if ("".equals(text)) { //$NON-NLS-1$ fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.EnterBuildPath")); //$NON-NLS-1$ return; } IPath path= getOutputLocation(); IResource res= fWorkspaceRoot.findMember(path); if (res != null) { // if exists, must be a folder or project if (res.getType() == IResource.FILE) { fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.InvalidBuildPath")); //$NON-NLS-1$ return; } } fOutputLocationPath= path; List elements= fClassPathList.getElements(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; boolean outputFolderAlsoSourceFolder= false; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); entries[i]= currElement.getClasspathEntry(); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE && fOutputLocationPath.equals(currElement.getPath())) { outputFolderAlsoSourceFolder= true; } } IStatus status= JavaConventions.validateClasspath(fCurrJProject, entries, path); if (!status.isOK()) { fBuildPathStatus.setError(status.getMessage()); return; } if (res != null && res.exists() && fCurrJProject.exists()) { try { IPath oldOutputLocation= fCurrJProject.getOutputLocation(); if (!oldOutputLocation.equals(fOutputLocationPath) && !outputFolderAlsoSourceFolder) { if (((IContainer)res).members().length > 0) { fBuildPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.OutputFolderNotEmpty")); //$NON-NLS-1$ return; } } } catch (CoreException e) { JavaPlugin.log(e); } } fBuildPathStatus.setOK(); } // -------- creation ------------------------------- public static void createProject(IProject project, IPath locationPath, IProgressMonitor monitor) throws CoreException { // create the project try { if (!project.exists()) { IProjectDescription desc= project.getWorkspace().newProjectDescription(project.getName()); if (Platform.getLocation().equals(locationPath)) { locationPath= null; } desc.setLocation(locationPath); project.create(desc, monitor); monitor= null; } if (!project.isOpen()) { project.open(monitor); monitor= null; } } finally { if (monitor != null) { monitor.done(); } } } public static void addJavaNature(IProject project, IProgressMonitor monitor) throws CoreException { if (!project.hasNature(JavaCore.NATURE_ID)) { IProjectDescription description = project.getDescription(); String[] prevNatures= description.getNatureIds(); String[] newNatures= new String[prevNatures.length + 1]; System.arraycopy(prevNatures, 0, newNatures, 0, prevNatures.length); newNatures[prevNatures.length]= JavaCore.NATURE_ID; description.setNatureIds(newNatures); project.setDescription(description, monitor); } } public void configureJavaProject(IProgressMonitor monitor) throws CoreException, InterruptedException { if (monitor == null) { monitor= new NullProgressMonitor(); } monitor.beginTask(NewWizardMessages.getString("BuildPathsBlock.operationdesc"), 10); //$NON-NLS-1$ try { Shell shell= null; if (fSWTWidget != null && !fSWTWidget.getShell().isDisposed()) { shell= fSWTWidget.getShell(); } internalConfigureJavaProject(fClassPathList.getElements(), getOutputLocation(), shell, monitor); } finally { monitor.done(); } } /** * Creates the Java project and sets the configured build path and output location. * If the project already exists only build paths are updated. */ private void internalConfigureJavaProject(List classPathEntries, IPath outputLocation, Shell shell, IProgressMonitor monitor) throws CoreException, InterruptedException { // 10 monitor steps to go IRemoveOldBinariesQuery reorgQuery= null; if (shell != null) { reorgQuery= getRemoveOldBinariesQuery(shell); } // remove old .class files if (reorgQuery != null) { IPath oldOutputLocation= fCurrJProject.getOutputLocation(); if (!outputLocation.equals(oldOutputLocation)) { IResource res= fWorkspaceRoot.findMember(oldOutputLocation); if (res instanceof IContainer && hasClassfiles(res)) { if (reorgQuery.doQuery(oldOutputLocation)) { removeOldClassfiles(res); } } } } // create and set the output path first if (!fWorkspaceRoot.exists(outputLocation)) { IFolder folder= fWorkspaceRoot.getFolder(outputLocation); CoreUtility.createFolder(folder, true, true, null); } monitor.worked(2); int nEntries= classPathEntries.size(); IClasspathEntry[] classpath= new IClasspathEntry[nEntries]; // create and set the class path for (int i= 0; i < nEntries; i++) { CPListElement entry= ((CPListElement)classPathEntries.get(i)); IResource res= entry.getResource(); if ((res instanceof IFolder) && !res.exists()) { CoreUtility.createFolder((IFolder)res, true, true, null); } classpath[i]= entry.getClasspathEntry(); // set javadoc location URL javadocLocation= entry.getJavadocLocation(); if (javadocLocation != null) { IPath path= entry.getPath(); if (entry.getEntryKind() == IClasspathEntry.CPE_VARIABLE) { path= JavaCore.getResolvedVariablePath(path); } if (path != null) { JavaDocLocations.setLibraryJavadocLocation(path, javadocLocation); } } } monitor.worked(1); fCurrJProject.setRawClasspath(classpath, outputLocation, new SubProgressMonitor(monitor, 7)); } public static boolean hasClassfiles(IResource resource) throws CoreException { if (resource.isDerived() && "class".equals(resource.getFileExtension())) { //$NON-NLS-1$ return true; } if (resource instanceof IContainer) { IResource[] members= ((IContainer) resource).members(); for (int i= 0; i < members.length; i++) { if (hasClassfiles(members[i])) { return true; } } } return false; } public static void removeOldClassfiles(IResource resource) throws CoreException { if (resource.isDerived() && "class".equals(resource.getFileExtension())) { //$NON-NLS-1$ resource.delete(false, null); } if (resource instanceof IContainer) { IResource[] members= ((IContainer) resource).members(); for (int i= 0; i < members.length; i++) { removeOldClassfiles(members[i]); } } } public static IRemoveOldBinariesQuery getRemoveOldBinariesQuery(final Shell shell) { return new IRemoveOldBinariesQuery() { public boolean doQuery(final IPath oldOutputLocation) throws InterruptedException { final int[] res= new int[] { 1 }; shell.getDisplay().syncExec(new Runnable() { public void run() { String title= NewWizardMessages.getString("BuildPathsBlock.RemoveBinariesDialog.title"); //$NON-NLS-1$ String message= NewWizardMessages.getFormattedString("BuildPathsBlock.RemoveBinariesDialog.description", oldOutputLocation.toString()); //$NON-NLS-1$ MessageDialog dialog= new MessageDialog(shell, title, null, message, MessageDialog.QUESTION, new String[] { IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }, 2); res[0]= dialog.open(); } }); if (res[0] == 0) { return true; } else if (res[0] == 1) { return false; } throw new InterruptedException(); } }; } // ---------- util method ------------ private IContainer chooseContainer() { Class[] acceptedClasses= new Class[] { IProject.class, IFolder.class }; ISelectionStatusValidator validator= new TypedElementSelectionValidator(acceptedClasses, false); IProject[] allProjects= fWorkspaceRoot.getProjects(); ArrayList rejectedElements= new ArrayList(allProjects.length); IProject currProject= fCurrJProject.getProject(); for (int i= 0; i < allProjects.length; i++) { if (!allProjects[i].equals(currProject)) { rejectedElements.add(allProjects[i]); } } ViewerFilter filter= new TypedViewerFilter(acceptedClasses, rejectedElements.toArray()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); IResource initSelection= null; if (fOutputLocationPath != null) { initSelection= fWorkspaceRoot.findMember(fOutputLocationPath); } ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setTitle(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.title")); //$NON-NLS-1$ dialog.setValidator(validator); dialog.setMessage(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(fWorkspaceRoot); dialog.setInitialSelection(initSelection); if (dialog.open() == dialog.OK) { return (IContainer)dialog.getFirstResult(); } return null; } // -------- tab switching ---------- private void tabChanged(Widget widget) { if (widget instanceof TabItem) { BuildPathBasePage newPage= (BuildPathBasePage) ((TabItem) widget).getData(); if (fCurrPage != null) { List selection= fCurrPage.getSelection(); if (!selection.isEmpty()) { newPage.setSelection(selection); } } fCurrPage= newPage; } } }
17,373
Bug 17373 create getter/setter - getter javadoc text [code manipulation]
The getter javadoc says: /** * Gets the name. * @return Returns a string */ It should be: /** * Returns the name. * @return returns the name */ I'm not sure about the second line, but I feel strongly about the first line. Also, I think the param lines should start with lower case letters.
resolved wontfix
cf852eb
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T18:31:52Z
2002-05-23T16:06:40Z
org.eclipse.jdt.ui/core
17,373
Bug 17373 create getter/setter - getter javadoc text [code manipulation]
The getter javadoc says: /** * Gets the name. * @return Returns a string */ It should be: /** * Returns the name. * @return returns the name */ I'm not sure about the second line, but I feel strongly about the first line. Also, I think the param lines should start with lower case letters.
resolved wontfix
cf852eb
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-27T18:31:52Z
2002-05-23T16:06:40Z
extension/org/eclipse/jdt/internal/corext/codemanipulation/AddGetterSetterOperation.java
17,396
Bug 17396 Organize import on multiple CUs flickers
20020521 Should use a WorkspaceModifyOperation
verified fixed
ac4ba83
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T09:16:47Z
2002-05-23T16:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/OrganizeImportsAction.java
package org.eclipse.jdt.ui.actions; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.Arrays; import java.util.HashSet; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.OperationCanceledException; import org.eclipse.core.runtime.Status; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.IEditorActionBarContributor; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IObjectActionDelegate; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.EditorActionBarContributor; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.internal.corext.codemanipulation.OrganizeImportsOperation; import org.eclipse.jdt.internal.corext.codemanipulation.OrganizeImportsOperation.IChooseImportQuery; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.corext.util.TypeInfo; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.WorkbenchRunnableAdapter; import org.eclipse.jdt.internal.ui.dialogs.MultiElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ProblemDialog; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.preferences.ImportOrganizePreferencePage; import org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.TypeInfoLabelProvider; public class OrganizeImportsAction extends SelectionDispatchAction { private JavaEditor fEditor; /* (non-Javadoc) * Class implements IObjectActionDelegate */ public static class ObjectDelegate implements IObjectActionDelegate { private OrganizeImportsAction fAction; public void setActivePart(IAction action, IWorkbenchPart targetPart) { fAction= new OrganizeImportsAction(targetPart.getSite()); } public void run(IAction action) { fAction.run(); } public void selectionChanged(IAction action, ISelection selection) { if (fAction == null) action.setEnabled(false); } } public OrganizeImportsAction(IWorkbenchSite site) { super(site); setText(ActionMessages.getString("OrganizeImportsAction.label")); //$NON-NLS-1$ setToolTipText(ActionMessages.getString("OrganizeImportsAction.tooltip")); //$NON-NLS-1$ setDescription(ActionMessages.getString("OrganizeImportsAction.description")); //$NON-NLS-1$ WorkbenchHelp.setHelp(this, IJavaHelpContextIds.ORGANIZE_IMPORTS_ACTION); } /** * Creates a new <code>OrganizeImportsAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public OrganizeImportsAction(JavaEditor editor) { this(editor.getEditorSite()); fEditor= editor; } /* package */ void editorStateChanged() { setEnabled(fEditor != null && !fEditor.isEditorInputReadOnly()); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(ITextSelection selection) { // do nothing } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(IStructuredSelection selection) { ICompilationUnit[] cus= getCompilationUnits(selection); boolean isEnabled= cus.length > 0; for (int i= 0; i < cus.length; i++) { if (!JavaModelUtil.isEditable(cus[i])) { isEnabled= false; break; } } setEnabled(isEnabled); } private ICompilationUnit[] getCompilationUnits(IStructuredSelection selection) { HashSet result= new HashSet(); Object[] selected= selection.toArray(); for (int i= 0; i < selected.length; i++) { try { if (selected[i] instanceof IJavaElement) { IJavaElement elem= (IJavaElement) selected[i]; switch (elem.getElementType()) { case IJavaElement.COMPILATION_UNIT: result.add(elem); break; case IJavaElement.IMPORT_CONTAINER: result.add(elem.getParent()); break; case IJavaElement.PACKAGE_FRAGMENT: IPackageFragment pack= (IPackageFragment) elem; result.addAll(Arrays.asList(pack.getCompilationUnits())); break; } } } catch (JavaModelException e) { JavaPlugin.log(e); } } return (ICompilationUnit[]) result.toArray(new ICompilationUnit[result.size()]); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(ITextSelection selection) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit cu= manager.getWorkingCopy(fEditor.getEditorInput()); runOnSingle(cu, true); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(IStructuredSelection selection) { ICompilationUnit[] cus= getCompilationUnits(selection); if (cus.length == 1) { runOnSingle(cus[0], true); } else { runOnMultiple(cus, true); } } private void runOnMultiple(final ICompilationUnit[] cus, final boolean doResolve) { try { String message= ActionMessages.getString("OrganizeImportsAction.multi.status.description"); //$NON-NLS-1$ final MultiStatus status= new MultiStatus(JavaUI.ID_PLUGIN, Status.OK, message, null); ProgressMonitorDialog dialog= new ProgressMonitorDialog(getShell()); dialog.run(false, true, new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { doRunOnMultiple(cus, status, doResolve, monitor); } }); if (!status.isOK()) { String title= ActionMessages.getString("OrganizeImportsAction.multi.status.title"); //$NON-NLS-1$ ProblemDialog.open(getShell(), title, null, status); } } catch (InvocationTargetException e) { ExceptionHandler.handle(e, getShell(), ActionMessages.getString("OrganizeImportsAction.error.title"), ActionMessages.getString("OrganizeImportsAction.error.message")); //$NON-NLS-1$ //$NON-NLS-2$ } catch (InterruptedException e) { // cancelled by user } } private void doRunOnMultiple(ICompilationUnit[] cus, MultiStatus status, boolean doResolve, IProgressMonitor monitor) throws InterruptedException { final class OrganizeImportError extends Error { } if (monitor == null) { monitor= new NullProgressMonitor(); } monitor.beginTask(ActionMessages.getString("OrganizeImportsAction.multi.op.description"), cus.length); //$NON-NLS-1$ try { String[] prefOrder= ImportOrganizePreferencePage.getImportOrderPreference(); int threshold= ImportOrganizePreferencePage.getImportNumberThreshold(); boolean ignoreLowerCaseNames= ImportOrganizePreferencePage.doIgnoreLowerCaseNames(); IChooseImportQuery query= new IChooseImportQuery() { public TypeInfo[] chooseImports(TypeInfo[][] openChoices, ISourceRange[] ranges) { throw new OrganizeImportError(); } }; for (int i= 0; i < cus.length; i++) { ICompilationUnit cu= cus[i]; try { if (!cu.isWorkingCopy()) { ICompilationUnit workingCopy= EditorUtility.getWorkingCopy(cu); if (workingCopy != null) { cu= workingCopy; } } OrganizeImportsOperation op= new OrganizeImportsOperation(cu, prefOrder, threshold, ignoreLowerCaseNames, !cu.isWorkingCopy(), doResolve, query); op.run(new SubProgressMonitor(monitor, 1)); ISourceRange errorRange= op.getErrorSourceRange(); if (errorRange != null) { String message= ActionMessages.getFormattedString("OrganizeImportsAction.multi.error.parse", cu.getElementName()); //$NON-NLS-1$ status.add(new Status(Status.INFO, JavaUI.ID_PLUGIN, Status.ERROR, message, null)); } } catch (OrganizeImportError e) { String message= ActionMessages.getFormattedString("OrganizeImportsAction.multi.error.unresolvable", cu.getElementName()); //$NON-NLS-1$ status.add(new Status(Status.INFO, JavaUI.ID_PLUGIN, Status.ERROR, message, null)); } catch (CoreException e) { JavaPlugin.log(e); String message= ActionMessages.getFormattedString("OrganizeImportsAction.multi.error.unexpected", e.getMessage()); //$NON-NLS-1$ status.add(new Status(Status.ERROR, JavaUI.ID_PLUGIN, Status.ERROR, message, null)); } catch (OperationCanceledException e) { throw new InterruptedException(); } } } finally { monitor.done(); } } private void runOnSingle(ICompilationUnit cu, boolean doResolve) { try { String[] prefOrder= ImportOrganizePreferencePage.getImportOrderPreference(); int threshold= ImportOrganizePreferencePage.getImportNumberThreshold(); boolean ignoreLowerCaseNames= ImportOrganizePreferencePage.doIgnoreLowerCaseNames(); if (!cu.isWorkingCopy()) { IEditorPart editor= EditorUtility.openInEditor(cu); if (editor instanceof JavaEditor) { fEditor= (JavaEditor) editor; } ICompilationUnit workingCopy= EditorUtility.getWorkingCopy(cu); if (workingCopy != null) { cu= workingCopy; } } OrganizeImportsOperation op= new OrganizeImportsOperation(cu, prefOrder, threshold, ignoreLowerCaseNames, !cu.isWorkingCopy(), doResolve, createChooseImportQuery()); BusyIndicatorRunnableContext context= new BusyIndicatorRunnableContext(); context.run(false, true, new WorkbenchRunnableAdapter(op)); ISourceRange errorRange= op.getErrorSourceRange(); if (errorRange != null) { MessageDialog.openInformation(getShell(), ActionMessages.getString("OrganizeImportsAction.error.title"), ActionMessages.getString("OrganizeImportsAction.single.error.parse")); //$NON-NLS-1$ //$NON-NLS-2$ if (fEditor != null) { fEditor.selectAndReveal(errorRange.getOffset(), errorRange.getLength()); } } else { if (fEditor != null) { setStatusBarMessage(getOrganizeInfo(op)); } } } catch (CoreException e) { ExceptionHandler.handle(e, getShell(), ActionMessages.getString("OrganizeImportsAction.error.title"), ActionMessages.getString("OrganizeImportsAction.error.message")); //$NON-NLS-1$ //$NON-NLS-2$ } catch (InvocationTargetException e) { ExceptionHandler.handle(e, getShell(), ActionMessages.getString("OrganizeImportsAction.error.title"), ActionMessages.getString("OrganizeImportsAction.error.message")); //$NON-NLS-1$ //$NON-NLS-2$ } catch (InterruptedException e) { } } private String getOrganizeInfo(OrganizeImportsOperation op) { int nImportsAdded= op.getNumberOfImportsAdded(); if (nImportsAdded >= 0) { return ActionMessages.getFormattedString("OrganizeImportsAction.summary_added", String.valueOf(nImportsAdded)); //$NON-NLS-1$ } else { return ActionMessages.getFormattedString("OrganizeImportsAction.summary_removed", String.valueOf(-nImportsAdded)); //$NON-NLS-1$ } } private IChooseImportQuery createChooseImportQuery() { return new IChooseImportQuery() { public TypeInfo[] chooseImports(TypeInfo[][] openChoices, ISourceRange[] ranges) { return doChooseImports(openChoices, ranges); } }; } private TypeInfo[] doChooseImports(TypeInfo[][] openChoices, final ISourceRange[] ranges) { // remember selection ISelection sel= fEditor.getSelectionProvider().getSelection(); TypeInfo[] result= null;; ILabelProvider labelProvider= new TypeInfoLabelProvider(TypeInfoLabelProvider.SHOW_FULLYQUALIFIED); MultiElementListSelectionDialog dialog= new MultiElementListSelectionDialog(getShell(), labelProvider) { protected void handleSelectionChanged() { super.handleSelectionChanged(); // show choices in editor doListSelectionChanged(getCurrentPage(), ranges); } }; dialog.setTitle(ActionMessages.getString("OrganizeImportsAction.selectiondialog.title")); //$NON-NLS-1$ dialog.setMessage(ActionMessages.getString("OrganizeImportsAction.selectiondialog.message")); //$NON-NLS-1$ dialog.setElements(openChoices); if (dialog.open() == dialog.OK) { Object[] res= dialog.getResult(); result= new TypeInfo[res.length]; for (int i= 0; i < res.length; i++) { Object[] array= (Object[]) res[i]; if (array.length > 0) result[i]= (TypeInfo) array[0]; } } // restore selection if (sel instanceof ITextSelection) { ITextSelection textSelection= (ITextSelection) sel; fEditor.selectAndReveal(textSelection.getOffset(), textSelection.getLength()); } return result; } private void doListSelectionChanged(int page, ISourceRange[] ranges) { if (page >= 0 && page < ranges.length) { ISourceRange range= ranges[page]; fEditor.selectAndReveal(range.getOffset(), range.getLength()); } } private void setStatusBarMessage(String message) { IEditorActionBarContributor contributor= fEditor.getEditorSite().getActionBarContributor(); if (contributor instanceof EditorActionBarContributor) { IStatusLineManager manager= ((EditorActionBarContributor) contributor).getActionBars().getStatusLineManager(); manager.setMessage(message); } } }
17,801
Bug 17801 Organize Imports dialog: default button should not be Cancel
Steps: 1) Create file that requires two ambiguous classes (List and ArrayList, for example) 2) Run Organize Imports 3) On first page of the dialog, the list has focus, allowing for easy keyboard selection of the class to use, and default button is next (all good) 4) Press next 5) The list no longer has focus, so can't use arrow keys to select the class to use, and the default button is Cancel (all bad). The list should maintain focus like on the first page, and the default button should be Finish. Using build F1.
verified fixed
75db65d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T09:39:56Z
2002-05-24T19:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/MultiElementListSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.text.MessageFormat; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.ui.dialogs.AbstractElementListSelectionDialog; import org.eclipse.core.runtime.IStatus; import org.eclipse.jdt.internal.ui.JavaUIMessages; /** * A class to select elements out of a list of elements, organized on multiple * pages. */ public class MultiElementListSelectionDialog extends AbstractElementListSelectionDialog { private static class Page { public Object[] elements; public String filter; public boolean okState= false; public Page(Object[] elements) { this.elements= elements; } }; private Page[] fPages; private int fCurrentPage; private int fNumberOfPages; private Button fFinishButton; private Button fBackButton; private Button fNextButton; private Label fPageInfoLabel; private String fPageInfoMessage= JavaUIMessages.getString("MultiElementListSelectionDialog.pageInfoMessage"); //$NON-NLS-1$; /** * Constructs a multi-page list selection dialog. * @param renderer the label renderer. * @param ignoreCase specifies if sorting and filtering ignores cases. * @param multipleSelection specifies if multiple selection is allowed. */ public MultiElementListSelectionDialog(Shell parent, ILabelProvider renderer) { super(parent, renderer); } /** * Sets message shown in the right top corner. Use {0} and {1} as placeholders * for the current and the total number of pages. * @param message the message. */ public void setPageInfoMessage(String message) { fPageInfoMessage= message; } /** * Sets the elements to be displayed in the dialog. * @param elements an array of pages holding arrays of elements */ public void setElements(Object[][] elements) { fNumberOfPages= elements.length; fPages= new Page[fNumberOfPages]; for (int i= 0; i != fNumberOfPages; i++) fPages[i]= new Page(elements[i]); initializeResult(fNumberOfPages); } /* * @see Window#open() */ public int open() { List selection= getInitialSelections(); if (selection == null) { setInitialSelections(new Object[fNumberOfPages]); selection= getInitialSelections(); } Assert.isTrue(selection.size() == fNumberOfPages); return super.open(); } /** * @see Dialog#createDialogArea(Composite) */ protected Control createDialogArea(Composite parent) { Composite contents= (Composite) super.createDialogArea(parent); createMessageArea(contents); createFilterText(contents); createFilteredList(contents); fCurrentPage= 0; setPageData(); return contents; } /** * @see Dialog#createButtonsForButtonBar(Composite) */ protected void createButtonsForButtonBar(Composite parent) { fBackButton= createButton(parent, IDialogConstants.BACK_ID, IDialogConstants.BACK_LABEL, false); fNextButton= createButton(parent, IDialogConstants.NEXT_ID, IDialogConstants.NEXT_LABEL, true); fFinishButton= createButton(parent, IDialogConstants.OK_ID, IDialogConstants.FINISH_LABEL, false); createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.CANCEL_LABEL, false); } /** * @see SelectionDialog#createMessageArea(Composite) */ protected Label createMessageArea(Composite parent) { Composite composite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.horizontalSpacing= 5; layout.numColumns= 2; composite.setLayout(layout); GridData data= new GridData(GridData.HORIZONTAL_ALIGN_FILL); composite.setLayoutData(data); Label messageLabel= super.createMessageArea(composite); fPageInfoLabel= new Label(composite, SWT.NULL); fPageInfoLabel.setText(getPageInfoMessage()); data= new GridData(GridData.HORIZONTAL_ALIGN_FILL); data.horizontalAlignment= data.END; fPageInfoLabel.setLayoutData(data); return messageLabel; } /** * @see SelectionStatusDialog#computeResult() */ protected void computeResult() { setResult(fCurrentPage, getSelectedElements()); } /** * @see Dialog#buttonPressed(int) */ protected void buttonPressed(int buttonId) { if (buttonId == IDialogConstants.BACK_ID) { turnPage(false); } else if (buttonId == IDialogConstants.NEXT_ID) { turnPage(true); } else { super.buttonPressed(buttonId); } } /** * @see AbstractElementListSelectionDialog#handleDefaultSelected() */ protected void handleDefaultSelected() { if (validateCurrentSelection()) { if (fCurrentPage == fNumberOfPages - 1) { buttonPressed(IDialogConstants.OK_ID); } else { buttonPressed(IDialogConstants.NEXT_ID); } } } /** * @see AbstractElementListSelectionDialog#updateButtonsEnableState(IStatus) */ protected void updateButtonsEnableState(IStatus status) { boolean isOK= !status.matches(IStatus.ERROR); fPages[fCurrentPage].okState= isOK; fNextButton.setEnabled(isOK && (fCurrentPage < fNumberOfPages - 1)); fBackButton.setEnabled(fCurrentPage != 0); boolean isAllOK= isOK; for (int i= 0; i != fNumberOfPages; i++) isAllOK = isAllOK && fPages[i].okState; fFinishButton.setEnabled(isAllOK); } private void turnPage(boolean toNextPage) { Page page= fPages[fCurrentPage]; // store filter String filter= getFilter(); if (filter == null) filter= ""; //$NON-NLS-1$ page.filter= filter; // store selection Object[] selectedElements= getSelectedElements(); List list= getInitialSelections(); list.set(fCurrentPage, selectedElements); // store result setResult(fCurrentPage, getSelectedElements()); if (toNextPage) { if (fCurrentPage + 1 >= fNumberOfPages) return; fCurrentPage++; } else { if (fCurrentPage - 1 < 0) return; fCurrentPage--; } if (fPageInfoLabel != null && !fPageInfoLabel.isDisposed()) fPageInfoLabel.setText(getPageInfoMessage()); setPageData(); validateCurrentSelection(); } private void setPageData() { Page page= fPages[fCurrentPage]; // 1. set elements setListElements(page.elements); // 2. apply filter String filter= page.filter; if (filter == null) filter= ""; //$NON-NLS-1$ setFilter(filter); // 3. select elements Object[] selectedElements= (Object[]) getInitialSelections().get(fCurrentPage); setSelection(selectedElements); } private String getPageInfoMessage() { if (fPageInfoMessage == null) return ""; //$NON-NLS-1$ String[] args= new String[] { Integer.toString(fCurrentPage + 1), Integer.toString(fNumberOfPages) }; return MessageFormat.format(fPageInfoMessage, args); } private void initializeResult(int length) { List result= new ArrayList(length); for (int i= 0; i != length; i++) result.add(null); setResult(result); } /** * Gets the current Page. * @return Returns a int */ public int getCurrentPage() { return fCurrentPage; } }
17,271
Bug 17271 Not present exception renaming class in java browsing perspective
Build 20020521 (running with java delta tracing) 1. Create the following CU: public class HelloWorld { } 2. Open Java Browsing perspective 3. Open HelloWorld 4. In java editor, rename HelloWorld to Hellorld2 5. Save Observe the following in the console: UPDATING Model with Delta: [Thread[main,5,main]:HelloWorld.java[*]: {CHILDREN | FINE GRAINED} HelloWorld2[+]: {} HelloWorld[-]: {}]: FIRING PRE_AUTO_BUILD Delta [Thread[main,5,main]]: HelloWorld.java[*]: {CHILDREN | FINE GRAINED} HelloWorld2[+]: {} HelloWorld[-]: {} MERGING 2 DELTAS [Thread[main,5,main]] HelloWorld.java[*]: {CHILDREN | FINE GRAINED} HelloWorld2[+]: {} HelloWorld[-]: {} Java Model[*]: {CHILDREN} Test[*]: {CHILDREN} [project root][*]: {CHILDREN} [default][*]: {CHILDREN} HelloWorld.java[*]: {CONTENT} FIRING POST_CHANGE Delta [Thread[main,5,main]]: Java Model[*]: {CHILDREN} Test[*]: {CHILDREN} [project root][*]: {CHILDREN} [default][*]: {CHILDREN} HelloWorld.java[*]: {CHILDREN | FINE GRAINED} HelloWorld2[+]: {} HelloWorld[-]: {} !ENTRY org.eclipse.jdt.ui 4 1 May 23, 2002 16:01:58.72 !MESSAGE Internal Error !STACK 1 Java Model Exception: Java Model Status [HelloWorld does not exist.] at org.eclipse.jdt.internal.core.JavaElement.newNotPresentException (JavaElement.java:501) at org.eclipse.jdt.internal.core.JavaElement.openHierarchy (JavaElement.java:530) at org.eclipse.jdt.internal.core.JavaElement.getElementInfo (JavaElement.java:309) at org.eclipse.jdt.internal.core.JavaElement.getChildren (JavaElement.java:266) at org.eclipse.jdt.internal.core.JavaElement.getChildrenOfType (JavaElement.java:275) at org.eclipse.jdt.internal.core.SourceType.getFields (SourceType.java:178) at org.eclipse.jdt.ui.actions.AddGetterSetterAction.canEnableOn (AddGetterSetterAction.java:168) at org.eclipse.jdt.ui.actions.AddGetterSetterAction.canEnable (AddGetterSetterAction.java:157) at org.eclipse.jdt.ui.actions.AddGetterSetterAction.selectionChanged (AddGetterSetterAction.java:123) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchSelectionChanged (SelectionDispatchAction.java:168) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.selectionChanged (SelectionDispatchAction.java:163) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged (Viewer.java:147) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:1154) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:544) at org.eclipse.jface.viewers.StructuredViewer$1.widgetSelected (StructuredViewer.java:568) at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent (OpenStrategy.java:171) at org.eclipse.jface.util.OpenStrategy.access$3(OpenStrategy.java:168) at org.eclipse.jface.util.OpenStrategy$1.handleEvent (OpenStrategy.java:297) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:432) at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24) !ENTRY org.eclipse.jdt.core 4 969 May 23, 2002 16:01:58.72 !MESSAGE HelloWorld does not exist. !ENTRY org.eclipse.jdt.ui 4 1 May 23, 2002 16:01:58.102 !MESSAGE An error occurred while accessing a Java element !STACK 1 Java Model Exception: Java Model Status [HelloWorld does not exist.] at org.eclipse.jdt.internal.core.JavaElement.newNotPresentException (JavaElement.java:501) at org.eclipse.jdt.internal.core.JavaElement.openHierarchy (JavaElement.java:530) at org.eclipse.jdt.internal.core.JavaElement.getElementInfo (JavaElement.java:309) at org.eclipse.jdt.internal.core.SourceType.isInterface (SourceType.java:320) at org.eclipse.jdt.ui.actions.FindImplementorsAction.canOperateOn (FindImplementorsAction.java:69) at org.eclipse.jdt.ui.actions.FindAction.canOperateOn (FindAction.java:91) at org.eclipse.jdt.ui.actions.FindAction.selectionChanged (FindAction.java:257) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchSelectionChanged (SelectionDispatchAction.java:168) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.selectionChanged (SelectionDispatchAction.java:163) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged (Viewer.java:147) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:1154) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:544) at org.eclipse.jface.viewers.StructuredViewer$1.widgetSelected (StructuredViewer.java:568) at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent (OpenStrategy.java:171) at org.eclipse.jface.util.OpenStrategy.access$3(OpenStrategy.java:168) at org.eclipse.jface.util.OpenStrategy$1.handleEvent (OpenStrategy.java:297) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:432) at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24) !ENTRY org.eclipse.jdt.core 4 969 May 23, 2002 16:01:58.102 !MESSAGE HelloWorld does not exist. !ENTRY org.eclipse.jdt.ui 4 1 May 23, 2002 16:01:58.112 !MESSAGE An error occurred while accessing a Java element !STACK 1 Java Model Exception: Java Model Status [HelloWorld does not exist.] at org.eclipse.jdt.internal.core.JavaElement.newNotPresentException (JavaElement.java:501) at org.eclipse.jdt.internal.core.JavaElement.openHierarchy (JavaElement.java:530) at org.eclipse.jdt.internal.core.JavaElement.getElementInfo (JavaElement.java:309) at org.eclipse.jdt.internal.core.SourceType.isInterface (SourceType.java:320) at org.eclipse.jdt.ui.actions.FindImplementorsAction.canOperateOn (FindImplementorsAction.java:69) at org.eclipse.jdt.ui.actions.FindAction.canOperateOn (FindAction.java:91) at org.eclipse.jdt.ui.actions.FindAction.selectionChanged (FindAction.java:257) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchSelectionChanged (SelectionDispatchAction.java:168) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.selectionChanged (SelectionDispatchAction.java:163) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged (Viewer.java:147) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:1154) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:544) at org.eclipse.jface.viewers.StructuredViewer$1.widgetSelected (StructuredViewer.java:568) at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent (OpenStrategy.java:171) at org.eclipse.jface.util.OpenStrategy.access$3(OpenStrategy.java:168) at org.eclipse.jface.util.OpenStrategy$1.handleEvent (OpenStrategy.java:297) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:432) at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24) !ENTRY org.eclipse.jdt.core 4 969 May 23, 2002 16:01:58.112 !MESSAGE HelloWorld does not exist.
verified fixed
5f7562f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T10:40:34Z
2002-05-23T13:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/JavaBrowsingContentProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.Iterator; import java.util.List; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.jface.viewers.AbstractTreeViewer; import org.eclipse.jface.viewers.IBasicPropertyConstants; import org.eclipse.jface.viewers.ListViewer; import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.jface.viewers.TableViewer; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jdt.core.ElementChangedEvent; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IElementChangedListener; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaElementDelta; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageDeclaration; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.IParent; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.ui.StandardJavaElementContentProvider; class JavaBrowsingContentProvider extends StandardJavaElementContentProvider implements IElementChangedListener { private StructuredViewer fViewer; private Object fInput; private JavaBrowsingPart fBrowsingPart; public JavaBrowsingContentProvider(boolean provideMembers, JavaBrowsingPart browsingPart) { super(provideMembers, reconcileJavaViews()); fBrowsingPart= browsingPart; fViewer= fBrowsingPart.getViewer(); JavaCore.addElementChangedListener(this); } private static boolean reconcileJavaViews() { return JavaBasePreferencePage.reconcileJavaViews(); } public Object[] getChildren(Object element) { if (!exists(element)) return NO_CHILDREN; try { if (element instanceof Collection) { Collection elements= (Collection)element; if (elements.isEmpty()) return NO_CHILDREN; Object[] result= new Object[0]; Iterator iter= ((Collection)element).iterator(); while (iter.hasNext()) { Object[] children= getChildren(iter.next()); if (children != NO_CHILDREN) result= concatenate(result, children); } return result; } if (element instanceof IPackageFragment) return getPackageContents((IPackageFragment)element); if (fProvideMembers && element instanceof IType) return getChildren((IType)element); if (fProvideMembers && element instanceof ISourceReference && element instanceof IParent) return removeImportAndPackageDeclarations(super.getChildren(element)); if (element instanceof IJavaProject) return getPackageFragmentRoots((IJavaProject)element); return super.getChildren(element); } catch (JavaModelException e) { return NO_CHILDREN; } } private Object[] getPackageContents(IPackageFragment fragment) throws JavaModelException { ISourceReference[] sourceRefs; if (fragment.getKind() == IPackageFragmentRoot.K_SOURCE) { sourceRefs= fragment.getCompilationUnits(); if (getProvideWorkingCopy()) { for (int i= 0; i < sourceRefs.length; i++) { IWorkingCopy wc= EditorUtility.getWorkingCopy((ICompilationUnit)sourceRefs[i]); if (wc != null) sourceRefs[i]= (ICompilationUnit)wc; } } } else { IClassFile[] classFiles= fragment.getClassFiles(); List topLevelClassFile= new ArrayList(); for (int i= 0; i < classFiles.length; i++) { IType type= classFiles[i].getType(); if (type != null && type.getDeclaringType() == null) topLevelClassFile.add(classFiles[i]); } sourceRefs= (ISourceReference[])topLevelClassFile.toArray(new ISourceReference[topLevelClassFile.size()]); } Object[] result= new Object[0]; for (int i= 0; i < sourceRefs.length; i++) result= concatenate(result, removeImportAndPackageDeclarations(getChildren(sourceRefs[i]))); return concatenate(result, fragment.getNonJavaResources()); } private Object[] removeImportAndPackageDeclarations(Object[] members) { ArrayList tempResult= new ArrayList(members.length); for (int i= 0; i < members.length; i++) if (!(members[i] instanceof IImportContainer) && !(members[i] instanceof IPackageDeclaration)) tempResult.add(members[i]); return tempResult.toArray(); } private Object[] getChildren(IType type) throws JavaModelException{ IParent parent; if (type.isBinary()) parent= type.getClassFile(); else { parent= type.getCompilationUnit(); if (getProvideWorkingCopy()) { IWorkingCopy wc= EditorUtility.getWorkingCopy((ICompilationUnit)parent); if (wc != null) { parent= (IParent)wc; IMember wcType= EditorUtility.getWorkingCopy(type); if (wcType != null) type= (IType)wcType; } } } if (type.getDeclaringType() != null) return type.getChildren(); // Add import declarations IJavaElement[] members= parent.getChildren(); ArrayList tempResult= new ArrayList(members.length); for (int i= 0; i < members.length; i++) if ((members[i] instanceof IImportContainer)) tempResult.add(members[i]); tempResult.addAll(Arrays.asList(type.getChildren())); return tempResult.toArray(); } private Object[] getPackageFragmentRoots(IJavaProject project) throws JavaModelException { if (!project.getProject().isOpen()) return NO_CHILDREN; IPackageFragmentRoot[] roots= project.getPackageFragmentRoots(); List list= new ArrayList(roots.length); // filter out package fragments that correspond to projects and // replace them with the package fragments directly for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot root= (IPackageFragmentRoot)roots[i]; if (!root.isExternal()) { Object[] children= root.getChildren(); for (int k= 0; k < children.length; k++) list.add(children[k]); } else if (hasChildren(root)) { list.add(root); } } return concatenate(list.toArray(), project.getNonJavaResources()); } // ---------------- Element change handling /* (non-Javadoc) * Method declared on IContentProvider. */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { super.inputChanged(viewer, oldInput, newInput); if (newInput instanceof Collection) { // Get a template object from the collection Collection col= (Collection)newInput; if (!col.isEmpty()) newInput= col.iterator().next(); else newInput= null; } fInput= newInput; } /* (non-Javadoc) * Method declared on IContentProvider. */ public void dispose() { super.dispose(); JavaCore.removeElementChangedListener(this); } /* (non-Javadoc) * Method declared on IElementChangedListener. */ public void elementChanged(final ElementChangedEvent event) { try { processDelta(event.getDelta()); } catch(JavaModelException e) { JavaPlugin.getDefault().log(e.getStatus()); //$NON-NLS-1$ } } /** * Processes a delta recursively. When more than two children are affected the * tree is fully refreshed starting at this node. The delta is processed in the * current thread but the viewer updates are posted to the UI thread. */ protected void processDelta(IJavaElementDelta delta) throws JavaModelException { int kind= delta.getKind(); int flags= delta.getFlags(); IJavaElement element= delta.getElement(); if (!getProvideWorkingCopy() && element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { return; } // handle open and closing of a solution or project if (((flags & IJavaElementDelta.F_CLOSED) != 0) || ((flags & IJavaElementDelta.F_OPENED) != 0)) { postRefresh(element); return; } if (kind == IJavaElementDelta.REMOVED) { Object parent= internalGetParent(element); if (fBrowsingPart.isValidElement(element)) { if (element instanceof IClassFile) { postRemove(((IClassFile)element).getType()); } else if (element instanceof ICompilationUnit && !((ICompilationUnit)element).isWorkingCopy()) { // if (!getProvideWorkingCopy()) postRefresh(null); } else if (element instanceof ICompilationUnit && ((ICompilationUnit)element).isWorkingCopy()) { if (getProvideWorkingCopy()) postRefresh(null); } else if (parent instanceof ICompilationUnit && getProvideWorkingCopy() && !((ICompilationUnit)parent).isWorkingCopy()) { if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { // working copy removed from system - refresh postRefresh(null); } } else if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy() && parent != null && parent.equals(fInput)) // closed editor - removing working copy postRefresh(null); else postRemove(element); } if (fBrowsingPart.isAncestorOf(element, fInput)) { if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { postAdjustInputAndSetSelection(((IWorkingCopy)element).getOriginal((IJavaElement)fInput)); } else postAdjustInputAndSetSelection(null); } return; } if (kind == IJavaElementDelta.ADDED && delta.getMovedFromElement() != null && element instanceof ICompilationUnit) return; if (kind == IJavaElementDelta.ADDED) { if (fBrowsingPart.isValidElement(element)) { Object parent= internalGetParent(element); if (element instanceof IClassFile) { postAdd(parent, ((IClassFile)element).getType()); } else if (element instanceof ICompilationUnit && !((ICompilationUnit)element).isWorkingCopy()) { // if (!getProvideWorkingCopy()) postAdd(parent, ((ICompilationUnit)element).getAllTypes()); } else if (parent instanceof ICompilationUnit && getProvideWorkingCopy() && !((ICompilationUnit)parent).isWorkingCopy()) { // do nothing } else if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { // new working copy comes to live postRefresh(null); } else postAdd(parent, element); } else if (fInput == null) { IJavaElement newInput= fBrowsingPart.findInputForJavaElement(element); if (newInput != null) postAdjustInputAndSetSelection(element); } else if (element instanceof IType && fBrowsingPart.isValidInput(element)) { IJavaElement cu1= element.getAncestor(IJavaElement.COMPILATION_UNIT); IJavaElement cu2= ((IJavaElement)fInput).getAncestor(IJavaElement.COMPILATION_UNIT); if (cu1 != null && cu2 != null && cu1.equals(cu2)) postAdjustInputAndSetSelection(element); } return; } if (kind == IJavaElementDelta.CHANGED) { if (fBrowsingPart.isValidElement(element)) { postRefresh(element); } } if (isClassPathChange(delta)) // throw the towel and do a full refresh postRefresh(null); IJavaElementDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren.length > 1) { // a package fragment might become non empty refresh from the parent if (element instanceof IPackageFragment) { IJavaElement parent= (IJavaElement)internalGetParent(element); // avoid posting a refresh to an unvisible parent if (element.equals(fInput)) { postRefresh(element); } else { postRefresh(parent); } } // more than one child changed, refresh from here downwards if (element instanceof IPackageFragmentRoot && fBrowsingPart.isValidElement(element)) { postRefresh(skipProjectPackageFragmentRoot((IPackageFragmentRoot)element)); return; } } for (int i= 0; i < affectedChildren.length; i++) { processDelta(affectedChildren[i]); } } /** * Updates the package icon */ private void updatePackageIcon(final IJavaElement element) { postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.update(element, new String[]{IBasicPropertyConstants.P_IMAGE}); } }); } private void postRefresh(final Object root) { postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.refresh(root); } }); } private void postAdd(final Object parent, final Object element) { postAdd(parent, new Object[] {element}); } private void postAdd(final Object parent, final Object[] elements) { if (elements.length <= 0) return; postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.setRedraw(false); if (fViewer instanceof AbstractTreeViewer) { if (fViewer.testFindItem(parent) == null) { Object root= ((AbstractTreeViewer)fViewer).getInput(); if (root != null) ((AbstractTreeViewer)fViewer).add(root, elements); } else ((AbstractTreeViewer)fViewer).add(parent, elements); } else if (fViewer instanceof ListViewer) ((ListViewer)fViewer).add(elements); else if (fViewer instanceof TableViewer) ((TableViewer)fViewer).add(elements); if (fViewer.testFindItem(elements[0]) != null) fBrowsingPart.adjustInputAndSetSelection((IJavaElement)elements[0]); ctrl.setRedraw(true); } } }); } private void postRemove(final Object element) { postRemove(new Object[] {element}); } private void postRemove(final Object[] elements) { if (elements.length <= 0) return; postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.setRedraw(false); if (fViewer instanceof AbstractTreeViewer) ((AbstractTreeViewer)fViewer).remove(elements); else if (fViewer instanceof ListViewer) ((ListViewer)fViewer).remove(elements); else if (fViewer instanceof TableViewer) ((TableViewer)fViewer).remove(elements); ctrl.setRedraw(true); } } }); } private void postAdjustInputAndSetSelection(final Object element) { postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.setRedraw(false); fBrowsingPart.adjustInputAndSetSelection((IJavaElement)element); ctrl.setRedraw(true); } } }); } private void postRunnable(final Runnable r) { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { fBrowsingPart.setProcessSelectionEvents(false); try { Display currentDisplay= ctrl.getDisplay().getCurrent(); if (currentDisplay != null && currentDisplay.equals(ctrl.getDisplay())) ctrl.getDisplay().syncExec(r); else ctrl.getDisplay().asyncExec(r); } finally { fBrowsingPart.setProcessSelectionEvents(true); } } } }
16,923
Bug 16923 Auto activation preference dialog
The auto activation characters and Timeout Text fields are enabled even when Auto activation itself is disabled. This was confusing to me because I thought that "." should cause automatic code assist, but it wasn't. Disabling the feature should disable the controls what modify the details for that feature.
verified fixed
7c12a6c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T10:48:10Z
2002-05-22T17:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.Map; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.layout.RowLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.List; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.ui.texteditor.WorkbenchChainedTextFontFieldEditor; import org.eclipse.jdt.ui.text.IJavaColorConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; /* * The page for setting the editor options. */ public class JavaEditorPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { public static final String BOLD= "_bold"; //$NON-NLS-1$ public static final String PREF_SHOW_TEMP_PROBLEMS= "JavaEditor.ShowTemporaryProblem"; //$NON-NLS-1$ public static final String PREF_SYNC_OUTLINE_ON_CURSOR_MOVE= "JavaEditor.SyncOutlineOnCursorMove"; //$NON-NLS-1$ public final OverlayPreferenceStore.OverlayKey[] fKeys= new OverlayPreferenceStore.OverlayKey[] { new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_KEYWORD + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_STRING), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_STRING + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_DEFAULT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_KEYWORD + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_TAG), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_TAG + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_LINK), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_LINK + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_DEFAULT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.MATCHING_BRACKETS_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.MATCHING_BRACKETS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.CURRENT_LINE_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.CURRENT_LINE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.PRINT_MARGIN_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, CompilationUnitEditor.PRINT_MARGIN_COLUMN), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.PRINT_MARGIN), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.LINKED_POSITION_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.PROBLEM_INDICATION_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.PROBLEM_INDICATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.OVERVIEW_RULER), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, JavaEditor.LINE_NUMBER_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditor.LINE_NUMBER_RULER), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.SPACES_FOR_TABS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOACTIVATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, ContentAssistPreference.AUTOACTIVATION_DELAY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOINSERT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ORDER_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.CASE_SENSITIVITY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ADD_IMPORT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.FILL_METHOD_ARGUMENTS) }; private final String[][] fSyntaxColorListModel= new String[][] { { JavaUIMessages.getString("JavaEditorPreferencePage.multiLineComment"), IJavaColorConstants.JAVA_MULTI_LINE_COMMENT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.singleLineComment"), IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.keywords"), IJavaColorConstants.JAVA_KEYWORD }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.strings"), IJavaColorConstants.JAVA_STRING }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.others"), IJavaColorConstants.JAVA_DEFAULT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocKeywords"), IJavaColorConstants.JAVADOC_KEYWORD }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocHtmlTags"), IJavaColorConstants.JAVADOC_TAG }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocLinks"), IJavaColorConstants.JAVADOC_LINK }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocOthers"), IJavaColorConstants.JAVADOC_DEFAULT } //$NON-NLS-1$ }; private final String[][] fAppearanceColorListModel= new String[][] { {JavaUIMessages.getString("JavaEditorPreferencePage.lineNumberForegroundColor"), JavaEditor.LINE_NUMBER_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.matchingBracketsHighlightColor2"), CompilationUnitEditor.MATCHING_BRACKETS_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.currentLineHighlighColor"), CompilationUnitEditor.CURRENT_LINE_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.problemsHighlightColor"), CompilationUnitEditor.PROBLEM_INDICATION_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.printMarginColor2"), CompilationUnitEditor.PRINT_MARGIN_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.findScopeColor2"), AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.linkedPositionColor2"), CompilationUnitEditor.LINKED_POSITION_COLOR}, //$NON-NLS-1$ }; private OverlayPreferenceStore fOverlayStore; private JavaTextTools fJavaTextTools; private Map fColorButtons= new HashMap(); private SelectionListener fColorButtonListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { ColorEditor editor= (ColorEditor) e.widget.getData(); PreferenceConverter.setValue(fOverlayStore, (String) fColorButtons.get(editor), editor.getColorValue()); } }; private Map fCheckBoxes= new HashMap(); private SelectionListener fCheckBoxListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { Button button= (Button) e.widget; fOverlayStore.setValue((String) fCheckBoxes.get(button), button.getSelection()); } }; private Map fTextFields= new HashMap(); private ModifyListener fTextFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { Text text= (Text) e.widget; fOverlayStore.setValue((String) fTextFields.get(text), text.getText()); } }; private ArrayList fNumberFields= new ArrayList(); private ModifyListener fNumberFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { numberFieldChanged((Text) e.widget); } }; private WorkbenchChainedTextFontFieldEditor fFontEditor; private List fSyntaxColorList; private List fAppearanceColorList; private ColorEditor fSyntaxForegroundColorEditor; private ColorEditor fAppearanceForegroundColorEditor; private ColorEditor fBackgroundColorEditor; private Button fBackgroundDefaultRadioButton; private Button fBackgroundCustomRadioButton; private Button fBackgroundColorButton; private Button fBoldCheckBox; private SourceViewer fPreviewViewer; private Color fBackgroundColor; public JavaEditorPreferencePage() { setDescription(JavaUIMessages.getString("JavaEditorPreferencePage.description")); //$NON-NLS-1$ setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); fOverlayStore= new OverlayPreferenceStore(getPreferenceStore(), fKeys); } public static void initDefaults(IPreferenceStore store) { /* * Ensure that the display is accessed only in the UI thread. * Ensure that there are no side effects of switching the thread. */ final RGB[] rgbs= new RGB[3]; final Display display= Display.getDefault(); display.syncExec(new Runnable() { public void run() { Color c= display.getSystemColor(SWT.COLOR_GRAY); rgbs[0]= c.getRGB(); c= display.getSystemColor(SWT.COLOR_LIST_FOREGROUND); rgbs[1]= c.getRGB(); c= display.getSystemColor(SWT.COLOR_LIST_BACKGROUND); rgbs[2]= c.getRGB(); } }); /* * Go on in whatever thread this is. */ store.setDefault(CompilationUnitEditor.MATCHING_BRACKETS, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.MATCHING_BRACKETS_COLOR, rgbs[0]); store.setDefault(CompilationUnitEditor.CURRENT_LINE, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.CURRENT_LINE_COLOR, new RGB(225, 235, 224)); store.setDefault(CompilationUnitEditor.PRINT_MARGIN, false); store.setDefault(CompilationUnitEditor.PRINT_MARGIN_COLUMN, 80); PreferenceConverter.setDefault(store, CompilationUnitEditor.PRINT_MARGIN_COLOR, new RGB(176, 180 , 185)); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE, new RGB(185, 176 , 180)); store.setDefault(CompilationUnitEditor.PROBLEM_INDICATION, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.PROBLEM_INDICATION_COLOR, new RGB(255, 0 , 128)); store.setDefault(JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS, true); store.setDefault(JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE, false); store.setDefault(CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS, true); store.setDefault(CompilationUnitEditor.OVERVIEW_RULER, true); store.setDefault(JavaEditor.LINE_NUMBER_RULER, false); PreferenceConverter.setDefault(store, JavaEditor.LINE_NUMBER_COLOR, new RGB(0, 0, 0)); WorkbenchChainedTextFontFieldEditor.startPropagate(store, JFaceResources.TEXT_FONT); PreferenceConverter.setDefault(store, CompilationUnitEditor.LINKED_POSITION_COLOR, new RGB(0, 200 , 100)); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND, rgbs[1]); store.setDefault(AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT, true); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, rgbs[2]); store.setDefault(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT, true); store.setDefault(JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 4); store.setDefault(CompilationUnitEditor.SPACES_FOR_TABS, false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_KEYWORD, new RGB(127, 0, 85)); store.setDefault(IJavaColorConstants.JAVA_KEYWORD + "_bold", true); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_STRING, new RGB(42, 0, 255)); store.setDefault(IJavaColorConstants.JAVA_STRING + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_DEFAULT, new RGB(0, 0, 0)); store.setDefault(IJavaColorConstants.JAVA_DEFAULT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_KEYWORD, new RGB(127, 159, 191)); store.setDefault(IJavaColorConstants.JAVADOC_KEYWORD + "_bold", true); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_TAG, new RGB(127, 127, 159)); store.setDefault(IJavaColorConstants.JAVADOC_TAG + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_LINK, new RGB(63, 63, 191)); store.setDefault(IJavaColorConstants.JAVADOC_LINK + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_DEFAULT, new RGB(63, 95, 191)); store.setDefault(IJavaColorConstants.JAVADOC_DEFAULT + "_bold", false); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.AUTOACTIVATION, true); store.setDefault(ContentAssistPreference.AUTOACTIVATION_DELAY, 500); store.setDefault(ContentAssistPreference.AUTOINSERT, true); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_FOREGROUND, new RGB(0, 0, 0)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_FOREGROUND, new RGB(0, 0, 0)); store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, "."); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, "@"); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, true); store.setDefault(ContentAssistPreference.CASE_SENSITIVITY, false); store.setDefault(ContentAssistPreference.ORDER_PROPOSALS, false); store.setDefault(ContentAssistPreference.ADD_IMPORT, true); store.setDefault(ContentAssistPreference.FILL_METHOD_ARGUMENTS, false); } /* * @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /* * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), IJavaHelpContextIds.JAVA_EDITOR_PREFERENCE_PAGE); } private void handleSyntaxColorListSelection() { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fSyntaxForegroundColorEditor.setColorValue(rgb); fBoldCheckBox.setSelection(fOverlayStore.getBoolean(key + BOLD)); } private void handleAppearanceColorListSelection() { int i= fAppearanceColorList.getSelectionIndex(); String key= fAppearanceColorListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fAppearanceForegroundColorEditor.setColorValue(rgb); } private Control createColorPage(Composite parent) { Composite colorComposite= new Composite(parent, SWT.NULL); colorComposite.setLayout(new GridLayout()); Composite backgroundComposite= new Composite(colorComposite, SWT.NULL); backgroundComposite.setLayout(new RowLayout()); Label label= new Label(backgroundComposite, SWT.NULL); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.backgroundColor")); //$NON-NLS-1$ SelectionListener backgroundSelectionListener= new SelectionListener() { public void widgetSelected(SelectionEvent e) { boolean custom= fBackgroundCustomRadioButton.getSelection(); fBackgroundColorButton.setEnabled(custom); fOverlayStore.setValue(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT, !custom); } public void widgetDefaultSelected(SelectionEvent e) {} }; fBackgroundDefaultRadioButton= new Button(backgroundComposite, SWT.RADIO | SWT.LEFT); fBackgroundDefaultRadioButton.setText(JavaUIMessages.getString("JavaEditorPreferencePage.systemDefault")); //$NON-NLS-1$ fBackgroundDefaultRadioButton.addSelectionListener(backgroundSelectionListener); fBackgroundCustomRadioButton= new Button(backgroundComposite, SWT.RADIO | SWT.LEFT); fBackgroundCustomRadioButton.setText(JavaUIMessages.getString("JavaEditorPreferencePage.custom")); //$NON-NLS-1$ fBackgroundCustomRadioButton.addSelectionListener(backgroundSelectionListener); fBackgroundColorEditor= new ColorEditor(backgroundComposite); fBackgroundColorButton= fBackgroundColorEditor.getButton(); label= new Label(colorComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.foreground")); //$NON-NLS-1$ label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Composite editorComposite= new Composite(colorComposite, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); GridData gd= new GridData(GridData.FILL_BOTH); editorComposite.setLayoutData(gd); fSyntaxColorList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL | SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fSyntaxColorList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NONE); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); label= new Label(stylesComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.color")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fSyntaxForegroundColorEditor= new ColorEditor(stylesComposite); Button foregroundColorButton= fSyntaxForegroundColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; foregroundColorButton.setLayoutData(gd); label= new Label(stylesComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.bold")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fBoldCheckBox= new Button(stylesComposite, SWT.CHECK); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; fBoldCheckBox.setLayoutData(gd); label= new Label(colorComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.preview")); //$NON-NLS-1$ label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Control previewer= createPreviewer(colorComposite); gd= new GridData(GridData.FILL_BOTH); gd.widthHint= convertWidthInCharsToPixels(80); gd.heightHint= convertHeightInCharsToPixels(15); previewer.setLayoutData(gd); fSyntaxColorList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleSyntaxColorListSelection(); } }); foregroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fSyntaxForegroundColorEditor.getColorValue()); } }); fBackgroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { PreferenceConverter.setValue(fOverlayStore, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, fBackgroundColorEditor.getColorValue()); } }); fBoldCheckBox.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; fOverlayStore.setValue(key + BOLD, fBoldCheckBox.getSelection()); } }); return colorComposite; } private Control createPreviewer(Composite parent) { fJavaTextTools= new JavaTextTools(fOverlayStore); fPreviewViewer= new SourceViewer(parent, null, SWT.V_SCROLL | SWT.H_SCROLL | SWT.BORDER); fPreviewViewer.configure(new JavaSourceViewerConfiguration(fJavaTextTools, null)); fPreviewViewer.getTextWidget().setFont(JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT)); fPreviewViewer.setEditable(false); initializeViewerColors(fPreviewViewer); String content= loadPreviewContentFromFile("ColorSettingPreviewCode.txt"); //$NON-NLS-1$ IDocument document= new Document(content); IDocumentPartitioner partitioner= fJavaTextTools.createDocumentPartitioner(); partitioner.connect(document); document.setDocumentPartitioner(partitioner); fPreviewViewer.setDocument(document); fOverlayStore.addPropertyChangeListener(new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { String p= event.getProperty(); if (p.equals(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND) || p.equals(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT)) { initializeViewerColors(fPreviewViewer); } fPreviewViewer.invalidateTextPresentation(); } }); return fPreviewViewer.getControl(); } /** * Initializes the given viewer's colors. * * @param viewer the viewer to be initialized */ private void initializeViewerColors(ISourceViewer viewer) { IPreferenceStore store= fOverlayStore; if (store != null) { StyledText styledText= viewer.getTextWidget(); // ---------- background color ---------------------- Color color= store.getBoolean(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT) ? null : createColor(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, styledText.getDisplay()); styledText.setBackground(color); if (fBackgroundColor != null) fBackgroundColor.dispose(); fBackgroundColor= color; } } /** * Creates a color from the information stored in the given preference store. * Returns <code>null</code> if there is no such information available. */ private Color createColor(IPreferenceStore store, String key, Display display) { RGB rgb= null; if (store.contains(key)) { if (store.isDefault(key)) rgb= PreferenceConverter.getDefaultColor(store, key); else rgb= PreferenceConverter.getColor(store, key); if (rgb != null) return new Color(display, rgb); } return null; } // sets enabled flag for a control and all its sub-tree private static void setEnabled(Control control, boolean enable) { control.setEnabled(enable); if (control instanceof Composite) { Composite composite= (Composite) control; Control[] children= composite.getChildren(); for (int i= 0; i < children.length; i++) setEnabled(children[i], enable); } } private Control createAppearancePage(Composite parent) { Composite behaviorComposite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; behaviorComposite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.textFont"); //$NON-NLS-1$ addTextFontEditor(behaviorComposite, label, AbstractTextEditor.PREFERENCE_FONT); label= JavaUIMessages.getString("JavaEditorPreferencePage.displayedTabWidth"); //$NON-NLS-1$ addTextField(behaviorComposite, label, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 3, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.printMarginColumn"); //$NON-NLS-1$ addTextField(behaviorComposite, label, CompilationUnitEditor.PRINT_MARGIN_COLUMN, 3, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.insertSpaceForTabs"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.SPACES_FOR_TABS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.synchronizeOnCursor"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showOverviewRuler"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.OVERVIEW_RULER, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showLineNumbers"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, JavaEditor.LINE_NUMBER_RULER, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightMatchingBrackets"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.MATCHING_BRACKETS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightCurrentLine"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.CURRENT_LINE, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showPrintMargin"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.PRINT_MARGIN, 0); Label l= new Label(behaviorComposite, SWT.LEFT ); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; gd.heightHint= convertHeightInCharsToPixels(1) / 2; l.setLayoutData(gd); l= new Label(behaviorComposite, SWT.LEFT); l.setText(JavaUIMessages.getString("JavaEditorPreferencePage.appearanceOptions")); //$NON-NLS-1$ gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; l.setLayoutData(gd); Composite editorComposite= new Composite(behaviorComposite, SWT.NONE); layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.FILL_VERTICAL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); fAppearanceColorList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL | SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fAppearanceColorList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NONE); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); l= new Label(stylesComposite, SWT.LEFT); l.setText(JavaUIMessages.getString("JavaEditorPreferencePage.color")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; l.setLayoutData(gd); fAppearanceForegroundColorEditor= new ColorEditor(stylesComposite); Button foregroundColorButton= fAppearanceForegroundColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; foregroundColorButton.setLayoutData(gd); fAppearanceColorList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleAppearanceColorListSelection(); } }); foregroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fAppearanceColorList.getSelectionIndex(); String key= fAppearanceColorListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fAppearanceForegroundColorEditor.getColorValue()); } }); return behaviorComposite; } private Control createProblemIndicationPage(Composite parent) { Composite composite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; composite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.showProblemsBeforeCompiling"); //$NON-NLS-1$ addCheckBox(composite, label, CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightProblems"); //$NON-NLS-1$ addCheckBox(composite, label, CompilationUnitEditor.PROBLEM_INDICATION, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showQuickFixables"); //$NON-NLS-1$ addCheckBox(composite, label, JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS, 0); return composite; } private Control createContentAssistPage(Composite parent) { Composite contentAssistComposite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; contentAssistComposite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.insertSingleProposalsAutomatically"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOINSERT, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showOnlyProposalsVisibleInTheInvocationContext"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.presentProposalsInAlphabeticalOrder"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.ORDER_PROPOSALS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.enableAutoActivation"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.automaticallyAddImportInsteadOfQualifiedName"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.ADD_IMPORT, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.fillArgumentNamesOnMethodCompletion"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.FILL_METHOD_ARGUMENTS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationDelay"); //$NON-NLS-1$ addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_DELAY, 4, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationTriggersForJava"); //$NON-NLS-1$ addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, 4, 0, false); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationTriggersForJavaDoc"); //$NON-NLS-1$ addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, 4, 0, false); label= JavaUIMessages.getString("JavaEditorPreferencePage.backgroundForCompletionProposals"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_BACKGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.foregroundForCompletionProposals"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_FOREGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.backgroundForMethodParameters"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_BACKGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.foregroundForMethodParameters"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_FOREGROUND, 0); return contentAssistComposite; } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { fOverlayStore.load(); fOverlayStore.start(); TabFolder folder= new TabFolder(parent, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); TabItem item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.general")); //$NON-NLS-1$ item.setControl(createAppearancePage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.colors")); //$NON-NLS-1$ item.setControl(createColorPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.codeAssist")); //$NON-NLS-1$ item.setControl(createContentAssistPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText("Problem Indi&cation"); item.setControl(createProblemIndicationPage(folder)); initialize(); return folder; } private void initialize() { fFontEditor.setPreferenceStore(getPreferenceStore()); fFontEditor.setPreferencePage(this); fFontEditor.load(); initializeFields(); for (int i= 0; i < fSyntaxColorListModel.length; i++) fSyntaxColorList.add(fSyntaxColorListModel[i][0]); fSyntaxColorList.getDisplay().asyncExec(new Runnable() { public void run() { fSyntaxColorList.select(0); handleSyntaxColorListSelection(); } }); for (int i= 0; i < fAppearanceColorListModel.length; i++) fAppearanceColorList.add(fAppearanceColorListModel[i][0]); fAppearanceColorList.getDisplay().asyncExec(new Runnable() { public void run() { fAppearanceColorList.select(0); handleAppearanceColorListSelection(); } }); } private void initializeFields() { Iterator e= fColorButtons.keySet().iterator(); while (e.hasNext()) { ColorEditor c= (ColorEditor) e.next(); String key= (String) fColorButtons.get(c); RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); c.setColorValue(rgb); } e= fCheckBoxes.keySet().iterator(); while (e.hasNext()) { Button b= (Button) e.next(); String key= (String) fCheckBoxes.get(b); b.setSelection(fOverlayStore.getBoolean(key)); } e= fTextFields.keySet().iterator(); while (e.hasNext()) { Text t= (Text) e.next(); String key= (String) fTextFields.get(t); t.setText(fOverlayStore.getString(key)); } RGB rgb= PreferenceConverter.getColor(fOverlayStore, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND); fBackgroundColorEditor.setColorValue(rgb); boolean default_= fOverlayStore.getBoolean(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT); fBackgroundDefaultRadioButton.setSelection(default_); fBackgroundCustomRadioButton.setSelection(!default_); fBackgroundColorButton.setEnabled(!default_); } /* * @see PreferencePage#performOk() */ public boolean performOk() { fFontEditor.store(); fOverlayStore.propagate(); JavaPlugin.getDefault().savePluginPreferences(); return true; } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fFontEditor.loadDefault(); fOverlayStore.loadDefaults(); initializeFields(); handleSyntaxColorListSelection(); handleAppearanceColorListSelection(); super.performDefaults(); fPreviewViewer.invalidateTextPresentation(); } /* * @see DialogPage#dispose() */ public void dispose() { if (fJavaTextTools != null) { fJavaTextTools= null; } fFontEditor.setPreferencePage(null); fFontEditor.setPreferenceStore(null); if (fOverlayStore != null) { fOverlayStore.stop(); fOverlayStore= null; } super.dispose(); } private Control addColorButton(Composite composite, String label, String key, int indentation) { Label labelControl= new Label(composite, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); ColorEditor editor= new ColorEditor(composite); Button button= editor.getButton(); button.setData(editor); gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); button.setLayoutData(gd); button.addSelectionListener(fColorButtonListener); fColorButtons.put(editor, key); return composite; } private Button addCheckBox(Composite parent, String label, String key, int indentation) { Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; gd.horizontalSpan= 2; checkBox.setLayoutData(gd); checkBox.addSelectionListener(fCheckBoxListener); fCheckBoxes.put(checkBox, key); return checkBox; } private Control addTextField(Composite composite, String label, String key, int textLimit, int indentation, boolean isNumber) { Label labelControl= new Label(composite, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); Text textControl= new Text(composite, SWT.BORDER | SWT.SINGLE); gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.widthHint= convertWidthInCharsToPixels(textLimit + 1); textControl.setLayoutData(gd); textControl.setTextLimit(textLimit); fTextFields.put(textControl, key); if (isNumber) { fNumberFields.add(textControl); textControl.addModifyListener(fNumberFieldListener); } else { textControl.addModifyListener(fTextFieldListener); } return composite; } private void addTextFontEditor(Composite parent, String label, String key) { Composite editorComposite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 3; editorComposite.setLayout(layout); fFontEditor= new WorkbenchChainedTextFontFieldEditor(key, label, editorComposite); fFontEditor.setChangeButtonText(JavaUIMessages.getString("JavaEditorPreferencePage.change")); //$NON-NLS-1$ GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); } private String loadPreviewContentFromFile(String filename) { String line; String separator= System.getProperty("line.separator"); //$NON-NLS-1$ StringBuffer buffer= new StringBuffer(512); BufferedReader reader= null; try { reader= new BufferedReader(new InputStreamReader(getClass().getResourceAsStream(filename))); while ((line= reader.readLine()) != null) { buffer.append(line); buffer.append(separator); } } catch (IOException io) { JavaPlugin.log(io); } finally { if (reader != null) { try { reader.close(); } catch (IOException e) {} } } return buffer.toString(); } private void numberFieldChanged(Text textControl) { String number= textControl.getText(); IStatus status= validatePositiveNumber(number); if (!status.matches(IStatus.ERROR)) fOverlayStore.setValue((String) fTextFields.get(textControl), number); updateStatus(status); } private IStatus validatePositiveNumber(String number) { StatusInfo status= new StatusInfo(); if (number.length() == 0) { status.setError(JavaUIMessages.getString("JavaEditorPreferencePage.empty_input")); //$NON-NLS-1$ } else { try { int value= Integer.parseInt(number); if (value < 0) status.setError(JavaUIMessages.getFormattedString("JavaEditorPreferencePage.invalid_input", number)); //$NON-NLS-1$ } catch (NumberFormatException e) { status.setError(JavaUIMessages.getFormattedString("JavaEditorPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } return status; } private void updateStatus(IStatus status) { if (!status.matches(IStatus.ERROR)) { for (int i= 0; i < fNumberFields.size(); i++) { Text text= (Text) fNumberFields.get(i); IStatus s= validatePositiveNumber(text.getText()); status= StatusUtil.getMoreSevere(s, status); } } setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } public static boolean showTempProblems() { return JavaPlugin.getDefault().getPreferenceStore().getBoolean(JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS); } static public boolean synchronizeOutlineOnCursorMove() { return JavaPlugin.getDefault().getPreferenceStore().getBoolean(PREF_SYNC_OUTLINE_ON_CURSOR_MOVE); } }
17,603
Bug 17603 Name Conflict dialog should be improved
Build F1 See attached picture. The problem is that that CU name including the .java is in quotes and that the user should enter a new name for it. Unfortunately . is not accepted in that name. We should use better wording.
verified fixed
9b02f77
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T10:50:38Z
2002-05-24T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/CopyQueries.java
package org.eclipse.jdt.internal.ui.reorg; import java.text.MessageFormat; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.OperationCanceledException; import org.eclipse.jface.dialogs.IInputValidator; import org.eclipse.jface.dialogs.InputDialog; import org.eclipse.jface.window.Window; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.Checks; import org.eclipse.jdt.internal.corext.refactoring.base.RefactoringStatus; import org.eclipse.jdt.internal.corext.refactoring.rename.RenamePackageRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ICopyQueries; import org.eclipse.jdt.internal.corext.refactoring.reorg.INewNameQuery; import org.eclipse.jdt.internal.ui.JavaPlugin; public class CopyQueries implements ICopyQueries { private static final String EMPTY= " "; //XXX workaround for bug#16256 public CopyQueries() { } private static String removeTrailingJava(String name) { Assert.isTrue(name.endsWith(".java")); return name.substring(0, name.length() - ".java".length()); } public INewNameQuery createNewCompilationUnitNameQuery(ICompilationUnit cu) { String key= "Enter a new name for ''{0}''"; String message= MessageFormat.format(key, new String[]{cu.getElementName()}); return createStaticQuery(createCompilationUnitNameValidator(cu), message, removeTrailingJava(cu.getElementName())); } public INewNameQuery createNewResourceNameQuery(IResource res) { String key= "Enter a new name for ''{0}''"; String message= MessageFormat.format(key, new String[]{ res.getName()}); return createStaticQuery(createResourceNameValidator(res), message, res.getName()); } public INewNameQuery createNewPackageNameQuery(IPackageFragment pack) { String key= "Enter a new name for ''{0}''"; String message= MessageFormat.format(key, new String[]{pack.getElementName()}); return createStaticQuery(createPackageNameValidator(pack), message, pack.getElementName()); } public INewNameQuery createNullQuery(){ return createStaticQuery(null); } public INewNameQuery createStaticQuery(final String newName){ return new INewNameQuery(){ public String getNewName() { return newName; } }; } private static INewNameQuery createStaticQuery(final IInputValidator validator, final String message, final String initial){ return new INewNameQuery(){ public String getNewName() { InputDialog dialog= new InputDialog(JavaPlugin.getActiveWorkbenchShell(), "Name Conflict", message, initial, validator); if (dialog.open() == Window.CANCEL) throw new OperationCanceledException(); return dialog.getValue(); } }; } private static IInputValidator createResourceNameValidator(final IResource res){ IInputValidator validator= new IInputValidator(){ public String isValid(String newText) { if (newText == null || "".equals(newText) || res.getParent() == null) return EMPTY; if (res.getParent().findMember(newText) != null) return "Resource with this name already exists"; if (! res.getParent().getFullPath().isValidSegment(newText)) return "Invalid name"; IStatus status= res.getParent().getWorkspace().validateName(newText, res.getType()); if (status.getSeverity() == IStatus.ERROR) return status.getMessage(); if (res.getName().equalsIgnoreCase(newText)) return "Resource exists with different case"; return null; } }; return validator; } private static IInputValidator createCompilationUnitNameValidator(final ICompilationUnit cu) { IInputValidator validator= new IInputValidator(){ public String isValid(String newText) { if (newText == null || "".equals(newText)) return EMPTY; String newCuName= newText + ".java"; IStatus status= JavaConventions.validateCompilationUnitName(newCuName); if (status.getSeverity() == IStatus.ERROR) return status.getMessage(); RefactoringStatus refStatus; try { refStatus= Checks.checkCompilationUnitNewName(cu, newText); } catch (JavaModelException e) { return EMPTY; } if (refStatus.hasFatalError()) return refStatus.getFirstMessage(RefactoringStatus.FATAL); if (cu.getElementName().equalsIgnoreCase(newCuName)) return "Resource exists with different case"; return null; } }; return validator; } private static IInputValidator createPackageNameValidator(final IPackageFragment pack) { IInputValidator validator= new IInputValidator(){ public String isValid(String newText) { if (newText == null || "".equals(newText)) return EMPTY; IStatus status= JavaConventions.validatePackageName(newText); if (status.getSeverity() == IStatus.ERROR) return status.getMessage(); IJavaElement parent= pack.getParent(); try { if (parent instanceof IPackageFragmentRoot){ if (! RenamePackageRefactoring.isPackageNameOkInRoot(newText, (IPackageFragmentRoot)parent)) return "Package with that name exists"; } } catch (JavaModelException e) { return EMPTY; } if (pack.getElementName().equalsIgnoreCase(newText)) return "Resource exists with different case"; return null; } }; return validator; } }
16,265
Bug 16265 Disable empty refactor menu in context menu
Build 20020515 - select default package - open context menu
verified fixed
60c5bde
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T11:02:11Z
2002-05-17T15:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/RefactorActionGroup.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.part.Page; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; /** * Action group that adds refactor actions (e.g. Rename..., Move..., etc.) * to a context menu and the global menu bar. * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class RefactorActionGroup extends ActionGroup { private IWorkbenchSite fSite; private boolean fIsEditorOwner; private String fGroupName= IContextMenuConstants.GROUP_REORGANIZE; private SelectionDispatchAction fSelfEncapsulateField; private SelectionDispatchAction fMoveAction; private SelectionDispatchAction fRenameAction; private SelectionDispatchAction fModifyParametersAction; private SelectionDispatchAction fPullUpAction; private SelectionDispatchAction fInlineTempAction; private SelectionDispatchAction fExtractTempAction; private SelectionDispatchAction fExtractMethodAction; /** * Creates a new <code>RefactorActionGroup</code>. * * @param part the view part that owns this action group */ public RefactorActionGroup(IViewPart part) { this(part.getSite()); } /** * Creates a new <code>RefactorActionGroup</code>. * * @param page the page that owns this action group */ public RefactorActionGroup(Page page) { this(page.getSite()); } /** * Creates a new <code>RefactorActionGroup</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> * * @param editor the editor that owns this action group */ public RefactorActionGroup(CompilationUnitEditor editor, String groupName) { fSite= editor.getEditorSite(); fIsEditorOwner= true; fGroupName= groupName; ISelectionProvider provider= editor.getSelectionProvider(); ISelection selection= provider.getSelection(); fRenameAction= new RenameAction(editor); fRenameAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.RENAME_ELEMENT); fRenameAction.update(selection); editor.setAction("RenameElement", fRenameAction); //$NON-NLS-1$ fSelfEncapsulateField= new SelfEncapsulateFieldAction(editor); fSelfEncapsulateField.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELF_ENCAPSULATE_FIELD); fSelfEncapsulateField.update(selection); editor.setAction("SelfEncapsulateField", fSelfEncapsulateField); //$NON-NLS-1$ fModifyParametersAction= new ModifyParametersAction(editor); fModifyParametersAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.MODIFY_METHOD_PARAMETERS); fModifyParametersAction.update(selection); editor.setAction("ModifyParameters", fModifyParametersAction); //$NON-NLS-1$ fPullUpAction= new PullUpAction(editor); fPullUpAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.PULL_UP); fPullUpAction.update(selection); editor.setAction("PullUp", fPullUpAction); //$NON-NLS-1$ fMoveAction= new MoveAction(editor); fMoveAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.MOVE_ELEMENT); fMoveAction.update(selection); editor.setAction("MoveElement", fMoveAction); //$NON-NLS-1$ fInlineTempAction= new InlineTempAction(editor); fInlineTempAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.INLINE_LOCAL_VARIABLE); fInlineTempAction.update(selection); editor.setAction("InlineLocalVariable", fInlineTempAction); //$NON-NLS-1$ fExtractTempAction= new ExtractTempAction(editor); fExtractTempAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.EXTRACT_LOCAL_VARIABLE); initAction(fExtractTempAction, provider, selection); editor.setAction("ExtractLocalVariable", fExtractTempAction); //$NON-NLS-1$ fExtractMethodAction= new ExtractMethodAction(editor); fExtractMethodAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.EXTRACT_METHOD); initAction(fExtractMethodAction, provider, selection); editor.setAction("ExtractMethod", fExtractMethodAction); //$NON-NLS-1$ } private RefactorActionGroup(IWorkbenchSite site) { fSite= site; fIsEditorOwner= false; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fMoveAction= new MoveAction(site); initAction(fMoveAction, provider, selection); fRenameAction= new RenameAction(site); initAction(fRenameAction, provider, selection); fModifyParametersAction= new ModifyParametersAction(fSite); initAction(fModifyParametersAction, provider, selection); fPullUpAction= new PullUpAction(fSite); initAction(fPullUpAction, provider, selection); fSelfEncapsulateField= new SelfEncapsulateFieldAction(fSite); initAction(fSelfEncapsulateField, provider, selection); } private static void initAction(SelectionDispatchAction action, ISelectionProvider provider, ISelection selection){ action.update(selection); provider.addSelectionChangedListener(action); }; private boolean isEditorOwner() { return fIsEditorOwner; } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillActionBars(IActionBars actionBars) { super.fillActionBars(actionBars); actionBars.setGlobalActionHandler(JdtActionConstants.SELF_ENCAPSULATE_FIELD, fSelfEncapsulateField); actionBars.setGlobalActionHandler(JdtActionConstants.MOVE, fMoveAction); actionBars.setGlobalActionHandler(JdtActionConstants.RENAME, fRenameAction); actionBars.setGlobalActionHandler(JdtActionConstants.MODIFY_PARAMETERS, fModifyParametersAction); actionBars.setGlobalActionHandler(JdtActionConstants.PULL_UP, fPullUpAction); actionBars.setGlobalActionHandler(JdtActionConstants.INLINE_TEMP, fInlineTempAction); actionBars.setGlobalActionHandler(JdtActionConstants.EXTRACT_TEMP, fExtractTempAction); actionBars.setGlobalActionHandler(JdtActionConstants.EXTRACT_METHOD, fExtractMethodAction); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillContextMenu(IMenuManager menu) { super.fillContextMenu(menu); addRefactorSubmenu(menu); } /* * @see ActionGroup#dispose() */ public void dispose() { ISelectionProvider provider= fSite.getSelectionProvider(); disposeAction(fSelfEncapsulateField, provider); disposeAction(fMoveAction, provider); disposeAction(fRenameAction, provider); disposeAction(fModifyParametersAction, provider); disposeAction(fPullUpAction, provider); disposeAction(fInlineTempAction, provider); disposeAction(fExtractTempAction, provider); disposeAction(fExtractMethodAction, provider); super.dispose(); } private void disposeAction(ISelectionChangedListener action, ISelectionProvider provider) { if (action != null) provider.removeSelectionChangedListener(action); } private void addRefactorSubmenu(IMenuManager menu) { IMenuManager refactorSubmenu= new MenuManager(ActionMessages.getString("RefactorMenu.label")); //$NON-NLS-1$ addAction(refactorSubmenu, fRenameAction); addAction(refactorSubmenu, fMoveAction); addAction(refactorSubmenu, fPullUpAction); addAction(refactorSubmenu, fModifyParametersAction); refactorSubmenu.add(new Separator()); addAction(refactorSubmenu, fExtractMethodAction); addAction(refactorSubmenu, fExtractTempAction); addAction(refactorSubmenu, fInlineTempAction); addAction(refactorSubmenu, fSelfEncapsulateField); if (!refactorSubmenu.isEmpty()) menu.appendToGroup(fGroupName, refactorSubmenu); } private void addAction(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) menu.add(action); } }
16,441
Bug 16441 DBCS: Key and Value in string externalize
When invoking "Externalize String" for Java applicatopn includes Japanese string, Key name at Wizard contains the Japanese DBCS. The objective is to create i18n application, Key name should be ASCII name by default Moreover created properties file contains Japanese string as is for Value. It should be converted Unicode encoding like \uXXXX as VAJ does.
closed fixed
82ed82d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T12:48:44Z
2002-05-20T15:53:20Z
org.eclipse.jdt.ui/core
16,441
Bug 16441 DBCS: Key and Value in string externalize
When invoking "Externalize String" for Java applicatopn includes Japanese string, Key name at Wizard contains the Japanese DBCS. The objective is to create i18n application, Key name should be ASCII name by default Moreover created properties file contains Japanese string as is for Value. It should be converted Unicode encoding like \uXXXX as VAJ does.
closed fixed
82ed82d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T12:48:44Z
2002-05-20T15:53:20Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/nls/NLSHolder.java
18,015
Bug 18015 NPE in structured selection if file opened from repo
F1 1. repository view - open a java file 2. use structured selection java.lang.NullPointerException at org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionActi on.getNewSelectionRange(StructureSelectionAction.java:68) at org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionActi on.run(StructureSelectionAction.java:53) at org.eclipse.ui.texteditor.RetargetTextEditorAction.run (RetargetTextEditorAction.java:127) at org.eclipse.jface.action.Action.runWithEvent(Action.java:590) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:432) at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24)
verified fixed
f8bcbf5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T13:33:19Z
2002-05-28T10:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/structureselection/StructureSelectHistoryAction.java
package org.eclipse.jdt.internal.ui.javaeditor.structureselection; import org.eclipse.jface.action.Action; import org.eclipse.jface.util.Assert; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditorMessages; public class StructureSelectHistoryAction extends Action implements IUpdate { private CompilationUnitEditor fEditor; private SelectionHistory fHistory; public StructureSelectHistoryAction(CompilationUnitEditor editor, SelectionHistory history) { super(JavaEditorMessages.getString("StructureSelectHistory.label")); //$NON-NLS-1$ setToolTipText(JavaEditorMessages.getString("StructureSelectHistory.tooltip")); //$NON-NLS-1$ setDescription(JavaEditorMessages.getString("StructureSelectHistory.description")); //$NON-NLS-1$ Assert.isNotNull(history); Assert.isNotNull(editor); fHistory= history; fEditor= editor; update(); } public void update() { setEnabled(!fHistory.isEmpty()); } public void run() { ISourceRange old= fHistory.getLast(); if (old != null) { try { fHistory.ignoreSelectionChanges(); fEditor.selectAndReveal(old.getOffset(), old.getLength()); } finally { fHistory.listenToSelectionChanges(); } } } }
18,015
Bug 18015 NPE in structured selection if file opened from repo
F1 1. repository view - open a java file 2. use structured selection java.lang.NullPointerException at org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionActi on.getNewSelectionRange(StructureSelectionAction.java:68) at org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionActi on.run(StructureSelectionAction.java:53) at org.eclipse.ui.texteditor.RetargetTextEditorAction.run (RetargetTextEditorAction.java:127) at org.eclipse.jface.action.Action.runWithEvent(Action.java:590) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:432) at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24)
verified fixed
f8bcbf5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T13:33:19Z
2002-05-28T10:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/structureselection/StructureSelectionAction.java
package org.eclipse.jdt.internal.ui.javaeditor.structureselection; import java.util.Collection; import org.eclipse.jface.action.Action; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.util.Assert; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.dom.AST; import org.eclipse.jdt.core.dom.ASTNode; import org.eclipse.jdt.core.dom.Block; import org.eclipse.jdt.core.dom.CompilationUnit; import org.eclipse.jdt.core.dom.TypeDeclaration; import org.eclipse.jdt.internal.corext.SourceRange; import org.eclipse.jdt.internal.corext.dom.Selection; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; public abstract class StructureSelectionAction extends Action { public static final String NEXT= "SelectNextElement"; //$NON-NLS-1$ public static final String PREVIOUS= "SelectPreviousElement"; //$NON-NLS-1$ public static final String ENCLOSING= "SelectEnclosingElement"; //$NON-NLS-1$ public static final String HISTORY= "RestoreLastSelection"; //$NON-NLS-1$ private CompilationUnitEditor fEditor; private SelectionHistory fSelectionHistory; protected StructureSelectionAction(String text, CompilationUnitEditor editor, SelectionHistory history) { super(text); Assert.isNotNull(editor); Assert.isNotNull(history); fEditor= editor; fSelectionHistory= history; } /* * This constructor is for testing purpose only. */ protected StructureSelectionAction() { super(""); //$NON-NLS-1$ } /* (non-JavaDoc) * Method declared in IAction. */ public final void run() { ITextSelection selection= getTextSelection(); ISourceRange newRange= getNewSelectionRange(createSourceRange(selection), getCompilationUnit()); // Check if new selection differs from current selection if (selection.getOffset() == newRange.getOffset() && selection.getLength() == newRange.getLength()) return; fSelectionHistory.remember(new SourceRange(selection.getOffset(), selection.getLength())); try { fSelectionHistory.ignoreSelectionChanges(); fEditor.selectAndReveal(newRange.getOffset(), newRange.getLength()); } finally { fSelectionHistory.listenToSelectionChanges(); } } public final ISourceRange getNewSelectionRange(ISourceRange oldSourceRange, ICompilationUnit cu){ try{ if (! cu.isStructureKnown()) return oldSourceRange; CompilationUnit root= AST.parseCompilationUnit(cu, false); Selection selection= Selection.createFromStartLength(oldSourceRange.getOffset(), oldSourceRange.getLength()); StructureSelectionAnalyzer selAnalyzer= new StructureSelectionAnalyzer(selection, true); root.accept(selAnalyzer); return internalGetNewSelectionRange(oldSourceRange, cu, selAnalyzer); } catch (JavaModelException e){ JavaPlugin.log(e); //dialog would be too heavy here return new SourceRange(oldSourceRange.getOffset(), oldSourceRange.getLength()); } } /** * This is the default implementation - it goes up one level in the AST. * Subclasses may implement different behavior and/or use this implementation as a fallback for cases they do not handle.. */ abstract ISourceRange internalGetNewSelectionRange(ISourceRange oldSourceRange, ICompilationUnit cu, StructureSelectionAnalyzer selAnalyzer) throws JavaModelException; protected final ICompilationUnit getCompilationUnit() { return JavaPlugin.getDefault().getWorkingCopyManager().getWorkingCopy(fEditor.getEditorInput()); } protected final ITextSelection getTextSelection() { return (ITextSelection)fEditor.getSelectionProvider().getSelection(); } protected static ISourceRange getLastCoveringNodeRange(ISourceRange oldSourceRange, ICompilationUnit cu, StructureSelectionAnalyzer selAnalyzer) throws JavaModelException { if (selAnalyzer.getLastCoveringNode() == null) return oldSourceRange; else return getSelectedNodeSourceRange(cu, selAnalyzer.getLastCoveringNode()); } protected static ISourceRange getSelectedNodeSourceRange(ICompilationUnit cu, ASTNode nodeToSelect) throws JavaModelException { int offset= nodeToSelect.getStartPosition(); int end= Math.min(cu.getSourceRange().getLength(), nodeToSelect.getStartPosition() + nodeToSelect.getLength() - 1); return createSourceRange(offset, end); } //-- private helper methods private static ISourceRange createSourceRange(ITextSelection ts){ if (ts.getLength() == 0) //to allow 0-length selection return new SourceRange(ts.getOffset(), 1); else return new SourceRange(ts.getOffset(), ts.getLength()); } //-- helper methods for this class and subclasses static ISourceRange createSourceRange(int offset, int end){ int length= end - offset + 1; if (length == 0) //to allow 0-length selection length= 1; return new SourceRange(Math.max(0, offset), length); } static ASTNode[] getChildNodes(ASTNode node){ if (node instanceof Block) return convertToNodeArray(((Block)node).statements()); if (node instanceof TypeDeclaration) return convertToNodeArray(((TypeDeclaration)node).bodyDeclarations()); if (node instanceof CompilationUnit) return convertToNodeArray(((CompilationUnit)node).types()); return null; } private static ASTNode[] convertToNodeArray(Collection statements){ return (ASTNode[]) statements.toArray(new ASTNode[statements.size()]); } static int findIndex(Object[] array, Object o){ for (int i= 0; i < array.length; i++) { Object object= array[i]; if (object == o) return i; } return -1; } }
16,455
Bug 16455 Open type in hierarchy perspective. [type hierarchy]
I use open type dialog a lot to open the type in a hierarchy perpective but I can't find the preference to open the type in a hierarchy perpective anymore. I saw the button "Hierarchy" in the open type dialog but takes me 4 tabs to get there instead of pressing enter. (Not acceptable). Please can you point me to the new preference if it exists. Or can you give a way to make the Hierarchy button the default button. For example: If I press it once, it becames the active next time the dialog is opened.
resolved wontfix
e8a411e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T14:44:58Z
2002-05-20T15:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenTypeAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.actions; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.viewers.ISelection; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.IWorkbenchWindowActionDelegate; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.search.IJavaSearchConstants; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.OpenTypeSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; public class OpenTypeAction extends Action implements IWorkbenchWindowActionDelegate { public OpenTypeAction() { super(); setText(JavaUIMessages.getString("OpenTypeAction.label")); //$NON-NLS-1$ setDescription(JavaUIMessages.getString("OpenTypeAction.description")); //$NON-NLS-1$ setToolTipText(JavaUIMessages.getString("OpenTypeAction.tooltip")); //$NON-NLS-1$ setImageDescriptor(JavaPluginImages.DESC_TOOL_OPENTYPE); } public void run() { Shell parent= JavaPlugin.getActiveWorkbenchShell(); OpenTypeSelectionDialog dialog= new OpenTypeSelectionDialog(parent, new ProgressMonitorDialog(parent), IJavaSearchConstants.TYPE, SearchEngine.createWorkspaceScope()); dialog.setMatchEmptyString(true); dialog.setTitle(JavaUIMessages.getString("OpenTypeAction.dialogTitle")); //$NON-NLS-1$ dialog.setMessage(JavaUIMessages.getString("OpenTypeAction.dialogMessage")); //$NON-NLS-1$ int result= dialog.open(); if (result != OpenTypeSelectionDialog.IN_HIERARCHY && result != IDialogConstants.OK_ID) return; Object[] types= dialog.getResult(); if (types != null && types.length > 0) { IType type= (IType)types[0]; if (result == OpenTypeSelectionDialog.IN_HIERARCHY) { OpenTypeHierarchyUtil.open(new IType[] { type }, JavaPlugin.getActiveWorkbenchWindow()); } else { try { IEditorPart part= EditorUtility.openInEditor(type, true); EditorUtility.revealInEditor(part, type); } catch (CoreException x) { String title= JavaUIMessages.getString("OpenTypeAction.errorTitle"); //$NON-NLS-1$ String message= JavaUIMessages.getString("OpenTypeAction.errorMessage"); //$NON-NLS-1$ ExceptionHandler.handle(x, title, message); } } } } //---- IWorkbenchWindowActionDelegate ------------------------------------------------ public void run(IAction action) { run(); } public void dispose() { // do nothing. } public void init(IWorkbenchWindow window) { // do nothing. } public void selectionChanged(IAction action, ISelection selection) { // do nothing. Action doesn't depend on selection. } }
16,455
Bug 16455 Open type in hierarchy perspective. [type hierarchy]
I use open type dialog a lot to open the type in a hierarchy perpective but I can't find the preference to open the type in a hierarchy perpective anymore. I saw the button "Hierarchy" in the open type dialog but takes me 4 tabs to get there instead of pressing enter. (Not acceptable). Please can you point me to the new preference if it exists. Or can you give a way to make the Hierarchy button the default button. For example: If I press it once, it becames the active next time the dialog is opened.
resolved wontfix
e8a411e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T14:44:58Z
2002-05-20T15:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenTypeInHierarchyAction.java
16,455
Bug 16455 Open type in hierarchy perspective. [type hierarchy]
I use open type dialog a lot to open the type in a hierarchy perpective but I can't find the preference to open the type in a hierarchy perpective anymore. I saw the button "Hierarchy" in the open type dialog but takes me 4 tabs to get there instead of pressing enter. (Not acceptable). Please can you point me to the new preference if it exists. Or can you give a way to make the Hierarchy button the default button. For example: If I press it once, it becames the active next time the dialog is opened.
resolved wontfix
e8a411e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T14:44:58Z
2002-05-20T15:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/OpenTypeSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; /** * A dialog to select a type from a list of types. The selected type will be * opened in the editor. */ public class OpenTypeSelectionDialog extends TypeSelectionDialog { public static final int IN_HIERARCHY= IDialogConstants.CLIENT_ID + 1; /** * Constructs an instance of <code>OpenTypeSelectionDialog</code>. * @param parent the parent shell. * @param context the context. * @param elementKinds <code>IJavaSearchConstants.CLASS</code>, <code>IJavaSearchConstants.INTERFACE</code> * or <code>IJavaSearchConstants.TYPE</code> * @param scope the java search scope. */ public OpenTypeSelectionDialog(Shell parent, IRunnableContext context, int elementKinds, IJavaSearchScope scope) { super(parent, context, elementKinds, scope); } /** * @see Windows#configureShell(Shell) */ protected void configureShell(Shell newShell) { super.configureShell(newShell); WorkbenchHelp.setHelp(newShell, IJavaHelpContextIds.OPEN_TYPE_DIALOG); } /* * @see Dialog#createButtonsForButtonBar(Composite) */ protected void createButtonsForButtonBar(Composite parent) { createButton(parent, IDialogConstants.OK_ID, IDialogConstants.OK_LABEL, true); createButton(parent, IN_HIERARCHY, JavaUIMessages.getString("OpenTypeSelectionDialog.hierarchy.label"), false); createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.CANCEL_LABEL, false); } protected void buttonPressed(int buttonId) { super.buttonPressed(buttonId); if (buttonId == IN_HIERARCHY) { setReturnCode(buttonId); computeResult(); close(); } } }
16,413
Bug 16413 Strange "Organize Import" behavior
In the following scenario, organize imports adds an import that does not compile (says the import is not visible). Removing the import removes the error and everything compiles OK. I create a new project and add the folowing class to package a package a; public class ClassA { protected static interface InterfaceA { } public void methodA(InterfaceA a) { } } I then create the following class in package b (this class compiles) package b; import a.ClassA; public class ClassB extends ClassA { // Override of inherited method public void methodA(InterfaceA a) { super.methodA(a); } } Performing an "organize imports" on project B gives: package b; import a.ClassA; import a.ClassA.InterfaceA; /* this line won't compile */ public class ClassB extends ClassA { public void methodA(InterfaceA a) { super.methodA(a); } }
verified fixed
808e83b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:00:25Z
2002-05-19T23:13:20Z
org.eclipse.jdt.ui/core
16,413
Bug 16413 Strange "Organize Import" behavior
In the following scenario, organize imports adds an import that does not compile (says the import is not visible). Removing the import removes the error and everything compiles OK. I create a new project and add the folowing class to package a package a; public class ClassA { protected static interface InterfaceA { } public void methodA(InterfaceA a) { } } I then create the following class in package b (this class compiles) package b; import a.ClassA; public class ClassB extends ClassA { // Override of inherited method public void methodA(InterfaceA a) { super.methodA(a); } } Performing an "organize imports" on project B gives: package b; import a.ClassA; import a.ClassA.InterfaceA; /* this line won't compile */ public class ClassB extends ClassA { public void methodA(InterfaceA a) { super.methodA(a); } }
verified fixed
808e83b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:00:25Z
2002-05-19T23:13:20Z
extension/org/eclipse/jdt/internal/corext/codemanipulation/OrganizeImportsOperation.java
16,413
Bug 16413 Strange "Organize Import" behavior
In the following scenario, organize imports adds an import that does not compile (says the import is not visible). Removing the import removes the error and everything compiles OK. I create a new project and add the folowing class to package a package a; public class ClassA { protected static interface InterfaceA { } public void methodA(InterfaceA a) { } } I then create the following class in package b (this class compiles) package b; import a.ClassA; public class ClassB extends ClassA { // Override of inherited method public void methodA(InterfaceA a) { super.methodA(a); } } Performing an "organize imports" on project B gives: package b; import a.ClassA; import a.ClassA.InterfaceA; /* this line won't compile */ public class ClassB extends ClassA { public void methodA(InterfaceA a) { super.methodA(a); } }
verified fixed
808e83b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:00:25Z
2002-05-19T23:13:20Z
org.eclipse.jdt.ui/core
16,413
Bug 16413 Strange "Organize Import" behavior
In the following scenario, organize imports adds an import that does not compile (says the import is not visible). Removing the import removes the error and everything compiles OK. I create a new project and add the folowing class to package a package a; public class ClassA { protected static interface InterfaceA { } public void methodA(InterfaceA a) { } } I then create the following class in package b (this class compiles) package b; import a.ClassA; public class ClassB extends ClassA { // Override of inherited method public void methodA(InterfaceA a) { super.methodA(a); } } Performing an "organize imports" on project B gives: package b; import a.ClassA; import a.ClassA.InterfaceA; /* this line won't compile */ public class ClassB extends ClassA { public void methodA(InterfaceA a) { super.methodA(a); } }
verified fixed
808e83b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:00:25Z
2002-05-19T23:13:20Z
extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
16,413
Bug 16413 Strange "Organize Import" behavior
In the following scenario, organize imports adds an import that does not compile (says the import is not visible). Removing the import removes the error and everything compiles OK. I create a new project and add the folowing class to package a package a; public class ClassA { protected static interface InterfaceA { } public void methodA(InterfaceA a) { } } I then create the following class in package b (this class compiles) package b; import a.ClassA; public class ClassB extends ClassA { // Override of inherited method public void methodA(InterfaceA a) { super.methodA(a); } } Performing an "organize imports" on project B gives: package b; import a.ClassA; import a.ClassA.InterfaceA; /* this line won't compile */ public class ClassB extends ClassA { public void methodA(InterfaceA a) { super.methodA(a); } }
verified fixed
808e83b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:00:25Z
2002-05-19T23:13:20Z
org.eclipse.jdt.ui/core
16,413
Bug 16413 Strange "Organize Import" behavior
In the following scenario, organize imports adds an import that does not compile (says the import is not visible). Removing the import removes the error and everything compiles OK. I create a new project and add the folowing class to package a package a; public class ClassA { protected static interface InterfaceA { } public void methodA(InterfaceA a) { } } I then create the following class in package b (this class compiles) package b; import a.ClassA; public class ClassB extends ClassA { // Override of inherited method public void methodA(InterfaceA a) { super.methodA(a); } } Performing an "organize imports" on project B gives: package b; import a.ClassA; import a.ClassA.InterfaceA; /* this line won't compile */ public class ClassB extends ClassA { public void methodA(InterfaceA a) { super.methodA(a); } }
verified fixed
808e83b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:00:25Z
2002-05-19T23:13:20Z
extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
17,910
Bug 17910 OpenRefactoringWIzardAction: is API but has protected method that us internal classes
F1 Opt to remove the class and use an internal helper class instead.
verified fixed
38fd169
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:25:26Z
2002-05-27T11:46:40Z
org.eclipse.jdt.ui/ui
17,910
Bug 17910 OpenRefactoringWIzardAction: is API but has protected method that us internal classes
F1 Opt to remove the class and use an internal helper class instead.
verified fixed
38fd169
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:25:26Z
2002-05-27T11:46:40Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/actions/MoveMembersAction.java
17,910
Bug 17910 OpenRefactoringWIzardAction: is API but has protected method that us internal classes
F1 Opt to remove the class and use an internal helper class instead.
verified fixed
38fd169
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:25:26Z
2002-05-27T11:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/ModifyParametersAction.java
package org.eclipse.jdt.ui.actions; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.base.Refactoring; import org.eclipse.jdt.internal.corext.refactoring.structure.ModifyParametersRefactoring; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.refactoring.ModifyParametersWizard; import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages; import org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard; public class ModifyParametersAction extends OpenRefactoringWizardAction { private static final String TITLE= RefactoringMessages.getString("RefactoringGroup.modify_Parameters_label"); //$NON-NLS-1$ private static final String UNAVAILABLE= RefactoringMessages.getString("ModifyParametersAction.unavailable"); //$NON-NLS-1$ public ModifyParametersAction(CompilationUnitEditor editor) { super(TITLE, UNAVAILABLE, editor, IMethod.class, false); } public ModifyParametersAction(IWorkbenchSite site) { super(TITLE, UNAVAILABLE, site, IMethod.class, false); } protected Refactoring createNewRefactoringInstance(Object obj){ return new ModifyParametersRefactoring((IMethod)obj); } protected boolean canActivateRefactoring(Refactoring refactoring) throws JavaModelException{ return ((ModifyParametersRefactoring)refactoring).checkPreactivation().isOK(); } protected RefactoringWizard createWizard(Refactoring ref){ String title= RefactoringMessages.getString("RefactoringGroup.modify_method_parameters"); //$NON-NLS-1$ //FIX ME: wrong String helpId= IJavaHelpContextIds.RENAME_PARAMS_ERROR_WIZARD_PAGE; return new ModifyParametersWizard((ModifyParametersRefactoring)ref, title, helpId); } }
17,910
Bug 17910 OpenRefactoringWIzardAction: is API but has protected method that us internal classes
F1 Opt to remove the class and use an internal helper class instead.
verified fixed
38fd169
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:25:26Z
2002-05-27T11:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/OpenRefactoringWizardAction.java
package org.eclipse.jdt.ui.actions; import java.util.Iterator; import org.eclipse.swt.widgets.Display; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.base.Refactoring; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages; import org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; public abstract class OpenRefactoringWizardAction extends SelectionDispatchAction { private Class fActivationType; private Refactoring fRefactoring; private CompilationUnitEditor fEditor; private boolean fCanActivateOnMultiSelection; private String fUnavailableMessage; protected OpenRefactoringWizardAction(String label, String unavailableString, IWorkbenchSite site, Class activatedOnType, boolean canActivateOnMultiSelection) { super(site); Assert.isNotNull(unavailableString); Assert.isNotNull(activatedOnType); setText(label); fActivationType= activatedOnType; fCanActivateOnMultiSelection= canActivateOnMultiSelection; fUnavailableMessage= unavailableString; } protected OpenRefactoringWizardAction(String label, String unavailableString, CompilationUnitEditor editor, Class activatedOnType, boolean canActivateOnMultiSelection) { this(label, unavailableString, editor.getEditorSite(), activatedOnType, canActivateOnMultiSelection); fEditor= editor; } /* * @see SelectionDispatchAction#selectionChanged(IStructuredSelection) */ protected void selectionChanged(IStructuredSelection selection) { setEnabled(canEnable(selection)); } protected void selectionChanged(ITextSelection selection) { //resolving is too expensive to do on selection changes in the editor - just enable here, we'll check it later setEnabled(checkEnabled(selection)); } private boolean checkEnabled(ITextSelection selection) { if (fEditor == null) return false; return SelectionConverter.getInputAsCompilationUnit(fEditor) != null; } /* * @see SelectionDispatchAction#run(IStructuredSelection) */ protected void run(IStructuredSelection selection) { startRefactoring(); } protected void run(ITextSelection selection) { if (! canRun(selection)){ MessageDialog.openInformation(getShell(), RefactoringMessages.getString("OpenRefactoringWizardAction.unavailable"), fUnavailableMessage); //$NON-NLS-1$ fRefactoring= null; return; } startRefactoring(); } /** * Creates a new instance of <code>Refactoring</code>. * @param obj is guaranteed to be of the accepted type (passed in the constructor) * However, if <code>fCanOperateOnMultiSelection</code> is set to <code>true</code>, * then obj is <code>Object[]</code> and contains elements of the accepted type (passed in the constructor) */ protected abstract Refactoring createNewRefactoringInstance(Object obj) throws JavaModelException; protected abstract RefactoringWizard createWizard(Refactoring refactoring); protected abstract boolean canActivateRefactoring(Refactoring refactoring) throws JavaModelException; private boolean canEnable(IStructuredSelection selection){ if (selection.isEmpty()) return false; if (selection.size() > 1 && ! fCanActivateOnMultiSelection) return false; if (selection.size() == 1 && ! fCanActivateOnMultiSelection) return fActivationType.isInstance(selection.getFirstElement()) && shouldAcceptElement(selection.getFirstElement()); for (Iterator iter= selection.iterator(); iter.hasNext(); ) { if (!fActivationType.isInstance(iter.next())) return false; } return shouldAcceptElement(selection.toArray()); } private boolean canRun(ITextSelection selection){ IJavaElement[] elements= resolveElements(); if (elements.length != 1) return false; if (fCanActivateOnMultiSelection) return fActivationType.isInstance(elements[0]) && shouldAcceptElement(elements); //XXX not pretty else return fActivationType.isInstance(elements[0]) && shouldAcceptElement(elements[0]); } /** * @param obj is guaranteed to be of the accepted type (passed in the constructor) * However, if <code>canOperateOnMultiSelection</code> resturns <code>true</code>, * then obj is <code>Object[]</code> and contains elements of the accepted type (passed in the constructor) * @see OpenWizardAction#shouldAcceptElement */ private final boolean shouldAcceptElement(Object obj) { try{ fRefactoring= createNewRefactoringInstance(obj); return canActivateRefactoring(fRefactoring); } catch (JavaModelException e){ JavaPlugin.log(e); //this happen on selection changes in viewers - do not show ui if fails, just log return false; } } private IJavaElement[] resolveElements() { return SelectionConverter.codeResolveHandled(fEditor, getShell(), RefactoringMessages.getString("OpenRefactoringWizardAction.refactoring")); //$NON-NLS-1$ } private void startRefactoring() { Assert.isNotNull(fRefactoring); try{ Object newElementToProcess= new RefactoringStarter().activate(fRefactoring, createWizard(fRefactoring), RefactoringMessages.getString("OpenRefactoringWizardAction.refactoring"), true); //$NON-NLS-1$ if (newElementToProcess == null) return; IStructuredSelection mockSelection= new StructuredSelection(newElementToProcess); selectionChanged(mockSelection); if (isEnabled()) run(mockSelection); else MessageDialog.openInformation(JavaPlugin.getActiveWorkbenchShell(), "Refactoring", "Operation not possible."); } catch (JavaModelException e){ ExceptionHandler.handle(e, RefactoringMessages.getString("OpenRefactoringWizardAction.refactoring"), RefactoringMessages.getString("OpenRefactoringWizardAction.exception")); //$NON-NLS-1$ //$NON-NLS-2$ } } }
17,910
Bug 17910 OpenRefactoringWIzardAction: is API but has protected method that us internal classes
F1 Opt to remove the class and use an internal helper class instead.
verified fixed
38fd169
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T15:25:26Z
2002-05-27T11:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/PullUpAction.java
package org.eclipse.jdt.ui.actions; import java.util.Arrays; import java.util.HashSet; import java.util.Set; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.base.Refactoring; import org.eclipse.jdt.internal.corext.refactoring.structure.PullUpRefactoring; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.refactoring.PullUpWizard; import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages; import org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard; public class PullUpAction extends OpenRefactoringWizardAction { private static final String TITLE= RefactoringMessages.getString("RefactoringGroup.pull_Up_label"); //$NON-NLS-1$ private static final String UNAVAILABLE= RefactoringMessages.getString("PullUpAction.unavailable"); //$NON-NLS-1$ public PullUpAction(CompilationUnitEditor editor) { super(TITLE, UNAVAILABLE, editor, IMember.class, true); } public PullUpAction(IWorkbenchSite site) { super(TITLE, UNAVAILABLE, site, IMember.class, true); } protected Refactoring createNewRefactoringInstance(Object obj){ Set memberSet= new HashSet(); memberSet.addAll(Arrays.asList((Object[])obj)); IMember[] members= (IMember[]) memberSet.toArray(new IMember[memberSet.size()]); return new PullUpRefactoring(members, JavaPreferencesSettings.getCodeGenerationSettings()); } protected boolean canActivateRefactoring(Refactoring refactoring) throws JavaModelException{ return ((PullUpRefactoring)refactoring).checkPreactivation().isOK(); } protected RefactoringWizard createWizard(Refactoring ref){ String title= RefactoringMessages.getString("RefactoringGroup.pull_up"); //$NON-NLS-1$ //FIX ME: wrong String helpId= "HELPID"; //$NON-NLS-1$ return new PullUpWizard((PullUpRefactoring)ref, title, helpId); } }
16,847
Bug 16847 Japanese: Template page buttons cut off
In the Java->Template page in Japanese the text is cut off on the last 4 buttons. STEPS 1) Install build 20020521 with the 20020515 fragments 2) Open Preferences->Java->Templates
resolved fixed
af58435
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T16:44:10Z
2002-05-22T15:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/TemplatePreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; import java.io.File; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ColumnWeightData; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TableLayout; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.corext.template.ContextType; import org.eclipse.jdt.internal.corext.template.ContextTypeRegistry; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.TemplateContext; import org.eclipse.jdt.internal.corext.template.TemplateMessages; import org.eclipse.jdt.internal.corext.template.TemplateSet; import org.eclipse.jdt.internal.corext.template.Templates; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.text.template.TemplateContentProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateLabelProvider; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class TemplatePreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // preference store keys private static final String PREF_FORMAT_TEMPLATES= JavaUI.ID_PLUGIN + ".template.format"; //$NON-NLS-1$ private Templates fTemplates; private CheckboxTableViewer fTableViewer; private Button fAddButton; private Button fEditButton; private Button fImportButton; private Button fExportButton; private Button fExportAllButton; private Button fRemoveButton; private Button fEnableAllButton; private Button fDisableAllButton; private SourceViewer fPatternViewer; private Button fFormatButton; public TemplatePreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(TemplateMessages.getString("TemplatePreferencePage.message")); //$NON-NLS-1$ fTemplates= Templates.getInstance(); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; parent.setLayout(layout); Table table= new Table(parent, SWT.CHECK | SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(80); data.heightHint= convertHeightInCharsToPixels(10); table.setLayoutData(data); table.setHeaderVisible(true); table.setLinesVisible(true); TableLayout tableLayout= new TableLayout(); table.setLayout(tableLayout); TableColumn column1= new TableColumn(table, SWT.NONE); column1.setText(TemplateMessages.getString("TemplatePreferencePage.column.name")); //$NON-NLS-1$ TableColumn column2= new TableColumn(table, SWT.NONE); column2.setText(TemplateMessages.getString("TemplatePreferencePage.column.context")); //$NON-NLS-1$ TableColumn column3= new TableColumn(table, SWT.NONE); column3.setText(TemplateMessages.getString("TemplatePreferencePage.column.description")); //$NON-NLS-1$ tableLayout.addColumnData(new ColumnWeightData(30)); tableLayout.addColumnData(new ColumnWeightData(20)); tableLayout.addColumnData(new ColumnWeightData(70)); fTableViewer= new CheckboxTableViewer(table); fTableViewer.setLabelProvider(new TemplateLabelProvider()); fTableViewer.setContentProvider(new TemplateContentProvider()); fTableViewer.setSorter(new ViewerSorter() { public int compare(Viewer viewer, Object object1, Object object2) { if ((object1 instanceof Template) && (object2 instanceof Template)) { Template left= (Template) object1; Template right= (Template) object2; int result= left.getName().compareToIgnoreCase(right.getName()); if (result != 0) return result; return left.getDescription().compareToIgnoreCase(right.getDescription()); } return super.compare(viewer, object1, object2); } public boolean isSorterProperty(Object element, String property) { return true; } }); fTableViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent e) { edit(); } }); fTableViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent e) { selectionChanged1(); } }); fTableViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { Template template= (Template) event.getElement(); template.setEnabled(event.getChecked()); } }); Composite buttons= new Composite(parent, SWT.NULL); buttons.setLayoutData(new GridData(GridData.VERTICAL_ALIGN_BEGINNING)); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; buttons.setLayout(layout); fAddButton= new Button(buttons, SWT.PUSH); fAddButton.setLayoutData(getButtonGridData(fAddButton)); fAddButton.setText(TemplateMessages.getString("TemplatePreferencePage.new")); //$NON-NLS-1$ fAddButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { add(); } }); fEditButton= new Button(buttons, SWT.PUSH); fEditButton.setLayoutData(getButtonGridData(fEditButton)); fEditButton.setText(TemplateMessages.getString("TemplatePreferencePage.edit")); //$NON-NLS-1$ fEditButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { edit(); } }); fRemoveButton= new Button(buttons, SWT.PUSH); fRemoveButton.setLayoutData(getButtonGridData(fRemoveButton)); fRemoveButton.setText(TemplateMessages.getString("TemplatePreferencePage.remove")); //$NON-NLS-1$ fRemoveButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { remove(); } }); createSpacer(buttons); fImportButton= new Button(buttons, SWT.PUSH); fImportButton.setLayoutData(getButtonGridData(fImportButton)); fImportButton.setText(TemplateMessages.getString("TemplatePreferencePage.import")); //$NON-NLS-1$ fImportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { import_(); } }); fExportButton= new Button(buttons, SWT.PUSH); fExportButton.setLayoutData(getButtonGridData(fExportButton)); fExportButton.setText(TemplateMessages.getString("TemplatePreferencePage.export")); //$NON-NLS-1$ fExportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { export(); } }); fExportAllButton= new Button(buttons, SWT.PUSH); fExportAllButton.setLayoutData(getButtonGridData(fExportAllButton)); fExportAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.export.all")); //$NON-NLS-1$ fExportAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { exportAll(); } }); createSpacer(buttons); fEnableAllButton= new Button(buttons, SWT.PUSH); fEnableAllButton.setLayoutData(getButtonGridData(fEnableAllButton)); fEnableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.enable.all")); //$NON-NLS-1$ fEnableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(true); } }); fDisableAllButton= new Button(buttons, SWT.PUSH); fDisableAllButton.setLayoutData(getButtonGridData(fDisableAllButton)); fDisableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.disable.all")); //$NON-NLS-1$ fDisableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(false); } }); fPatternViewer= createViewer(parent); createSpacer(parent); fFormatButton= new Button(parent, SWT.CHECK); fFormatButton.setText(TemplateMessages.getString("TemplatePreferencePage.use.code.formatter")); //$NON-NLS-1$ fTableViewer.setInput(fTemplates); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getBoolean(PREF_FORMAT_TEMPLATES)); updateButtons(); WorkbenchHelp.setHelp(parent, IJavaHelpContextIds.TEMPLATE_PREFERENCE_PAGE); return parent; } private Template[] getEnabledTemplates() { Template[] templates= fTemplates.getTemplates(); List list= new ArrayList(templates.length); for (int i= 0; i != templates.length; i++) if (templates[i].isEnabled()) list.add(templates[i]); return (Template[]) list.toArray(new Template[list.size()]); } private SourceViewer createViewer(Composite parent) { Label label= new Label(parent, SWT.NONE); label.setText(TemplateMessages.getString("TemplatePreferencePage.preview")); //$NON-NLS-1$ GridData data= new GridData(); data.horizontalSpan= 2; label.setLayoutData(data); SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); viewer.configure(new JavaSourceViewerConfiguration(tools, null)); viewer.setEditable(false); viewer.setDocument(new Document()); viewer.getTextWidget().setBackground(getShell().getDisplay().getSystemColor(SWT.COLOR_WIDGET_BACKGROUND)); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); data= new GridData(GridData.FILL_BOTH); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); return viewer; } public void createSpacer(Composite parent) { Label spacer= new Label(parent, SWT.NONE); GridData data= new GridData(); data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; data.heightHint= 4; spacer.setLayoutData(data); } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.widthHint= SWTUtil.getButtonWidthHint(button); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private void selectionChanged1() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); if (selection.size() == 1) { Template template= (Template) selection.getFirstElement(); fPatternViewer.getTextWidget().setText(template.getPattern()); } else { fPatternViewer.getTextWidget().setText(""); //$NON-NLS-1$ } updateButtons(); } private void updateButtons() { int selectionCount= ((IStructuredSelection) fTableViewer.getSelection()).size(); int itemCount= fTableViewer.getTable().getItemCount(); fEditButton.setEnabled(selectionCount == 1); fExportButton.setEnabled(selectionCount > 0); fRemoveButton.setEnabled(selectionCount > 0 && selectionCount <= itemCount); fEnableAllButton.setEnabled(itemCount > 0); fDisableAllButton.setEnabled(itemCount > 0); } private void add() { Template template= new Template(); ContextTypeRegistry registry=ContextTypeRegistry.getInstance(); ContextType type= registry.getContextType("java"); //$NON-NLS-1$ String contextTypeName; if (type != null) contextTypeName= type.getName(); else { Iterator iterator= registry.iterator(); contextTypeName= (String) iterator.next(); } template.setContext(contextTypeName); //$NON-NLS-1$ EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, false); if (dialog.open() == dialog.OK) { fTemplates.add(template); fTableViewer.refresh(); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void edit() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] objects= selection.toArray(); if ((objects == null) || (objects.length != 1)) return; Template template= (Template) selection.getFirstElement(); edit(template); } private void edit(Template template) { Template newTemplate= new Template(template); EditTemplateDialog dialog= new EditTemplateDialog(getShell(), newTemplate, true); if (dialog.open() == dialog.OK) { if (!newTemplate.getName().equals(template.getName()) && MessageDialog.openQuestion(getShell(), TemplateMessages.getString("TemplatePreferencePage.question.create.new.title"), //$NON-NLS-1$ TemplateMessages.getString("TemplatePreferencePage.question.create.new.message"))) //$NON-NLS-1$ { template= newTemplate; fTemplates.add(template); fTableViewer.refresh(); } else { template.setName(newTemplate.getName()); template.setDescription(newTemplate.getDescription()); template.setContext(newTemplate.getContextTypeName()); template.setPattern(newTemplate.getPattern()); fTableViewer.refresh(template); } fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void import_() { FileDialog dialog= new FileDialog(getShell()); dialog.setText(TemplateMessages.getString("TemplatePreferencePage.import.title")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.import.extension")}); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { fTemplates.addFromFile(new File(path)); fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } catch (CoreException e) { openReadErrorDialog(e); } } private void exportAll() { export(fTemplates); } private void export() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] templates= selection.toArray(); TemplateSet templateSet= new TemplateSet(); for (int i= 0; i != templates.length; i++) templateSet.add((Template) templates[i]); export(templateSet); } private void export(TemplateSet templateSet) { FileDialog dialog= new FileDialog(getShell(), SWT.SAVE); dialog.setText(TemplateMessages.getFormattedString("TemplatePreferencePage.export.title", new Integer(templateSet.getTemplates().length))); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.export.extension")}); //$NON-NLS-1$ dialog.setFileName(TemplateMessages.getString("TemplatePreferencePage.export.filename")); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; File file= new File(path); if (!file.exists() || confirmOverwrite(file)) { try { templateSet.saveToFile(file); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } } } private boolean confirmOverwrite(File file) { return MessageDialog.openQuestion(getShell(), TemplateMessages.getString("TemplatePreferencePage.export.exists.title"), //$NON-NLS-1$ TemplateMessages.getFormattedString("TemplatePreferencePage.export.exists.message", file.getAbsolutePath())); //$NON-NLS-1$ } private void remove() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Iterator elements= selection.iterator(); while (elements.hasNext()) { Template template= (Template) elements.next(); fTemplates.remove(template); } fTableViewer.refresh(); } private void enableAll(boolean enable) { Template[] templates= fTemplates.getTemplates(); for (int i= 0; i != templates.length; i++) templates[i].setEnabled(enable); fTableViewer.setAllChecked(enable); } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) {} /* * @see Control#setVisible(boolean) */ public void setVisible(boolean visible) { super.setVisible(visible); if (visible) setTitle(TemplateMessages.getString("TemplatePreferencePage.title")); //$NON-NLS-1$ } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getDefaultBoolean(PREF_FORMAT_TEMPLATES)); try { fTemplates.restoreDefaults(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } // refresh fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } /* * @see PreferencePage#performOk() */ public boolean performOk() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); prefs.setValue(PREF_FORMAT_TEMPLATES, fFormatButton.getSelection()); try { fTemplates.save(); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } JavaPlugin.getDefault().savePluginPreferences(); return super.performOk(); } /* * @see PreferencePage#performCancel() */ public boolean performCancel() { try { fTemplates.reset(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } return super.performCancel(); } /** * Initializes the default values of this page in the preference bundle. * Will be called on startup of the JavaPlugin */ public static void initDefaults(IPreferenceStore prefs) { prefs.setDefault(PREF_FORMAT_TEMPLATES, true); } public static boolean useCodeFormatter() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); return prefs.getBoolean(PREF_FORMAT_TEMPLATES); } private void openReadErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.read.title"), //$NON-NLS-1$ null, e.getStatus()); } private void openWriteErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.write.title"), //$NON-NLS-1$ null, e.getStatus()); } }
17,345
Bug 17345 add "org" to "Organize Imports"
Preferences>>Java>>Organize Imports I'd like to see the entry "org" added to the existing entries "java, javax, com". The package prefix "org" is so common ... why not add it to the existing ones ... eclipse itself has mostly this prefix.
closed fixed
0f0f22c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T16:55:08Z
2002-05-23T16:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/ImportOrganizePreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.IOException; import java.util.ArrayList; import java.util.List; import java.util.Properties; import java.util.StringTokenizer; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; /* * The page for setting the organize import settings */ public class ImportOrganizePreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // Preference store keys public static final String PREF_IMPORTORDER= JavaUI.ID_PLUGIN + ".importorder"; //$NON-NLS-1$ public static final String PREF_ONDEMANDTHRESHOLD= JavaUI.ID_PLUGIN + ".ondemandthreshold"; //$NON-NLS-1$ public static final String PREF_IGNORELOWERCASE= JavaUI.ID_PLUGIN + ".ignorelowercasenames"; //$NON-NLS-1$ private static final String PREF_LASTLOADPATH= JavaUI.ID_PLUGIN + ".importorder.loadpath"; //$NON-NLS-1$ private static final String PREF_LASTSAVEPATH= JavaUI.ID_PLUGIN + ".importorder.savepath"; //$NON-NLS-1$ public static String[] getImportOrderPreference() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); String str= prefs.getString(PREF_IMPORTORDER); if (str != null) { return unpackOrderList(str); } return new String[0]; } private static String[] unpackOrderList(String str) { StringTokenizer tok= new StringTokenizer(str, ";"); //$NON-NLS-1$ int nTokens= tok.countTokens(); String[] res= new String[nTokens]; for (int i= 0; i < nTokens; i++) { res[i]= tok.nextToken(); } return res; } private static String packOrderList(List orderList) { StringBuffer buf= new StringBuffer(); for (int i= 0; i < orderList.size(); i++) { buf.append((String) orderList.get(i)); buf.append(';'); } return buf.toString(); } public static int getImportNumberThreshold() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); int threshold= prefs.getInt(PREF_ONDEMANDTHRESHOLD); if (threshold < 0) { threshold= Integer.MAX_VALUE; } return threshold; } public static boolean doIgnoreLowerCaseNames() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); return prefs.getBoolean(PREF_IGNORELOWERCASE); } /** * Initializes the default values of this page in the preference bundle. * Will be called on startup of the JavaPlugin */ public static void initDefaults(IPreferenceStore prefs) { prefs.setDefault(PREF_IMPORTORDER, "java;javax;com"); //$NON-NLS-1$ prefs.setDefault(PREF_ONDEMANDTHRESHOLD, 99); } private static class ImportOrganizeLabelProvider extends LabelProvider { private static final Image PCK_ICON= JavaPluginImages.get(JavaPluginImages.IMG_OBJS_PACKAGE); public Image getImage(Object element) { return PCK_ICON; } } private class ImportOrganizeAdapter implements IListAdapter, IDialogFieldListener { public void customButtonPressed(DialogField field, int index) { doButtonPressed(index); } public void selectionChanged(DialogField field) { doSelectionChanged(); } public void dialogFieldChanged(DialogField field) { if (field == fThresholdField) { doThresholdChanged(); } } } private ListDialogField fOrderListField; private StringDialogField fThresholdField; private SelectionButtonDialogField fIgnoreLowerCaseTypesField; public ImportOrganizePreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("ImportOrganizePreferencePage.description")); //$NON-NLS-1$ String[] buttonLabels= new String[] { /* 0 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.add.button"), //$NON-NLS-1$ /* 1 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.edit.button"), //$NON-NLS-1$ /* 2 */ null, /* 3 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.up.button"), //$NON-NLS-1$ /* 4 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.down.button"), //$NON-NLS-1$ /* 5 */ null, /* 6 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.remove.button"), //$NON-NLS-1$ /* 7 */ null, /* 8 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.load.button"), //$NON-NLS-1$ /* 9 */ JavaUIMessages.getString("ImportOrganizePreferencePage.order.save.button") //$NON-NLS-1$ }; ImportOrganizeAdapter adapter= new ImportOrganizeAdapter(); fOrderListField= new ListDialogField(adapter, buttonLabels, new ImportOrganizeLabelProvider()); fOrderListField.setDialogFieldListener(adapter); fOrderListField.setLabelText(JavaUIMessages.getString("ImportOrganizePreferencePage.order.label")); //$NON-NLS-1$ fOrderListField.setUpButtonIndex(3); fOrderListField.setDownButtonIndex(4); fOrderListField.setRemoveButtonIndex(6); fOrderListField.enableButton(1, false); fThresholdField= new StringDialogField(); fThresholdField.setDialogFieldListener(adapter); fThresholdField.setLabelText(JavaUIMessages.getString("ImportOrganizePreferencePage.threshold.label")); //$NON-NLS-1$ fIgnoreLowerCaseTypesField= new SelectionButtonDialogField(SWT.CHECK); fIgnoreLowerCaseTypesField.setLabelText(JavaUIMessages.getString("ImportOrganizePreferencePage.ignoreLowerCase.label")); //$NON-NLS-1$ } /** * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { // added for 1GEUGE6: ITPJUI:WIN2000 - Help is the same on all preference pages super.createControl(parent); WorkbenchHelp.setHelp(getControl(), IJavaHelpContextIds.ORGANIZE_IMPORTS_PREFERENCE_PAGE); } protected Control createContents(Composite parent) { initialize(getImportOrderPreference(), getImportNumberThreshold(), doIgnoreLowerCaseNames()); Composite composite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); fOrderListField.doFillIntoGrid(composite, 3); LayoutUtil.setHorizontalSpan(fOrderListField.getLabelControl(null), 2); LayoutUtil.setHorizontalGrabbing(fOrderListField.getListControl(null)); fThresholdField.doFillIntoGrid(composite, 2); ((GridData) fThresholdField.getTextControl(null).getLayoutData()).grabExcessHorizontalSpace= false; fIgnoreLowerCaseTypesField.doFillIntoGrid(composite, 2); return composite; } private void initialize(String[] importOrder, int threshold, boolean ignoreLowerCase) { fOrderListField.removeAllElements(); for (int i= 0; i < importOrder.length; i++) { fOrderListField.addElement(importOrder[i]); } fThresholdField.setText(String.valueOf(threshold)); fIgnoreLowerCaseTypesField.setSelection(ignoreLowerCase); } private void doThresholdChanged() { StatusInfo status= new StatusInfo(); String thresholdString= fThresholdField.getText(); try { int threshold= Integer.parseInt(thresholdString); if (threshold < 0) { status.setError(JavaUIMessages.getString("ImportOrganizePreferencePage.error.invalidthreshold")); //$NON-NLS-1$ } } catch (NumberFormatException e) { status.setError(JavaUIMessages.getString("ImportOrganizePreferencePage.error.invalidthreshold")); //$NON-NLS-1$ } updateStatus(status); } private void doButtonPressed(int index) { if (index == 0) { // add new List existing= fOrderListField.getElements(); ImportOrganizeInputDialog dialog= new ImportOrganizeInputDialog(getShell(), existing); if (dialog.open() == dialog.OK) { fOrderListField.addElement(dialog.getResult()); } } else if (index == 1) { // edit List selected= fOrderListField.getSelectedElements(); if (selected.isEmpty()) { return; } String editedEntry= (String) selected.get(0); List existing= fOrderListField.getElements(); existing.remove(editedEntry); ImportOrganizeInputDialog dialog= new ImportOrganizeInputDialog(getShell(), existing); dialog.setInitialString(editedEntry); if (dialog.open() == dialog.OK) { fOrderListField.replaceElement(editedEntry, dialog.getResult()); } } else if (index == 8) { // load List order= loadImportOrder(); if (order != null) { fOrderListField.setElements(order); } } else if (index == 9) { // save saveImportOrder(fOrderListField.getElements()); } } private void doSelectionChanged() { // update enable state of the edit button List selected= fOrderListField.getSelectedElements(); fOrderListField.enableButton(1, selected.size() == 1); } /** * The import order file is a property file with keys * "0", "1" ... last entry. * values must be valid package names */ private List loadFromProperties(Properties properties) { ArrayList res= new ArrayList(); int nEntries= properties.size(); for (int i= 0 ; i < nEntries; i++) { String curr= properties.getProperty(String.valueOf(i)); if (curr != null) { if (JavaConventions.validatePackageName(curr).isOK()) { res.add(curr); } else { return null; } } else { return res; } } return res; } private List loadImportOrder() { FileDialog dialog= new FileDialog(getShell(), SWT.OPEN); dialog.setText(JavaUIMessages.getString("ImportOrganizePreferencePage.loadDialog.title")); //$NON-NLS-1$) dialog.setFilterExtensions(new String[] {"*.importorder", "*.*"}); //$NON-NLS-1$ //$NON-NLS-2$ String lastPath= getPreferenceStore().getString(PREF_LASTLOADPATH); if (lastPath != null) { dialog.setFilterPath(lastPath); } String fileName= dialog.open(); if (fileName != null) { getPreferenceStore().putValue(PREF_LASTLOADPATH, dialog.getFilterPath()); Properties properties= new Properties(); FileInputStream fis= null; try { fis= new FileInputStream(fileName); properties.load(fis); List res= loadFromProperties(properties); if (res != null) { return res; } } catch (IOException e) { JavaPlugin.log(e); } finally { if (fis != null) { try { fis.close(); } catch (IOException e) {} } } String title= JavaUIMessages.getString("ImportOrganizePreferencePage.loadDialog.error.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("ImportOrganizePreferencePage.loadDialog.error.message"); //$NON-NLS-1$ MessageDialog.openError(getShell(), title, message); } return null; } private void saveImportOrder(List elements) { FileDialog dialog= new FileDialog(getShell(), SWT.SAVE); dialog.setText(JavaUIMessages.getString("ImportOrganizePreferencePage.saveDialog.title")); //$NON-NLS-1$) dialog.setFilterExtensions(new String[] {"*.importorder", "*.*"}); //$NON-NLS-1$ //$NON-NLS-2$ dialog.setFileName("example.importorder"); //$NON-NLS-1$ String lastPath= getPreferenceStore().getString(PREF_LASTSAVEPATH); if (lastPath != null) { dialog.setFilterPath(lastPath); } String fileName= dialog.open(); if (fileName != null) { getPreferenceStore().putValue(PREF_LASTSAVEPATH, dialog.getFilterPath()); Properties properties= new Properties(); for (int i= 0; i < elements.size(); i++) { properties.setProperty(String.valueOf(i), (String) elements.get(i)); } FileOutputStream fos= null; try { fos= new FileOutputStream(fileName); properties.store(fos, "Organize Import Order"); //$NON-NLS-1$ } catch (IOException e) { JavaPlugin.log(e); String title= JavaUIMessages.getString("ImportOrganizePreferencePage.saveDialog.error.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("ImportOrganizePreferencePage.saveDialog.error.message"); //$NON-NLS-1$ MessageDialog.openError(getShell(), title, message); } finally { if (fos != null) { try { fos.close(); } catch (IOException e) {} } } } } public void init(IWorkbench workbench) { } private void updateStatus(IStatus status) { setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } /** * @see PreferencePage#performDefaults() */ protected void performDefaults() { String[] order; IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); String str= prefs.getDefaultString(PREF_IMPORTORDER); if (str != null) { order= unpackOrderList(str); } else { order= new String[0]; } int threshold= prefs.getDefaultInt(PREF_ONDEMANDTHRESHOLD); if (threshold < 0) { threshold= Integer.MAX_VALUE; } boolean ignoreLowerCase= prefs.getDefaultBoolean(PREF_IGNORELOWERCASE); initialize(order, threshold, ignoreLowerCase); super.performDefaults(); } /** * @see IPreferencePage#performOk() */ public boolean performOk() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); prefs.setValue(PREF_IMPORTORDER, packOrderList(fOrderListField.getElements())); prefs.setValue(PREF_ONDEMANDTHRESHOLD, fThresholdField.getText()); prefs.setValue(PREF_IGNORELOWERCASE, fIgnoreLowerCaseTypesField.isSelected()); JavaPlugin.getDefault().savePluginPreferences(); return true; } }
18,034
Bug 18034 active working set indication in view menu
should use the bullet (one-of) decoration and not the check mark to show the active working set.
verified fixed
0ee70c1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T17:03:33Z
2002-05-28T12:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/workingsets/CheckWorkingSetAction.java
18,034
Bug 18034 active working set indication in view menu
should use the bullet (one-of) decoration and not the check mark to show the active working set.
verified fixed
0ee70c1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T17:03:33Z
2002-05-28T12:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/workingsets/WorkingSetFilterActionGroup.java
18,034
Bug 18034 active working set indication in view menu
should use the bullet (one-of) decoration and not the check mark to show the active working set.
verified fixed
0ee70c1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T17:03:33Z
2002-05-28T12:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/workingsets/WorkingSetMenuContributionItem.java
17,311
Bug 17311 Javadoc properties page prevents keyboard navigation
Build 20020521 The Javadoc properties page for a project sets the focus to the javadoc location as soon as it is selected. As a result if you are using the keyboard to move through the list entries you have to tab out everytime you hit it. STEPS 1) Open the properties on a java project 2) Use the keyboard to move through the list of pages 3) When you hit the javadoc page the cursor is taken and you have to tab out
verified fixed
f5f6d4e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T17:15:12Z
2002-05-23T13:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavadocConfigurationPropertyPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.net.URL; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.ui.dialogs.PropertyPage; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; /** * Property page used to set the project's Javadoc location for sources */ public class JavadocConfigurationPropertyPage extends PropertyPage implements IStatusChangeListener { private JavadocConfigurationBlock fJavadocConfigurationBlock; public JavadocConfigurationPropertyPage() { } /** * @see IDialogPage#createControl(Composite) */ public void createControl(Composite parent) { IJavaElement elem= getJavaElement(); if (elem instanceof IPackageFragmentRoot) setDescription(JavaUIMessages.getString("JavadocConfigurationPropertyPage.IsPackageFragmentRoot.description")); //$NON-NLS-1$ else if (elem instanceof IJavaProject) setDescription(JavaUIMessages.getString("JavadocConfigurationPropertyPage.IsJavaProject.description")); //$NON-NLS-1$ else setDescription(JavaUIMessages.getString("JavadocConfigurationPropertyPage.IsIncorrectElement.description")); //$NON-NLS-1$ super.createControl(parent); } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { IJavaElement elem= getJavaElement(); fJavadocConfigurationBlock= new JavadocConfigurationBlock(elem, getShell(), this); Control control= fJavadocConfigurationBlock.createContents(parent); return control; } private IJavaElement getJavaElement() { IAdaptable adaptable= getElement(); IJavaElement elem= (IJavaElement) adaptable.getAdapter(IJavaElement.class); if (elem == null) { IResource resource= (IResource) adaptable.getAdapter(IResource.class); //special case when the .jar is a file try { if (resource instanceof IFile) { IProject proj= resource.getProject(); if (proj.hasNature(JavaCore.NATURE_ID)) { IJavaProject jproject= JavaCore.create(proj); IPackageFragmentRoot root= jproject.findPackageFragmentRoot(resource.getFullPath()); if (root != null && root.isArchive()) { elem= root; } } } } catch (CoreException e) { JavaPlugin.log(e); } } return elem; } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fJavadocConfigurationBlock.performDefaults(); super.performDefaults(); } /** * @see IPreferencePage#performOk() */ public boolean performOk() { return fJavadocConfigurationBlock.performOk(); } /* (non-Javadoc) * @see IDialogPage#setVisible(boolean) */ public void setVisible(boolean visible) { if (visible) { fJavadocConfigurationBlock.setFocus(); } super.setVisible(visible); } /** * @see IStatusChangeListener#statusChanged(IStatus) */ public void statusChanged(IStatus status) { setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } }
17,295
Bug 17295 Formating pref page: remove the icons in the tabs
The icons add minimal value and we should remove them.
resolved fixed
e872c61
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-28T17:18:05Z
2002-05-23T13:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CodeFormatterPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.Hashtable; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.ICodeFormatter; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.ToolFactory; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; /* * The page for setting code formatter options */ public class CodeFormatterPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // Preference store keys, see JavaCore.getOptions private static final String PREF_NEWLINE_OPENING_BRACES= JavaCore.FORMATTER_NEWLINE_OPENING_BRACE; private static final String PREF_NEWLINE_CONTROL_STATEMENT= JavaCore.FORMATTER_NEWLINE_CONTROL; private static final String PREF_NEWLINE_CLEAR_ALL= JavaCore.FORMATTER_CLEAR_BLANK_LINES; private static final String PREF_NEWLINE_ELSE_IF= JavaCore.FORMATTER_NEWLINE_ELSE_IF; private static final String PREF_NEWLINE_EMPTY_BLOCK= JavaCore.FORMATTER_NEWLINE_EMPTY_BLOCK; private static final String PREF_LINE_SPLIT= JavaCore.FORMATTER_LINE_SPLIT; private static final String PREF_STYLE_COMPACT_ASSIGNEMENT= JavaCore.FORMATTER_COMPACT_ASSIGNMENT; private static final String PREF_TAB_CHAR= JavaCore.FORMATTER_TAB_CHAR; private static final String PREF_TAB_SIZE= JavaCore.FORMATTER_TAB_SIZE; // values private static final String INSERT= JavaCore.INSERT; private static final String DO_NOT_INSERT= JavaCore.DO_NOT_INSERT; private static final String COMPACT= JavaCore.COMPACT; private static final String NORMAL= JavaCore.NORMAL; private static final String TAB= JavaCore.TAB; private static final String SPACE= JavaCore.SPACE; private static final String CLEAR_ALL= JavaCore.CLEAR_ALL; private static final String PRESERVE_ONE= JavaCore.PRESERVE_ONE; private static String[] getAllKeys() { return new String[] { PREF_NEWLINE_OPENING_BRACES, PREF_NEWLINE_CONTROL_STATEMENT, PREF_NEWLINE_CLEAR_ALL, PREF_NEWLINE_ELSE_IF, PREF_NEWLINE_EMPTY_BLOCK, PREF_LINE_SPLIT, PREF_STYLE_COMPACT_ASSIGNEMENT, PREF_TAB_CHAR, PREF_TAB_SIZE }; } /** * Gets the currently configured tab size */ public static int getTabSize() { String string= (String) JavaCore.getOptions().get(PREF_TAB_SIZE); return getPositiveIntValue(string, 4); } /** * Gets the current compating assignement configuration */ public static boolean isCompactingAssignment() { return COMPACT.equals(JavaCore.getOptions().get(PREF_STYLE_COMPACT_ASSIGNEMENT)); } /** * Gets the current compating assignement configuration */ public static boolean useSpaces() { return SPACE.equals(JavaCore.getOptions().get(PREF_TAB_CHAR)); } private static int getPositiveIntValue(String string, int dflt) { try { int i= Integer.parseInt(string); if (i >= 0) { return i; } } catch (NumberFormatException e) { } return dflt; } /** * Initializes the current options (read from preference store) */ public static void initDefaults(IPreferenceStore store) { } private static class ControlData { private String fKey; private String[] fValues; public ControlData(String key, String[] values) { fKey= key; fValues= values; } public String getKey() { return fKey; } public String getValue(boolean selection) { int index= selection ? 0 : 1; return fValues[index]; } public String getValue(int index) { return fValues[index]; } public int getSelection(String value) { for (int i= 0; i < fValues.length; i++) { if (value.equals(fValues[i])) { return i; } } throw new IllegalArgumentException(); } } private Hashtable fWorkingValues; private ArrayList fCheckBoxes; private ArrayList fTextBoxes; private SelectionListener fButtonSelectionListener; private ModifyListener fTextModifyListener; private String fPreviewText; private IDocument fPreviewDocument; private Text fTabSizeTextBox; private SourceViewer fSourceViewer; public CodeFormatterPreferencePage() { setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("CodeFormatterPreferencePage.description")); //$NON-NLS-1$ fWorkingValues= JavaCore.getOptions(); fCheckBoxes= new ArrayList(); fTextBoxes= new ArrayList(); fButtonSelectionListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) {} public void widgetSelected(SelectionEvent e) { if (!e.widget.isDisposed()) { controlChanged((Button) e.widget); } } }; fTextModifyListener= new ModifyListener() { public void modifyText(ModifyEvent e) { if (!e.widget.isDisposed()) { textChanged((Text) e.widget); } } }; fPreviewDocument= new Document(); fPreviewText= loadPreviewFile("CodeFormatterPreviewCode.txt"); //$NON-NLS-1$ } /* * @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /* * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), IJavaHelpContextIds.CODEFORMATTER_PREFERENCE_PAGE); } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { GridLayout layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; Composite composite= new Composite(parent, SWT.NONE); composite.setLayout(layout); TabFolder folder= new TabFolder(composite, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); String[] insertNotInsert= new String[] { INSERT, DO_NOT_INSERT }; layout= new GridLayout(); layout.numColumns= 2; Composite newlineComposite= new Composite(folder, SWT.NULL); newlineComposite.setLayout(layout); String label= JavaUIMessages.getString("CodeFormatterPreferencePage.newline_opening_braces.label"); //$NON-NLS-1$ addCheckBox(newlineComposite, label, PREF_NEWLINE_OPENING_BRACES, insertNotInsert); label= JavaUIMessages.getString("CodeFormatterPreferencePage.newline_control_statement.label"); //$NON-NLS-1$ addCheckBox(newlineComposite, label, PREF_NEWLINE_CONTROL_STATEMENT, insertNotInsert); label= JavaUIMessages.getString("CodeFormatterPreferencePage.newline_clear_lines"); //$NON-NLS-1$ addCheckBox(newlineComposite, label, PREF_NEWLINE_CLEAR_ALL, new String[] { CLEAR_ALL, PRESERVE_ONE } ); label= JavaUIMessages.getString("CodeFormatterPreferencePage.newline_else_if.label"); //$NON-NLS-1$ addCheckBox(newlineComposite, label, PREF_NEWLINE_ELSE_IF, insertNotInsert); label= JavaUIMessages.getString("CodeFormatterPreferencePage.newline_empty_block.label"); //$NON-NLS-1$ addCheckBox(newlineComposite, label, PREF_NEWLINE_EMPTY_BLOCK, insertNotInsert); layout= new GridLayout(); layout.numColumns= 2; Composite lineSplittingComposite= new Composite(folder, SWT.NULL); lineSplittingComposite.setLayout(layout); label= JavaUIMessages.getString("CodeFormatterPreferencePage.split_line.label"); //$NON-NLS-1$ addTextField(lineSplittingComposite, label, PREF_LINE_SPLIT); layout= new GridLayout(); layout.numColumns= 2; Composite styleComposite= new Composite(folder, SWT.NULL); styleComposite.setLayout(layout); label= JavaUIMessages.getString("CodeFormatterPreferencePage.style_compact_assignement.label"); //$NON-NLS-1$ addCheckBox(styleComposite, label, PREF_STYLE_COMPACT_ASSIGNEMENT, new String[] { COMPACT, NORMAL } ); label= JavaUIMessages.getString("CodeFormatterPreferencePage.tab_char.label"); //$NON-NLS-1$ addCheckBox(styleComposite, label, PREF_TAB_CHAR, new String[] { TAB, SPACE } ); label= JavaUIMessages.getString("CodeFormatterPreferencePage.tab_size.label"); //$NON-NLS-1$ fTabSizeTextBox= addTextField(styleComposite, label, PREF_TAB_SIZE); TabItem item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CodeFormatterPreferencePage.tab.newline.tabtitle")); //$NON-NLS-1$ item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_IMPDECL)); item.setControl(newlineComposite); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CodeFormatterPreferencePage.tab.linesplit.tabtitle")); //$NON-NLS-1$ item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CFILE)); item.setControl(lineSplittingComposite); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CodeFormatterPreferencePage.tab.style.tabtitle")); //$NON-NLS-1$ item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_SEARCH_REF)); item.setControl(styleComposite); fSourceViewer= createPreview(parent); updatePreview(); return composite; } private SourceViewer createPreview(Composite parent) { SourceViewer previewViewer= new SourceViewer(parent, null, SWT.V_SCROLL | SWT.H_SCROLL | SWT.BORDER); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); previewViewer.configure(new JavaSourceViewerConfiguration(tools, null)); previewViewer.getTextWidget().setFont(JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT)); previewViewer.getTextWidget().setTabs(getPositiveIntValue((String) fWorkingValues.get(PREF_TAB_SIZE), 0)); previewViewer.setEditable(false); previewViewer.setDocument(fPreviewDocument); Control control= previewViewer.getControl(); GridData gdata= new GridData(GridData.FILL_BOTH); gdata.widthHint= convertWidthInCharsToPixels(80); gdata.heightHint= convertHeightInCharsToPixels(15); control.setLayoutData(gdata); return previewViewer; } private Button addCheckBox(Composite parent, String label, String key, String[] values) { ControlData data= new ControlData(key, values); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalSpan= 2; Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); checkBox.setData(data); checkBox.setLayoutData(gd); String currValue= (String)fWorkingValues.get(key); checkBox.setSelection(data.getSelection(currValue) == 0); checkBox.addSelectionListener(fButtonSelectionListener); fCheckBoxes.add(checkBox); return checkBox; } private Text addTextField(Composite parent, String label, String key) { Label labelControl= new Label(parent, SWT.NONE); labelControl.setText(label); labelControl.setLayoutData(new GridData()); Text textBox= new Text(parent, SWT.BORDER | SWT.SINGLE); textBox.setData(key); textBox.setLayoutData(new GridData()); String currValue= (String)fWorkingValues.get(key); textBox.setText(String.valueOf(getPositiveIntValue(currValue, 1))); textBox.setTextLimit(3); textBox.addModifyListener(fTextModifyListener); GridData gd= new GridData(); gd.widthHint= convertWidthInCharsToPixels(5); textBox.setLayoutData(gd); fTextBoxes.add(textBox); return textBox; } private void controlChanged(Button button) { ControlData data= (ControlData) button.getData(); boolean selection= button.getSelection(); String newValue= data.getValue(selection); fWorkingValues.put(data.getKey(), newValue); updatePreview(); if (PREF_TAB_CHAR.equals(data.getKey())) { updateStatus(new StatusInfo()); if (selection) { fTabSizeTextBox.setText((String)fWorkingValues.get(PREF_TAB_SIZE)); } } } private void textChanged(Text textControl) { String key= (String) textControl.getData(); String number= textControl.getText(); IStatus status= validatePositiveNumber(number); if (!status.matches(IStatus.ERROR)) { fWorkingValues.put(key, number); } if (PREF_TAB_SIZE.equals(key)) { fSourceViewer.getTextWidget().setTabs(getPositiveIntValue(number, 0)); } updateStatus(status); updatePreview(); } /* * @see IPreferencePage#performOk() */ public boolean performOk() { String[] allKeys= getAllKeys(); // preserve other options // store in JCore Hashtable actualOptions= JavaCore.getOptions(); for (int i= 0; i < allKeys.length; i++) { String key= allKeys[i]; String val= (String) fWorkingValues.get(key); actualOptions.put(key, val); } JavaCore.setOptions(actualOptions); JavaPlugin.getDefault().savePluginPreferences(); return super.performOk(); } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fWorkingValues= JavaCore.getDefaultOptions(); updateControls(); super.performDefaults(); } private String loadPreviewFile(String filename) { String separator= System.getProperty("line.separator"); //$NON-NLS-1$ StringBuffer btxt= new StringBuffer(512); BufferedReader rin= null; try { rin= new BufferedReader(new InputStreamReader(getClass().getResourceAsStream(filename))); String line; while ((line= rin.readLine()) != null) { btxt.append(line); btxt.append(separator); } } catch (IOException io) { JavaPlugin.log(io); } finally { if (rin != null) { try { rin.close(); } catch (IOException e) {} } } return btxt.toString(); } private void updatePreview() { ICodeFormatter formatter= ToolFactory.createDefaultCodeFormatter(fWorkingValues); fPreviewDocument.set(formatter.format(fPreviewText, 0, null, "\n")); //$NON-NLS-1$ } private void updateControls() { // update the UI for (int i= fCheckBoxes.size() - 1; i >= 0; i--) { Button curr= (Button) fCheckBoxes.get(i); ControlData data= (ControlData) curr.getData(); String currValue= (String) fWorkingValues.get(data.getKey()); curr.setSelection(data.getSelection(currValue) == 0); } for (int i= fTextBoxes.size() - 1; i >= 0; i--) { Text curr= (Text) fTextBoxes.get(i); String key= (String) curr.getData(); String currValue= (String) fWorkingValues.get(key); curr.setText(currValue); } } private IStatus validatePositiveNumber(String number) { StatusInfo status= new StatusInfo(); if (number.length() == 0) { status.setError(JavaUIMessages.getString("CodeFormatterPreferencePage.empty_input")); //$NON-NLS-1$ } else { try { int value= Integer.parseInt(number); if (value < 0) { status.setError(JavaUIMessages.getFormattedString("CodeFormatterPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } catch (NumberFormatException e) { status.setError(JavaUIMessages.getFormattedString("CodeFormatterPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } return status; } private void updateStatus(IStatus status) { if (!status.matches(IStatus.ERROR)) { // look if there are more severe errors for (int i= 0; i < fTextBoxes.size(); i++) { Text curr= (Text) fTextBoxes.get(i); if (!(curr == fTabSizeTextBox && usesTabs())) { IStatus currStatus= validatePositiveNumber(curr.getText()); status= StatusUtil.getMoreSevere(currStatus, status); } } } setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } private boolean usesTabs() { return TAB.equals(fWorkingValues.get(PREF_TAB_CHAR)); } }
18,082
Bug 18082 compiler pref page is the only one with icons
the icons are pretty but i think we should remove them for consistency
resolved fixed
bb27a7f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T07:57:23Z
2002-05-28T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Arrays; import java.util.Hashtable; import org.eclipse.core.resources.IncrementalProjectBuilder; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.events.DisposeEvent; import org.eclipse.swt.events.DisposeListener; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Combo; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Text; import org.eclipse.swt.widgets.Widget; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; /* * The page for setting the compiler options. */ public class CompilerPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // Preference store keys, see JavaCore.getOptions private static final String PREF_LOCAL_VARIABLE_ATTR= JavaCore.COMPILER_LOCAL_VARIABLE_ATTR; private static final String PREF_LINE_NUMBER_ATTR= JavaCore.COMPILER_LINE_NUMBER_ATTR; private static final String PREF_SOURCE_FILE_ATTR= JavaCore.COMPILER_SOURCE_FILE_ATTR; private static final String PREF_CODEGEN_UNUSED_LOCAL= JavaCore.COMPILER_CODEGEN_UNUSED_LOCAL; private static final String PREF_CODEGEN_TARGET_PLATFORM= JavaCore.COMPILER_CODEGEN_TARGET_PLATFORM; private static final String PREF_PB_UNREACHABLE_CODE= JavaCore.COMPILER_PB_UNREACHABLE_CODE; private static final String PREF_PB_INVALID_IMPORT= JavaCore.COMPILER_PB_INVALID_IMPORT; private static final String PREF_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD= JavaCore.COMPILER_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD; private static final String PREF_PB_METHOD_WITH_CONSTRUCTOR_NAME= JavaCore.COMPILER_PB_METHOD_WITH_CONSTRUCTOR_NAME; private static final String PREF_PB_DEPRECATION= JavaCore.COMPILER_PB_DEPRECATION; private static final String PREF_PB_HIDDEN_CATCH_BLOCK= JavaCore.COMPILER_PB_HIDDEN_CATCH_BLOCK; private static final String PREF_PB_UNUSED_LOCAL= JavaCore.COMPILER_PB_UNUSED_LOCAL; private static final String PREF_PB_UNUSED_PARAMETER= JavaCore.COMPILER_PB_UNUSED_PARAMETER; private static final String PREF_PB_SYNTHETIC_ACCESS_EMULATION= JavaCore.COMPILER_PB_SYNTHETIC_ACCESS_EMULATION; private static final String PREF_PB_NON_EXTERNALIZED_STRINGS= JavaCore.COMPILER_PB_NON_NLS_STRING_LITERAL; private static final String PREF_PB_ASSERT_AS_IDENTIFIER= JavaCore.COMPILER_PB_ASSERT_IDENTIFIER; private static final String PREF_PB_MAX_PER_UNIT= JavaCore.COMPILER_PB_MAX_PER_UNIT; private static final String PREF_SOURCE_COMPATIBILITY= JavaCore.COMPILER_SOURCE; private static final String PREF_COMPLIANCE= JavaCore.COMPILER_COMPLIANCE; private static final String INTR_DEFAULT_COMPLIANCE= "internal.default.compliance"; //$NON-NLS-1$ // values private static final String GENERATE= JavaCore.GENERATE; private static final String DO_NOT_GENERATE= JavaCore.DO_NOT_GENERATE; private static final String PRESERVE= JavaCore.PRESERVE; private static final String OPTIMIZE_OUT= JavaCore.OPTIMIZE_OUT; private static final String VERSION_1_1= JavaCore.VERSION_1_1; private static final String VERSION_1_2= JavaCore.VERSION_1_2; private static final String VERSION_1_3= JavaCore.VERSION_1_3; private static final String VERSION_1_4= JavaCore.VERSION_1_4; private static final String ERROR= JavaCore.ERROR; private static final String WARNING= JavaCore.WARNING; private static final String IGNORE= JavaCore.IGNORE; private static final String DEFAULT= "default"; //$NON-NLS-1$ private static final String USER= "user"; //$NON-NLS-1$ private static String[] getAllKeys() { return new String[] { PREF_LOCAL_VARIABLE_ATTR, PREF_LINE_NUMBER_ATTR, PREF_SOURCE_FILE_ATTR, PREF_CODEGEN_UNUSED_LOCAL, PREF_CODEGEN_TARGET_PLATFORM, PREF_PB_UNREACHABLE_CODE, PREF_PB_INVALID_IMPORT, PREF_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD, PREF_PB_METHOD_WITH_CONSTRUCTOR_NAME, PREF_PB_DEPRECATION, PREF_PB_HIDDEN_CATCH_BLOCK, PREF_PB_UNUSED_LOCAL, PREF_PB_UNUSED_PARAMETER, PREF_PB_SYNTHETIC_ACCESS_EMULATION, PREF_PB_NON_EXTERNALIZED_STRINGS, PREF_PB_ASSERT_AS_IDENTIFIER, PREF_SOURCE_COMPATIBILITY, PREF_COMPLIANCE, PREF_PB_MAX_PER_UNIT }; } /** * Initializes the current options (read from preference store) */ public static void initDefaults(IPreferenceStore store) { } private static class ControlData { private String fKey; private String[] fValues; public ControlData(String key, String[] values) { fKey= key; fValues= values; } public String getKey() { return fKey; } public String getValue(boolean selection) { int index= selection ? 0 : 1; return fValues[index]; } public String getValue(int index) { return fValues[index]; } public int getSelection(String value) { for (int i= 0; i < fValues.length; i++) { if (value.equals(fValues[i])) { return i; } } throw new IllegalArgumentException(); } } private Hashtable fWorkingValues; private ArrayList fCheckBoxes; private ArrayList fComboBoxes; private ArrayList fTextBoxes; private SelectionListener fSelectionListener; private ModifyListener fTextModifyListener; private ArrayList fComplianceControls; public CompilerPreferencePage() { setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("CompilerPreferencePage.description")); //$NON-NLS-1$ fWorkingValues= JavaCore.getOptions(); fWorkingValues.put(INTR_DEFAULT_COMPLIANCE, getCurrentCompliance()); fCheckBoxes= new ArrayList(); fComboBoxes= new ArrayList(); fTextBoxes= new ArrayList(2); fComplianceControls= new ArrayList(); fSelectionListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) {} public void widgetSelected(SelectionEvent e) { controlChanged(e.widget); } }; fTextModifyListener= new ModifyListener() { public void modifyText(ModifyEvent e) { textChanged((Text) e.widget); } }; } /** * @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /** * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { // added for 1GEUGE6: ITPJUI:WIN2000 - Help is the same on all preference pages super.createControl(parent); WorkbenchHelp.setHelp(getControl(), IJavaHelpContextIds.COMPILER_PREFERENCE_PAGE); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { TabFolder folder= new TabFolder(parent, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); Composite warningsComposite= createWarningsTabContent(folder); Composite codeGenComposite= createCodeGenTabContent(folder); Composite complianceComposite= createComplianceTabContent(folder); TabItem item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CompilerPreferencePage.warnings.tabtitle")); //$NON-NLS-1$ final Image errorWarningImage= JavaPluginImages.DESC_VIEW_ERRORWARNING_TAB.createImage(); item.setImage(errorWarningImage); item.setControl(warningsComposite); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CompilerPreferencePage.generation.tabtitle")); //$NON-NLS-1$ final Image generationImage= JavaPluginImages.DESC_VIEW_CLASSFILEGENERATION_TAB.createImage(); item.setImage(generationImage); item.setControl(codeGenComposite); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CompilerPreferencePage.compliance.tabtitle")); //$NON-NLS-1$ final Image jdkcomplianceImage= JavaPluginImages.DESC_VIEW_JDKCOMPLIANCE_TAB.createImage(); item.setImage(jdkcomplianceImage); item.setControl(complianceComposite); validateSettings(null, null); folder.addDisposeListener(new DisposeListener() { public void widgetDisposed(DisposeEvent e) { errorWarningImage.dispose(); generationImage.dispose(); jdkcomplianceImage.dispose(); } }); return folder; } private Composite createWarningsTabContent(Composite folder) { String[] errorWarningIgnore= new String[] { ERROR, WARNING, IGNORE }; String[] errorWarningIgnoreLabels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.error"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.warning"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.ignore") //$NON-NLS-1$ }; GridLayout layout= new GridLayout(); layout.numColumns= 2; Composite warningsComposite= new Composite(folder, SWT.NULL); warningsComposite.setLayout(layout); Label description= new Label(warningsComposite, SWT.WRAP); description.setText(JavaUIMessages.getString("CompilerPreferencePage.warnings.description")); //$NON-NLS-1$ GridData gd= new GridData(); gd.horizontalSpan= 2; gd.widthHint= convertWidthInCharsToPixels(60); description.setLayoutData(gd); String label= JavaUIMessages.getString("CompilerPreferencePage.pb_unreachable_code.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_UNREACHABLE_CODE, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_invalid_import.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_INVALID_IMPORT, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_overriding_pkg_dflt.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_method_naming.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_METHOD_WITH_CONSTRUCTOR_NAME, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_deprecation.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_DEPRECATION, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_hidden_catchblock.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_HIDDEN_CATCH_BLOCK, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_unused_local.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_UNUSED_LOCAL, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_unused_parameter.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_UNUSED_PARAMETER, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_synth_access_emul.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_SYNTHETIC_ACCESS_EMULATION, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_non_externalized_strings.label"); //$NON-NLS-1$ addComboBox(warningsComposite, label, PREF_PB_NON_EXTERNALIZED_STRINGS, errorWarningIgnore, errorWarningIgnoreLabels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.pb_max_per_unit.label"); //$NON-NLS-1$ addTextField(warningsComposite, label, PREF_PB_MAX_PER_UNIT); return warningsComposite; } private Composite createCodeGenTabContent(Composite folder) { String[] generateValues= new String[] { GENERATE, DO_NOT_GENERATE }; GridLayout layout= new GridLayout(); layout.numColumns= 2; Composite codeGenComposite= new Composite(folder, SWT.NULL); codeGenComposite.setLayout(layout); String label= JavaUIMessages.getString("CompilerPreferencePage.variable_attr.label"); //$NON-NLS-1$ addCheckBox(codeGenComposite, label, PREF_LOCAL_VARIABLE_ATTR, generateValues, 0); label= JavaUIMessages.getString("CompilerPreferencePage.line_number_attr.label"); //$NON-NLS-1$ addCheckBox(codeGenComposite, label, PREF_LINE_NUMBER_ATTR, generateValues, 0); label= JavaUIMessages.getString("CompilerPreferencePage.source_file_attr.label"); //$NON-NLS-1$ addCheckBox(codeGenComposite, label, PREF_SOURCE_FILE_ATTR, generateValues, 0); label= JavaUIMessages.getString("CompilerPreferencePage.codegen_unused_local.label"); //$NON-NLS-1$ addCheckBox(codeGenComposite, label, PREF_CODEGEN_UNUSED_LOCAL, new String[] { PRESERVE, OPTIMIZE_OUT }, 0); return codeGenComposite; } private Composite createComplianceTabContent(Composite folder) { GridLayout layout= new GridLayout(); layout.numColumns= 2; Composite complianceComposite= new Composite(folder, SWT.NULL); complianceComposite.setLayout(layout); String[] values34= new String[] { VERSION_1_3, VERSION_1_4 }; String[] values34Labels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.version13"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.version14") //$NON-NLS-1$ }; String label= JavaUIMessages.getString("CompilerPreferencePage.compiler_compliance.label"); //$NON-NLS-1$ addComboBox(complianceComposite, label, PREF_COMPLIANCE, values34, values34Labels, 0); label= JavaUIMessages.getString("CompilerPreferencePage.default_settings.label"); //$NON-NLS-1$ addCheckBox(complianceComposite, label, INTR_DEFAULT_COMPLIANCE, new String[] { DEFAULT, USER }, 0); int indent= convertWidthInCharsToPixels(2); Control[] otherChildren= complianceComposite.getChildren(); String[] values14= new String[] { VERSION_1_1, VERSION_1_2, VERSION_1_3, VERSION_1_4 }; String[] values14Labels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.version11"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.version12"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.version13"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.version14") //$NON-NLS-1$ }; label= JavaUIMessages.getString("CompilerPreferencePage.codegen_targetplatform.label"); //$NON-NLS-1$ addComboBox(complianceComposite, label, PREF_CODEGEN_TARGET_PLATFORM, values14, values14Labels, indent); label= JavaUIMessages.getString("CompilerPreferencePage.source_compatibility.label"); //$NON-NLS-1$ addComboBox(complianceComposite, label, PREF_SOURCE_COMPATIBILITY, values34, values34Labels, indent); String[] errorWarningIgnore= new String[] { ERROR, WARNING, IGNORE }; String[] errorWarningIgnoreLabels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.error"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.warning"), //$NON-NLS-1$ JavaUIMessages.getString("CompilerPreferencePage.ignore") //$NON-NLS-1$ }; label= JavaUIMessages.getString("CompilerPreferencePage.pb_assert_as_identifier.label"); //$NON-NLS-1$ addComboBox(complianceComposite, label, PREF_PB_ASSERT_AS_IDENTIFIER, errorWarningIgnore, errorWarningIgnoreLabels, indent); Control[] allChildren= complianceComposite.getChildren(); fComplianceControls.addAll(Arrays.asList(allChildren)); fComplianceControls.removeAll(Arrays.asList(otherChildren)); return complianceComposite; } private void addCheckBox(Composite parent, String label, String key, String[] values, int indent) { ControlData data= new ControlData(key, values); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; gd.horizontalIndent= indent; Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); checkBox.setData(data); checkBox.setLayoutData(gd); checkBox.addSelectionListener(fSelectionListener); String currValue= (String)fWorkingValues.get(key); checkBox.setSelection(data.getSelection(currValue) == 0); fCheckBoxes.add(checkBox); } private void addComboBox(Composite parent, String label, String key, String[] values, String[] valueLabels, int indent) { ControlData data= new ControlData(key, values); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indent; Label labelControl= new Label(parent, SWT.LEFT | SWT.WRAP); labelControl.setText(label); labelControl.setLayoutData(gd); Combo comboBox= new Combo(parent, SWT.READ_ONLY); comboBox.setItems(valueLabels); comboBox.setData(data); comboBox.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_FILL)); comboBox.addSelectionListener(fSelectionListener); String currValue= (String)fWorkingValues.get(key); comboBox.select(data.getSelection(currValue)); fComboBoxes.add(comboBox); } private Text addTextField(Composite parent, String label, String key) { Label labelControl= new Label(parent, SWT.NONE); labelControl.setText(label); labelControl.setLayoutData(new GridData()); Text textBox= new Text(parent, SWT.BORDER | SWT.SINGLE | SWT.RIGHT); textBox.setData(key); textBox.setLayoutData(new GridData()); String currValue= (String) fWorkingValues.get(key); textBox.setText(currValue); textBox.setTextLimit(6); textBox.addModifyListener(fTextModifyListener); GridData gd= new GridData(); gd.widthHint= convertWidthInCharsToPixels(8); textBox.setLayoutData(gd); fTextBoxes.add(textBox); return textBox; } private void controlChanged(Widget widget) { ControlData data= (ControlData) widget.getData(); String newValue= null; if (widget instanceof Button) { newValue= data.getValue(((Button)widget).getSelection()); } else if (widget instanceof Combo) { newValue= data.getValue(((Combo)widget).getSelectionIndex()); } else { return; } fWorkingValues.put(data.getKey(), newValue); validateSettings(data.getKey(), newValue); } private void textChanged(Text textControl) { String key= (String) textControl.getData(); String number= textControl.getText(); fWorkingValues.put(key, number); validateSettings(key, number); } private boolean checkValue(String key, String value) { return value.equals(fWorkingValues.get(key)); } /* (non-javadoc) * Update fields and validate. * @param changedKey Key that changed, or null, if all changed. */ private void validateSettings(String changedKey, String newValue) { if (changedKey != null) { if (INTR_DEFAULT_COMPLIANCE.equals(changedKey)) { updateComplianceEnableState(); if (DEFAULT.equals(newValue)) { updateComplianceDefaultSettings(); } } else if (PREF_COMPLIANCE.equals(changedKey)) { if (checkValue(INTR_DEFAULT_COMPLIANCE, DEFAULT)) { updateComplianceDefaultSettings(); } } else if (!PREF_SOURCE_COMPATIBILITY.equals(changedKey) && !PREF_CODEGEN_TARGET_PLATFORM.equals(changedKey) && !PREF_PB_ASSERT_AS_IDENTIFIER.equals(changedKey) && !PREF_PB_MAX_PER_UNIT.equals(changedKey)) { return; } } else { updateComplianceEnableState(); } updateStatus(getValidation()); } private IStatus getValidation() { StatusInfo status= new StatusInfo(); if (checkValue(PREF_COMPLIANCE, VERSION_1_3)) { if (checkValue(PREF_SOURCE_COMPATIBILITY, VERSION_1_4)) { status.setError(JavaUIMessages.getString("CompilerPreferencePage.cpl13src14.error")); //$NON-NLS-1$ return status; } else if (checkValue(PREF_CODEGEN_TARGET_PLATFORM, VERSION_1_4)) { status.setError(JavaUIMessages.getString("CompilerPreferencePage.cpl13trg14.error")); //$NON-NLS-1$ return status; } } if (checkValue(PREF_SOURCE_COMPATIBILITY, VERSION_1_4)) { if (!checkValue(PREF_PB_ASSERT_AS_IDENTIFIER, ERROR)) { status.setError(JavaUIMessages.getString("CompilerPreferencePage.src14asrterr.error")); //$NON-NLS-1$ return status; } } if (checkValue(PREF_SOURCE_COMPATIBILITY, VERSION_1_4)) { if (!checkValue(PREF_CODEGEN_TARGET_PLATFORM, VERSION_1_4)) { status.setError(JavaUIMessages.getString("CompilerPreferencePage.src14tgt14.error")); //$NON-NLS-1$ return status; } } String maxNumberProblems= (String) fWorkingValues.get(PREF_PB_MAX_PER_UNIT); return validatePositiveNumber(maxNumberProblems); } private IStatus validatePositiveNumber(String number) { StatusInfo status= new StatusInfo(); if (number.length() == 0) { status.setError(JavaUIMessages.getString("CompilerPreferencePage.empty_input")); //$NON-NLS-1$ } else { try { int value= Integer.parseInt(number); if (value <= 0) { status.setError(JavaUIMessages.getFormattedString("CompilerPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } catch (NumberFormatException e) { status.setError(JavaUIMessages.getFormattedString("CompilerPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } return status; } /* * Update the compliance controls' enable state */ private void updateComplianceEnableState() { boolean enabled= checkValue(INTR_DEFAULT_COMPLIANCE, USER); for (int i= fComplianceControls.size() - 1; i >= 0; i--) { Control curr= (Control) fComplianceControls.get(i); curr.setEnabled(enabled); } } /* * Set the default compliance values derived from the chosen level */ private void updateComplianceDefaultSettings() { Object complianceLevel= fWorkingValues.get(PREF_COMPLIANCE); if (VERSION_1_3.equals(complianceLevel)) { fWorkingValues.put(PREF_PB_ASSERT_AS_IDENTIFIER, IGNORE); fWorkingValues.put(PREF_SOURCE_COMPATIBILITY, VERSION_1_3); fWorkingValues.put(PREF_CODEGEN_TARGET_PLATFORM, VERSION_1_1); } else if (VERSION_1_4.equals(complianceLevel)) { fWorkingValues.put(PREF_PB_ASSERT_AS_IDENTIFIER, ERROR); fWorkingValues.put(PREF_SOURCE_COMPATIBILITY, VERSION_1_4); fWorkingValues.put(PREF_CODEGEN_TARGET_PLATFORM, VERSION_1_4); } updateControls(); } /* * Evaluate if the current compliance setting correspond to a default setting */ private String getCurrentCompliance() { Object complianceLevel= fWorkingValues.get(PREF_COMPLIANCE); if ((VERSION_1_3.equals(complianceLevel) && checkValue(PREF_PB_ASSERT_AS_IDENTIFIER, IGNORE) && checkValue(PREF_SOURCE_COMPATIBILITY, VERSION_1_3) && checkValue(PREF_CODEGEN_TARGET_PLATFORM, VERSION_1_1)) || (VERSION_1_4.equals(complianceLevel) && checkValue(PREF_PB_ASSERT_AS_IDENTIFIER, ERROR) && checkValue(PREF_SOURCE_COMPATIBILITY, VERSION_1_4) && checkValue(PREF_CODEGEN_TARGET_PLATFORM, VERSION_1_4))) { return DEFAULT; } return USER; } /* * @see IPreferencePage#performOk() */ public boolean performOk() { String[] allKeys= getAllKeys(); // preserve other options // store in JCore and the preferences Hashtable actualOptions= JavaCore.getOptions(); boolean hasChanges= false; for (int i= 0; i < allKeys.length; i++) { String key= allKeys[i]; String val= (String) fWorkingValues.get(key); String oldVal= (String) actualOptions.get(key); hasChanges= hasChanges | !val.equals(oldVal); actualOptions.put(key, val); } if (hasChanges) { String title= JavaUIMessages.getString("CompilerPreferencePage.needsbuild.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("CompilerPreferencePage.needsbuild.message"); //$NON-NLS-1$ MessageDialog dialog= new MessageDialog(getShell(), title, null, message, MessageDialog.QUESTION, new String[] { IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }, 2); int res= dialog.open(); if (res != 0 && res != 1) { JavaPlugin.getDefault().savePluginPreferences(); return false; } JavaCore.setOptions(actualOptions); if (res == 0) { doFullBuild(); } } JavaPlugin.getDefault().savePluginPreferences(); return super.performOk(); } public static boolean openQuestion(Shell parent, String title, String message) { MessageDialog dialog= new MessageDialog(parent, title, null, message, MessageDialog.QUESTION, new String[] { IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }, 2); return dialog.open() == 0; } private void doFullBuild() { ProgressMonitorDialog dialog= new ProgressMonitorDialog(getShell()); try { dialog.run(true, true, new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException { try { JavaPlugin.getWorkspace().build(IncrementalProjectBuilder.FULL_BUILD, monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }); } catch (InterruptedException e) { // cancelled by user } catch (InvocationTargetException e) { String title= JavaUIMessages.getString("CompilerPreferencePage.builderror.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("CompilerPreferencePage.builderror.message"); //$NON-NLS-1$ ExceptionHandler.handle(e, getShell(), title, message); } } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fWorkingValues= JavaCore.getDefaultOptions(); fWorkingValues.put(INTR_DEFAULT_COMPLIANCE, getCurrentCompliance()); updateControls(); validateSettings(null, null); super.performDefaults(); } private void updateControls() { // update the UI for (int i= fCheckBoxes.size() - 1; i >= 0; i--) { Button curr= (Button) fCheckBoxes.get(i); ControlData data= (ControlData) curr.getData(); String currValue= (String) fWorkingValues.get(data.getKey()); curr.setSelection(data.getSelection(currValue) == 0); } for (int i= fComboBoxes.size() - 1; i >= 0; i--) { Combo curr= (Combo) fComboBoxes.get(i); ControlData data= (ControlData) curr.getData(); String currValue= (String) fWorkingValues.get(data.getKey()); curr.select(data.getSelection(currValue)); } for (int i= fTextBoxes.size() - 1; i >= 0; i--) { Text curr= (Text) fTextBoxes.get(i); String key= (String) curr.getData(); String currValue= (String) fWorkingValues.get(key); curr.setText(currValue); } } private void updateStatus(IStatus status) { setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } }
16,843
Bug 16843 Not present exception closing java editor that is outside classpath
Build 20020521 1. Create java project 'Proj' with source folder 'src' 2. Create folder 'p' directly under 'Proj' (i.e. outside build path) 3. Create file 'X.java' under 'Proj/p' 4. Open X.java in java editor 5. Close it Observe: You get the following message printed to the log: !ENTRY org.eclipse.jdt.ui 4 1 May 22, 2002 17:14:39.936 !MESSAGE Child not present !SUBENTRY 1 org.eclipse.jdt.core 4 969 May 22, 2002 17:14:39.936 !MESSAGE p does not exist.
verified fixed
2ae271f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T08:29:08Z
2002-05-22T15:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/JavaBrowsingContentProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IResource; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.jface.viewers.AbstractTreeViewer; import org.eclipse.jface.viewers.IBasicPropertyConstants; import org.eclipse.jface.viewers.ListViewer; import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.jface.viewers.TableViewer; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jdt.core.ElementChangedEvent; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IElementChangedListener; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaElementDelta; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageDeclaration; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.IParent; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.StandardJavaElementContentProvider; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; class JavaBrowsingContentProvider extends StandardJavaElementContentProvider implements IElementChangedListener { private StructuredViewer fViewer; private Object fInput; private JavaBrowsingPart fBrowsingPart; public JavaBrowsingContentProvider(boolean provideMembers, JavaBrowsingPart browsingPart) { super(provideMembers, reconcileJavaViews()); fBrowsingPart= browsingPart; fViewer= fBrowsingPart.getViewer(); JavaCore.addElementChangedListener(this); } private static boolean reconcileJavaViews() { return JavaBasePreferencePage.reconcileJavaViews(); } public Object[] getChildren(Object element) { if (!exists(element)) return NO_CHILDREN; try { if (element instanceof Collection) { Collection elements= (Collection)element; if (elements.isEmpty()) return NO_CHILDREN; Object[] result= new Object[0]; Iterator iter= ((Collection)element).iterator(); while (iter.hasNext()) { Object[] children= getChildren(iter.next()); if (children != NO_CHILDREN) result= concatenate(result, children); } return result; } if (element instanceof IPackageFragment) return getPackageContents((IPackageFragment)element); if (fProvideMembers && element instanceof IType) return getChildren((IType)element); if (fProvideMembers && element instanceof ISourceReference && element instanceof IParent) return removeImportAndPackageDeclarations(super.getChildren(element)); if (element instanceof IJavaProject) return getPackageFragmentRoots((IJavaProject)element); return super.getChildren(element); } catch (JavaModelException e) { return NO_CHILDREN; } } private Object[] getPackageContents(IPackageFragment fragment) throws JavaModelException { ISourceReference[] sourceRefs; if (fragment.getKind() == IPackageFragmentRoot.K_SOURCE) { sourceRefs= fragment.getCompilationUnits(); if (getProvideWorkingCopy()) { for (int i= 0; i < sourceRefs.length; i++) { IWorkingCopy wc= EditorUtility.getWorkingCopy((ICompilationUnit)sourceRefs[i]); if (wc != null) sourceRefs[i]= (ICompilationUnit)wc; } } } else { IClassFile[] classFiles= fragment.getClassFiles(); List topLevelClassFile= new ArrayList(); for (int i= 0; i < classFiles.length; i++) { IType type= classFiles[i].getType(); if (type != null && type.getDeclaringType() == null) topLevelClassFile.add(classFiles[i]); } sourceRefs= (ISourceReference[])topLevelClassFile.toArray(new ISourceReference[topLevelClassFile.size()]); } Object[] result= new Object[0]; for (int i= 0; i < sourceRefs.length; i++) result= concatenate(result, removeImportAndPackageDeclarations(getChildren(sourceRefs[i]))); return concatenate(result, fragment.getNonJavaResources()); } private Object[] removeImportAndPackageDeclarations(Object[] members) { ArrayList tempResult= new ArrayList(members.length); for (int i= 0; i < members.length; i++) if (!(members[i] instanceof IImportContainer) && !(members[i] instanceof IPackageDeclaration)) tempResult.add(members[i]); return tempResult.toArray(); } private Object[] getChildren(IType type) throws JavaModelException{ IParent parent; if (type.isBinary()) parent= type.getClassFile(); else { parent= type.getCompilationUnit(); if (getProvideWorkingCopy()) { IWorkingCopy wc= EditorUtility.getWorkingCopy((ICompilationUnit)parent); if (wc != null) { parent= (IParent)wc; IMember wcType= EditorUtility.getWorkingCopy(type); if (wcType != null) type= (IType)wcType; } } } if (type.getDeclaringType() != null) return type.getChildren(); // Add import declarations IJavaElement[] members= parent.getChildren(); ArrayList tempResult= new ArrayList(members.length); for (int i= 0; i < members.length; i++) if ((members[i] instanceof IImportContainer)) tempResult.add(members[i]); tempResult.addAll(Arrays.asList(type.getChildren())); return tempResult.toArray(); } private Object[] getPackageFragmentRoots(IJavaProject project) throws JavaModelException { if (!project.getProject().isOpen()) return NO_CHILDREN; IPackageFragmentRoot[] roots= project.getPackageFragmentRoots(); List list= new ArrayList(roots.length); // filter out package fragments that correspond to projects and // replace them with the package fragments directly for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot root= (IPackageFragmentRoot)roots[i]; if (!root.isExternal()) { Object[] children= root.getChildren(); for (int k= 0; k < children.length; k++) list.add(children[k]); } else if (hasChildren(root)) { list.add(root); } } return concatenate(list.toArray(), project.getNonJavaResources()); } // ---------------- Element change handling /* (non-Javadoc) * Method declared on IContentProvider. */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { super.inputChanged(viewer, oldInput, newInput); if (newInput instanceof Collection) { // Get a template object from the collection Collection col= (Collection)newInput; if (!col.isEmpty()) newInput= col.iterator().next(); else newInput= null; } fInput= newInput; } /* (non-Javadoc) * Method declared on IContentProvider. */ public void dispose() { super.dispose(); JavaCore.removeElementChangedListener(this); } /* (non-Javadoc) * Method declared on IElementChangedListener. */ public void elementChanged(final ElementChangedEvent event) { try { processDelta(event.getDelta()); } catch(JavaModelException e) { JavaPlugin.getDefault().log(e.getStatus()); //$NON-NLS-1$ } } /** * Processes a delta recursively. When more than two children are affected the * tree is fully refreshed starting at this node. The delta is processed in the * current thread but the viewer updates are posted to the UI thread. */ protected void processDelta(IJavaElementDelta delta) throws JavaModelException { int kind= delta.getKind(); int flags= delta.getFlags(); IJavaElement element= delta.getElement(); if (!getProvideWorkingCopy() && element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { return; } // handle open and closing of a solution or project if (((flags & IJavaElementDelta.F_CLOSED) != 0) || ((flags & IJavaElementDelta.F_OPENED) != 0)) { postRefresh(element); return; } if (kind == IJavaElementDelta.REMOVED) { Object parent= internalGetParent(element); if (fBrowsingPart.isValidElement(element)) { if (element instanceof IClassFile) { postRemove(((IClassFile)element).getType()); } else if (element instanceof ICompilationUnit && !((ICompilationUnit)element).isWorkingCopy()) { // if (!getProvideWorkingCopy()) postRefresh(null); } else if (element instanceof ICompilationUnit && ((ICompilationUnit)element).isWorkingCopy()) { if (getProvideWorkingCopy()) postRefresh(null); } else if (parent instanceof ICompilationUnit && getProvideWorkingCopy() && !((ICompilationUnit)parent).isWorkingCopy()) { if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { // working copy removed from system - refresh postRefresh(null); } } else if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy() && parent != null && parent.equals(fInput)) // closed editor - removing working copy postRefresh(null); else postRemove(element); } if (fBrowsingPart.isAncestorOf(element, fInput)) { if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { postAdjustInputAndSetSelection(((IWorkingCopy)element).getOriginal((IJavaElement)fInput)); } else postAdjustInputAndSetSelection(null); } return; } if (kind == IJavaElementDelta.ADDED && delta.getMovedFromElement() != null && element instanceof ICompilationUnit) return; if (kind == IJavaElementDelta.ADDED) { if (fBrowsingPart.isValidElement(element)) { Object parent= internalGetParent(element); if (element instanceof IClassFile) { postAdd(parent, ((IClassFile)element).getType()); } else if (element instanceof ICompilationUnit && !((ICompilationUnit)element).isWorkingCopy()) { // if (!getProvideWorkingCopy()) postAdd(parent, ((ICompilationUnit)element).getAllTypes()); } else if (parent instanceof ICompilationUnit && getProvideWorkingCopy() && !((ICompilationUnit)parent).isWorkingCopy()) { // do nothing } else if (element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { // new working copy comes to live postRefresh(null); } else postAdd(parent, element); } else if (fInput == null) { IJavaElement newInput= fBrowsingPart.findInputForJavaElement(element); if (newInput != null) postAdjustInputAndSetSelection(element); } else if (element instanceof IType && fBrowsingPart.isValidInput(element)) { IJavaElement cu1= element.getAncestor(IJavaElement.COMPILATION_UNIT); IJavaElement cu2= ((IJavaElement)fInput).getAncestor(IJavaElement.COMPILATION_UNIT); if (cu1 != null && cu2 != null && cu1.equals(cu2)) postAdjustInputAndSetSelection(element); } return; } if (kind == IJavaElementDelta.CHANGED) { if (fBrowsingPart.isValidElement(element)) { postRefresh(element); } } if (isClassPathChange(delta)) // throw the towel and do a full refresh postRefresh(null); IJavaElementDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren.length > 1) { // a package fragment might become non empty refresh from the parent if (element instanceof IPackageFragment) { IJavaElement parent= (IJavaElement)internalGetParent(element); // avoid posting a refresh to an unvisible parent if (element.equals(fInput)) { postRefresh(element); } else { postRefresh(parent); } } // more than one child changed, refresh from here downwards if (element instanceof IPackageFragmentRoot && fBrowsingPart.isValidElement(element)) { postRefresh(skipProjectPackageFragmentRoot((IPackageFragmentRoot)element)); return; } } for (int i= 0; i < affectedChildren.length; i++) { processDelta(affectedChildren[i]); } } /** * Updates the package icon */ private void updatePackageIcon(final IJavaElement element) { postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.update(element, new String[]{IBasicPropertyConstants.P_IMAGE}); } }); } private void postRefresh(final Object root) { postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.refresh(root); } }); } private void postAdd(final Object parent, final Object element) { postAdd(parent, new Object[] {element}); } private void postAdd(final Object parent, final Object[] elements) { if (elements.length <= 0) return; postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.setRedraw(false); if (fViewer instanceof AbstractTreeViewer) { if (fViewer.testFindItem(parent) == null) { Object root= ((AbstractTreeViewer)fViewer).getInput(); if (root != null) ((AbstractTreeViewer)fViewer).add(root, elements); } else ((AbstractTreeViewer)fViewer).add(parent, elements); } else if (fViewer instanceof ListViewer) ((ListViewer)fViewer).add(elements); else if (fViewer instanceof TableViewer) ((TableViewer)fViewer).add(elements); if (fViewer.testFindItem(elements[0]) != null) fBrowsingPart.adjustInputAndSetSelection((IJavaElement)elements[0]); ctrl.setRedraw(true); } } }); } private void postRemove(final Object element) { postRemove(new Object[] {element}); } private void postRemove(final Object[] elements) { if (elements.length <= 0) return; postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.setRedraw(false); if (fViewer instanceof AbstractTreeViewer) ((AbstractTreeViewer)fViewer).remove(elements); else if (fViewer instanceof ListViewer) ((ListViewer)fViewer).remove(elements); else if (fViewer instanceof TableViewer) ((TableViewer)fViewer).remove(elements); ctrl.setRedraw(true); } } }); } private void postAdjustInputAndSetSelection(final Object element) { postRunnable(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.setRedraw(false); fBrowsingPart.adjustInputAndSetSelection((IJavaElement)element); ctrl.setRedraw(true); } } }); } private void postRunnable(final Runnable r) { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { fBrowsingPart.setProcessSelectionEvents(false); try { Display currentDisplay= ctrl.getDisplay().getCurrent(); if (currentDisplay != null && currentDisplay.equals(ctrl.getDisplay())) ctrl.getDisplay().syncExec(r); else ctrl.getDisplay().asyncExec(r); } finally { fBrowsingPart.setProcessSelectionEvents(true); } } } /** * Returns the parent for the element. * <p> * Note: This method will return a working copy if the * parent is a working copy. The super class implementation * returns the original element instead. * </p> */ protected Object internalGetParent(Object element) { if (element instanceof IJavaProject) { return ((IJavaProject)element).getJavaModel(); } // try to map resources to the containing package fragment if (element instanceof IResource) { IResource parent= ((IResource)element).getParent(); Object jParent= JavaCore.create(parent); if (jParent != null) return jParent; return parent; } // for package fragments that are contained in a project package fragment // we have to skip the package fragment root as the parent. if (element instanceof IPackageFragment) { IPackageFragmentRoot parent= (IPackageFragmentRoot)((IPackageFragment)element).getParent(); return skipProjectPackageFragmentRoot(parent); } if (element instanceof IJavaElement) return ((IJavaElement)element).getParent(); return null; } }
16,843
Bug 16843 Not present exception closing java editor that is outside classpath
Build 20020521 1. Create java project 'Proj' with source folder 'src' 2. Create folder 'p' directly under 'Proj' (i.e. outside build path) 3. Create file 'X.java' under 'Proj/p' 4. Open X.java in java editor 5. Close it Observe: You get the following message printed to the log: !ENTRY org.eclipse.jdt.ui 4 1 May 22, 2002 17:14:39.936 !MESSAGE Child not present !SUBENTRY 1 org.eclipse.jdt.core 4 969 May 22, 2002 17:14:39.936 !MESSAGE p does not exist.
verified fixed
2ae271f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T08:29:08Z
2002-05-22T15:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaElementContentProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.ui; import org.eclipse.core.resources.*; import org.eclipse.jdt.core.*; import org.eclipse.jdt.internal.ui.*; import org.eclipse.jdt.internal.ui.viewsupport.*; import org.eclipse.jface.viewers.*; import org.eclipse.swt.widgets.*; /** * A tree content provider for Java elements. It extends the * StandardJavaElementContentProvider with support for listening to changes. * It is recommended to implement a custom listening support * and to derive from the StandardJavaElementContentProvider directly. * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * @see StandardJavaElementContentProvider */ public class JavaElementContentProvider extends StandardJavaElementContentProvider implements ITreeContentProvider, IElementChangedListener { protected TreeViewer fViewer; protected Object fInput; /* (non-Javadoc) * Method declared on IContentProvider. */ public void dispose() { super.dispose(); JavaCore.removeElementChangedListener(this); } /* (non-Javadoc) * Method declared on IContentProvider. */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { super.inputChanged(viewer, oldInput, newInput); fViewer= (TreeViewer)viewer; if (oldInput == null && newInput != null) { JavaCore.addElementChangedListener(this); } else if (oldInput != null && newInput == null) { JavaCore.removeElementChangedListener(this); } fInput= newInput; } /** * Creates a new content provider for Java elements. */ public JavaElementContentProvider() { } /** * Creates a new content provider for Java elements. */ public JavaElementContentProvider(boolean provideMembers, boolean provideWorkingCopy) { super(provideMembers, provideWorkingCopy); } /* (non-Javadoc) * Method declared on IElementChangedListener. */ public void elementChanged(final ElementChangedEvent event) { try { processDelta(event.getDelta()); } catch(JavaModelException e) { JavaPlugin.getDefault().logErrorStatus(JavaUIMessages.getString("JavaElementContentProvider.errorMessage"), e.getStatus()); //$NON-NLS-1$ } } /** * Processes a delta recursively. When more than two children are affected the * tree is fully refreshed starting at this node. The delta is processed in the * current thread but the viewer updates are posted to the UI thread. */ protected void processDelta(IJavaElementDelta delta) throws JavaModelException { int kind= delta.getKind(); int flags= delta.getFlags(); IJavaElement element= delta.getElement(); if (!getProvideWorkingCopy() && element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) { return; } // handle open and closing of a solution or project if (((flags & IJavaElementDelta.F_CLOSED) != 0) || ((flags & IJavaElementDelta.F_OPENED) != 0)) { postRefresh(element); return; } if (kind == IJavaElementDelta.REMOVED) { Object parent= internalGetParent(element); postRemove(element); if (parent instanceof IPackageFragment) updatePackageIcon((IPackageFragment)parent); // we are filtering out empty subpackages, so we // a package becomes empty we remove it from the viewer. if (isPackageFragmentEmpty(element.getParent())) { if (fViewer.testFindItem(parent) != null) postRefresh(internalGetParent(parent)); } return; } if (kind == IJavaElementDelta.ADDED) { Object parent= internalGetParent(element); // we are filtering out empty subpackages, so we // have to handle additions to them specially. if (parent instanceof IPackageFragment) { Object grandparent= internalGetParent(parent); // 1GE8SI6: ITPJUI:WIN98 - Rename is not shown in Packages View // avoid posting a refresh to an unvisible parent if (parent.equals(fInput)) { postRefresh(parent); } else { // refresh from grandparent if parent isn't visible yet if (fViewer.testFindItem(parent) == null) postRefresh(grandparent); else { postRefresh(parent); } } } else { postAdd(parent, element); } } if (element instanceof ICompilationUnit) { if (getProvideWorkingCopy()) { IJavaElement original= ((IWorkingCopy)element).getOriginalElement(); if (original != null) element= original; } if (kind == IJavaElementDelta.CHANGED) { postRefresh(element); return; } } // we don't show the contents of a compilation or IClassFile, so don't go any deeper if ((element instanceof ICompilationUnit) || (element instanceof IClassFile)) return; if (isClassPathChange(delta)) { // throw the towel and do a full refresh of the affected java project. postRefresh(element.getJavaProject()); } if (delta.getResourceDeltas() != null) { IResourceDelta[] rd= delta.getResourceDeltas(); for (int i= 0; i < rd.length; i++) { processResourceDelta(rd[i], element); } } IJavaElementDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren.length > 1) { // a package fragment might become non empty refresh from the parent if (element instanceof IPackageFragment) { IJavaElement parent= (IJavaElement)internalGetParent(element); // 1GE8SI6: ITPJUI:WIN98 - Rename is not shown in Packages View // avoid posting a refresh to an unvisible parent if (element.equals(fInput)) { postRefresh(element); } else { postRefresh(parent); } return; } // more than one child changed, refresh from here downwards if (element instanceof IPackageFragmentRoot) postRefresh(skipProjectPackageFragmentRoot((IPackageFragmentRoot)element)); else postRefresh(element); return; } for (int i= 0; i < affectedChildren.length; i++) { processDelta(affectedChildren[i]); } } /** * Updates the package icon */ private void updatePackageIcon(final IJavaElement element) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.update(element, new String[]{IBasicPropertyConstants.P_IMAGE}); } }); } /** * Process resource deltas */ private void processResourceDelta(IResourceDelta delta, Object parent) { int status= delta.getKind(); IResource resource= delta.getResource(); // filter out changes affecting the output folder if (resource == null) return; // this could be optimized by handling all the added children in the parent if ((status & IResourceDelta.REMOVED) != 0) { if (parent instanceof IPackageFragment) // refresh one level above to deal with empty package filtering properly postRefresh(internalGetParent(parent)); else postRemove(resource); } if ((status & IResourceDelta.ADDED) != 0) { if (parent instanceof IPackageFragment) // refresh one level above to deal with empty package filtering properly postRefresh(internalGetParent(parent)); else postAdd(parent, resource); } IResourceDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren.length > 1) { // more than one child changed, refresh from here downwards postRefresh(resource); return; } for (int i= 0; i < affectedChildren.length; i++) processResourceDelta(affectedChildren[i], resource); } private void postRefresh(final Object root) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.refresh(root); } }); } private void postAdd(final Object parent, final Object element) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.add(parent, element); } }); } private void postRemove(final Object element) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.remove(element); } }); } private void postRunnable(final Runnable r) { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.getDisplay().asyncExec(r); } } }
18,028
Bug 18028 Rename package doesn't check if all resources are writeable
F1+ - create a package with a CU in it - make the CU read-only - try to rename the package. observe: after finish you get an unexpected exception dialog. Precondition checking should check for read only files inside packages.
verified fixed
629bde3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T09:51:47Z
2002-05-28T12:46:40Z
org.eclipse.jdt.ui/core
18,028
Bug 18028 Rename package doesn't check if all resources are writeable
F1+ - create a package with a CU in it - make the CU read-only - try to rename the package. observe: after finish you get an unexpected exception dialog. Precondition checking should check for read only files inside packages.
verified fixed
629bde3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T09:51:47Z
2002-05-28T12:46:40Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RenamePackageRefactoring.java
17,308
Bug 17308 Misleading checkbox in Self Encapsulate field wizard
The following checkbox was misleading to me: [ ] Encapsulate field accesses in declaring class If I check does it mean: a) ONLY the declaring class will be processed? b) the delcaring class will ALSO be processed together with all sub-classes? From experience I learned that b) is the right answer.
verified fixed
9ae9a3c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T09:54:41Z
2002-05-23T13:20:00Z
org.eclipse.jdt.ui/ui
17,308
Bug 17308 Misleading checkbox in Self Encapsulate field wizard
The following checkbox was misleading to me: [ ] Encapsulate field accesses in declaring class If I check does it mean: a) ONLY the declaring class will be processed? b) the delcaring class will ALSO be processed together with all sub-classes? From experience I learned that b) is the right answer.
verified fixed
9ae9a3c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T09:54:41Z
2002-05-23T13:20:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/sef/SelfEncapsulateFieldInputPage.java
16,316
Bug 16316 no indication of filters
now that we have many filters and i could filter out stuff like java files there should be an indication that a filter is applied to a view.
verified fixed
b107e80
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T10:48:21Z
2002-05-17T21:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/CustomFiltersActionGroup.java
17,703
Bug 17703 Edit-Add Task action should use Workbench dialog as Java Editor does
F1 - select CU in packages view - execute File->Add Task observe: you get a different dialog than executing the action from the Java editors ruler context menu
verified fixed
05a77e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T12:29:17Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/AddTaskAction.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.internal.ui.actions; import java.util.HashMap; import java.util.Map; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.InputDialog; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.texteditor.MarkerUtilities; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.ui.actions.SelectionDispatchAction; public class AddTaskAction extends SelectionDispatchAction { public AddTaskAction(IWorkbenchSite site) { super(site); setEnabled(false); } protected void selectionChanged(IStructuredSelection selection) { setEnabled(getElement(selection) != null); } protected void run(IStructuredSelection selection) { IResource resource= getElement(selection); if (resource == null) return; InputDialog dialog= new InputDialog(getShell(), getDialogTitle(), ActionMessages.getString("AddTaskAction.inputDialog.message"), "", null); //$NON-NLS-1$ //$NON-NLS-2$ if (dialog.open() == IDialogConstants.CANCEL_ID) return; String message= dialog.getValue().trim(); Map attributes= new HashMap(2); MarkerUtilities.setMessage(attributes, message); try { MarkerUtilities.createMarker(resource, attributes, IMarker.TASK); } catch (CoreException e) { ExceptionHandler.handle(e, getShell(), getDialogTitle(), ActionMessages.getString("AddTaskAction.error.create_failed")); //$NON-NLS-1$ } } private IResource getElement(IStructuredSelection selection) { if (selection.size() != 1) return null; Object element= selection.getFirstElement(); if (!(element instanceof IAdaptable)) return null; return (IResource)((IAdaptable)element).getAdapter(IResource.class); } private String getDialogTitle() { return ActionMessages.getString("AddTaskAction.dialog.title"); //$NON-NLS-1$ } }
12,523
Bug 12523 Paste in Packages does not accept files on the clipboard
I created a FileTransfer in another view that contains file paths and placed it on the clipboard using SWT DND Clipboard object. Resource navigator recognized this and allowed me to paste the files into the project, but Packages 'Paste' didn't.
verified fixed
1bc4d43
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T13:04:06Z
2002-03-31T18:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/PasteResourcesFromClipboardAction.java
package org.eclipse.jdt.internal.ui.reorg; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.swt.dnd.Clipboard; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.actions.CopyProjectAction; import org.eclipse.ui.part.ResourceTransfer; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.actions.SelectionDispatchAction; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.reorg.CopyRefactoring; public class PasteResourcesFromClipboardAction extends SelectionDispatchAction { private Clipboard fClipboard; protected PasteResourcesFromClipboardAction(IWorkbenchSite site, Clipboard clipboard) { super(site); Assert.isNotNull(clipboard); fClipboard= clipboard; } protected void selectionChanged(IStructuredSelection selection) { setEnabled(canOperateOn(selection)); } public void run(IStructuredSelection selection) { IResource[] resourceData = getClipboardResources(); if (resourceData == null || resourceData.length == 0) return; pasteResources(selection, resourceData); } private void pasteResources(IStructuredSelection selection, IResource[] resourceData) { if (resourceData[0].getType() == IResource.PROJECT) pasteProject((IProject) resourceData[0]); else ReorgActionFactory.createDnDCopyAction(resourceData, getFirstSelectedResource(selection)).run(); } private void pasteProject(IProject project){ CopyProjectAction cpa= new CopyProjectAction(getShell()); cpa.selectionChanged(new StructuredSelection(project)); if (! cpa.isEnabled()) return; cpa.run(); } //- enablement --- private boolean canOperateOn(IStructuredSelection selection){ IResource[] resourceData= getClipboardResources(); if (resourceData == null || resourceData.length == 0) return false; if (ClipboardActionUtil.isOneOpenProject(resourceData)) return true; if (selection.size() != 1) //only after we checked the 'one project' case return false; /* * special case: if both source references and resources are in clipboard - disable this action * if a compilation unit is selected. * this is important in the case when a type is copied to the clipboard - we put also its compilation unit */ TypedSource[] typedSource= getClipboardSourceReference(); if (selection.getFirstElement() instanceof ICompilationUnit && typedSource != null && typedSource.length != 0) return false; if (StructuredSelectionUtil.getResources(selection).length != 1) return false; if (resourceData == null) return ClipboardActionUtil.getFirstResource(selection) instanceof IContainer; return canActivateCopyRefactoring(resourceData, ClipboardActionUtil.getFirstResource(selection)); } private static boolean canActivateCopyRefactoring(IResource[] resourceData, IResource selectedResource) { try{ CopyRefactoring ref= createCopyRefactoring(resourceData); if (! ref.checkActivation(new NullProgressMonitor()).isOK()) return false; return ref.isValidDestination(ClipboardActionUtil.tryConvertingToJava(selectedResource)); } catch (JavaModelException e){ return false; } } //-- helpers private IResource getFirstSelectedResource(IStructuredSelection selection){ return ClipboardActionUtil.getFirstResource(selection); } private IResource[] getClipboardResources() { return ((IResource[])fClipboard.getContents(ResourceTransfer.getInstance())); } private TypedSource[] getClipboardSourceReference() { return ((TypedSource[])fClipboard.getContents(TypedSourceTransfer.getInstance())); } private static CopyRefactoring createCopyRefactoring(IResource[] resourceData) { return new CopyRefactoring(ClipboardActionUtil.getConvertedResources(resourceData), new CopyQueries()); } }
17,922
Bug 17922 ClassCastException on rename temp
should try to reproduce and isolate a test case java.lang.reflect.InvocationTargetException: java.lang.ClassCastException: org.eclipse.jdt.internal.compiler.lookup.ArrayBinding at org.eclipse.jdt.core.dom.DefaultBindingResolver.returnBindingForQualifiedNamePar t(DefaultBindingResolver.java:738) at org.eclipse.jdt.core.dom.DefaultBindingResolver.internalResolveNameForSimpleName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.core.dom.DefaultBindingResolver.resolveName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visit(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleName.accept0(SimpleName.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.QualifiedName.accept0(QualifiedName.java:88) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleType.accept0(SimpleType.java:73) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ArrayType.accept0(ArrayType.java:76) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.FieldDeclaration.accept0 (FieldDeclaration.java:119) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.TypeDeclaration.accept0 (TypeDeclaration.java:160) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.CompilationUnit.accept0 (CompilationUnit.java:145) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder.findTemp OccurrenceOffsets(TempOccurrenceFinder.java:27) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.getAllR enameEdits(RenameTempRefactoring.java:201) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.analyze AST(RenameTempRefactoring.java:176) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.checkIn put(RenameTempRefactoring.java:162) at org.eclipse.jdt.internal.ui.refactoring.CheckConditionsOperation.run (CheckConditionsOperation.java:58) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run (CreateChangeOperation.java:93) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run (ModalContext.java:98)
verified fixed
62fae36
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T13:47:56Z
2002-05-27T14:33:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/RenameTemp/canRename/A_test47_in.java
17,922
Bug 17922 ClassCastException on rename temp
should try to reproduce and isolate a test case java.lang.reflect.InvocationTargetException: java.lang.ClassCastException: org.eclipse.jdt.internal.compiler.lookup.ArrayBinding at org.eclipse.jdt.core.dom.DefaultBindingResolver.returnBindingForQualifiedNamePar t(DefaultBindingResolver.java:738) at org.eclipse.jdt.core.dom.DefaultBindingResolver.internalResolveNameForSimpleName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.core.dom.DefaultBindingResolver.resolveName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visit(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleName.accept0(SimpleName.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.QualifiedName.accept0(QualifiedName.java:88) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleType.accept0(SimpleType.java:73) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ArrayType.accept0(ArrayType.java:76) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.FieldDeclaration.accept0 (FieldDeclaration.java:119) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.TypeDeclaration.accept0 (TypeDeclaration.java:160) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.CompilationUnit.accept0 (CompilationUnit.java:145) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder.findTemp OccurrenceOffsets(TempOccurrenceFinder.java:27) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.getAllR enameEdits(RenameTempRefactoring.java:201) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.analyze AST(RenameTempRefactoring.java:176) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.checkIn put(RenameTempRefactoring.java:162) at org.eclipse.jdt.internal.ui.refactoring.CheckConditionsOperation.run (CheckConditionsOperation.java:58) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run (CreateChangeOperation.java:93) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run (ModalContext.java:98)
verified fixed
62fae36
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T13:47:56Z
2002-05-27T14:33:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/RenameTemp/canRename/A_test47_out.java
17,922
Bug 17922 ClassCastException on rename temp
should try to reproduce and isolate a test case java.lang.reflect.InvocationTargetException: java.lang.ClassCastException: org.eclipse.jdt.internal.compiler.lookup.ArrayBinding at org.eclipse.jdt.core.dom.DefaultBindingResolver.returnBindingForQualifiedNamePar t(DefaultBindingResolver.java:738) at org.eclipse.jdt.core.dom.DefaultBindingResolver.internalResolveNameForSimpleName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.core.dom.DefaultBindingResolver.resolveName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visit(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleName.accept0(SimpleName.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.QualifiedName.accept0(QualifiedName.java:88) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleType.accept0(SimpleType.java:73) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ArrayType.accept0(ArrayType.java:76) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.FieldDeclaration.accept0 (FieldDeclaration.java:119) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.TypeDeclaration.accept0 (TypeDeclaration.java:160) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.CompilationUnit.accept0 (CompilationUnit.java:145) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder.findTemp OccurrenceOffsets(TempOccurrenceFinder.java:27) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.getAllR enameEdits(RenameTempRefactoring.java:201) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.analyze AST(RenameTempRefactoring.java:176) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.checkIn put(RenameTempRefactoring.java:162) at org.eclipse.jdt.internal.ui.refactoring.CheckConditionsOperation.run (CheckConditionsOperation.java:58) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run (CreateChangeOperation.java:93) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run (ModalContext.java:98)
verified fixed
62fae36
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T13:47:56Z
2002-05-27T14:33:20Z
org.eclipse.jdt.ui.tests.refactoring/test
17,922
Bug 17922 ClassCastException on rename temp
should try to reproduce and isolate a test case java.lang.reflect.InvocationTargetException: java.lang.ClassCastException: org.eclipse.jdt.internal.compiler.lookup.ArrayBinding at org.eclipse.jdt.core.dom.DefaultBindingResolver.returnBindingForQualifiedNamePar t(DefaultBindingResolver.java:738) at org.eclipse.jdt.core.dom.DefaultBindingResolver.internalResolveNameForSimpleName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.core.dom.DefaultBindingResolver.resolveName (DefaultBindingResolver.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visitNameReference(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder$TempOccu rrenceAnalyzer.visit(TempOccurrenceFinder.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleName.accept0(SimpleName.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.QualifiedName.accept0(QualifiedName.java:88) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.SimpleType.accept0(SimpleType.java:73) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ArrayType.accept0(ArrayType.java:76) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.FieldDeclaration.accept0 (FieldDeclaration.java:119) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.TypeDeclaration.accept0 (TypeDeclaration.java:160) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java (Compiled Code)) at org.eclipse.jdt.core.dom.CompilationUnit.accept0 (CompilationUnit.java:145) at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.rename.TempOccurrenceFinder.findTemp OccurrenceOffsets(TempOccurrenceFinder.java:27) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.getAllR enameEdits(RenameTempRefactoring.java:201) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.analyze AST(RenameTempRefactoring.java:176) at org.eclipse.jdt.internal.corext.refactoring.rename.RenameTempRefactoring.checkIn put(RenameTempRefactoring.java:162) at org.eclipse.jdt.internal.ui.refactoring.CheckConditionsOperation.run (CheckConditionsOperation.java:58) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run (CreateChangeOperation.java:93) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run (ModalContext.java:98)
verified fixed
62fae36
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T13:47:56Z
2002-05-27T14:33:20Z
cases/org/eclipse/jdt/ui/tests/refactoring/RenameTempTests.java
15,829
Bug 15829 Encapsulate field should default generate after last method, not after first.
Great feature! It would be even better if by default the inserted methods were placed after the last method in the class (before the first would work, too, I guess) instead of after the first method. Especially when used twice in a row, after the first is an awkward choice.
verified fixed
09f8ffc
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T14:18:36Z
2002-05-12T19:00:00Z
org.eclipse.jdt.ui/ui
15,829
Bug 15829 Encapsulate field should default generate after last method, not after first.
Great feature! It would be even better if by default the inserted methods were placed after the last method in the class (before the first would work, too, I guess) instead of after the first method. Especially when used twice in a row, after the first is an awkward choice.
verified fixed
09f8ffc
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T14:18:36Z
2002-05-12T19:00:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/sef/SelfEncapsulateFieldInputPage.java
17,045
Bug 17045 Import/Export should always be on context menu of Packages view (or never)
Build 20020521 The Packages view does only include Import when a container is selected. It only includes Export when a container or file is selected. When the selection is empty, neither appear. The Navigator always includes Import/Export on the context menu. Filtering these action based on the selection makes too many assumptions about the kinds of available importers / exporters. For example, the importers for external projects and binary projects ignore the selection. Therefore, I currently cannot import binary projects via the packages view when my workspace is empty. Either these actions should always be included (and enabled), or always excluded.
verified fixed
7b82915
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T15:14:31Z
2002-05-22T20:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/ImportActionGroup.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.util.Iterator; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.ExportResourcesAction; import org.eclipse.ui.actions.ImportResourcesAction; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.ui.IContextMenuConstants; /** * Action group to add the Import and Export action to a view part's * context menu. * * @sine 2.0 */ public class ImportActionGroup extends ActionGroup { private static final String GROUP_IMPORT= "group.import"; //$NON-NLS-1$ private static final int FAILED= 1 << 0; private static final int IMPORT= 1 << 1; private static final int EXPORT= 1 << 2; private static final int IMPORT_EXPORT= IMPORT | EXPORT; private ImportResourcesAction fImportAction; private ExportResourcesAction fExportAction; /** * Creates a new <code>ImportActionGroup</code>. * * @param part the view part that owns this action group */ public ImportActionGroup(IViewPart part) { IWorkbench workbench = part.getSite().getWorkbenchWindow().getWorkbench(); fImportAction= new ImportResourcesAction(workbench); fExportAction= new ExportResourcesAction(workbench); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillContextMenu(IMenuManager menu) { IStructuredSelection selection= getStructuredSelection(); if (selection == null) return; int mode= checkSelection(selection); if ((mode & FAILED) == 0) { menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new Separator(GROUP_IMPORT)); if ((mode & IMPORT) != 0) menu.appendToGroup(GROUP_IMPORT, fImportAction); if ((mode & EXPORT) != 0) menu.appendToGroup(GROUP_IMPORT, fExportAction); } super.fillContextMenu(menu); } private void appendToGroup(IMenuManager menu, IAction action) { if (action.isEnabled()) menu.appendToGroup(GROUP_IMPORT, action); } private IStructuredSelection getStructuredSelection() { ISelection selection= getContext().getSelection(); if (selection instanceof IStructuredSelection) return (IStructuredSelection)selection; return null; } private int checkSelection(IStructuredSelection selection) { int result= 0; for (Iterator iter= selection.iterator(); iter.hasNext();) { Object element= (Object) iter.next(); if (element instanceof IJavaElement) { int type= ((IJavaElement)element).getElementType(); switch (type) { case IJavaElement.JAVA_PROJECT: case IJavaElement.PACKAGE_FRAGMENT_ROOT: case IJavaElement.PACKAGE_FRAGMENT: result= result | IMPORT_EXPORT; break; case IJavaElement.COMPILATION_UNIT: result= result | EXPORT; break; default: return FAILED; } } else if (element instanceof IContainer) { result= result | IMPORT_EXPORT; } else if (element instanceof IFile) { result= result | EXPORT; } else { return FAILED; } } return result; } }
17,168
Bug 17168 Packages view: Open in context menu for * imports
Test pass 1 - JUnit setup - open AboutDialog - select java.awt.event.* - open context menu observe: Open is in context menu, although it can't be applied.
verified fixed
3ffec79
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T15:28:22Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/OpenAction.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.util.Iterator; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.util.OpenStrategy; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IStorage; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Status; import org.eclipse.ui.IEditorActionBarContributor; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.PartInitException; import org.eclipse.ui.part.EditorActionBarContributor; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaStatusConstants; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.OpenActionUtil; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.packageview.PackagesMessages; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * This action opens a java editor on an element represented by either * <ul> * <li>a text selection inside a Java editor, or </li> * <li>a structured selection of a view part showing Java elements</li> * </ul> * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class OpenAction extends SelectionDispatchAction { private JavaEditor fEditor; /** * Creates a new <code>OpenAction</code>. * * @param site the site providing context information for this action */ public OpenAction(IWorkbenchSite site) { super(site); setText(ActionMessages.getString("OpenAction.label")); //$NON-NLS-1$ setToolTipText(ActionMessages.getString("OpenAction.tooltip")); //$NON-NLS-1$ setDescription(ActionMessages.getString("OpenAction.description")); //$NON-NLS-1$ } /** * Creates a new <code>OpenAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public OpenAction(JavaEditor editor) { this(editor.getEditorSite()); fEditor= editor; setText(ActionMessages.getString("OpenAction.declaration.label")); //$NON-NLS-1$ setEnabled(SelectionConverter.canOperateOn(fEditor)); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(ITextSelection selection) { } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(IStructuredSelection selection) { setEnabled(checkEnabled(selection)); } private boolean checkEnabled(IStructuredSelection selection) { if (selection.isEmpty()) return false; for (Iterator iter= selection.iterator(); iter.hasNext();) { Object element= (Object)iter.next(); if (element instanceof IImportDeclaration && !((IImportDeclaration)element).isOnDemand()) continue; if (element instanceof ISourceReference) continue; if (element instanceof IResource) continue; if (element instanceof IStorage) continue; return false; } return true; } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(ITextSelection selection) { try { IJavaElement element= SelectionConverter.codeResolve(fEditor, getShell(), getDialogTitle(), ActionMessages.getString("OpenAction.select_element")); //$NON-NLS-1$ if (element == null) { /* waiting for support a time out in status line to ensure that message disappears IStatusLineManager statusLine= getStatusLineManager(); if (statusLine != null) { statusLine.setErrorMessage("Current text selection doesn't resolve to Java element"); } */ getShell().getDisplay().beep(); return; } IJavaElement input= SelectionConverter.getInput(fEditor); int type= element.getElementType(); if (type == IJavaElement.JAVA_PROJECT || type == IJavaElement.PACKAGE_FRAGMENT_ROOT || type == IJavaElement.PACKAGE_FRAGMENT) element= input; run(new Object[] {element} ); } catch (JavaModelException e) { showError(e); } } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(IStructuredSelection selection) { if (!checkEnabled(selection)) return; run(selection.toArray()); } private void run(Object[] elements) { if (elements == null) return; for (int i= 0; i < elements.length; i++) { Object element= elements[i]; try { element= getElementToOpen(element); boolean activateOnOpen= fEditor != null ? true : OpenStrategy.activateOnOpen(); OpenActionUtil.open(element, activateOnOpen); } catch (JavaModelException e) { JavaPlugin.log(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, ActionMessages.getString("OpenAction.error.message"), e)); //$NON-NLS-1$ ErrorDialog.openError(getShell(), getDialogTitle(), ActionMessages.getString("OpenAction.error.messageProblems"), //$NON-NLS-1$ e.getStatus()); } catch (PartInitException x) { String name= null; if (element instanceof IJavaElement) { name= ((IJavaElement) element).getElementName(); } else if (element instanceof IStorage) { name= ((IStorage) element).getName(); } else if (element instanceof IResource) { name= ((IResource) element).getName(); } if (name != null) { MessageDialog.openError(getShell(), ActionMessages.getString("OpenAction.error.messageProblems"), //$NON-NLS-1$ ActionMessages.getFormattedString("OpenAction.error.messageArgs", //$NON-NLS-1$ new String[] { name, x.getMessage() } )); } } } } public Object getElementToOpen(Object object) throws JavaModelException { if (!(object instanceof IJavaElement)) return object; IJavaElement element= (IJavaElement)object; switch (element.getElementType()) { case IJavaElement.IMPORT_DECLARATION: // select referenced element: package fragment or cu/classfile of referenced type IImportDeclaration declaration= (IImportDeclaration) element; if (declaration.isOnDemand()) { element= JavaModelUtil.findTypeContainer(element.getJavaProject(), Signature.getQualifier(element.getElementName())); } else { element= element.getJavaProject().findType(element.getElementName()); } if (element instanceof IType) { element= (IJavaElement)element.getOpenable(); } break; } return element; } private String getDialogTitle() { return ActionMessages.getString("OpenAction.error.title"); //$NON-NLS-1$ } private void showError(CoreException e) { ExceptionHandler.handle(e, getShell(), getDialogTitle(), ActionMessages.getString("OpenAction.error.message")); //$NON-NLS-1$ } private IStatusLineManager getStatusLineManager() { IEditorActionBarContributor contributor= fEditor.getEditorSite().getActionBarContributor(); if (contributor instanceof EditorActionBarContributor) { return ((EditorActionBarContributor)contributor).getActionBars().getStatusLineManager(); } return null; } }
17,001
Bug 17001 JUnit preference page margins too wide
Build: 20020521 The left, right, top and bottom margins on the JUnit preference page are too wide. They are inconsistent with the other preference pages. Adding the following lines in JUnitPreferencePage.createContents(Composite) will fix this problem: layout.marginWidth = 0; layout.marginHeight = 0;
verified fixed
1dcea9f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:26:47Z
2002-05-22T17:53:20Z
org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/JUnitPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.junit.ui; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.preference.*; import org.eclipse.swt.SWT; import org.eclipse.swt.events.*; import org.eclipse.swt.layout.*; import org.eclipse.swt.widgets.*; import org.eclipse.ui.*; /** * Preference page for JUnit settings. Supports to define the failure * stack filter patterns. */ public class JUnitPreferencePage extends PreferencePage implements IWorkbenchPreferencePage, SelectionListener { private String fFilterString; private Table fTable; private Button fAddButton; private Button fRemoveButton; private Button fShowOnErrorCheck; public static String STACK_FILTER_ENTRIES_COUNT= "NOF_STACK_FILTER_ENTRIES"; //$NON-NLS-1$ public static String STACK_FILTER_ENTRY_= "STACK_FILTER_ENTRY_"; //$NON-NLS-1$ public static String DO_FILTER_STACK= "DO_FILTER_STACK"; //$NON-NLS-1$ public static String SHOW_ON_ERROR_ONLY= "SHOW_ON_ERROR"; //$NON-NLS-1$ private static String[] fgDefaultFilterPatterns= new String[] { "org.eclipse.jdt.internal.junit.runner", //$NON-NLS-1$ "org.eclipse.jdt.internal.junit.ui", //$NON-NLS-1$ "junit.framework.TestCase", //$NON-NLS-1$ "junit.framework.TestResult", //$NON-NLS-1$ "junit.framework.TestSuite", //$NON-NLS-1$ "junit.framework.Assert.", // don't filter AssertionFailure //$NON-NLS-1$ "java.lang.reflect.Method.invoke" //$NON-NLS-1$ }; public JUnitPreferencePage() { super(); setPreferenceStore(JUnitPlugin.getDefault().getPreferenceStore()); } public static String[] getFilterPatterns() { IPreferenceStore store= JUnitPlugin.getDefault().getPreferenceStore(); int count= store.getInt(STACK_FILTER_ENTRIES_COUNT); String[] result= new String[count]; for (int i= 0; i < count; i++) { result[i]= store.getString(STACK_FILTER_ENTRY_ + i); } return result; } public static boolean getFilterStack() { IPreferenceStore store= JUnitPlugin.getDefault().getPreferenceStore(); return store.getBoolean(DO_FILTER_STACK); } public static void setFilterStack(boolean filter) { IPreferenceStore store= JUnitPlugin.getDefault().getPreferenceStore(); store.setValue(DO_FILTER_STACK, filter); } public static void initializeDefaults(IPreferenceStore store) { store.setDefault(JUnitPreferencePage.DO_FILTER_STACK, true); store.setDefault(JUnitPreferencePage.SHOW_ON_ERROR_ONLY, false); int count= store.getInt(STACK_FILTER_ENTRIES_COUNT); if (count == 0) { store.setValue(STACK_FILTER_ENTRIES_COUNT, fgDefaultFilterPatterns.length); for (int i= 0; i < fgDefaultFilterPatterns.length; i++) { store.setValue(STACK_FILTER_ENTRY_ + i, fgDefaultFilterPatterns[i]); } } } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { noDefaultAndApplyButton(); Composite composite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; composite.setLayout(layout); GridData data= new GridData(); data.verticalAlignment= GridData.FILL; data.horizontalAlignment= GridData.FILL; composite.setLayoutData(data); createShowCheck(composite); createFilterTable(composite); createListButtons(composite); return composite; } private void createShowCheck(Composite composite) { GridData data; fShowOnErrorCheck= new Button(composite, SWT.CHECK); fShowOnErrorCheck.setText(JUnitMessages.getString("JUnitPreferencePage.showcheck.label")); //$NON-NLS-1$ data= new GridData(); data.horizontalAlignment= GridData.FILL; data.horizontalSpan= 2; fShowOnErrorCheck.setLayoutData(data); fShowOnErrorCheck.setSelection(getShowOnErrorOnly()); } /** * @return boolean */ public static boolean getShowOnErrorOnly() { IPreferenceStore store= JUnitPlugin.getDefault().getPreferenceStore(); return store.getBoolean(SHOW_ON_ERROR_ONLY); } protected void createListButtons(Composite composite) { Composite buttonComposite= new Composite(composite, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginHeight= 0; buttonComposite.setLayout(layout); GridData gridData= new GridData(); gridData.verticalAlignment= GridData.FILL; gridData.horizontalAlignment= GridData.FILL; buttonComposite.setLayoutData(gridData); fAddButton= new Button(buttonComposite, SWT.CENTER | SWT.PUSH); fAddButton.setText(JUnitMessages.getString("JUnitPreferencePage.addbutton.label")); //$NON-NLS-1$ setButtonGridData(fAddButton); fAddButton.addSelectionListener(this); fRemoveButton= new Button(buttonComposite, SWT.CENTER | SWT.PUSH); fRemoveButton.setText(JUnitMessages.getString("JUnitPreferencePage.removebutton.label")); //$NON-NLS-1$ setButtonGridData(fRemoveButton); fRemoveButton.addSelectionListener(this); } private void setButtonGridData(Button button) { GridData data = new GridData(); data.horizontalAlignment = GridData.FILL; data.grabExcessHorizontalSpace = true; data.heightHint= convertVerticalDLUsToPixels(IDialogConstants.BUTTON_HEIGHT); int widthHint= convertHorizontalDLUsToPixels(IDialogConstants.BUTTON_WIDTH); data.widthHint= Math.max(widthHint, button.computeSize(SWT.DEFAULT, SWT.DEFAULT, true).x); button.setLayoutData(data); } protected void createFilterTable(Composite composite) { Label label= new Label(composite, SWT.NONE); label.setText(JUnitMessages.getString("JUnitPreferencePage.filter.label")); //$NON-NLS-1$ GridData gridData= new GridData(); gridData.horizontalAlignment= GridData.FILL; gridData.horizontalSpan= 2; label.setLayoutData(gridData); fTable= new Table(composite, SWT.BORDER | SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL); GridData data= new GridData(); //Set heightHint with a small value so the list size will be defined by //the space available in the dialog instead of resizing the dialog to //fit all the items in the list. data.heightHint= fTable.getItemHeight(); data.verticalAlignment= GridData.FILL; data.horizontalAlignment= GridData.FILL; data.grabExcessHorizontalSpace= true; data.grabExcessVerticalSpace= true; fTable.setLayoutData(data); fTable.addSelectionListener(this); fillList(); if (fTable.getItemCount() > 0) fTable.setSelection(0); } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) { } /* * @see SelectionListener#widgetDefaultSelected(SelectionEvent) */ public void widgetDefaultSelected(SelectionEvent selectionEvent) { widgetSelected(selectionEvent); } protected void addFilterString(String filterEntry) { if (filterEntry != null) { TableItem tableItem= new TableItem(fTable, SWT.NONE); tableItem.setText(filterEntry); } } /* * @see SelectionListener#widgetSelected(SelectionEvent) */ public void widgetSelected(SelectionEvent selectionEvent) { if (selectionEvent.getSource().equals(fAddButton)) { FilterPatternsDialog dialog= new FilterPatternsDialog(getControl().getShell(), JUnitMessages.getString("JUnitPreferencePage.adddialog.title"), JUnitMessages.getString("JUnitPreferencePage.addialog.prompt")); //$NON-NLS-1$ //$NON-NLS-2$ dialog.open(); String pattern= dialog.getValue(); addFilterString(pattern); fTable.deselectAll(); fTable.select(fTable.getItemCount()-1); } else if (selectionEvent.getSource().equals(fRemoveButton)) { fTable.remove(fTable.getSelectionIndices()); } fRemoveButton.setEnabled(fTable.getSelectionIndex() != -1); } public boolean performOk() { IPreferenceStore store= getPreferenceStore(); int filterEntriesCount= fTable.getItemCount(); store.setValue(STACK_FILTER_ENTRIES_COUNT, filterEntriesCount); for (int i= 0; i < filterEntriesCount; i++) { store.setValue(STACK_FILTER_ENTRY_ + i, fTable.getItem(i).getText()); } store.setValue(SHOW_ON_ERROR_ONLY, fShowOnErrorCheck.getSelection()); return true; } private void fillList() { String[] patterns= getFilterPatterns(); for (int i= 0; i < patterns.length; i++) { TableItem tableItem= new TableItem(fTable, SWT.NONE); tableItem.setText(patterns[i]); } } }
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/object_in/TestFinalField.java
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/object_out/TestFinalField.java
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
org.eclipse.jdt.ui.tests.refactoring/test
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
cases/org/eclipse/jdt/ui/tests/refactoring/SefTests.java
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
org.eclipse.jdt.ui/core
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/sef/AccessAnalyzer.java
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
org.eclipse.jdt.ui/ui
16,182
Bug 16182 sef: incorrect handling of final flag results in compile error
20020515+ check the 'encapsulate .... in declaring class' checkbox class Test{ private final int x; Test(int y){ x= y; } } write access is changed to setX(y); which causes a compile error (becuase no setX method is created). the assignemnen must be left as is. and it must create no setters (any setter will result in an error.)
verified fixed
9ef7f57
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:33:09Z
2002-05-16T17:26:40Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/sef/SelfEncapsulateFieldInputPage.java
17,699
Bug 17699 Java Editor: Local Histroy menu entries are enabled for read-only files
F1 - make file read-only - open it - observe: context menu contains Local History actions. Only compare makes sense for read-only files
verified fixed
a180e8a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:59:02Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaAddElementFromHistory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.compare; import java.util.ResourceBundle; import java.lang.reflect.InvocationTargetException; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.IAction; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.viewers.*; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.ui.IEditorInput; import org.eclipse.core.resources.IFile; import org.eclipse.core.runtime.*; import org.eclipse.jdt.core.*; import org.eclipse.jdt.internal.corext.codemanipulation.MemberEdit; import org.eclipse.jdt.internal.corext.textmanipulation.*; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.compare.JavaHistoryAction.JavaTextBufferNode; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.preferences.CodeFormatterPreferencePage; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.compare.*; public class JavaAddElementFromHistory extends JavaHistoryAction { private static final String BUNDLE_NAME= "org.eclipse.jdt.internal.ui.compare.AddFromHistoryAction"; //$NON-NLS-1$ private JavaEditor fEditor; public JavaAddElementFromHistory() { } public void run(IAction action) { String errorTitle= CompareMessages.getString("AddFromHistory.title"); //$NON-NLS-1$ String errorMessage= CompareMessages.getString("AddFromHistory.internalErrorMessage"); //$NON-NLS-1$ Shell shell= JavaPlugin.getActiveWorkbenchShell(); // shell can be null; as a result error dialogs won't be parented ICompilationUnit cu= null; IParent parent= null; IMember input= null; // analyse selection ISelection selection= getSelection(); if (selection.isEmpty()) { // no selection: we try to use the editor's input if (fEditor != null) { IEditorInput editorInput= fEditor.getEditorInput(); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); if (manager != null) { cu= manager.getWorkingCopy(editorInput); parent= cu; } } } else { input= getEditionElement(selection); if (input != null) { cu= input.getCompilationUnit(); if (input instanceof IParent) { parent= (IParent)input; input= null; } else { IJavaElement parentElement= input.getParent(); if (parentElement instanceof IParent) parent= (IParent)parentElement; } } else { if (selection instanceof IStructuredSelection) { Object o= ((IStructuredSelection)selection).getFirstElement(); if (o instanceof ICompilationUnit) { cu= (ICompilationUnit) o; parent= cu; } } } } if (parent == null || cu == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } IFile file= getFile(parent); if (file == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } boolean inEditor= beingEdited(file); if (inEditor) { parent= (IParent) getWorkingCopy((IJavaElement)parent); if (input != null) input= (IMember) getWorkingCopy(input); } // get a TextBuffer where to insert the text TextBuffer buffer= null; try { buffer= TextBuffer.acquire(file); // configure EditionSelectionDialog and let user select an edition ITypedElement target= new JavaTextBufferNode(buffer, inEditor); ITypedElement[] editions= buildEditions(target, file); ResourceBundle bundle= ResourceBundle.getBundle(BUNDLE_NAME); EditionSelectionDialog d= new EditionSelectionDialog(shell, bundle); d.setAddMode(true); ITypedElement ti= d.selectEdition(target, editions, parent); if (!(ti instanceof IStreamContentAccessor)) return; // user cancel // from the edition get the lines (text) to insert String[] lines= null; try { lines= JavaCompareUtilities.readLines(((IStreamContentAccessor) ti).getContents()); } catch (CoreException ex) { JavaPlugin.log(ex); } if (lines == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } // build the TextEdit that inserts the text into the buffer MemberEdit edit= null; if (input != null) edit= new MemberEdit(input, MemberEdit.INSERT_AFTER, lines, CodeFormatterPreferencePage.getTabSize()); else edit= createEdit(lines, parent); if (edit == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } edit.setAddLineSeparators(false); IProgressMonitor nullProgressMonitor= new NullProgressMonitor(); TextBufferEditor editor= new TextBufferEditor(buffer); editor.add(edit); editor.performEdits(nullProgressMonitor); final TextBuffer bb= buffer; IRunnableWithProgress r= new IRunnableWithProgress() { public void run(IProgressMonitor pm) throws InvocationTargetException { try { TextBuffer.commitChanges(bb, false, pm); } catch (CoreException ex) { throw new InvocationTargetException(ex); } } }; if (inEditor) { // we don't show progress r.run(nullProgressMonitor); } else { ProgressMonitorDialog pd= new ProgressMonitorDialog(shell); pd.run(true, false, r); } } catch(InvocationTargetException ex) { JavaPlugin.log(ex); MessageDialog.openError(shell, errorTitle, errorMessage); } catch(InterruptedException ex) { // shouldn't be called because is not cancable } catch(CoreException ex) { JavaPlugin.log(ex); MessageDialog.openError(shell, errorTitle, errorMessage); } finally { if (buffer != null) TextBuffer.release(buffer); } } /** * Creates a TextEdit for inserting the given lines into the container. */ private MemberEdit createEdit(String[] lines, IParent container) { // find a child where to insert before IJavaElement[] children= null; try { children= container.getChildren(); } catch(JavaModelException ex) { } if (children != null) { IJavaElement candidate= null; for (int i= 0; i < children.length; i++) { IJavaElement chld= children[i]; switch (chld.getElementType()) { case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: // skip these but remember the last of them candidate= chld; continue; default: return new MemberEdit(chld, MemberEdit.INSERT_BEFORE, lines, CodeFormatterPreferencePage.getTabSize()); } } if (candidate != null) return new MemberEdit(candidate, MemberEdit.INSERT_AFTER, lines, CodeFormatterPreferencePage.getTabSize()); } // no children: insert at end (but before closing bracket) if (container instanceof IJavaElement) return new MemberEdit((IJavaElement)container, MemberEdit.ADD_AT_END, lines, CodeFormatterPreferencePage.getTabSize()); return null; } protected boolean isEnabled(ISelection selection) { if (selection.isEmpty()) { if (fEditor != null) { // we check whether editor shows CompilationUnit IEditorInput editorInput= fEditor.getEditorInput(); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); return manager.getWorkingCopy(editorInput) != null; } return false; } if (selection instanceof IStructuredSelection) { Object o= ((IStructuredSelection)selection).getFirstElement(); if (o instanceof ICompilationUnit) return true; } return super.isEnabled(selection); } }
17,699
Bug 17699 Java Editor: Local Histroy menu entries are enabled for read-only files
F1 - make file read-only - open it - observe: context menu contains Local History actions. Only compare makes sense for read-only files
verified fixed
a180e8a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:59:02Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareWithEditionAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.compare; import java.util.ResourceBundle; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.IAction; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.viewers.ISelection; import org.eclipse.core.resources.IFile; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.internal.corext.textmanipulation.TextBuffer; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.compare.JavaHistoryAction.JavaTextBufferNode; import org.eclipse.compare.*; /** * Provides "Replace from local history" for Java elements. */ public class JavaCompareWithEditionAction extends JavaHistoryAction { private static final String BUNDLE_NAME= "org.eclipse.jdt.internal.ui.compare.CompareWithEditionAction"; //$NON-NLS-1$ public JavaCompareWithEditionAction() { } public void run(IAction action) { String errorTitle= CompareMessages.getString("ReplaceFromHistory.title"); //$NON-NLS-1$ String errorMessage= CompareMessages.getString("ReplaceFromHistory.internalErrorMessage"); //$NON-NLS-1$ Shell shell= JavaPlugin.getActiveWorkbenchShell(); // shell can be null; as a result error dialogs won't be parented ISelection selection= getSelection(); IMember input= getEditionElement(selection); if (input == null) { // shouldn't happen because Action should not be enabled in the first place MessageDialog.openInformation(shell, errorTitle, errorMessage); return; } IFile file= getFile(input); if (file == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } boolean inEditor= beingEdited(file); if (inEditor) input= (IMember) getWorkingCopy(input); // get a TextBuffer where to insert the text TextBuffer buffer= null; try { buffer= TextBuffer.acquire(file); ITypedElement target= new JavaTextBufferNode(buffer, inEditor); ITypedElement[] editions= buildEditions(target, file); ResourceBundle bundle= ResourceBundle.getBundle(BUNDLE_NAME); EditionSelectionDialog d= new EditionSelectionDialog(shell, bundle); d.setCompareMode(true); d.setEditionTitleImage(JavaCompareUtilities.getImage(input)); d.selectEdition(target, editions, input); } catch(CoreException ex) { JavaPlugin.log(ex); MessageDialog.openError(shell, errorTitle, errorMessage); } finally { if (buffer != null) TextBuffer.release(buffer); } } }
17,699
Bug 17699 Java Editor: Local Histroy menu entries are enabled for read-only files
F1 - make file read-only - open it - observe: context menu contains Local History actions. Only compare makes sense for read-only files
verified fixed
a180e8a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:59:02Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaHistoryAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.compare; import java.io.*; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.action.*; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.*; import org.eclipse.ui.IActionDelegate; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.core.resources.*; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.*; import org.eclipse.jdt.internal.corext.textmanipulation.TextBuffer; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider; import org.eclipse.compare.*; /** * Base class for the "Replace with local history" * and "Add from local history" actions. */ public abstract class JavaHistoryAction implements IActionDelegate { /** * Implements the IStreamContentAccessor and ITypedElement protocols * for a TextBuffer. */ class JavaTextBufferNode implements ITypedElement, IStreamContentAccessor { private TextBuffer fBuffer; private boolean fInEditor; JavaTextBufferNode(TextBuffer buffer, boolean inEditor) { fBuffer= buffer; fInEditor= inEditor; } public String getName() { if (fInEditor) return CompareMessages.getString("Editor_Buffer"); //$NON-NLS-1$ return CompareMessages.getString("Workspace_File"); //$NON-NLS-1$ } public String getType() { return "java"; //$NON-NLS-1$ } public Image getImage() { return null; } public InputStream getContents() { return new ByteArrayInputStream(fBuffer.getContent().getBytes()); } } private ISelection fSelection; ISelection getSelection() { return fSelection; } protected IFile getFile(Object input) { // extract CU from input ICompilationUnit cu= null; if (input instanceof ICompilationUnit) cu= (ICompilationUnit) input; else if (input instanceof IMember) cu= ((IMember)input).getCompilationUnit(); if (cu == null || !cu.exists()) return null; // get to original CU if (cu.isWorkingCopy()) cu= (ICompilationUnit) cu.getOriginalElement(); // find underlying file IFile file= null; try { file= (IFile) cu.getUnderlyingResource(); } catch (JavaModelException ex) { JavaPlugin.log(ex); } if (file.exists()) return file; return null; } protected ITypedElement[] buildEditions(ITypedElement target, IFile file) { // setup array of editions IFileState[] states= null; // add available editions try { states= file.getHistory(null); } catch (CoreException ex) { JavaPlugin.log(ex); } int count= 1; if (states != null) count+= states.length; ITypedElement[] editions= new ITypedElement[count]; editions[0]= new ResourceNode(file); if (states != null) for (int i= 0; i < states.length; i++) editions[i+1]= new HistoryItem(target, states[i]); return editions; } /** * Tries to find the given element in a workingcopy. */ protected IJavaElement getWorkingCopy(IJavaElement input) { try { return EditorUtility.getWorkingCopy(input, true); } catch (JavaModelException ex) { } return null; } /** * Returns true if the given file is open in an editor. */ boolean beingEdited(IFile file) { CompilationUnitDocumentProvider dp= JavaPlugin.getDefault().getCompilationUnitDocumentProvider(); FileEditorInput input= new FileEditorInput(file); return dp.getDocument(input) != null; } /** * Returns an IMember or null. */ IMember getEditionElement(ISelection selection) { if (selection instanceof IStructuredSelection) { IStructuredSelection ss= (IStructuredSelection) selection; if (ss.size() == 1) { Object o= ss.getFirstElement(); if (o instanceof IMember) { IMember m= (IMember) o; if (m.exists() && !m.isBinary() && JavaStructureCreator.hasEdition(m)) return m; } } } return null; } protected boolean isEnabled(ISelection selection) { IMember m= getEditionElement(selection); if (m == null) return false; IFile file= getFile(m); if (file != null && beingEdited(file)) return getWorkingCopy(m) != null; return true; } /** * Notifies this action delegate that the selection in the workbench has changed. * <p> * Implementers can use this opportunity to change the availability of the * action or to modify other presentation properties. * </p> * * @param action the action proxy that handles presentation portion of the action * @param selection the current selection in the workbench */ public void selectionChanged(IAction action, ISelection selection) { fSelection= selection; action.setEnabled(isEnabled(selection)); } }
17,699
Bug 17699 Java Editor: Local Histroy menu entries are enabled for read-only files
F1 - make file read-only - open it - observe: context menu contains Local History actions. Only compare makes sense for read-only files
verified fixed
a180e8a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T16:59:02Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaReplaceWithEditionAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.compare; import java.lang.reflect.InvocationTargetException; import java.util.ResourceBundle; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.IAction; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.ISelection; import org.eclipse.compare.EditionSelectionDialog; import org.eclipse.compare.HistoryItem; import org.eclipse.compare.IStreamContentAccessor; import org.eclipse.compare.ITypedElement; import org.eclipse.compare.ResourceNode; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IFileState; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.internal.corext.codemanipulation.MemberEdit; import org.eclipse.jdt.internal.corext.textmanipulation.TextBuffer; import org.eclipse.jdt.internal.corext.textmanipulation.TextBufferEditor; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.compare.JavaHistoryAction.JavaTextBufferNode; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.preferences.CodeFormatterPreferencePage; /** * Provides "Replace from local history" for Java elements. */ public class JavaReplaceWithEditionAction extends JavaHistoryAction { private static final String BUNDLE_NAME= "org.eclipse.jdt.internal.ui.compare.ReplaceWithEditionAction"; //$NON-NLS-1$ private boolean fPrevious= false; public JavaReplaceWithEditionAction() { } public JavaReplaceWithEditionAction(boolean previous) { fPrevious= previous; } // CompareMessages.getString("ReplaceFromHistory.action.label") protected ITypedElement[] buildEditions(ITypedElement target, IFile file, IFileState[] states) { ITypedElement[] editions= new ITypedElement[states.length+1]; editions[0]= new ResourceNode(file); for (int i= 0; i < states.length; i++) editions[i+1]= new HistoryItem(target, states[i]); return editions; } /* * @see org.eclipse.ui.IActionDelegate#run(org.eclipse.jface.action.IAction) */ public void run(IAction action) { String errorTitle= CompareMessages.getString("ReplaceFromHistory.title"); //$NON-NLS-1$ String errorMessage= CompareMessages.getString("ReplaceFromHistory.internalErrorMessage"); //$NON-NLS-1$ Shell shell= JavaPlugin.getActiveWorkbenchShell(); // shell can be null; as a result error dialogs won't be parented ISelection selection= getSelection(); IMember input= getEditionElement(selection); if (input == null) { // shouldn't happen because Action should not be enabled in the first place MessageDialog.openError(shell, errorTitle, errorMessage); return; } IFile file= getFile(input); if (file == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } boolean inEditor= beingEdited(file); if (inEditor) input= (IMember) getWorkingCopy(input); // get a TextBuffer where to insert the text TextBuffer buffer= null; try { buffer= TextBuffer.acquire(file); ResourceBundle bundle= ResourceBundle.getBundle(BUNDLE_NAME); EditionSelectionDialog d= new EditionSelectionDialog(shell, bundle); ITypedElement target= new JavaTextBufferNode(buffer, inEditor); ITypedElement[] editions= buildEditions(target, file); ITypedElement ti= null; if (fPrevious) ti= d.selectPreviousEdition(target, editions, input); else ti= d.selectEdition(target, editions, input); if (ti instanceof IStreamContentAccessor) { // from the edition get the lines (text) to insert String[] lines= null; try { lines= JavaCompareUtilities.readLines(((IStreamContentAccessor) ti).getContents()); } catch (CoreException ex) { JavaPlugin.log(ex); } if (lines == null) { MessageDialog.openError(shell, errorTitle, errorMessage); return; } MemberEdit edit= new MemberEdit(input, MemberEdit.REPLACE, lines, CodeFormatterPreferencePage.getTabSize()); edit.setAddLineSeparators(false); IProgressMonitor nullProgressMonitor= new NullProgressMonitor(); TextBufferEditor editor= new TextBufferEditor(buffer); editor.add(edit); editor.performEdits(nullProgressMonitor); final TextBuffer bb= buffer; IRunnableWithProgress r= new IRunnableWithProgress() { public void run(IProgressMonitor pm) throws InvocationTargetException { try { TextBuffer.commitChanges(bb, false, pm); } catch (CoreException ex) { throw new InvocationTargetException(ex); } } }; if (inEditor) { JavaEditor je= getEditor(file); if (je != null) je.setFocus(); // we don't show progress r.run(nullProgressMonitor); } else { ProgressMonitorDialog pd= new ProgressMonitorDialog(shell); pd.run(true, false, r); } } } catch(InvocationTargetException ex) { JavaPlugin.log(ex); MessageDialog.openError(shell, errorTitle, errorMessage); } catch(InterruptedException ex) { // shouldn't be called because is not cancable } catch(CoreException ex) { JavaPlugin.log(ex); MessageDialog.openError(shell, errorTitle, errorMessage); } finally { if (buffer != null) TextBuffer.release(buffer); } } private JavaEditor getEditor(IFile file) { IWorkbench workbench= JavaPlugin.getDefault().getWorkbench(); IWorkbenchWindow[] windows= workbench.getWorkbenchWindows(); for (int i= 0; i < windows.length; i++) { IWorkbenchPage[] pages= windows[i].getPages(); for (int x= 0; x < pages.length; x++) { IEditorPart[] editors= pages[x].getDirtyEditors(); for (int z= 0; z < editors.length; z++) { IEditorPart ep= editors[z]; if (ep instanceof JavaEditor) return (JavaEditor) ep; } } } return null; } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/CreateJavadocActionDelegate.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.jface.action.IAction; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.ui.IObjectActionDelegate; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.jdt.internal.ui.JavaPlugin; public class CreateJavadocActionDelegate implements IObjectActionDelegate { private ISelection fCurrentSelection; /* * @see IObjectActionDelegate#setActivePart(IAction, IWorkbenchPart) */ public void setActivePart(IAction action, IWorkbenchPart targetPart) { } /* * @see IActionDelegate#run(IAction) */ public void run(IAction action) { if (fCurrentSelection instanceof IStructuredSelection) { IStructuredSelection structuredSelection= (IStructuredSelection) fCurrentSelection; Iterator iter= structuredSelection.iterator(); if (iter.hasNext()) { Object res= iter.next(); if (res instanceof IFile) { IFile file= (IFile) res; JavadocWizard wizard= new JavadocWizard(file); wizard.init(JavaPlugin.getActiveWorkbenchWindow().getWorkbench(),structuredSelection); WizardDialog dialog= new WizardDialog(JavaPlugin.getActiveWorkbenchShell(), wizard); dialog.create(); // dialog.getShell().setText(WorkbenchMessages.getString("CreateFileAction.title")); //$NON-NLS-1$ dialog.open(); } } } } /* * @see IActionDelegate#selectionChanged(IAction, ISelection) */ public void selectionChanged(IAction action, ISelection selection) { fCurrentSelection= selection; } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocMemberContentProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.util.ArrayList; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; public class JavadocMemberContentProvider implements ITreeContentProvider { /* * @see ITreeContentProvider#getChildren(Object) */ public Object[] getChildren(Object parentElement) { return new Object[0]; } /* * @see ITreeContentProvider#getParent(Object) */ public Object getParent(Object element) { //@test //System.out.println(element.getClass().toString()); if (element instanceof IPackageFragment) return ((IPackageFragment) element).getParent(); return null; } /* * @see ITreeContentProvider#hasChildren(Object) */ public boolean hasChildren(Object element) { try { if (element instanceof IPackageFragment) { IPackageFragment iPackageFragment= (IPackageFragment) element; return (iPackageFragment.getChildren().length > 0); } } catch (JavaModelException e) { } return false; } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { try { if (inputElement instanceof IPackageFragment) { ICompilationUnit[] cu= ((IPackageFragment) inputElement).getCompilationUnits(); return cu; } } catch (JavaModelException e) { JavaPlugin.log(e); } return new Object[0]; } /* * @see IContentProvider#dispose() */ public void dispose() { } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocOptionsManager.java
/* * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.io.File; import java.io.FileOutputStream; import java.io.IOException; import java.net.URL; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Set; import java.util.StringTokenizer; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.Path; import org.eclipse.jface.dialogs.DialogSettings; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.w3c.dom.Element; import org.w3c.dom.Node; import org.w3c.dom.NodeList; import org.xml.sax.SAXException; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.launching.ExecutionArguments; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.preferences.JavadocPreferencePage; public class JavadocOptionsManager { private IWorkspaceRoot fRoot; private IJavaProject fProject; private IFile fXmlfile; private StatusInfo fWizardStatus; private List fSourceElements; private List fSelectedElements; private String fAccess; private String fDocletpath; private String fDocletname; private boolean fFromStandard; private String fStylesheet; private String fAdditionalParams; private String fOverview; private String fTitle; private String fJDocCommand; private String fSourcepath; private String fClasspath; private boolean fNotree; private boolean fNoindex; private boolean fSplitindex; private boolean fNonavbar; private boolean fNodeprecated; private boolean fNoDeprecatedlist; private boolean fAuthor; private boolean fVersion; private boolean fUse; //list of hrefs in string format private Map fLinks; public final static String PRIVATE= "private"; //$NON-NLS-1$ public final static String PROTECTED= "protected"; //$NON-NLS-1$ public final static String PACKAGE= "package"; //$NON-NLS-1$ public final static String PUBLIC= "public"; //$NON-NLS-1$ public final static String USE="use"; //$NON-NLS-1$ public final static String NOTREE= "notree"; //$NON-NLS-1$ public final static String NOINDEX= "noindex"; //$NON-NLS-1$ public final static String NONAVBAR= "nonavbar"; //$NON-NLS-1$ public final static String NODEPRECATED= "nodeprecated"; //$NON-NLS-1$ public final static String NODEPRECATEDLIST= "nodeprecatedlist"; //$NON-NLS-1$ public final static String VERSION= "version"; //$NON-NLS-1$ public final static String AUTHOR= "author"; //$NON-NLS-1$ public final static String SPLITINDEX= "splitindex"; //$NON-NLS-1$ public final static String STYLESHEETFILE= "stylesheetfile"; //$NON-NLS-1$ public final static String OVERVIEW= "overview"; //$NON-NLS-1$ public final static String DOCLETNAME= "docletname"; //$NON-NLS-1$ public final static String DOCLETPATH= "docletpath"; //$NON-NLS-1$ public final static String SOURCEPATH= "sourcepath"; //$NON-NLS-1$ public final static String CLASSPATH= "classpath"; //$NON-NLS-1$ public final static String DESTINATION= "destdir"; //$NON-NLS-1$ public final static String VISIBILITY= "access"; //$NON-NLS-1$ public final static String PACKAGENAMES= "packagenames"; //$NON-NLS-1$ public final static String EXTRAOPTIONS= "additionalparam"; //$NON-NLS-1$ public final static String JAVADOCCOMMAND= "javadoccommand"; //$NON-NLS-1$ public final static String TITLE= "doctitle"; //$NON-NLS-1$ public final String HREF="href"; //$NON-NLS-1$ public final String NAME= "name"; //$NON-NLS-1$ public final String PATH= "path"; //$NON-NLS-1$ private final String FROMSTANDARD= "fromStandard"; //$NON-NLS-1$ private final String ANTPATH= "antpath"; //$NON-NLS-1$ /** * @param xmlJavadocFile The ant file to take initl values from or null, if not started from an ant file. * @param setting Dialog settings for the Javadoc exporter. */ public JavadocOptionsManager(IFile xmlJavadocFile, IDialogSettings settings, ISelection currSelection) { Element element; this.fRoot= ResourcesPlugin.getWorkspace().getRoot(); fJDocCommand= JavadocPreferencePage.getJavaDocCommand(); this.fXmlfile= xmlJavadocFile; this.fWizardStatus= new StatusInfo(); this.fLinks= new HashMap(); if(xmlJavadocFile!= null) { try { JavadocReader reader= new JavadocReader(xmlJavadocFile.getContents()); element= reader.readXML(); if (element == null) { fWizardStatus.setWarning(JavadocExportMessages.getString("JavadocOptionsManager.antfileincorrectCE.warning")); //$NON-NLS-1$ loadStore(settings, currSelection); } else loadStore(element, settings); } catch(CoreException e) { JavaPlugin.log(e); fWizardStatus.setWarning(JavadocExportMessages.getString("JavadocOptionsManager.antfileincorrectCE.warning")); //$NON-NLS-1$ loadStore(settings, currSelection); } catch(IOException e) { JavaPlugin.log(e); fWizardStatus.setWarning(JavadocExportMessages.getString("JavadocOptionsManager.antfileincorrectIOE.warning")); //$NON-NLS-1$ loadStore(settings, currSelection); } catch(SAXException e) { fWizardStatus.setWarning(JavadocExportMessages.getString("JavadocOptionsManager.antfileincorrectSAXE.warning")); //$NON-NLS-1$ loadStore(settings, currSelection); } }else loadStore(settings, currSelection); } private void loadStore(IDialogSettings settings, ISelection sel) { if(settings!= null){ //getValidSelection will also find the project fSelectedElements= getValidSelection(sel); fAccess= settings.get(VISIBILITY); if (fAccess == null) fAccess= PRIVATE; //this is defaulted to false. fFromStandard= settings.getBoolean(FROMSTANDARD); //doclet is loaded even if the standard doclet is being used fDocletpath= settings.get(DOCLETPATH); fDocletname= settings.get(DOCLETNAME); if (fDocletpath == null || fDocletname == null) { fFromStandard= true; fDocletpath= ""; //$NON-NLS-1$ fDocletname= ""; //$NON-NLS-1$ } //load a destination even if a custom doclet is being used fTitle= settings.get(TITLE); if(fTitle==null) fTitle=""; //$NON-NLS-1$ fStylesheet= settings.get(STYLESHEETFILE); if (fStylesheet == null) fStylesheet= ""; //$NON-NLS-1$ fAdditionalParams= settings.get(EXTRAOPTIONS); if (fAdditionalParams == null) fAdditionalParams= ""; //$NON-NLS-1$ fOverview= settings.get(OVERVIEW); if (fOverview == null) fOverview= ""; //$NON-NLS-1$ fUse= loadbutton(settings.get(USE)); fAuthor= loadbutton(settings.get(AUTHOR)); fVersion= loadbutton(settings.get(VERSION)); fNodeprecated= loadbutton(settings.get(NODEPRECATED)); fNoDeprecatedlist= loadbutton(settings.get(NODEPRECATEDLIST)); fNonavbar= loadbutton(settings.get(NONAVBAR)); fNoindex= loadbutton(settings.get(NOINDEX)); fNotree= loadbutton(settings.get(NOTREE)); fSplitindex= loadbutton(settings.get(SPLITINDEX)); loadLinksFromDialogSettings(settings); }else loadDefaults(sel); } private String getDefaultAntPath(IJavaProject project) { if (project != null) { IPath path = project.getProject().getLocation(); return path.append("javadoc.xml").toOSString(); //$NON-NLS-1$ } else return ""; //$NON-NLS-1$ } private String getDefaultDestination(IJavaProject project) { if (project != null) { URL url = JavaDocLocations.getProjectJavadocLocation(project); //uses default if source is has http protocol if (url == null || !url.getProtocol().equals("file")) { //$NON-NLS-1$ return project.getProject().getLocation().append("doc").toOSString(); //$NON-NLS-1$ } else { //must do this to remove leading "/" return (new File(url.getFile())).getPath(); } } else return ""; //$NON-NLS-1$ } private void loadLinksFromDialogSettings(IDialogSettings settings) { if (settings != null) { IDialogSettings links = settings.getSection("projects"); //$NON-NLS-1$ if (links != null) { IDialogSettings[] projs = links.getSections(); for (int i = 0; i < projs.length; i++) { IDialogSettings iDialogSettings = projs[i]; String projectName = iDialogSettings.getName(); IProject project = fRoot.getProject(projectName); if (project.exists()) { IJavaProject javaProject = JavaCore.create(project); if (!fLinks.containsKey(javaProject)) { String hrefs = iDialogSettings.get(HREF); if (hrefs == null) { hrefs= ""; //$NON-NLS-1$ } String destdir= iDialogSettings.get(DESTINATION); if (destdir == null || destdir.length() == 0) { destdir= getDefaultDestination(javaProject); } String antpath= iDialogSettings.get(ANTPATH); if (antpath == null || antpath.length() == 0) { antpath= getDefaultAntPath(javaProject); } ProjectData data= new ProjectData(javaProject); data.setDestination(destdir); data.setAntpath(antpath); data.setlinks(hrefs); fLinks.put(javaProject, data); } } } } } IProject[] projects = fRoot.getProjects(); for (int i = 0; i < projects.length; i++) { IProject iProject = projects[i]; IJavaProject javaProject = JavaCore.create(iProject); if (!fLinks.containsKey(javaProject)) { ProjectData data= new ProjectData(javaProject); data.setDestination(getDefaultDestination(javaProject)); data.setAntpath(getDefaultAntPath(javaProject)); data.setlinks(""); //$NON-NLS-1$ fLinks.put(javaProject, data); } } } private void loadDefaults(ISelection sel) { fSelectedElements= getValidSelection(sel); fAccess= PUBLIC; fDocletname=""; //$NON-NLS-1$ fDocletpath=""; //$NON-NLS-1$ fTitle= ""; //$NON-NLS-1$ fStylesheet= ""; //$NON-NLS-1$ fAdditionalParams= ""; //$NON-NLS-1$ fOverview= ""; //$NON-NLS-1$ fUse= true; fAuthor= true; fVersion= true; fNodeprecated= false; fNoDeprecatedlist= false; fNonavbar= false; fNoindex= false; fNotree= false; fSplitindex= true; //by default it is empty all project map to the empty string fFromStandard= true; loadLinksFromDialogSettings(null); } private void loadStore(Element element, IDialogSettings settings) { fAccess= element.getAttribute(VISIBILITY); if (!(fAccess.length() > 0)) fAccess= PRIVATE; //locate the project, set global variable fProject fSourcepath= element.getAttribute(SOURCEPATH); String token; if (fSourcepath.length() > 0) { int index= fSourcepath.indexOf(';'); if (index != -1) token= fSourcepath.substring(0, index); else token= fSourcepath; IContainer container= fRoot.getContainerForLocation(new Path(token)); if (container != null && container.exists()) { IProject p= container.getProject(); fProject= JavaCore.create(p); } } //Since the selected packages are stored we must locate the project String destination= element.getAttribute(DESTINATION); fFromStandard= true; fDocletname= ""; //$NON-NLS-1$ fDocletpath= ""; //$NON-NLS-1$ if (destination.equals("")) { //$NON-NLS-1$ NodeList list= element.getChildNodes(); for (int i= 0; i < list.getLength(); i++) { Node child= list.item(i); if (child.getNodeName().equals("doclet")) { //$NON-NLS-1$ fDocletpath= ((Element) child).getAttribute(PATH); fDocletname= ((Element) child).getAttribute(NAME); if (!(fDocletpath.equals("") && !fDocletname.equals(""))) { //$NON-NLS-1$ //$NON-NLS-2$ fFromStandard= false; } else { fDocletname= ""; //$NON-NLS-1$ fDocletpath= ""; //$NON-NLS-1$ } break; } } } if(fProject != null) { boolean firstTime= true; StringBuffer buf= new StringBuffer(); NodeList children= element.getChildNodes(); for(int i=0; i < children.getLength(); i++) { Node child= children.item(i); if(child.getNodeName().equals("link")) { //$NON-NLS-1$ String href= ((Element)child).getAttribute(HREF); if(firstTime) firstTime= false; else buf.append(';'); buf.append(href); } } ProjectData data= new ProjectData(fProject); data.setAntpath(fXmlfile.getLocation().toOSString()); data.setlinks(buf.toString()); data.setDestination(destination); fLinks.put(fProject, data); } loadLinksFromDialogSettings(settings); //get tree elements fSelectedElements= new ArrayList(); if (fProject != null) { //get all the package or type names //@Notice : Change settreechecked List names= new ArrayList(); String packagenames= element.getAttribute(PACKAGENAMES); if (packagenames != null) { StringTokenizer tokenizer= new StringTokenizer(packagenames, ","); //$NON-NLS-1$ while (tokenizer.hasMoreTokens()) { names.add(tokenizer.nextToken().trim()); } } try { for (int i = 0; i < names.size(); i++) { String name = (String) names.get(i); if (name.endsWith(".java")) { //$NON-NLS-1$ IPath path = new Path(name); IFile re = fRoot.getFileForLocation(path); if (re != null && re.exists()) { IJavaElement el = JavaCore.createCompilationUnitFrom(re); if (el != null) { fSelectedElements.add(el); } } } else { IJavaElement el = JavaModelUtil.findTypeContainer(fProject, name); if (el instanceof IPackageFragment) { fSelectedElements.add(el); } } } } catch (JavaModelException e) { JavaPlugin.log(e); } } fStylesheet= element.getAttribute(STYLESHEETFILE); fTitle= element.getAttribute(TITLE); fAdditionalParams= element.getAttribute(EXTRAOPTIONS); fOverview= element.getAttribute(OVERVIEW); fUse= loadbutton(element.getAttribute(USE)); fAuthor= loadbutton(element.getAttribute(AUTHOR)); fVersion= loadbutton(element.getAttribute(VERSION)); fNodeprecated= loadbutton(element.getAttribute(NODEPRECATED)); fNoDeprecatedlist= loadbutton(element.getAttribute(NODEPRECATEDLIST)); fNonavbar= loadbutton(element.getAttribute(NONAVBAR)); fNoindex= loadbutton(element.getAttribute(NOINDEX)); fNotree= loadbutton(element.getAttribute(NOTREE)); fSplitindex= loadbutton(element.getAttribute(SPLITINDEX)); } //it is possible that the package list is empty public StatusInfo getWizardStatus() { return fWizardStatus; } public IJavaElement[] getSelectedElements() { return (IJavaElement[]) fSelectedElements.toArray(new IJavaElement[fSelectedElements.size()]); } public IJavaElement[] getSourceElements() { return (IJavaElement[]) fSourceElements.toArray(new IJavaElement[fSourceElements.size()]); } public String getAccess() { return fAccess; } public String getAntpath(IJavaProject project) { ProjectData data= (ProjectData)fLinks.get(project); if(data != null) return data.getAntPath(); else return ""; //$NON-NLS-1$ } public boolean fromStandard() { return fFromStandard; } public String getDestination(IJavaProject project) { ProjectData data= (ProjectData)fLinks.get(project); if(data != null) return data.getDestination(); else return ""; //$NON-NLS-1$ } public String getDocletPath() { return fDocletpath; } public String getDocletName() { return fDocletname; } public String getStyleSheet() { return fStylesheet; } public String getOverview() { return fOverview; } public String getAdditionalParams() { return fAdditionalParams; } public String getClasspath() { return fClasspath; } public String getSourcepath() { return fSourcepath; } public IWorkspaceRoot getRoot() { return fRoot; } public IJavaProject getJavaProject() { return this.fProject; } public String getTitle() { return fTitle; } public String getLinks(IJavaProject project) { ProjectData data= (ProjectData)fLinks.get(project); if(data != null) return data.getlinks(); else return ""; //$NON-NLS-1$ } public Map getLinkMap() { return fLinks; } public boolean getBoolean(String flag) { if (flag.equals(AUTHOR)) return fAuthor; else if (flag.equals(VERSION)) return fVersion; else if(flag.equals(USE)) return fUse; else if (flag.equals(NODEPRECATED)) return fNodeprecated; else if (flag.equals(NODEPRECATEDLIST)) return fNoDeprecatedlist; else if (flag.equals(NOINDEX)) return fNoindex; else if (flag.equals(NOTREE)) return fNotree; else if (flag.equals(SPLITINDEX)) return fSplitindex; else if (flag.equals(NONAVBAR)) return fNonavbar; else return false; } private boolean loadbutton(String value) { if (value == null || value.equals("")) //$NON-NLS-1$ return false; else { if (value.equals("true")) //$NON-NLS-1$ return true; else return false; } } public String[] createArgumentArray() throws CoreException { if (fProject == null) { return new String[0]; } List args= new ArrayList(); ProjectData data= (ProjectData)fLinks.get(fProject); args.add(fJDocCommand); if (fFromStandard) { args.add("-d"); //$NON-NLS-1$ args.add(data.getDestination()); } else { if (!fAdditionalParams.equals("")) { //$NON-NLS-1$ ExecutionArguments tokens= new ExecutionArguments("", fAdditionalParams); //$NON-NLS-1$ String[] argsArray= tokens.getProgramArgumentsArray(); for (int i= 0; i < argsArray.length; i++) { args.add(argsArray[i]); } } args.add("-doclet"); //$NON-NLS-1$ args.add(fDocletname); args.add("-docletpath"); //$NON-NLS-1$ args.add(fDocletpath); } args.add("-sourcepath"); //$NON-NLS-1$ args.add(fSourcepath); args.add("-classpath"); //$NON-NLS-1$ args.add(fClasspath); args.add("-" + fAccess); //$NON-NLS-1$ if (fFromStandard) { if(fUse) args.add("-use"); //$NON-NLS-1$ if (fVersion) args.add("-version"); //$NON-NLS-1$ if (fAuthor) args.add("-author"); //$NON-NLS-1$ if (fNonavbar) args.add("-nonavbar"); //$NON-NLS-1$ if (fNoindex) args.add("-noindex"); //$NON-NLS-1$ if (fNotree) args.add("-notree"); //$NON-NLS-1$ if (fNodeprecated) args.add("-nodeprecated"); //$NON-NLS-1$ if (fNoDeprecatedlist) args.add("-nodeprecatedlist"); //$NON-NLS-1$ if (fSplitindex) args.add("-splitindex"); //$NON-NLS-1$ if(!fTitle.equals("")) { //$NON-NLS-1$ args.add("-doctitle"); //$NON-NLS-1$ args.add(fTitle); } if (!fStylesheet.equals("")) { //$NON-NLS-1$ args.add("-stylesheetfile"); //$NON-NLS-1$ args.add(fStylesheet); } if (!fAdditionalParams.equals("")) { //$NON-NLS-1$ ExecutionArguments tokens = new ExecutionArguments("", fAdditionalParams); //$NON-NLS-1$ String[] argsArray = tokens.getProgramArgumentsArray(); for (int i = 0; i < argsArray.length; i++) { args.add(argsArray[i]); } } String hrefs = (String) data.getlinks(); StringTokenizer tokenizer = new StringTokenizer(hrefs, ";"); //$NON-NLS-1$ while (tokenizer.hasMoreElements()) { String href = (String) tokenizer.nextElement(); args.add("-link"); //$NON-NLS-1$ args.add(href); } }//end standard options if (!fOverview.equals("")) { //$NON-NLS-1$ args.add("-overview"); //$NON-NLS-1$ args.add(fOverview); } for (int i= 0; i < fSourceElements.size(); i++) { IJavaElement curr= (IJavaElement) fSourceElements.get(i); if (curr instanceof IPackageFragment) { args.add(curr.getElementName()); } else if (curr instanceof ICompilationUnit) { args.add(curr.getUnderlyingResource().getLocation().toOSString()); } } return (String[]) args.toArray(new String[args.size()]); } public void createXML() { FileOutputStream objectStreamOutput= null; ProjectData data= (ProjectData)fLinks.get(fProject); String antpath= data.getAntPath(); try { if (!antpath.equals("")) { //$NON-NLS-1$ File file= new File(antpath); IPath path= new Path(antpath); path= path.removeLastSegments(1); path.toFile().mkdirs(); objectStreamOutput= new FileOutputStream(file); JavadocWriter writer= new JavadocWriter(objectStreamOutput); writer.writeXML(this); } } catch (IOException e) { JavaPlugin.log(e); } catch (CoreException e) { JavaPlugin.log(e); } finally { if (objectStreamOutput != null) { try { objectStreamOutput.close(); } catch (IOException e) {} } } } public IDialogSettings createDialogSettings() { IDialogSettings settings= new DialogSettings("javadoc"); //$NON-NLS-1$ settings.put(FROMSTANDARD, fFromStandard); settings.put(DOCLETNAME, fDocletname); settings.put(DOCLETPATH, fDocletpath); settings.put(VISIBILITY, fAccess); settings.put(USE, fUse); settings.put(AUTHOR, fAuthor); settings.put(VERSION, fVersion); settings.put(NODEPRECATED, fNodeprecated); settings.put(NODEPRECATEDLIST, fNoDeprecatedlist); settings.put(SPLITINDEX, fSplitindex); settings.put(NOINDEX, fNoindex); settings.put(NOTREE, fNotree); settings.put(NONAVBAR, fNonavbar); if (!fAdditionalParams.equals("")) //$NON-NLS-1$ settings.put(EXTRAOPTIONS, fAdditionalParams); if (!fOverview.equals("")) //$NON-NLS-1$ settings.put(OVERVIEW, fOverview); if (!fStylesheet.equals("")) //$NON-NLS-1$ settings.put(STYLESHEETFILE, fStylesheet); if(!fTitle.equals("")) //$NON-NLS-1$ settings.put(TITLE, fTitle); IDialogSettings links = new DialogSettings("projects"); //$NON-NLS-1$ Set keys = fLinks.keySet(); List contains = new ArrayList(); IProject[] projects = fRoot.getProjects(); for (int i = 0; i < projects.length; i++) { IProject iProject = projects[i]; IJavaProject javaProject = JavaCore.create(iProject); if (javaProject != null) { IDialogSettings proj = new DialogSettings(javaProject.getElementName()); if (!keys.contains(javaProject)) { proj.put(HREF, ""); //$NON-NLS-1$ proj.put(DESTINATION, ""); //$NON-NLS-1$ proj.put(ANTPATH, ""); //$NON-NLS-1$ } else { ProjectData data = (ProjectData) fLinks.get(javaProject); proj.put(HREF, data.getlinks()); proj.put(DESTINATION, data.getDestination()); proj.put(ANTPATH, data.getAntPath()); } links.addSection(proj); } } settings.addSection(links); return settings; } public void setAccess(String access) { this.fAccess= access; } public void setDestination(IJavaProject project, String destination) { ProjectData data= (ProjectData)fLinks.get(project); data.setDestination(destination); } public void setDocletPath(String docletpath) { this.fDocletpath= docletpath; } public void setDocletName(String docletname) { this.fDocletname= docletname; } public void setStyleSheet(String stylesheet) { this.fStylesheet= stylesheet; } public void setOverview(String overview) { this.fOverview= overview; } public void setAdditionalParams(String params) { fAdditionalParams= params; } public void setAntpath(IJavaProject project, String antpath) { ProjectData data= (ProjectData)fLinks.get(project); data.setAntpath(antpath); } public void setClasspath(String classpath) { this.fClasspath= classpath; } public void setSourcepath(String sourcepath) { this.fSourcepath= sourcepath; } public void setSourceElements(IJavaElement[] elements) { this.fSourceElements= new ArrayList(Arrays.asList(elements)); } public void setRoot(IWorkspaceRoot root) { this.fRoot= root; } public void setProject(IJavaProject project) { this.fProject= project; } public void setFromStandard(boolean fromStandard) { this.fFromStandard= fromStandard; } public void setTitle(String title) { this.fTitle= title; } public void setLinks(IJavaProject project, String hrefs) { ProjectData data= (ProjectData)fLinks.get(project); data.setlinks(hrefs); } public void setBoolean(String flag, boolean value) { if (flag.equals(AUTHOR)) this.fAuthor= value; else if(flag.equals(USE)) this.fUse= value; else if (flag.equals(VERSION)) this.fVersion= value; else if (flag.equals(NODEPRECATED)) this.fNodeprecated= value; else if (flag.equals(NODEPRECATEDLIST)) this.fNoDeprecatedlist= value; else if (flag.equals(NOINDEX)) this.fNoindex= value; else if (flag.equals(NOTREE)) this.fNotree= value; else if (flag.equals(SPLITINDEX)) this.fSplitindex= value; else if (flag.equals(NONAVBAR)) this.fNonavbar= value; } private List getValidSelection(ISelection currentSelection) { fProject = null; ArrayList res= new ArrayList(); if (currentSelection instanceof IStructuredSelection) { IStructuredSelection structuredSelection= (IStructuredSelection) currentSelection; if (structuredSelection.isEmpty()) { currentSelection= JavaPlugin.getActiveWorkbenchWindow().getSelectionService().getSelection(); if (currentSelection instanceof IStructuredSelection) structuredSelection= (IStructuredSelection) currentSelection; } Iterator iter= structuredSelection.iterator(); //this method will also find the project for default //destination and ant generation paths getProject(res, iter); } return res; } private void getProject(List selectedElements, Iterator iter) { fProject = null; while (iter.hasNext()) { Object selectedElement = iter.next(); IJavaElement elem = getSelectableJavaElement(selectedElement); if (elem != null) { IJavaProject jproj = elem.getJavaProject(); if (jproj != null) { if (fProject == null){ fProject = jproj; selectedElements.add(elem); } else if (fProject.equals(jproj)) { selectedElements.add(elem); } } } } if (fProject == null) { Object[] roots= fRoot.getProjects(); for (int i= 0; i < roots.length; i++) { IProject p= (IProject) roots[i]; IJavaProject iJavaProject= JavaCore.create(p); if (getValidProject(iJavaProject)) { fProject= iJavaProject; break; } } } } private IJavaElement getSelectableJavaElement(Object obj) { IJavaElement je= null; try { if (obj instanceof IAdaptable) { je= (IJavaElement) ((IAdaptable) obj).getAdapter(IJavaElement.class); } if (je == null) { return null; } switch (je.getElementType()) { case IJavaElement.JAVA_MODEL : case IJavaElement.JAVA_PROJECT : case IJavaElement.CLASS_FILE : break; case IJavaElement.PACKAGE_FRAGMENT_ROOT : if (containsCompilationUnits((IPackageFragmentRoot) je)) { return je; } break; case IJavaElement.PACKAGE_FRAGMENT : if (containsCompilationUnits((IPackageFragment) je)) { return je; } break; default : ICompilationUnit cu= (ICompilationUnit) je.getAncestor(IJavaElement.COMPILATION_UNIT); if (cu != null) { if (cu.isWorkingCopy()) { cu= (ICompilationUnit) cu.getOriginalElement(); } return cu; } } } catch (JavaModelException e) { JavaPlugin.log(e); } IJavaProject project= je.getJavaProject(); if (getValidProject(project)) return project; else return null; } private boolean getValidProject(IJavaProject project) { if (project != null) { try { IPackageFragmentRoot[] roots= project.getPackageFragmentRoots(); for (int i= 0; i < roots.length; i++) { if (containsCompilationUnits(roots[i])) { return true; } } } catch (JavaModelException e) { JavaPlugin.log(e); } } return false; } private boolean containsCompilationUnits(IPackageFragmentRoot root) throws JavaModelException { if (root.getKind() != IPackageFragmentRoot.K_SOURCE) { return false; } IJavaElement[] elements= root.getChildren(); for (int i= 0; i < elements.length; i++) { if (elements[i] instanceof IPackageFragment) { IPackageFragment fragment= (IPackageFragment) elements[i]; if (containsCompilationUnits(fragment)) { return true; } } } return false; } private boolean containsCompilationUnits(IPackageFragment pack) throws JavaModelException { return pack.getCompilationUnits().length > 0; } private class ProjectData { private IJavaProject dataProject; private String dataHrefs; private String dataDestdir; private String dataAntPath; ProjectData(IJavaProject project) { dataProject= project; } public void setlinks(String hrefs) { if(hrefs==null) dataHrefs=""; //$NON-NLS-1$ else dataHrefs= hrefs; } public void setDestination(String destination) { if(destination==null) dataDestdir=""; //$NON-NLS-1$ else dataDestdir= destination; } public void setAntpath(String antpath) { if(antpath==null) dataAntPath= ""; //$NON-NLS-1$ else dataAntPath= antpath; } public String getlinks() { return dataHrefs; } public String getDestination() { return dataDestdir; } public String getAntPath() { return dataAntPath; } } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocProjectContentProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.util.ArrayList; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; public class JavadocProjectContentProvider implements ITreeContentProvider { /* * @see ITreeContentProvider#getChildren(Object) */ public Object[] getChildren(Object parentElement) { try { if (parentElement instanceof IJavaProject) { IJavaProject project= (IJavaProject) parentElement; return getPackageFragmentRoots(project); } else if (parentElement instanceof IPackageFragmentRoot) { return getPackageFragments((IPackageFragmentRoot) parentElement); } } catch (JavaModelException e) { JavaPlugin.log(e); } return new Object[0]; } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { if (inputElement instanceof IWorkspaceRoot) { ArrayList list= new ArrayList(); try { IJavaProject[] jprojects= JavaCore.create((IWorkspaceRoot) inputElement).getJavaProjects(); for (int i= 0; i < jprojects.length; i++) { IJavaProject javaProject= jprojects[i]; IPackageFragment[] els= javaProject.getPackageFragments(); for (int j= 0; j < els.length; j++) { IPackageFragment iPackageFragment= (IPackageFragment) els[j]; if (iPackageFragment.getCompilationUnits().length > 0) { list.add(javaProject); break; } } } } catch (JavaModelException e) { JavaPlugin.log(e); } return list.toArray(); } return new Object[0]; } /* * @see ITreeContentProvider#getParent(Object) */ public Object getParent(Object element) { IJavaElement parent= ((IJavaElement)element).getParent(); if (parent instanceof IPackageFragmentRoot) { IPackageFragmentRoot root= (IPackageFragmentRoot) parent; if (root.getPath().equals(root.getJavaProject().getProject().getFullPath())) { return root.getJavaProject(); } } return parent; } /* * @see ITreeContentProvider#hasChildren(Object) */ public boolean hasChildren(Object element) { try { if (element instanceof IPackageFragment) return (((IPackageFragment) element).getChildren().length > 0); else return (getChildren(element).length > 0); } catch (JavaModelException e) { } return false; } /* * @see IContentProvider#dispose() */ public void dispose() { } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } private Object[] getPackageFragmentRoots(IJavaProject project) throws JavaModelException { ArrayList result= new ArrayList(); IPackageFragmentRoot[] roots= project.getPackageFragmentRoots(); for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot root= roots[i]; if (root.getKind() == IPackageFragmentRoot.K_SOURCE) { if (root.getPath().equals(root.getJavaProject().getProject().getFullPath())) { return getPackageFragments(root); } result.add(root); } } return result.toArray(); } private Object[] getPackageFragments(IPackageFragmentRoot root) throws JavaModelException { ArrayList packageFragments= new ArrayList(); IJavaElement[] children= root.getChildren(); for (int i= 0; i < children.length; i++) { if (((IPackageFragment) children[i]).containsJavaResources()) packageFragments.add(children[i]); } return packageFragments.toArray(); } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocSpecificsWizardPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.io.File; import java.util.ArrayList; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Group; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.dialogs.ControlEnableState; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javadocexport.JavadocWizardPage.ToggleSelectionAdapter; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class JavadocSpecificsWizardPage extends JavadocWizardPage { protected Button fAntBrowseButton; private Button fCheckbrowser; protected Text fAntText; protected Button fOverViewButton; private Button fOverViewBrowseButton; protected Button fAntButton; private Composite fLowerComposite; private Label fSeparator; protected Text fOverViewText; protected Text fExtraOptionsText; private StatusInfo fOverviewStatus; private StatusInfo fAntStatus; private ControlEnableState fControlEnableState; private JavadocOptionsManager fStore; private JavadocWizard fWizard; private String fDialogSectionName; private final int OVERVIEWSTATUS=1; private final int ANTSTATUS= 2; /** * Constructor for JavadocWizardPage. * @param pageName */ protected JavadocSpecificsWizardPage(String pageName, JavadocOptionsManager store) { super(pageName); setDescription(JavadocExportMessages.getString("JavadocSpecificsWizardPage.description")); //$NON-NLS-1$ fStore= store; fOverviewStatus= new StatusInfo(); fAntStatus= new StatusInfo(); } /* * @see IDialogPage#createControl(Composite) */ public void createControl(Composite parent) { fWizard= (JavadocWizard)this.getWizard(); fLowerComposite= new Composite(parent, SWT.NONE); fLowerComposite.setLayoutData(createGridData(GridData.FILL_BOTH, 1, 0)); GridLayout layout= createGridLayout(3); layout.marginHeight= 0; fLowerComposite.setLayout(layout); createExtraOptionsGroup(fLowerComposite); createAntGroup(fLowerComposite); setControl(fLowerComposite); } //end method createControl private void createExtraOptionsGroup(Composite composite) { Composite c= new Composite(composite, SWT.NONE); c.setLayout(createGridLayout(3)); c.setLayoutData(createGridData(GridData.FILL_HORIZONTAL, 3, 0)); ((GridLayout) c.getLayout()).marginWidth= 0; fOverViewButton= createButton(c, SWT.CHECK, JavadocExportMessages.getString("JavadocSpecificsWizardPage.overviewbutton.label"), createGridData(1)); //$NON-NLS-1$ fOverViewText= createText(c, SWT.SINGLE | SWT.BORDER , null, createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //there really aught to be a way to specify this ((GridData) fOverViewText.getLayoutData()).widthHint = 200; fOverViewBrowseButton= createButton(c, SWT.PUSH, JavadocExportMessages.getString("JavadocSpecificsWizardPage.overviewbrowse.label"), createGridData(GridData.HORIZONTAL_ALIGN_END, 1, 0)); //$NON-NLS-1$ SWTUtil.setButtonDimensionHint(fOverViewBrowseButton); String str= fStore.getOverview(); if (str.equals("")) { //$NON-NLS-1$ //default fOverViewText.setEnabled(false); fOverViewBrowseButton.setEnabled(false); } else { fOverViewButton.setSelection(true); fOverViewText.setText(str); } Label jdocLocationLabel= createLabel(composite, SWT.NONE, JavadocExportMessages.getString("JavadocSpecificsWizardPage.extraoptionsfield.label"), createGridData(GridData.HORIZONTAL_ALIGN_BEGINNING, 3, 0)); //$NON-NLS-1$ fExtraOptionsText= createText(composite, SWT.MULTI | SWT.BORDER | SWT.WRAP | SWT.H_SCROLL | SWT.V_SCROLL, null, createGridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.FILL_VERTICAL, 3, 0)); //fExtraOptionsText.setSize(convertWidthInCharsToPixels(60), convertHeightInCharsToPixels(10)); str= fStore.getAdditionalParams(); fExtraOptionsText.setText(str); //Listeners fOverViewButton.addSelectionListener(new ToggleSelectionAdapter(new Control[] { fOverViewBrowseButton, fOverViewText }) { public void validate() { doValidation(OVERVIEWSTATUS); } }); fOverViewText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { doValidation(OVERVIEWSTATUS); } }); fOverViewBrowseButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { handleFileBrowseButtonPressed(fOverViewText, new String[] { "*.html" }, JavadocExportMessages.getString("JavadocSpecificsWizardPage.overviewbrowsedialog.title")); //$NON-NLS-1$ //$NON-NLS-2$ } }); } private void createAntGroup(Composite composite) { Composite c= new Composite(composite, SWT.NONE); c.setLayout(createGridLayout(3)); c.setLayoutData(createGridData(GridData.FILL_HORIZONTAL, 3, 0)); ((GridLayout) c.getLayout()).marginWidth= 0; fAntButton= createButton(c, SWT.CHECK, JavadocExportMessages.getString("JavadocSpecificsWizardPage.antscriptbutton.label"), createGridData(3)); //$NON-NLS-1$ Label AntLabel= createLabel(c, SWT.NONE, JavadocExportMessages.getString("JavadocSpecificsWizardPage.antscripttext.label"), createGridData(GridData.HORIZONTAL_ALIGN_BEGINNING, 1, 0)); //$NON-NLS-1$ fAntText= createText(c, SWT.SINGLE | SWT.BORDER, null, createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //there really aught to be a way to specify this ((GridData) fAntText.getLayoutData()).widthHint = 200; fAntText.setText(fStore.getAntpath(fWizard.getProject())); fAntText.setEnabled(false); fAntBrowseButton= createButton(c, SWT.PUSH, JavadocExportMessages.getString("JavadocSpecificsWizardPage.antscriptbrowse.label"), createGridData(GridData.HORIZONTAL_ALIGN_END, 1, 0)); //$NON-NLS-1$ SWTUtil.setButtonDimensionHint(fAntBrowseButton); fAntBrowseButton.setEnabled(false); fCheckbrowser= createButton(c, SWT.CHECK, JavadocExportMessages.getString("JavadocSpecificsWizardPage.openbrowserbutton.label"), createGridData(3)); //$NON-NLS-1$ fAntButton.addSelectionListener(new ToggleSelectionAdapter(new Control[] { fAntText, fAntBrowseButton }) { public void validate() { doValidation(ANTSTATUS); } }); fAntText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { doValidation(ANTSTATUS); } }); fAntBrowseButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { String temp= fAntText.getText(); IPath path= new Path(temp); String file= path.lastSegment(); path= path.removeLastSegments(1); temp= handleFolderBrowseButtonPressed(path.toOSString(),fAntText.getShell(), JavadocExportMessages.getString("JavadocSpecificsWizardPage.antscriptbrowsedialog.title"), JavadocExportMessages.getString("JavadocSpecificsWizardPage.antscriptbrowsedialog.label")); //$NON-NLS-1$ //$NON-NLS-2$ path= new Path(temp); path= path.addTrailingSeparator().append(file); fAntText.setText(path.toOSString()); } }); } //end method createExtraOptionsGroup private void doValidation(int VALIDATE) { File file= null; String ext= null; Path path= null; switch (VALIDATE) { case OVERVIEWSTATUS : fOverviewStatus = new StatusInfo(); if (fOverViewButton.getSelection()) { path = new Path(fOverViewText.getText()); file = path.toFile(); ext = path.getFileExtension(); if ((file == null) || !file.exists()) { fOverviewStatus.setError(JavadocExportMessages.getString("JavadocSpecificsWizardPage.overviewnotfound.error")); //$NON-NLS-1$ } else if ((ext == null) || !ext.equalsIgnoreCase("html")) { //$NON-NLS-1$ fOverviewStatus.setError(JavadocExportMessages.getString("JavadocSpecificsWizardPage.overviewincorrect.error")); //$NON-NLS-1$ } } break; case ANTSTATUS : fAntStatus = new StatusInfo(); if (fAntButton.getSelection()) { path = new Path(fAntText.getText()); ext = path.getFileExtension(); IPath antSeg = path.removeLastSegments(1); if ((!antSeg.isValidPath(antSeg.toOSString())) || (ext == null) || !(ext.equalsIgnoreCase("xml"))) //$NON-NLS-1$ fAntStatus.setError(JavadocExportMessages.getString("JavadocSpecificsWizardPage.antfileincorrect.error")); //$NON-NLS-1$ else if (path.toFile().exists()) fAntStatus.setWarning(JavadocExportMessages.getString("JavadocSpecificsWizardPage.antfileoverwrite.warning")); //$NON-NLS-1$ } break; } updateStatus(findMostSevereStatus()); } /* * @see JavadocWizardPage#onFinish() */ protected void finish() { String str= fExtraOptionsText.getText(); if (str.length() > 0) fStore.setAdditionalParams(str); else fStore.setAdditionalParams(""); //$NON-NLS-1$ if (fOverViewText.getEnabled()) fStore.setOverview(fOverViewText.getText()); else fStore.setOverview(""); //$NON-NLS-1$ if (fAntText.getEnabled()) fStore.setAntpath(fWizard.getProject(), fAntText.getText()); else fStore.setAntpath(fWizard.getProject(), ""); //$NON-NLS-1$ } public void setVisible(boolean visible) { super.setVisible(visible); if (visible) { doValidation(OVERVIEWSTATUS); doValidation(ANTSTATUS); } } public void init() { updateStatus(new StatusInfo()); } private IStatus findMostSevereStatus() { return StatusUtil.getMostSevere(new IStatus[] { fAntStatus, fOverviewStatus}); } public boolean generateAnt() { return fAntButton.getSelection(); } public boolean openInBrowser() { return fCheckbrowser.getSelection(); } } //JavadocSpecificsWizardPage
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocStandardWizardPage.java
package org.eclipse.jdt.internal.ui.javadocexport; import java.io.File; import java.net.URL; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.StringTokenizer; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Group; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javadocexport.JavadocWizardPage.ToggleSelectionAdapter; import org.eclipse.jdt.internal.ui.preferences.JavadocConfigurationBlock; import org.eclipse.jdt.internal.ui.util.SWTUtil; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.CheckedListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; public class JavadocStandardWizardPage extends JavadocWizardPage { private JavadocOptionsManager fStore; private JavadocWizard fWizard; private Composite fUpperComposite; private Group fBasicOptionsGroup; private Group fTagsGroup; private Button fTitleButton; private Text fTitleText; protected Text fStyleSheetText; protected FlaggedButton fDeprecatedList; protected FlaggedButton fAuthorCheck; protected FlaggedButton fVersionCheck; protected FlaggedButton fDeprecatedCheck; protected FlaggedButton fHierarchyCheck; protected FlaggedButton fNavigatorCheck; protected FlaggedButton fIndexCheck; protected FlaggedButton fSeperatedIndexCheck; protected FlaggedButton fUse; protected Button fStyleSheetBrowseButton; protected Button fStyleSheetButton; private CheckedListDialogField fListDialogField; private IJavaProject lastProject; private final int STYLESHEETSTATUS= 0; private StatusInfo fStyleSheetStatus; protected ArrayList fButtonsList; private Map fTempLinks; public JavadocStandardWizardPage(String pageName, JavadocOptionsManager store) { super(pageName); setDescription(JavadocExportMessages.getString("JavadcoStandardWizardPage.description")); //$NON-NLS-1$ fStore= store; fButtonsList= new ArrayList(); fStyleSheetStatus= new StatusInfo(); } /* * @see org.eclipse.jface.dialogs.IDialogPage#createControl(org.eclipse.swt.widgets.Composite) */ public void createControl(Composite parent) { initializeDialogUnits(parent); lastProject= null; fWizard= (JavadocWizard)this.getWizard(); fUpperComposite= new Composite(parent, SWT.NONE); fUpperComposite.setLayoutData(createGridData(GridData.FILL_VERTICAL | GridData.FILL_HORIZONTAL, 1, 0)); GridLayout layout= createGridLayout(4); layout.marginHeight= 0; fUpperComposite.setLayout(layout); createBasicOptionsGroup(fUpperComposite); createTagOptionsGroup(fUpperComposite); createListDialgField(fUpperComposite); createStyleSheetGroup(fUpperComposite); setControl(fUpperComposite); } private void createBasicOptionsGroup(Composite composite) { fTitleButton= createButton(composite, SWT.CHECK, JavadocExportMessages.getString("JavadcoStandardWizardPage.titlebutton.label"), createGridData(1)); //$NON-NLS-1$ fTitleText= createText(composite, SWT.SINGLE | SWT.BORDER, null, createGridData(GridData.FILL_HORIZONTAL, 3, 0)); String text= fStore.getTitle(); if(!text.equals("")) { //$NON-NLS-1$ fTitleText.setText(text); fTitleButton.setSelection(true); } else fTitleText.setEnabled(false); fBasicOptionsGroup= new Group(composite, SWT.SHADOW_ETCHED_IN); fBasicOptionsGroup.setLayout(createGridLayout(1)); fBasicOptionsGroup.setLayoutData(createGridData(GridData.FILL_HORIZONTAL | GridData.FILL_VERTICAL, 2, 0)); fBasicOptionsGroup.setText(JavadocExportMessages.getString("JavadcoStandardWizardPage.basicgroup.label")); //$NON-NLS-1$ fUse= new FlaggedButton(fBasicOptionsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.usebutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.USE, true); //$NON-NLS-1$ fHierarchyCheck= new FlaggedButton(fBasicOptionsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.hierarchybutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.NOTREE, false); //$NON-NLS-1$ fNavigatorCheck= new FlaggedButton(fBasicOptionsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.navigartorbutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.NONAVBAR, false); //$NON-NLS-1$ fIndexCheck= new FlaggedButton(fBasicOptionsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.indexbutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.NOINDEX, false); //$NON-NLS-1$ fSeperatedIndexCheck= new FlaggedButton(fBasicOptionsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.seperateindexbutton.label"), createGridData(GridData.GRAB_HORIZONTAL, 1, convertWidthInCharsToPixels(3)), fStore.SPLITINDEX, true); //$NON-NLS-1$ fSeperatedIndexCheck.getButton().setEnabled(fIndexCheck.getButton().getSelection()); fIndexCheck.getButton().addSelectionListener(new ToggleSelectionAdapter(new Control[] { fSeperatedIndexCheck.getButton()}) { public void validate() { } }); fTitleButton.addSelectionListener(new ToggleSelectionAdapter(new Control[] { fTitleText}) { public void validate() { } }); } private void createTagOptionsGroup(Composite composite) { fTagsGroup= new Group(composite, SWT.SHADOW_ETCHED_IN); fTagsGroup.setLayout(createGridLayout(1)); fTagsGroup.setLayoutData(createGridData(GridData.FILL_HORIZONTAL | GridData.FILL_VERTICAL, 2, 0)); fTagsGroup.setText(JavadocExportMessages.getString("JavadcoStandardWizardPage.tagsgroup.label")); //$NON-NLS-1$ fAuthorCheck= new FlaggedButton(fTagsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.authorbutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.AUTHOR, true); //$NON-NLS-1$ fVersionCheck= new FlaggedButton(fTagsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.versionbutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.VERSION, true); //$NON-NLS-1$ fDeprecatedCheck= new FlaggedButton(fTagsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.deprecatedbutton.label"), new GridData(GridData.FILL_HORIZONTAL), fStore.NODEPRECATED, false); //$NON-NLS-1$ fDeprecatedList= new FlaggedButton(fTagsGroup, JavadocExportMessages.getString("JavadcoStandardWizardPage.deprecatedlistbutton.label"), createGridData(GridData.FILL_HORIZONTAL, 1, convertWidthInCharsToPixels(3)), fStore.NODEPRECATEDLIST, false); //$NON-NLS-1$ fDeprecatedList.getButton().setEnabled(fDeprecatedCheck.getButton().getSelection()); fDeprecatedCheck.getButton().addSelectionListener(new ToggleSelectionAdapter(new Control[] { fDeprecatedList.getButton()}) { public void validate() { } }); } //end createTagOptionsGroup private void createStyleSheetGroup(Composite composite) { Composite c= new Composite(composite, SWT.NONE); c.setLayout(createGridLayout(3)); c.setLayoutData(createGridData(GridData.FILL_HORIZONTAL, 4, 0)); ((GridLayout) c.getLayout()).marginWidth= 0; fStyleSheetButton= createButton(c, SWT.CHECK, JavadocExportMessages.getString("JavadcoStandardWizardPage.stylesheettext.label"), createGridData(1)); //$NON-NLS-1$ fStyleSheetText= createText(c, SWT.SINGLE | SWT.BORDER, null, createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //there really aught to be a way to specify this ((GridData) fStyleSheetText.getLayoutData()).widthHint = 200; fStyleSheetBrowseButton= createButton(c, SWT.PUSH, JavadocExportMessages.getString("JavadocStandardWizardPage.stylesheetbrowsebutton.label"), createGridData(GridData.HORIZONTAL_ALIGN_END, 1, 0)); //$NON-NLS-1$ SWTUtil.setButtonDimensionHint(fStyleSheetBrowseButton); String str= fStore.getStyleSheet(); if (str.equals("")) { //$NON-NLS-1$ //default fStyleSheetText.setEnabled(false); fStyleSheetBrowseButton.setEnabled(false); } else { fStyleSheetButton.setSelection(true); fStyleSheetText.setText(str); } //Listeners fStyleSheetButton.addSelectionListener(new ToggleSelectionAdapter(new Control[] { fStyleSheetText, fStyleSheetBrowseButton }) { public void validate() { doValidation(STYLESHEETSTATUS); } }); fStyleSheetText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { doValidation(STYLESHEETSTATUS); } }); fStyleSheetBrowseButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { handleFileBrowseButtonPressed(fStyleSheetText, new String[] { "*.css" }, JavadocExportMessages.getString("JavadocSpecificsWizardPage.stylesheetbrowsedialog.title")); //$NON-NLS-1$ //$NON-NLS-2$ } }); } private void createListDialgField(Composite composite) { Composite c= new Composite(composite, SWT.NONE); c.setLayout(createGridLayout(3)); c.setLayoutData(createGridData(GridData.FILL_HORIZONTAL | GridData.FILL_VERTICAL, 4, 0)); ((GridLayout) c.getLayout()).marginWidth= 0; String[] buttonlabels= new String[] {JavadocExportMessages.getString("JavadcoStandardWizardPage.selectallbutton.label") , JavadocExportMessages.getString("JavadcoStandardWizardPage.clearallbutton.label"), JavadocExportMessages.getString("JavadocStandardWizardPage.configurebutton.label")}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ JavadocLinkDialogLabelProvider labelProvider= new JavadocLinkDialogLabelProvider(); fListDialogField= new CheckedListDialogField(new ListAdapter(), buttonlabels, labelProvider); fListDialogField.setCheckAllButtonIndex(0); fListDialogField.setUncheckAllButtonIndex(1); Label listlabel= createLabel(c, SWT.NONE, JavadocExportMessages.getString("JavadcoStandardWizardPage.referencedclasses.label"), createGridData(GridData.HORIZONTAL_ALIGN_BEGINNING, 4, 0)); //$NON-NLS-1$ fListDialogField.doFillIntoGrid(c, 3); LayoutUtil.setHorizontalGrabbing(fListDialogField.getListControl(null)); fListDialogField.enableButton(2, false); fTempLinks= createTempLinksStore(); UpdateCheckedListGroup(); } private Map createTempLinksStore() { Map temp= new HashMap(); IProject[] projects= fStore.getRoot().getProjects(); for (int i = 0; i < projects.length; i++) { IProject iProject = projects[i]; IJavaProject javaProject= JavaCore.create(iProject); if(javaProject!= null) { String links= fStore.getLinks(javaProject); temp.put(javaProject, links); } } return temp; } private void checkListDialogFieldElements(List referencedClasses) { List checkedElements= new ArrayList(); String hrefs= (String)fTempLinks.get(fWizard.getProject()); URL url= null; if(!hrefs.equals("")) { //$NON-NLS-1$ for (Iterator iterator = referencedClasses.iterator(); iterator.hasNext();) { IJavaElement element = (IJavaElement) iterator.next(); try { url= JavaDocLocations.getJavadocBaseLocation(element); } catch(JavaModelException e) { JavaPlugin.log(e); continue; } StringTokenizer tokenizer = new StringTokenizer(hrefs, ";"); //$NON-NLS-1$ while(tokenizer.hasMoreElements()) { String href = (String)tokenizer.nextElement(); if((url!=null) && href.equals(url.toExternalForm())) { checkedElements.add(element); break; } } } } fListDialogField.setCheckedElements(checkedElements); } private void getElements(List referencedClasses, IJavaProject jproject, List visited) throws JavaModelException { boolean sourceFolderFound= false; //to avoid loops if (visited.contains(jproject)) { return; } visited.add(jproject); IClasspathEntry[] entries= jproject.getResolvedClasspath(true); for (int i= 0; i < entries.length; i++) { IClasspathEntry curr= entries[i]; switch (curr.getEntryKind()) { case IClasspathEntry.CPE_LIBRARY: IPackageFragmentRoot el = jproject.getPackageFragmentRoot(curr.getPath().toOSString()); if(el != null) { if (!referencedClasses.contains(el)) { // URL url= JavaDocLocations.getJavadocBaseLocation(el); // if(url != null) referencedClasses.add(el); } } break; case IClasspathEntry.CPE_PROJECT: IProject reqProject= (IProject)fStore.getRoot().findMember(curr.getPath().lastSegment()); IJavaProject javaProject = JavaCore.create(reqProject); if (javaProject != null && javaProject.getProject().isOpen()) { getElements(referencedClasses, javaProject, visited); } break; case IClasspathEntry.CPE_SOURCE: if (!sourceFolderFound) { // add the output location for the first source folder found IPath outputLocation= jproject.getOutputLocation(); IResource resource= fStore.getRoot().findMember(outputLocation); if (resource != null) { IJavaElement javaElement= JavaCore.create(resource); if((javaElement!= null) && (!javaElement.equals(fWizard.getProject()))) { URL url= JavaDocLocations.getJavadocBaseLocation(javaElement); if(url != null) referencedClasses.add(javaElement); } } sourceFolderFound= true; } break; } } } private void doValidation(int VALIDATE) { File file= null; String ext= null; Path path= null; switch (VALIDATE) { case STYLESHEETSTATUS : fStyleSheetStatus = new StatusInfo(); if (fStyleSheetButton.getSelection()) { path = new Path(fStyleSheetText.getText()); file = new File(fStyleSheetText.getText()); ext = path.getFileExtension(); if ((file == null) || !file.exists()) { fStyleSheetStatus.setError(JavadocExportMessages.getString("JavadcoStandardWizardPage.stylesheetnopath.error")); //$NON-NLS-1$ } else if ((ext == null) || !ext.equalsIgnoreCase("css")) { //$NON-NLS-1$ fStyleSheetStatus.setError(JavadocExportMessages.getString("JavadcoStandardWizardPage.stylesheetnotcss.error")); //$NON-NLS-1$ } } break; } updateStatus(findMostSevereStatus()); } private IStatus findMostSevereStatus() { return StatusUtil.getMostSevere(new IStatus[] { fStyleSheetStatus}); } protected void finish() { if (fTitleButton.getSelection()) fStore.setTitle(fTitleText.getText()); else fStore.setTitle(""); //$NON-NLS-1$ //don't store the buttons if they are not enabled //this will change when there is a single page aimed at the standard doclet if (true) { Object[] buttons = fButtonsList.toArray(); for (int i = 0; i < buttons.length; i++) { FlaggedButton button = (FlaggedButton) buttons[i]; if (button.getButton().getEnabled()) fStore.setBoolean( button.getFlag(), !(button.getButton().getSelection() ^ button.show())); else fStore.setBoolean(button.getFlag(), false == button.show()); } } if (fStyleSheetText.getEnabled()) fStore.setStyleSheet(fStyleSheetText.getText()); else fStore.setStyleSheet(""); //$NON-NLS-1$ String hrefs = makeHrefString(); fStore.setLinks(fWizard.getProject(), hrefs); } protected String makeHrefString() { boolean firstTime= true; StringBuffer buf= new StringBuffer(); List els = fListDialogField.getCheckedElements(); URL url = null; for (Iterator iterator = els.iterator(); iterator.hasNext();) { try { IJavaElement element = (IJavaElement) iterator.next(); url = JavaDocLocations.getJavadocBaseLocation(element); } catch (JavaModelException e) { JavaPlugin.log(e); continue; } if (url != null) { if(firstTime) firstTime= false; else buf.append(";"); //$NON-NLS-1$ buf.append(url.toExternalForm()); } } return buf.toString(); } //get the links public void setVisible(boolean visible) { super.setVisible(visible); if (visible) { doValidation(STYLESHEETSTATUS); //update elements CheckedListDialogField UpdateCheckedListGroup(); } else { String hrefs= makeHrefString(); fTempLinks.put(fWizard.getProject(), hrefs); } } public void UpdateCheckedListGroup() { List referencedClasses = new ArrayList(); List visited = new ArrayList(); try { IJavaProject currProject = fWizard.getProject(); if (lastProject != currProject) { lastProject= currProject; getElements(referencedClasses, currProject, visited); fListDialogField.removeAllElements(); fListDialogField.addElements(referencedClasses); //compare with elements in list with those that are checked. checkListDialogFieldElements(referencedClasses); } } catch (JavaModelException e) { JavaPlugin.log(e); } } public void init() { updateStatus(new StatusInfo()); } protected class FlaggedButton { private Button fButton; private String fFlag; private boolean fShowFlag; public FlaggedButton(Composite composite, String message, GridData gridData, String flag, boolean show) { fFlag= flag; fShowFlag= show; fButton= createButton(composite, SWT.CHECK, message, gridData); fButtonsList.add(this); setButtonSettings(); } public Button getButton() { return fButton; } public String getFlag() { return fFlag; } public boolean show() { return fShowFlag; } private void setButtonSettings() { fButton.setSelection(!(fStore.getBoolean(fFlag) ^ fShowFlag)); } } //end class FlaggesButton private class ListAdapter implements IListAdapter { /** * @see IListAdapter#customButtonPressed(DialogField, int) */ public void customButtonPressed(DialogField field, int index) { if(index == 2) doEditButtonPressed(); } /** * @see IListAdapter#selectionChanged(DialogField) */ public void selectionChanged(DialogField field) { List selection = fListDialogField.getSelectedElements(); if(selection.size() != 1) { fListDialogField.enableButton(2, false); } else { fListDialogField.enableButton(2, true); } } } /** * Method doEditButtonPressed. */ private void doEditButtonPressed() { StructuredSelection selection = (StructuredSelection) fListDialogField.getTableViewer().getSelection(); Iterator iter = selection.iterator(); Object obj = selection.getFirstElement(); if (obj instanceof IAdaptable) { IJavaElement el = (IJavaElement) ((IAdaptable) obj).getAdapter(IJavaElement.class); JavadocPropertyDialog jdialog = new JavadocPropertyDialog(getShell(), el); jdialog.open(); } } private class JavadocPropertyDialog extends StatusDialog implements IStatusChangeListener { private JavadocConfigurationBlock fJavadocConfigurationBlock; private IJavaElement fElement; public JavadocPropertyDialog(Shell parent, IJavaElement selection) { super(parent); setTitle(JavadocExportMessages.getString("JavadocStandardWizardPage.javadocpropertydialog.title")); //$NON-NLS-1$ fJavadocConfigurationBlock= new JavadocConfigurationBlock( selection, parent , this); } protected Control createDialogArea(Composite parent) { Composite composite= (Composite)super.createDialogArea(parent); Control inner= fJavadocConfigurationBlock.createContents(composite); inner.setLayoutData(new GridData(GridData.FILL_BOTH)); return composite; } public void statusChanged(IStatus status) { updateStatus(status); } /** * @see Dialog#okPressed() */ protected void okPressed() { fJavadocConfigurationBlock.performOk(); super.okPressed(); fListDialogField.refresh(); } } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocTreeWizardPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.io.File; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import java.util.Set; import java.util.StringTokenizer; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.wizard.IWizardPage; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.launching.JavaRuntime; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.jarpackager.CheckboxTreeAndListGroup; import org.eclipse.jdt.internal.ui.javadocexport.JavadocWizardPage.EnableSelectionAdapter; import org.eclipse.jdt.internal.ui.preferences.JavadocPreferencePage; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class JavadocTreeWizardPage extends JavadocWizardPage { private JavadocProjectContentProvider fProjectContentProvider; private JavaElementLabelProvider fProjectLabelProvider; private CheckboxTreeAndListGroup fInputGroup; protected IWorkspaceRoot fRoot; protected String fWorkspace; private final String DOCUMENT_DIRECTORY= "doc"; //$NON-NLS-1$ private File fTempFile; //private JavadocTreeViewerFilter fFilter; protected Text fDestinationText; protected Text fDocletText; protected Text fDocletTypeText; protected Button fStandardButton; protected Button fDestinationBrowserButton; protected Button fCustomButton; protected Button fPrivateVisibility; protected Button fProtectedVisibility; protected Button fPackageVisibility; protected Button fPublicVisibility; private Label fDocletLabel; private Label fDocletTypeLabel; private Label fDestinationLabel; private String fDialogSectionName; protected String fVisibilitySelection; protected boolean docletselected; private JavadocOptionsManager fStore; private JavadocWizard fWizard; protected StatusInfo fDestinationStatus; protected StatusInfo fDocletStatus; protected StatusInfo fTreeStatus; protected StatusInfo fPreferenceStatus; protected StatusInfo fWizardStatus; private final int PREFERENCESTATUS= 0; private final int CUSTOMSTATUS= 1; private final int STANDARDSTATUS= 2; private final int TREESTATUS= 3; /** * Constructor for JavadocTreeWizardPage. * @param pageName */ protected JavadocTreeWizardPage(String pageName, JavadocOptionsManager store) { super(pageName); setDescription(JavadocExportMessages.getString("JavadocTreeWizardPage.javadoctreewizardpage.description")); //$NON-NLS-1$ fStore= store; // Status variables fDestinationStatus= new StatusInfo(); fDocletStatus= new StatusInfo(); fTreeStatus= new StatusInfo(); fPreferenceStatus= new StatusInfo(); fWizardStatus= store.getWizardStatus(); } /* * @see IDialogPage#createControl(Composite) */ public void createControl(Composite parent) { initializeDialogUnits(parent); fWizard = (JavadocWizard)this.getWizard(); Composite composite= new Composite(parent, SWT.NONE); GridLayout compositeGridLayout= new GridLayout(); composite.setLayoutData(createGridData(GridData.FILL_BOTH, 0, 0)); compositeGridLayout.numColumns= 6; composite.setLayout(compositeGridLayout); createInputGroup(composite); createVisibilitySet(composite); createOptionsSet(composite); setControl(composite); } protected void createInputGroup(Composite composite) { Label treeLabel= createLabel(composite, SWT.NONE, JavadocExportMessages.getString("JavadocTreeWizardPage.checkboxtreeandlistgroup.label"), createGridData(6)); //$NON-NLS-1$ Composite c= new Composite(composite, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 1; layout.makeColumnsEqualWidth= true; c.setLayout(layout); c.setLayoutData(createGridData(GridData.FILL_BOTH, 6, 0)); ITreeContentProvider treeContentProvider= new JavadocProjectContentProvider(); ITreeContentProvider listContentProvider= new JavadocMemberContentProvider(); fInputGroup= new CheckboxTreeAndListGroup( c, fStore.getRoot(), treeContentProvider, new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT), listContentProvider, new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT), SWT.NONE, convertWidthInCharsToPixels(60), convertHeightInCharsToPixels(10)); fInputGroup.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent e) { doValidation(TREESTATUS); IJavaElement el= null; Object[] set= fInputGroup.getAllCheckedTreeItems().toArray(); for (int i = 0; i < set.length; i++) { IJavaElement javaElement = (IJavaElement)set[i]; if(javaElement instanceof IJavaModel) continue; else { el=(IJavaElement) set[i]; break; } } if(el != null) fWizard.setProject(el.getJavaProject()); } }); //fFilter= new JavadocTreeViewerFilter(); //fInputGroup.getTableViewer().addFilter(fFilter); try { setTreeChecked(fStore.getSelectedElements(), fStore.getJavaProject()); } catch(JavaModelException e) { JavaPlugin.logErrorMessage(e.getMessage()); } fInputGroup.aboutToOpen(); } private void createVisibilitySet(Composite composite) { GridLayout visibilityLayout= createGridLayout(4); visibilityLayout.marginHeight= 0; visibilityLayout.marginWidth= 0; Composite visibilityGroup= new Composite(composite, SWT.NONE); visibilityGroup.setLayoutData(createGridData(GridData.FILL_HORIZONTAL, 6, 0)); visibilityGroup.setLayout(visibilityLayout); Label visibilityLabel= createLabel(visibilityGroup, SWT.NONE, JavadocExportMessages.getString("JavadocTreeWizardPage.visibilitygroup.label"), createGridData(GridData.FILL_HORIZONTAL, 4, 0)); //$NON-NLS-1$ fPrivateVisibility= createButton(visibilityGroup, SWT.RADIO, JavadocExportMessages.getString("JavadocTreeWizardPage.privatebutton.label"), createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //$NON-NLS-1$ fPackageVisibility= createButton(visibilityGroup, SWT.RADIO, JavadocExportMessages.getString("JavadocTreeWizardPage.packagebutton.label"), createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //$NON-NLS-1$ fProtectedVisibility= createButton(visibilityGroup, SWT.RADIO, JavadocExportMessages.getString("JavadocTreeWizardPage.protectedbutton.label"), createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //$NON-NLS-1$ fPublicVisibility= createButton(visibilityGroup, SWT.RADIO, JavadocExportMessages.getString("JavadocTreeWizardPage.publicbutton.label"), createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //$NON-NLS-1$ fPrivateVisibility.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { if (((Button) e.widget).getSelection()) { fVisibilitySelection = fStore.PRIVATE; //fFilter.setVisibility(fVisibilitySelection); //fInputGroup.refresh(); } } }); fPackageVisibility.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { if (((Button) e.widget).getSelection()) { fVisibilitySelection = fStore.PACKAGE; //fFilter.setVisibility(fVisibilitySelection); //fInputGroup.refresh(); } } }); fProtectedVisibility.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { if (((Button) e.widget).getSelection()) { fVisibilitySelection = fStore.PROTECTED; //fFilter.setVisibility(fVisibilitySelection); //fInputGroup.refresh(); } } }); fPublicVisibility.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { if (((Button) e.widget).getSelection()) { fVisibilitySelection = fStore.PUBLIC; //fFilter.setVisibility(fVisibilitySelection); //fInputGroup.refresh(); } } }); setVisibilitySettings(); } protected void setVisibilitySettings() { fVisibilitySelection = fStore.getAccess(); fPrivateVisibility.setSelection( fVisibilitySelection.equals(fStore.PRIVATE)); fProtectedVisibility.setSelection( fVisibilitySelection.equals(fStore.PROTECTED)); fPackageVisibility.setSelection( fVisibilitySelection.equals(fStore.PACKAGE)); fPublicVisibility.setSelection( fVisibilitySelection.equals(fStore.PUBLIC)); //fFilter.setVisibility(fVisibilitySelection); } private void createOptionsSet(Composite composite) { GridLayout optionSetLayout= createGridLayout(3); optionSetLayout.marginHeight= 0; optionSetLayout.marginWidth= 0; Composite optionSetGroup= new Composite(composite, SWT.NONE); optionSetGroup.setLayoutData(createGridData(GridData.FILL_BOTH, 6, 0)); optionSetGroup.setLayout(optionSetLayout); fStandardButton= createButton(optionSetGroup, SWT.RADIO, JavadocExportMessages.getString("JavadocTreeWizardPage.standarddocletbutton.label"), createGridData(GridData.HORIZONTAL_ALIGN_FILL, 3, 0)); //$NON-NLS-1$ GridData gd= new GridData(); gd.horizontalSpan= 1; fDestinationLabel= createLabel(optionSetGroup, SWT.NONE, JavadocExportMessages.getString("JavadocTreeWizardPage.destinationfield.label"), createGridData(GridData.HORIZONTAL_ALIGN_BEGINNING, 1, convertWidthInCharsToPixels(3))); //$NON-NLS-1$ fDestinationText= createText(optionSetGroup, SWT.SINGLE | SWT.BORDER, null, createGridData(GridData.FILL_HORIZONTAL, 1, 0)); //there really aught to be a way to specify this ((GridData) fDestinationText.getLayoutData()).widthHint = 200; fDestinationText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { doValidation(STANDARDSTATUS); } }); fDestinationBrowserButton= createButton(optionSetGroup, SWT.PUSH, JavadocExportMessages.getString("JavadocTreeWizardPage.destinationbrowse.label"), createGridData(GridData.HORIZONTAL_ALIGN_FILL, 1, 0)); //$NON-NLS-1$ SWTUtil.setButtonDimensionHint(fDestinationBrowserButton); //Option to use custom doclet fCustomButton= createButton(optionSetGroup, SWT.RADIO, JavadocExportMessages.getString("JavadocTreeWizardPage.customdocletbutton.label"), createGridData(3)); //$NON-NLS-1$ //For Entering location of custom doclet fDocletTypeLabel= createLabel(optionSetGroup, SWT.NONE, JavadocExportMessages.getString("JavadocTreeWizardPage.docletnamefield.label"), createGridData(GridData.HORIZONTAL_ALIGN_FILL, 1, convertWidthInCharsToPixels(3))); //$NON-NLS-1$ fDocletTypeText= createText(optionSetGroup, SWT.SINGLE | SWT.BORDER, null, createGridData(GridData.HORIZONTAL_ALIGN_FILL, 2, 0)); fDocletTypeText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { doValidation(CUSTOMSTATUS); } }); fDocletLabel= createLabel(optionSetGroup, SWT.NONE, JavadocExportMessages.getString("JavadocTreeWizardPage.docletpathfield.label"), createGridData(GridData.HORIZONTAL_ALIGN_FILL, 1, convertWidthInCharsToPixels(3))); //$NON-NLS-1$ fDocletText= createText(optionSetGroup, SWT.SINGLE | SWT.BORDER, null, createGridData(GridData.HORIZONTAL_ALIGN_FILL, 2, 0)); fDocletText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { doValidation(CUSTOMSTATUS); } }); //Add Listeners fCustomButton.addSelectionListener( new EnableSelectionAdapter(new Control[] { fDocletLabel, fDocletText, fDocletTypeLabel, fDocletTypeText }, new Control[] { fDestinationLabel, fDestinationText, fDestinationBrowserButton })); fCustomButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { doValidation(CUSTOMSTATUS); } }); fStandardButton.addSelectionListener( new EnableSelectionAdapter(new Control[] { fDestinationLabel, fDestinationText, fDestinationBrowserButton }, new Control[] { fDocletLabel, fDocletText, fDocletTypeLabel, fDocletTypeText })); fStandardButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { doValidation(STANDARDSTATUS); } }); fDestinationBrowserButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { String text= handleFolderBrowseButtonPressed( fDestinationText.getText(), fDestinationText.getShell(), JavadocExportMessages.getString("JavadocTreeWizardPage.destinationbrowsedialog.title"), //$NON-NLS-1$ JavadocExportMessages.getString("JavadocTreeWizardPage.destinationbrowsedialog.label")); //$NON-NLS-1$ fDestinationText.setText(text); } }); setOptionSetSettings(); } public boolean getCustom(){ return fCustomButton.getSelection(); } private String getDestinationText() { Object[] els= fInputGroup.getAllCheckedTreeItems().toArray(); try { for (int i= 0; i < els.length; i++) { if (els[i] instanceof IJavaProject) { IJavaProject iJavaProject= (IJavaProject) els[i]; return iJavaProject.getUnderlyingResource().getLocation().addTrailingSeparator().append(DOCUMENT_DIRECTORY).toOSString(); } } } catch (JavaModelException e) { return ""; //$NON-NLS-1$ } catch (NullPointerException e) { return ""; //$NON-NLS-1$ } return ""; //$NON-NLS-1$ } private void setOptionSetSettings() { if(!fStore.fromStandard()) { fCustomButton.setSelection(true); fDocletText.setText(fStore.getDocletPath()); fDocletTypeText.setText(fStore.getDocletName()); fDestinationText.setText(fStore.getDestination(fWizard.getProject())); fDestinationText.setEnabled(false); fDestinationBrowserButton.setEnabled(false); fDestinationLabel.setEnabled(false); } else { fStandardButton.setSelection(true); fDestinationText.setText(fStore.getDestination(fWizard.getProject())); fDocletText.setText(fStore.getDocletPath()); fDocletTypeText.setText(fStore.getDocletName()); fDocletText.setEnabled(false); fDocletLabel.setEnabled(false); fDocletTypeText.setEnabled(false); fDocletTypeLabel.setEnabled(false); } } protected void setTreeChecked( IJavaElement[] sourceElements, IJavaProject project) throws JavaModelException { if (project == null) return; if (sourceElements.length < 1) fInputGroup.initialCheckTreeItem(project); else { for (int i = 0; i < sourceElements.length; i++) { IJavaElement curr = sourceElements[i]; if (curr instanceof ICompilationUnit) { fInputGroup.initialCheckListItem(curr); } else if (curr instanceof IPackageFragment) { fInputGroup.initialCheckTreeItem(curr); } else if(curr instanceof IJavaProject) { //if the only selected element is a project if(sourceElements.length==1) fInputGroup.initialCheckTreeItem(curr); } else if (curr instanceof IPackageFragmentRoot) { IPackageFragmentRoot root= (IPackageFragmentRoot)curr; if(!root.isArchive()) fInputGroup.initialCheckTreeItem(curr); } } } } private String getSourcePath(IJavaProject project) { StringBuffer buf= new StringBuffer(); try { IPackageFragmentRoot[] roots= project.getPackageFragmentRoots(); int nAdded= 0; for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot curr= roots[i]; if (curr.getKind() == IPackageFragmentRoot.K_SOURCE) { if (nAdded != 0) { buf.append(File.pathSeparatorChar); } buf.append(curr.getUnderlyingResource().getLocation().toOSString()); nAdded++; } } } catch (JavaModelException e) { JavaPlugin.log(e); } return buf.toString(); } private String getClassPath(IJavaProject javaProject) { StringBuffer buf= new StringBuffer(); try { IPath outputLocation= javaProject.getProject().getLocation().append(javaProject.getOutputLocation()); String[] classPath= JavaRuntime.computeDefaultRuntimeClassPath(javaProject); int nAdded= 0; for (int i= 0; i < classPath.length; i++) { String curr= classPath[i]; if (outputLocation.equals(new Path(curr))) { continue; } if (nAdded != 0) { buf.append(File.pathSeparatorChar); } buf.append(curr); nAdded++; } } catch (CoreException e) { JavaPlugin.log(e); } return buf.toString(); } //Returns the path were the doclet file will be created private IJavaElement[] getSourceElements() { ArrayList res= new ArrayList(); Iterator checkedElements= fInputGroup.getAllCheckedListItems(); while (checkedElements.hasNext()) { Object element= checkedElements.next(); if (element instanceof ICompilationUnit) { ICompilationUnit unit= (ICompilationUnit) element; IPackageFragment pack= (IPackageFragment) unit.getParent(); if (fInputGroup.isTreeItemGreyChecked(pack) || pack.isDefaultPackage()) { res.add(unit); } } } Iterator checkedTreeElements= fInputGroup.getAllCheckedTreeItems().iterator(); while (checkedTreeElements.hasNext()) { Object element= checkedTreeElements.next(); if (element instanceof IPackageFragment) { IPackageFragment pack= (IPackageFragment) element; if (!fInputGroup.isTreeItemGreyChecked(pack) && !pack.isDefaultPackage()) { res.add(pack); } } } return (IJavaElement[]) res.toArray(new IJavaElement[res.size()]); } protected void finish() { //I have made the assumption that preserve settings will not be //called on an ANT file, which is evident... if (fCustomButton.getSelection()) { fStore.setDocletName(fDocletTypeText.getText()); fStore.setDocletPath(fDocletText.getText()); fStore.setFromStandard(false); } if(fStandardButton.getSelection()){ fStore.setFromStandard(true); fStore.setDestination(fWizard.getProject(), fDestinationText.getText()); } IJavaProject project= getCurrentProject(); fStore.setProject(project); fStore.setSourcepath(getSourcePath(project)); fStore.setClasspath(getClassPath(project)); fStore.setAccess(fVisibilitySelection); fStore.setSourceElements(getSourceElements()); } private void doValidation(int validate) { switch (validate) { case PREFERENCESTATUS : fPreferenceStatus = new StatusInfo(); fDocletStatus= new StatusInfo(); if (JavadocPreferencePage.getJavaDocCommand().length() == 0) { fPreferenceStatus.setError( JavadocExportMessages.getString("JavadocTreeWizardPage.javadoccommand.error")); //$NON-NLS-1$ } updateStatus(findMostSevereStatus()); break; case CUSTOMSTATUS : if (fCustomButton.getSelection()) { fDestinationStatus = new StatusInfo(); fDocletStatus = new StatusInfo(); String doclet = fDocletTypeText.getText(); String docletPath = fDocletText.getText(); if (doclet.length() == 0) { fDocletStatus.setError(JavadocExportMessages.getString("JavadocTreeWizardPage.nodocletname.error")); //$NON-NLS-1$ } else if ( JavaConventions.validateJavaTypeName(doclet).matches(IStatus.ERROR)) { fDocletStatus.setError(JavadocExportMessages.getString("JavadocTreeWizardPage.invaliddocletname.error")); //$NON-NLS-1$ } else if ((docletPath.length() == 0) || !validDocletPath(docletPath)) { fDocletStatus.setError(JavadocExportMessages.getString("JavadocTreeWizardPage.invaliddocletpath.error")); //$NON-NLS-1$ } updateStatus(findMostSevereStatus()); } break; case STANDARDSTATUS : if (fStandardButton.getSelection()) { fDestinationStatus = new StatusInfo(); fDocletStatus= new StatusInfo(); IPath path = new Path(fDestinationText.getText()); if (Path.ROOT.equals(path) || Path.EMPTY.equals(path)) { fDestinationStatus.setError(JavadocExportMessages.getString("JavadocTreeWizardPage.nodestination.error")); //$NON-NLS-1$ } File file = new File(path.toOSString()); if (!path.isValidPath(path.toOSString()) || file.isFile()) { fDestinationStatus.setError(JavadocExportMessages.getString("JavadocTreeWizardPage.invaliddestination.error")); //$NON-NLS-1$ } updateStatus(findMostSevereStatus()); } break; case TREESTATUS : fTreeStatus = new StatusInfo(); boolean empty = fInputGroup.getAllCheckedTreeItems().isEmpty(); if (empty) fTreeStatus.setError(JavadocExportMessages.getString("JavadocTreeWizardPage.invalidtreeselection.error")); //$NON-NLS-1$ else { int projCount = 0; Object[] items = fInputGroup.getAllCheckedTreeItems().toArray(); for (int i = 0; i < items.length; i++) { IJavaElement element = (IJavaElement) items[i]; if (element instanceof IJavaProject) { projCount++; if (projCount > 1) fTreeStatus.setError( JavadocExportMessages.getString("JavadocTreeWizardPage.multipleprojectselected.error")); //$NON-NLS-1$ } } } updateStatus(findMostSevereStatus()); break; } //end switch } /** * looks at the currently selected projects and returns the current project * returns null if more than one project is checked */ private IJavaProject getCurrentProject() { Object[] items= fInputGroup.getAllCheckedTreeItems().toArray(); IJavaProject project= null; for (int i= 0; i < items.length; i++) { if (items[i] instanceof IJavaProject) { if (project != null) { return null; } project= (IJavaProject)items[i]; } } return project; } private boolean validDocletPath(String docletPath) { StringTokenizer tokens= new StringTokenizer(docletPath, ";"); //$NON-NLS-1$ while (tokens.hasMoreTokens()) { File file= new File(tokens.nextToken()); if (!file.exists()) return false; } return true; } /** * Finds the most severe error (if there is one) */ private IStatus findMostSevereStatus() { return StatusUtil.getMostSevere(new IStatus[] {fPreferenceStatus, fDestinationStatus, fDocletStatus, fTreeStatus, fWizardStatus }); } public void init() { updateStatus(new StatusInfo()); } public void setVisible(boolean visible) { super.setVisible(visible); if (visible) { doValidation(STANDARDSTATUS); doValidation(CUSTOMSTATUS); doValidation(TREESTATUS); doValidation(PREFERENCESTATUS); } } public IPath getDestination() { if (fStandardButton.getSelection()) { return new Path(fDestinationText.getText()); } return null; } public IWizardPage getNextPage() { return super.getNextPage(); } } //end Class
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocWizard.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.io.IOException; import java.lang.reflect.InvocationTargetException; import java.net.MalformedURLException; import java.net.URL; import java.text.MessageFormat; import java.util.ArrayList; import java.util.Arrays; import java.util.HashSet; import java.util.List; import java.util.Set; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.IWorkspaceDescription; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.debug.core.DebugEvent; import org.eclipse.debug.core.DebugPlugin; import org.eclipse.debug.core.IDebugEventSetListener; import org.eclipse.debug.core.ILaunch; import org.eclipse.debug.core.ILaunchConfigurationType; import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy; import org.eclipse.debug.core.ILaunchManager; import org.eclipse.debug.core.Launch; import org.eclipse.debug.core.model.IProcess; import org.eclipse.debug.ui.IDebugUIConstants; import org.eclipse.swt.widgets.Display; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.wizard.IWizardPage; import org.eclipse.jface.wizard.Wizard; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IExportWizard; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IWorkbench; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.launching.IJavaLaunchConfigurationConstants; import org.eclipse.jdt.launching.JavaRuntime; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.OpenBrowserUtil; import org.eclipse.jdt.internal.ui.jarpackager.ConfirmSaveModifiedResourcesDialog; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; public class JavadocWizard extends Wizard implements IExportWizard { private JavadocTreeWizardPage fJTWPage; private JavadocSpecificsWizardPage fJSWPage; private JavadocStandardWizardPage fJSpWPage; private IPath fDestination; private boolean fWriteCustom; private boolean fFromAnt; private boolean fOpenInBrowser; protected final String TreePageDesc= "JavadocTreePage"; //$NON-NLS-1$ protected final String SpecificsPageDesc= "JavadocSpecificsPage"; //$NON-NLS-1$ protected final String StandardPageDesc= "JavadocStandardPage"; //$NON-NLS-1$ private JavadocOptionsManager fStore; private IWorkspaceRoot fRoot; private IJavaProject fSelectedProject; private IFile fXmlJavadocFile; //private ILaunchConfiguration fConfig; public JavadocWizard() { this(null); } public JavadocWizard(IFile xmlJavadocFile) { super(); setDefaultPageImageDescriptor(JavaPluginImages.DESC_WIZBAN_EXPORT_JAVADOC); setWindowTitle(JavadocExportMessages.getString("JavadocWizard.javadocwizard.title")); //$NON-NLS-1$ setDialogSettings(JavaPlugin.getDefault().getDialogSettings()); fRoot= ResourcesPlugin.getWorkspace().getRoot(); fXmlJavadocFile= xmlJavadocFile; fWriteCustom= false; fFromAnt= (xmlJavadocFile != null); fSelectedProject= null; } /* * @see IWizard#performFinish() */ public boolean performFinish() { //writes the new settings to store fJTWPage.finish(); if(!fJTWPage.getCustom()) fJSpWPage.finish(); fJSWPage.finish(); if (!checkPreconditions(fStore.getSourceElements())) { return false; } fDestination= new Path(fStore.getDestination(fStore.getJavaProject())); fDestination.toFile().mkdirs(); if (fJSWPage.openInBrowser()) { this.fOpenInBrowser= true; } try { URL currURL= JavaDocLocations.getProjectJavadocLocation(fStore.getJavaProject()); URL newURL= fDestination.toFile().toURL(); if (fStore.fromStandard() && ((currURL == null) || !(currURL.equals(newURL)))) { String message= JavadocExportMessages.getFormattedString("JavadocWizard.updatejavadoclocation.message", new String[] { fStore.getJavaProject().getElementName(), fDestination.toOSString() }); //$NON-NLS-1$ if (MessageDialog.openQuestion(getShell(), JavadocExportMessages.getString("JavadocWizard.updatejavadocdialog.label"), message)) { //$NON-NLS-1$ JavaDocLocations.setProjectJavadocLocation(fStore.getJavaProject(), newURL); } } } catch (MalformedURLException e) { JavaPlugin.log(e); } if (fJSWPage.generateAnt()) { fStore.createXML(); refresh(new Path(fStore.getAntpath(fStore.getJavaProject()))); } if (!fFromAnt) { getDialogSettings().addSection(fStore.createDialogSettings()); } try { String[] args= fStore.createArgumentArray(); // //@test // for (int i = 0; i < args.length; i++) { // String string = args[i]; // System.out.print(string+" "); // } // if (!executeJavadocGeneration(args)) return false; } catch(CoreException e) { JavaPlugin.log(e); return false; } return true; } private boolean executeJavadocGeneration(String[] args) { Process process= null; try { process= Runtime.getRuntime().exec(args); if (process != null) { // contruct a formatted command line for the process properties StringBuffer buf= new StringBuffer(); for (int i= 0; i < args.length; i++) { buf.append(args[i]); buf.append(' '); } IDebugEventSetListener listener= new JavadocDebugEventListener(); DebugPlugin.getDefault().addDebugEventListener(listener); ILaunchConfigurationWorkingCopy wc= null; try { ILaunchConfigurationType lcType= DebugPlugin.getDefault().getLaunchManager().getLaunchConfigurationType(IJavaLaunchConfigurationConstants.ID_JAVA_APPLICATION); String name= JavadocExportMessages.getString("JavadocWizard.launchconfig.name"); //$NON-NLS-1$ wc= lcType.newInstance(null, name); wc.setAttribute(IDebugUIConstants.ATTR_TARGET_RUN_PERSPECTIVE, (String) null); wc.setAttribute(IDebugUIConstants.ATTR_PRIVATE, true); ILaunch newLaunch= new Launch(wc, ILaunchManager.RUN_MODE, null); IProcess iprocess= DebugPlugin.newProcess(newLaunch, process, JavadocExportMessages.getString("JavadocWizard.javadocprocess.label")); //$NON-NLS-1$ iprocess.setAttribute(JavaRuntime.ATTR_CMDLINE, buf.toString()); DebugPlugin.getDefault().getLaunchManager().addLaunch(newLaunch); } catch (CoreException e) { JavaPlugin.log(e); } return true; } } catch (IOException e) { JavaPlugin.log(e); return false; } return false; } private boolean checkPreconditions(IJavaElement[] elements) { ArrayList resources= new ArrayList(); for (int i= 0; i < elements.length; i++) { try { if (elements[i] instanceof ICompilationUnit) { resources.add(elements[i].getCorrespondingResource()); } } catch(JavaModelException e) { JavaPlugin.log(e); } } //message could be null IFile[] unSavedFiles = getUnsavedFiles(resources); return saveModifiedResourcesIfUserConfirms(unSavedFiles); } /** * Returns the files which are not saved and which are * part of the files being exported. * * @return an array of unsaved files */ private IFile[] getUnsavedFiles(List resources) { IEditorPart[] dirtyEditors = JavaPlugin.getDirtyEditors(); Set unsavedFiles = new HashSet(dirtyEditors.length); if (dirtyEditors.length > 0) { for (int i = 0; i < dirtyEditors.length; i++) { if (dirtyEditors[i].getEditorInput() instanceof IFileEditorInput) { IFile dirtyFile = ((IFileEditorInput) dirtyEditors[i].getEditorInput()).getFile(); if (resources.contains(dirtyFile)) { unsavedFiles.add(dirtyFile); } } } } return (IFile[]) unsavedFiles.toArray(new IFile[unsavedFiles.size()]); } /** * Asks to confirm to save the modified resources * and save them if OK is pressed. Must be run in the display thread. * * @return true if user pressed OK and save was successful. */ private boolean saveModifiedResourcesIfUserConfirms(IFile[] dirtyFiles) { if (confirmSaveModifiedResources(dirtyFiles)) { try { if (saveModifiedResources(dirtyFiles)) return true; } catch(CoreException e) { ExceptionHandler.handle(e, getShell(), JavadocExportMessages.getString("JavadocWizard.saveresourcedialogCE.title"), JavadocExportMessages.getString("JavadocWizard.saveresourcedialogCE.message")); //$NON-NLS-1$ //$NON-NLS-2$ } catch(InvocationTargetException e) { ExceptionHandler.handle(e, getShell(), JavadocExportMessages.getString("JavadocWizard.saveresourcedialogITE.title"), JavadocExportMessages.getString("JavadocWizard.saveresourcedialogITE.message")); //$NON-NLS-1$ //$NON-NLS-2$ } } return false; } /** * Asks the user to confirm to save the modified resources. * * @return true if user pressed OK. */ private boolean confirmSaveModifiedResources(IFile[] dirtyFiles) { if (dirtyFiles == null || dirtyFiles.length == 0) return true; // Get display for further UI operations Display display= getShell().getDisplay(); if (display == null || display.isDisposed()) return false; // Ask user to confirm saving of all files final ConfirmSaveModifiedResourcesDialog dlg= new ConfirmSaveModifiedResourcesDialog(getShell(), dirtyFiles); final int[] intResult= new int[1]; Runnable runnable= new Runnable() { public void run() { intResult[0]= dlg.open(); } }; display.syncExec(runnable); return intResult[0] == IDialogConstants.OK_ID; } /** * Save all of the editors in the workbench. Must be run in the display thread. * * @return true if successful. */ private boolean saveModifiedResources(final IFile[] dirtyFiles) throws CoreException, InvocationTargetException { IWorkspace workspace= ResourcesPlugin.getWorkspace(); IWorkspaceDescription description= workspace.getDescription(); boolean autoBuild= description.isAutoBuilding(); description.setAutoBuilding(false); try { workspace.setDescription(description); // This save operation can not be canceled. try { new ProgressMonitorDialog(getShell()).run(false, false, createSaveModifiedResourcesRunnable(dirtyFiles)); } finally { description.setAutoBuilding(autoBuild); workspace.setDescription(description); } } catch (InterruptedException ex) { return false; } return true; } private IRunnableWithProgress createSaveModifiedResourcesRunnable(final IFile[] dirtyFiles) { return new IRunnableWithProgress() { public void run(final IProgressMonitor pm) { IEditorPart[] editorsToSave= JavaPlugin.getDirtyEditors(); String name= JavadocExportMessages.getString("JavadocWizard.savetask.name"); //$NON-NLS-1$ pm.beginTask(name, editorsToSave.length); try { List dirtyFilesList= Arrays.asList(dirtyFiles); for (int i= 0; i < editorsToSave.length; i++) { if (editorsToSave[i].getEditorInput() instanceof IFileEditorInput) { IFile dirtyFile= ((IFileEditorInput)editorsToSave[i].getEditorInput()).getFile(); if (dirtyFilesList.contains((dirtyFile))) editorsToSave[i].doSave(new SubProgressMonitor(pm, 1)); } pm.worked(1); } } finally { pm.done(); } } }; } /* * @see IWizard#addPages() */ public void addPages() { fJTWPage= new JavadocTreeWizardPage(TreePageDesc, fStore); fJSWPage= new JavadocSpecificsWizardPage(SpecificsPageDesc, fStore); fJSpWPage= new JavadocStandardWizardPage(StandardPageDesc, fStore); super.addPage(fJTWPage); super.addPage(fJSpWPage); super.addPage(fJSWPage); fJTWPage.init(); fJSpWPage.init(); fJSWPage.init(); this.fSelectedProject= fStore.getJavaProject(); } public void init(IWorkbench workbench, IStructuredSelection structuredSelection) { IDialogSettings settings= getDialogSettings().getSection("javadoc"); //$NON-NLS-1$ fStore= new JavadocOptionsManager(fXmlJavadocFile, settings, structuredSelection); } private void refresh(IPath path) { if (fRoot.getContainerForLocation(path) != null) { try { fRoot.refreshLocal(fJTWPage.fRoot.DEPTH_INFINITE, null); } catch (CoreException e) { JavaPlugin.log(e); } } } private void spawnInBrowser() { if (fOpenInBrowser) { try { IPath indexFile= fDestination.append("index.html"); //$NON-NLS-1$ URL url= indexFile.toFile().toURL(); OpenBrowserUtil.open(url, getShell(), getWindowTitle()); } catch (MalformedURLException e) { JavaPlugin.log(e); } } } private class JavadocDebugEventListener implements IDebugEventSetListener { public void handleDebugEvents(DebugEvent[] events) { for (int i= 0; i < events.length; i++) { if (events[i].getKind() == DebugEvent.TERMINATE) { try { if (!fWriteCustom) { refresh(fDestination); //If destination of javadoc is in workspace then refresh workspace spawnInBrowser(); } } finally { DebugPlugin.getDefault().removeDebugEventListener(this); } return; } } } } public IWizardPage getNextPage(IWizardPage page) { if(page instanceof JavadocTreeWizardPage) { if(!fJTWPage.getCustom()) { return fJSpWPage; } return fJSWPage; } else if (page instanceof JavadocSpecificsWizardPage) { return null; } else if (page instanceof JavadocStandardWizardPage) return fJSWPage; else return null; } public IWizardPage getPreviousPage(IWizardPage page) { if(page instanceof JavadocSpecificsWizardPage) { if(!fJTWPage.getCustom()) { return fJSpWPage; } return fJSWPage; } else if (page instanceof JavadocTreeWizardPage) { return null; } else if (page instanceof JavadocStandardWizardPage) return fJTWPage; else return null; } protected void setProject(IJavaProject project) { this.fSelectedProject= project; } protected IJavaProject getProject() { return this.fSelectedProject; } }
17,177
Bug 17177 Javadoc wizard doesn't remember checked options between 2 runs
Build 20020521 The Javadoc wizard doesn't remember that I checked 'Open generated index file in browser' between 2 runs. As a result, I cannot just press Finish, but I need to press Next twice, then check the option again, then press Finish.
verified fixed
39d0fdf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-29T17:34:14Z
2002-05-23T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocWriter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.javadocexport; import java.io.BufferedOutputStream; import java.io.IOException; import java.io.OutputStream; import java.net.URL; import java.util.List; import java.util.StringTokenizer; import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; import org.apache.xml.serialize.Method; import org.apache.xml.serialize.OutputFormat; import org.apache.xml.serialize.Serializer; import org.apache.xml.serialize.SerializerFactory; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.jface.util.Assert; import org.w3c.dom.DOMException; import org.w3c.dom.Document; import org.w3c.dom.Element; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.JavaPlugin; public class JavadocWriter { protected OutputStream fOutputStream; private IJavaProject fProject; /** * Create a JavadocWriter on the given output stream. * It is the client's responsibility to close the output stream. */ public JavadocWriter(OutputStream outputStream) { Assert.isNotNull(outputStream); fOutputStream= new BufferedOutputStream(outputStream); } /** * Writes a XML representation of the JAR specification * to to the underlying stream. * * @exception IOException if writing to the underlying stream fails */ public void writeXML(JavadocOptionsManager store) throws IOException, CoreException { DocumentBuilder docBuilder= null; DocumentBuilderFactory factory= DocumentBuilderFactory.newInstance(); factory.setValidating(false); try { docBuilder= factory.newDocumentBuilder(); } catch (ParserConfigurationException ex) { throw new IOException(); } Document document= docBuilder.newDocument(); // Create the document Element project= document.createElement("project"); //$NON-NLS-1$ document.appendChild(project); try { fProject= store.getJavaProject(); if(fProject!=null) { project.setAttribute("name", fProject.getCorrespondingResource().getName()); //$NON-NLS-1$ } else project.setAttribute("name", "project_name"); //$NON-NLS-1$ //$NON-NLS-2$ } catch(DOMException e) { project.setAttribute("name", "project_name"); //$NON-NLS-1$ //$NON-NLS-2$ } catch(JavaModelException e) { project.setAttribute("name", "project_name"); //$NON-NLS-1$ //$NON-NLS-2$ } project.setAttribute("default", "javadoc"); //$NON-NLS-1$ //$NON-NLS-2$ Element javadocTarget= document.createElement("target"); //$NON-NLS-1$ project.appendChild(javadocTarget); javadocTarget.setAttribute("name", "javadoc"); //$NON-NLS-1$ //$NON-NLS-2$ Element xmlJavadocDesc= document.createElement("javadoc"); //$NON-NLS-1$ javadocTarget.appendChild(xmlJavadocDesc); if (!store.fromStandard()) xmlWriteDoclet(store, document, xmlJavadocDesc); else xmlWriteJavadocStandardParams(store, document,xmlJavadocDesc); // Write the document to the stream OutputFormat format= new OutputFormat(); format.setIndenting(true); SerializerFactory serializerFactory= SerializerFactory.getSerializerFactory(Method.XML); Serializer serializer= serializerFactory.makeSerializer(fOutputStream, format); serializer.asDOMSerializer().serialize(document); } private void xmlWriteJavadocStandardParams(JavadocOptionsManager store, Document document ,Element xmlJavadocDesc) throws DOMException, CoreException { xmlJavadocDesc.setAttribute(store.DESTINATION, store.getDestination(store.getJavaProject())); xmlJavadocDesc.setAttribute(store.VISIBILITY, store.getAccess()); xmlJavadocDesc.setAttribute(store.USE, booleanToString(store.getBoolean("use"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.NOTREE, booleanToString(store.getBoolean("notree"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.NONAVBAR, booleanToString(store.getBoolean("nonavbar"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.NOINDEX, booleanToString(store.getBoolean("noindex"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.SPLITINDEX, booleanToString(store.getBoolean("splitindex"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.AUTHOR, booleanToString(store.getBoolean("author"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.VERSION, booleanToString(store.getBoolean("version"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.NODEPRECATEDLIST, booleanToString(store.getBoolean("nodeprecatedlist"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.NODEPRECATED, booleanToString(store.getBoolean("nodeprecated"))); //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.PACKAGENAMES, toPackageList(store.getSourceElements())); xmlJavadocDesc.setAttribute(store.SOURCEPATH, store.getSourcepath()); xmlJavadocDesc.setAttribute(store.CLASSPATH, store.getClasspath()); String str= store.getOverview(); if (!str.equals("")) //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.OVERVIEW, str); str= store.getStyleSheet(); if (!str.equals("")) //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.STYLESHEETFILE, str); str= store.getTitle(); if(!str.equals("")) //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.TITLE, str); str= store.getAdditionalParams(); if (!str.equals("")) //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.EXTRAOPTIONS, str); if (fProject != null) { //it should never equal null String hrefs = store.getLinks(fProject); StringTokenizer tokenizer = new StringTokenizer(hrefs, ";"); //$NON-NLS-1$ while (tokenizer.hasMoreElements()) { String href = (String) tokenizer.nextElement(); Element links = document.createElement("link"); //$NON-NLS-1$ xmlJavadocDesc.appendChild(links); links.setAttribute(store.HREF, href); } } } private void xmlWriteDoclet(JavadocOptionsManager store, Document document, Element xmlJavadocDesc) throws DOMException, CoreException { xmlJavadocDesc.setAttribute(store.PACKAGENAMES, toPackageList(store.getSourceElements())); xmlJavadocDesc.setAttribute(store.SOURCEPATH, store.getSourcepath()); xmlJavadocDesc.setAttribute(store.CLASSPATH, store.getClasspath()); xmlJavadocDesc.setAttribute(store.VISIBILITY, store.getAccess()); Element doclet= document.createElement("doclet"); //$NON-NLS-1$ xmlJavadocDesc.appendChild(doclet); doclet.setAttribute(store.NAME, store.getDocletName()); doclet.setAttribute(store.PATH, store.getDocletPath()); String str= store.getOverview(); if (!str.equals("")) //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.OVERVIEW, str); str= store.getAdditionalParams(); if (!str.equals("")) //$NON-NLS-1$ xmlJavadocDesc.setAttribute(store.EXTRAOPTIONS, str); } /** * Closes this stream. * It is the client's responsibility to close the stream. * * @exception IOException */ private String toPackageList(IJavaElement[] sourceElements) throws JavaModelException { StringBuffer buf= new StringBuffer(); for (int i= 0; i < sourceElements.length; i++) { if (i > 0) { buf.append(","); //$NON-NLS-1$ } IJavaElement curr= sourceElements[i]; if (curr instanceof IPackageFragment) { buf.append(curr.getElementName()); } else { buf.append(curr.getUnderlyingResource().getLocation().toOSString()); } } return buf.toString(); } private String booleanToString(boolean bool){ if(bool) return "true"; //$NON-NLS-1$ else return"false"; //$NON-NLS-1$ } public void close() throws IOException { if (fOutputStream != null) { fOutputStream.close(); } } }
18,071
Bug 18071 Package Viewer: Too many refreshes
F1 - when a working copy is closed, it's package is updated - update on a package results in a refresh as the abstract filter claims that IMAGE is a filter property
verified fixed
21a786c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T08:22:16Z
2002-05-28T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaElementContentProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.ui; import org.eclipse.core.resources.*; import org.eclipse.jdt.core.*; import org.eclipse.jdt.internal.ui.*; import org.eclipse.jdt.internal.ui.viewsupport.*; import org.eclipse.jface.viewers.*; import org.eclipse.swt.widgets.*; /** * A tree content provider for Java elements. It extends the * StandardJavaElementContentProvider with support for listening to changes. * It is recommended to implement a custom listening support * and to derive from the StandardJavaElementContentProvider directly. * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * @see StandardJavaElementContentProvider */ public class JavaElementContentProvider extends StandardJavaElementContentProvider implements ITreeContentProvider, IElementChangedListener { protected TreeViewer fViewer; protected Object fInput; /* (non-Javadoc) * Method declared on IContentProvider. */ public void dispose() { super.dispose(); JavaCore.removeElementChangedListener(this); } /* (non-Javadoc) * Method declared on IContentProvider. */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { super.inputChanged(viewer, oldInput, newInput); fViewer= (TreeViewer)viewer; if (oldInput == null && newInput != null) { JavaCore.addElementChangedListener(this); } else if (oldInput != null && newInput == null) { JavaCore.removeElementChangedListener(this); } fInput= newInput; } /** * Creates a new content provider for Java elements. */ public JavaElementContentProvider() { } /** * Creates a new content provider for Java elements. */ public JavaElementContentProvider(boolean provideMembers, boolean provideWorkingCopy) { super(provideMembers, provideWorkingCopy); } /* (non-Javadoc) * Method declared on IElementChangedListener. */ public void elementChanged(final ElementChangedEvent event) { try { processDelta(event.getDelta()); } catch(JavaModelException e) { JavaPlugin.getDefault().logErrorStatus(JavaUIMessages.getString("JavaElementContentProvider.errorMessage"), e.getStatus()); //$NON-NLS-1$ } } /** * Processes a delta recursively. When more than two children are affected the * tree is fully refreshed starting at this node. The delta is processed in the * current thread but the viewer updates are posted to the UI thread. */ protected void processDelta(IJavaElementDelta delta) throws JavaModelException { int kind= delta.getKind(); int flags= delta.getFlags(); IJavaElement element= delta.getElement(); if (!getProvideWorkingCopy() && element instanceof IWorkingCopy && ((IWorkingCopy)element).isWorkingCopy()) return; if (element != null && element.getElementType() == IJavaElement.COMPILATION_UNIT && !element.getJavaProject().isOnClasspath(element)) return; // handle open and closing of a solution or project if (((flags & IJavaElementDelta.F_CLOSED) != 0) || ((flags & IJavaElementDelta.F_OPENED) != 0)) { postRefresh(element); return; } if (kind == IJavaElementDelta.REMOVED) { Object parent= internalGetParent(element); postRemove(element); if (parent instanceof IPackageFragment) updatePackageIcon((IPackageFragment)parent); // we are filtering out empty subpackages, so we // a package becomes empty we remove it from the viewer. if (isPackageFragmentEmpty(element.getParent())) { if (fViewer.testFindItem(parent) != null) postRefresh(internalGetParent(parent)); } return; } if (kind == IJavaElementDelta.ADDED) { Object parent= internalGetParent(element); // we are filtering out empty subpackages, so we // have to handle additions to them specially. if (parent instanceof IPackageFragment) { Object grandparent= internalGetParent(parent); // 1GE8SI6: ITPJUI:WIN98 - Rename is not shown in Packages View // avoid posting a refresh to an unvisible parent if (parent.equals(fInput)) { postRefresh(parent); } else { // refresh from grandparent if parent isn't visible yet if (fViewer.testFindItem(parent) == null) postRefresh(grandparent); else { postRefresh(parent); } } } else { postAdd(parent, element); } } if (element instanceof ICompilationUnit) { if (getProvideWorkingCopy()) { IJavaElement original= ((IWorkingCopy)element).getOriginalElement(); if (original != null) element= original; } if (kind == IJavaElementDelta.CHANGED) { postRefresh(element); return; } } // we don't show the contents of a compilation or IClassFile, so don't go any deeper if ((element instanceof ICompilationUnit) || (element instanceof IClassFile)) return; if (isClassPathChange(delta)) { // throw the towel and do a full refresh of the affected java project. postRefresh(element.getJavaProject()); } if (delta.getResourceDeltas() != null) { IResourceDelta[] rd= delta.getResourceDeltas(); for (int i= 0; i < rd.length; i++) { processResourceDelta(rd[i], element); } } IJavaElementDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren.length > 1) { // a package fragment might become non empty refresh from the parent if (element instanceof IPackageFragment) { IJavaElement parent= (IJavaElement)internalGetParent(element); // 1GE8SI6: ITPJUI:WIN98 - Rename is not shown in Packages View // avoid posting a refresh to an unvisible parent if (element.equals(fInput)) { postRefresh(element); } else { postRefresh(parent); } return; } // more than one child changed, refresh from here downwards if (element instanceof IPackageFragmentRoot) postRefresh(skipProjectPackageFragmentRoot((IPackageFragmentRoot)element)); else postRefresh(element); return; } for (int i= 0; i < affectedChildren.length; i++) { processDelta(affectedChildren[i]); } } /** * Updates the package icon */ private void updatePackageIcon(final IJavaElement element) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.update(element, new String[]{IBasicPropertyConstants.P_IMAGE}); } }); } /** * Process resource deltas */ private void processResourceDelta(IResourceDelta delta, Object parent) { int status= delta.getKind(); IResource resource= delta.getResource(); // filter out changes affecting the output folder if (resource == null) return; // this could be optimized by handling all the added children in the parent if ((status & IResourceDelta.REMOVED) != 0) { if (parent instanceof IPackageFragment) // refresh one level above to deal with empty package filtering properly postRefresh(internalGetParent(parent)); else postRemove(resource); } if ((status & IResourceDelta.ADDED) != 0) { if (parent instanceof IPackageFragment) // refresh one level above to deal with empty package filtering properly postRefresh(internalGetParent(parent)); else postAdd(parent, resource); } IResourceDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren.length > 1) { // more than one child changed, refresh from here downwards postRefresh(resource); return; } for (int i= 0; i < affectedChildren.length; i++) processResourceDelta(affectedChildren[i], resource); } private void postRefresh(final Object root) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.refresh(root); } }); } private void postAdd(final Object parent, final Object element) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.add(parent, element); } }); } private void postRemove(final Object element) { postRunnable(new Runnable() { public void run() { // 1GF87WR: ITPUI:ALL - SWTEx + NPE closing a workbench window. Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.remove(element); } }); } private void postRunnable(final Runnable r) { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.getDisplay().asyncExec(r); } } }
18,266
Bug 18266 Turning off lightbulb preference doesn't turn the lights off right away
When you turn off the lightbulb preference, editors with existing lightbulbs continue to show them. Closing and reopening the editors gets rid of them.
verified fixed
8038473
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T09:20:57Z
2002-05-30T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.Map; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.layout.RowLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.List; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.ui.texteditor.WorkbenchChainedTextFontFieldEditor; import org.eclipse.jdt.ui.text.IJavaColorConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; import org.eclipse.jdt.internal.corext.refactoring.util.DebugUtils; /* * The page for setting the editor options. */ public class JavaEditorPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { public static final String BOLD= "_bold"; //$NON-NLS-1$ public static final String PREF_SHOW_TEMP_PROBLEMS= "JavaEditor.ShowTemporaryProblem"; //$NON-NLS-1$ public static final String PREF_SYNC_OUTLINE_ON_CURSOR_MOVE= "JavaEditor.SyncOutlineOnCursorMove"; //$NON-NLS-1$ public final OverlayPreferenceStore.OverlayKey[] fKeys= new OverlayPreferenceStore.OverlayKey[] { new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_KEYWORD + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_STRING), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_STRING + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_DEFAULT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_KEYWORD + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_TAG), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_TAG + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_LINK), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_LINK + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_DEFAULT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.MATCHING_BRACKETS_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.MATCHING_BRACKETS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.CURRENT_LINE_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.CURRENT_LINE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.PRINT_MARGIN_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, CompilationUnitEditor.PRINT_MARGIN_COLUMN), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.PRINT_MARGIN), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.LINKED_POSITION_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.PROBLEM_INDICATION_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.PROBLEM_INDICATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.OVERVIEW_RULER), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, JavaEditor.LINE_NUMBER_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditor.LINE_NUMBER_RULER), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.SPACES_FOR_TABS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOACTIVATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, ContentAssistPreference.AUTOACTIVATION_DELAY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOINSERT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ORDER_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.CASE_SENSITIVITY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ADD_IMPORT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.FILL_METHOD_ARGUMENTS) }; private final String[][] fSyntaxColorListModel= new String[][] { { JavaUIMessages.getString("JavaEditorPreferencePage.multiLineComment"), IJavaColorConstants.JAVA_MULTI_LINE_COMMENT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.singleLineComment"), IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.keywords"), IJavaColorConstants.JAVA_KEYWORD }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.strings"), IJavaColorConstants.JAVA_STRING }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.others"), IJavaColorConstants.JAVA_DEFAULT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocKeywords"), IJavaColorConstants.JAVADOC_KEYWORD }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocHtmlTags"), IJavaColorConstants.JAVADOC_TAG }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocLinks"), IJavaColorConstants.JAVADOC_LINK }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocOthers"), IJavaColorConstants.JAVADOC_DEFAULT } //$NON-NLS-1$ }; private final String[][] fAppearanceColorListModel= new String[][] { {JavaUIMessages.getString("JavaEditorPreferencePage.lineNumberForegroundColor"), JavaEditor.LINE_NUMBER_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.matchingBracketsHighlightColor2"), CompilationUnitEditor.MATCHING_BRACKETS_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.currentLineHighlighColor"), CompilationUnitEditor.CURRENT_LINE_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.problemsHighlightColor"), CompilationUnitEditor.PROBLEM_INDICATION_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.printMarginColor2"), CompilationUnitEditor.PRINT_MARGIN_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.findScopeColor2"), AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.linkedPositionColor2"), CompilationUnitEditor.LINKED_POSITION_COLOR}, //$NON-NLS-1$ }; private OverlayPreferenceStore fOverlayStore; private JavaTextTools fJavaTextTools; private Map fColorButtons= new HashMap(); private SelectionListener fColorButtonListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { ColorEditor editor= (ColorEditor) e.widget.getData(); PreferenceConverter.setValue(fOverlayStore, (String) fColorButtons.get(editor), editor.getColorValue()); } }; private Map fCheckBoxes= new HashMap(); private SelectionListener fCheckBoxListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { Button button= (Button) e.widget; fOverlayStore.setValue((String) fCheckBoxes.get(button), button.getSelection()); } }; private Map fTextFields= new HashMap(); private ModifyListener fTextFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { Text text= (Text) e.widget; fOverlayStore.setValue((String) fTextFields.get(text), text.getText()); } }; private ArrayList fNumberFields= new ArrayList(); private ModifyListener fNumberFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { numberFieldChanged((Text) e.widget); } }; private WorkbenchChainedTextFontFieldEditor fFontEditor; private List fSyntaxColorList; private List fAppearanceColorList; private ColorEditor fSyntaxForegroundColorEditor; private ColorEditor fAppearanceForegroundColorEditor; private ColorEditor fBackgroundColorEditor; private Button fBackgroundDefaultRadioButton; private Button fBackgroundCustomRadioButton; private Button fBackgroundColorButton; private Button fBoldCheckBox; private SourceViewer fPreviewViewer; private Color fBackgroundColor; private Control fAutoInsertDelayText; private Control fAutoInsertJavaTriggerText; private Control fAutoInsertJavaDocTriggerText; public JavaEditorPreferencePage() { setDescription(JavaUIMessages.getString("JavaEditorPreferencePage.description")); //$NON-NLS-1$ setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); fOverlayStore= new OverlayPreferenceStore(getPreferenceStore(), fKeys); } public static void initDefaults(IPreferenceStore store) { /* * Ensure that the display is accessed only in the UI thread. * Ensure that there are no side effects of switching the thread. */ final RGB[] rgbs= new RGB[3]; final Display display= Display.getDefault(); display.syncExec(new Runnable() { public void run() { Color c= display.getSystemColor(SWT.COLOR_GRAY); rgbs[0]= c.getRGB(); c= display.getSystemColor(SWT.COLOR_LIST_FOREGROUND); rgbs[1]= c.getRGB(); c= display.getSystemColor(SWT.COLOR_LIST_BACKGROUND); rgbs[2]= c.getRGB(); } }); /* * Go on in whatever thread this is. */ store.setDefault(CompilationUnitEditor.MATCHING_BRACKETS, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.MATCHING_BRACKETS_COLOR, rgbs[0]); store.setDefault(CompilationUnitEditor.CURRENT_LINE, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.CURRENT_LINE_COLOR, new RGB(225, 235, 224)); store.setDefault(CompilationUnitEditor.PRINT_MARGIN, false); store.setDefault(CompilationUnitEditor.PRINT_MARGIN_COLUMN, 80); PreferenceConverter.setDefault(store, CompilationUnitEditor.PRINT_MARGIN_COLOR, new RGB(176, 180 , 185)); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE, new RGB(185, 176 , 180)); store.setDefault(CompilationUnitEditor.PROBLEM_INDICATION, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.PROBLEM_INDICATION_COLOR, new RGB(255, 0 , 128)); store.setDefault(JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS, true); store.setDefault(JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE, false); store.setDefault(CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS, true); store.setDefault(CompilationUnitEditor.OVERVIEW_RULER, true); store.setDefault(JavaEditor.LINE_NUMBER_RULER, false); PreferenceConverter.setDefault(store, JavaEditor.LINE_NUMBER_COLOR, new RGB(0, 0, 0)); WorkbenchChainedTextFontFieldEditor.startPropagate(store, JFaceResources.TEXT_FONT); PreferenceConverter.setDefault(store, CompilationUnitEditor.LINKED_POSITION_COLOR, new RGB(0, 200 , 100)); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND, rgbs[1]); store.setDefault(AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT, true); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, rgbs[2]); store.setDefault(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT, true); store.setDefault(JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 4); store.setDefault(CompilationUnitEditor.SPACES_FOR_TABS, false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_KEYWORD, new RGB(127, 0, 85)); store.setDefault(IJavaColorConstants.JAVA_KEYWORD + "_bold", true); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_STRING, new RGB(42, 0, 255)); store.setDefault(IJavaColorConstants.JAVA_STRING + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_DEFAULT, new RGB(0, 0, 0)); store.setDefault(IJavaColorConstants.JAVA_DEFAULT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_KEYWORD, new RGB(127, 159, 191)); store.setDefault(IJavaColorConstants.JAVADOC_KEYWORD + "_bold", true); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_TAG, new RGB(127, 127, 159)); store.setDefault(IJavaColorConstants.JAVADOC_TAG + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_LINK, new RGB(63, 63, 191)); store.setDefault(IJavaColorConstants.JAVADOC_LINK + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_DEFAULT, new RGB(63, 95, 191)); store.setDefault(IJavaColorConstants.JAVADOC_DEFAULT + "_bold", false); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.AUTOACTIVATION, true); store.setDefault(ContentAssistPreference.AUTOACTIVATION_DELAY, 500); store.setDefault(ContentAssistPreference.AUTOINSERT, true); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_FOREGROUND, new RGB(0, 0, 0)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_FOREGROUND, new RGB(0, 0, 0)); store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, "."); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, "@"); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, true); store.setDefault(ContentAssistPreference.CASE_SENSITIVITY, false); store.setDefault(ContentAssistPreference.ORDER_PROPOSALS, false); store.setDefault(ContentAssistPreference.ADD_IMPORT, true); store.setDefault(ContentAssistPreference.FILL_METHOD_ARGUMENTS, false); } /* * @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /* * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), IJavaHelpContextIds.JAVA_EDITOR_PREFERENCE_PAGE); } private void handleSyntaxColorListSelection() { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fSyntaxForegroundColorEditor.setColorValue(rgb); fBoldCheckBox.setSelection(fOverlayStore.getBoolean(key + BOLD)); } private void handleAppearanceColorListSelection() { int i= fAppearanceColorList.getSelectionIndex(); String key= fAppearanceColorListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fAppearanceForegroundColorEditor.setColorValue(rgb); } private Control createColorPage(Composite parent) { Composite colorComposite= new Composite(parent, SWT.NULL); colorComposite.setLayout(new GridLayout()); Composite backgroundComposite= new Composite(colorComposite, SWT.NULL); backgroundComposite.setLayout(new RowLayout()); Label label= new Label(backgroundComposite, SWT.NULL); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.backgroundColor")); //$NON-NLS-1$ SelectionListener backgroundSelectionListener= new SelectionListener() { public void widgetSelected(SelectionEvent e) { boolean custom= fBackgroundCustomRadioButton.getSelection(); fBackgroundColorButton.setEnabled(custom); fOverlayStore.setValue(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT, !custom); } public void widgetDefaultSelected(SelectionEvent e) {} }; fBackgroundDefaultRadioButton= new Button(backgroundComposite, SWT.RADIO | SWT.LEFT); fBackgroundDefaultRadioButton.setText(JavaUIMessages.getString("JavaEditorPreferencePage.systemDefault")); //$NON-NLS-1$ fBackgroundDefaultRadioButton.addSelectionListener(backgroundSelectionListener); fBackgroundCustomRadioButton= new Button(backgroundComposite, SWT.RADIO | SWT.LEFT); fBackgroundCustomRadioButton.setText(JavaUIMessages.getString("JavaEditorPreferencePage.custom")); //$NON-NLS-1$ fBackgroundCustomRadioButton.addSelectionListener(backgroundSelectionListener); fBackgroundColorEditor= new ColorEditor(backgroundComposite); fBackgroundColorButton= fBackgroundColorEditor.getButton(); label= new Label(colorComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.foreground")); //$NON-NLS-1$ label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Composite editorComposite= new Composite(colorComposite, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); GridData gd= new GridData(GridData.FILL_BOTH); editorComposite.setLayoutData(gd); fSyntaxColorList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL | SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fSyntaxColorList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NONE); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); label= new Label(stylesComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.color")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fSyntaxForegroundColorEditor= new ColorEditor(stylesComposite); Button foregroundColorButton= fSyntaxForegroundColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; foregroundColorButton.setLayoutData(gd); label= new Label(stylesComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.bold")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fBoldCheckBox= new Button(stylesComposite, SWT.CHECK); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; fBoldCheckBox.setLayoutData(gd); label= new Label(colorComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.preview")); //$NON-NLS-1$ label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Control previewer= createPreviewer(colorComposite); gd= new GridData(GridData.FILL_BOTH); gd.widthHint= convertWidthInCharsToPixels(80); gd.heightHint= convertHeightInCharsToPixels(15); previewer.setLayoutData(gd); fSyntaxColorList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleSyntaxColorListSelection(); } }); foregroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fSyntaxForegroundColorEditor.getColorValue()); } }); fBackgroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { PreferenceConverter.setValue(fOverlayStore, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, fBackgroundColorEditor.getColorValue()); } }); fBoldCheckBox.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; fOverlayStore.setValue(key + BOLD, fBoldCheckBox.getSelection()); } }); return colorComposite; } private Control createPreviewer(Composite parent) { fJavaTextTools= new JavaTextTools(fOverlayStore); fPreviewViewer= new SourceViewer(parent, null, SWT.V_SCROLL | SWT.H_SCROLL | SWT.BORDER); fPreviewViewer.configure(new JavaSourceViewerConfiguration(fJavaTextTools, null)); fPreviewViewer.getTextWidget().setFont(JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT)); fPreviewViewer.setEditable(false); initializeViewerColors(fPreviewViewer); String content= loadPreviewContentFromFile("ColorSettingPreviewCode.txt"); //$NON-NLS-1$ IDocument document= new Document(content); IDocumentPartitioner partitioner= fJavaTextTools.createDocumentPartitioner(); partitioner.connect(document); document.setDocumentPartitioner(partitioner); fPreviewViewer.setDocument(document); fOverlayStore.addPropertyChangeListener(new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { String p= event.getProperty(); if (p.equals(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND) || p.equals(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT)) { initializeViewerColors(fPreviewViewer); } fPreviewViewer.invalidateTextPresentation(); } }); return fPreviewViewer.getControl(); } /** * Initializes the given viewer's colors. * * @param viewer the viewer to be initialized */ private void initializeViewerColors(ISourceViewer viewer) { IPreferenceStore store= fOverlayStore; if (store != null) { StyledText styledText= viewer.getTextWidget(); // ---------- background color ---------------------- Color color= store.getBoolean(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT) ? null : createColor(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, styledText.getDisplay()); styledText.setBackground(color); if (fBackgroundColor != null) fBackgroundColor.dispose(); fBackgroundColor= color; } } /** * Creates a color from the information stored in the given preference store. * Returns <code>null</code> if there is no such information available. */ private Color createColor(IPreferenceStore store, String key, Display display) { RGB rgb= null; if (store.contains(key)) { if (store.isDefault(key)) rgb= PreferenceConverter.getDefaultColor(store, key); else rgb= PreferenceConverter.getColor(store, key); if (rgb != null) return new Color(display, rgb); } return null; } // sets enabled flag for a control and all its sub-tree private static void setEnabled(Control control, boolean enable) { control.setEnabled(enable); if (control instanceof Composite) { Composite composite= (Composite) control; Control[] children= composite.getChildren(); for (int i= 0; i < children.length; i++) setEnabled(children[i], enable); } } private Control createAppearancePage(Composite parent) { Composite behaviorComposite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; behaviorComposite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.textFont"); //$NON-NLS-1$ addTextFontEditor(behaviorComposite, label, AbstractTextEditor.PREFERENCE_FONT); label= JavaUIMessages.getString("JavaEditorPreferencePage.displayedTabWidth"); //$NON-NLS-1$ addTextField(behaviorComposite, label, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 3, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.printMarginColumn"); //$NON-NLS-1$ addTextField(behaviorComposite, label, CompilationUnitEditor.PRINT_MARGIN_COLUMN, 3, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.insertSpaceForTabs"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.SPACES_FOR_TABS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.synchronizeOnCursor"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showOverviewRuler"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.OVERVIEW_RULER, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showLineNumbers"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, JavaEditor.LINE_NUMBER_RULER, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightMatchingBrackets"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.MATCHING_BRACKETS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightCurrentLine"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.CURRENT_LINE, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showPrintMargin"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.PRINT_MARGIN, 0); Label l= new Label(behaviorComposite, SWT.LEFT ); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; gd.heightHint= convertHeightInCharsToPixels(1) / 2; l.setLayoutData(gd); l= new Label(behaviorComposite, SWT.LEFT); l.setText(JavaUIMessages.getString("JavaEditorPreferencePage.appearanceOptions")); //$NON-NLS-1$ gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; l.setLayoutData(gd); Composite editorComposite= new Composite(behaviorComposite, SWT.NONE); layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.FILL_VERTICAL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); fAppearanceColorList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL | SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fAppearanceColorList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NONE); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); l= new Label(stylesComposite, SWT.LEFT); l.setText(JavaUIMessages.getString("JavaEditorPreferencePage.color")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; l.setLayoutData(gd); fAppearanceForegroundColorEditor= new ColorEditor(stylesComposite); Button foregroundColorButton= fAppearanceForegroundColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; foregroundColorButton.setLayoutData(gd); fAppearanceColorList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleAppearanceColorListSelection(); } }); foregroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fAppearanceColorList.getSelectionIndex(); String key= fAppearanceColorListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fAppearanceForegroundColorEditor.getColorValue()); } }); return behaviorComposite; } private Control createProblemIndicationPage(Composite parent) { Composite composite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; composite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.showProblemsBeforeCompiling"); //$NON-NLS-1$ addCheckBox(composite, label, CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightProblems"); //$NON-NLS-1$ addCheckBox(composite, label, CompilationUnitEditor.PROBLEM_INDICATION, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showQuickFixables"); //$NON-NLS-1$ addCheckBox(composite, label, JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS, 0); return composite; } private Control createContentAssistPage(Composite parent) { Composite contentAssistComposite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; contentAssistComposite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.insertSingleProposalsAutomatically"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOINSERT, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showOnlyProposalsVisibleInTheInvocationContext"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.presentProposalsInAlphabeticalOrder"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.ORDER_PROPOSALS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.automaticallyAddImportInsteadOfQualifiedName"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.ADD_IMPORT, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.fillArgumentNamesOnMethodCompletion"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.FILL_METHOD_ARGUMENTS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.enableAutoActivation"); //$NON-NLS-1$ final Button autoactivation= addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationDelay"); //$NON-NLS-1$ fAutoInsertDelayText= addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_DELAY, 4, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationTriggersForJava"); //$NON-NLS-1$ fAutoInsertJavaTriggerText= addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, 4, 0, false); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationTriggersForJavaDoc"); //$NON-NLS-1$ fAutoInsertJavaDocTriggerText= addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, 4, 0, false); label= JavaUIMessages.getString("JavaEditorPreferencePage.backgroundForCompletionProposals"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_BACKGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.foregroundForCompletionProposals"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_FOREGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.backgroundForMethodParameters"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_BACKGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.foregroundForMethodParameters"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_FOREGROUND, 0); autoactivation.addSelectionListener(new SelectionAdapter(){ public void widgetSelected(SelectionEvent e) { updateAutoactivationControls(); } }); return contentAssistComposite; } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { fOverlayStore.load(); fOverlayStore.start(); TabFolder folder= new TabFolder(parent, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); TabItem item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.general")); //$NON-NLS-1$ item.setControl(createAppearancePage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.colors")); //$NON-NLS-1$ item.setControl(createColorPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.codeAssist")); //$NON-NLS-1$ item.setControl(createContentAssistPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText("Problem Indi&cation"); item.setControl(createProblemIndicationPage(folder)); initialize(); return folder; } private void initialize() { fFontEditor.setPreferenceStore(getPreferenceStore()); fFontEditor.setPreferencePage(this); fFontEditor.load(); initializeFields(); for (int i= 0; i < fSyntaxColorListModel.length; i++) fSyntaxColorList.add(fSyntaxColorListModel[i][0]); fSyntaxColorList.getDisplay().asyncExec(new Runnable() { public void run() { fSyntaxColorList.select(0); handleSyntaxColorListSelection(); } }); for (int i= 0; i < fAppearanceColorListModel.length; i++) fAppearanceColorList.add(fAppearanceColorListModel[i][0]); fAppearanceColorList.getDisplay().asyncExec(new Runnable() { public void run() { fAppearanceColorList.select(0); handleAppearanceColorListSelection(); } }); } private void initializeFields() { Iterator e= fColorButtons.keySet().iterator(); while (e.hasNext()) { ColorEditor c= (ColorEditor) e.next(); String key= (String) fColorButtons.get(c); RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); c.setColorValue(rgb); } e= fCheckBoxes.keySet().iterator(); while (e.hasNext()) { Button b= (Button) e.next(); String key= (String) fCheckBoxes.get(b); b.setSelection(fOverlayStore.getBoolean(key)); } e= fTextFields.keySet().iterator(); while (e.hasNext()) { Text t= (Text) e.next(); String key= (String) fTextFields.get(t); t.setText(fOverlayStore.getString(key)); } RGB rgb= PreferenceConverter.getColor(fOverlayStore, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND); fBackgroundColorEditor.setColorValue(rgb); boolean default_= fOverlayStore.getBoolean(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT); fBackgroundDefaultRadioButton.setSelection(default_); fBackgroundCustomRadioButton.setSelection(!default_); fBackgroundColorButton.setEnabled(!default_); updateAutoactivationControls(); } private void updateAutoactivationControls() { boolean autoactivation= fOverlayStore.getBoolean(ContentAssistPreference.AUTOACTIVATION); fAutoInsertDelayText.setEnabled(autoactivation); fAutoInsertJavaTriggerText.setEnabled(autoactivation); fAutoInsertJavaDocTriggerText.setEnabled(autoactivation); } /* * @see PreferencePage#performOk() */ public boolean performOk() { fFontEditor.store(); fOverlayStore.propagate(); JavaPlugin.getDefault().savePluginPreferences(); return true; } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fFontEditor.loadDefault(); fOverlayStore.loadDefaults(); initializeFields(); handleSyntaxColorListSelection(); handleAppearanceColorListSelection(); super.performDefaults(); fPreviewViewer.invalidateTextPresentation(); } /* * @see DialogPage#dispose() */ public void dispose() { if (fJavaTextTools != null) { fJavaTextTools= null; } fFontEditor.setPreferencePage(null); fFontEditor.setPreferenceStore(null); if (fOverlayStore != null) { fOverlayStore.stop(); fOverlayStore= null; } super.dispose(); } private Control addColorButton(Composite composite, String label, String key, int indentation) { Label labelControl= new Label(composite, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); ColorEditor editor= new ColorEditor(composite); Button button= editor.getButton(); button.setData(editor); gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); button.setLayoutData(gd); button.addSelectionListener(fColorButtonListener); fColorButtons.put(editor, key); return composite; } private Button addCheckBox(Composite parent, String label, String key, int indentation) { Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; gd.horizontalSpan= 2; checkBox.setLayoutData(gd); checkBox.addSelectionListener(fCheckBoxListener); fCheckBoxes.put(checkBox, key); return checkBox; } private Control addTextField(Composite composite, String label, String key, int textLimit, int indentation, boolean isNumber) { Label labelControl= new Label(composite, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); Text textControl= new Text(composite, SWT.BORDER | SWT.SINGLE); gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.widthHint= convertWidthInCharsToPixels(textLimit + 1); textControl.setLayoutData(gd); textControl.setTextLimit(textLimit); fTextFields.put(textControl, key); if (isNumber) { fNumberFields.add(textControl); textControl.addModifyListener(fNumberFieldListener); } else { textControl.addModifyListener(fTextFieldListener); } return textControl; } private void addTextFontEditor(Composite parent, String label, String key) { Composite editorComposite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 3; editorComposite.setLayout(layout); fFontEditor= new WorkbenchChainedTextFontFieldEditor(key, label, editorComposite); fFontEditor.setChangeButtonText(JavaUIMessages.getString("JavaEditorPreferencePage.change")); //$NON-NLS-1$ GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); } private String loadPreviewContentFromFile(String filename) { String line; String separator= System.getProperty("line.separator"); //$NON-NLS-1$ StringBuffer buffer= new StringBuffer(512); BufferedReader reader= null; try { reader= new BufferedReader(new InputStreamReader(getClass().getResourceAsStream(filename))); while ((line= reader.readLine()) != null) { buffer.append(line); buffer.append(separator); } } catch (IOException io) { JavaPlugin.log(io); } finally { if (reader != null) { try { reader.close(); } catch (IOException e) {} } } return buffer.toString(); } private void numberFieldChanged(Text textControl) { String number= textControl.getText(); IStatus status= validatePositiveNumber(number); if (!status.matches(IStatus.ERROR)) fOverlayStore.setValue((String) fTextFields.get(textControl), number); updateStatus(status); } private IStatus validatePositiveNumber(String number) { StatusInfo status= new StatusInfo(); if (number.length() == 0) { status.setError(JavaUIMessages.getString("JavaEditorPreferencePage.empty_input")); //$NON-NLS-1$ } else { try { int value= Integer.parseInt(number); if (value < 0) status.setError(JavaUIMessages.getFormattedString("JavaEditorPreferencePage.invalid_input", number)); //$NON-NLS-1$ } catch (NumberFormatException e) { status.setError(JavaUIMessages.getFormattedString("JavaEditorPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } return status; } private void updateStatus(IStatus status) { if (!status.matches(IStatus.ERROR)) { for (int i= 0; i < fNumberFields.size(); i++) { Text text= (Text) fNumberFields.get(i); IStatus s= validatePositiveNumber(text.getText()); status= StatusUtil.getMoreSevere(s, status); } } setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } public static boolean showTempProblems() { return JavaPlugin.getDefault().getPreferenceStore().getBoolean(JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS); } static public boolean synchronizeOutlineOnCursorMove() { return JavaPlugin.getDefault().getPreferenceStore().getBoolean(PREF_SYNC_OUTLINE_ON_CURSOR_MOVE); } }
18,198
Bug 18198 Java Model Exception out of JavaOutlineViewer / JDT Core
20020528 Unsure if this is a Core or UI problem Open a compilation unit Close the project containing the compilation unit Java Model Exception: Java Model Status [HEy does not exist.] at org.eclipse.jdt.internal.core.JavaElement.newNotPresentException (JavaElement.java:502) at org.eclipse.jdt.internal.core.JavaProject.openWhenClosed (JavaProject.java:1665) at org.eclipse.jdt.internal.core.JavaElement.openHierarchy (JavaElement.java:523) at org.eclipse.jdt.internal.core.JavaElement.getElementInfo (JavaElement.java:310) at org.eclipse.jdt.internal.core.JavaProject.getJavaProjectElementInfo (JavaProject.java:966) at org.eclipse.jdt.internal.core.JavaProject.getSearchableNameEnvironment (JavaProject.java:1425) at org.eclipse.jdt.internal.core.hierarchy.HierarchyBuilder.<init> (HierarchyBuilder.java:81) at org.eclipse.jdt.internal.core.hierarchy.IndexBasedHierarchyBuilder.<init> (IndexBasedHierarchyBuilder.java:117) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.compute (TypeHierarchy.java:266) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.refresh (TypeHierarchy.java:1128) at org.eclipse.jdt.internal.core.CreateTypeHierarchyOperation.executeOperation (CreateTypeHierarchyOperation.java:69) at org.eclipse.jdt.internal.core.JavaModelOperation.execute (JavaModelOperation.java:292) at org.eclipse.jdt.internal.core.JavaModelOperation.run (JavaModelOperation.java:500) at org.eclipse.jdt.internal.core.JavaModelManager.runOperation (JavaModelManager.java:1183) at org.eclipse.jdt.internal.core.JavaElement.runOperation (JavaElement.java:576) at org.eclipse.jdt.internal.core.SourceType.newSupertypeHierarchy (SourceType.java:338) at org.eclipse.jdt.internal.core.SourceType.newSupertypeHierarchy (SourceType.java:327) at org.eclipse.jdt.internal.corext.util.SuperTypeHierarchyCache.getTypeHierarchy (SuperTypeHierarchyCache.java:60) at org.eclipse.jdt.ui.OverrideIndicatorLabelDecorator.getOverrideIndicators (OverrideIndicatorLabelDecorator.java:97) at org.eclipse.jdt.ui.OverrideIndicatorLabelDecorator.computeAdornmentFlags (OverrideIndicatorLabelDecorator.java:84) at org.eclipse.jdt.ui.OverrideIndicatorLabelDecorator.decorateImage (OverrideIndicatorLabelDecorator.java:67) at org.eclipse.jdt.internal.ui.viewsupport.JavaUILabelProvider.getImage (JavaUILabelProvider.java:110) at org.eclipse.jface.viewers.DecoratingLabelProvider.getImage (DecoratingLabelProvider.java:67) at org.eclipse.jface.viewers.TreeViewer.doUpdateItem(TreeViewer.java:83) at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem (AbstractTreeViewer.java:354) at org.eclipse.jface.viewers.StructuredViewer.updateItem (StructuredViewer.java:1134) at org.eclipse.jface.viewers.AbstractTreeViewer.internalRefresh (AbstractTreeViewer.java:834) at org.eclipse.jface.viewers.AbstractTreeViewer.internalRefresh (AbstractTreeViewer.java:848) at org.eclipse.jface.viewers.AbstractTreeViewer.internalRefresh (AbstractTreeViewer.java:848) at org.eclipse.jface.viewers.AbstractTreeViewer.labelProviderChanged (AbstractTreeViewer.java:936) at org.eclipse.jface.viewers.ContentViewer.handleLabelProviderChanged (ContentViewer.java:157) at org.eclipse.jface.viewers.StructuredViewer.handleLabelProviderChanged (StructuredViewer.java:528) at org.eclipse.jdt.internal.ui.javaeditor.JavaOutlinePage$JavaOutlineViewer.handleL abelProviderChanged(JavaOutlinePage.java:566) at org.eclipse.jface.viewers.ContentViewer$1.labelProviderChanged (ContentViewer.java:70) at org.eclipse.jdt.ui.ProblemsLabelDecorator.fireProblemsChanged (ProblemsLabelDecorator.java:293) at org.eclipse.jdt.ui.ProblemsLabelDecorator.access$0 (ProblemsLabelDecorator.java:288) at org.eclipse.jdt.ui.ProblemsLabelDecorator$1.problemsChanged (ProblemsLabelDecorator.java:268) at org.eclipse.jdt.internal.ui.viewsupport.ProblemMarkerManager$1.run (ProblemMarkerManager.java:177) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:29) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages (Synchronizer.java:93) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:1504) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1292) at org.eclipse.jface.operation.ModalContext$ModalContextThread.block (ModalContext.java:133) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:258) at org.eclipse.jface.dialogs.ProgressMonitorDialog.run (ProgressMonitorDialog.java:335) at org.eclipse.ui.actions.WorkspaceAction.run(WorkspaceAction.java:272) at org.eclipse.ui.actions.CloseResourceAction.run (CloseResourceAction.java:151) at org.eclipse.jface.action.Action.runWithEvent(Action.java:590) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:825) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1527) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1289) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1085) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1068) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:432) at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24)
resolved fixed
73bbec8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T09:21:33Z
2002-05-29T16:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/OverrideIndicatorLabelDecorator.java
package org.eclipse.jdt.ui; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProviderListener; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.corext.util.SuperTypeHierarchyCache; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; import org.eclipse.jdt.internal.ui.viewsupport.ImageDescriptorRegistry; import org.eclipse.jdt.internal.ui.viewsupport.ImageImageDescriptor; /** * LabelDecorator that decorates an method's image with override or implements overlays. * Updating of images on element changes is the resposibility of the viewers using this * decorator. */ public class OverrideIndicatorLabelDecorator implements ILabelDecorator { private ImageDescriptorRegistry fRegistry; private boolean fRegistryNeedsDispose= false; /** * Creates a decorator. The decorator creates an own image registry to cache * images. */ public OverrideIndicatorLabelDecorator() { this(new ImageDescriptorRegistry()); fRegistryNeedsDispose= true; } /** * Internal constructor. Creates decorator with a shared image registry. * @param registry The registry to use or <code>null</code> to use the Java plugin's * image registry. */ public OverrideIndicatorLabelDecorator(ImageDescriptorRegistry registry) { if (registry == null) { registry= JavaPlugin.getImageDescriptorRegistry(); } fRegistry= registry; } /* (non-Javadoc) * @see ILabelDecorator#decorateText(String, Object) */ public String decorateText(String text, Object element) { return text; } /* (non-Javadoc) * @see ILabelDecorator#decorateImage(Image, Object) */ public Image decorateImage(Image image, Object element) { int adornmentFlags= computeAdornmentFlags(element); if (adornmentFlags != 0) { ImageDescriptor baseImage= new ImageImageDescriptor(image); Rectangle bounds= image.getBounds(); return fRegistry.get(new JavaElementImageDescriptor(baseImage, adornmentFlags, new Point(bounds.width, bounds.height))); } return image; } public int computeAdornmentFlags(Object element) { if (AppearancePreferencePage.showOverrideIndicators()) { if (element instanceof IMethod) { try { IMethod method= (IMethod) element; if (method.exists()) { int flags= method.getFlags(); if (method.getDeclaringType().isClass() && !method.isConstructor() && !Flags.isPrivate(flags) && !Flags.isStatic(flags)) { return getOverrideIndicators(method); } } } catch (JavaModelException e) { JavaPlugin.log(e); } } } return 0; } protected int getOverrideIndicators(IMethod method) throws JavaModelException { IType type= method.getDeclaringType(); ITypeHierarchy hierarchy= SuperTypeHierarchyCache.getTypeHierarchy(type); if (hierarchy != null) { return findInHierarchy(type, hierarchy, method.getElementName(), method.getParameterTypes()); } return 0; } protected int findInHierarchy(IType type, ITypeHierarchy hierarchy, String name, String[] paramTypes) throws JavaModelException { IMethod impl= JavaModelUtil.findMethodDeclarationInHierarchy(hierarchy, type, name, paramTypes, false); if (impl != null) { IMethod overridden= JavaModelUtil.findMethodImplementationInHierarchy(hierarchy, type, name, paramTypes, false); if (overridden != null) { return JavaElementImageDescriptor.OVERRIDES; } else { return JavaElementImageDescriptor.IMPLEMENTS; } } return 0; } /* (non-Javadoc) * @see IBaseLabelProvider#addListener(ILabelProviderListener) */ public void addListener(ILabelProviderListener listener) { } /* (non-Javadoc) * @see IBaseLabelProvider#dispose() */ public void dispose() { } /* (non-Javadoc) * @see IBaseLabelProvider#isLabelProperty(Object, String) */ public boolean isLabelProperty(Object element, String property) { return true; } /* (non-Javadoc) * @see IBaseLabelProvider#removeListener(ILabelProviderListener) */ public void removeListener(ILabelProviderListener listener) { } }
18,163
Bug 18163 Add Import should ignore leading/trailing whitespace
It often happens to me that I have selected i.e. "Node " instead of "Node" because I made my selection by using "Shift + Ctrl + Right". When I then use Ctrl+M (Add Import) nothing happens because of the trailing whitespace within the selection.
resolved fixed
b92efa1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T09:32:10Z
2002-05-29T13:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/AddImportOnSelectionAction.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.Action; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.ISelection; import org.eclipse.ui.dialogs.ElementListSelectionDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.core.search.IJavaSearchConstants; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.ITypeNameRequestor; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.internal.corext.codemanipulation.AddImportsOperation; import org.eclipse.jdt.internal.corext.codemanipulation.CodeGenerationSettings; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.corext.util.TypeInfo; import org.eclipse.jdt.internal.corext.util.TypeInfoRequestor; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.WorkbenchRunnableAdapter; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.util.TypeInfoLabelProvider; public class AddImportOnSelectionAction extends Action implements IUpdate { private CompilationUnitEditor fEditor; public AddImportOnSelectionAction(CompilationUnitEditor editor) { super(JavaEditorMessages.getString("AddImportOnSelection.label")); //$NON-NLS-1$ setToolTipText(JavaEditorMessages.getString("AddImportOnSelection.tooltip")); //$NON-NLS-1$ setDescription(JavaEditorMessages.getString("AddImportOnSelection.description")); //$NON-NLS-1$ fEditor= editor; WorkbenchHelp.setHelp(this, IJavaHelpContextIds.ADD_IMPORT_ON_SELECTION_ACTION); } public AddImportOnSelectionAction() { this(null); } public void update() { setEnabled(fEditor != null && !fEditor.isEditorInputReadOnly()); } private ICompilationUnit getCompilationUnit () { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); return manager.getWorkingCopy(fEditor.getEditorInput()); } /* * @see org.eclipse.jface.action.IAction#run() */ public void run() { ICompilationUnit cu= getCompilationUnit(); if (cu != null) { ISelection s= fEditor.getSelectionProvider().getSelection(); IDocument doc= fEditor.getDocumentProvider().getDocument(fEditor.getEditorInput()); ITextSelection selection= (ITextSelection) s; if (doc != null) { try { int nameStart= getNameStart(doc, selection.getOffset()); int nameEnd= getNameEnd(doc, selection.getOffset() + selection.getLength()); int len= nameEnd - nameStart; String name= doc.get(nameStart, len).trim(); String simpleName= Signature.getSimpleName(name); String containerName= Signature.getQualifier(name); IImportDeclaration existingImport= JavaModelUtil.findImport(cu, simpleName); if (existingImport != null) { if (!existingImport.getElementName().equals(name)) { getShell().getDisplay().beep(); } return; } IJavaSearchScope searchScope= SearchEngine.createJavaSearchScope(new IJavaElement[] { cu.getJavaProject() }); TypeInfo[] types= findAllTypes(simpleName, searchScope, null); if (types.length== 0) { getShell().getDisplay().beep(); return; } TypeInfo chosen= selectResult(types, containerName, getShell()); if (chosen == null) { return; } IType type= chosen.resolveType(searchScope); if (type == null) { JavaPlugin.logErrorMessage("AddImportOnSelectionAction: Failed to resolve TypeRef: " + chosen.toString()); //$NON-NLS-1$ MessageDialog.openError(getShell(), JavaEditorMessages.getString("AddImportOnSelection.error.title"), JavaEditorMessages.getString("AddImportOnSelection.error.notresolved.message")); //$NON-NLS-1$ //$NON-NLS-2$ return; } removeQualification(doc, nameStart, chosen); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); AddImportsOperation op= new AddImportsOperation(cu, new IJavaElement[] { type }, settings, false); ProgressMonitorDialog dialog= new ProgressMonitorDialog(getShell()); try { dialog.run(false, true, new WorkbenchRunnableAdapter(op)); } catch (InvocationTargetException e) { JavaPlugin.log(e); MessageDialog.openError(getShell(), JavaEditorMessages.getString("AddImportOnSelection.error.title"), e.getTargetException().getMessage()); //$NON-NLS-1$ } catch (InterruptedException e) { // Do nothing. Operation has been canceled. } return; } catch (CoreException e) { JavaPlugin.log(e); ErrorDialog.openError(getShell(), JavaEditorMessages.getString("AddImportOnSelection.error.title"), null, e.getStatus()); //$NON-NLS-1$ } catch (BadLocationException e) { JavaPlugin.log(e); MessageDialog.openError(getShell(), JavaEditorMessages.getString("AddImportOnSelection.error.title"), e.getMessage()); //$NON-NLS-1$ } } } } private int getNameStart(IDocument doc, int pos) throws BadLocationException { while (pos > 0) { char ch= doc.getChar(pos - 1); if (!Character.isJavaIdentifierPart(ch) && ch != '.') { return pos; } pos--; } return pos; } private int getNameEnd(IDocument doc, int pos) throws BadLocationException { int len= doc.getLength(); while (pos < len) { char ch= doc.getChar(pos); if (!Character.isJavaIdentifierPart(ch)) { return pos; } pos++; } return pos; } private void removeQualification(IDocument doc, int nameStart, TypeInfo typeInfo) throws BadLocationException { String containerName= typeInfo.getTypeContainerName(); int containerLen= containerName.length(); int docLen= doc.getLength(); if ((containerLen > 0) && (nameStart + containerLen + 1 < docLen)) { for (int k= 0; k < containerLen; k++) { if (doc.getChar(nameStart + k) != containerName.charAt(k)) { return; } } if (doc.getChar(nameStart + containerLen) == '.') { doc.replace(nameStart, containerLen + 1, ""); //$NON-NLS-1$ } } } /** * Finds a type by the simple name. */ private static TypeInfo[] findAllTypes(String simpleTypeName, IJavaSearchScope searchScope, IProgressMonitor monitor) throws CoreException { SearchEngine searchEngine= new SearchEngine(); ArrayList typeRefsFound= new ArrayList(10); ITypeNameRequestor requestor= new TypeInfoRequestor(typeRefsFound); searchEngine.searchAllTypeNames( JavaPlugin.getWorkspace(), null, simpleTypeName.toCharArray(), IJavaSearchConstants.EXACT_MATCH, IJavaSearchConstants.CASE_SENSITIVE, IJavaSearchConstants.TYPE, searchScope, requestor, IJavaSearchConstants.WAIT_UNTIL_READY_TO_SEARCH, monitor); return (TypeInfo[]) typeRefsFound.toArray(new TypeInfo[typeRefsFound.size()]); } private Shell getShell() { return fEditor.getSite().getShell(); } private TypeInfo selectResult(TypeInfo[] results, String containerName, Shell shell) { int nResults= results.length; if (nResults == 0) { return null; } else if (nResults == 1) { return results[0]; } if (containerName.length() != 0) { for (int i= 0; i < nResults; i++) { TypeInfo curr= (TypeInfo) results[i]; if (containerName.equals(curr.getTypeContainerName())) { return curr; } } } ElementListSelectionDialog dialog= new ElementListSelectionDialog(getShell(), new TypeInfoLabelProvider(TypeInfoLabelProvider.SHOW_FULLYQUALIFIED)); dialog.setTitle(JavaEditorMessages.getString("AddImportOnSelection.dialog.title")); //$NON-NLS-1$ dialog.setMessage(JavaEditorMessages.getString("AddImportOnSelection.dialog.message")); //$NON-NLS-1$ dialog.setElements(results); if (dialog.open() == dialog.OK) { return (TypeInfo) dialog.getFirstResult(); } return null; } }
18,132
Bug 18132 New wizards should verify if folder is on classpath
1. create J project 'P' with source folder setup (source folder 'src') 2. use new wizard to create a class ==> you can create a class inside 'P' or in a folder which is not on the classpath
resolved fixed
cb8ab38
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T09:39:28Z
2002-05-29T08:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/wizards/NewContainerWizardPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.ui.wizards; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.swt.widgets.Composite; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaElementSorter; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; /** * Base class for Java wizards. Provides source folder selection UI, validation and creation. * @since 2.0 */ public abstract class NewContainerWizardPage extends NewElementWizardPage { /** * container field id */ protected static final String CONTAINER= "NewContainerWizardPage.container"; //$NON-NLS-1$ /** * Status of last validation */ protected IStatus fContainerStatus; private StringButtonDialogField fContainerDialogField; /* * package fragment root corresponding to the input type (can be null) */ private IPackageFragmentRoot fCurrRoot; private IWorkspaceRoot fWorkspaceRoot; public NewContainerWizardPage(String name) { super(name); fWorkspaceRoot= ResourcesPlugin.getWorkspace().getRoot(); ContainerFieldAdapter adapter= new ContainerFieldAdapter(); fContainerDialogField= new StringButtonDialogField(adapter); fContainerDialogField.setDialogFieldListener(adapter); fContainerDialogField.setLabelText(NewWizardMessages.getString("NewContainerWizardPage.container.label")); //$NON-NLS-1$ fContainerDialogField.setButtonLabel(NewWizardMessages.getString("NewContainerWizardPage.container.button")); //$NON-NLS-1$ fContainerStatus= new StatusInfo(); fCurrRoot= null; } /** * Initializes the fields provided by the container page with a given * Java element as selection. * @param elem The initial selection of this page or null if no * selection was available */ protected void initContainerPage(IJavaElement elem) { IPackageFragmentRoot initRoot= null; if (elem != null) { initRoot= JavaModelUtil.getPackageFragmentRoot(elem); if (initRoot == null || initRoot.isArchive()) { IJavaProject jproject= elem.getJavaProject(); try { initRoot= null; IPackageFragmentRoot[] roots= jproject.getPackageFragmentRoots(); for (int i= 0; i < roots.length; i++) { if (roots[i].getKind() == IPackageFragmentRoot.K_SOURCE) { initRoot= roots[i]; break; } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } if (initRoot == null) { initRoot= jproject.getPackageFragmentRoot(""); //$NON-NLS-1$ } } } setPackageFragmentRoot(initRoot, true); } /** * Utility method to inspect a selection to find a Java element as initial element. * @return Returns a Java element to use as initial selection, or <code>null</code>, * if none is found. */ protected IJavaElement getInitialJavaElement(IStructuredSelection selection) { IJavaElement jelem= null; if (selection != null && !selection.isEmpty()) { Object selectedElement= selection.getFirstElement(); if (selectedElement instanceof IAdaptable) { IAdaptable adaptable= (IAdaptable) selectedElement; jelem= (IJavaElement) adaptable.getAdapter(IJavaElement.class); if (jelem == null) { IResource resource= (IResource) adaptable.getAdapter(IResource.class); if (resource != null && resource.getType() != IResource.ROOT) { while (jelem == null && resource.getType() != IResource.PROJECT) { resource= resource.getParent(); jelem= (IJavaElement) resource.getAdapter(IJavaElement.class); } if (jelem == null) { jelem= JavaCore.create(resource); // java project } } } } } if (jelem == null) { jelem= EditorUtility.getActiveEditorJavaInput(); } if (jelem == null) { IProject[] projects= getWorkspaceRoot().getProjects(); if (projects.length > 0) { jelem= JavaCore.create(projects[0]); } } return jelem; } /** * Returns the recommended maximum width for text fields (in pixels) * Not valid until entering createContent. * Overwrite to change value. */ protected int getMaxFieldWidth() { return convertWidthInCharsToPixels(40); } /** * Creates the controls for the container field. Expects a GridLayout with at least 3 columns. * @param parent The parent composite * @param nColumns The number of columns to span */ protected void createContainerControls(Composite parent, int nColumns) { fContainerDialogField.doFillIntoGrid(parent, nColumns); LayoutUtil.setWidthHint(fContainerDialogField.getTextControl(null), getMaxFieldWidth()); } protected void setFocusOnContainer() { fContainerDialogField.setFocus(); } // -------- ContainerFieldAdapter -------- private class ContainerFieldAdapter implements IStringButtonAdapter, IDialogFieldListener { // -------- IStringButtonAdapter public void changeControlPressed(DialogField field) { containerChangeControlPressed(field); } // -------- IDialogFieldListener public void dialogFieldChanged(DialogField field) { containerDialogFieldChanged(field); } } private void containerChangeControlPressed(DialogField field) { // take the current jproject as init element of the dialog IPackageFragmentRoot root= getPackageFragmentRoot(); root= chooseSourceContainer(root); if (root != null) { setPackageFragmentRoot(root, true); } } private void containerDialogFieldChanged(DialogField field) { if (field == fContainerDialogField) { fContainerStatus= containerChanged(); } // tell all others handleFieldChanged(CONTAINER); } // ----------- validation ---------- /** * Called after the container field has changed. * Updates the model and returns the status. * Model is only valid if returned status is OK */ protected IStatus containerChanged() { StatusInfo status= new StatusInfo(); fCurrRoot= null; String str= getPackageFragmentRootText(); if (str.length() == 0) { status.setError(NewWizardMessages.getString("NewContainerWizardPage.error.EnterContainerName")); //$NON-NLS-1$ return status; } IPath path= new Path(str); IResource res= fWorkspaceRoot.findMember(path); if (res != null) { int resType= res.getType(); if (resType == IResource.PROJECT || resType == IResource.FOLDER) { IProject proj= res.getProject(); if (!proj.isOpen()) { status.setError(NewWizardMessages.getFormattedString("NewContainerWizardPage.error.ProjectClosed", proj.getFullPath().toString())); //$NON-NLS-1$ return status; } IJavaProject jproject= JavaCore.create(proj); fCurrRoot= jproject.getPackageFragmentRoot(res); if (fCurrRoot.exists()) { try { if (!proj.hasNature(JavaCore.NATURE_ID)) { if (resType == IResource.PROJECT) { status.setWarning(NewWizardMessages.getString("NewContainerWizardPage.warning.NotAJavaProject")); //$NON-NLS-1$ } else { status.setWarning(NewWizardMessages.getString("NewContainerWizardPage.warning.NotInAJavaProject")); //$NON-NLS-1$ } return status; } } catch (CoreException e) { status.setWarning(NewWizardMessages.getString("NewContainerWizardPage.warning.NotAJavaProject")); //$NON-NLS-1$ } try { if (!jproject.isOnClasspath(fCurrRoot)) { status.setWarning(NewWizardMessages.getFormattedString("NewContainerWizardPage.warning.NotOnClassPath", str)); //$NON-NLS-1$ } } catch (JavaModelException e) { status.setWarning(NewWizardMessages.getFormattedString("NewContainerWizardPage.warning.NotOnClassPath", str)); //$NON-NLS-1$ } if (fCurrRoot.isArchive()) { status.setError(NewWizardMessages.getFormattedString("NewContainerWizardPage.error.ContainerIsBinary", str)); //$NON-NLS-1$ return status; } } return status; } else { status.setError(NewWizardMessages.getFormattedString("NewContainerWizardPage.error.NotAFolder", str)); //$NON-NLS-1$ return status; } } else { status.setError(NewWizardMessages.getFormattedString("NewContainerWizardPage.error.ContainerDoesNotExist", str)); //$NON-NLS-1$ return status; } } // -------- update message ---------------- /** * Called when a field on a page changed. Every sub type is responsible to * call this method when a field on its page has changed. * Subtypes override (extend) the method to add verification when own field has a * dependency to an other field. (for example the class name input must be verified * again, when the package field changes (check for duplicated class names)) * @param fieldName The name of the field that has changed (field id) */ protected void handleFieldChanged(String fieldName) { } // ---- get ---------------- /** * Returns the workspace root. */ protected IWorkspaceRoot getWorkspaceRoot() { return fWorkspaceRoot; } /** * Returns the PackageFragmentRoot corresponding to the current input. * @return the PackageFragmentRoot or <code>null</code> if the current * input is not a valid source folder */ public IPackageFragmentRoot getPackageFragmentRoot() { return fCurrRoot; } /** * Returns the text of the container field. */ public String getPackageFragmentRootText() { return fContainerDialogField.getText(); } /** * Sets the current PackageFragmentRoot (model and text field). * @param canBeModified Selects if the container field can be changed by the user */ public void setPackageFragmentRoot(IPackageFragmentRoot root, boolean canBeModified) { fCurrRoot= root; String str= (root == null) ? "" : root.getPath().makeRelative().toString(); //$NON-NLS-1$ fContainerDialogField.setText(str); fContainerDialogField.setEnabled(canBeModified); } // ------------- choose source container dialog private IPackageFragmentRoot chooseSourceContainer(IJavaElement initElement) { Class[] acceptedClasses= new Class[] { IPackageFragmentRoot.class, IJavaProject.class }; TypedElementSelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, false) { public boolean isSelectedValid(Object element) { try { if (element instanceof IJavaProject) { IJavaProject jproject= (IJavaProject)element; IPath path= jproject.getProject().getFullPath(); return (jproject.findPackageFragmentRoot(path) != null); } else if (element instanceof IPackageFragmentRoot) { return (((IPackageFragmentRoot)element).getKind() == IPackageFragmentRoot.K_SOURCE); } return true; } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // just log, no ui in validation } return false; } }; acceptedClasses= new Class[] { IJavaModel.class, IPackageFragmentRoot.class, IJavaProject.class }; ViewerFilter filter= new TypedViewerFilter(acceptedClasses) { public boolean select(Viewer viewer, Object parent, Object element) { if (element instanceof IPackageFragmentRoot) { try { return (((IPackageFragmentRoot)element).getKind() == IPackageFragmentRoot.K_SOURCE); } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // just log, no ui in validation return false; } } return super.select(viewer, parent, element); } }; JavaElementContentProvider provider= new JavaElementContentProvider(); ILabelProvider labelProvider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), labelProvider, provider); dialog.setValidator(validator); dialog.setSorter(new JavaElementSorter()); dialog.setTitle(NewWizardMessages.getString("NewContainerWizardPage.ChooseSourceContainerDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("NewContainerWizardPage.ChooseSourceContainerDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(JavaCore.create(fWorkspaceRoot)); dialog.setInitialSelection(initElement); if (dialog.open() == dialog.OK) { Object element= dialog.getFirstResult(); if (element instanceof IJavaProject) { IJavaProject jproject= (IJavaProject)element; return jproject.getPackageFragmentRoot(jproject.getProject()); } else if (element instanceof IPackageFragmentRoot) { return (IPackageFragmentRoot)element; } return null; } return null; } }
18,137
Bug 18137 No uncaught exception are thrown by selected code. - .. But there is an uncaught IOExcption
eclipse build=20020521 Consider code 1 public Object foo(String name) 2 { 3 Object a; 4 a = super.createFilmType(name, false); 5 return a; 6 } *** Line 4 throws an IOException. So I select that line and select contextmenu source\surround with try ... I get a message "No uncaught exceptions are thrown..Catch java.lang RunTimeExc?" This is incorrect!
verified fixed
2571696
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:32:22Z
2002-05-29T08:13:20Z
org.eclipse.jdt.ui/core
18,137
Bug 18137 No uncaught exception are thrown by selected code. - .. But there is an uncaught IOExcption
eclipse build=20020521 Consider code 1 public Object foo(String name) 2 { 3 Object a; 4 a = super.createFilmType(name, false); 5 return a; 6 } *** Line 4 throws an IOException. So I select that line and select contextmenu source\surround with try ... I get a message "No uncaught exceptions are thrown..Catch java.lang RunTimeExc?" This is incorrect!
verified fixed
2571696
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:32:22Z
2002-05-29T08:13:20Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExceptionAnalyzer.java
18,137
Bug 18137 No uncaught exception are thrown by selected code. - .. But there is an uncaught IOExcption
eclipse build=20020521 Consider code 1 public Object foo(String name) 2 { 3 Object a; 4 a = super.createFilmType(name, false); 5 return a; 6 } *** Line 4 throws an IOException. So I select that line and select contextmenu source\surround with try ... I get a message "No uncaught exceptions are thrown..Catch java.lang RunTimeExc?" This is incorrect!
verified fixed
2571696
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:32:22Z
2002-05-29T08:13:20Z
org.eclipse.jdt.ui/core
18,137
Bug 18137 No uncaught exception are thrown by selected code. - .. But there is an uncaught IOExcption
eclipse build=20020521 Consider code 1 public Object foo(String name) 2 { 3 Object a; 4 a = super.createFilmType(name, false); 5 return a; 6 } *** Line 4 throws an IOException. So I select that line and select contextmenu source\surround with try ... I get a message "No uncaught exceptions are thrown..Catch java.lang RunTimeExc?" This is incorrect!
verified fixed
2571696
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:32:22Z
2002-05-29T08:13:20Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/surround/ExceptionAnalyzer.java
18,137
Bug 18137 No uncaught exception are thrown by selected code. - .. But there is an uncaught IOExcption
eclipse build=20020521 Consider code 1 public Object foo(String name) 2 { 3 Object a; 4 a = super.createFilmType(name, false); 5 return a; 6 } *** Line 4 throws an IOException. So I select that line and select contextmenu source\surround with try ... I get a message "No uncaught exceptions are thrown..Catch java.lang RunTimeExc?" This is incorrect!
verified fixed
2571696
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:32:22Z
2002-05-29T08:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/GenerateActionGroup.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.part.Page; import org.eclipse.ui.texteditor.ConvertLineDelimitersAction; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.AddBookmarkAction; import org.eclipse.jdt.internal.ui.javaeditor.AddImportOnSelectionAction; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.AddTaskAction; import org.eclipse.jdt.ui.IContextMenuConstants; /** * Action group that adds the source and generate actions to a context menu and * action bar. * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class GenerateActionGroup extends ActionGroup { private boolean fEditorIsOwner; private IWorkbenchSite fSite; private String fGroupName= IContextMenuConstants.GROUP_SOURCE; private List fRegisteredSelectionListeners; private AddImportOnSelectionAction fAddImport; private OverrideMethodsAction fOverrideMethods; private AddGetterSetterAction fAddGetterSetter; private AddUnimplementedConstructorsAction fAddUnimplementedConstructors; private AddJavaDocStubAction fAddJavaDocStub; private AddBookmarkAction fAddBookmark; private AddTaskAction fAddTaskAction; private ExternalizeStringsAction fExternalizeStrings; private FindStringsToExternalizeAction fFindStringsToExternalize; private SurroundWithTryCatchAction fSurroundWithTryCatch; private OrganizeImportsAction fOrganizeImports; private ConvertLineDelimitersAction fConvertToWindows; private ConvertLineDelimitersAction fConvertToUNIX; private ConvertLineDelimitersAction fConvertToMac; /** * Creates a new <code>GenerateActionGroup</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public GenerateActionGroup(CompilationUnitEditor editor, String groupName) { fSite= editor.getSite(); fEditorIsOwner= true; fGroupName= groupName; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fAddImport= new AddImportOnSelectionAction(editor); fAddImport.setActionDefinitionId(IJavaEditorActionDefinitionIds.ADD_IMPORT); fAddImport.update(); editor.setAction("AddImport", fAddImport); //$NON-NLS-1$ fOrganizeImports= new OrganizeImportsAction(editor); fOrganizeImports.setActionDefinitionId(IJavaEditorActionDefinitionIds.ORGANIZE_IMPORTS); fOrganizeImports.editorStateChanged(); editor.setAction("OrganizeImports", fOrganizeImports); //$NON-NLS-1$ fOverrideMethods= new OverrideMethodsAction(editor); fOverrideMethods.setActionDefinitionId(IJavaEditorActionDefinitionIds.OVERRIDE_METHODS); fOverrideMethods.editorStateChanged(); editor.setAction("OverrideMethods", fOverrideMethods); //$NON-NLS-1$ fAddGetterSetter= new AddGetterSetterAction(editor); fAddGetterSetter.setActionDefinitionId(IJavaEditorActionDefinitionIds.CREATE_GETTER_SETTER); fAddGetterSetter.editorStateChanged(); editor.setAction("AddGetterSetter", fAddGetterSetter); //$NON-NLS-1$ fAddUnimplementedConstructors= new AddUnimplementedConstructorsAction(editor); fAddUnimplementedConstructors.setActionDefinitionId(IJavaEditorActionDefinitionIds.ADD_UNIMPLEMENTED_CONTRUCTORS); fAddUnimplementedConstructors.editorStateChanged(); editor.setAction("AddUnimplementedConstructors", fAddUnimplementedConstructors); //$NON-NLS-1$ fAddJavaDocStub= new AddJavaDocStubAction(editor); fAddJavaDocStub.editorStateChanged(); fSurroundWithTryCatch= new SurroundWithTryCatchAction(editor); fSurroundWithTryCatch.setActionDefinitionId(IJavaEditorActionDefinitionIds.SURROUND_WITH_TRY_CATCH); fSurroundWithTryCatch.update(selection); provider.addSelectionChangedListener(fSurroundWithTryCatch); editor.setAction("SurroundWithTryCatch", fSurroundWithTryCatch); //$NON-NLS-1$ fExternalizeStrings= new ExternalizeStringsAction(editor); fExternalizeStrings.setActionDefinitionId(IJavaEditorActionDefinitionIds.EXTERNALIZE_STRINGS); fExternalizeStrings.editorStateChanged(); editor.setAction("ExternalizeStrings", fExternalizeStrings); //$NON-NLS-1$ fConvertToWindows= new ConvertLineDelimitersAction(editor, "\r\n"); //$NON-NLS-1$ fConvertToWindows.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_WINDOWS); editor.setAction("ConvertLineDelimitersToWindows", fConvertToWindows); //$NON-NLS-1$ fConvertToUNIX= new ConvertLineDelimitersAction(editor, "\n"); //$NON-NLS-1$ fConvertToUNIX.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_UNIX); editor.setAction("ConvertLineDelimitersToUNIX", fConvertToUNIX); //$NON-NLS-1$ fConvertToMac= new ConvertLineDelimitersAction(editor, "\r"); //$NON-NLS-1$ fConvertToMac.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_MAC); editor.setAction("ConvertLineDelimitersToMac", fConvertToMac); //$NON-NLS-1$ } /** * Creates a new <code>GenerateActionGroup</code>. * * @param page the page that owns this action group */ public GenerateActionGroup(Page page) { this(page.getSite()); } /** * Creates a new <code>GenerateActionGroup</code>. * * @param part the view part that owns this action group */ public GenerateActionGroup(IViewPart part) { this(part.getSite()); } private GenerateActionGroup(IWorkbenchSite site) { fSite= site; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fOverrideMethods= new OverrideMethodsAction(site); fAddGetterSetter= new AddGetterSetterAction(site); fAddUnimplementedConstructors= new AddUnimplementedConstructorsAction(site); fAddJavaDocStub= new AddJavaDocStubAction(site); fAddBookmark= new AddBookmarkAction(site.getShell()); fAddTaskAction= new AddTaskAction(site); fExternalizeStrings= new ExternalizeStringsAction(site); fFindStringsToExternalize= new FindStringsToExternalizeAction(site); fOrganizeImports= new OrganizeImportsAction(site); fOverrideMethods.update(selection); fAddGetterSetter.update(selection); fAddUnimplementedConstructors.update(selection); fAddJavaDocStub.update(selection); fExternalizeStrings.update(selection); fFindStringsToExternalize.update(selection); fAddTaskAction.update(selection); fOrganizeImports.update(selection); if (selection instanceof IStructuredSelection) { IStructuredSelection ss= (IStructuredSelection)selection; fAddBookmark.selectionChanged(ss); } else { fAddBookmark.setEnabled(false); } registerSelectionListener(provider, fOverrideMethods); registerSelectionListener(provider, fAddGetterSetter); registerSelectionListener(provider, fAddUnimplementedConstructors); registerSelectionListener(provider, fAddJavaDocStub); registerSelectionListener(provider, fAddBookmark); registerSelectionListener(provider, fExternalizeStrings); registerSelectionListener(provider, fFindStringsToExternalize); registerSelectionListener(provider, fOrganizeImports); registerSelectionListener(provider, fAddTaskAction); } private void registerSelectionListener(ISelectionProvider provider, ISelectionChangedListener listener) { if (fRegisteredSelectionListeners == null) fRegisteredSelectionListeners= new ArrayList(12); provider.addSelectionChangedListener(listener); fRegisteredSelectionListeners.add(listener); } /** * The state of the editor owning this action group has changed. * This method does nothing if the group's owner isn't an * editor. * <p> * Note: This method is for internal use only. Clients should not call this method. * </p> */ public void editorStateChanged() { Assert.isTrue(fEditorIsOwner); fAddImport.update(); fExternalizeStrings.editorStateChanged(); fOrganizeImports.editorStateChanged(); fOverrideMethods.editorStateChanged(); fAddUnimplementedConstructors.editorStateChanged(); fAddJavaDocStub.editorStateChanged(); fSurroundWithTryCatch.editorStateChanged(); fAddGetterSetter.editorStateChanged(); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillActionBars(IActionBars actionBar) { super.fillActionBars(actionBar); setGlobalActionHandlers(actionBar); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillContextMenu(IMenuManager menu) { super.fillContextMenu(menu); if (fEditorIsOwner) { IMenuManager subMenu= createEditorSubMenu(menu); if (subMenu != null) menu.appendToGroup(fGroupName, subMenu); } else { appendToGroup(menu, fOrganizeImports); appendToGroup(menu, fOverrideMethods); appendToGroup(menu, fAddGetterSetter); appendToGroup(menu, fAddUnimplementedConstructors); appendToGroup(menu, fAddJavaDocStub); appendToGroup(menu, fAddBookmark); } } private IMenuManager createEditorSubMenu(IMenuManager mainMenu) { IMenuManager result= new MenuManager(ActionMessages.getString("SourceMenu.label")); //$NON-NLS-1$ int added= 0; added+= addAction(result, fAddImport); added+= addAction(result, fOrganizeImports); result.add(new Separator()); added+= addAction(result, fOverrideMethods); added+= addAction(result, fAddGetterSetter); added+= addAction(result, fAddUnimplementedConstructors); added+= addAction(result, fAddJavaDocStub); added+= addAction(result, fAddBookmark); result.add(new Separator()); added+= addAction(result, fSurroundWithTryCatch); added+= addAction(result, fExternalizeStrings); if (added == 0) result= null; return result; } /* (non-Javadoc) * Method declared in ActionGroup */ public void dispose() { if (fRegisteredSelectionListeners != null) { ISelectionProvider provider= fSite.getSelectionProvider(); for (Iterator iter= fRegisteredSelectionListeners.iterator(); iter.hasNext();) { ISelectionChangedListener listener= (ISelectionChangedListener) iter.next(); provider.removeSelectionChangedListener(listener); } } super.dispose(); } private void setGlobalActionHandlers(IActionBars actionBar) { actionBar.setGlobalActionHandler(JdtActionConstants.ADD_IMPORT, fAddImport); actionBar.setGlobalActionHandler(JdtActionConstants.SURROUND_WITH_TRY_CATCH, fSurroundWithTryCatch); actionBar.setGlobalActionHandler(JdtActionConstants.OVERRIDE_METHODS, fOverrideMethods); actionBar.setGlobalActionHandler(JdtActionConstants.GENERATE_GETTER_SETTER, fAddGetterSetter); actionBar.setGlobalActionHandler(JdtActionConstants.ADD_CONSTRUCTOR_FROM_SUPERCLASS, fAddUnimplementedConstructors); actionBar.setGlobalActionHandler(JdtActionConstants.ADD_JAVA_DOC_COMMENT, fAddJavaDocStub); actionBar.setGlobalActionHandler(IWorkbenchActionConstants.BOOKMARK, fAddBookmark); actionBar.setGlobalActionHandler(IWorkbenchActionConstants.ADD_TASK, fAddTaskAction); actionBar.setGlobalActionHandler(JdtActionConstants.EXTERNALIZE_STRINGS, fExternalizeStrings); actionBar.setGlobalActionHandler(JdtActionConstants.FIND_STRINGS_TO_EXTERNALIZE, fFindStringsToExternalize); actionBar.setGlobalActionHandler(JdtActionConstants.ORGANIZE_IMPORTS, fOrganizeImports); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_WINDOWS, fConvertToWindows); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_UNIX, fConvertToUNIX); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_MAC, fConvertToMac); } private int appendToGroup(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) { menu.appendToGroup(fGroupName, action); return 1; } return 0; } private int addAction(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) { menu.add(action); return 1; } return 0; } }
18,292
Bug 18292 Move type fails
I was trying to move OptionalMessageDialog from jdt.internal.ui.search to .jdt.internal.ui.dialogs (where it now is). !ENTRY org.eclipse.jdt.ui 4 1 May 30, 2002 14:21:40.938 !MESSAGE Internal Error !STACK 0 java.lang.reflect.InvocationTargetException: java.lang.ArrayStoreException at java.lang.System.arraycopy(Native Method) at java.util.ArrayList.toArray(ArrayList.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.structure.ReferenceFinderUtil.getTypesReferencedIn(ReferenceFinderUtil.java:33) at org.eclipse.jdt.internal.corext.refactoring.reorg.MoveRefactoring.checkReferencesToNotPublicTypes(MoveRefactoring.java:100) at org.eclipse.jdt.internal.corext.refactoring.reorg.MoveRefactoring.checkInput(MoveRefactoring.java:82) at org.eclipse.jdt.internal.ui.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:58) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:93) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:98)
resolved fixed
365dd50
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:45:27Z
2002-05-30T12:00:00Z
org.eclipse.jdt.ui/core
18,292
Bug 18292 Move type fails
I was trying to move OptionalMessageDialog from jdt.internal.ui.search to .jdt.internal.ui.dialogs (where it now is). !ENTRY org.eclipse.jdt.ui 4 1 May 30, 2002 14:21:40.938 !MESSAGE Internal Error !STACK 0 java.lang.reflect.InvocationTargetException: java.lang.ArrayStoreException at java.lang.System.arraycopy(Native Method) at java.util.ArrayList.toArray(ArrayList.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.structure.ReferenceFinderUtil.getTypesReferencedIn(ReferenceFinderUtil.java:33) at org.eclipse.jdt.internal.corext.refactoring.reorg.MoveRefactoring.checkReferencesToNotPublicTypes(MoveRefactoring.java:100) at org.eclipse.jdt.internal.corext.refactoring.reorg.MoveRefactoring.checkInput(MoveRefactoring.java:82) at org.eclipse.jdt.internal.ui.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:58) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:93) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:98)
resolved fixed
365dd50
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:45:27Z
2002-05-30T12:00:00Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/structure/ReferenceFinderUtil.java
18,291
Bug 18291 incorrect dialog title in surround with try.catch
the title is 'Surround with &try/catch block' mnemonics do not work well in dialog titles
verified fixed
1492382
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T12:56:48Z
2002-05-30T12:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/SurroundWithTryCatchAction.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.lang.reflect.InvocationTargetException; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.internal.corext.refactoring.base.ChangeContext; import org.eclipse.jdt.internal.corext.refactoring.base.JavaSourceContext; import org.eclipse.jdt.internal.corext.refactoring.base.RefactoringStatus; import org.eclipse.jdt.internal.corext.refactoring.base.RefactoringStatusEntry; import org.eclipse.jdt.internal.corext.refactoring.surround.ISurroundWithTryCatchQuery; import org.eclipse.jdt.internal.corext.refactoring.surround.SurroundWithTryCatchRefactoring; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.preferences.CodeFormatterPreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation; import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringErrorDialogUtil; import org.eclipse.jdt.internal.ui.refactoring.changes.AbortChangeExceptionHandler; import org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * Action to surround a set of statements with a try/catch block. * * @since 2.0 */ public class SurroundWithTryCatchAction extends SelectionDispatchAction { private CompilationUnitEditor fEditor; private static final String TITLE= RefactoringMessages.getString("SurroundWithTryCatchAction.title"); //$NON-NLS-1$ private static class Query implements ISurroundWithTryCatchQuery { private Shell fParent; public Query(Shell shell) { fParent= shell; } public boolean catchRuntimeException() { return MessageDialog.openQuestion(fParent, TITLE, RefactoringMessages.getString("SurroundWithTryCatchAction.no_exceptions")); //$NON-NLS-1$ } } /** * Creates a new <code>SurroundWithTryCatchAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public SurroundWithTryCatchAction(CompilationUnitEditor editor) { super(editor.getEditorSite()); setText(TITLE); fEditor= editor; setEnabled(checkEditor()); } protected void run(ITextSelection selection) { SurroundWithTryCatchRefactoring refactoring= new SurroundWithTryCatchRefactoring(getCompilationUnit(), selection, JavaPreferencesSettings.getCodeGenerationSettings(), new Query(getShell())); try { RefactoringStatus status= refactoring.checkActivation(new NullProgressMonitor()); if (status.hasFatalError()) { RefactoringErrorDialogUtil.open(TITLE, status); RefactoringStatusEntry entry= status.getFirstEntry(RefactoringStatus.FATAL); if (entry.getContext() instanceof JavaSourceContext && fEditor != null) { JavaSourceContext context= (JavaSourceContext)entry.getContext(); ISourceRange range= context.getSourceRange(); fEditor.setHighlightRange(range.getOffset(), range.getLength(), true); } return; } if (refactoring.stopExecution()) return; PerformChangeOperation op= new PerformChangeOperation(refactoring.createChange(new NullProgressMonitor())); op.setChangeContext(new ChangeContext(new AbortChangeExceptionHandler())); new BusyIndicatorRunnableContext().run(false, false, op); } catch (CoreException e) { ExceptionHandler.handle(e, TITLE, RefactoringMessages.getString("SurroundWithTryCatchAction.exception")); //$NON-NLS-1$ } catch (InvocationTargetException e) { ExceptionHandler.handle(e, TITLE, RefactoringMessages.getString("SurroundWithTryCatchAction.exception")); //$NON-NLS-1$ } catch (InterruptedException e) { // not cancelable } } /* package */ void editorStateChanged() { setEnabled(fEditor != null && !fEditor.isEditorInputReadOnly() && getCompilationUnit() != null); } protected void selectionChanged(ITextSelection selection) { setEnabled(selection.getLength() > 0 && checkEditor()); } private final ICompilationUnit getCompilationUnit() { return SelectionConverter.getInputAsCompilationUnit(fEditor); } private boolean checkEditor() { return fEditor != null && !fEditor.isEditorInputReadOnly() && getCompilationUnit() != null; } }
17,916
Bug 17916 junit: progress max-filled when test still running
F1 the icon-progress is fully filled while test are still running (in my case, it was filled at ca. 1100 out of 1300 tests) what happens if the last test fails? (is the last 'brick' repainted?)
resolved fixed
3e1416d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T13:34:15Z
2002-05-27T11:46:40Z
org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ProgressImages.java
package org.eclipse.jdt.internal.junit.ui; import java.net.MalformedURLException; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.swt.graphics.Image; /** * Manages a set of images that can show progress in the image itself. */ public class ProgressImages { static final int PROGRESS_STEPS= 9; static final String BASE= "prgss/"; //$NON-NLS-1$ static final String FAILURE= "ff"; //$NON-NLS-1$ static final String OK= "ss"; //$NON-NLS-1$ Image[] fOKImages= new Image[PROGRESS_STEPS]; Image[] fFailureImages= new Image[PROGRESS_STEPS]; Image fMissingImage= null; void load() { if (isLoaded()) return; for (int i= 0; i < PROGRESS_STEPS; i++) { String okname= BASE+OK+Integer.toString(i+1)+".gif"; //$NON-NLS-1$ fOKImages[i]= createImage(okname); String failurename= BASE+FAILURE+Integer.toString(i+1)+".gif"; //$NON-NLS-1$ fFailureImages[i]= createImage(failurename); } } Image createImage(String name) { try { ImageDescriptor id= ImageDescriptor.createFromURL(JUnitPlugin.makeIconFileURL(name)); return id.createImage(); } catch (MalformedURLException e) { // fall through } if (fMissingImage == null) fMissingImage= ImageDescriptor.getMissingImageDescriptor().createImage(); return fMissingImage; } public void dispose() { if (!isLoaded()) return; if (fMissingImage != null) fMissingImage.dispose(); for (int i= 0; i < PROGRESS_STEPS; i++) { fOKImages[i].dispose(); fOKImages[i]= null; fFailureImages[i].dispose(); fFailureImages[i]= null; } } public Image getImage(int current, int total, int errors, int failures) { if (!isLoaded()) load(); if (total == 0) return fOKImages[0]; int index= (current*PROGRESS_STEPS)/total; index= Math.min(Math.max(0, index), PROGRESS_STEPS-1); if (errors + failures == 0) return fOKImages[index]; return fFailureImages[index]; } boolean isLoaded() { return fOKImages[0] != null; } }
17,292
Bug 17292 Inconsistent Undo behaviour for Cut/Copy/Paste in outline
Build 20020521 (freeze 1) 1) Open a java editor on some class 2) In the content outline, select a method and do Ctrl+X to cut 3) Notice in the menus, Edit->Undo and Refactor->Undo are disabled 4) Now select the type node in the content outline, and Ctrl+V to paste 5) Still, neither Undo action is enabled 6) Now click inside the editor area to give it focus. 7) Now "Edit->Undo" is possible. So, the problems are: 1) Undo is not consistent, it's available for Paste but not Cut. 2) Even when undo is possible, it only becomes enabled when the editor is activated.
resolved wontfix
0408678
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T13:50:39Z
2002-05-23T13:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/JavaOutlinePage.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.Enumeration; import java.util.Hashtable; import java.util.List; import java.util.Vector; import org.eclipse.core.resources.IResource; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Item; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.Tree; import org.eclipse.swt.widgets.Widget; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.util.Assert; import org.eclipse.jface.util.ListenerList; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.IBaseLabelProvider; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.LabelProviderChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.IActionBars; import org.eclipse.ui.PlatformUI; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.part.IPageSite; import org.eclipse.ui.part.Page; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.contentoutline.IContentOutlinePage; import org.eclipse.jdt.core.ElementChangedEvent; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IElementChangedListener; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaElementDelta; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IOpenable; import org.eclipse.jdt.core.IParent; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.JavaElementSorter; import org.eclipse.jdt.ui.OverrideIndicatorLabelDecorator; import org.eclipse.jdt.ui.ProblemsLabelDecorator.ProblemsLabelChangedEvent; import org.eclipse.jdt.ui.actions.CCPActionGroup; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.JavaSearchActionGroup; import org.eclipse.jdt.ui.actions.JdtActionConstants; import org.eclipse.jdt.ui.actions.MemberFilterActionGroup; import org.eclipse.jdt.ui.actions.OpenAction; import org.eclipse.jdt.ui.actions.OpenViewActionGroup; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.actions.ShowActionGroup; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.packageview.SelectionTransferDragAdapter; import org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; /** * The content outline page of the Java editor. The viewer implements a proprietary * update mechanism based on Java model deltas. It does not react on domain changes. * It is specified to show the content of ICompilationUnits and IClassFiles. * Pulishes its context menu under <code>JavaPlugin.getDefault().getPluginId() + ".outliner"</code>. */ class JavaOutlinePage extends Page implements IContentOutlinePage { /** * The element change listener of the java outline viewer. * @see IElementChangedListener */ class ElementChangedListener implements IElementChangedListener { public void elementChanged(final ElementChangedEvent e) { if (getControl() == null) return; Display d= getControl().getDisplay(); if (d != null) { d.asyncExec(new Runnable() { public void run() { IJavaElementDelta delta= findElement( (ICompilationUnit) fInput, e.getDelta()); if (delta != null && fOutlineViewer != null) { fOutlineViewer.reconcile(delta); } } }); } } protected IJavaElementDelta findElement(ICompilationUnit unit, IJavaElementDelta delta) { if (delta == null || unit == null) return null; IJavaElement element= delta.getElement(); if (unit.equals(element)) return delta; if (element.getElementType() > IJavaElement.CLASS_FILE) return null; IJavaElementDelta[] children= delta.getAffectedChildren(); if (children == null || children.length == 0) return null; for (int i= 0; i < children.length; i++) { IJavaElementDelta d= findElement(unit, children[i]); if (d != null) return d; } return null; } }; /** * Content provider for the children of an ICompilationUnit or * an IClassFile * @see ITreeContentProvider */ class ChildrenProvider implements ITreeContentProvider { private ElementChangedListener fListener; protected boolean matches(IJavaElement element) { if (element.getElementType() == IJavaElement.METHOD) { String name= element.getElementName(); return (name != null && name.indexOf('<') >= 0); } return false; } protected IJavaElement[] filter(IJavaElement[] children) { boolean initializers= false; for (int i= 0; i < children.length; i++) { if (matches(children[i])) { initializers= true; break; } } if (!initializers) return children; Vector v= new Vector(); for (int i= 0; i < children.length; i++) { if (matches(children[i])) continue; v.addElement(children[i]); } IJavaElement[] result= new IJavaElement[v.size()]; v.copyInto(result); return result; } public Object[] getChildren(Object parent) { if (parent instanceof IParent) { IParent c= (IParent) parent; try { return filter(c.getChildren()); } catch (JavaModelException x) { JavaPlugin.getDefault().logErrorStatus(JavaEditorMessages.getString("JavaOutlinePage.error.ChildrenProvider.getChildren.message1"), x.getStatus()); //$NON-NLS-1$ } } return new Object[0]; } public Object[] getElements(Object parent) { return getChildren(parent); } public Object getParent(Object child) { if (child instanceof IJavaElement) { IJavaElement e= (IJavaElement) child; return e.getParent(); } return null; } public boolean hasChildren(Object parent) { if (parent instanceof IParent) { IParent c= (IParent) parent; try { IJavaElement[] children= filter(c.getChildren()); return (children != null && children.length > 0); } catch (JavaModelException x) { JavaPlugin.getDefault().logErrorStatus(JavaEditorMessages.getString("JavaOutlinePage.error.ChildrenProvider.hasChildren.message1"), x.getStatus()); //$NON-NLS-1$ } } return false; } public boolean isDeleted(Object o) { return false; } public void dispose() { if (fListener != null) { JavaCore.removeElementChangedListener(fListener); fListener= null; } } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { boolean isCU= (newInput instanceof ICompilationUnit); if (isCU && fListener == null) { fListener= new ElementChangedListener(); JavaCore.addElementChangedListener(fListener); } else if (!isCU && fListener != null) { JavaCore.removeElementChangedListener(fListener); fListener= null; } } }; class JavaOutlineViewer extends TreeViewer { /** * Indicates an item which has been reused. At the point of * its reuse it has been expanded. This field is used to * communicate between <code>internalExpandToLevel</code> and * <code>reuseTreeItem</code>. */ private Item fReusedExpandedItem; public JavaOutlineViewer(Tree tree) { super(tree); setAutoExpandLevel(ALL_LEVELS); } /** * Investigates the given element change event and if affected incrementally * updates the outline. */ public void reconcile(IJavaElementDelta delta) { if (getSorter() == null) { Widget w= findItem(fInput); if (w != null && !w.isDisposed()) update(w, delta); } else { // just for now refresh(); } } /* * @see TreeViewer#internalExpandToLevel */ protected void internalExpandToLevel(Widget node, int level) { if (node instanceof Item) { Item i= (Item) node; if (i.getData() instanceof IJavaElement) { IJavaElement je= (IJavaElement) i.getData(); if (je.getElementType() == IJavaElement.IMPORT_CONTAINER || isInnerType(je)) { if (i != fReusedExpandedItem) { setExpanded(i, false); return; } } } } super.internalExpandToLevel(node, level); } protected void reuseTreeItem(Item item, Object element) { // remove children Item[] c= getChildren(item); if (c != null && c.length > 0) { if (getExpanded(item)) fReusedExpandedItem= item; for (int k= 0; k < c.length; k++) { if (c[k].getData() != null) disassociate(c[k]); c[k].dispose(); } } updateItem(item, element); updatePlus(item, element); internalExpandToLevel(item, ALL_LEVELS); fReusedExpandedItem= null; } protected boolean mustUpdateParent(IJavaElementDelta delta, IJavaElement element) { if (element instanceof IMethod) { if ((delta.getKind() & IJavaElementDelta.ADDED) != 0) { try { return ((IMethod)element).isMainMethod(); } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } return "main".equals(element.getElementName()); //$NON-NLS-1$ } return false; } protected ISourceRange getSourceRange(IJavaElement element) throws JavaModelException { if (element instanceof IMember) return ((IMember) element).getNameRange(); if (element instanceof ISourceReference) return ((ISourceReference) element).getSourceRange(); return null; } protected boolean overlaps(ISourceRange range, int start, int end) { return start <= (range.getOffset() + range.getLength() - 1) && range.getOffset() <= end; } protected boolean filtered(IJavaElement parent, IJavaElement child) { Object[] result= new Object[] { child }; ViewerFilter[] filters= getFilters(); for (int i= 0; i < filters.length; i++) { result= filters[i].filter(this, parent, result); if (result.length == 0) return true; } return false; } protected void update(Widget w, IJavaElementDelta delta) { Item item; IJavaElement parent= delta.getElement(); IJavaElementDelta[] affected= delta.getAffectedChildren(); Item[] children= getChildren(w); boolean doUpdateParent= false; Vector deletions= new Vector(); Vector additions= new Vector(); for (int i= 0; i < affected.length; i++) { IJavaElementDelta affectedDelta= affected[i]; IJavaElement affectedElement= affectedDelta.getElement(); int status= affected[i].getKind(); // find tree item with affected element int j; for (j= 0; j < children.length; j++) if (affectedElement.equals(children[j].getData())) break; if (j == children.length) { // addition if ((status & IJavaElementDelta.CHANGED) != 0 && (affectedDelta.getFlags() & IJavaElementDelta.F_MODIFIERS) != 0 && !filtered(parent, affectedElement)) { additions.addElement(affectedDelta); } continue; } item= children[j]; // removed if ((status & IJavaElementDelta.REMOVED) != 0) { deletions.addElement(item); doUpdateParent= doUpdateParent || mustUpdateParent(affectedDelta, affectedElement); // changed } else if ((status & IJavaElementDelta.CHANGED) != 0) { int change= affectedDelta.getFlags(); doUpdateParent= doUpdateParent || mustUpdateParent(affectedDelta, affectedElement); if ((change & IJavaElementDelta.F_MODIFIERS) != 0) { if (filtered(parent, affectedElement)) deletions.addElement(item); else updateItem(item, affectedElement); } if ((change & IJavaElementDelta.F_CONTENT) != 0) updateItem(item, affectedElement); if ((change & IJavaElementDelta.F_CHILDREN) != 0) update(item, affectedDelta); } } // find all elements to add IJavaElementDelta[] add= delta.getAddedChildren(); if (additions.size() > 0) { IJavaElementDelta[] tmp= new IJavaElementDelta[add.length + additions.size()]; System.arraycopy(add, 0, tmp, 0, add.length); for (int i= 0; i < additions.size(); i++) tmp[i + add.length]= (IJavaElementDelta) additions.elementAt(i); add= tmp; } // add at the right position go2: for (int i= 0; i < add.length; i++) { try { IJavaElement e= add[i].getElement(); if (filtered(parent, e)) continue go2; doUpdateParent= doUpdateParent || mustUpdateParent(add[i], e); ISourceRange rng= getSourceRange(e); int start= rng.getOffset(); int end= start + rng.getLength() - 1; Item last= null; item= null; children= getChildren(w); for (int j= 0; j < children.length; j++) { item= children[j]; IJavaElement r= (IJavaElement) item.getData(); if (r == null) { // parent node collapsed and not be opened before -> do nothing continue go2; } try { rng= getSourceRange(r); if (overlaps(rng, start, end)) { // be tolerant if the delta is not correct, or if // the tree has been updated other than by a delta reuseTreeItem(item, e); continue go2; } else if (rng.getOffset() > start) { if (last != null && deletions.contains(last)) { // reuse item deletions.removeElement(last); reuseTreeItem(last, (Object) e); } else { // nothing to reuse createTreeItem(w, (Object) e, j); } continue go2; } } catch (JavaModelException x) { // stumbled over deleted element } last= item; } // add at the end of the list if (last != null && deletions.contains(last)) { // reuse item deletions.removeElement(last); reuseTreeItem(last, e); } else { // nothing to reuse createTreeItem(w, e, -1); } } catch (JavaModelException x) { // the element to be added is not present -> don't add it } } // remove items which haven't been reused Enumeration e= deletions.elements(); while (e.hasMoreElements()) { item= (Item) e.nextElement(); disassociate(item); item.dispose(); } if (doUpdateParent) updateItem(w, delta.getElement()); } /* * @see ContentViewer#handleLabelProviderChanged(LabelProviderChangedEvent) */ protected void handleLabelProviderChanged(LabelProviderChangedEvent event) { Object input= getInput(); if (event instanceof ProblemsLabelChangedEvent) { ProblemsLabelChangedEvent e= (ProblemsLabelChangedEvent) event; if (e.isMarkerChange() && input instanceof ICompilationUnit) { return; // marker changes can be ignored } } // look if the underlying resource changed Object[] changed= event.getElements(); if (changed != null) { IResource resource= getUnderlyingResource(); if (resource != null) { for (int i= 0; i < changed.length; i++) { if (changed[i].equals(resource)) { // change event to a full refresh event= new LabelProviderChangedEvent((IBaseLabelProvider) event.getSource()); break; } } } } super.handleLabelProviderChanged(event); } private IResource getUnderlyingResource() { Object input= getInput(); if (input instanceof ICompilationUnit) { ICompilationUnit cu= (ICompilationUnit) input; if (cu.isWorkingCopy()) { return cu.getOriginalElement().getResource(); } else { return cu.getResource(); } } else if (input instanceof IClassFile) { return ((IClassFile) input).getResource(); } return null; } }; class LexicalSortingAction extends Action { private JavaElementSorter fSorter= new JavaElementSorter(); public LexicalSortingAction() { super(); setText(JavaEditorMessages.getString("JavaOutlinePage.Sort.label")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(this, "alphab_sort_co.gif"); //$NON-NLS-1$ setToolTipText(JavaEditorMessages.getString("JavaOutlinePage.Sort.tooltip")); //$NON-NLS-1$ setDescription(JavaEditorMessages.getString("JavaOutlinePage.Sort.description")); //$NON-NLS-1$ boolean checked= JavaPlugin.getDefault().getPreferenceStore().getBoolean("LexicalSortingAction.isChecked"); //$NON-NLS-1$ valueChanged(checked, false); } public void run() { valueChanged(isChecked(), true); } private void valueChanged(boolean on, boolean store) { setChecked(on); fOutlineViewer.setSorter(on ? fSorter : null); if (store) JavaPlugin.getDefault().getPreferenceStore().setValue("LexicalSortingAction.isChecked", on); //$NON-NLS-1$ } }; private IJavaElement fInput; private String fContextMenuID; private Menu fMenu; private JavaOutlineViewer fOutlineViewer; private JavaEditor fEditor; private MemberFilterActionGroup fMemberFilterActionGroup; private ListenerList fSelectionChangedListeners= new ListenerList(); private Hashtable fActions= new Hashtable(); private TogglePresentationAction fTogglePresentation; private ToggleTextHoverAction fToggleTextHover; private GotoErrorAction fPreviousError; private GotoErrorAction fNextError; private TextOperationAction fShowJavadoc; private OpenAction fOpenAction; private CompositeActionGroup fActionGroups; private CCPActionGroup fCCPActionGroup; public JavaOutlinePage(String contextMenuID, JavaEditor editor) { super(); Assert.isNotNull(editor); fContextMenuID= contextMenuID; fEditor= editor; fTogglePresentation= new TogglePresentationAction(); fToggleTextHover= new ToggleTextHoverAction(); fPreviousError= new GotoErrorAction("PreviousError.", false); //$NON-NLS-1$ fPreviousError.setImageDescriptor(JavaPluginImages.DESC_TOOL_GOTO_PREV_ERROR); fNextError= new GotoErrorAction("NextError.", true); //$NON-NLS-1$ fNextError.setImageDescriptor(JavaPluginImages.DESC_TOOL_GOTO_NEXT_ERROR); fShowJavadoc= (TextOperationAction) fEditor.getAction("ShowJavaDoc"); //$NON-NLS-1$ fTogglePresentation.setEditor(editor); fToggleTextHover.setEditor(editor); fPreviousError.setEditor(editor); fNextError.setEditor(editor); } /* (non-Javadoc) * Method declared on Page */ public void init(IPageSite pageSite) { super.init(pageSite); } /* * @see ISelectionProvider#addSelectionChangedListener(ISelectionChangedListener) */ public void addSelectionChangedListener(ISelectionChangedListener listener) { if (fOutlineViewer != null) fOutlineViewer.addSelectionChangedListener(listener); else fSelectionChangedListeners.add(listener); } /* * @see ISelectionProvider#removeSelectionChangedListener(ISelectionChangedListener) */ public void removeSelectionChangedListener(ISelectionChangedListener listener) { if (fOutlineViewer != null) fOutlineViewer.removeSelectionChangedListener(listener); else fSelectionChangedListeners.remove(listener); } /* * @see ISelectionProvider#setSelection(ISelection) */ public void setSelection(ISelection selection) { if (fOutlineViewer != null) fOutlineViewer.setSelection(selection); } /* * @see ISelectionProvider#getSelection() */ public ISelection getSelection() { if (fOutlineViewer == null) return StructuredSelection.EMPTY; return fOutlineViewer.getSelection(); } private void registerToolbarActions() { IToolBarManager toolBarManager= getSite().getActionBars().getToolBarManager(); if (toolBarManager != null) { Action action= new LexicalSortingAction(); toolBarManager.add(action); fMemberFilterActionGroup= new MemberFilterActionGroup(fOutlineViewer, "JavaOutlineViewer"); //$NON-NLS-1$ fMemberFilterActionGroup.contributeToToolBar(toolBarManager); } } /* * @see IPage#createControl */ public void createControl(Composite parent) { Tree tree= new Tree(parent, SWT.MULTI); ILabelProvider lprovider= new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS | JavaElementLabels.F_APP_TYPE_SIGNATURE, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS, AppearanceAwareLabelProvider.getDecorators(true, new OverrideIndicatorLabelDecorator(null)) ); fOutlineViewer= new JavaOutlineViewer(tree); fOutlineViewer.setContentProvider(new ChildrenProvider()); fOutlineViewer.setLabelProvider(new DecoratingLabelProvider(lprovider, PlatformUI.getWorkbench().getDecoratorManager().getLabelDecorator())); Object[] listeners= fSelectionChangedListeners.getListeners(); for (int i= 0; i < listeners.length; i++) { fSelectionChangedListeners.remove(listeners[i]); fOutlineViewer.addSelectionChangedListener((ISelectionChangedListener) listeners[i]); } MenuManager manager= new MenuManager(fContextMenuID, fContextMenuID); manager.setRemoveAllWhenShown(true); manager.addMenuListener(new IMenuListener() { public void menuAboutToShow(IMenuManager manager) { contextMenuAboutToShow(manager); } }); fMenu= manager.createContextMenu(tree); tree.setMenu(fMenu); IPageSite site= getSite(); site.registerContextMenu(JavaPlugin.getDefault().getPluginId() + ".outline", manager, fOutlineViewer); //$NON-NLS-1$ site.setSelectionProvider(fOutlineViewer); // we must create the groups after we have set the selection provider to the site fOpenAction= new OpenAction(site); site.getSelectionProvider().addSelectionChangedListener(fOpenAction); fActionGroups= new CompositeActionGroup(new ActionGroup[] { new OpenViewActionGroup(this), new ShowActionGroup(this), fCCPActionGroup= new CCPActionGroup(this), new RefactorActionGroup(this), new GenerateActionGroup(this), new JavaSearchActionGroup(this)}); // register global actions IActionBars bars= site.getActionBars(); bars.setGlobalActionHandler(JdtActionConstants.SHOW_PREVIOUS_PROBLEM, fPreviousError); bars.setGlobalActionHandler(JdtActionConstants.SHOW_NEXT_PROBLEM, fNextError); bars.setGlobalActionHandler(JdtActionConstants.SHOW_JAVA_DOC, fShowJavadoc); bars.setGlobalActionHandler(IJavaEditorActionConstants.TOGGLE_PRESENTATION, fTogglePresentation); bars.setGlobalActionHandler(IJavaEditorActionConstants.TOGGLE_TEXT_HOVER, fToggleTextHover); fActionGroups.fillActionBars(bars); bars.setGlobalActionHandler(JdtActionConstants.OPEN, fOpenAction); IStatusLineManager statusLineManager= site.getActionBars().getStatusLineManager(); if (statusLineManager != null) { StatusBarUpdater updater= new StatusBarUpdater(statusLineManager); fOutlineViewer.addSelectionChangedListener(updater); } registerToolbarActions(); fOutlineViewer.setInput(fInput); fOutlineViewer.getControl().addKeyListener(new KeyAdapter() { public void keyPressed(KeyEvent e) { handleKeyReleased(e); } }); initDragAndDrop(); } public void dispose() { if (fEditor == null) return; fEditor.outlinePageClosed(); fEditor= null; Object[] listeners= fSelectionChangedListeners.getListeners(); for (int i= 0; i < listeners.length; i++) fSelectionChangedListeners.remove(listeners[i]); fSelectionChangedListeners= null; if (fMenu != null && !fMenu.isDisposed()) { fMenu.dispose(); fMenu= null; } if (fActionGroups != null) fActionGroups.dispose(); fTogglePresentation.setEditor(null); fToggleTextHover.setEditor(null); fPreviousError.setEditor(null); fNextError.setEditor(null); fOutlineViewer= null; super.dispose(); } public Control getControl() { if (fOutlineViewer != null) return fOutlineViewer.getControl(); return null; } public void setInput(IJavaElement inputElement) { fInput= inputElement; if (fOutlineViewer != null) fOutlineViewer.setInput(fInput); } public void select(ISourceReference reference) { if (fOutlineViewer != null) { ISelection s= fOutlineViewer.getSelection(); if (s instanceof IStructuredSelection) { IStructuredSelection ss= (IStructuredSelection) s; List elements= ss.toList(); if (!elements.contains(reference)) { s= (reference == null ? StructuredSelection.EMPTY : new StructuredSelection(reference)); fOutlineViewer.setSelection(s, true); } } } } public void setAction(String actionID, IAction action) { Assert.isNotNull(actionID); if (action == null) fActions.remove(actionID); else fActions.put(actionID, action); } public IAction getAction(String actionID) { Assert.isNotNull(actionID); return (IAction) fActions.get(actionID); } /** * Convenience method to add the action installed under the given actionID to the * specified group of the menu. */ protected void addAction(IMenuManager menu, String group, String actionID) { IAction action= getAction(actionID); if (action != null) { if (action instanceof IUpdate) ((IUpdate) action).update(); if (action.isEnabled()) { IMenuManager subMenu= menu.findMenuUsingPath(group); if (subMenu != null) subMenu.add(action); else menu.appendToGroup(group, action); } } } protected void contextMenuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); IStructuredSelection selection= (IStructuredSelection)getSelection(); Object element= selection.getFirstElement(); if (fOpenAction.isEnabled() && element instanceof IImportDeclaration && !((IImportDeclaration)element).isOnDemand()) { menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpenAction); } fActionGroups.setContext(new ActionContext(selection)); fActionGroups.fillContextMenu(menu); } /* * @see Page#setFocus() */ public void setFocus() { if (fOutlineViewer != null) fOutlineViewer.getControl().setFocus(); } /** * Checkes whether a given Java element is an inner type. */ private boolean isInnerType(IJavaElement element) { if (element.getElementType() == IJavaElement.TYPE) { IJavaElement parent= element.getParent(); int type= parent.getElementType(); return (type != IJavaElement.COMPILATION_UNIT && type != IJavaElement.CLASS_FILE); } return false; } /** * Handles key events in viewer. */ private void handleKeyReleased(KeyEvent event) { if (event.stateMask != 0) return; IAction action= null; if (event.character == SWT.DEL) { action= fCCPActionGroup.getDeleteAction(); } if (action != null && action.isEnabled()) action.run(); } private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK; Transfer[] transfers= new Transfer[] { LocalSelectionTransfer.getInstance() }; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fOutlineViewer) }; fOutlineViewer.addDropSupport(ops | DND.DROP_DEFAULT, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fOutlineViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fOutlineViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners)); }}
17,646
Bug 17646 Comments in Java Templates don't have right syntax coloring
F1 - open Template preferences - select filecomment observe: the preview doesn't rendere the filecomment using the defined color for comments, but it does use the color for the keyword this.
verified fixed
320f4fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T13:58:00Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/EditTemplateDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Vector; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.custom.VerifyKeyListener; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.KeyListener; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.events.VerifyEvent; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Combo; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ITextListener; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.ITextViewerExtension; import org.eclipse.jface.text.TextEvent; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistProcessor; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.corext.template.ContextTypeRegistry; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.TemplateMessages; import org.eclipse.jdt.internal.corext.template.TemplateTranslator; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.template.TemplateVariableProcessor; import org.eclipse.jdt.internal.ui.util.SWTUtil; /** * Dialog to edit a template. */ public class EditTemplateDialog extends StatusDialog { private static class SimpleJavaSourceViewerConfiguration extends JavaSourceViewerConfiguration { private final IContentAssistProcessor fProcessor; SimpleJavaSourceViewerConfiguration(JavaTextTools tools, ITextEditor editor, IContentAssistProcessor processor) { super(tools, editor); fProcessor= processor; } /* * @see SourceViewerConfiguration#getContentAssistant(ISourceViewer) */ public IContentAssistant getContentAssistant(ISourceViewer sourceViewer) { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); ContentAssistant assistant= new ContentAssistant(); assistant.setContentAssistProcessor(fProcessor, IDocument.DEFAULT_CONTENT_TYPE); assistant.enableAutoInsert(store.getBoolean(ContentAssistPreference.AUTOINSERT)); assistant.enableAutoActivation(store.getBoolean(ContentAssistPreference.AUTOACTIVATION)); assistant.setAutoActivationDelay(store.getInt(ContentAssistPreference.AUTOACTIVATION_DELAY)); assistant.setProposalPopupOrientation(assistant.PROPOSAL_OVERLAY); assistant.setContextInformationPopupOrientation(assistant.CONTEXT_INFO_ABOVE); assistant.setInformationControlCreator(getInformationControlCreator(sourceViewer)); Display display= sourceViewer.getTextWidget().getDisplay(); Color background= createColor(store, ContentAssistPreference.PROPOSALS_BACKGROUND, display); assistant.setContextInformationPopupBackground(background); assistant.setContextSelectorBackground(background); assistant.setProposalSelectorBackground(background); Color foreground= createColor(store, ContentAssistPreference.PROPOSALS_FOREGROUND, display); assistant.setContextInformationPopupForeground(foreground); assistant.setContextSelectorForeground(foreground); assistant.setProposalSelectorForeground(foreground); return assistant; } /** * Creates a color from the information stored in the given preference store. * Returns <code>null</code> if there is no such information available. */ private Color createColor(IPreferenceStore store, String key, Display display) { RGB rgb= null; if (store.contains(key)) { if (store.isDefault(key)) rgb= PreferenceConverter.getDefaultColor(store, key); else rgb= PreferenceConverter.getColor(store, key); if (rgb != null) return new Color(display, rgb); } return null; } } private static class TextViewerAction extends Action implements IUpdate { private int fOperationCode= -1; private ITextOperationTarget fOperationTarget; public TextViewerAction(ITextViewer viewer, int operationCode) { fOperationCode= operationCode; fOperationTarget= viewer.getTextOperationTarget(); update(); } /** * Updates the enabled state of the action. * Fires a property change if the enabled state changes. * * @see Action#firePropertyChange(String, Object, Object) */ public void update() { boolean wasEnabled= isEnabled(); boolean isEnabled= (fOperationTarget != null && fOperationTarget.canDoOperation(fOperationCode)); setEnabled(isEnabled); if (wasEnabled != isEnabled) { firePropertyChange(ENABLED, wasEnabled ? Boolean.TRUE : Boolean.FALSE, isEnabled ? Boolean.TRUE : Boolean.FALSE); } } /** * @see Action#run() */ public void run() { if (fOperationCode != -1 && fOperationTarget != null) { fOperationTarget.doOperation(fOperationCode); } } } private final Template fTemplate; private Text fNameText; private Text fDescriptionText; private Combo fContextCombo; private SourceViewer fPatternEditor; private Button fInsertVariableButton; private TemplateTranslator fTranslator= new TemplateTranslator(); private boolean fSuppressError= true; // #4354 private Map fGlobalActions= new HashMap(10); private List fSelectionActions = new ArrayList(3); private Vector fContextTypes= new Vector(); private final TemplateVariableProcessor fProcessor= new TemplateVariableProcessor(); public EditTemplateDialog(Shell parent, Template template, boolean edit) { super(parent); setShellStyle(getShellStyle() | SWT.MAX | SWT.RESIZE); String title= edit ? TemplateMessages.getString("EditTemplateDialog.title.edit") //$NON-NLS-1$ : TemplateMessages.getString("EditTemplateDialog.title.new"); //$NON-NLS-1$ setTitle(title); fTemplate= template; ContextTypeRegistry registry= ContextTypeRegistry.getInstance(); for (Iterator iterator= registry.iterator(); iterator.hasNext(); ) fContextTypes.add(iterator.next()); if (fContextTypes.size() > 0) fProcessor.setContextType(ContextTypeRegistry.getInstance().getContextType((String) fContextTypes.get(0))); } /* * @see Dialog#createDialogArea(Composite) */ protected Control createDialogArea(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; parent.setLayout(layout); parent.setLayoutData(new GridData(GridData.FILL_BOTH)); createLabel(parent, TemplateMessages.getString("EditTemplateDialog.name")); //$NON-NLS-1$ Composite composite= new Composite(parent, SWT.NONE); composite.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); layout= new GridLayout(); layout.numColumns= 3; layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); fNameText= createText(composite); fNameText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { if (fSuppressError && (fNameText.getText().trim().length() != 0)) fSuppressError= false; updateButtons(); } }); createLabel(composite, TemplateMessages.getString("EditTemplateDialog.context")); //$NON-NLS-1$ fContextCombo= new Combo(composite, SWT.READ_ONLY); for (Iterator iterator= fContextTypes.iterator(); iterator.hasNext(); ) fContextCombo.add((String) iterator.next()); fContextCombo.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { String name= fContextCombo.getText(); fProcessor.setContextType(ContextTypeRegistry.getInstance().getContextType(name)); } }); createLabel(parent, TemplateMessages.getString("EditTemplateDialog.description")); //$NON-NLS-1$ fDescriptionText= createText(parent); composite= new Composite(parent, SWT.NONE); composite.setLayoutData(new GridData(GridData.FILL_VERTICAL)); layout= new GridLayout(); layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); createLabel(composite, TemplateMessages.getString("EditTemplateDialog.pattern")); //$NON-NLS-1$ fPatternEditor= createEditor(parent); Label filler= new Label(composite, SWT.NONE); filler.setLayoutData(new GridData(GridData.FILL_VERTICAL)); fInsertVariableButton= new Button(composite, SWT.NONE); fInsertVariableButton.setLayoutData(getButtonGridData(fInsertVariableButton)); fInsertVariableButton.setText(TemplateMessages.getString("EditTemplateDialog.insert.variable")); //$NON-NLS-1$ fInsertVariableButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent e) { fPatternEditor.getTextWidget().setFocus(); fPatternEditor.doOperation(ISourceViewer.CONTENTASSIST_PROPOSALS); } public void widgetDefaultSelected(SelectionEvent e) {} }); fNameText.setText(fTemplate.getName()); fDescriptionText.setText(fTemplate.getDescription()); fContextCombo.select(getIndex(fTemplate.getContextTypeName())); initializeActions(); return composite; } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private static Label createLabel(Composite parent, String name) { Label label= new Label(parent, SWT.NULL); label.setText(name); label.setLayoutData(new GridData()); return label; } private static Text createText(Composite parent) { Text text= new Text(parent, SWT.BORDER); text.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); return text; } private SourceViewer createEditor(Composite parent) { SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); viewer.configure(new SimpleJavaSourceViewerConfiguration(tools, null, fProcessor)); viewer.setEditable(true); viewer.setDocument(new Document(fTemplate.getPattern())); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(60); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); viewer.addTextListener(new ITextListener() { public void textChanged(TextEvent event) { try { fTranslator.translate(event.getDocumentEvent().getDocument().get()); } catch (CoreException e) { JavaPlugin.log(e); // XXX dialog } updateUndoAction(); updateButtons(); } }); viewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { updateSelectionDependentActions(); } }); if (viewer instanceof ITextViewerExtension) { ((ITextViewerExtension) viewer).prependVerifyKeyListener(new VerifyKeyListener() { public void verifyKey(VerifyEvent event) { handleVerifyKeyPressed(event); } }); } else { viewer.getTextWidget().addKeyListener(new KeyListener() { public void keyPressed(KeyEvent e) { handleKeyPressed(e); } public void keyReleased(KeyEvent e) {} }); } return viewer; } private void handleKeyPressed(KeyEvent event) { if (event.stateMask != SWT.CTRL) return; switch (event.character) { case ' ': fPatternEditor.doOperation(ISourceViewer.CONTENTASSIST_PROPOSALS); break; // CTRL-Z case (int) 'z' - (int) 'a' + 1: fPatternEditor.doOperation(ITextOperationTarget.UNDO); break; } } private void handleVerifyKeyPressed(VerifyEvent event) { if (!event.doit) return; if (event.stateMask != SWT.CTRL) return; switch (event.character) { case ' ': fPatternEditor.doOperation(ISourceViewer.CONTENTASSIST_PROPOSALS); event.doit= false; break; // CTRL-Z case (int) 'z' - (int) 'a' + 1: fPatternEditor.doOperation(ITextOperationTarget.UNDO); event.doit= false; break; } } private void initializeActions() { TextViewerAction action= new TextViewerAction(fPatternEditor, fPatternEditor.UNDO); action.setText(TemplateMessages.getString("EditTemplateDialog.undo")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.UNDO, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.CUT); action.setText(TemplateMessages.getString("EditTemplateDialog.cut")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.CUT, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.COPY); action.setText(TemplateMessages.getString("EditTemplateDialog.copy")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.COPY, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.PASTE); action.setText(TemplateMessages.getString("EditTemplateDialog.paste")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.PASTE, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.SELECT_ALL); action.setText(TemplateMessages.getString("EditTemplateDialog.select.all")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.SELECT_ALL, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.CONTENTASSIST_PROPOSALS); action.setText(TemplateMessages.getString("EditTemplateDialog.content.assist")); //$NON-NLS-1$ fGlobalActions.put("ContentAssistProposal", action); //$NON-NLS-1$ fSelectionActions.add(ITextEditorActionConstants.CUT); fSelectionActions.add(ITextEditorActionConstants.COPY); fSelectionActions.add(ITextEditorActionConstants.PASTE); // create context menu MenuManager manager= new MenuManager(null, null); manager.setRemoveAllWhenShown(true); manager.addMenuListener(new IMenuListener() { public void menuAboutToShow(IMenuManager mgr) { fillContextMenu(mgr); } }); StyledText text= fPatternEditor.getTextWidget(); Menu menu= manager.createContextMenu(text); text.setMenu(menu); } private void fillContextMenu(IMenuManager menu) { menu.add(new GroupMarker(ITextEditorActionConstants.GROUP_UNDO)); menu.appendToGroup(ITextEditorActionConstants.GROUP_UNDO, (IAction) fGlobalActions.get(ITextEditorActionConstants.UNDO)); menu.add(new Separator(ITextEditorActionConstants.GROUP_EDIT)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.CUT)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.COPY)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.PASTE)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.SELECT_ALL)); menu.add(new Separator(IContextMenuConstants.GROUP_GENERATE)); menu.appendToGroup(IContextMenuConstants.GROUP_GENERATE, (IAction) fGlobalActions.get("ContentAssistProposal")); //$NON-NLS-1$ } protected void updateSelectionDependentActions() { Iterator iterator= fSelectionActions.iterator(); while (iterator.hasNext()) updateAction((String)iterator.next()); } protected void updateUndoAction() { IAction action= (IAction) fGlobalActions.get(ITextEditorActionConstants.UNDO); if (action instanceof IUpdate) ((IUpdate) action).update(); } protected void updateAction(String actionId) { IAction action= (IAction) fGlobalActions.get(actionId); if (action instanceof IUpdate) ((IUpdate) action).update(); } private int getIndex(String context) { ContextTypeRegistry registry= ContextTypeRegistry.getInstance(); registry.getContextType(context); if (context == null) return -1; return fContextTypes.indexOf(context); } protected void okPressed() { fTemplate.setName(fNameText.getText()); fTemplate.setDescription(fDescriptionText.getText()); fTemplate.setContext(fContextCombo.getText()); fTemplate.setPattern(fPatternEditor.getTextWidget().getText()); super.okPressed(); } private void updateButtons() { boolean valid= fNameText.getText().trim().length() != 0; StatusInfo status= new StatusInfo(); if (!valid) { if (fSuppressError) status.setError(""); //$NON-NLS-1$ else status.setError(TemplateMessages.getString("EditTemplateDialog.error.noname")); //$NON-NLS-1$ } else if (fTranslator.getErrorMessage() != null) { status.setError(fTranslator.getErrorMessage()); } updateStatus(status); } }
17,646
Bug 17646 Comments in Java Templates don't have right syntax coloring
F1 - open Template preferences - select filecomment observe: the preview doesn't rendere the filecomment using the defined color for comments, but it does use the color for the keyword this.
verified fixed
320f4fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-30T13:58:00Z
2002-05-24T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/TemplatePreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; import java.io.File; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ColumnWeightData; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TableLayout; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.corext.template.ContextType; import org.eclipse.jdt.internal.corext.template.ContextTypeRegistry; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.TemplateContext; import org.eclipse.jdt.internal.corext.template.TemplateMessages; import org.eclipse.jdt.internal.corext.template.TemplateSet; import org.eclipse.jdt.internal.corext.template.Templates; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.text.template.TemplateContentProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateLabelProvider; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class TemplatePreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // preference store keys private static final String PREF_FORMAT_TEMPLATES= JavaUI.ID_PLUGIN + ".template.format"; //$NON-NLS-1$ private Templates fTemplates; private CheckboxTableViewer fTableViewer; private Button fAddButton; private Button fEditButton; private Button fImportButton; private Button fExportButton; private Button fExportAllButton; private Button fRemoveButton; private Button fEnableAllButton; private Button fDisableAllButton; private SourceViewer fPatternViewer; private Button fFormatButton; public TemplatePreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(TemplateMessages.getString("TemplatePreferencePage.message")); //$NON-NLS-1$ fTemplates= Templates.getInstance(); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; parent.setLayout(layout); Table table= new Table(parent, SWT.CHECK | SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(60); data.heightHint= convertHeightInCharsToPixels(10); table.setLayoutData(data); table.setHeaderVisible(true); table.setLinesVisible(true); TableLayout tableLayout= new TableLayout(); table.setLayout(tableLayout); TableColumn column1= new TableColumn(table, SWT.NONE); column1.setText(TemplateMessages.getString("TemplatePreferencePage.column.name")); //$NON-NLS-1$ TableColumn column2= new TableColumn(table, SWT.NONE); column2.setText(TemplateMessages.getString("TemplatePreferencePage.column.context")); //$NON-NLS-1$ TableColumn column3= new TableColumn(table, SWT.NONE); column3.setText(TemplateMessages.getString("TemplatePreferencePage.column.description")); //$NON-NLS-1$ tableLayout.addColumnData(new ColumnWeightData(30)); tableLayout.addColumnData(new ColumnWeightData(20)); tableLayout.addColumnData(new ColumnWeightData(70)); fTableViewer= new CheckboxTableViewer(table); fTableViewer.setLabelProvider(new TemplateLabelProvider()); fTableViewer.setContentProvider(new TemplateContentProvider()); fTableViewer.setSorter(new ViewerSorter() { public int compare(Viewer viewer, Object object1, Object object2) { if ((object1 instanceof Template) && (object2 instanceof Template)) { Template left= (Template) object1; Template right= (Template) object2; int result= left.getName().compareToIgnoreCase(right.getName()); if (result != 0) return result; return left.getDescription().compareToIgnoreCase(right.getDescription()); } return super.compare(viewer, object1, object2); } public boolean isSorterProperty(Object element, String property) { return true; } }); fTableViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent e) { edit(); } }); fTableViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent e) { selectionChanged1(); } }); fTableViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { Template template= (Template) event.getElement(); template.setEnabled(event.getChecked()); } }); Composite buttons= new Composite(parent, SWT.NULL); buttons.setLayoutData(new GridData(GridData.VERTICAL_ALIGN_BEGINNING)); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; buttons.setLayout(layout); fAddButton= new Button(buttons, SWT.PUSH); fAddButton.setLayoutData(getButtonGridData(fAddButton)); fAddButton.setText(TemplateMessages.getString("TemplatePreferencePage.new")); //$NON-NLS-1$ fAddButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { add(); } }); fEditButton= new Button(buttons, SWT.PUSH); fEditButton.setLayoutData(getButtonGridData(fEditButton)); fEditButton.setText(TemplateMessages.getString("TemplatePreferencePage.edit")); //$NON-NLS-1$ fEditButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { edit(); } }); fRemoveButton= new Button(buttons, SWT.PUSH); fRemoveButton.setLayoutData(getButtonGridData(fRemoveButton)); fRemoveButton.setText(TemplateMessages.getString("TemplatePreferencePage.remove")); //$NON-NLS-1$ fRemoveButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { remove(); } }); createSpacer(buttons); fImportButton= new Button(buttons, SWT.PUSH); fImportButton.setLayoutData(getButtonGridData(fImportButton)); fImportButton.setText(TemplateMessages.getString("TemplatePreferencePage.import")); //$NON-NLS-1$ fImportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { import_(); } }); fExportButton= new Button(buttons, SWT.PUSH); fExportButton.setLayoutData(getButtonGridData(fExportButton)); fExportButton.setText(TemplateMessages.getString("TemplatePreferencePage.export")); //$NON-NLS-1$ fExportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { export(); } }); fExportAllButton= new Button(buttons, SWT.PUSH); fExportAllButton.setLayoutData(getButtonGridData(fExportAllButton)); fExportAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.export.all")); //$NON-NLS-1$ fExportAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { exportAll(); } }); createSpacer(buttons); fEnableAllButton= new Button(buttons, SWT.PUSH); fEnableAllButton.setLayoutData(getButtonGridData(fEnableAllButton)); fEnableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.enable.all")); //$NON-NLS-1$ fEnableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(true); } }); fDisableAllButton= new Button(buttons, SWT.PUSH); fDisableAllButton.setLayoutData(getButtonGridData(fDisableAllButton)); fDisableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.disable.all")); //$NON-NLS-1$ fDisableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(false); } }); fPatternViewer= createViewer(parent); createSpacer(parent); fFormatButton= new Button(parent, SWT.CHECK); fFormatButton.setText(TemplateMessages.getString("TemplatePreferencePage.use.code.formatter")); //$NON-NLS-1$ fTableViewer.setInput(fTemplates); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getBoolean(PREF_FORMAT_TEMPLATES)); updateButtons(); WorkbenchHelp.setHelp(parent, IJavaHelpContextIds.TEMPLATE_PREFERENCE_PAGE); return parent; } private Template[] getEnabledTemplates() { Template[] templates= fTemplates.getTemplates(); List list= new ArrayList(templates.length); for (int i= 0; i != templates.length; i++) if (templates[i].isEnabled()) list.add(templates[i]); return (Template[]) list.toArray(new Template[list.size()]); } private SourceViewer createViewer(Composite parent) { Label label= new Label(parent, SWT.NONE); label.setText(TemplateMessages.getString("TemplatePreferencePage.preview")); //$NON-NLS-1$ GridData data= new GridData(); data.horizontalSpan= 2; label.setLayoutData(data); SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); viewer.configure(new JavaSourceViewerConfiguration(tools, null)); viewer.setEditable(false); viewer.setDocument(new Document()); viewer.getTextWidget().setBackground(getShell().getDisplay().getSystemColor(SWT.COLOR_WIDGET_BACKGROUND)); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); data= new GridData(GridData.FILL_BOTH); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); return viewer; } public void createSpacer(Composite parent) { Label spacer= new Label(parent, SWT.NONE); GridData data= new GridData(); data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; data.heightHint= 4; spacer.setLayoutData(data); } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.widthHint= SWTUtil.getButtonWidthHint(button); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private void selectionChanged1() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); if (selection.size() == 1) { Template template= (Template) selection.getFirstElement(); fPatternViewer.getTextWidget().setText(template.getPattern()); } else { fPatternViewer.getTextWidget().setText(""); //$NON-NLS-1$ } updateButtons(); } private void updateButtons() { int selectionCount= ((IStructuredSelection) fTableViewer.getSelection()).size(); int itemCount= fTableViewer.getTable().getItemCount(); fEditButton.setEnabled(selectionCount == 1); fExportButton.setEnabled(selectionCount > 0); fRemoveButton.setEnabled(selectionCount > 0 && selectionCount <= itemCount); fEnableAllButton.setEnabled(itemCount > 0); fDisableAllButton.setEnabled(itemCount > 0); } private void add() { Template template= new Template(); ContextTypeRegistry registry=ContextTypeRegistry.getInstance(); ContextType type= registry.getContextType("java"); //$NON-NLS-1$ String contextTypeName; if (type != null) contextTypeName= type.getName(); else { Iterator iterator= registry.iterator(); contextTypeName= (String) iterator.next(); } template.setContext(contextTypeName); //$NON-NLS-1$ EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, false); if (dialog.open() == dialog.OK) { fTemplates.add(template); fTableViewer.refresh(); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void edit() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] objects= selection.toArray(); if ((objects == null) || (objects.length != 1)) return; Template template= (Template) selection.getFirstElement(); edit(template); } private void edit(Template template) { Template newTemplate= new Template(template); EditTemplateDialog dialog= new EditTemplateDialog(getShell(), newTemplate, true); if (dialog.open() == dialog.OK) { if (!newTemplate.getName().equals(template.getName()) && MessageDialog.openQuestion(getShell(), TemplateMessages.getString("TemplatePreferencePage.question.create.new.title"), //$NON-NLS-1$ TemplateMessages.getString("TemplatePreferencePage.question.create.new.message"))) //$NON-NLS-1$ { template= newTemplate; fTemplates.add(template); fTableViewer.refresh(); } else { template.setName(newTemplate.getName()); template.setDescription(newTemplate.getDescription()); template.setContext(newTemplate.getContextTypeName()); template.setPattern(newTemplate.getPattern()); fTableViewer.refresh(template); } fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void import_() { FileDialog dialog= new FileDialog(getShell()); dialog.setText(TemplateMessages.getString("TemplatePreferencePage.import.title")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.import.extension")}); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { fTemplates.addFromFile(new File(path)); fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } catch (CoreException e) { openReadErrorDialog(e); } } private void exportAll() { export(fTemplates); } private void export() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] templates= selection.toArray(); TemplateSet templateSet= new TemplateSet(); for (int i= 0; i != templates.length; i++) templateSet.add((Template) templates[i]); export(templateSet); } private void export(TemplateSet templateSet) { FileDialog dialog= new FileDialog(getShell(), SWT.SAVE); dialog.setText(TemplateMessages.getFormattedString("TemplatePreferencePage.export.title", new Integer(templateSet.getTemplates().length))); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.export.extension")}); //$NON-NLS-1$ dialog.setFileName(TemplateMessages.getString("TemplatePreferencePage.export.filename")); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; File file= new File(path); if (!file.exists() || confirmOverwrite(file)) { try { templateSet.saveToFile(file); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } } } private boolean confirmOverwrite(File file) { return MessageDialog.openQuestion(getShell(), TemplateMessages.getString("TemplatePreferencePage.export.exists.title"), //$NON-NLS-1$ TemplateMessages.getFormattedString("TemplatePreferencePage.export.exists.message", file.getAbsolutePath())); //$NON-NLS-1$ } private void remove() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Iterator elements= selection.iterator(); while (elements.hasNext()) { Template template= (Template) elements.next(); fTemplates.remove(template); } fTableViewer.refresh(); } private void enableAll(boolean enable) { Template[] templates= fTemplates.getTemplates(); for (int i= 0; i != templates.length; i++) templates[i].setEnabled(enable); fTableViewer.setAllChecked(enable); } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) {} /* * @see Control#setVisible(boolean) */ public void setVisible(boolean visible) { super.setVisible(visible); if (visible) setTitle(TemplateMessages.getString("TemplatePreferencePage.title")); //$NON-NLS-1$ } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getDefaultBoolean(PREF_FORMAT_TEMPLATES)); try { fTemplates.restoreDefaults(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } // refresh fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } /* * @see PreferencePage#performOk() */ public boolean performOk() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); prefs.setValue(PREF_FORMAT_TEMPLATES, fFormatButton.getSelection()); try { fTemplates.save(); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } JavaPlugin.getDefault().savePluginPreferences(); return super.performOk(); } /* * @see PreferencePage#performCancel() */ public boolean performCancel() { try { fTemplates.reset(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } return super.performCancel(); } /** * Initializes the default values of this page in the preference bundle. * Will be called on startup of the JavaPlugin */ public static void initDefaults(IPreferenceStore prefs) { prefs.setDefault(PREF_FORMAT_TEMPLATES, true); } public static boolean useCodeFormatter() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); return prefs.getBoolean(PREF_FORMAT_TEMPLATES); } private void openReadErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.read.title"), //$NON-NLS-1$ null, e.getStatus()); } private void openWriteErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.write.title"), //$NON-NLS-1$ null, e.getStatus()); } }