issue_id
int64
2.03k
426k
title
stringlengths
9
251
body
stringlengths
1
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
2
187
file_content
stringlengths
0
368k
18,780
Bug 18780 Deleting a member in Members view not always working
Build F2 I detected that in some cases deleting a memeber (was a method) from the Members view doesn't get removed from the list. Should fix for F3
verified fixed
69a5625
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T15:13:02Z
2002-06-03T16:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/JavaBrowsingPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import java.util.Collection; import java.util.Comparator; import java.util.Iterator; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.ResourceTransferDragAdapter; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput; import org.eclipse.jdt.internal.ui.packageview.PackagesMessages; import org.eclipse.jdt.internal.ui.packageview.SelectionTransferDragAdapter; import org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.JavaUIHelp; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTableViewer; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; import org.eclipse.jdt.internal.ui.workingsets.WorkingSetFilterActionGroup; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaElementSorter; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.StandardJavaElementContentProvider; import org.eclipse.jdt.ui.actions.BuildActionGroup; import org.eclipse.jdt.ui.actions.CCPActionGroup; import org.eclipse.jdt.ui.actions.CustomFiltersActionGroup; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.ImportActionGroup; import org.eclipse.jdt.ui.actions.JavaSearchActionGroup; import org.eclipse.jdt.ui.actions.OpenEditorActionGroup; import org.eclipse.jdt.ui.actions.OpenViewActionGroup; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.actions.ShowActionGroup; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.util.Assert; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IOpenListener; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.OpenEvent; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.DragSourceEvent; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.Shell; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.ISelectionListener; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.ui.IWorkingSet; import org.eclipse.ui.IWorkingSetManager; import org.eclipse.ui.PartInitException; import org.eclipse.ui.PlatformUI; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.NewWizardMenu; import org.eclipse.ui.part.ResourceTransfer; import org.eclipse.ui.part.ViewPart; import org.eclipse.search.ui.ISearchResultView; abstract class JavaBrowsingPart extends ViewPart implements IMenuListener, ISelectionListener { private ILabelProvider fLabelProvider; private ILabelProvider fTitleProvider; private StructuredViewer fViewer; private IMemento fMemento; private JavaElementTypeComparator fTypeComparator; // Actions private WorkingSetFilterActionGroup fWorkingSetFilterActionGroup; private boolean fHasWorkingSetFilter= true; private boolean fHasCustomFilter= true; private OpenEditorActionGroup fOpenEditorGroup; private CCPActionGroup fCCPActionGroup; private BuildActionGroup fBuildActionGroup; protected CompositeActionGroup fActionGroups; // Filters private CustomFiltersActionGroup fCustomFiltersActionGroup; private Menu fContextMenu; private IWorkbenchPart fPreviousSelectionProvider; private Object fPreviousSelectedElement; /* * Ensure selection changed events being processed only if * initiated by user interaction with this part. */ private boolean fProcessSelectionEvents= true; private IPartListener fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { setSelectionFromEditor(part); } public void partBroughtToTop(IWorkbenchPart part) { } public void partClosed(IWorkbenchPart part) { } public void partDeactivated(IWorkbenchPart part) { } public void partOpened(IWorkbenchPart part) { } }; /* * Implements method from IViewPart. */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /* * Implements method from IViewPart. */ public void saveState(IMemento memento) { if (fViewer == null) { // part has not been created if (fMemento != null) //Keep the old state; memento.putMemento(fMemento); return; } if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup.saveState(memento); if (fHasCustomFilter) fCustomFiltersActionGroup.saveState(memento); } protected void restoreState(IMemento memento) { if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup.restoreState(memento); if (fHasCustomFilter) fCustomFiltersActionGroup.restoreState(memento); if (fHasCustomFilter || fHasWorkingSetFilter) { fViewer.getControl().setRedraw(false); fViewer.refresh(); fViewer.getControl().setRedraw(true); } } /** * Creates the search list inner viewer. */ public void createPartControl(Composite parent) { Assert.isTrue(fViewer == null); fTypeComparator= new JavaElementTypeComparator(); // Setup viewer fViewer= createViewer(parent); fLabelProvider= createLabelProvider(); ILabelDecorator decorationMgr= PlatformUI.getWorkbench().getDecoratorManager().getLabelDecorator(); fViewer.setLabelProvider(new DecoratingLabelProvider(fLabelProvider, decorationMgr)); fViewer.setSorter(new JavaElementSorter()); fViewer.setUseHashlookup(true); fTitleProvider= createTitleProvider(); MenuManager menuMgr= new MenuManager("#PopupMenu"); //$NON-NLS-1$ menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(this); fContextMenu= menuMgr.createContextMenu(fViewer.getControl()); fViewer.getControl().setMenu(fContextMenu); getSite().registerContextMenu(menuMgr, fViewer); getSite().setSelectionProvider(fViewer); createActions(); // call before registering for selection changes addKeyListener(); // Custom filter group if (fHasCustomFilter) fCustomFiltersActionGroup= new CustomFiltersActionGroup(this, fViewer); if (fMemento != null) restoreState(fMemento); fMemento= null; getSite().setSelectionProvider(fViewer); // Status line IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager)); hookViewerListeners(); // Filters addFilters(); // Initialize viewer input fViewer.setContentProvider(createContentProvider()); setInitialInput(); initDragAndDrop(); // Initialize selecton setInitialSelection(); // Listen to workbench window changes getViewSite().getWorkbenchWindow().getSelectionService().addPostSelectionListener(this); getViewSite().getPage().addPartListener(fPartListener); fillActionBars(); setHelp(); } private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK; Transfer[] transfers= new Transfer[] { LocalSelectionTransfer.getInstance(), ResourceTransfer.getInstance()}; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fViewer) }; fViewer.addDropSupport(ops | DND.DROP_DEFAULT, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fViewer), new ResourceTransferDragAdapter(fViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners) { public void dragStart(DragSourceEvent event) { IStructuredSelection selection= (IStructuredSelection)getSelectionProvider().getSelection(); for (Iterator iter= selection.iterator(); iter.hasNext(); ) { if (iter.next() instanceof IMember) { setPossibleListeners(new TransferDragSourceListener[] {new SelectionTransferDragAdapter(fViewer)}); break; } } super.dragStart(event); } }); } protected void fillActionBars() { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager toolBar= actionBars.getToolBarManager(); fillToolBar(toolBar); if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup.fillActionBars(getViewSite().getActionBars()); actionBars.updateActionBars(); fActionGroups.fillActionBars(actionBars); if (fHasCustomFilter) fCustomFiltersActionGroup.fillActionBars(actionBars); } //---- IWorkbenchPart ------------------------------------------------------ public void setFocus() { fViewer.getControl().setFocus(); } public void dispose() { if (fViewer != null) { getViewSite().getWorkbenchWindow().getSelectionService().removePostSelectionListener(this); getViewSite().getPage().removePartListener(fPartListener); fViewer= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /** * Adds the KeyListener */ protected void addKeyListener() { fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { handleKeyReleased(event); } }); } protected void handleKeyReleased(KeyEvent event) { if (event.stateMask != 0) return; int key= event.keyCode; IAction action; if (key == SWT.F5) { action= fBuildActionGroup.getRefreshAction(); if (action.isEnabled()) action.run(); } if (event.character == SWT.DEL) { action= fCCPActionGroup.getDeleteAction(); if (action.isEnabled()) action.run(); } } //---- Adding Action to Toolbar ------------------------------------------- protected void fillToolBar(IToolBarManager tbm) { } /** * Called when the context menu is about to open. * Override to add your own context dependent menu contributions. */ public void menuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); IStructuredSelection selection= (IStructuredSelection) fViewer.getSelection(); int size= selection.size(); Object element= selection.getFirstElement(); IJavaElement jElement= element instanceof IJavaElement ? (IJavaElement)element : null; if (size == 0 || (size == 1 && (isNewTarget(jElement) || element instanceof IContainer))) { MenuManager newMenu= new MenuManager(PackagesMessages.getString("PackageExplorer.new")); //$NON-NLS-1$ menu.appendToGroup(IContextMenuConstants.GROUP_NEW, newMenu); new NewWizardMenu(newMenu, getSite().getWorkbenchWindow(), false); } if (size == 1) addOpenNewWindowAction(menu, element); fActionGroups.setContext(new ActionContext(selection)); fActionGroups.fillContextMenu(menu); fActionGroups.setContext(null); } private boolean isNewTarget(IJavaElement element) { if (element == null) return false; int type= element.getElementType(); return type == IJavaElement.JAVA_PROJECT || type == IJavaElement.PACKAGE_FRAGMENT_ROOT || type == IJavaElement.PACKAGE_FRAGMENT || type == IJavaElement.COMPILATION_UNIT || type == IJavaElement.TYPE; } private void addOpenNewWindowAction(IMenuManager menu, Object element) { if (element instanceof IJavaElement) { try { element= ((IJavaElement)element).getCorrespondingResource(); } catch(JavaModelException e) { } } if (!(element instanceof IContainer)) return; menu.appendToGroup( IContextMenuConstants.GROUP_OPEN, new PatchedOpenInNewWindowAction(getSite().getWorkbenchWindow(), (IContainer)element)); } protected void createActions() { fActionGroups= new CompositeActionGroup(new ActionGroup[] { fOpenEditorGroup= new OpenEditorActionGroup(this), new OpenViewActionGroup(this), new ShowActionGroup(this), fCCPActionGroup= new CCPActionGroup(this), new RefactorActionGroup(this), new ImportActionGroup(this), new GenerateActionGroup(this), fBuildActionGroup= new BuildActionGroup(this), new JavaSearchActionGroup(this)}); String viewId= getConfigurationElement().getAttribute("id"); //$NON-NLS-1$ Assert.isNotNull(viewId); IPropertyChangeListener titleUpdater= new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { String property= event.getProperty(); if (IWorkingSetManager.CHANGE_WORKING_SET_NAME_CHANGE.equals(property)) updateTitle(); } }; if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup= new WorkingSetFilterActionGroup(fViewer, viewId, getShell(), titleUpdater); } /** * Returns the shell to use for opening dialogs. * Used in this class, and in the actions. */ private Shell getShell() { return fViewer.getControl().getShell(); } protected final Display getDisplay() { return fViewer.getControl().getDisplay(); } /** * Returns the selection provider. */ ISelectionProvider getSelectionProvider() { return fViewer; } /** * Answers if the given <code>element</code> is a valid * input for this part. * * @param element the object to test * @return <true> if the given element is a valid input */ abstract protected boolean isValidInput(Object element); /** * Answers if the given <code>element</code> is a valid * element for this part. * * @param element the object to test * @return <true> if the given element is a valid element */ protected boolean isValidElement(Object element) { if (element == null) return false; element= getSuitableJavaElement(element); if (element == null) return false; Object input= getViewer().getInput(); if (input == null) return false; if (input instanceof Collection) return ((Collection)input).contains(element); else return input.equals(element); } private boolean isInputResetBy(Object newInput, Object input, IWorkbenchPart part) { if (newInput == null) return part == fPreviousSelectionProvider; if (input instanceof IJavaElement && newInput instanceof IJavaElement) return getTypeComparator().compare(newInput, input) > 0; else return false; } private boolean isInputResetBy(IWorkbenchPart part) { if (!(part instanceof JavaBrowsingPart)) return true; Object thisInput= getViewer().getInput(); Object partInput= ((JavaBrowsingPart)part).getViewer().getInput(); if (thisInput instanceof IJavaElement && partInput instanceof IJavaElement) return getTypeComparator().compare(partInput, thisInput) > 0; else return true; } protected boolean isAncestorOf(Object ancestor, Object element) { if (element instanceof IJavaElement && ancestor instanceof IJavaElement) return !element.equals(ancestor) && internalIsAncestorOf((IJavaElement)ancestor, (IJavaElement)element); return false; } private boolean internalIsAncestorOf(IJavaElement ancestor, IJavaElement element) { if (element != null) return element.equals(ancestor) || internalIsAncestorOf(ancestor, element.getParent()); else return false; } public void selectionChanged(IWorkbenchPart part, ISelection selection) { if (!fProcessSelectionEvents || part == this || part instanceof ISearchResultView || !(selection instanceof IStructuredSelection)) return; // Set selection Object selectedElement= getSingleElementFromSelection(selection); if (selectedElement != null && part.equals(fPreviousSelectionProvider) && selectedElement.equals(fPreviousSelectedElement)) return; fPreviousSelectedElement= selectedElement; Object currentInput= (IJavaElement)getViewer().getInput(); if (selectedElement != null && selectedElement.equals(currentInput)) { IJavaElement elementToSelect= findElementToSelect(getSingleElementFromSelection(selection)); if (elementToSelect != null && getTypeComparator().compare(selectedElement, elementToSelect) < 0) setSelection(new StructuredSelection(elementToSelect), true); fPreviousSelectionProvider= part; return; } // Clear input if needed if (part != fPreviousSelectionProvider && selectedElement != null && !selectedElement.equals(currentInput) && isInputResetBy(selectedElement, currentInput, part)) { if (!isAncestorOf(selectedElement, currentInput)) setInput(null); fPreviousSelectionProvider= part; return; } else if (selection.isEmpty() && !isInputResetBy(part)) { fPreviousSelectionProvider= part; return; } else if (selectedElement == null && part == fPreviousSelectionProvider) { setInput(null); fPreviousSelectionProvider= part; return; } fPreviousSelectionProvider= part; // Adjust input and set selection and if (selectedElement instanceof IJavaElement) adjustInputAndSetSelection((IJavaElement)selectedElement); else setSelection(StructuredSelection.EMPTY, true); } void setHasWorkingSetFilter(boolean state) { fHasWorkingSetFilter= state; } void setHasCustomSetFilter(boolean state) { fHasCustomFilter= state; } protected void setInput(Object input) { setViewerInput(input); updateTitle(); } private void setViewerInput(Object input) { fProcessSelectionEvents= false; fViewer.setInput(input); fProcessSelectionEvents= true; } void updateTitle() { setTitleToolTip(getToolTipText(fViewer.getInput())); } /** * Returns the tool tip text for the given element. */ String getToolTipText(Object element) { String result; if (!(element instanceof IResource)) { result= JavaElementLabels.getTextLabel(element, AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS); } else { IPath path= ((IResource) element).getFullPath(); if (path.isRoot()) { result= getConfigurationElement().getAttribute("name"); //$NON-NLS-1$ } else { result= path.makeRelative().toString(); } } if (fWorkingSetFilterActionGroup == null || fWorkingSetFilterActionGroup.getWorkingSet() == null) return result; IWorkingSet ws= fWorkingSetFilterActionGroup.getWorkingSet(); String wsstr= JavaBrowsingMessages.getFormattedString("JavaBrowsingPart.toolTip", new String[] { ws.getName() }); //$NON-NLS-1$ if (result.length() == 0) return wsstr; return JavaBrowsingMessages.getFormattedString("JavaBrowsingPart.toolTip2", new String[] { result, ws.getName() }); //$NON-NLS-1$ } public String getTitleToolTip() { if (fViewer == null) return super.getTitleToolTip(); return getToolTipText(fViewer.getInput()); } protected final StructuredViewer getViewer() { return fViewer; } protected ILabelProvider createLabelProvider() { return new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS | JavaElementImageProvider.SMALL_ICONS, AppearanceAwareLabelProvider.getDecorators(true, null) ); } protected ILabelProvider createTitleProvider() { return new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_SMALL_ICONS); } protected final ILabelProvider getLabelProvider() { return fLabelProvider; } protected final ILabelProvider getTitleProvider() { return fTitleProvider; } /** * Creates the the viewer of this part. * * @param parent the parent for the viewer */ protected StructuredViewer createViewer(Composite parent) { return new ProblemTableViewer(parent, SWT.MULTI); } protected int getLabelProviderFlags() { return JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_OVERLAY_ICONS | JavaElementLabelProvider.SHOW_SMALL_ICONS | JavaElementLabelProvider.SHOW_VARIABLE | JavaElementLabelProvider.SHOW_PARAMETERS; } /** * Adds filters the viewer of this part. */ protected void addFilters() { // default is to have no filters } /** * Creates the the content provider of this part. */ protected StandardJavaElementContentProvider createContentProvider() { return new JavaBrowsingContentProvider(true, this); // } protected void setInitialInput() { // Use the selection, if any ISelection selection= getSite().getPage().getSelection(); Object input= getSingleElementFromSelection(selection); if (!(input instanceof IJavaElement)) { // Use the input of the page input= getSite().getPage().getInput(); if (!(input instanceof IJavaElement) && input instanceof IAdaptable) input= ((IAdaptable)input).getAdapter(IJavaElement.class); } setInput(findInputForJavaElement((IJavaElement)input)); } protected void setInitialSelection() { // Use the selection, if any Object input; ISelection selection= getSite().getPage().getSelection(); if (selection != null && !selection.isEmpty()) input= getSingleElementFromSelection(selection); else { // Use the input of the page input= getSite().getPage().getInput(); if (!(input instanceof IJavaElement)) { if (input instanceof IAdaptable) input= ((IAdaptable)input).getAdapter(IJavaElement.class); else return; } } if (findElementToSelect((IJavaElement)input) != null) adjustInputAndSetSelection((IJavaElement)input); } final protected void setHelp() { JavaUIHelp.setHelp(fViewer, getHelpContextId()); } /** * Returns the context ID for the Help system * * @return the string used as ID for the Help context */ abstract protected String getHelpContextId(); /** * Adds additional listeners to this view. * This method can be overridden but should * call super. */ protected void hookViewerListeners() { fViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { if (!fProcessSelectionEvents) return; IWorkbenchPage page= getSite().getPage(); if (page == null) return; if (page.equals(JavaPlugin.getActivePage()) && JavaBrowsingPart.this.equals(page.getActivePart())) { linkToEditor((IStructuredSelection)event.getSelection()); } } }); fViewer.addOpenListener(new IOpenListener() { public void open(OpenEvent event) { IAction open= fOpenEditorGroup.getOpenAction(); if (open.isEnabled()) open.run(); } }); } void adjustInputAndSetSelection(IJavaElement je) { je= getSuitableJavaElement(je); IJavaElement elementToSelect= findElementToSelect(je); IJavaElement newInput= findInputForJavaElement(je); if (elementToSelect == null && !isValidInput(newInput)) // Clear input setInput(null); else if (elementToSelect == null || getViewer().testFindItem(elementToSelect) == null) // Adjust input to selection setInput(findInputForJavaElement(je)); if (elementToSelect != null) setSelection(new StructuredSelection(elementToSelect), true); else setSelection(StructuredSelection.EMPTY, true); } /** * Finds the closest Java element which can be used as input for * this part and has the given Java element as child * * @param je the Java element for which to search the closest input * @return the closest Java element used as input for this part */ protected IJavaElement findInputForJavaElement(IJavaElement je) { if (je == null || !je.exists()) return null; if (isValidInput(je)) return je; return findInputForJavaElement(je.getParent()); } final protected IJavaElement findElementToSelect(Object obj) { if (obj instanceof IJavaElement) return findElementToSelect((IJavaElement)obj); return null; } /** * Finds the element which has to be selected in this part. * * @param je the Java element which has the focus */ abstract protected IJavaElement findElementToSelect(IJavaElement je); private Object getSingleElementFromSelection(ISelection selection) { if (!(selection instanceof StructuredSelection) || selection.isEmpty()) return null; Iterator iter= ((StructuredSelection)selection).iterator(); Object firstElement= iter.next(); if (!(firstElement instanceof IJavaElement)) { if (firstElement instanceof IAdaptable) return (IJavaElement)((IAdaptable)firstElement).getAdapter(IJavaElement.class); else return firstElement; } Object currentInput= (IJavaElement)getViewer().getInput(); if (currentInput == null || !currentInput.equals(findInputForJavaElement((IJavaElement)firstElement))) if (iter.hasNext()) // multi selection and view is empty return null; else // ok: single selection and view is empty return firstElement; // be nice to multi selection while (iter.hasNext()) { Object element= iter.next(); if (!(element instanceof IJavaElement)) return null; if (!currentInput.equals(findInputForJavaElement((IJavaElement)element))) return null; } return firstElement; } /** * Gets the typeComparator. * @return Returns a JavaElementTypeComparator */ protected Comparator getTypeComparator() { return fTypeComparator; } /** * Links to editor (if option enabled) */ private void linkToEditor(IStructuredSelection selection) { Object obj= selection.getFirstElement(); Object element= null; if (selection.size() == 1) { IEditorPart part= EditorUtility.isOpenInEditor(obj); if (part != null) { IWorkbenchPage page= getSite().getPage(); page.bringToTop(part); if (obj instanceof IJavaElement) EditorUtility.revealInEditor(part, (IJavaElement) obj); } } } private void setSelectionFromEditor(IWorkbenchPart part) { if (part == null) return; IWorkbenchPartSite site= part.getSite(); if (site == null) return; ISelectionProvider provider= site.getSelectionProvider(); if (provider != null) setSelectionFromEditor(part, provider.getSelection()); } private void setSelectionFromEditor(IWorkbenchPart part, ISelection selection) { if (part instanceof IEditorPart && JavaBasePreferencePage.linkBrowsingViewSelectionToEditor()) { IEditorInput ei= ((IEditorPart)part).getEditorInput(); if (selection instanceof ITextSelection) { int offset= ((ITextSelection)selection).getOffset(); IJavaElement element= getElementForInputAt(ei, offset); if (element != null) { adjustInputAndSetSelection(element); return; } } if (ei instanceof IFileEditorInput) { IFile file= ((IFileEditorInput)ei).getFile(); IJavaElement je= (IJavaElement)file.getAdapter(IJavaElement.class); if (je == null) { setSelection(null, false); return; } adjustInputAndSetSelection(je); } else if (ei instanceof IClassFileEditorInput) { IClassFile cf= ((IClassFileEditorInput)ei).getClassFile(); adjustInputAndSetSelection(cf); } return; } } /** * Returns the element contained in the EditorInput */ Object getElementOfInput(IEditorInput input) { if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); else if (input instanceof IFileEditorInput) return ((IFileEditorInput)input).getFile(); else if (input instanceof JarEntryEditorInput) return ((JarEntryEditorInput)input).getStorage(); return null; } private IResource getResourceFor(Object element) { if (element instanceof IJavaElement) { if (element instanceof IWorkingCopy) { IWorkingCopy wc= (IWorkingCopy)element; IJavaElement original= wc.getOriginalElement(); if (original != null) element= original; } try { element= ((IJavaElement)element).getUnderlyingResource(); } catch (JavaModelException e) { return null; } } if (!(element instanceof IResource) || ((IResource)element).isPhantom()) { return null; } return (IResource)element; } private void setSelection(ISelection selection, boolean reveal) { if (selection != null && selection.equals(fViewer.getSelection())) return; fProcessSelectionEvents= false; fViewer.setSelection(selection, reveal); fProcessSelectionEvents= true; } /** * Tries to find the given element in a workingcopy. */ protected static IJavaElement getWorkingCopy(IJavaElement input) { try { if (input instanceof ICompilationUnit) return ((ICompilationUnit)input).findSharedWorkingCopy(JavaUI.getBufferFactory()); else return EditorUtility.getWorkingCopy(input, false); } catch (JavaModelException ex) { } return null; } /** * Returns the original element from which the specified working copy * element was created from. This is a handle only method, the * returned element may or may not exist. * * @param workingCopy the element for which to get the original * @return the original Java element or <code>null</code> if this is not a working copy element */ protected static IJavaElement getOriginal(IJavaElement workingCopy) { ICompilationUnit cu= getCompilationUnit(workingCopy); if (cu != null) return ((IWorkingCopy)cu).getOriginal(workingCopy); return null; } /** * Returns the compilation unit for the given java element. * * @param element the java element whose compilation unit is searched for * @return the compilation unit of the given java element */ protected static ICompilationUnit getCompilationUnit(IJavaElement element) { if (element == null) return null; if (element instanceof IMember) return ((IMember) element).getCompilationUnit(); int type= element.getElementType(); if (IJavaElement.COMPILATION_UNIT == type) return (ICompilationUnit) element; if (IJavaElement.CLASS_FILE == type) return null; return getCompilationUnit(element.getParent()); } /** * Converts the given Java element to one which is suitable for this * view. It takes into account wether the view shows working copies or not. * * @param element the Java element to be converted * @return an element suitable for this view */ protected IJavaElement getSuitableJavaElement(Object obj) { if (!(obj instanceof IJavaElement)) return null; IJavaElement element= (IJavaElement)obj; if (fTypeComparator.compare(element, IJavaElement.COMPILATION_UNIT) > 0) return element; if (element.getElementType() == IJavaElement.CLASS_FILE) return element; if (((StandardJavaElementContentProvider)getViewer().getContentProvider()).getProvideWorkingCopy()) { IJavaElement wc= getWorkingCopy(element); if (wc != null) element= wc; return element; } else { ICompilationUnit cu= getCompilationUnit(element); if (cu != null && ((IWorkingCopy)cu).isWorkingCopy()) return ((IWorkingCopy)cu).getOriginal(element); else return element; } } /** * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementForInputAt(IEditorInput input, int offset) { if (input instanceof IClassFileEditorInput) { try { return ((IClassFileEditorInput)input).getClassFile().getElementAt(offset); } catch (JavaModelException ex) { return null; } } IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(input); if (unit != null) try { unit.reconcile(); return unit.getElementAt(offset); } catch (JavaModelException ex) { } return null; } protected IType getTypeForCU(ICompilationUnit cu) { cu= (ICompilationUnit)getSuitableJavaElement(cu); // Use primary type if possible IType primaryType= cu.findPrimaryType(); if (primaryType != null) return primaryType; // Use first top-level type try { IType[] types= cu.getTypes(); if (types.length > 0) return types[0]; else return null; } catch (JavaModelException ex) { return null; } } void setProcessSelectionEvents(boolean state) { fProcessSelectionEvents= state; } }
18,780
Bug 18780 Deleting a member in Members view not always working
Build F2 I detected that in some cases deleting a memeber (was a method) from the Members view doesn't get removed from the list. Should fix for F3
verified fixed
69a5625
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T15:13:02Z
2002-06-03T16:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/JavaBrowsingPerspectiveFactory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.ui.IPageLayout; import org.eclipse.ui.IPerspectiveFactory; import org.eclipse.ui.IPlaceholderFolderLayout; import org.eclipse.debug.ui.IDebugUIConstants; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; public class JavaBrowsingPerspectiveFactory implements IPerspectiveFactory { /* * XXX: This is a workaround for: http://dev.eclipse.org/bugs/show_bug.cgi?id=13070 */ static IJavaElement fgJavaElementFromAction; /** * Constructs a new Default layout engine. */ public JavaBrowsingPerspectiveFactory() { super(); } public void createInitialLayout(IPageLayout layout) { if (AppearancePreferencePage.stackBrowsingViewsHorizontally()) createHorizontalLayout(layout); else createVerticalLayout(layout); // action sets layout.addActionSet(IDebugUIConstants.LAUNCH_ACTION_SET); layout.addActionSet(JavaUI.ID_ACTION_SET); layout.addActionSet(JavaUI.ID_ELEMENT_CREATION_ACTION_SET); // views - java layout.addShowViewShortcut(JavaUI.ID_TYPE_HIERARCHY); // views - search layout.addShowViewShortcut(SearchUI.SEARCH_RESULT_VIEW_ID); // views - debugging layout.addShowViewShortcut(IDebugUIConstants.ID_CONSOLE_VIEW); // views - standard workbench layout.addShowViewShortcut(IPageLayout.ID_OUTLINE); layout.addShowViewShortcut(IPageLayout.ID_TASK_LIST); layout.addShowViewShortcut(IPageLayout.ID_RES_NAV); // new actions - Java project creation wizard layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewPackageCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewClassCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewInterfaceCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewSnippetCreationWizard"); //$NON-NLS-1$ } private void createVerticalLayout(IPageLayout layout) { String relativePartId= IPageLayout.ID_EDITOR_AREA; int relativePos= IPageLayout.LEFT; IPlaceholderFolderLayout placeHolderLeft= layout.createPlaceholderFolder("left", IPageLayout.LEFT, (float)0.25, IPageLayout.ID_EDITOR_AREA); //$NON-NLS-1$ placeHolderLeft.addPlaceholder(JavaUI.ID_TYPE_HIERARCHY); placeHolderLeft.addPlaceholder(IPageLayout.ID_OUTLINE); placeHolderLeft.addPlaceholder(JavaUI.ID_PACKAGES); placeHolderLeft.addPlaceholder(IPageLayout.ID_RES_NAV); if (shouldShowProjectsView()) { layout.addView(JavaUI.ID_PROJECTS_VIEW, IPageLayout.LEFT, (float)0.25, IPageLayout.ID_EDITOR_AREA); relativePartId= JavaUI.ID_PROJECTS_VIEW; relativePos= IPageLayout.BOTTOM; } if (shouldShowPackagesView()) { layout.addView(JavaUI.ID_PACKAGES_VIEW, relativePos, (float)0.25, relativePartId); relativePartId= JavaUI.ID_PACKAGES_VIEW; relativePos= IPageLayout.BOTTOM; } layout.addView(JavaUI.ID_TYPES_VIEW, relativePos, (float)0.33, relativePartId); layout.addView(JavaUI.ID_MEMBERS_VIEW, IPageLayout.BOTTOM, (float)0.50, JavaUI.ID_TYPES_VIEW); IPlaceholderFolderLayout placeHolderBottom= layout.createPlaceholderFolder("bottom", IPageLayout.BOTTOM, (float)0.75, IPageLayout.ID_EDITOR_AREA); //$NON-NLS-1$ placeHolderBottom.addPlaceholder(IPageLayout.ID_TASK_LIST); placeHolderBottom.addPlaceholder(SearchUI.SEARCH_RESULT_VIEW_ID); placeHolderBottom.addPlaceholder(IDebugUIConstants.ID_CONSOLE_VIEW); placeHolderBottom.addPlaceholder(IPageLayout.ID_BOOKMARKS); } private void createHorizontalLayout(IPageLayout layout) { String relativePartId= IPageLayout.ID_EDITOR_AREA; int relativePos= IPageLayout.TOP; if (shouldShowProjectsView()) { layout.addView(JavaUI.ID_PROJECTS_VIEW, IPageLayout.TOP, (float)0.25, IPageLayout.ID_EDITOR_AREA); relativePartId= JavaUI.ID_PROJECTS_VIEW; relativePos= IPageLayout.RIGHT; } if (shouldShowPackagesView()) { layout.addView(JavaUI.ID_PACKAGES_VIEW, relativePos, (float)0.25, relativePartId); relativePartId= JavaUI.ID_PACKAGES_VIEW; relativePos= IPageLayout.RIGHT; } layout.addView(JavaUI.ID_TYPES_VIEW, relativePos, (float)0.33, relativePartId); layout.addView(JavaUI.ID_MEMBERS_VIEW, IPageLayout.RIGHT, (float)0.50, JavaUI.ID_TYPES_VIEW); IPlaceholderFolderLayout placeHolderLeft= layout.createPlaceholderFolder("left", IPageLayout.LEFT, (float)0.25, IPageLayout.ID_EDITOR_AREA); //$NON-NLS-1$ placeHolderLeft.addPlaceholder(JavaUI.ID_TYPE_HIERARCHY); placeHolderLeft.addPlaceholder(IPageLayout.ID_OUTLINE); placeHolderLeft.addPlaceholder(JavaUI.ID_PACKAGES); placeHolderLeft.addPlaceholder(IPageLayout.ID_RES_NAV); IPlaceholderFolderLayout placeHolderBottom= layout.createPlaceholderFolder("bottom", IPageLayout.BOTTOM, (float)0.75, IPageLayout.ID_EDITOR_AREA); //$NON-NLS-1$ placeHolderBottom.addPlaceholder(IPageLayout.ID_TASK_LIST); placeHolderBottom.addPlaceholder(SearchUI.SEARCH_RESULT_VIEW_ID); placeHolderBottom.addPlaceholder(IDebugUIConstants.ID_CONSOLE_VIEW); placeHolderBottom.addPlaceholder(IPageLayout.ID_BOOKMARKS); } private boolean shouldShowProjectsView() { return fgJavaElementFromAction == null || fgJavaElementFromAction.getElementType() == IJavaElement.JAVA_MODEL; } private boolean shouldShowPackagesView() { if (fgJavaElementFromAction == null) return true; int type= fgJavaElementFromAction.getElementType(); return type == IJavaElement.JAVA_MODEL || type == IJavaElement.JAVA_PROJECT || type == IJavaElement.PACKAGE_FRAGMENT_ROOT; } /* * XXX: This is a workaround for: http://dev.eclipse.org/bugs/show_bug.cgi?id=13070 */ static void setInputFromAction(IAdaptable input) { if (input instanceof IJavaElement) fgJavaElementFromAction= (IJavaElement)input; else fgJavaElementFromAction= null; } }
18,780
Bug 18780 Deleting a member in Members view not always working
Build F2 I detected that in some cases deleting a memeber (was a method) from the Members view doesn't get removed from the list. Should fix for F3
verified fixed
69a5625
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T15:13:02Z
2002-06-03T16:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/MembersView.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.ui.IMemento; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.OverrideIndicatorLabelDecorator; import org.eclipse.jdt.ui.actions.MemberFilterActionGroup; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; public class MembersView extends JavaBrowsingPart { private MemberFilterActionGroup fMemberFilterActionGroup; public MembersView() { setHasWorkingSetFilter(false); setHasCustomSetFilter(false); } /** * Creates and returns the label provider for this part. * * @return the label provider * @see ILabelProvider */ protected ILabelProvider createLabelProvider() { return new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS, AppearanceAwareLabelProvider.getDecorators(true, new OverrideIndicatorLabelDecorator(null)) ); } /** * Returns the context ID for the Help system * * @return the string used as ID for the Help context */ protected String getHelpContextId() { return IJavaHelpContextIds.MEMBERS_VIEW; } /** * Creates the the viewer of this part. * * @param parent the parent for the viewer */ protected StructuredViewer createViewer(Composite parent) { ProblemTreeViewer viewer= new ProblemTreeViewer(parent, SWT.MULTI); fMemberFilterActionGroup= new MemberFilterActionGroup(viewer, JavaUI.ID_MEMBERS_VIEW); return viewer; } protected void fillToolBar(IToolBarManager tbm) { tbm.add(new LexicalSortingAction(getViewer(), JavaUI.ID_MEMBERS_VIEW)); fMemberFilterActionGroup.contributeToToolBar(tbm); } /** * Answers if the given <code>element</code> is a valid * input for this part. * * @param element the object to test * @return <true> if the given element is a valid input */ protected boolean isValidInput(Object element) { if (element instanceof IType) { IType type= (IType)element; return type.isBinary() || type.getDeclaringType() == null; } return false; } /** * Answers if the given <code>element</code> is a valid * element for this part. * * @param element the object to test * @return <true> if the given element is a valid element */ protected boolean isValidElement(Object element) { if (element instanceof IMember) return super.isValidElement(((IMember)element).getDeclaringType()); else if (element instanceof IImportDeclaration) return isValidElement(((IJavaElement)element).getParent()); else if (element instanceof IImportContainer) { Object input= getViewer().getInput(); if (input instanceof IJavaElement) { ICompilationUnit cu= (ICompilationUnit)((IJavaElement)input).getAncestor(IJavaElement.COMPILATION_UNIT); if (cu != null) { ICompilationUnit importContainerCu= (ICompilationUnit)((IJavaElement)element).getAncestor(IJavaElement.COMPILATION_UNIT); return cu.equals(importContainerCu); } else { IClassFile cf= (IClassFile)((IJavaElement)input).getAncestor(IJavaElement.CLASS_FILE); IClassFile importContainerCf= (IClassFile)((IJavaElement)element).getAncestor(IJavaElement.CLASS_FILE); return cf != null && cf.equals(importContainerCf); } } } return false; } /** * Finds the element which has to be selected in this part. * * @param je the Java element which has the focus */ protected IJavaElement findElementToSelect(IJavaElement je) { if (je == null) return null; switch (je.getElementType()) { case IJavaElement.TYPE: if (((IType)je).getDeclaringType() == null) return null; case IJavaElement.METHOD: case IJavaElement.FIELD: case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: case IJavaElement.IMPORT_DECLARATION: je= getSuitableJavaElement(je); if (je != null) return je; default: return null; } } /** * Finds the closest Java element which can be used as input for * this part and has the given Java element as child * * @param je the Java element for which to search the closest input * @return the closest Java element used as input for this part */ protected IJavaElement findInputForJavaElement(IJavaElement je) { if (je == null || !je.exists()) return null; switch (je.getElementType()) { case IJavaElement.TYPE: IType type= ((IType)je).getDeclaringType(); if (type == null) return je; else return findInputForJavaElement(type); case IJavaElement.COMPILATION_UNIT: return getTypeForCU((ICompilationUnit)je); case IJavaElement.CLASS_FILE: try { return findInputForJavaElement(((IClassFile)je).getType()); } catch (JavaModelException ex) { return null; } case IJavaElement.IMPORT_DECLARATION: return findInputForJavaElement(je.getParent()); case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: IJavaElement parent= je.getParent(); if (parent instanceof ICompilationUnit) { IType[] types; try { types= ((ICompilationUnit)parent).getAllTypes(); } catch (JavaModelException ex) { return null; } if (types.length > 0) return types[0]; else return null; } else if (parent instanceof IClassFile) return findInputForJavaElement(parent); default: if (je instanceof IMember) return findInputForJavaElement(((IMember)je).getDeclaringType()); } return null; } /* * Implements method from IViewPart. */ public void saveState(IMemento memento) { super.saveState(memento); fMemberFilterActionGroup.saveState(memento); } protected void restoreState(IMemento memento) { super.restoreState(memento); fMemberFilterActionGroup.restoreState(memento); getViewer().getControl().setRedraw(false); getViewer().refresh(); getViewer().getControl().setRedraw(true); } protected void hookViewerListeners() { super.hookViewerListeners(); getViewer().addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { TreeViewer viewer= (TreeViewer)getViewer(); Object element= ((IStructuredSelection)event.getSelection()).getFirstElement(); if (viewer.isExpandable(element)) viewer.setExpandedState(element, !viewer.getExpandedState(element)); } }); } }
5,877
Bug 5877 Rename package -> selection incorrect
1. select text in a .java file 2. rename the package of that file using the rename menu option 3. notice that the selection has moved Perhaps because selection index isn't updated when the .java file text changes to reflect the new package.
resolved fixed
a1769cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T17:27:55Z
2001-11-14T03:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Layout; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Preferences; import org.eclipse.core.runtime.Preferences.IPropertyChangeListener; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IMessageProvider; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.DocumentCommand; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ILineTracker; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.IWidgetTokenKeeper; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewerConfiguration; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.ContentAssistAction; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.tasklist.TaskList; import org.eclipse.help.IHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.compare.LocalHistoryActionGroup; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.SelectionHistory; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectEnclosingAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectHistoryAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectNextAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectPreviousAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionAction; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer; import org.eclipse.jdt.internal.ui.text.java.IReconcilingParticipant; /** * Java specific text editor. */ public class CompilationUnitEditor extends JavaEditor implements IReconcilingParticipant { interface ITextConverter { void customizeDocumentCommand(IDocument document, DocumentCommand command); }; class AdaptedRulerLayout extends Layout { protected int fGap; protected AdaptedSourceViewer fAdaptedSourceViewer; protected AdaptedRulerLayout(int gap, AdaptedSourceViewer asv) { fGap= gap; fAdaptedSourceViewer= asv; } protected Point computeSize(Composite composite, int wHint, int hHint, boolean flushCache) { Control[] children= composite.getChildren(); Point s= children[children.length - 1].computeSize(SWT.DEFAULT, SWT.DEFAULT, flushCache); if (fAdaptedSourceViewer.isVerticalRulerVisible()) s.x += fAdaptedSourceViewer.getVerticalRuler().getWidth() + fGap; return s; } protected void layout(Composite composite, boolean flushCache) { Rectangle clArea= composite.getClientArea(); if (fAdaptedSourceViewer.isVerticalRulerVisible()) { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); Rectangle trim= textWidget.computeTrim(0, 0, 0, 0); int scrollbarHeight= trim.height; IVerticalRuler vr= fAdaptedSourceViewer.getVerticalRuler(); int vrWidth=vr.getWidth(); int orWidth= 0; if (fAdaptedSourceViewer.isOverviewRulerVisible()) { OverviewRuler or= fAdaptedSourceViewer.getOverviewRuler(); orWidth= or.getWidth(); or.getControl().setBounds(clArea.width - orWidth, scrollbarHeight, orWidth, clArea.height - 3*scrollbarHeight); } textWidget.setBounds(vrWidth + fGap, 0, clArea.width - vrWidth - orWidth - 2*fGap, clArea.height); vr.getControl().setBounds(0, 0, vrWidth, clArea.height - scrollbarHeight); } else { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); textWidget.setBounds(0, 0, clArea.width, clArea.height); } } }; class AdaptedSourceViewer extends JavaCorrectionSourceViewer { private List fTextConverters; private OverviewRuler fOverviewRuler; private boolean fIsOverviewRulerVisible; private IVerticalRuler fCachedVerticalRuler; private boolean fCachedIsVerticalRulerVisible; public AdaptedSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { super(parent, ruler, styles, CompilationUnitEditor.this); fCachedVerticalRuler= ruler; fCachedIsVerticalRulerVisible= (ruler != null); fOverviewRuler= new OverviewRuler(VERTICAL_RULER_WIDTH); delayedCreateControl(parent, styles); } /* * @see ISourceViewer#showAnnotations(boolean) */ public void showAnnotations(boolean show) { fCachedIsVerticalRulerVisible= (show && fCachedVerticalRuler != null); super.showAnnotations(show); } public IContentAssistant getContentAssistant() { return fContentAssistant; } /* * @see ITextOperationTarget#doOperation(int) */ public void doOperation(int operation) { if (getTextWidget() == null) return; switch (operation) { case CONTENTASSIST_PROPOSALS: String msg= fContentAssistant.showPossibleCompletions(); setStatusLineErrorMessage(msg); return; } super.doOperation(operation); } public void insertTextConverter(ITextConverter textConverter, int index) { throw new UnsupportedOperationException(); } public void addTextConverter(ITextConverter textConverter) { if (fTextConverters == null) { fTextConverters= new ArrayList(1); fTextConverters.add(textConverter); } else if (!fTextConverters.contains(textConverter)) fTextConverters.add(textConverter); } public void removeTextConverter(ITextConverter textConverter) { if (fTextConverters != null) { fTextConverters.remove(textConverter); if (fTextConverters.size() == 0) fTextConverters= null; } } /* * @see TextViewer#customizeDocumentCommand(DocumentCommand) */ protected void customizeDocumentCommand(DocumentCommand command) { super.customizeDocumentCommand(command); if (fTextConverters != null) { for (Iterator e = fTextConverters.iterator(); e.hasNext();) ((ITextConverter) e.next()).customizeDocumentCommand(getDocument(), command); } } public IVerticalRuler getVerticalRuler() { return fCachedVerticalRuler; } public boolean isVerticalRulerVisible() { return fCachedIsVerticalRulerVisible; } public OverviewRuler getOverviewRuler() { return fOverviewRuler; } /* * @see TextViewer#createControl(Composite, int) */ protected void createControl(Composite parent, int styles) { // do nothing here } protected void delayedCreateControl(Composite parent, int styles) { //create the viewer super.createControl(parent, styles); Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.setLayout(new AdaptedRulerLayout(GAP_SIZE, this)); fOverviewRuler.createControl(composite, this); } } public void hideOverviewRuler() { fIsOverviewRulerVisible= false; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public void showOverviewRuler() { fIsOverviewRulerVisible= true; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public boolean isOverviewRulerVisible() { return fIsOverviewRulerVisible; } /* * @see ISourceViewer#setDocument(IDocument, IAnnotationModel, int, int) */ public void setDocument(IDocument document, IAnnotationModel annotationModel, int visibleRegionOffset, int visibleRegionLength) { super.setDocument(document, annotationModel, visibleRegionOffset, visibleRegionLength); fOverviewRuler.setModel(annotationModel); } // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 public void updateIndentationPrefixes() { SourceViewerConfiguration configuration= getSourceViewerConfiguration(); String[] types= configuration.getConfiguredContentTypes(this); for (int i= 0; i < types.length; i++) { String[] prefixes= configuration.getIndentPrefixes(this, types[i]); if (prefixes != null && prefixes.length > 0) setIndentPrefixes(prefixes, types[i]); } } /* * @see IWidgetTokenOwner#requestWidgetToken(IWidgetTokenKeeper) */ public boolean requestWidgetToken(IWidgetTokenKeeper requester) { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19445 IHelp help= WorkbenchHelp.getHelpSupport(); if (help != null && help.isContextHelpDisplayed()) return false; return super.requestWidgetToken(requester); } }; static class TabConverter implements ITextConverter { private int fTabRatio; private ILineTracker fLineTracker; public TabConverter() { } public void setNumberOfSpacesPerTab(int ratio) { fTabRatio= ratio; } public void setLineTracker(ILineTracker lineTracker) { fLineTracker= lineTracker; } private int insertTabString(StringBuffer buffer, int offsetInLine) { if (fTabRatio == 0) return 0; int remainder= offsetInLine % fTabRatio; remainder= fTabRatio - remainder; for (int i= 0; i < remainder; i++) buffer.append(' '); return remainder; } public void customizeDocumentCommand(IDocument document, DocumentCommand command) { String text= command.text; if (text == null) return; int index= text.indexOf('\t'); if (index > -1) { StringBuffer buffer= new StringBuffer(); fLineTracker.set(command.text); int lines= fLineTracker.getNumberOfLines(); try { for (int i= 0; i < lines; i++) { int offset= fLineTracker.getLineOffset(i); int endOffset= offset + fLineTracker.getLineLength(i); String line= text.substring(offset, endOffset); int position= 0; if (i == 0) { IRegion firstLine= document.getLineInformationOfOffset(command.offset); position= command.offset - firstLine.getOffset(); } int length= line.length(); for (int j= 0; j < length; j++) { char c= line.charAt(j); if (c == '\t') { position += insertTabString(buffer, position); } else { buffer.append(c); ++ position; } } } command.text= buffer.toString(); } catch (BadLocationException x) { } } } }; private class PropertyChangeListener implements IPropertyChangeListener { /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { handlePreferencePropertyChanged(event); } } /* Preference key for code formatter tab size */ private final static String CODE_FORMATTER_TAB_SIZE= JavaCore.FORMATTER_TAB_SIZE; /** Preference key for matching brackets */ public final static String MATCHING_BRACKETS= "matchingBrackets"; //$NON-NLS-1$ /** Preference key for matching brackets color */ public final static String MATCHING_BRACKETS_COLOR= "matchingBracketsColor"; //$NON-NLS-1$ /** Preference key for highlighting current line */ public final static String CURRENT_LINE= "currentLine"; //$NON-NLS-1$ /** Preference key for highlight color of current line */ public final static String CURRENT_LINE_COLOR= "currentLineColor"; //$NON-NLS-1$ /** Preference key for showing print marging ruler */ public final static String PRINT_MARGIN= "printMargin"; //$NON-NLS-1$ /** Preference key for print margin ruler color */ public final static String PRINT_MARGIN_COLOR= "printMarginColor"; //$NON-NLS-1$ /** Preference key for print margin ruler column */ public final static String PRINT_MARGIN_COLUMN= "printMarginColumn"; //$NON-NLS-1$ /** Preference key for inserting spaces rather than tabs */ public final static String SPACES_FOR_TABS= JavaSourceViewerConfiguration.SPACES_FOR_TABS; /** Preference key for problem indication */ public final static String PROBLEM_INDICATION= "problemIndication"; //$NON-NLS-1$ /** Preference key for problem highlight color */ public final static String PROBLEM_INDICATION_COLOR= "problemIndicationColor"; //$NON-NLS-1$ /** Preference key for linked position color */ public final static String LINKED_POSITION_COLOR= "linkedPositionColor"; //$NON-NLS-1$ /** Preference key for shwoing the overview ruler */ public final static String OVERVIEW_RULER= "overviewRuler"; //$NON-NLS-1$ /** The status line clearer */ protected ISelectionChangedListener fStatusLineClearer; /** The editor's save policy */ protected ISavePolicy fSavePolicy; /** Listener to annotation model changes that updates the error tick in the tab image */ private JavaEditorErrorTickUpdater fJavaEditorErrorTickUpdater; /** The editor's paint manager */ private PaintManager fPaintManager; /** The editor's bracket painter */ private BracketPainter fBracketPainter; /** The editor's line painter */ private LinePainter fLinePainter; /** The editor's print margin ruler painter */ private PrintMarginPainter fPrintMarginPainter; /** The editor's problem painter */ private ProblemPainter fProblemPainter; /** The editor's tab converter */ private TabConverter fTabConverter; /** History for structure select action */ private SelectionHistory fSelectionHistory; /** The preference property change listener for java core. */ private IPropertyChangeListener fPropertyChangeListener= new PropertyChangeListener(); /** The standard action groups added to the menu */ private GenerateActionGroup fGenerateActionGroup; private CompositeActionGroup fContextMenuGroup; /** * Creates a new compilation unit editor. */ public CompilationUnitEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getCompilationUnitDocumentProvider()); setEditorContextMenuId("#CompilationUnitEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#CompilationUnitRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#CompilationUnitOutlinerContext"); //$NON-NLS-1$ // don't set help contextId, we install our own help context fSavePolicy= null; fJavaEditorErrorTickUpdater= new JavaEditorErrorTickUpdater(this); } /* * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "CorrectionAssistProposal.", this, JavaCorrectionSourceViewer.CORRECTIONASSIST_PROPOSALS); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CORRECTION_ASSIST_PROPOSALS); setAction("CorrectionAssistProposal", action); //$NON-NLS-1$ action= new ContentAssistAction(JavaEditorMessages.getResourceBundle(), "ContentAssistProposal.", this); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS); setAction("ContentAssistProposal", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ContentAssistContextInformation.", this, ISourceViewer.CONTENTASSIST_CONTEXT_INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_CONTEXT_INFORMATION); setAction("ContentAssistContextInformation", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Comment.", this, ITextOperationTarget.PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.COMMENT); setAction("Comment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Uncomment.", this, ITextOperationTarget.STRIP_PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.UNCOMMENT); setAction("Uncomment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Format.", this, ISourceViewer.FORMAT); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.FORMAT); setAction("Format", action); //$NON-NLS-1$ markAsStateDependentAction("CorrectionAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistContextInformation", true); //$NON-NLS-1$ markAsStateDependentAction("Comment", true); //$NON-NLS-1$ markAsStateDependentAction("Uncomment", true); //$NON-NLS-1$ markAsStateDependentAction("Format", true); //$NON-NLS-1$ fSelectionHistory= new SelectionHistory(this); action= new StructureSelectEnclosingAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_ENCLOSING); setAction(StructureSelectionAction.ENCLOSING, action); action= new StructureSelectNextAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_NEXT); setAction(StructureSelectionAction.NEXT, action); action= new StructureSelectPreviousAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_PREVIOUS); setAction(StructureSelectionAction.PREVIOUS, action); StructureSelectHistoryAction historyAction= new StructureSelectHistoryAction(this, fSelectionHistory); historyAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_LAST); setAction(StructureSelectionAction.HISTORY, historyAction); fSelectionHistory.setHistoryAction(historyAction); fGenerateActionGroup= new GenerateActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); ActionGroup rg= new RefactorActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); fActionGroups.addGroup(rg); fActionGroups.addGroup(fGenerateActionGroup); // We have to keep the context menu group separate to have better control over positioning fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] { fGenerateActionGroup, rg, new LocalHistoryActionGroup(this, ITextEditorActionConstants.GROUP_EDIT)}); } /* * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { return getElementAt(offset, true); } /** * Returns the most narrow element including the given offset. If <code>reconcile</code> * is <code>true</code> the editor's input element is reconciled in advance. If it is * <code>false</code> this method only returns a result if the editor's input element * does not need to be reconciled. * * @param offset the offset included by the retrieved element * @param reconcile <code>true</code> if working copy should be reconciled */ protected IJavaElement getElementAt(int offset, boolean reconcile) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { if (reconcile) { synchronized (unit) { unit.reconcile(); } return unit.getElementAt(offset); } else if (unit.isConsistent()) return unit.getElementAt(offset); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { try { return EditorUtility.getWorkingCopy(element, true); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } return null; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow(IMenuManager) */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Format"); //$NON-NLS-1$ ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /* * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); page.setInput(manager.getWorkingCopy(input)); } } /* * @see AbstractTextEditor#performSaveOperation(WorkspaceModifyOperation, IProgressMonitor) */ protected void performSaveOperation(WorkspaceModifyOperation operation, IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(fSavePolicy); } try { super.performSaveOperation(operation, progressMonitor); } finally { if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(null); } } } /* * @see AbstractTextEditor#doSave(IProgressMonitor) */ public void doSave(IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p == null) return; if (p.isDeleted(getEditorInput())) { if (isSaveAsAllowed()) { /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed Behavior to make sure that if called inside a regular save (because * of deletion of input element) there is a way to report back to the caller. */ performSaveAs(progressMonitor); } else { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Shell shell= getSite().getShell(); MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title1"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message1")); //$NON-NLS-1$ //$NON-NLS-2$ } } else { setStatusLineErrorMessage(null); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { performSaveOperation(createSaveOperation(false), progressMonitor); } } else performSaveOperation(createSaveOperation(false), progressMonitor); } } /** * Jumps to the error next according to the given direction. */ public void gotoError(boolean forward) { ISelectionProvider provider= getSelectionProvider(); if (fStatusLineClearer != null) { provider.removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } ITextSelection s= (ITextSelection) provider.getSelection(); Position errorPosition= new Position(0, 0); IProblemAnnotation nextError= getNextError(s.getOffset(), forward, errorPosition); if (nextError != null) { IMarker marker= null; if (nextError instanceof MarkerAnnotation) marker= ((MarkerAnnotation) nextError).getMarker(); else { Iterator e= nextError.getOverlaidIterator(); if (e != null) { while (e.hasNext()) { Object o= e.next(); if (o instanceof MarkerAnnotation) { marker= ((MarkerAnnotation) o).getMarker(); break; } } } } if (marker != null) { IWorkbenchPage page= getSite().getPage(); IViewPart view= view= page.findView("org.eclipse.ui.views.TaskList"); //$NON-NLS-1$ if (view instanceof TaskList) { StructuredSelection ss= new StructuredSelection(marker); ((TaskList) view).setSelection(ss, true); } } selectAndReveal(errorPosition.getOffset(), errorPosition.getLength()); setStatusLineErrorMessage(nextError.getMessage()); } else { setStatusLineErrorMessage(null); } } /** * Sets the given message as error message to this editor's status line. * @param msg message to be set */ protected void setStatusLineErrorMessage(String msg) { // set error message getStatusLineManager().setErrorMessage(msg); // install message remover if (msg == null || msg.trim().length() == 0) { if (fStatusLineClearer != null) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } } else if (fStatusLineClearer == null) { fStatusLineClearer= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; getStatusLineManager().setErrorMessage(null); } }; getSelectionProvider().addSelectionChangedListener(fStatusLineClearer); } } private IProblemAnnotation getNextError(int offset, boolean forward, Position errorPosition) { IProblemAnnotation nextError= null; Position nextErrorPosition= null; IDocument document= getDocumentProvider().getDocument(getEditorInput()); int endOfDocument= document.getLength(); int distance= 0; IAnnotationModel model= getDocumentProvider().getAnnotationModel(getEditorInput()); Iterator e= new ProblemAnnotationIterator(model, false); while (e.hasNext()) { IProblemAnnotation a= (IProblemAnnotation) e.next(); if (a.hasOverlay() || !a.isProblem()) continue; Position p= model.getPosition((Annotation) a); if (!p.includes(offset)) { int currentDistance= 0; if (forward) { currentDistance= p.getOffset() - offset; if (currentDistance < 0) currentDistance= endOfDocument - offset + p.getOffset(); } else { currentDistance= offset - p.getOffset(); if (currentDistance < 0) currentDistance= offset + endOfDocument - p.getOffset(); } if (nextError == null || currentDistance < distance) { distance= currentDistance; nextError= a; nextErrorPosition= p; } } } if (nextErrorPosition != null) { errorPosition.setOffset(nextErrorPosition.getOffset()); errorPosition.setLength(nextErrorPosition.getLength()); } return nextError; } /* * @see AbstractTextEditor#isSaveAsAllowed() */ public boolean isSaveAsAllowed() { return true; } /** * The compilation unit editor implementation of this <code>AbstractTextEditor</code> * method asks the user for the workspace path of a file resource and saves the document * there. See http://dev.eclipse.org/bugs/show_bug.cgi?id=6295 */ protected void performSaveAs(IProgressMonitor progressMonitor) { Shell shell= getSite().getShell(); SaveAsDialog dialog= new SaveAsDialog(shell); dialog.create(); IEditorInput input = getEditorInput(); IFile original= (input instanceof IFileEditorInput) ? ((IFileEditorInput) input).getFile() : null; if (original != null) dialog.setOriginalFile(original); IDocumentProvider provider= getDocumentProvider(); if (provider.isDeleted(input) && original != null) { String message= JavaEditorMessages.getFormattedString("CompilationUnitEditor.warning.save.delete", new Object[] { original.getName() }); dialog.setMessage(message, IMessageProvider.WARNING); } if (dialog.open() == Dialog.CANCEL) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IPath filePath= dialog.getResult(); if (filePath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IWorkspace workspace= ResourcesPlugin.getWorkspace(); IFile file= workspace.getRoot().getFile(filePath); final IEditorInput newInput= new FileEditorInput(file); WorkspaceModifyOperation op= new WorkspaceModifyOperation() { public void execute(final IProgressMonitor monitor) throws CoreException { getDocumentProvider().saveDocument(monitor, newInput, getDocumentProvider().getDocument(getEditorInput()), true); } }; boolean success= false; try { getDocumentProvider().aboutToChange(newInput); new ProgressMonitorDialog(shell).run(false, true, op); success= true; } catch (InterruptedException x) { } catch (InvocationTargetException x) { Throwable t= x.getTargetException(); if (t instanceof CoreException) { CoreException cx= (CoreException) t; ErrorDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title2"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message2"), cx.getStatus()); //$NON-NLS-1$ //$NON-NLS-2$ } else { MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title3"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message3") + t.getMessage()); //$NON-NLS-1$ //$NON-NLS-2$ } } finally { getDocumentProvider().changed(newInput); if (success) setInput(newInput); } if (progressMonitor != null) progressMonitor.setCanceled(!success); } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); configureTabConverter(); } private void startBracketHighlighting() { if (fBracketPainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fBracketPainter= new BracketPainter(sourceViewer); fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); fPaintManager.addPainter(fBracketPainter); } } private void stopBracketHighlighting() { if (fBracketPainter != null) { fPaintManager.removePainter(fBracketPainter); fBracketPainter.deactivate(true); fBracketPainter.dispose(); fBracketPainter= null; } } private boolean isBracketHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(MATCHING_BRACKETS); } private void startLineHighlighting() { if (fLinePainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fLinePainter= new LinePainter(sourceViewer); fLinePainter.setHighlightColor(getColor(CURRENT_LINE_COLOR)); fPaintManager.addPainter(fLinePainter); } } private void stopLineHighlighting() { if (fLinePainter != null) { fPaintManager.removePainter(fLinePainter); fLinePainter.deactivate(true); fLinePainter.dispose(); fLinePainter= null; } } private boolean isLineHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(CURRENT_LINE); } private void showPrintMargin() { if (fPrintMarginPainter == null) { fPrintMarginPainter= new PrintMarginPainter(getSourceViewer()); fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); fPaintManager.addPainter(fPrintMarginPainter); } } private void hidePrintMargin() { if (fPrintMarginPainter != null) { fPaintManager.removePainter(fPrintMarginPainter); fPrintMarginPainter.deactivate(true); fPrintMarginPainter.dispose(); fPrintMarginPainter= null; } } private boolean isPrintMarginVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PRINT_MARGIN); } private void startProblemIndication() { if (fProblemPainter == null) { fProblemPainter= new ProblemPainter(this, getSourceViewer()); fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); fPaintManager.addPainter(fProblemPainter); } } private void stopProblemIndication() { if (fProblemPainter != null) { fPaintManager.removePainter(fProblemPainter); fProblemPainter.deactivate(true); fProblemPainter.dispose(); fProblemPainter= null; } } private boolean isProblemIndicationEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PROBLEM_INDICATION); } private void configureTabConverter() { if (fTabConverter != null) { IDocumentProvider provider= getDocumentProvider(); if (provider instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cup= (CompilationUnitDocumentProvider) provider; fTabConverter.setLineTracker(cup.createLineTracker(getEditorInput())); } } } private int getTabSize() { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); return preferences.getInt(CODE_FORMATTER_TAB_SIZE); } private void startTabConversion() { if (fTabConverter == null) { fTabConverter= new TabConverter(); configureTabConverter(); fTabConverter.setNumberOfSpacesPerTab(getTabSize()); AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.addTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); } } private void stopTabConversion() { if (fTabConverter != null) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.removeTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); fTabConverter= null; } } private boolean isTabConversionEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(SPACES_FOR_TABS); } private void showOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.showOverviewRuler(); } private void hideOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.hideOverviewRuler(); } private boolean isOverviewRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(OVERVIEW_RULER); } private Color getColor(String key) { RGB rgb= PreferenceConverter.getColor(getPreferenceStore(), key); return getColor(rgb); } private Color getColor(RGB rgb) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.getColorManager().getColor(rgb); } /* * @see AbstractTextEditor#dispose() */ public void dispose() { if (fPropertyChangeListener != null) { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.removePropertyChangeListener(fPropertyChangeListener); fPropertyChangeListener= null; } if (fJavaEditorErrorTickUpdater != null) { fJavaEditorErrorTickUpdater.dispose(); fJavaEditorErrorTickUpdater= null; } if (fSelectionHistory != null) fSelectionHistory.dispose(); stopBracketHighlighting(); stopLineHighlighting(); if (fPaintManager != null) { fPaintManager.dispose(); fPaintManager= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /* * @see AbstractTextEditor#createPartControl(Composite) */ public void createPartControl(Composite parent) { super.createPartControl(parent); fPaintManager= new PaintManager(getSourceViewer()); if (isBracketHighlightingEnabled()) startBracketHighlighting(); if (isLineHighlightingEnabled()) startLineHighlighting(); if (isPrintMarginVisible()) showPrintMargin(); if (isProblemIndicationEnabled()) startProblemIndication(); if (isTabConversionEnabled()) startTabConversion(); if (isOverviewRulerVisible()) showOverviewRuler(); Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.addPropertyChangeListener(fPropertyChangeListener); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (SPACES_FOR_TABS.equals(p)) { if (isTabConversionEnabled()) startTabConversion(); else stopTabConversion(); return; } if (MATCHING_BRACKETS.equals(p)) { if (isBracketHighlightingEnabled()) startBracketHighlighting(); else stopBracketHighlighting(); return; } if (MATCHING_BRACKETS_COLOR.equals(p)) { if (fBracketPainter != null) fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); return; } if (CURRENT_LINE.equals(p)) { if (isLineHighlightingEnabled()) startLineHighlighting(); else stopLineHighlighting(); return; } if (CURRENT_LINE_COLOR.equals(p)) { if (fLinePainter != null) { stopLineHighlighting(); startLineHighlighting(); } return; } if (PRINT_MARGIN.equals(p)) { if (isPrintMarginVisible()) showPrintMargin(); else hidePrintMargin(); return; } if (PRINT_MARGIN_COLOR.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); return; } if (PRINT_MARGIN_COLUMN.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); return; } if (PROBLEM_INDICATION.equals(p)) { if (isProblemIndicationEnabled()) startProblemIndication(); else stopProblemIndication(); return; } if (PROBLEM_INDICATION_COLOR.equals(p)) { if (fProblemPainter != null) fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); return; } if (OVERVIEW_RULER.equals(p)) { if (isOverviewRulerVisible()) showOverviewRuler(); else hideOverviewRuler(); return; } IContentAssistant c= asv.getContentAssistant(); if (c instanceof ContentAssistant) ContentAssistPreference.changeConfiguration((ContentAssistant) c, getPreferenceStore(), event); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Handles a property change event describing a change * of the java core's preferences and updates the preference * related editor properties. * * @param event the property change event */ protected void handlePreferencePropertyChanged(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (CODE_FORMATTER_TAB_SIZE.equals(p)) { asv.updateIndentationPrefixes(); if (fTabConverter != null) fTabConverter.setNumberOfSpacesPerTab(getTabSize()); } } } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { String p= event.getProperty(); boolean affects=MATCHING_BRACKETS_COLOR.equals(p) || CURRENT_LINE_COLOR.equals(p) || PROBLEM_INDICATION_COLOR.equals(p); return affects ? affects : super.affectsTextPresentation(event); } /* * @see JavaEditor#createJavaSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return new AdaptedSourceViewer(parent, ruler, styles); } /* * @see JavaEditor#synchronizeOutlinePageSelection() */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret, false); ISourceReference reference= getSourceReference(element, caret); if (reference != null) fOutlinePage.select(reference); } private ISourceReference getSourceReference(IJavaElement element, int offset) { if ( !(element instanceof ISourceReference)) return null; if (element.getElementType() == IJavaElement.IMPORT_DECLARATION) { IImportDeclaration declaration= (IImportDeclaration) element; IImportContainer container= (IImportContainer) declaration.getParent(); ISourceRange srcRange= null; try { srcRange= container.getSourceRange(); } catch (JavaModelException e) { } if (srcRange != null && srcRange.getOffset() == offset) return container; } return (ISourceReference) element; } /* * @see IReconcilingParticipant#reconciled() */ public void reconciled() { if (!JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) { Shell shell= getSite().getShell(); if (shell != null && !shell.isDisposed()) { shell.getDisplay().asyncExec(new Runnable() { public void run() { synchronizeOutlinePageSelection(); } }); } } } protected void updateStateDependentActions() { super.updateStateDependentActions(); fGenerateActionGroup.editorStateChanged(); } }
19,104
Bug 19104 Basket for problems with .java files outside build path
1) .java file is not inside a source folder - "Rename" refactoring is enabled but does not work: no preview and does not rename if finished is pressed. 2) .java file that is inside a non-Java project - Lots of problems when views hold on to a working copy which can not be mapped to a compilation unit after the editor has been closed - shows red squiggly lines when using "Show Source of selected element only" - same problems as 1) MORE WILL FOLLOW TOMORROW
verified fixed
b5a2f95
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T18:51:03Z
2002-06-04T17:00:00Z
org.eclipse.jdt.ui/ui
19,104
Bug 19104 Basket for problems with .java files outside build path
1) .java file is not inside a source folder - "Rename" refactoring is enabled but does not work: no preview and does not rename if finished is pressed. 2) .java file that is inside a non-Java project - Lots of problems when views hold on to a working copy which can not be mapped to a compilation unit after the editor has been closed - shows red squiggly lines when using "Show Source of selected element only" - same problems as 1) MORE WILL FOLLOW TOMORROW
verified fixed
b5a2f95
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T18:51:03Z
2002-06-04T17:00:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/actions/RenameJavaElementAction.java
19,104
Bug 19104 Basket for problems with .java files outside build path
1) .java file is not inside a source folder - "Rename" refactoring is enabled but does not work: no preview and does not rename if finished is pressed. 2) .java file that is inside a non-Java project - Lots of problems when views hold on to a working copy which can not be mapped to a compilation unit after the editor has been closed - shows red squiggly lines when using "Show Source of selected element only" - same problems as 1) MORE WILL FOLLOW TOMORROW
verified fixed
b5a2f95
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T18:51:03Z
2002-06-04T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/ActionUtil.java
19,104
Bug 19104 Basket for problems with .java files outside build path
1) .java file is not inside a source folder - "Rename" refactoring is enabled but does not work: no preview and does not rename if finished is pressed. 2) .java file that is inside a non-Java project - Lots of problems when views hold on to a working copy which can not be mapped to a compilation unit after the editor has been closed - shows red squiggly lines when using "Show Source of selected element only" - same problems as 1) MORE WILL FOLLOW TOMORROW
verified fixed
b5a2f95
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T18:51:03Z
2002-06-04T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/ModifyParametersAction.java
package org.eclipse.jdt.ui.actions; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.structure.ModifyParametersRefactoring; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.refactoring.ModifyParametersWizard; import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages; import org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; public class ModifyParametersAction extends SelectionDispatchAction { private ModifyParametersRefactoring fRefactoring; private CompilationUnitEditor fEditor; public ModifyParametersAction(CompilationUnitEditor editor) { this(editor.getEditorSite()); fEditor= editor; setEnabled(SelectionConverter.canOperateOn(fEditor)); } public ModifyParametersAction(IWorkbenchSite site) { super(site); setText(RefactoringMessages.getString("RefactoringGroup.modify_Parameters_label"));//$NON-NLS-1$ } /* * @see SelectionDispatchAction#selectionChanged(IStructuredSelection) */ protected void selectionChanged(IStructuredSelection selection) { setEnabled(canEnable(selection)); } /* * @see SelectionDispatchAction#selectionChanged(ITextSelection) */ protected void selectionChanged(ITextSelection selection) { } /* * @see SelectionDispatchAction#run(IStructuredSelection) */ protected void run(IStructuredSelection selection) { startRefactoring(); } /* * @see SelectionDispatchAction#run(ITextSelection) */ protected void run(ITextSelection selection) { if (! canRun(selection)){ String unavailable= RefactoringMessages.getString("ModifyParametersAction.unavailable"); //$NON-NLS-1$ MessageDialog.openInformation(getShell(), RefactoringMessages.getString("OpenRefactoringWizardAction.unavailable"), unavailable); //$NON-NLS-1$ fRefactoring= null; return; } startRefactoring(); } private boolean canEnable(IStructuredSelection selection){ if (selection.isEmpty() || selection.size() != 1) return false; Object first= selection.getFirstElement(); return (first instanceof IMethod) && shouldAcceptElement((IMethod)first); } private boolean canRun(ITextSelection selection){ IJavaElement[] elements= resolveElements(); if (elements.length != 1) return false; return (elements[0] instanceof IMethod) && shouldAcceptElement((IMethod)elements[0]); } private boolean shouldAcceptElement(IMethod method) { try{ fRefactoring= new ModifyParametersRefactoring(method); return fRefactoring.checkPreactivation().isOK(); } catch (JavaModelException e) { // http://bugs.eclipse.org/bugs/show_bug.cgi?id=19253 if (JavaModelUtil.filterNotPresentException(e)) JavaPlugin.log(e); //this happen on selection changes in viewers - do not show ui if fails, just log return false; } } private IJavaElement[] resolveElements() { return SelectionConverter.codeResolveHandled(fEditor, getShell(), RefactoringMessages.getString("OpenRefactoringWizardAction.refactoring")); //$NON-NLS-1$ } private RefactoringWizard createWizard(){ String title= RefactoringMessages.getString("RefactoringGroup.modify_method_parameters"); //$NON-NLS-1$ //FIX ME: wrong String helpId= IJavaHelpContextIds.RENAME_PARAMS_ERROR_WIZARD_PAGE; return new ModifyParametersWizard(fRefactoring, title, helpId); } private void startRefactoring() { Assert.isNotNull(fRefactoring); try{ Object newElementToProcess= new RefactoringStarter().activate(fRefactoring, createWizard(), RefactoringMessages.getString("OpenRefactoringWizardAction.refactoring"), true); //$NON-NLS-1$ if (newElementToProcess == null) return; IStructuredSelection mockSelection= new StructuredSelection(newElementToProcess); selectionChanged(mockSelection); if (isEnabled()) run(mockSelection); else MessageDialog.openInformation(JavaPlugin.getActiveWorkbenchShell(), ActionMessages.getString("ModifyParameterAction.problem.title"), ActionMessages.getString("ModifyParameterAction.problem.message")); //$NON-NLS-1$ //$NON-NLS-2$ } catch (JavaModelException e){ ExceptionHandler.handle(e, RefactoringMessages.getString("OpenRefactoringWizardAction.refactoring"), RefactoringMessages.getString("OpenRefactoringWizardAction.exception")); //$NON-NLS-1$ //$NON-NLS-2$ } } }
19,104
Bug 19104 Basket for problems with .java files outside build path
1) .java file is not inside a source folder - "Rename" refactoring is enabled but does not work: no preview and does not rename if finished is pressed. 2) .java file that is inside a non-Java project - Lots of problems when views hold on to a working copy which can not be mapped to a compilation unit after the editor has been closed - shows red squiggly lines when using "Show Source of selected element only" - same problems as 1) MORE WILL FOLLOW TOMORROW
verified fixed
b5a2f95
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T18:51:03Z
2002-06-04T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/OpenExternalJavadocAction.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.io.File; import java.net.URL; import java.text.MessageFormat; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.core.runtime.CoreException; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.OpenBrowserUtil; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; /** * This action opens the Javadoc in an external broder if the selected element * is represented by either * <ul> * <li>a text selection inside a Java editor, or </li> * <li>a structured selection of a view part showing Java elements</li> * </ul> * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class OpenExternalJavadocAction extends SelectionDispatchAction { private static boolean webBrowserOpened = false; private JavaEditor fEditor; /** * Creates a new <code>OpenExternalJavadocAction</code>. * * @param site the site providing additional context information for * this action */ public OpenExternalJavadocAction(IWorkbenchSite site) { super(site); setText(ActionMessages.getString("OpenExternalJavadocAction.label")); //$NON-NLS-1$ setDescription(ActionMessages.getString("OpenExternalJavadocAction.description")); //$NON-NLS-1$ setToolTipText(ActionMessages.getString("OpenExternalJavadocAction.tooltip")); //$NON-NLS-1$ } /** * Creates a new <code>OpenExternalJavadocAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public OpenExternalJavadocAction(JavaEditor editor) { this(editor.getEditorSite()); fEditor= editor; setEnabled(SelectionConverter.canOperateOn(fEditor)); } /* (non-Javadoc) * Method declared on SelectionDispatchAction */ protected String getDialogTitle() { return getTitle(); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(ITextSelection selection) { } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(IStructuredSelection selection) { setEnabled(checkEnabled(selection)); } private boolean checkEnabled(IStructuredSelection selection) { if (selection.size() != 1) return false; return selection.getFirstElement() instanceof IJavaElement; } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(ITextSelection selection) { try { run(SelectionConverter.codeResolveOrInput(fEditor, getShell(), getDialogTitle(), ActionMessages.getString("OpenExternalJavadocAction.select_element"))); //$NON-NLS-1$ } catch(JavaModelException e) { ExceptionHandler.handle(e, getShell(), getDialogTitle(), ActionMessages.getString("OpenExternalJavadocAction.code_resolve_failed")); //$NON-NLS-1$ } } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(IStructuredSelection selection) { if (!checkEnabled(selection)) return; run((IJavaElement)selection.getFirstElement()); } private void run(IJavaElement element) { if (element == null) return; Shell shell= getShell(); try { String labelName= JavaElementLabels.getElementLabel(element, JavaElementLabels.M_PARAMETER_TYPES); URL baseURL= JavaDocLocations.getJavadocBaseLocation(element); if (baseURL == null) { IPackageFragmentRoot root= JavaModelUtil.getPackageFragmentRoot(element); if (root != null && root.getKind() == IPackageFragmentRoot.K_BINARY) { String message= ActionMessages.getString("OpenExternalJavadocAction.libraries.no_location"); //$NON-NLS-1$ showMessage(shell, MessageFormat.format(message, new String[] { labelName, root.getElementName() }), false); } else { IJavaElement annotatedElement= element.getJavaProject(); String message= ActionMessages.getString("OpenExternalJavadocAction.source.no_location"); //$NON-NLS-1$ showMessage(shell, MessageFormat.format(message, new String[] { labelName, annotatedElement.getElementName() }), false); } return; } if ("file".equals(baseURL.getProtocol())) { //$NON-NLS-1$ URL noRefURL= JavaDocLocations.getJavadocLocation(element, false); if (!(new File(noRefURL.getFile())).isFile()) { String message= ActionMessages.getString("OpenExternalJavadocAction.no_entry"); //$NON-NLS-1$ showMessage(shell, MessageFormat.format(message, new String[] { labelName, noRefURL.toExternalForm() }), false); return; } } URL url= JavaDocLocations.getJavadocLocation(element, true); if (url != null) { OpenBrowserUtil.open(url, shell, getTitle()); } } catch (CoreException e) { JavaPlugin.log(e); showMessage(shell, ActionMessages.getString("OpenExternalJavadocAction.opening_failed"), true); //$NON-NLS-1$ } } private static void showMessage(final Shell shell, final String message, final boolean isError) { Display.getDefault().asyncExec(new Runnable() { public void run() { if (isError) { MessageDialog.openError(shell, getTitle(), message); //$NON-NLS-1$ } else { MessageDialog.openInformation(shell, getTitle(), message); //$NON-NLS-1$ } } }); } private static String getTitle() { return ActionMessages.getString("OpenExternalJavadocAction.dialog.title"); //$NON-NLS-1$ } }
19,104
Bug 19104 Basket for problems with .java files outside build path
1) .java file is not inside a source folder - "Rename" refactoring is enabled but does not work: no preview and does not rename if finished is pressed. 2) .java file that is inside a non-Java project - Lots of problems when views hold on to a working copy which can not be mapped to a compilation unit after the editor has been closed - shows red squiggly lines when using "Show Source of selected element only" - same problems as 1) MORE WILL FOLLOW TOMORROW
verified fixed
b5a2f95
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T18:51:03Z
2002-06-04T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/ShowInPackageViewAction.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.core.resources.IResource; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.OpenActionUtil; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; /** * This action reveals the currently selected Java element in the packages * view. The Java element can be represeented by either * <ul> * <li>a text selection inside a Java editor, or </li> * <li>a structured selection of a view part showing Java elements</li> * </ul> * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class ShowInPackageViewAction extends SelectionDispatchAction { private JavaEditor fEditor; /** * Creates a new <code>ShowInPackageViewAction</code>. * * @param site the site providing context information for this action */ public ShowInPackageViewAction(IWorkbenchSite site) { super(site); setText(ActionMessages.getString("ShowInPackageViewAction.label")); //$NON-NLS-1$ setDescription(ActionMessages.getString("ShowInPackageViewAction.description")); //$NON-NLS-1$ setToolTipText(ActionMessages.getString("ShowInPackageViewAction.tooltip")); //$NON-NLS-1$ WorkbenchHelp.setHelp(this, IJavaHelpContextIds.SHOW_IN_PACKAGEVIEW_ACTION); } /** * Creates a new <code>ShowInPackageViewAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public ShowInPackageViewAction(JavaEditor editor) { this(editor.getEditorSite()); fEditor= editor; setEnabled(SelectionConverter.canOperateOn(fEditor)); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(ITextSelection selection) { } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(IStructuredSelection selection) { setEnabled(checkEnabled(selection)); } private boolean checkEnabled(IStructuredSelection selection) { if (selection.size() != 1) return false; return selection.getFirstElement() instanceof IJavaElement; } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(ITextSelection selection) { try { IJavaElement element= SelectionConverter.getElementAtOffset(fEditor); if (element != null) run(element); } catch (JavaModelException e) { JavaPlugin.log(e); String message= ActionMessages.getString("ShowInPackageViewAction.error.message"); //$NON-NLS-1$ ErrorDialog.openError(getShell(), getDialogTitle(), message, e.getStatus()); } } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(IStructuredSelection selection) { if (!checkEnabled(selection)) return; run((IJavaElement)selection.getFirstElement()); } private void run(IJavaElement element) { if (element == null) return; boolean showMembers= JavaPlugin.getDefault().getPreferenceStore().getBoolean(AppearancePreferencePage.SHOW_CU_CHILDREN); PackageExplorerPart view= PackageExplorerPart.openInActivePerspective(); if (view != null) { if (reveal(view, element)) return; if (showMembers && element instanceof IMember) { // Since the packages view shows working copy elements it can happen that we try to show an original element // in the packages view. Fall back to working copy element IMember member= (IMember)element; if (!member.getCompilationUnit().isWorkingCopy()) { try { element= EditorUtility.getWorkingCopy(member); if (reveal(view, element)) return; } catch (JavaModelException e) { } } } element= getVisibleParent(element); if (element != null) { if (reveal(view, element)) return; IResource resource= null; try { resource= element.getCorrespondingResource(); } catch (JavaModelException e) { } if (resource != null) { if (reveal(view, resource)) return; } } MessageDialog.openInformation(getShell(), getDialogTitle(), ActionMessages.getString("ShowInPackageViewAction.not_found")); //$NON-NLS-1$ } } private boolean reveal(PackageExplorerPart view, Object element) { view.selectReveal(new StructuredSelection(element)); if (element.equals(getSelectedElement(view))) return true; return false; } private Object getSelectedElement(PackageExplorerPart view) { return ((IStructuredSelection)view.getSite().getSelectionProvider().getSelection()).getFirstElement(); } private IJavaElement getVisibleParent(IJavaElement element) { switch (element.getElementType()) { case IJavaElement.IMPORT_DECLARATION: case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: case IJavaElement.TYPE: case IJavaElement.METHOD: case IJavaElement.FIELD: case IJavaElement.INITIALIZER: // select parent cu/classfile element= (IJavaElement)element.getOpenable(); break; case IJavaElement.JAVA_MODEL: element= null; break; } if (element.getElementType() == IJavaElement.COMPILATION_UNIT) { ICompilationUnit unit= (ICompilationUnit)element; if (unit.isWorkingCopy()) element= unit.getOriginalElement(); } return element; } private static String getDialogTitle() { return ActionMessages.getString("ShowInPackageViewAction.dialog.title"); //$NON-NLS-1$ } }
19,075
Bug 19075 Rename Java file to non Java file causes most actions to crash
F2 - open Java file in editor - rename it so that it has the extension .txt Almost all Java relevant actions in Edit, Source, Refactor, Naviagte and context menu are still enabled. Executing them almost always leads to some sort of exceptions.
verified fixed
aeac1b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T21:21:27Z
2002-06-04T14:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Layout; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Preferences; import org.eclipse.core.runtime.Preferences.IPropertyChangeListener; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IMessageProvider; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.DocumentCommand; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ILineTracker; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.IWidgetTokenKeeper; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewerConfiguration; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.ContentAssistAction; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.tasklist.TaskList; import org.eclipse.help.IHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.compare.LocalHistoryActionGroup; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.SelectionHistory; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectEnclosingAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectHistoryAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectNextAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectPreviousAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionAction; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer; import org.eclipse.jdt.internal.ui.text.java.IReconcilingParticipant; /** * Java specific text editor. */ public class CompilationUnitEditor extends JavaEditor implements IReconcilingParticipant { interface ITextConverter { void customizeDocumentCommand(IDocument document, DocumentCommand command); }; class AdaptedRulerLayout extends Layout { protected int fGap; protected AdaptedSourceViewer fAdaptedSourceViewer; protected AdaptedRulerLayout(int gap, AdaptedSourceViewer asv) { fGap= gap; fAdaptedSourceViewer= asv; } protected Point computeSize(Composite composite, int wHint, int hHint, boolean flushCache) { Control[] children= composite.getChildren(); Point s= children[children.length - 1].computeSize(SWT.DEFAULT, SWT.DEFAULT, flushCache); if (fAdaptedSourceViewer.isVerticalRulerVisible()) s.x += fAdaptedSourceViewer.getVerticalRuler().getWidth() + fGap; return s; } protected void layout(Composite composite, boolean flushCache) { Rectangle clArea= composite.getClientArea(); if (fAdaptedSourceViewer.isVerticalRulerVisible()) { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); Rectangle trim= textWidget.computeTrim(0, 0, 0, 0); int scrollbarHeight= trim.height; IVerticalRuler vr= fAdaptedSourceViewer.getVerticalRuler(); int vrWidth=vr.getWidth(); int orWidth= 0; if (fAdaptedSourceViewer.isOverviewRulerVisible()) { OverviewRuler or= fAdaptedSourceViewer.getOverviewRuler(); orWidth= or.getWidth(); or.getControl().setBounds(clArea.width - orWidth, scrollbarHeight, orWidth, clArea.height - 3*scrollbarHeight); } textWidget.setBounds(vrWidth + fGap, 0, clArea.width - vrWidth - orWidth - 2*fGap, clArea.height); vr.getControl().setBounds(0, 0, vrWidth, clArea.height - scrollbarHeight); } else { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); textWidget.setBounds(0, 0, clArea.width, clArea.height); } } }; class AdaptedSourceViewer extends JavaCorrectionSourceViewer { private List fTextConverters; private OverviewRuler fOverviewRuler; private boolean fIsOverviewRulerVisible; private IVerticalRuler fCachedVerticalRuler; private boolean fCachedIsVerticalRulerVisible; public AdaptedSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { super(parent, ruler, styles, CompilationUnitEditor.this); fCachedVerticalRuler= ruler; fCachedIsVerticalRulerVisible= (ruler != null); fOverviewRuler= new OverviewRuler(VERTICAL_RULER_WIDTH); delayedCreateControl(parent, styles); } /* * @see ISourceViewer#showAnnotations(boolean) */ public void showAnnotations(boolean show) { fCachedIsVerticalRulerVisible= (show && fCachedVerticalRuler != null); super.showAnnotations(show); } public IContentAssistant getContentAssistant() { return fContentAssistant; } /* * @see ITextOperationTarget#doOperation(int) */ public void doOperation(int operation) { if (getTextWidget() == null) return; switch (operation) { case CONTENTASSIST_PROPOSALS: String msg= fContentAssistant.showPossibleCompletions(); setStatusLineErrorMessage(msg); return; } super.doOperation(operation); } public void insertTextConverter(ITextConverter textConverter, int index) { throw new UnsupportedOperationException(); } public void addTextConverter(ITextConverter textConverter) { if (fTextConverters == null) { fTextConverters= new ArrayList(1); fTextConverters.add(textConverter); } else if (!fTextConverters.contains(textConverter)) fTextConverters.add(textConverter); } public void removeTextConverter(ITextConverter textConverter) { if (fTextConverters != null) { fTextConverters.remove(textConverter); if (fTextConverters.size() == 0) fTextConverters= null; } } /* * @see TextViewer#customizeDocumentCommand(DocumentCommand) */ protected void customizeDocumentCommand(DocumentCommand command) { super.customizeDocumentCommand(command); if (fTextConverters != null) { for (Iterator e = fTextConverters.iterator(); e.hasNext();) ((ITextConverter) e.next()).customizeDocumentCommand(getDocument(), command); } } public IVerticalRuler getVerticalRuler() { return fCachedVerticalRuler; } public boolean isVerticalRulerVisible() { return fCachedIsVerticalRulerVisible; } public OverviewRuler getOverviewRuler() { return fOverviewRuler; } /* * @see TextViewer#createControl(Composite, int) */ protected void createControl(Composite parent, int styles) { // do nothing here } protected void delayedCreateControl(Composite parent, int styles) { //create the viewer super.createControl(parent, styles); Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.setLayout(new AdaptedRulerLayout(GAP_SIZE, this)); fOverviewRuler.createControl(composite, this); } } public void hideOverviewRuler() { fIsOverviewRulerVisible= false; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public void showOverviewRuler() { fIsOverviewRulerVisible= true; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public boolean isOverviewRulerVisible() { return fIsOverviewRulerVisible; } /* * @see ISourceViewer#setDocument(IDocument, IAnnotationModel, int, int) */ public void setDocument(IDocument document, IAnnotationModel annotationModel, int visibleRegionOffset, int visibleRegionLength) { super.setDocument(document, annotationModel, visibleRegionOffset, visibleRegionLength); fOverviewRuler.setModel(annotationModel); } // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 public void updateIndentationPrefixes() { SourceViewerConfiguration configuration= getSourceViewerConfiguration(); String[] types= configuration.getConfiguredContentTypes(this); for (int i= 0; i < types.length; i++) { String[] prefixes= configuration.getIndentPrefixes(this, types[i]); if (prefixes != null && prefixes.length > 0) setIndentPrefixes(prefixes, types[i]); } } /* * @see IWidgetTokenOwner#requestWidgetToken(IWidgetTokenKeeper) */ public boolean requestWidgetToken(IWidgetTokenKeeper requester) { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19445 IHelp help= WorkbenchHelp.getHelpSupport(); if (help != null && help.isContextHelpDisplayed()) return false; return super.requestWidgetToken(requester); } }; static class TabConverter implements ITextConverter { private int fTabRatio; private ILineTracker fLineTracker; public TabConverter() { } public void setNumberOfSpacesPerTab(int ratio) { fTabRatio= ratio; } public void setLineTracker(ILineTracker lineTracker) { fLineTracker= lineTracker; } private int insertTabString(StringBuffer buffer, int offsetInLine) { if (fTabRatio == 0) return 0; int remainder= offsetInLine % fTabRatio; remainder= fTabRatio - remainder; for (int i= 0; i < remainder; i++) buffer.append(' '); return remainder; } public void customizeDocumentCommand(IDocument document, DocumentCommand command) { String text= command.text; if (text == null) return; int index= text.indexOf('\t'); if (index > -1) { StringBuffer buffer= new StringBuffer(); fLineTracker.set(command.text); int lines= fLineTracker.getNumberOfLines(); try { for (int i= 0; i < lines; i++) { int offset= fLineTracker.getLineOffset(i); int endOffset= offset + fLineTracker.getLineLength(i); String line= text.substring(offset, endOffset); int position= 0; if (i == 0) { IRegion firstLine= document.getLineInformationOfOffset(command.offset); position= command.offset - firstLine.getOffset(); } int length= line.length(); for (int j= 0; j < length; j++) { char c= line.charAt(j); if (c == '\t') { position += insertTabString(buffer, position); } else { buffer.append(c); ++ position; } } } command.text= buffer.toString(); } catch (BadLocationException x) { } } } }; private class PropertyChangeListener implements IPropertyChangeListener { /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { handlePreferencePropertyChanged(event); } } /* Preference key for code formatter tab size */ private final static String CODE_FORMATTER_TAB_SIZE= JavaCore.FORMATTER_TAB_SIZE; /** Preference key for matching brackets */ public final static String MATCHING_BRACKETS= "matchingBrackets"; //$NON-NLS-1$ /** Preference key for matching brackets color */ public final static String MATCHING_BRACKETS_COLOR= "matchingBracketsColor"; //$NON-NLS-1$ /** Preference key for highlighting current line */ public final static String CURRENT_LINE= "currentLine"; //$NON-NLS-1$ /** Preference key for highlight color of current line */ public final static String CURRENT_LINE_COLOR= "currentLineColor"; //$NON-NLS-1$ /** Preference key for showing print marging ruler */ public final static String PRINT_MARGIN= "printMargin"; //$NON-NLS-1$ /** Preference key for print margin ruler color */ public final static String PRINT_MARGIN_COLOR= "printMarginColor"; //$NON-NLS-1$ /** Preference key for print margin ruler column */ public final static String PRINT_MARGIN_COLUMN= "printMarginColumn"; //$NON-NLS-1$ /** Preference key for inserting spaces rather than tabs */ public final static String SPACES_FOR_TABS= JavaSourceViewerConfiguration.SPACES_FOR_TABS; /** Preference key for problem indication */ public final static String PROBLEM_INDICATION= "problemIndication"; //$NON-NLS-1$ /** Preference key for problem highlight color */ public final static String PROBLEM_INDICATION_COLOR= "problemIndicationColor"; //$NON-NLS-1$ /** Preference key for linked position color */ public final static String LINKED_POSITION_COLOR= "linkedPositionColor"; //$NON-NLS-1$ /** Preference key for shwoing the overview ruler */ public final static String OVERVIEW_RULER= "overviewRuler"; //$NON-NLS-1$ /** The status line clearer */ protected ISelectionChangedListener fStatusLineClearer; /** The editor's save policy */ protected ISavePolicy fSavePolicy; /** Listener to annotation model changes that updates the error tick in the tab image */ private JavaEditorErrorTickUpdater fJavaEditorErrorTickUpdater; /** The editor's paint manager */ private PaintManager fPaintManager; /** The editor's bracket painter */ private BracketPainter fBracketPainter; /** The editor's line painter */ private LinePainter fLinePainter; /** The editor's print margin ruler painter */ private PrintMarginPainter fPrintMarginPainter; /** The editor's problem painter */ private ProblemPainter fProblemPainter; /** The editor's tab converter */ private TabConverter fTabConverter; /** History for structure select action */ private SelectionHistory fSelectionHistory; /** The preference property change listener for java core. */ private IPropertyChangeListener fPropertyChangeListener= new PropertyChangeListener(); /** The remembered java element */ private IJavaElement fRememberedElement; /** The remembered selection */ private ITextSelection fRememberedSelection; /** The remembered java element offset */ private int fRememberedElementOffset; /** The standard action groups added to the menu */ private GenerateActionGroup fGenerateActionGroup; private CompositeActionGroup fContextMenuGroup; /** * Creates a new compilation unit editor. */ public CompilationUnitEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getCompilationUnitDocumentProvider()); setEditorContextMenuId("#CompilationUnitEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#CompilationUnitRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#CompilationUnitOutlinerContext"); //$NON-NLS-1$ // don't set help contextId, we install our own help context fSavePolicy= null; fJavaEditorErrorTickUpdater= new JavaEditorErrorTickUpdater(this); } /* * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "CorrectionAssistProposal.", this, JavaCorrectionSourceViewer.CORRECTIONASSIST_PROPOSALS); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CORRECTION_ASSIST_PROPOSALS); setAction("CorrectionAssistProposal", action); //$NON-NLS-1$ action= new ContentAssistAction(JavaEditorMessages.getResourceBundle(), "ContentAssistProposal.", this); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS); setAction("ContentAssistProposal", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ContentAssistContextInformation.", this, ISourceViewer.CONTENTASSIST_CONTEXT_INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_CONTEXT_INFORMATION); setAction("ContentAssistContextInformation", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Comment.", this, ITextOperationTarget.PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.COMMENT); setAction("Comment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Uncomment.", this, ITextOperationTarget.STRIP_PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.UNCOMMENT); setAction("Uncomment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Format.", this, ISourceViewer.FORMAT); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.FORMAT); setAction("Format", action); //$NON-NLS-1$ markAsStateDependentAction("CorrectionAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistContextInformation", true); //$NON-NLS-1$ markAsStateDependentAction("Comment", true); //$NON-NLS-1$ markAsStateDependentAction("Uncomment", true); //$NON-NLS-1$ markAsStateDependentAction("Format", true); //$NON-NLS-1$ fSelectionHistory= new SelectionHistory(this); action= new StructureSelectEnclosingAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_ENCLOSING); setAction(StructureSelectionAction.ENCLOSING, action); action= new StructureSelectNextAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_NEXT); setAction(StructureSelectionAction.NEXT, action); action= new StructureSelectPreviousAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_PREVIOUS); setAction(StructureSelectionAction.PREVIOUS, action); StructureSelectHistoryAction historyAction= new StructureSelectHistoryAction(this, fSelectionHistory); historyAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_LAST); setAction(StructureSelectionAction.HISTORY, historyAction); fSelectionHistory.setHistoryAction(historyAction); fGenerateActionGroup= new GenerateActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); ActionGroup rg= new RefactorActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); fActionGroups.addGroup(rg); fActionGroups.addGroup(fGenerateActionGroup); // We have to keep the context menu group separate to have better control over positioning fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] { fGenerateActionGroup, rg, new LocalHistoryActionGroup(this, ITextEditorActionConstants.GROUP_EDIT)}); } /* * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { return getElementAt(offset, true); } /** * Returns the most narrow element including the given offset. If <code>reconcile</code> * is <code>true</code> the editor's input element is reconciled in advance. If it is * <code>false</code> this method only returns a result if the editor's input element * does not need to be reconciled. * * @param offset the offset included by the retrieved element * @param reconcile <code>true</code> if working copy should be reconciled */ protected IJavaElement getElementAt(int offset, boolean reconcile) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { if (reconcile) { synchronized (unit) { unit.reconcile(); } return unit.getElementAt(offset); } else if (unit.isConsistent()) return unit.getElementAt(offset); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { try { return EditorUtility.getWorkingCopy(element, true); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } return null; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow(IMenuManager) */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Format"); //$NON-NLS-1$ ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /* * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); page.setInput(manager.getWorkingCopy(input)); } } /* * @see AbstractTextEditor#performSaveOperation(WorkspaceModifyOperation, IProgressMonitor) */ protected void performSaveOperation(WorkspaceModifyOperation operation, IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(fSavePolicy); } try { super.performSaveOperation(operation, progressMonitor); } finally { if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(null); } } } /* * @see AbstractTextEditor#doSave(IProgressMonitor) */ public void doSave(IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p == null) return; if (p.isDeleted(getEditorInput())) { if (isSaveAsAllowed()) { /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed Behavior to make sure that if called inside a regular save (because * of deletion of input element) there is a way to report back to the caller. */ performSaveAs(progressMonitor); } else { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Shell shell= getSite().getShell(); MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title1"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message1")); //$NON-NLS-1$ //$NON-NLS-2$ } } else { setStatusLineErrorMessage(null); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { performSaveOperation(createSaveOperation(false), progressMonitor); } } else performSaveOperation(createSaveOperation(false), progressMonitor); } } /** * Jumps to the error next according to the given direction. */ public void gotoError(boolean forward) { ISelectionProvider provider= getSelectionProvider(); if (fStatusLineClearer != null) { provider.removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } ITextSelection s= (ITextSelection) provider.getSelection(); Position errorPosition= new Position(0, 0); IProblemAnnotation nextError= getNextError(s.getOffset(), forward, errorPosition); if (nextError != null) { IMarker marker= null; if (nextError instanceof MarkerAnnotation) marker= ((MarkerAnnotation) nextError).getMarker(); else { Iterator e= nextError.getOverlaidIterator(); if (e != null) { while (e.hasNext()) { Object o= e.next(); if (o instanceof MarkerAnnotation) { marker= ((MarkerAnnotation) o).getMarker(); break; } } } } if (marker != null) { IWorkbenchPage page= getSite().getPage(); IViewPart view= view= page.findView("org.eclipse.ui.views.TaskList"); //$NON-NLS-1$ if (view instanceof TaskList) { StructuredSelection ss= new StructuredSelection(marker); ((TaskList) view).setSelection(ss, true); } } selectAndReveal(errorPosition.getOffset(), errorPosition.getLength()); setStatusLineErrorMessage(nextError.getMessage()); } else { setStatusLineErrorMessage(null); } } /** * Sets the given message as error message to this editor's status line. * @param msg message to be set */ protected void setStatusLineErrorMessage(String msg) { // set error message getStatusLineManager().setErrorMessage(msg); // install message remover if (msg == null || msg.trim().length() == 0) { if (fStatusLineClearer != null) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } } else if (fStatusLineClearer == null) { fStatusLineClearer= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; getStatusLineManager().setErrorMessage(null); } }; getSelectionProvider().addSelectionChangedListener(fStatusLineClearer); } } private IProblemAnnotation getNextError(int offset, boolean forward, Position errorPosition) { IProblemAnnotation nextError= null; Position nextErrorPosition= null; IDocument document= getDocumentProvider().getDocument(getEditorInput()); int endOfDocument= document.getLength(); int distance= 0; IAnnotationModel model= getDocumentProvider().getAnnotationModel(getEditorInput()); Iterator e= new ProblemAnnotationIterator(model, false); while (e.hasNext()) { IProblemAnnotation a= (IProblemAnnotation) e.next(); if (a.hasOverlay() || !a.isProblem()) continue; Position p= model.getPosition((Annotation) a); if (!p.includes(offset)) { int currentDistance= 0; if (forward) { currentDistance= p.getOffset() - offset; if (currentDistance < 0) currentDistance= endOfDocument - offset + p.getOffset(); } else { currentDistance= offset - p.getOffset(); if (currentDistance < 0) currentDistance= offset + endOfDocument - p.getOffset(); } if (nextError == null || currentDistance < distance) { distance= currentDistance; nextError= a; nextErrorPosition= p; } } } if (nextErrorPosition != null) { errorPosition.setOffset(nextErrorPosition.getOffset()); errorPosition.setLength(nextErrorPosition.getLength()); } return nextError; } /* * @see AbstractTextEditor#isSaveAsAllowed() */ public boolean isSaveAsAllowed() { return true; } /** * The compilation unit editor implementation of this <code>AbstractTextEditor</code> * method asks the user for the workspace path of a file resource and saves the document * there. See http://dev.eclipse.org/bugs/show_bug.cgi?id=6295 */ protected void performSaveAs(IProgressMonitor progressMonitor) { Shell shell= getSite().getShell(); SaveAsDialog dialog= new SaveAsDialog(shell); dialog.create(); IEditorInput input = getEditorInput(); IFile original= (input instanceof IFileEditorInput) ? ((IFileEditorInput) input).getFile() : null; if (original != null) dialog.setOriginalFile(original); IDocumentProvider provider= getDocumentProvider(); if (provider.isDeleted(input) && original != null) { String message= JavaEditorMessages.getFormattedString("CompilationUnitEditor.warning.save.delete", new Object[] { original.getName() }); dialog.setMessage(message, IMessageProvider.WARNING); } if (dialog.open() == Dialog.CANCEL) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IPath filePath= dialog.getResult(); if (filePath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IWorkspace workspace= ResourcesPlugin.getWorkspace(); IFile file= workspace.getRoot().getFile(filePath); final IEditorInput newInput= new FileEditorInput(file); WorkspaceModifyOperation op= new WorkspaceModifyOperation() { public void execute(final IProgressMonitor monitor) throws CoreException { getDocumentProvider().saveDocument(monitor, newInput, getDocumentProvider().getDocument(getEditorInput()), true); } }; boolean success= false; try { getDocumentProvider().aboutToChange(newInput); new ProgressMonitorDialog(shell).run(false, true, op); success= true; } catch (InterruptedException x) { } catch (InvocationTargetException x) { Throwable t= x.getTargetException(); if (t instanceof CoreException) { CoreException cx= (CoreException) t; ErrorDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title2"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message2"), cx.getStatus()); //$NON-NLS-1$ //$NON-NLS-2$ } else { MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title3"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message3") + t.getMessage()); //$NON-NLS-1$ //$NON-NLS-2$ } } finally { getDocumentProvider().changed(newInput); if (success) setInput(newInput); } if (progressMonitor != null) progressMonitor.setCanceled(!success); } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); configureTabConverter(); } private void startBracketHighlighting() { if (fBracketPainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fBracketPainter= new BracketPainter(sourceViewer); fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); fPaintManager.addPainter(fBracketPainter); } } private void stopBracketHighlighting() { if (fBracketPainter != null) { fPaintManager.removePainter(fBracketPainter); fBracketPainter.deactivate(true); fBracketPainter.dispose(); fBracketPainter= null; } } private boolean isBracketHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(MATCHING_BRACKETS); } private void startLineHighlighting() { if (fLinePainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fLinePainter= new LinePainter(sourceViewer); fLinePainter.setHighlightColor(getColor(CURRENT_LINE_COLOR)); fPaintManager.addPainter(fLinePainter); } } private void stopLineHighlighting() { if (fLinePainter != null) { fPaintManager.removePainter(fLinePainter); fLinePainter.deactivate(true); fLinePainter.dispose(); fLinePainter= null; } } private boolean isLineHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(CURRENT_LINE); } private void showPrintMargin() { if (fPrintMarginPainter == null) { fPrintMarginPainter= new PrintMarginPainter(getSourceViewer()); fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); fPaintManager.addPainter(fPrintMarginPainter); } } private void hidePrintMargin() { if (fPrintMarginPainter != null) { fPaintManager.removePainter(fPrintMarginPainter); fPrintMarginPainter.deactivate(true); fPrintMarginPainter.dispose(); fPrintMarginPainter= null; } } private boolean isPrintMarginVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PRINT_MARGIN); } private void startProblemIndication() { if (fProblemPainter == null) { fProblemPainter= new ProblemPainter(this, getSourceViewer()); fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); fPaintManager.addPainter(fProblemPainter); } } private void stopProblemIndication() { if (fProblemPainter != null) { fPaintManager.removePainter(fProblemPainter); fProblemPainter.deactivate(true); fProblemPainter.dispose(); fProblemPainter= null; } } private boolean isProblemIndicationEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PROBLEM_INDICATION); } private void configureTabConverter() { if (fTabConverter != null) { IDocumentProvider provider= getDocumentProvider(); if (provider instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cup= (CompilationUnitDocumentProvider) provider; fTabConverter.setLineTracker(cup.createLineTracker(getEditorInput())); } } } private int getTabSize() { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); return preferences.getInt(CODE_FORMATTER_TAB_SIZE); } private void startTabConversion() { if (fTabConverter == null) { fTabConverter= new TabConverter(); configureTabConverter(); fTabConverter.setNumberOfSpacesPerTab(getTabSize()); AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.addTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); } } private void stopTabConversion() { if (fTabConverter != null) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.removeTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); fTabConverter= null; } } private boolean isTabConversionEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(SPACES_FOR_TABS); } private void showOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.showOverviewRuler(); } private void hideOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.hideOverviewRuler(); } private boolean isOverviewRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(OVERVIEW_RULER); } private Color getColor(String key) { RGB rgb= PreferenceConverter.getColor(getPreferenceStore(), key); return getColor(rgb); } private Color getColor(RGB rgb) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.getColorManager().getColor(rgb); } /* * @see AbstractTextEditor#dispose() */ public void dispose() { if (fPropertyChangeListener != null) { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.removePropertyChangeListener(fPropertyChangeListener); fPropertyChangeListener= null; } if (fJavaEditorErrorTickUpdater != null) { fJavaEditorErrorTickUpdater.dispose(); fJavaEditorErrorTickUpdater= null; } if (fSelectionHistory != null) fSelectionHistory.dispose(); stopBracketHighlighting(); stopLineHighlighting(); if (fPaintManager != null) { fPaintManager.dispose(); fPaintManager= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /* * @see AbstractTextEditor#createPartControl(Composite) */ public void createPartControl(Composite parent) { super.createPartControl(parent); fPaintManager= new PaintManager(getSourceViewer()); if (isBracketHighlightingEnabled()) startBracketHighlighting(); if (isLineHighlightingEnabled()) startLineHighlighting(); if (isPrintMarginVisible()) showPrintMargin(); if (isProblemIndicationEnabled()) startProblemIndication(); if (isTabConversionEnabled()) startTabConversion(); if (isOverviewRulerVisible()) showOverviewRuler(); Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.addPropertyChangeListener(fPropertyChangeListener); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (SPACES_FOR_TABS.equals(p)) { if (isTabConversionEnabled()) startTabConversion(); else stopTabConversion(); return; } if (MATCHING_BRACKETS.equals(p)) { if (isBracketHighlightingEnabled()) startBracketHighlighting(); else stopBracketHighlighting(); return; } if (MATCHING_BRACKETS_COLOR.equals(p)) { if (fBracketPainter != null) fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); return; } if (CURRENT_LINE.equals(p)) { if (isLineHighlightingEnabled()) startLineHighlighting(); else stopLineHighlighting(); return; } if (CURRENT_LINE_COLOR.equals(p)) { if (fLinePainter != null) { stopLineHighlighting(); startLineHighlighting(); } return; } if (PRINT_MARGIN.equals(p)) { if (isPrintMarginVisible()) showPrintMargin(); else hidePrintMargin(); return; } if (PRINT_MARGIN_COLOR.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); return; } if (PRINT_MARGIN_COLUMN.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); return; } if (PROBLEM_INDICATION.equals(p)) { if (isProblemIndicationEnabled()) startProblemIndication(); else stopProblemIndication(); return; } if (PROBLEM_INDICATION_COLOR.equals(p)) { if (fProblemPainter != null) fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); return; } if (OVERVIEW_RULER.equals(p)) { if (isOverviewRulerVisible()) showOverviewRuler(); else hideOverviewRuler(); return; } IContentAssistant c= asv.getContentAssistant(); if (c instanceof ContentAssistant) ContentAssistPreference.changeConfiguration((ContentAssistant) c, getPreferenceStore(), event); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Handles a property change event describing a change * of the java core's preferences and updates the preference * related editor properties. * * @param event the property change event */ protected void handlePreferencePropertyChanged(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (CODE_FORMATTER_TAB_SIZE.equals(p)) { asv.updateIndentationPrefixes(); if (fTabConverter != null) fTabConverter.setNumberOfSpacesPerTab(getTabSize()); } } } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { String p= event.getProperty(); boolean affects=MATCHING_BRACKETS_COLOR.equals(p) || CURRENT_LINE_COLOR.equals(p) || PROBLEM_INDICATION_COLOR.equals(p); return affects ? affects : super.affectsTextPresentation(event); } /* * @see JavaEditor#createJavaSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return new AdaptedSourceViewer(parent, ruler, styles); } /* * @see JavaEditor#synchronizeOutlinePageSelection() */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret, false); ISourceReference reference= getSourceReference(element, caret); if (reference != null) fOutlinePage.select(reference); } private ISourceReference getSourceReference(IJavaElement element, int offset) { if ( !(element instanceof ISourceReference)) return null; if (element.getElementType() == IJavaElement.IMPORT_DECLARATION) { IImportDeclaration declaration= (IImportDeclaration) element; IImportContainer container= (IImportContainer) declaration.getParent(); ISourceRange srcRange= null; try { srcRange= container.getSourceRange(); } catch (JavaModelException e) { } if (srcRange != null && srcRange.getOffset() == offset) return container; } return (ISourceReference) element; } /* * @see IReconcilingParticipant#reconciled() */ public void reconciled() { if (!JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) { Shell shell= getSite().getShell(); if (shell != null && !shell.isDisposed()) { shell.getDisplay().asyncExec(new Runnable() { public void run() { synchronizeOutlinePageSelection(); } }); } } } protected void updateStateDependentActions() { super.updateStateDependentActions(); fGenerateActionGroup.editorStateChanged(); } /** * Returns the updated java element for the old java element. */ private IJavaElement findElement(IJavaElement element) { if (element == null) return null; IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { synchronized (unit) { unit.reconcile(); } IJavaElement[] findings= unit.findElements(element); if (findings != null && findings.length > 0) return findings[0]; } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /** * Returns the offset of the given Java element. */ private int getOffset(IJavaElement element) { if (element instanceof ISourceReference) { ISourceReference sr= (ISourceReference) element; try { ISourceRange srcRange= sr.getSourceRange(); if (srcRange != null) return srcRange.getOffset(); } catch (JavaModelException e) { } } return -1; } /* * @see AbstractTextEditor#rememberSelection() */ protected void rememberSelection() { ISelectionProvider sp= getSelectionProvider(); fRememberedSelection= (sp == null ? null : (ITextSelection) sp.getSelection()); if (fRememberedSelection != null) { fRememberedElement= getElementAt(fRememberedSelection.getOffset(), true); fRememberedElementOffset= getOffset(fRememberedElement); } } /* * @see AbstractTextEditor#restoreSelection() */ protected void restoreSelection() { try { if (getSourceViewer() == null || fRememberedSelection == null) return; IJavaElement newElement= findElement(fRememberedElement); int newOffset= getOffset(newElement); int offset= (newOffset > -1 && fRememberedElementOffset > -1) ? newOffset - fRememberedElementOffset : 0; selectAndReveal(offset + fRememberedSelection.getOffset(), fRememberedSelection.getLength()); } finally { fRememberedSelection= null; fRememberedElement= null; fRememberedElementOffset= -1; } } }
14,939
Bug 14939 Parameter assist highlighting doesn't always match editor
Build 20020426 (M5 patch 1) Type the following in the body of a java method: int[] source, destination; System.arraycopy(source, <cursor> Now hit Ctrl+Space at <cursor>, and hit enter to select the only match in the popup list. Now the "parameter assist" window is supposed to highlight the parameters as they are typed in the editor. Since I have already typed the first parameter before doing code-assist, the highlighting will always be off by one parameter as I type.
verified fixed
80b9a20
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T21:22:44Z
2002-04-30T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProcessor.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.io.IOException; import java.util.ArrayList; import java.util.Arrays; import java.util.Hashtable; import java.util.List; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.contentassist.ICompletionProposal; import org.eclipse.jface.text.contentassist.IContentAssistProcessor; import org.eclipse.jface.text.contentassist.IContextInformation; import org.eclipse.jface.text.contentassist.IContextInformationExtension; import org.eclipse.jface.text.contentassist.IContextInformationValidator; import org.eclipse.ui.IEditorPart; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.PreferenceConstants; import org.eclipse.jdt.internal.corext.template.ContextType; import org.eclipse.jdt.internal.corext.template.ContextTypeRegistry; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.text.JavaCodeReader; import org.eclipse.jdt.internal.ui.text.template.TemplateEngine; /** * Java completion processor. */ public class JavaCompletionProcessor implements IContentAssistProcessor { private static class ContextInformationWrapper implements IContextInformation, IContextInformationExtension { private final IContextInformation fContextInformation; private int fPosition; public ContextInformationWrapper(IContextInformation contextInformation) { fContextInformation= contextInformation; } /* * @see IContextInformation#getContextDisplayString() */ public String getContextDisplayString() { return fContextInformation.getContextDisplayString(); } /* * @see IContextInformation#getImage() */ public Image getImage() { return fContextInformation.getImage(); } /* * @see IContextInformation#getInformationDisplayString() */ public String getInformationDisplayString() { return fContextInformation.getInformationDisplayString(); } /* * @see IContextInformationExtension#getContextInformationPosition() */ public int getContextInformationPosition() { return fPosition; } public void setContextInformationPosition(int position) { fPosition= position; } }; private final static String VISIBILITY= JavaCore.CODEASSIST_VISIBILITY_CHECK; private final static String ENABLED= "enabled"; //$NON-NLS-1$ private final static String DISABLED= "disabled"; //$NON-NLS-1$ private IEditorPart fEditor; private ResultCollector fCollector; private IWorkingCopyManager fManager; private IContextInformationValidator fValidator; private char[] fProposalAutoActivationSet; private JavaCompletionProposalComparator fComparator; private boolean fAllowAddImports; private TemplateEngine fTemplateEngine; private ExperimentalResultCollector fExperimentalCollector; private int fNumberOfComputedResults= 0; public JavaCompletionProcessor(IEditorPart editor) { fEditor= editor; fCollector= new ResultCollector(); fManager= JavaPlugin.getDefault().getWorkingCopyManager(); ContextType contextType= ContextTypeRegistry.getInstance().getContextType("java"); //$NON-NLS-1$ if (contextType != null) fTemplateEngine= new TemplateEngine(contextType); fExperimentalCollector= new ExperimentalResultCollector(); fAllowAddImports= true; fComparator= new JavaCompletionProposalComparator(); } /** * Sets this processor's set of characters triggering the activation of the * completion proposal computation. * * @param activationSet the activation set */ public void setCompletionProposalAutoActivationCharacters(char[] activationSet) { fProposalAutoActivationSet= activationSet; } /** * Tells this processor to restrict its proposal to those element * visible in the actual invocation context. * * @param restrict <code>true</code> if proposals should be restricted */ public void restrictProposalsToVisibility(boolean restrict) { Hashtable options= JavaCore.getOptions(); Object value= options.get(VISIBILITY); if (value instanceof String) { String newValue= restrict ? ENABLED : DISABLED; if ( !newValue.equals((String) value)) { options.put(VISIBILITY, newValue); JavaCore.setOptions(options); } } } /** * Tells this processor to order the proposals alphabetically. * * @param order <code>true</code> if proposals should be ordered. */ public void orderProposalsAlphabetically(boolean order) { fComparator.setOrderAlphabetically(order); } /** * Tells this processor to restrict is proposals to those * starting with matching cases. * * @param restrict <code>true</code> if proposals should be restricted */ public void restrictProposalsToMatchingCases(boolean restrict) { // not yet supported } /** * Tells this processor to add import statement for proposals that have * a fully qualified type name * * @param restrict <code>true</code> if import can be added */ public void allowAddingImports(boolean allowAddingImports) { fAllowAddImports= allowAddingImports; } /** * @see IContentAssistProcessor#getErrorMessage() */ public String getErrorMessage() { if (fNumberOfComputedResults == 0) return JavaUIMessages.getString("JavaEditor.codeassist.noCompletions"); //$NON-NLS-1$ return fCollector.getErrorMessage(); } /** * @see IContentAssistProcessor#getContextInformationValidator() */ public IContextInformationValidator getContextInformationValidator() { if (fValidator == null) fValidator= new JavaParameterListValidator(); return fValidator; } /** * @see IContentAssistProcessor#getContextInformationAutoActivationCharacters() */ public char[] getContextInformationAutoActivationCharacters() { return null; } /** * @see IContentAssistProcessor#getCompletionProposalAutoActivationCharacters() */ public char[] getCompletionProposalAutoActivationCharacters() { return fProposalAutoActivationSet; } private boolean looksLikeMethod(JavaCodeReader reader) throws IOException { int curr= reader.read(); while (curr != JavaCodeReader.EOF && Character.isWhitespace((char) curr)) curr= reader.read(); if (curr == JavaCodeReader.EOF) return false; return Character.isJavaIdentifierPart((char) curr) || Character.isJavaIdentifierStart((char) curr); } private int guessContextInformationPosition(ITextViewer viewer, int offset) { int contextPosition= offset; IDocument document= viewer.getDocument(); try { JavaCodeReader reader= new JavaCodeReader(); reader.configureBackwardReader(document, offset, true, true); int nestingLevel= 0; int curr= reader.read(); while (curr != JavaCodeReader.EOF) { if (')' == (char) curr) ++ nestingLevel; else if ('(' == (char) curr) { -- nestingLevel; if (nestingLevel < 0) { int start= reader.getOffset(); if (looksLikeMethod(reader)) return start + 1; } } curr= reader.read(); } } catch (IOException e) { } return contextPosition; } private List addContextInformations(ITextViewer viewer, int offset) { ICompletionProposal[] proposals= computeCompletionProposals(viewer, offset); List result= new ArrayList(); for (int i= 0; i < proposals.length; i++) { IContextInformation contextInformation= proposals[i].getContextInformation(); if (contextInformation != null) { ContextInformationWrapper wrapper= new ContextInformationWrapper(contextInformation); wrapper.setContextInformationPosition(offset); result.add(wrapper); } } return result; } /** * @see IContentAssistProcessor#computeContextInformation(ITextViewer, int) */ public IContextInformation[] computeContextInformation(ITextViewer viewer, int offset) { int contextInformationPosition= guessContextInformationPosition(viewer, offset); List result= addContextInformations(viewer, contextInformationPosition); return (IContextInformation[]) result.toArray(new IContextInformation[result.size()]); } /** * Order the given proposals. */ private ICompletionProposal[] order(ICompletionProposal[] proposals) { Arrays.sort(proposals, fComparator); return proposals; } /** * @see IContentAssistProcessor#computeCompletionProposals(ITextViewer, int) */ public ICompletionProposal[] computeCompletionProposals(ITextViewer viewer, int offset) { ICompilationUnit unit= fManager.getWorkingCopy(fEditor.getEditorInput()); IJavaCompletionProposal[] results; if (JavaPlugin.getDefault().getPreferenceStore().getBoolean(PreferenceConstants.CODEASSIST_FILL_ARGUMENT_NAMES)) { try { if (unit != null) { fExperimentalCollector.reset(offset, unit.getJavaProject(), fAllowAddImports ? unit : null); fExperimentalCollector.setViewer(viewer); Point selection= viewer.getSelectedRange(); if (selection.y > 0) fExperimentalCollector.setReplacementLength(selection.y); unit.codeComplete(offset, fExperimentalCollector); } } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } results= fExperimentalCollector.getResults(); } else { try { if (unit != null) { fCollector.reset(offset, unit.getJavaProject(), fAllowAddImports ? unit : null); Point selection= viewer.getSelectedRange(); if (selection.y > 0) fCollector.setReplacementLength(selection.y); unit.codeComplete(offset, fCollector); } } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } results= fCollector.getResults(); } if (fTemplateEngine != null) { try { fTemplateEngine.reset(); fTemplateEngine.complete(viewer, offset, unit); } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } IJavaCompletionProposal[] templateResults= fTemplateEngine.getResults(); // concatenate arrays IJavaCompletionProposal[] total= new IJavaCompletionProposal[results.length + templateResults.length]; System.arraycopy(templateResults, 0, total, 0, templateResults.length); System.arraycopy(results, 0, total, templateResults.length, results.length); results= total; } fNumberOfComputedResults= (results == null ? 0 : results.length); /* * Order here and not in result collector to make sure that the order * applies to all proposals and not just those of the compilation unit. */ return order(results); } }
14,939
Bug 14939 Parameter assist highlighting doesn't always match editor
Build 20020426 (M5 patch 1) Type the following in the body of a java method: int[] source, destination; System.arraycopy(source, <cursor> Now hit Ctrl+Space at <cursor>, and hit enter to select the only match in the popup list. Now the "parameter assist" window is supposed to highlight the parameters as they are typed in the editor. Since I have already typed the first parameter before doing code-assist, the highlighting will always be off by one parameter as I type.
verified fixed
80b9a20
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T21:22:44Z
2002-04-30T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ProposalContextInformation.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.swt.graphics.Image; import org.eclipse.jface.text.contentassist.IContextInformation; import org.eclipse.jface.util.Assert; /** * Implementation of the <code>IContextInformation</code> interface. */ public final class ProposalContextInformation implements IContextInformation { private String fContextDisplayString; private String fInformationDisplayString; private Image fImage; /** * Creates a new context information. */ public ProposalContextInformation() { } /** * @param image the image to display when presenting the context information */ public void setImage(Image image) { fImage= image; } /** * @param contextDisplayString the string to be used when presenting the context * may not be <code>null</code> */ public void setContextDisplayString(String contextDisplayString) { Assert.isNotNull(contextDisplayString); fContextDisplayString= contextDisplayString; } /** * @param informationDisplayString the string to be displayed when presenting the context information, * may not be <code>null</code> */ public void setInformationDisplayString(String informationDisplayString) { Assert.isNotNull(informationDisplayString); fInformationDisplayString= informationDisplayString; } /* * @see IContextInformation#equals */ public boolean equals(Object object) { if (object instanceof IContextInformation) { IContextInformation contextInformation= (IContextInformation) object; boolean equals= fInformationDisplayString.equalsIgnoreCase(contextInformation.getInformationDisplayString()); if (fContextDisplayString != null) equals= equals && fContextDisplayString.equalsIgnoreCase(contextInformation.getContextDisplayString()); return equals; } return false; } /* * @see IContextInformation#getInformationDisplayString() */ public String getInformationDisplayString() { return fInformationDisplayString; } /* * @see IContextInformation#getImage() */ public Image getImage() { return fImage; } /* * @see IContextInformation#getContextDisplayString() */ public String getContextDisplayString() { if (fContextDisplayString != null) return fContextDisplayString; return fInformationDisplayString; } }
14,939
Bug 14939 Parameter assist highlighting doesn't always match editor
Build 20020426 (M5 patch 1) Type the following in the body of a java method: int[] source, destination; System.arraycopy(source, <cursor> Now hit Ctrl+Space at <cursor>, and hit enter to select the only match in the popup list. Now the "parameter assist" window is supposed to highlight the parameters as they are typed in the editor. Since I have already typed the first parameter before doing code-assist, the highlighting will always be off by one parameter as I type.
verified fixed
80b9a20
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-11T21:22:44Z
2002-04-30T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jdt.core.CompletionRequestorAdapter; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.core.compiler.IProblem; import org.eclipse.jdt.ui.JavaElementImageDescriptor; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.viewsupport.ImageDescriptorRegistry; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; /** * Bin to collect the proposal of the infrastructure on code assist in a java text. */ public class ResultCollector extends CompletionRequestorAdapter { private final static char[] METHOD_WITH_ARGUMENTS_TRIGGERS= new char[] { '(', '-', ' ' }; private final static char[] METHOD_TRIGGERS= new char[] { ';', ',', '.', '\t', '[', ' ' }; private final static char[] TYPE_TRIGGERS= new char[] { '.', '\t', '[', '(', ' ' }; private final static char[] VAR_TRIGGER= new char[] { '\t', ' ', '=', ';' }; private ArrayList fFields= new ArrayList(), fKeywords= new ArrayList(10), fLabels= new ArrayList(10), fMethods= new ArrayList(), fModifiers= new ArrayList(10), fPackages= new ArrayList(), fTypes= new ArrayList(), fVariables= new ArrayList(); private IProblem fLastProblem; private IJavaProject fJavaProject; private ICompilationUnit fCompilationUnit; // set when imports can be added private int fCodeAssistOffset; private ImageDescriptorRegistry fRegistry= JavaPlugin.getImageDescriptorRegistry(); private ArrayList[] fResults = new ArrayList[] { fPackages, fLabels, fModifiers, fKeywords, fTypes, fMethods, fFields, fVariables }; private int fUserReplacementLength; /* * Is eating code assist enabled or disabled? PR #3666 * When eating is enabled, JavaCompletionProposal must be revisited: PR #5533 */ private boolean fPreventEating= true; /* * @see ICompletionRequestor#acceptClass */ public void acceptClass(char[] packageName, char[] typeName, char[] completionName, int modifiers, int start, int end, int relevance) { ImageDescriptor descriptor= JavaElementImageProvider.getTypeImageDescriptor(false, false, modifiers); if (Flags.isDeprecated(modifiers)) descriptor= getDeprecatedDescriptor(descriptor); ProposalInfo info= new ProposalInfo(fJavaProject, packageName, typeName); fTypes.add(createTypeCompletion(start, end, new String(completionName), descriptor, new String(typeName), new String(packageName), info, relevance)); } /* * @see ICompletionRequestor#acceptError */ public void acceptError(IProblem error) { fLastProblem= error; } /* * @see ICompletionRequestor#acceptField */ public void acceptField( char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[] typePackageName, char[] typeName, char[] completionName, int modifiers, int start, int end, int relevance) { ImageDescriptor descriptor= getFieldDescriptor(modifiers); StringBuffer nameBuffer= new StringBuffer(); nameBuffer.append(name); if (typeName.length > 0) { nameBuffer.append(" "); //$NON-NLS-1$ nameBuffer.append(typeName); } if (declaringTypeName != null && declaringTypeName.length > 0) { nameBuffer.append(" - "); //$NON-NLS-1$ nameBuffer.append(declaringTypeName); } JavaCompletionProposal proposal= createCompletion(start, end, new String(completionName), descriptor, nameBuffer.toString(), relevance); proposal.setProposalInfo(new ProposalInfo(fJavaProject, declaringTypePackageName, declaringTypeName, name)); proposal.setTriggerCharacters(VAR_TRIGGER); fFields.add(proposal); } /* * @see ICompletionRequestor#acceptInterface */ public void acceptInterface(char[] packageName, char[] typeName, char[] completionName, int modifiers, int start, int end, int relevance) { ImageDescriptor descriptor= JavaElementImageProvider.getTypeImageDescriptor(true, false, modifiers); if (Flags.isDeprecated(modifiers)) descriptor= getDeprecatedDescriptor(descriptor); ProposalInfo info= new ProposalInfo(fJavaProject, packageName, typeName); fTypes.add(createTypeCompletion(start, end, new String(completionName), descriptor, new String(typeName), new String(packageName), info, relevance)); } /* * @see ICompletionRequestor#acceptAnonymousType */ public void acceptAnonymousType(char[] superTypePackageName, char[] superTypeName, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] completionName, int modifiers, int completionStart, int completionEnd, int relevance) { JavaCompletionProposal proposal= createAnonymousTypeCompletion(superTypePackageName, superTypeName, parameterTypeNames, parameterNames, completionName, completionStart, completionEnd, relevance); proposal.setProposalInfo(new ProposalInfo(fJavaProject, superTypePackageName, superTypeName)); fTypes.add(proposal); } /* * @see ICompletionRequestor#acceptKeyword */ public void acceptKeyword(char[] keyword, int start, int end, int relevance) { String kw= new String(keyword); fKeywords.add(createCompletion(start, end, kw, null, kw, relevance)); } /* * @see ICompletionRequestor#acceptLabel */ public void acceptLabel(char[] labelName, int start, int end, int relevance) { String ln= new String(labelName); fLabels.add(createCompletion(start, end, ln, null, ln, relevance)); } /* * @see ICompletionRequestor#acceptLocalVariable */ public void acceptLocalVariable(char[] name, char[] typePackageName, char[] typeName, int modifiers, int start, int end, int relevance) { StringBuffer buf= new StringBuffer(); buf.append(name); if (typeName != null) { buf.append(" "); //$NON-NLS-1$ buf.append(typeName); } JavaCompletionProposal proposal= createCompletion(start, end, new String(name), JavaPluginImages.DESC_OBJS_LOCAL_VARIABLE, buf.toString(), relevance); proposal.setTriggerCharacters(VAR_TRIGGER); fVariables.add(proposal); } private String getParameterSignature(char[][] parameterTypeNames, char[][] parameterNames) { StringBuffer buf = new StringBuffer(); if (parameterTypeNames != null) { for (int i = 0; i < parameterTypeNames.length; i++) { if (i > 0) { buf.append(','); buf.append(' '); } buf.append(parameterTypeNames[i]); if (parameterNames != null && parameterNames[i] != null) { buf.append(' '); buf.append(parameterNames[i]); } } } return buf.toString(); } /* * @see ICompletionRequestor#acceptMethod */ public void acceptMethod(char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypePackageName, char[] returnTypeName, char[] completionName, int modifiers, int start, int end, int relevance) { if (completionName == null) return; JavaCompletionProposal proposal= createMethodCallCompletion(declaringTypeName, name, parameterTypeNames, parameterNames, returnTypeName, completionName, modifiers, start, end, relevance); boolean isConstructor= returnTypeName == null ? true : returnTypeName.length == 0; proposal.setProposalInfo(new ProposalInfo(fJavaProject, declaringTypePackageName, declaringTypeName, name, parameterPackageNames, parameterTypeNames, isConstructor)); boolean hasOpeningBracket= completionName.length == 0 || (completionName.length > 0 && completionName[completionName.length - 1] == ')'); ProposalContextInformation contextInformation= null; if (hasOpeningBracket && parameterTypeNames.length > 0) { contextInformation= new ProposalContextInformation(); contextInformation.setInformationDisplayString(getParameterSignature(parameterTypeNames, parameterNames)); contextInformation.setContextDisplayString(proposal.getDisplayString()); contextInformation.setImage(proposal.getImage()); proposal.setContextInformation(contextInformation); } boolean userMustCompleteParameters= (contextInformation != null && completionName.length > 0); char[] triggers= userMustCompleteParameters ? METHOD_WITH_ARGUMENTS_TRIGGERS : METHOD_TRIGGERS; proposal.setTriggerCharacters(triggers); if (userMustCompleteParameters) { // set the cursor before the closing bracket proposal.setCursorPosition(completionName.length - 1); } fMethods.add(proposal); } /* * @see ICompletionRequestor#acceptModifier */ public void acceptModifier(char[] modifier, int start, int end, int relevance) { String mod= new String(modifier); fModifiers.add(createCompletion(start, end, mod, null, mod, relevance)); } /* * @see ICompletionRequestor#acceptPackage */ public void acceptPackage(char[] packageName, char[] completionName, int start, int end, int relevance) { fPackages.add(createCompletion(start, end, new String(completionName), JavaPluginImages.DESC_OBJS_PACKAGE, new String(packageName), relevance)); } /* * @see ICompletionRequestor#acceptType */ public void acceptType(char[] packageName, char[] typeName, char[] completionName, int start, int end, int relevance) { ProposalInfo info= new ProposalInfo(fJavaProject, packageName, typeName); fTypes.add(createTypeCompletion(start, end, new String(completionName), JavaPluginImages.DESC_OBJS_CLASS, new String(typeName), new String(packageName), info, relevance)); } /* * @see ICodeCompletionRequestor#acceptMethodDeclaration */ public void acceptMethodDeclaration(char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypePackageName, char[] returnTypeName, char[] completionName, int modifiers, int start, int end, int relevance) { StringBuffer displayString= getMethodDisplayString(declaringTypeName, name, parameterTypeNames, parameterNames, returnTypeName); StringBuffer typeName= new StringBuffer(); if (declaringTypePackageName.length > 0) { typeName.append(declaringTypePackageName); typeName.append('.'); } typeName.append(declaringTypeName); String[] paramTypes= new String[parameterTypeNames.length]; for (int i= 0; i < parameterTypeNames.length; i++) { paramTypes[i]= Signature.createTypeSignature(parameterTypeNames[i], true); } JavaCompletionProposal proposal= new MethodStubCompletionProposal(fJavaProject, fCompilationUnit, typeName.toString(), new String(name), paramTypes, start, getLength(start, end), displayString.toString(), new String(completionName)); proposal.setImage(getImage(getMemberDescriptor(modifiers))); proposal.setProposalInfo(new ProposalInfo(fJavaProject, declaringTypePackageName, declaringTypeName, name, parameterPackageNames, parameterTypeNames, returnTypeName.length == 0)); proposal.setRelevance(relevance); fMethods.add(proposal); } /* * @see ICodeCompletionRequestor#acceptVariableName */ public void acceptVariableName(char[] typePackageName, char[] typeName, char[] name, char[] completionName, int start, int end, int relevance) { // XXX: To be revised StringBuffer buf= new StringBuffer(); buf.append(name); if (typeName != null && typeName.length > 0) { buf.append(" - "); //$NON-NLS-1$ buf.append(typeName); } JavaCompletionProposal proposal= createCompletion(start, end, new String(completionName), null, buf.toString(), relevance); proposal.setTriggerCharacters(VAR_TRIGGER); fVariables.add(proposal); } public String getErrorMessage() { if (fLastProblem != null) return fLastProblem.getMessage(); return ""; //$NON-NLS-1$ } public JavaCompletionProposal[] getResults() { // return unsorted int totLen= 0; for (int i= 0; i < fResults.length; i++) { totLen += fResults[i].size(); } JavaCompletionProposal[] result= new JavaCompletionProposal[totLen]; int k= 0; for (int i= 0; i < fResults.length; i++) { ArrayList curr= fResults[i]; int currLen= curr.size(); for (int j= 0; j < currLen; j++) { JavaCompletionProposal proposal= (JavaCompletionProposal) curr.get(j); // for equal relevance, take categories proposal.setRelevance(proposal.getRelevance() * 16 + i); result[k++]= proposal; } } return result; } private StringBuffer getMethodDisplayString(char[] declaringTypeName, char[] name, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypeName) { StringBuffer nameBuffer= new StringBuffer(); nameBuffer.append(name); nameBuffer.append('('); if (parameterTypeNames != null && parameterTypeNames.length > 0) { nameBuffer.append(getParameterSignature(parameterTypeNames, parameterNames)); } nameBuffer.append(')'); if (returnTypeName != null && returnTypeName.length > 0) { nameBuffer.append(" "); //$NON-NLS-1$ nameBuffer.append(returnTypeName); } if (declaringTypeName != null && declaringTypeName.length > 0) { nameBuffer.append(" - "); //$NON-NLS-1$ nameBuffer.append(declaringTypeName); } return nameBuffer; } protected JavaCompletionProposal createMethodCallCompletion(char[] declaringTypeName, char[] name, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypeName, char[] completionName, int modifiers, int start, int end, int relevance) { ImageDescriptor descriptor= getMemberDescriptor(modifiers); StringBuffer nameBuffer= getMethodDisplayString(declaringTypeName, name, parameterTypeNames, parameterNames, returnTypeName); return createCompletion(start, end, new String(completionName), descriptor, nameBuffer.toString(), relevance); } protected JavaCompletionProposal createAnonymousTypeCompletion(char[] declaringTypePackageName, char[] declaringTypeName, char[][] parameterTypeNames, char[][] parameterNames, char[] completionName, int start, int end, int relevance) { StringBuffer declTypeBuf= new StringBuffer(); if (declaringTypePackageName.length > 0) { declTypeBuf.append(declaringTypePackageName); declTypeBuf.append('.'); } declTypeBuf.append(declaringTypeName); StringBuffer nameBuffer= new StringBuffer(); nameBuffer.append(declaringTypeName); nameBuffer.append('('); if (parameterTypeNames.length > 0) { nameBuffer.append(getParameterSignature(parameterTypeNames, parameterNames)); } nameBuffer.append(')'); nameBuffer.append(" "); //$NON-NLS-1$ nameBuffer.append(JavaTextMessages.getString("ResultCollector.anonymous_type")); //$NON-NLS-1$ int length= end - start; return new AnonymousTypeCompletionProposal(fJavaProject, fCompilationUnit, start, length, new String(completionName), nameBuffer.toString(), declTypeBuf.toString(), relevance); } protected JavaCompletionProposal createTypeCompletion(int start, int end, String completion, ImageDescriptor descriptor, String typeName, String containerName, ProposalInfo proposalInfo, int relevance) { StringBuffer buf= new StringBuffer(typeName); if (containerName != null) { buf.append(" - "); //$NON-NLS-1$ if (containerName.length() > 0) { buf.append(containerName); } else { buf.append(JavaTextMessages.getString("ResultCollector.default_package")); //$NON-NLS-1$ } } String name= buf.toString(); ICompilationUnit cu= null; if (containerName != null && fCompilationUnit != null) { if (completion.equals(JavaModelUtil.concatenateName(containerName, typeName))) { cu= fCompilationUnit; } } JavaCompletionProposal proposal= new JavaTypeCompletionProposal(completion, cu, start, getLength(start, end), getImage(descriptor), name, relevance); proposal.setProposalInfo(proposalInfo); proposal.setTriggerCharacters(TYPE_TRIGGERS); return proposal; } protected ImageDescriptor getMemberDescriptor(int modifiers) { ImageDescriptor desc= JavaElementImageProvider.getMethodImageDescriptor(false, modifiers); if (Flags.isDeprecated(modifiers)) return getDeprecatedDescriptor(desc); return desc; } protected ImageDescriptor getFieldDescriptor(int modifiers) { ImageDescriptor desc= JavaElementImageProvider.getFieldImageDescriptor(false, modifiers); if (Flags.isDeprecated(modifiers)) return getDeprecatedDescriptor(desc); return desc; } protected ImageDescriptor getDeprecatedDescriptor(ImageDescriptor descriptor) { Point size= new Point(16, 16); return new JavaElementImageDescriptor(descriptor, JavaElementImageDescriptor.WARNING, size); } protected JavaCompletionProposal createCompletion(int start, int end, String completion, ImageDescriptor descriptor, String name, int relevance) { return new JavaCompletionProposal(completion, start, getLength(start, end), getImage(descriptor), name, relevance); } private int getLength(int start, int end) { int length; if (fUserReplacementLength == -1) { length= fPreventEating ? fCodeAssistOffset - start : end - start; } else { length= fUserReplacementLength; // extend length to begin at start if (start < fCodeAssistOffset) { length+= fCodeAssistOffset - start; } } return length; } private Image getImage(ImageDescriptor descriptor) { return (descriptor == null) ? null : fRegistry.get(descriptor); } /** * Specifies the context of the code assist operation. * @param codeAssistOffset The Offset on which the code assist will be called. * Used to modify the offsets of the created proposals. ('Non Eating') * @param jproject The Java project to which the underlying source belongs. * Needed to find types referred. * @param cu The compilation unit that is edited. Used to add import statements. * Can be <code>null</code> if no import statements should be added. */ public void reset(int codeAssistOffset, IJavaProject jproject, ICompilationUnit cu) { fJavaProject= jproject; fCompilationUnit= cu; fCodeAssistOffset= codeAssistOffset; fUserReplacementLength= -1; fLastProblem= null; for (int i= 0; i < fResults.length; i++) fResults[i].clear(); } /** * If the replacement length is set, it overrides the length returned from * the content assist infrastructure. * Use this setting if code assist is called with a none empty selection. */ public void setReplacementLength(int length) { fUserReplacementLength= length; } /** * If set, proposals created will not remove characters after the code assist position * @param preventEating The preventEating to set */ public void setPreventEating(boolean preventEating) { fPreventEating= preventEating; } }
20,033
Bug 20033 Add Javadoc comment on type swallows line delimiter
null
verified fixed
843e682
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-12T15:48:04Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui/core
20,033
Bug 20033 Add Javadoc comment on type swallows line delimiter
null
verified fixed
843e682
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-12T15:48:04Z
2002-06-12T13:53:20Z
extension/org/eclipse/jdt/internal/corext/codemanipulation/AddJavaDocStubOperation.java
20,051
Bug 20051 Renaming: Operation cannot be performed
Using the 06/12 integration build. 1. Create a plug-in project. 2. Try to rename it using refactor->rename..., you get the Java message dialog saying: "The resource is not on the build path of a Java project". First, what does this message mean? Second, are we not allowed to change the name of a PDE project after it is created?
verified fixed
a7dc1c5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-12T17:43:28Z
2002-06-12T16:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/ActionUtil.java
package org.eclipse.jdt.internal.ui.actions; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IProjectNature; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaCore; /* * http://dev.eclipse.org/bugs/show_bug.cgi?id=19104 */ public class ActionUtil { public static boolean isProcessable(Shell shell, Object element) { if (!(element instanceof IJavaElement)) return true; if (checkJavaElement((IJavaElement)element)) return true; MessageDialog.openInformation(shell, ActionMessages.getString("ActionUtil.notOnBuildPath.title"), //$NON-NLS-1$ ActionMessages.getString("ActionUtil.notOnBuildPath.message")); //$NON-NLS-1$ return false; } private static boolean checkJavaElement(IJavaElement element) { IJavaProject project= element.getJavaProject(); try { if (!project.isOnClasspath(element)) return false; IProject resourceProject= project.getProject(); if (resourceProject == null) return false; IProjectNature nature= resourceProject.getNature(JavaCore.NATURE_ID); // We have a Java project if (nature != null) return true; } catch (CoreException e) { } return false; } }
20,047
Bug 20047 NPE in ShowInPackageViewAction
20020612 found in log java.lang.NullPointerException at org.eclipse.jdt.ui.actions.ShowInPackageViewAction.run (ShowInPackageViewAction.java:138) at org.eclipse.jdt.ui.actions.ShowInPackageViewAction.run (ShowInPackageViewAction.java:109) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun (SelectionDispatchAction.java:180) at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run (SelectionDispatchAction.java:156) at org.eclipse.jface.action.Action.runWithEvent(Action.java:749) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Menu.setVisible(Menu.java:920) at org.eclipse.swt.widgets.Control.WM_CONTEXTMENU(Control.java:2818) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.DefWindowProcW(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java (Compiled Code)) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java (Compiled Code)) at org.eclipse.swt.widgets.Control.WM_RBUTTONUP(Control.java:3707) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1160) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:739) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:462) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:248) at org.eclipse.core.launcher.Main.run(Main.java:697) at org.eclipse.core.launcher.Main.main(Main.java:530)
resolved fixed
0925f71
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T09:41:00Z
2002-06-12T16:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/ShowInPackageViewAction.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.core.resources.IResource; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.OpenActionUtil; import org.eclipse.jdt.internal.ui.actions.SelectionConverter; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; /** * This action reveals the currently selected Java element in the packages * view. The Java element can be represeented by either * <ul> * <li>a text selection inside a Java editor, or </li> * <li>a structured selection of a view part showing Java elements</li> * </ul> * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class ShowInPackageViewAction extends SelectionDispatchAction { private JavaEditor fEditor; /** * Creates a new <code>ShowInPackageViewAction</code>. * * @param site the site providing context information for this action */ public ShowInPackageViewAction(IWorkbenchSite site) { super(site); setText(ActionMessages.getString("ShowInPackageViewAction.label")); //$NON-NLS-1$ setDescription(ActionMessages.getString("ShowInPackageViewAction.description")); //$NON-NLS-1$ setToolTipText(ActionMessages.getString("ShowInPackageViewAction.tooltip")); //$NON-NLS-1$ WorkbenchHelp.setHelp(this, IJavaHelpContextIds.SHOW_IN_PACKAGEVIEW_ACTION); } /** * Creates a new <code>ShowInPackageViewAction</code>. * <p> * Note: This constructor is for internal use only. Clients should not call this constructor. * </p> */ public ShowInPackageViewAction(JavaEditor editor) { this(editor.getEditorSite()); fEditor= editor; setEnabled(SelectionConverter.canOperateOn(fEditor)); } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(ITextSelection selection) { } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void selectionChanged(IStructuredSelection selection) { setEnabled(checkEnabled(selection)); } private boolean checkEnabled(IStructuredSelection selection) { if (selection.size() != 1) return false; return selection.getFirstElement() instanceof IJavaElement; } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(ITextSelection selection) { try { IJavaElement element= SelectionConverter.getElementAtOffset(fEditor); if (element != null) run(element); } catch (JavaModelException e) { JavaPlugin.log(e); String message= ActionMessages.getString("ShowInPackageViewAction.error.message"); //$NON-NLS-1$ ErrorDialog.openError(getShell(), getDialogTitle(), message, e.getStatus()); } } /* (non-Javadoc) * Method declared on SelectionDispatchAction. */ protected void run(IStructuredSelection selection) { if (!checkEnabled(selection)) return; run((IJavaElement)selection.getFirstElement()); } private void run(IJavaElement element) { if (element == null) return; boolean showMembers= JavaPlugin.getDefault().getPreferenceStore().getBoolean(AppearancePreferencePage.SHOW_CU_CHILDREN); PackageExplorerPart view= PackageExplorerPart.openInActivePerspective(); if (view != null) { if (reveal(view, element)) return; if (showMembers && element instanceof IMember) { // Since the packages view shows working copy elements it can happen that we try to show an original element // in the packages view. Fall back to working copy element IMember member= (IMember)element; if (!member.getCompilationUnit().isWorkingCopy()) { try { element= EditorUtility.getWorkingCopy(member); if (reveal(view, element)) return; } catch (JavaModelException e) { } } } element= getVisibleParent(element); if (element != null) { if (reveal(view, element)) return; IResource resource= null; try { resource= element.getCorrespondingResource(); } catch (JavaModelException e) { } if (resource != null) { if (reveal(view, resource)) return; } } MessageDialog.openInformation(getShell(), getDialogTitle(), ActionMessages.getString("ShowInPackageViewAction.not_found")); //$NON-NLS-1$ } } private boolean reveal(PackageExplorerPart view, Object element) { // Fix for http://dev.eclipse.org/bugs/show_bug.cgi?id=19104 if (element == null) return false; view.selectReveal(new StructuredSelection(element)); if (element.equals(getSelectedElement(view))) return true; return false; } private Object getSelectedElement(PackageExplorerPart view) { return ((IStructuredSelection)view.getSite().getSelectionProvider().getSelection()).getFirstElement(); } private IJavaElement getVisibleParent(IJavaElement element) { // Fix for http://dev.eclipse.org/bugs/show_bug.cgi?id=19104 if (element == null) return null; switch (element.getElementType()) { case IJavaElement.IMPORT_DECLARATION: case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: case IJavaElement.TYPE: case IJavaElement.METHOD: case IJavaElement.FIELD: case IJavaElement.INITIALIZER: // select parent cu/classfile element= (IJavaElement)element.getOpenable(); break; case IJavaElement.JAVA_MODEL: element= null; break; } if (element.getElementType() == IJavaElement.COMPILATION_UNIT) { ICompilationUnit unit= (ICompilationUnit)element; if (unit.isWorkingCopy()) element= unit.getOriginalElement(); } return element; } private static String getDialogTitle() { return ActionMessages.getString("ShowInPackageViewAction.dialog.title"); //$NON-NLS-1$ } }
20,144
Bug 20144 Enter key not working in packages view
Build 20020612 (F3) Linux-GTK Selecting a file in the packages view and hitting the ENTER key does not open the file. Unless there's another way to open a file without the mouse, the is a serious accessibility problem.
resolved fixed
cf308b3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T10:51:58Z
2002-06-13T12:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/JavaSelectMarkerRulerAction.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.internal.ui.javaeditor; import java.util.Iterator; import java.util.ResourceBundle; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.IVerticalRulerInfo; import org.eclipse.core.resources.IMarker; import org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.ui.texteditor.MarkerUtilities; import org.eclipse.ui.texteditor.SelectMarkerRulerAction; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaModelMarker; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer; import org.eclipse.jdt.internal.ui.text.correction.ProblemPosition; /** * A special select marker ruler action which activates quick fix if clicked on a quick fixable * probelm. */ public class JavaSelectMarkerRulerAction extends SelectMarkerRulerAction { private ITextEditor fMyTextEditor; private Position fPosition; public JavaSelectMarkerRulerAction(ResourceBundle bundle, String prefix, ITextEditor editor, IVerticalRulerInfo ruler) { super(bundle, prefix, editor, ruler); fMyTextEditor= editor; } public void run() { superCall: { if (fPosition == null) break superCall; ITextOperationTarget operation= (ITextOperationTarget) fMyTextEditor.getAdapter(ITextOperationTarget.class); final int opCode= JavaCorrectionSourceViewer.CORRECTIONASSIST_PROPOSALS; if (operation == null || !operation.canDoOperation(opCode)) { break superCall; } fMyTextEditor.selectAndReveal(fPosition.getOffset(), fPosition.getLength()); operation.doOperation(opCode); return; } super.run(); } public void update() { fPosition= getProblemPosition(); if (fPosition != null) setEnabled(true); else super.update(); } private Position getProblemPosition() { AbstractMarkerAnnotationModel model= getAnnotationModel(); IDocument document= getDocument(); if (model == null) return null; Iterator iter= model.getAnnotationIterator(); while (iter.hasNext()) { Annotation annotation= (Annotation)iter.next(); if (annotation instanceof IProblemAnnotation) { Position position= model.getPosition(annotation); if (includesRulerLine(position, document) && JavaCorrectionProcessor.hasCorrections(((IProblemAnnotation)annotation).getId())) return position; } } return null; } }
20,242
Bug 20242 TVT2: Buttons not resizing in Java prefs (truncation)
Build F2 In Window>Preferences, Java>Templates all of the buttons on the right side of the prefs page are not resizing with translated text. This is a critical issue for TVT, since there are translations that cannot be shortened to accomodate a particular button size.
resolved fixed
8c1b612
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T11:32:57Z
2002-06-13T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/TemplatePreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; import java.io.File; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ControlAdapter; import org.eclipse.swt.events.ControlEvent; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ColumnWeightData; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TableLayout; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.corext.template.ContextType; import org.eclipse.jdt.internal.corext.template.ContextTypeRegistry; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.TemplateContext; import org.eclipse.jdt.internal.corext.template.TemplateMessages; import org.eclipse.jdt.internal.corext.template.TemplateSet; import org.eclipse.jdt.internal.corext.template.Templates; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.text.template.TemplateContentProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateLabelProvider; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class TemplatePreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // preference store keys private static final String PREF_FORMAT_TEMPLATES= JavaUI.ID_PLUGIN + ".template.format"; //$NON-NLS-1$ private Templates fTemplates; private CheckboxTableViewer fTableViewer; private Button fAddButton; private Button fEditButton; private Button fImportButton; private Button fExportButton; private Button fExportAllButton; private Button fRemoveButton; private Button fEnableAllButton; private Button fDisableAllButton; private SourceViewer fPatternViewer; private Button fFormatButton; public TemplatePreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(TemplateMessages.getString("TemplatePreferencePage.message")); //$NON-NLS-1$ fTemplates= Templates.getInstance(); } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; parent.setLayout(layout); Composite innerParent= new Composite(parent, SWT.NONE); GridLayout innerLayout= new GridLayout(); innerLayout.numColumns= 2; innerLayout.marginHeight= 0; innerLayout.marginWidth= 0; innerParent.setLayout(innerLayout); GridData gd= new GridData(GridData.FILL_BOTH); gd.horizontalSpan= 2; innerParent.setLayoutData(gd); Table table= new Table(innerParent, SWT.CHECK | SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(3); data.heightHint= convertHeightInCharsToPixels(10); table.setLayoutData(data); table.setHeaderVisible(true); table.setLinesVisible(true); TableLayout tableLayout= new TableLayout(); table.setLayout(tableLayout); TableColumn column1= new TableColumn(table, SWT.NONE); column1.setText(TemplateMessages.getString("TemplatePreferencePage.column.name")); //$NON-NLS-1$ TableColumn column2= new TableColumn(table, SWT.NONE); column2.setText(TemplateMessages.getString("TemplatePreferencePage.column.context")); //$NON-NLS-1$ TableColumn column3= new TableColumn(table, SWT.NONE); column3.setText(TemplateMessages.getString("TemplatePreferencePage.column.description")); //$NON-NLS-1$ fTableViewer= new CheckboxTableViewer(table); fTableViewer.setLabelProvider(new TemplateLabelProvider()); fTableViewer.setContentProvider(new TemplateContentProvider()); fTableViewer.setSorter(new ViewerSorter() { public int compare(Viewer viewer, Object object1, Object object2) { if ((object1 instanceof Template) && (object2 instanceof Template)) { Template left= (Template) object1; Template right= (Template) object2; int result= left.getName().compareToIgnoreCase(right.getName()); if (result != 0) return result; return left.getDescription().compareToIgnoreCase(right.getDescription()); } return super.compare(viewer, object1, object2); } public boolean isSorterProperty(Object element, String property) { return true; } }); fTableViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent e) { edit(); } }); fTableViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent e) { selectionChanged1(); } }); fTableViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { Template template= (Template) event.getElement(); template.setEnabled(event.getChecked()); } }); Composite buttons= new Composite(innerParent, SWT.NONE); buttons.setLayoutData(new GridData(GridData.VERTICAL_ALIGN_BEGINNING)); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; buttons.setLayout(layout); fAddButton= new Button(buttons, SWT.PUSH); fAddButton.setLayoutData(getButtonGridData(fAddButton)); fAddButton.setText(TemplateMessages.getString("TemplatePreferencePage.new")); //$NON-NLS-1$ fAddButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { add(); } }); fEditButton= new Button(buttons, SWT.PUSH); fEditButton.setLayoutData(getButtonGridData(fEditButton)); fEditButton.setText(TemplateMessages.getString("TemplatePreferencePage.edit")); //$NON-NLS-1$ fEditButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { edit(); } }); fRemoveButton= new Button(buttons, SWT.PUSH); fRemoveButton.setLayoutData(getButtonGridData(fRemoveButton)); fRemoveButton.setText(TemplateMessages.getString("TemplatePreferencePage.remove")); //$NON-NLS-1$ fRemoveButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { remove(); } }); fImportButton= new Button(buttons, SWT.PUSH); fImportButton.setLayoutData(getButtonGridData(fImportButton)); fImportButton.setText(TemplateMessages.getString("TemplatePreferencePage.import")); //$NON-NLS-1$ fImportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { import_(); } }); fExportButton= new Button(buttons, SWT.PUSH); fExportButton.setLayoutData(getButtonGridData(fExportButton)); fExportButton.setText(TemplateMessages.getString("TemplatePreferencePage.export")); //$NON-NLS-1$ fExportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { export(); } }); fExportAllButton= new Button(buttons, SWT.PUSH); fExportAllButton.setLayoutData(getButtonGridData(fExportAllButton)); fExportAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.export.all")); //$NON-NLS-1$ fExportAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { exportAll(); } }); fEnableAllButton= new Button(buttons, SWT.PUSH); fEnableAllButton.setLayoutData(getButtonGridData(fEnableAllButton)); fEnableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.enable.all")); //$NON-NLS-1$ fEnableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(true); } }); fDisableAllButton= new Button(buttons, SWT.PUSH); fDisableAllButton.setLayoutData(getButtonGridData(fDisableAllButton)); fDisableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.disable.all")); //$NON-NLS-1$ fDisableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(false); } }); fPatternViewer= createViewer(parent); fFormatButton= new Button(parent, SWT.CHECK); fFormatButton.setText(TemplateMessages.getString("TemplatePreferencePage.use.code.formatter")); //$NON-NLS-1$ GridData gd1= new GridData(); gd1.horizontalSpan= 2; fFormatButton.setLayoutData(gd1); fTableViewer.setInput(fTemplates); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getBoolean(PREF_FORMAT_TEMPLATES)); updateButtons(); configureTableResizing(innerParent, buttons, table, column1, column2, column3); WorkbenchHelp.setHelp(parent, IJavaHelpContextIds.TEMPLATE_PREFERENCE_PAGE); return parent; } /** * Correctly resizes the table so no phantom columns appear */ private static void configureTableResizing(final Composite parent, final Composite buttons, final Table table, final TableColumn column1, final TableColumn column2, final TableColumn column3) { parent.addControlListener(new ControlAdapter() { public void controlResized(ControlEvent e) { Rectangle area = parent.getClientArea(); Point preferredSize = table.computeSize(SWT.DEFAULT, SWT.DEFAULT); int width = area.width - 2 * table.getBorderWidth(); if (preferredSize.y > area.height) { // Subtract the scrollbar width from the total column width // if a vertical scrollbar will be required Point vBarSize = table.getVerticalBar().getSize(); width -= vBarSize.x; } width-= buttons.getSize().x; Point oldSize = table.getSize(); if (oldSize.x > width) { // table is getting smaller so make the columns // smaller first and then resize the table to // match the client area width column1.setWidth(width/4); column2.setWidth(width/4); column3.setWidth(width - (column1.getWidth() + column2.getWidth())); table.setSize(width, area.height); } else { // table is getting bigger so make the table // bigger first and then make the columns wider // to match the client area width table.setSize(width, area.height); column1.setWidth(width/4); column2.setWidth(width/4); column3.setWidth(width - (column1.getWidth() + column2.getWidth())); } } }); } private Template[] getEnabledTemplates() { Template[] templates= fTemplates.getTemplates(); List list= new ArrayList(templates.length); for (int i= 0; i != templates.length; i++) if (templates[i].isEnabled()) list.add(templates[i]); return (Template[]) list.toArray(new Template[list.size()]); } private SourceViewer createViewer(Composite parent) { Label label= new Label(parent, SWT.NONE); label.setText(TemplateMessages.getString("TemplatePreferencePage.preview")); //$NON-NLS-1$ GridData data= new GridData(); data.horizontalSpan= 2; label.setLayoutData(data); SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); IDocument document= new Document(); IDocumentPartitioner partitioner= tools.createDocumentPartitioner(); document.setDocumentPartitioner(partitioner); partitioner.connect(document); viewer.configure(new JavaSourceViewerConfiguration(tools, null)); viewer.setEditable(false); viewer.setDocument(document); viewer.getTextWidget().setBackground(getShell().getDisplay().getSystemColor(SWT.COLOR_WIDGET_BACKGROUND)); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); data= new GridData(GridData.FILL_BOTH); data.horizontalSpan= 2; data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); return viewer; } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.widthHint= SWTUtil.getButtonWidthHint(button); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private void selectionChanged1() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); if (selection.size() == 1) { Template template= (Template) selection.getFirstElement(); fPatternViewer.getTextWidget().setText(template.getPattern()); } else { fPatternViewer.getTextWidget().setText(""); //$NON-NLS-1$ } updateButtons(); } private void updateButtons() { int selectionCount= ((IStructuredSelection) fTableViewer.getSelection()).size(); int itemCount= fTableViewer.getTable().getItemCount(); fEditButton.setEnabled(selectionCount == 1); fExportButton.setEnabled(selectionCount > 0); fRemoveButton.setEnabled(selectionCount > 0 && selectionCount <= itemCount); fEnableAllButton.setEnabled(itemCount > 0); fDisableAllButton.setEnabled(itemCount > 0); } private void add() { Template template= new Template(); ContextTypeRegistry registry=ContextTypeRegistry.getInstance(); ContextType type= registry.getContextType("java"); //$NON-NLS-1$ String contextTypeName; if (type != null) contextTypeName= type.getName(); else { Iterator iterator= registry.iterator(); contextTypeName= (String) iterator.next(); } template.setContext(contextTypeName); //$NON-NLS-1$ EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, false); if (dialog.open() == dialog.OK) { fTemplates.add(template); fTableViewer.refresh(); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void edit() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] objects= selection.toArray(); if ((objects == null) || (objects.length != 1)) return; Template template= (Template) selection.getFirstElement(); edit(template); } private void edit(Template template) { Template newTemplate= new Template(template); EditTemplateDialog dialog= new EditTemplateDialog(getShell(), newTemplate, true); if (dialog.open() == dialog.OK) { if (!newTemplate.getName().equals(template.getName()) && MessageDialog.openQuestion(getShell(), TemplateMessages.getString("TemplatePreferencePage.question.create.new.title"), //$NON-NLS-1$ TemplateMessages.getString("TemplatePreferencePage.question.create.new.message"))) //$NON-NLS-1$ { template= newTemplate; fTemplates.add(template); fTableViewer.refresh(); } else { template.setName(newTemplate.getName()); template.setDescription(newTemplate.getDescription()); template.setContext(newTemplate.getContextTypeName()); template.setPattern(newTemplate.getPattern()); fTableViewer.refresh(template); } fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void import_() { FileDialog dialog= new FileDialog(getShell()); dialog.setText(TemplateMessages.getString("TemplatePreferencePage.import.title")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.import.extension")}); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { fTemplates.addFromFile(new File(path)); fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } catch (CoreException e) { openReadErrorDialog(e); } } private void exportAll() { export(fTemplates); } private void export() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] templates= selection.toArray(); TemplateSet templateSet= new TemplateSet(); for (int i= 0; i != templates.length; i++) templateSet.add((Template) templates[i]); export(templateSet); } private void export(TemplateSet templateSet) { FileDialog dialog= new FileDialog(getShell(), SWT.SAVE); dialog.setText(TemplateMessages.getFormattedString("TemplatePreferencePage.export.title", new Integer(templateSet.getTemplates().length))); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.export.extension")}); //$NON-NLS-1$ dialog.setFileName(TemplateMessages.getString("TemplatePreferencePage.export.filename")); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; File file= new File(path); if (!file.exists() || confirmOverwrite(file)) { try { templateSet.saveToFile(file); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } } } private boolean confirmOverwrite(File file) { return MessageDialog.openQuestion(getShell(), TemplateMessages.getString("TemplatePreferencePage.export.exists.title"), //$NON-NLS-1$ TemplateMessages.getFormattedString("TemplatePreferencePage.export.exists.message", file.getAbsolutePath())); //$NON-NLS-1$ } private void remove() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Iterator elements= selection.iterator(); while (elements.hasNext()) { Template template= (Template) elements.next(); fTemplates.remove(template); } fTableViewer.refresh(); } private void enableAll(boolean enable) { Template[] templates= fTemplates.getTemplates(); for (int i= 0; i != templates.length; i++) templates[i].setEnabled(enable); fTableViewer.setAllChecked(enable); } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) {} /* * @see Control#setVisible(boolean) */ public void setVisible(boolean visible) { super.setVisible(visible); if (visible) setTitle(TemplateMessages.getString("TemplatePreferencePage.title")); //$NON-NLS-1$ } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getDefaultBoolean(PREF_FORMAT_TEMPLATES)); try { fTemplates.restoreDefaults(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } // refresh fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } /* * @see PreferencePage#performOk() */ public boolean performOk() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); prefs.setValue(PREF_FORMAT_TEMPLATES, fFormatButton.getSelection()); try { fTemplates.save(); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } JavaPlugin.getDefault().savePluginPreferences(); return super.performOk(); } /* * @see PreferencePage#performCancel() */ public boolean performCancel() { try { fTemplates.reset(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } return super.performCancel(); } /** * Initializes the default values of this page in the preference bundle. * Will be called on startup of the JavaPlugin */ public static void initDefaults(IPreferenceStore prefs) { prefs.setDefault(PREF_FORMAT_TEMPLATES, true); } public static boolean useCodeFormatter() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); return prefs.getBoolean(PREF_FORMAT_TEMPLATES); } private void openReadErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.read.title"), //$NON-NLS-1$ null, e.getStatus()); } private void openWriteErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.write.title"), //$NON-NLS-1$ null, e.getStatus()); } }
20,237
Bug 20237 TVT2: mnemonic not workin in java template prefs
With build F2. A mnemonic in the new template dialog is not working. Below are the replication steps. 1) Window>Preferences 2) Java>Templates 3) Click on New... 4) Mnemonic for Patterns does not work. All others are fine.
resolved fixed
67d7d54
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T11:33:39Z
2002-06-13T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/EditTemplateDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Vector; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.custom.VerifyKeyListener; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.KeyListener; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.events.VerifyEvent; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Combo; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.ITextListener; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.ITextViewerExtension; import org.eclipse.jface.text.TextEvent; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistProcessor; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.corext.template.ContextTypeRegistry; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.TemplateMessages; import org.eclipse.jdt.internal.corext.template.TemplateTranslator; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.JavaPartitionScanner; import org.eclipse.jdt.internal.ui.text.template.TemplateVariableProcessor; import org.eclipse.jdt.internal.ui.util.SWTUtil; /** * Dialog to edit a template. */ public class EditTemplateDialog extends StatusDialog { private static class SimpleJavaSourceViewerConfiguration extends JavaSourceViewerConfiguration { private final IContentAssistProcessor fProcessor; SimpleJavaSourceViewerConfiguration(JavaTextTools tools, ITextEditor editor, IContentAssistProcessor processor) { super(tools, editor); fProcessor= processor; } /* * @see SourceViewerConfiguration#getContentAssistant(ISourceViewer) */ public IContentAssistant getContentAssistant(ISourceViewer sourceViewer) { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); ContentAssistant assistant= new ContentAssistant(); assistant.setContentAssistProcessor(fProcessor, IDocument.DEFAULT_CONTENT_TYPE); // Register the same processor for strings and single line comments to get code completion at the start of those partitions. assistant.setContentAssistProcessor(fProcessor, JavaPartitionScanner.JAVA_STRING); assistant.setContentAssistProcessor(fProcessor, JavaPartitionScanner.JAVA_SINGLE_LINE_COMMENT); assistant.setContentAssistProcessor(fProcessor, JavaPartitionScanner.JAVA_DOC); assistant.enableAutoInsert(store.getBoolean(ContentAssistPreference.AUTOINSERT)); assistant.enableAutoActivation(store.getBoolean(ContentAssistPreference.AUTOACTIVATION)); assistant.setAutoActivationDelay(store.getInt(ContentAssistPreference.AUTOACTIVATION_DELAY)); assistant.setProposalPopupOrientation(assistant.PROPOSAL_OVERLAY); assistant.setContextInformationPopupOrientation(assistant.CONTEXT_INFO_ABOVE); assistant.setInformationControlCreator(getInformationControlCreator(sourceViewer)); Display display= sourceViewer.getTextWidget().getDisplay(); Color background= createColor(store, ContentAssistPreference.PROPOSALS_BACKGROUND, display); assistant.setContextInformationPopupBackground(background); assistant.setContextSelectorBackground(background); assistant.setProposalSelectorBackground(background); Color foreground= createColor(store, ContentAssistPreference.PROPOSALS_FOREGROUND, display); assistant.setContextInformationPopupForeground(foreground); assistant.setContextSelectorForeground(foreground); assistant.setProposalSelectorForeground(foreground); return assistant; } /** * Creates a color from the information stored in the given preference store. * Returns <code>null</code> if there is no such information available. */ private Color createColor(IPreferenceStore store, String key, Display display) { RGB rgb= null; if (store.contains(key)) { if (store.isDefault(key)) rgb= PreferenceConverter.getDefaultColor(store, key); else rgb= PreferenceConverter.getColor(store, key); if (rgb != null) return new Color(display, rgb); } return null; } } private static class TextViewerAction extends Action implements IUpdate { private int fOperationCode= -1; private ITextOperationTarget fOperationTarget; public TextViewerAction(ITextViewer viewer, int operationCode) { fOperationCode= operationCode; fOperationTarget= viewer.getTextOperationTarget(); update(); } /** * Updates the enabled state of the action. * Fires a property change if the enabled state changes. * * @see Action#firePropertyChange(String, Object, Object) */ public void update() { boolean wasEnabled= isEnabled(); boolean isEnabled= (fOperationTarget != null && fOperationTarget.canDoOperation(fOperationCode)); setEnabled(isEnabled); if (wasEnabled != isEnabled) { firePropertyChange(ENABLED, wasEnabled ? Boolean.TRUE : Boolean.FALSE, isEnabled ? Boolean.TRUE : Boolean.FALSE); } } /** * @see Action#run() */ public void run() { if (fOperationCode != -1 && fOperationTarget != null) { fOperationTarget.doOperation(fOperationCode); } } } private final Template fTemplate; private Text fNameText; private Text fDescriptionText; private Combo fContextCombo; private SourceViewer fPatternEditor; private Button fInsertVariableButton; private TemplateTranslator fTranslator= new TemplateTranslator(); private boolean fSuppressError= true; // #4354 private Map fGlobalActions= new HashMap(10); private List fSelectionActions = new ArrayList(3); private Vector fContextTypes= new Vector(); private final TemplateVariableProcessor fProcessor= new TemplateVariableProcessor(); public EditTemplateDialog(Shell parent, Template template, boolean edit) { super(parent); setShellStyle(getShellStyle() | SWT.MAX | SWT.RESIZE); String title= edit ? TemplateMessages.getString("EditTemplateDialog.title.edit") //$NON-NLS-1$ : TemplateMessages.getString("EditTemplateDialog.title.new"); //$NON-NLS-1$ setTitle(title); fTemplate= template; ContextTypeRegistry registry= ContextTypeRegistry.getInstance(); for (Iterator iterator= registry.iterator(); iterator.hasNext(); ) fContextTypes.add(iterator.next()); if (fContextTypes.size() > 0) fProcessor.setContextType(ContextTypeRegistry.getInstance().getContextType((String) fContextTypes.get(0))); } /* * @see Dialog#createDialogArea(Composite) */ protected Control createDialogArea(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; parent.setLayout(layout); parent.setLayoutData(new GridData(GridData.FILL_BOTH)); createLabel(parent, TemplateMessages.getString("EditTemplateDialog.name")); //$NON-NLS-1$ Composite composite= new Composite(parent, SWT.NONE); composite.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); layout= new GridLayout(); layout.numColumns= 3; layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); fNameText= createText(composite); fNameText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { if (fSuppressError && (fNameText.getText().trim().length() != 0)) fSuppressError= false; updateButtons(); } }); createLabel(composite, TemplateMessages.getString("EditTemplateDialog.context")); //$NON-NLS-1$ fContextCombo= new Combo(composite, SWT.READ_ONLY); for (Iterator iterator= fContextTypes.iterator(); iterator.hasNext(); ) fContextCombo.add((String) iterator.next()); fContextCombo.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { String name= fContextCombo.getText(); fProcessor.setContextType(ContextTypeRegistry.getInstance().getContextType(name)); } }); createLabel(parent, TemplateMessages.getString("EditTemplateDialog.description")); //$NON-NLS-1$ fDescriptionText= createText(parent); composite= new Composite(parent, SWT.NONE); composite.setLayoutData(new GridData(GridData.FILL_VERTICAL)); layout= new GridLayout(); layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); createLabel(composite, TemplateMessages.getString("EditTemplateDialog.pattern")); //$NON-NLS-1$ fPatternEditor= createEditor(parent); Label filler= new Label(composite, SWT.NONE); filler.setLayoutData(new GridData(GridData.FILL_VERTICAL)); fInsertVariableButton= new Button(composite, SWT.NONE); fInsertVariableButton.setLayoutData(getButtonGridData(fInsertVariableButton)); fInsertVariableButton.setText(TemplateMessages.getString("EditTemplateDialog.insert.variable")); //$NON-NLS-1$ fInsertVariableButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent e) { fPatternEditor.getTextWidget().setFocus(); fPatternEditor.doOperation(ISourceViewer.CONTENTASSIST_PROPOSALS); } public void widgetDefaultSelected(SelectionEvent e) {} }); fNameText.setText(fTemplate.getName()); fDescriptionText.setText(fTemplate.getDescription()); fContextCombo.select(getIndex(fTemplate.getContextTypeName())); initializeActions(); return composite; } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private static Label createLabel(Composite parent, String name) { Label label= new Label(parent, SWT.NULL); label.setText(name); label.setLayoutData(new GridData()); return label; } private static Text createText(Composite parent) { Text text= new Text(parent, SWT.BORDER); text.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); return text; } private SourceViewer createEditor(Composite parent) { SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); IDocument document= new Document(fTemplate.getPattern()); IDocumentPartitioner partitioner= tools.createDocumentPartitioner(); document.setDocumentPartitioner(partitioner); partitioner.connect(document); viewer.configure(new SimpleJavaSourceViewerConfiguration(tools, null, fProcessor)); viewer.setEditable(true); viewer.setDocument(document); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(60); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); viewer.addTextListener(new ITextListener() { public void textChanged(TextEvent event) { try { fTranslator.translate(event.getDocumentEvent().getDocument().get()); } catch (CoreException e) { JavaPlugin.log(e); } updateUndoAction(); updateButtons(); } }); viewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { updateSelectionDependentActions(); } }); if (viewer instanceof ITextViewerExtension) { ((ITextViewerExtension) viewer).prependVerifyKeyListener(new VerifyKeyListener() { public void verifyKey(VerifyEvent event) { handleVerifyKeyPressed(event); } }); } else { viewer.getTextWidget().addKeyListener(new KeyListener() { public void keyPressed(KeyEvent e) { handleKeyPressed(e); } public void keyReleased(KeyEvent e) {} }); } return viewer; } private void handleKeyPressed(KeyEvent event) { if (event.stateMask != SWT.CTRL) return; switch (event.character) { case ' ': fPatternEditor.doOperation(ISourceViewer.CONTENTASSIST_PROPOSALS); break; // CTRL-Z case (int) 'z' - (int) 'a' + 1: fPatternEditor.doOperation(ITextOperationTarget.UNDO); break; } } private void handleVerifyKeyPressed(VerifyEvent event) { if (!event.doit) return; if (event.stateMask != SWT.CTRL) return; switch (event.character) { case ' ': fPatternEditor.doOperation(ISourceViewer.CONTENTASSIST_PROPOSALS); event.doit= false; break; // CTRL-Z case (int) 'z' - (int) 'a' + 1: fPatternEditor.doOperation(ITextOperationTarget.UNDO); event.doit= false; break; } } private void initializeActions() { TextViewerAction action= new TextViewerAction(fPatternEditor, fPatternEditor.UNDO); action.setText(TemplateMessages.getString("EditTemplateDialog.undo")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.UNDO, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.CUT); action.setText(TemplateMessages.getString("EditTemplateDialog.cut")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.CUT, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.COPY); action.setText(TemplateMessages.getString("EditTemplateDialog.copy")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.COPY, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.PASTE); action.setText(TemplateMessages.getString("EditTemplateDialog.paste")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.PASTE, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.SELECT_ALL); action.setText(TemplateMessages.getString("EditTemplateDialog.select.all")); //$NON-NLS-1$ fGlobalActions.put(ITextEditorActionConstants.SELECT_ALL, action); action= new TextViewerAction(fPatternEditor, fPatternEditor.CONTENTASSIST_PROPOSALS); action.setText(TemplateMessages.getString("EditTemplateDialog.content.assist")); //$NON-NLS-1$ fGlobalActions.put("ContentAssistProposal", action); //$NON-NLS-1$ fSelectionActions.add(ITextEditorActionConstants.CUT); fSelectionActions.add(ITextEditorActionConstants.COPY); fSelectionActions.add(ITextEditorActionConstants.PASTE); // create context menu MenuManager manager= new MenuManager(null, null); manager.setRemoveAllWhenShown(true); manager.addMenuListener(new IMenuListener() { public void menuAboutToShow(IMenuManager mgr) { fillContextMenu(mgr); } }); StyledText text= fPatternEditor.getTextWidget(); Menu menu= manager.createContextMenu(text); text.setMenu(menu); } private void fillContextMenu(IMenuManager menu) { menu.add(new GroupMarker(ITextEditorActionConstants.GROUP_UNDO)); menu.appendToGroup(ITextEditorActionConstants.GROUP_UNDO, (IAction) fGlobalActions.get(ITextEditorActionConstants.UNDO)); menu.add(new Separator(ITextEditorActionConstants.GROUP_EDIT)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.CUT)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.COPY)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.PASTE)); menu.appendToGroup(ITextEditorActionConstants.GROUP_EDIT, (IAction) fGlobalActions.get(ITextEditorActionConstants.SELECT_ALL)); menu.add(new Separator(IContextMenuConstants.GROUP_GENERATE)); menu.appendToGroup(IContextMenuConstants.GROUP_GENERATE, (IAction) fGlobalActions.get("ContentAssistProposal")); //$NON-NLS-1$ } protected void updateSelectionDependentActions() { Iterator iterator= fSelectionActions.iterator(); while (iterator.hasNext()) updateAction((String)iterator.next()); } protected void updateUndoAction() { IAction action= (IAction) fGlobalActions.get(ITextEditorActionConstants.UNDO); if (action instanceof IUpdate) ((IUpdate) action).update(); } protected void updateAction(String actionId) { IAction action= (IAction) fGlobalActions.get(actionId); if (action instanceof IUpdate) ((IUpdate) action).update(); } private int getIndex(String context) { ContextTypeRegistry registry= ContextTypeRegistry.getInstance(); registry.getContextType(context); if (context == null) return -1; return fContextTypes.indexOf(context); } protected void okPressed() { fTemplate.setName(fNameText.getText()); fTemplate.setDescription(fDescriptionText.getText()); fTemplate.setContext(fContextCombo.getText()); fTemplate.setPattern(fPatternEditor.getTextWidget().getText()); super.okPressed(); } private void updateButtons() { boolean valid= fNameText.getText().trim().length() != 0; StatusInfo status= new StatusInfo(); if (!valid) { if (fSuppressError) status.setError(""); //$NON-NLS-1$ else status.setError(TemplateMessages.getString("EditTemplateDialog.error.noname")); //$NON-NLS-1$ } else if (fTranslator.getErrorMessage() != null) { status.setError(fTranslator.getErrorMessage()); } updateStatus(status); } /* * @see org.eclipse.jface.window.Window#configureShell(Shell) */ protected void configureShell(Shell newShell) { super.configureShell(newShell); WorkbenchHelp.setHelp(newShell, IJavaHelpContextIds.EDIT_TEMPLATE_DIALOG); } }
20,475
Bug 20475 Quick fix proposal preview: Bold off by 2 characters
F3 create file class A extends Object1 { } -> Object1 is marked as temporary error, Quick Fix. Select 'Change to Object', look at the preview: The preview shows changes in bold: It is off by 2 charaters: 'ject {' is bold, should be 'Object'. From debugging I see that the resulting html is correct, bug must be in rendering. Look stupid, should be fixed.
resolved fixed
25f383b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T18:20:37Z
2002-06-17T16:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/HTML2TextReader.java
package org.eclipse.jdt.internal.ui.text; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.io.IOException; import java.io.PushbackReader; import java.io.Reader; import java.util.HashMap; import java.util.HashSet; import java.util.Map; import java.util.Set; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyleRange; import org.eclipse.jface.text.TextPresentation; import org.eclipse.jdt.internal.ui.JavaUIMessages; /** * Reads the text contents from a reader of HTML contents and translates * the tags or cut them out. */ public class HTML2TextReader extends SubstitutionTextReader { private static final String LINE_DELIM= System.getProperty("line.separator", "\n"); //$NON-NLS-1$ //$NON-NLS-2$ private static final Map fgEntityLookup; private static final Set fgTags; static { fgTags= new HashSet(); fgTags.add("b"); //$NON-NLS-1$ fgTags.add("br"); //$NON-NLS-1$ fgTags.add("h5"); //$NON-NLS-1$ fgTags.add("p"); //$NON-NLS-1$ fgTags.add("dl"); //$NON-NLS-1$ fgTags.add("dt"); //$NON-NLS-1$ fgTags.add("dd"); //$NON-NLS-1$ fgTags.add("li"); //$NON-NLS-1$ fgTags.add("ul"); //$NON-NLS-1$ fgEntityLookup= new HashMap(7); fgEntityLookup.put("lt", "<"); //$NON-NLS-1$ //$NON-NLS-2$ fgEntityLookup.put("gt", ">"); //$NON-NLS-1$ //$NON-NLS-2$ fgEntityLookup.put("nbsp", " "); //$NON-NLS-1$ //$NON-NLS-2$ fgEntityLookup.put("amp", "&"); //$NON-NLS-1$ //$NON-NLS-2$ fgEntityLookup.put("circ", "^"); //$NON-NLS-1$ //$NON-NLS-2$ fgEntityLookup.put("tilde", "~"); //$NON-NLS-2$ //$NON-NLS-1$ fgEntityLookup.put("quot", "\""); //$NON-NLS-1$ //$NON-NLS-2$ } private int fCounter= 0; private TextPresentation fTextPresentation; private int fBold= 0; private int fStartOffset= -1; /** * Transforms the html text from the reader to formatted text. * @param presentation If not <code>null</code>, formattings will be applied to * the presentation. */ public HTML2TextReader(Reader reader, TextPresentation presentation) { super(new PushbackReader(reader)); fTextPresentation= presentation; } public int read() throws IOException { int c= super.read(); if (c != -1) ++ fCounter; return c; } protected void startBold() { if (fBold == 0) fStartOffset= fCounter; ++ fBold; } protected void stopBold() { -- fBold; if (fBold == 0) { if (fTextPresentation != null) { fTextPresentation.addStyleRange(new StyleRange(fStartOffset, fCounter - fStartOffset, null, null, SWT.BOLD)); } fStartOffset= -1; } } /** * @see SubstitutionTextReader#computeSubstitution(char) */ protected String computeSubstitution(int c) throws IOException { if (c == '<') return processHTMLTag(); else if (c == '&') return processEntity(); return null; } private String html2Text(String html) { String tag= html; if ('/' == tag.charAt(0)) tag= tag.substring(1); if (!fgTags.contains(tag)) return ""; //$NON-NLS-1$ if ("b".equals(html)) { //$NON-NLS-1$ startBold(); return ""; //$NON-NLS-1$ } if ("h5".equals(html) || "dt".equals(html)) { //$NON-NLS-1$ //$NON-NLS-2$ startBold(); return ""; //$NON-NLS-1$ } if ("dl".equals(html)) //$NON-NLS-1$ return LINE_DELIM; if ("dd".equals(html)) //$NON-NLS-1$ return "\t"; //$NON-NLS-1$ if ("li".equals(html)) //$NON-NLS-1$ return LINE_DELIM + "\t" + JavaUIMessages.getString("HTML2TextReader.dash"); //$NON-NLS-1$ //$NON-NLS-2$ if ("/b".equals(html)) { //$NON-NLS-1$ stopBold(); return ""; //$NON-NLS-1$ } if ("p".equals(html)) //$NON-NLS-1$ return LINE_DELIM; if ("br".equals(html)) //$NON-NLS-1$ return LINE_DELIM; if ("/p".equals(html)) //$NON-NLS-1$ return LINE_DELIM; if ("/h5".equals(html) || "/dt".equals(html)) { //$NON-NLS-1$ //$NON-NLS-2$ stopBold(); return LINE_DELIM; } if ("/dd".equals(html)) //$NON-NLS-1$ return LINE_DELIM; return ""; //$NON-NLS-1$ } /* * A '<' has been read. Process a html tag */ private String processHTMLTag() throws IOException { StringBuffer buf= new StringBuffer(); int ch; do { ch= nextChar(); while (ch != -1 && ch != '>') { buf.append(Character.toLowerCase((char) ch)); ch= nextChar(); if (ch == '"'){ buf.append(Character.toLowerCase((char) ch)); ch= nextChar(); while (ch != -1 && ch != '"'){ buf.append(Character.toLowerCase((char) ch)); ch= nextChar(); } } if (ch == '<'){ unread(ch); return '<' + buf.toString(); } } if (ch == -1) return null; int tagLen= buf.length(); // needs special treatment for comments if ((tagLen >= 3 && "!--".equals(buf.substring(0, 3))) //$NON-NLS-1$ && !(tagLen >= 5 && "--!".equals(buf.substring(tagLen - 3)))) { //$NON-NLS-1$ // unfinished comment buf.append(ch); } else { break; } } while (true); return html2Text(buf.toString()); } private void unread(int ch) throws IOException { ((PushbackReader) getReader()).unread(ch); } protected String entity2Text(String symbol) { if (symbol.length() > 1 && symbol.charAt(0) == '#') { int ch; try { if (symbol.charAt(1) == 'x') { ch= Integer.parseInt(symbol.substring(2), 16); } else { ch= Integer.parseInt(symbol.substring(1), 10); } return "" + (char)ch; //$NON-NLS-1$ } catch (NumberFormatException e) { } } else { String str= (String) fgEntityLookup.get(symbol); if (str != null) { return str; } } return "&" + symbol; // not found //$NON-NLS-1$ } /* * A '&' has been read. Process a entity */ private String processEntity() throws IOException { StringBuffer buf= new StringBuffer(); int ch= nextChar(); while (Character.isLetterOrDigit((char)ch) || ch == '#') { buf.append((char) ch); ch= nextChar(); } if (ch == ';') return entity2Text(buf.toString()); buf.insert(0, '&'); if (ch != -1) buf.append((char) ch); return buf.toString(); } }
20,475
Bug 20475 Quick fix proposal preview: Bold off by 2 characters
F3 create file class A extends Object1 { } -> Object1 is marked as temporary error, Quick Fix. Select 'Change to Object', look at the preview: The preview shows changes in bold: It is off by 2 charaters: 'ject {' is bold, should be 'Object'. From debugging I see that the resulting html is correct, bug must be in rendering. Look stupid, should be fixed.
resolved fixed
25f383b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T18:20:37Z
2002-06-17T16:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/HTMLTextPresenter.java
package org.eclipse.jdt.internal.ui.text; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.io.IOException; import java.io.Reader; import java.io.StringReader; import java.util.Iterator; import org.eclipse.swt.custom.StyleRange; import org.eclipse.swt.graphics.GC; import org.eclipse.swt.widgets.Display; import org.eclipse.jface.text.DefaultInformationControl; import org.eclipse.jface.text.Region; import org.eclipse.jface.text.TextPresentation; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; public class HTMLTextPresenter implements DefaultInformationControl.IInformationPresenter { private static final String LINE_DELIM= System.getProperty("line.separator", "\n"); //$NON-NLS-1$ //$NON-NLS-2$ private int fCounter; private boolean fEnforceUpperLineLimit; public HTMLTextPresenter(boolean enforceUpperLineLimit) { super(); fEnforceUpperLineLimit= enforceUpperLineLimit; } public HTMLTextPresenter() { this(true); } protected Reader createReader(String hoverInfo, TextPresentation presentation) { return new HTML2TextReader(new StringReader(hoverInfo), presentation); } protected void adaptTextPresentation(TextPresentation presentation, int offset, int insertLength) { int yoursStart= offset; int yoursEnd= offset + insertLength -1; yoursEnd= Math.max(yoursStart, yoursEnd); Iterator e= presentation.getAllStyleRangeIterator(); while (e.hasNext()) { StyleRange range= (StyleRange) e.next(); int myStart= range.start; int myEnd= range.start + range.length -1; myEnd= Math.max(myStart, myEnd); if (myEnd < yoursStart) continue; if (myStart < yoursStart) range.length += insertLength; else range.start += insertLength; } } private void append(StringBuffer buffer, String string, TextPresentation presentation) { int length= string.length(); buffer.append(string); if (presentation != null) adaptTextPresentation(presentation, fCounter, length); fCounter += length; } private String getIndent(String line) { int length= line.length(); int i= 0; while (i < length && Character.isWhitespace(line.charAt(i))) ++i; return (i == length ? line : line.substring(0, i)) + " "; //$NON-NLS-1$ } /* * @see IHoverInformationPresenter#updatePresentation(Display display, String, TextPresentation, int, int) */ public String updatePresentation(Display display, String hoverInfo, TextPresentation presentation, int maxWidth, int maxHeight) { if (hoverInfo == null) return null; GC gc= new GC(display); try { StringBuffer buffer= new StringBuffer(); int maxNumberOfLines= Math.round(maxHeight / gc.getFontMetrics().getHeight()); fCounter= 0; LineBreakingReader reader= new LineBreakingReader(createReader(hoverInfo, presentation), gc, maxWidth); boolean lastLineFormatted= false; String lastLineIndent= null; String line=reader.readLine(); boolean lineFormatted= reader.isFormattedLine(); while (line != null) { if (fEnforceUpperLineLimit && maxNumberOfLines <= 0) break; if (buffer.length() > 0) { if (!lastLineFormatted) append(buffer, LINE_DELIM, null); else { append(buffer, LINE_DELIM, presentation); if (lastLineIndent != null) append(buffer, lastLineIndent, presentation); } } append(buffer, line, null); lastLineFormatted= lineFormatted; if (!lineFormatted) lastLineIndent= null; else if (lastLineIndent == null) lastLineIndent= getIndent(line); line= reader.readLine(); lineFormatted= reader.isFormattedLine(); maxNumberOfLines--; } if (line != null) { append(buffer, LINE_DELIM, lineFormatted ? presentation : null); append(buffer, JavaUIMessages.getString("HTMLTextPresenter.ellipsis"), presentation); //$NON-NLS-1$ } return trim(buffer, presentation); } catch (IOException e) { JavaPlugin.log(e); return null; } finally { gc.dispose(); } } private String trim(StringBuffer buffer, TextPresentation presentation) { int length= buffer.length(); int end= length -1; while (end >= 0 && Character.isWhitespace(buffer.charAt(end))) -- end; if (end == -1) return ""; //$NON-NLS-1$ if (end < length -1) buffer.delete(end + 1, length); else end= length; int start= 0; while (start < end && Character.isWhitespace(buffer.charAt(start))) ++ start; buffer.delete(0, start); presentation.setResultWindow(new Region(start, buffer.length())); return buffer.toString(); } }
20,040
Bug 20040 java editor: undo does not work correctly
20020612 .create new class .'override methods...' - add clone() .undo .redo .undo the plain text editor does not exhibit this mis-behavior you're left with garbage like (pressing undo/redo more times produces even more garbage): public class Dfg { r.clone(); //<<GARBAGE } //<<GARBAGE }
resolved fixed
e11a624
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T18:35:49Z
2002-06-12T16:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Layout; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Preferences; import org.eclipse.core.runtime.Preferences.IPropertyChangeListener; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IMessageProvider; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.DocumentCommand; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ILineTracker; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.IWidgetTokenKeeper; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewerConfiguration; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.ContentAssistAction; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.tasklist.TaskList; import org.eclipse.help.IHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.compare.LocalHistoryActionGroup; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.SelectionHistory; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectEnclosingAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectHistoryAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectNextAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectPreviousAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionAction; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer; import org.eclipse.jdt.internal.ui.text.java.IReconcilingParticipant; /** * Java specific text editor. */ public class CompilationUnitEditor extends JavaEditor implements IReconcilingParticipant { interface ITextConverter { void customizeDocumentCommand(IDocument document, DocumentCommand command); }; class AdaptedRulerLayout extends Layout { protected int fGap; protected AdaptedSourceViewer fAdaptedSourceViewer; protected AdaptedRulerLayout(int gap, AdaptedSourceViewer asv) { fGap= gap; fAdaptedSourceViewer= asv; } protected Point computeSize(Composite composite, int wHint, int hHint, boolean flushCache) { Control[] children= composite.getChildren(); Point s= children[children.length - 1].computeSize(SWT.DEFAULT, SWT.DEFAULT, flushCache); if (fAdaptedSourceViewer.isVerticalRulerVisible()) s.x += fAdaptedSourceViewer.getVerticalRuler().getWidth() + fGap; return s; } protected void layout(Composite composite, boolean flushCache) { Rectangle clArea= composite.getClientArea(); if (fAdaptedSourceViewer.isVerticalRulerVisible()) { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); Rectangle trim= textWidget.computeTrim(0, 0, 0, 0); int scrollbarHeight= trim.height; IVerticalRuler vr= fAdaptedSourceViewer.getVerticalRuler(); int vrWidth=vr.getWidth(); int orWidth= 0; if (fAdaptedSourceViewer.isOverviewRulerVisible()) { OverviewRuler or= fAdaptedSourceViewer.getOverviewRuler(); orWidth= or.getWidth(); or.getControl().setBounds(clArea.width - orWidth, scrollbarHeight, orWidth, clArea.height - 3*scrollbarHeight); } textWidget.setBounds(vrWidth + fGap, 0, clArea.width - vrWidth - orWidth - 2*fGap, clArea.height); vr.getControl().setBounds(0, 0, vrWidth, clArea.height - scrollbarHeight); } else { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); textWidget.setBounds(0, 0, clArea.width, clArea.height); } } }; class AdaptedSourceViewer extends JavaCorrectionSourceViewer { private List fTextConverters; private OverviewRuler fOverviewRuler; private boolean fIsOverviewRulerVisible; private IVerticalRuler fCachedVerticalRuler; private boolean fCachedIsVerticalRulerVisible; public AdaptedSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { super(parent, ruler, styles, CompilationUnitEditor.this); fCachedVerticalRuler= ruler; fCachedIsVerticalRulerVisible= (ruler != null); fOverviewRuler= new OverviewRuler(VERTICAL_RULER_WIDTH); delayedCreateControl(parent, styles); } /* * @see ISourceViewer#showAnnotations(boolean) */ public void showAnnotations(boolean show) { fCachedIsVerticalRulerVisible= (show && fCachedVerticalRuler != null); super.showAnnotations(show); } public IContentAssistant getContentAssistant() { return fContentAssistant; } /* * @see ITextOperationTarget#doOperation(int) */ public void doOperation(int operation) { if (getTextWidget() == null) return; switch (operation) { case CONTENTASSIST_PROPOSALS: String msg= fContentAssistant.showPossibleCompletions(); setStatusLineErrorMessage(msg); return; } super.doOperation(operation); } public void insertTextConverter(ITextConverter textConverter, int index) { throw new UnsupportedOperationException(); } public void addTextConverter(ITextConverter textConverter) { if (fTextConverters == null) { fTextConverters= new ArrayList(1); fTextConverters.add(textConverter); } else if (!fTextConverters.contains(textConverter)) fTextConverters.add(textConverter); } public void removeTextConverter(ITextConverter textConverter) { if (fTextConverters != null) { fTextConverters.remove(textConverter); if (fTextConverters.size() == 0) fTextConverters= null; } } /* * @see TextViewer#customizeDocumentCommand(DocumentCommand) */ protected void customizeDocumentCommand(DocumentCommand command) { super.customizeDocumentCommand(command); if (fTextConverters != null) { for (Iterator e = fTextConverters.iterator(); e.hasNext();) ((ITextConverter) e.next()).customizeDocumentCommand(getDocument(), command); } } public IVerticalRuler getVerticalRuler() { return fCachedVerticalRuler; } public boolean isVerticalRulerVisible() { return fCachedIsVerticalRulerVisible; } public OverviewRuler getOverviewRuler() { return fOverviewRuler; } /* * @see TextViewer#createControl(Composite, int) */ protected void createControl(Composite parent, int styles) { // do nothing here } protected void delayedCreateControl(Composite parent, int styles) { //create the viewer super.createControl(parent, styles); Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.setLayout(new AdaptedRulerLayout(GAP_SIZE, this)); fOverviewRuler.createControl(composite, this); } } public void hideOverviewRuler() { fIsOverviewRulerVisible= false; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public void showOverviewRuler() { fIsOverviewRulerVisible= true; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public boolean isOverviewRulerVisible() { return fIsOverviewRulerVisible; } /* * @see ISourceViewer#setDocument(IDocument, IAnnotationModel, int, int) */ public void setDocument(IDocument document, IAnnotationModel annotationModel, int visibleRegionOffset, int visibleRegionLength) { super.setDocument(document, annotationModel, visibleRegionOffset, visibleRegionLength); fOverviewRuler.setModel(annotationModel); } // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 public void updateIndentationPrefixes() { SourceViewerConfiguration configuration= getSourceViewerConfiguration(); String[] types= configuration.getConfiguredContentTypes(this); for (int i= 0; i < types.length; i++) { String[] prefixes= configuration.getIndentPrefixes(this, types[i]); if (prefixes != null && prefixes.length > 0) setIndentPrefixes(prefixes, types[i]); } } /* * @see IWidgetTokenOwner#requestWidgetToken(IWidgetTokenKeeper) */ public boolean requestWidgetToken(IWidgetTokenKeeper requester) { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19445 IHelp help= WorkbenchHelp.getHelpSupport(); if (help != null && help.isContextHelpDisplayed()) return false; return super.requestWidgetToken(requester); } }; static class TabConverter implements ITextConverter { private int fTabRatio; private ILineTracker fLineTracker; public TabConverter() { } public void setNumberOfSpacesPerTab(int ratio) { fTabRatio= ratio; } public void setLineTracker(ILineTracker lineTracker) { fLineTracker= lineTracker; } private int insertTabString(StringBuffer buffer, int offsetInLine) { if (fTabRatio == 0) return 0; int remainder= offsetInLine % fTabRatio; remainder= fTabRatio - remainder; for (int i= 0; i < remainder; i++) buffer.append(' '); return remainder; } public void customizeDocumentCommand(IDocument document, DocumentCommand command) { String text= command.text; if (text == null) return; int index= text.indexOf('\t'); if (index > -1) { StringBuffer buffer= new StringBuffer(); fLineTracker.set(command.text); int lines= fLineTracker.getNumberOfLines(); try { for (int i= 0; i < lines; i++) { int offset= fLineTracker.getLineOffset(i); int endOffset= offset + fLineTracker.getLineLength(i); String line= text.substring(offset, endOffset); int position= 0; if (i == 0) { IRegion firstLine= document.getLineInformationOfOffset(command.offset); position= command.offset - firstLine.getOffset(); } int length= line.length(); for (int j= 0; j < length; j++) { char c= line.charAt(j); if (c == '\t') { position += insertTabString(buffer, position); } else { buffer.append(c); ++ position; } } } command.text= buffer.toString(); } catch (BadLocationException x) { } } } }; private class PropertyChangeListener implements IPropertyChangeListener { /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { handlePreferencePropertyChanged(event); } } /* Preference key for code formatter tab size */ private final static String CODE_FORMATTER_TAB_SIZE= JavaCore.FORMATTER_TAB_SIZE; /** Preference key for matching brackets */ public final static String MATCHING_BRACKETS= "matchingBrackets"; //$NON-NLS-1$ /** Preference key for matching brackets color */ public final static String MATCHING_BRACKETS_COLOR= "matchingBracketsColor"; //$NON-NLS-1$ /** Preference key for highlighting current line */ public final static String CURRENT_LINE= "currentLine"; //$NON-NLS-1$ /** Preference key for highlight color of current line */ public final static String CURRENT_LINE_COLOR= "currentLineColor"; //$NON-NLS-1$ /** Preference key for showing print marging ruler */ public final static String PRINT_MARGIN= "printMargin"; //$NON-NLS-1$ /** Preference key for print margin ruler color */ public final static String PRINT_MARGIN_COLOR= "printMarginColor"; //$NON-NLS-1$ /** Preference key for print margin ruler column */ public final static String PRINT_MARGIN_COLUMN= "printMarginColumn"; //$NON-NLS-1$ /** Preference key for inserting spaces rather than tabs */ public final static String SPACES_FOR_TABS= JavaSourceViewerConfiguration.SPACES_FOR_TABS; /** Preference key for problem indication */ public final static String PROBLEM_INDICATION= "problemIndication"; //$NON-NLS-1$ /** Preference key for problem highlight color */ public final static String PROBLEM_INDICATION_COLOR= "problemIndicationColor"; //$NON-NLS-1$ /** Preference key for linked position color */ public final static String LINKED_POSITION_COLOR= "linkedPositionColor"; //$NON-NLS-1$ /** Preference key for shwoing the overview ruler */ public final static String OVERVIEW_RULER= "overviewRuler"; //$NON-NLS-1$ /** The status line clearer */ protected ISelectionChangedListener fStatusLineClearer; /** The editor's save policy */ protected ISavePolicy fSavePolicy; /** Listener to annotation model changes that updates the error tick in the tab image */ private JavaEditorErrorTickUpdater fJavaEditorErrorTickUpdater; /** The editor's paint manager */ private PaintManager fPaintManager; /** The editor's bracket painter */ private BracketPainter fBracketPainter; /** The editor's line painter */ private LinePainter fLinePainter; /** The editor's print margin ruler painter */ private PrintMarginPainter fPrintMarginPainter; /** The editor's problem painter */ private ProblemPainter fProblemPainter; /** The editor's tab converter */ private TabConverter fTabConverter; /** History for structure select action */ private SelectionHistory fSelectionHistory; /** The preference property change listener for java core. */ private IPropertyChangeListener fPropertyChangeListener= new PropertyChangeListener(); /** The remembered java element */ private IJavaElement fRememberedElement; /** The remembered selection */ private ITextSelection fRememberedSelection; /** The remembered java element offset */ private int fRememberedElementOffset; /** The standard action groups added to the menu */ private GenerateActionGroup fGenerateActionGroup; private CompositeActionGroup fContextMenuGroup; /** * Creates a new compilation unit editor. */ public CompilationUnitEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getCompilationUnitDocumentProvider()); setEditorContextMenuId("#CompilationUnitEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#CompilationUnitRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#CompilationUnitOutlinerContext"); //$NON-NLS-1$ // don't set help contextId, we install our own help context fSavePolicy= null; fJavaEditorErrorTickUpdater= new JavaEditorErrorTickUpdater(this); } /* * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "CorrectionAssistProposal.", this, JavaCorrectionSourceViewer.CORRECTIONASSIST_PROPOSALS); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CORRECTION_ASSIST_PROPOSALS); setAction("CorrectionAssistProposal", action); //$NON-NLS-1$ action= new ContentAssistAction(JavaEditorMessages.getResourceBundle(), "ContentAssistProposal.", this); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS); setAction("ContentAssistProposal", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ContentAssistContextInformation.", this, ISourceViewer.CONTENTASSIST_CONTEXT_INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_CONTEXT_INFORMATION); setAction("ContentAssistContextInformation", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Comment.", this, ITextOperationTarget.PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.COMMENT); setAction("Comment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Uncomment.", this, ITextOperationTarget.STRIP_PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.UNCOMMENT); setAction("Uncomment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Format.", this, ISourceViewer.FORMAT); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.FORMAT); setAction("Format", action); //$NON-NLS-1$ markAsStateDependentAction("CorrectionAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistContextInformation", true); //$NON-NLS-1$ markAsStateDependentAction("Comment", true); //$NON-NLS-1$ markAsStateDependentAction("Uncomment", true); //$NON-NLS-1$ markAsStateDependentAction("Format", true); //$NON-NLS-1$ fSelectionHistory= new SelectionHistory(this); action= new StructureSelectEnclosingAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_ENCLOSING); setAction(StructureSelectionAction.ENCLOSING, action); action= new StructureSelectNextAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_NEXT); setAction(StructureSelectionAction.NEXT, action); action= new StructureSelectPreviousAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_PREVIOUS); setAction(StructureSelectionAction.PREVIOUS, action); StructureSelectHistoryAction historyAction= new StructureSelectHistoryAction(this, fSelectionHistory); historyAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_LAST); setAction(StructureSelectionAction.HISTORY, historyAction); fSelectionHistory.setHistoryAction(historyAction); fGenerateActionGroup= new GenerateActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); ActionGroup rg= new RefactorActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); fActionGroups.addGroup(rg); fActionGroups.addGroup(fGenerateActionGroup); // We have to keep the context menu group separate to have better control over positioning fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] { fGenerateActionGroup, rg, new LocalHistoryActionGroup(this, ITextEditorActionConstants.GROUP_EDIT)}); } /* * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { return getElementAt(offset, true); } /** * Returns the most narrow element including the given offset. If <code>reconcile</code> * is <code>true</code> the editor's input element is reconciled in advance. If it is * <code>false</code> this method only returns a result if the editor's input element * does not need to be reconciled. * * @param offset the offset included by the retrieved element * @param reconcile <code>true</code> if working copy should be reconciled */ protected IJavaElement getElementAt(int offset, boolean reconcile) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { if (reconcile) { synchronized (unit) { unit.reconcile(); } return unit.getElementAt(offset); } else if (unit.isConsistent()) return unit.getElementAt(offset); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { try { return EditorUtility.getWorkingCopy(element, true); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } return null; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow(IMenuManager) */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Format"); //$NON-NLS-1$ ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /* * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); page.setInput(manager.getWorkingCopy(input)); } } /* * @see AbstractTextEditor#performSaveOperation(WorkspaceModifyOperation, IProgressMonitor) */ protected void performSaveOperation(WorkspaceModifyOperation operation, IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(fSavePolicy); } try { super.performSaveOperation(operation, progressMonitor); } finally { if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(null); } } } /* * @see AbstractTextEditor#doSave(IProgressMonitor) */ public void doSave(IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p == null) return; if (p.isDeleted(getEditorInput())) { if (isSaveAsAllowed()) { /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed Behavior to make sure that if called inside a regular save (because * of deletion of input element) there is a way to report back to the caller. */ performSaveAs(progressMonitor); } else { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Shell shell= getSite().getShell(); MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title1"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message1")); //$NON-NLS-1$ //$NON-NLS-2$ } } else { setStatusLineErrorMessage(null); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { performSaveOperation(createSaveOperation(false), progressMonitor); } } else performSaveOperation(createSaveOperation(false), progressMonitor); } } /** * Jumps to the error next according to the given direction. */ public void gotoError(boolean forward) { ISelectionProvider provider= getSelectionProvider(); if (fStatusLineClearer != null) { provider.removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } ITextSelection s= (ITextSelection) provider.getSelection(); Position errorPosition= new Position(0, 0); IProblemAnnotation nextError= getNextError(s.getOffset(), forward, errorPosition); if (nextError != null) { IMarker marker= null; if (nextError instanceof MarkerAnnotation) marker= ((MarkerAnnotation) nextError).getMarker(); else { Iterator e= nextError.getOverlaidIterator(); if (e != null) { while (e.hasNext()) { Object o= e.next(); if (o instanceof MarkerAnnotation) { marker= ((MarkerAnnotation) o).getMarker(); break; } } } } if (marker != null) { IWorkbenchPage page= getSite().getPage(); IViewPart view= view= page.findView("org.eclipse.ui.views.TaskList"); //$NON-NLS-1$ if (view instanceof TaskList) { StructuredSelection ss= new StructuredSelection(marker); ((TaskList) view).setSelection(ss, true); } } selectAndReveal(errorPosition.getOffset(), errorPosition.getLength()); setStatusLineErrorMessage(nextError.getMessage()); } else { setStatusLineErrorMessage(null); } } /** * Sets the given message as error message to this editor's status line. * @param msg message to be set */ protected void setStatusLineErrorMessage(String msg) { // set error message getStatusLineManager().setErrorMessage(msg); // install message remover if (msg == null || msg.trim().length() == 0) { if (fStatusLineClearer != null) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } } else if (fStatusLineClearer == null) { fStatusLineClearer= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; getStatusLineManager().setErrorMessage(null); } }; getSelectionProvider().addSelectionChangedListener(fStatusLineClearer); } } private IProblemAnnotation getNextError(int offset, boolean forward, Position errorPosition) { IProblemAnnotation nextError= null; Position nextErrorPosition= null; IDocument document= getDocumentProvider().getDocument(getEditorInput()); int endOfDocument= document.getLength(); int distance= 0; IAnnotationModel model= getDocumentProvider().getAnnotationModel(getEditorInput()); Iterator e= new ProblemAnnotationIterator(model, false); while (e.hasNext()) { IProblemAnnotation a= (IProblemAnnotation) e.next(); if (a.hasOverlay() || !a.isProblem()) continue; Position p= model.getPosition((Annotation) a); if (!p.includes(offset)) { int currentDistance= 0; if (forward) { currentDistance= p.getOffset() - offset; if (currentDistance < 0) currentDistance= endOfDocument - offset + p.getOffset(); } else { currentDistance= offset - p.getOffset(); if (currentDistance < 0) currentDistance= offset + endOfDocument - p.getOffset(); } if (nextError == null || currentDistance < distance) { distance= currentDistance; nextError= a; nextErrorPosition= p; } } } if (nextErrorPosition != null) { errorPosition.setOffset(nextErrorPosition.getOffset()); errorPosition.setLength(nextErrorPosition.getLength()); } return nextError; } /* * @see AbstractTextEditor#isSaveAsAllowed() */ public boolean isSaveAsAllowed() { return true; } /** * The compilation unit editor implementation of this <code>AbstractTextEditor</code> * method asks the user for the workspace path of a file resource and saves the document * there. See http://dev.eclipse.org/bugs/show_bug.cgi?id=6295 */ protected void performSaveAs(IProgressMonitor progressMonitor) { Shell shell= getSite().getShell(); SaveAsDialog dialog= new SaveAsDialog(shell); dialog.create(); IEditorInput input = getEditorInput(); IFile original= (input instanceof IFileEditorInput) ? ((IFileEditorInput) input).getFile() : null; if (original != null) dialog.setOriginalFile(original); IDocumentProvider provider= getDocumentProvider(); if (provider.isDeleted(input) && original != null) { String message= JavaEditorMessages.getFormattedString("CompilationUnitEditor.warning.save.delete", new Object[] { original.getName() }); //$NON-NLS-1$ dialog.setMessage(message, IMessageProvider.WARNING); } if (dialog.open() == Dialog.CANCEL) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IPath filePath= dialog.getResult(); if (filePath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IWorkspace workspace= ResourcesPlugin.getWorkspace(); IFile file= workspace.getRoot().getFile(filePath); final IEditorInput newInput= new FileEditorInput(file); WorkspaceModifyOperation op= new WorkspaceModifyOperation() { public void execute(final IProgressMonitor monitor) throws CoreException { getDocumentProvider().saveDocument(monitor, newInput, getDocumentProvider().getDocument(getEditorInput()), true); } }; boolean success= false; try { getDocumentProvider().aboutToChange(newInput); new ProgressMonitorDialog(shell).run(false, true, op); success= true; } catch (InterruptedException x) { } catch (InvocationTargetException x) { Throwable t= x.getTargetException(); if (t instanceof CoreException) { CoreException cx= (CoreException) t; ErrorDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title2"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message2"), cx.getStatus()); //$NON-NLS-1$ //$NON-NLS-2$ } else { MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title3"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message3") + t.getMessage()); //$NON-NLS-1$ //$NON-NLS-2$ } } finally { getDocumentProvider().changed(newInput); if (success) setInput(newInput); } if (progressMonitor != null) progressMonitor.setCanceled(!success); } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); configureTabConverter(); } private void startBracketHighlighting() { if (fBracketPainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fBracketPainter= new BracketPainter(sourceViewer); fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); fPaintManager.addPainter(fBracketPainter); } } private void stopBracketHighlighting() { if (fBracketPainter != null) { fPaintManager.removePainter(fBracketPainter); fBracketPainter.deactivate(true); fBracketPainter.dispose(); fBracketPainter= null; } } private boolean isBracketHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(MATCHING_BRACKETS); } private void startLineHighlighting() { if (fLinePainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fLinePainter= new LinePainter(sourceViewer); fLinePainter.setHighlightColor(getColor(CURRENT_LINE_COLOR)); fPaintManager.addPainter(fLinePainter); } } private void stopLineHighlighting() { if (fLinePainter != null) { fPaintManager.removePainter(fLinePainter); fLinePainter.deactivate(true); fLinePainter.dispose(); fLinePainter= null; } } private boolean isLineHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(CURRENT_LINE); } private void showPrintMargin() { if (fPrintMarginPainter == null) { fPrintMarginPainter= new PrintMarginPainter(getSourceViewer()); fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); fPaintManager.addPainter(fPrintMarginPainter); } } private void hidePrintMargin() { if (fPrintMarginPainter != null) { fPaintManager.removePainter(fPrintMarginPainter); fPrintMarginPainter.deactivate(true); fPrintMarginPainter.dispose(); fPrintMarginPainter= null; } } private boolean isPrintMarginVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PRINT_MARGIN); } private void startProblemIndication() { if (fProblemPainter == null) { fProblemPainter= new ProblemPainter(this, getSourceViewer()); fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); fPaintManager.addPainter(fProblemPainter); } } private void stopProblemIndication() { if (fProblemPainter != null) { fPaintManager.removePainter(fProblemPainter); fProblemPainter.deactivate(true); fProblemPainter.dispose(); fProblemPainter= null; } } private boolean isProblemIndicationEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PROBLEM_INDICATION); } private void configureTabConverter() { if (fTabConverter != null) { IDocumentProvider provider= getDocumentProvider(); if (provider instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cup= (CompilationUnitDocumentProvider) provider; fTabConverter.setLineTracker(cup.createLineTracker(getEditorInput())); } } } private int getTabSize() { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); return preferences.getInt(CODE_FORMATTER_TAB_SIZE); } private void startTabConversion() { if (fTabConverter == null) { fTabConverter= new TabConverter(); configureTabConverter(); fTabConverter.setNumberOfSpacesPerTab(getTabSize()); AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.addTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); } } private void stopTabConversion() { if (fTabConverter != null) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.removeTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); fTabConverter= null; } } private boolean isTabConversionEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(SPACES_FOR_TABS); } private void showOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.showOverviewRuler(); } private void hideOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.hideOverviewRuler(); } private boolean isOverviewRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(OVERVIEW_RULER); } private Color getColor(String key) { RGB rgb= PreferenceConverter.getColor(getPreferenceStore(), key); return getColor(rgb); } private Color getColor(RGB rgb) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.getColorManager().getColor(rgb); } /* * @see AbstractTextEditor#dispose() */ public void dispose() { if (fPropertyChangeListener != null) { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.removePropertyChangeListener(fPropertyChangeListener); fPropertyChangeListener= null; } if (fJavaEditorErrorTickUpdater != null) { fJavaEditorErrorTickUpdater.dispose(); fJavaEditorErrorTickUpdater= null; } if (fSelectionHistory != null) fSelectionHistory.dispose(); stopBracketHighlighting(); stopLineHighlighting(); if (fPaintManager != null) { fPaintManager.dispose(); fPaintManager= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /* * @see AbstractTextEditor#createPartControl(Composite) */ public void createPartControl(Composite parent) { super.createPartControl(parent); fPaintManager= new PaintManager(getSourceViewer()); if (isBracketHighlightingEnabled()) startBracketHighlighting(); if (isLineHighlightingEnabled()) startLineHighlighting(); if (isPrintMarginVisible()) showPrintMargin(); if (isProblemIndicationEnabled()) startProblemIndication(); if (isTabConversionEnabled()) startTabConversion(); if (isOverviewRulerVisible()) showOverviewRuler(); Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.addPropertyChangeListener(fPropertyChangeListener); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (SPACES_FOR_TABS.equals(p)) { if (isTabConversionEnabled()) startTabConversion(); else stopTabConversion(); return; } if (MATCHING_BRACKETS.equals(p)) { if (isBracketHighlightingEnabled()) startBracketHighlighting(); else stopBracketHighlighting(); return; } if (MATCHING_BRACKETS_COLOR.equals(p)) { if (fBracketPainter != null) fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); return; } if (CURRENT_LINE.equals(p)) { if (isLineHighlightingEnabled()) startLineHighlighting(); else stopLineHighlighting(); return; } if (CURRENT_LINE_COLOR.equals(p)) { if (fLinePainter != null) { stopLineHighlighting(); startLineHighlighting(); } return; } if (PRINT_MARGIN.equals(p)) { if (isPrintMarginVisible()) showPrintMargin(); else hidePrintMargin(); return; } if (PRINT_MARGIN_COLOR.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); return; } if (PRINT_MARGIN_COLUMN.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); return; } if (PROBLEM_INDICATION.equals(p)) { if (isProblemIndicationEnabled()) startProblemIndication(); else stopProblemIndication(); return; } if (PROBLEM_INDICATION_COLOR.equals(p)) { if (fProblemPainter != null) fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); return; } if (OVERVIEW_RULER.equals(p)) { if (isOverviewRulerVisible()) showOverviewRuler(); else hideOverviewRuler(); return; } IContentAssistant c= asv.getContentAssistant(); if (c instanceof ContentAssistant) ContentAssistPreference.changeConfiguration((ContentAssistant) c, getPreferenceStore(), event); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Handles a property change event describing a change * of the java core's preferences and updates the preference * related editor properties. * * @param event the property change event */ protected void handlePreferencePropertyChanged(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (CODE_FORMATTER_TAB_SIZE.equals(p)) { asv.updateIndentationPrefixes(); if (fTabConverter != null) fTabConverter.setNumberOfSpacesPerTab(getTabSize()); } } } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { String p= event.getProperty(); boolean affects=MATCHING_BRACKETS_COLOR.equals(p) || CURRENT_LINE_COLOR.equals(p) || PROBLEM_INDICATION_COLOR.equals(p); return affects ? affects : super.affectsTextPresentation(event); } /* * @see JavaEditor#createJavaSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return new AdaptedSourceViewer(parent, ruler, styles); } /* * @see JavaEditor#synchronizeOutlinePageSelection() */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret, false); ISourceReference reference= getSourceReference(element, caret); if (reference != null) fOutlinePage.select(reference); } private ISourceReference getSourceReference(IJavaElement element, int offset) { if ( !(element instanceof ISourceReference)) return null; if (element.getElementType() == IJavaElement.IMPORT_DECLARATION) { IImportDeclaration declaration= (IImportDeclaration) element; IImportContainer container= (IImportContainer) declaration.getParent(); ISourceRange srcRange= null; try { srcRange= container.getSourceRange(); } catch (JavaModelException e) { } if (srcRange != null && srcRange.getOffset() == offset) return container; } return (ISourceReference) element; } /* * @see IReconcilingParticipant#reconciled() */ public void reconciled() { if (!JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) { Shell shell= getSite().getShell(); if (shell != null && !shell.isDisposed()) { shell.getDisplay().asyncExec(new Runnable() { public void run() { synchronizeOutlinePageSelection(); } }); } } } protected void updateStateDependentActions() { super.updateStateDependentActions(); fGenerateActionGroup.editorStateChanged(); } /** * Returns the updated java element for the old java element. */ private IJavaElement findElement(IJavaElement element) { if (element == null) return null; IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { synchronized (unit) { unit.reconcile(); } IJavaElement[] findings= unit.findElements(element); if (findings != null && findings.length > 0) return findings[0]; } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /** * Returns the offset of the given Java element. */ private int getOffset(IJavaElement element) { if (element instanceof ISourceReference) { ISourceReference sr= (ISourceReference) element; try { ISourceRange srcRange= sr.getSourceRange(); if (srcRange != null) return srcRange.getOffset(); } catch (JavaModelException e) { } } return -1; } /* * @see AbstractTextEditor#rememberSelection() */ protected void rememberSelection() { ISelectionProvider sp= getSelectionProvider(); fRememberedSelection= (sp == null ? null : (ITextSelection) sp.getSelection()); if (fRememberedSelection != null) { fRememberedElement= getElementAt(fRememberedSelection.getOffset(), true); fRememberedElementOffset= getOffset(fRememberedElement); } } /* * @see AbstractTextEditor#restoreSelection() */ protected void restoreSelection() { try { if (getSourceViewer() == null || fRememberedSelection == null) return; IJavaElement newElement= findElement(fRememberedElement); int newOffset= getOffset(newElement); int offset= (newOffset > -1 && fRememberedElementOffset > -1) ? newOffset - fRememberedElementOffset : 0; selectAndReveal(offset + fRememberedSelection.getOffset(), fRememberedSelection.getLength()); } finally { fRememberedSelection= null; fRememberedElement= null; fRememberedElementOffset= -1; } } /* * @see AbstractTextEditor#canHandleMove(IEditorInput, IEditorInput) */ protected boolean canHandleMove(IEditorInput originalElement, IEditorInput movedElement) { String oldExtension= ""; //$NON-NLS-1$ if (originalElement instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) originalElement).getFile(); if (file != null) { String ext= file.getFileExtension(); if (ext != null) oldExtension= ext; } } String newExtension= ""; //$NON-NLS-1$ if (movedElement instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) movedElement).getFile(); if (file != null) newExtension= file.getFileExtension(); } return oldExtension.equals(newExtension); } }
20,181
Bug 20181 TVT2: Mnemonic doesn't work in Java Editor prefs
Japanese TVT tester found a non-functional mnemonic in Preferences>Java>Editor on the Syntax tab. Pressing Alt+B doesn't activate the bold checkbox. Build F2 NL fragments generated on 6/11 Window>Preferences Select Java Select Editor Click on Syntax tab press Alt+B... checkbox does not work.
resolved fixed
3304ed1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-18T18:49:38Z
2002-06-13T14:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.Map; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.layout.RowLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Group; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.List; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.ui.texteditor.WorkbenchChainedTextFontFieldEditor; import org.eclipse.jdt.ui.text.IJavaColorConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; /* * The page for setting the editor options. */ public class JavaEditorPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { public static final String BOLD= "_bold"; //$NON-NLS-1$ public static final String PREF_SHOW_TEMP_PROBLEMS= "JavaEditor.ShowTemporaryProblem"; //$NON-NLS-1$ public static final String PREF_SYNC_OUTLINE_ON_CURSOR_MOVE= "JavaEditor.SyncOutlineOnCursorMove"; //$NON-NLS-1$ public final OverlayPreferenceStore.OverlayKey[] fKeys= new OverlayPreferenceStore.OverlayKey[] { new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_KEYWORD + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_STRING), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_STRING + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_DEFAULT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_KEYWORD + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_TAG), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_TAG + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_LINK), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_LINK + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_DEFAULT + BOLD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.MATCHING_BRACKETS_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.MATCHING_BRACKETS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.CURRENT_LINE_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.CURRENT_LINE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.PRINT_MARGIN_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, CompilationUnitEditor.PRINT_MARGIN_COLUMN), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.PRINT_MARGIN), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.LINKED_POSITION_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.PROBLEM_INDICATION_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.PROBLEM_INDICATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.OVERVIEW_RULER), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, JavaEditor.LINE_NUMBER_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, JavaEditor.LINE_NUMBER_RULER), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.SPACES_FOR_TABS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOACTIVATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, ContentAssistPreference.AUTOACTIVATION_DELAY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOINSERT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ORDER_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.CASE_SENSITIVITY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ADD_IMPORT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.FILL_METHOD_ARGUMENTS) }; private final String[][] fSyntaxColorListModel= new String[][] { { JavaUIMessages.getString("JavaEditorPreferencePage.multiLineComment"), IJavaColorConstants.JAVA_MULTI_LINE_COMMENT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.singleLineComment"), IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.keywords"), IJavaColorConstants.JAVA_KEYWORD }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.strings"), IJavaColorConstants.JAVA_STRING }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.others"), IJavaColorConstants.JAVA_DEFAULT }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocKeywords"), IJavaColorConstants.JAVADOC_KEYWORD }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocHtmlTags"), IJavaColorConstants.JAVADOC_TAG }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocLinks"), IJavaColorConstants.JAVADOC_LINK }, //$NON-NLS-1$ { JavaUIMessages.getString("JavaEditorPreferencePage.javaDocOthers"), IJavaColorConstants.JAVADOC_DEFAULT } //$NON-NLS-1$ }; private final String[][] fAppearanceColorListModel= new String[][] { {JavaUIMessages.getString("JavaEditorPreferencePage.lineNumberForegroundColor"), JavaEditor.LINE_NUMBER_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.matchingBracketsHighlightColor2"), CompilationUnitEditor.MATCHING_BRACKETS_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.currentLineHighlighColor"), CompilationUnitEditor.CURRENT_LINE_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.problemsHighlightColor"), CompilationUnitEditor.PROBLEM_INDICATION_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.printMarginColor2"), CompilationUnitEditor.PRINT_MARGIN_COLOR}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.findScopeColor2"), AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaEditorPreferencePage.linkedPositionColor2"), CompilationUnitEditor.LINKED_POSITION_COLOR}, //$NON-NLS-1$ }; private OverlayPreferenceStore fOverlayStore; private JavaTextTools fJavaTextTools; private Map fColorButtons= new HashMap(); private SelectionListener fColorButtonListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { ColorEditor editor= (ColorEditor) e.widget.getData(); PreferenceConverter.setValue(fOverlayStore, (String) fColorButtons.get(editor), editor.getColorValue()); } }; private Map fCheckBoxes= new HashMap(); private SelectionListener fCheckBoxListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { Button button= (Button) e.widget; fOverlayStore.setValue((String) fCheckBoxes.get(button), button.getSelection()); } }; private Map fTextFields= new HashMap(); private ModifyListener fTextFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { Text text= (Text) e.widget; fOverlayStore.setValue((String) fTextFields.get(text), text.getText()); } }; private ArrayList fNumberFields= new ArrayList(); private ModifyListener fNumberFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { numberFieldChanged((Text) e.widget); } }; private WorkbenchChainedTextFontFieldEditor fFontEditor; private List fSyntaxColorList; private List fAppearanceColorList; private ColorEditor fSyntaxForegroundColorEditor; private ColorEditor fAppearanceForegroundColorEditor; private ColorEditor fBackgroundColorEditor; private Button fBackgroundDefaultRadioButton; private Button fBackgroundCustomRadioButton; private Button fBackgroundColorButton; private Button fBoldCheckBox; private SourceViewer fPreviewViewer; private Color fBackgroundColor; private Control fAutoInsertDelayText; private Control fAutoInsertJavaTriggerText; private Control fAutoInsertJavaDocTriggerText; public JavaEditorPreferencePage() { setDescription(JavaUIMessages.getString("JavaEditorPreferencePage.description")); //$NON-NLS-1$ setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); fOverlayStore= new OverlayPreferenceStore(getPreferenceStore(), fKeys); } public static void initDefaults(IPreferenceStore store) { /* * Ensure that the display is accessed only in the UI thread. * Ensure that there are no side effects of switching the thread. */ final RGB[] rgbs= new RGB[3]; final Display display= Display.getDefault(); display.syncExec(new Runnable() { public void run() { Color c= display.getSystemColor(SWT.COLOR_GRAY); rgbs[0]= c.getRGB(); c= display.getSystemColor(SWT.COLOR_LIST_FOREGROUND); rgbs[1]= c.getRGB(); c= display.getSystemColor(SWT.COLOR_LIST_BACKGROUND); rgbs[2]= c.getRGB(); } }); /* * Go on in whatever thread this is. */ store.setDefault(CompilationUnitEditor.MATCHING_BRACKETS, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.MATCHING_BRACKETS_COLOR, rgbs[0]); store.setDefault(CompilationUnitEditor.CURRENT_LINE, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.CURRENT_LINE_COLOR, new RGB(225, 235, 224)); store.setDefault(CompilationUnitEditor.PRINT_MARGIN, false); store.setDefault(CompilationUnitEditor.PRINT_MARGIN_COLUMN, 80); PreferenceConverter.setDefault(store, CompilationUnitEditor.PRINT_MARGIN_COLOR, new RGB(176, 180 , 185)); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE, new RGB(185, 176 , 180)); store.setDefault(CompilationUnitEditor.PROBLEM_INDICATION, true); PreferenceConverter.setDefault(store, CompilationUnitEditor.PROBLEM_INDICATION_COLOR, new RGB(255, 0 , 128)); store.setDefault(JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS, true); store.setDefault(JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE, false); store.setDefault(CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS, true); store.setDefault(CompilationUnitEditor.OVERVIEW_RULER, true); store.setDefault(JavaEditor.LINE_NUMBER_RULER, false); PreferenceConverter.setDefault(store, JavaEditor.LINE_NUMBER_COLOR, new RGB(0, 0, 0)); WorkbenchChainedTextFontFieldEditor.startPropagate(store, JFaceResources.TEXT_FONT); PreferenceConverter.setDefault(store, CompilationUnitEditor.LINKED_POSITION_COLOR, new RGB(0, 200 , 100)); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND, rgbs[1]); store.setDefault(AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT, true); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, rgbs[2]); store.setDefault(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT, true); store.setDefault(JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 4); store.setDefault(CompilationUnitEditor.SPACES_FOR_TABS, false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_KEYWORD, new RGB(127, 0, 85)); store.setDefault(IJavaColorConstants.JAVA_KEYWORD + "_bold", true); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_STRING, new RGB(42, 0, 255)); store.setDefault(IJavaColorConstants.JAVA_STRING + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_DEFAULT, new RGB(0, 0, 0)); store.setDefault(IJavaColorConstants.JAVA_DEFAULT + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_KEYWORD, new RGB(127, 159, 191)); store.setDefault(IJavaColorConstants.JAVADOC_KEYWORD + "_bold", true); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_TAG, new RGB(127, 127, 159)); store.setDefault(IJavaColorConstants.JAVADOC_TAG + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_LINK, new RGB(63, 63, 191)); store.setDefault(IJavaColorConstants.JAVADOC_LINK + "_bold", false); //$NON-NLS-1$ PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_DEFAULT, new RGB(63, 95, 191)); store.setDefault(IJavaColorConstants.JAVADOC_DEFAULT + "_bold", false); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.AUTOACTIVATION, true); store.setDefault(ContentAssistPreference.AUTOACTIVATION_DELAY, 500); store.setDefault(ContentAssistPreference.AUTOINSERT, true); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_FOREGROUND, new RGB(0, 0, 0)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_FOREGROUND, new RGB(0, 0, 0)); store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, "."); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, "@"); //$NON-NLS-1$ store.setDefault(ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, true); store.setDefault(ContentAssistPreference.CASE_SENSITIVITY, false); store.setDefault(ContentAssistPreference.ORDER_PROPOSALS, false); store.setDefault(ContentAssistPreference.ADD_IMPORT, true); store.setDefault(ContentAssistPreference.FILL_METHOD_ARGUMENTS, false); } /* * @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /* * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), IJavaHelpContextIds.JAVA_EDITOR_PREFERENCE_PAGE); } private void handleSyntaxColorListSelection() { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fSyntaxForegroundColorEditor.setColorValue(rgb); fBoldCheckBox.setSelection(fOverlayStore.getBoolean(key + BOLD)); } private void handleAppearanceColorListSelection() { int i= fAppearanceColorList.getSelectionIndex(); String key= fAppearanceColorListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fAppearanceForegroundColorEditor.setColorValue(rgb); } private Control createSyntaxPage(Composite parent) { Composite colorComposite= new Composite(parent, SWT.NULL); colorComposite.setLayout(new GridLayout()); Group backgroundComposite= new Group(colorComposite, SWT.SHADOW_ETCHED_IN); backgroundComposite.setLayout(new RowLayout()); backgroundComposite.setText(JavaUIMessages.getString("JavaEditorPreferencePage.backgroundColor"));//$NON-NLS-1$ SelectionListener backgroundSelectionListener= new SelectionListener() { public void widgetSelected(SelectionEvent e) { boolean custom= fBackgroundCustomRadioButton.getSelection(); fBackgroundColorButton.setEnabled(custom); fOverlayStore.setValue(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT, !custom); } public void widgetDefaultSelected(SelectionEvent e) {} }; fBackgroundDefaultRadioButton= new Button(backgroundComposite, SWT.RADIO | SWT.LEFT); fBackgroundDefaultRadioButton.setText(JavaUIMessages.getString("JavaEditorPreferencePage.systemDefault")); //$NON-NLS-1$ fBackgroundDefaultRadioButton.addSelectionListener(backgroundSelectionListener); fBackgroundCustomRadioButton= new Button(backgroundComposite, SWT.RADIO | SWT.LEFT); fBackgroundCustomRadioButton.setText(JavaUIMessages.getString("JavaEditorPreferencePage.custom")); //$NON-NLS-1$ fBackgroundCustomRadioButton.addSelectionListener(backgroundSelectionListener); fBackgroundColorEditor= new ColorEditor(backgroundComposite); fBackgroundColorButton= fBackgroundColorEditor.getButton(); Label label= new Label(colorComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.foreground")); //$NON-NLS-1$ label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Composite editorComposite= new Composite(colorComposite, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); GridData gd= new GridData(GridData.FILL_BOTH); editorComposite.setLayoutData(gd); fSyntaxColorList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL | SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fSyntaxColorList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NONE); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); label= new Label(stylesComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.color")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fSyntaxForegroundColorEditor= new ColorEditor(stylesComposite); Button foregroundColorButton= fSyntaxForegroundColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; foregroundColorButton.setLayoutData(gd); label= new Label(stylesComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.bold")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fBoldCheckBox= new Button(stylesComposite, SWT.CHECK); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; fBoldCheckBox.setLayoutData(gd); label= new Label(colorComposite, SWT.LEFT); label.setText(JavaUIMessages.getString("JavaEditorPreferencePage.preview")); //$NON-NLS-1$ label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Control previewer= createPreviewer(colorComposite); gd= new GridData(GridData.FILL_BOTH); gd.widthHint= convertWidthInCharsToPixels(20); gd.heightHint= convertHeightInCharsToPixels(5); previewer.setLayoutData(gd); fSyntaxColorList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleSyntaxColorListSelection(); } }); foregroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fSyntaxForegroundColorEditor.getColorValue()); } }); fBackgroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { PreferenceConverter.setValue(fOverlayStore, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, fBackgroundColorEditor.getColorValue()); } }); fBoldCheckBox.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fSyntaxColorList.getSelectionIndex(); String key= fSyntaxColorListModel[i][1]; fOverlayStore.setValue(key + BOLD, fBoldCheckBox.getSelection()); } }); return colorComposite; } private Control createPreviewer(Composite parent) { fJavaTextTools= new JavaTextTools(fOverlayStore); fPreviewViewer= new SourceViewer(parent, null, SWT.V_SCROLL | SWT.H_SCROLL | SWT.BORDER); fPreviewViewer.configure(new JavaSourceViewerConfiguration(fJavaTextTools, null)); fPreviewViewer.getTextWidget().setFont(JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT)); fPreviewViewer.setEditable(false); initializeViewerColors(fPreviewViewer); String content= loadPreviewContentFromFile("ColorSettingPreviewCode.txt"); //$NON-NLS-1$ IDocument document= new Document(content); IDocumentPartitioner partitioner= fJavaTextTools.createDocumentPartitioner(); partitioner.connect(document); document.setDocumentPartitioner(partitioner); fPreviewViewer.setDocument(document); fOverlayStore.addPropertyChangeListener(new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { String p= event.getProperty(); if (p.equals(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND) || p.equals(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT)) { initializeViewerColors(fPreviewViewer); } fPreviewViewer.invalidateTextPresentation(); } }); return fPreviewViewer.getControl(); } /** * Initializes the given viewer's colors. * * @param viewer the viewer to be initialized */ private void initializeViewerColors(ISourceViewer viewer) { IPreferenceStore store= fOverlayStore; if (store != null) { StyledText styledText= viewer.getTextWidget(); // ---------- background color ---------------------- Color color= store.getBoolean(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT) ? null : createColor(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, styledText.getDisplay()); styledText.setBackground(color); if (fBackgroundColor != null) fBackgroundColor.dispose(); fBackgroundColor= color; } } /** * Creates a color from the information stored in the given preference store. * Returns <code>null</code> if there is no such information available. */ private Color createColor(IPreferenceStore store, String key, Display display) { RGB rgb= null; if (store.contains(key)) { if (store.isDefault(key)) rgb= PreferenceConverter.getDefaultColor(store, key); else rgb= PreferenceConverter.getColor(store, key); if (rgb != null) return new Color(display, rgb); } return null; } // sets enabled flag for a control and all its sub-tree private static void setEnabled(Control control, boolean enable) { control.setEnabled(enable); if (control instanceof Composite) { Composite composite= (Composite) control; Control[] children= composite.getChildren(); for (int i= 0; i < children.length; i++) setEnabled(children[i], enable); } } private Control createAppearancePage(Composite parent) { Composite behaviorComposite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; behaviorComposite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.textFont"); //$NON-NLS-1$ addTextFontEditor(behaviorComposite, label, AbstractTextEditor.PREFERENCE_FONT); label= JavaUIMessages.getString("JavaEditorPreferencePage.displayedTabWidth"); //$NON-NLS-1$ addTextField(behaviorComposite, label, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 3, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.printMarginColumn"); //$NON-NLS-1$ addTextField(behaviorComposite, label, CompilationUnitEditor.PRINT_MARGIN_COLUMN, 3, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.insertSpaceForTabs"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.SPACES_FOR_TABS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.synchronizeOnCursor"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, JavaEditorPreferencePage.PREF_SYNC_OUTLINE_ON_CURSOR_MOVE, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showOverviewRuler"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.OVERVIEW_RULER, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showLineNumbers"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, JavaEditor.LINE_NUMBER_RULER, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightMatchingBrackets"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.MATCHING_BRACKETS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightCurrentLine"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.CURRENT_LINE, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showPrintMargin"); //$NON-NLS-1$ addCheckBox(behaviorComposite, label, CompilationUnitEditor.PRINT_MARGIN, 0); Label l= new Label(behaviorComposite, SWT.LEFT ); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; gd.heightHint= convertHeightInCharsToPixels(1) / 2; l.setLayoutData(gd); l= new Label(behaviorComposite, SWT.LEFT); l.setText(JavaUIMessages.getString("JavaEditorPreferencePage.appearanceOptions")); //$NON-NLS-1$ gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; l.setLayoutData(gd); Composite editorComposite= new Composite(behaviorComposite, SWT.NONE); layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.FILL_VERTICAL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); fAppearanceColorList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL | SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fAppearanceColorList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NONE); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); l= new Label(stylesComposite, SWT.LEFT); l.setText(JavaUIMessages.getString("JavaEditorPreferencePage.color")); //$NON-NLS-1$ gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; l.setLayoutData(gd); fAppearanceForegroundColorEditor= new ColorEditor(stylesComposite); Button foregroundColorButton= fAppearanceForegroundColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; foregroundColorButton.setLayoutData(gd); fAppearanceColorList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleAppearanceColorListSelection(); } }); foregroundColorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fAppearanceColorList.getSelectionIndex(); String key= fAppearanceColorListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fAppearanceForegroundColorEditor.getColorValue()); } }); return behaviorComposite; } private Control createProblemIndicationPage(Composite parent) { Composite composite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; composite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.showProblemsBeforeCompiling"); //$NON-NLS-1$ addCheckBox(composite, label, CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.highlightProblems"); //$NON-NLS-1$ addCheckBox(composite, label, CompilationUnitEditor.PROBLEM_INDICATION, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showQuickFixables"); //$NON-NLS-1$ addCheckBox(composite, label, JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS, 0); Label note= new Label(composite, SWT.NONE); note.setText(JavaUIMessages.getString("JavaEditorPreferencePage.updatesOnNextChangeIinEditor.label")); //$NON-NLS-1$ GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan= 2; note.setLayoutData(gd); return composite; } private Control createContentAssistPage(Composite parent) { Composite contentAssistComposite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; contentAssistComposite.setLayout(layout); String label= JavaUIMessages.getString("JavaEditorPreferencePage.insertSingleProposalsAutomatically"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOINSERT, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.showOnlyProposalsVisibleInTheInvocationContext"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.presentProposalsInAlphabeticalOrder"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.ORDER_PROPOSALS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.automaticallyAddImportInsteadOfQualifiedName"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.ADD_IMPORT, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.fillArgumentNamesOnMethodCompletion"); //$NON-NLS-1$ addCheckBox(contentAssistComposite, label, ContentAssistPreference.FILL_METHOD_ARGUMENTS, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.enableAutoActivation"); //$NON-NLS-1$ final Button autoactivation= addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationDelay"); //$NON-NLS-1$ fAutoInsertDelayText= addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_DELAY, 4, 0, true); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationTriggersForJava"); //$NON-NLS-1$ fAutoInsertJavaTriggerText= addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, 4, 0, false); label= JavaUIMessages.getString("JavaEditorPreferencePage.autoActivationTriggersForJavaDoc"); //$NON-NLS-1$ fAutoInsertJavaDocTriggerText= addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, 4, 0, false); label= JavaUIMessages.getString("JavaEditorPreferencePage.backgroundForCompletionProposals"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_BACKGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.foregroundForCompletionProposals"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_FOREGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.backgroundForMethodParameters"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_BACKGROUND, 0); label= JavaUIMessages.getString("JavaEditorPreferencePage.foregroundForMethodParameters"); //$NON-NLS-1$ addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_FOREGROUND, 0); autoactivation.addSelectionListener(new SelectionAdapter(){ public void widgetSelected(SelectionEvent e) { updateAutoactivationControls(); } }); return contentAssistComposite; } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { fOverlayStore.load(); fOverlayStore.start(); TabFolder folder= new TabFolder(parent, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); TabItem item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.general")); //$NON-NLS-1$ item.setControl(createAppearancePage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.colors")); //$NON-NLS-1$ item.setControl(createSyntaxPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.codeAssist")); //$NON-NLS-1$ item.setControl(createContentAssistPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("JavaEditorPreferencePage.problemIndicationTab.title")); //$NON-NLS-1$ item.setControl(createProblemIndicationPage(folder)); initialize(); return folder; } private void initialize() { fFontEditor.setPreferenceStore(getPreferenceStore()); fFontEditor.setPreferencePage(this); fFontEditor.load(); initializeFields(); for (int i= 0; i < fSyntaxColorListModel.length; i++) fSyntaxColorList.add(fSyntaxColorListModel[i][0]); fSyntaxColorList.getDisplay().asyncExec(new Runnable() { public void run() { fSyntaxColorList.select(0); handleSyntaxColorListSelection(); } }); for (int i= 0; i < fAppearanceColorListModel.length; i++) fAppearanceColorList.add(fAppearanceColorListModel[i][0]); fAppearanceColorList.getDisplay().asyncExec(new Runnable() { public void run() { fAppearanceColorList.select(0); handleAppearanceColorListSelection(); } }); } private void initializeFields() { Iterator e= fColorButtons.keySet().iterator(); while (e.hasNext()) { ColorEditor c= (ColorEditor) e.next(); String key= (String) fColorButtons.get(c); RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); c.setColorValue(rgb); } e= fCheckBoxes.keySet().iterator(); while (e.hasNext()) { Button b= (Button) e.next(); String key= (String) fCheckBoxes.get(b); b.setSelection(fOverlayStore.getBoolean(key)); } e= fTextFields.keySet().iterator(); while (e.hasNext()) { Text t= (Text) e.next(); String key= (String) fTextFields.get(t); t.setText(fOverlayStore.getString(key)); } RGB rgb= PreferenceConverter.getColor(fOverlayStore, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND); fBackgroundColorEditor.setColorValue(rgb); boolean default_= fOverlayStore.getBoolean(AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT); fBackgroundDefaultRadioButton.setSelection(default_); fBackgroundCustomRadioButton.setSelection(!default_); fBackgroundColorButton.setEnabled(!default_); updateAutoactivationControls(); } private void updateAutoactivationControls() { boolean autoactivation= fOverlayStore.getBoolean(ContentAssistPreference.AUTOACTIVATION); fAutoInsertDelayText.setEnabled(autoactivation); fAutoInsertJavaTriggerText.setEnabled(autoactivation); fAutoInsertJavaDocTriggerText.setEnabled(autoactivation); } /* * @see PreferencePage#performOk() */ public boolean performOk() { fFontEditor.store(); fOverlayStore.propagate(); JavaPlugin.getDefault().savePluginPreferences(); return true; } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fFontEditor.loadDefault(); fOverlayStore.loadDefaults(); initializeFields(); handleSyntaxColorListSelection(); handleAppearanceColorListSelection(); super.performDefaults(); fPreviewViewer.invalidateTextPresentation(); } /* * @see DialogPage#dispose() */ public void dispose() { if (fJavaTextTools != null) { fJavaTextTools= null; } fFontEditor.setPreferencePage(null); fFontEditor.setPreferenceStore(null); if (fOverlayStore != null) { fOverlayStore.stop(); fOverlayStore= null; } super.dispose(); } private Control addColorButton(Composite composite, String label, String key, int indentation) { Label labelControl= new Label(composite, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); ColorEditor editor= new ColorEditor(composite); Button button= editor.getButton(); button.setData(editor); gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); button.setLayoutData(gd); button.addSelectionListener(fColorButtonListener); fColorButtons.put(editor, key); return composite; } private Button addCheckBox(Composite parent, String label, String key, int indentation) { Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; gd.horizontalSpan= 2; checkBox.setLayoutData(gd); checkBox.addSelectionListener(fCheckBoxListener); fCheckBoxes.put(checkBox, key); return checkBox; } private Control addTextField(Composite composite, String label, String key, int textLimit, int indentation, boolean isNumber) { Label labelControl= new Label(composite, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); Text textControl= new Text(composite, SWT.BORDER | SWT.SINGLE); gd= new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.widthHint= convertWidthInCharsToPixels(textLimit + 1); textControl.setLayoutData(gd); textControl.setTextLimit(textLimit); fTextFields.put(textControl, key); if (isNumber) { fNumberFields.add(textControl); textControl.addModifyListener(fNumberFieldListener); } else { textControl.addModifyListener(fTextFieldListener); } return textControl; } private void addTextFontEditor(Composite parent, String label, String key) { Composite editorComposite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 3; editorComposite.setLayout(layout); fFontEditor= new WorkbenchChainedTextFontFieldEditor(key, label, editorComposite); fFontEditor.setChangeButtonText(JavaUIMessages.getString("JavaEditorPreferencePage.change")); //$NON-NLS-1$ GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); } private String loadPreviewContentFromFile(String filename) { String line; String separator= System.getProperty("line.separator"); //$NON-NLS-1$ StringBuffer buffer= new StringBuffer(512); BufferedReader reader= null; try { reader= new BufferedReader(new InputStreamReader(getClass().getResourceAsStream(filename))); while ((line= reader.readLine()) != null) { buffer.append(line); buffer.append(separator); } } catch (IOException io) { JavaPlugin.log(io); } finally { if (reader != null) { try { reader.close(); } catch (IOException e) {} } } return buffer.toString(); } private void numberFieldChanged(Text textControl) { String number= textControl.getText(); IStatus status= validatePositiveNumber(number); if (!status.matches(IStatus.ERROR)) fOverlayStore.setValue((String) fTextFields.get(textControl), number); updateStatus(status); } private IStatus validatePositiveNumber(String number) { StatusInfo status= new StatusInfo(); if (number.length() == 0) { status.setError(JavaUIMessages.getString("JavaEditorPreferencePage.empty_input")); //$NON-NLS-1$ } else { try { int value= Integer.parseInt(number); if (value < 0) status.setError(JavaUIMessages.getFormattedString("JavaEditorPreferencePage.invalid_input", number)); //$NON-NLS-1$ } catch (NumberFormatException e) { status.setError(JavaUIMessages.getFormattedString("JavaEditorPreferencePage.invalid_input", number)); //$NON-NLS-1$ } } return status; } private void updateStatus(IStatus status) { if (!status.matches(IStatus.ERROR)) { for (int i= 0; i < fNumberFields.size(); i++) { Text text= (Text) fNumberFields.get(i); IStatus s= validatePositiveNumber(text.getText()); status= StatusUtil.getMoreSevere(s, status); } } setValid(!status.matches(IStatus.ERROR)); StatusUtil.applyToStatusLine(this, status); } public static boolean showTempProblems() { return JavaPlugin.getDefault().getPreferenceStore().getBoolean(JavaEditorPreferencePage.PREF_SHOW_TEMP_PROBLEMS); } static public boolean synchronizeOutlineOnCursorMove() { return JavaPlugin.getDefault().getPreferenceStore().getBoolean(PREF_SYNC_OUTLINE_ON_CURSOR_MOVE); } }
20,441
Bug 20441 TVT2: Word order of the title needs to be changed
The following description is from a Japanese tester working on build F2. She has tried looking for the string where "Externalize Strings in <source file name>" would be built and has been unable to find it, as have I. Her problem is that in Japanese the title needs to read in a different order than it does. Unless she can change the order, it just won't make sense in Japanese. Could we either be told where to find the proper key to switch the order, or have one made if it doesn't exist? I will also attach a screencap. This bug opened in response to TPRS ID=112 From the Java perspective, expand the com.ibm.wsweducation.dialogs package to expose DialogsPlugin.java in the Packages view. Double-click DialogsPlugin.java to edit it if it is not already open for editing. Make another change, but do not save the file. In the Packages view, select the com.ibm.wsweducation.dialogs project or package. On the menu bar, click on Source -> Find Strings to Externalize... Select the DialogsPlugin.java file and click on Externalize... Then Click on OK. 'Externalize Strings' opens. Title of this window is 'Externalize Strings in 'DialogsPlugin.java'. I found 'in' in NLSUIMessage.properties file, but even if I translate it, word order is incorrect for Japanese. In this case, order should be: 'DialogsPlugin.jave' 'in' 'Externalize Strings' in Japanese. We need complete sentence with variables.
resolved fixed
7d74fca
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T08:56:46Z
2002-06-17T13:20:00Z
org.eclipse.jdt.ui/ui
20,441
Bug 20441 TVT2: Word order of the title needs to be changed
The following description is from a Japanese tester working on build F2. She has tried looking for the string where "Externalize Strings in <source file name>" would be built and has been unable to find it, as have I. Her problem is that in Japanese the title needs to read in a different order than it does. Unless she can change the order, it just won't make sense in Japanese. Could we either be told where to find the proper key to switch the order, or have one made if it doesn't exist? I will also attach a screencap. This bug opened in response to TPRS ID=112 From the Java perspective, expand the com.ibm.wsweducation.dialogs package to expose DialogsPlugin.java in the Packages view. Double-click DialogsPlugin.java to edit it if it is not already open for editing. Make another change, but do not save the file. In the Packages view, select the com.ibm.wsweducation.dialogs project or package. On the menu bar, click on Source -> Find Strings to Externalize... Select the DialogsPlugin.java file and click on Externalize... Then Click on OK. 'Externalize Strings' opens. Title of this window is 'Externalize Strings in 'DialogsPlugin.java'. I found 'in' in NLSUIMessage.properties file, but even if I translate it, word order is incorrect for Japanese. In this case, order should be: 'DialogsPlugin.jave' 'in' 'Externalize Strings' in Japanese. We need complete sentence with variables.
resolved fixed
7d74fca
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T08:56:46Z
2002-06-17T13:20:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/nls/ExternalizeWizard.java
20,595
Bug 20595 Preference listeners should use equals, not ==
null
resolved fixed
76d5255
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T09:50:16Z
2002-06-18T19:53:20Z
org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/TestRunnerViewPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.junit.ui; import java.net.MalformedURLException; import java.text.NumberFormat; import java.util.Enumeration; import java.util.HashMap; import java.util.Map; import java.util.Vector; import org.eclipse.core.runtime.CoreException; import org.eclipse.debug.core.*; import org.eclipse.debug.core.ILaunchManager; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CLabel; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.SashForm; import org.eclipse.swt.custom.ViewForm; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.ProgressBar; import org.eclipse.swt.widgets.ToolBar; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.ToolBarManager; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorActionBarContributor; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.PartInitException; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.EditorActionBarContributor; import org.eclipse.ui.part.ViewPart; import org.eclipse.jdt.core.ElementChangedEvent; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IElementChangedListener; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaElementDelta; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.junit.runner.ITestRunListener; /** * A ViewPart that shows the results of a test run. */ public class TestRunnerViewPart extends ViewPart implements ITestRunListener, IPropertyChangeListener { public static final String NAME= "org.eclipse.jdt.junit.ResultView"; //$NON-NLS-1$ /** * Number of executed tests during a test run */ protected int fExecutedTests; /** * Number of errors during this test run */ protected int fErrors; /** * Number of failures during this test run */ protected int fFailures; /** * Number of tests run */ private int fTestCount; /** * Map storing TestInfos for each executed test keyed by * the test name. */ private Map fTestInfos = new HashMap(); /** * The first failure of a test run. Used to reveal the * first failed tests at the end of a run. */ private TestRunInfo fFirstFailure; private ProgressBar fProgressBar; private ProgressImages fProgressImages; private Image fViewImage; private CounterPanel fCounterPanel; private boolean fShowOnErrorOnly= false; /** * The view that shows the stack trace of a failure */ private FailureTraceView fFailureView; /** * The collection of ITestRunViews */ private Vector fTestRunViews = new Vector(); /** * The currently active run view */ private ITestRunView fActiveRunView; /** * Is the UI disposed */ private boolean fIsDisposed= false; /** * The launched test type */ private IType fTestType; /** * The launcher that has started the test */ private String fLaunchMode; private ILaunch fLastLaunch= null; /** * The client side of the remote test runner */ private RemoteTestRunnerClient fTestRunnerClient; final Image fStackViewIcon= TestRunnerViewPart.createImage("cview16/stackframe.gif");//$NON-NLS-1$ final Image fTestRunOKIcon= TestRunnerViewPart.createImage("cview16/junitsucc.gif"); //$NON-NLS-1$ final Image fTestRunFailIcon= TestRunnerViewPart.createImage("cview16/juniterr.gif"); //$NON-NLS-1$ final Image fTestRunOKDirtyIcon= TestRunnerViewPart.createImage("cview16/junitsuccq.gif"); //$NON-NLS-1$ final Image fTestRunFailDirtyIcon= TestRunnerViewPart.createImage("cview16/juniterrq.gif"); //$NON-NLS-1$ Image fOriginalViewImage= null; IElementChangedListener fDirtyListener= null; private class StopAction extends Action{ public StopAction() { setText(JUnitMessages.getString("TestRunnerViewPart.stopaction.text"));//$NON-NLS-1$ setToolTipText(JUnitMessages.getString("TestRunnerViewPart.stopaction.tooltip"));//$NON-NLS-1$ setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/stop.gif")); //$NON-NLS-1$ setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("clcl16/stop.gif")); //$NON-NLS-1$ setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/stop.gif")); //$NON-NLS-1$ } public void run() { stopTest(); } } private class RerunAction extends Action{ public RerunAction() { setText(JUnitMessages.getString("TestRunnerViewPart.rerunaction.label")); //$NON-NLS-1$ setToolTipText(JUnitMessages.getString("TestRunnerViewPart.rerunaction.tooltip")); //$NON-NLS-1$ setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/relaunch.gif")); //$NON-NLS-1$ setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("clcl16/relaunch.gif")); //$NON-NLS-1$ setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/relaunch.gif")); //$NON-NLS-1$ } public void run(){ rerunTestRun(); } } /** * Listen for for modifications to Java elements */ private class DirtyListener implements IElementChangedListener { public void elementChanged(ElementChangedEvent event) { processDelta(event.getDelta()); } private boolean processDelta(IJavaElementDelta delta) { int kind= delta.getKind(); int details= delta.getFlags(); int type= delta.getElement().getElementType(); switch (type) { // Consider containers for class files. case IJavaElement.JAVA_MODEL: case IJavaElement.JAVA_PROJECT: case IJavaElement.PACKAGE_FRAGMENT_ROOT: case IJavaElement.PACKAGE_FRAGMENT: // If we did some different than changing a child we flush the the undo / redo stack. if (kind != IJavaElementDelta.CHANGED || details != IJavaElementDelta.F_CHILDREN) { codeHasChanged(); return false; } break; case IJavaElement.COMPILATION_UNIT: ICompilationUnit unit= (ICompilationUnit)delta.getElement(); // If we change a working copy we do nothing if (unit.isWorkingCopy()) { // Don't examine children of a working copy but keep processing siblings. return true; } else { codeHasChanged(); return false; } case IJavaElement.CLASS_FILE: // Don't examine children of a class file but keep on examining siblings. return true; default: codeHasChanged(); return false; } IJavaElementDelta[] affectedChildren= delta.getAffectedChildren(); if (affectedChildren == null) return true; for (int i= 0; i < affectedChildren.length; i++) { if (!processDelta(affectedChildren[i])) return false; } return true; } } /** * Stops the currently running test and shuts down the RemoteTestRunner */ public void stopTest() { if (fTestRunnerClient != null) fTestRunnerClient.stopTest(); } /** * Stops the currently running test and shuts down the RemoteTestRunner */ public void rerunTestRun() { if (fLastLaunch != null && fLastLaunch.getLaunchConfiguration() != null) { try { fLastLaunch.getLaunchConfiguration().launch(fLastLaunch.getLaunchMode(), null); } catch (CoreException e) { ErrorDialog.openError(getSite().getShell(), JUnitMessages.getString("TestRunnerViewPart.error.cannotrerun"), e.getMessage(), e.getStatus() //$NON-NLS-1$ ); } } } /* * @see ITestRunListener#testRunStarted(testCount) */ public void testRunStarted(final int testCount){ reset(testCount); fShowOnErrorOnly= JUnitPreferencePage.getShowOnErrorOnly(); fExecutedTests++; } /* * @see ITestRunListener#testRunEnded */ public void testRunEnded(long elapsedTime){ fExecutedTests--; String msg= JUnitMessages.getFormattedString("TestRunnerViewPart.message.finish", elapsedTimeAsString(elapsedTime)); //$NON-NLS-1$ postInfo(msg); postAsyncRunnable(new Runnable() { public void run() { if(isDisposed()) return; if (fFirstFailure != null) { fActiveRunView.setSelectedTest(fFirstFailure.fTestName); handleTestSelected(fFirstFailure.fTestName); } updateViewIcon(); if (fDirtyListener == null) { fDirtyListener= new DirtyListener(); JavaCore.addElementChangedListener(fDirtyListener); } } }); } private void updateViewIcon() { if (fErrors+fFailures > 0) fViewImage= fTestRunFailIcon; else fViewImage= fTestRunOKIcon; firePropertyChange(IWorkbenchPart.PROP_TITLE); } private String elapsedTimeAsString(long runTime) { return NumberFormat.getInstance().format((double)runTime/1000); } /* * @see ITestRunListener#testRunStopped */ public void testRunStopped(final long elapsedTime) { String msg= JUnitMessages.getFormattedString("TestRunnerViewPart.message.stopped", elapsedTimeAsString(elapsedTime)); //$NON-NLS-1$ postInfo(msg); postAsyncRunnable(new Runnable() { public void run() { if(isDisposed()) return; resetViewIcon(); } }); } private void resetViewIcon() { fViewImage= fOriginalViewImage; firePropertyChange(IWorkbenchPart.PROP_TITLE); } /* * @see ITestRunListener#testRunTerminated */ public void testRunTerminated() { String msg= JUnitMessages.getString("TestRunnerViewPart.message.terminated"); //$NON-NLS-1$ showMessage(msg); } private void showMessage(String msg) { showInformation(msg); postError(msg); } /* * @see ITestRunListener#testStarted */ public void testStarted(String testName) { // reveal the part when the first test starts if (!fShowOnErrorOnly && fExecutedTests == 1) postShowTestResultsView(); postInfo(JUnitMessages.getFormattedString("TestRunnerViewPart.message.started", testName)); //$NON-NLS-1$ TestRunInfo testInfo= getTestInfo(testName); if (testInfo == null) fTestInfos.put(testName, new TestRunInfo(testName)); } /* * @see ITestRunListener#testEnded */ public void testEnded(String testName){ postEndTest(testName); fExecutedTests++; } /* * @see ITestRunListener#testFailed */ public void testFailed(int status, String testName, String trace){ TestRunInfo testInfo= getTestInfo(testName); if (testInfo == null) { testInfo= new TestRunInfo(testName); fTestInfos.put(testName, testInfo); } testInfo.fTrace= trace; testInfo.fStatus= status; if (status == ITestRunListener.STATUS_ERROR) fErrors++; else fFailures++; if (fFirstFailure == null) fFirstFailure= testInfo; // show the view on the first error only if (fShowOnErrorOnly && (fErrors + fFailures == 1)) postShowTestResultsView(); } /* * @see ITestRunListener#testReran */ public void testReran(String className, String testName, int status, String trace) { if (status == ITestRunListener.STATUS_ERROR) { String msg= JUnitMessages.getFormattedString("TestRunnerViewPart.message.error", new String[]{testName, className}); //$NON-NLS-1$ postError(msg); } else if (status == ITestRunListener.STATUS_FAILURE) { String msg= JUnitMessages.getFormattedString("TestRunnerViewPart.message.failure", new String[]{testName, className}); //$NON-NLS-1$ postError(msg); } else { String msg= JUnitMessages.getFormattedString("TestRunnerViewPart.message.success", new String[]{testName, className}); //$NON-NLS-1$ postInfo(msg); } String test= testName+"("+className+")"; //$NON-NLS-1$ //$NON-NLS-2$ TestRunInfo info= getTestInfo(test); updateTest(info, status); if (info.fTrace == null || !info.fTrace.equals(trace)) { info.fTrace= trace; showFailure(info.fTrace); } } private void updateTest(TestRunInfo info, final int status) { if (status == info.fStatus) return; if (info.fStatus == ITestRunListener.STATUS_OK) { if (status == ITestRunListener.STATUS_FAILURE) fFailures++; else if (status == ITestRunListener.STATUS_ERROR) fErrors++; } else if (info.fStatus == ITestRunListener.STATUS_ERROR) { if (status == ITestRunListener.STATUS_OK) fErrors--; else if (status == ITestRunListener.STATUS_FAILURE) { fErrors--; fFailures++; } } else if (info.fStatus == ITestRunListener.STATUS_FAILURE) { if (status == ITestRunListener.STATUS_OK) fFailures--; else if (status == ITestRunListener.STATUS_ERROR) { fFailures--; fErrors++; } } info.fStatus= status; final TestRunInfo finalInfo= info; postAsyncRunnable(new Runnable() { public void run() { refreshCounters(); for (Enumeration e= fTestRunViews.elements(); e.hasMoreElements();) { ITestRunView v= (ITestRunView) e.nextElement(); v.testStatusChanged(finalInfo); } } }); } /* * @see ITestRunListener#testTreeEntry */ public void testTreeEntry(final String treeEntry){ postSyncRunnable(new Runnable() { public void run() { if(isDisposed()) return; for (Enumeration e= fTestRunViews.elements(); e.hasMoreElements();) { ITestRunView v= (ITestRunView) e.nextElement(); v.newTreeEntry(treeEntry); } } }); } public void startTestRunListening(IType type, int port, ILaunch launch) { fTestType= type; fLaunchMode= launch.getLaunchMode(); aboutToLaunch(); if (fTestRunnerClient != null) { stopTest(); } fTestRunnerClient= new RemoteTestRunnerClient(); fTestRunnerClient.startListening(this, port); fLastLaunch= launch; String title= JUnitMessages.getFormattedString("TestRunnerViewPart.title", fTestType.getElementName()); //$NON-NLS-1$ setTitle(title); setTitleToolTip(fTestType.getFullyQualifiedName()); } private void aboutToLaunch() { String msg= JUnitMessages.getString("TestRunnerViewPart.message.launching"); //$NON-NLS-1$ showInformation(msg); postInfo(msg); fViewImage= fOriginalViewImage; firePropertyChange(IWorkbenchPart.PROP_TITLE); } public void rerunTest(String className, String testName) { if (fTestRunnerClient != null && fTestRunnerClient.isRunning() && ILaunchManager.DEBUG_MODE.equals(fLaunchMode)) fTestRunnerClient.rerunTest(className, testName); else { MessageDialog.openInformation(getSite().getShell(), JUnitMessages.getString("TestRunnerViewPart.cannotrerun.title"), //$NON-NLS-1$ JUnitMessages.getString("TestRunnerViewPart.cannotrerurn.message") //$NON-NLS-1$ ); } } public synchronized void dispose(){ fIsDisposed= true; stopTest(); fProgressImages.dispose(); JUnitPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this); fTestRunOKIcon.dispose(); fTestRunFailIcon.dispose(); fStackViewIcon.dispose(); fTestRunOKDirtyIcon.dispose(); fTestRunFailDirtyIcon.dispose(); } private void start(final int total) { resetProgressBar(total); fCounterPanel.setTotal(total); fCounterPanel.setRunValue(0); } private void resetProgressBar(final int total) { fProgressBar.setMinimum(0); fProgressBar.setSelection(0); fProgressBar.setForeground(getDisplay().getSystemColor(SWT.COLOR_GREEN)); fProgressBar.setMaximum(total); } private void postSyncRunnable(Runnable r) { if (!isDisposed()) getDisplay().syncExec(r); } private void postAsyncRunnable(Runnable r) { if (!isDisposed()) getDisplay().asyncExec(r); } private void aboutToStart() { postSyncRunnable(new Runnable() { public void run() { if (!isDisposed()) { for (Enumeration e= fTestRunViews.elements(); e.hasMoreElements();) { ITestRunView v= (ITestRunView) e.nextElement(); v.aboutToStart(); } } } }); } private void postEndTest(final String testName) { postSyncRunnable(new Runnable() { public void run() { if(isDisposed()) return; handleEndTest(); for (Enumeration e= fTestRunViews.elements(); e.hasMoreElements();) { ITestRunView v= (ITestRunView) e.nextElement(); v.endTest(testName); } } }); } private void handleEndTest() { refreshCounters(); updateProgressColor(fFailures+fErrors); fProgressBar.setSelection(fProgressBar.getSelection() + 1); if (fShowOnErrorOnly) { Image progress= fProgressImages.getImage(fExecutedTests, fTestCount, fErrors, fFailures); if (progress != fViewImage) { fViewImage= progress; firePropertyChange(IWorkbenchPart.PROP_TITLE); } } } private void updateProgressColor(int failures) { if (failures > 0) fProgressBar.setForeground(getDisplay().getSystemColor(SWT.COLOR_RED)); else fProgressBar.setForeground(getDisplay().getSystemColor(SWT.COLOR_GREEN)); } private void refreshCounters() { fCounterPanel.setErrorValue(fErrors); fCounterPanel.setFailureValue(fFailures); fCounterPanel.setRunValue(fExecutedTests); updateProgressColor(fErrors + fFailures); } protected void postShowTestResultsView() { postAsyncRunnable(new Runnable() { public void run() { if (isDisposed()) return; showTestResultsView(); } }); } public void showTestResultsView() { IWorkbenchWindow window= getSite().getWorkbenchWindow(); IWorkbenchPage page= window.getActivePage(); TestRunnerViewPart testRunner= null; if (page != null) { try { // show the result view testRunner= (TestRunnerViewPart)page.findView(TestRunnerViewPart.NAME); if(testRunner == null) { IWorkbenchPart activePart= page.getActivePart(); testRunner= (TestRunnerViewPart)page.showView(TestRunnerViewPart.NAME); //restore focus stolen by the creation of the console page.activate(activePart); } else { page.bringToTop(testRunner); } } catch (PartInitException pie) { JUnitPlugin.log(pie); } } } protected void postInfo(final String message) { postAsyncRunnable(new Runnable() { public void run() { if (isDisposed()) return; getStatusLine().setErrorMessage(null); getStatusLine().setMessage(message); } }); } protected void postError(final String message) { postAsyncRunnable(new Runnable() { public void run() { if (isDisposed()) return; getStatusLine().setMessage(null); getStatusLine().setErrorMessage(message); } }); } protected void showInformation(final String info){ postSyncRunnable(new Runnable() { public void run() { if (!isDisposed()) fFailureView.setInformation(info); } }); } private CTabFolder createTestRunViews(Composite parent) { CTabFolder tabFolder= new CTabFolder(parent, SWT.TOP); GridData gridData= new GridData(); tabFolder.setLayoutData(new GridData(GridData.FILL_BOTH | GridData.GRAB_VERTICAL)); ITestRunView failureRunView= new FailureRunView(tabFolder, this); ITestRunView testHierarchyRunView= new HierarchyRunView(tabFolder, this); fTestRunViews.addElement(failureRunView); fTestRunViews.addElement(testHierarchyRunView); tabFolder.setSelection(0); fActiveRunView= (ITestRunView)fTestRunViews.firstElement(); tabFolder.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { testViewChanged(event); } }); return tabFolder; } private void testViewChanged(SelectionEvent event) { for (Enumeration e= fTestRunViews.elements(); e.hasMoreElements();) { ITestRunView v= (ITestRunView) e.nextElement(); if (((CTabFolder) event.widget).getSelection().getText() == v.getName()){ v.setSelectedTest(fActiveRunView.getTestName()); fActiveRunView= v; fActiveRunView.activate(); } } } private SashForm createSashForm(Composite parent) { SashForm sashForm= new SashForm(parent, SWT.VERTICAL); ViewForm top= new ViewForm(sashForm, SWT.NONE); CTabFolder tabFolder= createTestRunViews(top); tabFolder.setLayoutData(new TabFolderLayout()); top.setContent(tabFolder); ViewForm bottom= new ViewForm(sashForm, SWT.NONE); ToolBar failureToolBar= new ToolBar(bottom, SWT.FLAT | SWT.WRAP); bottom.setTopCenter(failureToolBar); fFailureView= new FailureTraceView(bottom, this); bottom.setContent(fFailureView.getComposite()); CLabel label= new CLabel(bottom, SWT.NONE); label.setText(JUnitMessages.getString("TestRunnerViewPart.label.failure")); //$NON-NLS-1$ label.setImage(fStackViewIcon); bottom.setTopLeft(label); Composite traceView= fFailureView.getComposite(); // fill the failure trace viewer toolbar ToolBarManager failureToolBarmanager= new ToolBarManager(failureToolBar); failureToolBarmanager.add(new EnableStackFilterAction(fFailureView)); failureToolBarmanager.update(true); sashForm.setWeights(new int[]{50, 50}); return sashForm; } private void reset(final int testCount) { postAsyncRunnable(new Runnable() { public void run() { if (isDisposed()) return; fCounterPanel.reset(); fFailureView.clear(); clearStatus(); start(testCount); } }); fExecutedTests= 0; fFailures= 0; fErrors= 0; fTestCount= testCount; aboutToStart(); fTestInfos.clear(); fFirstFailure= null; } private void clearStatus() { getStatusLine().setMessage(null); getStatusLine().setErrorMessage(null); } public void setFocus() { if (fActiveRunView != null) fActiveRunView.setFocus(); } public void createPartControl(Composite parent) { GridLayout gridLayout= new GridLayout(); gridLayout.marginWidth= 0; parent.setLayout(gridLayout); IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager toolBar= actionBars.getToolBarManager(); toolBar.add(new StopAction()); toolBar.add(new RerunAction()); actionBars.updateActionBars(); Composite counterPanel= createProgressCountPanel(parent); counterPanel.setLayoutData(new GridData(GridData.GRAB_HORIZONTAL | GridData.HORIZONTAL_ALIGN_FILL)); SashForm sashForm= createSashForm(parent); sashForm.setLayoutData(new GridData(GridData.FILL_BOTH)); actionBars.setGlobalActionHandler( IWorkbenchActionConstants.COPY, new CopyTraceAction(fFailureView)); JUnitPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(this); fOriginalViewImage= getTitleImage(); fProgressImages= new ProgressImages(); WorkbenchHelp.setHelp(parent, IJUnitHelpContextIds.RESULTS_VIEW); } private IStatusLineManager getStatusLine() { // we want to show messages globally hence we // have to go throgh the active part IViewSite site= getViewSite(); IWorkbenchPage page= site.getPage(); IWorkbenchPart activePart= page.getActivePart(); if (activePart instanceof IViewPart) { IViewPart activeViewPart= (IViewPart)activePart; IViewSite activeViewSite= activeViewPart.getViewSite(); return activeViewSite.getActionBars().getStatusLineManager(); } if (activePart instanceof IEditorPart) { IEditorPart activeEditorPart= (IEditorPart)activePart; IEditorActionBarContributor contributor= activeEditorPart.getEditorSite().getActionBarContributor(); if (contributor instanceof EditorActionBarContributor) return ((EditorActionBarContributor) contributor).getActionBars().getStatusLineManager(); } // no active part return getViewSite().getActionBars().getStatusLineManager(); } private Composite createProgressCountPanel(Composite parent) { Composite composite= new Composite(parent, SWT.NONE); composite.setLayout(new GridLayout()); fProgressBar = new ProgressBar(composite, SWT.HORIZONTAL); fProgressBar.setLayoutData( new GridData(GridData.GRAB_HORIZONTAL | GridData.HORIZONTAL_ALIGN_FILL)); fCounterPanel = new CounterPanel(composite); fCounterPanel.setLayoutData( new GridData(GridData.GRAB_HORIZONTAL | GridData.HORIZONTAL_ALIGN_FILL)); return composite; } public TestRunInfo getTestInfo(String testName) { return (TestRunInfo) fTestInfos.get(testName); } public void handleTestSelected(String testName) { TestRunInfo testInfo= getTestInfo(testName); if (testInfo == null) { showFailure(""); //$NON-NLS-1$ } else { showFailure(testInfo.fTrace); } } private void showFailure(final String failure) { postSyncRunnable(new Runnable() { public void run() { if (!isDisposed()) fFailureView.showFailure(failure); } }); } public IJavaProject getLaunchedProject() { return fTestType.getJavaProject(); } protected static Image createImage(String path) { try { ImageDescriptor id= ImageDescriptor.createFromURL(JUnitPlugin.makeIconFileURL(path)); return id.createImage(); } catch (MalformedURLException e) { // fall through } return null; } private boolean isDisposed() { return fIsDisposed || fCounterPanel.isDisposed(); } private Display getDisplay() { return fCounterPanel.getDisplay(); } /** * @see IWorkbenchPart#getTitleImage() */ public Image getTitleImage() { if (fOriginalViewImage == null) fOriginalViewImage= super.getTitleImage(); if (fViewImage == null) return super.getTitleImage(); return fViewImage; } public void propertyChange(PropertyChangeEvent event) { if (isDisposed()) return; if (event.getProperty() == JUnitPreferencePage.SHOW_ON_ERROR_ONLY) { if (!JUnitPreferencePage.getShowOnErrorOnly()) { fViewImage= fOriginalViewImage; firePropertyChange(IWorkbenchPart.PROP_TITLE); } } } void codeHasChanged() { postAsyncRunnable(new Runnable() { public void run() { if (isDisposed()) return; if (fDirtyListener != null) { JavaCore.removeElementChangedListener(fDirtyListener); fDirtyListener= null; } if (fViewImage == fTestRunOKIcon) fViewImage= fTestRunOKDirtyIcon; else if (fViewImage == fTestRunFailIcon) fViewImage= fTestRunFailDirtyIcon; firePropertyChange(IWorkbenchPart.PROP_TITLE); } }); } }
20,595
Bug 20595 Preference listeners should use equals, not ==
null
resolved fixed
76d5255
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T09:50:16Z
2002-06-18T19:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial implementation ******************************************************************************/ package org.eclipse.jdt.internal.ui.packageview; import java.util.ArrayList; import java.util.Iterator; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.IPath; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.DragSourceEvent; import org.eclipse.swt.dnd.FileTransfer; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Tree; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IOpenListener; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITreeViewerListener; import org.eclipse.jface.viewers.OpenEvent; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TreeExpansionEvent; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.ui.PartInitException; import org.eclipse.ui.PlatformUI; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.part.ISetSelectionTarget; import org.eclipse.ui.part.ResourceTransfer; import org.eclipse.ui.part.ViewPart; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IPackagesViewPart; import org.eclipse.jdt.ui.JavaElementSorter; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.StandardJavaElementContentProvider; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.ResourceTransferDragAdapter; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.JavaUIHelp; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; /** * The ViewPart for the ProjectExplorer. It listens to part activation events. * When selection linking with the editor is enabled the view selection tracks * the active editor page. Similarly when a resource is selected in the packages * view the corresponding editor is activated. */ public class PackageExplorerPart extends ViewPart implements ISetSelectionTarget, IMenuListener, IPackagesViewPart, IPropertyChangeListener { public final static String VIEW_ID= JavaUI.ID_PACKAGES; // Persistance tags. static final String TAG_SELECTION= "selection"; //$NON-NLS-1$ static final String TAG_EXPANDED= "expanded"; //$NON-NLS-1$ static final String TAG_ELEMENT= "element"; //$NON-NLS-1$ static final String TAG_PATH= "path"; //$NON-NLS-1$ static final String TAG_VERTICAL_POSITION= "verticalPosition"; //$NON-NLS-1$ static final String TAG_HORIZONTAL_POSITION= "horizontalPosition"; //$NON-NLS-1$ static final String TAG_FILTERS = "filters"; //$NON-NLS-1$ static final String TAG_FILTER = "filter"; //$NON-NLS-1$ static final String TAG_SHOWLIBRARIES = "showLibraries"; //$NON-NLS-1$ static final String TAG_SHOWBINARIES = "showBinaries"; //$NON-NLS-1$ private PackageExplorerActionGroup fActionSet; private ProblemTreeViewer fViewer; private Menu fContextMenu; private IMemento fMemento; private ISelectionChangedListener fSelectionListener; private String fWorkingSetName; private IPartListener fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { if (part instanceof IEditorPart) editorActivated((IEditorPart) part); } public void partBroughtToTop(IWorkbenchPart part) { } public void partClosed(IWorkbenchPart part) { } public void partDeactivated(IWorkbenchPart part) { } public void partOpened(IWorkbenchPart part) { } }; private ITreeViewerListener fExpansionListener= new ITreeViewerListener() { public void treeCollapsed(TreeExpansionEvent event) { } public void treeExpanded(TreeExpansionEvent event) { Object element= event.getElement(); if (element instanceof ICompilationUnit || element instanceof IClassFile) expandMainType(element); } }; public PackageExplorerPart() { } /* (non-Javadoc) * Method declared on IViewPart. */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /** * Initializes the default preferences */ public static void initDefaults(IPreferenceStore store) { store.setDefault(TAG_SHOWLIBRARIES, true); store.setDefault(TAG_SHOWBINARIES, true); } /** * Returns the package explorer part of the active perspective. If * there isn't any package explorer part <code>null</code> is returned. */ public static PackageExplorerPart getFromActivePerspective() { IViewPart view= JavaPlugin.getActivePage().findView(VIEW_ID); if (view instanceof PackageExplorerPart) return (PackageExplorerPart)view; return null; } /** * Makes the package explorer part visible in the active perspective. If there * isn't a package explorer part registered <code>null</code> is returned. * Otherwise the opened view part is returned. */ public static PackageExplorerPart openInActivePerspective() { try { return (PackageExplorerPart)JavaPlugin.getActivePage().showView(VIEW_ID); } catch(PartInitException pe) { return null; } } public void dispose() { if (fContextMenu != null && !fContextMenu.isDisposed()) fContextMenu.dispose(); getSite().getPage().removePartListener(fPartListener); JavaPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this); if (fViewer != null) fViewer.removeTreeListener(fExpansionListener); if (fActionSet != null) fActionSet.dispose(); super.dispose(); } /** * Implementation of IWorkbenchPart.createPartControl(Composite) */ public void createPartControl(Composite parent) { fViewer= new ProblemTreeViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL); boolean showCUChildren= AppearancePreferencePage.showCompilationUnitChildren(); boolean reconcile= JavaBasePreferencePage.reconcileJavaViews(); fViewer.setContentProvider(new PackageExplorerContentProvider(showCUChildren, reconcile)); JavaPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(this); ILabelProvider labelProvider= new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS | JavaElementLabels.P_COMPRESSED, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS | JavaElementImageProvider.SMALL_ICONS, AppearanceAwareLabelProvider.getDecorators(true, null) ); fViewer.setLabelProvider(new DecoratingLabelProvider( labelProvider, PlatformUI.getWorkbench().getDecoratorManager().getLabelDecorator()) ); fViewer.setSorter(new JavaElementSorter()); fViewer.setUseHashlookup(true); MenuManager menuMgr= new MenuManager("#PopupMenu"); //$NON-NLS-1$ menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(this); fContextMenu= menuMgr.createContextMenu(fViewer.getTree()); fViewer.getTree().setMenu(fContextMenu); // Register viewer with site. This must be done before making the actions. IWorkbenchPartSite site= getSite(); site.registerContextMenu(menuMgr, fViewer); site.setSelectionProvider(fViewer); site.getPage().addPartListener(fPartListener); makeActions(); // call before registering for selection changes // Set input after filter and sorter has been set. This avoids resorting // and refiltering. fViewer.setInput(findInputElement()); initDragAndDrop(); initKeyListener(); fSelectionListener= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { handleSelectionChanged(event); } }; fViewer.addSelectionChangedListener(fSelectionListener); fViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { fActionSet.handleDoubleClick(event); } }); fViewer.addOpenListener(new IOpenListener() { public void open(OpenEvent event) { fActionSet.handleOpen(event); } }); IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager)); fViewer.addTreeListener(fExpansionListener); if (fMemento != null) restoreState(fMemento); fMemento= null; // Set help for the view JavaUIHelp.setHelp(fViewer, IJavaHelpContextIds.PACKAGES_VIEW); fillActionBars(); updateTitle(); } private void fillActionBars() { IActionBars actionBars= getViewSite().getActionBars(); fActionSet.fillActionBars(actionBars); } private Object findInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IWorkspace) { return JavaCore.create(((IWorkspace)input).getRoot()); } else if (input instanceof IContainer) { return JavaCore.create((IContainer)input); } //1GERPRT: ITPJUI:ALL - Packages View is empty when shown in Type Hierarchy Perspective // we can't handle the input // fall back to show the workspace return JavaCore.create(JavaPlugin.getWorkspace().getRoot()); } /** * Answer the property defined by key. */ public Object getAdapter(Class key) { if (key.equals(ISelectionProvider.class)) return fViewer; return super.getAdapter(key); } /** * Returns the tool tip text for the given element. */ String getToolTipText(Object element) { String result; if (!(element instanceof IResource)) { result= JavaElementLabels.getTextLabel(element, AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS); } else { IPath path= ((IResource) element).getFullPath(); if (path.isRoot()) { result= PackagesMessages.getString("PackageExplorer.title"); //$NON-NLS-1$ } else { result= path.makeRelative().toString(); } } if (fWorkingSetName == null) return result; String wsstr= PackagesMessages.getFormattedString("PackageExplorer.toolTip", new String[] { fWorkingSetName }); //$NON-NLS-1$ if (result.length() == 0) return wsstr; return PackagesMessages.getFormattedString("PackageExplorer.toolTip2", new String[] { result, fWorkingSetName }); //$NON-NLS-1$ } public String getTitleToolTip() { if (fViewer == null) return super.getTitleToolTip(); return getToolTipText(fViewer.getInput()); } /** * @see IWorkbenchPart#setFocus() */ public void setFocus() { fViewer.getTree().setFocus(); } /** * Returns the shell to use for opening dialogs. * Used in this class, and in the actions. */ private Shell getShell() { return fViewer.getTree().getShell(); } /** * Returns the selection provider. */ private ISelectionProvider getSelectionProvider() { return fViewer; } /** * Returns the current selection. */ private ISelection getSelection() { return fViewer.getSelection(); } //---- Action handling ---------------------------------------------------------- /** * Called when the context menu is about to open. Override * to add your own context dependent menu contributions. */ public void menuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); fActionSet.setContext(new ActionContext(getSelection())); fActionSet.fillContextMenu(menu); fActionSet.setContext(null); } private void makeActions() { fActionSet= new PackageExplorerActionGroup(this); } private boolean isSelectionOfType(ISelection s, Class clazz, boolean considerUnderlyingResource) { if (! (s instanceof IStructuredSelection) || s.isEmpty()) return false; IStructuredSelection selection= (IStructuredSelection)s; Iterator iter= selection.iterator(); while (iter.hasNext()) { Object o= iter.next(); if (clazz.isInstance(o)) return true; if (considerUnderlyingResource) { if (! (o instanceof IJavaElement)) return false; IJavaElement element= (IJavaElement)o; Object resource= element.getAdapter(IResource.class); if (! clazz.isInstance(resource)) return false; } } return true; } //---- Event handling ---------------------------------------------------------- private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK; Transfer[] transfers= new Transfer[] { LocalSelectionTransfer.getInstance(), ResourceTransfer.getInstance(), FileTransfer.getInstance()}; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fViewer), new FileTransferDropAdapter(fViewer) }; fViewer.addDropSupport(ops | DND.DROP_DEFAULT, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fViewer), new ResourceTransferDragAdapter(fViewer), new FileTransferDragAdapter(fViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners) { public void dragStart(DragSourceEvent event) { IStructuredSelection selection= (IStructuredSelection)getSelection(); for (Iterator iter= selection.iterator(); iter.hasNext(); ) { if (iter.next() instanceof IMember) { setPossibleListeners(new TransferDragSourceListener[] {new SelectionTransferDragAdapter(fViewer)}); break; } } super.dragStart(event); } }); } /** * Handles selection changed in viewer. * Updates global actions. * Links to editor (if option enabled) */ private void handleSelectionChanged(SelectionChangedEvent event) { IStructuredSelection selection= (IStructuredSelection) event.getSelection(); fActionSet.handleSelectionChanged(event); // if (OpenStrategy.getOpenMethod() != OpenStrategy.SINGLE_CLICK) linkToEditor(selection); } public void selectReveal(ISelection selection) { ISelection javaSelection= convertSelection(selection); fViewer.setSelection(javaSelection, true); if (javaSelection != selection && !javaSelection.equals(fViewer.getSelection())) fViewer.setSelection(selection); } private ISelection convertSelection(ISelection s) { if (!(s instanceof IStructuredSelection)) return s; Object[] elements= ((StructuredSelection)s).toArray(); if (!containsResources(elements)) return s; for (int i= 0; i < elements.length; i++) { Object o= elements[i]; if (o instanceof IResource) { IJavaElement jElement= JavaCore.create((IResource)o); if (jElement != null) elements[i]= jElement; } } return new StructuredSelection(elements); } private boolean containsResources(Object[] elements) { for (int i = 0; i < elements.length; i++) { if (elements[i] instanceof IResource) return true; } return false; } public void selectAndReveal(Object element) { selectReveal(new StructuredSelection(element)); } /** * Returns whether the preference to link selection to active editor is enabled. */ boolean isLinkingEnabled() { return JavaBasePreferencePage.linkPackageSelectionToEditor(); } /** * Links to editor (if option enabled) */ private void linkToEditor(IStructuredSelection selection) { // ignore selection changes if the package explorer is not the active part. // In this case the selection change isn't triggered by a user. if (!isActivePart()) return; Object obj= selection.getFirstElement(); Object element= null; if (selection.size() == 1) { IEditorPart part= EditorUtility.isOpenInEditor(obj); if (part != null) { IWorkbenchPage page= getSite().getPage(); page.bringToTop(part); if (obj instanceof IJavaElement) EditorUtility.revealInEditor(part, (IJavaElement) obj); } } } private boolean isActivePart() { return this == getSite().getPage().getActivePart(); } private IResource getResourceFor(Object element) { if (element instanceof IJavaElement) { if (element instanceof IWorkingCopy) { IWorkingCopy wc= (IWorkingCopy)element; IJavaElement original= wc.getOriginalElement(); if (original != null) element= original; } try { element= ((IJavaElement)element).getUnderlyingResource(); } catch (JavaModelException e) { return null; } } if (!(element instanceof IResource) || ((IResource)element).isPhantom()) { return null; } return (IResource)element; } public void saveState(IMemento memento) { if (fViewer == null) { // part has not been created if (fMemento != null) //Keep the old state; memento.putMemento(fMemento); return; } saveExpansionState(memento); saveSelectionState(memento); // commented out because of http://bugs.eclipse.org/bugs/show_bug.cgi?id=4676 //saveScrollState(memento, fViewer.getTree()); fActionSet.saveState(memento); } protected void saveScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_POSITION, String.valueOf(position)); //save horizontal position bar= tree.getHorizontalBar(); position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_HORIZONTAL_POSITION, String.valueOf(position)); } protected void saveSelectionState(IMemento memento) { Object elements[]= ((IStructuredSelection) fViewer.getSelection()).toArray(); if (elements.length > 0) { IMemento selectionMem= memento.createChild(TAG_SELECTION); for (int i= 0; i < elements.length; i++) { IMemento elementMem= selectionMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= elements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) elements[i]).getHandleIdentifier()); } } } protected void saveExpansionState(IMemento memento) { Object expandedElements[]= fViewer.getVisibleExpandedElements(); if (expandedElements.length > 0) { IMemento expandedMem= memento.createChild(TAG_EXPANDED); for (int i= 0; i < expandedElements.length; i++) { IMemento elementMem= expandedMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= expandedElements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) expandedElements[i]).getHandleIdentifier()); } } } void restoreState(IMemento memento) { restoreExpansionState(memento); restoreSelectionState(memento); // commented out because of http://bugs.eclipse.org/bugs/show_bug.cgi?id=4676 //restoreScrollState(memento, fViewer.getTree()); fActionSet.restoreState(memento); } protected void restoreScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_VERTICAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore, don't set scrollposition } } bar= tree.getHorizontalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_HORIZONTAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore don't set scroll position } } } protected void restoreSelectionState(IMemento memento) { IMemento childMem; childMem= memento.getChild(TAG_SELECTION); if (childMem != null) { ArrayList list= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); if (element != null) list.add(element); } fViewer.setSelection(new StructuredSelection(list)); } } protected void restoreExpansionState(IMemento memento) { IMemento childMem= memento.getChild(TAG_EXPANDED); if (childMem != null) { ArrayList elements= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); if (element != null) elements.add(element); } fViewer.setExpandedElements(elements.toArray()); } } /** * Create the KeyListener for doing the refresh on the viewer. */ private void initKeyListener() { fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { fActionSet.handleKeyEvent(event); } }); } /** * An editor has been activated. Set the selection in this Packages Viewer * to be the editor's input, if linking is enabled. */ void editorActivated(IEditorPart editor) { if (!isLinkingEnabled()) return; Object input= getElementOfInput(editor.getEditorInput()); Object element= null; if (input instanceof IFile) element= JavaCore.create((IFile)input); if (element == null) // try a non Java resource element= input; if (element != null) { // if the current selection is a child of the new // selection then ignore it. IStructuredSelection oldSelection= (IStructuredSelection)getSelection(); if (oldSelection.size() == 1) { Object o= oldSelection.getFirstElement(); if (o instanceof IJavaElement) { ICompilationUnit cu= (ICompilationUnit)((IJavaElement)o).getAncestor(IJavaElement.COMPILATION_UNIT); if (cu != null) { if (cu.isWorkingCopy()) cu= (ICompilationUnit)cu.getOriginalElement(); if ( element.equals(cu)) return; } IClassFile cf= (IClassFile)((IJavaElement)o).getAncestor(IJavaElement.CLASS_FILE); if (cf != null && element.equals(cf)) return; } } ISelection newSelection= new StructuredSelection(element); if (!fViewer.getSelection().equals(newSelection)) { try { fViewer.removeSelectionChangedListener(fSelectionListener); fViewer.setSelection(newSelection); } finally { fViewer.addSelectionChangedListener(fSelectionListener); } } } } /** * A compilation unit or class was expanded, expand * the main type. */ void expandMainType(Object element) { try { IType type= null; if (element instanceof ICompilationUnit) { ICompilationUnit cu= (ICompilationUnit)element; IType[] types= cu.getTypes(); if (types.length > 0) type= types[0]; } else if (element instanceof IClassFile) { IClassFile cf= (IClassFile)element; type= cf.getType(); } if (type != null) { final IType type2= type; Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.getDisplay().asyncExec(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.expandToLevel(type2, 1); } }); } } } catch(JavaModelException e) { // no reveal } } /** * Returns the element contained in the EditorInput */ Object getElementOfInput(IEditorInput input) { if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); else if (input instanceof IFileEditorInput) return ((IFileEditorInput)input).getFile(); else if (input instanceof JarEntryEditorInput) return ((JarEntryEditorInput)input).getStorage(); return null; } /** * Returns the Viewer. */ TreeViewer getViewer() { return fViewer; } /** * Returns the TreeViewer. */ public TreeViewer getTreeViewer() { return fViewer; } boolean isExpandable(Object element) { if (fViewer == null) return false; return fViewer.isExpandable(element); } void setWorkingSetName(String workingSetName) { fWorkingSetName= workingSetName; } /** * Updates the title text and title tool tip. * Called whenever the input of the viewer changes. */ void updateTitle() { Object input= fViewer.getInput(); String viewName= getConfigurationElement().getAttribute("name"); //$NON-NLS-1$ if (input == null || (input instanceof IJavaModel)) { setTitle(viewName); setTitleToolTip(""); //$NON-NLS-1$ } else { String inputText= JavaElementLabels.getTextLabel(input, AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS); String title= PackagesMessages.getFormattedString("PackageExplorer.argTitle", new String[] { viewName, inputText }); //$NON-NLS-1$ setTitle(title); setTitleToolTip(getToolTipText(input)); } } /** * Sets the decorator for the package explorer. * * @param decorator a label decorator or <code>null</code> for no decorations. * @deprecated To be removed */ public void setLabelDecorator(ILabelDecorator decorator) { } /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(PropertyChangeEvent event) { if (fViewer == null) return; boolean refreshViewer= false; if (event.getProperty() == AppearancePreferencePage.SHOW_CU_CHILDREN) { IActionBars actionBars= getViewSite().getActionBars(); fActionSet.fillToolBar(actionBars.getToolBarManager()); actionBars.updateActionBars(); boolean showCUChildren= AppearancePreferencePage.showCompilationUnitChildren(); ((StandardJavaElementContentProvider)fViewer.getContentProvider()).setProvideMembers(showCUChildren); refreshViewer= true; } if (refreshViewer) fViewer.refresh(); } }
20,512
Bug 20512 TVT2: truncated strings in buttons on Modify Parameters window
Build F2, running latest NL fragments. I have been unable to confirm this problem in F3, because we have not migrated to that build yet for our fragments. This problem was reported in Portugese Brazilian, but it probably will occur in all languages, especially German. Here's how to get to the offending buttons. I will also attach a screenshot showing which ones are affected in Brazilian. This bug was opened in response to TPRS ID=125
resolved fixed
02c9efe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T11:41:35Z
2002-06-17T21:40:00Z
org.eclipse.jdt.ui/ui
20,512
Bug 20512 TVT2: truncated strings in buttons on Modify Parameters window
Build F2, running latest NL fragments. I have been unable to confirm this problem in F3, because we have not migrated to that build yet for our fragments. This problem was reported in Portugese Brazilian, but it probably will occur in all languages, especially German. Here's how to get to the offending buttons. I will also attach a screenshot showing which ones are affected in Brazilian. This bug was opened in response to TPRS ID=125
resolved fixed
02c9efe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T11:41:35Z
2002-06-17T21:40:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/ModifyParametersInputPage.java
20,512
Bug 20512 TVT2: truncated strings in buttons on Modify Parameters window
Build F2, running latest NL fragments. I have been unable to confirm this problem in F3, because we have not migrated to that build yet for our fragments. This problem was reported in Portugese Brazilian, but it probably will occur in all languages, especially German. Here's how to get to the offending buttons. I will also attach a screenshot showing which ones are affected in Brazilian. This bug was opened in response to TPRS ID=125
resolved fixed
02c9efe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T11:41:35Z
2002-06-17T21:40:00Z
org.eclipse.jdt.ui/ui
20,512
Bug 20512 TVT2: truncated strings in buttons on Modify Parameters window
Build F2, running latest NL fragments. I have been unable to confirm this problem in F3, because we have not migrated to that build yet for our fragments. This problem was reported in Portugese Brazilian, but it probably will occur in all languages, especially German. Here's how to get to the offending buttons. I will also attach a screenshot showing which ones are affected in Brazilian. This bug was opened in response to TPRS ID=125
resolved fixed
02c9efe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-19T11:41:35Z
2002-06-17T21:40:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/PullUpInputPage.java
19,859
Bug 19859 [JUnit] Socket connection error
I'll provide more specifics as I come across them. Sorry for the sparse detail. Sometimes (but not always) when I Run.. or Debug.. a JUnit launcher, I get the following exception: Console [<disconnected> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner at localHost:9613] Could not connect to: : 6293 java.net.ConnectException: Connection refused at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:295) at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:161) at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:148) at java.net.Socket.connect(Socket.java:425) at java.net.Socket.connect(Socket.java:375) at java.net.Socket.<init>(Socket.java:290) at java.net.Socket.<init>(Socket.java:118) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.connect(RemoteTestRunner.java:440) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:210) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:151) Could be related to one of the following: **I'm running a dual head linux systems via xinerama, but other apps have not had any difficulty. **I'm suspicious that the problem occurs when I have more than one perspective open in different windows, OR when using Debug... would cause a new perspective to be started.
resolved fixed
bf3151a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:09:56Z
2002-06-10T23:00:00Z
org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/runner/RemoteTestRunner.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.junit.runner; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.io.PrintWriter; import java.io.StringWriter; import java.lang.reflect.Constructor; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.net.Socket; import java.util.ArrayList; import java.util.List; import junit.extensions.TestDecorator; import junit.framework.AssertionFailedError; import junit.framework.Test; import junit.framework.TestFailure; import junit.framework.TestListener; import junit.framework.TestResult; import junit.framework.TestSuite; import org.eclipse.jdt.internal.junit.ui.JUnitMessages; /** * A TestRunner that reports results via a socket connection. * See MessageIds for more information about the protocl. */ public class RemoteTestRunner implements TestListener { /** * Holder for information for a rerun request */ private static class RerunRequest { String fClassName; String fTestName; public RerunRequest(String className, String testName) { fClassName= className; fTestName= testName; } } private static final String SUITE_METHODNAME= "suite"; //$NON-NLS-1$ /** * The name of the test classes to be executed */ private String[] fTestClassNames; /** * The current test result */ private TestResult fTestResult; /** * The client socket. */ private Socket fClientSocket; /** * Print writer for sending messages */ private PrintWriter fWriter; /** * Reader for incoming messages */ private BufferedReader fReader; /** * Host to connect to, default is the localhost */ private String fHost= ""; //$NON-NLS-1$ /** * Port to connect to. */ private int fPort= -1; /** * Is the debug mode enabled? */ private boolean fDebugMode= false; /** * Keep the test run server alive after a test run has finished. * This allows to rerun tests. */ private boolean fKeepAlive= false; /** * Has the server been stopped */ private boolean fStopped= false; /** * Queue of rerun requests. */ private List fRerunRequests= new ArrayList(10); /** * Reader thread that processes messages from the client. */ private class ReaderThread extends Thread { public ReaderThread() { super("ReaderThread"); //$NON-NLS-1$ } public void run(){ try { String message= null; while (true) { if ((message= fReader.readLine()) != null) { if (message.startsWith(MessageIds.TEST_STOP)){ fStopped= true; RemoteTestRunner.this.stop(); synchronized(RemoteTestRunner.this) { RemoteTestRunner.this.notifyAll(); } break; } else if (message.startsWith(MessageIds.TEST_RERUN)) { String arg= message.substring(MessageIds.MSG_HEADER_LENGTH); int c= arg.indexOf(" "); //$NON-NLS-1$ synchronized(RemoteTestRunner.this) { fRerunRequests.add(new RerunRequest(arg.substring(0, c), arg.substring(c+1))); RemoteTestRunner.this.notifyAll(); } } } } } catch (Exception e) { RemoteTestRunner.this.stop(); } } } /** * The main entry point. * Parameters<pre> * -classnames: the name of the test suite class * -host: the host to connect to - default local host * -port: the port to connect to, mandatory argument * -keepalive: keep the process alive after a test run * </pre> */ public static void main(String[] args) { // hack to pass the AllTests of JUnit // force static initialization of BaseTestRunner // by creating a junit.textui.TestRunner and free // it immediately. junit.runner.BaseTestRunner runner= new junit.textui.TestRunner(); runner= null; RemoteTestRunner testRunServer= new RemoteTestRunner(); testRunServer.init(args); testRunServer.run(); // fix for 14434 System.exit(0); } /** * Parse command line arguments. Hook for subclasses to process * additional arguments. */ protected void init(String[] args) { defaultInit(args); } /** * The class loader to be used for loading tests. * Subclasses may override to use another class loader. */ protected ClassLoader getClassLoader() { return getClass().getClassLoader(); } /** * Process the default arguments. */ protected final void defaultInit(String[] args) { for(int i= 0; i < args.length; i++) { if(args[i].toLowerCase().equals("-classnames") || args[i].toLowerCase().equals("-classname")){ //$NON-NLS-1$ //$NON-NLS-2$ ArrayList list= new ArrayList(); for (int j= i+1; j < args.length; j++) { if (args[j].startsWith("-")) //$NON-NLS-1$ break; list.add(args[j]); } fTestClassNames= (String[]) list.toArray(new String[list.size()]); } else if(args[i].toLowerCase().equals("-port")) { //$NON-NLS-1$ fPort= Integer.parseInt(args[i+1]); } else if(args[i].toLowerCase().equals("-host")) { //$NON-NLS-1$ fHost= args[i+1]; } else if(args[i].toLowerCase().equals("-keepalive")) { //$NON-NLS-1$ fKeepAlive= true; } else if(args[i].toLowerCase().equals("-debugging") || args[i].toLowerCase().equals("-debug")){ //$NON-NLS-1$ //$NON-NLS-2$ fDebugMode= true; } } if(fTestClassNames == null || fTestClassNames.length == 0) throw new IllegalArgumentException(JUnitMessages.getString("RemoteTestRunner.error.classnamemissing")); //$NON-NLS-1$ if (fPort == -1) throw new IllegalArgumentException(JUnitMessages.getString("RemoteTestRunner.error.portmissing")); //$NON-NLS-1$ if (fDebugMode) System.out.println("keepalive "+fKeepAlive); //$NON-NLS-1$ } /** * Connects to the remote ports and runs the tests. */ protected void run() { if (!connect()) { return; } fTestResult= new TestResult(); fTestResult.addListener(this); runTests(fTestClassNames); fTestResult.removeListener(this); if (fTestResult != null) { fTestResult.stop(); fTestResult= null; } if (fKeepAlive) waitForReruns(); shutDown(); } /** * Waits for rerun requests until an explicit stop request */ private synchronized void waitForReruns() { while (!fStopped) { try { wait(); if (!fStopped && fRerunRequests.size() > 0) { RerunRequest r= (RerunRequest)fRerunRequests.remove(0); rerunTest(r.fClassName, r.fTestName); } } catch (InterruptedException e) { } } } /** * Returns the Test corresponding to the given suite. */ private Test getTest(String suiteClassName) { Class testClass= null; try { testClass= loadSuiteClass(suiteClassName); } catch (ClassNotFoundException e) { String clazz= e.getMessage(); if (clazz == null) clazz= suiteClassName; runFailed(JUnitMessages.getFormattedString("RemoteTestRunner.error.classnotfound", clazz)); //$NON-NLS-1$ return null; } catch(Exception e) { runFailed(JUnitMessages.getFormattedString("RemoteTestRunner.error.exception", e.toString() )); //$NON-NLS-1$ return null; } Method suiteMethod= null; try { suiteMethod= testClass.getMethod(SUITE_METHODNAME, new Class[0]); } catch(Exception e) { // try to extract a test suite automatically return new TestSuite(testClass); } Test test= null; try { test= (Test)suiteMethod.invoke(null, new Class[0]); // static method } catch (InvocationTargetException e) { runFailed(JUnitMessages.getFormattedString("RemoteTestRunner.error.invoke", e.getTargetException().toString() )); //$NON-NLS-1$ return null; } catch (IllegalAccessException e) { runFailed(JUnitMessages.getFormattedString("RemoteTestRunner.error.invoke", e.toString() )); //$NON-NLS-1$ return null; } return test; } protected void runFailed(String message) { System.err.println(message); } /** * Loads the test suite class. */ private Class loadSuiteClass(String className) throws ClassNotFoundException { if (className == null) return null; return getClassLoader().loadClass(className); } /** * Runs a set of tests. */ private void runTests(String[] testClassNames) { // instantiate all tests Test[] suites= new Test[testClassNames.length]; for (int i= 0; i < suites.length; i++) { Test test= getTest(testClassNames[i]); suites[i]= test; } // count all testMethods and inform ITestRunListeners int count= countTests(suites); notifyTestRunStarted(count); if (count == 0) { notifyTestRunEnded(0); return; } long startTime= System.currentTimeMillis(); if (fDebugMode) System.out.println("start send tree"); //$NON-NLS-1$ sendTree(suites[0]); if (fDebugMode) System.out.println("done send tree"+(System.currentTimeMillis()-startTime)); //$NON-NLS-1$ long testStartTime= System.currentTimeMillis(); for (int i= 0; i < suites.length; i++) { suites[i].run(fTestResult); } // inform ITestRunListeners of test end if (fTestResult == null || fTestResult.shouldStop()) notifyTestRunStopped(System.currentTimeMillis() - testStartTime); else notifyTestRunEnded(System.currentTimeMillis() - testStartTime); } private int countTests(Test[] tests) { int count= 0; for (int i= 0; i < tests.length; i++) { if (tests[i] != null) count= count + tests[i].countTestCases(); } return count; } /** * Reruns a test as defined by the fully qualified class name and * the name of the test. */ public void rerunTest(String className, String testName) { Test reloadedTest= null; try { Class reloadedTestClass= getClassLoader().loadClass(className); Class[] classArgs= { String.class }; Constructor constructor= reloadedTestClass.getConstructor(classArgs); Object[] args= new Object[]{testName}; reloadedTest=(Test)constructor.newInstance(args); } catch(Exception e) { runFailed(JUnitMessages.getFormattedString("RemoteTestRunner.error.load", reloadedTest )); //$NON-NLS-1$ return; } TestResult result= new TestResult(); reloadedTest.run(result); notifyTestReran(result, className, testName); } /* * @see TestListener#addError(Test, Throwable) */ public final void addError(Test test, Throwable throwable) { notifyTestFailed(MessageIds.TEST_ERROR, test.toString(), getTrace(throwable)); } /* * @see TestListener#addFailure(Test, AssertionFailedError) */ public final void addFailure(Test test, AssertionFailedError assertionFailedError) { notifyTestFailed(MessageIds.TEST_FAILED, test.toString(), getTrace(assertionFailedError)); } /* * @see TestListener#endTest(Test) */ public void endTest(Test test) { notifyTestEnded(test.toString()); } /* * @see TestListener#startTest(Test) */ public void startTest(Test test) { notifyTestStarted(test.toString()); } private void sendTree(Test test){ if(test instanceof TestDecorator){ TestDecorator decorator= (TestDecorator) test; sendTree(decorator.getTest()); } else if(test instanceof TestSuite){ TestSuite suite= (TestSuite) test; notifyTestTreeEntry(suite.toString().trim() + ',' + true + ',' + suite.testCount()); for(int i=0; i < suite.testCount(); i++){ sendTree(suite.testAt(i)); } } else { notifyTestTreeEntry(test.toString().trim() + ',' + false + ',' + test.countTestCases()); } } /** * Returns the stack trace for the given throwable. */ private String getTrace(Throwable t) { StringWriter stringWriter= new StringWriter(); PrintWriter writer= new PrintWriter(stringWriter); t.printStackTrace(writer); StringBuffer buffer= stringWriter.getBuffer(); return buffer.toString(); } /** * Stop the current test run. */ protected void stop() { if (fTestResult != null) { fTestResult.stop(); } } /** * Connect to the remote test listener. */ private boolean connect() { if (fDebugMode) System.out.println("RemoteTestRunner: trying to connect" + fHost + ":" + fPort); //$NON-NLS-1$ //$NON-NLS-2$ Exception exception= null; for (int i= 1; i < 5; i++) { try{ fClientSocket= new Socket(fHost, fPort); fWriter= new PrintWriter(fClientSocket.getOutputStream(), false/*true*/); fReader= new BufferedReader(new InputStreamReader(fClientSocket.getInputStream())); new ReaderThread().start(); return true; } catch(IOException e){ exception= e; } try { Thread.currentThread().sleep(200); } catch(InterruptedException e) { } } runFailed(JUnitMessages.getFormattedString("RemoteTestRunner.error.connect", new String[]{fHost, Integer.toString(fPort)} )); //$NON-NLS-1$ exception.printStackTrace(); return false; } /** * Shutsdown the connection to the remote test listener. */ private void shutDown() { if (fWriter != null) { fWriter.close(); fWriter= null; } try { if (fReader != null) { fReader.close(); fReader= null; } } catch(IOException e) { if (fDebugMode) e.printStackTrace(); } try { if (fClientSocket != null) { fClientSocket.close(); fClientSocket= null; } } catch(IOException e) { if (fDebugMode) e.printStackTrace(); } } private void sendMessage(String msg) { if(fWriter == null) return; fWriter.println(msg); } private void notifyTestRunStarted(int testCount) { sendMessage(MessageIds.TEST_RUN_START + testCount); } private void notifyTestRunEnded(long elapsedTime) { sendMessage(MessageIds.TEST_RUN_END + elapsedTime); fWriter.flush(); //shutDown(); } private void notifyTestRunStopped(long elapsedTime) { sendMessage(MessageIds.TEST_STOPPED + elapsedTime ); fWriter.flush(); //shutDown(); } private void notifyTestStarted(String testName) { sendMessage(MessageIds.TEST_START + testName); fWriter.flush(); } private void notifyTestEnded(String testName) { sendMessage(MessageIds.TEST_END + testName); } private void notifyTestFailed(String status, String testName, String trace) { sendMessage(status + testName); sendMessage(MessageIds.TRACE_START); sendMessage(trace); sendMessage(MessageIds.TRACE_END); fWriter.flush(); } private void notifyTestTreeEntry(String treeEntry) { sendMessage(MessageIds.TEST_TREE + treeEntry); } private void notifyTestReran(TestResult result, String testClass, String testName) { TestFailure failure= null; if (result.errorCount() > 0) { failure= (TestFailure)result.errors().nextElement(); } if (result.failureCount() > 0) { failure= (TestFailure)result.failures().nextElement(); } if (failure != null) { Throwable t= failure.thrownException(); String trace= getTrace(t); sendMessage(MessageIds.RTRACE_START); sendMessage(trace); sendMessage(MessageIds.RTRACE_END); fWriter.flush(); } String status= "OK"; //$NON-NLS-1$ if (result.errorCount() > 0) status= "ERROR"; //$NON-NLS-1$ else if (result.failureCount() > 0) status= "FAILURE"; //$NON-NLS-1$ if (fPort != -1) { sendMessage(MessageIds.TEST_RERAN + testClass+" "+testName+" "+status); //$NON-NLS-1$ //$NON-NLS-2$ fWriter.flush(); } } }
20,405
Bug 20405 Stack overflow
Non repeatable GPF occurred after running Eclipse F3 for several hours. I selected all the projects in my workspace and chose 'Compute build path' (the PDE option). Just before it crashed it looked like Eclipse was getting sick. An error dialog appeared on the screen that said something like 'Couldn't find class file on classpath'. The dialog looked like it was flickering, as if it was being redrawn rapidly. Although the GPF is a VM problem, it looks like the underlying cause was a stack overflow. Unhandled exception Type=GPF vmState=0xffffffff ExceptionCode=0xc0000005 ExceptionAddress=0x1001e41f ContextFlags=0x0001003f Handler1=0x10f015a6 Handler2=0x10026720 Module=D:\eclipse\j9-20\bin\J9VM20.dll Module_base_address=0x10000000 Offset_in_DLL=0x0001e41f EDI=0x00000000 ESI=0x00000000 EAX=0x0014bca8 EBX=0x04000001 ECX=0x001d7a60 EDX=0x0012f488 EBP=0x0014af70 ESP=0x0012f1d8 EIP=0x1001e41f Thread: main (priority 5) (LOCATION OF ERROR) INLN java/lang/StringBuffer.<init>(Ljava/lang/String;)V (@020622b2) 02a2 org/eclipse/jdt/internal/core/ClasspathEntry.rootID()Ljava/lang/String; ( @020622b2) 0081 org/eclipse/jdt/internal/core/JavaProject.computePackageFragmentRoots (Lorg /eclipse/jdt/core/IClasspathEntry;Lorg/eclipse/jdt/internal/compiler/util/Objec t Vector;Ljava/util/HashSet;ZZZ)V (@02065e09) 00b8 org/eclipse/jdt/internal/core/JavaProject.computePackageFragmentRoots ([Lor g/eclipse/jdt/core/IClasspathEntry;Lorg/eclipse/jdt/internal/compiler/util/Obje c tVector;Ljava/util/HashSet;ZZZ)V (@01f96be8) 10c4 org/eclipse/jdt/internal/core/JavaProject.computePackageFragmentRoots (Lorg /eclipse/jdt/core/IClasspathEntry;Lorg/eclipse/jdt/internal/compiler/util/Objec t Vector;Ljava/util/HashSet;ZZZ)V (@02066e4c) 00b8 org/eclipse/jdt/internal/core/JavaProject.computePackageFragmentRoots ([Lor g/eclipse/jdt/core/IClasspathEntry;Lorg/eclipse/jdt/internal/compiler/util/Obje c tVector;Ljava/util/HashSet;ZZZ)V (@01f96be8) 01c6 org/eclipse/jdt/internal/core/JavaProject.computePackageFragmentRoots ([Lor g/eclipse/jdt/core/IClasspathEntry;Z) [Lorg/eclipse/jdt/core/IPackageFragmentRoot ; (@132f4656) 0007 org/eclipse/jdt/internal/core/JavaProject.getAllPackageFragmentRoots() [Lor g/eclipse/jdt/core/IPackageFragmentRoot; 0033 org/eclipse/jdt/internal/core/JavaProject.findPackageFragmentRoot0 (Lorg/ec lipse/core/runtime/IPath;)Lorg/eclipse/jdt/core/IPackageFragmentRoot; (@020646a 3) 002e org/eclipse/jdt/internal/core/JavaProject.isOnClasspath (Lorg/eclipse/jdt/c ore/IJavaElement;)Z 0040 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.doSetInput (Lorg/ecl ipse/ui/IEditorInput;)V 0002 org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@133045f0) 08c8 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@133045f0) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;)I 002a org/eclipse/ui/texteditor/AbstractTextEditor.setInput (Lorg/eclipse/ui/IEdi torInput;)V 0008 org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor$4.run()V INLN org/eclipse/swt/widgets/RunnableLock.run()V (@1330402e) 0306 org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z (@1330402e) 0021 org/eclipse/swt/widgets/Display.runAsyncMessages()Z (@022c1d31) 0618 org/eclipse/swt/widgets/Display.readAndDispatch()Z (@023f7d1c) 0426 org/eclipse/jface/window/Window.runEventLoop (Lorg/eclipse/swt/widgets/Shel l;)V (@0236f1ae) 0022 org/eclipse/jface/window/Window.open()I 000f org/eclipse/jface/dialogs/ErrorDialog.open()I 0011 org/eclipse/jface/dialogs/ErrorDialog.openError (Lorg/eclipse/swt/widgets/S hell;Ljava/lang/String;Ljava/lang/String;Lorg/eclipse/core/runtime/IStatus;I)I 0006 org/eclipse/jfac
resolved fixed
92c549d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:29:23Z
2002-06-14T21:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileDocumentProvider.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.editors.text.FileDocumentProvider; import org.eclipse.jdt.core.ElementChangedEvent; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.IElementChangedListener; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaElementDelta; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IResourceLocator; import org.eclipse.jdt.internal.ui.JavaPlugin; /** * A document provider for class files. Class files can be either inside */ public class ClassFileDocumentProvider extends FileDocumentProvider { /** * An input change listener to request the editor to reread the input. */ public interface InputChangeListener { void inputChanged(IClassFileEditorInput input); } /** * Synchronizes the document with external resource changes. */ protected class ClassFileSynchronizer implements IElementChangedListener { protected IClassFileEditorInput fInput; protected IPackageFragmentRoot fPackageFragmentRoot; /** * Default constructor. */ public ClassFileSynchronizer(IClassFileEditorInput input) { fInput= input; IJavaElement parent= fInput.getClassFile().getParent(); while (parent != null && !(parent instanceof IPackageFragmentRoot)) { parent= parent.getParent(); } fPackageFragmentRoot= (IPackageFragmentRoot) parent; } /** * Installs the synchronizer. */ public void install() { JavaCore.addElementChangedListener(this); } /** * Uninstalls the synchronizer. */ public void uninstall() { JavaCore.removeElementChangedListener(this); } /* * @see IElementChangedListener#elementChanged */ public void elementChanged(ElementChangedEvent e) { check(fPackageFragmentRoot, e.getDelta()); } /** * Recursively check whether the class file has been deleted. * Returns true if delta processing can be stopped. */ protected boolean check(IPackageFragmentRoot input, IJavaElementDelta delta) { IJavaElement element= delta.getElement(); if ((delta.getKind() & IJavaElementDelta.REMOVED) != 0 || (delta.getFlags() & IJavaElementDelta.F_CLOSED) != 0) { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19023 if (element.equals(input.getJavaProject()) || element.equals(input)) { handleDeleted(fInput); return true; } } if (((delta.getFlags() & IJavaElementDelta.F_ARCHIVE_CONTENT_CHANGED) != 0) && input.equals(element)) { handleDeleted(fInput); return true; } if (((delta.getFlags() & IJavaElementDelta.F_REMOVED_FROM_CLASSPATH) != 0) && input.equals(element)) { handleDeleted(fInput); return true; } IJavaElementDelta[] subdeltas= delta.getAffectedChildren(); for (int i= 0; i < subdeltas.length; i++) { if (check(input, subdeltas[i])) return true; } if ((delta.getFlags() & IJavaElementDelta.F_SOURCEDETACHED) != 0 || (delta.getFlags() & IJavaElementDelta.F_SOURCEATTACHED) != 0) { fireInputChanged(fInput); return false; } return false; } }; /** * Correcting the visibility of <code>FileSynchronizer</code>. */ protected class _FileSynchronizer extends FileSynchronizer { public _FileSynchronizer(IFileEditorInput fileEditorInput) { super(fileEditorInput); } }; /** * Bundle of all required informations. */ protected class ClassFileInfo extends FileInfo { ClassFileSynchronizer fClassFileSynchronizer= null; ClassFileInfo(IDocument document, IAnnotationModel model, _FileSynchronizer fileSynchronizer) { super(document, model, fileSynchronizer); } ClassFileInfo(IDocument document, IAnnotationModel model, ClassFileSynchronizer classFileSynchronizer) { super(document, model, null); fClassFileSynchronizer= classFileSynchronizer; } }; /** Input change listeners. */ private List fInputListeners= new ArrayList(); /** * Creates a new document provider. */ public ClassFileDocumentProvider() { super(); } /* * @see StorageDocumentProvider#setDocumentContent(IDocument, IEditorInput) */ protected boolean setDocumentContent(IDocument document, IEditorInput editorInput, String encoding) throws CoreException { if (editorInput instanceof IClassFileEditorInput) { IClassFile classFile= ((IClassFileEditorInput) editorInput).getClassFile(); document.set(classFile.getSource()); return true; } return super.setDocumentContent(document, editorInput, encoding); } /** * Creates an annotation model derrived from the given class file editor input. * @param the editor input from which to query the annotations * @return the created annotation model * @exception CoreException if the editor input could not be accessed */ protected IAnnotationModel createClassFileAnnotationModel(IClassFileEditorInput classFileEditorInput) throws CoreException { IResource resource= null; IClassFile classFile= classFileEditorInput.getClassFile(); IResourceLocator locator= (IResourceLocator) classFile.getAdapter(IResourceLocator.class); if (locator != null) resource= locator.getContainingResource(classFile); if (resource != null) { ClassFileMarkerAnnotationModel model= new ClassFileMarkerAnnotationModel(resource); model.setClassFile(classFile); return model; } return null; } /* * @see AbstractDocumentProvider#createDocument(Object) */ protected IDocument createDocument(Object element) throws CoreException { IDocument document= super.createDocument(element); if (document != null) { JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); IDocumentPartitioner partitioner= tools.createDocumentPartitioner(); document.setDocumentPartitioner(partitioner); partitioner.connect(document); } return document; } /* * @see AbstractDocumentProvider#createElementInfo(Object) */ protected ElementInfo createElementInfo(Object element) throws CoreException { if (element instanceof IClassFileEditorInput) { IClassFileEditorInput input = (IClassFileEditorInput) element; ExternalClassFileEditorInput external= null; if (input instanceof ExternalClassFileEditorInput) external= (ExternalClassFileEditorInput) input; if (external != null) { try { external.getFile().refreshLocal(IResource.DEPTH_INFINITE, null); } catch (CoreException x) { handleCoreException(x, JavaEditorMessages.getString("ClassFileDocumentProvider.error.createElementInfo")); //$NON-NLS-1$ } } IDocument d= createDocument(input); IAnnotationModel m= createClassFileAnnotationModel(input); if (external != null) { ClassFileInfo info= new ClassFileInfo(d, m, (_FileSynchronizer) null); info.fModificationStamp= computeModificationStamp(external.getFile()); return info; } else if (input instanceof InternalClassFileEditorInput) { ClassFileSynchronizer s= new ClassFileSynchronizer(input); s.install(); return new ClassFileInfo(d, m, s); } } return null; } /* * @see FileDocumentProvider#disposeElementInfo(Object, ElementInfo) */ protected void disposeElementInfo(Object element, ElementInfo info) { ClassFileInfo classFileInfo= (ClassFileInfo) info; if (classFileInfo.fClassFileSynchronizer != null) { classFileInfo.fClassFileSynchronizer.uninstall(); classFileInfo.fClassFileSynchronizer= null; } super.disposeElementInfo(element, info); } /* * @see AbstractDocumentProvider#doSaveDocument(IProgressMonitor, Object, IDocument) */ protected void doSaveDocument(IProgressMonitor monitor, Object element, IDocument document) throws CoreException { } /** * Handles the deletion of the element underlying the given class file editor input. * @param input the editor input */ protected void handleDeleted(IClassFileEditorInput input) { fireElementDeleted(input); } /** * Fires input changes to input change listeners. */ protected void fireInputChanged(IClassFileEditorInput input) { List list= new ArrayList(fInputListeners); for (Iterator i = list.iterator(); i.hasNext();) ((InputChangeListener) i.next()).inputChanged(input); } /** * Adds an input change listener. */ public void addInputChangeListener(InputChangeListener listener) { fInputListeners.add(listener); } /** * Removes an input change listener. */ public void removeInputChangeListener(InputChangeListener listener) { fInputListeners.remove(listener); } }
20,508
Bug 20508 TVT2: hardcoded string in NewTestSuiteCreationWizardPage.java
Build F3 In NewTestSuiteCreationWizardPage.java there is a hardcoded string that shows up in the JUnit Test Suite creation page. I have attached a screenshot from a Japanese tester that shows where this appears. To replicate: From the resource perspective, project in the Navigator. Right click on it to bring up a context menu. Select New -> Other.... On the New wizard, expand Java in the left frame, then select Junit. In the right frame, select TestSuite then click on Next. 'JUnit Test Suite' page appears. Under 'Test Classes to iclude in Suite:' box, text '... class selected' appears in English This bug was opened in response to TPRS ID=120
resolved fixed
690b9cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:32:25Z
2002-06-17T18:53:20Z
org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/wizards/NewTestSuiteCreationWizardPage.java
/* * (c) Copyright IBM Corp. 2000, 2002. * All Rights Reserved. */ package org.eclipse.jdt.internal.junit.wizards; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.jdt.core.IBuffer; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.codemanipulation.IImportsStructure; import org.eclipse.jdt.internal.junit.ui.IJUnitHelpContextIds; import org.eclipse.jdt.internal.junit.ui.JUnitPlugin; import org.eclipse.jdt.internal.junit.util.JUnitStatus; import org.eclipse.jdt.internal.junit.util.JUnitStubUtility; import org.eclipse.jdt.internal.junit.util.LayoutUtil; import org.eclipse.jdt.internal.junit.util.SWTUtil; import org.eclipse.jdt.internal.junit.util.TestSearchEngine; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.wizards.NewTypeWizardPage; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.IStructuredContentProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; import org.eclipse.ui.help.WorkbenchHelp; /** * Wizard page to select the test classes to include * in the test suite. */ public class NewTestSuiteCreationWizardPage extends NewTypeWizardPage { private final static String PAGE_NAME= "NewTestSuiteCreationWizardPage"; //$NON-NLS-1$ private final static String CLASSES_IN_SUITE= PAGE_NAME + ".classesinsuite"; //$NON-NLS-1$ private final static String SUITE_NAME= PAGE_NAME + ".suitename"; //$NON-NLS-1$ private final static String SELECTED_CLASSES_LABEL_TEXT_ONE= " class selected."; //$NON-NLS-1$ private final static String SELECTED_CLASSES_LABEL_TEXT_MANY= " classes selected."; //$NON-NLS-1$ protected final static String STORE_GENERATE_MAIN= PAGE_NAME + ".GENERATE_MAIN"; //$NON-NLS-1$ protected final static String STORE_USE_TESTRUNNER= PAGE_NAME + ".USE_TESTRUNNER"; //$NON-NLS-1$ protected final static String STORE_TESTRUNNER_TYPE= PAGE_NAME + ".TESTRUNNER_TYPE"; //$NON-NLS-1$ public static final String START_MARKER= "//$JUnit-BEGIN$"; //$NON-NLS-1$ public static final String END_MARKER= "//$JUnit-END$"; //$NON-NLS-1$ private IPackageFragment fCurrentPackage; private CheckboxTableViewer fClassesInSuiteTable; private Button fSelectAllButton; private Button fDeselectAllButton; private Label fSelectedClassesLabel; private Label fSuiteNameLabel; private Text fSuiteNameText; private String fSuiteNameTextInitialValue; private MethodStubsSelectionButtonGroup fMethodStubsButtons; private boolean fUpdatedExistingClassButton; protected IStatus fClassesInSuiteStatus; protected IStatus fSuiteNameStatus; public NewTestSuiteCreationWizardPage() { super(true, PAGE_NAME); fSuiteNameStatus= new JUnitStatus(); fSuiteNameTextInitialValue= ""; //$NON-NLS-1$ setTitle(WizardMessages.getString("NewTestSuiteWizPage.title")); //$NON-NLS-1$ setDescription(WizardMessages.getString("NewTestSuiteWizPage.description")); //$NON-NLS-1$ String[] buttonNames= new String[] { "public static void main(Strin&g[] args)", //$NON-NLS-1$ /* Add testrunner statement to main Method */ WizardMessages.getString("NewTestClassWizPage.methodStub.testRunner"), //$NON-NLS-1$ }; fMethodStubsButtons= new MethodStubsSelectionButtonGroup(SWT.CHECK, buttonNames, 1); fMethodStubsButtons.setLabelText(WizardMessages.getString("NewTestClassWizPage2.method.Stub.label")); //$NON-NLS-1$ fClassesInSuiteStatus= new JUnitStatus(); } /** * @see IDialogPage#createControl(Composite) */ public void createControl(Composite parent) { initializeDialogUnits(parent); Composite composite= new Composite(parent, SWT.NONE); int nColumns= 4; GridLayout layout= new GridLayout(); layout.numColumns= nColumns; composite.setLayout(layout); createContainerControls(composite, nColumns); createPackageControls(composite, nColumns); createSeparator(composite, nColumns); createSuiteNameControl(composite, nColumns); setTypeName("AllTests", true); //$NON-NLS-1$ createSeparator(composite, nColumns); createClassesInSuiteControl(composite, nColumns); createMethodStubSelectionControls(composite, nColumns); setControl(composite); restoreWidgetValues(); WorkbenchHelp.setHelp(composite, IJUnitHelpContextIds.NEW_TESTSUITE_WIZARD_PAGE); } protected void createMethodStubSelectionControls(Composite composite, int nColumns) { LayoutUtil.setHorizontalSpan(fMethodStubsButtons.getLabelControl(composite), nColumns); LayoutUtil.createEmptySpace(composite,1); LayoutUtil.setHorizontalSpan(fMethodStubsButtons.getSelectionButtonsGroup(composite), nColumns - 1); } /** * Should be called from the wizard with the initial selection. */ public void init(IStructuredSelection selection) { IJavaElement jelem= getInitialJavaElement(selection); initContainerPage(jelem); initTypePage(jelem); doStatusUpdate(); fMethodStubsButtons.setSelection(0, false); //main fMethodStubsButtons.setSelection(1, false); //add textrunner fMethodStubsButtons.setEnabled(1, false); //add text } /** * @see NewContainerWizardPage#handleFieldChanged */ protected void handleFieldChanged(String fieldName) { super.handleFieldChanged(fieldName); if (fieldName.equals(PACKAGE) || fieldName.equals(CONTAINER)) { if (fieldName.equals(PACKAGE)) fPackageStatus= packageChanged(); updateClassesInSuiteTable(); } else if (fieldName.equals(CLASSES_IN_SUITE)) { fClassesInSuiteStatus= classesInSuiteChanged(); updateSelectedClassesLabel(); } else if (fieldName.equals(SUITE_NAME)) { fSuiteNameStatus= testSuiteChanged(); } doStatusUpdate(); } // ------ validation -------- private void doStatusUpdate() { // status of all used components IStatus[] status= new IStatus[] { fContainerStatus, fPackageStatus, fSuiteNameStatus, fClassesInSuiteStatus }; // the mode severe status will be displayed and the ok button enabled/disabled. updateStatus(status); } /** * @see DialogPage#setVisible(boolean) */ public void setVisible(boolean visible) { super.setVisible(visible); if (visible) { setFocus(); updateClassesInSuiteTable(); } } protected void updateClassesInSuiteTable() { if (fClassesInSuiteTable != null) { IPackageFragment pack= getPackageFragment(); if (pack == null) { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root != null) pack= root.getPackageFragment(""); //$NON-NLS-1$ else return; } fCurrentPackage= pack; fClassesInSuiteTable.setInput(pack); fClassesInSuiteTable.setAllChecked(true); updateSelectedClassesLabel(); } } protected void createClassesInSuiteControl(Composite parent, int nColumns) { if (fClassesInSuiteTable == null) { Label label = new Label(parent, SWT.LEFT); label.setText(WizardMessages.getString("NewTestSuiteWizPage.classes_in_suite.label")); //$NON-NLS-1$ GridData gd= new GridData(); gd.horizontalAlignment = GridData.FILL; gd.horizontalSpan= nColumns; label.setLayoutData(gd); fClassesInSuiteTable= CheckboxTableViewer.newCheckList(parent, SWT.BORDER); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= 80; gd.horizontalSpan= nColumns-1; fClassesInSuiteTable.getTable().setLayoutData(gd); fClassesInSuiteTable.setContentProvider(new ClassesInSuitContentProvider()); fClassesInSuiteTable.setLabelProvider(new JavaElementLabelProvider()); fClassesInSuiteTable.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { handleFieldChanged(CLASSES_IN_SUITE); } }); Composite buttonContainer= new Composite(parent, SWT.NONE); gd= new GridData(GridData.FILL_VERTICAL); buttonContainer.setLayoutData(gd); GridLayout buttonLayout= new GridLayout(); buttonLayout.marginWidth= 0; buttonLayout.marginHeight= 0; buttonContainer.setLayout(buttonLayout); fSelectAllButton= new Button(buttonContainer, SWT.PUSH); fSelectAllButton.setText(WizardMessages.getString("NewTestSuiteWizPage.selectAll")); //$NON-NLS-1$ GridData bgd= new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); bgd.heightHint = SWTUtil.getButtonHeigthHint(fSelectAllButton); bgd.widthHint = SWTUtil.getButtonWidthHint(fSelectAllButton); fSelectAllButton.setLayoutData(bgd); fSelectAllButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { fClassesInSuiteTable.setAllChecked(true); handleFieldChanged(CLASSES_IN_SUITE); } }); fDeselectAllButton= new Button(buttonContainer, SWT.PUSH); fDeselectAllButton.setText(WizardMessages.getString("NewTestSuiteWizPage.deselectAll")); //$NON-NLS-1$ bgd= new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); bgd.heightHint = SWTUtil.getButtonHeigthHint(fDeselectAllButton); bgd.widthHint = SWTUtil.getButtonWidthHint(fDeselectAllButton); fDeselectAllButton.setLayoutData(bgd); fDeselectAllButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { fClassesInSuiteTable.setAllChecked(false); handleFieldChanged(CLASSES_IN_SUITE); } }); // No of selected classes label fSelectedClassesLabel= new Label(parent, SWT.LEFT | SWT.WRAP); fSelectedClassesLabel.setFont(parent.getFont()); updateSelectedClassesLabel(); gd = new GridData(); gd.horizontalSpan = 2; fSelectedClassesLabel.setLayoutData(gd); } } public static class ClassesInSuitContentProvider implements IStructuredContentProvider { private Object[] fTypes; public ClassesInSuitContentProvider() { super(); } public Object[] getElements(Object parent) { try { if (parent instanceof IPackageFragment) { IPackageFragment pack= (IPackageFragment) parent; ICompilationUnit[] cuArray= pack.getCompilationUnits(); ArrayList typesArrayList= new ArrayList(); for (int i= 0; i < cuArray.length; i++) { ICompilationUnit cu= cuArray[i]; IType[] types= cu.getTypes(); for (int j= 0; j < types.length; j++) { if (TestSearchEngine.isTestImplementor(types[j])) typesArrayList.add(types[j]); } } return typesArrayList.toArray(); } } catch (JavaModelException e) { JUnitPlugin.log(e); } return new Object[0]; } public void dispose() { } public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } } /* * @see TypePage#evalMethods */ protected void createTypeMembers(IType type, ImportsManager imports, IProgressMonitor monitor) throws CoreException { writeImports(imports); if (fMethodStubsButtons.isEnabled() && fMethodStubsButtons.isSelected(0)) createMain(type); type.createMethod(getSuiteMethodString(), null, false, null); } protected void createMain(IType type) throws JavaModelException { type.createMethod(fMethodStubsButtons.getMainMethod(getTypeName()), null, false, null); } /** * Returns the string content for creating a new suite() method. */ public String getSuiteMethodString() throws JavaModelException { IPackageFragment pack= getPackageFragment(); String packName= pack.getElementName(); StringBuffer suite= new StringBuffer("public static Test suite () {TestSuite suite= new TestSuite(\"Test for "+((packName.equals(""))?"default package":packName)+"\");\n"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ suite.append(getUpdatableString()); suite.append("\nreturn suite;}"); //$NON-NLS-1$ return suite.toString(); } /** * Returns the new code to be included in a new suite() or which replaces old code in an existing suite(). */ public static String getUpdatableString(Object[] selectedClasses) throws JavaModelException { StringBuffer suite= new StringBuffer(); suite.append(START_MARKER+"\n"); //$NON-NLS-1$ for (int i= 0; i < selectedClasses.length; i++) { if (selectedClasses[i] instanceof IType) { IType testType= (IType) selectedClasses[i]; IMethod suiteMethod= testType.getMethod("suite", new String[] {}); //$NON-NLS-1$ if (!suiteMethod.exists()) { suite.append("suite.addTest(new TestSuite("+testType.getElementName()+".class));"); //$NON-NLS-1$ //$NON-NLS-2$ } else { suite.append("suite.addTest("+testType.getElementName()+".suite());"); //$NON-NLS-1$ //$NON-NLS-2$ } } } suite.append("\n"+END_MARKER); //$NON-NLS-1$ return suite.toString(); } private String getUpdatableString() throws JavaModelException { return getUpdatableString(fClassesInSuiteTable.getCheckedElements()); } /** * Runnable for replacing an existing suite() method. */ public IRunnableWithProgress getRunnable() { return new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { try { if (monitor == null) { monitor= new NullProgressMonitor(); } updateExistingClass(monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }; } protected void updateExistingClass(IProgressMonitor monitor) throws CoreException, InterruptedException { try { IPackageFragment pack= getPackageFragment(); ICompilationUnit cu= pack.getCompilationUnit(getTypeName() + ".java"); //$NON-NLS-1$ if (!cu.exists()) { createType(monitor); fUpdatedExistingClassButton= false; return; } IType suiteType= cu.getType(getTypeName()); monitor.beginTask(WizardMessages.getString("NewTestSuiteWizPage.createType.beginTask"), 10); //$NON-NLS-1$ IMethod suiteMethod= suiteType.getMethod("suite", new String[] {}); //$NON-NLS-1$ monitor.worked(1); String lineDelimiter= JUnitStubUtility.getLineDelimiterUsed(cu); if (suiteMethod.exists()) { ISourceRange range= suiteMethod.getSourceRange(); if (range != null) { IBuffer buf= cu.getBuffer(); String originalContent= buf.getText(range.getOffset(), range.getLength()); StringBuffer source= new StringBuffer(originalContent); //using JDK 1.4 //int start= source.toString().indexOf(START_MARKER) --> int start= source.indexOf(START_MARKER); int start= source.toString().indexOf(START_MARKER); if (start > -1) { //using JDK 1.4 //int end= source.toString().indexOf(END_MARKER, start) --> int end= source.indexOf(END_MARKER, start) int end= source.toString().indexOf(END_MARKER, start); if (end > -1) { monitor.subTask(WizardMessages.getString("NewTestSuiteWizPage.createType.updating.suite_method")); //$NON-NLS-1$ monitor.worked(1); end += END_MARKER.length(); source.replace(start, end, getUpdatableString()); buf.replace(range.getOffset(), range.getLength(), source.toString()); cu.reconcile(); originalContent= buf.getText(0, buf.getLength()); monitor.worked(1); String formattedContent= JUnitStubUtility.codeFormat(originalContent, 0, lineDelimiter); buf.replace(0, buf.getLength(), formattedContent); monitor.worked(1); cu.save(new SubProgressMonitor(monitor, 1), false); } else { cannotUpdateSuiteError(); } } else { cannotUpdateSuiteError(); } } else { MessageDialog.openError(getShell(), WizardMessages.getString("NewTestSuiteWizPage.createType.updateErrorDialog.title"), WizardMessages.getString("NewTestSuiteWizPage.createType.updateErrorDialog.message")); //$NON-NLS-1$ //$NON-NLS-2$ } } else { suiteType.createMethod(getSuiteMethodString(), null, true, monitor); ISourceRange range= cu.getSourceRange(); IBuffer buf= cu.getBuffer(); String originalContent= buf.getText(range.getOffset(), range.getLength()); monitor.worked(2); String formattedContent= JUnitStubUtility.codeFormat(originalContent, 0, lineDelimiter); buf.replace(range.getOffset(), range.getLength(), formattedContent); monitor.worked(1); cu.save(new SubProgressMonitor(monitor, 1), false); } monitor.done(); fUpdatedExistingClassButton= true; } catch (JavaModelException e) { JUnitPlugin.log(e); } } /** * Returns true iff an existing suite() method has been replaced. */ public boolean hasUpdatedExistingClass() { return fUpdatedExistingClassButton; } private IStatus classesInSuiteChanged() { JUnitStatus status= new JUnitStatus(); if (fClassesInSuiteTable.getCheckedElements().length <= 0) status.setWarning(WizardMessages.getString("NewTestSuiteWizPage.classes_in_suite.error.no_testclasses_selected")); //$NON-NLS-1$ return status; } private void updateSelectedClassesLabel() { int noOfClassesChecked= fClassesInSuiteTable.getCheckedElements().length; fSelectedClassesLabel.setText(noOfClassesChecked+((noOfClassesChecked==1)?SELECTED_CLASSES_LABEL_TEXT_ONE:SELECTED_CLASSES_LABEL_TEXT_MANY)); } protected void createSuiteNameControl(Composite composite, int nColumns) { fSuiteNameLabel= new Label(composite, SWT.LEFT | SWT.WRAP); fSuiteNameLabel.setFont(composite.getFont()); fSuiteNameLabel.setText(WizardMessages.getString("NewTestSuiteWizPage.suiteName.text")); //$NON-NLS-1$ GridData gd= new GridData(); gd.horizontalSpan= 1; fSuiteNameLabel.setLayoutData(gd); fSuiteNameText= new Text(composite, SWT.SINGLE | SWT.BORDER); // moved up due to 1GEUNW2 fSuiteNameText.setEnabled(true); fSuiteNameText.setFont(composite.getFont()); fSuiteNameText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { handleFieldChanged(SUITE_NAME); } }); gd= new GridData(); gd.horizontalAlignment= gd.FILL; gd.grabExcessHorizontalSpace= true; gd.horizontalSpan= nColumns - 2; fSuiteNameText.setLayoutData(gd); Label space= new Label(composite, SWT.LEFT); space.setText(" "); //$NON-NLS-1$ gd= new GridData(); gd.horizontalSpan= 1; space.setLayoutData(gd); } /** * Gets the type name. */ public String getTypeName() { return (fSuiteNameText==null)?fSuiteNameTextInitialValue:fSuiteNameText.getText(); } /** * Sets the type name. * @param canBeModified Selects if the type name can be changed by the user */ public void setTypeName(String name, boolean canBeModified) { if (fSuiteNameText == null) { fSuiteNameTextInitialValue= name; } else { fSuiteNameText.setText(name); fSuiteNameText.setEnabled(canBeModified); } } /** * Called when the type name has changed. * The method validates the type name and returns the status of the validation. * Can be extended to add more validation */ protected IStatus testSuiteChanged() { JUnitStatus status= new JUnitStatus(); String typeName= getTypeName(); // must not be empty if (typeName.length() == 0) { status.setError(WizardMessages.getString("NewTestSuiteWizPage.typeName.error.name_empty")); //$NON-NLS-1$ return status; } if (typeName.indexOf('.') != -1) { status.setError(WizardMessages.getString("NewTestSuiteWizPage.typeName.error.name_qualified")); //$NON-NLS-1$ return status; } IStatus val= JavaConventions.validateJavaTypeName(typeName); if (val.getSeverity() == IStatus.ERROR) { status.setError(WizardMessages.getString("NewTestSuiteWizPage.typeName.error.name_not_valid")+val.getMessage()); //$NON-NLS-1$ return status; } else if (val.getSeverity() == IStatus.WARNING) { status.setWarning(WizardMessages.getString("NewTestSuiteWizPage.typeName.error.name.name_discouraged")+val.getMessage()); //$NON-NLS-1$ // continue checking } IPackageFragment pack= getPackageFragment(); if (pack != null) { ICompilationUnit cu= pack.getCompilationUnit(typeName + ".java"); //$NON-NLS-1$ if (cu.exists()) { status.setWarning(WizardMessages.getString("NewTestSuiteWizPage.typeName.warning.already_exists")); //$NON-NLS-1$ fMethodStubsButtons.setEnabled(false); return status; } } fMethodStubsButtons.setEnabled(true); return status; } /** * Sets the focus. */ protected void setFocus() { fSuiteNameText.setFocus(); } /** * Sets the classes in <code>elements</code> as checked. */ public void setCheckedElements(Object[] elements) { fClassesInSuiteTable.setCheckedElements(elements); } protected void cannotUpdateSuiteError() { MessageDialog.openError(getShell(), WizardMessages.getString("NewTestSuiteWizPage.cannotUpdateDialog.title"), //$NON-NLS-1$ WizardMessages.getFormattedString("NewTestSuiteWizPage.cannotUpdateDialog.message", new String[] {START_MARKER, END_MARKER})); //$NON-NLS-1$ } private void writeImports(ImportsManager imports) { imports.addImport("junit.framework.Test"); //$NON-NLS-1$ imports.addImport("junit.framework.TestSuite"); //$NON-NLS-1$ } /** * Use the dialog store to restore widget values to the values that they held * last time this wizard was used to completion */ private void restoreWidgetValues() { IDialogSettings settings= getDialogSettings(); if (settings != null) { boolean generateMain= settings.getBoolean(STORE_GENERATE_MAIN); fMethodStubsButtons.setSelection(0, generateMain); fMethodStubsButtons.setEnabled(1, generateMain); fMethodStubsButtons.setSelection(1,settings.getBoolean(STORE_USE_TESTRUNNER)); //The next 2 lines are necessary. Otherwise, if fMethodsStubsButtons is disabled, and USE_TESTRUNNER gets enabled, //then the checkbox for USE_TESTRUNNER will be the only enabled component of fMethodsStubsButton fMethodStubsButtons.setEnabled(!fMethodStubsButtons.isEnabled()); fMethodStubsButtons.setEnabled(!fMethodStubsButtons.isEnabled()); try { fMethodStubsButtons.setComboSelection(settings.getInt(STORE_TESTRUNNER_TYPE)); } catch(NumberFormatException e) {} } } /** * Since Finish was pressed, write widget values to the dialog store so that they * will persist into the next invocation of this wizard page */ void saveWidgetValues() { IDialogSettings settings= getDialogSettings(); if (settings != null) { settings.put(STORE_GENERATE_MAIN, fMethodStubsButtons.isSelected(0)); settings.put(STORE_USE_TESTRUNNER, fMethodStubsButtons.isSelected(1)); settings.put(STORE_TESTRUNNER_TYPE, fMethodStubsButtons.getComboSelection()); } } }
20,693
Bug 20693 Finding references to variables does not find all occurances
When searching for variables by using the context menu command "refernces" not all occurances are found. After some investigation as an informed user I could track it down to a simple sample (see below). Find all references to the var "willSearchFingMe". All occurances are found except the one in "getWillSearchFndMe2()". If you remove the brackets around "this.willSearchFindMe" it will be found. ----- package com; public class EclipseSearchTest { String willSearchFndMe; public String getWillSearchFndMe() { return willSearchFndMe; } public String getWillSearchFndMe2() { return (this.willSearchFndMe); } public void setWillSearchFndMe(String willSearchFndMe) { this.willSearchFndMe = willSearchFndMe; } }
verified fixed
370d6b1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:54:10Z
2002-06-19T23:40:00Z
org.eclipse.jdt.ui.tests.refactoring/resources/RenameNonPrivateField/test16/in/A.java
20,693
Bug 20693 Finding references to variables does not find all occurances
When searching for variables by using the context menu command "refernces" not all occurances are found. After some investigation as an informed user I could track it down to a simple sample (see below). Find all references to the var "willSearchFingMe". All occurances are found except the one in "getWillSearchFndMe2()". If you remove the brackets around "this.willSearchFindMe" it will be found. ----- package com; public class EclipseSearchTest { String willSearchFndMe; public String getWillSearchFndMe() { return willSearchFndMe; } public String getWillSearchFndMe2() { return (this.willSearchFndMe); } public void setWillSearchFndMe(String willSearchFndMe) { this.willSearchFndMe = willSearchFndMe; } }
verified fixed
370d6b1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:54:10Z
2002-06-19T23:40:00Z
org.eclipse.jdt.ui.tests.refactoring/resources/RenameNonPrivateField/test16/out/A.java
20,693
Bug 20693 Finding references to variables does not find all occurances
When searching for variables by using the context menu command "refernces" not all occurances are found. After some investigation as an informed user I could track it down to a simple sample (see below). Find all references to the var "willSearchFingMe". All occurances are found except the one in "getWillSearchFndMe2()". If you remove the brackets around "this.willSearchFindMe" it will be found. ----- package com; public class EclipseSearchTest { String willSearchFndMe; public String getWillSearchFndMe() { return willSearchFndMe; } public String getWillSearchFndMe2() { return (this.willSearchFndMe); } public void setWillSearchFndMe(String willSearchFndMe) { this.willSearchFndMe = willSearchFndMe; } }
verified fixed
370d6b1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:54:10Z
2002-06-19T23:40:00Z
org.eclipse.jdt.ui.tests.refactoring/test
20,693
Bug 20693 Finding references to variables does not find all occurances
When searching for variables by using the context menu command "refernces" not all occurances are found. After some investigation as an informed user I could track it down to a simple sample (see below). Find all references to the var "willSearchFingMe". All occurances are found except the one in "getWillSearchFndMe2()". If you remove the brackets around "this.willSearchFindMe" it will be found. ----- package com; public class EclipseSearchTest { String willSearchFndMe; public String getWillSearchFndMe() { return willSearchFndMe; } public String getWillSearchFndMe2() { return (this.willSearchFndMe); } public void setWillSearchFndMe(String willSearchFndMe) { this.willSearchFndMe = willSearchFndMe; } }
verified fixed
370d6b1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-20T09:54:10Z
2002-06-19T23:40:00Z
cases/org/eclipse/jdt/ui/tests/refactoring/RenameNonPrivateFieldTests.java
20,520
Bug 20520 Refactor - expression detection incorrect
Build F3 Enter the following class into a Java editor: 1: public class Foo { 2: public Object foo() { 3: if ( ((Object)null).toString() == null ) { 4: return (Object)null; 5: } 6: return null; 7: } 8: } If you select "(Object)null" on line 3, and choose 'Refactor'->'Extract Local Variable', the action complains that "An expression must be selected to activate this refactoring. If you select the same expression on line 4, the refactoring is allowed. If you select "((Object)null)" on line 3, the refactoring is alos allowed. All three of these are identical expressions, and should all be permitted.
verified fixed
f95b60d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-21T10:37:38Z
2002-06-17T21:40:00Z
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractTemp/canExtract/A_test39_in.java
20,520
Bug 20520 Refactor - expression detection incorrect
Build F3 Enter the following class into a Java editor: 1: public class Foo { 2: public Object foo() { 3: if ( ((Object)null).toString() == null ) { 4: return (Object)null; 5: } 6: return null; 7: } 8: } If you select "(Object)null" on line 3, and choose 'Refactor'->'Extract Local Variable', the action complains that "An expression must be selected to activate this refactoring. If you select the same expression on line 4, the refactoring is allowed. If you select "((Object)null)" on line 3, the refactoring is alos allowed. All three of these are identical expressions, and should all be permitted.
verified fixed
f95b60d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-21T10:37:38Z
2002-06-17T21:40:00Z
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractTemp/canExtract/A_test39_out.java
20,520
Bug 20520 Refactor - expression detection incorrect
Build F3 Enter the following class into a Java editor: 1: public class Foo { 2: public Object foo() { 3: if ( ((Object)null).toString() == null ) { 4: return (Object)null; 5: } 6: return null; 7: } 8: } If you select "(Object)null" on line 3, and choose 'Refactor'->'Extract Local Variable', the action complains that "An expression must be selected to activate this refactoring. If you select the same expression on line 4, the refactoring is allowed. If you select "((Object)null)" on line 3, the refactoring is alos allowed. All three of these are identical expressions, and should all be permitted.
verified fixed
f95b60d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-21T10:37:38Z
2002-06-17T21:40:00Z
org.eclipse.jdt.ui.tests.refactoring/test
20,520
Bug 20520 Refactor - expression detection incorrect
Build F3 Enter the following class into a Java editor: 1: public class Foo { 2: public Object foo() { 3: if ( ((Object)null).toString() == null ) { 4: return (Object)null; 5: } 6: return null; 7: } 8: } If you select "(Object)null" on line 3, and choose 'Refactor'->'Extract Local Variable', the action complains that "An expression must be selected to activate this refactoring. If you select the same expression on line 4, the refactoring is allowed. If you select "((Object)null)" on line 3, the refactoring is alos allowed. All three of these are identical expressions, and should all be permitted.
verified fixed
f95b60d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-21T10:37:38Z
2002-06-17T21:40:00Z
cases/org/eclipse/jdt/ui/tests/refactoring/ExtractTempTests.java
20,700
Bug 20700 Code assist activates help UI
null
resolved fixed
cf9960f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-21T11:19:12Z
2002-06-20T02:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.ScrolledComposite; import org.eclipse.swt.custom.StackLayout; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.events.ControlEvent; import org.eclipse.swt.events.ControlListener; import org.eclipse.swt.events.DisposeEvent; import org.eclipse.swt.events.DisposeListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.graphics.FontData; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.layout.FillLayout; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.core.resources.IFile; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.IWidgetTokenKeeper; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.help.IHelp; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.IClasspathContainer; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModelStatusConstants; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.ToolFactory; import org.eclipse.jdt.core.util.IClassFileDisassembler; import org.eclipse.jdt.core.util.IClassFileReader; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIStatus; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * Java specific text editor. */ public class ClassFileEditor extends JavaEditor implements ClassFileDocumentProvider.InputChangeListener { /** The horizontal scroll increment. */ private static final int HORIZONTAL_SCROLL_INCREMENT= 10; /** The vertical scroll increment. */ private static final int VERTICAL_SCROLL_INCREMENT= 10; /** * A form to attach source to a class file. */ private class SourceAttachmentForm implements IPropertyChangeListener { private final IClassFile fFile; private ScrolledComposite fScrolledComposite; private Color fBackgroundColor; private Color fForegroundColor; private Color fSeparatorColor; private List fBannerLabels= new ArrayList(); private List fHeaderLabels= new ArrayList(); private Font fFont; /** * Creates a source attachment form for a class file. */ public SourceAttachmentForm(IClassFile file) { fFile= file; } /** * Returns the package fragment root of this file. */ private IPackageFragmentRoot getPackageFragmentRoot(IClassFile file) { IJavaElement element= file.getParent(); while (element != null && element.getElementType() != IJavaElement.PACKAGE_FRAGMENT_ROOT) element= element.getParent(); return (IPackageFragmentRoot) element; } /** * Creates the control of the source attachment form. */ public Control createControl(Composite parent) { Display display= parent.getDisplay(); fBackgroundColor= display.getSystemColor(SWT.COLOR_LIST_BACKGROUND); fForegroundColor= display.getSystemColor(SWT.COLOR_LIST_FOREGROUND); fSeparatorColor= new Color(display, 152, 170, 203); JFaceResources.getFontRegistry().addListener(this); fScrolledComposite= new ScrolledComposite(parent, SWT.H_SCROLL | SWT.V_SCROLL); fScrolledComposite.setAlwaysShowScrollBars(false); fScrolledComposite.setExpandHorizontal(true); fScrolledComposite.setExpandVertical(true); fScrolledComposite.addDisposeListener(new DisposeListener() { public void widgetDisposed(DisposeEvent e) { JFaceResources.getFontRegistry().removeListener(SourceAttachmentForm.this); fScrolledComposite= null; fSeparatorColor.dispose(); fSeparatorColor= null; fBannerLabels.clear(); fHeaderLabels.clear(); if (fFont != null) { fFont.dispose(); fFont= null; } } }); fScrolledComposite.addControlListener(new ControlListener() { public void controlMoved(ControlEvent e) {} public void controlResized(ControlEvent e) { Rectangle clientArea = fScrolledComposite.getClientArea(); ScrollBar verticalBar= fScrolledComposite.getVerticalBar(); verticalBar.setIncrement(VERTICAL_SCROLL_INCREMENT); verticalBar.setPageIncrement(clientArea.height - verticalBar.getIncrement()); ScrollBar horizontalBar= fScrolledComposite.getHorizontalBar(); horizontalBar.setIncrement(HORIZONTAL_SCROLL_INCREMENT); horizontalBar.setPageIncrement(clientArea.width - horizontalBar.getIncrement()); } }); Composite composite= createComposite(fScrolledComposite); composite.setLayout(new GridLayout()); Label titleLabel= createTitleLabel(composite, JavaEditorMessages.getString("SourceAttachmentForm.title")); //$NON-NLS-1$ createLabel(composite, null); createLabel(composite, null); createHeadingLabel(composite, JavaEditorMessages.getString("SourceAttachmentForm.heading")); //$NON-NLS-1$ Composite separator= createCompositeSeparator(composite); GridData data= new GridData(GridData.FILL_HORIZONTAL); data.heightHint= 2; separator.setLayoutData(data); try { final IPackageFragmentRoot root= getPackageFragmentRoot(fFile); if (root != null) { IClasspathEntry entry= root.getRawClasspathEntry(); if (!root.isArchive()) { createLabel(composite, JavaEditorMessages.getFormattedString("SourceAttachmentForm.message.noSource", fFile.getElementName())); //$NON-NLS-1$ } else if (entry != null && entry.getEntryKind() == IClasspathEntry.CPE_CONTAINER) { IClasspathContainer container= JavaCore.getClasspathContainer(entry.getPath(), root.getJavaProject()); String containerName= container == null ? entry.getPath().toString() : container.getDescription(); createLabel(composite, JavaEditorMessages.getFormattedString("SourceAttachmentForm.message.containerEntry", containerName)); //$NON-NLS-1$ } else { Button button; IPath path= root.getSourceAttachmentPath(); if (path == null) { createLabel(composite, JavaEditorMessages.getFormattedString("SourceAttachmentForm.message.noSourceAttachment", root.getElementName())); //$NON-NLS-1$ createLabel(composite, JavaEditorMessages.getString("SourceAttachmentForm.message.pressButtonToAttach")); //$NON-NLS-1$ createLabel(composite, null); button= createButton(composite, JavaEditorMessages.getString("SourceAttachmentForm.button.attachSource")); //$NON-NLS-1$ } else { createLabel(composite, JavaEditorMessages.getFormattedString("SourceAttachmentForm.message.noSourceInAttachment", fFile.getElementName())); //$NON-NLS-1$ createLabel(composite, JavaEditorMessages.getString("SourceAttachmentForm.message.pressButtonToChange")); //$NON-NLS-1$ createLabel(composite, null); button= createButton(composite, JavaEditorMessages.getString("SourceAttachmentForm.button.changeAttachedSource")); //$NON-NLS-1$ } button.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent event) { try { SourceAttachmentDialog dialog= new SourceAttachmentDialog(fScrolledComposite.getShell(), root); if (dialog.open() == SourceAttachmentDialog.OK) verifyInput(getEditorInput()); } catch (CoreException e) { String title= JavaEditorMessages.getString("SourceAttachmentForm.error.title"); //$NON-NLS-1$ String message= JavaEditorMessages.getString("SourceAttachmentForm.error.message"); //$NON-NLS-1$ ExceptionHandler.handle(e, fScrolledComposite.getShell(), title, message); } } public void widgetDefaultSelected(SelectionEvent e) {} }); } } } catch (JavaModelException e) { String title= JavaEditorMessages.getString("SourceAttachmentForm.error.title"); //$NON-NLS-1$ String message= JavaEditorMessages.getString("SourceAttachmentForm.error.message"); //$NON-NLS-1$ ExceptionHandler.handle(e, fScrolledComposite.getShell(), title, message); } separator= createCompositeSeparator(composite); data= new GridData(GridData.FILL_HORIZONTAL); data.heightHint= 2; separator.setLayoutData(data); StyledText styledText= createCodeView(composite); data= new GridData(GridData.FILL_BOTH); styledText.setLayoutData(data); updateCodeView(styledText, fFile); fScrolledComposite.setContent(composite); fScrolledComposite.setMinSize(composite.computeSize(SWT.DEFAULT, SWT.DEFAULT)); return fScrolledComposite; } /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(PropertyChangeEvent event) { for (Iterator iterator = fBannerLabels.iterator(); iterator.hasNext();) { Label label = (Label) iterator.next(); label.setFont(JFaceResources.getBannerFont()); } for (Iterator iterator = fHeaderLabels.iterator(); iterator.hasNext();) { Label label = (Label) iterator.next(); label.setFont(JFaceResources.getHeaderFont()); } Control control= fScrolledComposite.getContent(); fScrolledComposite.setMinSize(control.computeSize(SWT.DEFAULT, SWT.DEFAULT)); fScrolledComposite.setContent(control); fScrolledComposite.layout(true); fScrolledComposite.redraw(); } // --- copied from org.eclipse.update.ui.forms.internal.FormWidgetFactory private Composite createComposite(Composite parent) { Composite composite = new Composite(parent, SWT.NONE); composite.setBackground(fBackgroundColor); // composite.addMouseListener(new MouseAdapter() { // public void mousePressed(MouseEvent e) { // ((Control) e.widget).setFocus(); // } // }); return composite; } private Composite createCompositeSeparator(Composite parent) { Composite composite = new Composite(parent, SWT.NONE); composite.setBackground(fSeparatorColor); return composite; } private StyledText createCodeView(Composite parent) { int styles= SWT.MULTI | SWT.FULL_SELECTION; StyledText styledText= new StyledText(parent, styles); styledText.setBackground(fBackgroundColor); styledText.setForeground(fForegroundColor); styledText.setEditable(false); setFont(styledText); return styledText; } private void setFont(StyledText styledText) { IPreferenceStore store= getPreferenceStore(); if (store != null) { FontData data= null; if (store.contains(PREFERENCE_FONT) && !store.isDefault(PREFERENCE_FONT)) data= PreferenceConverter.getFontData(store, PREFERENCE_FONT); else data= PreferenceConverter.getDefaultFontData(store, PREFERENCE_FONT); if (data != null) { Font font= new Font(styledText.getDisplay(), data); styledText.setFont(font); if (fFont != null) fFont.dispose(); fFont= font; } } } private Label createLabel(Composite parent, String text) { Label label = new Label(parent, SWT.NONE); if (text != null) label.setText(text); label.setBackground(fBackgroundColor); label.setForeground(fForegroundColor); return label; } private Label createTitleLabel(Composite parent, String text) { Label label = new Label(parent, SWT.NONE); if (text != null) label.setText(text); label.setBackground(fBackgroundColor); label.setForeground(fForegroundColor); label.setFont(JFaceResources.getHeaderFont()); fHeaderLabels.add(label); return label; } private Label createHeadingLabel(Composite parent, String text) { Label label = new Label(parent, SWT.NONE); if (text != null) label.setText(text); label.setBackground(fBackgroundColor); label.setForeground(fForegroundColor); label.setFont(JFaceResources.getBannerFont()); fBannerLabels.add(label); return label; } private Button createButton(Composite parent, String text) { Button button = new Button(parent, SWT.FLAT); button.setBackground(fBackgroundColor); button.setForeground(fForegroundColor); if (text != null) button.setText(text); // button.addFocusListener(visibilityHandler); return button; } private void updateCodeView(StyledText styledText, IClassFile classFile) { String content= null; int flags= IClassFileReader.FIELD_INFOS | IClassFileReader.METHOD_INFOS | IClassFileReader.SUPER_INTERFACES; IClassFileReader classFileReader= ToolFactory.createDefaultClassFileReader(classFile, flags); if (classFileReader != null) { IClassFileDisassembler disassembler= ToolFactory.createDefaultClassFileDisassembler(); content= disassembler.disassemble(classFileReader, "\n"); //$NON-NLS-1$ } styledText.setText(content == null ? "" : content); //$NON-NLS-1$ } }; private StackLayout fStackLayout; private Composite fParent; private Composite fViewerComposite; private Control fSourceAttachmentForm; /** * Default constructor. */ public ClassFileEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getClassFileDocumentProvider()); setEditorContextMenuId("#ClassFileEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#ClassFileRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#ClassFileOutlinerContext"); //$NON-NLS-1$ // don't set help contextId, we install our own help context } /* * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); setAction(ITextEditorActionConstants.SAVE, null); setAction(ITextEditorActionConstants.REVERT_TO_SAVED, null); /* * 1GF82PL: ITPJUI:ALL - Need to be able to add bookmark to classfile * * // replace default action with class file specific ones * * setAction(ITextEditorActionConstants.BOOKMARK, new AddClassFileMarkerAction("AddBookmark.", this, IMarker.BOOKMARK, true)); //$NON-NLS-1$ * setAction(ITextEditorActionConstants.ADD_TASK, new AddClassFileMarkerAction("AddTask.", this, IMarker.TASK, false)); //$NON-NLS-1$ * setAction(ITextEditorActionConstants.RULER_MANAGE_BOOKMARKS, new ClassFileMarkerRulerAction("ManageBookmarks.", getVerticalRuler(), this, IMarker.BOOKMARK, true)); //$NON-NLS-1$ * setAction(ITextEditorActionConstants.RULER_MANAGE_TASKS, new ClassFileMarkerRulerAction("ManageTasks.", getVerticalRuler(), this, IMarker.TASK, true)); //$NON-NLS-1$ */ setAction(ITextEditorActionConstants.BOOKMARK, null); setAction(ITextEditorActionConstants.ADD_TASK, null); } /* * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { if (getEditorInput() instanceof IClassFileEditorInput) { try { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); return input.getClassFile().getElementAt(offset); } catch (JavaModelException x) { } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { if (getEditorInput() instanceof IClassFileEditorInput) { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); IJavaElement parent= element.getAncestor(IJavaElement.CLASS_FILE); if (input.getClassFile().equals(parent)) return element; } return null; } /* * @see IEditorPart#saveState(IMemento) */ public void saveState(IMemento memento) { } /* * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null && input instanceof IClassFileEditorInput) { IClassFileEditorInput cfi= (IClassFileEditorInput) input; page.setInput(cfi.getClassFile()); } } /* * 1GEPKT5: ITPJUI:Linux - Source in editor for external classes is editable * Removed methods isSaveOnClosedNeeded and isDirty. * Added method isEditable. */ /* * @see org.eclipse.ui.texteditor.AbstractTextEditor#isEditable() */ public boolean isEditable() { return false; } /** * Translates the given editor input into an <code>ExternalClassFileEditorInput</code> * if it is a file editor input representing an external class file. * * @param input the editor input to be transformed if necessary * @return the transformed editor input */ protected IEditorInput transformEditorInput(IEditorInput input) { if (input instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) input).getFile(); IClassFileEditorInput classFileInput= new ExternalClassFileEditorInput(file); if (classFileInput.getClassFile() != null) input= classFileInput; } return input; } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { input= transformEditorInput(input); if (!(input instanceof IClassFileEditorInput)) throw new CoreException(new JavaUIStatus(IJavaModelStatusConstants.INVALID_RESOURCE_TYPE, JavaEditorMessages.getString("ClassFileEditor.error.invalid_input_message"))); //$NON-NLS-1$ JavaModelException e= probeInputForSource(input); if (e != null) { IClassFileEditorInput classFileEditorInput= (IClassFileEditorInput) input; IClassFile file= classFileEditorInput.getClassFile(); if (!file.getJavaProject().isOnClasspath(file)) { throw new CoreException(new JavaUIStatus(IJavaModelStatusConstants.INVALID_RESOURCE, JavaEditorMessages.getString("ClassFileEditor.error.classfile_not_on_classpath"))); //$NON-NLS-1$ } else { throw e; } } IDocumentProvider documentProvider= getDocumentProvider(); if (documentProvider instanceof ClassFileDocumentProvider) ((ClassFileDocumentProvider) documentProvider).removeInputChangeListener(this); super.doSetInput(input); documentProvider= getDocumentProvider(); if (documentProvider instanceof ClassFileDocumentProvider) ((ClassFileDocumentProvider) documentProvider).addInputChangeListener(this); verifyInput(getEditorInput()); } /* * @see IWorkbenchPart#createPartControl(Composite) */ public void createPartControl(Composite parent) { fParent= new Composite(parent, SWT.NONE); fStackLayout= new StackLayout(); fParent.setLayout(fStackLayout); fViewerComposite= new Composite(fParent, SWT.NONE); fViewerComposite.setLayout(new FillLayout()); super.createPartControl(fViewerComposite); fStackLayout.topControl= fViewerComposite; fParent.layout(); try { verifyInput(getEditorInput()); } catch (CoreException e) { String title= JavaEditorMessages.getString("ClassFileEditor.error.title"); //$NON-NLS-1$ String message= JavaEditorMessages.getString("ClassFileEditor.error.message"); //$NON-NLS-1$ ExceptionHandler.handle(e, fParent.getShell(), title, message); } } /** * Returns the package fragment root corresponding to the class file. */ private static IPackageFragmentRoot getPackageFragmentRoot(IClassFile file) { IJavaElement element= file.getParent(); while (element != null && element.getElementType() != IJavaElement.PACKAGE_FRAGMENT_ROOT) element= element.getParent(); return (IPackageFragmentRoot) element; } private JavaModelException probeInputForSource(IEditorInput input) { if (input == null) return null; IClassFileEditorInput classFileEditorInput= (IClassFileEditorInput) input; IClassFile file= classFileEditorInput.getClassFile(); try { file.getSourceRange(); } catch (JavaModelException e) { return e; } return null; } /** * Checks if the class file input has no source attached. If so, a source attachment form is shown. */ private void verifyInput(IEditorInput input) throws CoreException { if (fParent == null || input == null) return; IClassFileEditorInput classFileEditorInput= (IClassFileEditorInput) input; IClassFile file= classFileEditorInput.getClassFile(); // show source attachment form if no source found if (file.getSourceRange() == null) { // dispose old source attachment form if (fSourceAttachmentForm != null) fSourceAttachmentForm.dispose(); SourceAttachmentForm form= new SourceAttachmentForm(file); fSourceAttachmentForm= form.createControl(fParent); fStackLayout.topControl= fSourceAttachmentForm; fParent.layout(); // show source viewer } else { if (fSourceAttachmentForm != null) { fSourceAttachmentForm.dispose(); fSourceAttachmentForm= null; fStackLayout.topControl= fViewerComposite; fParent.layout(); } } } /* * @see ClassFileDocumentProvider.InputChangeListener#inputChanged(IClassFileEditorInput) */ public void inputChanged(final IClassFileEditorInput input) { if (input != null && input.equals(getEditorInput())) { ISourceViewer viewer= getSourceViewer(); if (viewer != null) { StyledText textWidget= viewer.getTextWidget(); if (textWidget != null && !textWidget.isDisposed()) { textWidget.getDisplay().asyncExec(new Runnable() { public void run() { setInput(input); } }); } } } } /* * @see JavaEditor#createJavaSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19445 return new SourceViewer(parent, ruler, styles) { public boolean requestWidgetToken(IWidgetTokenKeeper requester) { IHelp help= WorkbenchHelp.getHelpSupport(); if (help != null && help.isContextHelpDisplayed()) return false; return super.requestWidgetToken(requester); } }; } /* * @see org.eclipse.ui.IWorkbenchPart#dispose() */ public void dispose() { // http://bugs.eclipse.org/bugs/show_bug.cgi?id=18510 IDocumentProvider documentProvider= getDocumentProvider(); if (documentProvider instanceof ClassFileDocumentProvider) ((ClassFileDocumentProvider) documentProvider).removeInputChangeListener(this); super.dispose(); } }
20,700
Bug 20700 Code assist activates help UI
null
resolved fixed
cf9960f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-21T11:19:12Z
2002-06-20T02:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Layout; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Preferences; import org.eclipse.core.runtime.Preferences.IPropertyChangeListener; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IMessageProvider; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.DocumentCommand; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ILineTracker; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.IWidgetTokenKeeper; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewerConfiguration; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.ContentAssistAction; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.tasklist.TaskList; import org.eclipse.help.IHelp; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.compare.LocalHistoryActionGroup; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.SelectionHistory; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectEnclosingAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectHistoryAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectNextAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectPreviousAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionAction; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer; import org.eclipse.jdt.internal.ui.text.java.IReconcilingParticipant; /** * Java specific text editor. */ public class CompilationUnitEditor extends JavaEditor implements IReconcilingParticipant { interface ITextConverter { void customizeDocumentCommand(IDocument document, DocumentCommand command); }; class AdaptedRulerLayout extends Layout { protected int fGap; protected AdaptedSourceViewer fAdaptedSourceViewer; protected AdaptedRulerLayout(int gap, AdaptedSourceViewer asv) { fGap= gap; fAdaptedSourceViewer= asv; } protected Point computeSize(Composite composite, int wHint, int hHint, boolean flushCache) { Control[] children= composite.getChildren(); Point s= children[children.length - 1].computeSize(SWT.DEFAULT, SWT.DEFAULT, flushCache); if (fAdaptedSourceViewer.isVerticalRulerVisible()) s.x += fAdaptedSourceViewer.getVerticalRuler().getWidth() + fGap; return s; } protected void layout(Composite composite, boolean flushCache) { Rectangle clArea= composite.getClientArea(); if (fAdaptedSourceViewer.isVerticalRulerVisible()) { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); Rectangle trim= textWidget.computeTrim(0, 0, 0, 0); int scrollbarHeight= trim.height; IVerticalRuler vr= fAdaptedSourceViewer.getVerticalRuler(); int vrWidth=vr.getWidth(); int orWidth= 0; if (fAdaptedSourceViewer.isOverviewRulerVisible()) { OverviewRuler or= fAdaptedSourceViewer.getOverviewRuler(); orWidth= or.getWidth(); or.getControl().setBounds(clArea.width - orWidth, scrollbarHeight, orWidth, clArea.height - 3*scrollbarHeight); } textWidget.setBounds(vrWidth + fGap, 0, clArea.width - vrWidth - orWidth - 2*fGap, clArea.height); vr.getControl().setBounds(0, 0, vrWidth, clArea.height - scrollbarHeight); } else { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); textWidget.setBounds(0, 0, clArea.width, clArea.height); } } }; class AdaptedSourceViewer extends JavaCorrectionSourceViewer { private List fTextConverters; private OverviewRuler fOverviewRuler; private boolean fIsOverviewRulerVisible; private boolean fIgnoreTextConverters= false; private IVerticalRuler fCachedVerticalRuler; private boolean fCachedIsVerticalRulerVisible; public AdaptedSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { super(parent, ruler, styles, CompilationUnitEditor.this); fCachedVerticalRuler= ruler; fCachedIsVerticalRulerVisible= (ruler != null); fOverviewRuler= new OverviewRuler(VERTICAL_RULER_WIDTH); delayedCreateControl(parent, styles); } /* * @see ISourceViewer#showAnnotations(boolean) */ public void showAnnotations(boolean show) { fCachedIsVerticalRulerVisible= (show && fCachedVerticalRuler != null); super.showAnnotations(show); } public IContentAssistant getContentAssistant() { return fContentAssistant; } /* * @see ITextOperationTarget#doOperation(int) */ public void doOperation(int operation) { if (getTextWidget() == null) return; switch (operation) { case CONTENTASSIST_PROPOSALS: String msg= fContentAssistant.showPossibleCompletions(); setStatusLineErrorMessage(msg); return; case UNDO: fIgnoreTextConverters= true; break; case REDO: fIgnoreTextConverters= true; break; } super.doOperation(operation); } public void insertTextConverter(ITextConverter textConverter, int index) { throw new UnsupportedOperationException(); } public void addTextConverter(ITextConverter textConverter) { if (fTextConverters == null) { fTextConverters= new ArrayList(1); fTextConverters.add(textConverter); } else if (!fTextConverters.contains(textConverter)) fTextConverters.add(textConverter); } public void removeTextConverter(ITextConverter textConverter) { if (fTextConverters != null) { fTextConverters.remove(textConverter); if (fTextConverters.size() == 0) fTextConverters= null; } } /* * @see TextViewer#customizeDocumentCommand(DocumentCommand) */ protected void customizeDocumentCommand(DocumentCommand command) { super.customizeDocumentCommand(command); if (!fIgnoreTextConverters && fTextConverters != null) { for (Iterator e = fTextConverters.iterator(); e.hasNext();) ((ITextConverter) e.next()).customizeDocumentCommand(getDocument(), command); } fIgnoreTextConverters= false; } public IVerticalRuler getVerticalRuler() { return fCachedVerticalRuler; } public boolean isVerticalRulerVisible() { return fCachedIsVerticalRulerVisible; } public OverviewRuler getOverviewRuler() { return fOverviewRuler; } /* * @see TextViewer#createControl(Composite, int) */ protected void createControl(Composite parent, int styles) { // do nothing here } protected void delayedCreateControl(Composite parent, int styles) { //create the viewer super.createControl(parent, styles); Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.setLayout(new AdaptedRulerLayout(GAP_SIZE, this)); fOverviewRuler.createControl(composite, this); } } public void hideOverviewRuler() { fIsOverviewRulerVisible= false; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public void showOverviewRuler() { fIsOverviewRulerVisible= true; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public boolean isOverviewRulerVisible() { return fIsOverviewRulerVisible; } /* * @see ISourceViewer#setDocument(IDocument, IAnnotationModel, int, int) */ public void setDocument(IDocument document, IAnnotationModel annotationModel, int visibleRegionOffset, int visibleRegionLength) { super.setDocument(document, annotationModel, visibleRegionOffset, visibleRegionLength); fOverviewRuler.setModel(annotationModel); } // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 public void updateIndentationPrefixes() { SourceViewerConfiguration configuration= getSourceViewerConfiguration(); String[] types= configuration.getConfiguredContentTypes(this); for (int i= 0; i < types.length; i++) { String[] prefixes= configuration.getIndentPrefixes(this, types[i]); if (prefixes != null && prefixes.length > 0) setIndentPrefixes(prefixes, types[i]); } } /* * @see IWidgetTokenOwner#requestWidgetToken(IWidgetTokenKeeper) */ public boolean requestWidgetToken(IWidgetTokenKeeper requester) { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19445 IHelp help= WorkbenchHelp.getHelpSupport(); if (help != null && help.isContextHelpDisplayed()) return false; return super.requestWidgetToken(requester); } }; static class TabConverter implements ITextConverter { private int fTabRatio; private ILineTracker fLineTracker; public TabConverter() { } public void setNumberOfSpacesPerTab(int ratio) { fTabRatio= ratio; } public void setLineTracker(ILineTracker lineTracker) { fLineTracker= lineTracker; } private int insertTabString(StringBuffer buffer, int offsetInLine) { if (fTabRatio == 0) return 0; int remainder= offsetInLine % fTabRatio; remainder= fTabRatio - remainder; for (int i= 0; i < remainder; i++) buffer.append(' '); return remainder; } public void customizeDocumentCommand(IDocument document, DocumentCommand command) { String text= command.text; if (text == null) return; int index= text.indexOf('\t'); if (index > -1) { StringBuffer buffer= new StringBuffer(); fLineTracker.set(command.text); int lines= fLineTracker.getNumberOfLines(); try { for (int i= 0; i < lines; i++) { int offset= fLineTracker.getLineOffset(i); int endOffset= offset + fLineTracker.getLineLength(i); String line= text.substring(offset, endOffset); int position= 0; if (i == 0) { IRegion firstLine= document.getLineInformationOfOffset(command.offset); position= command.offset - firstLine.getOffset(); } int length= line.length(); for (int j= 0; j < length; j++) { char c= line.charAt(j); if (c == '\t') { position += insertTabString(buffer, position); } else { buffer.append(c); ++ position; } } } command.text= buffer.toString(); } catch (BadLocationException x) { } } } }; private class PropertyChangeListener implements IPropertyChangeListener { /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { handlePreferencePropertyChanged(event); } } /* Preference key for code formatter tab size */ private final static String CODE_FORMATTER_TAB_SIZE= JavaCore.FORMATTER_TAB_SIZE; /** Preference key for matching brackets */ public final static String MATCHING_BRACKETS= "matchingBrackets"; //$NON-NLS-1$ /** Preference key for matching brackets color */ public final static String MATCHING_BRACKETS_COLOR= "matchingBracketsColor"; //$NON-NLS-1$ /** Preference key for highlighting current line */ public final static String CURRENT_LINE= "currentLine"; //$NON-NLS-1$ /** Preference key for highlight color of current line */ public final static String CURRENT_LINE_COLOR= "currentLineColor"; //$NON-NLS-1$ /** Preference key for showing print marging ruler */ public final static String PRINT_MARGIN= "printMargin"; //$NON-NLS-1$ /** Preference key for print margin ruler color */ public final static String PRINT_MARGIN_COLOR= "printMarginColor"; //$NON-NLS-1$ /** Preference key for print margin ruler column */ public final static String PRINT_MARGIN_COLUMN= "printMarginColumn"; //$NON-NLS-1$ /** Preference key for inserting spaces rather than tabs */ public final static String SPACES_FOR_TABS= JavaSourceViewerConfiguration.SPACES_FOR_TABS; /** Preference key for problem indication */ public final static String PROBLEM_INDICATION= "problemIndication"; //$NON-NLS-1$ /** Preference key for problem highlight color */ public final static String PROBLEM_INDICATION_COLOR= "problemIndicationColor"; //$NON-NLS-1$ /** Preference key for linked position color */ public final static String LINKED_POSITION_COLOR= "linkedPositionColor"; //$NON-NLS-1$ /** Preference key for shwoing the overview ruler */ public final static String OVERVIEW_RULER= "overviewRuler"; //$NON-NLS-1$ /** The status line clearer */ protected ISelectionChangedListener fStatusLineClearer; /** The editor's save policy */ protected ISavePolicy fSavePolicy; /** Listener to annotation model changes that updates the error tick in the tab image */ private JavaEditorErrorTickUpdater fJavaEditorErrorTickUpdater; /** The editor's paint manager */ private PaintManager fPaintManager; /** The editor's bracket painter */ private BracketPainter fBracketPainter; /** The editor's line painter */ private LinePainter fLinePainter; /** The editor's print margin ruler painter */ private PrintMarginPainter fPrintMarginPainter; /** The editor's problem painter */ private ProblemPainter fProblemPainter; /** The editor's tab converter */ private TabConverter fTabConverter; /** History for structure select action */ private SelectionHistory fSelectionHistory; /** The preference property change listener for java core. */ private IPropertyChangeListener fPropertyChangeListener= new PropertyChangeListener(); /** The remembered java element */ private IJavaElement fRememberedElement; /** The remembered selection */ private ITextSelection fRememberedSelection; /** The remembered java element offset */ private int fRememberedElementOffset; /** The standard action groups added to the menu */ private GenerateActionGroup fGenerateActionGroup; private CompositeActionGroup fContextMenuGroup; /** * Creates a new compilation unit editor. */ public CompilationUnitEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getCompilationUnitDocumentProvider()); setEditorContextMenuId("#CompilationUnitEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#CompilationUnitRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#CompilationUnitOutlinerContext"); //$NON-NLS-1$ // don't set help contextId, we install our own help context fSavePolicy= null; fJavaEditorErrorTickUpdater= new JavaEditorErrorTickUpdater(this); } /* * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "CorrectionAssistProposal.", this, JavaCorrectionSourceViewer.CORRECTIONASSIST_PROPOSALS); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CORRECTION_ASSIST_PROPOSALS); setAction("CorrectionAssistProposal", action); //$NON-NLS-1$ action= new ContentAssistAction(JavaEditorMessages.getResourceBundle(), "ContentAssistProposal.", this); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS); setAction("ContentAssistProposal", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ContentAssistContextInformation.", this, ISourceViewer.CONTENTASSIST_CONTEXT_INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_CONTEXT_INFORMATION); setAction("ContentAssistContextInformation", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Comment.", this, ITextOperationTarget.PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.COMMENT); setAction("Comment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Uncomment.", this, ITextOperationTarget.STRIP_PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.UNCOMMENT); setAction("Uncomment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Format.", this, ISourceViewer.FORMAT); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.FORMAT); setAction("Format", action); //$NON-NLS-1$ markAsStateDependentAction("CorrectionAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistContextInformation", true); //$NON-NLS-1$ markAsStateDependentAction("Comment", true); //$NON-NLS-1$ markAsStateDependentAction("Uncomment", true); //$NON-NLS-1$ markAsStateDependentAction("Format", true); //$NON-NLS-1$ fSelectionHistory= new SelectionHistory(this); action= new StructureSelectEnclosingAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_ENCLOSING); setAction(StructureSelectionAction.ENCLOSING, action); action= new StructureSelectNextAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_NEXT); setAction(StructureSelectionAction.NEXT, action); action= new StructureSelectPreviousAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_PREVIOUS); setAction(StructureSelectionAction.PREVIOUS, action); StructureSelectHistoryAction historyAction= new StructureSelectHistoryAction(this, fSelectionHistory); historyAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_LAST); setAction(StructureSelectionAction.HISTORY, historyAction); fSelectionHistory.setHistoryAction(historyAction); fGenerateActionGroup= new GenerateActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); ActionGroup rg= new RefactorActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); fActionGroups.addGroup(rg); fActionGroups.addGroup(fGenerateActionGroup); // We have to keep the context menu group separate to have better control over positioning fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] { fGenerateActionGroup, rg, new LocalHistoryActionGroup(this, ITextEditorActionConstants.GROUP_EDIT)}); } /* * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { return getElementAt(offset, true); } /** * Returns the most narrow element including the given offset. If <code>reconcile</code> * is <code>true</code> the editor's input element is reconciled in advance. If it is * <code>false</code> this method only returns a result if the editor's input element * does not need to be reconciled. * * @param offset the offset included by the retrieved element * @param reconcile <code>true</code> if working copy should be reconciled */ protected IJavaElement getElementAt(int offset, boolean reconcile) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { if (reconcile) { synchronized (unit) { unit.reconcile(); } return unit.getElementAt(offset); } else if (unit.isConsistent()) return unit.getElementAt(offset); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { try { return EditorUtility.getWorkingCopy(element, true); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } return null; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow(IMenuManager) */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Format"); //$NON-NLS-1$ ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /* * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); page.setInput(manager.getWorkingCopy(input)); } } /* * @see AbstractTextEditor#performSaveOperation(WorkspaceModifyOperation, IProgressMonitor) */ protected void performSaveOperation(WorkspaceModifyOperation operation, IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(fSavePolicy); } try { super.performSaveOperation(operation, progressMonitor); } finally { if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(null); } } } /* * @see AbstractTextEditor#doSave(IProgressMonitor) */ public void doSave(IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p == null) return; if (p.isDeleted(getEditorInput())) { if (isSaveAsAllowed()) { /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed Behavior to make sure that if called inside a regular save (because * of deletion of input element) there is a way to report back to the caller. */ performSaveAs(progressMonitor); } else { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Shell shell= getSite().getShell(); MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title1"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message1")); //$NON-NLS-1$ //$NON-NLS-2$ } } else { setStatusLineErrorMessage(null); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { performSaveOperation(createSaveOperation(false), progressMonitor); } } else performSaveOperation(createSaveOperation(false), progressMonitor); } } /** * Jumps to the error next according to the given direction. */ public void gotoError(boolean forward) { ISelectionProvider provider= getSelectionProvider(); if (fStatusLineClearer != null) { provider.removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } ITextSelection s= (ITextSelection) provider.getSelection(); Position errorPosition= new Position(0, 0); IProblemAnnotation nextError= getNextError(s.getOffset(), forward, errorPosition); if (nextError != null) { IMarker marker= null; if (nextError instanceof MarkerAnnotation) marker= ((MarkerAnnotation) nextError).getMarker(); else { Iterator e= nextError.getOverlaidIterator(); if (e != null) { while (e.hasNext()) { Object o= e.next(); if (o instanceof MarkerAnnotation) { marker= ((MarkerAnnotation) o).getMarker(); break; } } } } if (marker != null) { IWorkbenchPage page= getSite().getPage(); IViewPart view= view= page.findView("org.eclipse.ui.views.TaskList"); //$NON-NLS-1$ if (view instanceof TaskList) { StructuredSelection ss= new StructuredSelection(marker); ((TaskList) view).setSelection(ss, true); } } selectAndReveal(errorPosition.getOffset(), errorPosition.getLength()); setStatusLineErrorMessage(nextError.getMessage()); } else { setStatusLineErrorMessage(null); } } /** * Sets the given message as error message to this editor's status line. * @param msg message to be set */ protected void setStatusLineErrorMessage(String msg) { // set error message getStatusLineManager().setErrorMessage(msg); // install message remover if (msg == null || msg.trim().length() == 0) { if (fStatusLineClearer != null) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } } else if (fStatusLineClearer == null) { fStatusLineClearer= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; getStatusLineManager().setErrorMessage(null); } }; getSelectionProvider().addSelectionChangedListener(fStatusLineClearer); } } private IProblemAnnotation getNextError(int offset, boolean forward, Position errorPosition) { IProblemAnnotation nextError= null; Position nextErrorPosition= null; IDocument document= getDocumentProvider().getDocument(getEditorInput()); int endOfDocument= document.getLength(); int distance= 0; IAnnotationModel model= getDocumentProvider().getAnnotationModel(getEditorInput()); Iterator e= new ProblemAnnotationIterator(model, false); while (e.hasNext()) { IProblemAnnotation a= (IProblemAnnotation) e.next(); if (a.hasOverlay() || !a.isProblem()) continue; Position p= model.getPosition((Annotation) a); if (!p.includes(offset)) { int currentDistance= 0; if (forward) { currentDistance= p.getOffset() - offset; if (currentDistance < 0) currentDistance= endOfDocument - offset + p.getOffset(); } else { currentDistance= offset - p.getOffset(); if (currentDistance < 0) currentDistance= offset + endOfDocument - p.getOffset(); } if (nextError == null || currentDistance < distance) { distance= currentDistance; nextError= a; nextErrorPosition= p; } } } if (nextErrorPosition != null) { errorPosition.setOffset(nextErrorPosition.getOffset()); errorPosition.setLength(nextErrorPosition.getLength()); } return nextError; } /* * @see AbstractTextEditor#isSaveAsAllowed() */ public boolean isSaveAsAllowed() { return true; } /** * The compilation unit editor implementation of this <code>AbstractTextEditor</code> * method asks the user for the workspace path of a file resource and saves the document * there. See http://dev.eclipse.org/bugs/show_bug.cgi?id=6295 */ protected void performSaveAs(IProgressMonitor progressMonitor) { Shell shell= getSite().getShell(); SaveAsDialog dialog= new SaveAsDialog(shell); dialog.create(); IEditorInput input = getEditorInput(); IFile original= (input instanceof IFileEditorInput) ? ((IFileEditorInput) input).getFile() : null; if (original != null) dialog.setOriginalFile(original); IDocumentProvider provider= getDocumentProvider(); if (provider.isDeleted(input) && original != null) { String message= JavaEditorMessages.getFormattedString("CompilationUnitEditor.warning.save.delete", new Object[] { original.getName() }); //$NON-NLS-1$ dialog.setMessage(message, IMessageProvider.WARNING); } if (dialog.open() == Dialog.CANCEL) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IPath filePath= dialog.getResult(); if (filePath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IWorkspace workspace= ResourcesPlugin.getWorkspace(); IFile file= workspace.getRoot().getFile(filePath); final IEditorInput newInput= new FileEditorInput(file); WorkspaceModifyOperation op= new WorkspaceModifyOperation() { public void execute(final IProgressMonitor monitor) throws CoreException { getDocumentProvider().saveDocument(monitor, newInput, getDocumentProvider().getDocument(getEditorInput()), true); } }; boolean success= false; try { getDocumentProvider().aboutToChange(newInput); new ProgressMonitorDialog(shell).run(false, true, op); success= true; } catch (InterruptedException x) { } catch (InvocationTargetException x) { Throwable t= x.getTargetException(); if (t instanceof CoreException) { CoreException cx= (CoreException) t; ErrorDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title2"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message2"), cx.getStatus()); //$NON-NLS-1$ //$NON-NLS-2$ } else { MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title3"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message3") + t.getMessage()); //$NON-NLS-1$ //$NON-NLS-2$ } } finally { getDocumentProvider().changed(newInput); if (success) setInput(newInput); } if (progressMonitor != null) progressMonitor.setCanceled(!success); } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); configureTabConverter(); } private void startBracketHighlighting() { if (fBracketPainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fBracketPainter= new BracketPainter(sourceViewer); fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); fPaintManager.addPainter(fBracketPainter); } } private void stopBracketHighlighting() { if (fBracketPainter != null) { fPaintManager.removePainter(fBracketPainter); fBracketPainter.deactivate(true); fBracketPainter.dispose(); fBracketPainter= null; } } private boolean isBracketHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(MATCHING_BRACKETS); } private void startLineHighlighting() { if (fLinePainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fLinePainter= new LinePainter(sourceViewer); fLinePainter.setHighlightColor(getColor(CURRENT_LINE_COLOR)); fPaintManager.addPainter(fLinePainter); } } private void stopLineHighlighting() { if (fLinePainter != null) { fPaintManager.removePainter(fLinePainter); fLinePainter.deactivate(true); fLinePainter.dispose(); fLinePainter= null; } } private boolean isLineHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(CURRENT_LINE); } private void showPrintMargin() { if (fPrintMarginPainter == null) { fPrintMarginPainter= new PrintMarginPainter(getSourceViewer()); fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); fPaintManager.addPainter(fPrintMarginPainter); } } private void hidePrintMargin() { if (fPrintMarginPainter != null) { fPaintManager.removePainter(fPrintMarginPainter); fPrintMarginPainter.deactivate(true); fPrintMarginPainter.dispose(); fPrintMarginPainter= null; } } private boolean isPrintMarginVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PRINT_MARGIN); } private void startProblemIndication() { if (fProblemPainter == null) { fProblemPainter= new ProblemPainter(this, getSourceViewer()); fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); fPaintManager.addPainter(fProblemPainter); } } private void stopProblemIndication() { if (fProblemPainter != null) { fPaintManager.removePainter(fProblemPainter); fProblemPainter.deactivate(true); fProblemPainter.dispose(); fProblemPainter= null; } } private boolean isProblemIndicationEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PROBLEM_INDICATION); } private void configureTabConverter() { if (fTabConverter != null) { IDocumentProvider provider= getDocumentProvider(); if (provider instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cup= (CompilationUnitDocumentProvider) provider; fTabConverter.setLineTracker(cup.createLineTracker(getEditorInput())); } } } private int getTabSize() { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); return preferences.getInt(CODE_FORMATTER_TAB_SIZE); } private void startTabConversion() { if (fTabConverter == null) { fTabConverter= new TabConverter(); configureTabConverter(); fTabConverter.setNumberOfSpacesPerTab(getTabSize()); AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.addTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); } } private void stopTabConversion() { if (fTabConverter != null) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.removeTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); fTabConverter= null; } } private boolean isTabConversionEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(SPACES_FOR_TABS); } private void showOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.showOverviewRuler(); } private void hideOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.hideOverviewRuler(); } private boolean isOverviewRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(OVERVIEW_RULER); } private Color getColor(String key) { RGB rgb= PreferenceConverter.getColor(getPreferenceStore(), key); return getColor(rgb); } private Color getColor(RGB rgb) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.getColorManager().getColor(rgb); } /* * @see AbstractTextEditor#dispose() */ public void dispose() { if (fPropertyChangeListener != null) { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.removePropertyChangeListener(fPropertyChangeListener); fPropertyChangeListener= null; } if (fJavaEditorErrorTickUpdater != null) { fJavaEditorErrorTickUpdater.dispose(); fJavaEditorErrorTickUpdater= null; } if (fSelectionHistory != null) fSelectionHistory.dispose(); stopBracketHighlighting(); stopLineHighlighting(); if (fPaintManager != null) { fPaintManager.dispose(); fPaintManager= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /* * @see AbstractTextEditor#createPartControl(Composite) */ public void createPartControl(Composite parent) { super.createPartControl(parent); fPaintManager= new PaintManager(getSourceViewer()); if (isBracketHighlightingEnabled()) startBracketHighlighting(); if (isLineHighlightingEnabled()) startLineHighlighting(); if (isPrintMarginVisible()) showPrintMargin(); if (isProblemIndicationEnabled()) startProblemIndication(); if (isTabConversionEnabled()) startTabConversion(); if (isOverviewRulerVisible()) showOverviewRuler(); Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.addPropertyChangeListener(fPropertyChangeListener); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (SPACES_FOR_TABS.equals(p)) { if (isTabConversionEnabled()) startTabConversion(); else stopTabConversion(); return; } if (MATCHING_BRACKETS.equals(p)) { if (isBracketHighlightingEnabled()) startBracketHighlighting(); else stopBracketHighlighting(); return; } if (MATCHING_BRACKETS_COLOR.equals(p)) { if (fBracketPainter != null) fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); return; } if (CURRENT_LINE.equals(p)) { if (isLineHighlightingEnabled()) startLineHighlighting(); else stopLineHighlighting(); return; } if (CURRENT_LINE_COLOR.equals(p)) { if (fLinePainter != null) { stopLineHighlighting(); startLineHighlighting(); } return; } if (PRINT_MARGIN.equals(p)) { if (isPrintMarginVisible()) showPrintMargin(); else hidePrintMargin(); return; } if (PRINT_MARGIN_COLOR.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); return; } if (PRINT_MARGIN_COLUMN.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); return; } if (PROBLEM_INDICATION.equals(p)) { if (isProblemIndicationEnabled()) startProblemIndication(); else stopProblemIndication(); return; } if (PROBLEM_INDICATION_COLOR.equals(p)) { if (fProblemPainter != null) fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); return; } if (OVERVIEW_RULER.equals(p)) { if (isOverviewRulerVisible()) showOverviewRuler(); else hideOverviewRuler(); return; } IContentAssistant c= asv.getContentAssistant(); if (c instanceof ContentAssistant) ContentAssistPreference.changeConfiguration((ContentAssistant) c, getPreferenceStore(), event); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Handles a property change event describing a change * of the java core's preferences and updates the preference * related editor properties. * * @param event the property change event */ protected void handlePreferencePropertyChanged(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (CODE_FORMATTER_TAB_SIZE.equals(p)) { asv.updateIndentationPrefixes(); if (fTabConverter != null) fTabConverter.setNumberOfSpacesPerTab(getTabSize()); } } } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { String p= event.getProperty(); boolean affects=MATCHING_BRACKETS_COLOR.equals(p) || CURRENT_LINE_COLOR.equals(p) || PROBLEM_INDICATION_COLOR.equals(p); return affects ? affects : super.affectsTextPresentation(event); } /* * @see JavaEditor#createJavaSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return new AdaptedSourceViewer(parent, ruler, styles); } /* * @see JavaEditor#synchronizeOutlinePageSelection() */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret, false); ISourceReference reference= getSourceReference(element, caret); if (reference != null) fOutlinePage.select(reference); } private ISourceReference getSourceReference(IJavaElement element, int offset) { if ( !(element instanceof ISourceReference)) return null; if (element.getElementType() == IJavaElement.IMPORT_DECLARATION) { IImportDeclaration declaration= (IImportDeclaration) element; IImportContainer container= (IImportContainer) declaration.getParent(); ISourceRange srcRange= null; try { srcRange= container.getSourceRange(); } catch (JavaModelException e) { } if (srcRange != null && srcRange.getOffset() == offset) return container; } return (ISourceReference) element; } /* * @see IReconcilingParticipant#reconciled() */ public void reconciled() { if (!JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) { Shell shell= getSite().getShell(); if (shell != null && !shell.isDisposed()) { shell.getDisplay().asyncExec(new Runnable() { public void run() { synchronizeOutlinePageSelection(); } }); } } } protected void updateStateDependentActions() { super.updateStateDependentActions(); fGenerateActionGroup.editorStateChanged(); } /** * Returns the updated java element for the old java element. */ private IJavaElement findElement(IJavaElement element) { if (element == null) return null; IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { synchronized (unit) { unit.reconcile(); } IJavaElement[] findings= unit.findElements(element); if (findings != null && findings.length > 0) return findings[0]; } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /** * Returns the offset of the given Java element. */ private int getOffset(IJavaElement element) { if (element instanceof ISourceReference) { ISourceReference sr= (ISourceReference) element; try { ISourceRange srcRange= sr.getSourceRange(); if (srcRange != null) return srcRange.getOffset(); } catch (JavaModelException e) { } } return -1; } /* * @see AbstractTextEditor#rememberSelection() */ protected void rememberSelection() { ISelectionProvider sp= getSelectionProvider(); fRememberedSelection= (sp == null ? null : (ITextSelection) sp.getSelection()); if (fRememberedSelection != null) { fRememberedElement= getElementAt(fRememberedSelection.getOffset(), true); fRememberedElementOffset= getOffset(fRememberedElement); } } /* * @see AbstractTextEditor#restoreSelection() */ protected void restoreSelection() { try { if (getSourceViewer() == null || fRememberedSelection == null) return; IJavaElement newElement= findElement(fRememberedElement); int newOffset= getOffset(newElement); int offset= (newOffset > -1 && fRememberedElementOffset > -1) ? newOffset - fRememberedElementOffset : 0; selectAndReveal(offset + fRememberedSelection.getOffset(), fRememberedSelection.getLength()); } finally { fRememberedSelection= null; fRememberedElement= null; fRememberedElementOffset= -1; } } /* * @see AbstractTextEditor#canHandleMove(IEditorInput, IEditorInput) */ protected boolean canHandleMove(IEditorInput originalElement, IEditorInput movedElement) { String oldExtension= ""; //$NON-NLS-1$ if (originalElement instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) originalElement).getFile(); if (file != null) { String ext= file.getFileExtension(); if (ext != null) oldExtension= ext; } } String newExtension= ""; //$NON-NLS-1$ if (movedElement instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) movedElement).getFile(); if (file != null) newExtension= file.getFileExtension(); } return oldExtension.equals(newExtension); } }
20,533
Bug 20533 Unexpected popup closing eclipse with unsaved changes
Build 20020617 Win2k I'm not sure if this is core, but... - In the resource perspective, create a new simple project - Create a .txt file in this project - Type something in it (to flag it as modified) - close eclipse - it will ask you if you want to save it before exiting, save it Now you should see another dialog pop up saying: "The file has been changed on the file system. Do you want to load the changes? (Yes/No).
resolved fixed
0b1a139
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-24T11:03:53Z
2002-06-18T14:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitDocumentProvider.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.io.ByteArrayInputStream; import java.io.IOException; import java.io.InputStream; import java.util.ArrayList; import java.util.HashMap; import java.util.Hashtable; import java.util.Iterator; import java.util.List; import java.util.Map; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Status; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.GC; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Canvas; import org.eclipse.swt.widgets.Display; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.DefaultLineTracker; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.ILineTracker; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.AnnotationModelEvent; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.IAnnotationModelListener; import org.eclipse.jface.text.source.IAnnotationModelListenerExtension; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.ListenerList; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.editors.text.FileDocumentProvider; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.ResourceMarkerAnnotationModel; import org.eclipse.jdt.core.IBuffer; import org.eclipse.jdt.core.IBufferFactory; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaModelStatusConstants; import org.eclipse.jdt.core.IOpenable; import org.eclipse.jdt.core.IProblemRequestor; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.compiler.IProblem; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaStatusConstants; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.JavaUIStatus; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor; import org.eclipse.jdt.internal.ui.text.java.IProblemRequestorExtension; public class CompilationUnitDocumentProvider extends FileDocumentProvider implements IWorkingCopyManager { /** * Here for visibility issues only. */ protected class _FileSynchronizer extends FileSynchronizer { public _FileSynchronizer(IFileEditorInput fileEditorInput) { super(fileEditorInput); } }; /** * Bundle of all required informations to allow working copy management. */ protected class CompilationUnitInfo extends FileInfo { ICompilationUnit fCopy; CompilationUnitInfo(IDocument document, IAnnotationModel model, _FileSynchronizer fileSynchronizer, ICompilationUnit copy) { super(document, model, fileSynchronizer); fCopy= copy; } void setModificationStamp(long timeStamp) { fModificationStamp= timeStamp; } }; /** * Annotation representating an <code>IProblem</code>. */ static protected class ProblemAnnotation extends Annotation implements IProblemAnnotation { private static Image fgImage; private static boolean fgImageInitialized= false; private List fOverlaids; private IProblem fProblem; private Image fImage; private boolean fImageInitialized= false; public ProblemAnnotation(IProblem problem) { fProblem= problem; setLayer(MarkerAnnotation.PROBLEM_LAYER + 1); } private void initializeImage() { // http://bugs.eclipse.org/bugs/show_bug.cgi?id=18936 if (!fImageInitialized) { if (JavaEditorPreferencePage.showTempProblems() && JavaCorrectionProcessor.hasCorrections(fProblem.getID())) { if (!fgImageInitialized) { fgImage= JavaPluginImages.get(JavaPluginImages.IMG_OBJS_FIXABLE_PROBLEM); fgImageInitialized= true; } fImage= fgImage; } fImageInitialized= true; } } /* * @see Annotation#paint */ public void paint(GC gc, Canvas canvas, Rectangle r) { initializeImage(); if (fImage != null) drawImage(fImage, gc, canvas, r, SWT.CENTER, SWT.CENTER); } /* * @see IProblemAnnotation#getImage(Display) */ public Image getImage(Display display) { initializeImage(); return fImage; } /* * @see IProblemAnnotation#getMessage() */ public String getMessage() { return fProblem.getMessage(); } /* * @see IProblemAnnotation#isTemporaryProblem() */ public boolean isTemporaryProblem() { return true; } /* * @see IProblemAnnotation#isWarning() */ public boolean isWarning() { return fProblem.isWarning(); } /* * @see IProblemAnnotation#isError() */ public boolean isError() { return fProblem.isError(); } /* * @see IProblemAnnotation#getArguments() */ public String[] getArguments() { return fProblem.getArguments(); } /* * @see IProblemAnnotation#getId() */ public int getId() { return fProblem.getID(); } /* * @see IProblemAnnotation#isProblem() */ public boolean isProblem() { return true; } /* * @see IProblemAnnotation#isRelevant() */ public boolean isRelevant() { return true; } /* * @see IProblemAnnotation#hasOverlay() */ public boolean hasOverlay() { return false; } /* * @see IProblemAnnotation#addOverlaid(IProblemAnnotation) */ public void addOverlaid(IProblemAnnotation annotation) { if (fOverlaids == null) fOverlaids= new ArrayList(1); fOverlaids.add(annotation); } /* * @see IProblemAnnotation#removeOverlaid(IProblemAnnotation) */ public void removeOverlaid(IProblemAnnotation annotation) { if (fOverlaids != null) { fOverlaids.remove(annotation); if (fOverlaids.size() == 0) fOverlaids= null; } } /* * @see IProblemAnnotation#getOverlaidIterator() */ public Iterator getOverlaidIterator() { if (fOverlaids != null) return fOverlaids.iterator(); return null; } }; /** * Internal structure for mapping positions to some value. * The reason for this specific structure is that positions can * change over time. Thus a lookup is based on value and not * on hash value. */ protected static class ReverseMap { static class Entry { Position fPosition; Object fValue; }; private List fList= new ArrayList(2); private int fAnchor= 0; public ReverseMap() { } public Object get(Position position) { Entry entry; // behind anchor int length= fList.size(); for (int i= fAnchor; i < length; i++) { entry= (Entry) fList.get(i); if (entry.fPosition.equals(position)) { fAnchor= i; return entry.fValue; } } // before anchor for (int i= 0; i < fAnchor; i++) { entry= (Entry) fList.get(i); if (entry.fPosition.equals(position)) { fAnchor= i; return entry.fValue; } } return null; } private int getIndex(Position position) { Entry entry; int length= fList.size(); for (int i= 0; i < length; i++) { entry= (Entry) fList.get(i); if (entry.fPosition.equals(position)) return i; } return -1; } public void put(Position position, Object value) { int index= getIndex(position); if (index == -1) { Entry entry= new Entry(); entry.fPosition= position; entry.fValue= value; fList.add(entry); } else { Entry entry= (Entry) fList.get(index); entry.fValue= value; } } public void remove(Position position) { int index= getIndex(position); if (index > -1) fList.remove(index); } public void clear() { fList.clear(); } }; /** * Annotation model dealing with java marker annotations and temporary problems. * Also acts as problem requestor for its compilation unit. Initialiy inactive. Must explicitly be * activated. */ protected class CompilationUnitAnnotationModel extends ResourceMarkerAnnotationModel implements IProblemRequestor, IProblemRequestorExtension { private IFileEditorInput fInput; private List fCollectedProblems; private List fGeneratedAnnotations; private IProgressMonitor fProgressMonitor; private boolean fIsActive= false; private ReverseMap fReverseMap= new ReverseMap(); private List fPreviouslyShadowed= null; private List fCurrentlyShadowed= new ArrayList(); public CompilationUnitAnnotationModel(IFileEditorInput input) { super(input.getFile()); fInput= input; } protected MarkerAnnotation createMarkerAnnotation(IMarker marker) { return new JavaMarkerAnnotation(marker); } protected Position createPositionFromProblem(IProblem problem) { int start= problem.getSourceStart(); if (start < 0) return null; int length= problem.getSourceEnd() - problem.getSourceStart() + 1; if (length < 0) return null; return new Position(start, length); } /* * @see IProblemRequestor#beginReporting() */ public void beginReporting() { ICompilationUnit unit= getWorkingCopy(fInput); try { if (unit != null && unit.getJavaProject().isOnClasspath(unit)) fCollectedProblems= new ArrayList(); else fCollectedProblems= null; } catch (JavaModelException e) { fCollectedProblems= null; } } /* * @see IProblemRequestor#acceptProblem(IProblem) */ public void acceptProblem(IProblem problem) { if (isActive()) fCollectedProblems.add(problem); } /* * @see IProblemRequestor#endReporting() */ public void endReporting() { if (!isActive()) return; if (fProgressMonitor != null && fProgressMonitor.isCanceled()) return; boolean isCanceled= false; boolean temporaryProblemsChanged= false; fPreviouslyShadowed= fCurrentlyShadowed; fCurrentlyShadowed= new ArrayList(); synchronized (fAnnotations) { if (fGeneratedAnnotations.size() > 0) { temporaryProblemsChanged= true; removeAnnotations(fGeneratedAnnotations, false, true); fGeneratedAnnotations.clear(); } if (fCollectedProblems != null && fCollectedProblems.size() > 0) { Iterator e= fCollectedProblems.iterator(); while (e.hasNext()) { IProblem problem= (IProblem) e.next(); if (fProgressMonitor != null && fProgressMonitor.isCanceled()) { isCanceled= true; break; } Position position= createPositionFromProblem(problem); if (position != null) { ProblemAnnotation annotation= new ProblemAnnotation(problem); overlayMarkers(position, annotation); fGeneratedAnnotations.add(annotation); addAnnotation(annotation, position, false); temporaryProblemsChanged= true; } } fCollectedProblems.clear(); } removeMarkerOverlays(isCanceled); fPreviouslyShadowed.clear(); fPreviouslyShadowed= null; } if (temporaryProblemsChanged) fireModelChanged(new CompilationUnitAnnotationModelEvent(this, getResource(), false)); } private void removeMarkerOverlays(boolean isCanceled) { if (isCanceled) { fCurrentlyShadowed.addAll(fPreviouslyShadowed); } else { Iterator e= fPreviouslyShadowed.iterator(); while (e.hasNext()) { JavaMarkerAnnotation annotation= (JavaMarkerAnnotation) e.next(); annotation.setOverlay(null); } } } private void setOverlay(Object value, ProblemAnnotation problemAnnotation) { if (value instanceof JavaMarkerAnnotation) { JavaMarkerAnnotation annotation= (JavaMarkerAnnotation) value; if (annotation.isProblem()) { annotation.setOverlay(problemAnnotation); fPreviouslyShadowed.remove(annotation); fCurrentlyShadowed.add(annotation); } } } private void overlayMarkers(Position position, ProblemAnnotation problemAnnotation) { Object value= getAnnotations(position); if (value instanceof List) { List list= (List) value; for (Iterator e = list.iterator(); e.hasNext();) setOverlay(e.next(), problemAnnotation); } else { setOverlay(value, problemAnnotation); } } /** * Tells this annotation model to collect temporary problems from now on. */ private void startCollectingProblems() { fCollectedProblems= new ArrayList(); fGeneratedAnnotations= new ArrayList(); } /** * Tells this annotation model to no longer collect temporary problems. */ private void stopCollectingProblems() { if (fGeneratedAnnotations != null) { removeAnnotations(fGeneratedAnnotations, true, true); fGeneratedAnnotations.clear(); } fCollectedProblems= null; fGeneratedAnnotations= null; } /* * @see AnnotationModel#fireModelChanged() */ protected void fireModelChanged() { fireModelChanged(new CompilationUnitAnnotationModelEvent(this, getResource(), true)); } /* * @see IProblemRequestor#isActive() */ public boolean isActive() { return fIsActive && (fCollectedProblems != null); } /* * @see IProblemRequestorExtension#setProgressMonitor(IProgressMonitor) */ public void setProgressMonitor(IProgressMonitor monitor) { fProgressMonitor= monitor; } /* * @see IProblemRequestorExtension#setIsActive(boolean) */ public void setIsActive(boolean isActive) { if (fIsActive != isActive) { fIsActive= isActive; if (fIsActive) startCollectingProblems(); else stopCollectingProblems(); } } private Object getAnnotations(Position position) { return fReverseMap.get(position); } /* * @see AnnotationModel#addAnnotation(Annotation, Position, boolean) */ protected void addAnnotation(Annotation annotation, Position position, boolean fireModelChanged) { super.addAnnotation(annotation, position, fireModelChanged); Object cached= fReverseMap.get(position); if (cached == null) fReverseMap.put(position, annotation); else if (cached instanceof List) { List list= (List) cached; list.add(annotation); } else if (cached instanceof Annotation) { List list= new ArrayList(2); list.add(cached); list.add(annotation); fReverseMap.put(position, list); } } /* * @see AnnotationModel#removeAllAnnotations(boolean) */ protected void removeAllAnnotations(boolean fireModelChanged) { super.removeAllAnnotations(fireModelChanged); fReverseMap.clear(); } /* * @see AnnotationModel#removeAnnotation(Annotation, boolean) */ protected void removeAnnotation(Annotation annotation, boolean fireModelChanged) { Position position= getPosition(annotation); Object cached= fReverseMap.get(position); if (cached instanceof List) { List list= (List) cached; list.remove(annotation); if (list.size() == 1) { fReverseMap.put(position, list.get(0)); list.clear(); } } else if (cached instanceof Annotation) { fReverseMap.remove(position); } super.removeAnnotation(annotation, fireModelChanged); } }; /** * Creates <code>IBuffer</code>s based on documents. */ protected class BufferFactory implements IBufferFactory { private IDocument internalGetDocument(IFileEditorInput input) throws CoreException { IDocument document= getDocument(input); if (document != null) return document; return CompilationUnitDocumentProvider.this.createDocument(input); } public IBuffer createBuffer(IOpenable owner) { if (owner instanceof ICompilationUnit) { ICompilationUnit unit= (ICompilationUnit) owner; try { ICompilationUnit original= (ICompilationUnit) unit.getOriginalElement(); IResource resource= original.getCorrespondingResource(); if (resource instanceof IFile) { IFileEditorInput providerKey= new FileEditorInput((IFile) resource); IDocument document= null; IStatus status= null; try { document= internalGetDocument(providerKey); } catch (CoreException x) { status= x.getStatus(); document= new Document(); initializeDocument(document); } DocumentAdapter adapter= new DocumentAdapter(unit, document, new DefaultLineTracker(), CompilationUnitDocumentProvider.this, providerKey); adapter.setStatus(status); return adapter; } } catch (CoreException x) { handleCoreException(x, JavaUIMessages.getString("CompilationUnitDocumentProvider.problemsCreatingBuffer")); //$NON-NLS-1$ } } return DocumentAdapter.NULL; } }; protected static class GlobalAnnotationModelListener implements IAnnotationModelListener, IAnnotationModelListenerExtension { private ListenerList fListenerList; public GlobalAnnotationModelListener() { fListenerList= new ListenerList(); } /** * @see IAnnotationModelListener#modelChanged(IAnnotationModel) */ public void modelChanged(IAnnotationModel model) { Object[] listeners= fListenerList.getListeners(); for (int i= 0; i < listeners.length; i++) { ((IAnnotationModelListener) listeners[i]).modelChanged(model); } } /** * @see IAnnotationModelListenerExtension#modelChanged(AnnotationModelEvent) */ public void modelChanged(AnnotationModelEvent event) { Object[] listeners= fListenerList.getListeners(); for (int i= 0; i < listeners.length; i++) { Object curr= listeners[i]; if (curr instanceof IAnnotationModelListenerExtension) { ((IAnnotationModelListenerExtension) curr).modelChanged(event); } } } public void addListener(IAnnotationModelListener listener) { fListenerList.add(listener); } public void removeListener(IAnnotationModelListener listener) { fListenerList.remove(listener); } }; /** * Document that can also be used by a background reconciler. */ protected static class PartiallySynchronizedDocument extends Document { /* * @see IDocumentExtension#startSequentialRewrite(boolean) */ synchronized public void startSequentialRewrite(boolean normalized) { super.startSequentialRewrite(normalized); } /* * @see IDocumentExtension#stopSequentialRewrite() */ synchronized public void stopSequentialRewrite() { super.stopSequentialRewrite(); } /* * @see IDocument#get() */ synchronized public String get() { return super.get(); } /* * @see IDocument#get(int, int) */ synchronized public String get(int offset, int length) throws BadLocationException { return super.get(offset, length); } /* * @see IDocument#getChar(int) */ synchronized public char getChar(int offset) throws BadLocationException { return super.getChar(offset); } /* * @see IDocument#replace(int, int, String) */ synchronized public void replace(int offset, int length, String text) throws BadLocationException { super.replace(offset, length, text); } /* * @see IDocument#set(String) */ synchronized public void set(String text) { super.set(text); } }; /* Preference key for temporary problems */ public final static String HANDLE_TEMPORARY_PROBLEMS= "handleTemporaryProblems"; //$NON-NLS-1$ /** The buffer factory */ private IBufferFactory fBufferFactory= new BufferFactory(); /** Indicates whether the save has been initialized by this provider */ private boolean fIsAboutToSave= false; /** The save policy used by this provider */ private ISavePolicy fSavePolicy; /** Internal property changed listener */ private IPropertyChangeListener fPropertyListener; /** annotation model listener added to all created CU annotation models */ private GlobalAnnotationModelListener fGlobalAnnotationModelListener; /** * Constructor */ public CompilationUnitDocumentProvider() { fPropertyListener= new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { if (HANDLE_TEMPORARY_PROBLEMS.equals(event.getProperty())) enableHandlingTemporaryProblems(); } }; fGlobalAnnotationModelListener= new GlobalAnnotationModelListener(); JavaPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(fPropertyListener); } /** * Sets the document provider's save policy. */ public void setSavePolicy(ISavePolicy savePolicy) { fSavePolicy= savePolicy; } /** * Creates a compilation unit from the given file. * * @param file the file from which to create the compilation unit */ protected ICompilationUnit createCompilationUnit(IFile file) { Object element= JavaCore.create(file); if (element instanceof ICompilationUnit) return (ICompilationUnit) element; return null; } /** * Creates a line tracker working with the same line delimiters as the document * of the given element. Assumes the element to be managed by this document provider. * * @param element the element serving as blue print * @return a line tracker based on the same line delimiters as the element's document */ public ILineTracker createLineTracker(Object element) { return new DefaultLineTracker(); } /* * @see AbstractDocumentProvider#createElementInfo(Object) */ protected ElementInfo createElementInfo(Object element) throws CoreException { if ( !(element instanceof IFileEditorInput)) return super.createElementInfo(element); IFileEditorInput input= (IFileEditorInput) element; ICompilationUnit original= createCompilationUnit(input.getFile()); if (original != null) { try { IProgressMonitor monitor= new NullProgressMonitor(); try { input.getFile().refreshLocal(IResource.DEPTH_INFINITE, monitor); } catch (CoreException x) { handleCoreException(x, JavaEditorMessages.getString("CompilationUnitDocumentProvider.error.createElementInfo")); //$NON-NLS-1$ } IAnnotationModel m= createCompilationUnitAnnotationModel(input); IProblemRequestor r= m instanceof IProblemRequestor ? (IProblemRequestor) m : null; ICompilationUnit c= (ICompilationUnit) original.getSharedWorkingCopy(monitor, fBufferFactory, r); DocumentAdapter a= null; try { a= (DocumentAdapter) c.getBuffer(); } catch (ClassCastException x) { IStatus status= new Status(IStatus.ERROR, JavaUI.ID_PLUGIN, JavaStatusConstants.TEMPLATE_IO_EXCEPTION, "Shared working copy has wrong buffer", x); //$NON-NLS-1$ throw new CoreException(status); } _FileSynchronizer f= new _FileSynchronizer(input); f.install(); CompilationUnitInfo info= new CompilationUnitInfo(a.getDocument(), m, f, c); info.setModificationStamp(computeModificationStamp(input.getFile())); info.fStatus= a.getStatus(); if (r instanceof IProblemRequestorExtension) { IProblemRequestorExtension extension= (IProblemRequestorExtension) r; extension.setIsActive(isHandlingTemporaryProblems()); } m.addAnnotationModelListener(fGlobalAnnotationModelListener); return info; } catch (JavaModelException x) { throw new CoreException(x.getStatus()); } } else { return super.createElementInfo(element); } } /* * @see AbstractDocumentProvider#disposeElementInfo(Object, ElementInfo) */ protected void disposeElementInfo(Object element, ElementInfo info) { if (info instanceof CompilationUnitInfo) { CompilationUnitInfo cuInfo= (CompilationUnitInfo) info; cuInfo.fCopy.destroy(); cuInfo.fModel.removeAnnotationModelListener(fGlobalAnnotationModelListener); } super.disposeElementInfo(element, info); } /* * @see AbstractDocumentProvider#doSaveDocument(IProgressMonitor, Object, IDocument, boolean) */ protected void doSaveDocument(IProgressMonitor monitor, Object element, IDocument document, boolean overwrite) throws CoreException { ElementInfo elementInfo= getElementInfo(element); if (elementInfo instanceof CompilationUnitInfo) { CompilationUnitInfo info= (CompilationUnitInfo) elementInfo; // update structure, assumes lock on info.fCopy info.fCopy.reconcile(); ICompilationUnit original= (ICompilationUnit) info.fCopy.getOriginalElement(); IResource resource= null; try { resource= original.getUnderlyingResource(); } catch (JavaModelException x) { // workaround for http://bugs.eclipse.org/bugs/show_bug.cgi?id=14940 } if (resource == null) { // underlying resource has been deleted, just recreate file, ignore the rest super.doSaveDocument(monitor, element, document, overwrite); return; } if (resource != null && !overwrite) checkSynchronizationState(info.fModificationStamp, resource); if (fSavePolicy != null) fSavePolicy.preSave(info.fCopy); try { fIsAboutToSave= true; // commit working copy info.fCopy.commit(overwrite, monitor); } finally { fIsAboutToSave= false; } AbstractMarkerAnnotationModel model= (AbstractMarkerAnnotationModel) info.fModel; model.updateMarkers(info.fDocument); if (resource != null) info.setModificationStamp(computeModificationStamp(resource)); if (fSavePolicy != null) { ICompilationUnit unit= fSavePolicy.postSave(original); if (unit != null) { IResource r= unit.getUnderlyingResource(); IMarker[] markers= r.findMarkers(IMarker.MARKER, true, IResource.DEPTH_ZERO); if (markers != null && markers.length > 0) { for (int i= 0; i < markers.length; i++) model.updateMarker(markers[i], info.fDocument, null); } } } } else { super.doSaveDocument(monitor, element, document, overwrite); } } /** * Replaces createAnnotionModel of the super class. */ protected IAnnotationModel createCompilationUnitAnnotationModel(Object element) throws CoreException { if ( !(element instanceof IFileEditorInput)) throw new CoreException(new JavaUIStatus(IJavaModelStatusConstants.INVALID_RESOURCE_TYPE)); IFileEditorInput input= (IFileEditorInput) element; return new CompilationUnitAnnotationModel(input); } protected void initializeDocument(IDocument document) { if (document != null) { JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); IDocumentPartitioner partitioner= tools.createDocumentPartitioner(); document.setDocumentPartitioner(partitioner); partitioner.connect(document); } } /* * @see AbstractDocumentProvider#createDocument(Object) */ protected IDocument createDocument(Object element) throws CoreException { if (element instanceof IEditorInput) { Document document= new PartiallySynchronizedDocument(); if (setDocumentContent(document, (IEditorInput) element, getEncoding(element))) { initializeDocument(document); return document; } } return null; } /* * @see AbstractDocumentProvider#resetDocument(Object) */ public void resetDocument(Object element) throws CoreException { if (element == null) return; ElementInfo elementInfo= getElementInfo(element); if (elementInfo instanceof CompilationUnitInfo) { CompilationUnitInfo info= (CompilationUnitInfo) elementInfo; IDocument document; IStatus status= null; try { ICompilationUnit original= (ICompilationUnit) info.fCopy.getOriginalElement(); IResource resource= original.getUnderlyingResource(); if (resource instanceof IFile) { IFile file= (IFile) resource; IProgressMonitor monitor= new NullProgressMonitor(); try { // http://dev.eclipse.org/bugs/show_bug.cgi?id=19014 file.refreshLocal(IResource.DEPTH_INFINITE, monitor); } catch (CoreException x) { handleCoreException(x, JavaEditorMessages.getString("CompilationUnitDocumentProvider.error.resetDocument")); //$NON-NLS-1$ } IFileEditorInput input= new FileEditorInput(file); document= super.createDocument(input); } else { document= new Document(); } } catch (CoreException x) { document= new Document(); status= x.getStatus(); } fireElementContentAboutToBeReplaced(element); removeUnchangedElementListeners(element, info); info.fDocument.set(document.get()); info.fCanBeSaved= false; info.fStatus= status; addUnchangedElementListeners(element, info); fireElementContentReplaced(element); } else { super.resetDocument(element); } } /** * Saves the content of the given document to the given element. * This is only performed when this provider initiated the save. * * @param monitor the progress monitor * @param element the element to which to save * @param document the document to save * @param overwrite <code>true</code> if the save should be enforced */ public void saveDocumentContent(IProgressMonitor monitor, Object element, IDocument document, boolean overwrite) throws CoreException { if (!fIsAboutToSave) return; if (element instanceof IFileEditorInput) { IFileEditorInput input= (IFileEditorInput) element; try { InputStream stream= new ByteArrayInputStream(document.get().getBytes(ResourcesPlugin.getEncoding())); IFile file= input.getFile(); file.setContents(stream, overwrite, true, monitor); } catch (IOException x) { IStatus s= new Status(IStatus.ERROR, JavaUI.ID_PLUGIN, IStatus.OK, x.getMessage(), x); throw new CoreException(s); } } } /** * Returns the underlying resource for the given element. * * @param the element * @return the underlying resource of the given element */ public IResource getUnderlyingResource(Object element) { if (element instanceof IFileEditorInput) { IFileEditorInput input= (IFileEditorInput) element; return input.getFile(); } return null; } /* * @see IWorkingCopyManager#connect(IEditorInput) */ public void connect(IEditorInput input) throws CoreException { super.connect(input); } /* * @see IWorkingCopyManager#disconnect(IEditorInput) */ public void disconnect(IEditorInput input) { super.disconnect(input); } /* * @see IWorkingCopyManager#getWorkingCopy(Object) */ public ICompilationUnit getWorkingCopy(IEditorInput element) { ElementInfo elementInfo= getElementInfo(element); if (elementInfo instanceof CompilationUnitInfo) { CompilationUnitInfo info= (CompilationUnitInfo) elementInfo; return info.fCopy; } return null; } /** * Gets the BufferFactory. */ public IBufferFactory getBufferFactory() { return fBufferFactory; } public void shutdown() { JavaPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(fPropertyListener); Iterator e= getConnectedElements(); while (e.hasNext()) disconnect(e.next()); } /** * Returns the preference whether handling temporary problems is enabled. */ protected boolean isHandlingTemporaryProblems() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(HANDLE_TEMPORARY_PROBLEMS); } /** * Switches the state of problem acceptance according to the value in the preference store. */ protected void enableHandlingTemporaryProblems() { boolean enable= isHandlingTemporaryProblems(); for (Iterator iter= getConnectedElements(); iter.hasNext();) { ElementInfo element= getElementInfo(iter.next()); if (element instanceof CompilationUnitInfo) { CompilationUnitInfo info= (CompilationUnitInfo)element; if (info.fModel instanceof IProblemRequestorExtension) { IProblemRequestorExtension extension= (IProblemRequestorExtension) info.fModel; extension.setIsActive(enable); } } } } /** * Adds a listener that reports changes from all compilation unit annotation models. */ public void addGlobalAnnotationModelListener(IAnnotationModelListener listener) { fGlobalAnnotationModelListener.addListener(listener); } /** * Removes the listener. */ public void removeGlobalAnnotationModelListener(IAnnotationModelListener listener) { fGlobalAnnotationModelListener.removeListener(listener); } }
20,674
Bug 20674 JavaCapabilityConfigurationPage.init is not clearing the default path when classpath already exists
F4 JavaCapabilityConfigurationPage.init: The doc states that when defaultsOverrideExistingClasspath is set to false and a .classpath file already exists the setting from the classpath file is taken. code is defaultOutputLocation= null; defaultOutputLocation= null; is meant to be defaultOutputLocation= null; defaultEntries= null; Class is API and this bug would prevent cliants from using the functionality. No dependences so far, fix is riskless.
resolved fixed
f85f2b3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-24T11:11:40Z
2002-06-19T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/wizards/JavaCapabilityConfigurationPage.java
package org.eclipse.jdt.ui.wizards; import java.lang.reflect.InvocationTargetException; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IProjectDescription; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.buildpaths.BuildPathsBlock; /** * Standard wizard page for creating new Java projects. This page can be used in * project creation wizards for projects and in capability install wizards. The page * shows UI to configure the project with a Java build path and output location. On * finish the page will also configure the Java nature. * This is a replace for <code>NewJavaProjectWizardPage</code> with a cleaner API. */ public class JavaCapabilityConfigurationPage extends NewElementWizardPage { private static final String PAGE_NAME= "JavaCapabilityConfigurationPage"; //$NON-NLS-1$ private IJavaProject fJavaProject; private BuildPathsBlock fBuildPathsBlock; /** * Creates a wizard page that can be used in a Java project creation wizard or * in a capability install wizard. * It contains UI to configure a the classpath and the output folder. * * <p> * After constructing, a call to <code>init</code> is required * </p> */ public JavaCapabilityConfigurationPage() { super(PAGE_NAME); fJavaProject= null; setTitle(NewWizardMessages.getString("JavaCapabilityConfigurationPage.title")); //$NON-NLS-1$ setDescription(NewWizardMessages.getString("JavaCapabilityConfigurationPage.description")); //$NON-NLS-1$ IStatusChangeListener listener= new IStatusChangeListener() { public void statusChanged(IStatus status) { updateStatus(status); } }; fBuildPathsBlock= new BuildPathsBlock(ResourcesPlugin.getWorkspace().getRoot(), listener, true); } /** * Initializes the page with the project and default classpaths. * <p> * The default classpath entries must correspond the the given project. * </p> * <p> * The caller of this method is responsible for creating the underlying project. The page will create the output folder * and source and library folders if required. * </p> * <p> * The project does not have to exist at the time of initialization, but must exist when executing the runnable * obtained by <code>getRunnable()</code>. * </p> * @param project The Java project. * @param entries The default classpath entries or <code>null</code> to let the page choose the default * @param path The folder to be taken as the default output path or <code>null</code> to let the page choose the default * @return overrideExistingClasspath If set to <code>true</code>, an existing '.classpath' file is ignored. If set to <code>false</code> * the given default classpath and output location is only used if no '.classpath' exists. */ public void init(IJavaProject jproject, IPath defaultOutputLocation, IClasspathEntry[] defaultEntries, boolean defaultsOverrideExistingClasspath) { if (!defaultsOverrideExistingClasspath && jproject.exists() && jproject.getProject().getFile(".classpath").exists()) { //$NON-NLS-1$ defaultOutputLocation= null; defaultOutputLocation= null; } fBuildPathsBlock.init(jproject, defaultOutputLocation, defaultEntries); fJavaProject= jproject; } /* (non-Javadoc) * @see WizardPage#createControl */ public void createControl(Composite parent) { Control control= fBuildPathsBlock.createControl(parent); setControl(control); WorkbenchHelp.setHelp(control, IJavaHelpContextIds.NEW_JAVAPROJECT_WIZARD_PAGE); } /** * Returns the currently configured output location. Note that the returned path might not be a valid path. */ public IPath getOutputLocation() { return fBuildPathsBlock.getOutputLocation(); } /** * Returns the currently configured class path. Note that the class path might not be valid. */ public IClasspathEntry[] getRawClassPath() { return fBuildPathsBlock.getRawClassPath(); } /** * Returns the Java project that was passed in <code>init</code> or <code>null</code> if the page has not * been initialized yet. */ public IJavaProject getJavaProject() { return fJavaProject; } /** * Returns the runnable that will create the Java project or <code>null</code> if the page has not been initialized. * The runnable sets the project's classpath and output location to the values configured in the page and * adds the Java nature if not yet set. It assumes that the project is created and opened. * * @return the runnable */ public IRunnableWithProgress getRunnable() { if (getJavaProject() != null) { return new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { try { configureJavaProject(monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }; } return null; } /** * Adds the Java nature to the project (if not yet set) and configures the build class paths */ public void configureJavaProject(IProgressMonitor monitor) throws CoreException, InterruptedException { if (monitor == null) { monitor= new NullProgressMonitor(); } int nSteps= 5; monitor.beginTask(NewWizardMessages.getString("JavaCapabilityConfigurationPage.op_desc"), nSteps); //$NON-NLS-1$ try { IProject project= getJavaProject().getProject(); fBuildPathsBlock.addJavaNature(project, new SubProgressMonitor(monitor, 1)); fBuildPathsBlock.configureJavaProject(new SubProgressMonitor(monitor, 5)); } finally { monitor.done(); } } }
20,885
Bug 20885 Search match not revealed when in the single element view
0) enable single element view (full preference settings will be attached) 1) do a reference search for JavaPlugin.getDirtyEditors() 2) double click on a match ->the match gets quickly revealed and then the editor jumps to the top again.
resolved fixed
4af747f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-26T11:15:23Z
2002-06-24T14:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Layout; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Preferences; import org.eclipse.core.runtime.Preferences.IPropertyChangeListener; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IMessageProvider; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.DocumentCommand; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ILineTracker; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.IWidgetTokenKeeper; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewerConfiguration; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.ContentAssistAction; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.tasklist.TaskList; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.compare.LocalHistoryActionGroup; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.SelectionHistory; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectEnclosingAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectHistoryAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectNextAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectPreviousAction; import org.eclipse.jdt.internal.ui.javaeditor.structureselection.StructureSelectionAction; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionSourceViewer; import org.eclipse.jdt.internal.ui.text.java.IReconcilingParticipant; /** * Java specific text editor. */ public class CompilationUnitEditor extends JavaEditor implements IReconcilingParticipant { interface ITextConverter { void customizeDocumentCommand(IDocument document, DocumentCommand command); }; class AdaptedRulerLayout extends Layout { protected int fGap; protected AdaptedSourceViewer fAdaptedSourceViewer; protected AdaptedRulerLayout(int gap, AdaptedSourceViewer asv) { fGap= gap; fAdaptedSourceViewer= asv; } protected Point computeSize(Composite composite, int wHint, int hHint, boolean flushCache) { Control[] children= composite.getChildren(); Point s= children[children.length - 1].computeSize(SWT.DEFAULT, SWT.DEFAULT, flushCache); if (fAdaptedSourceViewer.isVerticalRulerVisible()) s.x += fAdaptedSourceViewer.getVerticalRuler().getWidth() + fGap; return s; } protected void layout(Composite composite, boolean flushCache) { Rectangle clArea= composite.getClientArea(); if (fAdaptedSourceViewer.isVerticalRulerVisible()) { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); Rectangle trim= textWidget.computeTrim(0, 0, 0, 0); int scrollbarHeight= trim.height; IVerticalRuler vr= fAdaptedSourceViewer.getVerticalRuler(); int vrWidth=vr.getWidth(); int orWidth= 0; if (fAdaptedSourceViewer.isOverviewRulerVisible()) { OverviewRuler or= fAdaptedSourceViewer.getOverviewRuler(); orWidth= or.getWidth(); or.getControl().setBounds(clArea.width - orWidth, scrollbarHeight, orWidth, clArea.height - 3*scrollbarHeight); } textWidget.setBounds(vrWidth + fGap, 0, clArea.width - vrWidth - orWidth - 2*fGap, clArea.height); vr.getControl().setBounds(0, 0, vrWidth, clArea.height - scrollbarHeight); } else { StyledText textWidget= fAdaptedSourceViewer.getTextWidget(); textWidget.setBounds(0, 0, clArea.width, clArea.height); } } }; class AdaptedSourceViewer extends JavaCorrectionSourceViewer { private List fTextConverters; private OverviewRuler fOverviewRuler; private boolean fIsOverviewRulerVisible; private boolean fIgnoreTextConverters= false; private IVerticalRuler fCachedVerticalRuler; private boolean fCachedIsVerticalRulerVisible; public AdaptedSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { super(parent, ruler, styles, CompilationUnitEditor.this); fCachedVerticalRuler= ruler; fCachedIsVerticalRulerVisible= (ruler != null); fOverviewRuler= new OverviewRuler(VERTICAL_RULER_WIDTH); delayedCreateControl(parent, styles); } /* * @see ISourceViewer#showAnnotations(boolean) */ public void showAnnotations(boolean show) { fCachedIsVerticalRulerVisible= (show && fCachedVerticalRuler != null); super.showAnnotations(show); } public IContentAssistant getContentAssistant() { return fContentAssistant; } /* * @see ITextOperationTarget#doOperation(int) */ public void doOperation(int operation) { if (getTextWidget() == null) return; switch (operation) { case CONTENTASSIST_PROPOSALS: String msg= fContentAssistant.showPossibleCompletions(); setStatusLineErrorMessage(msg); return; case UNDO: fIgnoreTextConverters= true; break; case REDO: fIgnoreTextConverters= true; break; } super.doOperation(operation); } public void insertTextConverter(ITextConverter textConverter, int index) { throw new UnsupportedOperationException(); } public void addTextConverter(ITextConverter textConverter) { if (fTextConverters == null) { fTextConverters= new ArrayList(1); fTextConverters.add(textConverter); } else if (!fTextConverters.contains(textConverter)) fTextConverters.add(textConverter); } public void removeTextConverter(ITextConverter textConverter) { if (fTextConverters != null) { fTextConverters.remove(textConverter); if (fTextConverters.size() == 0) fTextConverters= null; } } /* * @see TextViewer#customizeDocumentCommand(DocumentCommand) */ protected void customizeDocumentCommand(DocumentCommand command) { super.customizeDocumentCommand(command); if (!fIgnoreTextConverters && fTextConverters != null) { for (Iterator e = fTextConverters.iterator(); e.hasNext();) ((ITextConverter) e.next()).customizeDocumentCommand(getDocument(), command); } fIgnoreTextConverters= false; } public IVerticalRuler getVerticalRuler() { return fCachedVerticalRuler; } public boolean isVerticalRulerVisible() { return fCachedIsVerticalRulerVisible; } public OverviewRuler getOverviewRuler() { return fOverviewRuler; } /* * @see TextViewer#createControl(Composite, int) */ protected void createControl(Composite parent, int styles) { // do nothing here } protected void delayedCreateControl(Composite parent, int styles) { //create the viewer super.createControl(parent, styles); Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.setLayout(new AdaptedRulerLayout(GAP_SIZE, this)); fOverviewRuler.createControl(composite, this); } } public void hideOverviewRuler() { fIsOverviewRulerVisible= false; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public void showOverviewRuler() { fIsOverviewRulerVisible= true; Control control= getControl(); if (control instanceof Composite) { Composite composite= (Composite) control; composite.layout(); } } public boolean isOverviewRulerVisible() { return fIsOverviewRulerVisible; } /* * @see ISourceViewer#setDocument(IDocument, IAnnotationModel, int, int) */ public void setDocument(IDocument document, IAnnotationModel annotationModel, int visibleRegionOffset, int visibleRegionLength) { super.setDocument(document, annotationModel, visibleRegionOffset, visibleRegionLength); fOverviewRuler.setModel(annotationModel); } // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 public void updateIndentationPrefixes() { SourceViewerConfiguration configuration= getSourceViewerConfiguration(); String[] types= configuration.getConfiguredContentTypes(this); for (int i= 0; i < types.length; i++) { String[] prefixes= configuration.getIndentPrefixes(this, types[i]); if (prefixes != null && prefixes.length > 0) setIndentPrefixes(prefixes, types[i]); } } /* * @see IWidgetTokenOwner#requestWidgetToken(IWidgetTokenKeeper) */ public boolean requestWidgetToken(IWidgetTokenKeeper requester) { if (WorkbenchHelp.isContextHelpDisplayed()) return false; return super.requestWidgetToken(requester); } }; static class TabConverter implements ITextConverter { private int fTabRatio; private ILineTracker fLineTracker; public TabConverter() { } public void setNumberOfSpacesPerTab(int ratio) { fTabRatio= ratio; } public void setLineTracker(ILineTracker lineTracker) { fLineTracker= lineTracker; } private int insertTabString(StringBuffer buffer, int offsetInLine) { if (fTabRatio == 0) return 0; int remainder= offsetInLine % fTabRatio; remainder= fTabRatio - remainder; for (int i= 0; i < remainder; i++) buffer.append(' '); return remainder; } public void customizeDocumentCommand(IDocument document, DocumentCommand command) { String text= command.text; if (text == null) return; int index= text.indexOf('\t'); if (index > -1) { StringBuffer buffer= new StringBuffer(); fLineTracker.set(command.text); int lines= fLineTracker.getNumberOfLines(); try { for (int i= 0; i < lines; i++) { int offset= fLineTracker.getLineOffset(i); int endOffset= offset + fLineTracker.getLineLength(i); String line= text.substring(offset, endOffset); int position= 0; if (i == 0) { IRegion firstLine= document.getLineInformationOfOffset(command.offset); position= command.offset - firstLine.getOffset(); } int length= line.length(); for (int j= 0; j < length; j++) { char c= line.charAt(j); if (c == '\t') { position += insertTabString(buffer, position); } else { buffer.append(c); ++ position; } } } command.text= buffer.toString(); } catch (BadLocationException x) { } } } }; private class PropertyChangeListener implements IPropertyChangeListener { /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { handlePreferencePropertyChanged(event); } } /* Preference key for code formatter tab size */ private final static String CODE_FORMATTER_TAB_SIZE= JavaCore.FORMATTER_TAB_SIZE; /** Preference key for matching brackets */ public final static String MATCHING_BRACKETS= "matchingBrackets"; //$NON-NLS-1$ /** Preference key for matching brackets color */ public final static String MATCHING_BRACKETS_COLOR= "matchingBracketsColor"; //$NON-NLS-1$ /** Preference key for highlighting current line */ public final static String CURRENT_LINE= "currentLine"; //$NON-NLS-1$ /** Preference key for highlight color of current line */ public final static String CURRENT_LINE_COLOR= "currentLineColor"; //$NON-NLS-1$ /** Preference key for showing print marging ruler */ public final static String PRINT_MARGIN= "printMargin"; //$NON-NLS-1$ /** Preference key for print margin ruler color */ public final static String PRINT_MARGIN_COLOR= "printMarginColor"; //$NON-NLS-1$ /** Preference key for print margin ruler column */ public final static String PRINT_MARGIN_COLUMN= "printMarginColumn"; //$NON-NLS-1$ /** Preference key for inserting spaces rather than tabs */ public final static String SPACES_FOR_TABS= JavaSourceViewerConfiguration.SPACES_FOR_TABS; /** Preference key for problem indication */ public final static String PROBLEM_INDICATION= "problemIndication"; //$NON-NLS-1$ /** Preference key for problem highlight color */ public final static String PROBLEM_INDICATION_COLOR= "problemIndicationColor"; //$NON-NLS-1$ /** Preference key for linked position color */ public final static String LINKED_POSITION_COLOR= "linkedPositionColor"; //$NON-NLS-1$ /** Preference key for shwoing the overview ruler */ public final static String OVERVIEW_RULER= "overviewRuler"; //$NON-NLS-1$ /** The status line clearer */ protected ISelectionChangedListener fStatusLineClearer; /** The editor's save policy */ protected ISavePolicy fSavePolicy; /** Listener to annotation model changes that updates the error tick in the tab image */ private JavaEditorErrorTickUpdater fJavaEditorErrorTickUpdater; /** The editor's paint manager */ private PaintManager fPaintManager; /** The editor's bracket painter */ private BracketPainter fBracketPainter; /** The editor's line painter */ private LinePainter fLinePainter; /** The editor's print margin ruler painter */ private PrintMarginPainter fPrintMarginPainter; /** The editor's problem painter */ private ProblemPainter fProblemPainter; /** The editor's tab converter */ private TabConverter fTabConverter; /** History for structure select action */ private SelectionHistory fSelectionHistory; /** The preference property change listener for java core. */ private IPropertyChangeListener fPropertyChangeListener= new PropertyChangeListener(); /** The remembered java element */ private IJavaElement fRememberedElement; /** The remembered selection */ private ITextSelection fRememberedSelection; /** The remembered java element offset */ private int fRememberedElementOffset; /** The standard action groups added to the menu */ private GenerateActionGroup fGenerateActionGroup; private CompositeActionGroup fContextMenuGroup; /** * Creates a new compilation unit editor. */ public CompilationUnitEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getCompilationUnitDocumentProvider()); setEditorContextMenuId("#CompilationUnitEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#CompilationUnitRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#CompilationUnitOutlinerContext"); //$NON-NLS-1$ // don't set help contextId, we install our own help context fSavePolicy= null; fJavaEditorErrorTickUpdater= new JavaEditorErrorTickUpdater(this); } /* * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "CorrectionAssistProposal.", this, JavaCorrectionSourceViewer.CORRECTIONASSIST_PROPOSALS); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CORRECTION_ASSIST_PROPOSALS); setAction("CorrectionAssistProposal", action); //$NON-NLS-1$ action= new ContentAssistAction(JavaEditorMessages.getResourceBundle(), "ContentAssistProposal.", this); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_PROPOSALS); setAction("ContentAssistProposal", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ContentAssistContextInformation.", this, ISourceViewer.CONTENTASSIST_CONTEXT_INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONTENT_ASSIST_CONTEXT_INFORMATION); setAction("ContentAssistContextInformation", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Comment.", this, ITextOperationTarget.PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.COMMENT); setAction("Comment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Uncomment.", this, ITextOperationTarget.STRIP_PREFIX); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.UNCOMMENT); setAction("Uncomment", action); //$NON-NLS-1$ action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Format.", this, ISourceViewer.FORMAT); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.FORMAT); setAction("Format", action); //$NON-NLS-1$ markAsStateDependentAction("CorrectionAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistProposal", true); //$NON-NLS-1$ markAsStateDependentAction("ContentAssistContextInformation", true); //$NON-NLS-1$ markAsStateDependentAction("Comment", true); //$NON-NLS-1$ markAsStateDependentAction("Uncomment", true); //$NON-NLS-1$ markAsStateDependentAction("Format", true); //$NON-NLS-1$ fSelectionHistory= new SelectionHistory(this); action= new StructureSelectEnclosingAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_ENCLOSING); setAction(StructureSelectionAction.ENCLOSING, action); action= new StructureSelectNextAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_NEXT); setAction(StructureSelectionAction.NEXT, action); action= new StructureSelectPreviousAction(this, fSelectionHistory); action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_PREVIOUS); setAction(StructureSelectionAction.PREVIOUS, action); StructureSelectHistoryAction historyAction= new StructureSelectHistoryAction(this, fSelectionHistory); historyAction.setActionDefinitionId(IJavaEditorActionDefinitionIds.SELECT_LAST); setAction(StructureSelectionAction.HISTORY, historyAction); fSelectionHistory.setHistoryAction(historyAction); fGenerateActionGroup= new GenerateActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); ActionGroup rg= new RefactorActionGroup(this, ITextEditorActionConstants.GROUP_EDIT); fActionGroups.addGroup(rg); fActionGroups.addGroup(fGenerateActionGroup); // We have to keep the context menu group separate to have better control over positioning fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] { fGenerateActionGroup, rg, new LocalHistoryActionGroup(this, ITextEditorActionConstants.GROUP_EDIT)}); } /* * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { return getElementAt(offset, true); } /** * Returns the most narrow element including the given offset. If <code>reconcile</code> * is <code>true</code> the editor's input element is reconciled in advance. If it is * <code>false</code> this method only returns a result if the editor's input element * does not need to be reconciled. * * @param offset the offset included by the retrieved element * @param reconcile <code>true</code> if working copy should be reconciled */ protected IJavaElement getElementAt(int offset, boolean reconcile) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { if (reconcile) { synchronized (unit) { unit.reconcile(); } return unit.getElementAt(offset); } else if (unit.isConsistent()) return unit.getElementAt(offset); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { try { return EditorUtility.getWorkingCopy(element, true); } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } return null; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow(IMenuManager) */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Format"); //$NON-NLS-1$ ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /* * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); page.setInput(manager.getWorkingCopy(input)); } } /* * @see AbstractTextEditor#performSaveOperation(WorkspaceModifyOperation, IProgressMonitor) */ protected void performSaveOperation(WorkspaceModifyOperation operation, IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(fSavePolicy); } try { super.performSaveOperation(operation, progressMonitor); } finally { if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(null); } } } /* * @see AbstractTextEditor#doSave(IProgressMonitor) */ public void doSave(IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p == null) return; if (p.isDeleted(getEditorInput())) { if (isSaveAsAllowed()) { /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed Behavior to make sure that if called inside a regular save (because * of deletion of input element) there is a way to report back to the caller. */ performSaveAs(progressMonitor); } else { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Shell shell= getSite().getShell(); MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title1"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message1")); //$NON-NLS-1$ //$NON-NLS-2$ } } else { setStatusLineErrorMessage(null); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { performSaveOperation(createSaveOperation(false), progressMonitor); } } else performSaveOperation(createSaveOperation(false), progressMonitor); } } /** * Jumps to the error next according to the given direction. */ public void gotoError(boolean forward) { ISelectionProvider provider= getSelectionProvider(); if (fStatusLineClearer != null) { provider.removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } ITextSelection s= (ITextSelection) provider.getSelection(); Position errorPosition= new Position(0, 0); IProblemAnnotation nextError= getNextError(s.getOffset(), forward, errorPosition); if (nextError != null) { IMarker marker= null; if (nextError instanceof MarkerAnnotation) marker= ((MarkerAnnotation) nextError).getMarker(); else { Iterator e= nextError.getOverlaidIterator(); if (e != null) { while (e.hasNext()) { Object o= e.next(); if (o instanceof MarkerAnnotation) { marker= ((MarkerAnnotation) o).getMarker(); break; } } } } if (marker != null) { IWorkbenchPage page= getSite().getPage(); IViewPart view= view= page.findView("org.eclipse.ui.views.TaskList"); //$NON-NLS-1$ if (view instanceof TaskList) { StructuredSelection ss= new StructuredSelection(marker); ((TaskList) view).setSelection(ss, true); } } selectAndReveal(errorPosition.getOffset(), errorPosition.getLength()); setStatusLineErrorMessage(nextError.getMessage()); } else { setStatusLineErrorMessage(null); } } /** * Sets the given message as error message to this editor's status line. * @param msg message to be set */ protected void setStatusLineErrorMessage(String msg) { // set error message getStatusLineManager().setErrorMessage(msg); // install message remover if (msg == null || msg.trim().length() == 0) { if (fStatusLineClearer != null) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } } else if (fStatusLineClearer == null) { fStatusLineClearer= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; getStatusLineManager().setErrorMessage(null); } }; getSelectionProvider().addSelectionChangedListener(fStatusLineClearer); } } private IProblemAnnotation getNextError(int offset, boolean forward, Position errorPosition) { IProblemAnnotation nextError= null; Position nextErrorPosition= null; IDocument document= getDocumentProvider().getDocument(getEditorInput()); int endOfDocument= document.getLength(); int distance= 0; IAnnotationModel model= getDocumentProvider().getAnnotationModel(getEditorInput()); Iterator e= new ProblemAnnotationIterator(model, false); while (e.hasNext()) { IProblemAnnotation a= (IProblemAnnotation) e.next(); if (a.hasOverlay() || !a.isProblem()) continue; Position p= model.getPosition((Annotation) a); if (!p.includes(offset)) { int currentDistance= 0; if (forward) { currentDistance= p.getOffset() - offset; if (currentDistance < 0) currentDistance= endOfDocument - offset + p.getOffset(); } else { currentDistance= offset - p.getOffset(); if (currentDistance < 0) currentDistance= offset + endOfDocument - p.getOffset(); } if (nextError == null || currentDistance < distance) { distance= currentDistance; nextError= a; nextErrorPosition= p; } } } if (nextErrorPosition != null) { errorPosition.setOffset(nextErrorPosition.getOffset()); errorPosition.setLength(nextErrorPosition.getLength()); } return nextError; } /* * @see AbstractTextEditor#isSaveAsAllowed() */ public boolean isSaveAsAllowed() { return true; } /** * The compilation unit editor implementation of this <code>AbstractTextEditor</code> * method asks the user for the workspace path of a file resource and saves the document * there. See http://dev.eclipse.org/bugs/show_bug.cgi?id=6295 */ protected void performSaveAs(IProgressMonitor progressMonitor) { Shell shell= getSite().getShell(); SaveAsDialog dialog= new SaveAsDialog(shell); dialog.create(); IEditorInput input = getEditorInput(); IFile original= (input instanceof IFileEditorInput) ? ((IFileEditorInput) input).getFile() : null; if (original != null) dialog.setOriginalFile(original); IDocumentProvider provider= getDocumentProvider(); if (provider.isDeleted(input) && original != null) { String message= JavaEditorMessages.getFormattedString("CompilationUnitEditor.warning.save.delete", new Object[] { original.getName() }); //$NON-NLS-1$ dialog.setMessage(message, IMessageProvider.WARNING); } if (dialog.open() == Dialog.CANCEL) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IPath filePath= dialog.getResult(); if (filePath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IWorkspace workspace= ResourcesPlugin.getWorkspace(); IFile file= workspace.getRoot().getFile(filePath); final IEditorInput newInput= new FileEditorInput(file); WorkspaceModifyOperation op= new WorkspaceModifyOperation() { public void execute(final IProgressMonitor monitor) throws CoreException { getDocumentProvider().saveDocument(monitor, newInput, getDocumentProvider().getDocument(getEditorInput()), true); } }; boolean success= false; try { getDocumentProvider().aboutToChange(newInput); new ProgressMonitorDialog(shell).run(false, true, op); success= true; } catch (InterruptedException x) { } catch (InvocationTargetException x) { Throwable t= x.getTargetException(); if (t instanceof CoreException) { CoreException cx= (CoreException) t; ErrorDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title2"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message2"), cx.getStatus()); //$NON-NLS-1$ //$NON-NLS-2$ } else { MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title3"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message3") + t.getMessage()); //$NON-NLS-1$ //$NON-NLS-2$ } } finally { getDocumentProvider().changed(newInput); if (success) setInput(newInput); } if (progressMonitor != null) progressMonitor.setCanceled(!success); } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); configureTabConverter(); } private void startBracketHighlighting() { if (fBracketPainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fBracketPainter= new BracketPainter(sourceViewer); fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); fPaintManager.addPainter(fBracketPainter); } } private void stopBracketHighlighting() { if (fBracketPainter != null) { fPaintManager.removePainter(fBracketPainter); fBracketPainter.deactivate(true); fBracketPainter.dispose(); fBracketPainter= null; } } private boolean isBracketHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(MATCHING_BRACKETS); } private void startLineHighlighting() { if (fLinePainter == null) { ISourceViewer sourceViewer= getSourceViewer(); fLinePainter= new LinePainter(sourceViewer); fLinePainter.setHighlightColor(getColor(CURRENT_LINE_COLOR)); fPaintManager.addPainter(fLinePainter); } } private void stopLineHighlighting() { if (fLinePainter != null) { fPaintManager.removePainter(fLinePainter); fLinePainter.deactivate(true); fLinePainter.dispose(); fLinePainter= null; } } private boolean isLineHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(CURRENT_LINE); } private void showPrintMargin() { if (fPrintMarginPainter == null) { fPrintMarginPainter= new PrintMarginPainter(getSourceViewer()); fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); fPaintManager.addPainter(fPrintMarginPainter); } } private void hidePrintMargin() { if (fPrintMarginPainter != null) { fPaintManager.removePainter(fPrintMarginPainter); fPrintMarginPainter.deactivate(true); fPrintMarginPainter.dispose(); fPrintMarginPainter= null; } } private boolean isPrintMarginVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PRINT_MARGIN); } private void startProblemIndication() { if (fProblemPainter == null) { fProblemPainter= new ProblemPainter(this, getSourceViewer()); fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); fPaintManager.addPainter(fProblemPainter); } } private void stopProblemIndication() { if (fProblemPainter != null) { fPaintManager.removePainter(fProblemPainter); fProblemPainter.deactivate(true); fProblemPainter.dispose(); fProblemPainter= null; } } private boolean isProblemIndicationEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(PROBLEM_INDICATION); } private void configureTabConverter() { if (fTabConverter != null) { IDocumentProvider provider= getDocumentProvider(); if (provider instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cup= (CompilationUnitDocumentProvider) provider; fTabConverter.setLineTracker(cup.createLineTracker(getEditorInput())); } } } private int getTabSize() { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); return preferences.getInt(CODE_FORMATTER_TAB_SIZE); } private void startTabConversion() { if (fTabConverter == null) { fTabConverter= new TabConverter(); configureTabConverter(); fTabConverter.setNumberOfSpacesPerTab(getTabSize()); AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.addTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); } } private void stopTabConversion() { if (fTabConverter != null) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.removeTextConverter(fTabConverter); // http://dev.eclipse.org/bugs/show_bug.cgi?id=19270 asv.updateIndentationPrefixes(); fTabConverter= null; } } private boolean isTabConversionEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(SPACES_FOR_TABS); } private void showOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.showOverviewRuler(); } private void hideOverviewRuler() { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); asv.hideOverviewRuler(); } private boolean isOverviewRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(OVERVIEW_RULER); } private Color getColor(String key) { RGB rgb= PreferenceConverter.getColor(getPreferenceStore(), key); return getColor(rgb); } private Color getColor(RGB rgb) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.getColorManager().getColor(rgb); } /* * @see AbstractTextEditor#dispose() */ public void dispose() { if (fPropertyChangeListener != null) { Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.removePropertyChangeListener(fPropertyChangeListener); fPropertyChangeListener= null; } if (fJavaEditorErrorTickUpdater != null) { fJavaEditorErrorTickUpdater.dispose(); fJavaEditorErrorTickUpdater= null; } if (fSelectionHistory != null) fSelectionHistory.dispose(); stopBracketHighlighting(); stopLineHighlighting(); if (fPaintManager != null) { fPaintManager.dispose(); fPaintManager= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /* * @see AbstractTextEditor#createPartControl(Composite) */ public void createPartControl(Composite parent) { super.createPartControl(parent); fPaintManager= new PaintManager(getSourceViewer()); if (isBracketHighlightingEnabled()) startBracketHighlighting(); if (isLineHighlightingEnabled()) startLineHighlighting(); if (isPrintMarginVisible()) showPrintMargin(); if (isProblemIndicationEnabled()) startProblemIndication(); if (isTabConversionEnabled()) startTabConversion(); if (isOverviewRulerVisible()) showOverviewRuler(); Preferences preferences= JavaCore.getPlugin().getPluginPreferences(); preferences.addPropertyChangeListener(fPropertyChangeListener); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (SPACES_FOR_TABS.equals(p)) { if (isTabConversionEnabled()) startTabConversion(); else stopTabConversion(); return; } if (MATCHING_BRACKETS.equals(p)) { if (isBracketHighlightingEnabled()) startBracketHighlighting(); else stopBracketHighlighting(); return; } if (MATCHING_BRACKETS_COLOR.equals(p)) { if (fBracketPainter != null) fBracketPainter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); return; } if (CURRENT_LINE.equals(p)) { if (isLineHighlightingEnabled()) startLineHighlighting(); else stopLineHighlighting(); return; } if (CURRENT_LINE_COLOR.equals(p)) { if (fLinePainter != null) { stopLineHighlighting(); startLineHighlighting(); } return; } if (PRINT_MARGIN.equals(p)) { if (isPrintMarginVisible()) showPrintMargin(); else hidePrintMargin(); return; } if (PRINT_MARGIN_COLOR.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColor(getColor(PRINT_MARGIN_COLOR)); return; } if (PRINT_MARGIN_COLUMN.equals(p)) { if (fPrintMarginPainter != null) fPrintMarginPainter.setMarginRulerColumn(getPreferenceStore().getInt(PRINT_MARGIN_COLUMN)); return; } if (PROBLEM_INDICATION.equals(p)) { if (isProblemIndicationEnabled()) startProblemIndication(); else stopProblemIndication(); return; } if (PROBLEM_INDICATION_COLOR.equals(p)) { if (fProblemPainter != null) fProblemPainter.setHighlightColor(getColor(PROBLEM_INDICATION_COLOR)); return; } if (OVERVIEW_RULER.equals(p)) { if (isOverviewRulerVisible()) showOverviewRuler(); else hideOverviewRuler(); return; } IContentAssistant c= asv.getContentAssistant(); if (c instanceof ContentAssistant) ContentAssistPreference.changeConfiguration((ContentAssistant) c, getPreferenceStore(), event); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Handles a property change event describing a change * of the java core's preferences and updates the preference * related editor properties. * * @param event the property change event */ protected void handlePreferencePropertyChanged(org.eclipse.core.runtime.Preferences.PropertyChangeEvent event) { AdaptedSourceViewer asv= (AdaptedSourceViewer) getSourceViewer(); if (asv != null) { String p= event.getProperty(); if (CODE_FORMATTER_TAB_SIZE.equals(p)) { asv.updateIndentationPrefixes(); if (fTabConverter != null) fTabConverter.setNumberOfSpacesPerTab(getTabSize()); } } } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { String p= event.getProperty(); boolean affects=MATCHING_BRACKETS_COLOR.equals(p) || CURRENT_LINE_COLOR.equals(p) || PROBLEM_INDICATION_COLOR.equals(p); return affects ? affects : super.affectsTextPresentation(event); } /* * @see JavaEditor#createJavaSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return new AdaptedSourceViewer(parent, ruler, styles); } /* * @see JavaEditor#synchronizeOutlinePageSelection() */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret, false); ISourceReference reference= getSourceReference(element, caret); if (reference != null) fOutlinePage.select(reference); } private ISourceReference getSourceReference(IJavaElement element, int offset) { if ( !(element instanceof ISourceReference)) return null; if (element.getElementType() == IJavaElement.IMPORT_DECLARATION) { IImportDeclaration declaration= (IImportDeclaration) element; IImportContainer container= (IImportContainer) declaration.getParent(); ISourceRange srcRange= null; try { srcRange= container.getSourceRange(); } catch (JavaModelException e) { } if (srcRange != null && srcRange.getOffset() == offset) return container; } return (ISourceReference) element; } /* * @see IReconcilingParticipant#reconciled() */ public void reconciled() { if (!JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) { Shell shell= getSite().getShell(); if (shell != null && !shell.isDisposed()) { shell.getDisplay().asyncExec(new Runnable() { public void run() { synchronizeOutlinePageSelection(); } }); } } } protected void updateStateDependentActions() { super.updateStateDependentActions(); fGenerateActionGroup.editorStateChanged(); } /** * Returns the updated java element for the old java element. */ private IJavaElement findElement(IJavaElement element) { if (element == null) return null; IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { try { synchronized (unit) { unit.reconcile(); } IJavaElement[] findings= unit.findElements(element); if (findings != null && findings.length > 0) return findings[0]; } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); // nothing found, be tolerant and go on } } return null; } /** * Returns the offset of the given Java element. */ private int getOffset(IJavaElement element) { if (element instanceof ISourceReference) { ISourceReference sr= (ISourceReference) element; try { ISourceRange srcRange= sr.getSourceRange(); if (srcRange != null) return srcRange.getOffset(); } catch (JavaModelException e) { } } return -1; } /* * @see AbstractTextEditor#rememberSelection() */ protected void rememberSelection() { ISelectionProvider sp= getSelectionProvider(); fRememberedSelection= (sp == null ? null : (ITextSelection) sp.getSelection()); if (fRememberedSelection != null) { fRememberedElement= getElementAt(fRememberedSelection.getOffset(), true); fRememberedElementOffset= getOffset(fRememberedElement); } } /* * @see AbstractTextEditor#restoreSelection() */ protected void restoreSelection() { try { if (getSourceViewer() == null || fRememberedSelection == null) return; IJavaElement newElement= findElement(fRememberedElement); int newOffset= getOffset(newElement); int offset= (newOffset > -1 && fRememberedElementOffset > -1) ? newOffset - fRememberedElementOffset : 0; selectAndReveal(offset + fRememberedSelection.getOffset(), fRememberedSelection.getLength()); } finally { fRememberedSelection= null; fRememberedElement= null; fRememberedElementOffset= -1; } } /* * @see AbstractTextEditor#canHandleMove(IEditorInput, IEditorInput) */ protected boolean canHandleMove(IEditorInput originalElement, IEditorInput movedElement) { String oldExtension= ""; //$NON-NLS-1$ if (originalElement instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) originalElement).getFile(); if (file != null) { String ext= file.getFileExtension(); if (ext != null) oldExtension= ext; } } String newExtension= ""; //$NON-NLS-1$ if (movedElement instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) movedElement).getFile(); if (file != null) newExtension= file.getFileExtension(); } return oldExtension.equals(newExtension); } }
20,885
Bug 20885 Search match not revealed when in the single element view
0) enable single element view (full preference settings will be attached) 1) do a reference search for JavaPlugin.getDirtyEditors() 2) double click on a match ->the match gets quickly revealed and then the editor jumps to the top again.
resolved fixed
4af747f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-06-26T11:15:23Z
2002-06-24T14:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/JavaEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.custom.BidiSegmentEvent; import org.eclipse.swt.custom.BidiSegmentListener; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.ITypedRegion; import org.eclipse.jface.text.source.AnnotationRulerColumn; import org.eclipse.jface.text.source.CompositeRuler; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.IVerticalRulerColumn; import org.eclipse.jface.text.source.LineNumberRulerColumn; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.ui.IEditorActionBarContributor; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IPartService; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.editors.text.DefaultEncodingSupport; import org.eclipse.ui.editors.text.IEncodingSupport; import org.eclipse.ui.part.EditorActionBarContributor; import org.eclipse.ui.texteditor.DefaultRangeIndicator; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.StatusTextEditor; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.contentoutline.IContentOutlinePage; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageDeclaration; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.JavaSearchActionGroup; import org.eclipse.jdt.ui.actions.OpenEditorActionGroup; import org.eclipse.jdt.ui.actions.OpenViewActionGroup; import org.eclipse.jdt.ui.actions.ShowActionGroup; import org.eclipse.jdt.ui.text.IColorManager; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.JavaPartitionScanner; import org.eclipse.jdt.internal.ui.util.JavaUIHelp; /** * Java specific text editor. */ public abstract class JavaEditor extends StatusTextEditor { /** * "Smart" runnable for updating the outline page's selection. */ class OutlinePageSelectionUpdater implements Runnable { /** Has the runnable already been posted? */ private boolean fPosted= false; public OutlinePageSelectionUpdater() { } /* * @see Runnable#run() */ public void run() { synchronizeOutlinePageSelection(); fPosted= false; } /** * Posts this runnable into the event queue. */ public void post() { if (fPosted) return; Shell shell= getSite().getShell(); if (shell != null & !shell.isDisposed()) { fPosted= true; shell.getDisplay().asyncExec(this); } } }; class SelectionChangedListener implements ISelectionChangedListener { public void selectionChanged(SelectionChangedEvent event) { doSelectionChanged(event); } }; /** Preference key for showing the line number ruler */ public final static String LINE_NUMBER_RULER= "lineNumberRuler"; //$NON-NLS-1$ /** Preference key for the foreground color of the line numbers */ public final static String LINE_NUMBER_COLOR= "lineNumberColor"; //$NON-NLS-1$ /** The outline page */ protected JavaOutlinePage fOutlinePage; /** Outliner context menu Id */ protected String fOutlinerContextMenuId; /** The selection changed listener */ private ISelectionChangedListener fSelectionChangedListener= new SelectionChangedListener(); /** The outline page selection updater */ private OutlinePageSelectionUpdater fUpdater; /** Indicates whether this editor should react on outline page selection changes */ private int fIgnoreOutlinePageSelection; /** The line number ruler column */ private LineNumberRulerColumn fLineNumberRulerColumn; /** This editor's encoding support */ private DefaultEncodingSupport fEncodingSupport; protected CompositeActionGroup fActionGroups; private CompositeActionGroup fContextMenuGroup; /** * Returns the most narrow java element including the given offset * * @param offset the offset inside of the requested element */ abstract protected IJavaElement getElementAt(int offset); /** * Returns the java element of this editor's input corresponding to the given IJavaElement */ abstract protected IJavaElement getCorrespondingElement(IJavaElement element); /** * Sets the input of the editor's outline page. */ abstract protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input); /** * Default constructor. */ public JavaEditor() { super(); JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); setSourceViewerConfiguration(new JavaSourceViewerConfiguration(textTools, this)); setRangeIndicator(new DefaultRangeIndicator()); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); if (JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) fUpdater= new OutlinePageSelectionUpdater(); } /* * @see AbstractTextEditor#createSourceViewer(Composite, IVerticalRuler, int) */ protected final ISourceViewer createSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { ISourceViewer viewer= createJavaSourceViewer(parent, ruler, styles); StyledText text= viewer.getTextWidget(); text.addBidiSegmentListener(new BidiSegmentListener() { public void lineGetSegments(BidiSegmentEvent event) { event.segments= getBidiLineSegments(event.lineOffset, event.lineText); } }); JavaUIHelp.setHelp(this, text, IJavaHelpContextIds.JAVA_EDITOR); return viewer; } /* * @see AbstractTextEditor#createSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return super.createSourceViewer(parent, ruler, styles); } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.affectsBehavior(event); } /** * Sets the outliner's context menu ID. */ protected void setOutlinerContextMenuId(String menuId) { fOutlinerContextMenuId= menuId; } /** * Returns the standard action group of this editor. */ protected ActionGroup getActionGroup() { return fActionGroups; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); menu.appendToGroup(ITextEditorActionConstants.GROUP_UNDO, new Separator(IContextMenuConstants.GROUP_OPEN)); menu.insertAfter(IContextMenuConstants.GROUP_OPEN, new GroupMarker(IContextMenuConstants.GROUP_SHOW)); ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /** * Creates the outline page used with this editor. */ protected JavaOutlinePage createOutlinePage() { JavaOutlinePage page= new JavaOutlinePage(fOutlinerContextMenuId, this); page.addSelectionChangedListener(fSelectionChangedListener); setOutlinePageInput(page, getEditorInput()); return page; } /** * Informs the editor that its outliner has been closed. */ public void outlinePageClosed() { if (fOutlinePage != null) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage= null; resetHighlightRange(); } } /** * Synchronizes the outliner selection with the actual cursor * position in the editor. */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret); if (element instanceof ISourceReference) fOutlinePage.select((ISourceReference) element); } /* * Get the desktop's StatusLineManager */ protected IStatusLineManager getStatusLineManager() { IEditorActionBarContributor contributor= getEditorSite().getActionBarContributor(); if (contributor instanceof EditorActionBarContributor) { return ((EditorActionBarContributor) contributor).getActionBars().getStatusLineManager(); } return null; } /* * @see AbstractTextEditor#getAdapter(Class) */ public Object getAdapter(Class required) { if (IContentOutlinePage.class.equals(required)) { if (fOutlinePage == null) fOutlinePage= createOutlinePage(); return fOutlinePage; } if (IEncodingSupport.class.equals(required)) return fEncodingSupport; return super.getAdapter(required); } protected void setSelection(ISourceReference reference, boolean moveCursor) { if (reference != null) { StyledText textWidget= null; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer != null) textWidget= sourceViewer.getTextWidget(); if (textWidget == null) return; try { ISourceRange range= reference.getSourceRange(); if (range == null) return; int offset= range.getOffset(); int length= range.getLength(); if (offset < 0 || length < 0) return; textWidget.setRedraw(false); setHighlightRange(offset, length, moveCursor); if (!moveCursor) return; offset= -1; length= -1; if (reference instanceof IMember) { range= ((IMember) reference).getNameRange(); if (range != null) { offset= range.getOffset(); length= range.getLength(); } } else if (reference instanceof IImportDeclaration) { String name= ((IImportDeclaration) reference).getElementName(); if (name != null && name.length() > 0) { String content= reference.getSource(); offset= range.getOffset() + content.indexOf(name); length= name.length(); } } else if (reference instanceof IPackageDeclaration) { String name= ((IPackageDeclaration) reference).getElementName(); if (name != null && name.length() > 0) { String content= reference.getSource(); offset= range.getOffset() + content.indexOf(name); length= name.length(); } } if (offset > -1 && length > 0) { sourceViewer.revealRange(offset, length); sourceViewer.setSelectedRange(offset, length); } } catch (JavaModelException x) { } catch (IllegalArgumentException x) { } finally { if (textWidget != null) textWidget.setRedraw(true); } } else if (moveCursor) { resetHighlightRange(); } } public void setSelection(IJavaElement element) { if (element == null || element instanceof ICompilationUnit || element instanceof IClassFile) { /* * If the element is an ICompilationUnit this unit is either the input * of this editor or not being displayed. In both cases, nothing should * happened. (http://dev.eclipse.org/bugs/show_bug.cgi?id=5128) */ return; } IJavaElement corresponding= getCorrespondingElement(element); if (corresponding instanceof ISourceReference) { ISourceReference reference= (ISourceReference) corresponding; // set hightlight range setSelection(reference, true); // set outliner selection if (fOutlinePage != null) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage.select(reference); fOutlinePage.addSelectionChangedListener(fSelectionChangedListener); } } } public synchronized void editingScriptStarted() { ++ fIgnoreOutlinePageSelection; } public synchronized void editingScriptEnded() { -- fIgnoreOutlinePageSelection; } public synchronized boolean isEditingScriptRunning() { return (fIgnoreOutlinePageSelection > 0); } protected void doSelectionChanged(SelectionChangedEvent event) { ISourceReference reference= null; ISelection selection= event.getSelection(); Iterator iter= ((IStructuredSelection) selection).iterator(); while (iter.hasNext()) { Object o= iter.next(); if (o instanceof ISourceReference) { reference= (ISourceReference) o; break; } } if (!isActivePart() && JavaPlugin.getActivePage() != null) JavaPlugin.getActivePage().bringToTop(this); try { editingScriptStarted(); setSelection(reference, !isActivePart()); } finally { editingScriptEnded(); } } /* * @see AbstractTextEditor#adjustHighlightRange(int, int) */ protected void adjustHighlightRange(int offset, int length) { try { IJavaElement element= getElementAt(offset); while (element instanceof ISourceReference) { ISourceRange range= ((ISourceReference) element).getSourceRange(); if (offset < range.getOffset() + range.getLength() && range.getOffset() < offset + length) { setHighlightRange(range.getOffset(), range.getLength(), true); if (fOutlinePage != null) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage.select((ISourceReference) element); fOutlinePage.addSelectionChangedListener(fSelectionChangedListener); } return; } element= element.getParent(); } } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); } resetHighlightRange(); } protected boolean isActivePart() { IWorkbenchWindow window= getSite().getWorkbenchWindow(); IPartService service= window.getPartService(); return (this == service.getActivePart()); } /* * @see StatusTextEditor#getStatusHeader(IStatus) */ protected String getStatusHeader(IStatus status) { if (fEncodingSupport != null) { String message= fEncodingSupport.getStatusHeader(status); if (message != null) return message; } return super.getStatusHeader(status); } /* * @see StatusTextEditor#getStatusBanner(IStatus) */ protected String getStatusBanner(IStatus status) { if (fEncodingSupport != null) { String message= fEncodingSupport.getStatusBanner(status); if (message != null) return message; } return super.getStatusBanner(status); } /* * @see StatusTextEditor#getStatusMessage(IStatus) */ protected String getStatusMessage(IStatus status) { if (fEncodingSupport != null) { String message= fEncodingSupport.getStatusMessage(status); if (message != null) return message; } return super.getStatusMessage(status); } /* * @see AbstractTextEditor#doSetInput */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); if (fEncodingSupport != null) fEncodingSupport.reset(); setOutlinePageInput(fOutlinePage, input); } /* * @see IWorkbenchPart#dispose() */ public void dispose() { if (fEncodingSupport != null) { fEncodingSupport.dispose(); fEncodingSupport= null; } super.dispose(); } protected void createActions() { super.createActions(); ActionGroup oeg, ovg, sg, jsg; fActionGroups= new CompositeActionGroup( new ActionGroup[] { oeg= new OpenEditorActionGroup(this), ovg= new OpenViewActionGroup(this), sg= new ShowActionGroup(this), jsg= new JavaSearchActionGroup(this)}); fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] {oeg, ovg, sg, jsg}); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ShowJavaDoc.", this, ISourceViewer.INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SHOW_JAVADOC); setAction("ShowJavaDoc", action); //$NON-NLS-1$ fEncodingSupport= new DefaultEncodingSupport(); fEncodingSupport.initialize(this); } private boolean isTextSelectionEmpty() { ISelection selection= getSelectionProvider().getSelection(); if (!(selection instanceof ITextSelection)) return true; return ((ITextSelection)selection).getLength() == 0; } public void updatedTitleImage(Image image) { setTitleImage(image); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null) return; String property= event.getProperty(); if (JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH.equals(property)) { Object value= event.getNewValue(); if (value instanceof Integer) { sourceViewer.getTextWidget().setTabs(((Integer) value).intValue()); } else if (value instanceof String) { sourceViewer.getTextWidget().setTabs(Integer.parseInt((String) value)); } return; } if (LINE_NUMBER_RULER.equals(property)) { if (isLineNumberRulerVisible()) showLineNumberRuler(); else hideLineNumberRuler(); return; } if (fLineNumberRulerColumn != null && (LINE_NUMBER_COLOR.equals(property) || PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT.equals(property) || PREFERENCE_COLOR_BACKGROUND.equals(property))) { initializeLineNumberRulerColumn(fLineNumberRulerColumn); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Shows the line number ruler column. */ private void showLineNumberRuler() { IVerticalRuler v= getVerticalRuler(); if (v instanceof CompositeRuler) { CompositeRuler c= (CompositeRuler) v; c.addDecorator(1, createLineNumberRulerColumn()); } } /** * Hides the line number ruler column. */ private void hideLineNumberRuler() { IVerticalRuler v= getVerticalRuler(); if (v instanceof CompositeRuler) { CompositeRuler c= (CompositeRuler) v; c.removeDecorator(1); } } /** * Return whether the line number ruler column should be * visible according to the preference store settings. * @return <code>true</code> if the line numbers should be visible */ private boolean isLineNumberRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(LINE_NUMBER_RULER); } /** * Returns a segmentation of the line of the given document appropriate for bidi rendering. * The default implementation returns only the string literals of a java code line as segments. * * @param document the document * @param lineOffset the offset of the line * @return the line's bidi segmentation * @throws BadLocationException in case lineOffset is not valid in document */ public static int[] getBidiLineSegments(IDocument document, int lineOffset) throws BadLocationException { IRegion line= document.getLineInformationOfOffset(lineOffset); ITypedRegion[] linePartitioning= document.computePartitioning(lineOffset, line.getLength()); List segmentation= new ArrayList(); for (int i= 0; i < linePartitioning.length; i++) { if (JavaPartitionScanner.JAVA_STRING.equals(linePartitioning[i].getType())) segmentation.add(linePartitioning[i]); } if (segmentation.size() == 0) return null; int size= segmentation.size(); int[] segments= new int[size * 2 + 1]; int j= 0; for (int i= 0; i < size; i++) { ITypedRegion segment= (ITypedRegion) segmentation.get(i); if (i == 0) segments[j++]= 0; int offset= segment.getOffset() - lineOffset; if (offset > segments[j - 1]) segments[j++]= offset; if (offset + segment.getLength() >= line.getLength()) break; segments[j++]= offset + segment.getLength(); } if (j < segments.length) { int[] result= new int[j]; System.arraycopy(segments, 0, result, 0, j); segments= result; } return segments; } /** * Returns a segmentation of the given line appropriate for bidi rendering. The default * implementation returns only the string literals of a java code line as segments. * * @param lineOffset the offset of the line * @param line the content of the line * @return the line's bidi segmentation */ protected int[] getBidiLineSegments(int lineOffset, String line) { IDocumentProvider provider= getDocumentProvider(); if (provider != null) { IDocument document= provider.getDocument(getEditorInput()); if (document != null) try { return getBidiLineSegments(document, lineOffset); } catch (BadLocationException x) { // ignore } } return null; } /* * @see AbstractTextEditor#handleCursorPositionChanged() */ protected void handleCursorPositionChanged() { super.handleCursorPositionChanged(); if (!isEditingScriptRunning() && fUpdater != null) fUpdater.post(); } /** * Initializes the given line number ruler column from the preference store. * @param rulerColumn the ruler column to be initialized */ protected void initializeLineNumberRulerColumn(LineNumberRulerColumn rulerColumn) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); IColorManager manager= textTools.getColorManager(); IPreferenceStore store= getPreferenceStore(); if (store != null) { RGB rgb= null; // foreground color if (store.contains(LINE_NUMBER_COLOR)) { if (store.isDefault(LINE_NUMBER_COLOR)) rgb= PreferenceConverter.getDefaultColor(store, LINE_NUMBER_COLOR); else rgb= PreferenceConverter.getColor(store, LINE_NUMBER_COLOR); } rulerColumn.setForeground(manager.getColor(rgb)); rgb= null; // background color if (!store.getBoolean(PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT)) { if (store.contains(PREFERENCE_COLOR_BACKGROUND)) { if (store.isDefault(PREFERENCE_COLOR_BACKGROUND)) rgb= PreferenceConverter.getDefaultColor(store, PREFERENCE_COLOR_BACKGROUND); else rgb= PreferenceConverter.getColor(store, PREFERENCE_COLOR_BACKGROUND); } } rulerColumn.setBackground(manager.getColor(rgb)); } } /** * Creates a new line number ruler column that is appropriately initialized. */ protected IVerticalRulerColumn createLineNumberRulerColumn() { fLineNumberRulerColumn= new LineNumberRulerColumn(); initializeLineNumberRulerColumn(fLineNumberRulerColumn); return fLineNumberRulerColumn; } /* * @see AbstractTextEditor#createVerticalRuler() */ protected IVerticalRuler createVerticalRuler() { CompositeRuler ruler= new CompositeRuler(); ruler.addDecorator(0, new AnnotationRulerColumn(VERTICAL_RULER_WIDTH)); if (isLineNumberRulerVisible()) ruler.addDecorator(1, createLineNumberRulerColumn()); return ruler; } /* * @see org.eclipse.ui.texteditor.AbstractTextEditor#updatePropertyDependentActions() */ protected void updatePropertyDependentActions() { super.updatePropertyDependentActions(); if (fEncodingSupport != null) fEncodingSupport.reset(); } }
15,877
Bug 15877 Jar export wizard (driver 020502)
Hi, I really don't know if this is the correct category for this bug. Sorry if I am at the wrong place. The option of saving the "export to jar" wizard settings on a file is really good. The only problem is that if I activate the Jar wizard again (not using the jardesc file) to do an export that I don't to create a jardesc for, all the previous settings are loaded again, including the jardesc file name. Since this information is on the 2nd or 3rd page, I got it rewrite without knowing it. Maybe the export wizard should keep the previous settings only if a jardesc is NOT created (afterall why do I need then persisted between wizard activations if I saved the information?).
resolved fixed
4092b01
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-22T14:36:18Z
2002-05-13T17:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarFileExportOperation.java
/* * (c) Copyright IBM Corp. 2000, 2002. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.jarpackager; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Set; import java.util.jar.Manifest; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.resources.IWorkspaceDescription; import org.eclipse.core.resources.IncrementalProjectBuilder; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.core.runtime.Status; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.operation.ModalContext; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModelMarker; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.jarpackager.IJarDescriptionWriter; import org.eclipse.jdt.ui.jarpackager.IJarExportRunnable; import org.eclipse.jdt.ui.jarpackager.JarPackageData; import org.eclipse.jdt.ui.jarpackager.JarWriter; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaStatusConstants; import org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext; /** * Operation for exporting a resource and its children to a new JAR file. */ public class JarFileExportOperation implements IJarExportRunnable { private static class MessageMultiStatus extends MultiStatus { MessageMultiStatus(String pluginId, int code, String message, Throwable exception) { super(pluginId, code, message, exception); } /* * allows to change the message */ protected void setMessage(String message) { super.setMessage(message); } } private JarWriter fJarWriter; private JarPackageData fJarPackage; private JarPackageData[] fJarPackages; private Shell fParentShell; private Map fJavaNameToClassFilesMap; private IContainer fClassFilesMapContainer; private Set fExportedClassContainers; private MessageMultiStatus fStatus; /** * Creates an instance of this class. * * @param jarPackage the JAR package specification * @param parent the parent for the dialog, * or <code>null</code> if no dialog should be presented */ public JarFileExportOperation(JarPackageData jarPackage, Shell parent) { this(new JarPackageData[] {jarPackage}, parent); } /** * Creates an instance of this class. * * @param jarPackages an array with JAR package data objects * @param parent the parent for the dialog, * or <code>null</code> if no dialog should be presented */ public JarFileExportOperation(JarPackageData[] jarPackages, Shell parent) { this(parent); fJarPackages= jarPackages; } private JarFileExportOperation(Shell parent) { fParentShell= parent; fStatus= new MessageMultiStatus(JavaPlugin.getPluginId(), IStatus.OK, "", null); //$NON-NLS-1$ } protected void addToStatus(CoreException ex) { IStatus status= ex.getStatus(); String message= ex.getLocalizedMessage(); if (message == null || message.length() < 1) { message= JarPackagerMessages.getString("JarFileExportOperation.coreErrorDuringExport"); //$NON-NLS-1$ status= new Status(status.getSeverity(), status.getPlugin(), status.getCode(), message, ex); } fStatus.add(status); } /** * Adds a new info to the list with the passed information. * Normally the export operation continues after a warning. * @param message the message * @param exception the throwable that caused the warning, or <code>null</code> */ protected void addInfo(String message, Throwable error) { fStatus.add(new Status(IStatus.INFO, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, message, error)); } /** * Adds a new warning to the list with the passed information. * Normally the export operation continues after a warning. * @param message the message * @param exception the throwable that caused the warning, or <code>null</code> */ protected void addWarning(String message, Throwable error) { fStatus.add(new Status(IStatus.WARNING, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, message, error)); } /** * Adds a new error to the list with the passed information. * Normally an error terminates the export operation. * @param message the message * @param exception the throwable that caused the error, or <code>null</code> */ protected void addError(String message, Throwable error) { fStatus.add(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, message, error)); } /** * Answers the number of file resources specified by the JAR package. * * @return int */ protected int countSelectedElements() { int count= 0; int n= fJarPackage.getElements().length; for (int i= 0; i < n; i++) { Object element= fJarPackage.getElements()[i]; IResource resource= null; if (element instanceof IJavaElement) { IJavaElement je= (IJavaElement)element; try { resource= je.getUnderlyingResource(); } catch (JavaModelException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.underlyingResourceNotFound", je.getElementName()), ex); //$NON-NLS-1$ return count; } } else resource= (IResource)element; if (resource.getType() == IResource.FILE) count++; else count += getTotalChildCount((IContainer)resource); } return count; } private int getTotalChildCount(IContainer container) { IResource[] members; try { members= container.members(); } catch (CoreException ex) { return 0; } int count= 0; for (int i= 0; i < members.length; i++) { if (members[i].getType() == IResource.FILE) count++; else count += getTotalChildCount((IContainer)members[i]); } return count; } /** * Exports the passed resource to the JAR file * * @param element the resource or JavaElement to export */ protected void exportElement(Object element, IProgressMonitor progressMonitor) throws InterruptedException { int leadSegmentsToRemove= 1; IPackageFragmentRoot pkgRoot= null; boolean isInJavaProject= false; IResource resource= null; IJavaProject jProject= null; if (element instanceof IJavaElement) { isInJavaProject= true; IJavaElement je= (IJavaElement)element; try { resource= je.getUnderlyingResource(); } catch (JavaModelException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.underlyingResourceNotFound", je.getElementName()), ex); //$NON-NLS-1$ return; } jProject= je.getJavaProject(); pkgRoot= JavaModelUtil.getPackageFragmentRoot(je); } else resource= (IResource)element; if (!resource.isAccessible()) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.resourceNotFound", resource.getFullPath()), null); //$NON-NLS-1$ return; } if (resource.getType() == IResource.FILE) { if (!resource.isLocal(IResource.DEPTH_ZERO)) try { resource.setLocal(true , IResource.DEPTH_ZERO, progressMonitor); } catch (CoreException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.resourceNotLocal", resource.getFullPath()), ex); //$NON-NLS-1$ return; } if (!isInJavaProject) { // check if it's a Java resource try { isInJavaProject= resource.getProject().hasNature(JavaCore.NATURE_ID); } catch (CoreException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.projectNatureNotDeterminable", resource.getFullPath()), ex); //$NON-NLS-1$ return; } if (isInJavaProject) { jProject= JavaCore.create(resource.getProject()); try { IPackageFragment pkgFragment= jProject.findPackageFragment(resource.getFullPath().removeLastSegments(1)); if (pkgFragment != null) pkgRoot= JavaModelUtil.getPackageFragmentRoot(pkgFragment); else pkgRoot= findPackageFragmentRoot(jProject, resource.getFullPath().removeLastSegments(1)); } catch (JavaModelException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.javaPackageNotDeterminable", resource.getFullPath()), ex); //$NON-NLS-1$ return; } } } if (pkgRoot != null) { leadSegmentsToRemove= pkgRoot.getPath().segmentCount(); if (mustUseSourceFolderHierarchy() && !pkgRoot.getElementName().equals(pkgRoot.DEFAULT_PACKAGEROOT_PATH)) leadSegmentsToRemove--; } IPath destinationPath= resource.getFullPath().removeFirstSegments(leadSegmentsToRemove); boolean isInOutputFolder= false; if (isInJavaProject) { try { isInOutputFolder= jProject.getOutputLocation().isPrefixOf(resource.getFullPath()); } catch (JavaModelException ex) { isInOutputFolder= false; } } exportClassFiles(progressMonitor, pkgRoot, resource, jProject, destinationPath); exportResource(progressMonitor, pkgRoot, isInJavaProject, resource, destinationPath, isInOutputFolder); progressMonitor.worked(1); ModalContext.checkCanceled(progressMonitor); } else if (element instanceof IPackageFragment) exportPackageFragment(progressMonitor, (IPackageFragment)element); else exportContainer(progressMonitor, (IContainer)resource); } private void exportPackageFragment(IProgressMonitor progressMonitor, IPackageFragment pkgFragment) throws java.lang.InterruptedException { Object[] children; try { children= pkgFragment.getChildren(); for (int i= 0; i < children.length; i++) exportElement(children[i], progressMonitor); children= pkgFragment.getNonJavaResources(); for (int i= 0; i < children.length; i++) exportElement(children[i], progressMonitor); } catch (CoreException e) { // this should never happen because an #isAccessible check is done before #members is invoked addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.errorDuringExport", pkgFragment.toString()), e); //$NON-NLS-1$ } } private void exportContainer(IProgressMonitor progressMonitor, IContainer container) throws java.lang.InterruptedException { if (container.getType() == IResource.FOLDER && isOutputFolder((IFolder)container)) return; IResource[] children= null; try { children= container.members(); } catch (CoreException e) { // this should never happen because an #isAccessible check is done before #members is invoked addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.errorDuringExport", container.getFullPath()), e); //$NON-NLS-1$ } for (int i= 0; i < children.length; i++) exportElement(children[i], progressMonitor); } private IPackageFragmentRoot findPackageFragmentRoot(IJavaProject jProject, IPath path) throws JavaModelException { if (jProject == null || path == null || path.segmentCount() <= 0) return null; IPackageFragmentRoot pkgRoot= jProject.findPackageFragmentRoot(path); if (pkgRoot != null) return pkgRoot; else return findPackageFragmentRoot(jProject, path.removeLastSegments(1)); } private void exportResource(IProgressMonitor progressMonitor, IPackageFragmentRoot pkgRoot, boolean isInJavaProject, IResource resource, IPath destinationPath, boolean isInOutputFolder) { boolean isNonJavaResource= !isInJavaProject || pkgRoot == null; boolean isInClassFolder= false; try { isInClassFolder= pkgRoot != null && !pkgRoot.isArchive() && pkgRoot.getKind() == pkgRoot.K_BINARY; } catch (JavaModelException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.cantGetRootKind", resource.getFullPath()), ex); //$NON-NLS-1$ } if ((fJarPackage.areClassFilesExported() && ((isNonJavaResource || (pkgRoot != null && !isJavaFile(resource) && !isClassFile(resource))) || isInClassFolder && isClassFile(resource))) || (fJarPackage.areJavaFilesExported() && (isNonJavaResource || (pkgRoot != null && !isClassFile(resource))))) { try { progressMonitor.subTask(JarPackagerMessages.getFormattedString("JarFileExportOperation.exporting", destinationPath.toString())); //$NON-NLS-1$ fJarWriter.write((IFile) resource, destinationPath); } catch (CoreException ex) { addToStatus(ex); } } } private boolean isOutputFolder(IFolder folder) { try { IJavaProject javaProject= JavaCore.create(folder.getProject()); IPath outputFolderPath= javaProject.getOutputLocation(); return folder.getFullPath().equals(outputFolderPath); } catch (JavaModelException ex) { return false; } } private void exportClassFiles(IProgressMonitor progressMonitor, IPackageFragmentRoot pkgRoot, IResource resource, IJavaProject jProject, IPath destinationPath) { if (fJarPackage.areClassFilesExported() && isJavaFile(resource) && pkgRoot != null) { try { // find corresponding file(s) on classpath and export Iterator iter= filesOnClasspath((IFile)resource, destinationPath, jProject, progressMonitor); IPath baseDestinationPath= destinationPath.removeLastSegments(1); while (iter.hasNext()) { IFile file= (IFile)iter.next(); if (!resource.isLocal(IResource.DEPTH_ZERO)) file.setLocal(true , IResource.DEPTH_ZERO, progressMonitor); IPath classFilePath= baseDestinationPath.append(file.getName()); progressMonitor.subTask(JarPackagerMessages.getFormattedString("JarFileExportOperation.exporting", classFilePath.toString())); //$NON-NLS-1$ fJarWriter.write(file, classFilePath); } } catch (CoreException ex) { addToStatus(ex); } } } /** * Exports the resources as specified by the JAR package. */ protected void exportSelectedElements(IProgressMonitor progressMonitor) throws InterruptedException { fExportedClassContainers= new HashSet(10); int n= fJarPackage.getElements().length; for (int i= 0; i < n; i++) exportElement(fJarPackage.getElements()[i], progressMonitor); } /** * Returns an iterator on a list with files that correspond to the * passed file and that are on the classpath of its project. * * @param file the file for which to find the corresponding classpath resources * @param pathInJar the path that the file has in the JAR (i.e. project and source folder segments removed) * @param javaProject the javaProject that contains the file * @return the iterator over the corresponding classpath files for the given file */ protected Iterator filesOnClasspath(IFile file, IPath pathInJar, IJavaProject javaProject, IProgressMonitor progressMonitor) throws CoreException { // Allow JAR Package to provide its own strategy IFile[] classFiles= fJarPackage.findClassfilesFor(file); if (classFiles != null) return Arrays.asList(classFiles).iterator(); if (!isJavaFile(file)) return Collections.EMPTY_LIST.iterator(); IPath outputPath= javaProject.getOutputLocation(); IContainer outputContainer; if (javaProject.getProject().getFullPath().equals(outputPath)) outputContainer= javaProject.getProject(); else { outputContainer= createFolderHandle(outputPath); if (outputContainer == null || !outputContainer.isAccessible()) { String msg= JarPackagerMessages.getString("JarFileExportOperation.outputContainerNotAccessible"); //$NON-NLS-1$ throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, msg, null)); } } // Java CU - search files with .class ending boolean hasErrors= hasCompileErrors(file); boolean hasWarnings= hasCompileWarnings(file); boolean canBeExported= canBeExported(hasErrors, hasWarnings); if (!canBeExported) return Collections.EMPTY_LIST.iterator(); reportPossibleCompileProblems(file, hasErrors, hasWarnings, canBeExported); IContainer classContainer= outputContainer; if (pathInJar.segmentCount() > 1) classContainer= outputContainer.getFolder(pathInJar.removeLastSegments(1)); if (fExportedClassContainers.contains(classContainer)) return Collections.EMPTY_LIST.iterator(); if (fClassFilesMapContainer == null || !fClassFilesMapContainer.equals(classContainer)) { fJavaNameToClassFilesMap= buildJavaToClassMap(classContainer); if (fJavaNameToClassFilesMap == null) { // Could not fully build map. fallback is to export whole directory String msg= JarPackagerMessages.getFormattedString("JarFileExportOperation.missingSourceFileAttributeExportedAll", classContainer.getLocation().toFile()); //$NON-NLS-1$ addInfo(msg, null); fExportedClassContainers.add(classContainer); return getClassesIn(classContainer); } fClassFilesMapContainer= classContainer; } ArrayList classFileList= (ArrayList)fJavaNameToClassFilesMap.get(file.getName()); if (classFileList == null || classFileList.isEmpty()) { String msg= JarPackagerMessages.getFormattedString("JarFileExportOperation.classFileOnClasspathNotAccessible", file.getFullPath()); //$NON-NLS-1$ throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, msg, null)); } return classFileList.iterator(); } private Iterator getClassesIn(IContainer classContainer) throws CoreException { IResource[] resources= classContainer.members(); List files= new ArrayList(resources.length); for (int i= 0; i < resources.length; i++) if (resources[i].getType() == IResource.FILE && isClassFile(resources[i])) files.add(resources[i]); return files.iterator(); } /** * Answers whether the given resource is a Java file. * The resource must be a file whose file name ends with ".java". * * @return a <code>true<code> if the given resource is a Java file */ boolean isJavaFile(IResource file) { return file != null && file.getType() == IFile.FILE && file.getFileExtension() != null && file.getFileExtension().equalsIgnoreCase("java"); //$NON-NLS-1$ } /** * Answers whether the given resource is a class file. * The resource must be a file whose file name ends with ".class". * * @return a <code>true<code> if the given resource is a class file */ boolean isClassFile(IResource file) { return file != null && file.getType() == IFile.FILE && file.getFileExtension() != null && file.getFileExtension().equalsIgnoreCase("class"); //$NON-NLS-1$ } /* * Builds and returns a map that has the class files * for each java file in a given directory */ private Map buildJavaToClassMap(IContainer container) throws CoreException { if (!isCompilerGeneratingSourceFileAttribute()) return null; if (container == null || !container.isAccessible()) return new HashMap(0); /* * XXX: Bug 6584: Need a way to get class files for a java file (or CU) */ org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader cfReader; IResource[] members= container.members(); Map map= new HashMap(members.length); for (int i= 0; i < members.length; i++) { if (isClassFile(members[i])) { IFile classFile= (IFile)members[i]; try { cfReader= org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.read(classFile.getLocation().toFile()); } catch (org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.invalidClassFileFormat", classFile.getLocation().toFile()), ex); //$NON-NLS-1$ continue; } catch (IOException ex) { addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.ioErrorDuringClassFileLookup", classFile.getLocation().toFile()), ex); //$NON-NLS-1$ continue; } if (cfReader != null) { if (cfReader.sourceFileName() == null) { /* * Can't fully build the map because one or more * class file does not contain the name of its * source file. */ addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.classFileWithoutSourceFileAttribute", classFile.getLocation().toFile()), null); //$NON-NLS-1$ return null; } String javaName= new String(cfReader.sourceFileName()); Object classFiles= map.get(javaName); if (classFiles == null) { classFiles= new ArrayList(3); map.put(javaName, classFiles); } ((ArrayList)classFiles).add(classFile); } } } return map; } /** * Creates a file resource handle for the file with the given workspace path. * This method does not create the file resource; this is the responsibility * of <code>createFile</code>. * * @param filePath the path of the file resource to create a handle for * @return the new file resource handle * @see #createFile */ protected IFile createFileHandle(IPath filePath) { if (filePath.isValidPath(filePath.toString()) && filePath.segmentCount() >= 2) return JavaPlugin.getWorkspace().getRoot().getFile(filePath); else return null; } /** * Creates a folder resource handle for the folder with the given workspace path. * * @param folderPath the path of the folder to create a handle for * @return the new folder resource handle */ protected IFolder createFolderHandle(IPath folderPath) { if (folderPath.isValidPath(folderPath.toString()) && folderPath.segmentCount() >= 2) return JavaPlugin.getWorkspace().getRoot().getFolder(folderPath); else return null; } /** * Returns the status of this operation. * The result is a status object containing individual * status objects. * * @return the status of this operation */ public IStatus getStatus() { String message= null; switch (fStatus.getSeverity()) { case IStatus.OK: message= ""; //$NON-NLS-1$ break; case IStatus.INFO: message= JarPackagerMessages.getString("JarFileExportOperation.exportFinishedWithInfo"); //$NON-NLS-1$ break; case IStatus.WARNING: message= JarPackagerMessages.getString("JarFileExportOperation.exportFinishedWithWarnings"); //$NON-NLS-1$ break; case IStatus.ERROR: if (fJarPackages.length > 1) message= JarPackagerMessages.getString("JarFileExportOperation.creationOfSomeJARsFailed"); //$NON-NLS-1$ else message= JarPackagerMessages.getString("JarFileExportOperation.jarCreationFailed"); //$NON-NLS-1$ break; default: // defensive code in case new severity is defined message= ""; //$NON-NLS-1$ break; } fStatus.setMessage(message); return fStatus; } /** * Answer a boolean indicating whether the passed child is a descendant * of one or more members of the passed resources collection * * @param resources a List contain potential parents * @param child the resource to test * @return a <code>boolean</code> indicating if the child is a descendant */ protected boolean isDescendant(List resources, IResource child) { if (child.getType() == IResource.PROJECT) return false; IResource parent= child.getParent(); if (resources.contains(parent)) return true; return isDescendant(resources, parent); } protected boolean canBeExported(boolean hasErrors, boolean hasWarnings) throws CoreException { return (!hasErrors && !hasWarnings) || (hasErrors && fJarPackage.areErrorsExported()) || (hasWarnings && fJarPackage.exportWarnings()); } protected void reportPossibleCompileProblems(IFile file, boolean hasErrors, boolean hasWarnings, boolean canBeExported) { if (hasErrors) { if (canBeExported) addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.exportedWithCompileErrors", file.getFullPath()), null); //$NON-NLS-1$ else addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.notExportedDueToCompileErrors", file.getFullPath()), null); //$NON-NLS-1$ } if (hasWarnings) { if (canBeExported) addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.exportedWithCompileWarnings", file.getFullPath()), null); //$NON-NLS-1$ else addWarning(JarPackagerMessages.getFormattedString("JarFileExportOperation.notExportedDueToCompileWarnings", file.getFullPath()), null); //$NON-NLS-1$ } } /** * Exports the resources as specified by the JAR package. * * @param progressMonitor the progress monitor that displays the progress * @see #getStatus() */ public void run(IProgressMonitor progressMonitor) throws InvocationTargetException, InterruptedException { int count= fJarPackages.length; progressMonitor.beginTask("", count); //$NON-NLS-1$ try { for (int i= 0; i < count; i++) { SubProgressMonitor subProgressMonitor= new SubProgressMonitor(progressMonitor, 1); fJarPackage= fJarPackages[i]; if (fJarPackage != null) singleRun(subProgressMonitor); } } finally { progressMonitor.done(); } } public void singleRun(IProgressMonitor progressMonitor) throws InvocationTargetException, InterruptedException { try { if (!preconditionsOK()) throw new InvocationTargetException(null, JarPackagerMessages.getString("JarFileExportOperation.jarCreationFailedSeeDetails")); //$NON-NLS-1$ int totalWork= countSelectedElements(); if (!isAutoBuilding() && fJarPackage.isBuildingIfNeeded()) { int subMonitorTicks= totalWork/10; totalWork += subMonitorTicks; progressMonitor.beginTask("", totalWork); //$NON-NLS-1$ SubProgressMonitor subProgressMonitor= new SubProgressMonitor(progressMonitor, subMonitorTicks, SubProgressMonitor.PREPEND_MAIN_LABEL_TO_SUBTASK); buildProjects(subProgressMonitor); } else progressMonitor.beginTask("", totalWork); //$NON-NLS-1$ fJarWriter= fJarPackage.createJarWriter(fParentShell); exportSelectedElements(progressMonitor); if (getStatus().getSeverity() != IStatus.ERROR) { progressMonitor.subTask(JarPackagerMessages.getString("JarFileExportOperation.savingFiles")); //$NON-NLS-1$ saveFiles(); } } catch (CoreException ex) { addToStatus(ex); } finally { try { if (fJarWriter != null) fJarWriter.close(); } catch (CoreException ex) { addToStatus(ex); } progressMonitor.done(); } } protected boolean preconditionsOK() { if (!fJarPackage.areClassFilesExported() && !fJarPackage.areJavaFilesExported()) { addError(JarPackagerMessages.getString("JarFileExportOperation.noExportTypeChosen"), null); //$NON-NLS-1$ return false; } if (fJarPackage.getElements() == null || fJarPackage.getElements().length == 0) { addError(JarPackagerMessages.getString("JarFileExportOperation.noResourcesSelected"), null); //$NON-NLS-1$ return false; } if (fJarPackage.getJarLocation() == null) { addError(JarPackagerMessages.getString("JarFileExportOperation.invalidJarLocation"), null); //$NON-NLS-1$ return false; } if (!fJarPackage.isManifestAccessible()) { addError(JarPackagerMessages.getString("JarFileExportOperation.manifestDoesNotExist"), null); //$NON-NLS-1$ return false; } if (!fJarPackage.isMainClassValid(new BusyIndicatorRunnableContext())) { addError(JarPackagerMessages.getString("JarFileExportOperation.invalidMainClass"), null); //$NON-NLS-1$ return false; } if (fParentShell == null) // no checking if shell is null return true; IFile[] unsavedFiles= getUnsavedFiles(); if (unsavedFiles.length > 0) return saveModifiedResourcesIfUserConfirms(unsavedFiles); return true; } /** * Returns the files which are not saved and which are * part of the files being exported. * * @return an array of unsaved files */ private IFile[] getUnsavedFiles() { IEditorPart[] dirtyEditors= getDirtyEditors(fParentShell); Set unsavedFiles= new HashSet(dirtyEditors.length); if (dirtyEditors.length > 0) { List selection= JarPackagerUtil.asResources(fJarPackage.getElements()); for (int i= 0; i < dirtyEditors.length; i++) { if (dirtyEditors[i].getEditorInput() instanceof IFileEditorInput) { IFile dirtyFile= ((IFileEditorInput)dirtyEditors[i].getEditorInput()).getFile(); if (JarPackagerUtil.contains(selection, dirtyFile)) { unsavedFiles.add(dirtyFile); } } } } return (IFile[])unsavedFiles.toArray(new IFile[unsavedFiles.size()]); } /** * Asks the user to confirm to save the modified resources. * * @return true if user pressed OK. */ private boolean confirmSaveModifiedResources(IFile[] dirtyFiles) { if (dirtyFiles == null || dirtyFiles.length == 0) return true; // Get display for further UI operations Display display= fParentShell.getDisplay(); if (display == null || display.isDisposed()) return false; // Ask user to confirm saving of all files final ConfirmSaveModifiedResourcesDialog dlg= new ConfirmSaveModifiedResourcesDialog(fParentShell, dirtyFiles); final int[] intResult= new int[1]; Runnable runnable= new Runnable() { public void run() { intResult[0]= dlg.open(); } }; display.syncExec(runnable); return intResult[0] == IDialogConstants.OK_ID; } /** * Asks to confirm to save the modified resources * and save them if OK is pressed. * * @return true if user pressed OK and save was successful. */ private boolean saveModifiedResourcesIfUserConfirms(IFile[] dirtyFiles) { if (confirmSaveModifiedResources(dirtyFiles)) return saveModifiedResources(dirtyFiles); // Report unsaved files for (int i= 0; i < dirtyFiles.length; i++) addError(JarPackagerMessages.getFormattedString("JarFileExportOperation.fileUnsaved", dirtyFiles[i].getFullPath()), null); //$NON-NLS-1$ return false; } /** * Save all of the editors in the workbench. * * @return true if successful. */ private boolean saveModifiedResources(final IFile[] dirtyFiles) { // Get display for further UI operations Display display= fParentShell.getDisplay(); if (display == null || display.isDisposed()) return false; final boolean[] retVal= new boolean[1]; Runnable runnable= new Runnable() { public void run() { IWorkspace workspace= ResourcesPlugin.getWorkspace(); IWorkspaceDescription description= workspace.getDescription(); boolean autoBuild= description.isAutoBuilding(); description.setAutoBuilding(false); try { workspace.setDescription(description); // This save operation can not be canceled. try { new ProgressMonitorDialog(fParentShell).run(false, false, createSaveModifiedResourcesRunnable(dirtyFiles)); retVal[0]= true; } finally { description.setAutoBuilding(autoBuild); workspace.setDescription(description); } } catch (InvocationTargetException ex) { addError(JarPackagerMessages.getString("JarFileExportOperation.errorSavingModifiedResources"), ex); //$NON-NLS-1$ JavaPlugin.log(ex); retVal[0]= false; } catch (InterruptedException ex) { Assert.isTrue(false); // Can't happen. Operation isn't cancelable. retVal[0]= false; } catch (CoreException ex) { addError(JarPackagerMessages.getString("JarFileExportOperation.errorSavingModifiedResources"), ex); //$NON-NLS-1$ JavaPlugin.log(ex); retVal[0]= false; } } }; display.syncExec(runnable); return retVal[0]; } private IRunnableWithProgress createSaveModifiedResourcesRunnable(final IFile[] dirtyFiles) { return new IRunnableWithProgress() { public void run(final IProgressMonitor pm) { IEditorPart[] editorsToSave= getDirtyEditors(fParentShell); pm.beginTask(JarPackagerMessages.getString("JarFileExportOperation.savingModifiedResources"), editorsToSave.length); //$NON-NLS-1$ try { List dirtyFilesList= Arrays.asList(dirtyFiles); for (int i= 0; i < editorsToSave.length; i++) { if (editorsToSave[i].getEditorInput() instanceof IFileEditorInput) { IFile dirtyFile= ((IFileEditorInput)editorsToSave[i].getEditorInput()).getFile(); if (dirtyFilesList.contains((dirtyFile))) editorsToSave[i].doSave(new SubProgressMonitor(pm, 1)); } pm.worked(1); } } finally { pm.done(); } } }; } protected void saveFiles() { // Save the manifest if (fJarPackage.isManifestGenerated() && fJarPackage.isManifestSaved()) { try { saveManifest(); } catch (CoreException ex) { addError(JarPackagerMessages.getString("JarFileExportOperation.errorSavingManifest"), ex); //$NON-NLS-1$ } catch (IOException ex) { addError(JarPackagerMessages.getString("JarFileExportOperation.errorSavingManifest"), ex); //$NON-NLS-1$ } } // Save the description if (fJarPackage.isDescriptionSaved()) { try { saveDescription(); } catch (CoreException ex) { addError(JarPackagerMessages.getString("JarFileExportOperation.errorSavingDescription"), ex); //$NON-NLS-1$ } catch (IOException ex) { addError(JarPackagerMessages.getString("JarFileExportOperation.errorSavingDescription"), ex); //$NON-NLS-1$ } } } private IEditorPart[] getDirtyEditors(Shell parent) { Display display= parent.getDisplay(); final Object[] result= new Object[1]; display.syncExec( new Runnable() { public void run() { result[0]= JavaPlugin.getDirtyEditors(); } } ); return (IEditorPart[])result[0]; } protected void saveDescription() throws CoreException, IOException { // Adjust JAR package attributes if (fJarPackage.isManifestReused()) fJarPackage.setGenerateManifest(false); ByteArrayOutputStream objectStreamOutput= new ByteArrayOutputStream(); IJarDescriptionWriter writer= fJarPackage.createJarDescriptionWriter(objectStreamOutput); ByteArrayInputStream fileInput= null; try { writer.write(fJarPackage); fileInput= new ByteArrayInputStream(objectStreamOutput.toByteArray()); IFile descriptionFile= fJarPackage.getDescriptionFile(); if (descriptionFile.isAccessible()) { if (fJarPackage.allowOverwrite() || JarPackagerUtil.askForOverwritePermission(fParentShell, descriptionFile.getFullPath().toString())) descriptionFile.setContents(fileInput, true, true, null); } else descriptionFile.create(fileInput, true, null); } finally { if (fileInput != null) fileInput.close(); if (writer != null) writer.close(); } } protected void saveManifest() throws CoreException, IOException { ByteArrayOutputStream manifestOutput= new ByteArrayOutputStream(); ByteArrayInputStream fileInput= null; try { Manifest manifest= fJarPackage.getManifestProvider().create(fJarPackage); manifest.write(manifestOutput); fileInput= new ByteArrayInputStream(manifestOutput.toByteArray()); IFile manifestFile= fJarPackage.getManifestFile(); if (manifestFile.isAccessible()) { if (fJarPackage.allowOverwrite() || JarPackagerUtil.askForOverwritePermission(fParentShell, manifestFile.getFullPath().toString())) manifestFile.setContents(fileInput, true, true, null); } else manifestFile.create(fileInput, true, null); } finally { if (manifestOutput != null) manifestOutput.close(); if (fileInput != null) fileInput.close(); } } private boolean isAutoBuilding() { return ResourcesPlugin.getWorkspace().getDescription().isAutoBuilding(); } private boolean isCompilerGeneratingSourceFileAttribute() { Object value= JavaCore.getOptions().get(JavaCore.COMPILER_SOURCE_FILE_ATTR); if (value instanceof String) return "generate".equalsIgnoreCase((String)value); //$NON-NLS-1$ else return true; // default } private void buildProjects(IProgressMonitor progressMonitor) { Set builtProjects= new HashSet(10); Object[] elements= fJarPackage.getElements(); for (int i= 0; i < elements.length; i++) { IProject project= null; Object element= elements[i]; if (element instanceof IResource) project= ((IResource)element).getProject(); else if (element instanceof IJavaElement) project= ((IJavaElement)element).getJavaProject().getProject(); if (project != null && !builtProjects.contains(project)) { try { project.build(IncrementalProjectBuilder.INCREMENTAL_BUILD, progressMonitor); } catch (CoreException ex) { String message= JarPackagerMessages.getFormattedString("JarFileExportOperation.errorDuringProjectBuild", project.getFullPath()); //$NON-NLS-1$ addError(message, ex); } finally { // don't try to build same project a second time even if it failed builtProjects.add(project); } } } } /** * Tells whether the given resource (or its children) have compile errors. * The method acts on the current build state and does not recompile. * * @param resource the resource to check for errors * @return <code>true</code> if the resource (and its children) are error free * @throws import org.eclipse.core.runtime.CoreException if there's a marker problem */ private boolean hasCompileErrors(IResource resource) throws CoreException { IMarker[] problemMarkers= resource.findMarkers(IJavaModelMarker.JAVA_MODEL_PROBLEM_MARKER, true, IResource.DEPTH_INFINITE); for (int i= 0; i < problemMarkers.length; i++) { if (problemMarkers[i].getAttribute(IMarker.SEVERITY, -1) == IMarker.SEVERITY_ERROR) return true; } return false; } /** * Tells whether the given resource (or its children) have compile errors. * The method acts on the current build state and does not recompile. * * @param resource the resource to check for errors * @return <code>true</code> if the resource (and its children) are error free * @throws import org.eclipse.core.runtime.CoreException if there's a marker problem */ private boolean hasCompileWarnings(IResource resource) throws CoreException { IMarker[] problemMarkers= resource.findMarkers(IJavaModelMarker.JAVA_MODEL_PROBLEM_MARKER, true, IResource.DEPTH_INFINITE); for (int i= 0; i < problemMarkers.length; i++) { if (problemMarkers[i].getAttribute(IMarker.SEVERITY, -1) == IMarker.SEVERITY_WARNING) return true; } return false; } private boolean mustUseSourceFolderHierarchy() { return fJarPackage.useSourceFolderHierarchy() && fJarPackage.areJavaFilesExported() && !fJarPackage.areClassFilesExported(); } }
15,877
Bug 15877 Jar export wizard (driver 020502)
Hi, I really don't know if this is the correct category for this bug. Sorry if I am at the wrong place. The option of saving the "export to jar" wizard settings on a file is really good. The only problem is that if I activate the Jar wizard again (not using the jardesc file) to do an export that I don't to create a jardesc for, all the previous settings are loaded again, including the jardesc file name. Since this information is on the 2nd or 3rd page, I got it rewrite without knowing it. Maybe the export wizard should keep the previous settings only if a jardesc is NOT created (afterall why do I need then persisted between wizard activations if I saved the information?).
resolved fixed
4092b01
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-22T14:36:18Z
2002-05-13T17:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarOptionsPage.java
/* * (c) Copyright IBM Corp. 2000, 2002. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.jarpackager; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.wizard.IWizardPage; import org.eclipse.jface.wizard.WizardPage; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.ui.jarpackager.JarPackageData; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.util.SWTUtil; /** * Page 2 of the JAR Package wizard */ class JarOptionsPage extends WizardPage implements IJarPackageWizardPage { // Untyped listener private class UntypedListener implements Listener { /* * Implements method from Listener */ public void handleEvent(Event e) { if (getControl() == null) return; update(); } } private JarPackageData fJarPackage; // widgets private Button fExportErrorsCheckbox; private Button fExportWarningsCheckbox; private Button fUseSourceFoldersCheckbox; private Composite fDescriptionFileGroup; private Button fSaveDescriptionCheckbox; private Label fDescriptionFileLabel; private Text fDescriptionFileText; private Button fDescriptionFileBrowseButton; private Button fBuildIfNeededCheckbox; // dialog store id constants private final static String PAGE_NAME= "jarOptionsWizardPage"; //$NON-NLS-1$ private final static String STORE_EXPORT_WARNINGS= PAGE_NAME + ".EXPORT_WARNINGS"; //$NON-NLS-1$ private final static String STORE_EXPORT_ERRORS= PAGE_NAME + ".EXPORT_ERRORS"; //$NON-NLS-1$ private final static String STORE_SAVE_DESCRIPTION= PAGE_NAME + ".SAVE_DESCRIPTION"; //$NON-NLS-1$ private final static String STORE_DESCRIPTION_LOCATION= PAGE_NAME + ".DESCRIPTION_LOCATION"; //$NON-NLS-1$ private final static String STORE_USE_SRC_FOLDERS= PAGE_NAME + ".STORE_USE_SRC_FOLDERS"; //$NON-NLS-1$ private final static String STORE_BUILD_IF_NEEDED= PAGE_NAME + ".BUILD_IF_NEEDED"; //$NON-NLS-1$ /** * Create an instance of this class */ public JarOptionsPage(JarPackageData jarPackage) { super(PAGE_NAME); setTitle(JarPackagerMessages.getString("JarOptionsPage.title")); //$NON-NLS-1$ setDescription(JarPackagerMessages.getString("JarOptionsPage.description")); //$NON-NLS-1$ fJarPackage= jarPackage; } /* * Method declared on IDialogPage. */ public void createControl(Composite parent) { Composite composite= new Composite(parent, SWT.NULL); composite.setLayout(new GridLayout()); composite.setLayoutData( new GridData(GridData.VERTICAL_ALIGN_FILL | GridData.HORIZONTAL_ALIGN_FILL)); createOptionsGroup(composite); restoreWidgetValues(); setControl(composite); update(); WorkbenchHelp.setHelp(composite, IJavaHelpContextIds.JAROPTIONS_WIZARD_PAGE); } /** * Create the export options specification widgets. * * @param parent org.eclipse.swt.widgets.Composite */ protected void createOptionsGroup(Composite parent) { initializeDialogUnits(parent); Composite optionsGroup= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginHeight= 0; optionsGroup.setLayout(layout); createLabel(optionsGroup, JarPackagerMessages.getString("JarOptionsPage.howTreatProblems.label"), false); //$NON-NLS-1$ UntypedListener selectionListener= new UntypedListener(); fExportErrorsCheckbox= new Button(optionsGroup, SWT.CHECK | SWT.LEFT); fExportErrorsCheckbox.setText(JarPackagerMessages.getString("JarOptionsPage.exportErrors.text")); //$NON-NLS-1$ fExportErrorsCheckbox.addListener(SWT.Selection, selectionListener); fExportWarningsCheckbox= new Button(optionsGroup, SWT.CHECK | SWT.LEFT); fExportWarningsCheckbox.setText(JarPackagerMessages.getString("JarOptionsPage.exportWarnings.text")); //$NON-NLS-1$ fExportWarningsCheckbox.addListener(SWT.Selection, selectionListener); createSpacer(optionsGroup); fUseSourceFoldersCheckbox= new Button(optionsGroup, SWT.CHECK | SWT.LEFT); fUseSourceFoldersCheckbox.setText(JarPackagerMessages.getString("JarOptionsPage.useSourceFoldersHierarchy")); //$NON-NLS-1$ fUseSourceFoldersCheckbox.addListener(SWT.Selection, selectionListener); fUseSourceFoldersCheckbox.setEnabled(fJarPackage.areJavaFilesExported() && !fJarPackage.areClassFilesExported()); createSpacer(optionsGroup); fBuildIfNeededCheckbox= new Button(optionsGroup, SWT.CHECK | SWT.LEFT); fBuildIfNeededCheckbox.setText(JarPackagerMessages.getString("JarOptionsPage.buildIfNeeded")); //$NON-NLS-1$ fBuildIfNeededCheckbox.addListener(SWT.Selection, selectionListener); createSpacer(optionsGroup); fSaveDescriptionCheckbox= new Button(optionsGroup, SWT.CHECK | SWT.LEFT); fSaveDescriptionCheckbox.setText(JarPackagerMessages.getString("JarOptionsPage.saveDescription.text")); //$NON-NLS-1$ fSaveDescriptionCheckbox.addListener(SWT.Selection, selectionListener); createDescriptionFileGroup(parent); } /** * Persists resource specification control setting that are to be restored * in the next instance of this page. Subclasses wishing to persist * settings for their controls should extend the hook method * <code>internalSaveWidgetValues</code>. */ public final void saveWidgetValues() { // update directory names history IDialogSettings settings= getDialogSettings(); if (settings != null) { settings.put(STORE_EXPORT_WARNINGS, fJarPackage.exportWarnings()); settings.put(STORE_EXPORT_ERRORS, fJarPackage.areErrorsExported()); settings.put(STORE_USE_SRC_FOLDERS, fJarPackage.useSourceFolderHierarchy()); settings.put(STORE_BUILD_IF_NEEDED, fJarPackage.isBuildingIfNeeded()); settings.put(STORE_SAVE_DESCRIPTION, fJarPackage.isDescriptionSaved()); settings.put(STORE_DESCRIPTION_LOCATION, fJarPackage.getDescriptionLocation().toString()); } // Allow subclasses to save values internalSaveWidgetValues(); } /** * Hook method for subclasses to persist their settings. */ protected void internalSaveWidgetValues() { } /** * Hook method for restoring widget values to the values that they held * last time this wizard was used to completion. */ protected void restoreWidgetValues() { if (!((JarPackageWizard)getWizard()).isInitializingFromJarPackage()) initializeJarPackage(); fExportWarningsCheckbox.setSelection(fJarPackage.exportWarnings()); fExportErrorsCheckbox.setSelection(fJarPackage.areErrorsExported()); fBuildIfNeededCheckbox.setSelection(fJarPackage.isBuildingIfNeeded()); fUseSourceFoldersCheckbox.setSelection(fJarPackage.useSourceFolderHierarchy()); fSaveDescriptionCheckbox.setSelection(fJarPackage.isDescriptionSaved()); fDescriptionFileText.setText(fJarPackage.getDescriptionLocation().toString()); } /** * Initializes the JAR package from last used wizard page values. */ protected void initializeJarPackage() { IDialogSettings settings= getDialogSettings(); if (settings != null) { fJarPackage.setExportWarnings(settings.getBoolean(STORE_EXPORT_WARNINGS)); fJarPackage.setExportErrors(settings.getBoolean(STORE_EXPORT_ERRORS)); fJarPackage.setUseSourceFolderHierarchy(settings.getBoolean(STORE_USE_SRC_FOLDERS)); fJarPackage.setSaveDescription(settings.getBoolean(STORE_SAVE_DESCRIPTION)); String pathStr= settings.get(STORE_DESCRIPTION_LOCATION); if (pathStr == null) pathStr= ""; //$NON-NLS-1$ fJarPackage.setDescriptionLocation(new Path(pathStr)); if (settings.get(STORE_BUILD_IF_NEEDED) != null) fJarPackage.setBuildIfNeeded(settings.getBoolean(STORE_BUILD_IF_NEEDED)); } } private void update() { updateModel(); updateWidgetEnablements(); updatePageCompletion(); } /** * Stores the widget values in the JAR package. */ protected void updateModel() { if (getControl() == null) return; fJarPackage.setExportWarnings(fExportWarningsCheckbox.getSelection()); fJarPackage.setExportErrors(fExportErrorsCheckbox.getSelection()); fJarPackage.setBuildIfNeeded(fBuildIfNeededCheckbox.getSelection()); fJarPackage.setSaveDescription(fSaveDescriptionCheckbox.getSelection()); fJarPackage.setDescriptionLocation(new Path(fDescriptionFileText.getText())); fJarPackage.setUseSourceFolderHierarchy(fUseSourceFoldersCheckbox.getSelection()); } /** * Open an appropriate destination browser so that the user can specify a source * to import from */ protected void handleDescriptionFileBrowseButtonPressed() { SaveAsDialog dialog= new SaveAsDialog(getContainer().getShell()); dialog.create(); dialog.getShell().setText(JarPackagerMessages.getString("JarOptionsPage.saveAsDialog.title")); //$NON-NLS-1$ dialog.setMessage(JarPackagerMessages.getString("JarOptionsPage.saveAsDialog.message")); //$NON-NLS-1$ dialog.setOriginalFile(createFileHandle(fJarPackage.getDescriptionLocation())); if (dialog.open() == dialog.OK) { IPath path= dialog.getResult(); path= path.removeFileExtension().addFileExtension(JarPackagerUtil.DESCRIPTION_EXTENSION); fDescriptionFileText.setText(path.toString()); } } /** * Updates the enablements of this page's controls. Subclasses may extend. */ protected void updateWidgetEnablements() { boolean saveDescription= fSaveDescriptionCheckbox.getSelection(); fDescriptionFileGroup.setEnabled(saveDescription); fDescriptionFileBrowseButton.setEnabled(saveDescription); fDescriptionFileText.setEnabled(saveDescription); fDescriptionFileLabel.setEnabled(saveDescription); } /* * Implements method from IJarPackageWizardPage */ public boolean isPageComplete() { if (fJarPackage.isDescriptionSaved()){ if (fJarPackage.getDescriptionLocation().toString().length() == 0) { setErrorMessage(null); return false; } IPath location= fJarPackage.getDescriptionLocation(); if (!location.toString().startsWith("/")) { //$NON-NLS-1$ setErrorMessage(JarPackagerMessages.getString("JarOptionsPage.error.descriptionMustBeAbsolute")); //$NON-NLS-1$ return false; } IResource resource= findResource(location); if (resource != null && resource.getType() != IResource.FILE) { setErrorMessage(JarPackagerMessages.getString("JarOptionsPage.error.descriptionMustNotBeExistingContainer")); //$NON-NLS-1$ return false; } resource= findResource(location.removeLastSegments(1)); if (resource == null || resource.getType() == IResource.FILE) { setErrorMessage(JarPackagerMessages.getString("JarOptionsPage.error.descriptionContainerDoesNotExist")); //$NON-NLS-1$ return false; } String fileExtension= fJarPackage.getDescriptionLocation().getFileExtension(); if (fileExtension == null || !fileExtension.equals(JarPackagerUtil.DESCRIPTION_EXTENSION)) { setErrorMessage(JarPackagerMessages.getFormattedString("JarOptionsPage.error.invalidDescriptionExtension", JarPackagerUtil.DESCRIPTION_EXTENSION)); //$NON-NLS-1$ return false; } } setErrorMessage(null); return true; } public boolean canFlipToNextPage() { return fJarPackage.areClassFilesExported() && super.canFlipToNextPage(); } /* * Overrides method from WizardDataTransferPage */ protected void createDescriptionFileGroup(Composite parent) { // destination specification group fDescriptionFileGroup= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 3; fDescriptionFileGroup.setLayout(layout); fDescriptionFileGroup.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.VERTICAL_ALIGN_FILL | GridData.GRAB_HORIZONTAL)); fDescriptionFileLabel= new Label(fDescriptionFileGroup, SWT.NONE); fDescriptionFileLabel.setText(JarPackagerMessages.getString("JarOptionsPage.descriptionFile.label")); //$NON-NLS-1$ // destination name entry field fDescriptionFileText= new Text(fDescriptionFileGroup, SWT.SINGLE | SWT.BORDER); fDescriptionFileText.addListener(SWT.Modify, new UntypedListener()); GridData data= new GridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.GRAB_HORIZONTAL); data.widthHint= convertWidthInCharsToPixels(40); fDescriptionFileText.setLayoutData(data); // destination browse button fDescriptionFileBrowseButton= new Button(fDescriptionFileGroup, SWT.PUSH); fDescriptionFileBrowseButton.setText(JarPackagerMessages.getString("JarOptionsPage.browseButton.text")); //$NON-NLS-1$ fDescriptionFileBrowseButton.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_FILL)); SWTUtil.setButtonDimensionHint(fDescriptionFileBrowseButton); fDescriptionFileBrowseButton.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { handleDescriptionFileBrowseButtonPressed(); } }); } /** * Creates a file resource handle for the file with the given workspace path. * This method does not create the file resource; this is the responsibility * of <code>createFile</code>. * * @param filePath the path of the file resource to create a handle for * @return the new file resource handle * @see #createFile */ protected IFile createFileHandle(IPath filePath) { if (filePath.isValidPath(filePath.toString()) && filePath.segmentCount() >= 2) return JavaPlugin.getWorkspace().getRoot().getFile(filePath); else return null; } /* * Method declared on IWizardPage. */ public void setPreviousPage(IWizardPage page) { super.setPreviousPage(page); if (getControl() != null) updatePageCompletion(); } /* * Implements method from IJarPackageWizardPage. */ public void finish() { saveWidgetValues(); } /** * Creates a new label with a bold font. * * @param parent the parent control * @param text the label text * @return the new label control */ protected Label createLabel(Composite parent, String text, boolean bold) { Label label= new Label(parent, SWT.NONE); if (bold) label.setFont(JFaceResources.getBannerFont()); label.setText(text); GridData data= new GridData(); data.verticalAlignment= GridData.FILL; data.horizontalAlignment= GridData.FILL; label.setLayoutData(data); return label; } /** * Creates a horizontal spacer line that fills the width of its container. * * @param parent the parent control */ protected void createSpacer(Composite parent) { Label spacer= new Label(parent, SWT.NONE); GridData data= new GridData(); data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; spacer.setLayoutData(data); } /** * Determine if the page is complete and update the page appropriately. */ protected void updatePageCompletion() { boolean pageComplete= isPageComplete(); fUseSourceFoldersCheckbox.setEnabled(fJarPackage.areJavaFilesExported() && !fJarPackage.areClassFilesExported()); setPageComplete(pageComplete); if (pageComplete) { setErrorMessage(null); } } /** * Returns the resource for the specified path. * * @param path the path for which the resource should be returned * @return the resource specified by the path or <code>null</code> */ protected IResource findResource(IPath path) { IWorkspace workspace= JavaPlugin.getWorkspace(); IStatus result= workspace.validatePath( path.toString(), IResource.ROOT | IResource.PROJECT | IResource.FOLDER | IResource.FILE); if (result.isOK() && workspace.getRoot().exists(path)) return workspace.getRoot().findMember(path); return null; } }
21,767
Bug 21767 nls wizard: needs an 'edit' button
null
resolved fixed
c745d9d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T13:28:59Z
2002-07-22T15:00:00Z
org.eclipse.jdt.ui/ui
21,767
Bug 21767 nls wizard: needs an 'edit' button
null
resolved fixed
c745d9d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T13:28:59Z
2002-07-22T15:00:00Z
refactoring/org/eclipse/jdt/internal/ui/refactoring/nls/ExternalizeWizardPage.java
19,930
Bug 19930 Refactor->Extract Local Variable should guess name [refactoring]
Build F2 90% of the time, when I extract a local variable, the variable name could be easily inferred from selected code. If the last message send in selected code is of the form 'getXXX', the variable name should probably be XXX. e.g. I just extracted a local variable from the following code: getEditorPart().getToolTipHandler() not surprisingly, I named the variable toolTipHandler. It would be nice if the action figured this out for itself and seeded the variable name text field with this guess.
resolved fixed
d15285c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T13:30:25Z
2002-06-11T18:26:40Z
org.eclipse.jdt.ui/core
19,930
Bug 19930 Refactor->Extract Local Variable should guess name [refactoring]
Build F2 90% of the time, when I extract a local variable, the variable name could be easily inferred from selected code. If the last message send in selected code is of the form 'getXXX', the variable name should probably be XXX. e.g. I just extracted a local variable from the following code: getEditorPart().getToolTipHandler() not surprisingly, I named the variable toolTipHandler. It would be nice if the action figured this out for itself and seeded the variable name text field with this guess.
resolved fixed
d15285c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T13:30:25Z
2002-06-11T18:26:40Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractTempRefactoring.java
21,939
Bug 21939 extract temp: incorrect if expression used as statement [refactoring]
2.0 class A { int f(){ int t= f(); f(); return 1; } } extract f() from the first line - you end up with syntax errors
resolved fixed
a0c4d3c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T14:38:34Z
2002-07-26T13:26:40Z
org.eclipse.jdt.ui/core
21,939
Bug 21939 extract temp: incorrect if expression used as statement [refactoring]
2.0 class A { int f(){ int t= f(); f(); return 1; } } extract f() from the first line - you end up with syntax errors
resolved fixed
a0c4d3c
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T14:38:34Z
2002-07-26T13:26:40Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractTempRefactoring.java
21,815
Bug 21815 Refactor: should be able to extract local variable from expression used as statement
Enter the following class: public class Foo { public static void main(String[] arguments) { new String(); } } Select 'new String()' and choose 'Refactor'->'Extract local variable'. An error message appears saying: 'Cannot extract expressions used as statements.' This seems like an unnecessary restriction. I would like this action to generate: public class Foo { public static void main(String[] arguments) { String temp = new String(); } } This would be useful when you are not sure of the return type of an expression, for instance.
resolved fixed
c36b891
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T16:19:18Z
2002-07-23T16:00:00Z
org.eclipse.jdt.ui/core
21,815
Bug 21815 Refactor: should be able to extract local variable from expression used as statement
Enter the following class: public class Foo { public static void main(String[] arguments) { new String(); } } Select 'new String()' and choose 'Refactor'->'Extract local variable'. An error message appears saying: 'Cannot extract expressions used as statements.' This seems like an unnecessary restriction. I would like this action to generate: public class Foo { public static void main(String[] arguments) { String temp = new String(); } } This would be useful when you are not sure of the return type of an expression, for instance.
resolved fixed
c36b891
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-07-26T16:19:18Z
2002-07-23T16:00:00Z
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractTempRefactoring.java
207,141
Bug 207141 [Automation][Regression]There is a faint secondary image in column when preview reportdesign in PDF
Description: There is a faint secondary image in one column when preview reportdesign in PDF TestDate: 20071023 steps to reproduce: - use the attached report design - preview it in PDF Expected Result: Report should be preview correctly Actual Result: There is a faint secondary image.
closed fixed
ea120e7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T10:23:13Z
2007-10-23T09:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/OptionalMessageDialog.java
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
org.eclipse.jdt.ui/core
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
extension/org/eclipse/jdt/internal/corext/template/TemplateContext.java
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
org.eclipse.jdt.ui/core
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
extension/org/eclipse/jdt/internal/corext/template/java/JavaContext.java
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
org.eclipse.jdt.ui/core
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
extension/org/eclipse/jdt/internal/corext/template/java/JavaContextType.java
20,424
Bug 20424 Autocompletion "Iterate through Collection" should add "import java.util.Iterator"
I use autocompletion to generate an iteration through a collection. So this is the kind of code I'm getting: for (Iterator iter = myCollection.iterator(); iter.hasNext();) { type element = (type) iter.next(); However, autocompletion leaves my .java file without the neccessary import java.util.Iterator; required for all of this to make sense. I feel it's not as "auto" and not as "complete" as it could be (if you pardon the pun).
resolved fixed
3993ffa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:09:50Z
2002-06-17T10:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateProposal.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.text.template; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.contentassist.IContextInformation; import org.eclipse.jdt.internal.corext.Assert; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.TemplateBuffer; import org.eclipse.jdt.internal.corext.template.TemplateContext; import org.eclipse.jdt.internal.corext.template.TemplateMessages; import org.eclipse.jdt.internal.corext.template.TemplatePosition; import org.eclipse.jdt.internal.corext.template.java.JavaContext; import org.eclipse.jdt.internal.corext.template.java.JavaDocContext; import org.eclipse.jdt.internal.corext.template.java.JavaTemplateMessages; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.text.java.IJavaCompletionProposal; import org.eclipse.jdt.internal.ui.text.link.LinkedPositionManager; import org.eclipse.jdt.internal.ui.text.link.LinkedPositionUI; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * A template proposal. */ public class TemplateProposal implements IJavaCompletionProposal { private final Template fTemplate; private final TemplateContext fContext; private final ITextViewer fViewer; private final Image fImage; private final IRegion fRegion; private TemplateBuffer fTemplateBuffer; private String fOldText; private IRegion fSelectedRegion; // initialized by apply() /** * Creates a template proposal with a template and its context. * @param template the template * @param context the context in which the template was requested. * @param image the icon of the proposal. */ public TemplateProposal(Template template, TemplateContext context, IRegion region, ITextViewer viewer, Image image) { Assert.isNotNull(template); Assert.isNotNull(context); Assert.isNotNull(region); Assert.isNotNull(viewer); fTemplate= template; fContext= context; fViewer= viewer; fImage= image; fRegion= region; } /* * @see ICompletionProposal#apply(IDocument) */ public void apply(IDocument document) { try { if (fTemplateBuffer == null) fTemplateBuffer= fContext.evaluate(fTemplate); int start= fRegion.getOffset(); int end= fRegion.getOffset() + fRegion.getLength(); // insert template string String templateString= fTemplateBuffer.getString(); document.replace(start, end - start, templateString); // translate positions LinkedPositionManager manager= new LinkedPositionManager(document); TemplatePosition[] variables= fTemplateBuffer.getVariables(); for (int i= 0; i != variables.length; i++) { TemplatePosition variable= variables[i]; if (variable.isResolved()) continue; int[] offsets= variable.getOffsets(); int length= variable.getLength(); for (int j= 0; j != offsets.length; j++) manager.addPosition(offsets[j] + start, length); } LinkedPositionUI editor= new LinkedPositionUI(fViewer, manager); editor.setFinalCaretOffset(getCaretOffset(fTemplateBuffer) + start); editor.enter(); fSelectedRegion= editor.getSelectedRegion(); } catch (BadLocationException e) { JavaPlugin.log(e); openErrorDialog(e); } catch (CoreException e) { handleException(e); } } private static int getCaretOffset(TemplateBuffer buffer) { TemplatePosition[] variables= buffer.getVariables(); for (int i= 0; i != variables.length; i++) { TemplatePosition variable= variables[i]; if (variable.getName().equals(JavaTemplateMessages.getString("GlobalVariables.variable.name.cursor"))) //$NON-NLS-1$ return variable.getOffsets()[0]; } return buffer.getString().length(); } /* * @see ICompletionProposal#getSelection(IDocument) */ public Point getSelection(IDocument document) { return new Point(fSelectedRegion.getOffset(), fSelectedRegion.getLength()); } /* * @see ICompletionProposal#getAdditionalProposalInfo() */ public String getAdditionalProposalInfo() { try { if (fTemplateBuffer == null) fTemplateBuffer= fContext.evaluate(fTemplate); return textToHTML(fTemplateBuffer.getString()); } catch (CoreException e) { handleException(e); return null; } } /* * @see ICompletionProposal#getDisplayString() */ public String getDisplayString() { return fTemplate.getName() + TemplateMessages.getString("TemplateProposal.delimiter") + fTemplate.getDescription(); // $NON-NLS-1$ //$NON-NLS-1$ } /* * @see ICompletionProposal#getImage() */ public Image getImage() { return fImage; } /* * @see ICompletionProposal#getContextInformation() */ public IContextInformation getContextInformation() { return null; } private static String textToHTML(String string) { StringBuffer buffer= new StringBuffer(string.length()); buffer.append("<pre>"); //$NON-NLS-1$ for (int i= 0; i != string.length(); i++) { char ch= string.charAt(i); switch (ch) { case '&': buffer.append("&amp;"); //$NON-NLS-1$ break; case '<': buffer.append("&lt;"); //$NON-NLS-1$ break; case '>': buffer.append("&gt;"); //$NON-NLS-1$ break; case '\t': buffer.append(" "); //$NON-NLS-1$ break; case '\n': buffer.append("<br>"); //$NON-NLS-1$ break; default: buffer.append(ch); break; } } buffer.append("</pre>"); //$NON-NLS-1$ return buffer.toString(); } private void openErrorDialog(BadLocationException e) { Shell shell= fViewer.getTextWidget().getShell(); MessageDialog.openError(shell, TemplateMessages.getString("TemplateEvaluator.error.title"), e.getMessage()); //$NON-NLS-1$ } private void handleException(CoreException e) { Shell shell= fViewer.getTextWidget().getShell(); ExceptionHandler.handle(e, shell, TemplateMessages.getString("TemplateEvaluator.error.title"), null); //$NON-NLS-1$ } /* * @see IJavaCompletionProposal#getRelevance() */ public int getRelevance() { if (fContext instanceof JavaContext) { JavaContext context= (JavaContext) fContext; switch (context.getCharacterBeforeStart()) { // high relevance after whitespace case ' ': case '\r': case '\n': case '\t': return 90; default: return 0; } } else { return 90; } } }
21,631
Bug 21631 JavaUI.createTypeDialog() should provide default message [dialogs]
2.0 Release If you use JavaUI.createTypeDialog() to create a new (single selection) type dialog, and then open the dialog, the open will fail silently. The dialog cannot be succesfully opened unless you send setMessage() to the dialog before you open it. This behaviour should be documented, or, preferably, a default message ("Please select a type/class/interface") should be provided.
resolved fixed
cd4525e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:26:51Z
2002-07-16T20:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaUI.java
/******************************************************************************* * Copyright (c) 2000, 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v1.0 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v10.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui; import java.net.URL; import java.util.ArrayList; import java.util.Arrays; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IProject; import org.eclipse.core.runtime.IPath; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.dialogs.ElementListSelectionDialog; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.jdt.core.IBufferFactory; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchConstants; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.SharedImages; import org.eclipse.jdt.internal.ui.dialogs.MainTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MultiMainTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MultiTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.TypeSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; /** * Central access point for the Java UI plug-in (id <code>"org.eclipse.jdt.ui"</code>). * This class provides static methods for: * <ul> * <li> creating various kinds of selection dialogs to present a collection * of Java elements to the user and let them make a selection.</li> * <li> opening a Java editor on a compilation unit.</li> * </ul> * <p> * This class provides static methods and fields only; it is not intended to be * instantiated or subclassed by clients. * </p> */ public final class JavaUI { private static ISharedImages fgSharedImages= null; private JavaUI() { // prevent instantiation of JavaUI. } /** * The id of the Java plugin (value <code>"org.eclipse.jdt.ui"</code>). */ public static final String ID_PLUGIN= "org.eclipse.jdt.ui"; //$NON-NLS-1$ /** * The id of the Java perspective * (value <code>"org.eclipse.jdt.ui.JavaPerspective"</code>). */ public static final String ID_PERSPECTIVE= "org.eclipse.jdt.ui.JavaPerspective"; //$NON-NLS-1$ /** * The id of the Java hierarchy perspective * (value <code>"org.eclipse.jdt.ui.JavaHierarchyPerspective"</code>). */ public static final String ID_HIERARCHYPERSPECTIVE= "org.eclipse.jdt.ui.JavaHierarchyPerspective"; //$NON-NLS-1$ /** * The id of the Java action set * (value <code>"org.eclipse.jdt.ui.JavaActionSet"</code>). */ public static final String ID_ACTION_SET= "org.eclipse.jdt.ui.JavaActionSet"; //$NON-NLS-1$ /** * The id of the Java Element Creation action set * (value <code>"org.eclipse.jdt.ui.JavaElementCreationActionSet"</code>). * * @since 2.0 */ public static final String ID_ELEMENT_CREATION_ACTION_SET= "org.eclipse.jdt.ui.JavaElementCreationActionSet"; //$NON-NLS-1$ /** * The id of the Java Coding action set * (value <code>"org.eclipse.jdt.ui.CodingActionSet"</code>). * * @since 2.0 */ public static final String ID_CODING_ACTION_SET= "org.eclipse.jdt.ui.CodingActionSet"; //$NON-NLS-1$ /** * The id of the Java action set for open actions * (value <code>"org.eclipse.jdt.ui.A_OpenActionSet"</code>). * * @since 2.0 */ public static final String ID_OPEN_ACTION_SET= "org.eclipse.jdt.ui.A_OpenActionSet"; //$NON-NLS-1$ /** * The id of the Java Search action set * (value <code>org.eclipse.jdt.ui.SearchActionSet"</code>). * * @since 2.0 */ public static final String ID_SEARCH_ACTION_SET= "org.eclipse.jdt.ui.SearchActionSet"; //$NON-NLS-1$ /** * The editor part id of the editor that presents Java compilation units * (value <code>"org.eclipse.jdt.ui.CompilationUnitEditor"</code>). */ public static final String ID_CU_EDITOR= "org.eclipse.jdt.ui.CompilationUnitEditor"; //$NON-NLS-1$ /** * The editor part id of the editor that presents Java binary class files * (value <code>"org.eclipse.jdt.ui.ClassFileEditor"</code>). */ public static final String ID_CF_EDITOR= "org.eclipse.jdt.ui.ClassFileEditor"; //$NON-NLS-1$ /** * The editor part id of the code snippet editor * (value <code>"org.eclipse.jdt.ui.SnippetEditor"</code>). */ public static final String ID_SNIPPET_EDITOR= "org.eclipse.jdt.ui.SnippetEditor"; //$NON-NLS-1$ /** * The view part id of the Packages view * (value <code>"org.eclipse.jdt.ui.PackageExplorer"</code>). * <p> * When this id is used to access * a view part with <code>IWorkbenchPage.findView</code> or * <code>showView</code>, the returned <code>IViewPart</code> * can be safely cast to an <code>IPackagesViewPart</code>. * </p> * * @see IPackagesViewPart * @see org.eclipse.ui.IWorkbenchPage#findView(java.lang.String) * @see org.eclipse.ui.IWorkbenchPage#showView(java.lang.String) */ public static final String ID_PACKAGES= "org.eclipse.jdt.ui.PackageExplorer"; //$NON-NLS-1$ /** * The view part id of the type hierarchy part. * (value <code>"org.eclipse.jdt.ui.TypeHierarchy"</code>). * <p> * When this id is used to access * a view part with <code>IWorkbenchPage.findView</code> or * <code>showView</code>, the returned <code>IViewPart</code> * can be safely cast to an <code>ITypeHierarchyViewPart</code>. * </p> * * @see ITypeHierarchyViewPart * @see org.eclipse.ui.IWorkbenchPage#findView(java.lang.String) * @see org.eclipse.ui.IWorkbenchPage#showView(java.lang.String) */ public static final String ID_TYPE_HIERARCHY= "org.eclipse.jdt.ui.TypeHierarchy"; //$NON-NLS-1$ /** * The id of the Java Browsing Perspective * (value <code>"org.eclipse.jdt.ui.JavaBrowsingPerspective"</code>). * * @since 2.0 */ public static String ID_BROWSING_PERSPECTIVE= "org.eclipse.jdt.ui.JavaBrowsingPerspective"; //$NON-NLS-1$ /** * The view part id of the Java Browsing Projects view * (value <code>"org.eclipse.jdt.ui.ProjectsView"</code>). * * @since 2.0 */ public static String ID_PROJECTS_VIEW= "org.eclipse.jdt.ui.ProjectsView"; //$NON-NLS-1$ /** * The view part id of the Java Browsing Packages view * (value <code>"org.eclipse.jdt.ui.PackagesView"</code>). * * @since 2.0 */ public static String ID_PACKAGES_VIEW= "org.eclipse.jdt.ui.PackagesView"; //$NON-NLS-1$ /** * The view part id of the Java Browsing Types view * (value <code>"org.eclipse.jdt.ui.TypesView"</code>). * * @since 2.0 */ public static String ID_TYPES_VIEW= "org.eclipse.jdt.ui.TypesView"; //$NON-NLS-1$ /** * The view part id of the Java Browsing Members view * (value <code>"org.eclipse.jdt.ui.MembersView"</code>). * * @since 2.0 */ public static String ID_MEMBERS_VIEW= "org.eclipse.jdt.ui.MembersView"; //$NON-NLS-1$ /** * The class org.eclipse.debug.core.model.IProcess allows attaching * String properties to processes. The Java UI contributes a property * page for IProcess that will show the contents of the property * with this key. * The intent of this property is to show the command line a process * was launched with. * @deprecated */ public final static String ATTR_CMDLINE= JavaPlugin.getPluginId()+".launcher.cmdLine"; //$NON-NLS-1$ /** * Returns the shared images for the Java UI. * * @return the shared images manager */ public static ISharedImages getSharedImages() { if (fgSharedImages == null) fgSharedImages= new SharedImages(); return fgSharedImages; } /** * Creates a selection dialog that lists all packages of the given Java project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected package (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param project the Java project * @param style flags defining the style of the dialog; the valid flags are: * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, indicating that * packages from binary package fragment roots should be included in addition * to those from source package fragment roots; * <code>IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS</code>, indicating that * packages from required projects should be included as well. * @param filter the initial pattern to filter the set of packages. For example "com" shows * all packages starting with "com". The meta character '?' representing any character and * '*' representing any string are supported. Clients can pass an empty string if no filtering * is required. * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened * * @since 2.0 */ public static SelectionDialog createPackageDialog(Shell parent, IJavaProject project, int style, String filter) throws JavaModelException { Assert.isTrue((style | IJavaElementSearchConstants.CONSIDER_BINARIES | IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS) == (IJavaElementSearchConstants.CONSIDER_BINARIES | IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS)); IPackageFragmentRoot[] roots= null; if ((style & IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS) != 0) { roots= project.getAllPackageFragmentRoots(); } else { roots= project.getPackageFragmentRoots(); } List consideredRoots= null; if ((style & IJavaElementSearchConstants.CONSIDER_BINARIES) != 0) { consideredRoots= Arrays.asList(roots); } else { consideredRoots= new ArrayList(roots.length); for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot root= roots[i]; if (root.getKind() != IPackageFragmentRoot.K_BINARY) consideredRoots.add(root); } } int flags= JavaElementLabelProvider.SHOW_DEFAULT; if (consideredRoots.size() > 1) flags= flags | JavaElementLabelProvider.SHOW_ROOT; List packages= new ArrayList(); Iterator iter= consideredRoots.iterator(); while(iter.hasNext()) { IPackageFragmentRoot root= (IPackageFragmentRoot)iter.next(); packages.addAll(Arrays.asList(root.getChildren())); } ElementListSelectionDialog dialog= new ElementListSelectionDialog(parent, new JavaElementLabelProvider(flags)); dialog.setIgnoreCase(false); dialog.setElements(packages.toArray()); // XXX inefficient dialog.setFilter(filter); return dialog; } /** * Creates a selection dialog that lists all packages of the given Java project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected package (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param project the Java project * @param style flags defining the style of the dialog; the valid flags are: * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, indicating that * packages from binary package fragment roots should be included in addition * to those from source package fragment roots; * <code>IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS</code>, indicating that * packages from required projects should be included as well. * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createPackageDialog(Shell parent, IJavaProject project, int style) throws JavaModelException { return createPackageDialog(parent, project, style, ""); //$NON-NLS-1$ } /** * Creates a selection dialog that lists all packages under the given package * fragment root. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected package (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param root the package fragment root * @param filter the initial pattern to filter the set of packages. For example "com" shows * all packages starting with "com". The meta character '?' representing any character and * '*' representing any string are supported. Clients can pass an empty string if no filtering * is required. * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened * * @since 2.0 */ public static SelectionDialog createPackageDialog(Shell parent, IPackageFragmentRoot root, String filter) throws JavaModelException { ElementListSelectionDialog dialog= new ElementListSelectionDialog(parent, new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT)); dialog.setIgnoreCase(false); dialog.setElements(root.getChildren()); dialog.setFilter(filter); return dialog; } /** * Creates a selection dialog that lists all packages under the given package * fragment root. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected package (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param root the package fragment root * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createPackageDialog(Shell parent, IPackageFragmentRoot root) throws JavaModelException { return createPackageDialog(parent, root, ""); //$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given scope. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected type(s) (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @param filter the initial pattern to filter the set of types. For example "Abstract" shows * all types starting with "abstract". The meta character '?' representing any character and * '*' representing any string are supported. Clients can pass an empty string if no filtering * is required. * @exception JavaModelException if the selection dialog could not be opened * * @since 2.0 */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection, String filter) throws JavaModelException { int elementKinds= 0; if (style == IJavaElementSearchConstants.CONSIDER_TYPES) { elementKinds= IJavaSearchConstants.TYPE; } else if (style == IJavaElementSearchConstants.CONSIDER_INTERFACES) { elementKinds= IJavaSearchConstants.INTERFACE; } else if (style == IJavaElementSearchConstants.CONSIDER_CLASSES) { elementKinds= IJavaSearchConstants.CLASS; } else { Assert.isTrue(false, "illegal style"); //$NON-NLS-1$ } if (multipleSelection) { MultiTypeSelectionDialog dialog= new MultiTypeSelectionDialog(parent, context, elementKinds, scope); dialog.setFilter(filter); return dialog; } else { TypeSelectionDialog dialog= new TypeSelectionDialog(parent, context, elementKinds, scope); dialog.setFilter(filter); return dialog; } } /** * Creates a selection dialog that lists all types in the given scope. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected type(s) (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection) throws JavaModelException { return createTypeDialog(parent, context, scope, style, multipleSelection, "");//$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given scope containing * a standard <code>main</code> method. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected type(s) (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, * <code>CONSIDER_EXTERNAL_JARS</code>, or their bitwise OR, or <code>0</code> * @param multipleSelection <code>true</code> if multiple selection is allowed * @param filter the initial pattern to filter the set of types containg a main method. For * example "App" shows all types starting with "app". The meta character '?' representing * any character and '*' representing any string are supported. Clients can pass an empty * string if no filtering is required. * @return a new selection dialog * * @since 2.0 */ public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection, String filter) { if (multipleSelection) { MultiMainTypeSelectionDialog dialog= new MultiMainTypeSelectionDialog(parent, context, scope, style); dialog.setFilter(filter); return dialog; } else { MainTypeSelectionDialog dialog= new MainTypeSelectionDialog(parent, context, scope, style); dialog.setFilter(filter); return dialog; } } /** * Creates a selection dialog that lists all types in the given scope containing * a standard <code>main</code> method. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected type(s) (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, * <code>CONSIDER_EXTERNAL_JARS</code>, or their bitwise OR, or <code>0</code> * @param multipleSelection <code>true</code> if multiple selection is allowed * @return a new selection dialog */ public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection) { return createMainTypeDialog(parent, context, scope, style, multipleSelection, "");//$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected type(s) (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param project the Java project * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IProject project, int style, boolean multipleSelection) throws JavaModelException { IJavaSearchScope scope= SearchEngine.createJavaSearchScope(new IJavaProject[] { JavaCore.create(project) }); return createTypeDialog(parent, context, scope, style, multipleSelection); } /** * Opens a Java editor on the given Java element. The element can be a compilation unit * or class file. If there already is an open Java editor for the given element, it is returned. * * @param element the input element; either a compilation unit * (<code>ICompilationUnit</code>) or a class file (</code>IClassFile</code>) * @return the editor, or </code>null</code> if wrong element type or opening failed * @exception PartInitException if the editor could not be initialized * @exception JavaModelException if this element does not exist or if an * exception occurs while accessing its underlying resource */ public static IEditorPart openInEditor(IJavaElement element) throws JavaModelException, PartInitException { return EditorUtility.openInEditor(element); } /** * Reveals the source range of the given source reference element in the * given editor. No checking is done if the editor displays a compilation unit or * class file that contains the given source reference. The editor simply reveals * the source range denoted by the given source reference. * * @param part the editor displaying the compilation unit or class file * @param element the source reference element defining the source range to be revealed * * @deprecated use <code>revealInEditor(IEditorPart, IJavaElement)</code> instead */ public static void revealInEditor(IEditorPart part, ISourceReference element) { if (element instanceof IJavaElement) revealInEditor(part, (IJavaElement) element); } /** * Reveals the given java element in the given editor. If the element is not an instance * of <code>ISourceReference</code> this method result in a NOP. If it is a source * reference no checking is done if the editor displays a compilation unit or class file that * contains the source reference element. The editor simply reveals the source range * denoted by the given element. * * @param part the editor displaying a compilation unit or class file * @param element the element to be revealed * * @since 2.0 */ public static void revealInEditor(IEditorPart part, IJavaElement element) { EditorUtility.revealInEditor(part, element); } /** * Returns the working copy manager for the Java UI plug-in. * * @return the working copy manager for the Java UI plug-in */ public static IWorkingCopyManager getWorkingCopyManager() { return JavaPlugin.getDefault().getWorkingCopyManager(); } /** * Answers the shared working copies currently registered for the Java plug-in. * * @return the list of shared working copies this plug-in * * @see org.eclipse.jdt.core.JavaCore#getSharedWorkingCopies(org.eclipse.jdt.core.IBufferFactory) * @since 2.0 */ public static IWorkingCopy[] getSharedWorkingCopies() { return JavaCore.getSharedWorkingCopies(getBufferFactory()); } /** * Returns the BufferFactory for the Java UI plug-in. * * @return the BufferFactory for the Java UI plug-in * * @see org.eclipse.jdt.core.IBufferFactory * @since 2.0 */ public static IBufferFactory getBufferFactory() { CompilationUnitDocumentProvider provider= JavaPlugin.getDefault().getCompilationUnitDocumentProvider(); if (provider != null) return provider.getBufferFactory(); return null; } /** * Returns the DocumentProvider used for Java compilation units. * * @return the DocumentProvider for Java compilation units. * * @see IDocumentProvider * @since 2.0 */ public static IDocumentProvider getDocumentProvider() { return JavaPlugin.getDefault().getCompilationUnitDocumentProvider(); } /** * Sets the Javadoc location for an archive with the given path. * * @param archivePath the path of the library; this can be an workspace path * or an external path in case of an external library. * @param url The Javadoc location to set. This location should contain index.html and * a file 'package-list'. * * @since 2.0 */ public static void setLibraryJavadocLocation(IPath archivePath, URL url) { JavaDocLocations.setLibraryJavadocLocation(archivePath, url); } /** * Returns the Javadoc location for an archive or <code>null</code> if no * location is available. * * @param archivePath the path of the library. This can be an workspace path * or an external path in case of an external library. * * @since 2.0 */ public static URL getLibraryJavadocLocation(IPath archivePath) { return JavaDocLocations.getLibraryJavadocLocation(archivePath); } /** * Returns the Javadoc base URL for an element. The base location contains the * index file. This location must not exist. Returns <code>null</code> if no javadoc location * has been attached to the element's library or project. * Example of a returned URL is <i>http://www.junit.org/junit/javadoc</i>. * * @param The element for witch the doc URL is requested. * * @since 2.0 */ public static URL getJavadocBaseLocation(IJavaElement element) throws JavaModelException { return JavaDocLocations.getJavadocBaseLocation(element); } /** * Returns the Javadoc URL for an element. Example of a returned URL is * <i>http://www.junit.org/junit/javadoc/junit/extensions/TestSetup.html</i>. * This returned location must not exist. Returns <code>null</code> if no javadoc location * has been attached to the element's library or project. * * @param The element for witch the doc URL is requested. * @param includeAnchor If set, the URL contains an anchor for member references: * <i>http://www.junit.org/junit/javadoc/junit/extensions/TestSetup.html#run(junit.framework.TestResult)</i>. Note * that this involves type resolving and is a more expensive call than without anchor. * * @since 2.0 */ public static URL getJavadocLocation(IJavaElement element, boolean includeAnchor) throws JavaModelException { return JavaDocLocations.getJavadocLocation(element, includeAnchor); } }
15,247
Bug 15247 Class/Interface wizard fails if a ${cursor} variable is in the type or filecomment template
Upon using the New Class or New Interface wizard, if typecomment or filecomment is enabled at that template has a ${cursor} variable in it, the wizard fails with this exception: !ENTRY org.eclipse.jdt.ui 4 1 Fri May 03 16:58:04 MDT 2002 !MESSAGE Internal Error !STACK Java Model Exception: Java Model Status [Invalid contents specified.] at org.eclipse.jdt.internal.core.JavaModelOperation.execute(JavaModelOperation.java:270) at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:476) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1361) at org.eclipse.jdt.internal.core.JavaModelManager.runOperation(JavaModelManager.java:1281) at org.eclipse.jdt.internal.core.JavaElement.runOperation(JavaElement.java:552) at org.eclipse.jdt.internal.core.CompilationUnit.createType(CompilationUnit.java:169) at org.eclipse.jdt.ui.wizards.NewTypeWizardPage.createType(NewTypeWizardPage.java:1187) at org.eclipse.jdt.ui.wizards.NewTypeWizardPage$1.run(NewTypeWizardPage.java:1416) at org.eclipse.ui.actions.WorkspaceModifyDelegatingOperation.execute(WorkspaceModifyDelegatingOperation.java:39) at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:64) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1361) at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:78) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:249) at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:720) at org.eclipse.jdt.internal.ui.wizards.NewElementWizard.finishPage(NewElementWizard.java:66) at org.eclipse.jdt.internal.ui.wizards.NewClassCreationWizard.performFinish(NewClassCreationWizard.java:42) at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:577) at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:312) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:379) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:637) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1412) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1208) at org.eclipse.jface.window.Window.runEventLoop(Window.java:538) at org.eclipse.jface.window.Window.open(Window.java:525) at org.eclipse.jdt.internal.ui.wizards.AbstractOpenWizardAction.run(AbstractOpenWizardAction.java:147) at org.eclipse.jdt.internal.ui.wizards.AbstractOpenWizardAction.run(AbstractOpenWizardAction.java:165) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:202) at org.eclipse.ui.internal.WWinPluginAction.runWithEvent(WWinPluginAction.java:165) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:637) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1412) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1208) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:883) at org.eclipse.ui.internal.Workbench.run(Workbench.java:866) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:733) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:349) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.basicRun(Main.java:162) at org.eclipse.core.launcher.Main.run(Main.java:588) at org.eclipse.core.launcher.Main.main(Main.java:437) The underlying file is created, but it contains only the package declaration. Removing the ${cursor} var fixes this. While having that var in these templates doesn't make much sense, it still shouldn't cause a problem like this. This is with the 0502 integration build.
resolved fixed
6a0c3d4
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:56:40Z
2002-05-03T23:53:20Z
org.eclipse.jdt.ui/core
15,247
Bug 15247 Class/Interface wizard fails if a ${cursor} variable is in the type or filecomment template
Upon using the New Class or New Interface wizard, if typecomment or filecomment is enabled at that template has a ${cursor} variable in it, the wizard fails with this exception: !ENTRY org.eclipse.jdt.ui 4 1 Fri May 03 16:58:04 MDT 2002 !MESSAGE Internal Error !STACK Java Model Exception: Java Model Status [Invalid contents specified.] at org.eclipse.jdt.internal.core.JavaModelOperation.execute(JavaModelOperation.java:270) at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:476) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1361) at org.eclipse.jdt.internal.core.JavaModelManager.runOperation(JavaModelManager.java:1281) at org.eclipse.jdt.internal.core.JavaElement.runOperation(JavaElement.java:552) at org.eclipse.jdt.internal.core.CompilationUnit.createType(CompilationUnit.java:169) at org.eclipse.jdt.ui.wizards.NewTypeWizardPage.createType(NewTypeWizardPage.java:1187) at org.eclipse.jdt.ui.wizards.NewTypeWizardPage$1.run(NewTypeWizardPage.java:1416) at org.eclipse.ui.actions.WorkspaceModifyDelegatingOperation.execute(WorkspaceModifyDelegatingOperation.java:39) at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:64) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1361) at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:78) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:249) at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:720) at org.eclipse.jdt.internal.ui.wizards.NewElementWizard.finishPage(NewElementWizard.java:66) at org.eclipse.jdt.internal.ui.wizards.NewClassCreationWizard.performFinish(NewClassCreationWizard.java:42) at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:577) at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:312) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:379) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:637) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1412) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1208) at org.eclipse.jface.window.Window.runEventLoop(Window.java:538) at org.eclipse.jface.window.Window.open(Window.java:525) at org.eclipse.jdt.internal.ui.wizards.AbstractOpenWizardAction.run(AbstractOpenWizardAction.java:147) at org.eclipse.jdt.internal.ui.wizards.AbstractOpenWizardAction.run(AbstractOpenWizardAction.java:165) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:202) at org.eclipse.ui.internal.WWinPluginAction.runWithEvent(WWinPluginAction.java:165) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:75) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:637) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1412) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1208) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:883) at org.eclipse.ui.internal.Workbench.run(Workbench.java:866) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:733) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:349) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.basicRun(Main.java:162) at org.eclipse.core.launcher.Main.run(Main.java:588) at org.eclipse.core.launcher.Main.main(Main.java:437) The underlying file is created, but it contains only the package declaration. Removing the ${cursor} var fixes this. While having that var in these templates doesn't make much sense, it still shouldn't cause a problem like this. This is with the 0502 integration build.
resolved fixed
6a0c3d4
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T12:56:40Z
2002-05-03T23:53:20Z
extension/org/eclipse/jdt/internal/corext/template/java/JavaFormatter.java
14,646
Bug 14646 Template - local variable name should default to type name last segment
Build 20020423 When iteration over an array of IClasspathEntry[], the inserted local variable is 'iClasspathEntry', where it would make more sense to propose 'entry'. A simple way to solve this problem would be to default to a name computed by extracting the last segment of the name starting with an uppercase, and converting the uppercase into a lowercase one. IClasspathEntry --> entry Runnable --> runnable IResource --> resource
resolved fixed
323898f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T14:01:46Z
2002-04-25T15:53:20Z
org.eclipse.jdt.ui/core
14,646
Bug 14646 Template - local variable name should default to type name last segment
Build 20020423 When iteration over an array of IClasspathEntry[], the inserted local variable is 'iClasspathEntry', where it would make more sense to propose 'entry'. A simple way to solve this problem would be to default to a name computed by extracting the last segment of the name starting with an uppercase, and converting the uppercase into a lowercase one. IClasspathEntry --> entry Runnable --> runnable IResource --> resource
resolved fixed
323898f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T14:01:46Z
2002-04-25T15:53:20Z
extension/org/eclipse/jdt/internal/corext/codemanipulation/NameProposer.java
14,646
Bug 14646 Template - local variable name should default to type name last segment
Build 20020423 When iteration over an array of IClasspathEntry[], the inserted local variable is 'iClasspathEntry', where it would make more sense to propose 'entry'. A simple way to solve this problem would be to default to a name computed by extracting the last segment of the name starting with an uppercase, and converting the uppercase into a lowercase one. IClasspathEntry --> entry Runnable --> runnable IResource --> resource
resolved fixed
323898f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T14:01:46Z
2002-04-25T15:53:20Z
org.eclipse.jdt.ui/core
14,646
Bug 14646 Template - local variable name should default to type name last segment
Build 20020423 When iteration over an array of IClasspathEntry[], the inserted local variable is 'iClasspathEntry', where it would make more sense to propose 'entry'. A simple way to solve this problem would be to default to a name computed by extracting the last segment of the name starting with an uppercase, and converting the uppercase into a lowercase one. IClasspathEntry --> entry Runnable --> runnable IResource --> resource
resolved fixed
323898f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T14:01:46Z
2002-04-25T15:53:20Z
extension/org/eclipse/jdt/internal/corext/template/java/CompilationUnitCompletion.java
14,646
Bug 14646 Template - local variable name should default to type name last segment
Build 20020423 When iteration over an array of IClasspathEntry[], the inserted local variable is 'iClasspathEntry', where it would make more sense to propose 'entry'. A simple way to solve this problem would be to default to a name computed by extracting the last segment of the name starting with an uppercase, and converting the uppercase into a lowercase one. IClasspathEntry --> entry Runnable --> runnable IResource --> resource
resolved fixed
323898f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T14:01:46Z
2002-04-25T15:53:20Z
org.eclipse.jdt.ui/core
14,646
Bug 14646 Template - local variable name should default to type name last segment
Build 20020423 When iteration over an array of IClasspathEntry[], the inserted local variable is 'iClasspathEntry', where it would make more sense to propose 'entry'. A simple way to solve this problem would be to default to a name computed by extracting the last segment of the name starting with an uppercase, and converting the uppercase into a lowercase one. IClasspathEntry --> entry Runnable --> runnable IResource --> resource
resolved fixed
323898f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-05T14:01:46Z
2002-04-25T15:53:20Z
extension/org/eclipse/jdt/internal/corext/template/java/JavaContext.java
6,860
Bug 6860 template: for(array) - inserts qualified type name (+ incorrect temp name)
class A { class Inner{} void f(){ Inner[] t; //<<INSERT FOR(ARRAY) TEMPLATE HERE } } the created for loop is: for (int i = 0; i < t.length; i++) { A.Inner a.Inner = t[i]; }
resolved fixed
6dd9460
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T09:20:18Z
2001-12-12T18:00:00Z
org.eclipse.jdt.ui/core
6,860
Bug 6860 template: for(array) - inserts qualified type name (+ incorrect temp name)
class A { class Inner{} void f(){ Inner[] t; //<<INSERT FOR(ARRAY) TEMPLATE HERE } } the created for loop is: for (int i = 0; i < t.length; i++) { A.Inner a.Inner = t[i]; }
resolved fixed
6dd9460
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T09:20:18Z
2001-12-12T18:00:00Z
extension/org/eclipse/jdt/internal/corext/codemanipulation/NameProposer.java
6,860
Bug 6860 template: for(array) - inserts qualified type name (+ incorrect temp name)
class A { class Inner{} void f(){ Inner[] t; //<<INSERT FOR(ARRAY) TEMPLATE HERE } } the created for loop is: for (int i = 0; i < t.length; i++) { A.Inner a.Inner = t[i]; }
resolved fixed
6dd9460
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T09:20:18Z
2001-12-12T18:00:00Z
org.eclipse.jdt.ui/core
6,860
Bug 6860 template: for(array) - inserts qualified type name (+ incorrect temp name)
class A { class Inner{} void f(){ Inner[] t; //<<INSERT FOR(ARRAY) TEMPLATE HERE } } the created for loop is: for (int i = 0; i < t.length; i++) { A.Inner a.Inner = t[i]; }
resolved fixed
6dd9460
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T09:20:18Z
2001-12-12T18:00:00Z
extension/org/eclipse/jdt/internal/corext/template/java/CompilationUnitCompletion.java
6,860
Bug 6860 template: for(array) - inserts qualified type name (+ incorrect temp name)
class A { class Inner{} void f(){ Inner[] t; //<<INSERT FOR(ARRAY) TEMPLATE HERE } } the created for loop is: for (int i = 0; i < t.length; i++) { A.Inner a.Inner = t[i]; }
resolved fixed
6dd9460
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T09:20:18Z
2001-12-12T18:00:00Z
org.eclipse.jdt.ui/core
6,860
Bug 6860 template: for(array) - inserts qualified type name (+ incorrect temp name)
class A { class Inner{} void f(){ Inner[] t; //<<INSERT FOR(ARRAY) TEMPLATE HERE } } the created for loop is: for (int i = 0; i < t.length; i++) { A.Inner a.Inner = t[i]; }
resolved fixed
6dd9460
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T09:20:18Z
2001-12-12T18:00:00Z
extension/org/eclipse/jdt/internal/corext/template/java/JavaContext.java
9,615
Bug 9615 template pref page: should give warning if there are 2 {cursor} vars in a template
like in summary: template pref page should give warning if there are 2 {cursor} vars in a template
resolved fixed
726e202
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T13:31:16Z
2002-02-13T14:20:00Z
org.eclipse.jdt.ui/core
9,615
Bug 9615 template pref page: should give warning if there are 2 {cursor} vars in a template
like in summary: template pref page should give warning if there are 2 {cursor} vars in a template
resolved fixed
726e202
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T13:31:16Z
2002-02-13T14:20:00Z
extension/org/eclipse/jdt/internal/corext/template/TemplateTranslator.java
20,195
Bug 20195 Can't collapse import container in members view [browsing]
F3 - link Java Browsing to active editor - open Java Browsing perspective - open ClassFileDocumentProvider - expand import container in members view - select first import - try to collapse import container.
resolved fixed
7d17822
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-06T16:38:31Z
2002-06-13T14:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/MembersView.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IMemento; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.OverrideIndicatorLabelDecorator; import org.eclipse.jdt.ui.actions.MemberFilterActionGroup; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; public class MembersView extends JavaBrowsingPart { private MemberFilterActionGroup fMemberFilterActionGroup; public MembersView() { setHasWorkingSetFilter(false); setHasCustomSetFilter(false); } /** * Creates and returns the label provider for this part. * * @return the label provider * @see ILabelProvider */ protected ILabelProvider createLabelProvider() { return new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS, AppearanceAwareLabelProvider.getDecorators(true, new OverrideIndicatorLabelDecorator(null)) ); } /** * Returns the context ID for the Help system * * @return the string used as ID for the Help context */ protected String getHelpContextId() { return IJavaHelpContextIds.MEMBERS_VIEW; } /** * Creates the the viewer of this part. * * @param parent the parent for the viewer */ protected StructuredViewer createViewer(Composite parent) { ProblemTreeViewer viewer= new ProblemTreeViewer(parent, SWT.MULTI); fMemberFilterActionGroup= new MemberFilterActionGroup(viewer, JavaUI.ID_MEMBERS_VIEW); return viewer; } protected void fillToolBar(IToolBarManager tbm) { tbm.add(new LexicalSortingAction(getViewer(), JavaUI.ID_MEMBERS_VIEW)); fMemberFilterActionGroup.contributeToToolBar(tbm); } /** * Answers if the given <code>element</code> is a valid * input for this part. * * @param element the object to test * @return <true> if the given element is a valid input */ protected boolean isValidInput(Object element) { if (element instanceof IType) { IType type= (IType)element; return type.isBinary() || type.getDeclaringType() == null; } return false; } /** * Answers if the given <code>element</code> is a valid * element for this part. * * @param element the object to test * @return <true> if the given element is a valid element */ protected boolean isValidElement(Object element) { if (element instanceof IMember) return super.isValidElement(((IMember)element).getDeclaringType()); else if (element instanceof IImportDeclaration) return isValidElement(((IJavaElement)element).getParent()); else if (element instanceof IImportContainer) { Object input= getViewer().getInput(); if (input instanceof IJavaElement) { ICompilationUnit cu= (ICompilationUnit)((IJavaElement)input).getAncestor(IJavaElement.COMPILATION_UNIT); if (cu != null) { ICompilationUnit importContainerCu= (ICompilationUnit)((IJavaElement)element).getAncestor(IJavaElement.COMPILATION_UNIT); return cu.equals(importContainerCu); } else { IClassFile cf= (IClassFile)((IJavaElement)input).getAncestor(IJavaElement.CLASS_FILE); IClassFile importContainerCf= (IClassFile)((IJavaElement)element).getAncestor(IJavaElement.CLASS_FILE); return cf != null && cf.equals(importContainerCf); } } } return false; } /** * Finds the element which has to be selected in this part. * * @param je the Java element which has the focus */ protected IJavaElement findElementToSelect(IJavaElement je) { if (je == null) return null; switch (je.getElementType()) { case IJavaElement.TYPE: if (((IType)je).getDeclaringType() == null) return null; case IJavaElement.METHOD: case IJavaElement.FIELD: case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: case IJavaElement.IMPORT_DECLARATION: je= getSuitableJavaElement(je); if (je != null) return je; default: return null; } } /** * Finds the closest Java element which can be used as input for * this part and has the given Java element as child * * @param je the Java element for which to search the closest input * @return the closest Java element used as input for this part */ protected IJavaElement findInputForJavaElement(IJavaElement je) { if (je == null || !je.exists()) return null; switch (je.getElementType()) { case IJavaElement.TYPE: IType type= ((IType)je).getDeclaringType(); if (type == null) return je; else return findInputForJavaElement(type); case IJavaElement.COMPILATION_UNIT: return getTypeForCU((ICompilationUnit)je); case IJavaElement.CLASS_FILE: try { return findInputForJavaElement(((IClassFile)je).getType()); } catch (JavaModelException ex) { return null; } case IJavaElement.IMPORT_DECLARATION: return findInputForJavaElement(je.getParent()); case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_CONTAINER: IJavaElement parent= je.getParent(); if (parent instanceof ICompilationUnit) { IType[] types; try { types= ((ICompilationUnit)parent).getAllTypes(); } catch (JavaModelException ex) { return null; } if (types.length > 0) return types[0]; else return null; } else if (parent instanceof IClassFile) return findInputForJavaElement(parent); default: if (je instanceof IMember) return findInputForJavaElement(((IMember)je).getDeclaringType()); } return null; } /* * Implements method from IViewPart. */ public void saveState(IMemento memento) { super.saveState(memento); fMemberFilterActionGroup.saveState(memento); } protected void restoreState(IMemento memento) { super.restoreState(memento); fMemberFilterActionGroup.restoreState(memento); getViewer().getControl().setRedraw(false); getViewer().refresh(); getViewer().getControl().setRedraw(true); } protected void hookViewerListeners() { super.hookViewerListeners(); getViewer().addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { TreeViewer viewer= (TreeViewer)getViewer(); Object element= ((IStructuredSelection)event.getSelection()).getFirstElement(); if (viewer.isExpandable(element)) viewer.setExpandedState(element, !viewer.getExpandedState(element)); } }); } boolean isInputAWorkingCopy() { Object input= getViewer().getInput(); if (input instanceof IJavaElement) { ICompilationUnit cu= (ICompilationUnit)((IJavaElement)input).getAncestor(IJavaElement.COMPILATION_UNIT); if (cu != null) return cu.isWorkingCopy(); } return false; } protected void restoreSelection() { IEditorPart editor= getViewSite().getPage().getActiveEditor(); if (editor != null) setSelectionFromEditor(editor); } }
12,049
Bug 12049 Java Browing is not saving its state.
Open a java browing perspective. Select a project, package and type. Exit the workspace Re-start it. The selected project,package and type are not selected anymore.
resolved fixed
bc523a1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-07T13:42:26Z
2002-03-21T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/JavaBrowsingPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.browsing; import java.util.Collection; import java.util.Comparator; import java.util.Iterator; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.DragSourceEvent; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.util.Assert; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IOpenListener; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.OpenEvent; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.ISelectionListener; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.ui.IWorkingSet; import org.eclipse.ui.IWorkingSetManager; import org.eclipse.ui.PartInitException; import org.eclipse.ui.PlatformUI; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.NewWizardMenu; import org.eclipse.ui.part.ResourceTransfer; import org.eclipse.ui.part.ViewPart; import org.eclipse.search.ui.ISearchResultView; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaElementSorter; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.StandardJavaElementContentProvider; import org.eclipse.jdt.ui.actions.BuildActionGroup; import org.eclipse.jdt.ui.actions.CCPActionGroup; import org.eclipse.jdt.ui.actions.CustomFiltersActionGroup; import org.eclipse.jdt.ui.actions.GenerateActionGroup; import org.eclipse.jdt.ui.actions.ImportActionGroup; import org.eclipse.jdt.ui.actions.JavaSearchActionGroup; import org.eclipse.jdt.ui.actions.OpenEditorActionGroup; import org.eclipse.jdt.ui.actions.OpenViewActionGroup; import org.eclipse.jdt.ui.actions.RefactorActionGroup; import org.eclipse.jdt.ui.actions.ShowActionGroup; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.ResourceTransferDragAdapter; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput; import org.eclipse.jdt.internal.ui.packageview.PackagesMessages; import org.eclipse.jdt.internal.ui.packageview.SelectionTransferDragAdapter; import org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.JavaUIHelp; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTableViewer; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; import org.eclipse.jdt.internal.ui.workingsets.WorkingSetFilterActionGroup; abstract class JavaBrowsingPart extends ViewPart implements IMenuListener, ISelectionListener { private ILabelProvider fLabelProvider; private ILabelProvider fTitleProvider; private StructuredViewer fViewer; private IMemento fMemento; private JavaElementTypeComparator fTypeComparator; // Actions private WorkingSetFilterActionGroup fWorkingSetFilterActionGroup; private boolean fHasWorkingSetFilter= true; private boolean fHasCustomFilter= true; private OpenEditorActionGroup fOpenEditorGroup; private CCPActionGroup fCCPActionGroup; private BuildActionGroup fBuildActionGroup; protected CompositeActionGroup fActionGroups; // Filters private CustomFiltersActionGroup fCustomFiltersActionGroup; private Menu fContextMenu; private IWorkbenchPart fPreviousSelectionProvider; private Object fPreviousSelectedElement; /* * Ensure selection changed events being processed only if * initiated by user interaction with this part. */ private boolean fProcessSelectionEvents= true; private IPartListener fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { setSelectionFromEditor(part); } public void partBroughtToTop(IWorkbenchPart part) { setSelectionFromEditor(part); } public void partClosed(IWorkbenchPart part) { } public void partDeactivated(IWorkbenchPart part) { } public void partOpened(IWorkbenchPart part) { } }; /* * Implements method from IViewPart. */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /* * Implements method from IViewPart. */ public void saveState(IMemento memento) { if (fViewer == null) { // part has not been created if (fMemento != null) //Keep the old state; memento.putMemento(fMemento); return; } if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup.saveState(memento); if (fHasCustomFilter) fCustomFiltersActionGroup.saveState(memento); } protected void restoreState(IMemento memento) { if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup.restoreState(memento); if (fHasCustomFilter) fCustomFiltersActionGroup.restoreState(memento); if (fHasCustomFilter || fHasWorkingSetFilter) { fViewer.getControl().setRedraw(false); fViewer.refresh(); fViewer.getControl().setRedraw(true); } } /** * Creates the search list inner viewer. */ public void createPartControl(Composite parent) { Assert.isTrue(fViewer == null); fTypeComparator= new JavaElementTypeComparator(); // Setup viewer fViewer= createViewer(parent); fLabelProvider= createLabelProvider(); ILabelDecorator decorationMgr= PlatformUI.getWorkbench().getDecoratorManager().getLabelDecorator(); fViewer.setLabelProvider(new DecoratingLabelProvider(fLabelProvider, decorationMgr)); fViewer.setSorter(new JavaElementSorter()); fViewer.setUseHashlookup(true); fTitleProvider= createTitleProvider(); MenuManager menuMgr= new MenuManager("#PopupMenu"); //$NON-NLS-1$ menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(this); fContextMenu= menuMgr.createContextMenu(fViewer.getControl()); fViewer.getControl().setMenu(fContextMenu); getSite().registerContextMenu(menuMgr, fViewer); getSite().setSelectionProvider(fViewer); createActions(); // call before registering for selection changes addKeyListener(); // Custom filter group if (fHasCustomFilter) fCustomFiltersActionGroup= new CustomFiltersActionGroup(this, fViewer); if (fMemento != null) restoreState(fMemento); fMemento= null; getSite().setSelectionProvider(fViewer); // Status line IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager)); hookViewerListeners(); // Filters addFilters(); // Initialize viewer input fViewer.setContentProvider(createContentProvider()); setInitialInput(); initDragAndDrop(); // Initialize selecton setInitialSelection(); // Listen to workbench window changes getViewSite().getWorkbenchWindow().getSelectionService().addPostSelectionListener(this); getViewSite().getPage().addPartListener(fPartListener); fillActionBars(); setHelp(); } private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK; Transfer[] transfers= new Transfer[] { LocalSelectionTransfer.getInstance(), ResourceTransfer.getInstance()}; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fViewer) }; fViewer.addDropSupport(ops | DND.DROP_DEFAULT, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fViewer), new ResourceTransferDragAdapter(fViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners) { public void dragStart(DragSourceEvent event) { IStructuredSelection selection= (IStructuredSelection)getSelectionProvider().getSelection(); for (Iterator iter= selection.iterator(); iter.hasNext(); ) { if (iter.next() instanceof IMember) { setPossibleListeners(new TransferDragSourceListener[] {new SelectionTransferDragAdapter(fViewer)}); break; } } super.dragStart(event); } }); } protected void fillActionBars() { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager toolBar= actionBars.getToolBarManager(); fillToolBar(toolBar); if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup.fillActionBars(getViewSite().getActionBars()); actionBars.updateActionBars(); fActionGroups.fillActionBars(actionBars); if (fHasCustomFilter) fCustomFiltersActionGroup.fillActionBars(actionBars); } //---- IWorkbenchPart ------------------------------------------------------ public void setFocus() { fViewer.getControl().setFocus(); } public void dispose() { if (fViewer != null) { getViewSite().getWorkbenchWindow().getSelectionService().removePostSelectionListener(this); getViewSite().getPage().removePartListener(fPartListener); fViewer= null; } if (fActionGroups != null) fActionGroups.dispose(); super.dispose(); } /** * Adds the KeyListener */ protected void addKeyListener() { fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { handleKeyReleased(event); } }); } protected void handleKeyReleased(KeyEvent event) { if (event.stateMask != 0) return; int key= event.keyCode; IAction action; if (key == SWT.F5) { action= fBuildActionGroup.getRefreshAction(); if (action.isEnabled()) action.run(); } if (event.character == SWT.DEL) { action= fCCPActionGroup.getDeleteAction(); if (action.isEnabled()) action.run(); } } //---- Adding Action to Toolbar ------------------------------------------- protected void fillToolBar(IToolBarManager tbm) { } /** * Called when the context menu is about to open. * Override to add your own context dependent menu contributions. */ public void menuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); IStructuredSelection selection= (IStructuredSelection) fViewer.getSelection(); int size= selection.size(); Object element= selection.getFirstElement(); IJavaElement jElement= element instanceof IJavaElement ? (IJavaElement)element : null; if (size == 0 || (size == 1 && (isNewTarget(jElement) || element instanceof IContainer))) { MenuManager newMenu= new MenuManager(PackagesMessages.getString("PackageExplorer.new")); //$NON-NLS-1$ menu.appendToGroup(IContextMenuConstants.GROUP_NEW, newMenu); new NewWizardMenu(newMenu, getSite().getWorkbenchWindow(), false); } if (size == 1) addOpenNewWindowAction(menu, element); fActionGroups.setContext(new ActionContext(selection)); fActionGroups.fillContextMenu(menu); fActionGroups.setContext(null); } private boolean isNewTarget(IJavaElement element) { if (element == null) return false; int type= element.getElementType(); return type == IJavaElement.JAVA_PROJECT || type == IJavaElement.PACKAGE_FRAGMENT_ROOT || type == IJavaElement.PACKAGE_FRAGMENT || type == IJavaElement.COMPILATION_UNIT || type == IJavaElement.TYPE; } private void addOpenNewWindowAction(IMenuManager menu, Object element) { if (element instanceof IJavaElement) { try { element= ((IJavaElement)element).getCorrespondingResource(); } catch(JavaModelException e) { } } if (!(element instanceof IContainer)) return; menu.appendToGroup( IContextMenuConstants.GROUP_OPEN, new PatchedOpenInNewWindowAction(getSite().getWorkbenchWindow(), (IContainer)element)); } protected void createActions() { fActionGroups= new CompositeActionGroup(new ActionGroup[] { fOpenEditorGroup= new OpenEditorActionGroup(this), new OpenViewActionGroup(this), new ShowActionGroup(this), fCCPActionGroup= new CCPActionGroup(this), new RefactorActionGroup(this), new ImportActionGroup(this), new GenerateActionGroup(this), fBuildActionGroup= new BuildActionGroup(this), new JavaSearchActionGroup(this)}); String viewId= getConfigurationElement().getAttribute("id"); //$NON-NLS-1$ Assert.isNotNull(viewId); IPropertyChangeListener titleUpdater= new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { String property= event.getProperty(); if (IWorkingSetManager.CHANGE_WORKING_SET_NAME_CHANGE.equals(property)) updateTitle(); } }; if (fHasWorkingSetFilter) fWorkingSetFilterActionGroup= new WorkingSetFilterActionGroup(fViewer, viewId, getShell(), titleUpdater); } /** * Returns the shell to use for opening dialogs. * Used in this class, and in the actions. */ private Shell getShell() { return fViewer.getControl().getShell(); } protected final Display getDisplay() { return fViewer.getControl().getDisplay(); } /** * Returns the selection provider. */ ISelectionProvider getSelectionProvider() { return fViewer; } /** * Answers if the given <code>element</code> is a valid * input for this part. * * @param element the object to test * @return <true> if the given element is a valid input */ abstract protected boolean isValidInput(Object element); /** * Answers if the given <code>element</code> is a valid * element for this part. * * @param element the object to test * @return <true> if the given element is a valid element */ protected boolean isValidElement(Object element) { if (element == null) return false; element= getSuitableJavaElement(element); if (element == null) return false; Object input= getViewer().getInput(); if (input == null) return false; if (input instanceof Collection) return ((Collection)input).contains(element); else return input.equals(element); } private boolean isInputResetBy(Object newInput, Object input, IWorkbenchPart part) { if (newInput == null) return part == fPreviousSelectionProvider; if (input instanceof IJavaElement && newInput instanceof IJavaElement) return getTypeComparator().compare(newInput, input) > 0; else return false; } private boolean isInputResetBy(IWorkbenchPart part) { if (!(part instanceof JavaBrowsingPart)) return true; Object thisInput= getViewer().getInput(); Object partInput= ((JavaBrowsingPart)part).getViewer().getInput(); if (thisInput instanceof IJavaElement && partInput instanceof IJavaElement) return getTypeComparator().compare(partInput, thisInput) > 0; else return true; } protected boolean isAncestorOf(Object ancestor, Object element) { if (element instanceof IJavaElement && ancestor instanceof IJavaElement) return !element.equals(ancestor) && internalIsAncestorOf((IJavaElement)ancestor, (IJavaElement)element); return false; } private boolean internalIsAncestorOf(IJavaElement ancestor, IJavaElement element) { if (element != null) return element.equals(ancestor) || internalIsAncestorOf(ancestor, element.getParent()); else return false; } public void selectionChanged(IWorkbenchPart part, ISelection selection) { if (!fProcessSelectionEvents || part == this || part instanceof ISearchResultView || !(selection instanceof IStructuredSelection)) return; // Set selection Object selectedElement= getSingleElementFromSelection(selection); if (selectedElement != null && part.equals(fPreviousSelectionProvider) && selectedElement.equals(fPreviousSelectedElement)) return; fPreviousSelectedElement= selectedElement; Object currentInput= (IJavaElement)getViewer().getInput(); if (selectedElement != null && selectedElement.equals(currentInput)) { IJavaElement elementToSelect= findElementToSelect(getSingleElementFromSelection(selection)); if (elementToSelect != null && getTypeComparator().compare(selectedElement, elementToSelect) < 0) setSelection(new StructuredSelection(elementToSelect), true); fPreviousSelectionProvider= part; return; } // Clear input if needed if (part != fPreviousSelectionProvider && selectedElement != null && !selectedElement.equals(currentInput) && isInputResetBy(selectedElement, currentInput, part)) { if (!isAncestorOf(selectedElement, currentInput)) setInput(null); fPreviousSelectionProvider= part; return; } else if (selection.isEmpty() && !isInputResetBy(part)) { fPreviousSelectionProvider= part; return; } else if (selectedElement == null && part == fPreviousSelectionProvider) { setInput(null); fPreviousSelectionProvider= part; return; } fPreviousSelectionProvider= part; // Adjust input and set selection and if (selectedElement instanceof IJavaElement) adjustInputAndSetSelection((IJavaElement)selectedElement); else setSelection(StructuredSelection.EMPTY, true); } void setHasWorkingSetFilter(boolean state) { fHasWorkingSetFilter= state; } void setHasCustomSetFilter(boolean state) { fHasCustomFilter= state; } protected void setInput(Object input) { setViewerInput(input); updateTitle(); } private void setViewerInput(Object input) { fProcessSelectionEvents= false; fViewer.setInput(input); fProcessSelectionEvents= true; } void updateTitle() { setTitleToolTip(getToolTipText(fViewer.getInput())); } /** * Returns the tool tip text for the given element. */ String getToolTipText(Object element) { String result; if (!(element instanceof IResource)) { result= JavaElementLabels.getTextLabel(element, AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS); } else { IPath path= ((IResource) element).getFullPath(); if (path.isRoot()) { result= getConfigurationElement().getAttribute("name"); //$NON-NLS-1$ } else { result= path.makeRelative().toString(); } } if (fWorkingSetFilterActionGroup == null || fWorkingSetFilterActionGroup.getWorkingSet() == null) return result; IWorkingSet ws= fWorkingSetFilterActionGroup.getWorkingSet(); String wsstr= JavaBrowsingMessages.getFormattedString("JavaBrowsingPart.toolTip", new String[] { ws.getName() }); //$NON-NLS-1$ if (result.length() == 0) return wsstr; return JavaBrowsingMessages.getFormattedString("JavaBrowsingPart.toolTip2", new String[] { result, ws.getName() }); //$NON-NLS-1$ } public String getTitleToolTip() { if (fViewer == null) return super.getTitleToolTip(); return getToolTipText(fViewer.getInput()); } protected final StructuredViewer getViewer() { return fViewer; } protected ILabelProvider createLabelProvider() { return new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS | JavaElementImageProvider.SMALL_ICONS, AppearanceAwareLabelProvider.getDecorators(true, null) ); } protected ILabelProvider createTitleProvider() { return new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_SMALL_ICONS); } protected final ILabelProvider getLabelProvider() { return fLabelProvider; } protected final ILabelProvider getTitleProvider() { return fTitleProvider; } /** * Creates the the viewer of this part. * * @param parent the parent for the viewer */ protected StructuredViewer createViewer(Composite parent) { return new ProblemTableViewer(parent, SWT.MULTI); } protected int getLabelProviderFlags() { return JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_OVERLAY_ICONS | JavaElementLabelProvider.SHOW_SMALL_ICONS | JavaElementLabelProvider.SHOW_VARIABLE | JavaElementLabelProvider.SHOW_PARAMETERS; } /** * Adds filters the viewer of this part. */ protected void addFilters() { // default is to have no filters } /** * Creates the the content provider of this part. */ protected StandardJavaElementContentProvider createContentProvider() { return new JavaBrowsingContentProvider(true, this); // } protected void setInitialInput() { // Use the selection, if any ISelection selection= getSite().getPage().getSelection(); Object input= getSingleElementFromSelection(selection); if (!(input instanceof IJavaElement)) { // Use the input of the page input= getSite().getPage().getInput(); if (!(input instanceof IJavaElement) && input instanceof IAdaptable) input= ((IAdaptable)input).getAdapter(IJavaElement.class); } setInput(findInputForJavaElement((IJavaElement)input)); } protected void setInitialSelection() { // Use the selection, if any Object input; ISelection selection= getSite().getPage().getSelection(); if (selection != null && !selection.isEmpty()) input= getSingleElementFromSelection(selection); else { // Use the input of the page input= getSite().getPage().getInput(); if (!(input instanceof IJavaElement)) { if (input instanceof IAdaptable) input= ((IAdaptable)input).getAdapter(IJavaElement.class); else return; } } if (findElementToSelect((IJavaElement)input) != null) adjustInputAndSetSelection((IJavaElement)input); } final protected void setHelp() { JavaUIHelp.setHelp(fViewer, getHelpContextId()); } /** * Returns the context ID for the Help system * * @return the string used as ID for the Help context */ abstract protected String getHelpContextId(); /** * Adds additional listeners to this view. * This method can be overridden but should * call super. */ protected void hookViewerListeners() { fViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { if (!fProcessSelectionEvents) return; IWorkbenchPage page= getSite().getPage(); if (page == null) return; if (page.equals(JavaPlugin.getActivePage()) && JavaBrowsingPart.this.equals(page.getActivePart())) { linkToEditor((IStructuredSelection)event.getSelection()); } } }); fViewer.addOpenListener(new IOpenListener() { public void open(OpenEvent event) { IAction open= fOpenEditorGroup.getOpenAction(); if (open.isEnabled()) { open.run(); restoreSelection(); } } }); } void restoreSelection() { // Default is to do nothing } void adjustInputAndSetSelection(IJavaElement je) { IJavaElement elementToSelect= getSuitableJavaElement(findElementToSelect(je)); IJavaElement newInput= findInputForJavaElement(je); if (elementToSelect == null && !isValidInput(newInput)) // Clear input setInput(null); else if (elementToSelect == null || getViewer().testFindItem(elementToSelect) == null) { // Adjust input to selection setInput(newInput); // Recompute suitable element since it depends on the viewer's input elementToSelect= getSuitableJavaElement(elementToSelect); } if (elementToSelect != null && elementToSelect.exists()) setSelection(new StructuredSelection(elementToSelect), true); else setSelection(StructuredSelection.EMPTY, true); } /** * Finds the closest Java element which can be used as input for * this part and has the given Java element as child * * @param je the Java element for which to search the closest input * @return the closest Java element used as input for this part */ protected IJavaElement findInputForJavaElement(IJavaElement je) { if (je == null || !je.exists()) return null; if (isValidInput(je)) return je; return findInputForJavaElement(je.getParent()); } final protected IJavaElement findElementToSelect(Object obj) { if (obj instanceof IJavaElement) return findElementToSelect((IJavaElement)obj); return null; } /** * Finds the element which has to be selected in this part. * * @param je the Java element which has the focus */ abstract protected IJavaElement findElementToSelect(IJavaElement je); private Object getSingleElementFromSelection(ISelection selection) { if (!(selection instanceof StructuredSelection) || selection.isEmpty()) return null; Iterator iter= ((StructuredSelection)selection).iterator(); Object firstElement= iter.next(); if (!(firstElement instanceof IJavaElement)) { if (firstElement instanceof IAdaptable) return (IJavaElement)((IAdaptable)firstElement).getAdapter(IJavaElement.class); else return firstElement; } Object currentInput= (IJavaElement)getViewer().getInput(); if (currentInput == null || !currentInput.equals(findInputForJavaElement((IJavaElement)firstElement))) if (iter.hasNext()) // multi selection and view is empty return null; else // ok: single selection and view is empty return firstElement; // be nice to multi selection while (iter.hasNext()) { Object element= iter.next(); if (!(element instanceof IJavaElement)) return null; if (!currentInput.equals(findInputForJavaElement((IJavaElement)element))) return null; } return firstElement; } /** * Gets the typeComparator. * @return Returns a JavaElementTypeComparator */ protected Comparator getTypeComparator() { return fTypeComparator; } /** * Links to editor (if option enabled) */ private void linkToEditor(IStructuredSelection selection) { Object obj= selection.getFirstElement(); if (selection.size() == 1) { IEditorPart part= EditorUtility.isOpenInEditor(obj); if (part != null) { IWorkbenchPage page= getSite().getPage(); page.bringToTop(part); if (obj instanceof IJavaElement) EditorUtility.revealInEditor(part, (IJavaElement) obj); } } } void setSelectionFromEditor(IWorkbenchPart part) { if (part == null) return; IWorkbenchPartSite site= part.getSite(); if (site == null) return; ISelectionProvider provider= site.getSelectionProvider(); if (provider != null) setSelectionFromEditor(part, provider.getSelection()); } private void setSelectionFromEditor(IWorkbenchPart part, ISelection selection) { if (part instanceof IEditorPart && JavaBasePreferencePage.linkBrowsingViewSelectionToEditor()) { IEditorInput ei= ((IEditorPart)part).getEditorInput(); if (selection instanceof ITextSelection) { int offset= ((ITextSelection)selection).getOffset(); IJavaElement element= getElementForInputAt(ei, offset); if (element != null) { adjustInputAndSetSelection(element); return; } } if (ei instanceof IFileEditorInput) { IFile file= ((IFileEditorInput)ei).getFile(); IJavaElement je= (IJavaElement)file.getAdapter(IJavaElement.class); if (je == null) { setSelection(null, false); return; } adjustInputAndSetSelection(je); } else if (ei instanceof IClassFileEditorInput) { IClassFile cf= ((IClassFileEditorInput)ei).getClassFile(); adjustInputAndSetSelection(cf); } return; } } /** * Returns the element contained in the EditorInput */ Object getElementOfInput(IEditorInput input) { if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); else if (input instanceof IFileEditorInput) return ((IFileEditorInput)input).getFile(); else if (input instanceof JarEntryEditorInput) return ((JarEntryEditorInput)input).getStorage(); return null; } private IResource getResourceFor(Object element) { if (element instanceof IJavaElement) { if (element instanceof IWorkingCopy) { IWorkingCopy wc= (IWorkingCopy)element; IJavaElement original= wc.getOriginalElement(); if (original != null) element= original; } try { element= ((IJavaElement)element).getUnderlyingResource(); } catch (JavaModelException e) { return null; } } if (!(element instanceof IResource) || ((IResource)element).isPhantom()) { return null; } return (IResource)element; } private void setSelection(ISelection selection, boolean reveal) { if (selection != null && selection.equals(fViewer.getSelection())) return; fProcessSelectionEvents= false; fViewer.setSelection(selection, reveal); fProcessSelectionEvents= true; } /** * Tries to find the given element in a workingcopy. */ protected static IJavaElement getWorkingCopy(IJavaElement input) { try { if (input instanceof ICompilationUnit) return ((ICompilationUnit)input).findSharedWorkingCopy(JavaUI.getBufferFactory()); else return EditorUtility.getWorkingCopy(input, false); } catch (JavaModelException ex) { } return null; } /** * Returns the original element from which the specified working copy * element was created from. This is a handle only method, the * returned element may or may not exist. * * @param workingCopy the element for which to get the original * @return the original Java element or <code>null</code> if this is not a working copy element */ protected static IJavaElement getOriginal(IJavaElement workingCopy) { ICompilationUnit cu= getCompilationUnit(workingCopy); if (cu != null) return ((IWorkingCopy)cu).getOriginal(workingCopy); return null; } /** * Returns the compilation unit for the given java element. * * @param element the java element whose compilation unit is searched for * @return the compilation unit of the given java element */ protected static ICompilationUnit getCompilationUnit(IJavaElement element) { if (element == null) return null; if (element instanceof IMember) return ((IMember) element).getCompilationUnit(); int type= element.getElementType(); if (IJavaElement.COMPILATION_UNIT == type) return (ICompilationUnit) element; if (IJavaElement.CLASS_FILE == type) return null; return getCompilationUnit(element.getParent()); } /** * Converts the given Java element to one which is suitable for this * view. It takes into account wether the view shows working copies or not. * * @param element the Java element to be converted * @return an element suitable for this view */ IJavaElement getSuitableJavaElement(Object obj) { if (!(obj instanceof IJavaElement)) return null; IJavaElement element= (IJavaElement)obj; if (fTypeComparator.compare(element, IJavaElement.COMPILATION_UNIT) > 0) return element; if (element.getElementType() == IJavaElement.CLASS_FILE) return element; if (isInputAWorkingCopy()) { IJavaElement wc= getWorkingCopy(element); if (wc != null) element= wc; return element; } else { ICompilationUnit cu= getCompilationUnit(element); if (cu != null && ((IWorkingCopy)cu).isWorkingCopy()) return ((IWorkingCopy)cu).getOriginal(element); else return element; } } boolean isInputAWorkingCopy() { return ((StandardJavaElementContentProvider)getViewer().getContentProvider()).getProvideWorkingCopy(); } /** * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementForInputAt(IEditorInput input, int offset) { if (input instanceof IClassFileEditorInput) { try { return ((IClassFileEditorInput)input).getClassFile().getElementAt(offset); } catch (JavaModelException ex) { return null; } } IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(input); if (unit != null) try { unit.reconcile(); return unit.getElementAt(offset); } catch (JavaModelException ex) { } return null; } protected IType getTypeForCU(ICompilationUnit cu) { cu= (ICompilationUnit)getSuitableJavaElement(cu); // Use primary type if possible IType primaryType= cu.findPrimaryType(); if (primaryType != null) return primaryType; // Use first top-level type try { IType[] types= cu.getTypes(); if (types.length > 0) return types[0]; else return null; } catch (JavaModelException ex) { return null; } } void setProcessSelectionEvents(boolean state) { fProcessSelectionEvents= state; } }
13,036
Bug 13036 Search LabelProviders should not override getText()
Three search subclasses of DecoratingLabel Provider override getText and do not use the label provider. They are org.eclipse.search.internal.ui.util.FileLabelProvider org.eclipse.jdt.internal.ui.search.JavaSearchResultLabelProvider org.eclipse.search.internal.ui.SearchResultLabelProvider. As a result if DecoratinglabelProvider wishes to implement ICombinedLabelDecorator it cannot as it cannot rely on its subclasses to use their label providers. These special code should be moved to the label providers for these classes.
verified fixed
169955e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-09T14:57:46Z
2002-04-08T21:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultLabelProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.core.resources.IMarker; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.ui.PlatformUI; import org.eclipse.search.ui.ISearchResultViewEntry; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.internal.ui.viewsupport.AppearanceAwareLabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; public class JavaSearchResultLabelProvider extends DecoratingLabelProvider { public static final int SHOW_ELEMENT_CONTAINER= 1; // default public static final int SHOW_CONTAINER_ELEMENT= 2; public static final int SHOW_PATH= 3; public static final String POTENTIAL_MATCH= SearchMessages.getString("JavaSearchResultLabelProvider.potentialMatch"); //$NON-NLS-1$ // Cache private IMarker fLastMarker; private IJavaElement fLastJavaElement; public JavaSearchResultLabelProvider() { super( new AppearanceAwareLabelProvider( AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS, AppearanceAwareLabelProvider.DEFAULT_IMAGEFLAGS, null) , null); setLabelDecorator(PlatformUI.getWorkbench().getDecoratorManager().getLabelDecorator()); } public String getText(Object o) { fLastMarker= null; IJavaElement javaElement= getJavaElement(o); // sets fLastMarker as side effect boolean isPotentialMatch= fLastMarker != null && fLastMarker.getAttribute(SearchUI.POTENTIAL_MATCH, false); if (javaElement == null) { if (fLastMarker != null) { if (isPotentialMatch) return super.getText(fLastMarker.getResource()) + POTENTIAL_MATCH; else return super.getText(fLastMarker.getResource()); } else return ""; //$NON-NLS-1$ } if (javaElement instanceof IImportDeclaration) javaElement= ((IImportDeclaration)javaElement).getParent().getParent(); if (isPotentialMatch) return super.getText(javaElement) + POTENTIAL_MATCH; else return super.getText(javaElement); } public Image getImage(Object o) { IJavaElement javaElement= getJavaElement(o); if (javaElement == null) return null; return super.getImage(javaElement); } public void setOrder(int orderFlag) { int flags= AppearanceAwareLabelProvider.DEFAULT_TEXTFLAGS; if (orderFlag == SHOW_ELEMENT_CONTAINER) flags |= JavaElementLabels.F_POST_QUALIFIED | JavaElementLabels.M_POST_QUALIFIED | JavaElementLabels.I_POST_QUALIFIED | JavaElementLabels.M_PARAMETER_TYPES | JavaElementLabels.T_POST_QUALIFIED | JavaElementLabels.D_POST_QUALIFIED | JavaElementLabels.CF_POST_QUALIFIED | JavaElementLabels.CU_POST_QUALIFIED; else if (orderFlag == SHOW_CONTAINER_ELEMENT) flags |= JavaElementLabels.F_FULLY_QUALIFIED | JavaElementLabels.M_FULLY_QUALIFIED | JavaElementLabels.I_FULLY_QUALIFIED | JavaElementLabels.M_PARAMETER_TYPES | JavaElementLabels.T_FULLY_QUALIFIED | JavaElementLabels.D_QUALIFIED | JavaElementLabels.CF_QUALIFIED | JavaElementLabels.CU_QUALIFIED; else if (orderFlag == SHOW_PATH) { flags |= JavaElementLabels.F_FULLY_QUALIFIED | JavaElementLabels.M_FULLY_QUALIFIED | JavaElementLabels.I_FULLY_QUALIFIED | JavaElementLabels.M_PARAMETER_TYPES | JavaElementLabels.T_FULLY_QUALIFIED | JavaElementLabels.D_QUALIFIED | JavaElementLabels.CF_QUALIFIED | JavaElementLabels.CU_QUALIFIED; flags |= JavaElementLabels.PREPEND_ROOT_PATH; } ((AppearanceAwareLabelProvider)getLabelProvider()).setTextFlags(flags); } private IJavaElement getJavaElement(Object o) { if (o instanceof IJavaElement) return (IJavaElement)o; if (!(o instanceof ISearchResultViewEntry)) return null; IMarker marker= getMarker(o); if (marker == null || !marker.exists()) return null; return getJavaElement(marker); } protected IMarker getMarker(Object o) { if (!(o instanceof ISearchResultViewEntry)) return null; return ((ISearchResultViewEntry)o).getSelectedMarker(); } private IJavaElement getJavaElement(IMarker marker) { if (fLastMarker != marker) { fLastJavaElement= SearchUtil.getJavaElement(marker); fLastMarker= marker; } return fLastJavaElement; } }
21,173
Bug 21173 Can't create new Project because empty string in "New Project" Preference [2.0.1]
In the Java->New Project tab of Preferences I chose the folders radio button and leave the Source folder name empty, and the output location name to be "output". My intent is to have my source come off the main tree with an initial branch to be output. Like this: myProject (root) -- com -- ibm ... -- output -- com -- ibm ... Then when I try to create a New Java Project, I can enter a project name, but when I click Next nothing happnes, and when I'm forced to click Finish, I get an error message that reads: "An Error occured while creating the Java project. Path must include project and resource name." This bug is reproducible, but after I got to playing with the folder names, it went away when I setup the same conditions that caused it the first time. I just did a fresh extract of Eclipse (I'm using the final 2.0 release from June 28th) and was able to recreate it. So somehow by putting values in those fields and then taking them away, I've been able to make the bug go away. This bug may seem minor, but it's very frustrating and caused me to curse one of the mileston builds when I saw it (I didn't report it at the time because I thought I saw a bug that was to fix it). The correlation between a setting in the new project tab and actually creating a new project is quite small as I might set that tab up in the first week of using eclipse and not create a new project for weeks. Perhaps I'm misunderstanding the intent of those folder names, but I don't think I am. If I am, their intent should be better documented in the panel. If I'm correct as to their intent, then there is some wierd initial setting on the source folder name that is empty which later causes projects to not be created (with a confusing message to boot). This is my first bug submission to eclipse so my apologies if I've filed it on the wrong component.
verified fixed
f3785fc
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-12T10:04:33Z
2002-07-01T21:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/BuildPathsBlock.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.net.URL; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IProjectDescription; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Widget; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.ISharedImages; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.ui.dialogs.ISelectionStatusValidator; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.preferences.NewJavaProjectPreferencePage; import org.eclipse.jdt.internal.ui.util.CoreUtility; import org.eclipse.jdt.internal.ui.util.PixelConverter; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; import org.eclipse.jdt.internal.ui.viewsupport.ImageDisposer; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.CheckedListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; public class BuildPathsBlock { public static interface IRemoveOldBinariesQuery { /** * Do the callback. Returns <code>true</code> if .class files should be removed from the * old output location. */ boolean doQuery(IPath oldOutputLocation) throws InterruptedException; } private IWorkspaceRoot fWorkspaceRoot; private CheckedListDialogField fClassPathList; private StringButtonDialogField fBuildPathDialogField; private StatusInfo fClassPathStatus; private StatusInfo fBuildPathStatus; private IJavaProject fCurrJProject; private IPath fOutputLocationPath; private IStatusChangeListener fContext; private Control fSWTWidget; private boolean fShowSourceFolderPage; private SourceContainerWorkbookPage fSourceContainerPage; private ProjectsWorkbookPage fProjectsPage; private LibrariesWorkbookPage fLibrariesPage; private BuildPathBasePage fCurrPage; public BuildPathsBlock(IWorkspaceRoot root, IStatusChangeListener context, boolean showSourceFolders) { fWorkspaceRoot= root; fContext= context; fShowSourceFolderPage= showSourceFolders; fSourceContainerPage= null; fLibrariesPage= null; fProjectsPage= null; fCurrPage= null; BuildPathAdapter adapter= new BuildPathAdapter(); String[] buttonLabels= new String[] { /* 0 */ NewWizardMessages.getString("BuildPathsBlock.classpath.up.button"), //$NON-NLS-1$ /* 1 */ NewWizardMessages.getString("BuildPathsBlock.classpath.down.button"), //$NON-NLS-1$ /* 2 */ null, /* 3 */ NewWizardMessages.getString("BuildPathsBlock.classpath.checkall.button"), //$NON-NLS-1$ /* 4 */ NewWizardMessages.getString("BuildPathsBlock.classpath.uncheckall.button") //$NON-NLS-1$ }; fClassPathList= new CheckedListDialogField(null, buttonLabels, new CPListLabelProvider()); fClassPathList.setDialogFieldListener(adapter); fClassPathList.setLabelText(NewWizardMessages.getString("BuildPathsBlock.classpath.label")); //$NON-NLS-1$ fClassPathList.setUpButtonIndex(0); fClassPathList.setDownButtonIndex(1); fClassPathList.setCheckAllButtonIndex(3); fClassPathList.setUncheckAllButtonIndex(4); fBuildPathDialogField= new StringButtonDialogField(adapter); fBuildPathDialogField.setButtonLabel(NewWizardMessages.getString("BuildPathsBlock.buildpath.button")); //$NON-NLS-1$ fBuildPathDialogField.setDialogFieldListener(adapter); fBuildPathDialogField.setLabelText(NewWizardMessages.getString("BuildPathsBlock.buildpath.label")); //$NON-NLS-1$ fBuildPathStatus= new StatusInfo(); fClassPathStatus= new StatusInfo(); fCurrJProject= null; } // -------- UI creation --------- public Control createControl(Composite parent) { fSWTWidget= parent; PixelConverter converter= new PixelConverter(parent); Composite composite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginWidth= 0; layout.numColumns= 1; composite.setLayout(layout); TabFolder folder= new TabFolder(composite, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); folder.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { tabChanged(e.item); } }); ImageRegistry imageRegistry= JavaPlugin.getDefault().getImageRegistry(); TabItem item; fSourceContainerPage= new SourceContainerWorkbookPage(fWorkspaceRoot, fClassPathList, fBuildPathDialogField); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.source")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_PACKFRAG_ROOT)); item.setData(fSourceContainerPage); item.setControl(fSourceContainerPage.getControl(folder)); IWorkbench workbench= JavaPlugin.getDefault().getWorkbench(); Image projectImage= workbench.getSharedImages().getImage(ISharedImages.IMG_OBJ_PROJECT); fProjectsPage= new ProjectsWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.projects")); //$NON-NLS-1$ item.setImage(projectImage); item.setData(fProjectsPage); item.setControl(fProjectsPage.getControl(folder)); fLibrariesPage= new LibrariesWorkbookPage(fWorkspaceRoot, fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.libraries")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_LIBRARY)); item.setData(fLibrariesPage); item.setControl(fLibrariesPage.getControl(folder)); // a non shared image Image cpoImage= JavaPluginImages.DESC_TOOL_CLASSPATH_ORDER.createImage(); composite.addDisposeListener(new ImageDisposer(cpoImage)); ClasspathOrderingWorkbookPage ordpage= new ClasspathOrderingWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.order")); //$NON-NLS-1$ item.setImage(cpoImage); item.setData(ordpage); item.setControl(ordpage.getControl(folder)); if (fCurrJProject != null) { fSourceContainerPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); } Composite editorcomp= new Composite(composite, SWT.NONE); DialogField[] editors= new DialogField[] { fBuildPathDialogField }; LayoutUtil.doDefaultLayout(editorcomp, editors, true, 0, 0); int maxFieldWidth= converter.convertWidthInCharsToPixels(40); LayoutUtil.setWidthHint(fBuildPathDialogField.getTextControl(null), maxFieldWidth); LayoutUtil.setHorizontalGrabbing(fBuildPathDialogField.getTextControl(null)); editorcomp.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); if (fShowSourceFolderPage) { folder.setSelection(0); fCurrPage= fSourceContainerPage; } else { folder.setSelection(3); fCurrPage= ordpage; fClassPathList.selectFirstElement(); } WorkbenchHelp.setHelp(composite, IJavaHelpContextIds.BUILD_PATH_BLOCK); return composite; } private Shell getShell() { if (fSWTWidget != null) { return fSWTWidget.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } /** * Initializes the classpath for the given project. Multiple calls to init are allowed, * but all existing settings will be cleared and replace by the given or default paths. * @param project The java project to configure. Does not have to exist. * @param outputLocation The output location to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project- the * output location of the existing project * @param classpathEntries The classpath entries to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project - the * classpath entries of the existing project */ public void init(IJavaProject jproject, IPath outputLocation, IClasspathEntry[] classpathEntries) { fCurrJProject= jproject; boolean projectExists= false; List newClassPath= null; try { IProject project= fCurrJProject.getProject(); projectExists= (project.exists() && project.getFile(".classpath").exists()); //$NON-NLS-1$ if (projectExists) { if (outputLocation == null) { outputLocation= fCurrJProject.getOutputLocation(); } if (classpathEntries == null) { classpathEntries= fCurrJProject.getRawClasspath(); } } if (outputLocation == null) { outputLocation= getDefaultBuildPath(jproject); } if (classpathEntries != null) { newClassPath= getExistingEntries(classpathEntries); } } catch (CoreException e) { JavaPlugin.log(e); } if (newClassPath == null) { newClassPath= getDefaultClassPath(jproject); } List exportedEntries = new ArrayList(); for (int i= 0; i < newClassPath.size(); i++) { CPListElement curr= (CPListElement) newClassPath.get(i); if (curr.isExported() || curr.getEntryKind() == IClasspathEntry.CPE_SOURCE) { exportedEntries.add(curr); } } // inits the dialog field fBuildPathDialogField.setText(outputLocation.makeRelative().toString()); fClassPathList.setElements(newClassPath); fClassPathList.setCheckedElements(exportedEntries); if (fSourceContainerPage != null) { fSourceContainerPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); } doStatusLineUpdate(); } private ArrayList getExistingEntries(IClasspathEntry[] classpathEntries) { ArrayList newClassPath= new ArrayList(); boolean projectExists= fCurrJProject.exists(); for (int i= 0; i < classpathEntries.length; i++) { IClasspathEntry curr= classpathEntries[i]; IPath path= curr.getPath(); // get the resource IResource res= null; boolean isMissing= false; switch (curr.getEntryKind()) { case IClasspathEntry.CPE_CONTAINER: res= null; //try { // isMissing= (JavaCore.getClasspathContainer(path, fCurrJProject) == null); //} catch (JavaModelException e) { isMissing= true; //} isMissing= false; break; case IClasspathEntry.CPE_VARIABLE: IPath resolvedPath= JavaCore.getResolvedVariablePath(path); res= null; isMissing= fWorkspaceRoot.findMember(resolvedPath) == null && !resolvedPath.toFile().isFile(); break; case IClasspathEntry.CPE_LIBRARY: res= fWorkspaceRoot.findMember(path); if (res == null) { if (!ArchiveFileFilter.isArchivePath(path)) { if (fWorkspaceRoot.getWorkspace().validatePath(path.toString(), IResource.FOLDER).isOK()) { res= fWorkspaceRoot.getFolder(path); } } isMissing= !path.toFile().isFile(); // look for external JARs } break; case IClasspathEntry.CPE_SOURCE: res= fWorkspaceRoot.findMember(path); if (res == null) { if (fWorkspaceRoot.getWorkspace().validatePath(path.toString(), IResource.FOLDER).isOK()) { res= fWorkspaceRoot.getFolder(path); } isMissing= true; } break; case IClasspathEntry.CPE_PROJECT: res= fWorkspaceRoot.findMember(path); isMissing= (res == null); break; } boolean isExported= curr.isExported(); CPListElement elem= new CPListElement(fCurrJProject, curr.getEntryKind(), path, res, curr.getSourceAttachmentPath(), curr.getSourceAttachmentRootPath(), isExported); if (projectExists) { elem.setIsMissing(isMissing); } newClassPath.add(elem); } return newClassPath; } // -------- public api -------- /** * Returns the Java project. Can return <code>null<code> if the page has not * been initialized. */ public IJavaProject getJavaProject() { return fCurrJProject; } /** * Returns the current output location. Note that the path returned must not be valid. */ public IPath getOutputLocation() { return new Path(fBuildPathDialogField.getText()).makeAbsolute(); } /** * Returns the current class path (raw). Note that the entries returned must not be valid. */ public IClasspathEntry[] getRawClassPath() { List elements= fClassPathList.getElements(); int nElements= elements.size(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= 0; i < nElements; i++) { CPListElement currElement= (CPListElement) elements.get(i); entries[i]= currElement.getClasspathEntry(); } return entries; } // -------- evaluate default settings -------- private List getDefaultClassPath(IJavaProject jproj) { List list= new ArrayList(); IResource srcFolder; if (NewJavaProjectPreferencePage.useSrcAndBinFolders()) { String sourceFolderName= NewJavaProjectPreferencePage.getSourceFolderName(); srcFolder= jproj.getProject().getFolder(sourceFolderName); } else { srcFolder= jproj.getProject(); } list.add(new CPListElement(jproj, IClasspathEntry.CPE_SOURCE, srcFolder.getFullPath(), srcFolder)); IClasspathEntry[] jreEntries= NewJavaProjectPreferencePage.getDefaultJRELibrary(); list.addAll(getExistingEntries(jreEntries)); return list; } private IPath getDefaultBuildPath(IJavaProject jproj) { if (NewJavaProjectPreferencePage.useSrcAndBinFolders()) { String outputLocationName= NewJavaProjectPreferencePage.getOutputLocationName(); return jproj.getProject().getFullPath().append(outputLocationName); } else { return jproj.getProject().getFullPath(); } } private class BuildPathAdapter implements IStringButtonAdapter, IDialogFieldListener { // -------- IStringButtonAdapter -------- public void changeControlPressed(DialogField field) { buildPathChangeControlPressed(field); } // ---------- IDialogFieldListener -------- public void dialogFieldChanged(DialogField field) { buildPathDialogFieldChanged(field); } } private void buildPathChangeControlPressed(DialogField field) { if (field == fBuildPathDialogField) { IContainer container= chooseContainer(); if (container != null) { fBuildPathDialogField.setText(container.getFullPath().toString()); } } } private void buildPathDialogFieldChanged(DialogField field) { if (field == fClassPathList) { updateClassPathStatus(); updateBuildPathStatus(); } else if (field == fBuildPathDialogField) { updateBuildPathStatus(); } doStatusLineUpdate(); } // -------- verification ------------------------------- private void doStatusLineUpdate() { IStatus res= findMostSevereStatus(); fContext.statusChanged(res); } private IStatus findMostSevereStatus() { return StatusUtil.getMoreSevere(fClassPathStatus, fBuildPathStatus); } /** * Validates the build path. */ private void updateClassPathStatus() { fClassPathStatus.setOK(); List elements= fClassPathList.getElements(); boolean entryMissing= false; IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); boolean isChecked= fClassPathList.isChecked(currElement); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (!isChecked) { fClassPathList.setCheckedWithoutUpdate(currElement, true); } } else { currElement.setExported(isChecked); } entries[i]= currElement.getClasspathEntry(); entryMissing= entryMissing || currElement.isMissing(); } if (entryMissing) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.EntryMissing")); //$NON-NLS-1$ } if (fCurrJProject.hasClasspathCycle(entries)) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.CycleInClassPath")); //$NON-NLS-1$ } } /** * Validates output location & build path. */ private void updateBuildPathStatus() { fOutputLocationPath= null; String text= fBuildPathDialogField.getText(); if ("".equals(text)) { //$NON-NLS-1$ fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.EnterBuildPath")); //$NON-NLS-1$ return; } IPath path= getOutputLocation(); IResource res= fWorkspaceRoot.findMember(path); if (res != null) { // if exists, must be a folder or project if (res.getType() == IResource.FILE) { fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.InvalidBuildPath")); //$NON-NLS-1$ return; } } fOutputLocationPath= path; List elements= fClassPathList.getElements(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; boolean outputFolderAlsoSourceFolder= false; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); entries[i]= currElement.getClasspathEntry(); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE && fOutputLocationPath.equals(currElement.getPath())) { outputFolderAlsoSourceFolder= true; } } IStatus status= JavaConventions.validateClasspath(fCurrJProject, entries, path); if (!status.isOK()) { fBuildPathStatus.setError(status.getMessage()); return; } if (res != null && res.exists() && fCurrJProject.exists()) { try { IPath oldOutputLocation= fCurrJProject.getOutputLocation(); if (!oldOutputLocation.equals(fOutputLocationPath) && !outputFolderAlsoSourceFolder) { if (((IContainer)res).members().length > 0) { fBuildPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.OutputFolderNotEmpty")); //$NON-NLS-1$ return; } } } catch (CoreException e) { JavaPlugin.log(e); } } fBuildPathStatus.setOK(); } // -------- creation ------------------------------- public static void createProject(IProject project, IPath locationPath, IProgressMonitor monitor) throws CoreException { // create the project try { if (!project.exists()) { IProjectDescription desc= project.getWorkspace().newProjectDescription(project.getName()); if (Platform.getLocation().equals(locationPath)) { locationPath= null; } desc.setLocation(locationPath); project.create(desc, monitor); monitor= null; } if (!project.isOpen()) { project.open(monitor); monitor= null; } } finally { if (monitor != null) { monitor.done(); } } } public static void addJavaNature(IProject project, IProgressMonitor monitor) throws CoreException { if (!project.hasNature(JavaCore.NATURE_ID)) { IProjectDescription description = project.getDescription(); String[] prevNatures= description.getNatureIds(); String[] newNatures= new String[prevNatures.length + 1]; System.arraycopy(prevNatures, 0, newNatures, 0, prevNatures.length); newNatures[prevNatures.length]= JavaCore.NATURE_ID; description.setNatureIds(newNatures); project.setDescription(description, monitor); } } public void configureJavaProject(IProgressMonitor monitor) throws CoreException, InterruptedException { if (monitor == null) { monitor= new NullProgressMonitor(); } monitor.beginTask(NewWizardMessages.getString("BuildPathsBlock.operationdesc"), 10); //$NON-NLS-1$ try { Shell shell= null; if (fSWTWidget != null && !fSWTWidget.getShell().isDisposed()) { shell= fSWTWidget.getShell(); } internalConfigureJavaProject(fClassPathList.getElements(), getOutputLocation(), shell, monitor); } finally { monitor.done(); } } /** * Creates the Java project and sets the configured build path and output location. * If the project already exists only build paths are updated. */ private void internalConfigureJavaProject(List classPathEntries, IPath outputLocation, Shell shell, IProgressMonitor monitor) throws CoreException, InterruptedException { // 10 monitor steps to go IRemoveOldBinariesQuery reorgQuery= null; if (shell != null) { reorgQuery= getRemoveOldBinariesQuery(shell); } // remove old .class files if (reorgQuery != null) { IPath oldOutputLocation= fCurrJProject.getOutputLocation(); if (!outputLocation.equals(oldOutputLocation)) { IResource res= fWorkspaceRoot.findMember(oldOutputLocation); if (res instanceof IContainer && hasClassfiles(res)) { if (reorgQuery.doQuery(oldOutputLocation)) { removeOldClassfiles(res); } } } } // create and set the output path first if (!fWorkspaceRoot.exists(outputLocation)) { IFolder folder= fWorkspaceRoot.getFolder(outputLocation); CoreUtility.createFolder(folder, true, true, null); } monitor.worked(2); int nEntries= classPathEntries.size(); IClasspathEntry[] classpath= new IClasspathEntry[nEntries]; // create and set the class path for (int i= 0; i < nEntries; i++) { CPListElement entry= ((CPListElement)classPathEntries.get(i)); IResource res= entry.getResource(); if ((res instanceof IFolder) && !res.exists()) { CoreUtility.createFolder((IFolder)res, true, true, null); } classpath[i]= entry.getClasspathEntry(); // set javadoc location URL javadocLocation= entry.getJavadocLocation(); if (javadocLocation != null) { IPath path= entry.getPath(); if (entry.getEntryKind() == IClasspathEntry.CPE_VARIABLE) { path= JavaCore.getResolvedVariablePath(path); } if (path != null) { JavaDocLocations.setLibraryJavadocLocation(path, javadocLocation); } } } monitor.worked(1); fCurrJProject.setRawClasspath(classpath, outputLocation, new SubProgressMonitor(monitor, 7)); } public static boolean hasClassfiles(IResource resource) throws CoreException { if (resource.isDerived()) { //$NON-NLS-1$ return true; } if (resource instanceof IContainer) { IResource[] members= ((IContainer) resource).members(); for (int i= 0; i < members.length; i++) { if (hasClassfiles(members[i])) { return true; } } } return false; } public static void removeOldClassfiles(IResource resource) throws CoreException { if (resource.isDerived()) { resource.delete(false, null); } else if (resource instanceof IContainer) { IResource[] members= ((IContainer) resource).members(); for (int i= 0; i < members.length; i++) { removeOldClassfiles(members[i]); } } } public static IRemoveOldBinariesQuery getRemoveOldBinariesQuery(final Shell shell) { return new IRemoveOldBinariesQuery() { public boolean doQuery(final IPath oldOutputLocation) throws InterruptedException { final int[] res= new int[] { 1 }; shell.getDisplay().syncExec(new Runnable() { public void run() { String title= NewWizardMessages.getString("BuildPathsBlock.RemoveBinariesDialog.title"); //$NON-NLS-1$ String message= NewWizardMessages.getFormattedString("BuildPathsBlock.RemoveBinariesDialog.description", oldOutputLocation.toString()); //$NON-NLS-1$ MessageDialog dialog= new MessageDialog(shell, title, null, message, MessageDialog.QUESTION, new String[] { IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }, 2); res[0]= dialog.open(); } }); if (res[0] == 0) { return true; } else if (res[0] == 1) { return false; } throw new InterruptedException(); } }; } // ---------- util method ------------ private IContainer chooseContainer() { Class[] acceptedClasses= new Class[] { IProject.class, IFolder.class }; ISelectionStatusValidator validator= new TypedElementSelectionValidator(acceptedClasses, false); IProject[] allProjects= fWorkspaceRoot.getProjects(); ArrayList rejectedElements= new ArrayList(allProjects.length); IProject currProject= fCurrJProject.getProject(); for (int i= 0; i < allProjects.length; i++) { if (!allProjects[i].equals(currProject)) { rejectedElements.add(allProjects[i]); } } ViewerFilter filter= new TypedViewerFilter(acceptedClasses, rejectedElements.toArray()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); IResource initSelection= null; if (fOutputLocationPath != null) { initSelection= fWorkspaceRoot.findMember(fOutputLocationPath); } ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setTitle(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.title")); //$NON-NLS-1$ dialog.setValidator(validator); dialog.setMessage(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(fWorkspaceRoot); dialog.setInitialSelection(initSelection); if (dialog.open() == dialog.OK) { return (IContainer)dialog.getFirstResult(); } return null; } // -------- tab switching ---------- private void tabChanged(Widget widget) { if (widget instanceof TabItem) { BuildPathBasePage newPage= (BuildPathBasePage) ((TabItem) widget).getData(); if (fCurrPage != null) { List selection= fCurrPage.getSelection(); if (!selection.isEmpty()) { newPage.setSelection(selection); } } fCurrPage= newPage; } } }
21,198
Bug 21198 On JavaEditor dont use == in the isActivePart() method but instead use .equals(Object)
The class JavaEditor does an == check inside isActivePart(). This means that if the part is embedded inside another one then the check fails. Rather than this can it use .equals instead and dispatch this to the other part that can specialize accordingly, e.g. instead of the current method protected boolean isActivePart() { IWorkbenchWindow window= getSite().getWorkbenchWindow(); IPartService service= window.getPartService(); return (this == service.getActivePart()); } it could have the last line as return (service.getActivePart().equals(this));
verified fixed
3322182
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-12T10:20:10Z
2002-07-03T09:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/JavaEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.custom.BidiSegmentEvent; import org.eclipse.swt.custom.BidiSegmentListener; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.ITypedRegion; import org.eclipse.jface.text.source.AnnotationRulerColumn; import org.eclipse.jface.text.source.CompositeRuler; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.IVerticalRulerColumn; import org.eclipse.jface.text.source.LineNumberRulerColumn; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.ui.IEditorActionBarContributor; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IPartService; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.editors.text.DefaultEncodingSupport; import org.eclipse.ui.editors.text.IEncodingSupport; import org.eclipse.ui.part.EditorActionBarContributor; import org.eclipse.ui.texteditor.DefaultRangeIndicator; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.StatusTextEditor; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.contentoutline.IContentOutlinePage; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageDeclaration; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.actions.IJavaEditorActionDefinitionIds; import org.eclipse.jdt.ui.actions.JavaSearchActionGroup; import org.eclipse.jdt.ui.actions.OpenEditorActionGroup; import org.eclipse.jdt.ui.actions.OpenViewActionGroup; import org.eclipse.jdt.ui.actions.ShowActionGroup; import org.eclipse.jdt.ui.text.IColorManager; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.CompositeActionGroup; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.text.JavaPartitionScanner; import org.eclipse.jdt.internal.ui.util.JavaUIHelp; /** * Java specific text editor. */ public abstract class JavaEditor extends StatusTextEditor { /** * "Smart" runnable for updating the outline page's selection. */ class OutlinePageSelectionUpdater implements Runnable { /** Has the runnable already been posted? */ private boolean fPosted= false; public OutlinePageSelectionUpdater() { } /* * @see Runnable#run() */ public void run() { synchronizeOutlinePageSelection(); fPosted= false; } /** * Posts this runnable into the event queue. */ public void post() { if (fPosted) return; Shell shell= getSite().getShell(); if (shell != null & !shell.isDisposed()) { fPosted= true; shell.getDisplay().asyncExec(this); } } }; class SelectionChangedListener implements ISelectionChangedListener { public void selectionChanged(SelectionChangedEvent event) { doSelectionChanged(event); } }; /** Preference key for showing the line number ruler */ public final static String LINE_NUMBER_RULER= "lineNumberRuler"; //$NON-NLS-1$ /** Preference key for the foreground color of the line numbers */ public final static String LINE_NUMBER_COLOR= "lineNumberColor"; //$NON-NLS-1$ /** The outline page */ protected JavaOutlinePage fOutlinePage; /** Outliner context menu Id */ protected String fOutlinerContextMenuId; /** The selection changed listener */ protected ISelectionChangedListener fSelectionChangedListener= new SelectionChangedListener(); /** The outline page selection updater */ private OutlinePageSelectionUpdater fUpdater; /** Indicates whether this editor should react on outline page selection changes */ private int fIgnoreOutlinePageSelection; /** The line number ruler column */ private LineNumberRulerColumn fLineNumberRulerColumn; /** This editor's encoding support */ private DefaultEncodingSupport fEncodingSupport; protected CompositeActionGroup fActionGroups; private CompositeActionGroup fContextMenuGroup; /** * Returns the most narrow java element including the given offset * * @param offset the offset inside of the requested element */ abstract protected IJavaElement getElementAt(int offset); /** * Returns the java element of this editor's input corresponding to the given IJavaElement */ abstract protected IJavaElement getCorrespondingElement(IJavaElement element); /** * Sets the input of the editor's outline page. */ abstract protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input); /** * Default constructor. */ public JavaEditor() { super(); JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); setSourceViewerConfiguration(new JavaSourceViewerConfiguration(textTools, this)); setRangeIndicator(new DefaultRangeIndicator()); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); if (JavaEditorPreferencePage.synchronizeOutlineOnCursorMove()) fUpdater= new OutlinePageSelectionUpdater(); } /* * @see AbstractTextEditor#createSourceViewer(Composite, IVerticalRuler, int) */ protected final ISourceViewer createSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { ISourceViewer viewer= createJavaSourceViewer(parent, ruler, styles); StyledText text= viewer.getTextWidget(); text.addBidiSegmentListener(new BidiSegmentListener() { public void lineGetSegments(BidiSegmentEvent event) { event.segments= getBidiLineSegments(event.lineOffset, event.lineText); } }); JavaUIHelp.setHelp(this, text, IJavaHelpContextIds.JAVA_EDITOR); return viewer; } /* * @see AbstractTextEditor#createSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createJavaSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return super.createSourceViewer(parent, ruler, styles); } /* * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.affectsBehavior(event); } /** * Sets the outliner's context menu ID. */ protected void setOutlinerContextMenuId(String menuId) { fOutlinerContextMenuId= menuId; } /** * Returns the standard action group of this editor. */ protected ActionGroup getActionGroup() { return fActionGroups; } /* * @see AbstractTextEditor#editorContextMenuAboutToShow */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); menu.appendToGroup(ITextEditorActionConstants.GROUP_UNDO, new Separator(IContextMenuConstants.GROUP_OPEN)); menu.insertAfter(IContextMenuConstants.GROUP_OPEN, new GroupMarker(IContextMenuConstants.GROUP_SHOW)); ActionContext context= new ActionContext(getSelectionProvider().getSelection()); fContextMenuGroup.setContext(context); fContextMenuGroup.fillContextMenu(menu); fContextMenuGroup.setContext(null); } /** * Creates the outline page used with this editor. */ protected JavaOutlinePage createOutlinePage() { JavaOutlinePage page= new JavaOutlinePage(fOutlinerContextMenuId, this); page.addSelectionChangedListener(fSelectionChangedListener); setOutlinePageInput(page, getEditorInput()); return page; } /** * Informs the editor that its outliner has been closed. */ public void outlinePageClosed() { if (fOutlinePage != null) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage= null; resetHighlightRange(); } } /** * Synchronizes the outliner selection with the actual cursor * position in the editor. */ public void synchronizeOutlinePageSelection() { if (isEditingScriptRunning()) return; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null || fOutlinePage == null) return; StyledText styledText= sourceViewer.getTextWidget(); if (styledText == null) return; int offset= sourceViewer.getVisibleRegion().getOffset(); int caret= offset + styledText.getCaretOffset(); IJavaElement element= getElementAt(caret); if (element instanceof ISourceReference) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage.select((ISourceReference) element); fOutlinePage.addSelectionChangedListener(fSelectionChangedListener); } } /* * Get the desktop's StatusLineManager */ protected IStatusLineManager getStatusLineManager() { IEditorActionBarContributor contributor= getEditorSite().getActionBarContributor(); if (contributor instanceof EditorActionBarContributor) { return ((EditorActionBarContributor) contributor).getActionBars().getStatusLineManager(); } return null; } /* * @see AbstractTextEditor#getAdapter(Class) */ public Object getAdapter(Class required) { if (IContentOutlinePage.class.equals(required)) { if (fOutlinePage == null) fOutlinePage= createOutlinePage(); return fOutlinePage; } if (IEncodingSupport.class.equals(required)) return fEncodingSupport; return super.getAdapter(required); } protected void setSelection(ISourceReference reference, boolean moveCursor) { if (reference != null) { StyledText textWidget= null; ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer != null) textWidget= sourceViewer.getTextWidget(); if (textWidget == null) return; try { ISourceRange range= reference.getSourceRange(); if (range == null) return; int offset= range.getOffset(); int length= range.getLength(); if (offset < 0 || length < 0) return; textWidget.setRedraw(false); setHighlightRange(offset, length, moveCursor); if (!moveCursor) return; offset= -1; length= -1; if (reference instanceof IMember) { range= ((IMember) reference).getNameRange(); if (range != null) { offset= range.getOffset(); length= range.getLength(); } } else if (reference instanceof IImportDeclaration) { String name= ((IImportDeclaration) reference).getElementName(); if (name != null && name.length() > 0) { String content= reference.getSource(); offset= range.getOffset() + content.indexOf(name); length= name.length(); } } else if (reference instanceof IPackageDeclaration) { String name= ((IPackageDeclaration) reference).getElementName(); if (name != null && name.length() > 0) { String content= reference.getSource(); offset= range.getOffset() + content.indexOf(name); length= name.length(); } } if (offset > -1 && length > 0) { sourceViewer.revealRange(offset, length); sourceViewer.setSelectedRange(offset, length); } } catch (JavaModelException x) { } catch (IllegalArgumentException x) { } finally { if (textWidget != null) textWidget.setRedraw(true); } } else if (moveCursor) { resetHighlightRange(); } } public void setSelection(IJavaElement element) { if (element == null || element instanceof ICompilationUnit || element instanceof IClassFile) { /* * If the element is an ICompilationUnit this unit is either the input * of this editor or not being displayed. In both cases, nothing should * happened. (http://dev.eclipse.org/bugs/show_bug.cgi?id=5128) */ return; } IJavaElement corresponding= getCorrespondingElement(element); if (corresponding instanceof ISourceReference) { ISourceReference reference= (ISourceReference) corresponding; // set hightlight range setSelection(reference, true); // set outliner selection if (fOutlinePage != null) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage.select(reference); fOutlinePage.addSelectionChangedListener(fSelectionChangedListener); } } } public synchronized void editingScriptStarted() { ++ fIgnoreOutlinePageSelection; } public synchronized void editingScriptEnded() { -- fIgnoreOutlinePageSelection; } public synchronized boolean isEditingScriptRunning() { return (fIgnoreOutlinePageSelection > 0); } protected void doSelectionChanged(SelectionChangedEvent event) { ISourceReference reference= null; ISelection selection= event.getSelection(); Iterator iter= ((IStructuredSelection) selection).iterator(); while (iter.hasNext()) { Object o= iter.next(); if (o instanceof ISourceReference) { reference= (ISourceReference) o; break; } } if (!isActivePart() && JavaPlugin.getActivePage() != null) JavaPlugin.getActivePage().bringToTop(this); try { editingScriptStarted(); setSelection(reference, !isActivePart()); } finally { editingScriptEnded(); } } /* * @see AbstractTextEditor#adjustHighlightRange(int, int) */ protected void adjustHighlightRange(int offset, int length) { try { IJavaElement element= getElementAt(offset); while (element instanceof ISourceReference) { ISourceRange range= ((ISourceReference) element).getSourceRange(); if (offset < range.getOffset() + range.getLength() && range.getOffset() < offset + length) { setHighlightRange(range.getOffset(), range.getLength(), true); if (fOutlinePage != null) { fOutlinePage.removeSelectionChangedListener(fSelectionChangedListener); fOutlinePage.select((ISourceReference) element); fOutlinePage.addSelectionChangedListener(fSelectionChangedListener); } return; } element= element.getParent(); } } catch (JavaModelException x) { JavaPlugin.getDefault().log(x.getStatus()); } resetHighlightRange(); } protected boolean isActivePart() { IWorkbenchWindow window= getSite().getWorkbenchWindow(); IPartService service= window.getPartService(); return (this == service.getActivePart()); } /* * @see StatusTextEditor#getStatusHeader(IStatus) */ protected String getStatusHeader(IStatus status) { if (fEncodingSupport != null) { String message= fEncodingSupport.getStatusHeader(status); if (message != null) return message; } return super.getStatusHeader(status); } /* * @see StatusTextEditor#getStatusBanner(IStatus) */ protected String getStatusBanner(IStatus status) { if (fEncodingSupport != null) { String message= fEncodingSupport.getStatusBanner(status); if (message != null) return message; } return super.getStatusBanner(status); } /* * @see StatusTextEditor#getStatusMessage(IStatus) */ protected String getStatusMessage(IStatus status) { if (fEncodingSupport != null) { String message= fEncodingSupport.getStatusMessage(status); if (message != null) return message; } return super.getStatusMessage(status); } /* * @see AbstractTextEditor#doSetInput */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); if (fEncodingSupport != null) fEncodingSupport.reset(); setOutlinePageInput(fOutlinePage, input); } /* * @see IWorkbenchPart#dispose() */ public void dispose() { if (fEncodingSupport != null) { fEncodingSupport.dispose(); fEncodingSupport= null; } super.dispose(); } protected void createActions() { super.createActions(); ActionGroup oeg, ovg, sg, jsg; fActionGroups= new CompositeActionGroup( new ActionGroup[] { oeg= new OpenEditorActionGroup(this), ovg= new OpenViewActionGroup(this), sg= new ShowActionGroup(this), jsg= new JavaSearchActionGroup(this)}); fContextMenuGroup= new CompositeActionGroup(new ActionGroup[] {oeg, ovg, sg, jsg}); Action action= new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ShowJavaDoc.", this, ISourceViewer.INFORMATION); //$NON-NLS-1$ action.setActionDefinitionId(IJavaEditorActionDefinitionIds.SHOW_JAVADOC); setAction("ShowJavaDoc", action); //$NON-NLS-1$ fEncodingSupport= new DefaultEncodingSupport(); fEncodingSupport.initialize(this); } private boolean isTextSelectionEmpty() { ISelection selection= getSelectionProvider().getSelection(); if (!(selection instanceof ITextSelection)) return true; return ((ITextSelection)selection).getLength() == 0; } public void updatedTitleImage(Image image) { setTitleImage(image); } /* * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { ISourceViewer sourceViewer= getSourceViewer(); if (sourceViewer == null) return; String property= event.getProperty(); if (JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH.equals(property)) { Object value= event.getNewValue(); if (value instanceof Integer) { sourceViewer.getTextWidget().setTabs(((Integer) value).intValue()); } else if (value instanceof String) { sourceViewer.getTextWidget().setTabs(Integer.parseInt((String) value)); } return; } if (LINE_NUMBER_RULER.equals(property)) { if (isLineNumberRulerVisible()) showLineNumberRuler(); else hideLineNumberRuler(); return; } if (fLineNumberRulerColumn != null && (LINE_NUMBER_COLOR.equals(property) || PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT.equals(property) || PREFERENCE_COLOR_BACKGROUND.equals(property))) { initializeLineNumberRulerColumn(fLineNumberRulerColumn); } } finally { super.handlePreferenceStoreChanged(event); } } /** * Shows the line number ruler column. */ private void showLineNumberRuler() { IVerticalRuler v= getVerticalRuler(); if (v instanceof CompositeRuler) { CompositeRuler c= (CompositeRuler) v; c.addDecorator(1, createLineNumberRulerColumn()); } } /** * Hides the line number ruler column. */ private void hideLineNumberRuler() { IVerticalRuler v= getVerticalRuler(); if (v instanceof CompositeRuler) { CompositeRuler c= (CompositeRuler) v; c.removeDecorator(1); } } /** * Return whether the line number ruler column should be * visible according to the preference store settings. * @return <code>true</code> if the line numbers should be visible */ private boolean isLineNumberRulerVisible() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(LINE_NUMBER_RULER); } /** * Returns a segmentation of the line of the given document appropriate for bidi rendering. * The default implementation returns only the string literals of a java code line as segments. * * @param document the document * @param lineOffset the offset of the line * @return the line's bidi segmentation * @throws BadLocationException in case lineOffset is not valid in document */ public static int[] getBidiLineSegments(IDocument document, int lineOffset) throws BadLocationException { IRegion line= document.getLineInformationOfOffset(lineOffset); ITypedRegion[] linePartitioning= document.computePartitioning(lineOffset, line.getLength()); List segmentation= new ArrayList(); for (int i= 0; i < linePartitioning.length; i++) { if (JavaPartitionScanner.JAVA_STRING.equals(linePartitioning[i].getType())) segmentation.add(linePartitioning[i]); } if (segmentation.size() == 0) return null; int size= segmentation.size(); int[] segments= new int[size * 2 + 1]; int j= 0; for (int i= 0; i < size; i++) { ITypedRegion segment= (ITypedRegion) segmentation.get(i); if (i == 0) segments[j++]= 0; int offset= segment.getOffset() - lineOffset; if (offset > segments[j - 1]) segments[j++]= offset; if (offset + segment.getLength() >= line.getLength()) break; segments[j++]= offset + segment.getLength(); } if (j < segments.length) { int[] result= new int[j]; System.arraycopy(segments, 0, result, 0, j); segments= result; } return segments; } /** * Returns a segmentation of the given line appropriate for bidi rendering. The default * implementation returns only the string literals of a java code line as segments. * * @param lineOffset the offset of the line * @param line the content of the line * @return the line's bidi segmentation */ protected int[] getBidiLineSegments(int lineOffset, String line) { IDocumentProvider provider= getDocumentProvider(); if (provider != null) { IDocument document= provider.getDocument(getEditorInput()); if (document != null) try { return getBidiLineSegments(document, lineOffset); } catch (BadLocationException x) { // ignore } } return null; } /* * @see AbstractTextEditor#handleCursorPositionChanged() */ protected void handleCursorPositionChanged() { super.handleCursorPositionChanged(); if (!isEditingScriptRunning() && fUpdater != null) fUpdater.post(); } /** * Initializes the given line number ruler column from the preference store. * @param rulerColumn the ruler column to be initialized */ protected void initializeLineNumberRulerColumn(LineNumberRulerColumn rulerColumn) { JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); IColorManager manager= textTools.getColorManager(); IPreferenceStore store= getPreferenceStore(); if (store != null) { RGB rgb= null; // foreground color if (store.contains(LINE_NUMBER_COLOR)) { if (store.isDefault(LINE_NUMBER_COLOR)) rgb= PreferenceConverter.getDefaultColor(store, LINE_NUMBER_COLOR); else rgb= PreferenceConverter.getColor(store, LINE_NUMBER_COLOR); } rulerColumn.setForeground(manager.getColor(rgb)); rgb= null; // background color if (!store.getBoolean(PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT)) { if (store.contains(PREFERENCE_COLOR_BACKGROUND)) { if (store.isDefault(PREFERENCE_COLOR_BACKGROUND)) rgb= PreferenceConverter.getDefaultColor(store, PREFERENCE_COLOR_BACKGROUND); else rgb= PreferenceConverter.getColor(store, PREFERENCE_COLOR_BACKGROUND); } } rulerColumn.setBackground(manager.getColor(rgb)); } } /** * Creates a new line number ruler column that is appropriately initialized. */ protected IVerticalRulerColumn createLineNumberRulerColumn() { fLineNumberRulerColumn= new LineNumberRulerColumn(); initializeLineNumberRulerColumn(fLineNumberRulerColumn); return fLineNumberRulerColumn; } /* * @see AbstractTextEditor#createVerticalRuler() */ protected IVerticalRuler createVerticalRuler() { CompositeRuler ruler= new CompositeRuler(); ruler.addDecorator(0, new AnnotationRulerColumn(VERTICAL_RULER_WIDTH)); if (isLineNumberRulerVisible()) ruler.addDecorator(1, createLineNumberRulerColumn()); return ruler; } /* * @see org.eclipse.ui.texteditor.AbstractTextEditor#updatePropertyDependentActions() */ protected void updatePropertyDependentActions() { super.updatePropertyDependentActions(); if (fEncodingSupport != null) fEncodingSupport.reset(); } }
19,702
Bug 19702 Feature: Have comment/uncomment actions in context menu [code manipulation] [editor]
Build F2. The source Comment action is no longer available from the right-click context menu. It is available from the Source pull-down menu, as well as the keyboard shortcut, but I think it is much more efficient and usable to have it in the context menu as in previous builds. The reasoning being that generally when you are commenting out text, you are selecting a block of text with the mouse. It is then logical to bring up the context menu to comment/uncomment the text. It is less efficient to have to go under the Source menu, or to have to switch your hand to the keyboard to enter in the shortcut (as typing "<ctrl>-/" with only your left hand is fairly difficult, you must move your mousing hand to the keyboard). Just a suggestion, as I think the comment/uncomment are some of the most frequently-used actions, so it may be justifiable to have them in the context menu.
verified fixed
f2b70d4
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T09:16:34Z
2002-06-08T04:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/GenerateActionGroup.java
/******************************************************************************* * Copyright (c) 2002 International Business Machines Corp. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Common Public License v0.5 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/cpl-v05.html * * Contributors: * IBM Corporation - initial API and implementation ******************************************************************************/ package org.eclipse.jdt.ui.actions; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.jface.action.IAction; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchSite; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.ui.actions.AddBookmarkAction; import org.eclipse.ui.part.Page; import org.eclipse.ui.texteditor.ConvertLineDelimitersAction; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.internal.ui.actions.ActionMessages; import org.eclipse.jdt.internal.ui.actions.AddTaskAction; import org.eclipse.jdt.internal.ui.javaeditor.AddImportOnSelectionAction; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; /** * Action group that adds the source and generate actions to a part's context * menu and installs handlers for the corresponding global menu actions. * * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @since 2.0 */ public class GenerateActionGroup extends ActionGroup { private boolean fEditorIsOwner; private IWorkbenchSite fSite; private String fGroupName= IContextMenuConstants.GROUP_SOURCE; private List fRegisteredSelectionListeners; private AddImportOnSelectionAction fAddImport; private OverrideMethodsAction fOverrideMethods; private AddGetterSetterAction fAddGetterSetter; private AddUnimplementedConstructorsAction fAddUnimplementedConstructors; private AddJavaDocStubAction fAddJavaDocStub; private AddBookmarkAction fAddBookmark; private AddTaskAction fAddTaskAction; private ExternalizeStringsAction fExternalizeStrings; private FindStringsToExternalizeAction fFindStringsToExternalize; private SurroundWithTryCatchAction fSurroundWithTryCatch; private OrganizeImportsAction fOrganizeImports; private ConvertLineDelimitersAction fConvertToWindows; private ConvertLineDelimitersAction fConvertToUNIX; private ConvertLineDelimitersAction fConvertToMac; /** * Note: This constructor is for internal use only. Clients should not call this constructor. */ public GenerateActionGroup(CompilationUnitEditor editor, String groupName) { fSite= editor.getSite(); fEditorIsOwner= true; fGroupName= groupName; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fAddImport= new AddImportOnSelectionAction(editor); fAddImport.setActionDefinitionId(IJavaEditorActionDefinitionIds.ADD_IMPORT); fAddImport.update(); editor.setAction("AddImport", fAddImport); //$NON-NLS-1$ fOrganizeImports= new OrganizeImportsAction(editor); fOrganizeImports.setActionDefinitionId(IJavaEditorActionDefinitionIds.ORGANIZE_IMPORTS); fOrganizeImports.editorStateChanged(); editor.setAction("OrganizeImports", fOrganizeImports); //$NON-NLS-1$ fOverrideMethods= new OverrideMethodsAction(editor); fOverrideMethods.setActionDefinitionId(IJavaEditorActionDefinitionIds.OVERRIDE_METHODS); fOverrideMethods.editorStateChanged(); editor.setAction("OverrideMethods", fOverrideMethods); //$NON-NLS-1$ fAddGetterSetter= new AddGetterSetterAction(editor); fAddGetterSetter.setActionDefinitionId(IJavaEditorActionDefinitionIds.CREATE_GETTER_SETTER); fAddGetterSetter.editorStateChanged(); editor.setAction("AddGetterSetter", fAddGetterSetter); //$NON-NLS-1$ fAddUnimplementedConstructors= new AddUnimplementedConstructorsAction(editor); fAddUnimplementedConstructors.setActionDefinitionId(IJavaEditorActionDefinitionIds.ADD_UNIMPLEMENTED_CONTRUCTORS); fAddUnimplementedConstructors.editorStateChanged(); editor.setAction("AddUnimplementedConstructors", fAddUnimplementedConstructors); //$NON-NLS-1$ fAddJavaDocStub= new AddJavaDocStubAction(editor); fAddJavaDocStub.editorStateChanged(); fSurroundWithTryCatch= new SurroundWithTryCatchAction(editor); fSurroundWithTryCatch.setActionDefinitionId(IJavaEditorActionDefinitionIds.SURROUND_WITH_TRY_CATCH); fSurroundWithTryCatch.update(selection); provider.addSelectionChangedListener(fSurroundWithTryCatch); editor.setAction("SurroundWithTryCatch", fSurroundWithTryCatch); //$NON-NLS-1$ fExternalizeStrings= new ExternalizeStringsAction(editor); fExternalizeStrings.setActionDefinitionId(IJavaEditorActionDefinitionIds.EXTERNALIZE_STRINGS); fExternalizeStrings.editorStateChanged(); editor.setAction("ExternalizeStrings", fExternalizeStrings); //$NON-NLS-1$ fConvertToWindows= new ConvertLineDelimitersAction(editor, "\r\n"); //$NON-NLS-1$ fConvertToWindows.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_WINDOWS); editor.setAction("ConvertLineDelimitersToWindows", fConvertToWindows); //$NON-NLS-1$ fConvertToUNIX= new ConvertLineDelimitersAction(editor, "\n"); //$NON-NLS-1$ fConvertToUNIX.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_UNIX); editor.setAction("ConvertLineDelimitersToUNIX", fConvertToUNIX); //$NON-NLS-1$ fConvertToMac= new ConvertLineDelimitersAction(editor, "\r"); //$NON-NLS-1$ fConvertToMac.setActionDefinitionId(IJavaEditorActionDefinitionIds.CONVERT_LINE_DELIMITERS_TO_MAC); editor.setAction("ConvertLineDelimitersToMac", fConvertToMac); //$NON-NLS-1$ } /** * Creates a new <code>GenerateActionGroup</code>. The group * requires that the selection provided by the page's selection provider * is of type <code>org.eclipse.jface.viewers.IStructuredSelection</code>. * * @param page the page that owns this action group */ public GenerateActionGroup(Page page) { this(page.getSite()); } /** * Creates a new <code>GenerateActionGroup</code>. The group * requires that the selection provided by the part's selection provider * is of type <code>org.eclipse.jface.viewers.IStructuredSelection</code>. * * @param part the view part that owns this action group */ public GenerateActionGroup(IViewPart part) { this(part.getSite()); } private GenerateActionGroup(IWorkbenchSite site) { fSite= site; ISelectionProvider provider= fSite.getSelectionProvider(); ISelection selection= provider.getSelection(); fOverrideMethods= new OverrideMethodsAction(site); fAddGetterSetter= new AddGetterSetterAction(site); fAddUnimplementedConstructors= new AddUnimplementedConstructorsAction(site); fAddJavaDocStub= new AddJavaDocStubAction(site); fAddBookmark= new AddBookmarkAction(site.getShell()); fAddTaskAction= new AddTaskAction(site); fExternalizeStrings= new ExternalizeStringsAction(site); fFindStringsToExternalize= new FindStringsToExternalizeAction(site); fOrganizeImports= new OrganizeImportsAction(site); fOverrideMethods.update(selection); fAddGetterSetter.update(selection); fAddUnimplementedConstructors.update(selection); fAddJavaDocStub.update(selection); fExternalizeStrings.update(selection); fFindStringsToExternalize.update(selection); fAddTaskAction.update(selection); fOrganizeImports.update(selection); if (selection instanceof IStructuredSelection) { IStructuredSelection ss= (IStructuredSelection)selection; fAddBookmark.selectionChanged(ss); } else { fAddBookmark.setEnabled(false); } registerSelectionListener(provider, fOverrideMethods); registerSelectionListener(provider, fAddGetterSetter); registerSelectionListener(provider, fAddUnimplementedConstructors); registerSelectionListener(provider, fAddJavaDocStub); registerSelectionListener(provider, fAddBookmark); registerSelectionListener(provider, fExternalizeStrings); registerSelectionListener(provider, fFindStringsToExternalize); registerSelectionListener(provider, fOrganizeImports); registerSelectionListener(provider, fAddTaskAction); } private void registerSelectionListener(ISelectionProvider provider, ISelectionChangedListener listener) { if (fRegisteredSelectionListeners == null) fRegisteredSelectionListeners= new ArrayList(12); provider.addSelectionChangedListener(listener); fRegisteredSelectionListeners.add(listener); } /* * The state of the editor owning this action group has changed. * This method does nothing if the group's owner isn't an * editor. */ /** * Note: This method is for internal use only. Clients should not call this method. */ public void editorStateChanged() { Assert.isTrue(fEditorIsOwner); fAddImport.update(); fExternalizeStrings.editorStateChanged(); fOrganizeImports.editorStateChanged(); fOverrideMethods.editorStateChanged(); fAddUnimplementedConstructors.editorStateChanged(); fAddJavaDocStub.editorStateChanged(); fSurroundWithTryCatch.editorStateChanged(); fAddGetterSetter.editorStateChanged(); // http://dev.eclipse.org/bugs/show_bug.cgi?id=17709 fConvertToMac.update(); fConvertToUNIX.update(); fConvertToWindows.update(); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillActionBars(IActionBars actionBar) { super.fillActionBars(actionBar); setGlobalActionHandlers(actionBar); } /* (non-Javadoc) * Method declared in ActionGroup */ public void fillContextMenu(IMenuManager menu) { super.fillContextMenu(menu); if (fEditorIsOwner) { IMenuManager subMenu= createEditorSubMenu(menu); if (subMenu != null) menu.appendToGroup(fGroupName, subMenu); } else { appendToGroup(menu, fOrganizeImports); appendToGroup(menu, fOverrideMethods); appendToGroup(menu, fAddGetterSetter); appendToGroup(menu, fAddUnimplementedConstructors); appendToGroup(menu, fAddJavaDocStub); appendToGroup(menu, fAddBookmark); } } private IMenuManager createEditorSubMenu(IMenuManager mainMenu) { IMenuManager result= new MenuManager(ActionMessages.getString("SourceMenu.label")); //$NON-NLS-1$ int added= 0; added+= addAction(result, fOrganizeImports); added+= addAction(result, fAddImport); result.add(new Separator()); added+= addAction(result, fOverrideMethods); added+= addAction(result, fAddGetterSetter); added+= addAction(result, fAddUnimplementedConstructors); added+= addAction(result, fAddJavaDocStub); added+= addAction(result, fAddBookmark); result.add(new Separator()); added+= addAction(result, fSurroundWithTryCatch); added+= addAction(result, fExternalizeStrings); if (added == 0) result= null; return result; } /* (non-Javadoc) * Method declared in ActionGroup */ public void dispose() { if (fRegisteredSelectionListeners != null) { ISelectionProvider provider= fSite.getSelectionProvider(); for (Iterator iter= fRegisteredSelectionListeners.iterator(); iter.hasNext();) { ISelectionChangedListener listener= (ISelectionChangedListener) iter.next(); provider.removeSelectionChangedListener(listener); } } super.dispose(); } private void setGlobalActionHandlers(IActionBars actionBar) { actionBar.setGlobalActionHandler(JdtActionConstants.ADD_IMPORT, fAddImport); actionBar.setGlobalActionHandler(JdtActionConstants.SURROUND_WITH_TRY_CATCH, fSurroundWithTryCatch); actionBar.setGlobalActionHandler(JdtActionConstants.OVERRIDE_METHODS, fOverrideMethods); actionBar.setGlobalActionHandler(JdtActionConstants.GENERATE_GETTER_SETTER, fAddGetterSetter); actionBar.setGlobalActionHandler(JdtActionConstants.ADD_CONSTRUCTOR_FROM_SUPERCLASS, fAddUnimplementedConstructors); actionBar.setGlobalActionHandler(JdtActionConstants.ADD_JAVA_DOC_COMMENT, fAddJavaDocStub); actionBar.setGlobalActionHandler(JdtActionConstants.EXTERNALIZE_STRINGS, fExternalizeStrings); actionBar.setGlobalActionHandler(JdtActionConstants.FIND_STRINGS_TO_EXTERNALIZE, fFindStringsToExternalize); actionBar.setGlobalActionHandler(JdtActionConstants.ORGANIZE_IMPORTS, fOrganizeImports); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_WINDOWS, fConvertToWindows); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_UNIX, fConvertToUNIX); actionBar.setGlobalActionHandler(JdtActionConstants.CONVERT_LINE_DELIMITERS_TO_MAC, fConvertToMac); if (!fEditorIsOwner) { // editor provides its own implementation of these actions. actionBar.setGlobalActionHandler(IWorkbenchActionConstants.BOOKMARK, fAddBookmark); actionBar.setGlobalActionHandler(IWorkbenchActionConstants.ADD_TASK, fAddTaskAction); } } private int appendToGroup(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) { menu.appendToGroup(fGroupName, action); return 1; } return 0; } private int addAction(IMenuManager menu, IAction action) { if (action != null && action.isEnabled()) { menu.add(action); return 1; } return 0; } }
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/A.java
public class A { static String value; List l; void foo() { value= "d"; } }
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/base_in/TestThisExpression.java
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/base_in/TestThisExpressionInner.java
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/base_out/TestThisExpression.java
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/SefWorkSpace/SefTests/base_out/TestThisExpressionInner.java
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/test
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
cases/org/eclipse/jdt/ui/tests/refactoring/AbstractSelectionTestCase.java
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
org.eclipse.jdt.ui.tests.refactoring/test
20,017
Bug 20017 Self Encapsulate does not work correctly when "this.field = value" is used before refactoring [refactoring]
As an example I start with this class: public class Test { private Object obj; public Test (Object obj) { this.obj = obj; } } Then apply the "Self Encapsulate" refactoring on the obj field, which results: public class Test { private Object obj; public Test (Object obj) { this.getObj() = obj; } private void setObj(Object obj) { this.obj = obj; } private Object getObj() { return obj; } } The "this.getObj() = obj;" in the constructor should be "setObj(obj);" correctly. My Eclipse version was: 20020602
resolved fixed
698c0fe
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-08-13T13:51:56Z
2002-06-12T13:53:20Z
cases/org/eclipse/jdt/ui/tests/refactoring/ExtractInterfaceTests.java