status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,314 |
["CHANGELOG.md", "src/compiler/compile/css/Selector.ts", "test/css/samples/global-with-unused-descendant/_config.js", "test/css/samples/global-with-unused-descendant/expected.css", "test/css/samples/global-with-unused-descendant/input.svelte"]
|
:global(...) .child selector is given svelte- suffix if there is a variable class name in the html
|
If there is an element with a `class={someVariable}` attribute in the markup, `:global(body) .className` child selectors get suffixed, and therefore don't apply to child components.
For example, if you have a parent component that applies a "theme" class to its top-level element, and has child selectors to style matching elements within all its child components depending on the theme, it doesn't work if the theme class is a variable (but does if it's hard-coded as e.g. `<div class="purple">`.
(The variable class is what's relevant - any element with a non-hard-coded class name in the parent component will break it.)
REPL:
- reproduction: https://svelte.dev/repl/0cf466aa625c42ed9dc845d0b46d1905?version=3.17.3
- fixed (by removing variable class name): https://svelte.dev/repl/2f88829ff20846a79e8c395f8ecef741?version=3.17.3
|
https://github.com/sveltejs/svelte/issues/4314
|
https://github.com/sveltejs/svelte/pull/4332
|
70d17950880e56f78c0a919b41ad2a356a9e37ff
|
be9b79f805a3f738986dd6a2fc9f39e07efe46bf
| 2020-01-24T13:49:04Z |
javascript
| 2020-01-27T23:25:24Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,312 |
["CHANGELOG.md", "package-lock.json", "package.json"]
|
Unexpected token (Note that you need plugins to import files that are not JavaScript)
|
**Describe the bug**
When in script section there is **Inline comment** and right after it **Block comment** we can expect error.
**To Reproduce**
Write inline comment then press enter to write code from new line and write block comment
https://svelte.dev/repl/1ad2f11fa4a549bdb67703b5f16a0f4f?version=3.17.3
|
https://github.com/sveltejs/svelte/issues/4312
|
https://github.com/sveltejs/svelte/pull/4327
|
efe8ab9ca569b8cc706cb4c231b39c160ba479e3
|
3eb298fd28ff68f782f632a9029b430745cb0c2b
| 2020-01-23T16:23:11Z |
javascript
| 2020-01-27T19:02:30Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,310 |
["CHANGELOG.md", "src/compiler/compile/render_ssr/handlers/Title.ts", "test/hydration/samples/head-meta-hydrate-duplicate/_before_head.html", "test/server-side-rendering/samples/head-meta-hydrate-duplicate/_expected-head.html"]
|
Hydration removes <title> element
|
**Describe the bug**
When starting from SSR generated HTML with `hydratable: true`, hydration will remove the `<title>` element along with the other appropriate `<head>` elements, but will not add it back.
**Logs**
None.
**To Reproduce**
https://github.com/johnmuhl/svelte-hydrate-head
**Expected behavior**
The `<title>` should remain after hydration.
**Stacktraces**
None.
**Information about your Svelte project:**
Independent of browser.
Svelte 3.17.0+
**Severity**
Pretty bad.
**Additional context**
This was introduced in #4082. The compiled component sets `document.title` first and then later removes elements matching `[data-svelte="svelte-..."]`, and so the title is lost. The simplest way to handle this would probably be to not add the special SSR attribute to the `<title>` element at all, since as of #4250 we don't need to worry about there being more than one of that anyway.
cc @johnmuhl @tanhauhau
|
https://github.com/sveltejs/svelte/issues/4310
|
https://github.com/sveltejs/svelte/pull/4311
|
e959dbcf31fb418b282404daa20c942b2c4264c1
|
455a5cc754cbdf605630aceb8dab6bb1281d8a95
| 2020-01-23T14:29:08Z |
javascript
| 2020-01-23T15:06:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,308 |
["src/runtime/internal/Component.ts", "src/runtime/internal/dom.ts", "test/hydration/samples/head-meta-hydrate-duplicate/_after_head.html"]
|
Better hydration
|
**Is your feature request related to a problem? Please describe.**
Currently hydration is very expensive, it searches for the correct node type clears it and re-adds the attributes and finally unmounts and remounts the DOM node by calling insertBefore/append
This causes iframes to reload.
In the current implementation setting the innerHTML to '' and doing client side render is faster and cleaner
**Describe the solution you'd like**
All DOM should be reused, attributes should not be cleared, and no node should be insertBefore/append unless there is an actual reason.
DOM nodes shouldn't be scanned for the correct nodeName - assume everything is in order on the first miss clear all the rest and start adding new nodes as needed
Text nodes need special treatment as they collapse in SSR
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**How important is this feature to you?**
It is a deal breaker for us - we have quite a few iframes in use and using hydration in it's current form reloads them, it also slows our TTI. So we are stuck with either using only client-side rendering or picking a different solution
**Additional context**
-
|
https://github.com/sveltejs/svelte/issues/4308
|
https://github.com/sveltejs/svelte/pull/6395
|
96b56695729071d081b8ee11be245d1e15f6fa22
|
04bc37de31457dfb331cdea74e2b341c43c6b7c2
| 2020-01-23T10:46:13Z |
javascript
| 2021-06-22T14:34:48Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,301 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/EachBlock.ts", "src/runtime/internal/keyed_each.ts", "test/runtime/samples/keyed-each-dev-unique/_config.js", "test/runtime/samples/keyed-each-dev-unique/main.svelte"]
|
Throw dev mode exception when a keyed each has duplicate keys
|
**Is your feature request related to a problem? Please describe.**
Duplicate keys in a keyed each can cause confusing runtime errors.
**Describe the solution you'd like**
A dev-mode-only check for
**Describe alternatives you've considered**
Making keyed eaches behave better when there are duplicate keys sounds like a lot of work and probably not a good idea anyway.
The only alternative I've really considered (besides doing nothing) is to run this check all the time with keyed eaches, not just in dev mode. But this would be a) more code for people whose apps are already working fine, and b) more work for the browser to do. I think this makes the most sense as a dev mode error (or _possibly_ a dev mode warning).
**How important is this feature to you?**
It'd be nice. It shouldn't be too hard (I have it basically working locally), and it doesn't introduce any extra cost to people in prod mode.
**Additional context**
See #4244.
|
https://github.com/sveltejs/svelte/issues/4301
|
https://github.com/sveltejs/svelte/pull/4303
|
5107ad38b6ce0e388cb2eb99361c5000c4b6de91
|
1a343b165c577429e968cea48607cccabf714b9b
| 2020-01-21T22:16:42Z |
javascript
| 2020-01-22T16:05:31Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,298 |
["CHANGELOG.md", "src/runtime/internal/utils.ts", "src/runtime/store/index.ts", "test/store/index.js"]
|
svelte/store `derived` doesn't handle RxJS observables
|
**Describe the bug**
The `derived` implementation doesn't handle RxJS Observables like other autosubscription stuff does.
**Logs**
```
TypeError: "fn is not a function"
```
**To Reproduce**
```svelte
<script>
import { of } from 'rxjs';
import { derived } from 'svelte/store';
const store1 = of('foo');
const store2 = derived(store1, _ => _);
store2.subscribe()();
</script>
```
**Expected behavior**
Subscribing to and unsubscribing from a store derived from an observable should work. In particular, this means the 'look to see whether there's an `unsubscribe` method to call instead' logic we use elsewhere should also be use in the `derived` implementation.
**Information about your Svelte project:**
- Svelte 3.17.2
- REPL
**Severity**
Probably worth the bytes it would take to fix.
**Additional context**
A question came up in chat about using Observables in Svelte. I don't know whether the gap this issue describes is part of what was wrong, but the question did lead me to look into this.
We're already shipping a few extra bytes to everyone for RxJS support whether they're using it or not. It would be nice to be able to use the same helper in `derived` as we're already using in every Svelte project that uses autosubscription, but that might not be possible because of the two-argument `subscribe()` calls for diamond dependency stuff.
|
https://github.com/sveltejs/svelte/issues/4298
|
https://github.com/sveltejs/svelte/pull/4300
|
e4daaccd06cfe8fe1f4885fcb10942132153b521
|
5107ad38b6ce0e388cb2eb99361c5000c4b6de91
| 2020-01-21T16:46:48Z |
javascript
| 2020-01-22T14:19:32Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,292 |
["CHANGELOG.md", "src/compiler/compile/render_dom/Block.ts", "test/runtime/samples/component-slot-nested-if/Display.svelte", "test/runtime/samples/component-slot-nested-if/Input.svelte", "test/runtime/samples/component-slot-nested-if/_config.js", "test/runtime/samples/component-slot-nested-if/main.svelte"]
|
Potential bug with slot props/if block
|
Nested slot props inside of an #if block are only updating the first time the block is executed.
I have a simple input component that passes the input via a slot prop to another slot.
The prop is only updating the first time through when inside of an #if block.
If I dereference the prop outside of the inner slot it seems to work.
Here is a repl demonstrating the behavior:
https://svelte.dev/repl/50850852403548b5b6381145ba9dc796?version=3.17.1
Using latest svlete, Chrome on latest osx
Not sure if this is a bug or expected behavior, but it took a lot of effort to track down.
|
https://github.com/sveltejs/svelte/issues/4292
|
https://github.com/sveltejs/svelte/pull/4294
|
e93c9913623ba43d8424191fe33f8bebb36e7dea
|
e4daaccd06cfe8fe1f4885fcb10942132153b521
| 2020-01-20T22:34:37Z |
javascript
| 2020-01-22T11:32:24Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,284 |
[".gitattributes"]
|
Change detected language to TypeScript
|
**Is your feature request related to a problem? Please describe.**
Svelte is detected as a JavaScript project by github linguist.
I sugest to change it to TypeScript.
**Describe the solution you'd like**
There are several solutions: https://github.com/github/linguist#overrides
<img width="987" alt="image" src="https://user-images.githubusercontent.com/1494154/72664403-bd14fd80-39fd-11ea-83af-cf591545b535.png">
|
https://github.com/sveltejs/svelte/issues/4284
|
https://github.com/sveltejs/svelte/pull/5878
|
32775a699dd9cbc9884ee04931c3903b832775d5
|
dbd184c38c0f517107316835db948619ff4cf8c0
| 2020-01-18T13:25:03Z |
javascript
| 2021-01-18T19:46:51Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,278 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/Body.ts", "src/compiler/compile/render_dom/wrappers/Element/EventHandler.ts", "src/compiler/compile/render_dom/wrappers/shared/add_event_handlers.ts", "test/runtime/samples/event-handler-modifier-body-once/_config.js", "test/runtime/samples/event-handler-modifier-body-once/main.svelte"]
|
capture, passive modes not working for svelte:body special element.
|
**Describe the bug**
once, capture, passive options are not working for the svelte:body element.
**Observation**
`<svelte:window on:keydown|passive={handleKeydown}>`
generates
`listen(window, "keydown", /*handleKeydown*/ ctx[2], { passive: true }),`
*while*
`<svelte:body on:keydown|passive={handleKeydown}/>`
generates
`document.body.addEventListener("keydown", /*handleKeydown*/ ctx[2]);`
instead of using the listen method.
|
https://github.com/sveltejs/svelte/issues/4278
|
https://github.com/sveltejs/svelte/pull/4279
|
bda254e250e737a1dd7acf6c732d656ce52034a1
|
b39282a9188027903fdb99cdf762b640f11c6cc1
| 2020-01-17T11:21:14Z |
javascript
| 2020-01-17T12:22:40Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,267 |
["CHANGELOG.md", "package-lock.json", "package.json", "test/js/samples/debug-empty/expected.js", "test/js/samples/debug-foo-bar-baz-things/expected.js", "test/js/samples/debug-foo/expected.js", "test/js/samples/dev-warning-missing-data-computed/expected.js"]
|
Await Parenthesis
|
**Describe the bug**
If a component contains a javascript statement "await (expression)", then svelte removes the parenthesis in the generated javascript. However, the execution order is not the same (at least in chrome) :
"await a || b" is executed as "(await a) || b"
The bug is probably a regression between 3.12 and 3.17.1
**To Reproduce**
https://svelte.dev/repl/79a4dad98f3f41d7ae9840d3eb8209ea?version=3.17.1
```
async function myTest() {
let a, b;
let c = await (a || b);
}
```
has been outputed as
```
async function myTest() {
let a, b;
let c = await a || b;
}
```
**Expected behavior**
The parenthesis should not be removed in the generated javascript.
**Information about your Svelte project:**
- Chrome 77
- Svelte 3.17.1
- Windows 7
- Webpack
**Severity**
This is a minor issue because a workaround is easy to write, however the generated javascript is not correct and it's a regression with a previous version of svelte. it was not easy to find the cause of this new bugs in my application.
|
https://github.com/sveltejs/svelte/issues/4267
|
https://github.com/sveltejs/svelte/pull/4283
|
b39282a9188027903fdb99cdf762b640f11c6cc1
|
2f81365e44f585c28295cb3937910eef00a35b0e
| 2020-01-15T15:06:28Z |
javascript
| 2020-01-18T12:10:13Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,263 |
["src/compiler/compile/render_dom/wrappers/IfBlock.ts"]
|
Wrong {#if} {:else} with context_overflow (this.context.length > 31)
|
**Describe the bug**
`if` directive doesn't work as expected if context_overflow (this.context.length > 31)
**To Reproduce**
https://svelte.dev/repl/09bca24d4cc940e38b00afe53ad3da51?version=3.17.0
**Expected behavior**
You should see `true` two times
**Information about your Svelte project:**
- Your browser and the version: (e.x. Chrome 52.1, Firefox 48.0, IE 10)
FF, Chrome
- Your operating system: (e.x. OS X 10, Ubuntu Linux 19.10, Windows XP, etc)
Mac
- Svelte version (Please check you can reproduce the issue with the latest release!)
3.17.0
- Whether your project uses Webpack or Rollup
both reproduce bug
**Severity**
blocking an upgrade to Svelte with bitmasks
**Additional context**
Problem in this check dirty[0] it is falsy
```
function select_block_type(ctx, dirty) {
if (dirty[0] & /*a0*/ 1) show_if = !!(/*arr*/ ctx[1].indexOf(/*a1*/ ctx[2]) && /*a0*/ ctx[0] <= 1);
}
```
May be dirty should be mutidimensional array? Because it is not
|
https://github.com/sveltejs/svelte/issues/4263
|
https://github.com/sveltejs/svelte/pull/4508
|
a8291227ce6ebf959749ae5d6f86b017a140d4af
|
345d5f27ee2ed5fdd3f0bf2bea84c9f0f57b038e
| 2020-01-14T14:15:31Z |
javascript
| 2020-03-05T02:30:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,261 |
[".github/workflows/ci.yml", "src/compiler/compile/utils/__test__.ts"]
|
[Internals] Broken unit test when running test:unit
|
**Describe the bug**
Running the unit tests locally will fail when run (`npm run test:unit`). Specifically [this test](https://github.com/sveltejs/svelte/blob/master/src/compiler/compile/utils/__test__.ts#L13-L15) will fail.
**Logs**
```log
> [email protected] test:unit /Users/fossaloaner1/GitHub/svelte
> mocha --require sucrase/register --recursive src/**/__test__.ts
get_name_from_filename
✓ uses the basename
✓ uses the directory name, if basename is index
1) handles unusual filenames
2 passing (5ms)
1 failing
1) get_name_from_filename
handles unusual filenames:
AssertionError [ERR_ASSERTION]: 'U5B_partsu5D' == 'Parts'
+ expected - actual
-U5B_partsu5D
+Parts
at Context.<anonymous> (src/compiler/compile/utils/__test__.ts:14:10)
at processImmediate (internal/timers.js:439:21)
```
**To Reproduce**
Do this:
```
git clone [email protected]:sveltejs/svelte.git
cd svelte/
npm install
npm run test:unit
```
**Expected behavior**
The test should pass, or be removed. We should also investigate when this broke.
**Information about your Svelte project:**
Cloned this project, at commit 3d9655a2a186d18c366149d218cf67c75b722433.
**Severity**
These tests don't seem to get run anywhere (aside from locally as developers), so I'd rate this as pretty low priority. I already have a fix on the way 👍
**Additional context**
Noticed this while I was working on #3311 and I just wanted to document this here so I have something to attach a PR to.
I was also curious why these unit tests aren't run anywhere. 🤔
|
https://github.com/sveltejs/svelte/issues/4261
|
https://github.com/sveltejs/svelte/pull/4262
|
9cdf0da160d906948a4b4bbaebaf856751906177
|
bf006a43e5fd2339adb6cfca1a322fdedcbf48da
| 2020-01-14T04:28:28Z |
javascript
| 2020-01-24T01:51:29Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,259 |
["src/runtime/internal/scheduler.ts", "test/runtime/samples/onmount-get-current-component/_config.js", "test/runtime/samples/onmount-get-current-component/main.svelte"]
|
Current component should (probably?) not be available inside onMount
|
**Describe the bug**
Things that internally use `get_current_component()` should probably fail when they are called from an `onMount` callback.
**Logs**
None.
**To Reproduce**
```svelte
<script>
import { getContext, onMount } from 'svelte';
import { get_current_component } from 'svelte/internal';
onMount(() => {
console.log(get_current_component());
});
</script>
```
**Expected behavior**
I'd expect this to crash, but it doesn't. There _is_ an exception if you use `setTimeout` instead of `onMount`.
**Stacktraces**
n/a
**Information about your Svelte project:**
- Svelte 3.17.0
**Severity**
I'm not sure. I'm not actually positive this _is_ a bug, but it feels like it. I don't think we want people to be able to call other lifecycle hooks or access the context within `onMount`.
**Additional context**
Came up in chat by way of a question about calling `setContext` in a component and then calling `getContext` during that component's `onMount` callback. It feels like this shouldn't actually be allowed.
|
https://github.com/sveltejs/svelte/issues/4259
|
https://github.com/sveltejs/svelte/pull/4909
|
ae971f80ae11659c8885748a5aeaac82eb5ec17b
|
211fc92e69b7eb02b2e7f0d67e6569c8fcbfcb52
| 2020-01-14T02:36:47Z |
javascript
| 2020-09-10T19:39:45Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,256 |
["site/content/docs/03-run-time.md", "site/content/tutorial/09-motion/02-spring/text.md"]
|
Specify/explain access to store better
|
During the reading tutorial, I got confused with store access (usage of $) - confusion was due to this chapter https://svelte.dev/tutorial/spring
On line 30 there is usage of **$**
`<circle cx={$coords.x} cy={$coords.y} r={$size}/>`
Problem is that all over the coords are accessed without **$** (like line 15)
`<h3>stiffness ({coords.stiffness})</h3>`
After discussion on discord
it was explained that stiffness" and "damping" are actual attributes on the store "spring"
I'd like to see some link to a clean explanation or note about this difference in meaning.
I'd say it may slow down adoption and rise learning curve due to unclear meaning for newbies.
|
https://github.com/sveltejs/svelte/issues/4256
|
https://github.com/sveltejs/svelte/pull/7463
|
9e8592ef2cd8e3feaadeff58c10a237234a43e26
|
d554cdbb25678cdb7ea247469d2e009323dd037b
| 2020-01-12T18:32:19Z |
javascript
| 2022-04-20T01:29:34Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,242 |
["CHANGELOG.md", "src/compiler/compile/css/Selector.ts", "test/css/samples/attribute-selector-word-arbitrary-whitespace/expected.css", "test/css/samples/attribute-selector-word-arbitrary-whitespace/input.svelte"]
|
Multiline class attribute value breaks svelte
|
**Describe the bug**
At my team we spread classes into multiple lines when there are more than two classes to make it more readable. This breaks svelte.
```html
<div
class="
foo
"
>
</div>
<style>
.foo {
background: red;
}
</style>
```
**Logs**
```
ERROR in ./src/_components/Foo.svelte
Module Error (from ./node_modules/eslint-loader/dist/cjs.js):
[...]/_components/Foo.svelte
9:3 warning Unused CSS selector css-unused-selector
```
**To Reproduce**
To reproduce just spread the classes named in the value of the class attribute into multiple lines, like in this REPL https://svelte.dev/repl/b85c17a37a0547f58f1bd221ae4bd8bc?version=3.16.7
```html
<div
class="
foo
"
>
</div>
<style>
.foo {
background: red;
}
</style>
```
**Expected behavior**
Components are working as classes weren't written in multiple lines.
|
https://github.com/sveltejs/svelte/issues/4242
|
https://github.com/sveltejs/svelte/pull/4286
|
2f81365e44f585c28295cb3937910eef00a35b0e
|
e4460e38ba58d5209514f0fa93dc61b6bb1ebb54
| 2020-01-10T08:03:10Z |
javascript
| 2020-01-19T18:36:22Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,240 |
["src/runtime/internal/ssr.ts", "test/server-side-rendering/samples/spread-attributes-white-space/_expected.html", "test/server-side-rendering/samples/spread-attributes-white-space/main.svelte"]
|
White space escape characters are written into HTML when spread is used with SSR
|
**Describe the bug**
When new lines and tabs are used in attributes, then run through SSR, they end up written into the HTML, eg. `<div class="\none\ntwo\n"></div>`. This breaks the class name and can cause a FOUC with Sapper, and would completely break rendering of HTML-only static-generated pages.
**Logs**
N/A
**To Reproduce**
REPL: https://svelte.dev/repl/80b8863b778c4b608537a98fb811de43?version=3.16.7
If you download the REPL, change to `generate:'ssr'` and then `console.log(App.render())`, you get
```html
<div class="
white
space
">A</div>
<div class="\n\twhite\n\tspace\n">B</div>
<div class="white\nspace">C</div>
```
**Expected behavior**
I would expect the white space to be rendered into the HTML as white space characters, like the first `<div>` above.
**Stacktraces**
N/A
**Information about your Svelte project:**
- Your browser and the version: (e.x. Chrome 52.1, Firefox 48.0, IE 10)
N/A
- Your operating system: (e.x. OS X 10, Ubuntu Linux 19.10, Windows XP, etc)
Arch Linux
- Svelte version (Please check you can reproduce the issue with the latest release!)
3.16.7
- Whether your project uses Webpack or Rollup
Rollup
**Severity**
HTML-only web pages would be severely broken by this bug, and it may not be obvious during development. Sapper sites will have a FOUC.
**Additional context**
I came across this bug by running into a bug causing a FOUC when I was using Svelte Material UI:
[https://github.com/hperrin/svelte-material-ui/issues/66](https://github.com/hperrin/svelte-material-ui/issues/66)
|
https://github.com/sveltejs/svelte/issues/4240
|
https://github.com/sveltejs/svelte/pull/4247
|
ef56a70acbe484bf1be9787ae63ae5102ee275ea
|
e3d66869df5b75b81da6183c5d68cde53b2439aa
| 2020-01-10T02:14:41Z |
javascript
| 2020-01-13T16:24:34Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,233 |
["src/runtime/internal/dom.ts", "test/runtime-puppeteer/samples/binding-width-height-initialize/_config.js", "test/runtime-puppeteer/samples/binding-width-height-initialize/main.svelte"]
|
bind:offsetHeight doesn't update in certain cases
|
**Describe the bug**
In Chrome, using `bind:offsetHeight` on a component that immediately changes size does not trigger a change in the `offsetHeight` variable:
https://codesandbox.io/s/upbeat-hill-ilkqt?fontsize=14&hidenavigation=1&module=%2FApp.svelte&theme=dark
This does not seem to happen in Firefox or Safari, but it does happen in Chrome.
**To Reproduce**
https://codesandbox.io/s/upbeat-hill-ilkqt?fontsize=14&hidenavigation=1&module=%2FApp.svelte&theme=dark
**Expected behavior**
`offsetHeight` should be something close to `800` (in the example above)
**Notes**
Is there a reason Svelte doesn't attempt to use a ResizeObserver for resize detection?
|
https://github.com/sveltejs/svelte/issues/4233
|
https://github.com/sveltejs/svelte/pull/8096
|
709264a94cbd29093349ac86e3edd0acc6af46b0
|
e5b0b6235dbc3483a1d1feb3fe8abf12f13bebd8
| 2020-01-09T00:48:39Z |
javascript
| 2023-02-23T11:03:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,212 |
["CHANGELOG.md", "src/compiler/compile/Component.ts", "test/runtime/samples/reactive-values-no-implicit-member-expression/_config.js", "test/runtime/samples/reactive-values-no-implicit-member-expression/main.svelte"]
|
Assigning to a member expression in a reactive statement shouldn't auto-declare the variable
|
**Describe the bug**
A reactive assignment that looks like `$: document.title = whatever;` doesn't work, because the compiler (unhelpfully, in this case) auto-declares `document` for us, and - since that is now undefined - the assignment `document.title = whatever;` is a runtime error.
**Logs**
`TypeError: document is undefined`
**To Reproduce**
```svelte
<script>
$: document.title = 'foo';
</script>
```
**Expected behavior**
This should simply assign to the global `document` and not attempt to automatically declare it
**Stacktraces**
-
**Information about your Svelte project:**
Svelte 3.16.7 - independent of browser or bundler.
**Severity**
Moderate, probably. We do specifically mention this syntax in the docs, and it doesn't work.
**Additional context**
I believe this will simply be a matter of adjusting the logic [here](https://github.com/sveltejs/svelte/blob/5486d67adf2d48820e94a1812028dba9392975b7/src/compiler/compile/Component.ts#L600
) for when we bail out and decide we don't need to auto-declare the variable.
|
https://github.com/sveltejs/svelte/issues/4212
|
https://github.com/sveltejs/svelte/pull/4213
|
fe750d2606aa6203d394322f5d86c9da552be50e
|
741444d07e1e9bb51a1ca0b80daf6177876a9a6e
| 2020-01-05T03:25:17Z |
javascript
| 2020-01-06T12:37:04Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,173 |
["CHANGELOG.md", "src/compiler/compile/nodes/Element.ts", "test/runtime/samples/component-slot-let-g/A.svelte", "test/runtime/samples/component-slot-let-g/_config.js", "test/runtime/samples/component-slot-let-g/main.svelte"]
|
Slot `let` variables not accessible on slotted element root
|
In the following abbreviated components I'd expect to have access to `foo` in the h1 class attribute. But instead it's only accessible _inside_ the slotted element content.
#### Parent
```html
<Child {baz}>
Content
<h1 slot=foobar let:foo class='foobar-{foo.type}'>{foo.title}!</h1>
<!-- Unexpected behaviour is here - - ^ ^- - - This works fine -->
</Child>
```
#### Child
```html
<section class=child>
<slot name=foobar foo={makeFoo(baz)} />
{@html baz.content}
</Child>
```
I'd like the above example to work, with slot `let` variables in scope at the root slotted element
Alternatives to this include:
* Wrapping in a dummy element. (Yuck)
* `bind:this` and manually setting the attributes I want later. (Ulcer inducing)
This is pretty important for slotting tables: if you can't use data from the dataset to add attributes to slotted rows or cells you're missing something pretty darn important...
|
https://github.com/sveltejs/svelte/issues/4173
|
https://github.com/sveltejs/svelte/pull/4266
|
bfff7a9d0e67804e7a0db04ed4fb4b9a6078d0ec
|
8b9b2c266e55c7a3e589a32cecf8f208e430c10a
| 2019-12-27T03:19:07Z |
javascript
| 2020-01-16T14:25:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,172 |
["site/content/docs/02-template-syntax.md"]
|
API - Template Syntax - <slot> - first example unclear - Widget references itself
|
# Steps
Navigate to docs <slot> link: https://svelte.dev/docs#slot
## Expected
Remove self reference of `<Widget />`. Also, the fallback text could use some wordsmithing. Perhaps "no child content" or something to that effect?
```
<!-- Widget.svelte -->
<div>
<slot>
this will be rendered if someone does
</slot>
</div>
```
## Actual
I don't believe widget should be referencing itself.
```
<!-- Widget.svelte -->
<div>
<slot>
this will be rendered if someone does <Widget/>
</slot>
</div>
```
REPL: [https://svelte.dev/repl/417113c7766d4dfd88ed4293b4693fd1?version=3.16.7](https://svelte.dev/repl/417113c7766d4dfd88ed4293b4693fd1?version=3.16.7)
Note: My apologies for no PR as I'm very busy at the moment.
|
https://github.com/sveltejs/svelte/issues/4172
|
https://github.com/sveltejs/svelte/pull/4203
|
7ff0c8319126e6a0f8ea0dab5608454d57fb3034
|
fe750d2606aa6203d394322f5d86c9da552be50e
| 2019-12-26T22:12:06Z |
javascript
| 2020-01-05T21:08:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,170 |
["CHANGELOG.md", "src/runtime/internal/Component.ts", "test/runtime/samples/reactive-values-store-destructured-undefined/_config.js", "test/runtime/samples/reactive-values-store-destructured-undefined/main.svelte"]
|
Destructuring a store object retuns the whole store if the property does not exist
|
**Describe the bug**
When destructuring a store, the whole store object is returned if the property does not exist:
`$: ({shouldBeUndefined} = $store);`
It works if used with an existing property, i.e.:
`$: ({existingProperty, shouldBeUndefined} = $store);`
**To Reproduce**
You can find the REPL [here](https://svelte.dev/repl/52333798bbea4d1b8bb5e249be1cca18?version=3.16.7)
**Information about your Svelte project:**
- Your browser and the version: Firefox 71
- Your operating system: Windows 10
- Svelte version : 3.16.7
- Whether your project uses Webpack or Rollup : Rollup
**Severity**
Annoying
Thanks!
|
https://github.com/sveltejs/svelte/issues/4170
|
https://github.com/sveltejs/svelte/pull/4217
|
741444d07e1e9bb51a1ca0b80daf6177876a9a6e
|
3b0c6a1c5601b9f2e4339845b317044aa0a586d9
| 2019-12-26T08:33:59Z |
javascript
| 2020-01-06T17:52:21Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,137 |
["site/content/docs/03-run-time.md"]
|
Wrong link is set as tweend contents
|
**Describe the bug**
There is link connected with `tweend` in the contents of [spring](https://svelte.dev/docs#spring), but it doesn't work.
It's because of wrong link.
**To Reproduce**
Click the link in [spring](https://svelte.dev/docs#spring).
You will move to top page.
**Expected behavior**
Move to [tweend](https://svelte.dev/docs#tweened).
|
https://github.com/sveltejs/svelte/issues/4137
|
https://github.com/sveltejs/svelte/pull/4138
|
109639c57c51c9b73d5e618bbaf1b1c1b7698e17
|
11002c93fed22357d7e5bf95f37cc86931e467ba
| 2019-12-21T06:21:18Z |
javascript
| 2019-12-21T10:01:35Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,129 |
["src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts", "test/runtime/samples/dynamic-component-dirty/_config.js", "test/runtime/samples/dynamic-component-dirty/main.svelte"]
|
Infinite loop when props is updated inside a invalidation trigger in svelte:component
|
**Describe the bug**
Infinite loop when props is updated inside a invalidation trigger in svelte:component
**Logs**
N/A
**To Reproduce**
https://svelte.dev/repl/97c2b939e3a34786b06f180092be6746?version=3.16.5
**Expected behavior**
Would like params to be passed to the returned svelte component (from find_component).
**Information about your Svelte project:**
* All browsers.
* Svelte v3.16.5
**Severity**
Im using the svelte:component to be efficient in my coding, but could probably find a workaround.
|
https://github.com/sveltejs/svelte/issues/4129
|
https://github.com/sveltejs/svelte/pull/4192
|
311193f1d7dd7f04904567660b997f38c7b32e5b
|
fbaf3cfc1249645e7f0cc49fa3caab0a4ed6433e
| 2019-12-18T14:27:56Z |
javascript
| 2023-03-01T16:28:37Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,098 |
["src/runtime/internal/scheduler.ts", "test/runtime/samples/store-invalidation-while-update-1/_config.js", "test/runtime/samples/store-invalidation-while-update-1/main.svelte", "test/runtime/samples/store-invalidation-while-update-2/_config.js", "test/runtime/samples/store-invalidation-while-update-2/main.svelte"]
|
Actions and invalidation during update
|
Every Block's update function was written with the assumption that nothing in it would invalidate any part of the component's context, but this might not be the case when actions are used.
#4095 wasn't the correct solution to #4094. It was heavy-handed in that it removed all of the optimizations we could have when the entire dirty bitmask fits in one number. And it didn't actually fix the bug when the element that needs to be updated was located before the element that had the action attached to it.
Consider the examples (courtesy of @dkondrad and @tanhauhau) https://svelte.dev/repl/1fb88e85446143578289742e81fae65b?version=3.16.4 and https://svelte.dev/repl/5239a903de1b401f92113318dcb344cc?version=3.16.4 - The first one broke in 3.16.0 and then was fixed in 3.16.4 because mutations to the bitmask array are now affecting the rest of the update. The second one is still broken in 3.16.4 (and I think has always been broken) because the data is invalidated after we've already seen whether we should update it.
The obvious way to handle this is to make sure we schedule a new update if anything got invalidated during the update. One way to do that would be to make all calls to actions happen asynchronously, so that their updates happen afterwards. There might be a more elegant way to handle this.
I think we can also reinstate the destructing fairly easily and generate even better code than we were pre-3.16.4 in cases where there is overflow. The argument to the update function could always be an array destructuring. code-red should make it fairly easy to generate a bunch of local variables for these called `#dirty0`, `#dirty1`, etc., and we could just refer to those instead of subscripting the array. This should also let us (continue to) avoid having two cases depending on whether there's an overflow.
|
https://github.com/sveltejs/svelte/issues/4098
|
https://github.com/sveltejs/svelte/pull/4101
|
1ef7601d69677bcec8aa1711bb55f152bb38615d
|
0bb40196db72c7166fa2a6e6715808d3bb2a83e3
| 2019-12-11T23:37:01Z |
javascript
| 2019-12-18T01:04:39Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,086 |
["CHANGELOG.md", "src/compiler/compile/render_dom/Renderer.ts", "test/runtime/samples/module-context-bind/_config.js", "test/runtime/samples/module-context-bind/main.svelte"]
|
Module-level binding in svelte 3.16
|
Hi, after I updated svelte to the version `3.16.0`, the build command doesn't work anymore.
Modules versions:
* `"svelte": "3.16.0"`
* `"rollup-plugin-svelte": "5.1.1",`
Output:
```bash
⟩ yarn run build
yarn run v1.19.1
$ rollup -c
src/main.js → public/bundle.js...
[!] (plugin svelte) TypeError: Cannot read property 'index' of undefined
src/components/Header.svelte
TypeError: Cannot read property 'index' of undefined
at Renderer.invalidate (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/Renderer.ts:169:35)
at bind_this (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/wrappers/shared/bind_this.ts:32:22)
at ElementWrapper.add_bindings (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/wrappers/Element/index.ts:592:29)
at ElementWrapper.render (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/wrappers/Element/index.ts:380:8)
at FragmentWrapper.render (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/wrappers/Fragment.ts:151:18)
at new Renderer (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/Renderer.ts:95:17)
at dom (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/render_dom/index.ts:17:19)
at render_dom (/Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/svelte/src/compiler/compile/index.ts:97:6)
at /Users/jeremiecorpinot/GitHub/memorare/front-app/node_modules/rollup-plugin-svelte/index.js:252:22
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
What's in the file:
`Header.svelte`
```JavaScript
<script context="module">
let domHeader
// ...other variables
export function hideHeader() {
// ...function's body
}
</script>
<script>
// ...some JavaScript code
</script>
<style>
/*...some styles */
</style>
<header>
<!-- some dom -->
</header>
```
To see the full code you can go to my repo [Header.svelte](https://github.com/memorare/memorare.app/blob/master/src/components/Header.svelte)
The same code works with the svelte version `3.15.0`
The bug appears when I require the exported functions in the `script module` with svelte `3.16.0`.
Example:
```JavaScript
// Some other module
import { hideHeader } from 'Header.svelte';
```
|
https://github.com/sveltejs/svelte/issues/4086
|
https://github.com/sveltejs/svelte/pull/4352
|
83d461f53731d566c049a1b071c2b51ee57524b5
|
3cbe38cbf1d69e103a490cdb456aa74ab2cfda40
| 2019-12-10T18:35:20Z |
javascript
| 2020-02-03T17:12:01Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,077 |
["src/compiler/compile/render_dom/Renderer.ts", "test/runtime/samples/bitmask-overflow-3/_config.js", "test/runtime/samples/bitmask-overflow-3/main.svelte"]
|
Application won't compile - "cannot read property 'n' of undefined" since 3.16.1
|
**Describe the bug**
Upgrading an existing app to Svelte 3.16.1 causes client compilation to fail with the error `Cannot read property 'n' of undefined`.
I'm the second person to see this in the discord, it seems. I don't know where the error comes from or what the causes is (but I do see that the variable `n` is used a lot in recent Svelte commits - https://github.com/sveltejs/svelte/commit/bb5cf9ada7706fed9bb86467d2ae78c76f88b9d0).
**Logs**
ant@xeno ~/Projects/beyonk-dashboard master ● npm run dev
> [email protected] dev /home/ant/Projects/beyonk-dashboard
> PORT=1233 NODE_CONFIG_ENV=${NODE_ENV} sapper dev
✗ client
Cannot read property 'n' of undefined
**To Reproduce**
I'm afraid I simply don't know, at present.
**Expected behavior**
The client should compile as normal.
**Information about your Svelte project:**
- Your operating system: Ubuntu 19.04
- Svelte version 3.16.1
- Rollup
**Severity**
Blocker. It's broken, and my app won't start.
**Additional context**
The app was previously using 3.15, and trying 3.16.0 wouldn't start either, due to an issue with `reduce with no initial value`.
|
https://github.com/sveltejs/svelte/issues/4077
|
https://github.com/sveltejs/svelte/pull/4085
|
85c1829093a57877d65abccdf4a335014087a974
|
88201f2fcf997e8ea800856c8dc1bf32cd43eab8
| 2019-12-09T17:04:04Z |
javascript
| 2019-12-10T16:48:54Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,070 |
["src/compiler/compile/Component.ts", "test/validator/samples/missing-component-global/input.svelte", "test/validator/samples/missing-component-global/warnings.json"]
|
Component Not Defined not working for buildin javascript objects
|
**Describe the bug**
```
<String />
```
Compiles and results in a runtime error of `string.$$ is undefined`: [REPL](https://svelte.dev/repl/1ad764d626f54d60b4b03cef168d6b85).
`Math`, `Map`, `Set`, `RexExp`, etc. (resulting in other errors)
Instead of `<Random />` which would result in `'Random' is not defined. Consider adding a <script> block with 'export let Random' to declare a prop (1:0)`
**Expected behavior**
Check if `String` is a defined Svelte Component instead of defined in javascript.
|
https://github.com/sveltejs/svelte/issues/4070
|
https://github.com/sveltejs/svelte/pull/4071
|
2c9d864e33feba60d5f0b47d7b71f098815814a0
|
3433418dceeae56ffef0cd963e4a8d7bb6358525
| 2019-12-08T19:40:49Z |
javascript
| 2019-12-09T14:15:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,061 |
["src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts", "test/runtime/samples/component-slot-let-in-slot/Inner.svelte", "test/runtime/samples/component-slot-let-in-slot/Outer.svelte", "test/runtime/samples/component-slot-let-in-slot/_config.js", "test/runtime/samples/component-slot-let-in-slot/main.svelte"]
|
Slot with props doesn't propergate changes
|
**Describe the bug**
If a slot that passes a value back contains another slot then any changes to the value will not propagate through.
**To Reproduce**
[Here's a repl](https://svelte.dev/repl/14a72260fda84ddcab25aea7c3f4c993?version=3.16.0). *Outer.svelte* renders a slot and passes `text='first'` then updates it to `'second'`. *Inner.svelte* simply renders a slot. It should render `first first` then after a second change to `second second` but it instead changes to `second first` showing that the inner slot is never notified of the change.
**Severity**
At work I'm re-writting a very large application in svelte. I'm running into this bug frequently do to how we handle state. This very much needs to be fixed before we can push to production.
|
https://github.com/sveltejs/svelte/issues/4061
|
https://github.com/sveltejs/svelte/pull/4091
|
f9a9484e3918c299094403ba6f4fe8a88052bede
|
2cd5c2934b03c9ac3e5e984b3f1ccd3ffd657ef9
| 2019-12-07T01:53:23Z |
javascript
| 2019-12-11T16:46:53Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,050 |
["src/compiler/compile/create_module.ts"]
|
Bare Imports fail when using CJS format
|
**Describe the bug**
When using a _bare_ import in a component script (also with script in _module_ context as in thsi example) there are no [specifiers on the node at this line](https://github.com/sveltejs/svelte/blob/master/src/compiler/compile/create_module.ts#L160) which causes this error: `TypeError: Cannot read property 'type' of undefined`
**To Reproduce**
`a.js`:
```js
// any code here - empty is fine too
```
`Component.svelte`:
```html
<script context="module">
import './a';
</script>
```
`compile.js`:
```js
const { readFileSync } = require('fs');
const svelte = require('svelte/compiler');
const source = readFileSync('./Component.svelte', 'utf8');
const result = svelte.compile(source, {
format: 'cjs',
});
console.log(result);
```
**Expected behavior**
Should compile and generate `require('./a.js');` in the example provided above.
**Stacktrace**
```bash
/project-dir/node_modules/svelte/compiler.js:21095
id: node.specifiers[0].type === 'ImportNamespaceSpecifier'
^
TypeError: Cannot read property 'type' of undefined
at /project-dir/node_modules/svelte/compiler.js:21095:41
at Array.map (<anonymous>)
at cjs (/project-dir/node_modules/svelte/compiler.js:21090:36)
at create_module (/project-dir/node_modules/svelte/compiler.js:21002:17)
at Component.generate (/project-dir/node_modules/svelte/compiler.js:24900:14)
at Object.compile (/project-dir/node_modules/svelte/compiler.js:25965:23)
at Object.<anonymous> (/project-dir/compile.js:6:23)
at Module._compile (internal/modules/cjs/loader.js:1121:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1160:10)
at Module.load (internal/modules/cjs/loader.js:976:32)
```
**Information about your Svelte project:**
Not relevant but I'm using Svelte v3.16.0
**Severity**
Blocking - I'm using Jest for testing which requires `cjs` format with `jest-transform-svelte` which forces `cjs` format which breaks on compile when using a _bare_ import.
|
https://github.com/sveltejs/svelte/issues/4050
|
https://github.com/sveltejs/svelte/pull/4051
|
e996ef750d31ada1ef2dfefd4aae06010dbd2ea6
|
aa2b4e72f7f0991cb7ec89c533c9ebd6dfe2e7cf
| 2019-12-04T13:10:18Z |
javascript
| 2019-12-04T18:05:47Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,047 |
["rollup.config.js", "src/runtime/internal/dev.ts"]
|
Expose svelte version in dev mode
|
It would be helpful to be able to determine what version of svelte a given bundle was build with. This would simplify attempting to support both old and new versions of svelte in svelte-devtools. This hasn't been an issue so far but I'm sure it eventually will as new version change the internals more.
I'm not quite sure where this would be exposed though.
|
https://github.com/sveltejs/svelte/issues/4047
|
https://github.com/sveltejs/svelte/pull/4154
|
33aab8708294d247310ac4318d5e51f5442ce32b
|
646c3df3c670e4d31db218aa0927576e1575beac
| 2019-12-03T16:03:34Z |
javascript
| 2020-01-05T11:24:04Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,044 |
["src/compiler/compile/render_dom/wrappers/AwaitBlock.ts", "test/runtime/samples/await-then-if/_config.js", "test/runtime/samples/await-then-if/main.svelte"]
|
{#if} inside {#await} doesn't work
|
**Describe the bug**
Having an `{#if}` inside of an `{#await}` using a resolved object from `{:then}` fails.
**Logs**
`ReferenceError: object is not defined`
**To Reproduce**
https://svelte.dev/repl/a5419c05b3314b83b75ce786562f2c06?version=3.16.0
**Expected behavior**
it should render the if block
**Information about your Svelte project:**
- Firefox 70.0.1
- Manjaro GNU/Linux
- 3.16.0
**Severity**
It is blocking my app from upgrading.
|
https://github.com/sveltejs/svelte/issues/4044
|
https://github.com/sveltejs/svelte/pull/4065
|
3433418dceeae56ffef0cd963e4a8d7bb6358525
|
468938c573311d6eda0edc1eb91f55a48df91ea3
| 2019-12-03T12:36:43Z |
javascript
| 2019-12-09T14:16:37Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,037 |
["src/compiler/compile/render_dom/Renderer.ts", "test/runtime/samples/bitmask-overflow-2/_config.js", "test/runtime/samples/bitmask-overflow-2/main.svelte"]
|
3.16 `Reduce of empty array with no initial value`
|
**Describe the bug**
Using many vars throws under certain conditions the error:
Reduce of empty array with no initial value
**To Reproduce**
https://svelte.dev/repl/ebb874cf3a234db6ae13c314dccd5253?version=3.16.0
This started with 3.16, reverting to 3.15 is ok
|
https://github.com/sveltejs/svelte/issues/4037
|
https://github.com/sveltejs/svelte/pull/4063
|
3e1e6cbd787a9ff434e8df077af48d8af1bdd217
|
bb5cf9ada7706fed9bb86467d2ae78c76f88b9d0
| 2019-12-02T09:35:58Z |
javascript
| 2019-12-09T14:57:01Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,022 |
["src/compiler/compile/render_dom/wrappers/AwaitBlock.ts", "test/runtime/samples/await-then-no-context/main.svelte"]
|
{:then} without name for resolving value will not compile in certain circumstances
|
**Describe the bug**
In `{await}` ... `{:then}` blocks, not specifying a name for the resolving value will cause an error which is hard to trace back to the issue. It only happens when the block contains another block(?).
This did not happen in 3.15.0.
``
(plugin svelte)
Error: Not implemented Empty
``
**To Reproduce**
https://svelte.dev/repl/0eb341643bb4465ca47616f8b1cf2091?version=3.16.0
https://svelte.dev/repl/0eb341643bb4465ca47616f8b1cf2091?version=3.15.0
|
https://github.com/sveltejs/svelte/issues/4022
|
https://github.com/sveltejs/svelte/pull/4025
|
4e51d35dd8abb8f71602c151e428589ce5e98d10
|
185ff4ae041a6fcc1cd1f2be7114a3d1492d022b
| 2019-11-30T12:32:07Z |
javascript
| 2019-12-04T18:05:08Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,021 |
["src/compiler/compile/Component.ts", "test/validator/samples/unreferenced-variables/input.svelte"]
|
warning thrown in 3.16.0 when using export for store
|
**Describe the bug**
An incorrect(?) warning is thrown when exporting a variable that is exclusively used in a "$dereferenced" manner. This warning was not given in 3.15.0.
**To Reproduce**
```
<script>
export let store
</script>
<div class="{$store?'a':'b'}"></div>
```
https://svelte.dev/repl/809da99693de49acb3474159f9006dcc?version=3.15.0
https://svelte.dev/repl/809da99693de49acb3474159f9006dcc?version=3.16.0
|
https://github.com/sveltejs/svelte/issues/4021
|
https://github.com/sveltejs/svelte/pull/4027
|
185ff4ae041a6fcc1cd1f2be7114a3d1492d022b
|
e996ef750d31ada1ef2dfefd4aae06010dbd2ea6
| 2019-11-30T12:11:50Z |
javascript
| 2019-12-04T18:05:29Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,018 |
["src/compiler/compile/render_dom/index.ts", "src/compiler/compile/render_dom/invalidate.ts", "test/js/samples/instrumentation-script-main-block/expected.js", "test/js/samples/instrumentation-script-main-block/input.svelte"]
|
Unnecessary `$$invalidate` calls during component creation
|
There's no need to instrument assignments with calls to `$$invalidate` inside the main `instance()` function body as all variables are initially set to dirty already.
It wouldn't be a huge improvement, but it's unnecessary work nonetheless.
|
https://github.com/sveltejs/svelte/issues/4018
|
https://github.com/sveltejs/svelte/pull/4069
|
88201f2fcf997e8ea800856c8dc1bf32cd43eab8
|
6928284085c297faae008f398e4887c194dd8677
| 2019-11-30T00:14:33Z |
javascript
| 2019-12-10T16:50:07Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 4,012 |
["src/compiler/compile/nodes/Binding.ts", "src/compiler/compile/nodes/shared/TemplateScope.ts", "test/validator/samples/binding-await-catch/errors.json", "test/validator/samples/binding-await-catch/input.svelte", "test/validator/samples/binding-await-then-2/errors.json", "test/validator/samples/binding-await-then-2/input.svelte", "test/validator/samples/binding-await-then/errors.json", "test/validator/samples/binding-await-then/input.svelte"]
|
Two-way binding to expressions involving `{#await}` `then`s should be disallowed by compiler
|
**Describe the bug**
What the title says. See #3912 and #4008 for why this is a problem.
**Logs**
n/a
**To Reproduce**
See #3912 and #4008 for examples of code that we should disallow.
**Expected behavior**
Two-way binding between (inputs or component props) and (the `then` of an `{#await}` or any expression based on that) should throw an error refusing to compile.
**Stacktraces**
n/a
**Severity**
Minor-ish. It's evidently caused some confusion.
**Additional context**
None.
|
https://github.com/sveltejs/svelte/issues/4012
|
https://github.com/sveltejs/svelte/pull/4275
|
1438994bd4f51633ba5c869c26d16be2e8224213
|
527ddea289196f3dc4c8ca5e0d001b9c7e5ce2a0
| 2019-11-28T12:15:02Z |
javascript
| 2020-01-17T03:16:06Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,999 |
["src/compiler/compile/nodes/EachBlock.ts", "test/validator/samples/animation-comment-siblings/errors.json", "test/validator/samples/animation-comment-siblings/input.svelte"]
|
#each with animate: doesn't allow comments
|
**Describe the bug**
The combination of #each and the animate directive doesn't allow comments.
**To Reproduce**
See https://svelte.dev/repl/aa902b5c51fd4e79be8dda8267fe7485?version=3.15.0.
There will be an error message at the bottom.
If the comment is deleted, the error goes away.
**Expected behavior**
Comments should be ignored and not cause an error.
**Severity**
This prevents documenting some code.
|
https://github.com/sveltejs/svelte/issues/3999
|
https://github.com/sveltejs/svelte/pull/7435
|
fc19537995c8d2563345a4570e65ec6f08eb872d
|
d9687da63202633845e60e0538b3e075c5636ff8
| 2019-11-26T19:14:47Z |
javascript
| 2022-04-12T08:48:09Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,992 |
["src/compiler/compile/nodes/Binding.ts", "test/runtime/samples/bindings-global-dependency/_config.js", "test/runtime/samples/bindings-global-dependency/main.svelte"]
|
Regression: cannot bind to Object.values object properties in #each block
|
https://svelte.dev/repl/ed57d9ae519a489887ab88bb53b6906e throws "Cannot set property 'mutated' of undefined" on > 3.12.1. I assume this is the result of the big structured code generation restructuring (props, btw)!
Severity: you can always just bind to `data[key].value` instead of `object.value`, but the error did throw me for a loop.
|
https://github.com/sveltejs/svelte/issues/3992
|
https://github.com/sveltejs/svelte/pull/3996
|
2f4d77115f8e72dcf15302d8aa08b220986b661d
|
59b886fcbf6d028cbb10bf8b25bbe8ec89e0aca6
| 2019-11-25T19:01:08Z |
javascript
| 2019-11-26T14:50:38Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,983 |
["src/compiler/compile/Component.ts", "test/runtime/samples/module-context-export/Foo.svelte", "test/runtime/samples/module-context-export/_config.js", "test/runtime/samples/module-context-export/main.svelte"]
|
Module context export not working if instance variable with same name exists
|
**Describe the bug**
If a variable is exported from a module context and a variable with the same name is declared in a `<script>` element, the export is omitted from the module.
```js
<script context="module">
export const x = 1;
</script>
<script>
const x = 2;
</script>
```
**To reproduce**
Svelte REPL: https://svelte.dev/repl/0935c4be70ff446989a0517c28394e58?version=3.15.0
**Expected behavior**
The compiled module should have two exports: the default component export and the module context export:
```js
export default App;
export { x }; // This line is missing!
```
**Information about your Svelte project**
- Svelte version: 3.15.0
**Severity**
This issue can easily be avoided by giving the variables different names.
|
https://github.com/sveltejs/svelte/issues/3983
|
https://github.com/sveltejs/svelte/pull/3991
|
34bb8119b737731f8640ccd6f342e2c9b868244c
|
0ab5337ca5d6297f09756504c0c427461aea52ae
| 2019-11-24T15:35:52Z |
javascript
| 2019-11-26T14:05:34Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,968 |
["site/package-lock.json", "site/package.json"]
|
Broken polka version
|
**Describe the bug**
Svelte is using polka version `^1.0.0-next.6` which can be crashed via malformed URIs, so I would recommend a quick update.
https://github.com/lukeed/polka/issues/119
**Severity**
Not great, not terrible.
|
https://github.com/sveltejs/svelte/issues/3968
|
https://github.com/sveltejs/svelte/pull/3980
|
cd21acfb3cae574b81f2f417331993374222a9de
|
89585847ae19f12314d61bbeccca5c1b819334ab
| 2019-11-21T10:44:21Z |
javascript
| 2019-11-23T23:01:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,966 |
["test/runtime/samples/each-block-after-let/Child.svelte", "test/runtime/samples/each-block-after-let/_config.js", "test/runtime/samples/each-block-after-let/main.svelte"]
|
Each blocks after slot with let directive captures wrong ctx
|
**Describe the bug**
When an each block follows a slot that uses a let directive that hides a variable of the same name in the parent then the each block incorrectly references the value from inside the slot.
**To Reproduce**
https://svelte.dev/repl/537557d31921471e97632c6780c0ea39?version=3.15.0
The first line `a a` shows that the initial value of the array is `['a']`.
The second line `b` shows that the value of the array inside the slot is `['b']`.
The last line `a b` is unexpected. It shows that the value of the array is still `['a']` yet the each block is referencing the array from the slot, `['b']`.
**Expected behavior**
I would expect either the each block to use the parents value or for the svelte compiler to warn about let directive variable already being defined.
|
https://github.com/sveltejs/svelte/issues/3966
|
https://github.com/sveltejs/svelte/pull/3997
|
d3cefd2bcb4f2d8b632869837b88fe27cd6eed2a
|
afe06059bf3b72667a80306b96cb7c543bca6c20
| 2019-11-21T04:13:50Z |
javascript
| 2019-11-26T17:40:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,954 |
["src/compiler/compile/render_dom/index.ts", "test/runtime/samples/dev-warning-missing-data-function/_config.js", "test/runtime/samples/dev-warning-missing-data-function/main.svelte"]
|
Incorrect dev warning with `export function named() {}`
|
**Describe the bug**
In dev mode, when a component exports a named function with the `function` keyword, then a warning "created without expected prop XXX" is issued in the browser console.
Example:
~~~html
<script>
export function propOrNot() {}
</script>
~~~
**Logs**
~~~
WARNING <Child> was created without expected prop 'propOrNot'
~~~
**To Reproduce**
[REPL](https://svelte.dev/repl/c9a1567e2b8f4e8fb8c37b491b6a9422?version=3.15.0)
**Expected behavior**
No warning.
**Severity**
To me, zero... But I guess the fix is probably trivial. And maybe the incorrect state that leads to the warning might also be a cause for more annoying bugs?
|
https://github.com/sveltejs/svelte/issues/3954
|
https://github.com/sveltejs/svelte/pull/3984
|
3d0a5f8c37bd241e8990dfe0ab51aef067ec7466
|
34bb8119b737731f8640ccd6f342e2c9b868244c
| 2019-11-19T14:24:49Z |
javascript
| 2019-11-26T14:03:50Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,948 |
["CHANGELOG.md", "src/runtime/internal/dom.ts", "test/runtime/samples/binding-width-height-a11y/_config.js", "test/runtime/samples/binding-width-height-a11y/main.svelte"]
|
bind:offsetWidth causes accessibility failure
|
**Describe the bug**
When using `bind:offsetWidth` on an element, an <object> element is added to the dom, but does not include any accessibility information.
**To Reproduce**
Add `bind:offsetWidth` to any element
**Expected behavior**
The element should be rendered in an accessible way. Likely the most desirable behavior is to render the element with role="none". Here's the failure message I'm getting
> Element does not have text that is visible to screen readers
> aria-label attribute does not exist or is empty
> aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
> Element has no title attribute or the title attribute is empty
> Element's default semantics were not overridden with role=\"presentation\"
> Element's default semantics were not overridden with role=\"none\""
**Severity**
We will still use svelte, but it will likely cause us to not use the feature, which is highly annoying. ;)
|
https://github.com/sveltejs/svelte/issues/3948
|
https://github.com/sveltejs/svelte/pull/3949
|
39bbac4393d2845989601e216a5d0b4579e1983f
|
a85c250bda52aa48f196cc605f5fd39d3c807859
| 2019-11-18T13:55:10Z |
javascript
| 2019-11-18T15:19:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,935 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/shared/add_actions.ts", "test/runtime/samples/action-object/_config.js", "test/runtime/samples/action-object/main.svelte"]
|
Allow methods in use:action like: use:instance.method={....} or use:obj.method={....}
|
Would be nice to pass a class or an object method
Can be solved with a closure ....
|
https://github.com/sveltejs/svelte/issues/3935
|
https://github.com/sveltejs/svelte/pull/5398
|
b3f54bd2cffa3c9f146b62f10565a5d98f068a84
|
254096d32041ba5bb7dd80bebffba25f31936f8a
| 2019-11-16T14:08:19Z |
javascript
| 2020-09-18T16:50:18Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,929 |
["package-lock.json", "package.json"]
|
Reserved work used in prop default value outputs invalid javascript
|
**Describe the bug**
When giving a prop a default value of an object that uses a keyword as both key, and value (i.e `{true : true}`) the svelte compiler outputs invalid JavaScript, `{true}`.
**To Reproduce**
https://svelte.dev/repl/2edabca108b64bcb909791bf1c5f58fa?version=3.14.1
**Expected behavior**
Svelte will not collapse object literal declarations into the short form for keywords.
**Information about your Svelte project:**
This issue affects version 3.13.0 and up.
**Severity**
It is slightly annoying as I had to move the default into a separate variable for now, but not blocking in anyway.
|
https://github.com/sveltejs/svelte/issues/3929
|
https://github.com/sveltejs/svelte/pull/3931
|
4b5f34ec7fb1d82a258811f4b1cde690eb8953f8
|
bcb44c286b59b6b8a0057e137a542334bb06dc5b
| 2019-11-15T16:39:54Z |
javascript
| 2019-11-16T16:42:23Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,921 |
[".changeset/good-buses-reply.md", "packages/svelte/src/compiler/phases/2-analyze/validation.js", "packages/svelte/src/internal/client/render.js", "packages/svelte/tests/runtime-runes/samples/bind-value-input-type-dynamic/_config.js", "packages/svelte/tests/runtime-runes/samples/bind-value-input-type-dynamic/main.svelte", "packages/svelte/tests/validator/samples/binding-input-type-dynamic/errors.json", "packages/svelte/tests/validator/samples/binding-input-type-dynamic/input.svelte"]
|
Provide a way to dynamically set input type (with or without two way binding)
|
**Is your feature request related to a problem? Please describe.**
I am currently making a `Input.svelte` component to manage common logic:
```html
<script>
export let id;
export let label;
export let type = 'text';
export let value = '';
export let revealed = false;
const revealToggle = (event) => {
const input = event.currentTarget.previousElementSibling;
if (!input) {
return;
}
input.type = input.type === 'password' ? 'text' : 'password';
revealed = !revealed;
}
</script>
<style>
button:focus {
outline: 0 !important;
}
</style>
<label class="block mb-2" for="{id}">{label}</label>
<div class="flex mb-4">
{#if type === 'password'}
<input
{id}
type="password"
placeholder="{label}"
bind:value
class="rounded-r-none border-r-0"
>
<button
title="Afficher le mot de passe"
type="button"
class="border border-gray-400 rounded rounded-l-none px-3 text-gray-500"
on:click={revealToggle}
>
<i class="fa fa-fw {revealed ? 'fa-eye' : 'fa-eye-slash'}"></i>
</button>
{:else}
<input {id} type="text" placeholder="{label}" bind:value>
{/if}
</div>
```
It is currently not possible to assign a prop to the `type` html attribute as you well answered here: https://stackoverflow.com/a/57393751/1731473
Otherwise, it will produce this error:
```
Error: ValidationError: 'type' attribute cannot be dynamic if input uses two-way binding
```
But it is still possible to do "dynamic" type attribute with a basic `if`/`else` logic as you can see in my example.
So I don't understand why things are not simpler. Nowadays, with html5, we have a ton of "text similar input" like `date`, `email`, or `tel`: https://www.w3schools.com/html/html_form_input_types.asp
I would like to avoid to make a `if` forest if I only need to change the `type` attribute.
Also, maybe a good place for an another issue, but I can't find an easier way to pass input related directly to the right DOM element in my component without declaring each of them manually (`min`, `max`, `required` etc...), but I don't know if this is doable.
**Describe the solution you'd like**
Allow to do something like this:
```html
<input {id} {type} placeholder="{label}" bind:value>
```
With or without two-way binding. The goal is to quickly define what type I want from my input component:
```html
<script>
import Input from './Input.svelte';
</script>
<Input type="text" ... />
```
**Describe alternatives you've considered**
The only alternative I found is what you have on my example.
Maybe it's a design issue from my own. In that case, some good advices on this issue and the documentation would be very welcome. :+1:
**How important is this feature to you?**
It is not very urgent, but I think this is quite useful in order to avoid code repetition on big projects.
|
https://github.com/sveltejs/svelte/issues/3921
|
https://github.com/sveltejs/svelte/pull/10608
|
db0b802fc2a8d0cd75f3dc209f19e06712be5a92
|
506196b72b459b3219b8c3e8db6fcc67fc101974
| 2019-11-13T18:27:00Z |
javascript
| 2024-02-22T17:07:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,914 |
["src/compiler/compile/render_dom/index.ts", "test/js/samples/debug-empty/expected.js", "test/js/samples/debug-foo-bar-baz-things/expected.js", "test/js/samples/debug-foo/expected.js", "test/js/samples/dev-warning-missing-data-computed/expected.js"]
|
Development mode warnings use array.prototype.includes which breaks bundle on IE 11
|
**Describe the bug**
When bundling in development mode the check for unknown props utilizes the Array.prototype.includes method which isn't supported on ie 11. This causes a break on ie11
**Logs**
**Expected behavior**
Conduitry suggested in the discord that this should be replaced with indexOf to avoid having to use a polyfill
**Information about your Svelte project:**
- Your browser and the version: (IE 11)
- Your operating system: (Windows 7)
- Svelte version (3.12..1)
- Whether your project uses Webpack or **Rollup**
**Severity**
Renders usage in IE 11 while developing useless so decently annoying. Requires excess polyfills simply to develop although it is not a blocking issue as adding a polyfill should fix the issue.
|
https://github.com/sveltejs/svelte/issues/3914
|
https://github.com/sveltejs/svelte/pull/3915
|
8237db442223406d78aa560404801f0cb74a04cb
|
afe5ad430a741ebece0cb94a34ffe96c6d4fdfec
| 2019-11-13T00:43:13Z |
javascript
| 2019-11-13T02:42:13Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,911 |
["src/compiler/compile/render_dom/wrappers/Element/index.ts", "test/runtime/samples/unchanged-expression-escape/_config.js", "test/runtime/samples/unchanged-expression-escape/main.svelte"]
|
Single-quotes are incorrectly encoded
|
Reported by Bobby289 in chat.
Single-quotes (`'`) are being rendered in text as `'`.
This bug appears to have appeared in 3.13.0.
- Broken case showing the bug in 3.13.0: https://svelte.dev/repl/0e69250553bc4e5ca85b1187967b9cda?version=3.13.0
- Correctly working case in 3.12.1: https://svelte.dev/repl/0e69250553bc4e5ca85b1187967b9cda?version=3.12.1
The bug still exists [in the current version, 3.14.0](https://svelte.dev/repl/0e69250553bc4e5ca85b1187967b9cda?version=3.14.0).
As you can see in the REPL, ampersands aren't affected by the encoding issue, so this might be a fairly specific issue, I haven't dug any further yet.
|
https://github.com/sveltejs/svelte/issues/3911
|
https://github.com/sveltejs/svelte/pull/3916
|
c29e2085a192dd22f7a7122b143ca2ce09372c24
|
8237db442223406d78aa560404801f0cb74a04cb
| 2019-11-12T21:50:53Z |
javascript
| 2019-11-13T02:41:34Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,906 |
["src/compiler/parse/read/script.ts", "test/sourcemaps/samples/script-after-comment/input.svelte", "test/sourcemaps/samples/script-after-comment/test.js", "test/sourcemaps/samples/two-scripts/input.svelte", "test/sourcemaps/samples/two-scripts/test.js"]
|
HTML comment causes misaligned sourcemap
|
In our project we should add license headers to source files, but when I did that in our first `.svelte` file, I experienced the generated sourcemap is incorrect and it ignores the comments.
It makes the debugging more difficult and the test coverage result is useless as well.
Svelte version: `3.14.0`
Example `.svelte` source:
```
<!-- Some comment
and more
and more details -->
<script>
const test = () => {
console.log('test');
}
</script>
```
When I want to debug `test` variable it points to the 2. line of the `.svelte` file.
This tool can help to visualize source map: http://evanw.github.io/source-map-visualization/
If I add the comment into the script tag, it works without any problem, but it looks stupid.
|
https://github.com/sveltejs/svelte/issues/3906
|
https://github.com/sveltejs/svelte/pull/4738
|
e3fef0f740fa788bba68a29f5561ad439475edbb
|
cf72b4157575e4a64d73c75dc26fa22bcd25f719
| 2019-11-12T10:30:49Z |
javascript
| 2020-04-28T20:49:44Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,900 |
["package-lock.json", "package.json", "src/compiler/compile/render_dom/Block.ts", "test/runtime/samples/deconflict-block-methods/_config.js", "test/runtime/samples/deconflict-block-methods/main.svelte"]
|
Possible 3.13.0 issue around fragments
|
**Describe the bug**
Upon updating to 3.13.0 I'm now seeing the following error, which seems to be related to transitions and slots (possibly)
**Logs**
`Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'intro.$$.fragment')`
**To Reproduce**
https://svelte.dev/repl/a8d760c0fe474b238a07d684be0c39fe?version=3.13.0
**Stacktraces**
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
[Error] Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'intro.$$.fragment')
intro (Anonymous Script 3 (line 1065))
transition_in (Anonymous Script 3 (line 285))
intro (Anonymous Script 3 (line 826))
transition_in (Anonymous Script 3 (line 285))
update (Anonymous Script 3 (line 890))
update (Anonymous Script 3 (line 248))
flush (Anonymous Script 3 (line 222))
promiseReactionJob
</details>
**Information about your Svelte project:**
- Your browser and the version: Safari 13, Chrome 78, Firefox 70
- Your operating system: macOS 10.15.1
- Svelte version 3.13.0
- Whether your project uses Webpack or Rollup: Rollup
**Severity**
Crashing the thread and requires downgrading to 3.12.1
|
https://github.com/sveltejs/svelte/issues/3900
|
https://github.com/sveltejs/svelte/pull/3907
|
afe5ad430a741ebece0cb94a34ffe96c6d4fdfec
|
6774e336bacb8a4506c54161cc7c78c301f8262f
| 2019-11-11T18:38:11Z |
javascript
| 2019-11-13T02:42:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,892 |
["src/runtime/ambient.ts", "src/runtime/index.ts", "src/runtime/internal/dev.ts"]
|
Export Inferred type from `*.svelte`
|
## Description
When importing `*.svelte` files, inferred type (originating from `ambient.ts`) doesn't match internal `SveleteComponent` (and maybe rightly so).
## Use case
Using runtime `SvelteComponent` type (for example within a bootstrapping function for Storybook/testing env)
e.g
```typescript
import { SvelteComponent } from 'svelte/types/runtime'
export type StoryFunc = {
(): { Component: SvelteComponent; props: any }
story: { parameters: { notes: { markdown: any } } }
}
```
Another example of internal type usage in [svelte-testing-library](https://github.com/testing-library/svelte-testing-library/blob/master/types/index.d.ts#L6)
## Solution
Export external `SvelteComponent` (as declared in `ambient.ts`). see #3893
|
https://github.com/sveltejs/svelte/issues/3892
|
https://github.com/sveltejs/svelte/pull/3893
|
d67b44861ae32b3147a86686b6792c05ad388162
|
5b0b2d9fd2a076b14f21c29d433d9c939a51af12
| 2019-11-11T10:43:41Z |
javascript
| 2019-11-14T20:43:22Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,882 |
["src/compiler/compile/render_dom/wrappers/Element/index.ts", "test/js/samples/hydrated-void-element/_config.js", "test/js/samples/hydrated-void-element/expected.js", "test/js/samples/hydrated-void-element/input.svelte"]
|
Void element 'children' get hydrated
|
**Describe the bug**
Svelte generates code that hydrates the children of `<img>` elements and other void elements, even though there can't be any by definition.
**To Reproduce**
https://svelte.dev/repl/f5c696a56a234934a9556be6a696e5db?version=3.12.1
**Expected behavior**
```diff
return {
c() {
img = element("img");
this.h()
},
l(nodes) {
img = claim_element(nodes, "IMG", { src: true }, false);
- var img_nodes = children(img);
-
- img_nodes.forEach(detach);
this.h();
},
h() {
attr(img, "src", "donuts.jpg");
},
```
**Severity**
Mostly harmless, but easily fixed
|
https://github.com/sveltejs/svelte/issues/3882
|
https://github.com/sveltejs/svelte/pull/3884
|
ca6c01d11f3c4d8cd62374857f40b8be1c3aff3b
|
1b454bad4acd3daeb0767a0e6c5f33f1965d47fb
| 2019-11-09T20:47:10Z |
javascript
| 2019-11-09T23:26:19Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,877 |
["src/runtime/internal/lifecycle.ts"]
|
createEventDispatcher detail is required in types
|
Types: `node_modules/svelte/types/runtime/internal/lifecycle.d.ts`
Line: `export declare function createEventDispatcher(): (type: any, detail: any) => void;`
WebStorm notice:
But detail is optional:
https://github.com/sveltejs/svelte/blob/e931a56854e3edca105f166bc747e3f47968205a/site/content/docs/03-run-time.md#createeventdispatcher
(and `name` is string, not `any`)
|
https://github.com/sveltejs/svelte/issues/3877
|
https://github.com/sveltejs/svelte/pull/3890
|
ad2aac509d76e8611a79c6b0283b4c49135adfbe
|
8f83e8ad2d2632d47ecc97ef1014cfbb307362be
| 2019-11-08T15:32:58Z |
javascript
| 2019-11-11T13:06:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,861 |
["site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/text.md"]
|
[Tutorial] Add extra explanation for object reactivity
|
**Is your feature request related to a problem? Please describe.**
There are users that are confused about how reactivity work with objects, to be more precise:
```js
const childRef = obj.foo;
// The tutorial don't explicity says that if now
// I modify childRef it will not create an invalidation of obj
childRef.bar = "new value"; // Users expect this to work, because
// obj.foo.bar = "new value"; // this updates as they expect, but childRef don't
// So the point its to let know new users that:
obj = obj;
// Will be needed in this case to update it, or work directly with the top level obj
```
**Describe the solution you'd like**
Adding to the tutorial [02-reactivity/04-updating-arrays-and-objects](https://svelte.dev/tutorial/updating-arrays-and-objects) a better explanation about this case would better inform new users.
The tutorial speaks about how array methods don't create an invalidation, but this case can't be understanded just with the explanation given.
The user @halfnelson said a rule for this case that would help new users:
> [...] it can be tricky until you are used to it
but the rule is broadly "the name of the reactive variable must appear on the left of the equals to react to assignments"
**Describe alternatives you've considered**
An option would be to make derivated references also be reactive, but that calls for problems and I feel that just explaining to new users how it works its easier than changing the underlaying behaviour.
|
https://github.com/sveltejs/svelte/issues/3861
|
https://github.com/sveltejs/svelte/pull/3863
|
20451658c1a1bd287b5bf5951100bf7e6238300a
|
05e259c0e8391e7c103d7192faf7542bb06a7a2c
| 2019-11-06T15:09:04Z |
javascript
| 2019-11-06T20:56:01Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,858 |
["test/runtime/samples/await-then-blowback-reactive/Widget.svelte", "test/runtime/samples/await-then-blowback-reactive/_config.js", "test/runtime/samples/await-then-blowback-reactive/main.svelte"]
|
Binding to select value won't set the initial value if wrapped in Promise
|
When options data is wrapped in promise, the initial `selected` value is undefined.
https://svelte.dev/repl/602600d338a848249f4be2a3f63d4e2f?version=3.12.1
When options data is literal, the initial `selected` value is correctly set.
https://svelte.dev/repl/0335847ab0d647fdb81262d6b244c480?version=3.12.1
I feel like this has something to do with how the binding is propagated/updated. But I don't know why exactly it acts like this. Is this a bug? And is there some docs about how the bindings works?
|
https://github.com/sveltejs/svelte/issues/3858
|
https://github.com/sveltejs/svelte/pull/3878
|
f3650a6ff60440679be1aba66c0f943adf725cd2
|
0052a9145b2331d3a38df8d23f0dd4c70d63af91
| 2019-11-06T04:53:40Z |
javascript
| 2019-11-09T18:54:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,857 |
["src/compiler/compile/render_dom/wrappers/Element/index.ts", "test/runtime/samples/binding-input-range-change-with-max/_config.js", "test/runtime/samples/binding-input-range-change-with-max/main.svelte"]
|
bind:value fails on range input if max is changed at same time as value
|
VIa [StackOverflow](https://stackoverflow.com/questions/58615453/svelte-using-input-type-range-with-bindvalue-and-max-slider-shown-wrong-when-v).
**To Reproduce**
https://svelte.dev/repl/1012758496d74711b8cd2ceb4d56d8b4?version=3.12.1
**Expected behavior**
The range input should look the same before and after changing `max` and `value`
**Severity**
Medium
|
https://github.com/sveltejs/svelte/issues/3857
|
https://github.com/sveltejs/svelte/pull/3871
|
47cac13b7d5dd68c494d69921397bcaf9820e441
|
5c08465cfa3321010e71394fe4fa6aae2722200e
| 2019-11-05T23:09:56Z |
javascript
| 2019-11-10T21:22:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,854 |
["src/compiler/compile/render_dom/Block.ts"]
|
Component name "Block" throws error during compilation.
|
**Describe the bug**
The component name "Block" seems to throwing the Svelte compiler off.
```html
<script>
import Block from "./Block.svelte"
</script>
<Block>my block</Block>
```
results in the error:
```
Identifier 'block' has already been declared (Note that you need plugins to import files that are not JavaScript)
```
But simply changing the component name `import Blocky from "./Block.svelte" //path is the same` works. Also, using the `Block` component more than once get's rid of the error.
https://svelte.dev/repl/10c035a984e24c3b85cabd7c1455c1af?version=3.12.1
**Information about your Svelte project:**
- Chrome 78
- MacOS
- Svelte 3.12.1
- Rollup used
|
https://github.com/sveltejs/svelte/issues/3854
|
https://github.com/sveltejs/svelte/pull/3856
|
601ec45780aeec8d4f62e6438ff1af974ce25c39
|
5ad3f6a38ba0d67b80cca40c23e6579082ce2a34
| 2019-11-05T16:17:19Z |
javascript
| 2019-11-06T11:56:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,845 |
["src/compiler/compile/utils/get_name_from_filename.ts"]
|
Unicode support for filenames
|
**Describe the bug**
Filenames with Unicode characters on them produce errors.
**Stacktraces**
```
ERROR in ./src/routes/简体中文/index.svelte
Module build failed (from ./node_modules/svelte-loader/index.js):
Error: Error: Error: Could not derive component name from file /{my-repo_name}/src/routes/简体中文/index.svelte
```
**Information about your Svelte project:**
- Svelte 3.12.1, Webpack
**To Reproduce**
Simply name a file something like `中国.svelte` and watch it fail :sob:
**Expected behavior**
For this to work :wink: .
**Severity**
I REALLY need this! So I worked out a fix and a pull request is coming your way shortly :tada:
|
https://github.com/sveltejs/svelte/issues/3845
|
https://github.com/sveltejs/svelte/pull/3846
|
70de6a23c9c72a9fdda7b07a6ecb2a07e8f15a11
|
ced5243656d15d6b1bf5a7daa7cd2d69629cb829
| 2019-11-03T09:57:28Z |
javascript
| 2019-11-06T12:16:24Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,832 |
["src/compiler/compile/render_dom/wrappers/Window.ts", "test/helpers.js", "test/js/samples/window-binding-scroll/expected.js", "test/runtime/samples/window-binding-scroll-store/_config.js", "test/runtime/samples/window-binding-scroll-store/main.svelte"]
|
Window bindings to stores don't work
|
Via https://stackoverflow.com/questions/58642539/save-window-binding-in-svelte-store:
**Describe the bug**
`<svelte:window bind:scrollY={$y}/> doesn't update the `y` store.
**To Reproduce**
https://svelte.dev/repl/f4589ca97ea248a7926026d8519b8980?version=3.12.1
**Expected behavior**
The derived store should update. It doesn't, because only the local `$y` variable is updating.
**Severity**
Medium
|
https://github.com/sveltejs/svelte/issues/3832
|
https://github.com/sveltejs/svelte/pull/3835
|
b4c22264384b947d48ccfb7db38aecb70cf16a6d
|
0c8cb44d01d3908e4471ceb94dd9c79dccf8f725
| 2019-10-31T14:19:06Z |
javascript
| 2019-11-03T12:50:57Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,828 |
["src/compiler/compile/nodes/Element.ts", "test/js/samples/bindings-readonly-order/expected.js", "test/js/samples/bindings-readonly-order/input.svelte"]
|
File input binding fails if type declared last
|
**Describe the bug**
`<input type=file bind:files>` works. `<input bind:files type=file>` doesn't. Via [Stack Overflow](https://stackoverflow.com/questions/58634083/order-of-html-element-bindings-in-svelte)
**Logs**
> Value being assigned to HTMLInputElement.files does not implement interface FileList.
**To Reproduce**
https://svelte.dev/repl/b07ef4b35880412ea63683c1d33947b5?version=3.12.1
**Expected behavior**
Svelte shouldn't attempt to assign to `input.files`
**Severity**
Low, as it's easily worked around
|
https://github.com/sveltejs/svelte/issues/3828
|
https://github.com/sveltejs/svelte/pull/3849
|
a0c934d0b016acc6fc95e6634fd8130ffbdb6a35
|
70de6a23c9c72a9fdda7b07a6ecb2a07e8f15a11
| 2019-10-31T13:04:37Z |
javascript
| 2019-11-06T12:05:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,805 |
["CHANGELOG.md", "scripts/globals-extractor.mjs", "src/compiler/compile/Component.ts", "src/compiler/utils/globals.ts", "src/compiler/utils/names.ts"]
|
Take another sweep for known globals
|
(Opening in favor of https://github.com/rollup/rollup-plugin-svelte/issues/73)
Our list of known globals is still somehow missing `Event`. We should probably take another sweep (through MDN? somewhere else?) for a list of the the most famous ones and add them to the set [here](https://github.com/sveltejs/svelte/blob/master/src/compiler/utils/names.ts).
|
https://github.com/sveltejs/svelte/issues/3805
|
https://github.com/sveltejs/svelte/pull/7786
|
f3f3d074c59c79836a42f53ecd0cece3a916ef61
|
feb8dfce61212affedfede786fd571dbd55905cb
| 2019-10-27T12:43:28Z |
javascript
| 2022-09-04T04:13:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,801 |
["src/compiler/parse/read/style.ts", "test/validator/samples/invalid-empty-css-declaration/errors.json", "test/validator/samples/invalid-empty-css-declaration/input.svelte"]
|
Confusing error message "TypeError: Cannot read property 'start' of undefined" with invalid css
|
By mistake I had this invalid css in my component:
```css
<style>
.no-wrap {
word-wrap: ;
}
</style>
```
With latest 3.12.1 I get the following compilation error:
```
Running: 'node_modules/.bin/rollup -c -w'
rollup v1.25.0
bundles svelte/main.js → www/gen/bundle.js...
[!] (plugin svelte) TypeError: Cannot read property 'start' of undefined
svelte/GistEditor.svelte
TypeError: Cannot read property 'start' of undefined
at Declaration$1.minify (/Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/css/Stylesheet.ts:148:21)
at /Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/css/Stylesheet.ts:32:15
at Array.forEach (<anonymous>)
at minify_declarations (/Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/css/Stylesheet.ts:27:15)
at Rule$1.minify (/Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/css/Stylesheet.ts:92:7)
at /Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/css/Stylesheet.ts:408:11
at Array.forEach (<anonymous>)
at Stylesheet.render (/Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/css/Stylesheet.ts:405:17)
at dom (/Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/render_dom/index.ts:33:35)
at render_dom (/Users/kjk/src/codeeval/node_modules/svelte/src/compiler/compile/index.ts:86:6)
```
I understand this is invalid cs but it's hard to figure out what's wrong from the error message.
Here's a repl: https://svelte.dev/repl/03ce54696b44445fbc8edbfa1c77696c?version=3.12.1
|
https://github.com/sveltejs/svelte/issues/3801
|
https://github.com/sveltejs/svelte/pull/3818
|
f849408a944d9ffae693f6c9e3f6765cb57f0b7c
|
da824c0d5fc2e1759b07735c716ba074b7d24f78
| 2019-10-27T05:29:15Z |
javascript
| 2019-10-28T16:16:08Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,795 |
["site/src/routes/repl/[id]/_components/AppControls/index.svelte"]
|
REPL zip with external import omits sirv-cli dependency
|
**Describe the bug**
If you download a REPL with an external dependency, that dependency is conveniently added to the project. Unfortunately, the required dependency `sirv-cli` is also overwritten, causing `npm run dev` to fail.
**Logs**
```
$ npm run dev
> [email protected] dev /svelte-app-1
> rollup -c -w
rollup v1.25.2
bundles src/main.js → public/bundle.js...
LiveReload enabled
created public/bundle.js in 349ms
[2019-10-26 00:00:00] waiting for changes...
> [email protected] start:dev /svelte-app-1
> sirv public --single --dev
sh: sirv: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! [email protected] start:dev: `sirv public --single --dev`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the [email protected] start:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
```
**To Reproduce**
1. Go to https://svelte.dev/repl/
2. Add a line like `import 'leftpad';` to the default `<script>` tag
3. Click the icon for "download zip file"
**Expected behavior**
Dependencies in `package.json` in the downloaded zip should look like this:
```
"dependencies": {
"sirv-cli": "^0.4.4",
"leftpad": "latest"
}
```
but actually looks like this:
```
"dependencies": {
"leftpad": "latest"
}
```
|
https://github.com/sveltejs/svelte/issues/3795
|
https://github.com/sveltejs/svelte/pull/3796
|
4c239974c391d1c44adcdebaa0cd01bffd5602c4
|
3f6b743dd01d952c9b6e79ccad1b5b9f46d06efa
| 2019-10-26T19:13:56Z |
javascript
| 2019-10-26T20:22:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,791 |
["CODE_OF_CONDUCT.md"]
|
Code of conduct
|
According to the https://opensource.guide/, Svelte should get a Code of Conduct?
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. For example: I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**How important is this feature to you?**
Note: the more honest and specific you are here the more we will take you seriously.
**Additional context**
Add any other context or screenshots about the feature request here.
|
https://github.com/sveltejs/svelte/issues/3791
|
https://github.com/sveltejs/svelte/pull/7183
|
630ec4b32d5a46e8428625db018ec5f2aa72d17e
|
5ccfc3c5d7a29fe6df1cb109df8d0e7868d0ea51
| 2019-10-25T09:05:36Z |
javascript
| 2022-01-25T08:48:47Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,790 |
["CHANGELOG.md", "src/compiler/compile/nodes/Element.ts", "src/compiler/compile/render_dom/wrappers/Element/index.ts", "src/compiler/compile/render_ssr/handlers/Element.ts", "src/runtime/internal/ssr.ts", "test/runtime/samples/spread-element-class/main.svelte", "test/runtime/samples/spread-element-scope/_config.js", "test/runtime/samples/spread-element-scope/main.svelte"]
|
Spread and scoping class problems
|
```svelte
<style>
div { color: red; }
.bar { font-weight: bold; }
</style>
<div {...{ class: 'bar' }} class='foo'>
This is red.
</div>
<div class='foo' {...{ class: 'qux' }}>
This should be red.
It's not because the spread clobbers the scoping class attached to the class='foo'.
</div>
<div {...{ class: 'bar' }}>
This is red, but should also be bold.
It's not because the scoping class clobbers the class='bar'.
</div>
```
The style scoping class doesn't play nicely with spreads. There are a couple bad things that can happen, as shown above. There's at least one existing issue that this one intends to supersede, as well as probably some other as-yet-unreported issues.
It seems to me the proper way to handle this is to (at least in the case where we have spreads, possibly all the time, not sure) stop adding the scoping class by tweaking the AST so it has a new/updated `class=` attribute.
Instead, we can have a `needs_scoping` boolean on the `Element`, and when we're rendering the DOM code for this element, just do something like an `elm.className += ' svelte-xyz';`. I'd have to check whether this does the right thing if there's no class.
In SSR mode, we're going to have to do something else, because you can't just programmatically add a class to an element after the fact when you're writing a string of HTML as you go. Maybe another argument to the `spread` function. There may also be problems with `class:` directives, I'm realizing now as I write this. To be investigated sometime soon.
It may end up being that an additional argument to one of the spread-related helpers is the better thing to do in DOM mode as well. Or perhaps a separate function that updates a 'here are the attributes you need to mix in' object so that the `class` value (if present) includes the scoping class.
|
https://github.com/sveltejs/svelte/issues/3790
|
https://github.com/sveltejs/svelte/pull/3792
|
33c8cd33292405af00a500c2b860ce4b6e29e535
|
85692cbd5ac9f24f02c37f641feb54cdac54ca8c
| 2019-10-25T04:07:12Z |
javascript
| 2019-10-25T17:03:09Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,763 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/Slot.ts", "src/compiler/compile/render_dom/wrappers/shared/create_debugging_comment.ts", "test/runtime/samples/component-slot-fallback-2/Inner.svelte", "test/runtime/samples/component-slot-fallback-2/Outer.svelte", "test/runtime/samples/component-slot-fallback-2/_config.js", "test/runtime/samples/component-slot-fallback-2/main.svelte", "test/runtime/samples/component-slot-fallback-2/store.svelte"]
|
Nested slots with default value and store: Cannot read property 'value' of undefined
|
**Describe the bug**
There is an `Outer` Component with a slot, which defaults to `Inner` component. `Inner` component consisting of an input field bound to a store writable object.
If we now pass something to the slot, e.g the `Inner` component surrounded by a div, input binding will break and log an "Cannot read property 'value' of undefined" error.
**Logs**
```
VM210:422 Uncaught (in promise) TypeError: Cannot read property 'value' of undefined
at Object.update [as p] (eval at handle_message (VM204 about:srcdoc:13), <anonymous>:422:37)
at update (eval at handle_message (VM204 about:srcdoc:13), <anonymous>:159:25)
at flush (eval at handle_message (VM204 about:srcdoc:13), <anonymous>:133:17)
update @ VM210:422
update @ VM210:159
flush @ VM210:133
Promise.then (async)
schedule_update @ VM210:119
make_dirty @ VM210:219
eval @ VM210:253
eval @ VM210:444
set @ VM210:364
update @ VM210:372
input_input_handler @ VM210:447
```
**To Reproduce**
REPL 1 with bug: https://svelte.dev/repl/48555174f1a34bbe8268404c7a7f0b99?version=3.12.1
REPL 2 working without slot default: https://svelte.dev/repl/31a272fac83047c282a8fe721751a884?version=3.12.1
**Expected behavior**
It should work like REPL 2
**Information about your Svelte project:**
- Your browser and the version: Chromium: 77.0.3865.120
- Your operating system: OS X 10.15
- Svelte version: 3.12.1
**Severity**
The bug is not urgent, as I can work around it by removing the slot default like in REPL 2. But its quite inconvenient
|
https://github.com/sveltejs/svelte/issues/3763
|
https://github.com/sveltejs/svelte/pull/4514
|
0cde17a4adf32bc91032d2b7ebba20472f38f2a1
|
82dce0c8fcc2d23cc0911ff9d9152ff11a2136a6
| 2019-10-21T19:57:05Z |
javascript
| 2020-03-15T09:44:05Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,761 |
["site/content/docs/03-run-time.md", "src/runtime/motion/spring.ts", "src/runtime/motion/tweened.ts", "test/motion/index.js"]
|
Allow spring/tweened values to be initially undefined
|
**Is your feature request related to a problem? Please describe.**
When using springs and tweens to describe values that are set from props, I find myself doing this sort of thing:
```html
<script>
import { spring } from 'svelte/motion';
export let big = false;
const size = spring(big ? 100 : 20);
$: size.set(big ? 100 : 20);
</script>
```
In this situation I want the value of `size` to be static when the component is first created, *until* the prop changes. But it's a nuisance to have to specify `big ? 100 : 20` twice. You could create a function for it...
```js
const get_size = big => big ? 100 : 20;
const size = spring(get_size(big));
$: size.set(get_size(big));
```
...but that's arguably worse.
**Describe the solution you'd like**
If it were possible to call `spring` without an initial value, we could initialise it later:
```js
const size = spring();
$: size.set(big ? 100 : 20);
```
Of course, it would be nice if we could initialise the store right there in the reactive declaration, as happens for non-store values, but I'm not sure what that would look like. Might be cool to be able to do this sort of thing...
```js
$: <spring>$size = big ? 100 : 20;
```
...but it's obviously invalid JS. Maybe worth coming back round to that one day, but for the meantime allowing `undefined`/`null` initial values solves the DRY problem.
**How important is this feature to you?**
I'm encountering this situation a lot in my current project. I think it's important that using motion be as frictionless as possible.
|
https://github.com/sveltejs/svelte/issues/3761
|
https://github.com/sveltejs/svelte/pull/3762
|
292017c8d43acac33fdcf141b941b7fb4034c97e
|
e931a56854e3edca105f166bc747e3f47968205a
| 2019-10-21T19:12:47Z |
javascript
| 2019-10-28T11:18:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,756 |
["test/runtime/samples/sigil-expression-function-body/_config.js", "test/runtime/samples/sigil-expression-function-body/main.svelte"]
|
compiler error: this shouldn't happen! generated code is trying to use inexistent internal
|
Passing a function, with arguments containing "@", via prop, throws the above error until it reaches a "."
Example here....
https://svelte.dev/repl/fdf62523e0db4394baca68f1fa7e73da?version=3.12.1
If you remove the "@" it works fine.
Been working on a series of basic GUI components (buttons, sliders, etc.) that trigger some store or function depending on what you pass into them when I tripped across this bug. Would make doing anything related email addresses impossible.
Appreciate the help and everything going on here! Loving Svelte so far though!
|
https://github.com/sveltejs/svelte/issues/3756
|
https://github.com/sveltejs/svelte/pull/3770
|
ebf7a9024a47a5dd40a9e43c6c589bb6c1ffa449
|
614393edcba4806300d0601919e8b70d5b81be68
| 2019-10-21T01:17:50Z |
javascript
| 2019-10-22T13:22:25Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,752 |
["package-lock.json", "package.json", "src/compiler/parse/acorn.ts", "src/compiler/parse/read/script.ts"]
|
Compiler throws exception with simultaneous default and named import [@next]
|
**Describe the bug**
An exception is thrown from somewhere inside code-red when compiling a component that contains an import of both a default and named export.
**Logs**
see compiler stacktrace below
**To Reproduce**
```svelte
<script>
import foo, { bar } from 'baz';
</script>
```
**Expected behavior**
Compiling as expected, as with 3.12.1.
**Stacktraces**
```
Cannot read property 'type' of undefined
at handle (.../node_modules/svelte/compiler.js:13825:33)
at .../node_modules/svelte/compiler.js:14392:20
at Array.map (<anonymous>)
at ImportDeclaration (.../node_modules/svelte/compiler.js:14391:41)
at handle (.../node_modules/svelte/compiler.js:13831:10)
at .../node_modules/svelte/compiler.js:14004:39
at Array.map (<anonymous>)
at handle_body (.../node_modules/svelte/compiler.js:14004:22)
at Program (.../node_modules/svelte/compiler.js:14058:11)
at handle (.../node_modules/svelte/compiler.js:13831:10)
```
**Information about your Svelte project:**
- Svelte 3.13.0-alpha.0
**Severity**
This would personally prevent me from updating Svelte.
**Additional context**
None.
|
https://github.com/sveltejs/svelte/issues/3752
|
https://github.com/sveltejs/svelte/pull/3757
|
fca35def5389c8c132b80882d3cf4154d77bf4e9
|
d976203da8d8feb41d870580aa1edc86c6ea5161
| 2019-10-19T19:31:20Z |
javascript
| 2019-10-21T15:19:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,735 |
["src/compiler/compile/render_dom/index.ts", "test/runtime/samples/store-imported/_config.js"]
|
[svelte@next] Fails to compile with imported stores
|
Compilation Error:
`Unexpected token (Note that you need plugins to import files that are not JavaScript)`.
REPL: https://svelte.dev/repl/8c33aff5b60b4eb49e721c7b2692862a?version=3.13.0-alpha.0
This works with `version=3.12`.
The package that I am using here exports stores. The `ready` store is defined like this in the package:
```ts
import { writable, derived, Writable } from 'svelte/store'
const _ready = writable<boolean>(false)
export const ready = derived<boolean, Writable<boolean>>(
_ready,
$_ready => $_ready
)
```
(The package.json of the package only exports a `module` and no `main`, if that helps.)
|
https://github.com/sveltejs/svelte/issues/3735
|
https://github.com/sveltejs/svelte/pull/3751
|
8d7d0ff7dd7b248ca6d9b6b4cac098430c6e6ffa
|
914d155d9f2b8f93f5ef44ed84c76581187f9111
| 2019-10-18T11:36:16Z |
javascript
| 2019-10-19T19:20:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,724 |
["src/compiler/compile/render_dom/Block.ts", "test/js/samples/debug-no-dependencies/expected.js", "test/js/samples/deconflict-builtins/expected.js", "test/js/samples/each-block-array-literal/expected.js", "test/js/samples/each-block-keyed-animated/expected.js", "test/js/samples/each-block-keyed/expected.js", "test/runtime/samples/deconflict-builtins-2/_config.js", "test/runtime/samples/deconflict-builtins-2/main.svelte"]
|
"Text is not a function" (svelte@next)
|
**Describe the bug**
Can't render a component with a SVG tag `<text />`.
**To Reproduce**
https://svelte.dev/repl/1a13e6014a5140c69c25d809266478e9?version=3.13.0-alpha.0
**Information about your Svelte project:**
- Svelte version 3.13.0-alpha.0
|
https://github.com/sveltejs/svelte/issues/3724
|
https://github.com/sveltejs/svelte/pull/3727
|
e3953b234c47c1337e3fc17ca33332f537182bc6
|
fca35def5389c8c132b80882d3cf4154d77bf4e9
| 2019-10-17T07:51:59Z |
javascript
| 2019-10-21T15:19:15Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,708 |
["src/compiler/compile/nodes/shared/Expression.ts"]
|
List of known globals should only ever affect generated warnings
|
#3674 and its fix revealed some weird behavior that might be fixed, but there's still definitely some weird code present. The list of known `globals` really should only ever be used for the purposes of deciding whether to return warnings when compiling, but should have no effect on the generated code itself. Whether generated code treats something like a global should depend solely on whether it's declared/imported in the script block.
This feels adjacent to what I mentioned [here](https://github.com/sveltejs/svelte/issues/3607#issuecomment-541986044), or at least these two things might make sense to clean up at the same time.
|
https://github.com/sveltejs/svelte/issues/3708
|
https://github.com/sveltejs/svelte/pull/3746
|
39b387a4546d36cf6a4d045f4439e8197cd6cda4
|
0d36f1a7941dc11b75d44f329ae7efddffffd25d
| 2019-10-15T00:43:44Z |
javascript
| 2019-10-20T11:35:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,681 |
["CHANGELOG.md", "src/runtime/internal/dom.ts", "test/runtime/samples/spread-element-readonly/_config.js", "test/runtime/samples/spread-element-readonly/main.svelte", "test/server-side-rendering/samples/spread-attributes/_expected.html", "test/server-side-rendering/samples/spread-attributes/main.svelte"]
|
Spread operator doesn't work with "form" and "list" attributes
|
**Describe the bug**
I'll try set `list` and `form` with spread operator:
```js
let [type, form, list] = ['text', 'myID', 'listID'];
let props = {type, form, list};
```
It works in regular case:
```html
<input type={type} form={form} list={list}>
```
But fails with spread operator:
```html
<input {...props}>
```
**Logs**
Firefox: `setting getter-only property "form"`
Chrome: `Cannot assign to read only property 'form' of object '#<HTMLInputElement>'`
And if we remove "form" attribute:
Firefox: `setting getter-only property "list"`
Chrome: `Cannot assign to read only property 'list' of object '#<HTMLInputElement>'`
**To Reproduce**
[REPL](https://svelte.dev/repl/21720817a9464905934d7fbfe8216739?version=3.12.1)
|
https://github.com/sveltejs/svelte/issues/3681
|
https://github.com/sveltejs/svelte/pull/3687
|
43245a30fd051904f90b80cebbcc97d38c4484ee
|
57aeddcf859ffe474f17dbfbe484d2c4a048019c
| 2019-10-10T18:12:23Z |
javascript
| 2019-10-11T22:00:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,680 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/Element/Attribute.ts", "src/compiler/compile/render_dom/wrappers/Element/index.ts", "src/runtime/internal/dom.ts", "test/runtime/samples/binding-indirect-spread/_config.js", "test/runtime/samples/binding-indirect-spread/main.svelte"]
|
Radio/checkbox input with bind:group and spread props makes variable undefined
|
**Describe the bug**
When using an input (`type="radio"` or `type="checkbox"`) with `bind:group` in combination with spread properties, it sets the bound variable to undefined when clicked.
**To Reproduce**
https://svelte.dev/repl/eded09217d054d5cb518712f08833437?version=3.12.1
**Severity**
Semi-minor inconvenience. Having to specify each prop now instead of using a spread. And not being able to share props easily.
|
https://github.com/sveltejs/svelte/issues/3680
|
https://github.com/sveltejs/svelte/pull/4398
|
c3232826d4690bcf9fea780bdb0b14a56e87c20c
|
b6d80f485af9b2e383044efe3466e684c99620af
| 2019-10-10T07:00:05Z |
javascript
| 2020-02-12T02:01:30Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,674 |
["src/compiler/compile/nodes/shared/Expression.ts", "test/runtime/samples/globals-shadowed-by-each-binding/_config.js", "test/runtime/samples/globals-shadowed-by-each-binding/main.svelte"]
|
Incorrect work #each with 'alert' as item name
|
[See this repl](https://svelte.dev/repl/d7858ca7293a4aadae79d1c13044bb69?version=3.12.1)
This code:
```
{#each alerts as alert}
<p>{alert}</p>
{/each}
```
display the system alert() function instead the alerts item:
```
function alert() { [native code] }
function alert() { [native code] }
```
Same problem with many system names such as `window`, `document`, `history`, ...
It turns out that many good variable names are banned, also that leads to implicit errors, because I expect that local variables will override the global
Server rendering works correctly, probably because there are no such global variables
|
https://github.com/sveltejs/svelte/issues/3674
|
https://github.com/sveltejs/svelte/pull/3692
|
e4d7f7745338852fb28cc9aa8354fc817966400f
|
a778e50b35474d764369f8adc4dec447968a9f39
| 2019-10-08T05:36:53Z |
javascript
| 2019-10-12T12:32:11Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,662 |
["src/compiler/compile/Component.ts", "src/compiler/compile/render_dom/index.ts", "test/runtime/samples/store-resubscribe-export/_config.js", "test/runtime/samples/store-resubscribe-export/main.svelte"]
|
Stores subscriptions inside nested components are not updated as expected when the store instance is replaced
|
**Describe the bug**
Stores subscriptions inside nested components are not updated as expected when the store instance is replaced.
**To Reproduce**
https://svelte.dev/repl/e2cf3bd73f58470983e3c16432cdd34c?version=3.12.1
**Expected behavior**
The `Inner` component should unsubscribe from the old store instance and then subscribe to the new store instance so that the value propagates properly.
**Severity**
I think this is a rather niche issue, but it's blocking the development of my GraphQL client.
**Additional context**
I'm quite new to Svelte and Sapper, and I'm trying to build a light weight GraphQL client for use in my project.
I ran in to this issue while trying to build out my route handling. If you use `preload` calls with normal filesystem based routes in Sapper you wont notice this since the component will remount. However, if you use a `...rest` route (eg for dynamic route lookups against an external service, like me) then the component wont remount and things break. This issue isn't isolated to preloading in Sapper tho, as demonstrated in the REPL example above.
I tried to work around this by just returning a plain value. That was fine until I needed to add support for a `fetchMore`-style API in order to handle pagination, and encapsulating all that as a store seems like a really elegant solution. So then I tried to work around this by making the store module scoped instead to avoid creating new instances, and then everything renders and the pagination works, but it breaks horribly when enabling link prefetching. Then data from other routes will replace the current route data whenever you hover over a link, which is not really the desired behaviour. I could probably add some sort of cache and a bunch of logic to the client to work around this, but then the client wont be so small anymore :sweat_smile:
From what I can tell after reading through the source it seems like the complier will only ever insert one `component_subscribe` call into the generated output, and the current `component_subscribe` implementation does not have any logic to handle when the store instance is replaced.
I've been trying to figure out the best way to fix that, eg if `component_subscribe` should try to watch the component state and react accordingly, or if would be better to generate the required code inside say the `$set` method on the generated instance, but I'm a bit out of my depth here..
Thanks in advance and keep up the good work! :)
|
https://github.com/sveltejs/svelte/issues/3662
|
https://github.com/sveltejs/svelte/pull/3665
|
6a98febf5fb41d54c4bd1446934a6f4624657eb5
|
db901725ae3fa246b25234fc37602b5231ad633f
| 2019-10-05T14:31:36Z |
javascript
| 2019-10-19T00:40:06Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,660 |
["src/runtime/internal/await_block.ts", "test/runtime/samples/await-set-simultaneous-reactive/_config.js", "test/runtime/samples/await-set-simultaneous-reactive/main.svelte"]
|
bind:this used in {#await} does not trigger reaction
|
**Describe the bug**
From Stackoverflow [https://stackoverflow.com/questions/58228948/how-do-i-trigger-a-reaction-when-bindthis-is-used-in-await-in-svelte]
```
<script>
import TapHere from './TapHere.svelte';
let enableButton;
$: enableButtonRect = enableButton && enableButton.getBoundingClientRect();
let promise = new Promise((resolve) => {
setInterval(resolve, 3000);
});
</script>
{#await promise}
<p>
waiting...
</p>
{:then}
<div>
<button bind:this={enableButton}>Enable</button>
<button>Disable</button>
<TapHere rect={enableButtonRect}/>
</div>
{/await}
```
The enableButton (and enableButtonRect) should cause TapHere component to react when the promise is resolved. If the div is not enclosed by {#await} it certainly does happen; but {#await} seems to prevent the reaction.
**To Reproduce**
https://svelte.dev/repl/4e0e477d6a394a83a2d79b3d1fa50525?version=3.12.1
A green "Tap Here!" message should be shown.
|
https://github.com/sveltejs/svelte/issues/3660
|
https://github.com/sveltejs/svelte/pull/3663
|
52c086b1b9f814ca2c8bc7a9742b5e43d69ebe81
|
7d9262c4216f9d779790a33c170e913386ef4456
| 2019-10-04T23:19:25Z |
javascript
| 2019-10-09T16:56:20Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,631 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/Slot.ts"]
|
Svelte generates code referencing undefined variables like div_nodes
|
Hi. I'm trying to use ESLint on the final IIFE `.js` that Svelte generates, in order to get the `no-undef` lint (usage of undefined variable).
<details>
<summary>.eslintrc.js</summary>
```js
module.exports = {
parserOptions: {
ecmaVersion: 2019,
sourceType: 'module',
},
env: {
es6: true,
browser: true,
node: true,
},
plugins: [
'svelte3',
'@typescript-eslint/eslint-plugin'
],
overrides: [
{
files: ['**/*.svelte'],
processor: 'svelte3/svelte3',
extends: "eslint:recommended",
},
{
files: ['**/*.js'],
rules: {
"no-undef": "warn",
},
},
],
}
```
</details>
This gives me:
```text
/path/to/bundle.js
1668:43 warning 'form_nodes' is not defined no-undef
```
Offending code in `bundle.js`:
```js
l: function claim(nodes) {
if (default_slot) { default_slot.l(form_nodes); }
throw new Error("options.hydrate only works if the component was compiled with the `hydratable: true` option");
},
```
`Form.svelte` is just `<form><slot /></form>` (I simplified it for the purpose of this report). If I add content to the default slot, or other HTML tags (children) to `<form>`, the issue is still there. Searching for `form_nodes` and `_nodes` in `bundle.js` gives me no results aside of the function above. If I change `Form.svelte` content to `<div><slot /></form>`, I get warning about undefined `div_nodes`.
Are `<...>_nodes` in the code above intended to be `undefined`? How can I set them? Or what else can I do to get the results I want (getting "... is not defined" errors at compile time, not runtime)?
|
https://github.com/sveltejs/svelte/issues/3631
|
https://github.com/sveltejs/svelte/pull/3748
|
0d36f1a7941dc11b75d44f329ae7efddffffd25d
|
8ef32d766ad12c14aa922083af136e9d7d027206
| 2019-09-28T00:39:18Z |
javascript
| 2019-10-20T11:39:11Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,624 |
["CHANGELOG.md", "src/runtime/internal/style_manager.ts", "test/runtime/samples/transition-css-iframe/Foo.svelte", "test/runtime/samples/transition-css-iframe/Frame.svelte", "test/runtime/samples/transition-css-iframe/_config.js", "test/runtime/samples/transition-css-iframe/main.svelte"]
|
Allow transitions to work within iFrames
|
Sometimes your app needs to run within an iframe. For example, Intercom's chat widget which needs to be style-sandboxed from the rest of the page is run in an iFrame. My app wraps a navigation component inside an iFrame for better performance in the rest of the page.
The only thing that can't be worked around in this situation is Svelte's CSS transitions. They add the animation styles to the global (top-level) document and not the component's document.
For Svelte's transitions to work, Svelte will need to support adding styles to the document a component lives in.
I've created a solution which works well and avoids memory leaks. I reference this ticket in the PR.
|
https://github.com/sveltejs/svelte/issues/3624
|
https://github.com/sveltejs/svelte/pull/3625
|
c46b3727f11132cf765028522d97f3fedf91c051
|
966aae3420ed6474fee296ddb120aa4b68fb75e1
| 2019-09-26T19:52:53Z |
javascript
| 2020-03-14T20:37:27Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,623 |
["site/content/docs/02-template-syntax.md"]
|
{#await expression catch error} control structure for #await block
|
There are cases where a dev may use data returned from a single promise in multiple places within a template. In the event of an error, it may be desirable to display an error message in a single location rather than in catch scope every place there is an `#await` block associated with that promise. Currently, the Svelte syntax does not make this easy to do. For example:
```svelte
<script>
let promise = fetchSomeData();
</script>
{#await promise}
<p>waiting for the promise to resolve...</p>
{:then value}
<p>The value is {value.firstPart}</p>
{:catch error}
<p>Something went wrong: {error.message}</p>
{/await}
...
{#await promise}
<p>waiting for the promise to resolve...</p>
{:then value}
<p>The value is {value.secondPart}</p>
{:catch error}
<p>I'm starting to repeat myself: {error.message}</p>
{/await}
```
## Proposed solution
Svelte currently provides three control structures within an `#await` block:
`{#await expression}...{:then name}...{:catch name}...{/await}`
`{#await expression}...{:then name}...{/await}`
`{#await expression then name}...{/await}`
I propose adding a fourth:
`{#await expression catch name}...{/await}`
In the event that no error is thrown the content within this structure would never be rendered. This would allow you to address the problem as below:
```svelte
<script>
let promise = fetchSomeData();
</script>
{#await promise catch error}
<p>You're not going to see anything below because of {error.message}</p>
{/await}
...
{#await promise}
<p>waiting for the promise to resolve...</p>
{:then value}
<p>The value is {value.firstPart}</p>
{/await}
...
{#await promise}
<p>waiting for the promise to resolve...</p>
{:then value}
<p>The value is {value.secondPart}</p>
{/await}
```
## Possible alternatives
I considered whether this could already be achieved in some manner within Svelte. However, a structure such as the following currently returns no output under any conditions:
```svelte
{#await promise}
{:catch error}
<p>{error.message} in one place</p>
{/await}
```
That's probably a good thing as such a structure is not very idiomatic. To achieve something that's comparable with the proposed solution above you have to insert empty tags or insert some content for the sake of it, which is also not ideal:
```svelte
{#await promise}
<p></p>
{:then value}
<p></p>
{:catch error}
<p>{error.message} in one place</p>
{/await}
```
This is not a make-or-break feature for me but would be a nice addition to Svelte, I suspect it would be unlikely to clash with other features, and would make the syntax even more expressive.
Thanks for the great library!
|
https://github.com/sveltejs/svelte/issues/3623
|
https://github.com/sveltejs/svelte/pull/5682
|
02e560c9dafbbe295d46df4ee9c9c9ffd5d9156c
|
e750b7284e2edfde71ef93957c01d243ae57d9ac
| 2019-09-26T14:37:36Z |
javascript
| 2020-11-17T10:41:35Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,608 |
["src/runtime/internal/Component.ts"]
|
Extending HTMLElement crashes in iOS 9
|
**Describe the bug**
A web app fully developed in svelte (without SSR) displays blank because the framework fails to initialize. With some effort of debugging, I found out the cause was here in `svelte/internal`:
```
let SvelteElement;
if (typeof HTMLElement !== 'undefined') {
SvelteElement = class extends HTMLElement { // culprit
```
Interestingly `HTMLElement` is not undefined in iOS 9 but its not a class (function) either.
`typeof HTMLElement` equals to `"object"` in iOS 9.This causes the script to throw and stop running before anything can be seen.
The error wasn't that apparent actually. I used Babel to transpile es6 to es5, which changes class to functions. After transpile there is a native function check:
```
function _isNativeFunction(fn) {
return Function.toString.call(fn).indexOf("[native code]") !== -1;
}
```
You can try this out in Babel REPL by writing `class A extends HTMLElement {}`. And with this, the browser would run `Function.toString.call(HTMLElement)`, which is also faulty if HTMLElement is not a function.
**Logs**
The log on iOS 9 is quite vague:
```
TypeError: Type error
```
**To Reproduce**
Just run something written with Svelte on a iOS 9 device. If you can't find one, you can try it out on XCode iPhone simulator just as I did.
**Expected behavior**
Forget about SvelteElement if HTMLElement isn't extendable.
**Information about your Svelte project:**
- Your browser and the version: Safari and iOS UIWebView
- Your operating system: (e.x. OS X 10, Ubuntu Linux 19.10, Windows XP, etc)
- Svelte version: 3.12.1
- Whether your project uses Webpack or Rollup: both, the same
**Severity**
Severe as iOS 9 users are completely unusable because of `SvelteElement` which is not used at all. There's still 0.7% of my app users with this OS version.
**Additional context**
I'm actually curious why SvelteElement wasn't dropped by rollup. It's not used at all in my app.
|
https://github.com/sveltejs/svelte/issues/3608
|
https://github.com/sveltejs/svelte/pull/3609
|
729bb12d175dbc3003be6d159f54d1af03b8359d
|
0eb825b45804ab56cac52763b064b06a673ff4a5
| 2019-09-22T12:50:09Z |
javascript
| 2019-10-09T17:09:29Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,607 |
["src/compiler/compile/Component.ts"]
|
Issue with process.env inside props within loops or await blocks
|
I am building the app using Webpack, and I'm using [dotenv-webpack](https://webpack.js.org/plugins/environment-plugin/#dotenvplugin) to load a `.env` file and have the variables exposed as `process.env` inside the client-side app.
For example, I can have this `.env` file:
````sh
APP_URL="http://localhost:3000"
````
In my code I can then use `process.env.APP_URL` to retrieve that value. This also works inside Svelte statements:
````svelte
<a href="{process.env.APP_URL}/something">Something</a>
````
This works. However, if this is put inside a loop (`{#each...}`) or a "then" block (`{#await ...}{:then ...}`), Svelte returns `undefined` for `process.env.APP_URL`.
Sorry if I can't put a REPL URL, as this requires Webpack.
|
https://github.com/sveltejs/svelte/issues/3607
|
https://github.com/sveltejs/svelte/pull/3745
|
3e02b954887514983a62a7b14bf12309ac1fac02
|
39b387a4546d36cf6a4d045f4439e8197cd6cda4
| 2019-09-22T04:31:32Z |
javascript
| 2019-10-20T11:34:31Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,602 |
["site/content/docs/03-run-time.md"]
|
Draw API docs reference "scale"
|
**Describe the bug**
Under the docs relating to draw, there is a minor part of the text that references the animation as if it was scale that I encountered when reading them.
> scale accepts the following parameters:
<img width="693" alt="API_Docs_•_Svelte" src="https://user-images.githubusercontent.com/7583921/65364605-c5edf200-dc0a-11e9-9f26-3493685233e6.png">
**Severity**
Super super minor. I only made an issue so I can reference it in a PR.
|
https://github.com/sveltejs/svelte/issues/3602
|
https://github.com/sveltejs/svelte/pull/3603
|
1baf78b097af6dd34f8efbcb281010dea041f9cd
|
44447003a9a707ed65e254e9993579548c70d710
| 2019-09-21T00:00:32Z |
javascript
| 2019-09-21T15:26:27Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,595 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/IfBlock.ts", "test/runtime/samples/if-block-compound-outro-no-dependencies/_config.js", "test/runtime/samples/if-block-compound-outro-no-dependencies/main.svelte"]
|
Malformed generated code in a situation I can't describe
|
**Describe the bug**
For
```svelte
{#if $foo}
{:else}
{#if bar()}
<Baz/>
{/if}
{/if}
```
or alternatively
```svelte
{#if $foo}
{:else if bar()}
<Baz/>
{/if}
```
Svelte generates code like `if ((show_if == null) || ) show_if = !!(bar())`.
**To Reproduce**
Compile the above, and look at the invalid code that's generated.
**Expected behavior**
Presumably the ` || ` part just shouldn't be there, but I haven't checked whether that code would do what is expected.
**Information about your Svelte project:**
Svelte 3.12.1
**Severity**
Medium-low-ish, probably. This seems to occur in a fairly specific situation.
**Additional context**
Quite possibly this will be fixed by #3539, but I wanted a record of this repro anyway.
|
https://github.com/sveltejs/svelte/issues/3595
|
https://github.com/sveltejs/svelte/pull/3749
|
914d155d9f2b8f93f5ef44ed84c76581187f9111
|
3e02b954887514983a62a7b14bf12309ac1fac02
| 2019-09-19T14:58:12Z |
javascript
| 2019-10-20T11:29:33Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,591 |
["CHANGELOG.md", "src/compiler/compile/Component.ts", "test/runtime/samples/binding-this-store/_config.js", "test/runtime/samples/binding-this-store/main.svelte"]
|
bind:this fails with store
|
**Describe the bug**
Using `bind:this` and a writable store together doesn't provide expected behavior.
**Logs**
No error log.
**To Reproduce**
Can be reproduced in REPL:
```
<script>
import { writable } from 'svelte/store'
let ref = writable(null)
</script>
<h1 bind:this={$ref}>HELLO</h1>
<i>{$ref ? $ref.innerHTML : ''}</i>
```
**Expected behavior**
Expect to see two lines of "HELLO". The second "HELLO" inside `<i>` didn't show up as expected.
**Severity**
Can be worked around.
**Work around**
```
<script>
import { writable } from 'svelte/store'
let ref = writable({})
</script>
<h1 bind:this={$ref.el}>HELLO</h1>
<i>{$ref.el ? $ref.el.innerHTML : ''}</i>
```
|
https://github.com/sveltejs/svelte/issues/3591
|
https://github.com/sveltejs/svelte/pull/3743
|
2e2b0c9175cf720542527313b3a046f92384cb01
|
8d7d0ff7dd7b248ca6d9b6b4cac098430c6e6ffa
| 2019-09-19T08:54:50Z |
javascript
| 2019-10-19T12:51:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,588 |
["src/compiler/compile/render_dom/wrappers/DebugTag.ts", "test/js/samples/debug-no-dependencies/_config.js", "test/js/samples/debug-no-dependencies/expected.js", "test/js/samples/debug-no-dependencies/input.svelte"]
|
Compile error: Nested loops with index broke after 3.9.1
|
**Describe the bug**
You can see the exact same weird parsing behavior in the example below
**Logs**
Generated code is wrong, for instance when using `{@debug paneIndex}` it generates this:
(`paneIndex` is the index from `{#each ... }` loop)
**To Reproduce**
https://svelte.dev/repl/af7ece0c29f240ad97bf795bd3be1347?version=3.9.1
- Remove debug, it compiles properly
- Remove the inner loop, and it compiles properly.
- Debug is not at fault here, because in my project, the `index` is no longer passed onto nested loops which breaks my code.
**Expected behavior**
- Proper compilation without errors
**Stacktraces**
- No errors from the compiler, only compiled code gives an error
**Information about your Svelte project:**
- Svelte version 3.9.1 compared to every single version above
**Severity**
- Medium, project is live with over 100+ daily CCU. Having smooth animations is very important in my project. I would've loved to have latest transition/animations fixes which currently look a bit janky in 3.9.1, this compiler issue prevents me from upgrading.
|
https://github.com/sveltejs/svelte/issues/3588
|
https://github.com/sveltejs/svelte/pull/3702
|
565931dff957545bf1b8a9ea57cfc097ed1a7e83
|
4eb9affda1e7fd1a6ed6e4105b93e98dab44ff62
| 2019-09-18T17:11:23Z |
javascript
| 2019-10-13T06:19:44Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,561 |
["src/runtime/internal/globals.ts"]
|
Make SSR environment-agnostic (don't count on 'global')
|
**Is your feature request related to a problem? Please describe.**
We do not use Node, we use v8 instance. So, when I compile simple test page in SSR mode, I get 'Uncaught ReferenceError: global is not defined'.
**Describe the solution you'd like**
Add `typeof global` check here
https://github.com/sveltejs/svelte/blob/64c805b66d0a05b6f9e2f07e5e9dfb2cd5af2534/src/runtime/internal/globals.ts#L3
If `global` is undefined then return {}
**How important is this feature to you?**
No chances, that we start using Node because of this. (
So, I had to add global mock (somehow), but better solution is to change the line, that I mentioned
**Additional context**
|
https://github.com/sveltejs/svelte/issues/3561
|
https://github.com/sveltejs/svelte/pull/4628
|
89f30dae3692fd8d013bd33f0342c7d58f195aea
|
085897c799dba914e553fcfac83aa3416ab23bef
| 2019-09-12T13:18:41Z |
javascript
| 2020-04-06T11:01:02Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,555 |
["src/runtime/animate/index.ts"]
|
FLIP Animations janky; inside a parent with `transform:scale()`
|
### Problem
When running **FLIP** animations on a list, if that list is inside of a parent with `transform: scale();` set to anything other than `1`, it seems that the **First** position gets calculated wrongly and causes janky animations.
[Here's a reduced test case of the issue.](https://svelte.dev/repl/765bdee52e9d4537bbe78f3f7835d154?version=3.12.1)
### Reproduction Steps
1. Produce a FLIP animation list
2. Use `transform: scale()` on the list parent
[Test Case](https://svelte.dev/repl/765bdee52e9d4537bbe78f3f7835d154?version=3.12.1)
Please note that the `scale` value could be anything, but the problem's apparentness scales linearly with the `scale` value; if it's `<1` then the animation begins compressed, and if it's `>1` then animation begins stretched.
eg: if `scale == 0.99` it's barely noticeable. if `scale == 0.1` it's exaggerated.
### Expected behavior
I would expect that the FLIP animation can perform on an list which is scaled.
### Logs
~no error logs~
### Stacktraces
~none~
### Environment
- Chrome 76.0.3x
- Mac OSX Sierra 10.12
- Svelte 3.12.1
- REPL
### Severity
Low ... I can't imagine this is a common use case. But I also imagine it's simply a calculation oversight which could be resolved by multiplying the `distance * scale`
### Additional context
> My own use-case is an Article Editor, and the article is scaled when editing for a better view of the content. But when the user edits anything, the animations get all wonky.
|
https://github.com/sveltejs/svelte/issues/3555
|
https://github.com/sveltejs/svelte/pull/3627
|
004faf67f4e6e7edfc6813a40002ec3a214c1237
|
05cf649f802bdd430f07f33278f0b772c123ebfc
| 2019-09-12T02:45:29Z |
javascript
| 2019-11-15T01:28:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,544 |
["src/compiler/compile/css/Selector.ts", "test/css/samples/omit-scoping-attribute-global-children/expected.css", "test/css/samples/omit-scoping-attribute-global-children/expected.html", "test/css/samples/omit-scoping-attribute-global-children/input.svelte", "test/css/samples/omit-scoping-attribute-global-descendants/expected.css", "test/css/samples/omit-scoping-attribute-global-descendants/expected.html", "test/css/samples/omit-scoping-attribute-global-descendants/input.svelte", "test/css/samples/omit-scoping-attribute-multiple-descendants/expected.css", "test/css/samples/omit-scoping-attribute-multiple-descendants/expected.html", "test/css/samples/omit-scoping-attribute-multiple-descendants/input.svelte"]
|
Dynamic class breaks CSS selector
|
**Describe the bug**
Some style rules aren't being applied when there is a dynamic class between the root node and target node of the selector.
**Logs**
N/A
**To Reproduce**
[https://svelte.dev/repl/c122185d662a4897a4cda657d07a3027?version=3.12.0](https://svelte.dev/repl/c122185d662a4897a4cda657d07a3027?version=3.12.0)
**Expected behavior**
I would expect all three lines of the REPL to have red text. Only the second and third do.
**Stacktraces**
N/A
**Information about your Svelte project:**
Firefox 69.0
Arch Linux
Svelte 3.12.0
**Severity**
It's annoying and very unexpected, but I can work around it.
**Additional context**
N/A
|
https://github.com/sveltejs/svelte/issues/3544
|
https://github.com/sveltejs/svelte/pull/3679
|
af0557a2d41e468e98f179607693eba28c652e2e
|
b6798e522171f94cded4f06103f03321809be2b7
| 2019-09-10T14:38:07Z |
javascript
| 2019-10-24T17:34:58Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,542 |
["src/compiler/compile/render_dom/wrappers/Slot.ts", "test/runtime/samples/transition-js-slot-2/Nested.svelte", "test/runtime/samples/transition-js-slot-2/_config.js", "test/runtime/samples/transition-js-slot-2/main.svelte"]
|
Transitioning when slot element changes does not update slot element
|
**Describe the bug**
If a transition happens on an element that contains a slot, the slot does not properly update if it is rendered again immediately after the transition ends.
**To Reproduce**
https://svelte.dev/repl/46ba49b1c588454f8f4899b4b47b8df0?version=3.12.0
In the repl, 1. is an example of this bug, 2. is an example showing how if the component is transitioned out completely then the slot is updated properly.
**Expected behavior**
In the repl, 1. should fade out "Foo" and fade in "Bar" rather than fade out "Foo" and fade in "Foo".
**Information about your Svelte project:**
Chrome v76
Windows 10
Svelte v3.12.0
See REPL
**Severity**
Not too important as it is a corner case but additional context explains why fixing it may be useful.
**Additional context**
I discovered this bug because I was trying to create page transitions in sapper but could not find a elegant way of doing so which resulted in me trying this workaround and finding this bug.
The main problem is that there is no way of adding a transition when a \<slot\> changes unless you add transitions to the slot contents which is a problem in sapper because there isn't an easy way of wrapping every page component to include intro and outro transitions.
Fixing this bug would allow the parent component to add any kind of transitioning to \<slot\> elements.
|
https://github.com/sveltejs/svelte/issues/3542
|
https://github.com/sveltejs/svelte/pull/6042
|
93a5511447d8e7d8f7968ed5a8c5ffea156296a0
|
ebd21ae6d33102b9eabeffd1ad6b36e6deda6508
| 2019-09-10T12:29:14Z |
javascript
| 2021-04-30T16:05:43Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,545 |
["src/compiler/compile/render_dom/Block.ts", "test/runtime/samples/sigil-component-prop/Widget.svelte", "test/runtime/samples/sigil-component-prop/_config.js", "test/runtime/samples/sigil-component-prop/main.svelte"]
|
Unable to handle `@` in attribute values since Svelte v3.12.0
|
**Describe the bug**
It seems that after upgrading to Svelte 3.12.0, using an @ in an attribute value causes a compiler error on the client.
This works as expected in 3.11.0
**Logs**
```
> [email protected] dev /home/ant/Projects/martin-clunes
> sapper dev
✗ client
compiler error: this shouldn't happen! generated code is trying to use inexistent internal 'martin_clunes'
✔ server (846ms)
✔ service worker (439ms)
> Listening on http://localhost:3003
```
**To Reproduce**
https://github.com/beyonk-adventures/sapper-attribute-issue
**Expected behavior**
The bundle should compile correctly.
**Information about your Sapper Installation:**
- Sapper 0.27.0+
- Svelte 3.12.0
- Dynamic application
- Rollup (haven't tried webpack)
**Severity**
It's annoying and broken, but can be worked around temporarily.
**Additional context**
This only occurs in Sapper projects, yet occurs on the client-side build.
|
https://github.com/sveltejs/svelte/issues/3545
|
https://github.com/sveltejs/svelte/pull/3546
|
c250793b358f6002b8f78fcda7b40008a35f6642
|
14ca56e9a85679e0cb003b7ac8aa32be6dc512a2
| 2019-09-10T12:07:58Z |
javascript
| 2019-09-10T15:56:08Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,541 |
["site/content/examples/10-animations/00-animate/App.svelte"]
|
Animate example in docs doesn't add todos
|
In the [animate example](https://svelte.dev/examples#animate) in the docs, when a new todo is entered into the input and and the enter key is pressed, the new todo is not added to the todo list.
This seems to be caused because the `add()` function is being called with `undefined` instead of the input.
A solution to this would be to call `add(event.target)` instead of `add(this)`, which I'm happy to put up in a PR if that's an acceptable solution?
|
https://github.com/sveltejs/svelte/issues/3541
|
https://github.com/sveltejs/svelte/pull/3543
|
e8ad4018fc144581233a18ddf89415ccb7cfd5b7
|
c250793b358f6002b8f78fcda7b40008a35f6642
| 2019-09-10T10:28:39Z |
javascript
| 2019-09-10T13:08:44Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,537 |
["src/compiler/compile/utils/invalidate.ts", "test/runtime/samples/store-unreferenced/Nested.svelte", "test/runtime/samples/store-unreferenced/_config.js", "test/runtime/samples/store-unreferenced/main.svelte", "test/runtime/samples/store-unreferenced/store.js"]
|
Store value not set via $-prefix if not used in template
|
Code for updating store value doesn't generated if store value actually not used in the component even if it used in other components.
REPL: https://svelte.dev/repl/ebcbacf20ea3402c990c92c7caf81ac6?version=3.10.1
If uncomment store usage in template example start to works correctly.
|
https://github.com/sveltejs/svelte/issues/3537
|
https://github.com/sveltejs/svelte/pull/3538
|
670fadf260551213f22aeea29db2ada871f5773c
|
50ae5724d29a62af94e944cf0d8c9068e2b700d2
| 2019-09-08T21:46:08Z |
javascript
| 2019-09-08T23:15:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,526 |
["src/compiler/compile/nodes/Attribute.ts", "src/compiler/compile/render_dom/wrappers/Element/Attribute.ts", "src/compiler/compile/render_dom/wrappers/Element/index.ts", "src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts", "test/js/samples/component-static-var/expected.js", "test/js/samples/component-static-var/input.svelte"]
|
Component update code generated unnecessarily
|
**Describe the bug**
A component with no props that could change will nevertheless get update code generated
**To Reproduce**
https://svelte.dev/repl/f26f7150be604723a047981635d30d0e?version=3.9.2
**Expected behavior**
```diff
return {
c() {
foo.$$.fragment.c();
},
m(target, anchor) {
mount_component(foo, target, anchor);
current = true;
},
- p(changed, ctx) {
- var foo_changes = {};
- if (changed.y) foo_changes.x = y;
- foo.$set(foo_changes);
- },
+ noop,
i(local) {
if (current) return;
transition_in(foo.$$.fragment, local);
current = true;
},
o(local) {
transition_out(foo.$$.fragment, local);
current = false;
},
d(detaching) {
destroy_component(foo, detaching);
}
};
```
**Severity**
Low
|
https://github.com/sveltejs/svelte/issues/3526
|
https://github.com/sveltejs/svelte/pull/3529
|
c9cf65cdb0991cf3a5aa29f7f4d92c78c19427ce
|
b6905f8fa36b79fd9660ac13c7d180df2de59471
| 2019-09-07T12:51:29Z |
javascript
| 2019-09-08T20:30:26Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,524 |
["src/compiler/compile/render_dom/wrappers/Element/index.ts", "test/js/samples/media-bindings/expected.js"]
|
Media Element Binding for set currentTime is unreliable
|
**Describe the bug**
The [Media Element Binding](https://svelte.dev/docs#Media_element_bindings) for setting `bind:currentTime={time}` is unreliable when setting single times. For example a list of video position index markers. Clicking on an index, which sets the **currentTime**, doesn't always set the video position. Where as if I set **currentTime** via the DOM method then it does work every time.
**To Reproduce**
Here's a couple of examples the issue:
https://svelte.dev/repl/3470317362744bf296ae78b688445448?version=3.9.2
https://svelte.dev/repl/17fecf5e4b5449a79f7eda6abc480f19?version=3.9.2
|
https://github.com/sveltejs/svelte/issues/3524
|
https://github.com/sveltejs/svelte/pull/3530
|
b6905f8fa36b79fd9660ac13c7d180df2de59471
|
1a9f6b4a09ab845b10aa8074207a14ba1d047b2a
| 2019-09-07T11:11:53Z |
javascript
| 2019-09-08T20:30:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,522 |
["src/compiler/compile/render_dom/wrappers/Element/index.ts", "src/runtime/internal/dom.ts", "test/runtime/samples/svg-spread/_config.js", "test/runtime/samples/svg-spread/main.svelte"]
|
Spread operator doesn't work in SVG elements
|
**Describe the bug**
When trying to fill in various attributes of an SVG element using the spread operator I get a read-only error. This seems like it might be related to the closed issue of https://github.com/sveltejs/svelte/issues/1664. If I explicitly set the attributes from an object, the SVG element renders just fine.
Failing script: https://svelte.dev/repl/a9c3d921ed4e4ab7923d64d30ed3a497?version=3.9.2
A similar script that works: https://svelte.dev/repl/62e182c229f24c2ea5bd77d307de266f?version=3.9.2
**Logs**
When I try the failing script above, I get this error: `Cannot assign to read only property 'x' of object '#<SVGRectElement>'`
**Severity**
I am trying to use Svelte to work with dynamic SVG elements, so this is a major blocker.
|
https://github.com/sveltejs/svelte/issues/3522
|
https://github.com/sveltejs/svelte/pull/3531
|
41f5961ef965ee6dc5e91ba94d60464ca2d3d7f0
|
686aa0bdc5efc1090f192b8eba9fce6bf956e90d
| 2019-09-06T21:32:31Z |
javascript
| 2019-09-08T20:29:26Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,521 |
["CHANGELOG.md", "src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts", "test/runtime/samples/spread-component-2/Widget.svelte", "test/runtime/samples/spread-component-2/_config.js", "test/runtime/samples/spread-component-2/main.svelte"]
|
Spread Props in Component removes Reactivity
|
**Describe the bug**
Using the spread operator in a #each loop in variable deconstruction and use the spread props feature along side other explicit props, makes the explicit props not reactive.
**Logs**
See REPL
**To Reproduce**
https://svelte.dev/repl/3c742a2e9ab145139a64a8c344982a3e?version=3.9.2
There is a comment in the FieldSet.svelte component indicating how to remove the {...props} from being adding props to the component. Removing that will make reactivity work again.
To see it work properly, you can set this to version 3.6.7
**Expected behavior**
I expected to be able to use spread props along side explicit props and that everything is reactive. Note I was not able to reproduce unless the prop being spread was inside a #each and deconstructed.
**Information about your Svelte project:**
See REPL
**Severity**
This is very specific and important to the project I am working on because the spread operator is allows me to only set the variables that I want to override the defaults for. If I have to explicitly set each prop then I will end up overriding defaults that I do not want to.
|
https://github.com/sveltejs/svelte/issues/3521
|
https://github.com/sveltejs/svelte/pull/4487
|
3a37de364bfbe75202d8e9fcef9e76b9ce6faaa2
|
d802c3b266be31a509cb69f3a81666b20842f3ef
| 2019-09-06T20:09:32Z |
javascript
| 2020-03-01T03:47:50Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,505 |
["src/compiler/compile/render_dom/wrappers/IfBlock.ts", "test/runtime/samples/if-block-static-with-else-and-outros/EEE.svelte", "test/runtime/samples/if-block-static-with-else-and-outros/RRR.svelte", "test/runtime/samples/if-block-static-with-else-and-outros/_config.js", "test/runtime/samples/if-block-static-with-else-and-outros/main.svelte", "test/runtime/samples/if-block-static-with-else/_config.js", "test/runtime/samples/if-block-static-with-else/main.svelte"]
|
if/else regression in 3.9.2
|
**Describe the bug**
{#if "Eva".startsWith('E')}
eee
{:else}
rrr
{/if}
will throw an error
**To Reproduce**
https://svelte.dev/repl/60ba4405814042e4925edc98e3bcc797?version=3.9.2
**Expected behavior**
no error
**Stacktraces**
Rollup: Unexpected token (Note that you need
**Severity**
breaking change
|
https://github.com/sveltejs/svelte/issues/3505
|
https://github.com/sveltejs/svelte/pull/3518
|
686aa0bdc5efc1090f192b8eba9fce6bf956e90d
|
c9cf65cdb0991cf3a5aa29f7f4d92c78c19427ce
| 2019-09-04T22:21:23Z |
javascript
| 2019-09-08T20:29:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,459 |
["src/compiler/compile/Component.ts", "src/compiler/compile/utils/checkGraphForCycles.ts", "test/runtime/samples/reactive-values-non-cyclical-declaration-order-independent/_config.js", "test/runtime/samples/reactive-values-non-cyclical-declaration-order-independent/main.svelte", "test/validator/samples/reactive-declaration-cyclical/errors.json"]
|
Cycle detection is broken
|
I sometimes get a cycle detection error when there is no cycle. There are diamonds in the graph but no cycles, and statement order in the source code matters, i.e. sometimes re-ordering the reactive statements in the code doesn't give a cycle error.
**To Reproduce**
https://svelte.dev/repl/c58d52de222546a0a743fe6fb158568c?version=3.9.1
**Expected behavior**
No cycle detection bug error for any variant of this problem
**Severity**
I cannot use Svelte when it is giving spurious and incorrect error messages.
|
https://github.com/sveltejs/svelte/issues/3459
|
https://github.com/sveltejs/svelte/pull/3516
|
cc107147ec3715ef3d70d6506b933a54d126e84b
|
ee8825d34fe31137285d38fa95963c61aa2835b7
| 2019-08-24T13:02:23Z |
javascript
| 2019-09-06T13:12:40Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 3,455 |
["src/compiler/compile/render_dom/Block.ts", "src/compiler/compile/render_dom/wrappers/EachBlock.ts", "src/compiler/compile/render_dom/wrappers/Element/Binding.ts", "test/runtime/samples/store-each-binding-destructuring/_config.js", "test/runtime/samples/store-each-binding-destructuring/main.svelte", "test/runtime/samples/store-each-binding/_config.js", "test/runtime/samples/store-each-binding/main.svelte"]
|
Store binding inside each is broken
|
**Describe the bug**
This doesn't work:
```svelte
{#each $items as item, index}
<input bind:value={item.text}>
{/each}
```
**To Reproduce**
https://svelte.dev/repl/358a3620fd6b4f159a90268a6b2035a4?version=3.9.1
**Expected behavior**
Editing the text input should update the store
**Severity**
Seems bad
**Additional context**
https://stackoverflow.com/questions/57626273/svelte-component-not-re-rendering-with-new-values-if-text-input-is-inside-an-eac
|
https://github.com/sveltejs/svelte/issues/3455
|
https://github.com/sveltejs/svelte/pull/3534
|
1a9f6b4a09ab845b10aa8074207a14ba1d047b2a
|
fafb39093c9c1a75e7d8c358dd497fe098e2597b
| 2019-08-23T15:34:27Z |
javascript
| 2019-09-08T20:36:49Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.