status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,676 |
["site/content/docs/02-template-syntax.md"]
|
Doc: document rest in array/object destructuring in each blocks
|
document #2647 and #2658
|
https://github.com/sveltejs/svelte/issues/2676
|
https://github.com/sveltejs/svelte/pull/2677
|
fee4d351e1f681db223d111274d3f857055dfb9e
|
a7dd227336bee09f2aa365ad2fe00e4b5c405c6a
| 2019-05-04T19:45:03Z |
javascript
| 2019-06-22T16:42:00Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,673 |
["site/package-lock.json", "site/package.json", "site/src/routes/_components/Blurb.svelte", "site/src/routes/index.svelte"]
|
Site: homepage grid overflowing on mobile
|
Seems stop reacting to width below 450px of width.
<img width="436" alt="Screenshot 2019-05-04 at 18 35 06" src="https://user-images.githubusercontent.com/1309648/57183425-da705e80-6ea4-11e9-9eef-a005aec8c766.png">
|
https://github.com/sveltejs/svelte/issues/2673
|
https://github.com/sveltejs/svelte/pull/2678
|
985bf870d2a0e04bf312927c3188c7a48b40bcdc
|
52633542e6f07d47f1fde125d56f1b1669a342ab
| 2019-05-04T18:43:49Z |
javascript
| 2019-05-04T21:06:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,661 |
["site/content/docs/04-compile-time.md", "src/index.ts"]
|
Request: Expose pre-configured estree walker
|
For various advanced tooling things (linting stuff, preprocessing stuff, autoformatting stuff), it would be nice if the compiler exposed its already-configured instance of the estree walker to consumers.
I would imagine this would be technically pretty easy, and the question is whether it'd be tying us down in an area where we don't want to have to worry about breaking changes.
|
https://github.com/sveltejs/svelte/issues/2661
|
https://github.com/sveltejs/svelte/pull/2672
|
16dbb8f437e29ff18b801fd5ad0a383688fc16b2
|
ba91810b0b505bb120c30b2b884f5950ac574103
| 2019-05-02T22:48:41Z |
javascript
| 2019-05-04T15:22:25Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,654 |
["src/compiler/compile/nodes/InlineComponent.ts", "src/compiler/compile/render-dom/wrappers/InlineComponent/index.ts", "src/runtime/internal/utils.ts", "test/runtime/samples/component-event-handler-modifier-once/Button.svelte", "test/runtime/samples/component-event-handler-modifier-once/_config.js", "test/runtime/samples/component-event-handler-modifier-once/main.svelte", "test/validator/samples/component-event-modifiers-invalid/errors.json", "test/validator/samples/component-event-modifiers-invalid/input.svelte"]
|
Feature Request: allow `once` modifier on custom event handlers
|
Having the ability to add modifiers for DOM events (#1088 )is really great, for example: `on:click|once={handleClick}`. Since this mechanism is now available, it might be useful to extend it to custom event handlers, such that you can do `on:message|once={handleDispatch}`. Obviously not all modifiers make sense in the context of a custom event. But for sure `once` would be useful.
|
https://github.com/sveltejs/svelte/issues/2654
|
https://github.com/sveltejs/svelte/pull/2987
|
9754f2a817b7708623251b05282bf6442e7e5f18
|
1102ff642685c1f21aaf690075199e87018463ec
| 2019-05-02T18:01:24Z |
javascript
| 2019-06-09T21:34:02Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,648 |
["src/utils/names.ts"]
|
Using alert, prompt or confirm in an inlined event handler gives warning
|
Using `alert`, `prompt` or `confirm` in an inlined event handler gives a warning like `'alert' is not defined. Consider adding a <script> block with 'export let alert' to declare a prop`. [REPL](https://svelte.dev/repl?version=3.1.0&gist=85e93a1429a6783c6699043442d24515)
```html
<script>
let isConfirmed = false;
let promptValue = '';
</script>
<button on:click="{() => alert('foo')}">Click me</button>
<div>
<button on:click="{() => promptValue = prompt()}">Prompt me</button>
{promptValue}
</div>
<div>
<button on:click="{() => isConfirmed = confirm()}">Confirm</button>
{isConfirmed}
</div>
```
|
https://github.com/sveltejs/svelte/issues/2648
|
https://github.com/sveltejs/svelte/pull/2649
|
0f07accadb8ba618e102143a0ee1b4230a35f94b
|
7b99299691aa7aa978b54f8b7059ca5c5cadd73e
| 2019-05-02T07:35:52Z |
javascript
| 2019-05-04T03:28:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,647 |
["src/compile/nodes/EachBlock.ts", "src/compile/render-dom/wrappers/EachBlock.ts", "src/compile/utils/tail.ts", "src/internal/dom.js", "src/parse/read/context.ts", "test/runtime/samples/each-block-destructured-object-rest/_config.js", "test/runtime/samples/each-block-destructured-object-rest/main.svelte", "test/validator/samples/each-block-destructured-object-rest-comma-after/errors.json", "test/validator/samples/each-block-destructured-object-rest-comma-after/input.svelte"]
|
Support for object-rest in each destructuring
|
It'd be nice to be able to do:
```html
{#each sections as {type, ...props}}
<svelte:component this={foo[type]} {...props} />
{/each}
```
as an alternative to:
```html
{#each sections as section}
<svelte:component this={foo[section.type]} {...section} />
{/each}
```
|
https://github.com/sveltejs/svelte/issues/2647
|
https://github.com/sveltejs/svelte/pull/2664
|
411752c5bb25d38d5ae57950ab4ac8d6ac4fca61
|
78332cf5b0c37edbfb4709d5963e6f8854b6eade
| 2019-05-01T23:30:05Z |
javascript
| 2019-05-04T15:34:37Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,644 |
["store.mjs", "test/store/index.js"]
|
Derived store comparison logic differs from others
|
[REPL](https://svelte.dev/repl?version=3.1.0&gist=3d41c5ce18fcd3acc68a6ec5c25b8b8f). Normally with stores we use conservative comparison logic — if a value is a non-primitive, then `set` or `update` is considered to have changed the value even if it has referential equality.
That's not the case with derived stores. This causes surprising behaviour when you're reusing objects, as is common in WebGL programming.
|
https://github.com/sveltejs/svelte/issues/2644
|
https://github.com/sveltejs/svelte/pull/2695
|
db8d7007aa63770ba72de4b8b50fe656dbab8020
|
4962e20aa2c851abd6f7ad3aa9054bdde07510e0
| 2019-05-01T15:43:44Z |
javascript
| 2019-05-06T10:57:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,641 |
["site/src/routes/docs/_GuideContents.svelte", "site/src/routes/examples/_TableOfContents.svelte", "site/src/routes/tutorial/[slug]/_TableOfContents.svelte", "site/src/routes/tutorial/[slug]/index.svelte", "site/static/global.css"]
|
add consistent sidebar-styles
|
**Hey team,**
I noticed that the text- and link-styles are different (mainly different opacities in tutorial-, docs- and examples-sidebar).
I suggest going with an overall consistent styling.
PR for this is on the way.
moved examples sidebar-improvement to #2643
|
https://github.com/sveltejs/svelte/issues/2641
|
https://github.com/sveltejs/svelte/pull/2642
|
e73084b6affd9ebfc275857897a51df58095b6b4
|
3b244a6fdefa35e84a13ac6dcd3b113783b19b06
| 2019-05-01T15:20:54Z |
javascript
| 2019-05-01T21:13:13Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,640 |
["site/content/docs/02-template-syntax.md"]
|
Site: Document {@debug} in API docs
|
`{@debug}` is mentioned in the tutorial currently but not in the API docs.
|
https://github.com/sveltejs/svelte/issues/2640
|
https://github.com/sveltejs/svelte/pull/2765
|
011b33181ee566c1566082dc645da2bb5e412f7e
|
85073dbb723796465cce6f31654f9f1166bd9e71
| 2019-05-01T13:49:35Z |
javascript
| 2019-05-15T05:09:20Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,638 |
["site/content/examples/16-context/00-context-api/Map.svelte", "site/content/tutorial/15-context/01-context-api/app-a/Map.svelte", "site/content/tutorial/15-context/01-context-api/app-b/Map.svelte"]
|
Documentation setContext and getContext cleanup
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.dev/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
Shouldn't we use the [`<svelte:head>`](https://svelte.dev/docs#svelte_head) in the [setContext and getContext](https://svelte.dev/examples#context-api) example? I'm against introducing new concepts too early for no reason, but the current code is a bit of a mess now.
Propose using:
```html
<svelte:head>
<link rel="stylesheet" href="https://unpkg.com/mapbox-gl/dist/mapbox-gl.css">
</svelte:head>
```
Instead of the current:
https://github.com/sveltejs/svelte/blob/e73084b6affd9ebfc275857897a51df58095b6b4/site/content/examples/15-context/00-context-api/Map.svelte#L17-L21
https://github.com/sveltejs/svelte/blob/e73084b6affd9ebfc275857897a51df58095b6b4/site/content/examples/15-context/00-context-api/Map.svelte#L34
|
https://github.com/sveltejs/svelte/issues/2638
|
https://github.com/sveltejs/svelte/pull/6903
|
e3380e3ccb4ced2918b475f540609883e4751977
|
2484acea2624bb802f367ebf5bfcb94e6ff41612
| 2019-05-01T12:16:36Z |
javascript
| 2021-11-04T07:15:31Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,635 |
["src/compile/utils/scope.ts", "test/runtime/samples/dev-warning-missing-data-binding/main.svelte", "test/runtime/samples/dev-warning-missing-data-component/Foo.svelte"]
|
Components should be able to explicitly specify 'undefined' as default prop value
|
If a component has
```html
<script>
export let foo = undefined;
</script>
```
then instantiating the component without a `foo` prop shouldn't cause a warning in dev mode. This seems to affect only cases where `undefined` is the default value - other default values work fine.
|
https://github.com/sveltejs/svelte/issues/2635
|
https://github.com/sveltejs/svelte/pull/2637
|
7b99299691aa7aa978b54f8b7059ca5c5cadd73e
|
73bf5829f7ce168b3910f159a46cba000effb131
| 2019-05-01T05:08:26Z |
javascript
| 2019-05-04T03:29:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,625 |
["src/compile/render-dom/index.ts", "test/runtime/samples/store-increment-updates-reactive/_config.js", "test/runtime/samples/store-increment-updates-reactive/main.svelte"]
|
Increment operator (++) not reactive on auto-subscription variable
|
import { writable } from 'svelte/store';
let count1 = 0;
const count2 = writable(0);
function increment1() {
count1++;
}
function increment2() {
$count2++;
}
Above, `count++` is reactive, but `$count++` (a store auto-subscription variable) is not.
The generated code is:
function increment2() {
$count2++;
}
but should be:
function increment2() {
$count2++; count2.set($count2);
}
This was confirmed as a bug on Discord.
[REPL reproduction](https://svelte.dev/repl?version=3.1.0&gist=9a4e1211f840800cc0e1df915b8f646a)
|
https://github.com/sveltejs/svelte/issues/2625
|
https://github.com/sveltejs/svelte/pull/2634
|
73bf5829f7ce168b3910f159a46cba000effb131
|
203d0eced46b0388e344bcf33355db68a979fac0
| 2019-04-30T14:44:45Z |
javascript
| 2019-05-04T03:31:34Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,614 |
["site/static/global.css"]
|
Site: REPL compiler option toggles remain when switching between tabs
|
|
https://github.com/sveltejs/svelte/issues/2614
|
https://github.com/sveltejs/svelte/pull/2617
|
60e73c41dceaad8354c312105edfadc887849f7b
|
d419274afd550f98d281e9d3eb051e24f314391a
| 2019-04-29T13:30:03Z |
javascript
| 2019-04-30T11:21:19Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,609 |
["site/src/routes/blog/[slug].svelte", "site/src/routes/blog/_posts.js", "site/src/utils/slug.js"]
|
Site: blog headers anchors
|
Sometimes it's useful to refer to a section of a blog post: say that [here](https://svelte.dev/blog/svelte-3-rethinking-reactivity) I need to share the paragraph "Upgrading from version 2" down the page.
Currently there are not header anchors to do that.
|
https://github.com/sveltejs/svelte/issues/2609
|
https://github.com/sveltejs/svelte/pull/2610
|
5813248e5a958670c8c22648697e04e2efa17dc0
|
de31170a404d5011f803bab1b1aacf551f5703f4
| 2019-04-28T19:16:02Z |
javascript
| 2019-05-04T04:02:37Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,592 |
["site/src/components/InlineSvg.svelte", "site/src/routes/repl/_components/AppControls/index.svelte", "site/src/routes/repl/index.svelte", "site/src/utils/compat.js"]
|
Site: REPL tabs are indistinguishable
|
It is currently impossible to distinguish /repl tabs by title as they appear all the same:
<img width="684" alt="Screenshot 2019-04-27 at 17 45 06" src="https://user-images.githubusercontent.com/1309648/56852555-af21c880-6914-11e9-8a38-b260532228a6.png">
<img width="275" alt="Screenshot 2019-04-27 at 17 45 21" src="https://user-images.githubusercontent.com/1309648/56852556-af21c880-6914-11e9-88e9-e89d4190d49f.png">
It would be nice to use the example title in the page title.
|
https://github.com/sveltejs/svelte/issues/2592
|
https://github.com/sveltejs/svelte/pull/2593
|
55efa0e0b15d945b90c93e1e1e9c52707f7a7247
|
8839951185c6ce0abb8a1fe45e96394418e7950c
| 2019-04-27T16:50:29Z |
javascript
| 2019-04-28T23:09:40Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,582 |
["src/compile/nodes/Element.ts", "test/validator/samples/a11y-figcaption-in-non-element-block/input.svelte", "test/validator/samples/a11y-figcaption-in-non-element-block/warnings.json"]
|
A11y: <figcaption> must be an immediate child of <figure>
|
```
<script>
let caption = 'Lorem ipsum';
</script>
<figure>
<img src="https://placekitten.com/200/300" alt="kitty" />
{#if caption}
<figcaption>{caption}</figcaption>
{/if}
</figure>
```
This outputs the following warning: `A11y: <figcaption> must be an immediate child of <figure>`
REPL: https://svelte.dev/repl?version=3.1.0&gist=81856872f651e9f460d8f7497dedceb5
|
https://github.com/sveltejs/svelte/issues/2582
|
https://github.com/sveltejs/svelte/pull/2607
|
05428252bc58cea44632e8f84f70cf7316cc6653
|
16dbb8f437e29ff18b801fd5ad0a383688fc16b2
| 2019-04-26T23:40:19Z |
javascript
| 2019-05-04T15:21:39Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,573 |
["src/internal/dom.js"]
|
Give insertBefore a Node or null as anchor
|
> [`referenceNode` is **not** an optional parameter -- you must explicitly pass a `Node` or `null`. Failing to provide it or passing invalid values may behave differently in different browser versions.](https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore#Syntax)
This throws an error in IE9 and 10, so it might be worth [defaulting the `anchor` component option to `null`](https://github.com/sveltejs/svelte/blob/d03eddcce266ba519d3828226b2d38e7a5b9fe54/src/internal/Component.js#L108):
```javascript
mount_component(component, options.target, options.anchor || null);
```
Or possibly [defaulting it at `insert`](https://github.com/sveltejs/svelte/blob/1f5293810f442bcd6aecc5525b98cf4ac73f0974/src/internal/dom.js#L5-L7):
```javascript
export function insert(target, node, anchor) {
target.insertBefore(node, anchor || null);
}
```
I'm not sure what's best, so I thought I'd open an issue and discuss it before creating a PR.
|
https://github.com/sveltejs/svelte/issues/2573
|
https://github.com/sveltejs/svelte/pull/2616
|
c217f2b00bba91106f1b56ba6c29456752e2ef79
|
ab711ac89cb040220b11899a9717543a23771d3e
| 2019-04-26T08:47:25Z |
javascript
| 2019-05-04T04:01:33Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,571 |
["site/content/docs/01-component-format.md"]
|
Document RxJS support
|
Need to add to the docs the fact that you can now use RxJS/TC39 observables like regular stores
|
https://github.com/sveltejs/svelte/issues/2571
|
https://github.com/sveltejs/svelte/pull/4226
|
252ec8cecaafd0fdbd92aadc69420b82891ca8b1
|
14154fce364a773575c1633769e88aa73e345902
| 2019-04-26T03:18:12Z |
javascript
| 2020-01-07T22:26:57Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,569 |
["src/compiler/compile/nodes/shared/Expression.ts", "test/runtime/samples/each-block-keyed-index-in-event-handler/_config.js", "test/runtime/samples/each-block-keyed-index-in-event-handler/main.svelte"]
|
Index of elements in each loop are not reactive inside if blocks
|
REPL: https://svelte.dev/repl?version=3.0.1&gist=5b40d855b7b1627769fdcfff259a9fcb
Index specified on event handlers, inside if blocks within each blocks, do not get updated reactively. However, it does work if the index is displayed inside the if block.
In the above REPL, try removing f2 and then f3. f3 doesn't get removed, since the index remains the same.
|
https://github.com/sveltejs/svelte/issues/2569
|
https://github.com/sveltejs/svelte/pull/3443
|
b567eb2677204f5b52d34ba57b59d56ba87ee413
|
143125ecef2bfd1b40f3749bffadd13edfd5a686
| 2019-04-26T00:15:30Z |
javascript
| 2019-08-22T12:53:37Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,559 |
["site/content/docs/01-component-format.md"]
|
Site: document export-as trick
|
We should document the trick for using export-as to give methods and props reserved names.
Something else that came up yesterday in chat was giving a static class member and an instance member the same name, which can also be handled with this. This might be too niche to specifically call out in the docs though.
|
https://github.com/sveltejs/svelte/issues/2559
|
https://github.com/sveltejs/svelte/pull/2705
|
77959a2cc2be3cdb318057c45bd8bda0cc5fcbcc
|
f7978b234a6dff108b2469138ef3b5fdbe62b405
| 2019-04-25T10:37:56Z |
javascript
| 2019-05-07T12:49:54Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,553 |
["site/content/docs/03-run-time.md", "store.mjs", "test/store/index.js"]
|
No stop functionality in derived stores
|
I was thinking I could create internal subscriptions, say to firebase, within derived store start function, like with readable stores:
```js
export const posts = derived(
user,
($user, set) => {
if (isClient && $user) {
console.log('user update, subbing posts.')
const unsub = firebase
.firestore()
.collection('posts')
.orderBy('createdAt', 'desc')
.onSnapshot(snap => {
console.log('posts snapshot:', snap.docs.length)
set(snap.docs.map(d => ({ id: d.id, ...d.data() })))
})
// this doesn't do anything because internally it's never called.
// derived creates a readable sub from $user, and usubs from *that* outer subscription
// no way for me to unsub from this *internal* subscription
return () => console.log('unsub posts') || unsub()
}
},
undefined
)
```
Use case would be any subscription creation that depends on values from other stores or firebase paths or auth state etc. Kind of like `switchMap` from rxjs... reactive all the way down.
One useful aspect of the readable store is that if you *don't* return a stop function, the firebase listener remains active. It'd be nice to also have this use case inside `derived` but you'd have to distinguish between stopping subscription when dependencies change to recreate it, and stopping when there's 0 subscribers.
|
https://github.com/sveltejs/svelte/issues/2553
|
https://github.com/sveltejs/svelte/pull/2730
|
8f5f48153bf6b5c6abf4664fb6ac9399a396f826
|
644b8a732da3a64f47f39601fcf993bdfd0f4471
| 2019-04-24T18:44:42Z |
javascript
| 2019-05-12T17:31:24Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,550 |
["site/src/routes/examples/index.svelte", "site/src/routes/repl/index.svelte"]
|
Site: interactive output results of examples do not seem to work on touch screens
|
Interacting with any of the _output results_ of the examples on svelte.dev, on the front page or in the tutorial, using up-to-date iPad/iPhone on Mobile Safari fails.
It’s as if the `on:click` handlers aren’t firing on taps.
This page is a good example: https://svelte.dev/tutorial/updating-arrays-and-objects. Tapping the ”Add a number” button does nothing.
|
https://github.com/sveltejs/svelte/issues/2550
|
https://github.com/sveltejs/svelte/pull/2597
|
788519b1c460080c2f64fecdc7dc255409efff60
|
55efa0e0b15d945b90c93e1e1e9c52707f7a7247
| 2019-04-24T15:57:10Z |
javascript
| 2019-04-28T13:56:45Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,542 |
["src/compile/Component.ts", "test/runtime/samples/export-function-hoisting/_config.js", "test/runtime/samples/export-function-hoisting/main.svelte"]
|
`is_hoistable` causes "too much recursion" when exported functions reference each other
|
The compiler gets into an infinite loop with this code: [REPL](https://svelte.dev/repl?version=3.0.0&gist=0277b9bcce566130cf52c2b9ba219c6f)
Seems to be something in `is_hoistable`; here is part of the compiler stack trace:
```
at is_hoistable (compiler.js:15000:4)
at Object.enter (compiler.js:15025:21)
at visit (compiler.js:323:9)
at visit (compiler.js:345:4)
at visit (compiler.js:345:4)
at visit (compiler.js:340:5)
at visit (compiler.js:345:4)
at walk (compiler.js:303:2)
at is_hoistable (compiler.js:15000:4)
```
|
https://github.com/sveltejs/svelte/issues/2542
|
https://github.com/sveltejs/svelte/pull/2543
|
ed7c32d12b14d4239663c8c3a822ec40c1a176e0
|
f888123860d55eed0245d40c4eac61ac340cbff9
| 2019-04-24T04:19:07Z |
javascript
| 2019-04-25T01:51:55Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,533 |
["site/content/docs/02-template-syntax.md", "site/content/docs/03-run-time.md"]
|
Site: document createEventDispatcher
|
https://svelte.dev/docs#createEventDispatcher
|
https://github.com/sveltejs/svelte/issues/2533
|
https://github.com/sveltejs/svelte/pull/2583
|
211d86b4f810670d6549ba196c569a0b9f5d6d6a
|
764f71c30d7abdae8d36ad7cce9fa44c5e0e76d9
| 2019-04-23T23:04:54Z |
javascript
| 2019-04-29T22:17:13Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,527 |
["site/src/routes/examples/_TableOfContents.svelte", "site/src/routes/examples/index.svelte", "site/static/icons/loading.svg"]
|
Site examples: add a cache and show a loading icon
|
In the current implementation, when we click on an example in the navigation bar we immediately switch to the code view and start fetching, with some visible delay that makes so that we see the old code until we get new data, which is not ideal.
Here are couple of ways to address this:
- switch to the example code view when we actualy fetched the example data;
- meanwhile, show a loading icon and make it evident that the repl does not correspond to the selected example;
- cache the results so that when we navigate to an example we already visited we have no delay: this should be okay as currently the examples/ directory is 991 KB, so even if opened all the examples we'd still just cache 1MB of data.
|
https://github.com/sveltejs/svelte/issues/2527
|
https://github.com/sveltejs/svelte/pull/2529
|
14ece6e789ed9cf9fde6211de3edf7ae745b33fd
|
de8d1a3bc2ae96daab9e0c7faff44e61fd4ee20e
| 2019-04-23T20:13:05Z |
javascript
| 2019-04-25T03:41:33Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,520 |
["src/internal/spread.js", "test/runtime/samples/component-slot-spread-props/Nested.svelte", "test/runtime/samples/component-slot-spread-props/_config.js", "test/runtime/samples/component-slot-spread-props/main.svelte"]
|
Use of $$props in component causing DOMException
|
I am using `{...$$props}` to unpack all the props applied to a `<Link>` component (to make it easier to apply other attributes, such as class names, styles, etc), and this is causing an odd bug.
When used in conjunction with a `<Layout>` component that has a slot, and a form input, when you _change_ the form input value, it throw this error:
```
VM34:100 Uncaught (in promise) DOMException: Failed to execute 'setAttribute' on 'Element': '$$scope' is not a valid attribute name.
at attr (eval at handle_message (about:srcdoc:68:8), <anonymous>:100:13)
at set_attributes (eval at handle_message (about:srcdoc:68:8), <anonymous>:110:5)
at Object.update [as p] (eval at handle_message (about:srcdoc:68:8), <anonymous>:418:5)
at update (eval at handle_message (about:srcdoc:68:8), <anonymous>:182:16)
at flush (eval at handle_message (about:srcdoc:68:8), <anonymous>:152:5)
```
It's odd, since the form input obviously has no connection to the `<Link>` components.
You can find a REPL of this issue [here](https://svelte.dev/repl?version=3.0.0&gist=be00226445bd2828bd74e35a95f11f35). Simply open up devtools, type something into the input, and you'll see the error.
Version: Svelte 3.0.0
Browser: Chrome 73.0.3683.103 (Official Build) (64-bit)
|
https://github.com/sveltejs/svelte/issues/2520
|
https://github.com/sveltejs/svelte/pull/2618
|
6240ed0b940409e0bac64f38a50a013abc262ff3
|
c217f2b00bba91106f1b56ba6c29456752e2ef79
| 2019-04-23T18:28:48Z |
javascript
| 2019-05-04T04:00:43Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,514 |
["src/compile/utils/scope.ts", "test/runtime/samples/reactive-value-mutate/_config.js", "test/runtime/samples/reactive-value-mutate/main.svelte"]
|
REPL - extractors[param.type] is not a function
|
# :warning: REPL $ marks a statement as reactive
All steps saved here:
- https://gist.github.com/KeyJoo/280947f3c9147650e685e8e59165a7c6
|
https://github.com/sveltejs/svelte/issues/2514
|
https://github.com/sveltejs/svelte/pull/2518
|
b1117851847f1d7df610b72c1938128e639a79ad
|
c97ee00b4e697a5e38048022ce5aac34c36bb8a6
| 2019-04-23T14:47:32Z |
javascript
| 2019-04-25T01:58:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,510 |
["src/compile/utils/scope.ts", "test/runtime/samples/reactive-value-mutate/_config.js", "test/runtime/samples/reactive-value-mutate/main.svelte"]
|
Reactive statements throwing TypeError from svelte plugin
|
I just ran into an issue with Svelte with the reactive statements. I created a sample app using the `sveltejs/template` starter repo. I added a single reactive statement to the `App.svelte` component, which you can [see here](https://github.com/reinink/my-svelte-project/blob/aa0e5d425e405b40ac351b0094ca0dfb7939b610/src/App.svelte#L4)
```html
<script>
export let name;
$: document.title = name;
</script>
<style>
h1 {
color: purple;
}
</style>
<h1>Hello {name}!</h1>
```
Here is the error I'm getting:
```
1!] (svelte plugin) TypeError: extractors[param.type] is not a function
npm ERR! code ELIFECYCLE
npm ERR! errno 1ctors[param.type] is not a function
npm ERR! [email protected] autobuild: `rollup -c -w`y-svelte-project/node_modules/svelte/compiler.js:17623:28)
npm ERR! Exit status 1/Users/jonathan/Sites/my-svelte-project/node_modules/svelte/compiler.js:17619:13)
npm ERR! ript.content.body.forEach.node (/Users/jonathan/Sites/my-svelte-project/node_modules/svelte/compiler.js:22946:14)
npm ERR! Failed at the [email protected] autobuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.es/svelte/compiler.js:22938:30)
at new Component (/Users/jonathan/Sites/my-svelte-project/node_modules/svelte/compiler.js:22594:15)
npm ERR! A complete log of this run can be found in:ect/node_modules/svelte/compiler.js:23614:24)
npm ERR! /Users/jonathan/.npm/_logs/2019-04-23T13_46_58_987Z-debug.logt/node_modules/rollup-plugin-svelte/index.js:236:22)
ERROR: "autobuild" exited with 1.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] dev: `run-p start:dev autobuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
```
Full repo [here](https://github.com/reinink/my-svelte-project).
|
https://github.com/sveltejs/svelte/issues/2510
|
https://github.com/sveltejs/svelte/pull/2518
|
b1117851847f1d7df610b72c1938128e639a79ad
|
c97ee00b4e697a5e38048022ce5aac34c36bb8a6
| 2019-04-23T13:48:24Z |
javascript
| 2019-04-25T01:58:59Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,508 |
["site/README.md", "site/config.js", "site/package-lock.json", "site/package.json", "site/src/utils/slug.js", "site/test/utils/slug.js"]
|
Use pure javascript slugification library
|
The new library for generating site navigation slugs has a dependency on `nodejieba`, a native Node module. This requires that the user have Python 2 / Make / G++ installed on Unix to built and install the package, and goodness knows what on Windows. The site seems to work fine without the package (until we have a Chinese version of the site maybe), but having a library in pure js would be preferable.
---
cc @mindrones
|
https://github.com/sveltejs/svelte/issues/2508
|
https://github.com/sveltejs/svelte/pull/2590
|
e0bebb56a9389c2740623db1cc95449c70aee981
|
788519b1c460080c2f64fecdc7dc255409efff60
| 2019-04-23T10:21:14Z |
javascript
| 2019-04-28T13:54:38Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,506 |
["site/package-lock.json", "site/package.json"]
|
Input cursor jumps to the end of the text after a first letter has been entered (Safari 12.1)
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.dev/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
Hello. Found strange behavior while going through tutorial.
In chapter "Each block bindings" https://svelte.dev/tutorial/each-block-bindings
After bindings have set. Try to place input cursor in the middle of text in the input box and start input text. After the first letter cursor jumps to the end of the text.
Here is REPL gist:
https://svelte.dev/repl?version=3.0.0&gist=2c4c044cb22819dfa5335e98004c4f27
Here is video demonstration:
https://youtu.be/j1Sdrie3orM
Safari Version 12.1 (14607.1.40.1.4)
No issues in Chrome.
|
https://github.com/sveltejs/svelte/issues/2506
|
https://github.com/sveltejs/svelte/pull/5250
|
8f17d6c78c7de1af54b8eb5ccffc68c78708d26b
|
5d5a608d324abcae2250366a464fbc79f18fd7f4
| 2019-04-23T08:40:46Z |
javascript
| 2020-08-12T20:07:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,505 |
["site/content/examples/00-introduction/02-styling/App.svelte", "site/content/examples/00-introduction/03-nested-components/App.svelte", "site/content/examples/04-events/05-dom-event-forwarding/FancyButton.svelte", "site/content/examples/99-embeds/20181225-blog-svelte-css-in-js/styles.js", "site/content/tutorial/01-introduction/04-styling/app-b/App.svelte", "site/content/tutorial/01-introduction/04-styling/text.md", "site/content/tutorial/01-introduction/05-nested-components/app-a/App.svelte", "site/content/tutorial/01-introduction/05-nested-components/app-b/App.svelte", "site/content/tutorial/05-events/06-dom-event-forwarding/app-a/FancyButton.svelte", "site/content/tutorial/05-events/06-dom-event-forwarding/app-b/FancyButton.svelte"]
|
Comic Sans MS is not a standard font on Linux
|
Comic Sans MS is not a standard font on Linux, but there are some examples that use the font. I suggest to either add it as webfont or add an alternative font for Linux. Otherwise it just looks like the standard font.
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.dev/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
|
https://github.com/sveltejs/svelte/issues/2505
|
https://github.com/sveltejs/svelte/pull/3943
|
a4658e2d428acebf23a5b80ea7467f46efe8c20c
|
5721ae3aeb1ea989c49b0659af253b33241b4f9c
| 2019-04-23T07:47:48Z |
javascript
| 2019-11-18T15:45:39Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,499 |
["site/src/routes/examples/index.svelte", "site/src/routes/repl/index.svelte"]
|
Can’t interact with result pane on guide or REPL on iOS Safari
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.dev/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
I was going through the guide and couldn’t click or focus inputs on the result pane. I went to the repl to check and it shows the same behavior. I can switch tabs but it is like there is something covering the result pane. Selecting text is also not possible.
* iOS 12.1.1
|
https://github.com/sveltejs/svelte/issues/2499
|
https://github.com/sveltejs/svelte/pull/2597
|
788519b1c460080c2f64fecdc7dc255409efff60
|
55efa0e0b15d945b90c93e1e1e9c52707f7a7247
| 2019-04-22T22:47:20Z |
javascript
| 2019-04-28T13:56:45Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,494 |
["site/content/docs/00-introduction.md"]
|
Put a link to the archived v2 site
|
There should be a link to [v2.svelte.dev](https://v2.svelte.dev/) somewhere on the new homepage, probably even quite prominently — most v2 users probably don't know where to find their docs anymore.
|
https://github.com/sveltejs/svelte/issues/2494
|
https://github.com/sveltejs/svelte/pull/4745
|
35a910eea21d73f871a10335f1059c9dcb154eb5
|
0e61e51358039527bc153bf577ddc46feb082ce8
| 2019-04-22T18:25:36Z |
javascript
| 2020-04-29T19:38:58Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,485 |
["site/package-lock.json", "site/package.json"]
|
Reducible stores?
|
Feedback from my spy in the React community: 'You really, really, really need some sort of "useReducer."'.
`useReducer` is [documented here](https://reactjs.org/docs/hooks-reference.html#usereducer), and basically allows you to do [this](https://svelte.dev/repl?version=3.0.0&gist=de0292106bb6ce2a0de827ac7873d784):
```js
function reducer(count, action) {
switch (action.type) {
case 'increment':
return count + 1;
case 'decrement':
return count - 1;
default:
throw new Error();
}
}
const [count, dispatch] = reducible(0, reducer);
```
`count` is a store that you update by calling `dispatch({ type: 'increment' })` and so on.
Personally I'm not *entirely* convinced that stringly-typed Redux-style dispatching is superior to [creating custom stores like this](https://svelte.dev/repl?version=3.0.0&gist=43bb1deb9a81949849ef3e5f76262b1f), but perhaps there's some benefit I've overlooked. It would be a simple enough thing to add — the implementation is just this:
```js
function reducible(state, reducer) {
const { update, subscribe } = writable(state);
function dispatch(action) {
update(state => reducer(state, action));
}
return [{ subscribe }, dispatch];
}
```
(alternative API — `return { subscribe, dispatch }`)
|
https://github.com/sveltejs/svelte/issues/2485
|
https://github.com/sveltejs/svelte/pull/5250
|
8f17d6c78c7de1af54b8eb5ccffc68c78708d26b
|
5d5a608d324abcae2250366a464fbc79f18fd7f4
| 2019-04-22T13:25:30Z |
javascript
| 2020-08-12T20:07:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,484 |
["site/package-lock.json", "site/package.json"]
|
Allow component names like <Foo.Bar.Baz>?
|
Was just playing around with an interpretation of React's `createContext`/`useContext` API:
https://svelte.dev/repl?version=3.0.0&gist=2a110c18df550964f9b31aa2425eaaf1
I think it works pretty well, if you prefer that sort of thing to the standard context API, but it might be nice if `App.svelte` looked like this instead:
```diff
<script>
import ChildComponent from './ChildComponent.svelte';
- import { Provider } from './ThemeContext.js';
+ import ThemeContext from './ThemeContext.js';
let theme = 'light';
</script>
<select bind:value={theme}>
<option>light</option>
<option>dark</option>
</select>
<ThemeContext.Provider value={theme}>
<ChildComponent />
</ThemeContext.Provider>
```
I can see this being useful in other scenarios as well, e.g. if a package exported multiple components that were designed to be used together:
```html
<script>
import * as Funky from 'funky-ui';
</script>
<Funky.Dropdown>
<Funky.Option>one</Funky.Option>
<Funky.Option>two</Funky.Option>
<Funky.Option>three</Funky.Option>
</Funky.Dropdown>
```
|
https://github.com/sveltejs/svelte/issues/2484
|
https://github.com/sveltejs/svelte/pull/5250
|
8f17d6c78c7de1af54b8eb5ccffc68c78708d26b
|
5d5a608d324abcae2250366a464fbc79f18fd7f4
| 2019-04-22T13:17:08Z |
javascript
| 2020-08-12T20:07:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,456 |
["site/src/components/TopNav.svelte"]
|
Don't show/hide nav when clicking in docs sidebar
|
At the moment it's treated as a regular scroll, which causes the nav to appear/disappear unexpectedly
|
https://github.com/sveltejs/svelte/issues/2456
|
https://github.com/sveltejs/svelte/pull/2530
|
adcd13f6dd406b8081b81586382e05544496cacc
|
93f7ecca1d8fb90f7a1f8bfded3b03e0ab9e2b76
| 2019-04-21T17:59:11Z |
javascript
| 2019-04-24T14:29:04Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,449 |
["site/src/components/PreloadingIndicator.svelte", "site/src/routes/_layout.svelte"]
|
Add preloading indicator
|
Occasionally the site is slow to respond upon navigation (because Now needs a kick? who knows. eventually should look at updating to Now 2 or investigating alternatives), and when that happens the site feels broken. Adding a preloading indicator that appears after ~250ms (and maybe shows an offline/broken indicator if navigation takes over a second?) would mitigate that.
|
https://github.com/sveltejs/svelte/issues/2449
|
https://github.com/sveltejs/svelte/pull/2473
|
a8832f006e7cb9f24e5bb7fdcd9b7c662633265e
|
be6d61f5ed11abf8810dc9a034fa8a44a5ca67f0
| 2019-04-21T13:22:10Z |
javascript
| 2019-04-22T10:02:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,448 |
["site/src/routes/blog/[slug].svelte", "site/src/routes/blog/index.svelte", "site/src/routes/docs/index.svelte", "site/src/routes/examples/index.svelte", "site/src/routes/index.svelte", "site/src/routes/repl/embed.svelte", "site/src/routes/repl/index.svelte", "site/src/routes/tutorial/[slug]/index.svelte", "site/src/template.html", "site/static/images/twitter-card.png"]
|
Add <meta> tags for social sharing
|
https://svelte.technology has `<meta>` tags that mean links shared on Twitter (and other places?) get the card treatment, with logo and title/standfirst. Need to add it to https://svelte.dev
|
https://github.com/sveltejs/svelte/issues/2448
|
https://github.com/sveltejs/svelte/pull/2454
|
3826d6cc436d2bb6f6e4921066f394c48efe6764
|
f5fd1d11566a2f2ae6b4f270cef828b7d564947d
| 2019-04-21T13:19:39Z |
javascript
| 2019-04-21T15:59:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,447 |
["site/content/blog/2018-12-26-svelte-css-in-js.md", "site/content/blog/2019-04-20-write-less-code.md", "site/content/examples/99-embeds/20181225-blog-svelte-css-in-js/App.svelte", "site/content/examples/99-embeds/20181225-blog-svelte-css-in-js/Hero.svelte", "site/content/examples/99-embeds/20181225-blog-svelte-css-in-js/meta.json", "site/content/examples/99-embeds/20181225-blog-svelte-css-in-js/styles.js", "site/content/examples/99-embeds/20190420-blog-write-less-code/App.svelte", "site/content/examples/99-embeds/20190420-blog-write-less-code/meta.json", "site/content/examples/99-embeds/meta.json", "site/src/routes/examples/index.json.js"]
|
Move embedded blog REPLs into unindexed examples
|
Step 1: Add some sort of mechanism for unindexed examples.
Step 2: Use these for the (currently) two blog posts with embedded REPLs.
|
https://github.com/sveltejs/svelte/issues/2447
|
https://github.com/sveltejs/svelte/pull/2524
|
fa3b7b0c6553f07881f8f7168299dcb428e536a0
|
5b453ed56930e09eeb446588875a7b07589cf4ac
| 2019-04-21T02:04:47Z |
javascript
| 2019-04-25T01:56:57Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,446 |
["src/compiler/compile/render_dom/wrappers/Element/index.ts", "src/compiler/compile/render_dom/wrappers/shared/add_actions.ts", "src/compiler/compile/render_dom/wrappers/shared/add_event_handlers.ts", "src/runtime/internal/utils.ts", "test/js/samples/action-custom-event-handler/expected.js", "test/js/samples/action/expected.js", "test/runtime/samples/apply-directives-in-order-2/_config.js", "test/runtime/samples/apply-directives-in-order-2/main.svelte"]
|
Apply directives in order
|
Currently, `on:input` event handlers are applied before any event handlers from actions or bindings, regardless of the order in which they're declared. This makes certain tasks (such as input masking) overly difficult.
Demos (which behave differently between Chrome and Firefox):
* https://svelte.dev/repl?version=3.0.0-beta.28&gist=94cb5d06d79c3f8b33541f789f37f82a
* https://svelte.dev/repl?version=3.0.0-beta.28&gist=d7c46929f96d9377a1890f474dcd1f07
A solution would be to consistently apply directives in the order in which they're declared. It'll require some rejiggering though.
|
https://github.com/sveltejs/svelte/issues/2446
|
https://github.com/sveltejs/svelte/pull/4156
|
709b4d30ff198501b3234293ff0225ea26e24e2c
|
52dbc882a7e7396e76d17be8fa5357b3be14e188
| 2019-04-20T22:59:17Z |
javascript
| 2019-12-24T16:53:18Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,443 |
["src/runtime/internal/await_block.ts", "src/runtime/internal/lifecycle.ts", "test/runtime/samples/context-in-await/Child.svelte", "test/runtime/samples/context-in-await/_config.js", "test/runtime/samples/context-in-await/main.svelte"]
|
Incorrect context in child component inside await
|
[REPL](https://svelte.dev/repl?version=3.0.0-beta.28&gist=28e8889cf4022f33868d6adba34e19d0)
|
https://github.com/sveltejs/svelte/issues/2443
|
https://github.com/sveltejs/svelte/pull/3442
|
860040a7fad9cff8297cb2a72dbba0be9a100279
|
415dc5f3a1c1526cb4ece43bce3061356988029d
| 2019-04-20T12:16:36Z |
javascript
| 2019-08-22T12:51:04Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,439 |
["site/src/routes/blog/[slug].json.js", "site/src/routes/blog/[slug].svelte"]
|
Bug. 502 for https://ru.svelte.dev/blog/... links
|
If I try to open https://ru.svelte.dev/blog/setting-up-your-editor or https://ru.svelte.dev/blog/svelte-for-new-developers I recieved "502 bad gateway"
|
https://github.com/sveltejs/svelte/issues/2439
|
https://github.com/sveltejs/svelte/pull/2442
|
0fe4195fbfc1a465320e74c70c598cd2191ff408
|
b1312175bc8a803b4a5236decfd7731b0186f8bb
| 2019-04-19T13:38:10Z |
javascript
| 2019-04-20T12:59:05Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,435 |
["src/compile/render-dom/index.ts", "test/runtime/samples/store-resubscribe-b/_config.js", "test/runtime/samples/store-resubscribe-b/main.svelte"]
|
Store resubscriptions not being generated
|
```html
<script>
import { writable } from 'svelte/store';
let foo = writable(0);
foo = writable(42);
</script>
{$foo}
```
This doesn't generate a resubscription upon the reassignment to `foo`. I believe this is a bug. I'm not sure what distinguishes the situation here from the one in #2014 (implemented in #2099), which has a passing unit test.
---
Adjacent issue: #2181. In addition to emitting appropriate resubscription code, perhaps in cases where `foo` is initialized to something we can tell is not a store, we could skip the (re)subscription call. I haven't thought this part all the way through.
|
https://github.com/sveltejs/svelte/issues/2435
|
https://github.com/sveltejs/svelte/pull/2619
|
1eca19f3717bcd12daf117f609321ddd572ab139
|
6240ed0b940409e0bac64f38a50a013abc262ff3
| 2019-04-17T20:23:28Z |
javascript
| 2019-05-04T03:59:47Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,430 |
["site/content/docs/02-template-syntax.md", "site/content/tutorial/04-logic/05-keyed-each-blocks/text.md", "src/compile/render-dom/wrappers/EachBlock.ts", "src/internal/keyed-each.js", "test/js/samples/each-block-keyed-animated/expected.js", "test/js/samples/each-block-keyed/expected.js", "test/runtime/samples/each-block-keyed-object-identity/_config.js", "test/runtime/samples/each-block-keyed-object-identity/main.svelte"]
|
Use a Map for keyed each blocks
|
Currently, if you have a keyed each block...
```html
{#each things as thing (thing.id)}
<div>{thing.name}</div>
{/each}
```
...Svelte creates a lookup object so that it can calculate a diff: https://github.com/sveltejs/svelte/blob/master/src/internal/keyed-each.js#L30-L31
It would be convenient in some cases if that was a map instead, so that you could key on an object rather than a string:
```html
{#each things as thing (thing)}
<div>{thing.name}</div>
{/each}
```
Would need to check that there are no dire performance implications from doing so.
|
https://github.com/sveltejs/svelte/issues/2430
|
https://github.com/sveltejs/svelte/pull/2433
|
9474631faecf26df15d799dafddf5fc8ec011d50
|
5d71b5138a8b9d4be6d8a074d9c27078b79c87c4
| 2019-04-16T21:23:57Z |
javascript
| 2019-04-18T01:35:32Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,429 |
["src/compile/render-dom/wrappers/shared/create_debugging_comment.ts", "test/runtime/samples/component-slot-empty-b/Nested.svelte", "test/runtime/samples/component-slot-empty-b/_config.js", "test/runtime/samples/component-slot-empty-b/main.svelte"]
|
named slots compiler bug
|
https://v3.svelte.technology/repl?version=3.0.0-beta.25&gist=2aed12b93004e5cca8dc9732373a12ec
https://v3.svelte.technology/repl?version=3.0.0-beta.25&gist=f92d0d582694b4454278821a9e47442d
Seems to arise when tag, which is marked with slot attribute, has no inner content.
|
https://github.com/sveltejs/svelte/issues/2429
|
https://github.com/sveltejs/svelte/pull/2431
|
e7f54679b53d46599290dc9c522519714011dd9a
|
519059f7d84c56d7b4bcb9615102a689c850b51d
| 2019-04-15T20:19:47Z |
javascript
| 2019-04-17T12:36:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,417 |
["src/compile/Component.ts", "src/compile/render-dom/index.ts", "test/custom-elements/index.js", "test/custom-elements/samples/no-tag-warning/_config.js", "test/custom-elements/samples/no-tag-warning/main.svelte", "test/custom-elements/samples/no-tag-warning/test.js", "test/custom-elements/samples/no-tag/_config.js", "test/custom-elements/samples/no-tag/main.svelte", "test/custom-elements/samples/no-tag/test.js"]
|
Custom elements without tags
|
This can be done as a non-breaking change post v3, but I wonder if it should be possible to compile a custom element without a tag — i.e. it doesn't add the
```js
customElements.define(tag, constructor);
```
line automatically, but instead leaves it up to the consumer.
|
https://github.com/sveltejs/svelte/issues/2417
|
https://github.com/sveltejs/svelte/pull/2749
|
3f68f97def7ab0bb6aca9fa7bfcd68d36bb99de1
|
0bf991070c6de4e385df49a44c32562ffeccd8f3
| 2019-04-14T19:21:29Z |
javascript
| 2019-05-15T22:19:38Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,402 |
["site/package-lock.json", "site/package.json"]
|
Bug with repeated outros
|
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.23&gist=3bd909392a6e05154b0360e22cf11a86). Trying to fix this on deadline... 😬 why do these things only ever surface on a Friday night
|
https://github.com/sveltejs/svelte/issues/2402
|
https://github.com/sveltejs/svelte/pull/5250
|
8f17d6c78c7de1af54b8eb5ccffc68c78708d26b
|
5d5a608d324abcae2250366a464fbc79f18fd7f4
| 2019-04-12T23:01:01Z |
javascript
| 2020-08-12T20:07:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,399 |
["src/compile/render-dom/index.ts", "test/js/samples/css-shadow-dom-keyframes/expected.js"]
|
Don't emit empty observedAttributes array
|
When generating custom elements, we only need to add this...
```js
static get observedAttributes() {
return [/* props */]
}
```
...if we actually have props. Otherwise, skip it.
|
https://github.com/sveltejs/svelte/issues/2399
|
https://github.com/sveltejs/svelte/pull/2406
|
7fcad18f2af843ab72d191549ba7945abf67e9b4
|
1de67e3c84746f70d1efba96119b46aef798647a
| 2019-04-12T17:45:04Z |
javascript
| 2019-04-13T23:46:29Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,395 |
["src/compile/render-dom/wrappers/InlineComponent/index.ts", "test/runtime/samples/deconflict-value/Widget.svelte", "test/runtime/samples/deconflict-value/_config.js", "test/runtime/samples/deconflict-value/main.svelte"]
|
v3: Reactive declaration breaks when using 'value' as variable name
|
Having a component binding to a variable called 'value', a reactive declaration based on 'value' does not work. Strangely, renaming the variable to anything else makes it work.
https://v3.svelte.technology/repl?version=3.0.0-beta.23&gist=57ad0a420702944995b757435513bd30
|
https://github.com/sveltejs/svelte/issues/2395
|
https://github.com/sveltejs/svelte/pull/2414
|
cad5bbafd48059d80086a7fdc6b75c7bb85c8fb6
|
08955da04c46cc3df0246ffe9b2a4fb9d199dc72
| 2019-04-11T08:52:07Z |
javascript
| 2019-04-14T18:28:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,393 |
["site/content/tutorial/05-events/03-event-modifiers/text.md"]
|
Clarify what capturing and bubbling are
|
The docs (https://v3.svelte.technology/tutorial/event-modifiers) talk about capturing and bubbling without explaining what they are. We don't need to do a deep dive on it, but should maybe link to some MDN docs or whatever that introduce those terms for people unfamiliar with them
|
https://github.com/sveltejs/svelte/issues/2393
|
https://github.com/sveltejs/svelte/pull/2405
|
ade0bc870aeff0f04ffee07680dc0a66ea358707
|
493e0813a223009bc80395c8fee1fbfa2c6c7d76
| 2019-04-10T17:56:58Z |
javascript
| 2019-04-13T18:54:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,391 |
["site/src/components/Repl/ReplWidget.svelte", "site/src/routes/repl/index.svelte"]
|
REPL version=local broken again
|
From what I can see, the issue is the `importScript('/repl/local/whatever')` call the REPL component attempts to make. The exception thrown in Chrome is `DOMException: Failed to execute 'importScripts' on 'WorkerGlobalScope': The URL '/repl/local/compiler.js' is invalid.`. This works fine when given an absolute URL, but I have no idea why.
The simplest solution is probably to pass in an absolute `svelteUrl` (e.g., `http://localhost:3000/repl/local`). This is slightly complicated by `location.origin` not being available on the server side. I don't know whether it matters what `svelteUrl` we pass to the component on the server. If not, we don't really need to worry about that.
|
https://github.com/sveltejs/svelte/issues/2391
|
https://github.com/sveltejs/svelte/pull/2392
|
961364fbc12c9d618796c501cd3d1feecda0a1ec
|
d4860ee4445b3c7347d1f28964ab26c820de9235
| 2019-04-09T21:48:26Z |
javascript
| 2019-04-11T13:31:23Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,389 |
["site/content/docs/01-component-format.md", "site/src/routes/docs/_GuideContents.svelte", "site/src/routes/docs/_sections.js", "site/src/routes/docs/index.svelte"]
|
Site: showing level 4 heading in the sidebar
|
It would be nice to show sections sub-subheadings in the sidebar if it this doesn't make it too tall or unusable in general.
|
https://github.com/sveltejs/svelte/issues/2389
|
https://github.com/sveltejs/svelte/pull/2390
|
010a784b4e4a3e6c875b11d8fc44245405d1460e
|
9a503f21b11997dd01342f30beea263b78cdfdcf
| 2019-04-09T19:35:28Z |
javascript
| 2019-04-12T16:15:44Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,387 |
["site/content/docs/02-template-syntax.md", "site/content/docs/03-run-time.md", "site/src/routes/docs/index.svelte", "site/src/utils/markdown.js"]
|
Site: code blocks formatting
|
Code blocks are used for many different purposes:
- level-4 headings containg code
- type signatures
- svelte's syntax
and they are all styled the same, which doesn't help readability.
For example:
<img width="1004" alt="Screenshot 2019-04-09 at 20 29 29" src="https://user-images.githubusercontent.com/1309648/55829312-4d84f000-5b06-11e9-9f0c-c24bd5481328.png">
|
https://github.com/sveltejs/svelte/issues/2387
|
https://github.com/sveltejs/svelte/pull/2388
|
b04cada2ddf616535f1ec38b30add240bf9180b5
|
961364fbc12c9d618796c501cd3d1feecda0a1ec
| 2019-04-09T19:31:04Z |
javascript
| 2019-04-11T13:28:14Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,380 |
["site/content/docs/03-run-time.md", "transition.mjs"]
|
Add a scale transition
|
This comes in useful quite often:
```js
function scale(node, params) {
const {
delay = 0,
duration = 400,
easing = cubicOut,
start = 0,
opacity = 0
} = params;
const sd = 1 - start;
const od = 1 - opacity;
const transform = (
node.style.transform ||
getComputedStyle(node).transform
).replace('none', '');
return {
delay,
duration,
easing,
css: (t, u) => `
transform: ${transform} scale(${1 - (sd * u)});
opacity: ${1 - (od * u)}
`
};
}
```
[Demo](https://v3.svelte.technology/repl?version=3.0.0-beta.22&gist=7740d49466ef523d907e810928b4758d). Would be a good addition to `svelte/transition`.
|
https://github.com/sveltejs/svelte/issues/2380
|
https://github.com/sveltejs/svelte/pull/2381
|
bc295b3a999ebb727445bd9c4075d572f4497131
|
cf095c4723e7b75a5ce660a4dfe366c32cf14c96
| 2019-04-08T21:57:24Z |
javascript
| 2019-04-09T15:08:08Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,377 |
["src/compiler/compile/render_dom/index.ts", "test/js/samples/capture-inject-dev-only/_config.js", "test/js/samples/capture-inject-dev-only/expected.js", "test/js/samples/capture-inject-dev-only/input.svelte", "test/js/samples/debug-empty/expected.js", "test/js/samples/debug-foo-bar-baz-things/expected.js", "test/js/samples/debug-foo/expected.js", "test/js/samples/debug-hoisted/expected.js", "test/js/samples/dev-warning-missing-data-computed/expected.js"]
|
Hooks for granular HMR support
|
Follow up to recent conversation on discord regarding v3 support for HMR.
Let me list out the steps we need for a successful hot reload, and then maybe we can discuss if the core needs to change, or whether we can just monkey-patch stuff.
I'm going to gloss over the component resolution part, as I think we already have that handled in the v2 HMR code.
These steps happen when a hot reload process starts:
### Step 1
**Get the current state of the component and keep it somewhere.**
Looks like `component.$$.ctx` gives us the whole state.
However, seems like it also returns computed properties, along with handlers and bindings?
Can we work out a way to just get the props (exported or otherwise)?
### Step 2
**Get the position in the DOM where the component is mounted**
We normally add a comment marker just above the component, and store a reference to that comment node.
I think this can be achieved by the compiler using `mount_component_dev`.
`mount_component_dev` would first call `mount_component`, and then store a reference to `target` and `anchor` on `$$`.
### Step 3
**Destroy the old component**
This can be easily achieved using `component.$destroy()`.
We don't need any changes to support this.
### Step 4
**Render updated component in place of the old component**
Here, we can mount the new component with `mount_component_dev`, using the `target` and `anchor` we collected on Step 2.
### Step 5
**Apply state from old component on to the new component**
This I'm not sure at all.
We need to find a way to set the state.
Then we need to ensure that all computeds are up to date.
Will calling `$$.update()` re-run the computations?
---
I'll need your help/direction on step 1 and step 5.
I think I can do a PR for Step 2 and Step 4
|
https://github.com/sveltejs/svelte/issues/2377
|
https://github.com/sveltejs/svelte/pull/3148
|
f06bc2fff7916fbeebfba6f94fa3341c8d89a8bf
|
1ca0b23d0def112eb4febae5cf0d71eb9ee549fb
| 2019-04-08T13:52:15Z |
javascript
| 2019-06-28T16:40:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,375 |
["site/src/routes/repl/embed.svelte"]
|
CSS-in-JS blog post is broken
|
I removed the `/repl/embed` route a while back, and the demo in https://v3.svelte.technology/blog/svelte-css-in-js no longer works.
Possible solutions:
* Reinstate the route (easiest)
* Add some kind of MDX equivalent, and author blog posts that aren't just static HTML in `src/routes/blog`
* Something something web components?
|
https://github.com/sveltejs/svelte/issues/2375
|
https://github.com/sveltejs/svelte/pull/2420
|
520f69f7cb7287a9b309466b315ae8672c73fd4a
|
6a9d7bf144ee4354a249836e496bb26f7e4c92b0
| 2019-04-08T10:52:52Z |
javascript
| 2019-04-15T03:04:45Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,369 |
["site/src/routes/docs/index.svelte"]
|
Site: sections anchors link to the root rather than to /docs
|
For example, in https://v3.svelte.technology/docs, the anchor of the section "BEFORE WE BEGIN" points to https://v3.svelte.technology/#introduction.
|
https://github.com/sveltejs/svelte/issues/2369
|
https://github.com/sveltejs/svelte/pull/2370
|
c44d495e2fb64329e3a2b7e8664e4f4dd665fce6
|
4d08c421658336a0e485cb9af6f6fea7fc18ff00
| 2019-04-07T14:39:01Z |
javascript
| 2019-04-07T18:14:13Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,365 |
["site/src/routes/docs/_sections.js", "site/src/routes/docs/index.svelte"]
|
API docs: nav indicator arrow disappears when in `####` headings
|
The indicator arrow along the side nav bar in https://v3.svelte.technology/docs disappears when you scroll through a `####` heading. These are currently present in the "<script>" and "svelte/motion" sections.
|
https://github.com/sveltejs/svelte/issues/2365
|
https://github.com/sveltejs/svelte/pull/2371
|
4d08c421658336a0e485cb9af6f6fea7fc18ff00
|
1dc787493a17ac86c37922090ea7e599a3c798ba
| 2019-04-06T13:34:03Z |
javascript
| 2019-04-07T18:14:57Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,359 |
["src/compile/render-dom/wrappers/InlineComponent/index.ts", "test/runtime/samples/component-slot-chained/Inner.svelte", "test/runtime/samples/component-slot-chained/Outer.svelte", "test/runtime/samples/component-slot-chained/_config.js", "test/runtime/samples/component-slot-chained/main.svelte"]
|
Props in nested slots don't update
|
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.22&gist=610d349ceb0469c13b9f375e3efc2163) - clicking toggle should update the output, which it doesn't.
This worked in alpha18.
|
https://github.com/sveltejs/svelte/issues/2359
|
https://github.com/sveltejs/svelte/pull/2416
|
3c840aad88f30a50ffb4830d413ad966869a0bf3
|
5fc2fab89662abbf98b2b66c9b1ca4a16c3bb623
| 2019-04-05T06:47:40Z |
javascript
| 2019-04-14T19:17:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,354 |
["src/compile/render-dom/wrappers/Slot.ts", "test/hydration/index.js", "test/hydration/samples/text-fallback/Nested.svelte", "test/hydration/samples/text-fallback/_after.html", "test/hydration/samples/text-fallback/_before.html", "test/hydration/samples/text-fallback/main.svelte"]
|
Slot fallback content shown when rehydrating
|
The example shows the bug: https://v3.svelte.technology/repl?version=3.0.0-beta.22&example=slot-fallbacks
edit:
So the issue is icw rehydration, where textcontent nodes in a slot are rendered before the content supplied through slot
I'm not sure how to reproduce this in a REPL env.
|
https://github.com/sveltejs/svelte/issues/2354
|
https://github.com/sveltejs/svelte/pull/2409
|
1de67e3c84746f70d1efba96119b46aef798647a
|
3f97558533b1753855e5a55f7351ea08394c7ed7
| 2019-04-03T12:07:57Z |
javascript
| 2019-04-13T23:46:52Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,348 |
["src/compile/render-dom/wrappers/Element/Attribute.ts", "test/runtime/samples/contextual-callback-b/_config.js", "test/runtime/samples/contextual-callback-b/main.svelte"]
|
Select disabled with statement cannot compile
|
select tag with disabled using statement cannot compile
```html
<option disabled="{taken.filter(f => f == m).length > 0}" value="{m}">
```
https://v3.svelte.technology/repl?version=3.0.0-beta.22&gist=0db8f1e9aedca24f8c87a2fdfaa1d6cf
current workaround is using function instead
```html
<script>
const used = (m) => taken.filter(f => f == m).length > 0;
</script>
<option disabled="{used(m)}" value="{m}">
```
|
https://github.com/sveltejs/svelte/issues/2348
|
https://github.com/sveltejs/svelte/pull/2349
|
c20ad223637f6253a2ed6696fd4b94f681496628
|
c853e44130dfd6ec4623d8cd0019f9506d5b7b5d
| 2019-04-01T16:31:03Z |
javascript
| 2019-04-06T12:40:26Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,347 |
["src/compile/Component.ts", "test/runtime/samples/prop-exports/_config.js", "test/runtime/samples/prop-exports/main.svelte"]
|
Multiple exports issue
|
> $$props is not defined
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.22&gist=946df0b8d4a309c20d8016faeecca131)
|
https://github.com/sveltejs/svelte/issues/2347
|
https://github.com/sveltejs/svelte/pull/2351
|
1f5293810f442bcd6aecc5525b98cf4ac73f0974
|
c20ad223637f6253a2ed6696fd4b94f681496628
| 2019-04-01T10:30:23Z |
javascript
| 2019-04-06T12:39:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,344 |
["site/README.md", "site/config.js", "site/package-lock.json", "site/package.json", "site/src/routes/docs/_sections.js", "site/src/utils/slug.js", "site/test/utils/slug.js"]
|
v3 site: error 500 in translated docs slugs
|
I'm translating the docs right now. Site can't be build when I use cyrillic in `*** headers`, because this line:
```javascript
.replace(/[^a-zA-Z0-9]+/g, '-')
```
at https://github.com/sveltejs/svelte/blob/master/site/src/routes/docs/_sections.js#L105
... deletes all signs from the slug and causes 500 error.
`a-zA-Z` is a pattern for english letters only. The `\p{Letter}` could be used instead, but not all possible letters are allowed to be in URL.
|
https://github.com/sveltejs/svelte/issues/2344
|
https://github.com/sveltejs/svelte/pull/2404
|
85d3f769c71bd3167542713ea765a398dd51a2c9
|
787700571ecd24cdac57dcefe4657d509d99af05
| 2019-03-30T10:59:29Z |
javascript
| 2019-04-21T16:11:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,342 |
["site/package-lock.json", "site/package.json"]
|
Reactive declaration not firing
|
[REPL](https://svelte.dev/repl/f1dc27d59e5658852f25cdba62e12d31?version=3.9.0). Using slider `a` reports changes to both `a` and `b`, but using slider `b` only reports changes to `b`
|
https://github.com/sveltejs/svelte/issues/2342
|
https://github.com/sveltejs/svelte/pull/5250
|
8f17d6c78c7de1af54b8eb5ccffc68c78708d26b
|
5d5a608d324abcae2250366a464fbc79f18fd7f4
| 2019-03-30T00:30:53Z |
javascript
| 2020-08-12T20:07:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,340 |
["src/compile/nodes/Element.ts", "test/runtime/samples/svg-foreignobject-namespace/_config.js"]
|
fix foreignObject namespace stuff
|
So this is a fun thing to find out on deadline on a Friday afternoon...
I messed up #2298. The `<foreignObject>` element should still have a `namespaceUri` of http://www.w3.org/2000/svg; its *children* should have the http://www.w3.org/1999/xhtml namespace. Ugh.
|
https://github.com/sveltejs/svelte/issues/2340
|
https://github.com/sveltejs/svelte/pull/2372
|
1dc787493a17ac86c37922090ea7e599a3c798ba
|
d9dff613730d2a221d4fd7e47661893c0e65b7c8
| 2019-03-29T19:58:38Z |
javascript
| 2019-04-08T11:49:07Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,339 |
["src/compile/nodes/Binding.ts", "src/compile/nodes/shared/Node.ts", "src/compile/render-dom/wrappers/Element/Binding.ts", "src/compile/render-ssr/handlers/Element.ts", "test/server-side-rendering/samples/bindings-readonly/_expected.html", "test/server-side-rendering/samples/bindings-readonly/main.svelte"]
|
bind:clientWidth shows up in SSR
|
it shouldn't
|
https://github.com/sveltejs/svelte/issues/2339
|
https://github.com/sveltejs/svelte/pull/2877
|
338f5d18351111351971b6a08b03a7df082c5f6e
|
a7d4fe1f6b040121f032d4953fdbbdb0f53b98bb
| 2019-03-29T19:45:26Z |
javascript
| 2019-05-27T09:48:27Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,337 |
["site/content/docs/04-compile-time.md"]
|
Site v3 Api Docs - SASS example typo
|
2 hours ago in [this link](https://v3.svelte.technology/docs) was the new version of docs, now is older. I'm not sure if it's relevant now.
There is SASS example that contains a few typos. +`async ` -`)`
```javascript
const svelte = require('svelte/compiler');
const sass = require('node-sass');
const { dirname } = require('path');
const { code, dependencies } = svelte.preprocess(source, {
style: async ({ content, attributes, filename }) => {
// only process <style lang="sass">
if (attributes.lang !== 'sass') return;
const { css, stats } = await new Promise((resolve, reject) => sass.render({
file: filename,
data: content,
includePaths: [
dirname(filename),
],
}, (err, result) => {
if (err) reject(err);
else resolve(result);
}));
return {
code: css.toString(),
dependencies: stats.includedFiles
};
}
}, {
filename: 'App.svelte'
});
```
|
https://github.com/sveltejs/svelte/issues/2337
|
https://github.com/sveltejs/svelte/pull/2346
|
a68abb8a9a2cb139e8256fdb8ab646e2826bf301
|
b161725a51b0c58e9a6a1f36e960756d0c72fd2a
| 2019-03-29T13:53:58Z |
javascript
| 2019-04-02T18:43:40Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,330 |
["site/content/tutorial/08-stores/03-readable-stores/app-a/stores.js", "site/content/tutorial/08-stores/03-readable-stores/app-b/stores.js", "site/content/tutorial/08-stores/03-readable-stores/text.md"]
|
Tutorial: Outdated argument order for readable stores
|
The tutorial part about [readable stores](https://v3.svelte.technology/tutorial/readable-stores) is currently broken due to the argument order change in #2310.
|
https://github.com/sveltejs/svelte/issues/2330
|
https://github.com/sveltejs/svelte/pull/2331
|
9e4775704a8d65af2f9475b4ee6585bce5215cc9
|
edd92cf8ea945e4ca3f7d05e4395d33afb868677
| 2019-03-28T10:55:06Z |
javascript
| 2019-03-29T12:28:41Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,329 |
[".gitignore", "site/scripts/get-contributors.js", "site/src/routes/index.svelte"]
|
Compress github avatars on homepage
|
The biggest contributor to the size of the homepage is contributor avatars. At a bare minimum we should shrink/compress the images when we fetch the contributors list. More advanced solutions involve lazy loading and spritemaps.
|
https://github.com/sveltejs/svelte/issues/2329
|
https://github.com/sveltejs/svelte/pull/2368
|
7853d5af1337b2175baf26900e856b06902d21d7
|
92b66a313e1e27e4e3667ac35e3a9ea6851915c8
| 2019-03-28T02:12:14Z |
javascript
| 2019-04-07T14:03:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,325 |
["src/compile/render-dom/wrappers/EachBlock.ts", "test/runtime/samples/array-literal-spread-deopt/_config.js", "test/runtime/samples/array-literal-spread-deopt/main.svelte"]
|
Each block with generic iterable syntax creating only first element
|
This code (v3-beta21) shows only the first item of the array, instead of the 3 items:
```html
<script>
let cats = ['Keyboard Cat', 'Maru', 'Henri The Existential Cat'];
</script>
<ul>
{#each [...cats] as cat}
<li>{cat}</li>
{/each}
</ul>
```
The [tutorial](https://v3.svelte.technology/tutorial/each-blocks) says this syntax should work, and it allows to use the each block with generic iterables.
Here's a REPL: https://v3.svelte.technology/repl?version=3.0.0-beta.21&gist=bb2c3edd39f45eee6fb40599a41a508a
|
https://github.com/sveltejs/svelte/issues/2325
|
https://github.com/sveltejs/svelte/pull/2326
|
143117054a63c1eeefa0edd7fb13ae3fcf5c88ec
|
eb2f0cc245b0e31194edc6317f53f16d50eab269
| 2019-03-27T21:36:52Z |
javascript
| 2019-03-29T12:46:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,313 |
["site/src/routes/repl/index.svelte"]
|
REPL: Gist loading race conditions
|
There appears to be a race condition involved in loading gists - sometimes loading a gist will instead display the 'hello world' example in the editor, or will flash the correct gist briefly before switching to hello world while still displaying the compiled version of the gist.
|
https://github.com/sveltejs/svelte/issues/2313
|
https://github.com/sveltejs/svelte/pull/2315
|
d1536b21a2dc8457941e1321aeddf288f0b1d3cd
|
ef40a720a3f4115ca7de3189140a33bd66601abf
| 2019-03-25T16:36:28Z |
javascript
| 2019-03-25T20:21:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,306 |
["site/src/routes/repl/index.svelte"]
|
REPL zen mode broken
|
It hides the REPL controls beneath the nav, instead of hiding the nav
|
https://github.com/sveltejs/svelte/issues/2306
|
https://github.com/sveltejs/svelte/pull/2311
|
f6f06b3cf508baa50775a8222f2e8c2d4f5860fd
|
70c8d3e24adebc25a76aa063cc018a9d9d4ed15b
| 2019-03-24T16:26:04Z |
javascript
| 2019-03-25T20:24:03Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,305 |
["src/compile/nodes/shared/Expression.ts", "test/runtime/samples/event-handler-each-context-invalidation/_config.js", "test/runtime/samples/event-handler-each-context-invalidation/main.svelte"]
|
Wrong invalidate code generated for contextual event handlers
|
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=f2023d68b46afe40aa6bdc12373349f3). Clicking on the `<li>` elements should invalidate `todos`, not `todo`, but the wrong code is generated:
```diff
function click_handler({ todo }) {
const $$result = todo.done = !todo.done;
- $$invalidate('todo', todo);
+ $$invalidate('todos', todos);
return $$result;
}
```
|
https://github.com/sveltejs/svelte/issues/2305
|
https://github.com/sveltejs/svelte/pull/2307
|
fa47f764473ad1c8580171fa7e1b6e0251ad31f6
|
d1536b21a2dc8457941e1321aeddf288f0b1d3cd
| 2019-03-24T15:50:37Z |
javascript
| 2019-03-25T11:50:10Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,303 |
["src/compile/render-dom/wrappers/Slot.ts", "test/runtime/samples/transition-js-slot/Nested.svelte", "test/runtime/samples/transition-js-slot/_config.js", "test/runtime/samples/transition-js-slot/main.svelte"]
|
Slotted transitions don't work
|
Looks like we don't call `.i(...)` and `.o(...)` on `<slot>` elements: https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=0b5157d7b34982fcb52f72e17a845acf
|
https://github.com/sveltejs/svelte/issues/2303
|
https://github.com/sveltejs/svelte/pull/2309
|
45cd9605680f931a35b4567abf73c4c9236ccc58
|
a432f73cda1dbd288a39a38d50be61c7cbdbe4e5
| 2019-03-23T15:31:49Z |
javascript
| 2019-03-25T20:24:48Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,301 |
["src/compile/nodes/Binding.ts", "test/validator/samples/binding-let/errors.json", "test/validator/samples/binding-let/input.svelte"]
|
Two-way binding to `let:` var throws compile-time exception
|
```html
<script>
let Foo;
</script>
<Foo let:bar>
<input bind:value={bar}>
</Foo>
```
Throws a compile-time exception, attempting to access a property of something that's undefined.
I haven't put much thought into this, but it seems like two-way binding with something from `let:` might be difficult or impossible, in which case we should just have a better error here.
|
https://github.com/sveltejs/svelte/issues/2301
|
https://github.com/sveltejs/svelte/pull/2408
|
079a1ba2762c3dd98f5d55b6d91ec4ece837f68b
|
7fcad18f2af843ab72d191549ba7945abf67e9b4
| 2019-03-23T12:14:29Z |
javascript
| 2019-04-13T23:46:16Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,300 |
["src/compile/nodes/Element.ts"]
|
Svelte3 bind:checked and radio input
|
Hello!
I've got the compile time error with the `checked` binding:
>(svelte plugin) ValidationError: 'checked' binding can only be used with `<input type="checkbox">`
But what about `type="radio"` ? `checked` is valid attribute for it, please check: https://developer.mozilla.org/ru/docs/Web/HTML/Element/Input/radio
It make sense when we have several radio inputs with the same name.
Thanks!
PS svelte3 is awesome :)
|
https://github.com/sveltejs/svelte/issues/2300
|
https://github.com/sveltejs/svelte/pull/2302
|
88366b9ed2d5bc9b0b300116f72117a47ec394c2
|
1a2827ed32f138bbc7599291c11a1a403fed3738
| 2019-03-23T10:32:39Z |
javascript
| 2019-03-25T01:41:02Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,298 |
["src/compile/nodes/Element.ts", "test/runtime/samples/svg-foreignobject-namespace/_config.js", "test/runtime/samples/svg-foreignobject-namespace/main.svelte", "test/validator/samples/svg-child-component-undeclared-namespace/input.svelte", "test/validator/samples/svg-child-component-undeclared-namespace/warnings.json"]
|
Default to XHTML namespace inside <foreignObject>
|
This code will result in two visible paragraphs if pasted into an `about:blank` console:
```js
document.body.innerHTML = `<svg>
<!-- both should be visible -->
<foreignObject x=10 y=10 width=100 height=100>
<p>some text</p>
</foreignObject>
<foreignObject x=10 y=40 width=100 height=100>
<p xmlns="http://www.w3.org/1999/xhtml">some more text</p>
</foreignObject>
</svg>`;
```
The same code in a Svelte document does not; it thinks the first `<p>` element is [still in the SVG namespace](https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=a78548406dfc46288d76c7f9260cb311).
|
https://github.com/sveltejs/svelte/issues/2298
|
https://github.com/sveltejs/svelte/pull/2319
|
d637211e3eb53fdbb437b1cae1fbc40b51e00d92
|
33bf4a40db6732f513b1b72ea6132c3fd213fb76
| 2019-03-22T19:51:36Z |
javascript
| 2019-03-27T12:18:56Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,296 |
["store.mjs", "test/store/index.js"]
|
Should readable and writable have more similar signatures?
|
The writable signature is:
```js
store = writable(value: any, start?: () => () => void);
```
The readable signature is:
```js
store = readable(start: (set: (value: any) => void)) => () => void, value?: any);
```
In other words, the arguments are reversed, and the second argument to `writable` (if provided) doesn't take and `set` argument. (The mismatch is because `writable` didn't have a second argument when it was first designed, but it turns out to be useful.)
Perhaps it'd be more logical if it was
```js
store = writable(value: any, start?: (set: (value: any) => void)) => () => void);
store = readable(value: any, start: (set: (value: any) => void)) => () => void);
```
— in other words, the only difference between them is that `start` is optional for `writable` stores.
It would be a nuisance to change now, but more of a nuisance post-v3.
|
https://github.com/sveltejs/svelte/issues/2296
|
https://github.com/sveltejs/svelte/pull/2310
|
70c8d3e24adebc25a76aa063cc018a9d9d4ed15b
|
45cd9605680f931a35b4567abf73c4c9236ccc58
| 2019-03-22T12:33:26Z |
javascript
| 2019-03-25T20:24:30Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,295 |
["src/compile/Component.ts", "src/compile/nodes/Binding.ts", "test/validator/samples/binding-invalid-value-global/errors.json", "test/validator/samples/binding-invalid-value-global/input.svelte", "test/validator/samples/undefined-value-global/input.svelte", "test/validator/samples/undefined-value-global/warnings.json"]
|
Shouldn't allow binding to globals referenced in script
|
```html
<script>
console.log(foo);
</script>
<input bind:value={foo}>
```
Binding to `foo` - a global - shouldn't be allowed, but the compiler allows this if it has been referenced in the script.
|
https://github.com/sveltejs/svelte/issues/2295
|
https://github.com/sveltejs/svelte/pull/2321
|
33bf4a40db6732f513b1b72ea6132c3fd213fb76
|
a59cd36a399ed93a42745f840d8c799af45e6847
| 2019-03-22T09:01:37Z |
javascript
| 2019-03-27T12:21:48Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,294 |
["src/compile/Component.ts", "test/vars/samples/actions/_config.js", "test/vars/samples/actions/input.svelte", "test/vars/samples/animations/_config.js", "test/vars/samples/animations/input.svelte", "test/vars/samples/transitions/_config.js", "test/vars/samples/transitions/input.svelte"]
|
`var.referenced` false for imported action/transition/animation
|
```html
<script>
import foo from 'foo';
</script>
<div use:foo/>
```
I haven't investigated whether this affects other things as well, but `vars[0].referenced` here should be true.
|
https://github.com/sveltejs/svelte/issues/2294
|
https://github.com/sveltejs/svelte/pull/2312
|
415da7dade1e007562f4d35a11230fe532f6b954
|
f6f06b3cf508baa50775a8222f2e8c2d4f5860fd
| 2019-03-22T08:35:47Z |
javascript
| 2019-03-25T20:23:42Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,291 |
["src/utils/names.ts", "test/runtime/samples/slot-names/Nested.svelte", "test/runtime/samples/slot-names/_config.js", "test/runtime/samples/slot-names/main.svelte"]
|
Named slots is trimming non word chars before compare names
|
(version: 3.0.0-beta.20)
If this is a Svelte feature, then it can lead to implicit errors in the application.
Just add "_-123" to the start or end of slot name in this example, and you should see that changed nothing:
https://v3.svelte.technology/repl?version=3.0.0-beta.20&example=named-slots
|
https://github.com/sveltejs/svelte/issues/2291
|
https://github.com/sveltejs/svelte/pull/2304
|
a27a43076e606b8803858475f2993f1f0718ee83
|
33914410aa985e0049bf63b9bcb8df44a3125f15
| 2019-03-22T03:53:22Z |
javascript
| 2019-03-25T14:05:38Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,285 |
["src/compile/render-dom/index.ts", "test/runtime/samples/reactive-values-fixed/_config.js", "test/runtime/samples/reactive-values-fixed/main.svelte"]
|
Reactive declarations can not depend on const "variables" (svelte v3)
|
This is in svelte version 3.
Reactive declarations can not depend on const "variables", even though the variable is declared as `const`, its properties can still change.
```html
// This works
<script>
let obj = {
prop: 10
}
$: reactiveDecl = obj.prop;
</script>
<h1>{reactiveDecl}</h1>
```
vs
```html
// Error "Invalid reactive declaration — must depend on local state ..."
<script>
const obj = {
prop: 10
}
$: reactiveDecl = obj.prop;
</script>
<h1>{reactiveDecl}</h1>
```
|
https://github.com/sveltejs/svelte/issues/2285
|
https://github.com/sveltejs/svelte/pull/2631
|
cfb22e4a10abddcd3c387d4b00d6d464b836e36d
|
1eca19f3717bcd12daf117f609321ddd572ab139
| 2019-03-21T18:49:13Z |
javascript
| 2019-05-04T03:44:13Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,284 |
["src/parse/state/tag.ts", "test/runtime/samples/dynamic-component-ref/main.svelte"]
|
Order of attributes in <svelte:component>
|
Very small issue:
```xml
<svelte:component this={ Box } bind:this={ box } />
```
Works, but
```xml
<svelte:component bind:this={ box } this={ Box } />
```
Throws `Cannot read property 'length' of undefined`
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=5ac9aa28894f9463da48c652425f1235)
|
https://github.com/sveltejs/svelte/issues/2284
|
https://github.com/sveltejs/svelte/pull/2286
|
99f041900b60ed5cc75a9d5f735387bd8a21b6ff
|
da1e061cdab3c4fde0d35af53d69f5ffa146f0e8
| 2019-03-21T14:32:41Z |
javascript
| 2019-03-25T01:42:17Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,281 |
["src/runtime/internal/Component.ts", "src/runtime/internal/scheduler.ts", "test/runtime/samples/lifecycle-render-order-for-children/Item.svelte", "test/runtime/samples/lifecycle-render-order-for-children/_config.js", "test/runtime/samples/lifecycle-render-order-for-children/main.svelte", "test/runtime/samples/lifecycle-render-order-for-children/order.js"]
|
onMount triggers in reverse order for siblings
|
<!--
Thanks for raising an issue! (For *questions*, we recommend instead using https://stackoverflow.com and adding the 'svelte' tag.)
To help us help you, if you've found a bug please consider the following:
* If you can demonstrate the bug using https://svelte.technology/repl, please do.
* If that's not possible, we recommend creating a small repo that illustrates the problem.
* Make sure you include information about the browser, and which version of Svelte you're using
Reproductions should be small, self-contained, correct examples – http://sscce.org.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:
<details>
<summary>Stack trace</summary>
Stack trace goes here...
</details>
-->
When rendering a list of components (1, 2, 3) they trigger their respective `onMount`s in the opposite order (3, 2, 1). I think this is unintuitive.
React would trigger these events in order (1, 2, 3), but I don't know if that affects your decision process.
Anyways, here's a repro: https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=5f85713af12be6cfc5da9f2b812c57cd
|
https://github.com/sveltejs/svelte/issues/2281
|
https://github.com/sveltejs/svelte/pull/2752
|
135f7b649378a363c2efd889ace10e2d39e2c3c0
|
a9193fd9d63047312d8b76022ad5e75430fd2a32
| 2019-03-20T21:32:58Z |
javascript
| 2019-05-30T12:18:02Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,278 |
["src/compile/Component.ts", "test/runtime/samples/function-hoisting/_config.js", "test/runtime/samples/function-hoisting/main.svelte"]
|
Parsing bug in v3, leaving out functions
|
https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=5080ed860d3e91883f8070bc6e3ab21c
In this particular situation, the `getTextChange` function is not included in the compiled bundle, causing an error. If the code on line 46-51 is uncommented, or if the function is moved above `onMutate`, then it is included again. I'm not sure the underlying cause of this issue, but this is a simplified version of the code I discovered this issue in.
You can verify the issue by typing into the grey box on the right and seeing the console errors.
```
Uncaught ReferenceError: getTextChange is not defined
at MutationObserver.onMutate
```
|
https://github.com/sveltejs/svelte/issues/2278
|
https://github.com/sveltejs/svelte/pull/2363
|
b161725a51b0c58e9a6a1f36e960756d0c72fd2a
|
7d4a36af2d46df6074c635908abf73306c64aedd
| 2019-03-19T23:20:34Z |
javascript
| 2019-04-06T11:52:57Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,271 |
["site/src/components/Repl/index.svelte"]
|
Click on an error message doesn't change source code of the component in the REPL
|
See the [REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=38358f046fe07e5d0981cdde99d203df). When I click on the error message tab is changing to `Component.svelte`, but source code is not.
|
https://github.com/sveltejs/svelte/issues/2271
|
https://github.com/sveltejs/svelte/pull/2273
|
62701f57167b492fc2c9b0fe11b8da9c2d619a9f
|
9203bfac9aa9e5501a0d5a6990e515e5f3fca079
| 2019-03-18T22:26:47Z |
javascript
| 2019-03-19T13:26:23Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,268 |
["site/package-lock.json", "site/package.json"]
|
$props is not defined
|
Follow-up to #2264 — this now works...
https://v3.svelte.technology/repl?version=3.0.0-beta.20&gist=36b8d15735c76cd57e3d253de1aada04
...but there's a warning about `$props` is not defined
|
https://github.com/sveltejs/svelte/issues/2268
|
https://github.com/sveltejs/svelte/pull/5250
|
8f17d6c78c7de1af54b8eb5ccffc68c78708d26b
|
5d5a608d324abcae2250366a464fbc79f18fd7f4
| 2019-03-18T20:55:08Z |
javascript
| 2020-08-12T20:07:36Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,264 |
["src/compile/render-dom/index.ts", "test/runtime/samples/props-reactive/Nested.svelte", "test/runtime/samples/props-reactive/_config.js", "test/runtime/samples/props-reactive/main.svelte"]
|
Invalid code is generated with $$props in reactive statement
|
REPL example: https://v3.svelte.technology/repl?version=3.0.0-beta.19&gist=36b8d15735c76cd57e3d253de1aada04
|
https://github.com/sveltejs/svelte/issues/2264
|
https://github.com/sveltejs/svelte/pull/2266
|
c06d9f352cf0bdffe7b7a21519c8dc720b623170
|
beeaa3d09bea4db5a5fd12962d15b591836d63bc
| 2019-03-18T18:23:01Z |
javascript
| 2019-03-18T20:22:50Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,262 |
["src/compile/render-dom/index.ts", "test/js/samples/computed-collapsed-if/expected.js", "test/js/samples/debug-empty/expected.js", "test/js/samples/debug-foo-bar-baz-things/expected.js", "test/js/samples/debug-foo/expected.js", "test/js/samples/dev-warning-missing-data-computed/expected.js", "test/runtime/samples/prop-accessors/_config.js", "test/runtime/samples/prop-accessors/main.svelte"]
|
`accessors: false` should only exclude props
|
Compiling components with the default of `accessors: false` currently also excludes getters for `const`s and also some `function`s. Only `export let`s and `export var`s should be excluded - everything else should still have a getter (but no setter).
Relatedly, runtime unit tests are currently all compiling with `accessors: true` unless overridden in the specific test (which does not seem to happen in any existing tests) - which will certainly conceal bugs in this area.
|
https://github.com/sveltejs/svelte/issues/2262
|
https://github.com/sveltejs/svelte/pull/2263
|
621c13702d792f351a78f94094a4f1a0229ee578
|
c06d9f352cf0bdffe7b7a21519c8dc720b623170
| 2019-03-18T16:57:09Z |
javascript
| 2019-03-18T20:21:00Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,254 |
["src/compile/render-dom/wrappers/Window.ts", "test/js/samples/bind-online/expected.js", "test/js/samples/bind-online/input.svelte"]
|
bind:online doesn't work
|
Looks like some old v2 code somehow survived the last few months
https://v3.svelte.technology/repl?version=3.0.0-beta.19&gist=506f8f04531e31b90576672d30dfdf7f
|
https://github.com/sveltejs/svelte/issues/2254
|
https://github.com/sveltejs/svelte/pull/2260
|
21d56c9ee32f0a9b76e5e522943c818c3e36f9d3
|
51ab376de88ca21c498b5cf9528e300c48eaacb3
| 2019-03-18T02:50:14Z |
javascript
| 2019-03-18T15:03:07Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,253 |
["src/compile/Component.ts", "src/compile/render-dom/index.ts", "test/runtime/samples/renamed-instance-exports/_config.js", "test/runtime/samples/renamed-instance-exports/main.svelte"]
|
Renamed instance exports generates wrong/invalid code
|
```html
<script>
const foo = 42;
export { foo as bar };
</script>
```
This should create a component whose instances have a `bar` property with the value 42, but this code is generated instead:
```javascript
...
function instance($$self, $$props, $$invalidate) {
const bar:foo = 42;
return { foo };
}
...
```
The `bar:` should be on the return value, not the declaration.
---
```html
<svelte:options accessors/>
<script>
let foo = 42;
export { foo as bar };
</script>
```
Similarly, this should create a component with a writable prop `bar` - but setting the prop doesn't work, because the code that's generated includes:
```javascript
...
set bar(foo) {
this.$set({ foo });
flush();
}
...
```
We need to be setting `{ bar }` here (the actual name of the prop) and not `{ foo }`.
|
https://github.com/sveltejs/svelte/issues/2253
|
https://github.com/sveltejs/svelte/pull/2261
|
51ab376de88ca21c498b5cf9528e300c48eaacb3
|
3e2366d36046484a6ec68647377cf72e842e80cb
| 2019-03-18T01:06:38Z |
javascript
| 2019-03-18T17:21:25Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,243 |
["site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/app-a/App.svelte", "site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/app-b/App.svelte", "site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/text.md"]
|
Tutorial: Mention reactive assignments and mutation
|
This might already be mentioned somewhere, but if it is I missed it. The tutorial should mention that calling methods on objects which mutate them does not trigger any reactive updates, and that we have the `foo = foo;` escape hatch for this,
|
https://github.com/sveltejs/svelte/issues/2243
|
https://github.com/sveltejs/svelte/pull/2424
|
c5b401254cc70d2ba8f62f0e546c818af8654cd6
|
98dc8adc5df6f5b2971bc08d23eaeb433f0de91c
| 2019-03-17T14:31:50Z |
javascript
| 2019-04-15T15:43:09Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,236 |
["src/compile/Component.ts", "test/runtime/samples/prop-const/Nested.svelte", "test/runtime/samples/prop-const/_config.js", "test/runtime/samples/prop-const/main.svelte"]
|
Components allow const/class/function exports to be overridden
|
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.17&gist=9f60dacc2f84e79122692cf2ccd717c6). This code...
```html
<script>
export let a = 1;
export const b = 2;
</script>
```
...results in this:
```js
let { a = 1 } = $$props;
const { b = 2 } = $$props;
```
That's wrong — it should be this instead:
```js
let { a = 1 } = $$props;
const b = 2;
```
|
https://github.com/sveltejs/svelte/issues/2236
|
https://github.com/sveltejs/svelte/pull/2245
|
c2413ae9acbc0f5c1091d472a3c89d4ec1f778c5
|
81d33a2fb03e49687f3a5b856f9e53e1f5177b69
| 2019-03-16T19:56:14Z |
javascript
| 2019-03-17T18:53:03Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,221 |
["site/src/server.js"]
|
Bindings This not showing on Firefox
|
Steps:
1. Open https://v3.svelte.technology/tutorial/bind-this
2. Click **SHOW ME** button
Result:
- Firefox 65.0.2: **nothing showed**
- Waterfox 56.2.7: new Svelte logo **shown**
- Chrome 72: new Svelte logo **shown**
This might be related/unrelated, but opening this sample made Chrome eating up my resources.
|
https://github.com/sveltejs/svelte/issues/2221
|
https://github.com/sveltejs/svelte/pull/2267
|
3e2366d36046484a6ec68647377cf72e842e80cb
|
621c13702d792f351a78f94094a4f1a0229ee578
| 2019-03-15T03:07:57Z |
javascript
| 2019-03-18T19:37:58Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,220 |
["site/src/components/Repl/Output/Viewer.svelte"]
|
Global REPL styles aren't removed between tutorial chapters
|
If you go to https://v3.svelte.technology/tutorial/svelte-window-bindings, it adds `:global(body)` styles which then aren't removed if you navigate to another chapter, resulting in this sort of thing:
<img width="608" alt="Screen Shot 2019-03-14 at 20 04 50" src="https://user-images.githubusercontent.com/1162160/54399372-74c9d800-4694-11e9-99ce-47c28003ec8d.png">
|
https://github.com/sveltejs/svelte/issues/2220
|
https://github.com/sveltejs/svelte/pull/2269
|
2fc07c6dfb652076d3d91287ae62018fdd3c0715
|
28f91b5681ea5a4fba4aa6ddc7771a1f577ee07e
| 2019-03-15T00:05:11Z |
javascript
| 2019-03-18T21:20:11Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,212 |
["src/compile/render-dom/Block.ts"]
|
Components named 'Create' fail confusingly
|
I was recieving an error `(intermediate value).$$ is undefined` and it turns out this is because I named my component 'Create'. I'm guessing this clashes with an internal Create class or function or a javascript keyword (I don't remember it being one)?
This should probably give a descriptive error (I don't know if it could be renamed?). This was incredibly confusing and difficult to work out what was going on. Renaming fixed it.
[REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.15&gist=fd7c5335ecdc7fcdd090925561eefd9b)
|
https://github.com/sveltejs/svelte/issues/2212
|
https://github.com/sveltejs/svelte/pull/2213
|
3ef1c10190c27d3ae4211a8037087dc29e6ac658
|
916156b05fe4b442d5be73528ab0c299a6b06305
| 2019-03-12T11:17:01Z |
javascript
| 2019-03-15T23:38:49Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,211 |
["site/src/components/Repl/Input/ComponentSelector.svelte", "site/src/components/Repl/Output/CompilerOptions.svelte", "site/src/components/Repl/Output/index.svelte", "site/src/components/Repl/index.svelte"]
|
REPL: Compilation only re-triggered on file edits
|
- adding a new file should re-trigger bundling (in case something was attempting to import it and failing)
- changing Svelte compiler output options should immediately re-trigger compilation of that file
|
https://github.com/sveltejs/svelte/issues/2211
|
https://github.com/sveltejs/svelte/pull/2248
|
81d33a2fb03e49687f3a5b856f9e53e1f5177b69
|
7a297afa30a0e744af132c7cbf239acd8752e453
| 2019-03-11T18:45:59Z |
javascript
| 2019-03-17T21:30:06Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,208 |
["site/static/workers/bundler.js"]
|
REPL import resolution issues
|
Having an `import` in a file in the v3 REPL with a relative path to a file that doesn't exist displays an error "It looks like you're using Rollup in a non-Node.js environment. This means you must supply a plugin with custom resolveId and load functions" (which comes from Rollup) instead of the more helpful "Could not resolve './foo' from ./bar" that the v2 REPL displays.
|
https://github.com/sveltejs/svelte/issues/2208
|
https://github.com/sveltejs/svelte/pull/2210
|
e2a71cfce46c2f7810ef6830c96bdefd5b58da07
|
3ef1c10190c27d3ae4211a8037087dc29e6ac658
| 2019-03-11T11:23:32Z |
javascript
| 2019-03-15T23:38:12Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,184 |
["src/compile/render-dom/index.ts", "test/js/samples/dont-invalidate-this/expected.js", "test/js/samples/dont-invalidate-this/input.svelte"]
|
Assigning to a property of `this` in a function triggers invalidation of “undefined”
|
[Minimal example:](https://v3.svelte.technology/repl?version=3.0.0-beta.11&gist=1ad69afee5b85aa775178b32e033494a)
```html
<script>
function make_uppercase() {
this.value = this.value.toUpperCase();
}
</script>
<input on:input={make_uppercase}>
```
In that function, `this` will be the element the event was fired on.
Incorrect generated JS:
```js
function make_uppercase() {
this.value = this.value.toUpperCase(); $$invalidate('undefined', undefined);
}
```
There should be no `$$invalid('undefined', undefined);`.
A workaround: use `event.currentTarget` instead of `this`.
|
https://github.com/sveltejs/svelte/issues/2184
|
https://github.com/sveltejs/svelte/pull/2185
|
333b933837b9659643b08d9cc352e63226a1c1db
|
06040d3513b326570b2c279ac54b7146708f8c53
| 2019-03-09T13:24:06Z |
javascript
| 2019-03-09T19:02:46Z |
closed
|
sveltejs/svelte
|
https://github.com/sveltejs/svelte
| 2,182 |
["src/internal/ssr.js", "test/runtime/samples/context-api-b/Leaf.svelte", "test/runtime/samples/context-api-b/Nested.svelte", "test/runtime/samples/context-api-b/_config.js", "test/runtime/samples/context-api-b/main.svelte"]
|
Sibling context is read instead of parent context in SSR
|
The following example works great when rendered in the browser, where each `Tab` takes the label from its parent `Pane` component through context and adds it to its own label ([REPL](https://v3.svelte.technology/repl?version=3.0.0-beta.11&gist=fb75a7a2f20962ec21039aa91ae601c6)):
```html
<script>
import Pane from './Pane.svelte';
import Tab from './Tab.svelte';
</script>
<Pane label="foo">
<Tab label="bar" />
<Tab label="baz" />
</Pane>
<!--
The following is rendered in the browser:
foo
foo/bar
foo/baz
-->
```
However, when this example is setup for SSR, the second `Tab` gets its context from its sibling `Tab` component rather than the parent `Pane`, [like this repro illustrates](https://github.com/EmilTholin/svelte-context-ssr):
```html
<!--
The following is rendered on the server:
foo
foo/bar
foo/bar/baz
-->
```
|
https://github.com/sveltejs/svelte/issues/2182
|
https://github.com/sveltejs/svelte/pull/2249
|
5d6333aa8f7ee59cada32f3647635bf7cdf2bed1
|
e87976dc21575afa4742ec5fb79365860e76092e
| 2019-03-08T16:59:25Z |
javascript
| 2019-03-17T22:48:10Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.