status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 558 | ["server/client_test.go", "server/sublist.go", "server/sublist_test.go"] | Is this a bug or not? | Hi All:
I got a strange problem, when subject is something like xx.9999,\*,\*,1, when sub and pub restart, sub cant't receive anything on xx.9999,\*,\*,1 it can be reproduce by following step, please notice the start and stop sequence
Env is
Win7 x86
gnatsd 1.0.2
go-nats is lastest version by go get
1.start gnatsd
2.start sub
3.start pub
*sub will receive 5 msg it's ok
4.close pub
5.close sub
6.start sub
7.start pub
*now sub cant receive any msg..??
8.restart gnatsd
it's work again, but when follow step2 it's not working again.
if the subscription is invalid, the api should return IsValid() = false??, but if it's invalid, why it works first time?
here is sample code
sub code
```
package main
import (
"fmt"
"github.com/nats-io/nats"
)
func main() {
nc, err := nats.Connect("nats://127.0.0.1:4222")
s, err := nc.Subscribe("xx.9999,*,*,1", func(m *nats.Msg) {
fmt.Println(string(m.Data))
})
fmt.Printf("s.IsValid()=%v\n", s.IsValid())
fmt.Printf("Subscribe err=%v\n", err)
nc.Flush()
var buf string
fmt.Scanf("%s", buf)
}
```
pub code
```
package main
import (
"github.com/nats-io/nats"
"fmt"
)
func main() {
nc, _ := nats.Connect("nats://127.0.0.1:4222")
for i := 0; i < 5; i += 1 {
err := nc.Publish("xx.9999,*,*,1", []byte("test xx.9999,*,*,1"))
fmt.Printf("publish err=%v\n", err)
}
nc.Flush()
var buf string
fmt.Scanf("%s", buf)
}
```
| https://github.com/nats-io/nats-server/issues/558 | https://github.com/nats-io/nats-server/pull/561 | 2de6622fd0b61e398d43b89583d5a0088a6b4c6a | 10fd640aa4c21adddb73d7a0a6562611e9275fb0 | 2017-08-14T08:50:00Z | go | 2017-08-25T02:26:12Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 553 | ["README.md"] | Log File path using gnatsd.exe as a windows service needs to be in Linux format | - [X ] Defect
- [ ] Feature Request or Change Proposal
## Defects
When you install gnatsd.exe as a windows service (as per the ReadMe doc) and you specify a Config file on the service command line then ..
The Service can start and read the Config file but the path for the log_file in the config file has to be set to use the Linux "/" character instead of the normal "\" windows one. If you don't do this then the Service fails to start.
It should be like this on windows
log_file: "D:\Projects\Research\NATS\64Bit\Logs\gnats.log"
but it only works like this
log_file: "D:/Projects/Research/NATS/64Bit/Logs/gnats.log"
If you start gnatsd.exe from the command line (not as a service) the above does not happen.
Make sure that these boxes are checked before submitting your issue -- thank you!
- [ N] Included `gnatsd -DV` output
- [ N] Included a [Minimal, Complete, and Verifiable example] (http://stackoverflow.com/help/mcve)
#### Versions of `gnatsd` and affected client libraries used:
Version 1.02
#### OS/Container environment:
Windows 10 - Creators Update
#### Steps or code to reproduce the issue:
Install gnatsd.exe as a windows service using the following command:
sc.exe create gnatsd_Server binPath= "D:\Projects\Research\NATS\64Bit\gnatsd32.exe -c D:\Projects\Research\NATS\64Bit\Nats.cfg"
In the above Nats.cfg file, set the value for the log file to
# logging options
debug: false
trace: true
logtime: true
log_file: "D:\Projects\Research\NATS\64Bit\Logs\gnats.log"
(using normal windows backslash path separator)
Start the service
#### Expected result:
The Service should start and it should use the specified log file.
#### Actual result:
The service fails to start at all.
If you change the log file to
# logging options
debug: false
trace: true
logtime: true
log_file: "D:/Projects/Research/NATS/64Bit/Logs/gnats.log"
(now using Linux forward slash path separators)
it works as expected.
## Feature Requests
None
#### Use Case:
None
#### Proposed Change:
Change the code to allow for windows style paths on a Windows OS
#### Who Benefits From The Change(s)?
Everyone who uses gnatsd.exe as a Windows Service
#### Alternative Approaches
| https://github.com/nats-io/nats-server/issues/553 | https://github.com/nats-io/nats-server/pull/556 | 0497d592798273ff7a50256ee563aa7d45b75272 | 050049c2c7e0bc48245dc4f0202d9feedc3e6515 | 2017-07-27T09:19:48Z | go | 2017-08-16T16:16:36Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 549 | ["server/client.go", "test/cluster_test.go"] | Subscriptions zombie | - [x] Defect
- [ ] Feature Request or Change Proposal
## Defects
- [x] Included `gnatsd -DV` output
- [ ] Included a [Minimal, Complete, and Verifiable example] (http://stackoverflow.com/help/mcve)
#### Versions of `gnatsd` and affected client libraries used:
gnatsd 1.0.1 & go-nats 1.3.0
#### OS/Container environment:
Debian 8.8
#### Steps or code to reproduce the issue:
* cluster up (A and B nodes)
* client connect to node A
* client subscribe `sub, _ := nc.Subscribe("foo", func(msg *nats.Msg) {})`
* client set automatic unsubscribe `sub.AutoUnsubscribe(1)`
* client closed connection
#### Expected result:
No subscriptions to all cluster nodes
#### Actual result:
One subscription on node B
Perhaps, server should to call forced version (with sub.max = 0) `broadcastUnSubscribe()` when closing the client connection
#### Output
node A
```
[24514] 2017/07/20 13:18:17.678912 [INF] Starting nats-server version 1.0.1
[24514] 2017/07/20 13:18:17.678970 [DBG] Go build version go1.8.3
[24514] 2017/07/20 13:18:17.679030 [INF] Listening for client connections on 127.0.0.1:7222
[24514] 2017/07/20 13:18:17.679034 [DBG] Server id is y2j1m8QnzW33NME7roHUzw
[24514] 2017/07/20 13:18:17.679045 [INF] Server is ready
[24514] 2017/07/20 13:18:17.679107 [INF] Listening for route connections on 127.0.0.1:7244
[24514] 2017/07/20 13:18:17.679179 [DBG] Trying to connect to route on 127.0.0.1:7246
[24514] 2017/07/20 13:18:17.679271 [DBG] Error trying to connect to route: dial tcp 127.0.0.1:7246: getsockopt: connection refused
[24514] 2017/07/20 13:18:17.704357 [DBG] 127.0.0.1:50637 - rid:1 - Route connection created
[24514] 2017/07/20 13:18:17.704494 [TRC] 127.0.0.1:50637 - rid:1 - ->> [CONNECT {"verbose":false,"pedantic":false,"user":"ruser","pass":"top_secret","tls_required":false,"name":"y2j1m8QnzW33NME7roHV1H"}]
[24514] 2017/07/20 13:18:17.704568 [DBG] 127.0.0.1:50637 - rid:1 - Registering remote route "y2j1m8QnzW33NME7roHV1H"
[24514] 2017/07/20 13:18:17.704575 [DBG] 127.0.0.1:50637 - rid:1 - Route sent local subscriptions
[24514] 2017/07/20 13:18:17.729356 [DBG] 127.0.0.1:41999 - cid:2 - Client connection created
[24514] 2017/07/20 13:18:17.729566 [TRC] 127.0.0.1:41999 - cid:2 - ->> [CONNECT {"verbose":false,"pedantic":false,"tls_required":false,"name":"","lang":"go","version":"1.3.0","protocol":1}]
[24514] 2017/07/20 13:18:17.729588 [TRC] 127.0.0.1:41999 - cid:2 - ->> [PING]
[24514] 2017/07/20 13:18:17.729592 [TRC] 127.0.0.1:41999 - cid:2 - <<- [PONG]
[24514] 2017/07/20 13:18:17.729694 [TRC] 127.0.0.1:41999 - cid:2 - ->> [SUB foo 1]
[24514] 2017/07/20 13:18:17.729722 [TRC] 127.0.0.1:50637 - rid:1 - <<- [SUB foo RSID:2:1]
[24514] 2017/07/20 13:18:17.729726 [TRC] 127.0.0.1:41999 - cid:2 - ->> [UNSUB 1 1]
[24514] 2017/07/20 13:18:17.729730 [DBG] 127.0.0.1:41999 - cid:2 - Deferring actual UNSUB(foo): 1 max, 0 received
[24514] 2017/07/20 13:18:17.729739 [TRC] 127.0.0.1:50637 - rid:1 - <<- [UNSUB RSID:2:1 1]
[24514] 2017/07/20 13:18:17.830727 [DBG] 127.0.0.1:41999 - cid:2 - Client connection closed
[24514] 2017/07/20 13:18:17.830794 [TRC] 127.0.0.1:50637 - rid:1 - <<- [UNSUB RSID:2:1 1]
[24514] 2017/07/20 13:18:18.679382 [DBG] Trying to connect to route on 127.0.0.1:7246
[24514] 2017/07/20 13:18:18.679518 [DBG] 127.0.0.1:7246 - rid:3 - Route connection created
[24514] 2017/07/20 13:18:18.679528 [DBG] 127.0.0.1:7246 - rid:3 - Route connect msg sent
[24514] 2017/07/20 13:18:18.679609 [DBG] 127.0.0.1:7246 - rid:3 - Detected duplicate remote route "y2j1m8QnzW33NME7roHV1H"
[24514] 2017/07/20 13:18:18.679614 [DBG] 127.0.0.1:7246 - rid:3 - Router connection closed
[24514] 2017/07/20 13:18:18.679633 [DBG] Not attempting reconnect for solicited route, already connected to "y2j1m8QnzW33NME7roHV1H"
[24514] 2017/07/20 13:18:22.937075 [DBG] 127.0.0.1:50637 - rid:1 - Router connection closed
[24514] 2017/07/20 13:18:22.937080 [INF] Server Exiting..
[24514] 2017/07/20 13:18:22.937143 [DBG] Router accept loop exiting..
```
node B
```
[24514] 2017/07/20 13:18:17.704140 [INF] Starting nats-server version 1.0.1
[24514] 2017/07/20 13:18:17.704156 [DBG] Go build version go1.8.3
[24514] 2017/07/20 13:18:17.704199 [INF] Listening for client connections on 127.0.0.1:7224
[24514] 2017/07/20 13:18:17.704203 [DBG] Server id is y2j1m8QnzW33NME7roHV1H
[24514] 2017/07/20 13:18:17.704205 [INF] Server is ready
[24514] 2017/07/20 13:18:17.704225 [INF] Listening for route connections on 127.0.0.1:7246
[24514] 2017/07/20 13:18:17.704259 [DBG] Trying to connect to route on 127.0.0.1:7244
[24514] 2017/07/20 13:18:17.704338 [DBG] 127.0.0.1:7244 - rid:1 - Route connection created
[24514] 2017/07/20 13:18:17.704345 [DBG] 127.0.0.1:7244 - rid:1 - Route connect msg sent
[24514] 2017/07/20 13:18:17.704447 [DBG] 127.0.0.1:7244 - rid:1 - Registering remote route "y2j1m8QnzW33NME7roHUzw"
[24514] 2017/07/20 13:18:17.704453 [DBG] 127.0.0.1:7244 - rid:1 - Route sent local subscriptions
[24514] 2017/07/20 13:18:17.729752 [TRC] 127.0.0.1:7244 - rid:1 - ->> [SUB foo RSID:2:1]
[24514] 2017/07/20 13:18:17.729772 [TRC] 127.0.0.1:7244 - rid:1 - ->> [UNSUB RSID:2:1 1]
[24514] 2017/07/20 13:18:17.729777 [DBG] 127.0.0.1:7244 - rid:1 - Deferring actual UNSUB(foo): 1 max, 0 received
[24514] 2017/07/20 13:18:17.830810 [TRC] 127.0.0.1:7244 - rid:1 - ->> [UNSUB RSID:2:1 1]
[24514] 2017/07/20 13:18:17.830818 [DBG] 127.0.0.1:7244 - rid:1 - Deferring actual UNSUB(foo): 1 max, 0 received
[24514] 2017/07/20 13:18:18.679535 [DBG] 127.0.0.1:39572 - rid:2 - Route connection created
[24514] 2017/07/20 13:18:18.679601 [TRC] 127.0.0.1:39572 - rid:2 - ->> [CONNECT {"verbose":false,"pedantic":false,"user":"ruser","pass":"top_secret","tls_required":false,"name":"y2j1m8QnzW33NME7roHUzw"}]
[24514] 2017/07/20 13:18:18.679637 [DBG] 127.0.0.1:39572 - rid:2 - Detected duplicate remote route "y2j1m8QnzW33NME7roHUzw"
[24514] 2017/07/20 13:18:18.679641 [DBG] 127.0.0.1:39572 - rid:2 - Router connection closed
[24514] 2017/07/20 13:18:22.936998 [DBG] 127.0.0.1:7244 - rid:1 - Router connection closed
[24514] 2017/07/20 13:18:22.937035 [INF] Server Exiting..
[24514] 2017/07/20 13:18:22.937039 [DBG] Router accept loop exiting..
```
| https://github.com/nats-io/nats-server/issues/549 | https://github.com/nats-io/nats-server/pull/551 | 4ccbd2e3bac4a1e1f32ed760549f1f26560f58be | 3ee7f3b3b156aef2e23553b2e3236c331d5fa5f6 | 2017-07-20T12:11:17Z | go | 2017-07-21T14:28:43Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 543 | ["Dockerfile.win64", "logger/syslog_windows.go", "logger/syslog_windows_test.go", "server/const.go", "server/service_windows.go"] | Windows Docker Images fail to start | Error reported is this:
```
The service process could not connect to the service controller.
```
Version `0.9.6` works as expected. | https://github.com/nats-io/nats-server/issues/543 | https://github.com/nats-io/nats-server/pull/544 | 9a44c20890b875b0fbb28ec54f79f985bf58f44e | d26bef4edfe77678f7efef6f85c3b201da34435a | 2017-07-17T19:32:34Z | go | 2017-07-19T01:18:00Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 539 | ["server/monitor.go", "server/monitor_test.go"] | Possible routez data race | Could get the following race when hitting the `routez` endpoint
while a route was being disconnected:
```
==================
WARNING: DATA RACE
Write at 0x00c04246b2e0 by goroutine 354:
github.com/nats-io/gnatsd/server.(*client).closeConnection()
C:/Go/src/github.com/nats-io/gnatsd/server/client.go:1315 +0x20d
github.com/nats-io/gnatsd/server.(*client).readLoop()
C:/Go/src/github.com/nats-io/gnatsd/server/client.go:279 +0x14ac
github.com/nats-io/gnatsd/server.(*Server).createRoute.func2()
C:/Go/src/github.com/nats-io/gnatsd/server/route.go:411 +0x48
Previous read at 0x00c04246b2e0 by goroutine 70:
github.com/nats-io/gnatsd/server.(*Server).HandleRoutez()
C:/Go/src/github.com/nats-io/gnatsd/server/monitor.go:325 +0x7c7
github.com/nats-io/gnatsd/server.(*Server).HandleRoutez-fm()
C:/Go/src/github.com/nats-io/gnatsd/server/server.go:616 +0x66
net/http.HandlerFunc.ServeHTTP()
C:/Go/src/net/http/server.go:1726 +0x58
net/http.(*ServeMux).ServeHTTP()
C:/Go/src/net/http/server.go:2022 +0xa8
net/http.serverHandler.ServeHTTP()
C:/Go/src/net/http/server.go:2202 +0xc2
net/http.(*conn).serve()
C:/Go/src/net/http/server.go:1579 +0x5fd
Goroutine 354 (running) created at:
github.com/nats-io/gnatsd/server.(*Server).startGoRoutine()
C:/Go/src/github.com/nats-io/gnatsd/server/server.go:1006 +0xc2
github.com/nats-io/gnatsd/server.(*Server).createRoute()
C:/Go/src/github.com/nats-io/gnatsd/server/route.go:411 +0x581
github.com/nats-io/gnatsd/server.(*Server).routeAcceptLoop.func1()
C:/Go/src/github.com/nats-io/gnatsd/server/route.go:677 +0x68
Goroutine 70 (running) created at:
net/http.(*Server).Serve()
C:/Go/src/net/http/server.go:2293 +0x547
github.com/nats-io/gnatsd/server.(*Server).startMonitoring.func1()
C:/Go/src/github.com/nats-io/gnatsd/server/server.go:637 +0x57
==================
``` | https://github.com/nats-io/nats-server/issues/539 | https://github.com/nats-io/nats-server/pull/540 | 1ca5e57b2d656ff68e975c5a0cd7943289a0c77a | 56649b327341985679add63f08ff9ebe8934698a | 2017-07-11T21:33:40Z | go | 2017-07-11T22:11:22Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 534 | ["server/reload_test.go"] | Failed config reload test can leave symlink hanging around | If a config reload unit test fails, it's possible for one of the created config file symlinks to not get cleaned up, causing subsequent runs of the tests to fail. Tests should always clean up symlinks. | https://github.com/nats-io/nats-server/issues/534 | https://github.com/nats-io/nats-server/pull/536 | 8a1ac81620a240c9dcf8a7a4a5662bee0b6e59ed | d0a2661c325bf8184ba80ff6d74d6ba5119947a5 | 2017-07-11T00:06:46Z | go | 2017-07-11T16:12:34Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 530 | ["README.md", "conf/parse.go", "main.go", "server/config_check_test.go", "server/configs/include_bad_conf_check_a.conf", "server/configs/include_bad_conf_check_b.conf", "server/configs/include_conf_check_a.conf", "server/configs/include_conf_check_b.conf", "server/configs/include_conf_check_c.conf", "server/opts.go"] | Invalid configuration is accepted by the server | - [X ] Defect
- [X] Feature Request or Change Proposal
## Defects
The gnatsd configuration loads an invalid configuration without complaining. For example this snippet on a test to see if a JSON version of the configuration would work:
```
# NOTE 'DEFAULT_PERMISSIONS' needs to be in the authorization section
"DEFAULT_PERMISSIONS":{
"publish":">"
"subscribe":["foo.>","bar.>"]
}
"authorization": {
"users": [
{"user": "test", "password": "a"}
]
# default of 5 seconds for an authorization timeout.
"timeout": 5.0
}
```
The server takes it:
```
[albertoricart@barsoom:/tmp/natsservice/1/current]$ bin/natsservice1 -c natsservice1.conf
[54613] 2017/07/07 10:18:49.931405 [INF] Starting nats-server version 0.9.6
[54613] 2017/07/07 10:18:49.931480 [INF] Starting http monitor on barsoom.local:15084
[54613] 2017/07/07 10:18:49.931960 [INF] Listening for client connections on barsoom.local:10084
[54613] 2017/07/07 10:18:49.932360 [INF] Server is ready
[54613] 2017/07/07 10:18:49.932782 [INF] Listening for route connections on barsoom.local:12584
```
Now on a client:
```
[albertoricart@barsoom:~]$ nats-sub -s nats://test:[email protected]:10084 "barx.>"
Listening on [barx.>]
```
This is unexpected, the server likely should have failed to start since it had a configuration that it couldn't make sense of.
| https://github.com/nats-io/nats-server/issues/530 | https://github.com/nats-io/nats-server/pull/745 | 3e556abff24a8563a99f1f20ce94a0a66d6cf168 | 662f71ed9ec9cf455ac77f53d963739ae8f2b4e9 | 2017-07-07T15:31:25Z | go | 2018-09-12T18:27:41Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 518 | [".github/workflows/stale-issues.yaml"] | Extract gnatsd logger into separate logging package | With #500, the gnatsd logger was made non-global. This logger is also used by NATS Streaming and Prometheus Exporter. We should consider extracting the logger into a separate NATS logging package that both can consume. According to @ColinSullivan1:
> IMO the logger should be its own NATS logger package, and the server should have an instance of it. The server, streaming server, prometheus exporter all use the same logging code, copied. Well, the streaming server uses a hybrid version last I checked. | https://github.com/nats-io/nats-server/issues/518 | https://github.com/nats-io/nats-server/pull/4869 | 3c48d0ea8118c1a5020240417dfb70acb6cfb2b8 | 1998a9ee281f3a53542509e2592cac719e71f61c | 2017-06-15T15:40:49Z | go | 2023-12-11T16:09:10Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 516 | [".github/workflows/stale-issues.yaml"] | Improve external usage of server stats | - [ ] Defect
- [x] Feature Request or Change Proposal
## Feature Requests
#### Use Case:
When embedding the nats broker it would be handy for the thing its embedded in to be able to get at the stats in its data format.
Right now the http handlers in server/monitor.go also does the work of constructing the data they are serving
#### Proposed Change:
Extract each data creator out into say a method like server.NewConnz() that does the work of building up the data structure and filling in all the current values etc and then return that.
Use these new methods in the http handlers and as proposed make sure they are exported for others to use
Filing the issue to see if you're happy with the approach and if so I can look at making a PR for the change
#### Who Benefits From The Change(s)?
Those who embed the NATS server in other go projects
#### Alternative Approaches
not sure?
| https://github.com/nats-io/nats-server/issues/516 | https://github.com/nats-io/nats-server/pull/4869 | 3c48d0ea8118c1a5020240417dfb70acb6cfb2b8 | 1998a9ee281f3a53542509e2592cac719e71f61c | 2017-06-14T11:36:17Z | go | 2023-12-11T16:09:10Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 513 | ["server/server.go"] | Elevate TLS connection error logging levels | - [ ] Defect
- [x] Feature Request or Change Proposal
## Feature Requests
TLS errors should be logged at higher than debug level
#### Use Case:
Operational concerns
#### Proposed Change:
Adjust https://github.com/nats-io/gnatsd/blob/855ca705c3d026ed7e9779f84afedda00de81853/server/server.go#L657 and https://github.com/nats-io/gnatsd/blob/855ca705c3d026ed7e9779f84afedda00de81853/server/route.go#L373 to some level higher than debug
#### Who Benefits From The Change(s)?
Ops
#### Alternative Approaches
n/a
| https://github.com/nats-io/nats-server/issues/513 | https://github.com/nats-io/nats-server/pull/690 | dd59bdf2852a998362afddff576f17692766c1da | e155332e69caa1455e74553c15b121d0c176d69b | 2017-06-12T13:56:52Z | go | 2018-06-22T20:56:25Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 508 | [".travis.yml", "server/server.go", "server/server_test.go"] | Select Random Open Monitoring Port | - [ ] Defect
- [X] Feature Request or Change Proposal
## Feature Requests
#### Use Case:
To aid in unit testing, randomly select available port for monitoring. Ports must be exposed through a public function, allowing unit tests to access for verifying connections.
#### Who Benefits From The Change(s)?
Will help to eliminate intermittent test failures from port conflicts.
#### Alternative Approaches
| https://github.com/nats-io/nats-server/issues/508 | https://github.com/nats-io/nats-server/pull/509 | 482b6a9e46c28b8e444142a9dfef0230c40c7078 | 7a8fc9b3e643bbf5986f091c188bef59c126dfea | 2017-06-08T14:24:07Z | go | 2017-06-09T13:56:40Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 495 | ["server/server.go", "test/monitor_test.go", "test/test_test.go"] | When both HTTP and HTTPS ports are specified, monitoring pages may not load | #### Versions of `gnatsd`:
0.9.6
#### OS/Container environment:
Mac OS/X
#### Steps or code to reproduce the issue:
Start the server with both `-ms` and `-m` ports:
```
$gnatsd -tls -tlscert test/configs/certs/server-cert.pem -tlskey test/configs/certs/server-key.pem -ms 8223 -m 8222
[79215] 2017/05/18 12:42:21.806338 [INF] Starting nats-server version 0.9.6
[79215] 2017/05/18 12:42:21.806437 [INF] Starting http monitor on 0.0.0.0:8222
[79215] 2017/05/18 12:42:21.806513 [INF] Starting https monitor on 0.0.0.0:8223
[79215] 2017/05/18 12:42:21.807302 [INF] Listening for client connections on 0.0.0.0:4222
[79215] 2017/05/18 12:42:21.807335 [INF] TLS required for client connections
[79215] 2017/05/18 12:42:21.807338 [INF] Server is ready
```
Try to access `http://locahost:8222`, it may or may not work.
#### Expected result:
Valid results would be:
- Report misconfiguration error
- Favor security and start only TLS port
- Service both ports properly
#### Actual result:
Sometimes, one of the port (usually HTTP port) is not serviced properly: page never loads.
It looks like server is checking if HTTP port is specified and if so start monitoring on that (create a listener and starts a http.Serve() on that listener).
It then does the same for the HTTPS port. The problem, I believe, is that it stores the result of `net.Listen` or `tls.Listen` in the same server's variable (`s.http`) and pass this value to `srv.Serve(s.http)` in a go routine. So race conditions may cause problems.
If the intent was to support both, then I believe that the server should use 2 different variables. If not, I propose that the server starts only HTTPs if both are provided. | https://github.com/nats-io/nats-server/issues/495 | https://github.com/nats-io/nats-server/pull/497 | 4cef2dddd06633e6912e873cc77c0b43489e9aa8 | 1acdd2379c87ad4c8495df78fc5809f9762d9316 | 2017-05-18T18:57:02Z | go | 2017-05-25T04:58:56Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 491 | ["server/monitor.go", "server/monitor_test.go"] | Server doesn't handle negative offset and/or limit given to Connz | If server is started with monitoring on, and an user queries the `connz` endpoint with negative offset and/or limit, the server will report this for the current go-routine handling the request. The server is still working properly (does not entirely panic) and other well formed requests will go through.
For instance: `http://localhost:8222/connz?offset=-1` produces this:
```
2017/05/17 11:19:42 http: panic serving [::1]:60778: runtime error: slice bounds out of range
goroutine 34 [running]:
net/http.(*conn).serve.func1(0xc42016c000)
/usr/local/go/src/net/http/server.go:1491 +0x12a
panic(0x350c80, 0xc420012100)
/usr/local/go/src/runtime/panic.go:458 +0x243
github.com/nats-io/gnatsd/server.(*Server).HandleConnz(0xc420136280, 0x544820, 0xc4201a40d0, 0xc42019a000)
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/monitor.go:150 +0x19fb
github.com/nats-io/gnatsd/server.(*Server).HandleConnz-fm(0x544820, 0xc4201a40d0, 0xc42019a000)
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:492 +0x48
net/http.HandlerFunc.ServeHTTP(0xc420013550, 0x544820, 0xc4201a40d0, 0xc42019a000)
/usr/local/go/src/net/http/server.go:1726 +0x44
net/http.(*ServeMux).ServeHTTP(0xc42000d650, 0x544820, 0xc4201a40d0, 0xc42019a000)
/usr/local/go/src/net/http/server.go:2022 +0x7f
net/http.serverHandler.ServeHTTP(0xc420096380, 0x544820, 0xc4201a40d0, 0xc42019a000)
/usr/local/go/src/net/http/server.go:2202 +0x7d
net/http.(*conn).serve(0xc42016c000, 0x544fa0, 0xc42017e080)
/usr/local/go/src/net/http/server.go:1579 +0x4b7
created by net/http.(*Server).Serve
/usr/local/go/src/net/http/server.go:2293 +0x44d
``` | https://github.com/nats-io/nats-server/issues/491 | https://github.com/nats-io/nats-server/pull/492 | 0415221fe18d96cb103803c5d8f25f3faa6d0a12 | 4cef2dddd06633e6912e873cc77c0b43489e9aa8 | 2017-05-17T18:05:33Z | go | 2017-05-18T20:07:27Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 490 | ["server/monitor.go", "server/monitor_test.go"] | Server ID is not available on JSONs other than /varz | - [X] Defect
- [ ] Feature Request or Change Proposal
## Defects
Without the server id, there's no indication of whether the server restarted.
#### Versions of `gnatsd` and affected client libraries used:
All
#### OS/Container environment:
All
#### Steps or code to reproduce the issue:
See /varz, has `server_id` other JSONs don't.
#### Expected result:
`server_id` should be in all the JSONs.
#### Actual result:
## Feature Requests
#### Use Case:
#### Proposed Change:
#### Who Benefits From The Change(s)?
Monitoring tools.
#### Alternative Approaches
Time comparisons
| https://github.com/nats-io/nats-server/issues/490 | https://github.com/nats-io/nats-server/pull/598 | b56ca22d1bfb571fa395a35fe698b0eb7f95e706 | f39cd53d0712265557576d74aac9351170a70c08 | 2017-05-17T00:05:42Z | go | 2018-01-30T22:10:49Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 487 | ["server/configs/test.conf", "server/opts.go", "server/opts_test.go"] | Change configuration parameter write_deadline type (from integer to time.Duration) | - [X] Feature Request or Change Proposal
## Feature Requests
Change the `write_deadline` configuration type from being an integer to be a string that can be parsed as a duration (say "25ms") to allow lower than 1 second deadline from configuration.
#### Use Case:
There may be some cases of 1 to many subscribers where one would want to reduce the write deadline so that one slow consumer in the list does not slow down too much the rest of group.
#### Proposed Change:
Support for `write_deadline` in the configuration was introduced in PR #421 as a number of seconds. The corresponding option, however, is a `time.Duration`. Since this is in master but not part of an official release, I wonder if this would be ok to modify the configuration parsing to look for a time.Duration instead of an integer.
People that are using the parameter (say: `write_deadline: 1`) would get an error saying that this parameter is expected to be a duration, and would need to change to `write_deadline: "1s"` for instance.
#### Who Benefits From The Change(s)?
People that need a smaller than 1 second write deadline from the configuration file.
#### Alternative Approaches
Introduce a new parameter parsed as time.Duration that would override the current `write_deadline`.
cc @petemiron This is based on the discussion that we had. I can submit a PR if desired.
| https://github.com/nats-io/nats-server/issues/487 | https://github.com/nats-io/nats-server/pull/488 | 11d3eedda7f1b53df9b6404dc81d718641cefc71 | 6a12c218cd5e6c82a207fb979b1775e5df52aedd | 2017-05-05T20:58:34Z | go | 2017-05-06T21:18:29Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 480 | ["server/monitor_test.go", "server/pse/pse_darwin.go", "server/server.go"] | Expose the HTTP Handler used by the NATS Server | - [X] Feature Request or Change Proposal
## Feature Requests
#### Use Case:
Be able to add monitoring endpoints to the http server started by NATS Server.
#### Proposed Change:
Add a `Server.HTTPHandler()` function that returns the server's http handler. With that we can then add new endpoints. For instance, the code could look like this:
```
hh := s.natsServer.HTTPHandler()
mux := hh.(*http.ServeMux)
mux.HandleFunc(RootPath, s.handleRootz)
mux.HandleFunc(ChannelsPath, s.handleChannelsz)
...
```
#### Who Benefits From The Change(s)?
The NATS Streaming server needs to implement monitoring. With this function, it will be possible to add handlers and functions handling new endpoints (for channels, etc..). When the streaming server embeds the NATS Server, it simply adds new endpoints. If the Streaming server does not embed the NATS Server, and since it vendors it, it will still be possible to create an instance of `Server` and simply start the HTTP server, and again, add to the list of endpoints.
#### Alternative Approaches
Duplicate code and have a separate HTTP server for the streaming servers. It would be cumbersome when the user embeds the NATS Server since we would then need to have 2 ports, etc...
| https://github.com/nats-io/nats-server/issues/480 | https://github.com/nats-io/nats-server/pull/481 | 0635937a8109c884fa61a56163e31f840010c350 | 11d3eedda7f1b53df9b6404dc81d718641cefc71 | 2017-04-27T22:33:39Z | go | 2017-04-30T18:58:27Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 477 | ["conf/lex.go", "conf/lex_test.go"] | double-quoted string values in the config aren't backslash-escaped | From reading the lex code it looks like the only time string lexing does backslash-escaping is for raw strings (no quotes). And the lexer seems to only recognize backslashes, but it doesn't actually convert sequences like `\"` to `"` (and the lexer tests repeat that). The parser doesn't do any escaping, and it really can't, because it doesn't know how the `itemString` it picks up was delimited.
I found this trying to set up a bosh-lite cf with a nats password of `spaces and \ backslashes` | https://github.com/nats-io/nats-server/issues/477 | https://github.com/nats-io/nats-server/pull/482 | a94b5e0f4c7521be2640846cd150569ad0b08166 | 0635937a8109c884fa61a56163e31f840010c350 | 2017-04-25T16:37:02Z | go | 2017-04-30T18:52:04Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 476 | ["server/auth.go", "server/opts.go", "server/server_test.go"] | SetClientAuthMethod (authMethod Auth) | The new version does not have func (s * Server) SetClientAuthMethod (authMethod Auth)
Bring her back. Because you need the ability to override the authorization method for clients and routers. | https://github.com/nats-io/nats-server/issues/476 | https://github.com/nats-io/nats-server/pull/576 | d19c7d0a7da2207d381dbffd82af29e952fb7952 | 347798428d23e300963acbca864d6d68d589ce34 | 2017-04-24T09:29:25Z | go | 2017-09-20T17:40:49Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 466 | [".github/workflows/stale-issues.yaml"] | Support for linux/arm64 (ARMv8, aarch64) | - [x] Feature Request or Change Proposal
#### OS/Container environment:
ARMv8 server is a Packet 2A (Cavium ThunderX, 96-core at 2 Ghz)
#### Steps or code to reproduce the issue:
* Visit releases page, https://github.com/nats-io/gnatsd/releases
* Look for linux-arm64 version
#### Expected result:
linux-arm64 supported release
#### Actual result:
No files found.
As of 2017-04-04, build works fine, tests fail until timeouts are extended, and we've identified a performance issue on ARMv8 Go 1.8 `crypto/tls`. Further work pending Go performance improvements on ARMv8.
## Feature Requests
#### Use Case:
Two use cases: one for ARMv8 single-board computers (e.g. Raspberry Pi 3, Odroid C2, Pine64); another for ARMv8 in the data center (e.g. Cavium ThunderX).
#### Proposed Change:
Build and test for arm64, validate that it works, add as supported release.
#### Who Benefits From The Change(s)?
Users of arm64 (ARMv8) platforms as listed above.
#### Alternative Approaches
Planning to build from source and see how that goes; I'll use this issue to identify anything that comes up. | https://github.com/nats-io/nats-server/issues/466 | https://github.com/nats-io/nats-server/pull/4869 | 3c48d0ea8118c1a5020240417dfb70acb6cfb2b8 | 1998a9ee281f3a53542509e2592cac719e71f61c | 2017-04-04T15:53:00Z | go | 2023-12-11T16:09:10Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 464 | ["README.md", "server/opts.go", "server/opts_test.go", "test/client_auth_test.go"] | Auth Token in configuration file | I see there is a cli option for authorization via a token, however I cannot find anywhere how to put that into the actual configuration file.
Thanks,
| https://github.com/nats-io/nats-server/issues/464 | https://github.com/nats-io/nats-server/pull/465 | 91f4997795c46a239ffdef506c580c853e1618fd | 64dcdd6a7e9225e71c7678a9992802eff98d2e05 | 2017-03-30T12:23:31Z | go | 2017-03-30T18:22:52Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 460 | ["server/log_test.go", "server/routes_test.go", "server/signal_test.go"] | Increase Code Coverage | - [ ] Defect
- [X] Feature Request or Change Proposal
`server/log.go` and `server/signal.go` currently have ~50% code coverage. By increasing code coverage for those, the total coverage should increase above 90%. | https://github.com/nats-io/nats-server/issues/460 | https://github.com/nats-io/nats-server/pull/461 | b11ba5b11890161e96ff3e76a1c3f1b2336365b1 | 91f4997795c46a239ffdef506c580c853e1618fd | 2017-03-24T16:52:32Z | go | 2017-03-24T21:19:06Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 458 | [".travis.yml", "scripts/cov.sh", "server/client.go", "test/ping_test.go"] | Ping messages are not processed on TLS connections between routes | The PING/PONG functionality is not active on a running 3 nodes NATS cluster with TLS enabled between routes. I looked at the commit history, but I am not sure if this is a desired behavior or not.
This is the code line that disables the PING/PONG for TLS connections:
https://github.com/nats-io/gnatsd/blob/fdf1a24d78c1e5f2aa0f71a3426fd7a2fdc500bc/server/client.go#L1197
This is a dirty patch that enables PING/PONG for TLS connections: https://github.com/stefanschneider/gnatsd/commit/3bc0824f8c06b9bb9a9fa83282125d7aab8f09de
### How did I see this problem and how could PING/PONG prevented a network issue?
I have a 3 node NATS cluster (server A, B, and C) with TLS enabled.
Checking the server connections with netstat:
Server A has a route connection to server B established
Server A has a route connection to server C established
Server B has a route connection to server C established
Server C does NOT see the the connections from server A and B.
I am not sure how this happen, it may be because of some network issues or some TCP proxy issues.
Checking the server routes with `/routez`:
Server A has 2 routes
Server B has 2 routes
Server C has 0 routes
Because the PING/PONG was disabled in this scenario, Server A and B did not close the TCP/TLS connection and the route was kept in a healthy state until the underling socket would be closed. Even though server C attempted to created a route to server A and B, the new connection was considered a duplicate and closed.
This NATS cluster partition was present for at least 20 minutes in my debug environment. There was definitely something flaky in my network, but if the PING/PONG functionality was enabled the NATS cluster mesh would have automatically recovered very fast even in this scenario.
Fell free to close this issue if PING/PONG was disabled on purpose for TLS route connections.
Thank you
Stefan | https://github.com/nats-io/nats-server/issues/458 | https://github.com/nats-io/nats-server/pull/459 | 42a539f1c171b0617c338d76ded4a8442501ec65 | e1abaa51529c8044c050a9585080af7392d3889b | 2017-03-24T13:22:31Z | go | 2017-03-24T16:30:47Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 453 | ["server/client.go", "server/client_test.go", "server/const.go", "server/route.go", "server/server.go"] | Prevent delivery of messages to sending connection's subscriptions | If a client connection's `CONNECT` protocol contains (e.g.) `no_local : true`, the server should not deliver messages that originated from that connection to subscriptions on that connection.
- [ ] Add option to clients | https://github.com/nats-io/nats-server/issues/453 | https://github.com/nats-io/nats-server/pull/698 | e17ccb87605095902016487c9d11925ca0621864 | b32c408c193974d796c6a299045d6e07a0fc849f | 2017-03-21T19:10:06Z | go | 2018-06-29T17:51:46Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 441 | [".github/workflows/stale-issues.yaml"] | Test for concurrent connections | Is there a limit test for concurrent connections in a controlled environment?
Has anyone ever reached the mark of 1 million concurrent connections on a single server?
Thanks | https://github.com/nats-io/nats-server/issues/441 | https://github.com/nats-io/nats-server/pull/4869 | 3c48d0ea8118c1a5020240417dfb70acb6cfb2b8 | 1998a9ee281f3a53542509e2592cac719e71f61c | 2017-02-22T12:33:31Z | go | 2023-12-11T16:09:10Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 432 | ["server/client_test.go", "server/server.go", "test/tls_test.go"] | Authorization Timeout and TLS | When TLS and authorization is enabled, the authorization timeout can fire during the TLS handshake, causing the server to write the authorization timeout error string into the client socket, injecting what becomes bad data into the TLS handshake. This creates misleading errors on the client such as `tls: oversized record received with length 21024`.
I've only seen this happen when the host machine is under very heavy load with many clients simultaneously connecting, causing the server to become CPU bound.
There are a few ways to tackle this, but I propose waiting to schedule the authorization timer until after TLS is fully established to avoid this scenario. Any thoughts? | https://github.com/nats-io/nats-server/issues/432 | https://github.com/nats-io/nats-server/pull/493 | 01d2f1d12c4ca99270d95e3b65ac521273e49300 | 0415221fe18d96cb103803c5d8f25f3faa6d0a12 | 2017-02-06T22:05:32Z | go | 2017-05-18T15:25:18Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 408 | ["main.go", "server/configs/cluster.conf", "server/opts.go", "server/opts_test.go", "server/route.go", "server/routes_test.go", "test/route_discovery_test.go"] | i/o timeout error connecting to newly discovered routes using Kubernetes | **Setup:**
- Kubernetes 1.5.1 provisioned using kubeadm with the weave pod network add-on
- Kubernetes headless service called `nats`
- StatefulSet called `nats`
- Image: `nats:0.9.6`
- Replica Sets: 3
- Entrypoint: `/gnatsd --cluster=nats://$(POD_IP):6222 --routes=nats://nats-0.nats:6222 --http_port=8222 -D`.
- `$(POD_IP)` is filled in using the downward API.
**Description:**
In a three node (nats-0, nats-1, nats-2), clustered setup, where each node comes up in order, I see the following behavior:
- nats-0 starts, connects to itself, detects a route to itself, and correctly ignores it.
- nats-1 starts, connects to nats://nats-0.nats:6222, and registers itself. Now both nats-0 and nats-1 have a route to each other.
- nats-2 starts, connects to nats://nats-0.nats:6222, and registers itself. Now both nats-0 and nats-2 have a route to each other
- nats-0 sends a message to nats-1, telling it that nats-2 has joined the cluster. nats-1 attempts to connect to nats-2, using its IP, but gets an i/o timeout error and never retries, leaving nats-1 and nats-2 disconnected and unaware of each other's publishers/subscribers.
**Troubleshooting:**
- I've tested this same scenario on GKE (which uses NAT'ing and iptables on the hosts instead of an add-on like Weave) and I'm unable to reproduce the issue
- Using the same setup as described above, I've tested my own NATS image where I introduce a 2-second sleep in the entrypoint, and that seems to solve the problem as well.
So those two datapoints lead me to believe that there is a race condition that occurs between nats and the weave pod network.
**Possible NATS solution:**
- Add retry logic for handling discovered route connections (and possibly expose configuration to tweak it)?
**kubectl logs nats-0**
```
[1] 2016/12/20 17:50:40.520170 [INF] Starting nats-server version 0.9.6
[1] 2016/12/20 17:50:40.520216 [DBG] Go build version go1.7.4
[1] 2016/12/20 17:50:40.520226 [INF] Starting http monitor on 0.0.0.0:8222
[1] 2016/12/20 17:50:40.520340 [INF] Listening for client connections on 0.0.0.0:4222
[1] 2016/12/20 17:50:40.520408 [DBG] Server id is BriesLhAaK0vxV6RMIiDD5
[1] 2016/12/20 17:50:40.520414 [INF] Server is ready
[1] 2016/12/20 17:50:40.520652 [INF] Listening for route connections on 10.32.0.4:6222
[1] 2016/12/20 17:50:40.520720 [DBG] Trying to connect to route on nats-0.nats:6222
[1] 2016/12/20 17:50:40.734135 [DBG] Error trying to connect to route: dial tcp: lookup nats-0.nats on 10.96.0.10:53: no such host
[1] 2016/12/20 17:50:41.734422 [DBG] Trying to connect to route on nats-0.nats:6222
[1] 2016/12/20 17:50:41.737333 [DBG] 10.32.0.4:6222 - rid:1 - Route connection created
[1] 2016/12/20 17:50:41.737361 [DBG] 10.32.0.4:6222 - rid:1 - Route connect msg sent
[1] 2016/12/20 17:50:41.737608 [DBG] 10.32.0.4:39945 - rid:2 - Route connection created
[1] 2016/12/20 17:50:41.737821 [DBG] 10.32.0.4:39945 - rid:2 - Router connection closed
[1] 2016/12/20 17:50:41.737937 [DBG] 10.32.0.4:6222 - rid:1 - Router connection closed
[1] 2016/12/20 17:50:41.737997 [DBG] Detected route to self, ignoring "nats://nats-0.nats:6222"
[1] 2016/12/20 17:50:43.517369 [DBG] 10.46.0.1:40200 - rid:3 - Route connection created
[1] 2016/12/20 17:50:43.517902 [DBG] 10.46.0.1:40200 - rid:3 - Registering remote route "5ZSQuvRskobbbsYnJCURNv"
[1] 2016/12/20 17:50:43.517934 [DBG] 10.46.0.1:40200 - rid:3 - Route sent local subscriptions
[1] 2016/12/20 17:50:45.418738 [DBG] 10.40.0.2:41547 - rid:4 - Route connection created
[1] 2016/12/20 17:50:45.419022 [DBG] 10.40.0.2:41547 - rid:4 - Registering remote route "4WAjN6gqSES8slW5NqFs4n"
[1] 2016/12/20 17:50:45.419046 [DBG] 10.40.0.2:41547 - rid:4 - Route sent local subscriptions
```
**kubectl logs nats-1**
```
[1] 2016/12/20 17:50:43.482476 [INF] Starting nats-server version 0.9.6
[1] 2016/12/20 17:50:43.482578 [DBG] Go build version go1.7.4
[1] 2016/12/20 17:50:43.482598 [INF] Starting http monitor on 0.0.0.0:8222
[1] 2016/12/20 17:50:43.483078 [INF] Listening for client connections on 0.0.0.0:4222
[1] 2016/12/20 17:50:43.483168 [DBG] Server id is 5ZSQuvRskobbbsYnJCURNv
[1] 2016/12/20 17:50:43.483177 [INF] Server is ready
[1] 2016/12/20 17:50:43.483808 [INF] Listening for route connections on 10.46.0.1:6222
[1] 2016/12/20 17:50:43.483998 [DBG] Trying to connect to route on nats-0.nats:6222
[1] 2016/12/20 17:50:43.515903 [DBG] 10.32.0.4:6222 - rid:1 - Route connection created
[1] 2016/12/20 17:50:43.515947 [DBG] 10.32.0.4:6222 - rid:1 - Route connect msg sent
[1] 2016/12/20 17:50:43.516749 [DBG] 10.32.0.4:6222 - rid:1 - Registering remote route "BriesLhAaK0vxV6RMIiDD5"
[1] 2016/12/20 17:50:43.516814 [DBG] 10.32.0.4:6222 - rid:1 - Route sent local subscriptions
[1] 2016/12/20 17:50:45.418362 [DBG] Trying to connect to route on 10.40.0.2:6222
[1] 2016/12/20 17:50:46.418705 [DBG] Error trying to connect to route: dial tcp 10.40.0.2:6222: i/o timeout
```
**kubectl logs nats-2**
```
[1] 2016/12/20 17:50:45.383536 [INF] Starting nats-server version 0.9.6
[1] 2016/12/20 17:50:45.383611 [DBG] Go build version go1.7.4
[1] 2016/12/20 17:50:45.383629 [INF] Starting http monitor on 0.0.0.0:8222
[1] 2016/12/20 17:50:45.384192 [INF] Listening for client connections on 0.0.0.0:4222
[1] 2016/12/20 17:50:45.384277 [DBG] Server id is 4WAjN6gqSES8slW5NqFs4n
[1] 2016/12/20 17:50:45.384286 [INF] Server is ready
[1] 2016/12/20 17:50:45.384797 [INF] Listening for route connections on 10.40.0.2:6222
[1] 2016/12/20 17:50:45.384961 [DBG] Trying to connect to route on nats-0.nats:6222
[1] 2016/12/20 17:50:45.427020 [DBG] 10.32.0.4:6222 - rid:1 - Route connection created
[1] 2016/12/20 17:50:45.427064 [DBG] 10.32.0.4:6222 - rid:1 - Route connect msg sent
[1] 2016/12/20 17:50:45.427705 [DBG] 10.32.0.4:6222 - rid:1 - Registering remote route "BriesLhAaK0vxV6RMIiDD5"
[1] 2016/12/20 17:50:45.427733 [DBG] 10.32.0.4:6222 - rid:1 - Route sent local subscriptions
```
| https://github.com/nats-io/nats-server/issues/408 | https://github.com/nats-io/nats-server/pull/409 | ad1804c6e69cc9fa5cd61bad0a9d8d3e7bd47b3c | bc5f864bccff29999230385222460d5047874f9f | 2016-12-20T18:42:42Z | go | 2016-12-22T22:21:45Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 405 | [".github/workflows/stale-issues.yaml"] | Document what "slow consumer" means and how to deal with them | I just did a basic benchmark of gnatsd locally on my machine and was seeing a slow consumer.
http://nats.io/documentation/server/gnatsd-prune/ mentions "slow consumer" but doesn't really documents when a consumer is considered slow. Preferably, it should also document how to cope with it. Are there any configuration to allow a NATS server to buffer more messages? #217 mentions some strategies. | https://github.com/nats-io/nats-server/issues/405 | https://github.com/nats-io/nats-server/pull/4869 | 3c48d0ea8118c1a5020240417dfb70acb6cfb2b8 | 1998a9ee281f3a53542509e2592cac719e71f61c | 2016-12-16T21:17:12Z | go | 2023-12-11T16:09:10Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 399 | [".travis.yml", "staticcheck.ignore"] | PR #398 no longer triggers coverage/release | See last build for: [1.7.4](https://travis-ci.org/nats-io/gnatsd/jobs/181821670#L788)
Notice that code coverage was not started. Would be the same issue for cross compilation. | https://github.com/nats-io/nats-server/issues/399 | https://github.com/nats-io/nats-server/pull/400 | 6bc9389351d06c0bdf6f74f05ee12997f8de2580 | 0598bfa3b0b6c7f98e2b49b28bac2c8d40f2cbc6 | 2016-12-08T17:06:59Z | go | 2016-12-08T21:16:41Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 392 | ["main.go", "server/server.go", "server/server_test.go"] | Bareword in call to gnatsd causes it to ignore other params. | If you call `gnatsd bareword -cluster nats://:6222`, nats will still start, but it will ignore the `-cluster` arg (or any other args). This leads to confusing behavior and I think it would be better if nats just exited with an error in this case.
For example, the second revision of this gist works as expected, the first revision of this gist still starts, but does not cluster:
https://gist.github.com/ckeeney/ba40d1d6362a9d7633a0eb1f8eab7b24/revisions | https://github.com/nats-io/nats-server/issues/392 | https://github.com/nats-io/nats-server/pull/393 | 843d845263206ea294b5256d98cf66c6837c7a6e | 2b79c6c61e923422e099163b4bab5f02feeadada | 2016-12-01T20:05:11Z | go | 2016-12-02T02:30:07Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 386 | ["server/client.go", "server/errors.go", "server/server.go", "server/server_test.go"] | max_connection is not honored | The max_connections setting is getting loaded (reported by /varz), but its limit is not enforced.
I made a test case here: <https://github.com/nats-io/gnatsd/tree/max_connection_test> | https://github.com/nats-io/nats-server/issues/386 | https://github.com/nats-io/nats-server/pull/387 | 9eb590a14ece94b345b568d6e3fa906e6ae7f248 | a02ee91b20ce38b6ecbc50207bfd33980ef05a8a | 2016-11-30T22:49:36Z | go | 2016-12-01T16:03:36Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 381 | ["server/server.go", "server/signal.go", "server/signal_windows.go"] | Last version (master doesn't compile on Windows anymore) | This is because of the pull request #379, which used a syscall.SIGUSR1, which doesn't exist on Windows.
Could this be conditionally compile for Windows ?
| https://github.com/nats-io/nats-server/issues/381 | https://github.com/nats-io/nats-server/pull/382 | ee70a0903a17c316b58285b3359178fc311601e5 | e8dcb334ce5959c58fcf7ca61d7d907dca68e438 | 2016-11-22T16:17:14Z | go | 2016-11-22T23:28:12Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 359 | [".github/workflows/MQTT_test.yaml", ".github/workflows/cov.yaml", ".github/workflows/go-test.yaml"] | Tagged messages | Hello
This is a request.
The idea is to save bandwidth over internet, save CPU from server (crypted mode) to not send some messages, simplify the server administration by less create subscription and unsubscription.
To be able to ask after a subscription to NOT receive (on a particlar subscription) certain tagged messages, tag would be in the first 2 or 4 bytes of the messages.
This would be userfull for .
- The sender to not receive his own messages
- The other senders that are on the same queue group to not receive them also
- To less create un/subscriptions because, suppose a sender that propose different kind of messages to a group, if the sender says that it will propose a specific kind of messages with a specific tag, the receivers would simply specify that they don't want these tag on the main subscription, and let the other messages come. And all that without having to create new specific subscriptions, and unsubscribe them when the messages had passed.
And when the tag is over by the sender, the sender (or any connexion) could run a specific command like untag( subscription , tag ) that would remove this tag on all the subscriptions that didn't want it, that would prevent all the clients to untag by themselves.
To be able, to not receive our own messages, and to block others, it would be nice to have several unwanted tags at the same time on the same subscription for a connexion.
Thank you for reading. | https://github.com/nats-io/nats-server/issues/359 | https://github.com/nats-io/nats-server/pull/4870 | 1998a9ee281f3a53542509e2592cac719e71f61c | af04b7985c6aeff5294e4659043cc1399fdfdbed | 2016-10-05T10:28:10Z | go | 2023-12-11T16:10:08Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 336 | ["server/opts.go", "server/server.go", "test/configs/tlsverify_noca.conf", "test/tls_test.go"] | tlsverify doesn't do what it says it does | The `tlsverify` option states `Enable TLS, verify client certificates`. However in practice, it only requires that a client has a certificate, not performing any verification of the certificate.
Verification usually includes that a certificate is signed by a certificate chain that can be traced back to registered certificate authorities. gnatsd only [does that for other servers](https://github.com/nats-io/gnatsd/blob/master/server/opts.go#L308-L311), [not for clients](https://github.com/nats-io/gnatsd/blob/master/server/opts.go#L574-L577) (even when `tlsverify` is enabled).
This doesn't appear to be an actual security issue, as authentication can still be done via username/password (which is what's actually tied to authorization).
| https://github.com/nats-io/nats-server/issues/336 | https://github.com/nats-io/nats-server/pull/337 | c7e699ac29b3caca9f98d3c77fb109e617b68ecb | e41d360e77711885108008ccb6735a5b7637dd8e | 2016-08-25T18:19:12Z | go | 2016-08-25T22:44:11Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 331 | ["server/client.go", "server/route.go"] | Data RACE on Unsubscribe and connection close | TestServerRoutesWithAuthAndBCrypt
```
==================
WARNING: DATA RACE
Read by goroutine 16:
github.com/nats-io/gnatsd/server.(*Server).broadcastUnSubscribe()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/route.go:579 +0xa7
github.com/nats-io/gnatsd/server.(*client).closeConnection()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:1297 +0x67a
github.com/nats-io/gnatsd/server.(*Server).Shutdown()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:334 +0x81d
github.com/nats-io/gnatsd/server.TestServerRoutesWithAuthAndBCrypt()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/routes_test.go:136 +0xa25
testing.tRunner()
/usr/local/go/src/testing/testing.go:473 +0xdc
Previous write by goroutine 34:
github.com/nats-io/gnatsd/server.(*client).processUnsub()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:833 +0x42a
github.com/nats-io/gnatsd/server.(*client).parse()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/parser.go:340 +0x3fd5
github.com/nats-io/gnatsd/server.(*client).readLoop()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:271 +0x2f8
github.com/nats-io/gnatsd/server.(*Server).createClient.func2()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:615 +0x2d
Goroutine 16 (running) created at:
testing.RunTests()
/usr/local/go/src/testing/testing.go:582 +0xae2
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:515 +0x11d
main.main()
github.com/nats-io/gnatsd/server/_test/_testmain.go:316 +0x210
Goroutine 34 (finished) created at:
github.com/nats-io/gnatsd/server.(*Server).startGoRoutine()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:888 +0xa3
github.com/nats-io/gnatsd/server.(*Server).createClient()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:615 +0xf8f
github.com/nats-io/gnatsd/server.(*Server).AcceptLoop.func2()
/Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:421 +0x51
==================
```
| https://github.com/nats-io/nats-server/issues/331 | https://github.com/nats-io/nats-server/pull/332 | 14f5d0919c3f5368fe166049f792bb3b538f40f6 | 859949e70d849a8d891994bb13d8ac68135f21bf | 2016-08-17T22:46:17Z | go | 2016-08-18T04:04:33Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 327 | ["server/monitor.go", "server/monitor_test.go"] | Server panics with concurrent monitoring of endpoints | Here is the stack:
```
goroutine 88 [running]:
runtime.throw(0x957880, 0x21)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/runtime/panic.go:547 +0x90 fp=0xc8201ab400 sp=0xc8201ab3e8
runtime.mapaccess2(0x7a0d60, 0xc820013e60, 0xc8202de170, 0x6, 0x57112e)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/runtime/hashmap.go:343 +0x5a fp=0xc8201ab448 sp=0xc8201ab400
reflect.mapaccess(0x7a0d60, 0xc820013e60, 0xc8202de170, 0xc820013e60)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/runtime/hashmap.go:993 +0x35 fp=0xc8201ab478 sp=0xc8201ab448
reflect.Value.MapIndex(0x7a0d60, 0xc8202a8b58, 0x195, 0x7a1960, 0xc8202de170, 0x98, 0x0, 0x0, 0x0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/reflect/value.go:1041 +0x14a fp=0xc8201ab500 sp=0xc8201ab478
encoding/json.(*mapEncoder).encode(0xc8200202c0, 0xc8201cba20, 0x7a0d60, 0xc8202a8b58, 0x195, 0x200)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:622 +0x2ec fp=0xc8201ab5f0 sp=0xc8201ab500
encoding/json.(*mapEncoder).(encoding/json.encode)-fm(0xc8201cba20, 0x7a0d60, 0xc8202a8b58, 0x195, 0x0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:632 +0x51 fp=0xc8201ab628 sp=0xc8201ab5f0
encoding/json.(*structEncoder).encode(0xc8201744b0, 0xc8201cba20, 0x8c33e0, 0xc8202a8a90, 0x199, 0x0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:587 +0x2c4 fp=0xc8201ab7d0 sp=0xc8201ab628
encoding/json.(*structEncoder).(encoding/json.encode)-fm(0xc8201cba20, 0x8c33e0, 0xc8202a8a90, 0x199, 0xc8202a8a00)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:601 +0x51 fp=0xc8201ab808 sp=0xc8201ab7d0
encoding/json.(*ptrEncoder).encode(0xc8200202c8, 0xc8201cba20, 0x77ed60, 0xc8202a8a90, 0x16, 0x0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:709 +0xea fp=0xc8201ab858 sp=0xc8201ab808
encoding/json.(*ptrEncoder).(encoding/json.encode)-fm(0xc8201cba20, 0x77ed60, 0xc8202a8a90, 0x16, 0xc8202a8a00)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:714 +0x51 fp=0xc8201ab890 sp=0xc8201ab858
encoding/json.(*encodeState).reflectValue(0xc8201cba20, 0x77ed60, 0xc8202a8a90, 0x16)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:301 +0x6b fp=0xc8201ab8c0 sp=0xc8201ab890
encoding/json.(*encodeState).marshal(0xc8201cba20, 0x77ed60, 0xc8202a8a90, 0x0, 0x0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:274 +0xa9 fp=0xc8201ab908 sp=0xc8201ab8c0
encoding/json.Marshal(0x77ed60, 0xc8202a8a90, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:139 +0x84 fp=0xc8201ab940 sp=0xc8201ab908
encoding/json.MarshalIndent(0x77ed60, 0xc8202a8a90, 0x0, 0x0, 0x8e0fc0, 0x2, 0x0, 0x0, 0x0, 0x0, ...)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/encoding/json/encode.go:148 +0x64 fp=0xc8201ab9c8 sp=0xc8201ab940
github.com/nats-io/gnatsd/server.(*Server).HandleVarz(0xc820082c80, 0x7fe5aa39de68, 0xc8202a89c0, 0xc82027c9a0)
/home/travis/gopath/src/github.com/nats-io/gnatsd/server/monitor.go:486 +0x3f7 fp=0xc8201abad0 sp=0xc8201ab9c8
github.com/nats-io/gnatsd/server.(*Server).HandleVarz-fm(0x7fe5aa39de68, 0xc8202a89c0, 0xc82027c9a0)
/home/travis/gopath/src/github.com/nats-io/gnatsd/server/server.go:486 +0x3e fp=0xc8201abaf8 sp=0xc8201abad0
net/http.HandlerFunc.ServeHTTP(0xc820126600, 0x7fe5aa39de68, 0xc8202a89c0, 0xc82027c9a0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/net/http/server.go:1618 +0x3a fp=0xc8201abb18 sp=0xc8201abaf8
net/http.(*ServeMux).ServeHTTP(0xc82012a420, 0x7fe5aa39de68, 0xc8202a89c0, 0xc82027c9a0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/net/http/server.go:1910 +0x17d fp=0xc8201abb70 sp=0xc8201abb18
net/http.serverHandler.ServeHTTP(0xc82007c780, 0x7fe5aa39de68, 0xc8202a89c0, 0xc82027c9a0)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/net/http/server.go:2081 +0x19e fp=0xc8201abbd0 sp=0xc8201abb70
net/http.(*conn).serve(0xc82024ae80)
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/net/http/server.go:1472 +0xf2e fp=0xc8201abf98 sp=0xc8201abbd0
runtime.goexit()
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/runtime/asm_amd64.s:1998 +0x1 fp=0xc8201abfa0 sp=0xc8201abf98
created by net/http.(*Server).Serve
/home/travis/.gimme/versions/go1.6.3.linux.amd64/src/net/http/server.go:2137 +0x44e
```
| https://github.com/nats-io/nats-server/issues/327 | https://github.com/nats-io/nats-server/pull/328 | 638e249d2a9b33294d292d8b273cd60546831569 | 14f5d0919c3f5368fe166049f792bb3b538f40f6 | 2016-08-16T16:44:24Z | go | 2016-08-17T04:31:02Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 323 | ["server/route.go", "server/routes_test.go", "server/server.go", "server/server_test.go"] | Unable to use IPv6 for cluster + deadlocks on failed start | Trying to have the server listen for routes on IPv6 address fails:
```
gnatsd -cluster nats://[::]:6222
[99857] 2016/08/12 15:48:26.401570 [INF] Starting nats-server version 0.9.2
[99857] 2016/08/12 15:48:26.401638 [DBG] Go build version go1.6.3
[99857] 2016/08/12 15:48:26.401649 [INF] Listening for client connections on 0.0.0.0:4222
[99857] 2016/08/12 15:48:26.401715 [DBG] Server id is 0wTo6TVdAyYlrszMA94iS5
[99857] 2016/08/12 15:48:26.401719 [INF] Server is ready
[99857] 2016/08/12 15:48:26.401915 [INF] Listening for route connections on :::6222
[99857] 2016/08/12 15:48:26.401926 [FTL] Error listening on router port: 4222 - listen tcp: too many colons in address :::6222
```
Notice also that the port printed is the client port, not the route port.
Also found that there was cases where `s.Shutdown()` would block on startup failure scenario.
| https://github.com/nats-io/nats-server/issues/323 | https://github.com/nats-io/nats-server/pull/324 | 29b31010cc1cbf2a033d45c4f559aa750133a336 | a31e6b2b77c1a0a03d22650dd0cc687a2caab489 | 2016-08-12T21:53:52Z | go | 2016-08-12T22:20:36Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 322 | ["main.go", "server/opts.go", "server/opts_test.go", "server/route.go", "server/server.go", "test/routes_test.go"] | Add a parameter to disable sending async INFOs | This is in reference to https://github.com/nats-io/ruby-nats/issues/127
We should have the ability to disable the push of cluster's IPs to clients, even the one that support receiving async INFOs. A server-side parameter has been discussed as the best option.
| https://github.com/nats-io/nats-server/issues/322 | https://github.com/nats-io/nats-server/pull/326 | a31e6b2b77c1a0a03d22650dd0cc687a2caab489 | 638e249d2a9b33294d292d8b273cd60546831569 | 2016-08-12T14:57:17Z | go | 2016-08-16T00:27:42Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 321 | ["server/server.go", "server/server_test.go"] | link local v6 addresses in announced server list | Using latest gnatsd and the ruby gem I noticed the announced list includes link local addresses:
```
% curl -s localhost:8222/varz|jq .connect_urls
[
"10.1.71.185:4222",
"[fe80::207:cbff:fe03:9905]:4222",
"172.17.0.1:4222",
"[fe80::42:eff:fe14:e413]:4222",
"10.1.71.207:4222",
"[fe80::207:cbff:fe03:bbc4]:4222"
]
```
Link locals are not reachable from anywhere and so should be filtered, I confirmed these are announced to clients too:
```
NATS.start(options) do |c|
Log.info("NATS is connected to %s in a pool of %s" % [c.connected_server, c.server_pool.map{|s| s[:uri].to_s}])
end
```
```
info NATS is connected to nats://dev1.example.net:4222 in a pool of ["nats://dev1.example.net:4222", "nats://dev4.example.net:4222", "nats://dev2.example.net:4222", "nats://10.1.71.1
85:4222", "nats://[fe80::207:cbff:fe03:9905]:4222", "nats://172.17.0.1:4222", "nats://[fe80::42:eff:fe14:e413]:4222", "nats://10.1.71.207:4222", "nats://[fe80::207:cbff:fe03:bbc4]:4222"]
```
In the gnatsd config I do not tell it to bind to any particular address so it'll bind everywhere which is desirable, but it shouldn't include link locals in this announcement:
```
gnatsd[17653]: [17653] 2016/08/11 06:20:50.414243 [INF] Listening for client connections on 0.0.0.0:4222
gnatsd[17653]: [17653] 2016/08/11 06:20:50.416106 [INF] Listening for route connections on 0.0.0.0:4223
```
| https://github.com/nats-io/nats-server/issues/321 | https://github.com/nats-io/nats-server/pull/325 | 62923be357d99504f725ffc2ff27bcfc69f1943e | 29b31010cc1cbf2a033d45c4f559aa750133a336 | 2016-08-11T11:32:24Z | go | 2016-08-12T22:19:43Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 310 | ["server/pse/pse_test.go", "server/pse/pse_windows_test.go"] | Test TestPSEmulation fails when runs without -race parameter | Environment: go 1.6.2, ubuntu 16.04 64-bit.
without `-race`:
```
$ go test -v -run=TestPSEmulation ./server/pse
=== RUN TestPSEmulation
--- FAIL: TestPSEmulation (0.01s)
pse_test.go:49: RSSs did not match close enough: 2920448 vs 2154496
FAIL
exit status 1
FAIL github.com/nats-io/gnatsd/server/pse 0.010s
```
with `-race`
```
$ go test -race -v -run=TestPSEmulation ./server/pse
=== RUN TestPSEmulation
--- PASS: TestPSEmulation (0.01s)
PASS
ok github.com/nats-io/gnatsd/server/pse 1.015s
```
| https://github.com/nats-io/nats-server/issues/310 | https://github.com/nats-io/nats-server/pull/311 | fa4d3da26a313516e19d168dc40302218d8a6e2c | d95765f0528fd38bd292095b4da62b22606a91f8 | 2016-07-18T18:59:30Z | go | 2016-07-18T19:12:29Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 304 | ["server/monitor.go", "server/monitor_test.go"] | the style sheet for http://localhost:8222/ has non-ascii curly-quotes | When you fetch the `/` URL from the control port (8222) it gives you a simple HTML document with links to the other "real" endpoints. The style sheet in that document contains fancy curly-quotes:
```
body { font-family: “Century Gothic”, CenturyGothic, AppleGothic, sans-serif; font-size: 22; }
```
Note the quotes around Century Gothic. The first is UTF8 e2 80 9c and the second is UTF8 e2 80 9d. They should be plain old double quotes as the document itself does not declare UTF8 encoding.
Running "version": "0.8.1".
| https://github.com/nats-io/nats-server/issues/304 | https://github.com/nats-io/nats-server/pull/353 | e41d360e77711885108008ccb6735a5b7637dd8e | 8caed5eefdbb4b5c9455729343c8006cec71da21 | 2016-06-27T15:56:01Z | go | 2016-09-13T03:29:46Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 290 | ["server/pse/pse_openbsd.go"] | Is gnatsd/server/pse/pse_${GOOS}.go essential? | New to gnatsd (nats-server), and one of my dev boxes happens to be openbsd.
In order for `go build` to succeed on openbsd, I copied pse_solaris.go to pse_openbsd.go. With that, I was able to build, run, and follow the telnet "hello world" example. Totally working.
Or is it? What I am missing by having just a stub implementation of pse_openbsd.go? Under what circumstances do pse.ProcUsage results change gnatsd behavior?
BTW, before copying pse_solaris.go, I copied pse_freebsd.go thinking it might just work on openbsd. Doesn't. It also has a compilation error, and undefined variable "errno" on line 41.
| https://github.com/nats-io/nats-server/issues/290 | https://github.com/nats-io/nats-server/pull/661 | 9b90e7d665a017fd02916820abd02eb8e3e7a99e | e8b524aed6da4091892045fa80bd1b2ee2df5529 | 2016-05-30T00:26:11Z | go | 2018-03-29T18:37:02Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 289 | ["server/client.go"] | Server can send "authorization timeout" to client after accepting its CONNECT | In some race conditions, I believe that it is possible for the server to still send an authorization timeout (and close the connection) to a client after accepting its `CONNECT` protocol and responding to a `PING`. The issue is that then the client receives this error through its readLoop (not during the connect/reconnect handshake) which causes the client library to close the connection, preventing any reconnect.
I believe that the server should check the returned boolean from `c.atmr.Stop()` which, if `false`, would indicate that the timer could not be stopped, likely because the routine has been started/is executing. In this case, the server should return the auth timeout error in place and close the connection to prevent the client from receiving `PONG` and start its readLoop.
| https://github.com/nats-io/nats-server/issues/289 | https://github.com/nats-io/nats-server/pull/294 | 1ac5f97d44d530b6ed2237551ea4297e8519a33b | f2c17eb159e1fcc5859b25b632a60c26506f0665 | 2016-05-26T16:53:03Z | go | 2016-06-07T19:43:26Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 270 | ["server/parser.go", "server/split_test.go"] | NATS cluster: tons of Error reading from client: invalid character '"' after top-level value | Hello, I'm trying to start introducing NATS as a microservice communication protocol on mesos. I'm using mesos master nodes as seed nodes for NATS and each mesos slave runs gnatsd pointing to those seed nodes. I observed a peculiar flood of messages once I start/restart a bunch of mesos slaves (and gnatsd as it runs on those slaves).
This is small extract from gnats log:
> [7723] 2016/05/11 16:42:37.015681 [ERR] 10.21.0.31:7222 - rid:96441 - Route Error {"server_id":"OWN6ITRHRzycwYnuZVpESI","version":"0.8.0","go":"","host":"10.21.0.9","port":7222,"auth_required":false,"ssl_required":false,"tls_required":false,"tls_verify":false,"max_payload":1048576,"ip":"nats-route://10.21.0.9:7222/"}Parser Error'
> [7723] 2016/05/11 16:42:37.016299 [ERR] 10.21.0.20:48898 - rid:96291 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.017219 [ERR] 10.21.0.3:7222 - rid:96502 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.018002 [ERR] 10.21.0.11:7222 - rid:91454 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.018738 [ERR] 10.21.0.30:35941 - rid:96520 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.021777 [ERR] 10.21.0.25:23365 - rid:96456 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.022236 [ERR] 10.21.0.34:28619 - rid:96325 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.025008 [ERR] 10.21.0.20:7222 - rid:96523 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.026082 [ERR] 10.21.0.25:7222 - rid:96535 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.027167 [ERR] 10.21.0.11:3391 - rid:96527 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.028311 [ERR] 10.21.0.14:56649 - rid:96437 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.028988 [ERR] 10.21.0.3:57138 - rid:96524 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.029456 [ERR] 10.21.0.31:7222 - rid:96522 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.035386 [ERR] 10.21.0.4:7222 - rid:96442 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.055451 [ERR] 10.21.0.37:3716 - rid:96492 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.057689 [ERR] 10.21.0.3:7222 - rid:96543 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.075498 [ERR] 10.21.0.33:7222 - rid:96436 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.407565 [ERR] 10.21.0.20:7222 - rid:96540 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.411138 [ERR] 10.21.0.17:29337 - rid:96486 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.413138 [ERR] 10.21.0.22:65103 - rid:96241 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.413265 [ERR] 10.21.0.34:28632 - rid:96539 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.424351 [ERR] 10.21.0.38:50446 - rid:96334 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.431253 [ERR] 10.21.0.19:35303 - rid:96376 - Route Error 'Parser Error'
> [7723] 2016/05/11 16:42:37.458023 [ERR] 10.21.0.15:38285 - rid:96521 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.470157 [ERR] 10.21.0.37:3758 - rid:96564 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.471790 [ERR] 10.21.0.9:13872 - rid:96479 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.496984 [ERR] 10.21.0.20:7222 - rid:96624 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.497997 [ERR] 10.21.0.9:15451 - rid:96669 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.500422 [ERR] 10.21.0.12:7863 - rid:96530 - Route Error {"server_id":"OWN6ITRHRzycwYnuZVpESI","version":"0.8.0","go":"","host":"10.21.0.9","port":7222,"auth_required":false,"ssl_required":false,"tls_required":false,"tls_verify":false,"max_payload":1048576,"ip":"nats-route://10.21.0.9:7222/"}Parser Error'
> [7723] 2016/05/11 16:42:37.527624 [ERR] 10.21.0.16:57330 - rid:96500 - Error reading from client: invalid character '"' after top-level value
> [7723] 2016/05/11 16:42:37.572838 [ERR] 10.21.0.18:14535 - rid:96519 - Route Error 'Parser Error'
I tried using -DV flag for more info but I could not find anything related so I decided not to include it here as it's super verbose.
As a side effect noticed that sometimes (rarely) some of the gnatsd on mesos slaves keep running but are not connected to the rest of the cluster. Another case is when I restart gnatsd on one of the slave and it produces a cascading flood of logs like above. While observing /routez monitoring endpoint I can see "num_rutes" going up and down as if propagating routes cycles other live gnatsd instances.
Configuration files for seed nodes (routes changes depending on server):
```
port: 4222
http_port: 8222
cluster {
host: '10.21.0.2'
port: 7222
routes = [
nats-route://mesos-master-2:7222
nats-route://mesos-master-3:7222
]
}
```
Configuration for slave nodes:
```
port: 4222
cluster {
host: '10.21.0.30' # Managed by startup script
port: 7222
routes = [
nats-route://mesos-master-1:7222
nats-route://mesos-master-2:7222
nats-route://mesos-master-3:7222
]
}
```
I'm not certain if there is something wrong with the configuration files or my idea to run gnatsd on each mesos slave (for mesh cluster) is not the best use case for NATS.
If you need more details - let me know. I can alter configuration and deploy test code if needed.
| https://github.com/nats-io/nats-server/issues/270 | https://github.com/nats-io/nats-server/pull/271 | 26caad27c1073cbeada88c89204f3908919e1129 | e1bd6f7eafaadafe6692c45a5282c9a1628aabae | 2016-05-11T17:02:17Z | go | 2016-05-11T23:17:02Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 209 | ["go.mod", "go.sum"] | feature request: cluster membership changes sent to client connections | Because clients may be started before servers in a cluster, and server membership in a cluster may change, it is a chicken-and-egg problem to tell all clients about all servers. And impossible to do with a static configuration file for a client.
However, the fault tolerance guarantees of a gnatsd cluster depend critically on clients knowing about all servers in the cluster. If clients do not know about all currently running servers, then the system is no longer fault tolerant.
Hence this issue requests a mechanism to lets gnatsd tell clients about all servers in the cluster (perhaps in a heartbeat published on a "system topic"; perhaps in a reply to a request sent directly to the gnatsd server); so the clients wishing to be fault-tolerant can keep up to date with a dynamic server-cluster membership.
It could simply be a "system" topic that clients can subscribe to, that gnatsd itself publishes on every when a request for such information is made.
The part that would require some nats client smarts would be having the Go nats client automatically update that list of servers into its connection information. This would allow me to user the infinite auto-reconnect feature of the Go client in a fault-tolerant manner.
| https://github.com/nats-io/nats-server/issues/209 | https://github.com/nats-io/nats-server/pull/4748 | 9dfc52d216a3a1dfcbab0d92b74459506e56a942 | b10a0cb61b689ac07056a7f890e0bcfb81e27799 | 2016-02-20T22:14:37Z | go | 2023-11-06T16:46:02Z |
closed | nats-io/nats-server | https://github.com/nats-io/nats-server | 194 | ["server/client.go", "server/client_test.go", "server/websocket.go"] | how to determine the nats-client port number? | I'm looking at nats-top at the clients listed. I see two clients, but they are only distinguished by having different ports.
```
gnatsd version 0.7.3 (uptime: 16m53s)
Server:
Load: CPU: 0.0% Memory: 10.4M Slow Consumers: 0
In: Msgs: 6 Bytes: 18.2K Msgs/Sec: 0.0 Bytes/Sec: 0
Out: Msgs: 0 Bytes: 0 Msgs/Sec: 0.0 Bytes/Sec: 0
Connections: 2
HOST CID SUBS PENDING MSGS_TO MSGS_FROM BYTES_TO BYTES_FROM LANG VERSION
127.0.0.1:54028 1 0 0 0 0 0 0 go 1.1.7
127.0.0.1:54027 2 0 0 0 6 0 18.2K go 1.1.7
```
How do I tell what port a given client has bound? So I can tell which client is getting traffic through?
Looking at github.com/nats-io/nats/nats.go: the nats.Conn structure looks as though it has a conn net.Conn, but it is private so I can't ask it what its port is.
Suggestion: make that net.Conn public, or provide AddressPort() method that returns the IP and Port in use by the client.
| https://github.com/nats-io/nats-server/issues/194 | https://github.com/nats-io/nats-server/pull/4084 | e96ae0bf79a2a3737b00376636cd1d04194c244c | 01041ca1a659fae5a3852aeb947ff4a38f9c8aeb | 2016-02-05T07:01:55Z | go | 2023-04-21T17:06:39Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,249 | ["src/main/java/org/cryptomator/ui/vaultoptions/VaultOptionsController.java"] | Locked Vault Options after unlocking vault | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Vault Options should not be customizable once a vault is unlocked.
### What software is involved?
- Operating System: all
- Cryptomator: all
- …
### Volume Type
None
### Steps to Reproduce
1. Open the Vault Options of any vault.
2. Unlock the vault via the TrayMenu.
### Expected Behavior
Vault Options should no longer be customizable after unlocking.
### Actual Behavior
Vault Options are still customizable after unlocking.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/3249 | https://github.com/cryptomator/cryptomator/pull/3267 | daa026b2851e7e6ad9b191710a248d3a6f531303 | 828fd321cc48dbc0d862b0e9f07d05f91b0427b6 | 2023-12-08T10:57:09Z | java | 2024-01-16T11:32:36Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,247 | ["src/main/java/org/cryptomator/ui/keyloading/hub/HubConfig.java", "src/main/java/org/cryptomator/ui/keyloading/hub/ReceiveKeyController.java", "src/main/java/org/cryptomator/ui/keyloading/hub/RegisterSuccessController.java", "src/main/resources/fxml/hub_register_success.fxml", "src/main/resources/i18n/strings.properties"] | Relax the policy to create a Hub device when unlocking a vault | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
As a Hub user, I want to create a device even though there is no key for me to unlock the vault yet.
### Motivation
In the current implementation, if someone sets up a Hub account for you and says they have shared a vault with you. Full of anticipation, you put the vault in the desktop application, log in, set up the account, and then you get a "no access" dialogue.
Now it would be nice if you could create the device before getting the "no access" dialogue. The reason for this is that if the vault owner has updated the vault permissions, you can unlock the vault directly without any further interaction.
Currently you have to create the device after the vault owner has updated the vault privileges, and have the feeling twice that you cannot unlock the vault directly. I would like to reduce this to once.
There is no cryptographic or other technical reason for this limitation.
### Considered Alternatives
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/3247 | https://github.com/cryptomator/cryptomator/pull/3287 | b1a5eed2aad7be6a5b68c9affe278b0e1c8db9f0 | 325057c54866e91138e9ff6250fe13419911fcc1 | 2023-12-06T22:01:24Z | java | 2024-01-17T12:32:09Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,246 | ["src/main/java/org/cryptomator/ui/common/FxmlFile.java", "src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java", "src/main/java/org/cryptomator/ui/keyloading/hub/LegacyRegisterDeviceController.java", "src/main/java/org/cryptomator/ui/keyloading/hub/LegacyRegisterSuccessController.java", "src/main/resources/fxml/hub_legacy_register_device.fxml", "src/main/resources/fxml/hub_legacy_register_success.fxml", "src/main/resources/fxml/hub_register_success.fxml", "src/main/resources/i18n/strings.properties"] | Cryptomator tells me that when creating a new Hub device, the device needs to be authorised by the Vault owner | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Cryptomator tells me that when creating a new Hub device, the device needs to be authorised by the Vault owner
### What software is involved?
- Operating System: Linux
- Cryptomator: 1.11.1
- Hub: 1.3.0
### Volume Type
None
### Steps to Reproduce
Register a new device in Hub
### Expected Behavior
Cryptomator notifies my about its success and tells me to unlock again the vault (or directly tries it again?) but does not say anything about the vault owner.
### Actual Behavior
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
A newly added device does not need to be authorized by the vault owner. | https://github.com/cryptomator/cryptomator/issues/3246 | https://github.com/cryptomator/cryptomator/pull/3288 | ed902bc59f7ea870abf3bf80d835a858cf5535ac | f50b204cef02f0e879fc6d5938a80b5c926e16ef | 2023-12-06T21:46:54Z | java | 2024-01-22T13:56:45Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,233 | ["src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultLocationController.java", "src/main/resources/fxml/addvault_new_location.fxml"] | Loading LocationPreset in create vault workflow blocks UI | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
If loading and checking the location presets takes a long time, the UI does not proceed to the select-location-screen until all locationPresets are loaded.
### What software is involved?
- Operating System: -/-
- Cryptomator: 1.11.1
### Volume Type
None
### Steps to Reproduce
1. Open Cryptomator
2. Start workflow "create new vault"
3. Enter name and click "Next" button
### Expected Behavior
UI should proceed to select-storage-location-screen.
### Actual Behavior
UI stays the same, does not proceed.
### Reproducibility
Intermittent
### Relevant Log Output
_No response_
### Anything else?
First described in our forum: https://community.cryptomator.org/t/cannot-create-a-vault/13162 | https://github.com/cryptomator/cryptomator/issues/3233 | https://github.com/cryptomator/cryptomator/pull/3327 | a013ae3d91c44df50833edddd5906cecc9a1faab | 251ad65344389d1c365d9740571110e16274a8bc | 2023-11-29T17:34:20Z | java | 2024-02-16T15:21:01Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,155 | ["src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java"] | Double click on vault in list to toggle lock status | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Double click on vault in list to toggle lock status
### Motivation
As a minor convenience for more quickly (un-)locking vaults, how about allowing to double-click on a vault's entry in the left-hand side list of vaults to quickly toggle it's lock status?
### Considered Alternatives
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/3155 | https://github.com/cryptomator/cryptomator/pull/3194 | 09ced505906da874484251048a3f8271f50e6eb4 | 19cc4e8a372e640f47196c5b1251365e72e48bc1 | 2023-10-16T11:19:25Z | java | 2023-11-15T15:51:44Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,130 | [".github/workflows/win-exe.yml", "dist/win/build.ps1", "dist/win/resources/main.wxs"] | Windows: MSI Installer blocked by Smart App Control | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
I am unable to install Cryptomator with the MSI, because it is blocked by Smart App Control.
### What software is involved?
- Operating System: Windows 11
- Cryptomator: 1.10.1
### Volume Type
None
### Steps to Reproduce
Prerequisites: Smart App must be turned on.
1. Run Cryptomator msi installer
### Expected Behavior
Welcome screen of installer is shown and user is able to continue installation.
### Actual Behavior
Windows Smart App screen pops up, stating that "installation is being blocked by Smart App Control as the Cryptomator.msi file is unknown to Windows and they don't know who published it". A link provided in the screen sends you to the following site: https://support.microsoft.com/en-us/topic/smart-app-control-has-blocked-part-of-this-app-0729fff1-48bf-4b25-aa97-632fe55ccca2
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
Was already reported in our community some time ago, but without resolution: https://community.cryptomator.org/t/smart-app-control-blocks-fuse-and-webdav/10834 | https://github.com/cryptomator/cryptomator/issues/3130 | https://github.com/cryptomator/cryptomator/pull/3131 | 1debe4c7c8593e24d6fa8f81db9da6d19913eefc | 560a979e0eac172835ea1de9ab7cc245611630f3 | 2023-09-28T09:41:52Z | java | 2023-10-16T14:21:08Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,117 | [".github/workflows/debian.yml", "dist/linux/debian/rules", "src/main/java/org/cryptomator/common/Environment.java", "src/main/java/org/cryptomator/ui/fxapp/FxApplication.java", "src/main/java/org/cryptomator/ui/fxapp/UpdateChecker.java", "src/main/java/org/cryptomator/ui/preferences/PreferencesController.java"] | Disable Update Check via System Property | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Add a new system property to disable update checks
### Motivation
The dialog added in #2998 is currently shown to all users, regardless of how Cryptomator is installed. There are however scenarios, in which updates are managed externally, e.g. when using package managers.
In such cases, the "internal" update check is superfluous.
### Considered Alternatives
_No response_
### Anything else?
Related suggestion: https://github.com/cryptomator/cryptomator/issues/275#issuecomment-1334517305 | https://github.com/cryptomator/cryptomator/issues/3117 | https://github.com/cryptomator/cryptomator/pull/3118 | 0ed7415a0d4a06a80949e65cfb285ea988028379 | f9b170204a4345b8a872e3615d097fb873ce21c9 | 2023-09-18T11:01:32Z | java | 2023-09-20T09:02:14Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,113 | [".idea/compiler.xml", "pom.xml", "src/main/java/org/cryptomator/ui/error/ErrorController.java", "src/main/java/org/cryptomator/ui/fxapp/UpdateCheckerModule.java", "src/main/java/org/cryptomator/ui/keyloading/hub/AuthFlowTask.java"] | Add timeout to network requests | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Add to all network requests a timeout.
### Motivation
Currently, network requests done by Cryptomator (update check, unlock of [Hub](https://cryptomator.org/hub) vaults) do not specify a timeout. This can confuse users due to missing feedback/endless response waiting, especially, if different applications with explicit proxy settings have internet access.
### Considered Alternatives
_No response_
### Anything else?
We can use system properties: https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/net/doc-files/net-properties.html#misc-http-url-stream-protocol-handler-properties-heading . But this should be tested in combination with the new HttpClient API, which is used by Cryptomator. Additionally, side effects for the WebDAV-Impl needs to be considered. | https://github.com/cryptomator/cryptomator/issues/3113 | https://github.com/cryptomator/cryptomator/pull/3157 | 5c5777ffc59aced3a9dc5e202f9a603dbebda6de | 800b2440b37db7a90dae01309a6a33ce5e5defad | 2023-09-13T09:36:13Z | java | 2023-10-20T10:58:08Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,079 | ["src/main/java/org/cryptomator/ui/mainwindow/MainWindowComponent.java"] | Minimized window not restored through show button in tray icon | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
In Windows 11, a minimized window is not restored when selecting show through the tray icon
### What software is involved?
- Operating System: Windows 11
- Cryptomator: 1.9.1, develop branch
### Volume Type
None
### Steps to Reproduce
There are two variants:
1.1. Open Cryptomator window and make sure _show minimize_ and _show tray icon_ is selected in preferences
1.2. Minimize Cryptomator to system bar
1.3. Press show in the tray icon
2.1. Open Cryptomator window and make sure _show minimize_ and _show tray icon_ is selected in preferences
2.2. Minimize Cryptomator to system bar
2.3. Right click the icon in the system bar and select close
2.4. Press show in the tray icon
### Expected Behavior
The Cryptomator window should show
### Actual Behavior
The Cryptomator window does not show
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
When using Linux (KDE neon 5.27.7) it works as expected.
I think the first variant can be fixed by inserting `stage.setIconified(false);` before show:
https://github.com/cryptomator/cryptomator/blob/8a7a5eeea15fd8754001546867584ab49bb5fc79/src/main/java/org/cryptomator/ui/mainwindow/MainWindowComponent.java#L29
I am not sure about the second variant but it appears that in Windows the x and y of the window are near -32000 while in Linux they are within display bounds.
| https://github.com/cryptomator/cryptomator/issues/3079 | https://github.com/cryptomator/cryptomator/pull/3080 | 0e52b7aff435e88c7b9e2fd56a00ba267ab551f9 | cf248c5cbc5b6950d24f0ae67b6a58de07e79773 | 2023-08-19T14:25:38Z | java | 2023-09-01T14:06:15Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,077 | ["pom.xml"] | Cannot save modified Word 365 document “Network or file permission error” | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Using the latest Microsoft 365 on Windows 10, when trying to edit a Word document which is mounted through Cryptomator 1.9.3 the save fails: “There has been a network or file permission error. The network connection may be lost.”
### What software is involved?
- Operating System: Windows 10 or 11
- Cryptomator: 1.9.3
- Microsoft® Word for Microsoft 365 MSO (Version 2307 Build 16.0.16626.20170) 64-bit
Using the latest Office 365 on Windows 10, when trying to edit a Word document with Cryptomator 1.9.3 the save fails: “There has been a network or file permission error. The network connection may be lost.”
Uninstall v1.9.3 and install 1.6.17 from github archive, and it works fine.
### Volume Type
None
### Steps to Reproduce
1. Install cryptomater 1.9.3 on windows 10/11
2. make a new vault, and save it to Dropbox (using the wizard option)
3. reveal/mount in Explorer
4. copy/move a word document from elsewhere to the vault. This works fine - encrypted file uploads to dropbox
5. Open word dpocument, make changes, click change. This fails with "There has been a network or file permission error. The network connection may be lost.”
Uninstall 1.9.3 and install 1.6.17 and repeat steps (1 and 2 not needed since vault is automatically discovered), and it works fine. Make edits in word doc, click save and no problems. Dropbox file sync tool shows file updated to dropbox
### Expected Behavior
**Make edits in word doc, click save and no problems. Dropbox file sync tool shows file updated to dropbox**
### Actual Behavior
cannot save, error: "There has been a network or file permission error. The network connection may be lost.”
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
found the same here:
https://community.cryptomator.org/t/cannot-save-modified-word-365-document-network-or-file-permission-error/12325/1 | https://github.com/cryptomator/cryptomator/issues/3077 | https://github.com/cryptomator/cryptomator/pull/3089 | ad97338f9bb3b536cbc072ca5715c01d6e8060b0 | 864c1c9c0d7906d8420285cf7a5cd5eea32738bf | 2023-08-18T12:50:52Z | java | 2023-08-29T05:48:37Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,075 | [".github/workflows/appimage.yml", ".github/workflows/check-jdk-updates.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/win-exe.yml", "dist/linux/debian/control"] | Specify which Java version Cryptomator should use for testing, building and shipping, pin it and have it updated semi-automatically. | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Specify which Java version Cryptomator should use for testing, building and shipping, pin it and have it updated semi-automatically.
### Motivation
For the https://github.com/cryptomator/cryptomator/releases/tag/1.9.4 we introduced https://github.com/cryptomator/cryptomator/commit/ef4738f92048a43f3a84dfb47738d229173fd367 because our Mac ARM runner did cache the Java runtime and therefore did not use the latest 20.0.2v Java version which was the reason for this release, see https://github.com/cryptomator/cryptomator/actions/runs/5784809971/job/15715418321
```
Run actions/setup-java@v3
with:
distribution: zulu
java-version: 20
java-package: jdk+fx
architecture: aarch64
cache: maven
check-latest: false
...
env:
JAVA_VERSION: 20
Installed distributions
Resolved Java 20.0.1+9 from tool-cache
Setting Java 20.0.1+9 as the default
Creating toolchains.xml for JDK version 20 from zulu
Overwriting existing file /Users/quicksilver/.m2/toolchains.xml
Java configuration:
Distribution: zulu
Version: 20.0.1+9
Path: /Users/quicksilver/Developer/actions-runner/_work/_tool/Java_Zulu_jdk+fx/20.0.1-9/aarch64
Creating settings.xml with server-id: github
Overwriting existing file /Users/quicksilver/.m2/settings.xml
maven cache is not found
```
https://github.com/cryptomator/cryptomator/commit/ef4738f92048a43f3a84dfb47738d229173fd367 adds https://github.com/actions/setup-java/tree/main#check-latest for the release.
Maybe we should also enable it for all other CI builds otherwise it could happen that released version behaves differently than the tested variant. On the other side this still can happen because we only define we want to have an zulu Java 20 version, if after testing and before release another minor is released, the same would happen.
Therefore we should pin the exact version and update it semi-automatically (create an PR) using an bot so we have full control over it.
### Considered Alternatives
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/3075 | https://github.com/cryptomator/cryptomator/pull/3163 | f893b2b5bedb85d7e4c0e6ad0a071e98acaf03e2 | 7b522582fbdd78909367670fa0933789b79431f3 | 2023-08-15T14:25:48Z | java | 2023-10-27T10:51:49Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,056 | ["pom.xml"] | Cannot chose OneDrive target which contains an umlaut | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
If a suggested target location at which to create a vault contains an umlaut, it is not possible to select the target location.
### What software is involved?
- Operating System: Windows 11
- Cryptomator: 1.9.2 (msi-4510)
- OneDrive build 23.156.0726.0003 (64-Bit)
### Volume Type
None
### Steps to Reproduce
1. You need a OneDrive target/sync that contains an umlaut such as "ä" in my case. The full name of the target I have is "OneDrive - Universität xyz".
2. Create a new vault ("Add Vault" dialog), chose any name.
3. After clicking next, you will see the above mentioned OneDrive location as "OneDrive - Universit�t xyz", where the "ä" has been replaced with the "questionmark in a diamond".
### Expected Behavior
It should be possible to use this OneDrive installation as any other target for the vault.
### Actual Behavior
When selecting the location, the error message "A directory in the speicified path does not exist or cannot be accessed" ist shown below the "Storage location" text box. Note that this cannot be edited.
It is possible to manually select "Custom location", then navigate to the OneDrive location and use it as the target location.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/3056 | https://github.com/cryptomator/cryptomator/pull/3089 | ad97338f9bb3b536cbc072ca5715c01d6e8060b0 | 864c1c9c0d7906d8420285cf7a5cd5eea32738bf | 2023-08-03T21:12:33Z | java | 2023-08-29T05:48:37Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,032 | ["pom.xml"] | Unable to quit Cryptomator and system froze if open pdfs with PDF Expert | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Unable to quite Cryptomator
### What software is involved?
- Operating System: macOS 13.4 (22F66) MacBook Air M2 2022
- Cryptomator: 1.9.0 (dmg-4493)
- [PDF Expert](https://pdfexpert.com/): Version 3.2.2 (946)
- Chrome: Version 114.0.5735.248 (Official Build) (arm64)
- Firefox: 115.0.2 (64-bit)
- Volume Type: Automatic
<img width="401" alt="CS-mrWZu2uG@2x" src="https://github.com/cryptomator/cryptomator/assets/33796896/2c4fed1b-e910-4946-b11a-77d6237697d8">
### Volume Type
None
### Steps to Reproduce
1. Open Cryptomator and unlock any vault
2. Open a pdf file with PDF Expert
3. Close PDF Expert
4. Click `Quit` Cryptomator
### Expected Behavior
Cryptomator will quite successfully
### Actual Behavior
If I click lock or quit, I will see one of the following
<img width="497" alt="CS-MkLtOUmg@2x 2" src="https://github.com/cryptomator/cryptomator/assets/33796896/5b66ba4e-2b2a-4580-a591-c5fa646dd71a">
If I click `Cancel`, my mouse will become a spinning wheel.
If I click `Force and Quit`, Cryptomator won't quit and will stay on the meau bar. I have to force quit it in Activity Monitor
After that, my system looks find, but I can't Restart or Shut Down my system anymore.
If I open Chrome, it won't be able to open any website or quit. If I use Firefox, I can open websites but won't be able to quit it either.
I must hold my Power Button to shut down and reboot the system completely to back to normal.
<img width="631" alt="CS-nb2EL1Yu@2x" src="https://github.com/cryptomator/cryptomator/assets/33796896/65faff98-a4e1-4bb3-8b55-12612e2cfec8">
I have also tried to completely quit PDF Expert before lock any vault or quit Cryptomator, but the issue persisted.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
Related? https://github.com/cryptomator/cryptomator/issues/2757 | https://github.com/cryptomator/cryptomator/issues/3032 | https://github.com/cryptomator/cryptomator/pull/3073 | de78cd014d27df838d2f1c1bf1329379da5e5d9f | dc80d79da03b0db00750a28769e9a04e504fdff0 | 2023-07-25T23:38:27Z | java | 2023-08-14T08:42:34Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 3,030 | [".github/workflows/mac-dmg.yml", "dist/mac/dmg/build.sh"] | Building macOS dmg with Zulu+FX JVM fails | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Current macOS CI build fail, see https://github.com/cryptomator/cryptomator/actions/runs/5646443055/job/15317844949#step:8:56.
### What software is involved?
- Operating System: macOS Github runner
- Cryptomator: 1.10.0-beta1
### Volume Type
None
### Steps to Reproduce
1. Run macOS build
### Expected Behavior
Builds produces dmg
### Actual Behavior
Build fails while building custom JVM/ executing jlink
### Reproducibility
Always
### Relevant Log Output
```shell
Run ${JAVA_HOME}/bin/jlink --verbose --output runtime --module-path "${JAVA_HOME}/jmods" --add-modules java.base,java.desktop,java.instrument,java.logging,java.naming,java.net.http,java.scripting,java.sql,java.xml,javafx.base,javafx.graphics,javafx.controls,javafx.fxml,jdk.unsupported,jdk.crypto.ec,jdk.accessibility,jdk.management.jfr --strip-native-commands --no-header-files --no-man-pages --strip-debug --compress=1
${JAVA_HOME}/bin/jlink --verbose --output runtime --module-path "${JAVA_HOME}/jmods" --add-modules java.base,java.desktop,java.instrument,java.logging,java.naming,java.net.http,java.scripting,java.sql,java.xml,javafx.base,javafx.graphics,javafx.controls,javafx.fxml,jdk.unsupported,jdk.crypto.ec,jdk.accessibility,jdk.management.jfr --strip-native-commands --no-header-files --no-man-pages --strip-debug --compress=1
shell: /bin/bash -e {0}
env:
JAVA_VERSION: 20
JAVA_HOME: /Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64
JAVA_HOME_20_X64: /Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64
java.base file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.base.jmod
java.datatransfer file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.datatransfer.jmod
java.desktop file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.desktop.jmod
java.instrument file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.instrument.jmod
java.logging file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.logging.jmod
java.management file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.management.jmod
java.naming file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.naming.jmod
java.net.http file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.net.http.jmod
java.prefs file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.prefs.jmod
java.scripting file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.scripting.jmod
java.security.sasl file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.security.sasl.jmod
java.sql file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.sql.jmod
java.transaction.xa file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.transaction.xa.jmod
java.xml file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/java.xml.jmod
javafx.base file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/javafx.base.jmod
javafx.controls file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/javafx.controls.jmod
javafx.fxml file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/javafx.fxml.jmod
javafx.graphics file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/javafx.graphics.jmod
jdk.accessibility file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/jdk.accessibility.jmod
jdk.crypto.ec file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/jdk.crypto.ec.jmod
jdk.jfr file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/jdk.jfr.jmod
jdk.management file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/jdk.management.jmod
jdk.management.jfr file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/jdk.management.jfr.jmod
jdk.unsupported file:///Users/runner/hostedtoolcache/Java_Zulu_jdk+fx/20.0.2-9/x64/jmods/jdk.unsupported.jmod
Providers:
java.desktop provides java.net.ContentHandlerFactory used by java.base
java.base provides java.nio.file.spi.FileSystemProvider used by java.base
java.naming provides java.security.Provider used by java.base
java.security.sasl provides java.security.Provider used by java.base
jdk.crypto.ec provides java.security.Provider used by java.base
java.base provides java.util.random.RandomGenerator used by java.base
java.desktop provides javax.print.PrintServiceLookup used by java.desktop
java.desktop provides javax.print.StreamPrintServiceFactory used by java.desktop
java.management provides javax.security.auth.spi.LoginModule used by java.base
java.desktop provides javax.sound.midi.spi.MidiDeviceProvider used by java.desktop
java.desktop provides javax.sound.midi.spi.MidiFileReader used by java.desktop
java.desktop provides javax.sound.midi.spi.MidiFileWriter used by java.desktop
java.desktop provides javax.sound.midi.spi.SoundbankReader used by java.desktop
java.desktop provides javax.sound.sampled.spi.AudioFileReader used by java.desktop
java.desktop provides javax.sound.sampled.spi.AudioFileWriter used by java.desktop
java.desktop provides javax.sound.sampled.spi.FormatConversionProvider used by java.desktop
java.desktop provides javax.sound.sampled.spi.MixerProvider used by java.desktop
java.logging provides jdk.internal.logger.DefaultLoggerFinder used by java.base
java.desktop provides sun.datatransfer.DesktopDatatransferService used by java.datatransfer
jdk.management provides sun.management.spi.PlatformMBeanProvider used by java.management
jdk.management.jfr provides sun.management.spi.PlatformMBeanProvider used by java.management
Error: jdk.tools.jlink.plugin.PluginException: Duplicate resources: {conf/management/management.properties=[jdk.management.jfr, jdk.management, jdk.unsupported], lib/javafx.properties=[javafx.base, javafx.controls, javafx.fxml], lib/libinstrument.dylib=[java.logging, java.instrument], conf/logging.properties=[java.sql, java.logging, java.transaction.xa, java.management, java.xml, jdk.jfr, javafx.base, java.naming, javafx.controls, javafx.graphics, java.scripting, javafx.fxml, java.prefs, java.net.http, jdk.accessibility, java.security.sasl, jdk.crypto.ec], lib/libj2pcsc.dylib=[java.sql, java.transaction.xa, java.xml], conf/sound.properties=[java.desktop, java.instrument], conf/management/jmxremote.access=[jdk.management.jfr, jdk.management, jdk.unsupported], lib/libmanagement.dylib=[java.naming, java.management, java.net.http], conf/management/jmxremote.password.template=[jdk.management.jfr, jdk.management, jdk.unsupported]}
Error: Process completed with exit code 1.
```
### Anything else?
There is a bug ticket on the java bug tracker with the same error message, but targets JDK 11:
https://bugs.openjdk.org/browse/JDK-8207015 | https://github.com/cryptomator/cryptomator/issues/3030 | https://github.com/cryptomator/cryptomator/pull/3033 | 3071cfbfb1f8d5760d192eb59935ce4c03941111 | 8b9d5d136e67945b497d2b43977afe199a25478f | 2023-07-25T11:07:00Z | java | 2023-07-26T17:53:48Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,981 | ["src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java", "src/main/java/org/cryptomator/ui/fxapp/FxApplicationWindows.java", "src/main/java/org/cryptomator/ui/mainwindow/MainWindowModule.java", "src/main/java/org/cryptomator/ui/unlock/UnlockInvalidMountPointController.java", "src/main/java/org/cryptomator/ui/vaultoptions/VaultOptionsComponent.java", "src/main/resources/fxml/unlock_invalid_mount_point.fxml"] | Open vault options/application preferences based on type of invalid mountpoint | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
If there is a problem while mounting to a custom mountpoint, the application displays a button to open the application preferences. In some cases the underlying configuration error needs to be resolved in the vault options.
The UI should allow the user to open the vault options _or_ application preferences based on the type of invalid custom mountpoint.
### What software is involved?
- Cryptomator: 1.9.1
### Volume Type
Any with support for custom mountpoints
### Steps to Reproduce
1. Mount to an invalid custom mounpoint
### Expected Behavior
The UI displays the correct button.
### Actual Behavior
The UI always displays the button to go to the preferences.
### Reproducibility
Always
### Relevant Log Output
_None_
### Anything else?
_Originally pointed out by @sschuberth in https://github.com/cryptomator/cryptomator/pull/2961#discussion_r1232076917_
> Done. The only nuisance now is that the generic error dialog suggest to open the app preferences, although the misconfiguration should be resolved in the vault options. [...] | https://github.com/cryptomator/cryptomator/issues/2981 | https://github.com/cryptomator/cryptomator/pull/2985 | 2c984ad4059ff680e6c3ed0701094c8e23d74cf3 | c30c90d2c3bd087cad2a19abf758310e13f3e9bc | 2023-07-03T17:31:40Z | java | 2023-07-05T14:27:55Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,813 | ["src/main/java/org/cryptomator/launcher/SupportedLanguages.java", "src/main/java/org/cryptomator/ui/preferences/InterfacePreferencesController.java", "src/test/java/org/cryptomator/launcher/SupportedLanguagesTest.java"] | Interface language list sorting does not match localization | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
The drop-down for selecting the UI language is sorted strangely
### What software is involved?
- Operating System: MacOS 12.6.3
- Cryptomator: 1.7.3
### Volume Type
None
### Steps to Reproduce
1. Open "Preferences" dialog
2. Navigate to "Interface" tab
3. open the "Language" drop-down list
### Expected Behavior
List of languages should have system default, English and then all other languages in alphabetic order.
That is, in alphabetic order with respect to the language the list is localized in (seems to be English always)
### Actual Behavior
Order is system default, English and then some order.
Example: Greek, Spanish, Filipino, Persian, French.
And "Dutch" is between three flavours of "Norwegian",
The order is probably with respect to "native" language names: Nederlands instead of Dutch, Farsi rather than Persian, Español instead of Spanish.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
screenshot:
<img width="203" alt="Screenshot 2023-03-20 at 21 36 41" src="https://user-images.githubusercontent.com/8216047/226466187-e6116cd2-5290-4d3f-aa2e-74164b11bcde.png">
| https://github.com/cryptomator/cryptomator/issues/2813 | https://github.com/cryptomator/cryptomator/pull/2882 | e8f8466d9a2747f4bf338a0fbaee13148d155e36 | 532ffb1202a5888bd0eca52b6e464383a51da855 | 2023-03-20T21:07:25Z | java | 2023-05-05T09:51:17Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,786 | ["src/main/java/org/cryptomator/common/ObservableUtil.java", "src/main/java/org/cryptomator/common/mount/MountModule.java", "src/main/java/org/cryptomator/ui/preferences/VolumePreferencesController.java", "src/main/resources/css/dark_theme.css", "src/main/resources/css/light_theme.css", "src/main/resources/fxml/preferences_volume.fxml", "src/main/resources/i18n/strings.properties"] | Change of volume type takes only effect after restart of app | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
An app restart is needed to apply changes to volume type
### What software is involved?
- Operating System: Windows 11 Pro (22621)
- Cryptomator: 1.7.2
### Volume Type
None
### Steps to Reproduce
1. open cryptomator
2. set volume type to something other than "automatic". Example WebDAV
3. restart cryptomator
4. unlock vault, open windows explorer, see WebDAV typical network drive
5. close windows explorer
6. lock vault
7. open settings, change volume type to (for example) WinFSP
8. unlock vault
9. open windows explorer
10. still WebDAV network shown as volume.
11. lock vault, close windows explorer
12. restart cryptomator
13. unlock vault
14. open windows explorer
15. volume is now shows as it should be with WinFSP
### Expected Behavior
Volume type change should take effect as soon as changed in settings.
### Actual Behavior
Cryptomator needs a restart to apply changes to volume type
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
No | https://github.com/cryptomator/cryptomator/issues/2786 | https://github.com/cryptomator/cryptomator/pull/2789 | ea2a48771fd05d259cdeacfd321f7b5ea0604256 | dfe17569e199bf831e88d299ca9fc77b36c18fb5 | 2023-03-11T16:28:43Z | java | 2023-03-30T09:23:09Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,652 | ["dist/win/contrib/version170-migrate-settings.bat", "dist/win/contrib/version170-migrate-settings.ps1", "dist/win/resources/main.wxs"] | Update to 1.7.0: Vault does not unlock but shows specifc error dialog | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
After updating from Cryptomator 1.6.17 to 1.7.0, when I unlock my vault, a specific error dialog is shown. The vault uses a custom directory as mountpoint.
### What software is involved?
- Operating System: Windows
- Cryptomator: 1.7.0-beta1
### Volume Type
_No response_
### Steps to Reproduce
1. With 1.6.17 setup a vault with a custom mount path
2. Update to 1.7.0-beta1
3. Unlock vault
### Expected Behavior
Vault unlocks
### Actual Behavior
Error dialog is shown, saying that I have to change the volume type.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
This is due to a change of the mount service from WinFspMountProvider with a local drive to one which mounts it as a network drive. | https://github.com/cryptomator/cryptomator/issues/2652 | https://github.com/cryptomator/cryptomator/pull/2654 | fb54ee04a6167ab7adb5e899f1fe083c9533cd73 | b9e57ce895dd552a938b26d47c28be2a361a4b06 | 2023-01-31T10:58:22Z | java | 2023-02-01T10:17:11Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,640 | [".github/workflows/appimage.yml", "dist/linux/appimage/build.sh", "dist/linux/debian/rules"] | Running the AppImage from develop requires the jdk.security.auth module (again) | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Running an AppImage build from develop with build.sh fails
### What software is involved?
- Operating System: Arch linux
- Cryptomator: develop
### Volume Type
FUSE
### Steps to Reproduce
1. cd dist/linux/appimage
2. ./build.sh
3. ./cryptomator-1.7.0-SNAPSHOT-x86_64.AppImage
### Expected Behavior
Cryptomator starts and shows the UI
### Actual Behavior
Cryptomator crashes with a `java.lang.ClassNotFoundException`
### Reproducibility
Always
### Relevant Log Output
```java
18:57:56.785 [main] INFO o.cryptomator.launcher.Cryptomator - Starting Cryptomator SNAPSHOT on Linux 6.1.7-arch1-1 (amd64)
18:57:56.820 [main] INFO org.cryptomator.ipc.Server - Spawning IPC server listening on socket /home/ralph/.config/Cryptomator/ipc.socket
18:57:57.318 [JavaFX Application Thread] INFO o.cryptomator.launcher.Cryptomator - JavaFX runtime started after 951ms
18:57:58.418 [JavaFX Application Thread] INFO o.f.d.c.transports.TransportBuilder - Using transport dbus-java-transport-native-unixsocket to connect to unix:path=/run/user/1000/bus
18:57:58.441 [JavaFX Application Thread] ERROR o.c.ui.fxapp.FxApplicationWindows - Failed to display stage
java.util.concurrent.CompletionException: java.util.ServiceConfigurationError: org.cryptomator.integrations.keychain.KeychainAccessProvider: Provider org.cryptomator.linux.keychain.KDEWalletKeychainAccess could not be instantiated
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)
at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Unknown Source)
at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source)
at [email protected]/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
at [email protected]/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
at [email protected]/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.util.ServiceConfigurationError: org.cryptomator.integrations.keychain.KeychainAccessProvider: Provider org.cryptomator.linux.keychain.KDEWalletKeychainAccess could not be instantiated
at java.base/java.util.ServiceLoader.fail(Unknown Source)
at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(Unknown Source)
at java.base/java.util.ServiceLoader$ProviderImpl.get(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.ArrayList.forEach(Unknown Source)
at java.base/java.util.stream.SortedOps$RefSortingSink.end(Unknown Source)
at java.base/java.util.stream.Sink$ChainedReference.end(Unknown Source)
at java.base/java.util.stream.Sink$ChainedReference.end(Unknown Source)
at java.base/java.util.stream.Sink$ChainedReference.end(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.toArray(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.toArray(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.toList(Unknown Source)
at [email protected]/org.cryptomator.common.keychain.KeychainModule.provideSupportedKeychainAccessProviders(KeychainModule.java:19)
at [email protected]/org.cryptomator.common.keychain.KeychainModule_ProvideSupportedKeychainAccessProvidersFactory.provideSupportedKeychainAccessProviders(KeychainModule_ProvideSupportedKeychainAccessProvidersFactory.java:29)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$CryptomatorComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:9097)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$CryptomatorComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:9092)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$CryptomatorComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:9086)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$MainWindowComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:6012)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.constructController(FxmlLoaderFactory.java:78)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processAttribute(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$InstanceDeclarationElement.processAttribute(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$Element.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$IncludeElement.constructValue(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$IncludeElement.constructValue(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.load(Unknown Source)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.load(FxmlLoaderFactory.java:46)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.createScene(FxmlLoaderFactory.java:63)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.createScene(FxmlLoaderFactory.java:51)
at [email protected]/org.cryptomator.ui.mainwindow.MainWindowModule.provideMainScene(MainWindowModule.java:79)
at [email protected]/org.cryptomator.ui.mainwindow.MainWindowModule_ProvideMainSceneFactory.provideMainScene(MainWindowModule_ProvideMainSceneFactory.java:38)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$MainWindowComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:5946)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.ui.mainwindow.MainWindowComponent.showMainWindow(MainWindowComponent.java:28)
... 8 common frames omitted
Caused by: java.lang.NoClassDefFoundError: com/sun/security/auth/module/UnixSystem
at org.freedesktop.dbus.connections.SASL.getUserId(SASL.java:747)
at org.freedesktop.dbus.connections.SASL.auth(SASL.java:434)
at org.freedesktop.dbus.connections.transports.AbstractTransport.authenticate(AbstractTransport.java:159)
at org.freedesktop.dbus.connections.transports.AbstractTransport.connect(AbstractTransport.java:133)
at org.freedesktop.dbus.connections.transports.TransportBuilder.build(TransportBuilder.java:335)
at org.freedesktop.dbus.connections.AbstractConnection.<init>(AbstractConnection.java:150)
at org.freedesktop.dbus.connections.impl.DBusConnection.<init>(DBusConnection.java:231)
at org.freedesktop.dbus.connections.impl.DBusConnectionBuilder.build(DBusConnectionBuilder.java:200)
at [email protected]/org.cryptomator.linux.keychain.KDEWalletKeychainAccess$ConnectedWallet.getNewConnection(KDEWalletKeychainAccess.java:94)
at [email protected]/org.cryptomator.linux.keychain.KDEWalletKeychainAccess$ConnectedWallet.connect(KDEWalletKeychainAccess.java:85)
at [email protected]/org.cryptomator.linux.keychain.KDEWalletKeychainAccess.<init>(KDEWalletKeychainAccess.java:32)
at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
... 60 common frames omitted
Caused by: java.lang.ClassNotFoundException: com.sun.security.auth.module.UnixSystem
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 74 common frames omitted
18:57:58.444 [JavaFX Application Thread] ERROR o.cryptomator.ui.fxapp.FxApplication - Failed to show main window
java.util.concurrent.CompletionException: java.util.ServiceConfigurationError: org.cryptomator.integrations.keychain.KeychainAccessProvider: Provider org.cryptomator.linux.keychain.KDEWalletKeychainAccess could not be instantiated
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)
at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Unknown Source)
at [email protected]/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source)
at [email protected]/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
at [email protected]/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
at [email protected]/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.util.ServiceConfigurationError: org.cryptomator.integrations.keychain.KeychainAccessProvider: Provider org.cryptomator.linux.keychain.KDEWalletKeychainAccess could not be instantiated
at java.base/java.util.ServiceLoader.fail(Unknown Source)
at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(Unknown Source)
at java.base/java.util.ServiceLoader$ProviderImpl.get(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.ArrayList.forEach(Unknown Source)
at java.base/java.util.stream.SortedOps$RefSortingSink.end(Unknown Source)
at java.base/java.util.stream.Sink$ChainedReference.end(Unknown Source)
at java.base/java.util.stream.Sink$ChainedReference.end(Unknown Source)
at java.base/java.util.stream.Sink$ChainedReference.end(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.toArray(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.toArray(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.toList(Unknown Source)
at [email protected]/org.cryptomator.common.keychain.KeychainModule.provideSupportedKeychainAccessProviders(KeychainModule.java:19)
at [email protected]/org.cryptomator.common.keychain.KeychainModule_ProvideSupportedKeychainAccessProvidersFactory.provideSupportedKeychainAccessProviders(KeychainModule_ProvideSupportedKeychainAccessProvidersFactory.java:29)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$CryptomatorComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:9097)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$CryptomatorComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:9092)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$CryptomatorComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:9086)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$MainWindowComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:6012)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.constructController(FxmlLoaderFactory.java:78)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processAttribute(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$InstanceDeclarationElement.processAttribute(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$Element.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$IncludeElement.constructValue(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$IncludeElement.constructValue(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader$ValueElement.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.processStartElement(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.loadImpl(Unknown Source)
at [email protected]/javafx.fxml.FXMLLoader.load(Unknown Source)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.load(FxmlLoaderFactory.java:46)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.createScene(FxmlLoaderFactory.java:63)
at [email protected]/org.cryptomator.ui.common.FxmlLoaderFactory.createScene(FxmlLoaderFactory.java:51)
at [email protected]/org.cryptomator.ui.mainwindow.MainWindowModule.provideMainScene(MainWindowModule.java:79)
at [email protected]/org.cryptomator.ui.mainwindow.MainWindowModule_ProvideMainSceneFactory.provideMainScene(MainWindowModule_ProvideMainSceneFactory.java:38)
at [email protected]/org.cryptomator.launcher.DaggerCryptomatorComponent$MainWindowComponentImpl$SwitchingProvider.get(DaggerCryptomatorComponent.java:5946)
at [email protected]/dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at [email protected]/org.cryptomator.ui.mainwindow.MainWindowComponent.showMainWindow(MainWindowComponent.java:28)
... 8 common frames omitted
Caused by: java.lang.NoClassDefFoundError: com/sun/security/auth/module/UnixSystem
at org.freedesktop.dbus.connections.SASL.getUserId(SASL.java:747)
at org.freedesktop.dbus.connections.SASL.auth(SASL.java:434)
at org.freedesktop.dbus.connections.transports.AbstractTransport.authenticate(AbstractTransport.java:159)
at org.freedesktop.dbus.connections.transports.AbstractTransport.connect(AbstractTransport.java:133)
at org.freedesktop.dbus.connections.transports.TransportBuilder.build(TransportBuilder.java:335)
at org.freedesktop.dbus.connections.AbstractConnection.<init>(AbstractConnection.java:150)
at org.freedesktop.dbus.connections.impl.DBusConnection.<init>(DBusConnection.java:231)
at org.freedesktop.dbus.connections.impl.DBusConnectionBuilder.build(DBusConnectionBuilder.java:200)
at [email protected]/org.cryptomator.linux.keychain.KDEWalletKeychainAccess$ConnectedWallet.getNewConnection(KDEWalletKeychainAccess.java:94)
at [email protected]/org.cryptomator.linux.keychain.KDEWalletKeychainAccess$ConnectedWallet.connect(KDEWalletKeychainAccess.java:85)
at [email protected]/org.cryptomator.linux.keychain.KDEWalletKeychainAccess.<init>(KDEWalletKeychainAccess.java:32)
at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
... 60 common frames omitted
Caused by: java.lang.ClassNotFoundException: com.sun.security.auth.module.UnixSystem
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 74 common frames omitted
```
### Anything else?
Can be fixed by adding `jdk.security.auth` to
https://github.com/cryptomator/cryptomator/blob/d6388d6205298b4fb15e2b10da553b54ae0114d5/dist/linux/appimage/build.sh#L27
Probably this issue will lead to an unusable AppImage on the next Cryptomator release.
EDIT: Code highlighting | https://github.com/cryptomator/cryptomator/issues/2640 | https://github.com/cryptomator/cryptomator/pull/2641 | 3587d53d1596cafe047b2ce1cb84f21f8c859d56 | a3cb8cd2f135436ea0126cd7de6dc2cccae5d229 | 2023-01-21T18:31:33Z | java | 2023-01-23T10:10:59Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,623 | ["dist/linux/appimage/build.sh"] | build.sh to build AppImage is outdated | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Needs an update to adhere to .github/workflows/appimage.yml
### What software is involved?
- Operating System: Linux
- Cryptomator: develop
### Volume Type
FUSE
### Steps to Reproduce
1. cd dist/linux/appimage
2. ./build.sh
### Expected Behavior
Build a nice AppImage.
### Actual Behavior
Some errors occur.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2623 | https://github.com/cryptomator/cryptomator/pull/2624 | 5beeeae27fc7fec335912189a769cedf75e508cf | b8326907bf0c21cfcb963e6c8592a0ea360a92d1 | 2023-01-07T14:39:11Z | java | 2023-01-19T12:37:10Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,597 | ["src/main/java/org/cryptomator/ui/common/FxmlFile.java", "src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java", "src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingStrategy.java", "src/main/java/org/cryptomator/ui/keyloading/hub/NoKeychainController.java", "src/main/resources/fxml/hub_no_keychain.fxml", "src/main/resources/i18n/strings.properties"] | Hub vault unlock fails if "Store passwords with" is disabled | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
If setting "Store passwords with" is disabled Hub vaults unlocking fails
### What software is involved?
- Operating System: All
- Cryptomator: 1.6.17
- Hub: All
### Volume Type
_No response_
### Steps to Reproduce
1. Disable "Store passwords with" in Cryptomator settings
2. Unlock hub vault
### Expected Behavior
Vault can be unlocked
### Actual Behavior
Vault unlock process hangs forever
### Reproducibility
Always
### Relevant Log Output
```shell
17:32:25.912 [main] INFO o.c.common.settings.SettingsProvider - Settings loaded from /home/julian/.config/Cryptomator/settings.json
17:32:25.920 [main] INFO org.cryptomator.common.Environment - user.home: /home/julian
17:32:25.920 [main] INFO org.cryptomator.common.Environment - java.library.path: :/app/Cryptomator/lib/app:/usr/java/packages/lib:/usr/lib64:/lib64:/lib:/usr/lib
17:32:25.920 [main] INFO org.cryptomator.common.Environment - user.language: en
17:32:25.920 [main] INFO org.cryptomator.common.Environment - user.region: null
17:32:25.920 [main] INFO org.cryptomator.common.Environment - logback.configurationFile: null
17:32:25.920 [main] INFO org.cryptomator.common.Environment - cryptomator.settingsPath: ~/.config/Cryptomator/settings.json:~/.Cryptomator/settings.json
17:32:25.920 [main] INFO org.cryptomator.common.Environment - cryptomator.ipcSocketPath: ~/.config/Cryptomator/ipc.socket
17:32:25.920 [main] INFO org.cryptomator.common.Environment - cryptomator.integrationsWin.keychainPaths: null
17:32:25.920 [main] INFO org.cryptomator.common.Environment - cryptomator.logDir: ~/.local/share/Cryptomator/logs
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.loopbackAlias: null
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.pluginDir: ~/.local/share/Cryptomator/plugins
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.mountPointsDir: ~/.local/share/Cryptomator/mnt
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.minPwLength: null
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.appVersion: 1.6.17
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.buildNumber: flatpak-1
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.showTrayIcon: false
17:32:25.921 [main] INFO org.cryptomator.common.Environment - cryptomator.p12Path: ~/.config/Cryptomator/key.p12
17:32:25.921 [main] INFO o.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.6.17 on Linux 5.15.84-1-lts (amd64)
17:32:25.921 [main] DEBUG org.cryptomator.logging.DebugMode - Debug mode enabled
17:32:25.922 [main] DEBUG o.c.launcher.SupportedLanguages - Using system locale
17:32:25.938 [main] INFO org.cryptomator.ipc.Server - Spawning IPC server listening on socket /home/julian/.config/Cryptomator/ipc.socket
17:32:26.056 [main] DEBUG o.c.launcher.IpcMessageHandler - Received launch args:
17:32:26.058 [main] DEBUG o.cryptomator.launcher.Cryptomator - Did not find running application instance. Launching GUI...
17:32:26.230 [JavaFX Application Thread] INFO o.cryptomator.launcher.Cryptomator - JavaFX runtime started after 561ms
17:32:26.234 [JavaFX Application Thread] DEBUG o.c.i.common.ClassLoaderFactory - Found jars in cryptomator.pluginDir:
17:32:26.380 [JavaFX Application Thread] DEBUG o.cryptomator.common.CommonsModule - Starting App Scheduled Executor 01
17:32:26.381 [App Scheduled Executor 01] DEBUG o.cryptomator.common.CommonsModule - Starting App Scheduled Executor 02
17:32:26.383 [JavaFX Application Thread] DEBUG o.c.i.common.ClassLoaderFactory - Found jars in cryptomator.pluginDir:
17:32:26.445 [JavaFX Application Thread] TRACE o.cryptomator.ui.fxapp.FxApplication - FxApplication.start()
17:32:26.501 [JavaFX Application Thread] DEBUG o.cryptomator.common.CommonsModule - Starting App Background Thread 001
17:32:26.687 [JavaFX Application Thread] DEBUG o.c.i.common.ClassLoaderFactory - Found jars in cryptomator.pluginDir:
17:32:26.688 [JavaFX Application Thread] DEBUG o.c.i.common.IntegrationsLoader - TrayMenuController: Found implementation: org.cryptomator.ui.traymenu.AwtTrayMenuController in jar /app/Cryptomator/lib/app/mods/cryptomator-1.6.17.jar
17:32:26.696 [JavaFX Application Thread] DEBUG o.c.i.common.IntegrationsLoader - TrayMenuController: Implementation is available: org.cryptomator.ui.traymenu.AwtTrayMenuController
17:32:26.849 [JavaFX Application Thread] DEBUG o.cryptomator.ui.common.FontLoader - Loaded family: Font Awesome 5 Free Solid
17:32:26.871 [JavaFX Application Thread] TRACE o.c.u.m.MainWindowTitleController - init MainWindowTitleController
17:32:26.890 [JavaFX Application Thread] DEBUG o.c.i.common.ClassLoaderFactory - Found jars in cryptomator.pluginDir:
17:32:26.891 [JavaFX Application Thread] DEBUG o.c.i.common.IntegrationsLoader - KeychainAccessProvider: Found implementation: org.cryptomator.linux.keychain.KDEWalletKeychainAccess in jar /app/Cryptomator/lib/app/mods/integrations-linux-1.1.0.jar
17:32:26.893 [JavaFX Application Thread] DEBUG o.c.i.common.IntegrationsLoader - KeychainAccessProvider: Found implementation: org.cryptomator.linux.keychain.SecretServiceKeychainAccess in jar /app/Cryptomator/lib/app/mods/integrations-linux-1.1.0.jar
17:32:27.086 [JavaFX Application Thread] DEBUG o.c.i.common.IntegrationsLoader - KeychainAccessProvider: Implementation is available: org.cryptomator.linux.keychain.KDEWalletKeychainAccess
17:32:27.088 [JavaFX Application Thread] DEBUG o.c.i.common.IntegrationsLoader - KeychainAccessProvider: Implementation is available: org.cryptomator.linux.keychain.SecretServiceKeychainAccess
17:32:27.236 [JavaFX Application Thread] TRACE o.c.ui.mainwindow.ResizeController - init ResizeController
17:32:27.239 [JavaFX Application Thread] TRACE o.c.u.m.MainWindowController - init MainWindowController
17:32:27.483 [JavaFX Application Thread] DEBUG o.cryptomator.ui.fxapp.FxApplication - Main window initialized after 1814ms
17:32:30.023 [JavaFX Application Thread] DEBUG o.c.common.vaults.VaultStats - stop recording stats
17:32:30.025 [JavaFX Application Thread] DEBUG o.c.ui.fxapp.FxApplicationWindows - Start unlock workflow for asd
17:32:30.032 [JavaFX Application Thread] DEBUG o.cryptomator.common.CommonsModule - Starting App Background Thread 002
17:32:31.876 [JavaFX Application Thread] DEBUG o.cryptomator.common.CommonsModule - Starting App Background Thread 003
17:32:31.879 [JavaFX Application Thread] DEBUG o.cryptomator.ui.fxapp.UpdateChecker - Checking for updates...
17:32:32.419 [JavaFX Application Thread] INFO o.cryptomator.ui.fxapp.UpdateChecker - Current version: 1.6.17, lastest version: 1.6.17
17:32:41.308 [JavaFX Application Thread] DEBUG o.cryptomator.common.CommonsModule - Starting App Background Thread 004
17:32:41.312 [JavaFX Application Thread] INFO o.cryptomator.ui.quit.QuitController - Locked
17:32:41.323 [JavaFX Application Thread] INFO o.cryptomator.launcher.Cryptomator - JavaFX application stopped.
17:32:41.329 [main] INFO o.cryptomator.launcher.Cryptomator - UI shut down
17:32:41.330 [main] DEBUG org.cryptomator.ipc.Server - IPC server closed
17:32:41.331 [main] INFO o.cryptomator.launcher.Cryptomator - Exit 0
17:32:41.332 [ShutdownTasks] DEBUG org.cryptomator.common.ShutdownHook - Running graceful shutdown tasks...
17:32:41.334 [ShutdownTasks] DEBUG org.cryptomator.ipc.Server - IPC server closed
```
### Anything else?
https://user-images.githubusercontent.com/1786772/209181212-ca559bf3-39f8-4ea7-bbb9-39ad68afdf99.mp4
| https://github.com/cryptomator/cryptomator/issues/2597 | https://github.com/cryptomator/cryptomator/pull/2612 | 5fcd53be184be0d938f26a0a0d3558878aa39602 | 6704bb1f8c240489d50f94142ba8aec090aca0a6 | 2022-12-22T16:40:40Z | java | 2022-12-30T10:32:40Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,512 | ["src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java", "src/main/java/org/cryptomator/ui/fxapp/FxApplicationStyle.java"] | Wrong screenshot shown in "Open Existing Vault" | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
The dark screenshot is shown in "Open Existing Vault" when theme is set to "Automatic" and it's currently light
### What software is involved?
- Operating System: macOS 12.6
- Cryptomator: 1.6.15
### Volume Type
_No response_
### Steps to Reproduce
1. Go to Preferences and set theme to "Automatic"
2. Make sure that your system is currently in light mode
3. Press "Add Vault" and then "Open Existing Vault"
### Expected Behavior
<img width="562" alt="Screen Shot 2022-10-28 at 15 42 00" src="https://user-images.githubusercontent.com/2924160/198618769-8ab6732f-b406-4d40-9d24-840cebea917c.png">
### Actual Behavior
<img width="562" alt="Screen Shot 2022-10-28 at 15 41 47" src="https://user-images.githubusercontent.com/2924160/198618855-e508d904-c5a6-4fb8-89f8-9a72279a1b4f.png">
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2512 | https://github.com/cryptomator/cryptomator/pull/2521 | db63a82d76b2b2272657b8ac2efb39f64f6313be | 019292f1db856aedabb93281d3dba06c95a05385 | 2022-10-28T13:42:28Z | java | 2022-11-29T16:19:31Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,493 | [".github/workflows/win-exe.yml", "dist/win/.gitignore", "dist/win/build.ps1", "dist/win/bundle/bundleWithWinfsp.wxs", "dist/win/bundle/resources/winFspMetaData.wxi"] | Windows+FUSE: Files with long unicode Name are not listed in Explorer | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Mounting a vault with FUSE on Windows, files containing a lot of unicode characters cannot be accessed.
### What software is involved?
- Operating System: Windows 11 Pro N, Build 22000.1098
- Cryptomator: 1.6.15
### Volume Type
FUSE
### Steps to Reproduce
1. Mount a vault
2. Create a file with a long name containing unicode chars in the vault:
```pwsh
PS Z:\> New-Item -Type File -Name ああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああああ.txt
```
### Expected Behavior
File is created without error and displayed in the directory listing
### Actual Behavior
File creation reports success, the created file shortly appears in the file explorer window, but it dissappears at latest with the next window refresh. Also listing the content with shell does not reveal the file.
Mounting with a different volume technology shows the file again.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
First reported in the user forum: https://community.cryptomator.org/t/file-with-long-name-in-foreign-characters-becomes-invisible-using-winfsp/10693 | https://github.com/cryptomator/cryptomator/issues/2493 | https://github.com/cryptomator/cryptomator/pull/3026 | ed975b459ed0de7d755e703f8c6ab89e1f17eaa5 | f893b2b5bedb85d7e4c0e6ad0a071e98acaf03e2 | 2022-10-18T09:59:32Z | java | 2023-10-23T10:26:28Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,383 | ["pom.xml", "src/main/java/org/cryptomator/ui/traymenu/AwtTrayMenuController.java", "src/main/java/org/cryptomator/ui/traymenu/TrayMenuBuilder.java"] | Tray Icon Menu does not refresh the Vault Status | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Vault Status does not refresh after Device is available
### What software is involved?
- Operating System: Windows 10/Linux Mint
- Cryptomator: 1.6.11
### Volume Type
Dokany
### Steps to Reproduce
Same on Windows 10 and Linux Mint 21
1. Start Cryptomator with defined vaults
2. One vault is connected to device P:\Test but P: is not connected at start of Cryptomator
3. Connect P:
4. Right klick on the Tray Icon and try to open sub menu of the vault to unlock the vault
-> Submenu does not open, because the menu does not refres the status of the P:-Device
Workaround: Open the GUI and klick on the vault - than the menu will be refreshed
### Expected Behavior
On Click on the vault entry in the tray menu, the "online-status" of the vault is refreshed and the submenu unlock opens
### Actual Behavior
Submenu of the tray icon does not open, because the menu does not refres the status of the P:-Device
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
Same on Windows 10 and Linux Mint 21 Cinnamon | https://github.com/cryptomator/cryptomator/issues/2383 | https://github.com/cryptomator/cryptomator/pull/2489 | b98eb8c6566b665e1b8ed668694390f26c52b42c | c41ffe2568068009484a6385a6e3382fc1ea7e75 | 2022-08-09T07:14:33Z | java | 2022-11-30T15:37:19Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,345 | ["src/main/java/org/cryptomator/ui/traymenu/TrayMenuBuilder.java"] | Menu bar icon on Mac uses non-Retina 1x icon | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
The menu bar icon used by the Mac release defaults to the 1x resolution icon since the 1.6.9 release.
### What software is involved?
- Operating System: macOS 12.4
- Cryptomator: 1.6.10
### Volume Type
_No response_
### Steps to Reproduce
Icon in 1.6.9 and 1.6.10:
<img width="278" alt="Screen Shot 2022-07-20 at 4 35 14 pm" src="https://user-images.githubusercontent.com/819987/179913665-df13cb8b-0241-455d-97cc-317c7e782afb.png">
Icon in 1.6.8:
<img width="278" alt="Screen Shot 2022-07-20 at 4 38 36 pm" src="https://user-images.githubusercontent.com/819987/179913852-0fbd3f55-b097-4959-aa17-0560386189c0.png">
### Expected Behavior
Cryptomator should use the 2x icon on Retina displays. (or perhaps use the 2x icon by default, might be difficult to account for edge cases on multiple monitors etc)
### Actual Behavior
Cryptomator uses the 1x icon on retina displays since 1.6.9.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2345 | https://github.com/cryptomator/cryptomator/pull/2346 | 31d32f201883d0c4f88784f6ab0cf44a9cd4c1e5 | 0021f2d37cf3b5f96350e684a2025e80d9d88944 | 2022-07-20T06:41:52Z | java | 2022-09-15T15:38:42Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,315 | ["src/main/java/org/cryptomator/ui/mainwindow/WelcomeController.java", "src/main/java/org/cryptomator/ui/migration/MigrationImpossibleController.java", "src/main/java/org/cryptomator/ui/wrongfilealert/WrongFileAlertController.java"] | Incorrect link to docs | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Incorrect link to docs.cryptomator.org on welcome screen (Windows app)
### What software is involved?
- Operating System: Windows 10
- Cryptomator: 1.6.10
### Volume Type
_No response_
### Steps to Reproduce
Install and open cryptomator.
### Expected Behavior
Link on welcome sreen to docs for 1.6 version.
### Actual Behavior
Link on welcome sreen to docs for 1.5 version.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2315 | https://github.com/cryptomator/cryptomator/pull/2329 | 2a91403f2f85eb9c576b6d49112336b372e00c60 | 50413ca9d8b28c5654f79be82966563ddfa95b29 | 2022-07-01T09:23:18Z | java | 2022-07-11T11:37:58Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,309 | ["src/main/java/org/cryptomator/common/mount/MountPointInUseException.java", "src/main/java/org/cryptomator/common/mount/Mounter.java", "src/main/java/org/cryptomator/ui/unlock/UnlockInvalidMountPointController.java", "src/main/resources/i18n/strings.properties", "suppression.xml"] | Reserved DriveLetter in Unlock-Failed-Dialog not displayed | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
The unlock failed dialog does not show the correct drive letter.
### What software is involved?
- Operating System: Windows 10 Build
- Cryptomator: 1.6.10
### Volume Type
_No response_
### Steps to Reproduce
1. Create two vaults (A and B)
2. For each, set in vault options mountpoint to the _same_ fixed drive letter (e.g. `Y:\`)
3. Unlock A
4. Unlock B
### Expected Behavior
Unlock failed dialog for B is showing that drive letter Y is reserved.
### Actual Behavior
Unlock failed dialog for B is showing that drive letter "AUTO" is reserved.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
Screenshot:
| https://github.com/cryptomator/cryptomator/issues/2309 | https://github.com/cryptomator/cryptomator/pull/2961 | 9b18a179c2167c9e5789f2a20b06b080698de388 | 2c2606d6ad8047a8bc3ae41e0df312efd50b701e | 2022-06-28T08:24:27Z | java | 2023-06-20T16:25:00Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,301 | ["dist/linux/appimage/resources/AppDir/bin/cryptomator.sh", "dist/linux/debian/cryptomator.sh"] | --version option opens the GUI and outputs much more than version | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Current --version option not useful (https://github.com/cryptomator/cryptomator/pull/2064/files)
### What software is involved?
- Operating System: Debian
- Cryptomator: 1.6.10
### Volume Type
_No response_
### Steps to Reproduce
1. Execute `cryptomator --version` on terminal.
### Expected Behavior
It just outputs the version and exits.
Format:
Cryptomator version %s (build %s)%n", appVer, buildNumber
as implemented by @JaniruTEC in https://github.com/cryptomator/cryptomator/pull/2064/files#diff-2e572b10d01bd8c531daae6429e7eff675b7233d2efc1cd1b3b2fff97b5f14c3R66
### Actual Behavior
It opens the GUI and outputs:
```
% cryptomator --version
/usr/bin/dpkg
11:23:53.869 [main] DEBUG org.cryptomator.common.Environment - user.home: /home/user
11:23:53.870 [main] DEBUG org.cryptomator.common.Environment - java.library.path: :/tmp/.mount_crypto4AMcsR/lib/app:/usr/java/packages/lib:/usr/lib64:/lib64:/lib:/usr/lib
11:23:53.870 [main] DEBUG org.cryptomator.common.Environment - user.language: en
11:23:53.870 [main] DEBUG org.cryptomator.common.Environment - user.region: null
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - logback.configurationFile: null
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.settingsPath: ~/.config/Cryptomator/settings.json:~/.Cryptomator/settings.json
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.ipcSocketPath: ~/.config/Cryptomator/ipc.socket
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.keychainPath: null
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.logDir: ~/.local/share/Cryptomator/logs
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.pluginDir: ~/.local/share/Cryptomator/plugins
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.mountPointsDir: ~/.local/share/Cryptomator/mnt
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.minPwLength: null
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.appVersion: 1.6.10
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.buildNumber: appimage-3659
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - cryptomator.showTrayIcon: false
11:23:53.871 [main] DEBUG org.cryptomator.common.Environment - fuse.experimental: false
11:23:53.886 [main] DEBUG org.cryptomator.common.ShutdownHook - Registered shutdown hook.
11:23:53.957 [main] DEBUG org.cryptomator.common.settings.SettingsProvider - Attempting to load settings from /home/static/.config/Cryptomator/settings.json
11:23:53.999 [main] INFO org.cryptomator.common.settings.SettingsProvider - Settings loaded from /home/user/.config/Cryptomator/settings.json
11:23:54.001 [main] INFO org.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.6.10 on Linux 5.10.0-15-amd64 (amd64)
11:23:54.020 [main] INFO org.cryptomator.ipc.Server - Spawning IPC server listening on socket /home/user/.config/Cryptomator/ipc.socket
11:23:54.377 [JavaFX Application Thread] INFO org.cryptomator.launcher.Cryptomator - JavaFX runtime started after 601ms
Jun 20, 2022 11:23:54 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/home/runner/work/cryptomator/cryptomator/src/main/resources/css/opensans-regular.ttf]
Jun 20, 2022 11:23:54 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/home/runner/work/cryptomator/cryptomator/src/main/resources/css/opensans-semibold.ttf]
Jun 20, 2022 11:23:54 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/home/runner/work/cryptomator/cryptomator/src/main/resources/css/opensans-bold.ttf]
Jun 20, 2022 11:23:54 AM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFO: Could not load @font-face font [file:/home/runner/work/cryptomator/cryptomator/src/main/resources/css/quicksand-bold.ttf]
11:24:00.947 [JavaFX Application Thread] INFO o.cryptomator.ui.fxapp.UpdateChecker - Current version: 1.6.10, lastest version: 1.6.10
11:24:03.208 [JavaFX Application Thread] INFO org.cryptomator.launcher.Cryptomator - JavaFX application stopped.
11:24:03.211 [main] INFO org.cryptomator.launcher.Cryptomator - UI shut down
11:24:03.211 [main] INFO org.cryptomator.launcher.Cryptomator - Exit 0
```
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
Original request: https://github.com/cryptomator/cryptomator/pull/2064/files | https://github.com/cryptomator/cryptomator/issues/2301 | https://github.com/cryptomator/cryptomator/pull/2365 | 47f2d423b997ddebf86736e69677d0d02bbf472f | 1cd3d1d67f4cf9412d61fb91752c0cb4700f8299 | 2022-06-20T10:43:57Z | java | 2022-08-02T06:44:04Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,287 | ["pom.xml"] | On Windows 10 a WebDAV vault does not update timestamp when modifying files | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
The modified date of files isn't updated when writing to a file in Windows. with a WebDAV volume type
### What software is involved?
- Operating System: Windows 10 Enterprise, version 21H1
- Cryptomator: 1.6.10
- Vault: Dropbox
### Volume Type
WebDAV
### Steps to Reproduce
1. Set Virtual Drive to WebDAV (this is default)
2. Unlock a vault.
3. Edit a file in the vault and save it to disk.
### Expected Behavior
I expect the data in the file to be saved back into Dropbox and the last modified timestamp to be updated.
### Actual Behavior
The data is changed but the timestamp is unchanged.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
I can work around this by selecting FUSE instead. | https://github.com/cryptomator/cryptomator/issues/2287 | https://github.com/cryptomator/cryptomator/pull/3255 | 6929760979c7eff95baeeb09ceb019364d8c510c | 47df4213c3a702b2c691f311d7eb8f619ce0a5fa | 2022-06-09T15:02:07Z | java | 2023-12-18T09:40:34Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,266 | ["src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultModule.java", "src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultExpertSettingsController.java", "src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultLocationController.java", "src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultPasswordController.java", "src/main/java/org/cryptomator/ui/common/FxmlFile.java", "src/main/java/org/cryptomator/ui/controls/FontAwesome5Icon.java", "src/main/resources/fxml/addvault_new_expert_settings.fxml", "src/main/resources/fxml/addvault_new_location.fxml", "src/main/resources/i18n/strings.properties"] | Custom shorteningThreshold during vault creation | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Custom shorteningThreshold during vault creation
### Motivation
When creating a new vault it's not always possible to choose the ideal path to store the encrypted files: under some circumstances it happens the path is already deep and with notorious limitations (for ex. 260 total path length), with no way to change this for various reasons (company rules, technical limitations, etc.). For this reason the vault created this way is prone to problems, in particular when dealing with long file names.
It would be very useful during vault creation the possibility to set a custom _shorteningThreshold_ value (instead of the actual 220 fixed limit) as an optional setting: this way it would be possible to set the proper max-length value for encrypted file names, without worrying too much for the length of the decrypted ones.
### Considered Alternatives
I tried a workaround trying to customize the _maxCleartextFilenameLength_ (explained [here](https://community.cryptomator.org/t/from-1-5-x-to-1-6-x-migrating-filenamelengthlimit/9036/1)), but it's not always the right solution: the first drawback is that actually is not easy to set; the second (and most important) drawback is that it creates a relationship between decrypted name and the encrypted name, which is useful under certain circumstances, but in other is not, like in my case (where I want full "decrypted" depth but limited "encrypted" one).
### Anything else?
More context can be found here: https://community.cryptomator.org/t/custom-value-for-shorteningthreshold-setting/10062 | https://github.com/cryptomator/cryptomator/issues/2266 | https://github.com/cryptomator/cryptomator/pull/2987 | 58c7774e0da628eb188b9b8c33c4502da82639be | 2a0e0738be8ca6d75c5a12d62713da526e706c53 | 2022-05-24T10:07:14Z | java | 2023-07-13T10:15:07Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,260 | [".github/workflows/win-exe.yml", ".idea/runConfigurations/Cryptomator_Windows.xml", ".idea/runConfigurations/Cryptomator_Windows_Dev.xml", "dist/win/build.ps1", "pom.xml", "src/main/java/org/cryptomator/common/Environment.java", "src/test/java/org/cryptomator/common/EnvironmentTest.java"] | Updating to integrations-win 1.1.2 | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
The used JVM property `cryptomator.keychainPath` needs to be renamed to `cryptomator.integrationsWin.keychainPath`
### Motivation
-/-
### Considered Alternatives
-/-
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2260 | https://github.com/cryptomator/cryptomator/pull/2331 | 50413ca9d8b28c5654f79be82966563ddfa95b29 | d814c1cfca84d9d5184767418b9ad964bc876b34 | 2022-05-18T13:03:49Z | java | 2022-07-11T13:59:54Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,258 | ["src/main/java/org/cryptomator/common/CatchingExecutors.java", "src/main/java/org/cryptomator/common/CommonsModule.java"] | Missing exceptions in AutoLocker (and potentially other places) | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Some exceptions might not be logged
### What software is involved?
Cryptomator: develop
### Volume Type
_No response_
### Steps to Reproduce
1. Throw exception in affected area, e.g. https://github.com/cryptomator/cryptomator/blob/4989eacaf9418505e8195ce4592bfc41f5168f4c/src/main/java/org/cryptomator/common/vaults/AutoLocker.java#L31-L36
### Expected Behavior
An exception is logged.
### Actual Behavior
The thread dies and no exception is logged. The scheduled task is no longer executing.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2258 | https://github.com/cryptomator/cryptomator/pull/2259 | aca55734b09b0a4cfaf4626e3ad40845754aaf47 | e6ff7a6d886610ef8fa80702b0cc9ff1b854d79b | 2022-05-17T14:36:25Z | java | 2022-05-27T16:24:55Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,219 | ["src/main/java/org/cryptomator/common/keychain/KeychainModule.java", "src/main/java/org/cryptomator/common/settings/Settings.java", "src/main/java/org/cryptomator/common/settings/SettingsJsonAdapter.java", "src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java", "src/main/resources/fxml/preferences_general.fxml"] | Selecting vault from vault list let application (and system) freezes for 2 minutes | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Hello! I have manjaro KDE latest version. I updated cryptomator to version 1.6.9. Now when selecting the storage folder for 2 minutes the program and the system hangs. This didn't happen on the previous version.
### What software is involved?
- Operating System: Manjaro KDE 21.2.6
- Cryptomator: 1.6.9
- KDE Plasma: 5.24.4
- Kernel: 5.15.32-1-Manjaro
### Volume Type
FUSE
### Steps to Reproduce
1. Open Cryptomator
2. Select any storage folder (click on it)
### Expected Behavior
The password field to unlock the storage folder is displayed
### Actual Behavior
Program and operating system hangs for 2 minutes, then the password field to unlock the storage folder is displayed
### Reproducibility
Always
### Relevant Log Output
```shell
17:35:29.292 [main] INFO org.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.6.9 on Linux 5.15.32-1-MANJARO (amd64)
17:35:29.311 [main] INFO org.cryptomator.ipc.Server - Spawning IPC server listening on socket /home/ynwa/.config/Cryptomator/ipc.socket
17:35:30.010 [JavaFX Application Thread] INFO org.cryptomator.launcher.Cryptomator - JavaFX runtime started after 929ms
17:35:36.441 [JavaFX Application Thread] INFO o.cryptomator.ui.fxapp.UpdateChecker - Current version: 1.6.9, lastest version: 1.6.9
17:35:46.748 [JavaFX Application Thread] INFO o.f.dbus.handlers.SignalHandler - Await signal org.kde.KWallet$walletAsyncOpened(/modules/kwalletd5) within 120 seconds.
17:37:46.750 [JavaFX Application Thread] WARN o.f.dbus.handlers.SignalHandler - java.util.concurrent.TimeoutException
17:38:08.027 [JavaFX Application Thread] INFO o.c.ui.unlock.UnlockWorkflow - Unlock of 'Folder' succeeded.
17:38:08.054 [JavaFX Application Thread] INFO o.cryptomator.ui.common.VaultService - Revealed Folder
17:46:02.365 [App Scheduled Executor 01] INFO o.c.common.settings.SettingsProvider - Settings saved to /home/ynwa/.config/Cryptomator/settings.json
```
### Anything else?
I think that's the problem:
17:35:46.748 [JavaFX Application Thread] INFO o.f.dbus.handlers.SignalHandler - Await signal org.kde.KWallet$walletAsyncOpened(/modules/kwalletd5) within 120 seconds.
17:37:46.750 [JavaFX Application Thread] WARN o.f.dbus.handlers.SignalHandler - java.util.concurrent.TimeoutException | https://github.com/cryptomator/cryptomator/issues/2219 | https://github.com/cryptomator/cryptomator/pull/2445 | 08fc5e9a77f20339e1cfb921f25d8bcac5ab57c0 | cc24a4c9aea73b20172696522fab471a3c991f91 | 2022-05-01T14:53:48Z | java | 2022-09-21T07:12:40Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,200 | ["src/main/java/org/cryptomator/common/vaults/VaultComponent.java", "src/main/java/org/cryptomator/common/vaults/VaultListManager.java", "src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java", "src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java", "src/main/java/org/cryptomator/ui/vaultoptions/VaultOptionsComponent.java"] | Illegal use of builder(s) | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
At least one builder is reused
### What software is involved?
N/A
### Volume Type
_No response_
### Steps to Reproduce
N/A
### Expected Behavior
Builders that are injected into constructors should not be reused.
### Actual Behavior
At least one class (`VaultListManager`) uses the same instance of a builder (in this case `VaultComponent.Builder`) to create multiple components (in this case `VaultComponent`).
An instance of a builder should only be used once; otherwise values of prior invocations can leak into new objects in certain constellations, causing difficult to detect bugs.
### Reproducibility
Always
### Relevant Log Output
```shell
N/A
```
### Anything else?
Suggestion:
- Wrap the builder with a provider and use fresh instances of the builder by calling `#get()`
- Optional: Repeat this procedure for all classes that use constructor injection with builders | https://github.com/cryptomator/cryptomator/issues/2200 | https://github.com/cryptomator/cryptomator/pull/2262 | 5233e6b6901e621447d6ffbbdddf20b3a5d967e5 | 3d95276a7f0b4039f53f593eadf588a3569e281a | 2022-04-22T23:15:43Z | java | 2022-05-19T20:07:56Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,144 | [".github/workflows/win-exe.yml"] | Cryptomator-1.6.8-x64.exe installation error | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Can't install Cryptomator-1.6.8-x64.exe
### What software is involved?
- Operating System: windows 11
- Cryptomator: cryptomator 1.6.8 (exe file, not MSI)
- …
### Volume Type
WebDAV
### Steps to Reproduce
1. Uninstall Cryptomator 1.6.7
2. Reboot computer
3. Install cryptomator 1.6.8 with Cryptomator-1.6.8-x64.exe
4. Error during installation (see screenshot
)
### Expected Behavior
Cryptomator well installed
### Actual Behavior
Can't install cryptomator with Cryptomator-1.6.8-x64.exe
Old version Cryptomator-1.6.7-x64.exe installer works fine
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
Cryptomator-1.6.8-x64.msi is not affected by the problem | https://github.com/cryptomator/cryptomator/issues/2144 | https://github.com/cryptomator/cryptomator/pull/2145 | 28db04e6219d1a17972eda71c7a6d8fbae084be5 | a558135fec91e8ff8f5c9f17af994f6c19cb763f | 2022-03-31T07:02:44Z | java | 2022-03-31T09:03:15Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,106 | ["src/main/java/org/cryptomator/common/settings/Settings.java", "src/main/java/org/cryptomator/common/settings/SettingsJsonAdapter.java", "src/main/java/org/cryptomator/launcher/Cryptomator.java", "src/main/java/org/cryptomator/launcher/SupportedLanguages.java", "src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java", "src/main/resources/fxml/preferences_general.fxml", "src/main/resources/i18n/strings.properties", "src/test/java/org/cryptomator/common/settings/SettingsJsonAdapterTest.java", "src/test/java/org/cryptomator/launcher/SupportedLanguagesTest.java"] | Add "change language" option | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Add "change language" option
### Motivation
Sometime i like to change language for support purpose.
### Considered Alternatives
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/2106 | https://github.com/cryptomator/cryptomator/pull/2150 | 6af016f1feb85ce63d21ebeed4d9be398b301ca5 | 3136e22414456bff8b1d811a5da922034c3d5d81 | 2022-03-19T00:40:17Z | java | 2022-04-04T18:59:23Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 2,076 | ["src/main/java/org/cryptomator/ui/recoverykey/RecoveryKeyFactory.java", "src/main/java/org/cryptomator/ui/recoverykey/RecoveryKeyModule.java", "src/main/java/org/cryptomator/ui/recoverykey/RecoveryKeyRecoverController.java", "src/test/java/org/cryptomator/ui/recoverykey/RecoveryKeyFactoryTest.java"] | Validate recovery key against vault config | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
When entering a syntactically correct but non-matching recovery key, use the vault config's signature to check if the recovery key matches
### Motivation
If using a recovery key while `vault.cryptomator` still exists, we can check if the provided recovery key is not only well-formed but actually matches the vault.
This prevents using the "wrong" recovery key accidentally.
### Considered Alternatives
_No response_
### Anything else?
Doesn't work, if `vault.cryptomator` is missing. | https://github.com/cryptomator/cryptomator/issues/2076 | https://github.com/cryptomator/cryptomator/pull/2161 | 9ed7438f0529e8cb984d19966b8b5720c0e57d3d | 752e61219cb844fa3de50cb361c4bd1d071dac71 | 2022-02-25T11:13:36Z | java | 2022-04-05T10:03:12Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,996 | ["src/main/java/org/cryptomator/launcher/Cryptomator.java"] | Get binary version from command-line / shell | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Cryptomator does not support a command to just see binary version.
### Motivation
It would be nice to have a "cryptomator version" or "cryptomator --version" command to check via terminal.
I am developing a [streamlined way to have cryptomator installed in Linux workstations](https://github.com/staticdev/linux-workstation-playbook) (but this command can do the same in other OS. The problem is, without a command to get the version, tools such as ansible have to redownload everytime the binary to check if it has changed or not. With such command I can even create an ansible role to have better update options for cryptomator.
### Considered Alternatives
I also tried executing the program and getting the version shown in the output, but that is not desirable also, since the process needs to be killed in workstation configuration time (which is not a general best practice).
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/1996 | https://github.com/cryptomator/cryptomator/pull/2064 | 7dd0f0cb3154cd890382439aa2f537d1d3b81226 | e71b375437e4a6cee23354d52c9abc975d74cf19 | 2021-12-22T16:35:56Z | java | 2022-04-12T22:57:08Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,955 | [".github/workflows/appimage.yml", "dist/linux/appimage/build.sh", "dist/linux/appimage/resources/AppDir/bin/cryptomator.sh", "dist/linux/debian/rules", "dist/linux/launcher-gtk2.properties", "dist/mac/dmg/build.sh", "dist/win/build.ps1"] | elementaryOS Second Icon in Taskbar | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Second icon opening up when launching Cryptomator
### What software is involved?
- Operating System: elementaryOS 6 Odin
- Cryptomator: 1.6.3
### Volume Type
FUSE
### Steps to Reproduce
1. install elementaryOS 6
2. install Cryptomator AppImage
3. open Cryptomator
### Expected Behavior
When launching Appimage via Appimage directly or via Icon in Dock or Start Menu i expect the Application to open within the original icon in the dock.
### Actual Behavior
When launching Cryptomator Appimage there is a second icon popping up and revealing as the actual application.
Left: Original Appimage which is shown in dock and startmenu, Right: Actual application that will open.
When right clicking the actual application icon there is only shown "close", it is missing the option to pin it to the dock.
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/1955 | https://github.com/cryptomator/cryptomator/pull/2105 | e71b375437e4a6cee23354d52c9abc975d74cf19 | d368b010386fbda10eb33ae2322ad54e2f832782 | 2021-11-30T19:21:29Z | java | 2022-04-18T06:24:13Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,934 | ["src/main/java/org/cryptomator/ui/common/UserInteractionLock.java", "src/main/java/org/cryptomator/ui/lock/LockForcedController.java", "src/main/java/org/cryptomator/ui/lock/LockModule.java", "src/main/java/org/cryptomator/ui/lock/LockWorkflow.java", "src/main/resources/fxml/lock_forced.fxml", "src/main/resources/i18n/strings.properties"] | Unhandled exception when force-locking | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Force Lock may result in unhandled error
### What software is involved?
- Operating System: any
- Cryptomator: 1.6.3
### Volume Type
FUSE, Dokany, WebDAV
### Steps to Reproduce
1. Mount vault
2. Block volume
3. Unmount vault
4. Confirm "force lock"
### Expected Behavior
If force lock fails as well, fall into "retry loop" that keeps informing the user but allows him to cancel out.
### Actual Behavior
Second attempt (force lock) is just assumed to work, when in reality it might still fail.
### Reproducibility
Intermittent
### Relevant Log Output
```shell
Error Code JLHE:MI7B:MI7B
org.cryptomator.common.vaults.LockNotCompletedException: Locking of vault T still in progress.
at [email protected]/org.cryptomator.common.vaults.Vault.lock(Vault.java:183)
at [email protected]/org.cryptomator.ui.lock.LockWorkflow.call(LockWorkflow.java:60)
at [email protected]/org.cryptomator.ui.lock.LockWorkflow.call(LockWorkflow.java:31)
```
### Anything else?
In order to reproduce this, you might need a OS/volume combo that doesn't (reliably) support force-locking. | https://github.com/cryptomator/cryptomator/issues/1934 | https://github.com/cryptomator/cryptomator/pull/1935 | 71a575e0792ae2c3569533733a0ace03a4c6edf5 | 0c47af2f155dea22d689b27287f83953b530f575 | 2021-11-17T12:43:57Z | java | 2021-11-17T15:00:41Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,905 | [".github/workflows/release.yml", "dist/linux/debian/changelog"] | Can't install the program from the official PPA repository | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
I can not install the program from the official PPA repository, an error occurs due to the inability to install the necessary packages due to version mismatch
### What software is involved?
- Operating System: Ubuntu 18.04.6 LTS
### Volume Type
_No response_
### Steps to Reproduce
1. sudo add-apt-repository ppa:sebastian-stenzel/cryptomator
2. sudo apt-get update
3. sudo apt install cryptomator
### Expected Behavior
Installed program
### Actual Behavior
Application installation error due to package version mismatch
### Reproducibility
Always
### Relevant Log Output
_No response_
### Anything else?
| https://github.com/cryptomator/cryptomator/issues/1905 | https://github.com/cryptomator/cryptomator/pull/1909 | 0c6ecef92bd7058b58528d1af492d39e381aa2dc | c5b6d8f81fcedf4c853dc6b99166fd318ccbcc3e | 2021-11-07T07:45:52Z | java | 2021-11-10T11:20:52Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,888 | ["src/main/java/org/cryptomator/common/mountpoint/CustomDriveLetterChooser.java", "src/main/java/org/cryptomator/common/mountpoint/CustomMountPointChooser.java", "src/main/java/org/cryptomator/common/mountpoint/TemporaryMountPointChooser.java", "src/main/java/org/cryptomator/common/vaults/DokanyVolume.java", "src/main/java/org/cryptomator/common/vaults/FuseVolume.java", "src/main/java/org/cryptomator/common/vaults/MountPointRequirement.java", "src/main/java/org/cryptomator/ui/unlock/UnlockInvalidMountPointController.java", "src/main/java/org/cryptomator/ui/unlock/UnlockWorkflow.java", "src/main/resources/fxml/unlock_invalid_mount_point.fxml", "src/main/resources/i18n/strings.properties"] | Error because driveletter already exist on Windows | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
Cryptic message instead of undersandable Error message appear
### What software is involved?
- Operating System: Windows 10
- Cryptomator: 1.5.17
- Windwos Commandline cmd.exe and command subst
### Volume Type
Dokany
### Steps to Reproduce
1. use cmd.exe and the command subst to mount a directory as drive letter e.g. `subst X: C:/ProgramData`
2. Start Cryptomator
3. Try mount the same Drive with Cryptomator
### Expected Behavior
_Error Message appear:_
**Drive X: is already mounted by the Windows Commandline tool subst.
Should I unmount Driveletter X: for you?**
- [x] Remember the answer if the problem appears again
- [x] OK -> `subst /D x:`
- [ ] Do nothing
### Actual Behavior
A cryptic errror message appear. See log output.
### Reproducibility
Only once
### Relevant Log Output
```shell
org.cryptomator.common.vaults.Volume$VolumeException: Unable to mount Filesystem
at org.cryptomator.common.vaults.DokanyVolume.mount(DokanyVolume.java:48)
at org.cryptomator.common.vaults.Vault.unlock(Vault.java:151)
at org.cryptomator.ui.unlock.UnlockWorkflow.attemptUnlock(UnlockWorkflow.java:100)
at org.cryptomator.ui.unlock.UnlockWorkflow.call(UnlockWorkflow.java:81)
at org.cryptomator.ui.unlock.UnlockWorkflow.call(UnlockWorkflow.java:44)
at javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: org.cryptomator.frontend.dokany.DokanyMountFailedException: Error while mounting.
at org.cryptomator.frontend.dokany.MountFactory.mount(MountFactory.java:130)
at org.cryptomator.frontend.dokany.MountFactory.mount(MountFactory.java:116)
at org.cryptomator.common.vaults.DokanyVolume.mount(DokanyVolume.java:43)
... 11 more
Caused by: com.dokany.java.DokanyException: DokanMain returned error code-5: Dokan mount failed - Cannot assign a drive letter or mount point. Probably already used by another volume.
at com.dokany.java.DokanyMount.lambda$mount$2(DokanyMount.java:98)
... 1 more
```
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/1888 | https://github.com/cryptomator/cryptomator/pull/2013 | d6ccb410274d925bf764da04d6103921a8817268 | da2d6473612ad4e794effadb38f50fef9c2fb234 | 2021-11-03T07:28:49Z | java | 2022-01-30T00:38:16Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,733 | ["src/main/java/org/cryptomator/common/settings/Settings.java", "src/main/java/org/cryptomator/common/settings/SettingsJsonAdapter.java", "src/main/java/org/cryptomator/ui/mainwindow/MainWindowController.java", "src/main/java/org/cryptomator/ui/mainwindow/MainWindowModule.java", "src/main/java/org/cryptomator/ui/mainwindow/MainWindowTitleController.java", "src/main/java/org/cryptomator/ui/mainwindow/ResizeController.java", "src/main/resources/fxml/main_window.fxml", "src/main/resources/fxml/main_window_resize.fxml"] | Set window size / remember last window size / Fullscreen | ### Please agree to the following
- [X] I have searched [existing issues](https://github.com/cryptomator/cryptomator/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md)
### Summary
User should be able to config the window size permanently
### Motivation
I have a lot of vaults in Cryptomator. After every Windows boot Cryptomator has its fix window size so I maximize the window size by drawing (deutsch: Fenster großziehen) the window. This is okay for the current session but the window / frame size is reset again after a Windows boot.
In the "default" frame size I can't see enough of the folder path and I have to scroll down to see the other vaults in the bottom of the vault list.
It would be a nice if
- Cryptomator would remember the window size after Windows reboot or
- we could config this behavior in the settings or
- we could maximize the Cryptomator window (I mean really maximize like fullscreen browser).
### Considered Alternatives
_No response_
### Anything else?
_No response_ | https://github.com/cryptomator/cryptomator/issues/1733 | https://github.com/cryptomator/cryptomator/pull/1761 | cfe61a51b6127965a5c3b31822ecf5ec54f1a96a | af4603f022237d2ad1060d24b74d08cec779d0de | 2021-07-28T16:05:00Z | java | 2021-09-22T09:39:51Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,621 | ["README.md", "main/ui/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultLocationController.java", "main/ui/src/main/java/org/cryptomator/ui/addvaultwizard/LocationPresets.java", "main/ui/src/main/resources/fxml/addvault_new_location.fxml"] | Add MEGA & pCloud providers to vault location presets | <!--
Please make sure to:
- Comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
- Search for existing similar issues first: https://github.com/cryptomator/cryptomator/issues?q=
-->
### Summary
Add detection for [MEGA](https://mega.io) and [pCloud](https://pcloud.com) drives as location presets.
### Motivation
Improves the onboarding and vault addition experience for users by automatically detecting additional popular cloud storage providers.
### Considered Alternatives
N/A
### Additional Context
[MEGA](https://mega.nz) is a well-known and secure cloud storage provider which is great for uploading large files with its 50GB free plan offering. Its sync client is cross-platform (Windows, Mac OS and Linux) and [open source](https://github.com/meganz/MEGAsync).
[pCloud](https://pcloud.com) is a popular and secure cloud storage provider based in Switzerland which offers the choice of hosting in different [data regions](https://www.pcloud.com/data-regions/) (US or EU) and offers 10GB in its free plan. It also has a cross-platform desktop client. Support for this provider was recently [added to Android](https://github.com/cryptomator/android/commit/10ce9dee793688b17a6d968835b3ba199a0fadc6) and this would ensure further feature parity 'out of the box' between the platforms. | https://github.com/cryptomator/cryptomator/issues/1621 | https://github.com/cryptomator/cryptomator/pull/1622 | 8457c50ebce493b4a04a85e23b3ed7613dfdc7be | c1f498a1140afb0e491d8ca795cd8490535f47f6 | 2021-04-18T15:59:34Z | java | 2021-04-20T06:09:17Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,591 | ["pom.xml", "src/main/java/org/cryptomator/ui/controls/SecurePasswordField.java"] | GUI cannot be used over RDP connection | <!--
Please make sure to:
- Comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
- Search for existing similar issues first: https://github.com/cryptomator/cryptomator/issues?q=
⚠️ IMPORTANT: If you don't stick to this template, the issue will get closed.
-->
### Interface glitches and only way to fix is to kill the process
[Summarize your problem.]
### System Setup
* Windows 10 (Version 2004)
* Cryptomator version: 1.5.13 (exe-2755.216)
* Volume type: Dokany
* Dokany version: 1.4.1.1000 (x64)
So there isn't exact steps to reproduce this issue. It happens randomly. I think i notice it maybe about once a week now but it seems to be happen more frequently. I go to RDP into this machine (its generally a headless machine and notice the following). When i try to open to cryptomator interface this is what i see:
If i try to close cryptomator by right clicking the system tray icon and choosing "quit" this is what i see:
So the "Cancel" & "Lock and quit" buttons are missing. I have tried to click around in that area thinking the buttons are there but hidden but i've never been successful.
| https://github.com/cryptomator/cryptomator/issues/1591 | https://github.com/cryptomator/cryptomator/pull/1809 | 53afaf1b125dcfc53880bd8227c7eb0b7f1db0a0 | 90bceb0f6843dde07bb2225098793589eeef1116 | 2021-03-20T03:05:43Z | java | 2021-09-24T19:01:19Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,583 | ["src/main/java/org/cryptomator/ui/traymenu/TrayMenuController.java"] | Show vault locked/unlocked state in the vault title | ### Summary
It would be nice to see each vault's locked/unlocked state in both the list of vaults in the main GUI and the Windows system tray.
### Motivation
When you have lots of vaults, you can look at the "Lock all" command in the system tray popup menu to determine if some of them are currently unlocked. But if you want to keep some vaults unlocked while locking others, this information is not enough to find out exactly which other vaults are unlocked. In that case you're forced to check with each vault in turn to see if it is unlocked, which is quite cumbersome.
### Solution
Adding the unlocked (and possibly locked) state to each vault's title in those lists greatly helps with that. A simple suffix like "(unlocked)" should do, though long vault titles might put that information outside the list's bounds. Another option is to add a simple short "(*)" prefix instead.
Another option is to split the lists of vaults in 2 lists; a top one with all locked vaults, and a bottom one with all unlocked ones. This might even be more beneficial once a vault tree structure is supported; if tree nodes are closed by default you'd otherwise still have to open each node to see the statuses. In that case just having 2 (pruned) trees might thus work better. | https://github.com/cryptomator/cryptomator/issues/1583 | https://github.com/cryptomator/cryptomator/pull/2101 | 9e594ea127e9194cb2e1ad2a8ab4151d3cf7922d | 303f84166f9b42e02094f23ad72808b0807cdfde | 2021-03-15T21:22:15Z | java | 2022-03-22T11:45:21Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,547 | ["src/main/java/org/cryptomator/ui/vaultoptions/MountOptionsController.java"] | "Custom path" retains invalid value/state | <!--
Please make sure to:
- Comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
- Search for existing similar issues first: https://github.com/cryptomator/cryptomator/issues?q=
⚠️ IMPORTANT: If you don't stick to this template, the issue will get closed.
-->
### Description
After clicking "Choose..." in `VaultOptions > Mounting` and then clicking "Cancel" in the Explorer Window, the path for the custom mountpoint is removed from the Cryptomator Config.
### System Setup
* Operating system and version: Windows (potentially others)
* Cryptomator version: 1.5.12 (likely before)
* Volume type: Any
### Steps to Reproduce
1. Access `VaultOptions > Mounting`
2. **(Case A)** Select the "Custom path" radio button (if not already selected) **(Case B)** Click "Choose..."
3. Cancel the appearing Explorer window
#### Expected Behavior
**Case A:** The GUI reverts to a valid state (e.g. "Use assigned drive letter")
**Case B:** The GUI retains the last valid custom path (e.g. "C:\Users\User\Cryptomator\MyVault\")
#### Actual Behavior
**Case A & B:** "Custom path" stays selected and no path is displayed. If the user closes and reopens the Vault Options they are greeted with the Explorer window again (Cryptomator trying to fix the invalid state).
**Side effect:** If the user tries to mount the Volume, a drive letter is picked by Cryptomator!
#### Reproducibility
Always
### Additional Information
"Use assigned drive letter" handles this perfectly fine and reverts to a valid state if put into an invalid state.
The automatic drive letter picking is unwanted behavior. Cryptomator should just abort the operation.
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
| https://github.com/cryptomator/cryptomator/issues/1547 | https://github.com/cryptomator/cryptomator/pull/1548 | f5822fc5686f8e3a735dc4b64ab2e31ca9ce96ad | 1ef3e948be9e639e9659ba51f1d52e7632099924 | 2021-02-19T17:14:12Z | java | 2021-10-04T12:31:48Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,526 | ["main/ui/src/main/java/org/cryptomator/ui/changepassword/ChangePasswordController.java", "main/ui/src/main/java/org/cryptomator/ui/keyloading/masterkeyfile/MasterkeyFileLoadingModule.java", "main/ui/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java", "main/ui/src/main/java/org/cryptomator/ui/vaultoptions/MasterkeyOptionsController.java"] | User prompted by Gnome Keyring / KDE Wallet when clicking on "Unlock..." | ### Description
This is a follow-up on #1525. Essentially, the problem is that Cryptomator asks whether a password is stored, as soon as a user triggers the unlock workflow. While necessary, this has unwanted side effects on Linux, if no password is stored and the user doesn't expect any interaction with any 3rd party keychain.
### System Setup
* Operating system and version: Any Linux Distro providing KDE Wallet or Gnome Keyring
* Cryptomator version: 1.5.12
* Volume type: N/A
### Steps to Reproduce
1. Either
* don't use KDE Wallet or Gnome Keyring
* or make sure, your keychain is currently locked
2. Inside Cryptomator, click on "Unlock..." for any vault (regardless if a password is stored or not)
#### Expected Behavior
No interaction with Gnome Keyring / KDE Wallet
#### Actual Behavior
System keychain prompts the user.
#### Reproducibility
Always
### Additional Information
@purejava has tracked this down to the eager access to stored passwords here:
https://github.com/cryptomator/cryptomator/blob/e4709ed6fe0cf035efa24c073d68b4cc4d117d4e/main/commons/src/main/java/org/cryptomator/common/keychain/KeychainManager.java#L83 | https://github.com/cryptomator/cryptomator/issues/1526 | https://github.com/cryptomator/cryptomator/pull/1550 | 1159681824f929753c40bc292e7927a47fb64993 | 7b689c6b788e89fdaea7064c7250f4ae5fab017d | 2021-02-04T13:20:32Z | java | 2021-06-02T12:24:51Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,519 | ["main/ui/src/main/java/org/cryptomator/ui/unlock/UnlockWorkflow.java"] | Suppressed invalid mount point messages | ### Description
Users describe issues with mounting their vaults, making them unable to access their data. Only on the second attempt of unlocking the vault, the users are prompted with an "already unlocked" exception. Analysis of those issues lead to the discovery, that there are two bugs causal to this particular problem:
1.) If the mount process fails (but not the unlock), Cryptomator assigns an invalid state to the vault, requiring a restart of the application. See #1509 for more information.
**2.) If the user utilizes the "Save password" feature of Cryptomator, some messages, that should inform the user about an invalid mount point, are suppressed. This issue collects information on this particular bug.**
### System Setup
* Operating system and version: Any
* Cryptomator version: 1.5.11 (possibly 1.5.10)
* Volume type: Any
* **Usage of the "Save password" feature of Cryptomator**
* Usually a custom mountpoint (it's rare for automatic mountpoints to cause problems)
### Steps to Reproduce
1. Unlock a Vault normally and save your password to the keychain by ticking the box labeled "Save password"
2. Optional: Select a custom mountpoint
3. Modify your mountpoint (directory) to be unusable for Cryptomator, e.g. by removing the folder or inserting a file
### Expected Behavior
Cryptomator fails while mounting the vault, informing the user about their invalid mounpoint choice.
### Actual Behavior
Cryptomator suppresses the error and just returns to the "Unlock Now" button.
_Before #1509 was fixed:_ Users are prompted with "Already unlocked", when clicking "Unlock Now" for the second time.
_After #1509 was fixed:_ Users can repeatedly click "Unlock Now", causing Cryptomator to process the request and then return to the button without actually doing anything.
### Reproducibility
_Only when using "Save password"!_
### Additional Information
See https://github.com/cryptomator/cryptomator/issues/1515#issuecomment-764942322 for technical details and how this was solved.
### Workarounds
Remove the password from the password store by clicking `Vault Options` > `Password` > `Forget Saved Password`. Doing this and entering the password whenever you unlock your vault, causes error messages to appear correctly. (Please make sure, that you know your password before you delete it 😁)
Alternatively please check your Cryptomator log file to see why your vault can't mount.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
### Fix
This issue is resolved by PR #1518. | https://github.com/cryptomator/cryptomator/issues/1519 | https://github.com/cryptomator/cryptomator/pull/1518 | 402861b9c061a936ef4ac2ebcede8258f1e23b89 | 0fa052d2d1257ba18a7c0315ecf77c819d00912d | 2021-01-24T22:47:43Z | java | 2021-01-27T14:22:47Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,478 | ["main/ui/src/main/java/org/cryptomator/ui/mainwindow/MainWindowModule.java", "main/ui/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java", "main/ui/src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java", "main/ui/src/main/resources/fxml/vault_list.fxml", "main/ui/src/main/resources/fxml/vault_list_cell.fxml", "main/ui/src/main/resources/fxml/vault_list_contextmenu.fxml", "main/ui/src/main/resources/i18n/strings.properties"] | Removing the vault from the vault list while it is still being unlocked does not cancel the unlocking process | <!--
**************************************
⚠️⚠️⚠️ READ CAREFULLY ⚠️⚠️⚠️
**************************************
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
⚠️ IMPORTANT: If you don't stick to this template, the issue will get closed.
*****************************************************************************
To proof that you read this, please remove the X from the line below:
*****************************************************************************
-->
<!-- oooooo -->
### Description
If a vault is being unlocked and the vault is removed from the vault list during this process, the unlocking process is not interrupted. Therefore, as soon as the unlocking process is completed, the unlocked vault is accessible in the system. The successful completion of the unlock process is communicated via popup as usual.
### System Setup
* Operating system and version: macOS 10.15.7
* Cryptomator version: 1.5.10
* Volume type: FUSE
### Steps to Reproduce
1. Use a very slow file system / slow cloud so step 3 & 4 can be done before the vault is unlocked.
2. Start the unlock process by entering the password and click the Unlock button.
3. Immediately close the "popup" window from step 2.
4. Remove the vault from the vault list.
5. Wait until the unlock process is completed successfully (message in popup window).
#### Expected Behavior
The safe is not unlocked because the unlocking process is aborted.
#### Actual Behavior
The safe is unlocked and can only be unhooked by restarting Cryptomator. Moreover, if the vault is added to the list again, the vault cannot be unlocked because it already is and it will be shown as locked in the vault list.
#### Reproducibility
Always
### Additional Information
If the vault is added again while the removed vault is still unlocked, the newly added vault cannot be unlocked and the following error message appears:
```
java.nio.file.FileSystemAlreadyExistsException
at org.cryptomator.cryptofs.CryptoFileSystems.lambda$create$0(CryptoFileSystems.java:49)
at java.base/java.util.concurrent.ConcurrentHashMap.compute(Unknown Source)
at org.cryptomator.cryptofs.CryptoFileSystems.create(CryptoFileSystems.java:40)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:301)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:93)
at java.base/java.nio.file.FileSystems.newFileSystem(Unknown Source)
at java.base/java.nio.file.FileSystems.newFileSystem(Unknown Source)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:134)
at org.cryptomator.common.vaults.Vault.unlockCryptoFileSystem(Vault.java:126)
at org.cryptomator.common.vaults.Vault.lambda$getCryptoFileSystem$0(Vault.java:104)
at org.cryptomator.common.LazyInitializer.lambda$invokeFactoryIfNull$1(LazyInitializer.java:62)
at java.base/java.util.concurrent.atomic.AtomicReference.updateAndGet(Unknown Source)
at org.cryptomator.common.LazyInitializer.initializeLazily(LazyInitializer.java:49)
at org.cryptomator.common.vaults.Vault.getCryptoFileSystem(Vault.java:104)
at org.cryptomator.common.vaults.Vault.unlock(Vault.java:130)
at org.cryptomator.ui.unlock.UnlockWorkflow.attemptUnlock(UnlockWorkflow.java:107)
at org.cryptomator.ui.unlock.UnlockWorkflow.call(UnlockWorkflow.java:90)
at org.cryptomator.ui.unlock.UnlockWorkflow.call(UnlockWorkflow.java:44)
at javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
```
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
| https://github.com/cryptomator/cryptomator/issues/1478 | https://github.com/cryptomator/cryptomator/pull/1595 | c05c5e3f90641a0e99183492fef27444caa6e954 | 217e31fbd7b6032123d87b95f19d05ccf967c4dd | 2020-12-23T14:53:22Z | java | 2021-03-30T14:03:41Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,404 | [".github/workflows/build.yml", ".github/workflows/release.yml", ".idea/misc.xml", "README.md", "dist/linux/debian/control", "pom.xml"] | Cryptomator icon in the menu bar doesn't change color | ### Description
The cryptomator icon in the menu bar doesn't change to a light color if a dark background is used. Due to the translucent menu bar in macOS Big Sur the icon is hardly visible.
### System Setup
* Operating system and version: macOS Big Sur 11.0.1 (Appearance: light)
* Cryptomator version: 1.5.8
* Volume type: WebDAV
### Steps to Reproduce
1. Set appearance to "light" in the settings of macOS
2. Change the background image to a dark one
#### Expected Behavior
Cryptomator icon changes to a light color
#### Actual Behavior
Cryptomator icon is still dark.
#### Reproducibility
Always
| https://github.com/cryptomator/cryptomator/issues/1404 | https://github.com/cryptomator/cryptomator/pull/1828 | 8319a09b120116598d22543eb21b9e8d52d64f06 | 6c6f6baf12b73a92a6ac973453fff35de9c8d542 | 2020-11-14T17:52:40Z | java | 2021-10-08T12:59:24Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,382 | ["pom.xml"] | Problems with cryptomator after upgrading to Ubuntu 20.10 | After upgrading to Ubuntu 20.10, cryptomator just crash when i try to open a Vault with FUSE.
When opening with WebDav, it will open. But it will crash after some time, and operations are slow.
See this error log:
[hs_err_pid52521.log](https://github.com/cryptomator/cryptomator/files/5435600/hs_err_pid52521.log)
| https://github.com/cryptomator/cryptomator/issues/1382 | https://github.com/cryptomator/cryptomator/pull/3142 | 4ee1e6d9f1c79efc2bc25e3eaf88e54d20a68840 | a7eba377baf511f5107c24808de5b48bfa10ea3f | 2020-10-25T18:13:15Z | java | 2023-10-09T09:58:47Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,345 | ["main/keychain/src/main/java/org/cryptomator/keychain/LinuxKDEWalletKeychainAccessImpl.java", "main/pom.xml", "main/ui/src/main/resources/license/THIRD-PARTY.txt"] | Running the develop branch in an IDE on an OS other than Linux prints a DbusException | It looks like this
```
19:32:40.452 [main] INFO org.cryptomator.launcher.Cryptomator - Starting Cryptomator SNAPSHOT on Mac OS X 10.15.6 (x86_64)
19:32:40.697 [JavaFX Application Thread] INFO o.c.ui.launcher.FxApplicationStarter - JavaFX Runtime started.
19:32:40.744 [JavaFX Application Thread] ERROR o.f.secret.simple.SimpleCollection - org.freedesktop.dbus.exceptions.DBusException: Cannot Resolve Session Bus Address: MachineId file can not be found
org.freedesktop.dbus.exceptions.DBusException: Cannot Resolve Session Bus Address: MachineId file can not be found
at org.freedesktop.dbus.connections.impl.DBusConnection.lambda$determineMachineIdFile$5(DBusConnection.java:320)
at java.base/java.util.Optional.orElseThrow(Optional.java:401)
at org.freedesktop.dbus.connections.impl.DBusConnection.determineMachineIdFile(DBusConnection.java:320)
at org.freedesktop.dbus.connections.impl.DBusConnection.getDbusMachineId(DBusConnection.java:303)
at org.freedesktop.dbus.connections.impl.DBusConnection.getConnection(DBusConnection.java:149)
at org.freedesktop.dbus.connections.impl.DBusConnection.getConnection(DBusConnection.java:169)
at org.freedesktop.dbus.connections.impl.DBusConnection.getConnection(DBusConnection.java:228)
at org.freedesktop.dbus.connections.impl.DBusConnection.getConnection(DBusConnection.java:184)
at org.cryptomator.keychain.LinuxKDEWalletKeychainAccessImpl.<init>(LinuxKDEWalletKeychainAccessImpl.java:23)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at org.cryptomator.keychain.LinuxSystemKeychainAccess.constructKeychainAccess(LinuxSystemKeychainAccess.java:32)
at org.cryptomator.keychain.LinuxSystemKeychainAccess.<init>(LinuxSystemKeychainAccess.java:22)
at org.cryptomator.keychain.LinuxSystemKeychainAccess_Factory.get(LinuxSystemKeychainAccess_Factory.java:16)
at org.cryptomator.keychain.LinuxSystemKeychainAccess_Factory.get(LinuxSystemKeychainAccess_Factory.java:6)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at dagger.internal.SetFactory.get(SetFactory.java:126)
at dagger.internal.SetFactory.get(SetFactory.java:37)
at org.cryptomator.keychain.KeychainModule_ProvideSupportedKeychainFactory.get(KeychainModule_ProvideSupportedKeychainFactory.java:25)
at org.cryptomator.keychain.KeychainModule_ProvideSupportedKeychainFactory.get(KeychainModule_ProvideSupportedKeychainFactory.java:10)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.cryptomator.keychain.KeychainModule_ProvideKeychainManagerFactory.get(KeychainModule_ProvideKeychainManagerFactory.java:24)
at org.cryptomator.keychain.KeychainModule_ProvideKeychainManagerFactory.get(KeychainModule_ProvideKeychainManagerFactory.java:9)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.cryptomator.ui.common.VaultService_Factory.get(VaultService_Factory.java:28)
at org.cryptomator.ui.common.VaultService_Factory.get(VaultService_Factory.java:10)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.cryptomator.ui.fxapp.FxApplication_Factory.get(FxApplication_Factory.java:73)
at org.cryptomator.ui.fxapp.FxApplication_Factory.get(FxApplication_Factory.java:20)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.cryptomator.launcher.DaggerCryptomatorComponent$FxApplicationComponentImpl.application(DaggerCryptomatorComponent.java:1055)
at org.cryptomator.ui.launcher.FxApplicationStarter.lambda$start$0(FxApplicationStarter.java:47)
at com.sun.javafx.application.PlatformImpl.lambda$startup$5(PlatformImpl.java:271)
at com.sun.glass.ui.Application.invokeAndWait(Application.java:464)
at com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:366)
at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:280)
at com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
19:32:46.550 [JavaFX Application Thread] INFO o.cryptomator.ui.fxapp.UpdateChecker - Current version: null, lastest version: 1.5.8
```
<s>and is due to the fact that the decision to provide a `KeychainManager` is done early on startup.</s>
and is due to the fact that a stacktrace is printed instead of a simple error message on initialization of `LinuxKDEWalletKeychainAccessImpl()`.
`LinuxKDEWalletKeychainAccessImpl()` opens a Dbus-Connection, which throws the Exception above. As this does not break anything, it's quite ugly, but can be prevented with an easy fix.
Edit: corrected root cause.
| https://github.com/cryptomator/cryptomator/issues/1345 | https://github.com/cryptomator/cryptomator/pull/1346 | 0a32de2c92bf6cd7c7aea56d93b0f4efc07ba3eb | 26160e9bbcc49b6d3e3c8b3e677f5621acdf0628 | 2020-09-14T17:52:00Z | java | 2020-10-21T08:56:16Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,323 | ["main/ui/src/main/java/org/cryptomator/ui/fxapp/FxApplication.java", "main/ui/src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java", "main/ui/src/main/java/org/cryptomator/ui/quit/QuitComponent.java", "main/ui/src/main/java/org/cryptomator/ui/quit/QuitController.java"] | The "close window" can be opend multiple times | <!--
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
-->
### Description
When a vault is still unlocked and the user wants to close the application, the user gets the pop-up window, on how to proceed.
"Quit application? There are unlocked vaults."
This Window can be reopened multiple times. Each time a new window appears.
### System Setup
* Operating system and version: Windows 10
* Cryptomator version: 1.5.8
* Volume type: /
### Steps to Reproduce
1. Unlock a vault
2. Try closing Cryptomator via taskbar, right-click on Cryptomator bot, close
3. Don't interact with the window. repeat step 2
4. Move the upper (newest) close window and you see the other one behind it.
#### Expected Behavior
There is only one close/quit window. When this gets out of focus and the user tries to open a new quit window, the old/current window gets refocused.
#### Actual Behavior
A new quit window appears.
#### Reproducibility
Always
### Additional Information
 | https://github.com/cryptomator/cryptomator/issues/1323 | https://github.com/cryptomator/cryptomator/pull/1427 | e82167b5e651f256616f7f2809d9f98017fcbb38 | 82538091c9c6ae34e07fe4a8e4c01dd00602c8b8 | 2020-09-01T08:30:22Z | java | 2020-11-24T14:31:31Z |
closed | cryptomator/cryptomator | https://github.com/cryptomator/cryptomator | 1,291 | ["main/commons/src/main/java/org/cryptomator/common/settings/UiTheme.java", "main/ui/src/main/java/org/cryptomator/ui/fxapp/FxApplication.java"] | Automatic Theme Based on Windows System Settings | An "Automatic" theme should be added that automatically detects if the system is in dark or light mode and switch to dark or light theme accordingly.
This issue is for Windows only.
References:
- https://stackoverflow.com/a/41763234/1759462
- https://docs.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.uisettings.getcolorvalue
- https://docs.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.uisettings.colorvalueschanged | https://github.com/cryptomator/cryptomator/issues/1291 | https://github.com/cryptomator/cryptomator/pull/1556 | fe3d67d937371dee9af56253e7c243caffbfc71d | 6878f2e94b167900da1a5f3c303704857e8300e2 | 2020-08-06T11:59:21Z | java | 2021-02-24T13:31:17Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.