status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,289 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/get-version.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
Vault at filesystem roots prevent main application from showing
|
### Description
If a vault without a parent directory (i.e. the vault files are located at a filesystem root) is added to Cryptomator, the application windows refuses to open and an (unlogged) NPE is thrown. This was not a problem in version prior to 1.5.0
### System Setup
* Operating system and version: -
* Cryptomator version: 1.5.6
* Volume type: -
### Steps to Reproduce
Prerequisites: Having the d directory and the masterkey.cryptomator located at a root (e.g. `T:\`)
1. Add vault to Cryptomator
2. Show Main window
#### Expected Behavior
The main window is shown
#### Actual Behavior
The main window is not opened, no error logged.
#### Reproducibility
Always
### Additional Information
```
12:46:21.658 [main] DEBUG org.cryptomator.launcher.Cryptomator - Did not find running application instance. Launching GUI...
12:46:21.805 [main] DEBUG o.c.ui.traymenu.TrayIconController - initialized tray icon
12:46:21.808 [main] DEBUG org.cryptomator.launcher.IpcFactory - [Server] Shut down
Exception in thread "main" java.lang.NullPointerException
at org.cryptomator.common.vaults.Vault.getDisplayableName(Vault.java:234)
at org.cryptomator.ui.traymenu.TrayMenuController.buildSubmenu(TrayMenuController.java:83)
at org.cryptomator.ui.traymenu.TrayMenuController.rebuildMenu(TrayMenuController.java:67)
at org.cryptomator.ui.traymenu.TrayMenuController.initTrayMenu(TrayMenuController.java:46)
at org.cryptomator.ui.traymenu.TrayIconController.initializeTrayIcon(TrayIconController.java:47)
at org.cryptomator.ui.traymenu.TrayMenuComponent.addIconToSystemTray(TrayMenuComponent.java:20)
at org.cryptomator.ui.launcher.UiLauncher.launch(UiLauncher.java:47)
at org.cryptomator.launcher.Cryptomator.runGuiApplication(Cryptomator.java:91)
at org.cryptomator.launcher.Cryptomator.run(Cryptomator.java:75)
at org.cryptomator.launcher.Cryptomator.main(Cryptomator.java:48)
```
|
https://github.com/cryptomator/cryptomator/issues/1289
|
https://github.com/cryptomator/cryptomator/pull/3135
|
625334c6c8d314c21fc34f0815b10c9490a15d7f
|
4ee1e6d9f1c79efc2bc25e3eaf88e54d20a68840
| 2020-08-06T10:46:41Z |
java
| 2023-10-04T20:24:43Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,287 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/get-version.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
iCloud vault upgrade to v7 format fails
|
### Description
iCloud vault upgrade to v7 format fails.
```
org.cryptomator.cryptofs.migration.v7.PreMigrationVisitor$PreMigrationChecksFailedException: Migration impossible due to file: .E3FCN52E6EP5LJTR5K3YCK62W4KEWEFX.lng.icloud
at org.cryptomator.cryptofs.migration.v7.PreMigrationVisitor.assertNotBlacklisted(PreMigrationVisitor.java:101)
at org.cryptomator.cryptofs.migration.v7.PreMigrationVisitor.visitFile(PreMigrationVisitor.java:64)
at org.cryptomator.cryptofs.migration.v7.PreMigrationVisitor.visitFile(PreMigrationVisitor.java:14)
at java.base/java.nio.file.Files.walkFileTree(Unknown Source)
at org.cryptomator.cryptofs.migration.v7.Version7Migrator.migrate(Version7Migrator.java:82)
at org.cryptomator.cryptofs.migration.Migrators.migrate(Migrators.java:112)
at org.cryptomator.ui.migration.MigrationRunController.lambda$migrate$2(MigrationRunController.java:115)
at org.cryptomator.ui.common.Tasks$TaskImpl.call(Tasks.java:139)
at javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
```
### System Setup
* Operating system and version: macOS 10.15.6 (19G73)
* Cryptomator version: 1.5.6 (previously 1.4.something)
### Steps to Reproduce
1. Start cryptomator after update to my first `1.5.x` version, coming from `1.4.x`.
2. Select vault located in iCloud and click "Upgrade Vault".
#### Expected Behavior
Migration to succeed.
#### Actual Behavior
Migration fails.
#### Reproducibility
Always.
### Additional Information
Log:
```
08:56:09.650 [App Background Thread 006] INFO o.c.c.migration.v7.Version7Migrator - Upgrading /Users/USERNAME/Library/Mobile Documents/iCloud~com~setolabs~Cryptomator/Documents/iCloudVault from version 6 to version 7.
08:56:09.833 [App Background Thread 006] INFO o.c.c.migration.v7.Version7Migrator - Backed up masterkey from masterkey.cryptomator to masterkey.cryptomator.9181F49E.bkup.
08:56:09.845 [App Background Thread 006] INFO o.c.c.migration.v7.Version7Migrator - Underlying file system meets filename length requirements.
14:36:27.680 [App Background Thread 004] INFO o.c.c.migration.v7.Version7Migrator - Upgrading /Users/USERNAME/Library/Mobile Documents/iCloud~com~setolabs~Cryptomator/Documents/iCloudVault from version 6 to version 7.
14:36:28.205 [App Background Thread 004] INFO o.c.c.migration.v7.Version7Migrator - Backed up masterkey from masterkey.cryptomator to masterkey.cryptomator.9181F49E.bkup.
14:36:28.220 [App Background Thread 004] INFO o.c.c.migration.v7.Version7Migrator - Underlying file system meets filename length requirements.
```
|
https://github.com/cryptomator/cryptomator/issues/1287
|
https://github.com/cryptomator/cryptomator/pull/3135
|
625334c6c8d314c21fc34f0815b10c9490a15d7f
|
4ee1e6d9f1c79efc2bc25e3eaf88e54d20a68840
| 2020-08-04T12:46:10Z |
java
| 2023-10-04T20:24:43Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,276 |
["main/commons/src/main/java/org/cryptomator/common/vaults/VaultStats.java", "main/ui/src/main/java/org/cryptomator/ui/common/Tasks.java", "main/ui/src/main/java/org/cryptomator/ui/common/VaultService.java", "main/ui/src/main/java/org/cryptomator/ui/fxapp/UpdateCheckerModule.java", "main/ui/src/main/java/org/cryptomator/ui/fxapp/UpdateCheckerTask.java", "main/ui/src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java", "main/ui/src/main/java/org/cryptomator/ui/recoverykey/RecoveryKeyCreationController.java", "main/ui/src/main/java/org/cryptomator/ui/recoverykey/RecoveryKeyResetPasswordController.java", "main/ui/src/main/java/org/cryptomator/ui/unlock/UnlockWorkflow.java"]
|
No UncaughtExceptionHandler/onFailed method for Tasks
|
### Description
Some implementations of `javafx.concurrent.Task` in the Cryptomator project don't have something similar to an UncaughtExceptionHandler of `java.lang.Thread`. This causes exceptions - that haven't been caught in the `Runner-Thread` - to be neither logged nor handled, which makes debugging difficult.
Generally speaking the following design decision leads to problems: `Thread` has a default `UncaughtExceptionHandler` that prints a `stacktrace` if a `Thread` terminates with an exception. `Task` **suppresses** the exception fully.
### System Setup
* Operating system and version: Any
* Cryptomator version: 1.6.0-SNAPSHOT (Internal)
* Volume type: Any
### Recommended Course of Action
Use a combination of `setOnFailed()` and `getException()` to create an UncaughtExceptionHandler for Tasks.
See for reference: https://github.com/cryptomator/cryptomator/blob/4ab7bfaa20a73a63d76a4867e8804c6329cb5650/main/ui/src/main/java/org/cryptomator/ui/common/VaultService.java#L99
|
https://github.com/cryptomator/cryptomator/issues/1276
|
https://github.com/cryptomator/cryptomator/pull/1384
|
8904df91b495fa959f2d271a669750d9f2447bee
|
16be3e7a97bce44360e1c6bdf10540365c17ebae
| 2020-07-17T17:34:40Z |
java
| 2020-10-29T15:58:51Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,251 |
["main/pom.xml", "main/ui/src/main/java/org/cryptomator/ui/preferences/AutoStartModule.java", "main/ui/src/main/java/org/cryptomator/ui/preferences/AutoStartWinStrategy.java"]
|
Cryptomator does not remember autostart setting
|
<!--
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
-->
### Description
Cryptomator does not remember the setting "Start Cryptomator at system startup" in the app settings (tab "General" / 3rd checkbox from the top) after closing (exiting) and restarting the Cryptomator app. After app restart the corresponding checkbox is unchecked again.
Therefore Cryptomator also does not / cannot start automatically at system startup, but has to be started each time manually.
### System Setup
* Windows 10 Enterprise (Version 1909, Build 18363.900)
* Cryptomator version: 1.5.5
* Drive: Dokany
### Steps to Reproduce
1. Open Crpytomator app
2. Go to system settings / tab "General"
3. Check the last checkbox ("Start Cryptomator at system start")
4. Close the application (right click on Crpytomator taskbar symbol => "quit/exit")
5. Reopen / restart the Crpytomator app
6. Go to system settings / tab "General"
7. The last checkbox ("Start Cryptomator at system start") is unchecked
#### Expected Behavior
Cryptomator should remember the setting and start automatically at system startup, once this has been selected / checked in the settings.
#### Actual Behavior
Cryptomator does not remember the setting and does not start automatically at system startup, when this option has been selected / checked in the settings.
#### Reproducibility
[Always]
### Additional Information
[cryptomator0.log](https://github.com/cryptomator/cryptomator/files/4787787/cryptomator0.log)
[cryptomator1.log](https://github.com/cryptomator/cryptomator/files/4787789/cryptomator1.log)
1. Screenshot of the settings page after performing the above mentioned steps
2. Logfile of activating the setting and then shutting down the application
3. Logfile of application after restart.
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
|
https://github.com/cryptomator/cryptomator/issues/1251
|
https://github.com/cryptomator/cryptomator/pull/1311
|
cedbe6523d9fba8b1dad858264185209e93b36dd
|
fee2d4bc0cb0f10c4c32d9da528ce93b81cd2d03
| 2020-06-16T16:28:57Z |
java
| 2020-08-26T09:44:37Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,242 |
["pom.xml", "src/main/java/org/cryptomator/ui/controls/SecurePasswordField.java"]
|
AppImage on HiDPI screens: Follow system-wide scale settings
|
<!--
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
-->
### Description
On Fedora 32 Workstation (Gnome) the AppImage does not follow the system-wide scale settings from Gnome Settings. Cryptomator AppImage should follow the system-wide settings, because
- User friendliness out-of-the-box is one important goal
- With fractional scaling becoming more prominent (e.g. Ubuntu 20.04) the known workarounds (see Additional Information below) break consistency
Please comment, whether something could be changed to the build process of the AppImage or whether it is an upstream bug. I can file an upstream bug, if considered helpful. Which component?
### System Setup
* Linux: Fedora Workstation 32 (Gnome)
* Dell XPS 13 with HiDPI (200 % scaling)
* Cryptomator version: 1.5.5-x86_64 AppImage
* Drive: irrelevant
### Steps to Reproduce
1. Execute the AppImage
#### Expected Behavior
App window should scale according to system-wide settings.
#### Actual Behavior
App window scales at 100 %.
#### Reproducibility
Always
### Additional Information
Two workarounds exist, see also https://github.com/cryptomator/cryptomator/issues/42.
`gsettings set org.gnome.desktop.interface scaling-factor 2` (not tested by myself) and
`$GDK_SCALE=2 ./cryptomator-1.5.5-x86_64.AppImage` (works for me)
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
|
https://github.com/cryptomator/cryptomator/issues/1242
|
https://github.com/cryptomator/cryptomator/pull/1809
|
53afaf1b125dcfc53880bd8227c7eb0b7f1db0a0
|
90bceb0f6843dde07bb2225098793589eeef1116
| 2020-06-10T19:28:26Z |
java
| 2021-09-24T19:01:19Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,196 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/get-version.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
Version 1.5.4: FileSystemNeedsMigrationException thrown when started
|
<!--
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
-->
### Description
Got this bug message,
```
org.cryptomator.cryptofs.FileSystemNeedsMigrationException: /Users/edunn/Documents/Personnal Files: File system needs migration to a newer format.
at org.cryptomator.cryptofs.CryptoFileSystemProvider.migrateFileSystemIfRequired(CryptoFileSystemProvider.java:311)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:300)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:94)
at java.base/java.nio.file.FileSystems.newFileSystem(Unknown Source)
at java.base/java.nio.file.FileSystems.newFileSystem(Unknown Source)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:135)
at org.cryptomator.common.vaults.Vault.unlockCryptoFileSystem(Vault.java:120)
at org.cryptomator.common.vaults.Vault.lambda$getCryptoFileSystem$0(Vault.java:98)
at org.cryptomator.common.LazyInitializer.lambda$invokeFactoryIfNull$1(LazyInitializer.java:62)
at java.base/java.util.concurrent.atomic.AtomicReference.updateAndGet(Unknown Source)
at org.cryptomator.common.LazyInitializer.initializeLazily(LazyInitializer.java:49)
at org.cryptomator.common.vaults.Vault.getCryptoFileSystem(Vault.java:98)
at org.cryptomator.common.vaults.Vault.unlock(Vault.java:127)
at org.cryptomator.ui.unlock.UnlockWorkflow.attemptUnlock(UnlockWorkflow.java:102)
at org.cryptomator.ui.unlock.UnlockWorkflow.call(UnlockWorkflow.java:79)
at org.cryptomator.ui.unlock.UnlockWorkflow.call(UnlockWorkflow.java:42)
at javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
```
### System Setup
* Operating system and version: MacOS Catalina
* Cryptomator version: 1.5.4
* Drive: WebDAV
### Steps to Reproduce
1. Launch the app after install.
#### Expected Behavior
[What you expect to happen.]
#### Actual Behavior
[What actually happens.]
#### Reproducibility
[Always/Intermittent/Only once]
### Additional Information
[Any additional information, log files, screenshots, configuration, or data that might be necessary to reproduce the issue.]
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
|
https://github.com/cryptomator/cryptomator/issues/1196
|
https://github.com/cryptomator/cryptomator/pull/3135
|
625334c6c8d314c21fc34f0815b10c9490a15d7f
|
4ee1e6d9f1c79efc2bc25e3eaf88e54d20a68840
| 2020-05-13T11:40:12Z |
java
| 2023-10-04T20:24:43Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,189 |
["main/keychain/src/main/java/org/cryptomator/keychain/KeychainAccess.java", "main/keychain/src/main/java/org/cryptomator/keychain/LinuxSecretServiceKeychainAccess.java", "main/keychain/src/main/java/org/cryptomator/keychain/LinuxSecretServiceKeychainAccessImpl.java", "main/keychain/src/main/java/org/cryptomator/keychain/MacSystemKeychainAccess.java", "main/keychain/src/main/java/org/cryptomator/keychain/WindowsProtectedKeychainAccess.java", "main/keychain/src/test/java/org/cryptomator/keychain/MapKeychainAccess.java", "main/ui/src/main/java/org/cryptomator/ui/changepassword/ChangePasswordController.java"]
|
Improve change password workflow / update password in system keychain as well
|
Today, on opening the preferences of a vault and changing the pw, an existing pw in the system keychain for that vault stays unchanged. So, on unlocking, it prompts you with the enter password dialog, pre-filled with the old pw and requires to enter the new pw once more.
It might be easier from the workflow perspective to update the pw in the system keychain accordingly.
What do you think?
Suggestions welcome.
[Here](https://github.com/purejava/cryptomator/commits/update-keychain) is a code example, that is already tested on Linux with gnome-keyring.
Additional testing is required on Windows and Mac, where native functions are part of the game. And on Linux without gnome-keyring installed, of course.
|
https://github.com/cryptomator/cryptomator/issues/1189
|
https://github.com/cryptomator/cryptomator/pull/1191
|
d91d27f2a45acecbf8725a44194ca6471eced4ce
|
8cb9728565ae8d6c1c2493e377b8b9f428dc260a
| 2020-05-10T12:15:42Z |
java
| 2020-05-12T05:41:10Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,153 |
["pom.xml", "src/main/java/org/cryptomator/ui/controls/SecurePasswordField.java"]
|
Unable to add vault: Emojis in path to masterkey file lead to error
|
### Description
I cannot open vaults where the name contains some unicode symbol. This does not happen with the Android App, but with the Desktop App - at least under Linux (more specifically Debian 10). This here is the crash when opening an already existing vault:
```
java.nio.file.NoSuchFileException: /home/sts/ð: Not a vault directory
at org.cryptomator.common.vaults.VaultListManager.add(VaultListManager.java:55)
at org.cryptomator.ui.addvaultwizard.ChooseExistingVaultController.chooseFileAndNext(ChooseExistingVaultController.java:82)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.javafx.reflect.Trampoline.invoke(MethodUtil.java:76)
at jdk.internal.reflect.GeneratedMethodAccessor41.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.javafx.reflect.MethodUtil.invoke(MethodUtil.java:273)
at com.sun.javafx.fxml.MethodHelper.invoke(MethodHelper.java:83)
at javafx.fxml.FXMLLoader$MethodHandler.invoke(FXMLLoader.java:1784)
at javafx.fxml.FXMLLoader$ControllerMethodEventHandler.handle(FXMLLoader.java:1670)
at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
at javafx.event.Event.fireEvent(Event.java:198)
at javafx.scene.Node.fireEvent(Node.java:8885)
at javafx.scene.control.Button.fire(Button.java:203)
at com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:206)
at com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
at javafx.event.Event.fireEvent(Event.java:198)
at javafx.scene.Scene$MouseHandler.process(Scene.java:3890)
at javafx.scene.Scene.processMouseEvent(Scene.java:1885)
at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2618)
at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:409)
at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:299)
at java.base/java.security.AccessController.doPrivileged(Unknown Source)
at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(GlassViewEventHandler.java:447)
at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:412)
at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:446)
at com.sun.glass.ui.View.handleMouseEvent(View.java:556)
at com.sun.glass.ui.View.notifyMouse(View.java:942)
at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
at java.base/java.lang.Thread.run(Unknown Source)
```
### System Setup
* Operating system and version: Debian 10
* Cryptomator version: 1.5.1
* Drive: FUSE
### Steps to Reproduce
1. Create a vault with some name
2. Rename the folder to some unicode symbol
3. Load this vault in Cryptomator
#### Expected Behavior
Cryptomator should open the vault.
#### Actual Behavior
Cryptomator does not open the vault.
#### Reproducibility
Always
### Additional Information
|
https://github.com/cryptomator/cryptomator/issues/1153
|
https://github.com/cryptomator/cryptomator/pull/1809
|
53afaf1b125dcfc53880bd8227c7eb0b7f1db0a0
|
90bceb0f6843dde07bb2225098793589eeef1116
| 2020-04-26T19:33:01Z |
java
| 2021-09-24T19:01:19Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,134 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
Unlock Vault: Exceptional Read-Only Mount not shown in GUI
|
### Description
If a vault is stored onto a filesystem which does not meet the [compability checks](https://github.com/cryptomator/cryptofs/blob/develop/src/main/java/org/cryptomator/cryptofs/common/FileSystemCapabilityChecker.java), the vault is only unlocked in read only mode but without any user interface feedback.
### System Setup
* Operating system and version: ALL
* Cryptomator version: 1.5.1
* Drive: ALL
### Steps to Reproduce
1. Store a vault on an not-fully-compatible drive
2. Add this vault to Cryptomator and unlock it
#### Expected Behavior
Cryptomator notifies the user that the vault is read-only
#### Actual Behavior
Cryptomator shows no indication, only the log contains warnings
#### Reproducibility
Always.
### Additional Information
Log excerpt on a Windows system:
```
13:53:12.644 [main] INFO org.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.5.1 on Windows 10 10.0 (amd64)
13:53:13.381 [JavaFX Application Thread] INFO o.c.ui.launcher.FxApplicationStarter - JavaFX Runtime started.
13:53:13.396 [JavaFX Application Thread] INFO org.cryptomator.jni.FunctionsLoader - loaded WinFunctions.dll
13:53:21.203 [App Scheduled Executor 01] INFO o.c.common.settings.SettingsProvider - Settings saved to C:\Users\[**REDACTED**]\AppData\Roaming\Cryptomator\settings.json
13:53:23.519 [App Scheduled Executor 02] INFO o.c.common.settings.SettingsProvider - Settings saved to C:\Users\[**REDACTED**]\AppData\Roaming\Cryptomator\settings.json
13:53:35.381 [App Scheduled Executor 01] INFO o.c.common.settings.SettingsProvider - Settings saved to C:\Users\[**REDACTED**]\AppData\Roaming\Cryptomator\settings.json
13:53:37.568 [App Scheduled Executor 02] INFO o.c.common.settings.SettingsProvider - Settings saved to C:\Users\[**REDACTED**]\AppData\Roaming\Cryptomator\settings.json
13:53:50.805 [App Scheduled Executor 01] INFO o.c.common.settings.SettingsProvider - Settings saved to C:\Users\[**REDACTED**]\AppData\Roaming\Cryptomator\settings.json
13:53:57.525 [JavaFX Application Thread] INFO o.c.k.WindowsProtectedKeychainAccess - Unable to load existing keychain file, creating new keychain.
13:54:03.168 [App Background Thread 003] WARN o.c.c.c.FileSystemCapabilityChecker - Failed to clean up Z:\Test\c
java.nio.file.FileSystemException: Z:\Test\c: failed to delete one or more files; see suppressed exceptions for details
at com.google.common.io.MoreFiles.throwDeleteFailed(MoreFiles.java:786)
at com.google.common.io.MoreFiles.deleteRecursively(MoreFiles.java:552)
at org.cryptomator.cryptofs.common.FileSystemCapabilityChecker.deleteSilently(FileSystemCapabilityChecker.java:122)
at org.cryptomator.cryptofs.common.FileSystemCapabilityChecker.assertWriteAccess(FileSystemCapabilityChecker.java:88)
at org.cryptomator.cryptofs.CryptoFileSystems.adjustForCapabilities(CryptoFileSystems.java:60)
at org.cryptomator.cryptofs.CryptoFileSystems.create(CryptoFileSystems.java:39)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:301)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:92)
at java.base/java.nio.file.FileSystems.newFileSystem(Unknown Source)
at java.base/java.nio.file.FileSystems.newFileSystem(Unknown Source)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.newFileSystem(CryptoFileSystemProvider.java:133)
at org.cryptomator.common.vaults.Vault.unlockCryptoFileSystem(Vault.java:109)
at org.cryptomator.common.vaults.Vault.lambda$getCryptoFileSystem$0(Vault.java:96)
at org.cryptomator.common.LazyInitializer.lambda$invokeFactoryIfNull$1(LazyInitializer.java:62)
at java.base/java.util.concurrent.atomic.AtomicReference.updateAndGet(Unknown Source)
at org.cryptomator.common.LazyInitializer.initializeLazily(LazyInitializer.java:49)
at org.cryptomator.common.vaults.Vault.getCryptoFileSystem(Vault.java:96)
at org.cryptomator.common.vaults.Vault.unlock(Vault.java:116)
at org.cryptomator.ui.common.VaultService$UnlockVaultTask.call(VaultService.java:299)
at org.cryptomator.ui.common.VaultService$UnlockVaultTask.call(VaultService.java:278)
at javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Suppressed: java.nio.file.FileSystemException: Z:\Test\c\aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.c9r\aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.c9r: Der Dateiname oder die Erweiterung ist zu lang
at java.base/sun.nio.fs.WindowsException.translateToIOException(Unknown Source)
at java.base/sun.nio.fs.WindowsException.asIOException(Unknown Source)
at java.base/sun.nio.fs.WindowsDirectoryStream$WindowsDirectoryIterator.readNextEntry(Unknown Source)
at java.base/sun.nio.fs.WindowsDirectoryStream$WindowsDirectoryIterator.hasNext(Unknown Source)
at com.google.common.io.MoreFiles.deleteDirectoryContentsInsecure(MoreFiles.java:691)
at com.google.common.io.MoreFiles.deleteRecursivelyInsecure(MoreFiles.java:666)
at com.google.common.io.MoreFiles.deleteDirectoryContentsInsecure(MoreFiles.java:692)
at com.google.common.io.MoreFiles.deleteRecursivelyInsecure(MoreFiles.java:666)
at com.google.common.io.MoreFiles.deleteDirectoryContentsInsecure(MoreFiles.java:692)
at com.google.common.io.MoreFiles.deleteRecursivelyInsecure(MoreFiles.java:666)
at com.google.common.io.MoreFiles.deleteRecursively(MoreFiles.java:541)
... 23 common frames omitted
13:54:03.249 [App Background Thread 003] WARN o.c.cryptofs.CryptoFileSystems - No write access to vault. Fallback to read-only access.
13:54:03.276 [App Background Thread 003] INFO o.cryptomator.cryptofs.ReadonlyFlag - Vault opened readonly.
13:54:04.283 [App Background Thread 003] INFO com.dokany.java.DokanyDriver - Dokany version: 130
13:54:04.283 [App Background Thread 003] INFO com.dokany.java.DokanyDriver - Dokany driver version: 400
13:54:07.294 [JavaFX Application Thread] INFO o.c.ui.unlock.UnlockController - Unlock of 'Test' succeeded.
13:54:26.917 [Thread-324] WARN c.dokany.java.DokanyOperationsProxy - zwCreateFile(): Uncaught exception. Returning generic failure code.
java.nio.file.ReadOnlyFileSystemException: null
at org.cryptomator.cryptofs.ReadonlyFlag.assertWritable(ReadonlyFlag.java:33)
at org.cryptomator.cryptofs.CryptoFileSystemImpl.createDirectory(CryptoFileSystemImpl.java:290)
at org.cryptomator.cryptofs.CryptoFileSystemProvider.createDirectory(CryptoFileSystemProvider.java:363)
at java.base/java.nio.file.Files.createDirectory(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.createDirectory(ReadWriteAdapter.java:145)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.zwCreateFile(ReadWriteAdapter.java:130)
at com.dokany.java.DokanyOperationsProxy$ZwCreateFileProxy.callback(DokanyOperationsProxy.java:59)
at jdk.internal.reflect.GeneratedMethodAccessor48.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:
```
This error was reported in our [forum](https://community.cryptomator.org/t/0x8000ffff-with-magentacloud-on-cryptomator-1-5-1/5392?u=infeo) (german post).
|
https://github.com/cryptomator/cryptomator/issues/1134
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2020-04-23T09:55:39Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,133 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
windows encripted multiple files at a time.
|
<!--
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
-->
### Description
In windows
When encripting multiple files at a time.
by this I mean: Drop one directory into the encripted drive while the system is encripting something previously drop into the encripted drive.
Criptomator usually breaks in this case, note this error is highly reproducible.
ERROR: 0X800705AA: Insufficient system resources exist to complete the requested service.
### System Setup
* Operating system and version: [Windows/macOS/Linux + Version]
* Cryptomator version: [Shown in the settings]
* Drive: [Dokany/FUSE/WebDAV]
### Steps to Reproduce
1. drop one large directory with files to be encripted.
2. while encripting, drop another large directory with files to be encripted.
#### Expected Behavior
[What you expect to happen.]
#### Actual Behavior
Fails to copy.
ERROR: 0X800705AA: Insufficient system resources exist to complete the requested service.
#### Reproducibility
Intermittent
### Additional Information
I found this in the log
```
11:38:30.954 [main] INFO org.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.4.0 on Windows 10 10.0 (amd64)
11:38:31.249 [main] INFO o.c.launcher.FileOpenRequestHandler - Unable to setOpenFileHandler, probably not supported on this OS.
11:38:37.536 [JavaFX Application Thread] INFO o.c.launcher.MainApplication - JavaFX application started.
11:38:37.755 [JavaFX Application Thread] INFO o.c.common.settings.SettingsProvider - Settings loaded from C:\Users\hector.franco\AppData\Roaming\Cryptomator\settings.json
11:38:38.040 [JavaFX Application Thread] INFO org.cryptomator.jni.JniModule - loaded WinFunctions.dll
11:38:38.130 [JavaFX Application Thread] INFO o.c.ui.controllers.MainController - Unable to setPreferencesHandler, probably not supported on this OS.
11:38:40.967 [Background Thread 1] INFO com.dokany.java.DokanyDriver - Dokany version: 100
11:38:40.968 [Background Thread 1] INFO com.dokany.java.DokanyDriver - Dokany driver version: 400
11:38:41.742 [JavaFX Application Thread] INFO o.c.ui.controllers.WelcomeController - Current version: 1.4.0, lastest version: 1.5.0
17:26:52.327 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) Error filling Win32FindData with file case107_49.jpg. Occurred error is {}
17:26:52.575 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) findFilesWithPattern(): Stacktrace:
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:408)
at com.sun.jna.Function.invoke(Function.java:354)
at com.sun.jna.Function.invoke(Function.java:308)
at com.sun.jna.CallbackReference$NativeFunctionHandler.invoke(CallbackReference.java:679)
at com.sun.proxy.$Proxy9.fillWin32FindData(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.lambda$findFilesWithPattern$1(ReadWriteAdapter.java:541)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.findFilesWithPattern(ReadWriteAdapter.java:537)
at com.dokany.java.DokanyOperationsProxy$FindFilesWithPatternProxy.callback(DokanyOperationsProxy.java:112)
at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:551)
17:26:52.595 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) Error filling Win32FindData with file case109_54.jpg. Occurred error is {}
17:26:52.596 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) findFilesWithPattern(): Stacktrace:
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:408)
at com.sun.jna.Function.invoke(Function.java:354)
at com.sun.jna.Function.invoke(Function.java:308)
at com.sun.jna.CallbackReference$NativeFunctionHandler.invoke(CallbackReference.java:679)
at com.sun.proxy.$Proxy9.fillWin32FindData(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.lambda$findFilesWithPattern$1(ReadWriteAdapter.java:541)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.findFilesWithPattern(ReadWriteAdapter.java:537)
at com.dokany.java.DokanyOperationsProxy$FindFilesWithPatternProxy.callback(DokanyOperationsProxy.java:112)
at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:551)
17:26:52.781 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) Error filling Win32FindData with file case120_109.jpg. Occurred error is {}
17:26:52.782 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) findFilesWithPattern(): Stacktrace:
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:408)
at com.sun.jna.Function.invoke(Function.java:354)
at com.sun.jna.Function.invoke(Function.java:308)
at com.sun.jna.CallbackReference$NativeFunctionHandler.invoke(CallbackReference.java:679)
at com.sun.proxy.$Proxy9.fillWin32FindData(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.lambda$findFilesWithPattern$1(ReadWriteAdapter.java:541)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.findFilesWithPattern(ReadWriteAdapter.java:537)
at com.dokany.java.DokanyOperationsProxy$FindFilesWithPatternProxy.callback(DokanyOperationsProxy.java:112)
at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:551)
17:26:52.789 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) Error filling Win32FindData with file case121_114.jpg. Occurred error is {}
17:26:52.789 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) findFilesWithPattern(): Stacktrace:
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:408)
at com.sun.jna.Function.invoke(Function.java:354)
at com.sun.jna.Function.invoke(Function.java:308)
at com.sun.jna.CallbackReference$NativeFunctionHandler.invoke(CallbackReference.java:679)
at com.sun.proxy.$Proxy9.fillWin32FindData(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.lambda$findFilesWithPattern$1(ReadWriteAdapter.java:541)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.findFilesWithPattern(ReadWriteAdapter.java:537)
at com.dokany.java.DokanyOperationsProxy$FindFilesWithPatternProxy.callback(DokanyOperationsProxy.java:112)
at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:551)
17:26:57.382 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) Error filling Win32FindData with file case8_1765.jpg. Occurred error is {}
17:26:57.382 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) findFilesWithPattern(): Stacktrace:
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:408)
at com.sun.jna.Function.invoke(Function.java:354)
at com.sun.jna.Function.invoke(Function.java:308)
at com.sun.jna.CallbackReference$NativeFunctionHandler.invoke(CallbackReference.java:679)
at com.sun.proxy.$Proxy9.fillWin32FindData(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.lambda$findFilesWithPattern$1(ReadWriteAdapter.java:541)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.findFilesWithPattern(ReadWriteAdapter.java:537)
at com.dokany.java.DokanyOperationsProxy$FindFilesWithPatternProxy.callback(DokanyOperationsProxy.java:112)
at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:551)
17:26:57.399 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) Error filling Win32FindData with file case91_1816.jpg. Occurred error is {}
17:26:57.400 [Thread-357723] ERROR o.c.frontend.dokany.ReadWriteAdapter - (9691) findFilesWithPattern(): Stacktrace:
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:408)
at com.sun.jna.Function.invoke(Function.java:354)
at com.sun.jna.Function.invoke(Function.java:308)
at com.sun.jna.CallbackReference$NativeFunctionHandler.invoke(CallbackReference.java:679)
at com.sun.proxy.$Proxy9.fillWin32FindData(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.lambda$findFilesWithPattern$1(ReadWriteAdapter.java:541)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at org.cryptomator.frontend.dokany.ReadWriteAdapter.findFilesWithPattern(ReadWriteAdapter.java:537)
at com.dokany.java.DokanyOperationsProxy$FindFilesWithPatternProxy.callback(DokanyOperationsProxy.java:112)
at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.invokeCallback(CallbackReference.java:520)
at com.sun.jna.CallbackReference$DefaultCallbackProxy.callback(CallbackReference.java:551)
```
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
|
https://github.com/cryptomator/cryptomator/issues/1133
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2020-04-23T09:19:10Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,057 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/get-version.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
1.5.0-beta2 + Dokany: Timestamps not preserved when copying in
|
The modification and creation dates are set to the current time when copying files and directories into a vault. I'm using Cryptomator 1.5.0-beta2 and Dokany in Windows 10 1909.
|
https://github.com/cryptomator/cryptomator/issues/1057
|
https://github.com/cryptomator/cryptomator/pull/3135
|
625334c6c8d314c21fc34f0815b10c9490a15d7f
|
4ee1e6d9f1c79efc2bc25e3eaf88e54d20a68840
| 2020-01-28T21:41:26Z |
java
| 2023-10-04T20:24:43Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 1,033 |
["main/commons/src/main/java/org/cryptomator/common/vaults/DokanyVolume.java"]
|
Unable to access Cryptomator-Container from Windows10/WSL
|
<!--
Do you want to ask a QUESTION? Are you looking for SUPPORT?
We're happy to help you via our support channels! Please read: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
By filing an issue, you are expected to comply with our code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
Of course, we also expect you to search for existing similar issues first! ;) https://github.com/cryptomator/cryptomator/issues?q=
-->
### Description
[Summarize your problem.]
I am unable to access cryptomator container from Windows 10/WSL.
### System Setup
* Operating system and version:
Windows 10 (64bit)
WSL with
Distributor ID: Ubuntu
Description: Ubuntu 18.04.3 LTS
Release: 18.04
Codename: bionic
* Cryptomator version:
Windows Version of Cryptomator: 1.4.11
inside Windows10/WSL: cryptomator-1.4.15-x86_64.AppImage
### Steps to Reproduce
1. Create a Cryptomator-Container in Windows (file based).
2. Open Cryptomator-Container inside Windows, i.e. drive letter z:
3. try to access drive z: from WSL. It is not possible.
alternative
1. Create a Cryptomator-Container in Windows (file based).
2. try to install or run Cryptomator inside WSL for opening cryptomator-container there: It is not possible.
#### Expected Behavior
Have access to files inside the cryptomator container via Windows10/WSL
#### Actual Behavior
No access is possible:
#### Reproducibility
always
### Additional Information
Message from ./cryptomator-1.4.15-x86_64.AppImage
inside Windows10/WSL
```
fuse: device not found, try 'modprobe fuse' first
Cannot mount AppImage, please check your FUSE setup.
You might still be able to extract the contents of this AppImage
if you run it with the --appimage-extract option.
See https://github.com/AppImage/AppImageKit/wiki/FUSE
for more information
open dir error: No such file or directory
```
<!--
If you want to add the log file or screenshots, please add them as attachments. If your log file seems empty and doesn't show any errors, you may enable the debug mode first. Here is how to do that: https://community.cryptomator.org/t/how-do-i-enable-debug-mode/36
Then reproduce the problem to ensure all important information is contained in there. You may use test data or redact sensitive information from the log file.
Log file location:
- Windows: %appdata%/Cryptomator
- macOS: ~/Library/Logs/Cryptomator
- Linux: ~/.local/share/Cryptomator/logs
-->
|
https://github.com/cryptomator/cryptomator/issues/1033
|
https://github.com/cryptomator/cryptomator/pull/1371
|
f9cb438a0bdae245d98cda73c279a2dd722e92f1
|
0e5d72c22a2d29316a20ff3739d7aef7c153d37c
| 2019-12-28T13:38:29Z |
java
| 2020-10-12T12:12:09Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 891 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
File/Folder disappears after sequence of actions
|
## Basic Info
I'm using macOS in version 10.14.4.
I'm running Cryptomator in version 1.4.9.
## Description
Here's an examples that shows how a file/folder disappears after sequence of actions.
1. Create an empty vault.
2. Unlock the vault.
3. Create an empty text file and save it to the root folder of the vault with the following file name: `0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt`
4. Rename the file created in step 2 to the following file name: `0.txt`
5. Create a new empty text file and save it to the root folder of the vault with the same name used in step 1: `0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt`
6. Lock the vault.
7. Unlock the vault.
Instead of performing step 6 and step 7, you can wait for about ~20 seconds after step 5.
Also, the ciphertext file name for `0.txt` in `/d/...` folder changes from `Z3P4OLS434F7RES5H4WDV3NZ6C4ST4JZGI======` to `Z3P4OLS434F7RES5H4WDV3NZ6C4ST4JZGI======.lng` after step 7.
## Expected
There should exists two files in the root folder of the vault:
- `0.txt`
- `0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt`
## Actual
The vault shows only one file.
- `0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt`
The file `0.txt` disappears from the vault.
## Terminal Log
```
Davids-MacBook-Pro:~ david$ cd /Volumes/WRdujCzVRdKQ_0/
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ ls -l
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ touch 0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ ls -l
total 0
-rw-r--r-- 1 david staff 0 Dec 31 1969 0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ mv 0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt 0.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ ls -l
total 0
-rw-r--r-- 1 david staff 0 Dec 31 1969 0.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ touch 0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ ls -l
total 0
-rw-r--r-- 1 david staff 0 Dec 31 1969 0.txt
-rw-r--r-- 1 david staff 0 Dec 31 1969 0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ sleep 20
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$ ls -l
total 0
-rw-r--r-- 1 david staff 0 Dec 31 1969 0123456789abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz.txt
Davids-MacBook-Pro:WRdujCzVRdKQ_0 david$
```
|
https://github.com/cryptomator/cryptomator/issues/891
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2019-05-14T07:58:37Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 888 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
Dokany: Mounted Vault crashes sometimes
|
## Basic Info
I'm using Windows in version 10 Enterprise/Pro/Home 1809
I'm running Cryptomator in version 1.4.9
I'm using Dokany in version 1.2.2.1000
## Description
This is a sequel issue to #791.
Some user report that a Dokany provided vault crashes from time to time. The cause of the crashes are still unknown. With "crash" it is meant that the vault is inaccessible in the file explorer, but can be locked and Cryptomator is still useable.
Setups where it crashed:
1. copy a file into the vault with Altap Salamander
1. [Plex](https://www.plex.tv/) library scan of the vault
1. Generate previews in the file explorer of a vault which contain a lot of images
There may be a connection to the usage of Google File Stream in combination with a vault.
There are reports that the crashing does not appear if a specific (old) dokany version is installed (1.0.2). From my point of view this is _not_ a workaround, since god knows what bugs/security problems/whatever lie in this version.
## Attachments (optional)
Currently none.
## Misc
In issue #869 were a case of a crashing vault where an old version of Dokany was used. Cryptomator needs a specific feature level, which is given by Dokany 1.1.X and above.
I could not reproduce this issue on a _local_ vault. (no Google FileStream or other sync software)
|
https://github.com/cryptomator/cryptomator/issues/888
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2019-05-08T14:42:45Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 810 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
Windows 10 / Dokany: Problems with file access in LibreOffice und Indesign
|
## Issue Checklist
Before creating a new issue make sure that you
- searched existing (and closed) issues: https://github.com/cryptomator/cryptomator/issues
- searched the knowledge base: https://community.cryptomator.org/c/kb
- have read the support guide: https://github.com/cryptomator/cryptomator/blob/develop/SUPPORT.md
- have read the contribution guide: https://github.com/cryptomator/cryptomator/blob/develop/.github/CONTRIBUTING.md
- have read the code of conduct: https://github.com/cryptomator/cryptomator/blob/develop/.github/CODE_OF_CONDUCT.md
## Basic Info
I'm using Windows 10 Pro x64 (10.0.17134.523)
I'm running Cryptomator in version: 1.4.2
## Description
When using Dokany LibreOffice and Adobe Indesign show different issues:
- I'm unable to save LibreOffice files in the Cryptomator vault using Dokany. When trying to, LibreOffice prompts with an error message saying "Fehler beim Speichern des Dokumentes [_put filename here_]: Schreibfehler. Die Datei konnte nicht geschrieben werden." which translates to "Error saving the document [_put filename here_]: write error. File could not been saved."
- Adobe Indesign has a similiar issue when saving files: I can't save files that already exist. I'm only able to save new ones. Plus: After opening a file Indesign needs a long time loading the file, like 2 minutes. In the meantime Indesign is not usable and behaves like it crashed. When using Webdav, Indesign opens in a few seconds.
- Other random programs work: Microsoft Office, Windows Explorer etc.
Switching to Webdav is not an option for me because of the overall worse performance.
|
https://github.com/cryptomator/cryptomator/issues/810
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2019-01-23T13:02:10Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 809 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
1.4.2 Same vault opens twice
|
I'm using Windows 10 in version: 1809
I'm running Cryptomator in version: 1.4.2 (WebDAV)
(You can check the version in the Cryptomator settings.)
## Description
Hi there. Since 1.4.2 one of my three vaults opens twice with two different drive letters. See below. This causes some file references to malfunction and I'm sure it's not the intended behaviour.
EDIT: After a restart, my Desktop links don't work anymore; I imagined that "Vault" would at least link to one of the network drives but no. Btw. both drives can be opened and both display the content.
Side note: Unfortunately, Windows Timeline still doesn't work with Office 365 and Dokany is extremely slow on both my Surface and my PC.
|
https://github.com/cryptomator/cryptomator/issues/809
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2019-01-22T15:22:46Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 771 |
["main/ui/src/main/java/org/cryptomator/ui/controllers/MainController.java"]
|
'Locking vault(s) failed' dialog has no cancel option when attempting to close Cryptomator
|
## Basic Info
I'm using Windows 10, Cryptomator 1.4.0
## Description
If I an using the vault and attempt to close Cryptomator by mistake, I get a dialog "Locking vault(s) failed" / "Vault(s) in use". There are only the options "Force Shutdown" or "Try Again".
I think there should be an option to allow the user to cancel the shut down operation in this case and return to a previous state, in the case where a user has attempted to close Cryptomator by mistake, as otherwise there isn't really any other option but to kill the process in task manager, the dialog box is pretty much "stuck" in that state when only those two options are available with no ability to cancel.
|
https://github.com/cryptomator/cryptomator/issues/771
|
https://github.com/cryptomator/cryptomator/pull/784
|
da62a22faf144addc21abfecbb51029ca1c29da5
|
7844078203f349001e9cc1213764bc98e36c048a
| 2018-11-22T11:26:22Z |
java
| 2019-01-14T12:05:40Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 770 |
[".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
Nautilus Linux : Filename too long
|
## Basic Info
I'm using ArchLinux
I'm running Cryptomator in version: 1.4.0
## Description
When I open my vaults, Nautilus opens, showing my folders and files. When I want to create a new folder from Nautilus, It says that my filename it too long. I can only create it with one letter, then it's too long.
But I can create it from an application, folder or file, no problem.
I had no problem neither with webdav, with Cryptomator 1.3.x.
## Attachments (optional)
There's nothing on the log, because the issue is before arriving in Cryptomator... but I don't know where to ask : Nautilus devs ? Fuse devs ?...
|
https://github.com/cryptomator/cryptomator/issues/770
|
https://github.com/cryptomator/cryptomator/pull/3066
|
5c4c59fe18db4742d83ed4fd1e2754dedce0e2a6
|
b7f514e16b0b1d29402a7dc8ead4df5811929408
| 2018-11-20T13:02:54Z |
java
| 2023-08-09T13:03:35Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 671 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/win-exe.yml", "pom.xml"]
|
Ubuntu Bionic: PPA repository does not have a Release file
|
## Basic Info
Ubuntu 18.04
Cryptomator 1.3.2
## Description
When I try to the cryptomator repository as described in the [Download section](https://cryptomator.org/downloads/#linuxDownload)
`sudo add-apt-repository ppa:sebastian-stenzel/cryptomator`
I get the following error:
```
~$ sudo add-apt-repository ppa:sebastian-stenzel/cryptomator
Cryptomator provides free client-side AES encryption for your cloud files. Create encrypted vaults, which get mounted as virtual volumes. Whatever you save on one of these volumes will end up encrypted inside your vault.
https://cryptomator.org/
More info: https://launchpad.net/~sebastian-stenzel/+archive/ubuntu/cryptomator
Press [ENTER] to continue or Ctrl-c to cancel adding it.
Ign:1 http://ppa.launchpad.net/sebastian-stenzel/cryptomator/ubuntu bionic InRelease
Hit:2 http://cy.archive.ubuntu.com/ubuntu bionic InRelease
Get:3 http://cy.archive.ubuntu.com/ubuntu bionic-updates InRelease [65.4 kB]
Get:4 http://security.ubuntu.com/ubuntu bionic-security InRelease [69.9 kB]
Err:5 http://ppa.launchpad.net/sebastian-stenzel/cryptomator/ubuntu bionic Release
404 Not Found [IP: 91.189.95.83 80]
Hit:6 http://cy.archive.ubuntu.com/ubuntu bionic-backports InRelease
Reading package lists... Done
E: The repository 'http://ppa.launchpad.net/sebastian-stenzel/cryptomator/ubuntu bionic Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
```
|
https://github.com/cryptomator/cryptomator/issues/671
|
https://github.com/cryptomator/cryptomator/pull/3228
|
93b09cf449b82c69b9a87f25ba112d358ac12736
|
68713ef9a71a0527b4ed6c5a707543b1028094c2
| 2018-05-03T09:11:18Z |
java
| 2023-11-28T12:28:35Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 668 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/win-exe.yml", "pom.xml"]
|
Mount Point is Not Empty
|
I'm using macOS 10.13.4 and APFS. I'm running Cryptomator 1.4.0-beta1 with the mount method set to FUSE.
I've been running the 1.4.0 beta since it was announced to address the WebDAV connection issue with macOS. Everything worked great for a while. A couple of days ago I attempted to mount one of my Cryptomator vaults and I received a message that the "Unlock failed. See log file for details."
The log contained the following message:
_10:57:52.824 [pool-4-thread-1] ERROR o.cryptomator.ui.model.AutoUnlocker - Auto unlock failed.
java.nio.file.DirectoryNotEmptyException: Mount point is not empty._
This is after multiple reboots and a check run by Disk Utility. Switching to WebDAV as the mount method allowed me to mount the drives.
The complete log file is attached:
[Cryptomator Beta - Fail to Unlock.txt](https://github.com/cryptomator/cryptomator/files/1935723/Cryptomator.Beta.-.Fail.to.Unlock.txt)
|
https://github.com/cryptomator/cryptomator/issues/668
|
https://github.com/cryptomator/cryptomator/pull/3228
|
93b09cf449b82c69b9a87f25ba112d358ac12736
|
68713ef9a71a0527b4ed6c5a707543b1028094c2
| 2018-04-22T15:06:15Z |
java
| 2023-11-28T12:28:35Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 476 |
["main/commons/src/main/java/org/cryptomator/common/settings/VaultSettings.java", "main/commons/src/main/java/org/cryptomator/common/settings/VaultSettingsJsonAdapter.java", "main/ui/src/main/java/org/cryptomator/ui/controllers/UnlockController.java", "main/ui/src/main/java/org/cryptomator/ui/model/DokanyVolume.java", "main/ui/src/main/java/org/cryptomator/ui/model/Vault.java", "main/ui/src/main/resources/fxml/unlock.fxml", "main/ui/src/main/resources/localization/en.txt"]
|
Junctions-Points on NTFS
|
Hello,
This is a feature request.
i have only one questions. Is it possible to hook the Tresors as directory? I mean possible to use junctions on ntfs raither than drive-letters?
thx
|
https://github.com/cryptomator/cryptomator/issues/476
|
https://github.com/cryptomator/cryptomator/pull/797
|
078a1271826dea17289a5b151539a3360a2be1c8
|
bbe1ef3dbc479e9699559c027b7030af2248638b
| 2017-03-24T02:13:38Z |
java
| 2019-01-16T14:08:00Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 300 |
["pom.xml"]
|
Plausible deniability
|
For increase the cryptosystem security, encrypt the .cryptomator file and allow to select an arbitrary name. To open the vault the user doesn't select a directory, select a file.
Ok, ¡We need to store the salt in anyplace!. This place is the header of the encrypted .cryptomator. For example, this can be the file content:
```
<version><salt-size><salt-bytes><cost-param><block-size><encrypted xml>
```
The "<encrypted xml>" has the rest of parameters: primaryMasterKey, hmacMasterKey, versionMac.
No one could identity than a directory is a cryptomator vault.
|
https://github.com/cryptomator/cryptomator/issues/300
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2016-06-22T07:32:26Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 298 |
["pom.xml"]
|
[Feature Request] Decrypt all files inside vault
|
### Basic Info
- I'm running Cryptomator on: Windows 7 & Linux Mint
- I'm using Cryptomator in version: 1.1.0
### Description
I would like to request an option for allowing us to recursively decrypt all files inside the vault when unlocking it.
It currently appears to decrypt on demand; which can be excessively slow when you want to run software or general content that depend on each files to be decrypted. By giving us the option to decrypt all, it should theoretically speed everything up and act more like an USB in terms of speed.
I figure we are currently decrypting files on demand because of mobile apps? I hope to see an option for this in the future for the desktop. :)
|
https://github.com/cryptomator/cryptomator/issues/298
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2016-06-17T23:48:19Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 285 |
[".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
[OSX] Connection to localhost failed
|
### Basic Info
- I'm running Cryptomator on **OS X 10.10.5**
- I'm using Cryptomator in **version 1.1.0**
### Description
I'm unable to mount the crypted drive: _"Connection to localhost failed"_.
No Firewall is activated.
<img width="532" alt="capture d ecran 2016-06-06 a 13 06 13" src="https://cloud.githubusercontent.com/assets/334996/15820121/9511b09e-2be7-11e6-96a1-b57b64a92c42.png">
### Log File
```
2016-06-06 13:06:07,127 INFO [Cryptomator:40] Starting Cryptomator 1.1.0 on Mac OS X 10.10.5 (x86_64)
2016-06-06 13:06:07,311 INFO [SingleInstanceManager:299] no running instance found
2016-06-06 13:06:07,438 INFO [MainApplication:41] JavaFX application started
2016-06-06 13:06:07,458 INFO [Localization:42] Loaded localization from /localization/fr.txt
2016-06-06 13:06:07,636 INFO [SettingsProvider:86] Settings loaded from /Users/m.moquet/Library/Application Support/Cryptomator/settings.json
2016-06-06 13:06:08,832 DEBUG [SingleInstanceManager:325] InstanceManager bound to port 57751
2016-06-06 13:06:09,140 DEBUG [WelcomeController:151] Current version: 1.1.0, lastest version: 1.1.0
2016-06-06 13:06:11,593 INFO [WebDavMounterProvider:39] Using MacOsXAppleScriptWebDavMounter
2016-06-06 13:06:11,610 INFO [log:186] Logging initialized @4955ms
2016-06-06 13:06:11,723 INFO [Server:345] jetty-9.3.3.v20150827
2016-06-06 13:06:11,773 INFO [ContextHandler:775] Started o.e.j.s.ServletContextHandler@73cd6d52{/,null,AVAILABLE}
2016-06-06 13:06:11,791 INFO [ServerConnector:270] Started ServerConnector@41940974{HTTP/1.1,[http/1.1]}{0.0.0.0:42427}
2016-06-06 13:06:11,792 INFO [Server:397] Started @5139ms
2016-06-06 13:06:11,793 INFO [WebDavServer:79] Cryptomator is running on port 42427
2016-06-06 13:06:12,267 INFO [WebDavServer:117] Servlet available under http://localhost:42427/Secret
2016-06-06 13:06:12,270 INFO [AbstractWebdavServlet:169] authenticate-header = Basic realm="Jackrabbit Webdav Server"
2016-06-06 13:06:12,271 INFO [AbstractWebdavServlet:174] csrf-protection = null
2016-06-06 13:06:12,272 INFO [AbstractWebdavServlet:181] createAbsoluteURI = true
2016-06-06 13:06:12,272 INFO [ContextHandler:775] Started o.e.j.s.ServletContextHandler@56fb5b43{/Secret,null,AVAILABLE}
2016-06-06 13:06:12,549 DEBUG [Server:506] REQUEST on HttpChannelOverHttp@532600aa{r=1,c=false,a=DISPATCHED,uri=/Secret}
OPTIONS //localhost:42427/Secret
Host: localhost:42427
Accept: */*
Content-Length: 0
Connection: close
User-Agent: WebDAVLib/1.3
2016-06-06 13:06:12,556 DEBUG [Server:520] RESPONSE for /Secret h=true
302 null
Connection: close
Date: Mon, 06 Jun 2016 11:06:12 GMT
Location: http://localhost:42427/Secret/
2016-06-06 13:06:12,568 DEBUG [Server:506] REQUEST on HttpChannelOverHttp@2ae7627e{r=1,c=false,a=DISPATCHED,uri=/Secret/}
OPTIONS //localhost:42427/Secret/
Host: localhost:42427
Accept: */*
Content-Length: 0
Connection: close
User-Agent: WebDAVLib/1.3
2016-06-06 13:06:12,582 DEBUG [Server:520] RESPONSE for /Secret/ h=true
405 Can only access drive from localhost.
Connection: close
Date: Mon, 06 Jun 2016 11:06:12 GMT
Cache-Control: must-revalidate,no-cache,no-store
Content-Type: text/html;charset=iso-8859-1
Content-Length: 351
2016-06-06 13:06:12,590 DEBUG [Server:506] REQUEST on HttpChannelOverHttp@1515f8d6{r=1,c=false,a=DISPATCHED,uri=/Secret}
OPTIONS //localhost:42427/Secret
Host: localhost:42427
Accept: */*
Content-Length: 0
Connection: close
User-Agent: WebDAVLib/1.3
2016-06-06 13:06:12,590 DEBUG [Server:520] RESPONSE for /Secret h=true
302 null
Connection: close
Date: Mon, 06 Jun 2016 11:06:12 GMT
Location: http://localhost:42427/Secret/
2016-06-06 13:06:12,600 DEBUG [Server:506] REQUEST on HttpChannelOverHttp@50176410{r=1,c=false,a=DISPATCHED,uri=/Secret/}
OPTIONS //localhost:42427/Secret/
Host: localhost:42427
Accept: */*
Content-Length: 0
Connection: close
User-Agent: WebDAVLib/1.3
2016-06-06 13:06:12,601 DEBUG [Server:520] RESPONSE for /Secret/ h=true
405 Can only access drive from localhost.
Connection: close
Date: Mon, 06 Jun 2016 11:06:12 GMT
Cache-Control: must-revalidate,no-cache,no-store
Content-Type: text/html;charset=iso-8859-1
Content-Length: 351
2016-06-06 13:06:18,996 ERROR [UnlockController:304] Decryption failed for technical reasons.
org.cryptomator.frontend.FrontendCreationFailedException: org.cryptomator.frontend.CommandFailedException: Command failed with exit code 1. Stderr: 0:44: execution error: An error of type -5014 has occurred. (-5014)
at org.cryptomator.ui.model.Vault.activateFrontend(Vault.java:139) ~[Cryptomator-1.1.0.jar:1.1.0]
at org.cryptomator.ui.controllers.UnlockController.unlock(UnlockController.java:283) ~[Cryptomator-1.1.0.jar:1.1.0]
at org.cryptomator.ui.controllers.UnlockController.lambda$didClickUnlockButton$0(UnlockController.java:277) ~[Cryptomator-1.1.0.jar:1.1.0]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_92]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_92]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_92]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_92]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_92]
Caused by: org.cryptomator.frontend.CommandFailedException: Command failed with exit code 1. Stderr: 0:44: execution error: An error of type -5014 has occurred. (-5014)
at org.cryptomator.frontend.webdav.mount.MacOsXAppleScriptWebDavMounter.waitForProcessAndCheckSuccess(MacOsXAppleScriptWebDavMounter.java:116) ~[frontend-webdav-1.1.0.jar:?]
at org.cryptomator.frontend.webdav.mount.MacOsXAppleScriptWebDavMounter.mount(MacOsXAppleScriptWebDavMounter.java:57) ~[frontend-webdav-1.1.0.jar:?]
at org.cryptomator.frontend.webdav.WebDavFrontend.mount(WebDavFrontend.java:48) ~[frontend-webdav-1.1.0.jar:?]
at org.cryptomator.ui.model.Vault.activateFrontend(Vault.java:136) ~[Cryptomator-1.1.0.jar:1.1.0]
... 7 more
2016-06-06 13:06:23,700 DEBUG [Cryptomator:104] Shutting down
```
|
https://github.com/cryptomator/cryptomator/issues/285
|
https://github.com/cryptomator/cryptomator/pull/3066
|
5c4c59fe18db4742d83ed4fd1e2754dedce0e2a6
|
b7f514e16b0b1d29402a7dc8ead4df5811929408
| 2016-06-06T11:10:42Z |
java
| 2023-08-09T13:03:35Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 229 |
[".github/workflows/release-check.yml", ".github/workflows/win-exe.yml"]
|
Password Recovery
|
## Issue
It's not that unlikely that we forget passwords. Especially when they're newly created. In most cases this isn't an issue, because we're used to "forgot your password?" workflows. In Cryptomator's case it's fatal, because you won't be able to access your vault anymore.
This isn't the only reason why we haven't implemented #40 yet, but an automatism would increase the probability of forgetting passwords. That's why I've struggled with the Touch ID implementation in the iOS app, even though it's already in the app.
## Suggestion
Optionally generate a `recovery code` after a vault has been created. With the `recovery code` you will be able to set a new password for your vault. There should also be the possibility to generate a new `recovery code`, when a vault has been successfully unlocked. Recovery codes are already common practice when you activate two-step authentication in most online services. I'm not aware of any standardization of what the pattern of the `recovery code` should look like, but it shouldn't be too short (security) and shouldn't be too long (usability).
For example `xxxx-xxxx-xxxx-xxxx` is a pattern that we could use with `x = [a-z0-9]`. In my opinion the `recovery code` should be case-insensitive, because it's better usability-wise and doesn't weaken security significantly. Lowercase is preferred, because there are less-likely mix-ups like `0` and `O`.
|
https://github.com/cryptomator/cryptomator/issues/229
|
https://github.com/cryptomator/cryptomator/pull/3066
|
5c4c59fe18db4742d83ed4fd1e2754dedce0e2a6
|
b7f514e16b0b1d29402a7dc8ead4df5811929408
| 2016-04-11T09:15:52Z |
java
| 2023-08-09T13:03:35Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 210 |
["pom.xml"]
|
Vault fails to open using Windows x64 version 1.03
|
I upgraded to version 1.0.3 today and now I cannot access my vault. Here is the logfile with the error:
```
2016-03-31 09:33:00,286 INFO [SingleInstanceManager:299] no running instance found
2016-03-31 09:33:01,296 DEBUG [SingleInstanceManager:325] InstanceManager bound to port 52942
2016-03-31 09:33:01,434 DEBUG [WelcomeController:151] Current version: 1.0.3, lastest version: 1.0.3
2016-03-31 09:33:40,819 INFO [WebDavMounterProvider:39] Using WindowsWebDavMounter
2016-03-31 09:33:40,833 INFO [log:186] Logging initialized @40939ms
2016-03-31 09:33:40,886 INFO [Server:345] jetty-9.3.3.v20150827
2016-03-31 09:33:40,906 INFO [ContextHandler:775] Started o.e.j.s.ServletContextHandler@741ab977{/,null,AVAILABLE}
2016-03-31 09:33:40,912 INFO [ServerConnector:270] Started ServerConnector@5322abd3{HTTP/1.1,[http/1.1]}{0.0.0.0:50502}
2016-03-31 09:33:40,913 INFO [Server:397] Started @41021ms
2016-03-31 09:33:40,913 INFO [WebDavServer:79] Cryptomator is running on port 50502
2016-03-31 09:33:41,115 INFO [WebDavServer:117] Servlet available under http://localhost:50502/data
2016-03-31 09:33:41,119 INFO [AbstractWebdavServlet:169] authenticate-header = Basic realm="Jackrabbit Webdav Server"
2016-03-31 09:33:41,119 INFO [AbstractWebdavServlet:174] csrf-protection = null
2016-03-31 09:33:41,120 INFO [AbstractWebdavServlet:181] createAbsoluteURI = true
2016-03-31 09:33:41,120 INFO [ContextHandler:775] Started o.e.j.s.ServletContextHandler@12ba5742{/data,null,AVAILABLE}
2016-03-31 09:33:41,148 DEBUG [CommandResult:85] Command execution finished. Exit code: 0
Output: The operation completed successfully.
2016-03-31 09:33:41,172 DEBUG [CommandResult:87] Command execution finished. Exit code: 2
Error: System error 53 has occurred.
The network path was not found.
2016-03-31 09:33:41,173 ERROR [UnlockController:301] Decryption failed for technical reasons.
org.cryptomator.frontend.FrontendCreationFailedException: org.cryptomator.frontend.CommandFailedException: Command execution failed. Exit code: 2
# Output:
# Error:
System error 53 has occurred.
The network path was not found.
at org.cryptomator.ui.model.Vault.activateFrontend(Vault.java:137) ~[Cryptomator-1.0.3.jar:1.0.3]
at org.cryptomator.ui.controllers.UnlockController.unlock(UnlockController.java:280) ~[Cryptomator-1.0.3.jar:1.0.3]
at org.cryptomator.ui.controllers.UnlockController.lambda$didClickUnlockButton$0(UnlockController.java:274) ~[Cryptomator-1.0.3.jar:1.0.3]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_74]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_74]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_74]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_74]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_74]
Caused by: org.cryptomator.frontend.CommandFailedException: Command execution failed. Exit code: 2
# Output:
# Error:
System error 53 has occurred.
The network path was not found.
at org.cryptomator.frontend.webdav.mount.command.CommandResult.assertOk(CommandResult.java:98) ~[frontend-webdav-1.0.3.jar:?]
at org.cryptomator.frontend.webdav.mount.command.CommandRunner.execute(CommandRunner.java:69) ~[frontend-webdav-1.0.3.jar:?]
at org.cryptomator.frontend.webdav.mount.command.Script.execute(Script.java:42) ~[frontend-webdav-1.0.3.jar:?]
at org.cryptomator.frontend.webdav.mount.WindowsWebDavMounter.mount(WindowsWebDavMounter.java:91) ~[frontend-webdav-1.0.3.jar:1.0.3]
at org.cryptomator.frontend.webdav.mount.WindowsWebDavMounter.mount(WindowsWebDavMounter.java:71) ~[frontend-webdav-1.0.3.jar:1.0.3]
at org.cryptomator.frontend.webdav.WebDavFrontend.mount(WebDavFrontend.java:48) ~[frontend-webdav-1.0.3.jar:1.0.3]
at org.cryptomator.ui.model.Vault.activateFrontend(Vault.java:134) ~[Cryptomator-1.0.3.jar:1.0.3]
... 7 more
2016-03-31 09:33:43,813 DEBUG [Server:416] doStop org.eclipse.jetty.server.Server@3516fcf3
2016-03-31 09:33:43,814 DEBUG [Server:438] Graceful shutdown org.eclipse.jetty.server.Server@3516fcf3 by
2016-03-31 09:33:43,819 INFO [ServerConnector:310] Stopped ServerConnector@5322abd3{HTTP/1.1,[http/1.1]}{0.0.0.0:50502}
2016-03-31 09:33:43,820 INFO [ContextHandler:885] Stopped o.e.j.s.ServletContextHandler@741ab977{/,null,UNAVAILABLE}
2016-03-31 09:33:43,822 INFO [ContextHandler:885] Stopped o.e.j.s.ServletContextHandler@12ba5742{/data,null,UNAVAILABLE}
2016-03-31 09:33:43,824 DEBUG [Cryptomator:102] Shutting down
```
Any ideas?
|
https://github.com/cryptomator/cryptomator/issues/210
|
https://github.com/cryptomator/cryptomator/pull/3264
|
55ba2556516495a055e5d630fda6a27f4561b420
|
aaf8036713818d48dde470e5cd24a454d14715c4
| 2016-03-31T13:37:15Z |
java
| 2023-12-25T19:40:21Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 205 |
["pom.xml"]
|
webdav drive displays drive size information from wrong HDD
|
Using cryptomator 1.0.2 64bit on Win7 Professional.
Example:
Assume you have to drives, C: with 100GB size and 20GB free space, and D: with 500GB size and 250 GB free space. Cryptomator vault resides on drive D, but the webdav drive for this vault shows up in windows explorer with the information from drive C:, i.e. 100GB size / 20GB free space.
But great piece of software! Keep up the good work!
|
https://github.com/cryptomator/cryptomator/issues/205
|
https://github.com/cryptomator/cryptomator/pull/3340
|
99c89dbf39105aeec5b52375bb2a3e4a37d25357
|
c52780871005df230e7c8d43c83ffa0d54f5fc15
| 2016-03-25T08:26:43Z |
java
| 2024-02-19T09:35:25Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 203 |
["pom.xml"]
|
Unable to drag'n'drop .exe files outside Crypto safe
|
Hi,
When I noticed I could not open .exe files from inside an "opend safe" [(post N°78)](https://github.com/cryptomator/cryptomator/issues/78), I tried to copy the whole folder to "My Documents".
I got an error saying that the .exe file that was in the folder was not to be found. Obviously I can see it in the explorer window.
I instructed windows to ignore and, sure enough, ended up with incomplete folder.
I decided to drag'n'drop this specific file but got the same result. File missing.
Then I did a copy/paste of the same file and success.
I could understand that running apps from inside cryptomator is limited due to security reasons but I'd still want it to fully support drag'ndrop and to copy all files in one go.
I sincerely hope that you get things fixed 'cause this program looks promising..a bit like veracrypt but without waiting time
Thanks for your help
|
https://github.com/cryptomator/cryptomator/issues/203
|
https://github.com/cryptomator/cryptomator/pull/3264
|
55ba2556516495a055e5d630fda6a27f4561b420
|
aaf8036713818d48dde470e5cd24a454d14715c4
| 2016-03-24T15:23:35Z |
java
| 2023-12-25T19:40:21Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 178 |
["pom.xml"]
|
Use just _one_ random IV per file write
|
## Current situation
File contents are encrypted using CTR mode. Each file has a random key, that changes only when the _whole_ file is re-written. Each file consists of n 32 KiB chunks. Each chunk has a random IV.
Generating a new IV for each chunk causes some systems to run out of entropy (see #174).
The combination of IV and key must not be reused.
## Suggested fix
Instead we think it is sufficient to generate just one 128bit IV _per write access_ and adjust the last 64 for each chunk, so the counter will not repeat.
Example:
- Chunk 1 ends with a counter of 256
- Chunk 2 starts with a counter of 257
- All chunks of the same file write operation share the same MSBs in the IV.
- Subsequent write operations will use a new random IV.
|
https://github.com/cryptomator/cryptomator/issues/178
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2016-03-11T11:41:24Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 176 |
["pom.xml"]
|
Feature: Double-clicking unlocked vault on filesystem should reveal drive
|
When double-clicking on `.cryptomator` file and the vault is already unlocked, it should reveal the drive instead of showing it in the application.
|
https://github.com/cryptomator/cryptomator/issues/176
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2016-03-10T17:05:13Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 170 |
["pom.xml"]
|
Name and password for "localhost" requested
|
Mac OS X 10.11.3
When trying to set up a new vault I am asked after I have entered the password of the vault for name and password of "localhost" in a new window.
When I enter my normal account username (prefilled) I get an error.
See attached screenshot.
what's wrong?
Log says this:
09.03.16 17:58:22,000 kernel[0]: hfs: mounted Cryptomator on device disk3s1
09.03.16 17:58:22,216 mds[73]: (Volume.Normal:2464) volume:0x7fb3fa829000 *********\* Bootstrapped Creating a default store:1 SpotLoc:(null) SpotVerLoc:(null) occlude:0 /Volumes/Cryptomator
09.03.16 17:58:49,810 Cryptomator[4812]: assertion failed: 15D21: libxpc.dylib + 63930 [61AB4610-9304-354C-9E9B-D57198AE9866]: 0x89
09.03.16 18:03:21,602 Google Drive[784]: /dev/disk3s1 430288 404456 25832 94% 50555 3229 94% /Volumes/Cryptomator
|
https://github.com/cryptomator/cryptomator/issues/170
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2016-03-09T17:20:46Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 169 |
["pom.xml"]
|
Feature Request: Add support for WebDav and Sync/BittorrentSync to iOS-App
|
Currently the IOS-App support iCloud Drive, Dropbox, Google Drive and Onedrive only.
It would be very nice to support an open standard like WebDav that allows access to customer hosted cloud-storages like Owncloud.
Another interesting protocol is SYNC aka BittorrentSync aka BTSync (https://www.getsync.com/intl/de/), can you integrated it, please?
|
https://github.com/cryptomator/cryptomator/issues/169
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2016-03-09T09:14:22Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 151 |
["pom.xml"]
|
Vault not opening
|
Hello, so recently I had to factory reset my windows 8.1 laptop, I downloaded Cryptomator again and entered in my password for the vault. When I did that, the vault didn't open and without an error. I typed my password in many times and it still wouldn't open. I typed in an incorrect password and it said the password was incorrect, so that means my original password is correct. Is this a bug?
|
https://github.com/cryptomator/cryptomator/issues/151
|
https://github.com/cryptomator/cryptomator/pull/3081
|
4c11190be9854532b2ac86c1d8926d91351d2802
|
0cd3cf9e1c942ca92228892024330686d03ddedd
| 2016-02-27T01:40:42Z |
java
| 2023-08-23T13:51:07Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 147 |
["pom.xml"]
|
Report error, if JCE unlimited strength files are missing
|
As @thiloms suggested in #117:
> Nevertheless it would be great if cryptomator would report a error message if the strong JCE is not installed in the used JRE.
|
https://github.com/cryptomator/cryptomator/issues/147
|
https://github.com/cryptomator/cryptomator/pull/3081
|
4c11190be9854532b2ac86c1d8926d91351d2802
|
0cd3cf9e1c942ca92228892024330686d03ddedd
| 2016-02-26T10:31:32Z |
java
| 2023-08-23T13:51:07Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 139 |
["pom.xml"]
|
Can not encrypt Word documents
|
Some users have difficulties encrypting word documents. This needs further investigation on Windows.
|
https://github.com/cryptomator/cryptomator/issues/139
|
https://github.com/cryptomator/cryptomator/pull/3081
|
4c11190be9854532b2ac86c1d8926d91351d2802
|
0cd3cf9e1c942ca92228892024330686d03ddedd
| 2016-02-08T15:16:23Z |
java
| 2023-08-23T13:51:07Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 129 |
["pom.xml"]
|
High CPU usage at idle
|
Hello, I'm trying out cryptomator tonight :)
Shortly after install, I noticed that it has high-ish CPU load at idle.
At first I thought this was the throughput graph, but the usage remains when the widget is closed:
Using cryptomator 0.10.0 on a recent Linux Mint 17 install.
|
https://github.com/cryptomator/cryptomator/issues/129
|
https://github.com/cryptomator/cryptomator/pull/3081
|
4c11190be9854532b2ac86c1d8926d91351d2802
|
0cd3cf9e1c942ca92228892024330686d03ddedd
| 2016-01-04T03:43:09Z |
java
| 2023-08-23T13:51:07Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 121 |
["pom.xml"]
|
question about the master key
|
I'm using cryptomator to encrypt files in an owncloud-derived storage provider, and so far it works perfectly on windows and linux, so thanks :)
however, I noticed that opening a vault on another machine _only_ requires the password, as the master key is stored in the cloud... that means that the password is the weakest (and only ?) link in decrypting my owncloud. isn't it more secure to keep the master key out of the cloud ? wouldn't that be more secure to begin with ? by default, I don't want the provider to have or know my key.
|
https://github.com/cryptomator/cryptomator/issues/121
|
https://github.com/cryptomator/cryptomator/pull/3073
|
de78cd014d27df838d2f1c1bf1329379da5e5d9f
|
dc80d79da03b0db00750a28769e9a04e504fdff0
| 2015-12-18T10:49:14Z |
java
| 2023-08-14T08:42:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 105 |
["pom.xml"]
|
Cascade encryption
|
Implements cascade encryption like TrueCrypt:
- Encrypt plain-text with Serpent
- The result encrypt with Twofish
- The result encrypt with AES
- The result write to file
Each one must be its IV. The master key should be also cascade encrypted.
For the keys derivation, can instruct scrypt to return a lenght of AESKEYLENGTH + TWOFISHKEYLENT + SERPENTKEYLENT bytes, and then split.
|
https://github.com/cryptomator/cryptomator/issues/105
|
https://github.com/cryptomator/cryptomator/pull/3081
|
4c11190be9854532b2ac86c1d8926d91351d2802
|
0cd3cf9e1c942ca92228892024330686d03ddedd
| 2015-11-03T08:10:47Z |
java
| 2023-08-23T13:51:07Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 84 |
["pom.xml"]
|
Windows 10: some files / folders cannot be accessed
|
On windows 10, create a new vault (outside Dropbox / Google Drive / ...). Unlock / mount the vault. Start copying some files into the vault, creating folders, moving things around, copy-pasting etc.
After a while, some files / folders cannot be deleted / copied / read anymore. Sometimes these files disappear after locking and unlocking the vault. Others stay around also after locking / unlocking and can still not be accessed. The explorer error message says "Could not find this item. This is no longer located in Y:\slkfj". Actually, after locking and unlocking a number of times, eventually the file became accessible (deletable) again.
Sorry about the vague description - I couldn't find a step-by-step reproduction so far. However, I manage to reproduce it again and again within a few minutes.
|
https://github.com/cryptomator/cryptomator/issues/84
|
https://github.com/cryptomator/cryptomator/pull/3081
|
4c11190be9854532b2ac86c1d8926d91351d2802
|
0cd3cf9e1c942ca92228892024330686d03ddedd
| 2015-09-30T08:39:56Z |
java
| 2023-08-23T13:51:07Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 67 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/pullrequest.yml", ".github/workflows/win-exe.yml", "pom.xml"]
|
Windows WebDAV cache (Tfs_DAV directory) not correctly cleaned
|
Hello,
I am trying out this very interesting piece of software on window 7/64 bit. I am encryping a very large directory with a lot of files. Now I see the my C-drive is eaten up. The reason is that in the following directory very much *.tmp files are stored: C:\Windows\ServiceProfiles\LocalService\AppData\Local\Temp\TfsStore\Tfs_DAV. I think it is better that this program should automaticly removes the tmp file after the file is processed.
Best regards, Huub.
|
https://github.com/cryptomator/cryptomator/issues/67
|
https://github.com/cryptomator/cryptomator/pull/3228
|
93b09cf449b82c69b9a87f25ba112d358ac12736
|
68713ef9a71a0527b4ed6c5a707543b1028094c2
| 2015-07-22T10:06:42Z |
java
| 2023-11-28T12:28:35Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 56 |
["pom.xml"]
|
Show window when left-clicking tray icon
|
At least on Windows. This is not a standard behaviour on OS X, where showing a context menu is totally sufficient.
|
https://github.com/cryptomator/cryptomator/issues/56
|
https://github.com/cryptomator/cryptomator/pull/3295
|
509100e7aedb57e9e9358f99c0d311f47eba4e94
|
a30db34c1994e94de85f8e8fc59166add04424d3
| 2015-05-13T16:53:00Z |
java
| 2024-02-06T10:18:33Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 35 |
["pom.xml"]
|
Creating a new vault by replacing an old one doesn't work
|
When I create a new vault by replacing an old one (by choosing the same name/path), nothing happens. Neither in my file system nor in Cryptomator (it doesn't get added to the list). Not sure if intentional.
|
https://github.com/cryptomator/cryptomator/issues/35
|
https://github.com/cryptomator/cryptomator/pull/3255
|
6929760979c7eff95baeeb09ceb019364d8c510c
|
47df4213c3a702b2c691f311d7eb8f619ce0a5fa
| 2015-02-22T22:39:15Z |
java
| 2023-12-18T09:40:34Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 5 |
[".github/workflows/appimage.yml", ".github/workflows/build.yml", ".github/workflows/debian.yml", ".github/workflows/mac-dmg.yml", ".github/workflows/no-response.yml", ".github/workflows/release-check.yml", ".github/workflows/stale.yml", ".github/workflows/win-exe.yml"]
|
Different Names of Mounts in OS X
|
Each volume should get the name of the directory, its encrypted files are stored in.
|
https://github.com/cryptomator/cryptomator/issues/5
|
https://github.com/cryptomator/cryptomator/pull/3308
|
638570562bcaf2d39ae64dfe4beff137b8cfaee2
|
024c34172b92b0d3bccf72025d6c89e9c021ff40
| 2014-12-29T21:43:34Z |
java
| 2024-02-06T10:16:24Z |
closed
|
cryptomator/cryptomator
|
https://github.com/cryptomator/cryptomator
| 4 |
["pom.xml"]
|
Multiple list entries of the same folder
|
You can add the same folder multiple times to the list. Should be unique.
|
https://github.com/cryptomator/cryptomator/issues/4
|
https://github.com/cryptomator/cryptomator/pull/3359
|
ef3affece310d06def2099ba2e6ba81fa31dd990
|
dd4f87b54c9ed61492e4bd3bb7373b5a00f246ac
| 2014-12-24T14:25:27Z |
java
| 2024-03-05T17:21:09Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,669 |
["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java"]
|
[Bug] [worker] Worker's automatic user creation on linux is not fully correct
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
```
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.363 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[209] - Send task status RUNNING_EXECUTION master: 172.20.0.4:1234
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.363 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[217] - TenantCode: default check successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[220] - WorkflowInstanceExecDir: /tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5 check successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[227] - Create TaskChannel: org.apache.dolphinscheduler.plugin.task.python.PythonTaskChannel successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[232] - Download resources successfully:
ResourceContext(resourceItemMap={})
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[235] - Download upstream files: [] successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[239] - Task plugin instance: PYTHON create successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.p.t.p.PythonTask:[75] - Initialize python task params {
"localParams" : [ ],
"varPool" : [ ],
"rawScript" : "print(\"test\")",
"resourceList" : [ ]
}
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[243] - Success initialized task plugin instance successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.s.w.r.WorkerTaskExecutor:[246] - Set taskVarPool: null successfully
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.364 +0800 o.a.d.p.t.a.l.TaskInstanceLogHeader:[1259] - ***********************************************************************************************
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.a.l.TaskInstanceLogHeader:[1259] - ********************************* Execute task instance *************************************
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.a.l.TaskInstanceLogHeader:[1259] - ***********************************************************************************************
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.p.PythonTask:[165] - raw python script : print("test")
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.p.PythonTask:[131] - tenantCode :default, task dir:/tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.p.PythonTask:[134] - generate python script file:/tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5/py_5_5.py
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.p.PythonTask:[141] - #-*- encoding=utf8 -*-
print("test")
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.365 +0800 o.a.d.p.t.a.s.BaseLinuxShellInterceptorBuilder:[64] - Final Shell file is:
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.366 +0800 o.a.d.p.t.a.s.BaseLinuxShellInterceptorBuilder:[65] - ****************************** Script Content *****************************************************************
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.366 +0800 o.a.d.p.t.a.s.BaseLinuxShellInterceptorBuilder:[67] - #!/bin/bash
BASEDIR=$(cd `dirname $0`; pwd)
cd $BASEDIR
${PYTHON_LAUNCHER} /tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5/py_5_5.py
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.366 +0800 o.a.d.p.t.a.s.BaseLinuxShellInterceptorBuilder:[68] - ****************************** Script Content *****************************************************************
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.366 +0800 o.a.d.p.t.a.s.BaseShellInterceptor:[46] - Executing shell command : sudo -u default -i /tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5/5_5.sh
[WI-5][TI-5] - [INFO] 2024-03-04 21:47:37.368 +0800 o.a.d.p.t.a.AbstractCommandExecutor:[154] - process start, process id is: 14597
[WI-0][TI-5] - [INFO] 2024-03-04 21:47:37.702 +0800 o.a.d.s.w.r.l.TaskInstanceExecutionRunningEventAckListenFunction:[44] - Receive TaskInstanceExecutionRunningEventAck: TaskInstanceExecutionRunningEventAck(taskInstanceId=5, success=true)
[WI-0][TI-5] - [INFO] 2024-03-04 21:47:37.706 +0800 o.a.d.s.w.r.l.TaskInstanceExecutionInfoEventAckListenFunction:[45] - Receive TaskInstanceExecutionInfoEventAck: TaskInstanceExecutionInfoEventAck(success=true, taskInstanceId=5)
[WI-0][TI-0] - [INFO] 2024-03-04 21:47:38.368 +0800 o.a.d.p.t.a.AbstractTask:[169] - ->
sudo: unable to change directory to /home/default: No such file or directory
/tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5/5_5.sh: line 4: /tmp/dolphinscheduler/exec/process/default/12796470742656/12807950360608_3/5/5/py_5_5.py: Permission denied
```
`default check successfully` but `unable to change directory to /home/default`, though it seems this error doesn't affect the task's execution (if so, why is `sudo` present here?)
actually it's the same issue with #844, the root cause appears to be [OSUtils.java#L232](https://github.com/apache/dolphinscheduler/blame/04a6b0d2814c69b056639f65546ffd62ead22321/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java#L232) using 'useradd' without '-m' flag so `default` user created by the worker has no home dir.
By the way, the "permission denied" issue caused by #15085 should also be fixed reasonably. It's frustrating and confusing not being able to run 'hello world' out of the box. Perhaps we should improve the Docker image for the worker? Providing optional runtime via .env or some other form could be a solution.
### What you expected to happen
no error msg `unable to change directory to /home/default`
### How to reproduce
just install ds in docker compose following the tutorial and create a hello world python task
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15669
|
https://github.com/apache/dolphinscheduler/pull/15670
|
04a6b0d2814c69b056639f65546ffd62ead22321
|
82ffdbfb303671717b5b1ee7871ba4153ca3da51
| 2024-03-04T16:29:41Z |
java
| 2024-03-05T03:30:23Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,661 |
["dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/GlobalTaskDispatchWaitingQueue.java", "dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/GlobalTaskDispatchWaitingQueueLooper.java", "dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/runner/GlobalTaskDispatchWaitingQueueLooperTest.java", "pom.xml"]
|
[Bug] [Master] The task has been killed might still be dispatched
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
If the task is in dispatch waiting queue, then we kill the task it might still be dispatched.
### What you expected to happen
The killed task will not be dispatched.
### How to reproduce
1. Create a task with delay.
2. Start the workflow
3. Kill the workflow instance.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15661
|
https://github.com/apache/dolphinscheduler/pull/15662
|
040ab34bafa25c5fd17f4ca172f05f55aa2ab446
|
04a6b0d2814c69b056639f65546ffd62ead22321
| 2024-03-02T12:46:53Z |
java
| 2024-03-04T09:30:43Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,649 |
["docs/configs/docsdev.js"]
|
[Doc][remote shell] missing remote shell doc for version 3.2.1
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell code exists but doc not exists
### Documentation Links
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15649
|
https://github.com/apache/dolphinscheduler/pull/15660
|
502b49a1cb845c04c6b754e88748d2de8ef84508
|
040ab34bafa25c5fd17f4ca172f05f55aa2ab446
| 2024-02-28T08:11:24Z |
java
| 2024-03-04T08:49:22Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,626 |
["dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-hive/src/main/java/org/apache/dolphinscheduler/plugin/datasource/hive/param/HiveDataSourceProcessor.java"]
|
[Bug] [dolphinscheduler-datasource-hive] Can not connect HiveServer2 HA Zookeeper
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
https://dolphinscheduler.apache.org/zh-cn/docs/3.2.1/guide/datasource/hive
I have followed the instruction, but can not connect hive ha jdbc via zookeeper
```
[WI-0][TI-0] - [INFO] 2024-02-23 22:16:45.604 +0800 o.a.h.j.Utils:[318] - Supplied authorities: cdh-01:2181
[WI-0][TI-0] - [INFO] 2024-02-23 22:16:45.604 +0800 o.a.h.j.Utils:[437] - Resolved authority: cdh-01:2181
[WI-0][TI-0] - [WARN] 2024-02-23 22:16:45.607 +0800 o.a.h.j.HiveConnection:[200] - Failed to connect to cdh-01:2181
[WI-0][TI-0] - [WARN] 2024-02-23 22:16:45.607 +0800 n.s.c.j.SnowflakeConnectString:[136] - Connect strings must start with jdbc:snowflake://
[WI-0][TI-0] - [WARN] 2024-02-23 22:16:45.610 +0800 o.a.k.j.h.KyuubiConnection:[198] - Failed to connect to cdh-01:2181
[WI-0][TI-0] - [ERROR] 2024-02-23 22:16:45.611 +0800 o.a.d.p.d.a.d.AbstractDataSourceProcessor:[130] - Check datasource connectivity for: HIVE error
java.sql.SQLException: Could not open client transport with JDBC Uri: jdbc:hive2://cdh-01:2181/dws?serviceDiscoveryMode=zookeeper;zooKeeperNamespace=hiveserver2: null
at org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:219)
at org.apache.hive.jdbc.HiveConnection.<init>(HiveConnection.java:157)
at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:107)
at java.sql.DriverManager.getConnection(DriverManager.java:664)
at java.sql.DriverManager.getConnection(DriverManager.java:247)
at org.apache.dolphinscheduler.plugin.datasource.hive.param.HiveDataSourceProcessor.getConnection(HiveDataSourceProcessor.java:142)
at org.apache.dolphinscheduler.plugin.datasource.api.datasource.AbstractDataSourceProcessor.checkDataSourceConnectivity(AbstractDataSourceProcessor.java:127)
at org.apache.dolphinscheduler.api.service.impl.DataSourceServiceImpl.checkConnection(DataSourceServiceImpl.java:326)
at org.apache.dolphinscheduler.api.service.impl.DataSourceServiceImpl$$FastClassBySpringCGLIB$$a86d54aa.invoke(<generated>)
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy.invokeMethod(CglibAopProxy.java:386)
at org.springframework.aop.framework.CglibAopProxy.access$000(CglibAopProxy.java:85)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:704)
at org.apache.dolphinscheduler.api.service.impl.DataSourceServiceImpl$$EnhancerBySpringCGLIB$$c1257e5b.checkConnection(<generated>)
at org.apache.dolphinscheduler.api.controller.DataSourceController.connectDataSource(DataSourceController.java:215)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1070)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:963)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:909)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
at org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
at org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:91)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:516)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
at org.eclipse.jetty.server.HttpChannel$$Lambda$1333/172778919.dispatch(Unknown Source)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.transport.TTransportException: null
at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132)
at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
at org.apache.thrift.transport.TSaslTransport.receiveSaslMessage(TSaslTransport.java:178)
at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:307)
at org.apache.thrift.transport.TSaslClientTransport.open(TSaslClientTransport.java:37)
at org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:195)
... 81 common frames omitted
[WI-0][TI-0] - [ERROR] 2024-02-23 22:16:45.611 +0800 o.a.d.a.e.ApiExceptionHandler:[40] - org.apache.dolphinscheduler.api.controller.DataSourceController#connectDataSource[2 args] Meet a ServiceException: 测试数据源连接失败
```
### What you expected to happen
can connect hive ha jdbc via zookeepr
### How to reproduce
Create a hive data source and connect it using the zk method
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15626
|
https://github.com/apache/dolphinscheduler/pull/15627
|
380d108133cbd0fa2d11a69c8de11347552b6cb9
|
e498116025bee44bbf37ed1f24fc430b9c863366
| 2024-02-23T14:18:11Z |
java
| 2024-02-26T06:15:32Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,623 |
["dolphinscheduler-ui/src/views/projects/workflow/definition/use-table.ts"]
|
[Bug] [dolphinscheduler-ui] UI timed scheduler Improvement
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
https://github.com/apache/dolphinscheduler/issues/15449
https://github.com/apache/dolphinscheduler/assets/26395835/6251f961-b426-451f-a6d4-a7207aa771db
### What you expected to happen
在工作流定义中，上线一个已经存在定时配置的任务时，执行update逻辑。
In the workflow definition, the update logic is executed when a task already has a scheduled configuration.
### How to reproduce
在工作流定义中，上线一个已经存在定时配置的任务时，会错误的执行create逻辑。
In the workflow definition, the create logic will be executed incorrectly when a task already has a scheduled configuration.
### Anything else
pass
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15623
|
https://github.com/apache/dolphinscheduler/pull/15624
|
e3bd26322fcb75f620c5733c6f009823fb74dc3a
|
e9843002538dec9a21f1ef0383136fc699ff197b
| 2024-02-23T11:44:00Z |
java
| 2024-03-06T02:02:16Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,616 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/AbstractParameters.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParameters.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/test/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParametersTest.java"]
|
[Bug] [Worker] Task out param may loss
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Task param may loss due to the task exist out log but not match out param key.
### What you expected to happen
The out param cannot transport successfully.
### How to reproduce
1. Create a Shell echo '${setValue(a=111)}', outparam is b=222
2. Execute the shell find the shell cannot transport out param.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15616
|
https://github.com/apache/dolphinscheduler/pull/15617
|
2b4c1e06b67977dfed87fec0a528a1f9b75308d1
|
24ff70dc88dd56112100bb4c8ebad3cfd0da2e18
| 2024-02-22T11:57:35Z |
java
| 2024-02-23T03:11:06Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,612 |
["dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java"]
|
[Bug] [Master] Recovery paused workflowInstance may generate failover taskInstance
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When we pause a workflowInstance and recovery it, then will generate failover taskInstance.
This is caused by we try to takeover the paused taskInstance but takeover failed.
<img width="1627" alt="image" src="https://github.com/apache/dolphinscheduler/assets/22415594/3aa4f49e-378f-4fc7-88cb-9b09defc6f8e">
### What you expected to happen
xx
### How to reproduce
1. Run a workflow
2. Pause it
3. Recovery the workflow instance
4. See the task instance status.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15612
|
https://github.com/apache/dolphinscheduler/pull/15611
|
5213290262117d78dcd8936dd28eec2002a3e538
|
2b4c1e06b67977dfed87fec0a528a1f9b75308d1
| 2024-02-22T07:04:18Z |
java
| 2024-02-22T07:57:08Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,606 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java"]
|
[Bug] Version 3.2.1 [Instance list paging is incorrect, the monitored disk capacity is displayed as 0]
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
刚升级到3.2.1，发现实例列表分页失败，还有监控的磁盘容量显示错误 全是0
### What you expected to happen
解决实例列表无法分页问题
### How to reproduce
如上图，3.2.1版本
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15606
|
https://github.com/apache/dolphinscheduler/pull/15619
|
24ff70dc88dd56112100bb4c8ebad3cfd0da2e18
|
eb2a75b3b798b70e697505b42500e0aacdd45864
| 2024-02-21T05:46:37Z |
java
| 2024-02-23T05:57:54Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,575 |
["dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ProcessInstanceServiceTest.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceDao.java", "dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.xml", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapperTest.java", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapperTest.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java"]
|
[Bug] [Master] Recover then the workflow instance will not restart task instance
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When we kill a workflow instance which contains a failed task instance and recover it.
Then it might go into success, but the workflow instance contains failed task instance.
### What you expected to happen
The workflow instance status is correct with task instance.
### How to reproduce
1. Start a workflow instance which will contains failed task instance and running tasks instance.
2. Kill it and recovery
3. The workflow instance will go into success but it contains failed task instance.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15575
|
https://github.com/apache/dolphinscheduler/pull/15574
|
91d56f48601279eeb7de1a057e5c4425f86f2198
|
43a06525a29e01f6769aa0057512884d7441b438
| 2024-02-05T15:14:23Z |
java
| 2024-02-06T02:09:30Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,573 |
["dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java"]
|
[Bug] [Master] Master failover will not handle ready_stop and ready_pause workflow instance correctly.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When master failover, if the workflow instance belong to the failover master is ready_stop or ready_pause, then the task instance will not be killed and the workflow instance will go into finished.
This is caused we didn't handle the ready state in failover.
### What you expected to happen
The workflow instance state is correct with task instance state.
### How to reproduce
1. Kill master
2. Stop workflow instance
3. Restart master.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15573
|
https://github.com/apache/dolphinscheduler/pull/15572
|
73a5a77db249cbfc69e564557bb067e6febda6d9
|
1b32e28cc821daf940c264fecec23b2225446a67
| 2024-02-05T14:54:14Z |
java
| 2024-02-06T07:25:50Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,533 |
["docs/docs/en/guide/start/docker.md", "docs/docs/zh/guide/start/docker.md"]
|
[Doc][Docker] fix typo on start with docker
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
change database in `SPRING_DATASOURCE_URL` into dolphinscheduler
### Documentation Links
https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/guide/start/docker.md?plain=1
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15533
|
https://github.com/apache/dolphinscheduler/pull/15534
|
89742332a8c19ee8d52a2dc786b460f4fc96ee62
|
1b42d45fcdd22ccac7692fac4a64d096736f5e7c
| 2024-01-30T00:57:54Z |
java
| 2024-02-02T06:17:11Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,530 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParameters.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpTask.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/test/java/org/apache/dolphinscheduler/plugin/task/http/HttpTaskTest.java", "dolphinscheduler-ui/src/locales/en_US/project.ts", "dolphinscheduler-ui/src/locales/zh_CN/project.ts", "dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-http.ts", "dolphinscheduler-ui/src/views/projects/task/components/node/format-data.ts", "dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-http.ts", "dolphinscheduler-ui/src/views/projects/task/components/node/types.ts"]
|
[Improvement][HTTP] support customization of the JSON format in http body
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The current HTTP task only supports setting the HTTP body through `http_parameters`, and the body only supports JSON format where the value of the JSON is limited to strings. For example:
```json
{
"key1": "value1",
"key2": "value2"
}
```
Allowing customization of the JSON format would further enhance the flexibility of HTTP tasks. For instance, supporting the following format:
```json
{
"key1": "value1",
"key2": {
"int": 123,
"boolean": true,
"array": [1, 2, 3]
}
}
```
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15530
|
https://github.com/apache/dolphinscheduler/pull/15531
|
86ef9666c4caca83b703b742e07e5d371f3f4835
|
3640a2834848765f796ed1b6ba5e832657069332
| 2024-01-29T12:04:41Z |
java
| 2024-01-31T03:02:48Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,524 |
[".github/workflows/backend.yml", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AuditLogMapperTest.java"]
|
[Bug] [CI] 3.1.8 download failed
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The link of https://dlcdn.apache.org/dolphinscheduler/3.1.8/apache-dolphinscheduler-3.1.8-bin.tar.gz is 404.
<img width="1110" alt="image" src="https://github.com/apache/dolphinscheduler/assets/22415594/abf6b557-e957-4f12-8cfa-f5dc1808844e">
<img width="1088" alt="image" src="https://github.com/apache/dolphinscheduler/assets/22415594/da219928-55ab-462b-839a-b6ee72e2b3db">
### What you expected to happen
xx
### How to reproduce
xx
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15524
|
https://github.com/apache/dolphinscheduler/pull/15526
|
431414729fc9a75ba04a6dc01a196f4dd3660557
|
419cb49311d3e5aa7a04544efe46359f3802afba
| 2024-01-25T16:10:36Z |
java
| 2024-01-26T07:07:05Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,500 |
["docs/docs/en/guide/task/flink.md", "docs/docs/en/guide/task/spark.md", "docs/docs/zh/guide/task/flink.md", "docs/docs/zh/guide/task/spark.md"]
|
[Doc][Task] Update cli opts of spark and flink
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Update cli opts of spark and flink
### Documentation Links
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15500
|
https://github.com/apache/dolphinscheduler/pull/15501
|
603dfa2e4b38215afec05444789f09328507d48d
|
e4de06b5af1c42299a72988f356b8f611e8cf431
| 2024-01-17T05:40:53Z |
java
| 2024-01-17T06:22:27Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,491 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/K8sNamespaceService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/K8SNamespaceServiceImpl.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/K8SNamespaceServiceTest.java"]
|
[Bug] [dolphinscheduler-api-->K8sNamespaceController-->createK8sNamespace] create namespace, if not exist on k8s,will don't create
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
k8s操作报错[namespace dev_now does not exist in k8s cluster, please create namespace in k8s cluster first].
method createK8sNamespace notes： create namespace,if not exist on k8s,will create,if exist only register in db，but this method **don't** create on k8s when not exist on k8s.
### What you expected to happen
create namespace,if not exist on k8s,**will create on k8s**,if exist only register in db
### How to reproduce
ui create namespace dev-xx when not exist on k8s
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15491
|
https://github.com/apache/dolphinscheduler/pull/15546
|
25810a81dc528feedd81e44f8f57469286c0e8c7
|
2f66a667ba6bed20003cfb17af3f347166e678c1
| 2024-01-16T06:49:14Z |
java
| 2024-02-01T02:39:54Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,485 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskInstanceServiceImpl.java"]
|
[Bug] [API] NullPointException when deleting a workflow instance
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When I delete the workflow instance, I get a NullPointerException.
```
[ERROR] 2024-01-15 11:49:12.978 +0800 o.a.d.a.e.ApiExceptionHandler:[47] - Meet en unknown exception:
java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "args[i]" is null
at org.apache.dolphinscheduler.extract.base.StandardRpcRequest.of(StandardRpcRequest.java:43)
at org.apache.dolphinscheduler.extract.base.client.SyncClientMethodInvoker.invoke(SyncClientMethodInvoker.java:42)
at org.apache.dolphinscheduler.extract.base.client.ClientInvocationHandler.invoke(ClientInvocationHandler.java:55)
at jdk.proxy2/jdk.proxy2.$Proxy849.removeTaskInstanceLog(Unknown Source)
at org.apache.dolphinscheduler.api.service.impl.TaskInstanceServiceImpl.deleteByWorkflowInstanceId(TaskInstanceServiceImpl.java:384)
at org.apache.dolphinscheduler.api.service.impl.TaskInstanceServiceImpl$$FastClassBySpringCGLIB$$a1a6235.invoke(<generated>)
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy.invokeMethod(CglibAopProxy.java:386)
at org.springframework.aop.framework.CglibAopProxy.access$000(CglibAopProxy.java:85)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:704)
at org.apache.dolphinscheduler.api.service.impl.TaskInstanceServiceImpl$$EnhancerBySpringCGLIB$$86a5ad28.deleteByWorkflowInstanceId(<generated>)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
at jdk.proxy2/jdk.proxy2.$Proxy792.deleteByWorkflowInstanceId(Unknown Source)
at org.apache.dolphinscheduler.api.service.impl.ProcessInstanceServiceImpl.deleteProcessInstanceById(ProcessInstanceServiceImpl.java:1131)
at org.apache.dolphinscheduler.api.service.impl.ProcessInstanceServiceImpl.deleteProcessInstanceById(ProcessInstanceServiceImpl.java:886)
at org.apache.dolphinscheduler.api.service.impl.ProcessInstanceServiceImpl$$FastClassBySpringCGLIB$$4474b417.invoke(<generated>)
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:793)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123)
at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:388)
at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:708)
at org.apache.dolphinscheduler.api.service.impl.ProcessInstanceServiceImpl$$EnhancerBySpringCGLIB$$37de00e.deleteProcessInstanceById(<generated>)
at org.apache.dolphinscheduler.api.controller.ProcessInstanceController.deleteProcessInstanceById(ProcessInstanceController.java:261)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1070)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:963)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
at org.springframework.web.servlet.FrameworkServlet.doDelete(FrameworkServlet.java:931)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:713)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
at org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
at org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:91)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:516)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
at java.base/java.lang.Thread.run(Thread.java:833)
```
When I debug, I find that the cause of the error is that the instance state is kill and the log path is null when deleting the task instance：
Therefore, before deleting the task instance log, we need to check that the log path is not null.
### What you expected to happen
If the log path is null, don't need to delete task instance logs.
### How to reproduce
Start a process instance and terminate it quickly.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15485
|
https://github.com/apache/dolphinscheduler/pull/15488
|
c7a11ce6ed8b606671b4f1fa06b522a72aed50d4
|
e1fcd4e485531677fbbe203e107873e00b8c63c6
| 2024-01-15T05:05:44Z |
java
| 2024-01-17T14:03:33Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,483 |
["docs/docs/en/guide/installation/kubernetes.md", "docs/docs/zh/guide/installation/kubernetes.md"]
|
[Doc][K8S] Add DS K8S Operator into `k8s deployment character`
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
maybe we can add k8s operator into character 'k8s deployment'.
I thought helm is the only way to deploy ds before I knew https://github.com/apache/dolphinscheduler-operator
### Documentation Links
https://dolphinscheduler.apache.org/zh-cn/docs/3.2.0/guide/installation/kubernetes
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15483
|
https://github.com/apache/dolphinscheduler/pull/15516
|
95ae0036f6c0f129af20e8a0423e7085fc8993f2
|
8abb5e55b7f3ad12d4c33163927471bcbeab6c5d
| 2024-01-14T08:52:21Z |
java
| 2024-01-24T03:10:58Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,480 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtils.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/test/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtilsTest.java"]
|
[Bug] [Task Api] The MACPATTERN in ProcessUtils does not cover all cases on MacOS and ProcessUtilsTest failed on MacOS
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
**org.apache.dolphinscheduler.plugin.task.api.utils.ProcessUtils**
------
The is the `MACPATTERN` in `ProcessUtils`:
```
private static final Pattern MACPATTERN = Pattern.compile("-[+|-]-\\s(\\d+)");
```
and the `getPidsStr` method is:
```
public static String getPidsStr(int processId) throws Exception {
StringBuilder sb = new StringBuilder();
Matcher mat = null;
// pstree pid get sub pids
if (SystemUtils.IS_OS_MAC) {
String pids = OSUtils.exeCmd(String.format("%s -sp %d", TaskConstants.PSTREE, processId));
if (StringUtils.isNotEmpty(pids)) {
mat = MACPATTERN.matcher(pids);
}
} else if (SystemUtils.IS_OS_LINUX) {
String pids = OSUtils.exeCmd(String.format("%s -p %d", TaskConstants.PSTREE, processId));
if (StringUtils.isNotEmpty(pids)) {
mat = LINUXPATTERN.matcher(pids);
}
} else {
String pids = OSUtils.exeCmd(String.format("%s -p %d", TaskConstants.PSTREE, processId));
if (StringUtils.isNotEmpty(pids)) {
mat = WINDOWSPATTERN.matcher(pids);
}
}
if (null != mat) {
while (mat.find()) {
sb.append(mat.group(1)).append(" ");
}
}
return sb.toString().trim();
}
```
when I executed `pstree -sp` in MacOS, this was all the case:
`pstree -sp 04619`
```
-+= 04619 xxxxxx /Applications/IntelliJ IDEA.app/Contents/MacOS/idea
|--- 04626 xxxxxx /Applications/IntelliJ IDEA.app/Contents/bin/fsnotifier
|--- 04730 xxxxxx /Users/xxxxxx/Library/Java/JavaVirtualMachines/corretto-17.0.8.1/Contents/Home/bin/java -Djava.awt.headless=true -Dmaven.defaultProjectBuilder.disableGlobalModelCache=true -D
|--- 04997 xxxxxx /Applications/IntelliJ IDEA.app/Contents/jbr/Contents/Home/bin/java -Xmx1024m -Didea.version=2023.2.5 -Dfile.encoding=UTF-8 -classpath /Applications/IntelliJ IDEA.app/Contents/lib
\--= 04769 xxxxxx /bin/zsh --login -i
```
`pstree -sp 04642`
```
-+= 04642 xxxxxx /Applications/Docker.app/Contents/MacOS/com.docker.backend
|--- 04656 xxxxxx docker serve --address unix:///Users/xxxxxx/.docker/run/docker-cli-api.sock
|--- 04658 xxxxxx com.docker.extensions -address /Users/xxxxxx/Library/Containers/com.docker.docker/Data/extension-manager.sock -watchdog
|--- 04659 xxxxxx com.docker.dev-envs -watchdog
|--- 04660 xxxxxx com.docker.build
|--- 04661 xxxxxx /Applications/Docker.app/Contents/MacOS/com.docker.virtualization --kernel /Applications/Docker.app/Contents/Resources/linuxkit/kernel --cmdline init=/init loglevel=1 root=/dev/vd
\-+- 04685 xxxxxx /Applications/Docker.app/Contents/MacOS/Docker Desktop.app/Contents/MacOS/Docker Desktop --name=dashboard
|--- 04692 xxxxxx /Applications/Docker.app/Contents/MacOS/Docker Desktop.app/Contents/Frameworks/Docker Desktop Helper (GPU).app/Contents/MacOS/Docker Desktop Helper (GPU) --type=gpu-process --us
|--- 04693 xxxxxx /Applications/Docker.app/Contents/MacOS/Docker Desktop.app/Contents/Frameworks/Docker Desktop Helper.app/Contents/MacOS/Docker Desktop Helper --type=utility --utility-sub-type=n
|--- 04696 xxxxxx /Applications/Docker.app/Contents/MacOS/Docker Desktop.app/Contents/Frameworks/Docker Desktop Helper (Renderer).app/Contents/MacOS/Docker Desktop Helper (Renderer) --type=render
|--- 04700 xxxxxx /Applications/Docker.app/Contents/MacOS/Docker Desktop.app/Contents/Frameworks/Docker Desktop Helper (Renderer).app/Contents/MacOS/Docker Desktop Helper (Renderer) --type=render
|-+- 06650 xxxxxx /Applications/Docker.app/Contents/Resources/bin/docker stats --all --no-trunc --no-stream --format {{ json .}}
| \--- 06651 xxxxxx /Applications/Docker.app/Contents/Resources/bin/com.docker.cli stats --all --no-trunc --no-stream --format {{ json .}}
\-+- 06652 xxxxxx /Applications/Docker.app/Contents/Resources/bin/docker stats --all --no-trunc --no-stream --format {{ json .}}
\--- 06653 xxxxxx /Applications/Docker.app/Contents/Resources/bin/com.docker.cli stats --all --no-trunc --no-stream --format {{ json .}}
```
The conclusion drawn from the above results is: there are a total of 4 types of output: '-+=', '--=', '-+-', and '---', but the pattern: `-[+|-]-\\s(\\d+)` only covers 2 types: '-+-' and '---'.
**org.apache.dolphinscheduler.plugin.task.api.utils.ProcessUtilsTest**
------
In `ProcessUtilsTest`, the `testGetPidsStr` only considers linux scenario:
```
String pids = "sudo(6279)---558_1497.sh(6282)---sleep(6354)";
int processId = 6279;
String exceptPidsStr = "6279 6282 6354";
String command;
MockedStatic<OSUtils> osUtilsMockedStatic = Mockito.mockStatic(OSUtils.class);
if (SystemUtils.IS_OS_MAC) {
command = String.format("%s -sp %d", TaskConstants.PSTREE, processId);
} else if (SystemUtils.IS_OS_LINUX) {
command = String.format("%s -p %d", TaskConstants.PSTREE, processId);
} else {
command = String.format("%s -p %d", TaskConstants.PSTREE, processId);
}
osUtilsMockedStatic.when(() -> OSUtils.exeCmd(command)).thenReturn(pids);
String actualPidsStr = ProcessUtils.getPidsStr(processId);
Assertions.assertEquals(exceptPidsStr, actualPidsStr);
```
If you run this test on MacOS, you get this error:
```
org.opentest4j.AssertionFailedError:
Expected :6279 6282 6354
Actual :
```
### What you expected to happen
The `MACPATTERN` in `ProcessUtils` should cover all MacOS cases and run unit tests successfully on MacOS.
### How to reproduce
Run the`getPidsStr` method in `ProcessUtils` on MacOS.
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15480
|
https://github.com/apache/dolphinscheduler/pull/15529
|
ef9ed3db55cb1647886b06c2b2c6a5cfcdccfb5c
|
4d6af516b9bbc1587318f9a305d82b461c124a30
| 2024-01-13T04:47:20Z |
java
| 2024-02-05T03:41:21Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,476 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/test/java/org/apache/dolphinscheduler/plugin/task/java/JavaTaskTest.java"]
|
[Bug] [Task] java task args erro
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
java -help It's a classpath, not a class-path
### What you expected to happen
java -help It's a classpath, not a class-path
### How to reproduce
modify task args
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15476
|
https://github.com/apache/dolphinscheduler/pull/15470
|
0f7081be10b657184d2eef316c8a2cafcf2ce343
|
bd48c991783b2e0ea0c602f6ef6c9a09c92e7b42
| 2024-01-12T06:38:33Z |
java
| 2024-01-12T06:39:59Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,446 |
["README.md", "README_zh_CN.md"]
|
[Doc][ReadMe] Add link in dophinscheduler mail list
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
like button 'subscribe to list' https://lists.apache.org/[email protected] and other doc website
### Documentation Links
https://lists.apache.org/[email protected]
https://flink.apache.org/what-is-flink/community/
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15446
|
https://github.com/apache/dolphinscheduler/pull/15447
|
dcf69cad20642ffac3418b90ce9b7ea8c8ab29f1
|
e00121b44bff273a23dd7447d6027698edf73458
| 2024-01-09T10:46:08Z |
java
| 2024-01-19T07:33:53Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,426 |
["dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/AuditLogMapper.xml", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AuditLogMapperTest.java"]
|
[Bug] [Audit log] UI query error
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When db has `PROJECT` type data, ui will throw exception
<img width="1138" alt="image" src="https://github.com/apache/dolphinscheduler/assets/20885366/b09615d2-eeae-4922-8dc4-bb398c5e4b0a">
### What you expected to happen
Shows normally
### How to reproduce
Change the code
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15426
|
https://github.com/apache/dolphinscheduler/pull/15427
|
4c31e19e110ab198dbe666718c6db151a43a0852
|
e5a512803ec6f8728fe05f4a5433231ab1d13c7e
| 2024-01-04T09:02:26Z |
java
| 2024-01-05T05:25:54Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,396 |
["dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerStopStrategy.java", "dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerWaitingStrategy.java", "dolphinscheduler-worker/src/test/java/org/apache/dolphinscheduler/server/worker/registry/WorkerConnectionStateListenerTest.java", "dolphinscheduler-worker/src/test/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistryClientTest.java", "dolphinscheduler-worker/src/test/java/org/apache/dolphinscheduler/server/worker/registry/WorkerStrategyTest.java"]
|
[Improvement][Unit Tests] Improve DolphinScheduler Worker unit tests
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
part of https://github.com/apache/dolphinscheduler/issues/10573
improve dophinscheduler-worker UT
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15396
|
https://github.com/apache/dolphinscheduler/pull/15380
|
43a06525a29e01f6769aa0057512884d7441b438
|
69676b445c6a87dbd97c8bfd5797a26600e1bef6
| 2024-01-03T07:41:23Z |
java
| 2024-02-06T02:45:53Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,389 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java"]
|
[Improvement][K8S]Optimize MDC for K8S tasks
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
```
[INFO] 2024-01-02 19:50:01.365 +0800 org.apache.dolphinscheduler.plugin.task.api.AbstractTask:[335] - [WorkflowInstance-96941][TaskInstance-102599] - [K8sJobExecutor-mem-monitor-102599] start to submit job
[INFO] 2024-01-02 19:50:01.497 +0800 org.apache.dolphinscheduler.plugin.task.api.AbstractTask:[340] - [WorkflowInstance-96941][TaskInstance-102599] - [K8sJobExecutor-mem-monitor-102599] submitted job successfully
[INFO] 2024-01-02 19:50:01.503 +0800 o.a.d.server.worker.runner.listener.TaskInstanceExecutionRunningEventAckListenFunction:[44] - [WorkflowInstance-0][TaskInstance-102599] - Receive TaskInstanceExecutionRunningEventAck: TaskInstanceExecutionRunningEventAck(taskInstanceId=102599, success=true)
[INFO] 2024-01-02 19:50:01.506 +0800 org.apache.dolphinscheduler.plugin.task.api.AbstractTask:[205] - [WorkflowInstance-0][TaskInstance-0] - event received : job:mem-monitor-102599 action:ADDED
[INFO] 2024-01-02 19:50:01.560 +0800 org.apache.dolphinscheduler.plugin.task.api.AbstractTask:[205] - [WorkflowInstance-0][TaskInstance-0] - event received : job:mem-monitor-102599 action:MODIFIED
[INFO] 2024-01-02 19:50:01.560 +0800 org.apache.dolphinscheduler.plugin.task.api.AbstractTask:[212] - [WorkflowInstance-0][TaskInstance-0] - job mem-monitor-102599 status 1
[INFO] 2024-01-02 19:50:03.864 +0800 org.apache.dolphinscheduler.plugin.task.api.AbstractTask:[265] - [WorkflowInstance-0][TaskInstance-0] - [K8S-pod-log] error: node
```
The above log, in the k8s task log, both the WorkflowInstanceID and TaskInstanceID are missing.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15389
|
https://github.com/apache/dolphinscheduler/pull/15390
|
e4de06b5af1c42299a72988f356b8f611e8cf431
|
c7a11ce6ed8b606671b4f1fa06b522a72aed50d4
| 2024-01-02T12:00:40Z |
java
| 2024-01-17T09:56:11Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,382 |
["dolphinscheduler-ui/src/locales/en_US/project.ts", "dolphinscheduler-ui/src/locales/zh_CN/project.ts", "dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx", "dolphinscheduler-ui/src/views/projects/workflow/definition/components/timing-modal.tsx", "dolphinscheduler-ui/src/views/projects/workflow/definition/components/use-form.ts"]
|
[Improvement][workFlow] adjust the sequence of alarm group and add validate
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15382
|
https://github.com/apache/dolphinscheduler/pull/15384
|
bf2cdc530065b5ef121752a12b7c57de92281711
|
fd74cf16cbc7be39b02a6bd688ea5633f9757a83
| 2023-12-29T07:16:41Z |
java
| 2024-01-02T09:36:30Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,378 |
["dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx", "dolphinscheduler-ui/src/views/projects/workflow/definition/components/timing-modal.tsx", "dolphinscheduler-ui/src/views/security/worker-group-manage/components/worker-group-modal.tsx"]
|
[Improvement][workGroup & workFlow] Add workerGroup, workflow ; dropdowns filter
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15378
|
https://github.com/apache/dolphinscheduler/pull/15379
|
1c1d4bd59297942499a8242066de1c8ae0143a58
|
c3ffb1330de88e9fa8cd0368a0d0991d076ae53c
| 2023-12-28T11:47:26Z |
java
| 2023-12-29T05:29:09Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,370 |
["dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java", "dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManagerTest.java"]
|
[Bug] [Master] When a worker offline, the master still tries to dispatch tasks to the worker and throws an exception
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When a worker offline, there is a chance that the master will continue to send tasks to this worker and throw an exception:
[ERROR] 2023-12-20 22:58:25.317 +0800 org.apache.dolphinscheduler.server.master.runner.GlobalTaskDispatchWaitingQueueLooper:[87] - [WorkflowInstance-0][TaskInstance-0] - Dispatch task failed
org.apache.dolphinscheduler.server.master.exception.TaskDispatchException: Dispatch task to 192.168.1.128:1234 failed
at org.apache.dolphinscheduler.server.master.runner.BaseTaskDispatcher.doDispatch(BaseTaskDispatcher.java:101)
at org.apache.dolphinscheduler.server.master.runner.BaseTaskDispatcher.dispatchTask(BaseTaskDispatcher.java:74)
at org.apache.dolphinscheduler.server.master.runner.GlobalTaskDispatchWaitingQueueLooper.run(GlobalTaskDispatchWaitingQueueLooper.java:79)
Caused by: org.apache.dolphinscheduler.remote.exceptions.RemotingException: connect to : Host(ip=192.168.1.128, port=1234) fail
at org.apache.dolphinscheduler.remote.NettyRemotingClient.sendSync(NettyRemotingClient.java:210)
at org.apache.dolphinscheduler.server.master.rpc.MasterRpcClient.sendSyncCommand(MasterRpcClient.java:49)
at org.apache.dolphinscheduler.server.master.runner.BaseTaskDispatcher.doDispatch(BaseTaskDispatcher.java:87)
### What you expected to happen
When the worker is offline, clear the worker node information in the master and do not attempt to send tasks to it
### How to reproduce
1. Run master-1 and worker-1 server
2. Run worker-2 server. All worker services are in the default worker group
3. kill worker-1 server
4. Running a workflow consists of a number of tasks
5. Some exceptions will be printed to the master log
in addition,
we can debug master server at `org.apache.dolphinscheduler.server.master.registry.ServerNodeManager#updateWorkerNodes()`, We can find that when a worker is offline, the master does not clear the offline worker information in `workerNodeInfo`
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15370
|
https://github.com/apache/dolphinscheduler/pull/15459
|
feb302335bc0c0519f19cf6dc730c965a1f06d35
|
431414729fc9a75ba04a6dc01a196f4dd3660557
| 2023-12-27T11:37:11Z |
java
| 2024-01-25T10:10:36Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,368 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java"]
|
[Improvement][K8S] Custom label of a K8S task can be passed to the pod
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
For [apply policies using dynamic admission control](https://kubernetes.io/docs/concepts/policy/#apply-policies-using-dynamic-admission-control), the support for passing the custom label of a K8s task to the pod will bring more convenience.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15368
|
https://github.com/apache/dolphinscheduler/pull/15369
|
d6dea4633c3f0e89f245b4ebae4c607b8cbde733
|
93ea5f64c31311ab066d2093dbecd6e2f4215c68
| 2023-12-27T01:54:38Z |
java
| 2023-12-28T05:49:29Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,349 |
["dolphinscheduler-ui/src/locales/en_US/project.ts", "dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-resources.ts"]
|
[Bug] [Workflow Definition] [UI] Non-existent resource front ends cannot be culled
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
After a resource is deleted or its name is changed, the resource referenced by the current task node cannot be displayed or deleted. As a result, a message indicating that the resource does not exist is displayed during task running
### What you expected to happen
It should be possible to remove non-existent resource options
### How to reproduce
Select the resource, save the workflow, and go to the resource center to change the reference resource name
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15349
|
https://github.com/apache/dolphinscheduler/pull/15350
|
4e069991c738fba17860e129a7d7a10fac76eae3
|
c849501f3bed35024bca008477b31e1ad76ce8ff
| 2023-12-21T10:21:05Z |
java
| 2023-12-26T03:07:43Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,347 |
["dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/pom.xml", "dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/AbstractDataSourceProcessor.java", "dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-trino/src/test/java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessorTest.java"]
|
[Bug] [datasource] Trino:datasource other params illegal
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When I try to add a new trino data source,I get a error
```log
[INFO] 2023-12-20 18:49:04.362 +0800 org.apache.dolphinscheduler.api.aspect.AccessLogAspect:[107] - REQUEST TRACE_ID:11985932131264, LOGIN_USER:admin, URI:/dolphinscheduler/datasources/connect, METHOD:POST, HANDLER:org.apache.dolphinscheduler.api.controller.DataSourceController.connectDataSource, ARGS:{jsonStr={"type":"TRINO","label":"TRINO","name":"Trino评估","note":"","host":"**.**.**.**","port":8443,"principal":"","javaSecurityKrb5Conf":"","loginUserKeytabUsername":"","loginUserKeytabPath":"","mode":"","userName":"test","password":"******","database":"dwh","connectType":"","other":{"SSL":"true","SSLKeyStorePassword":"******","SSLKeyStorePath":"/home/dolphinscheduler/trino.jks"},"endpoint":"","MSIClientId":"","dbUser":"","datawarehouse":""}}
[ERROR] 2023-12-20 18:49:04.363 +0800 org.apache.dolphinscheduler.api.exceptions.ApiExceptionHandler:[52] - 建立数据源连接失败
java.lang.IllegalArgumentException: datasource other params illegal
at org.apache.dolphinscheduler.plugin.datasource.api.datasource.AbstractDataSourceProcessor.checkOther(AbstractDataSourceProcessor.java:100)
at org.apache.dolphinscheduler.plugin.datasource.api.datasource.AbstractDataSourceProcessor.checkDatasourceParam(AbstractDataSourceProcessor.java:61)
at org.apache.dolphinscheduler.plugin.datasource.api.utils.DataSourceUtils.checkDatasourceParam(DataSourceUtils.java:46)
at org.apache.dolphinscheduler.api.controller.DataSourceController.connectDataSource(DataSourceController.java:221)
at org.apache.dolphinscheduler.api.controller.DataSourceController$$FastClassBySpringCGLIB$$835fdd04.invoke(<generated>)
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:793)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:89)
at org.apache.dolphinscheduler.api.aspect.AccessLogAspect.doAround(AccessLogAspect.java:119)
at sun.reflect.GeneratedMethodAccessor284.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:634)
at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:624)
at org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:72)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:708)
```
As I know when you try to connect to a Trino with SSL, the jdbc string must link
```URL
jdbc:trino://IP:PORT?&SSL=true&SSLKeyStorePassword=password&SSLKeyStorePath=<Path to jks file location>
```
But In dolphinscheduler I can not config jdbc sting then I had to add a jdbc connect parameters
```json
{"SSL":"true","SSLKeyStorePassword":"password","SSLKeyStorePath":"myJKSfilePath"}
```
Then I get the error in API server log
### What you expected to happen
As I know when you try to connect to a Trino with SSL, the jdbc string must link
```URL
jdbc:trino://IP:PORT?&SSL=true&SSLKeyStorePassword=password&SSLKeyStorePath=<Path to jks file location>
```
But In dolphinscheduler I can not config jdbc sting then I had to add a jdbc connect parameters
```json
{"SSL":"true","SSLKeyStorePassword":"password","SSLKeyStorePath":"myJKSfilePath"}
```
Then I get the error in API server log.
If you just config like
```json
{"SSL":"true"}
```
the data source can be configed but will not work,you will see
```log
Caused by: java.sql.SQLException: Error executing query: javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
```
### How to reproduce
Just config a Trino data source use jdbc connect parameters
```json
{"SSL":"true","SSLKeyStorePassword":"password","SSLKeyStorePath":"myJKSfilePath"}
```
you will see add data source fail
### Anything else
Now I update the database table dolphinscheduler
```sql
update dolphinscheduler.t_ds_datasource set connection_params='{"user":"test","password":"*****","address":"jdbc:trino://**.**.**.**:8443","database":"dwh","jdbcUrl":"jdbc:trino://**.**.**.**:8443/dwh?&SSL=true&SSLKeyStorePassword=*****&SSLKeyStorePath=/home/dolphinscheduler/trino.jks","driverClassName":"io.trino.jdbc.TrinoDriver","validationQuery":"select 1"}' where id=12
```
to make the trino work.
But I don't want to update database again, I hope all config can be done in Web UI.
### Version
3.2.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15347
|
https://github.com/apache/dolphinscheduler/pull/15351
|
5b6b0ceb31aab5ddb79ae4b2551d104acc6d9f00
|
b73194bd35cad30748cf4f86cd65ba3cef5c2f72
| 2023-12-20T14:44:54Z |
java
| 2023-12-25T02:00:07Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,345 |
["README.md", "README_zh_CN.md", "dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/TaskResultEventHandler.java"]
|
[Bug][Master] send ACK event timeout
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
In the cluster, a large number of workflows are executed using a serial waiting strategy. It was found that some tasks have been completed, but the workflow has not ended. Checking the logs, the following logs were found:
At `17:12:43.517`, the master sent the execution result ACK of task `204531` to the worker, but the worker responded with a timeout.
```
[WARN] 2023-12-07 17:12:43.517 +0800 org.apache.dolphinscheduler.extract.base.future.ResponseFuture:[78] - [WorkflowInstance-184914][TaskInstance-204531] - Wait response in 3000/ms timeout, request id 83365
[ERROR] 2023-12-07 17:12:43.517 +0800 org.apache.dolphinscheduler.server.master.processor.queue.TaskExecuteRunnable:[64] - [WorkflowInstance-184914][TaskInstance-204531] - Handle task event error, this event will be removed, event: TaskEvent(taskInstanceId=204531, workerAddress=dolphinscheduler-worker-0.dolphinscheduler-worker-headless:1234, state=TaskExecutionStatus{code=7, desc='success'}, startTime=Thu Dec 07 17:11:47 CST 2023, endTime=Thu Dec 07 17:12:39 CST 2023, executePath=/tmp/dolphinscheduler/exec/process/default/10579449480160/11310276585441_19/184914/204531, logPath=/opt/dolphinscheduler/logs/20231207/11310276585441/19/184914/204531.log, processId=0, appIds=null, event=RESULT, varPool=[], cacheTaskInstanceId=0, processInstanceId=184914)
org.apache.dolphinscheduler.server.master.event.TaskEventHandleError: Handle task result event error, save taskInstance to db error
at org.apache.dolphinscheduler.server.master.event.TaskResultEventHandler.handleTaskEvent(TaskResultEventHandler.java:105)
at org.apache.dolphinscheduler.server.master.processor.queue.TaskExecuteRunnable.run(TaskExecuteRunnable.java:56)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.reflect.UndeclaredThrowableException: null
at com.sun.proxy.$Proxy246.handleTaskInstanceExecutionFinishEventAck(Unknown Source)
at org.apache.dolphinscheduler.server.master.event.TaskResultEventHandler.sendAckToWorker(TaskResultEventHandler.java:121)
at org.apache.dolphinscheduler.server.master.event.TaskResultEventHandler.handleTaskEvent(TaskResultEventHandler.java:102)
... 6 common frames omitted
Caused by: org.apache.dolphinscheduler.extract.base.exception.RemotingTimeoutException: wait response on the channel Host(ip=dolphinscheduler-worker-0.dolphinscheduler-worker-headless, port=1234) timeout 3000
at org.apache.dolphinscheduler.extract.base.NettyRemotingClient.sendSync(NettyRemotingClient.java:215)
at org.apache.dolphinscheduler.extract.base.client.SyncClientMethodInvoker.invoke(SyncClientMethodInvoker.java:46)
at org.apache.dolphinscheduler.extract.base.client.ClientInvocationHandler.invoke(ClientInvocationHandler.java:55)
... 9 common frames omitted
```
At `17:13:02.140`, the following log was found on the worker, indicating that the worker had received the ACK of task `204531`, but there was a delay in processing. The worker system load was relatively high at the time.
```
[INFO] 2023-12-07 17:13:02.140 +0800 o.a.d.server.worker.runner.listener.TaskInstanceExecutionFinishEventAckListenFunction:[44] - [WorkflowInstance-0][TaskInstance-204531] - Receive TaskInstanceExecutionFinishEventAck: TaskInstanceExecutionFinishEventAck(taskInstanceId=204531, success=true)
```
Checking the code, it was found that an exception occurred when the master sent `sendAckToWorker(taskEvent)`, causing the subsequent process to not be handled, leading to the workflow not ending. However, the worker actually received the ACK, but there was a delay in processing, so the worker will not retry sending the ACK.
https://github.com/apache/dolphinscheduler/blob/ce11674668cf26747f34c3474763c32e1ba5b6d1/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/TaskResultEventHandler.java#L90-L106
### What you expected to happen
Everything is OK.
### How to reproduce
...
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15345
|
https://github.com/apache/dolphinscheduler/pull/15346
|
ce11674668cf26747f34c3474763c32e1ba5b6d1
|
f8a44ff7192f7dc998f7568b229b48a2bf7ee769
| 2023-12-20T12:08:13Z |
java
| 2023-12-21T10:54:44Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,315 |
["dolphinscheduler-ui/src/views/projects/task/components/node/use-task.ts"]
|
[Bug] [UI] Paused in debugger when create task
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
- Paused in debugger when create task of console
<img width="811" alt="image" src="https://github.com/apache/dolphinscheduler/assets/8847400/57450833-36f2-4056-be6b-8efac43f8f83">
### What you expected to happen
open task modal
### How to reproduce
- Open the browser console
- Drag the task to the dag canvas
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15315
|
https://github.com/apache/dolphinscheduler/pull/15316
|
f921457a55fe09629d2ce23b1e0272c3ed8c9824
|
b7ffa7453768f0730ecca25fbd04478e0cc509ed
| 2023-12-14T02:25:15Z |
java
| 2023-12-21T14:32:09Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,280 |
["dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/expand/CuringParamsService.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/expand/CuringParamsServiceImpl.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java", "dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/expand/CuringParamsServiceTest.java"]
|
[Bug] [parameter] StartParams can't update local params
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When create a workflow, user can set local params in node definition, like the picture below
When start a new instanse by webUI, user can set the param value,
But according to the document, the priority of params,
> The priority of DolphinScheduler parameters from high to low is: Startup Parameter > Local Parameter > Parameter Context > Global Parameter > Project-level Parameter.
In this case, the value of *datat* should be "bbbb", but actually, the value of datat is "aaa" which seted in local param.
### What you expected to happen
according to the document, the priority of params,
> The priority of DolphinScheduler parameters from high to low is: Startup Parameter > Local Parameter > Parameter Context > Global Parameter > Project-level Parameter.
I think Startup Parameter will update local Parameter
### How to reproduce
Step1:
Create a workflow, add a shell task.
Step2:
Edit shell task, add stript:
```shell
echo ${datat}
```
and add a param "datat", default value is "aaa" and then save this workflow.
Step3:
Start this workflow, and add a startup params, **datat**, set the value to "bbb"
Step4:
Check the task log, the value of param *datat* is still 'aaa'
```
[INFO] 2023-12-05 14:20:24.185 +0800 - process start, process id is: 11226
[INFO] 2023-12-05 14:20:25.185 +0800 - ->
aaa
[INFO] 2023-12-05 14:20:25.186 +0800 - process has exited. execute
```
I check the log,
```json
"prepareParamsMap" : {
...
"datat" : {
"prop" : "datat",
"direct" : "IN",
"type" : "VARCHAR",
"value" : "aaa"
},
...
"StartParams" : {
"prop" : "StartParams",
"direct" : "IN",
"type" : "VARCHAR",
"value" : "{\"datat\":\"bbbb\"}"
}
...
}
```
### Anything else
Did I misunderstand the document and the type of Parameter ?
### Version
3.2.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15280
|
https://github.com/apache/dolphinscheduler/pull/15544
|
e5a208f363abcb31bb7e8ffee16c7a142671c667
|
01eb8f834ff4abf662b704379f1bcd019f4d2d74
| 2023-12-05T07:00:30Z |
java
| 2024-02-05T08:17:30Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,215 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UsersServiceTest.java"]
|
[Bug] [API] Users are not allowed to modify the default tenant and queue through the update API
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Users can modify the default tenant and queue through the update api. I think this should not be allowed because it cannot be modified through the UI. This should be consistent.
### What you expected to happen
Users are not allowed to modify the default tenant and queue through the update API
### How to reproduce
https://lists.apache.org/thread/89tkm3lmqlzbtm86kx3xnk8cc1smfm83
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15215
|
https://github.com/apache/dolphinscheduler/pull/15254
|
ef2e9c9b67e03b941ac3e8b6c2a77d4b1d564351
|
7bfc6dc3cfde4acc2f2bc232b8403fd776ed52f2
| 2023-11-24T02:20:58Z |
java
| 2023-12-04T02:20:34Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,172 |
["dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertChannelFactory.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertConstants.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/test/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertChannelFactoryTest.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/test/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertChannelTest.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/test/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSenderTest.java", "dolphinscheduler-ui/src/locales/en_US/security.ts", "dolphinscheduler-ui/src/locales/zh_CN/security.ts"]
|
[Improvement][Alert] Add timeout params for HTTP plugin
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Add timeout params for HTTP plugin
### Are you willing to submit a PR?
- [X] #15173
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15172
|
https://github.com/apache/dolphinscheduler/pull/15174
|
36f72056a9b692ffdc0a57acc0a20690a8b02de9
|
a158f1403f82ee0e5443cc6975287634177392cb
| 2023-11-16T09:51:41Z |
java
| 2023-11-18T14:28:29Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,159 |
["dolphinscheduler-ui/src/views/projects/workflow/instance/index.tsx"]
|
[Bug] [UI] Workflow instance delete button display error
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
* Workflow instance delete button display error
### What you expected to happen
* see above
### How to reproduce
* see above
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15159
|
https://github.com/apache/dolphinscheduler/pull/15160
|
6096c58cb7049783b8f67e790e6a5d62969a4bdf
|
b8e942208e7dedb06e5bdc6049700fc46df24097
| 2023-11-14T09:20:01Z |
java
| 2023-11-14T10:05:06Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,156 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java"]
|
[Bug] [seatunnel job ] When executing the local seatunneljob, an error message is displayed indicating that the file cannot be found
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
`将资源中心配置在本地时，对于上传到资源中的脚本文件，在执行seatunnel任务脚本，显示找不到脚本文件。因为在`dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java`文件的代码中，对ResourceName进行切分时，只切割了1个字符，代码如下
```
protected List<String> buildOptions() throws Exception {
List<String> args = new ArrayList<>();
if (BooleanUtils.isTrue(seatunnelParameters.getUseCustom())) {
args.add(CONFIG_OPTIONS);
args.add(buildCustomConfigCommand());
} else {
seatunnelParameters.getResourceList().forEach(resourceInfo -> {
args.add(CONFIG_OPTIONS);
// TODO: Need further check for refactored resource center
// TODO Currently resourceName is `/xxx.sh`, it has more `/` and needs to be optimized
args.add(resourceInfo.getResourceName().substring(1));
});
}
return args;
}
```
所以在初始化时，生成的脚本文件路径字符串前缀是`file:`，只切割掉1个字符，会导致文件路径包含`ile:` ,进而生成错误的路径字符串`ile:/tmp/dolphinscheduler`
所以实际应该切割掉5个字符。只切割掉一个字符会报如下的错误：
<img width="769" alt="Snipaste_2023-11-13_15-54-11" src="https://github.com/apache/dolphinscheduler/assets/142102731/e1f09219-ede2-4b62-83a3-62b5c4cd4636">
<img width="769" alt="Snipaste_2023-11-13_15-55-40" src="https://github.com/apache/dolphinscheduler/assets/142102731/18a1605a-812c-47d2-821b-3a3d113b2d40">
希望可以尽快处理一下，只需要在 `args.add(resourceInfo.getResourceName().substring(1));`改为`args.add(resourceInfo.getResourceName().substring(5));`
希望在下个版本中可以进行修复，谢谢！
### What you expected to happen
<img width="769" alt="Snipaste_2023-11-13_15-54-11" src="https://github.com/apache/dolphinscheduler/assets/142102731/5a554970-82ee-4598-8923-56f5d52f8fda">
<img width="769" alt="Snipaste_2023-11-13_15-55-40" src="https://github.com/apache/dolphinscheduler/assets/142102731/31f3de37-521a-4885-83d9-0800b60d6c05">
### How to reproduce
向资源中心上传seatunnel的作业文件，进行调度执行，会报错 找不到作业文件
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15156
|
https://github.com/apache/dolphinscheduler/pull/15621
|
f14749a94329e9f715f9cc4bcd2acd33d5e6dd03
|
00008515c0b2734285ed918ee5b3ec9a90659923
| 2023-11-13T08:17:58Z |
java
| 2024-02-27T07:11:11Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,152 |
["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/DaoConfiguration.java", "dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TriggerRelationMapper.xml"]
|
[Bug] [API] using docker-compose to start server. unable to run workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
unable to run workflow
<img width="1280" alt="Snipaste_2023-11-10_13-08-36" src="https://github.com/apache/dolphinscheduler/assets/49700906/991968a4-36e2-42c9-b7e7-85a7a606c0b6">
### What you expected to happen
run workflow
### How to reproduce
Using docker-compose to start server. And run workflow
### Anything else
[ERROR] 2023-11-10 12:59:53.134 +0800 org.apache.dolphinscheduler.api.exceptions.ApiExceptionHandler:[52] - 运行工作流实例错误
org.springframework.jdbc.BadSqlGrammarException:
### Error updating database. Cause: org.postgresql.util.PSQLException: ERROR: syntax error at or near "DUPLICATE"
Position: 145
### The error may exist in class path resource [org/apache/dolphinscheduler/dao/mapper/TriggerRelationMapper.xml]
### The error may involve defaultParameterMap
### The error occurred while setting parameters
### SQL: INSERT INTO t_ds_trigger_relation (trigger_code, trigger_type, job_id, create_time, update_time) VALUES( ?,?,?,?,?) ON DUPLICATE KEY UPDATE update_time = ?;
### Cause: org.postgresql.util.PSQLException: ERROR: syntax error at or near "DUPLICATE"
Position: 145
; bad SQL grammar []; nested exception is org.postgresql.util.PSQLException: ERROR: syntax error at or near "DUPLICATE"
Position: 145
at org.springframework.jdbc.support.SQLErrorCodeSQLExceptionTranslator.doTranslate(SQLErrorCodeSQLExceptionTranslator.java:239)
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:70)
at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:91)
at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:441)
at com.sun.proxy.$Proxy147.insert(Unknown Source)
at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:272)
at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:59)
at com.baomidou.mybatisplus.core.override.MybatisMapperProxy$PlainMethodInvoker.invoke(MybatisMapperProxy.java:148)
at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:89)
at com.sun.proxy.$Proxy194.upsert(Unknown Source)
at org.apache.dolphinscheduler.service.process.TriggerRelationServiceImpl.saveTriggerToDb(TriggerRelationServiceImpl.java:46)
at org.apache.dolphinscheduler.api.service.impl.ExecutorServiceImpl.createCommand(ExecutorServiceImpl.java:833)
at org.apache.dolphinscheduler.api.service.impl.ExecutorServiceImpl.execProcessInstance(ExecutorServiceImpl.java:271)
at org.apache.dolphinscheduler.api.service.impl.ExecutorServiceImpl$$FastClassBySpringCGLIB$$ff5175fc.invoke(<generated>)
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:793)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123)
at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:388)
at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:763)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:708)
at org.apache.dolphinscheduler.api.service.impl.ExecutorServiceImpl$$EnhancerBySpringCGLIB$$ce080d89.execProcessInstance(<generated>)
at org.apache.dolphinscheduler.api.controller.ExecutorController.startProcessInstance(ExecutorController.java:170)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1070)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:963)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:909)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:517)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:584)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
at org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
at org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:91)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:516)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
at java.lang.Thread.run(Thread.java:750)
Caused by: org.postgresql.util.PSQLException: ERROR: syntax error at or near "DUPLICATE"
Position: 145
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2676)
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2366)
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:356)
at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:490)
at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:408)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:181)
at org.postgresql.jdbc.PgPreparedStatement.execute(PgPreparedStatement.java:170)
at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44)
at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java)
at org.apache.ibatis.executor.statement.PreparedStatementHandler.update(PreparedStatementHandler.java:47)
at org.apache.ibatis.executor.statement.RoutingStatementHandler.update(RoutingStatementHandler.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.ibatis.plugin.Plugin.invoke(Plugin.java:64)
at com.sun.proxy.$Proxy826.update(Unknown Source)
at org.apache.ibatis.executor.SimpleExecutor.doUpdate(SimpleExecutor.java:50)
at org.apache.ibatis.executor.BaseExecutor.update(BaseExecutor.java:117)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.ibatis.plugin.Invocation.proceed(Invocation.java:49)
at com.baomidou.mybatisplus.extension.plugins.MybatisPlusInterceptor.intercept(MybatisPlusInterceptor.java:106)
at org.apache.ibatis.plugin.Plugin.invoke(Plugin.java:62)
at com.sun.proxy.$Proxy825.update(Unknown Source)
at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:194)
at org.apache.ibatis.session.defaults.DefaultSqlSession.insert(DefaultSqlSession.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:427)
... 93 common frames omitted
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15152
|
https://github.com/apache/dolphinscheduler/pull/15153
|
d6175f3bbf3e94b93327259b61315893157e417f
|
36f72056a9b692ffdc0a57acc0a20690a8b02de9
| 2023-11-10T06:34:41Z |
java
| 2023-11-17T13:32:22Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,142 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskInstanceServiceImpl.java"]
|
[Bug] [Task instance] Forced success, running time does not stop
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The task instance is forced successfully and the running time does not stop
### What you expected to happen
The task has ended and the running time has stopped
### How to reproduce
The task is scheduled to machine A, and then KILLs the worker directly, and another machine will be retried. At this time, the task is successfully executed, and then the previous task performs a forced success operation, but the running time does not stop.
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15142
|
https://github.com/apache/dolphinscheduler/pull/15144
|
d8e820c4b9fa70e6d7c8368a8dc17082f8b15db0
|
e5a208f363abcb31bb7e8ffee16c7a142671c667
| 2023-11-08T09:02:36Z |
java
| 2024-02-05T06:23:16Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,137 |
["dolphinscheduler-ui/src/views/resource/components/resource/edit/index.tsx", "dolphinscheduler-ui/src/views/resource/components/resource/table/table-action.tsx", "dolphinscheduler-ui/src/views/resource/components/resource/types.ts"]
|
[Improvement][Resource Center] Display brief file name in file-details page
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
hadoop集群与dolphin是分开部署的，不知道这个需要怎么配置，才能显示不是全路径的，只显示文件名称
### What you expected to happen
hadoop集群与dolphin是分开部署的，不知道这个需要怎么配置，才能显示不是全路径的，只显示文件名称
### How to reproduce
hadoop集群与dolphin是分开部署的，不知道这个需要怎么配置，才能显示不是全路径的，只显示文件名称
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15137
|
https://github.com/apache/dolphinscheduler/pull/15175
|
a158f1403f82ee0e5443cc6975287634177392cb
|
2b4edb3815035e75cd4189ebb9e81be6eee7085b
| 2023-11-08T03:28:49Z |
java
| 2023-11-19T03:50:53Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,136 |
["docs/docs/en/guide/parameter/context.md", "docs/docs/zh/guide/parameter/context.md"]
|
[Bug] [setValue] if "\n" in variable, then setValue function will work bad
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
In python task , if a variable has "\n"， then use setValue to make a Parameter for next node, the variable will not work well
node_one
```python
s = "hello \n world"
print("${setValue(message=%s)}"%s)
```
node_two
```shell
echo "${message}"
echo "hi"
```
check runtime log
node_one
```
[INFO] 2023-11-08 10:51:02.588 +0800 - process start, process id is: 10376
[INFO] 2023-11-08 10:51:03.588 +0800 - ->
world)}
[INFO] 2023-11-08 10:51:03.590 +0800 - process has exited. execute
```
node_two
```
[INFO] 2023-11-08 10:51:04.374 +0800 - process start, process id is: 30190
[INFO] 2023-11-08 10:51:05.374 +0800 - ->
hi
[INFO] 2023-11-08 10:51:05.375 +0800 - process has exited. execute
```
### What you expected to happen
In node_two, when `echo "${message}"` will show the Parameter set in pre task, in this case, want show “hello \n world"
### How to reproduce
create a workflow, the first task use python task, make a variable include "\n", then use setValue to make a Parameter
### Anything else
_No response_
### Version
3.2.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15136
|
https://github.com/apache/dolphinscheduler/pull/15145
|
b8e942208e7dedb06e5bdc6049700fc46df24097
|
3149928cdcde0007b03ab98bc42063d631e52988
| 2023-11-08T03:09:57Z |
java
| 2023-11-15T01:30:37Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,129 |
["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceDao.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/TaskInstanceDaoImpl.java", "dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.xml", "dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java"]
|
[Bug] [Dependent] The date rules of the dependent node are ambiguous.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
目前在执行过程中有两种日期时间:
1. 调度时间
2. 执行时间(或开始时间)
但目前存在一个逻辑问题，就是`dependent`节点使用`processInstance.scheduleTime`作为日期基准去匹配`startTime`。
在`3.2.0`版本中,'dependent'节点的匹配逻辑是:
1. 通过`findLastProcessInterval`找到依赖任务的`ProcessInstance`
- 搜索顺序是:
- a. 通过 `queryLastSchedulerProcessInterval` 查询 `ProcessInstance`, 条件是 `schedule_time >= #{startTime} and schedule_time <= #{endTime}`
- b. 通过 `queryLastManualProcessInterval` 查询 `ProcessInstance`, 条件是 `start_time >= #{startTime} and start_time <= #{endTime}`
https://github.com/apache/dolphinscheduler/blob/e648d6d2adede44c11711c313b5f27d4474961c5/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java#L115-L116
2. 通过`findValidTaskListByProcessId`匹配配依赖的任务
https://github.com/apache/dolphinscheduler/blob/e648d6d2adede44c11711c313b5f27d4474961c5/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java#L158-L166
在`dev`版本中,'dependent'节点的匹配逻辑是:
1. 通过`queryLastTaskInstanceIntervalByTaskCode`查找 TaskInstance, 条件是 `start_time >= #{startTime} and start_time <= #{endTime}`
https://github.com/apache/dolphinscheduler/blob/d675d32771f89a0ad09470e247469b504c6666fe/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java#L254-L255
在我所处的场景(银行, 数据仓库)中, '业务日期'或'数据日期'尤其重要, 因为对于数据加工的过程, 依赖的重点在于 '哪天的数据已经处理完成', 而不是 '数据的处理在哪天执行完成过', 数据的使用方涉及监管报送、报表还有诸多管理类系统, 对数据所处的业务时间的敏感度非常高, 所以在银行行业内的专业调度工具一般主要考虑数据的营业日期, 而不是任务的执行时间.
再者, 银行相关的业务系统非常多, 除了直接营业系统外, 还有管理类系统、第三方数据源、第三方托管系统, 截止上月末的数据很有可能会在下个月的2-3号才会产生, 比如财务系统出账调账就会延迟几天, 这种情况非常多且常规, 目前我负责的数据仓库已经有40+个上游系统或数据源, 可能延迟的至少有5个, 而因上游延迟会推后的数据加工任务就有上百个.
所以在对业务日期非常敏感且存在可能延迟的环境下, 对于<s>`3.2.0`</s>和`dev`版本有以下问题:
<s>1. 对于`3.2.0`版本, 假设'dependent'节点(today)所依赖的任务`T1`在当天还没有执行, 这时我对`T1`执行了日期为3天前的`补数`操作, 这就会触发上面`3.2.0`版本`1.b`的逻辑导致依赖意外检测成功。</s>
2. 对于`dev`版本, 假设上游的数据下发推迟了1天, 被依赖的任务`T1`在第二天才完成, 'dependent'节点包括它的下游节点永远也不会成功了, 因为永远不会有新任务的`startTime`发生在上一天。
目前我一直是维护一个本地化的版本，移除`dependent`节点对`startTime`的操作，完全依赖`scheduleTime`。
-------------
The dependency logic of the dependent node in the current implementation has two types of datetime:
1. Schedule time
2. Execution time (or start time)
However, there is a logical issue with the `dependent` node using `processInstance.scheduleTime` as the date base to match `startTime`.
In version `3.2.0`, the matching logic of the 'dependent' node is:
1. Find the dependent task's `ProcessInstance` by calling `findLastProcessInterval`.
- The search order is:
- a. Query `ProcessInstance` by calling `queryLastSchedulerProcessInterval` with the condition `schedule_time >= #{startTime} and schedule_time <= #{endTime}`.
- b. Query `ProcessInstance` by calling `queryLastManualProcessInterval` with the condition `start_time >= #{startTime} and start_time <= #{endTime}`.
Reference link: https://github.com/apache/dolphinscheduler/blob/e648d6d2adede44c11711c313b5f27d4474961c5/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java#L115-L116
2. Match the dependent tasks by calling `findValidTaskListByProcessId`.
Reference link: https://github.com/apache/dolphinscheduler/blob/e648d6d2adede44c11711c313b5f27d4474961c5/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java#L158-L166
In the `dev` version, the matching logic of the 'dependent' node is:
1. Find TaskInstance by calling `queryLastTaskInstanceIntervalByTaskCode` with the condition `start_time >= #{startTime} and start_time <= #{endTime}`.
Reference link: https://github.com/apache/dolphinscheduler/blob/d675d32771f89a0ad09470e247469b504c6666fe/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java#L254-L255
In my scenario (banking industry, data warehouse), the 'business date' or 'data date' is particularly important because for data processing, the focus of dependency lies in 'which day's data has been processed', rather than 'when was the data processed'. The users of data include regulatory reporting, reports, and many management systems, which are highly sensitive to the business time of the data. Therefore, professional scheduling tools in the banking industry mainly consider the business date of the data, rather than the execution time of tasks.
Furthermore, there are many banking-related business systems, including direct business systems, management systems, third-party data sources, and third-party hosting systems. The data at the end of last month may not be available until the 2nd or 3rd day of next month, such as financial system reconciliation that delays for several days. This situation is very common. Currently, I am responsible for more than 40 upstream systems or data sources, and there may be delays in at least 5 of them. As a result, there are hundreds of data processing tasks that may be delayed due to upstream delays.
Therefore, in an environment where the business date is highly sensitive and there may be delays, there are problems with versions <s>`3.2.0`</s> and `dev`:
<s>1. For version `3.2.0`, assuming that the dependent task `T1` that the 'dependent' node (today) depends on has not been executed on that day, if I perform a 'supplement' operation on it with a date three days ago, this will trigger the above logic in version `3.2.0`, causing an unexpected detection of dependency success.</s>
2. For the `dev` version, assuming that the upstream data is delayed by one day, and the dependent task `T1` is completed on the second day, the 'dependent' node and its downstream nodes will never succeed because there will never be a new task's `startTime` that occurs on the previous day.
Currently, I have been maintaining a localized version that removes the operation of `dependent` node on `startTime` and relies solely on `scheduleTime`.
### What you expected to happen
首先，用工作流的`scheduleTime`匹配任务的`startTime`是否合理？
其次，如果确实有不同的需求，是不是可以增加一个选项，指定依赖节点是检测`调度时间`还是`实际开始时间`？
---
Firstly, is it reasonable to match the `startTime` of a task with the `scheduleTime`?
Secondly, if there are indeed different requirements, can an option be added to specify whether the dependent node detects the `scheduleTime` or the actual `startTime`?
### How to reproduce
请参考上述内容
---
Please refer to the above content.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15129
|
https://github.com/apache/dolphinscheduler/pull/15289
|
0bb48f342973663b3466934701eea79aabcec6b3
|
0c470ffe66312085d47d5f55ad5717647aa44360
| 2023-11-07T05:29:11Z |
java
| 2023-12-08T08:18:33Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,114 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/KubernetesApplicationManager.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/AbstractParameters.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/K8sTaskParameters.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-k8s/src/main/java/org/apache/dolphinscheduler/plugin/task/k8s/K8sTask.java"]
|
[Bug] K8sTaskExecutionContext incorrectly set configYaml
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
```java
private KubernetesClient getClient(KubernetesApplicationManagerContext kubernetesApplicationManagerContext) {
K8sTaskExecutionContext k8sTaskExecutionContext =
kubernetesApplicationManagerContext.getK8sTaskExecutionContext();
k8sTaskExecutionContext
.setConfigYaml(JSONUtils.getNodeString(k8sTaskExecutionContext.getConnectionParams(), "kubeConfig"));
return cacheClientMap.computeIfAbsent(kubernetesApplicationManagerContext.getLabelValue(),
key -> new KubernetesClientBuilder()
.withConfig(Config.fromKubeconfig(k8sTaskExecutionContext.getConfigYaml())).build());
}
```
```java
k8sTaskExecutionContext
.setConfigYaml(JSONUtils.getNodeString(k8sTaskExecutionContext.getConnectionParams(), "kubeConfig"));
```
We can not directly change this. For normal task, like `spark` on k8s, `k8sTaskExecutionContext` is constructed by `TaskExecutionContextFactory`, when they call `getClient`, `connectionParams` is `null`.
### What you expected to happen
set configYaml during K8S task initialization
### How to reproduce
run `spark` task
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15114
|
https://github.com/apache/dolphinscheduler/pull/15116
|
159179ac95dd5dfc960ee0a6c341c7b67ec97941
|
ce11674668cf26747f34c3474763c32e1ba5b6d1
| 2023-11-03T07:01:36Z |
java
| 2023-12-14T13:34:42Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,072 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java"]
|
When a non-admin account uploads files in the resource center, the workflow definition Spark type task main package cannot be referenced.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When a non-admin account uploads files in the resource center, the workflow definition Spark type task main package cannot be referenced.
And no records are inserted into the metadata table, and the api-server does not report an error.
### What you expected to happen
The upload resource interface is abnormal, resulting in no records being inserted into the metadata.
### How to reproduce
Upload files and create spark type tasks
### Anything else
1
### Version
3.2.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
-------------
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
非admin账号在资源中心上传文件，工作流定义Spark类型任务主程序包无法引用
且元数据表中没有插入记录，api-server也没有报错
### What you expected to happen
上传资源接口异常，导致没有在元数据中插入记录
### How to reproduce
上传文件，并创建spark类型任务
### Anything else
1
### Version
3.2.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [ ] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15072
|
https://github.com/apache/dolphinscheduler/pull/15097
|
d5f99cc582a2ad518715c5c02d08dd5f315dd33b
|
dc503b0e00dd0b25f810e5b8dd3496a1efa1fede
| 2023-10-24T07:04:37Z |
java
| 2023-11-02T05:34:30Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,048 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/utils/SqlSplitUtils.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/test/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTaskTest.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/test/java/org/apache/dolphinscheduler/plugin/task/sql/utils/SqlSplitUtilsTest.java"]
|
[Bug] [API] sql default separator is ;\n , but save sql content to ds database, it display ;\r\n
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
I create sql task in 3.2.0 version. write two sql command in one sql task. use ;\n to separate it. but it execute fail.
i view database in ds. it save ;\r\n, not ;\n. cause not correctly separate it.
我安装了一个3.2.0版本的dolphinscheduler，创建了一个Sql任务，任务里面编写了两个SQL，然后执行执行失败。
### What you expected to happen
because ;\n is default sql separator, write more sql command in one sql task, it should separate it correctly.
因为3.2.0版本的dophinscheduler中sql任务的默认分隔符是;\n，正常来说应该能够正常执行。
### How to reproduce
1. create a sql task.
2. write two sql command in created sql task. for example
```
select current_date();
select current_date()
```
3. execute online
4. start execute
1. 创建一个Sql任务
2. 在创建的Sql任务里面添加两个sql命令，例如
```
select current_date();
select current_date();
```
3. 上线工作流
4. 执行工作流
### Anything else
跟踪代码发现，存储到数据库中的sql分隔符是;\r\n,导致代码无法正常分割多个SQL，最终sql任务执行失败。
### Version
3.2.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15048
|
https://github.com/apache/dolphinscheduler/pull/15062
|
a5284e40242eea7597e7be27d62e3133546e7073
|
99214d0fc387d5d26adde13707405d0d9104e001
| 2023-10-19T06:34:44Z |
java
| 2023-10-26T11:50:32Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,036 |
["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskDefinitionServiceImplTest.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessTaskRelationMapper.java", "dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessTaskRelationMapper.xml"]
|
[Bug] [API] Fix task definition edit doesn't work
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Problem description: All versions have the problem that task definition changes do not take effect in the workflow and vice versa. There are several points as follows:
1、Modify the task definition without a predecessor task, but it is not available in the workflow.
2、Modify the task definition with a predecessor task, but it is not available in the workflow.
3、Switch the workflow version and modify the task definition, which is not available in the workflow.
### What you expected to happen
The modifications in the task definition should also take effect in the workflow
### How to reproduce
### Anything else
_No response_
### Version
3.1.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15036
|
https://github.com/apache/dolphinscheduler/pull/14801
|
688f84452da6e99ca43c650a2eb9528233d5d579
|
ae847ba331ac6edec3c6b2e7013098bb274a5871
| 2023-10-16T09:10:48Z |
java
| 2023-10-25T12:25:02Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,026 |
["docs/docs/zh/guide/resource/file-manage.md"]
|
[Doc][file-manage] content text error
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
<img width="1438" alt="image" src="https://github.com/apache/dolphinscheduler/assets/29291456/d0b5585d-4ac0-4197-841a-c9260d45214a">
### Documentation Links
https://dolphinscheduler.apache.org/zh-cn/docs/3.1.8/guide/resource/file-manage
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15026
|
https://github.com/apache/dolphinscheduler/pull/15032
|
a13ce27671f3b2cf41de107c9445fec48ddb7be2
|
06c3663e22e348d2a880dc8940be3e39cc4aefde
| 2023-10-13T07:40:06Z |
java
| 2023-10-17T09:15:41Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,023 |
["dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/MailSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-pagerduty/src/main/java/org/apache/dolphinscheduler/plugin/alert/pagerduty/PagerDutySender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-webexteams/src/main/java/org/apache/dolphinscheduler/plugin/alert/webexteams/WebexMessage.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-webexteams/src/main/java/org/apache/dolphinscheduler/plugin/alert/webexteams/WebexTeamsSender.java"]
|
[Improvement][Alert] Alert plugin enhance fail message
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Alert plugin enhance fail message, user can see the error reason in db
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15023
|
https://github.com/apache/dolphinscheduler/pull/15024
|
33084d281f303701b345051f306fb505f78a0152
|
154e1679f9e162ef04a4c4fe6d4b07f87122c546
| 2023-10-13T06:53:06Z |
java
| 2023-10-16T05:13:45Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,017 |
["dolphinscheduler-ui/src/views/projects/workflow/definition/components/table-action.tsx", "dolphinscheduler-ui/src/views/projects/workflow/instance/components/table-action.tsx", "dolphinscheduler-ui/src/views/projects/workflow/instance/index.tsx", "dolphinscheduler-ui/src/views/resource/components/resource/table/table-action.tsx"]
|
[Improvement][workFlow] online,offline and delete Button, edge Popconfirm message does not take effect
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
online,offline and delete Button, edge Popconfirm message does not take effect
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15017
|
https://github.com/apache/dolphinscheduler/pull/15018
|
1f67e68400661fb03bb111b25294065c8096d375
|
d983e36ea4fedd391cbed78067b1861e3daf122f
| 2023-10-12T07:27:55Z |
java
| 2023-10-12T12:01:04Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,013 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/RetryUtils.java", "dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/test/java/org/apache/dolphinscheduler/plugin/task/api/utils/RetryUtilsTest.java"]
|
[Bug] [dolphinscheduler-task-api] RetryUtils:The retryInterval variable is not correctly assigned!
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The retryInterval variable is not correctly assigned
### What you expected to happen
The retryInterval variable should be assigned retryPolicy.retryInterval;
long retryInterval = retryPolicy.retryInterval;
### How to reproduce
always
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15013
|
https://github.com/apache/dolphinscheduler/pull/15014
|
8abb5e55b7f3ad12d4c33163927471bcbeab6c5d
|
d80a29c48cc5a29b0ef3888d6e2f6aa678742de3
| 2023-10-11T12:15:07Z |
java
| 2024-01-25T07:07:11Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,009 |
["dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql", "dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql", "dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql", "dolphinscheduler-dao/src/main/resources/sql/upgrade/3.2.1_schema/mysql/dolphinscheduler_ddl.sql", "dolphinscheduler-dao/src/main/resources/sql/upgrade/3.2.1_schema/postgresql/dolphinscheduler_ddl.sql"]
|
[Improvement][Parameter] Change project parameter value to text
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Change project parameter value form varchar to text
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15009
|
https://github.com/apache/dolphinscheduler/pull/15010
|
f2d146665c78fedd09027ba624aa5b5180bc7f33
|
b4cf1ccaac59093963ec943f32fd421c3730ada6
| 2023-10-11T02:20:20Z |
java
| 2023-11-30T05:56:22Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 15,007 |
["dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/rpc/LogicITaskInstanceDispatchOperationFunction.java", "dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/GlobalTaskInstanceDispatchQueueLooper.java"]
|
[Bug] [worker-server] task delay execution
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
start a task, task delay execution
### What you expected to happen
After submitting a task, it will run normally immediately
### How to reproduce
1.Start task ,Occasional appearance
2. Looking at the code, I found that the code logic did not consider this exception.
When there is an abnormality in the time zone under certain circumstances
### Anything else
_No response_
### Version
3.1.x
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/15007
|
https://github.com/apache/dolphinscheduler/pull/15012
|
23b2c8a532296caad987d296b8fcace62facce28
|
d6835533243e692f4d23b7e6923b2bf4d748ee52
| 2023-10-11T02:12:04Z |
java
| 2023-10-11T07:32:07Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 14,987 |
["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java", "dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/log/SensitiveDataConverterTest.java"]
|
[Improvement][Task] Mask password in task log
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Datasource password should better not visible in log.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/14987
|
https://github.com/apache/dolphinscheduler/pull/14988
|
629fced9efa0724463bcfe9410486d79af482a2a
|
2a6559011757267c387174b030444427b1650929
| 2023-10-07T10:41:59Z |
java
| 2023-10-08T06:54:45Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 14,971 |
["dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/HttpServiceRetryStrategy.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-dingtalk/src/main/java/org/apache/dolphinscheduler/plugin/alert/dingtalk/DingTalkSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/HttpRequestUtil.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-pagerduty/src/main/java/org/apache/dolphinscheduler/plugin/alert/pagerduty/PagerDutySender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-slack/src/main/java/org/apache/dolphinscheduler/plugin/alert/slack/SlackSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-webexteams/src/main/java/org/apache/dolphinscheduler/plugin/alert/webexteams/WebexTeamsSender.java", "dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatSender.java"]
|
[Improvement][Alert] Webex and PagerDuty Alert plugin add retry logic
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Now alert plugins just run once, and when occur network issues will not retry, so add retry logic
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/14971
|
https://github.com/apache/dolphinscheduler/pull/14972
|
4fe41ac57f3684d54a438a688a103b82dbd13d87
|
a866de1754bd81fca2c72e5beced4288700903d3
| 2023-09-27T09:18:15Z |
java
| 2023-10-11T02:20:43Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 14,965 |
["dolphinscheduler-api/src/main/resources/logback-spring.xml"]
|
[Bug] [Api] Logback file STDOUT duplicate
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Error line
### What you expected to happen
Delete error duplicate config line
### How to reproduce
.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/14965
|
https://github.com/apache/dolphinscheduler/pull/14966
|
6de1e2c1b39da7031d790efa6f44d1aef4faa14c
|
8cb765bdcb142526ff43a5dc06ce141f55d3374c
| 2023-09-26T09:56:02Z |
java
| 2023-09-26T12:19:43Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 14,963 |
["dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/shell/BaseLinuxShellInterceptorBuilder.java"]
|
[Bug] [Task] The error of using shell task to obtain Home variable in Ubuntu system
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The error of using shell task to obtain Home variable in Ubuntu system
### What you expected to happen
Get the Home variable normally
### How to reproduce
1.Configure DolphinScheduler Worker Server on ubuntu system
2.Add a new shell task, script: echo $HOME
3.Set up a tenant to execute. The print result is not the HOME directory of this tenant.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/14963
|
https://github.com/apache/dolphinscheduler/pull/14964
|
020092ed1e8328e76a27d06632337bb3e0324f5a
|
6de1e2c1b39da7031d790efa6f44d1aef4faa14c
| 2023-09-26T08:23:10Z |
java
| 2023-09-26T09:18:38Z |
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 14,951 |
["dolphinscheduler-ui/src/views/resource/components/resource/edit/index.tsx", "dolphinscheduler-ui/src/views/resource/components/resource/edit/use-edit.ts", "dolphinscheduler-ui/src/views/resource/components/resource/index.tsx", "dolphinscheduler-ui/src/views/resource/components/resource/table/use-table.ts"]
|
[Improvement][Resources Project] The details page does not return to the previous list page after returning to the list page
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
version 3.1.x 、3.2.x
**Current Problems**
When you come to the task or workflow list interface(Figure 1), click the task edit button on the specified page to enter the task details page(Figure 2). When you return, you will jump to the first page instead of the page where the original task is located(Figure 3). Very unfriendly to the user's experience.
When you come to the list interface of the resource file, click the edit button of the resource file on the specified page to enter the details page of the resource file. When you return or save, you will jump to the first page instead of the page where the original resource file is located. It is also very unfriendly to the user's experience.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/14951
|
https://github.com/apache/dolphinscheduler/pull/14954
|
d983e36ea4fedd391cbed78067b1861e3daf122f
|
166ef69066e682ee89d2b7e0ec45b0aecbdce864
| 2023-09-21T13:48:18Z |
java
| 2023-10-13T03:07:33Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.