status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,704 |
["docs/development/build-instructions-linux.md"]
|
python-dbusmock & libgnome-keyring-dev are not available on Ubuntu 20
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 13.0.0-nightly.20210210 <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:**
* Pop!_OS 20.10 <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:**
* N/A <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
When following the [build instructions for linux](https://www.electronjs.org/docs/development/build-instructions-linux#prerequisites), I expected the command to install dependencies on Ubuntu to run.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
How ever, it errors out saying that `libgnome-keyring-dev` could not be located and that `python-dbusmock` has no installation candidate (seems to be available for Ubuntu 18).
```
sudo apt-get install build-essential clang libdbus-1-dev libgtk-3-dev \
> libnotify-dev libgnome-keyring-dev \
> libasound2-dev libcap-dev libcups2-dev libxtst-dev \
> libxss1 libnss3-dev gcc-multilib g++-multilib curl \
> gperf bison python-dbusmock openjdk-8-jre
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package python-dbusmock is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Unable to locate package libgnome-keyring-dev
E: Package 'python-dbusmock' has no installation candidate
```
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Try to build electron on Ubuntu 20 with electron's build tools.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
Trying to install the python-dbusmock using pip lead to an error about syntax:
```
unning: Main process specs
Traceback (most recent call last):
File "/home/mauve/programming/electron/src/electron/script/dbus_mock.py", line 7, in <module>
from dbusmock import DBusTestCase
File "/home/mauve/.local/lib/python2.7/site-packages/dbusmock/__init__.py", line 14, in <module>
from dbusmock.mockobject import (DBusMockObject, MOCK_IFACE,
File "/home/mauve/.local/lib/python2.7/site-packages/dbusmock/mockobject.py", line 30
objects: Dict[str, 'DBusMockObject'] = {}
^
SyntaxError: invalid syntax
✗ Electron tests failed with code 1.
ERROR Error: Command failed: /home/mauve/.nvm/versions/node/v15.2.1/bin/node ./script/spec-runner.js
at checkExecSyncError (node:child_process:636:11)
at Object.execFileSync (node:child_process:654:15)
at runSpecRunner (/home/mauve/.electron_build_tools/src/e-test.js:33:16)
at Object.<anonymous> (/home/mauve/.electron_build_tools/src/e-test.js:63:3)
at Module._compile (node:internal/modules/cjs/loader:1102:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
at Module.load (node:internal/modules/cjs/loader:967:32)
at Function.Module._load (node:internal/modules/cjs/loader:807:14)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
at node:internal/main/run_main_module:17:47
```
This was solved by installing version 0.19, however it then errored out saying that `dbus` was not found.
```
Running: Main process specs
Traceback (most recent call last):
File "/home/mauve/programming/electron/src/electron/script/dbus_mock.py", line 7, in <module>
from dbusmock import DBusTestCase
File "/home/mauve/.local/lib/python2.7/site-packages/dbusmock/__init__.py", line 16, in <module>
from dbusmock.mockobject import (DBusMockObject, MOCK_IFACE,
File "/home/mauve/.local/lib/python2.7/site-packages/dbusmock/mockobject.py", line 27, in <module>
import dbus
ImportError: No module named dbus
✗ Electron tests failed with code 1.
ERROR Error: Command failed: /home/mauve/.nvm/versions/node/v15.2.1/bin/node ./script/spec-runner.js
at checkExecSyncError (node:child_process:636:11)
at Object.execFileSync (node:child_process:654:15)
at runSpecRunner (/home/mauve/.electron_build_tools/src/e-test.js:33:16)
at Object.<anonymous> (/home/mauve/.electron_build_tools/src/e-test.js:63:3)
at Module._compile (node:internal/modules/cjs/loader:1102:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
at Module.load (node:internal/modules/cjs/loader:967:32)
at Function.Module._load (node:internal/modules/cjs/loader:807:14)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
at node:internal/main/run_main_module:17:47
```
Trying to install pythin-dbus using `apt` had the same error as `python-dbusmock`, and installing from pip threw an error I don't understand.
```
configure: error: in `/tmp/pip-install-Q3evpa/dbus-python/build/temp.linux-x86_64-2.7':
configure: error:
Could not link test program to Python. Maybe the main Python library has been
installed in some non-standard library path. If so, pass it to configure,
via the LIBS environment variable.
Example: ./configure LIBS="-L/usr/non-standard-path/python/lib"
```
Have people been able to build electron on Ubuntu 20, or is it unsupported?
|
https://github.com/electron/electron/issues/27704
|
https://github.com/electron/electron/pull/32607
|
bac0a283243de5592900a243085e804926ff9f2d
|
7f517ba878cb8d0455f39f1baffc924979651d6d
| 2021-02-11T01:43:47Z |
c++
| 2022-01-26T15:29:16Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,687 |
["patches/node/.patches", "patches/node/fix_comment_out_incompatible_crypto_modules.patch", "patches/node/fix_parallel_test-crypto-ecdh-convert-key_to_use_compatible_group.patch", "script/node-disabled-tests.json"]
|
ECDH.setPrivateKey() is a noop since v12.0.0-nightly.20201014
|
```js
const crypto = require('crypto')
a = crypto.createECDH('secp521r1')
a.setPrivateKey(crypto.createHash('sha256').update('alice', 'utf8').digest())
a.getPrivateKey()
// Node.js / Electron v11 => <Buffer 2b d8 06 c9 7f 0e 00 af 1a 1f c3 32 8f a7 63 a9 26 97 23 c8 db 8f ac 4f 93 af 71 db 18 6d 6e 90>
// Electron v12.0.0-nightly.20201014+ => Uncaught Error: Failed to get ECDH private key
```
|
https://github.com/electron/electron/issues/27687
|
https://github.com/electron/electron/pull/27688
|
4ba5381e8da055dcebffb2a41d35f4e66e98f9ba
|
4ce9dd3a79e063d652b02bef4639ba4e009dfbf4
| 2021-02-09T19:12:18Z |
c++
| 2021-02-11T21:49:41Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,673 |
["patches/node/fix_comment_out_incompatible_crypto_modules.patch", "spec/node-spec.js"]
|
Electron v11 breaks crypto.createDiffieHellman with non-number generators
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* Electron v11 (11.0.0-beta.1, 11.0.0, 11.2.1 and 11.2.3 are tested and affected)
* **Operating System:**
* Personally tested on Windows 10 (1909), but possibly affects others _(a bunch of VS Code users on different OSes)_
* **Last Known Working Electron version:**
* Electron v10 (tested 10.3.2)
### Bug
Renderer process crashes when using [crypto.createDiffieHellman](https://nodejs.org/docs/latest-v12.x/api/crypto.html#crypto_crypto_creatediffiehellman_prime_primeencoding_generator_generatorencoding) with a non-number generator as argument. The exact same code works fine in the NodeJS version I tested, namely v12.18.3, the same as electron v11.2.3 uses.
Originally noticed in VS Code extensions (SchoofsKelvin/vscode-sshfs#239) after VS Code 1.53.0 switched from electron v9 to v11.2.1.
### To Reproduce
Electron fiddle: https://gist.github.com/SchoofsKelvin/90f78f8aeffa04e344bf8dbd3ade4961
Clicking a button will either show e.g. "test1 done" or crash the renderer, resulting in the page becoming fully white.
Alternatively, simply run this in the renderer process of an affected version and it should crash the renderer process:
```js
require('crypto').createDiffieHellman("abc", "\02")
```
|
https://github.com/electron/electron/issues/27673
|
https://github.com/electron/electron/pull/27674
|
87064e5b5e19b9165beff5483a1953e07245d66b
|
9063e84b7cb52943b70ac326feee16eb82c2e155
| 2021-02-08T23:01:21Z |
c++
| 2021-02-10T22:10:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,618 |
["filenames.gni", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/bluetooth/electron_bluetooth_delegate.cc", "shell/browser/bluetooth/electron_bluetooth_delegate.h", "shell/browser/electron_browser_client.cc", "shell/browser/electron_browser_client.h", "shell/browser/lib/bluetooth_chooser.cc", "shell/browser/lib/bluetooth_chooser.h", "spec-main/chromium-spec.ts"]
|
Web Bluetooth API calls crashes Electron
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x ] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x ] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v11.2.2
* **Operating System:**
* macOS 11.0.1
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 --> v10.x.y (but only on Mojave, see "Additional Information")
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
When I call `navigator.bluetooth.requestDevice({ acceptAllDevices: true})` I expect a promise to be returned, as described in the [documentation](https://developer.mozilla.org/en-US/docs/Web/API/Web_Bluetooth_API).
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
When I call `navigator.bluetooth.requestDevice({ acceptAllDevices: true})` (or any other Web Bluetooth API call) electron crashes with the following error trace from the terminal:
The log can be seen here, but nothing in it stands out to me:
[electron crash log.txt](https://github.com/electron/electron/files/5924542/electron.crash.log.txt)
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
I've added a small example for you to try out here: https://github.com/JakobOffersen/electron-bluetooth-issue
Steps:
- Clone the project: `git clone https://github.com/JakobOffersen/electron-bluetooth-issue.git`. There is only the `main` branch.
- Run `npm install`
- Run `npm start`
- Click the "Use Web Bluetooth" button
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
I've run the sample project on 2 macOS versions and I found the following:
- On MacOS Big Sur (11.0.1): Electron `beta`, `v11`, `v10` and `v9` all lead to crashes.
- MacOS Mojave (10.14.6): Electron `v9` and `v10` works as expected, but `v11` lead to crash.
|
https://github.com/electron/electron/issues/27618
|
https://github.com/electron/electron/pull/27902
|
bd940b2904dd67e12366039abb738fe3ca86f309
|
d57fd6cef0132b0260b908e48e4264a326a2ec00
| 2021-02-04T09:37:45Z |
c++
| 2021-02-26T19:10:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,601 |
["shell/browser/electron_download_manager_delegate.cc", "shell/browser/electron_download_manager_delegate.h"]
|
Download dialogs recreates the last saved folder
|
### Issue Details
* **Electron Version:**
11.0.0
* **Operating System:**
Windows 10
### Expected Behavior
When download an item using ```<a href="...filepath">``` will trigget session will-download event.
I set the download default path before opening the Save dialog as:
```
const documentsFolderPath = path.join(app.getPath('documents'), item.getFilename());
item.setSaveDialogOptions({ defaultPath: documentsFolderPath });
```
- Opens the save dialog on the specified path.
- Create a new folder on the dialog and save the file on this folder.
- File is saved.
- On windows explorer, I delete the previous saved folder.
- Try to save same or other file again.
- It opens the save dialog on the default folder. The deleted folder is not on the folder.
### Actual Behavior
- Electron recreates the last saved folder (the one was deleted on window explorer). This is not ok.
It seems the save dialog always remember the last path, and always recreates it.
### To Reproduce
Follow the expected behavior steps, and will result in the actual behavior on the last step.
This is my save dialog options before saving:
```
{
window: null,
title: '',
message: '',
buttonLabel: '',
nameFieldLabel: '',
defaultPath: 'C:\\Users\\guilherme\\Documents\\download(3).pdf',
filters: [],
showsTagField: false,
securityScopedBookmarks: false
}
```
Is it a bug, a feature, or I'm missing some setup?
|
https://github.com/electron/electron/issues/27601
|
https://github.com/electron/electron/pull/27745
|
599f398ddc4d960c6d338fae4309e2a522803061
|
b12e47b798b329ed86fcaea1a07734ec5b8b8275
| 2021-02-03T06:27:29Z |
c++
| 2021-02-18T23:27:29Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,457 |
["shell/common/node_bindings.cc", "shell/common/node_bindings.h", "shell/renderer/electron_renderer_client.cc"]
|
Renderer entirely hangs with "uncaught illegal access" when loading page with 2 iframes, nodeIntegrationInSubFrames, and node-ipc
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.2.1, also verfied on Electron 10.2.x and 9.0.0
* **Operating System:**
* verified on MacOS 10.14.6, MacOS 11.1, Debian 4.19.160-2, and Debian 5.9.15
* **Last Known Working Electron version:**
Electron 8.5.5 works.
### Expected Behavior
Page sucessfully loads and js continues running normally.
### Actual Behavior
The render window completely hangs partway through loading, is unresponsive to all input including the developer console, and can only be killed from the main process, or by killing the main process. When loading for the first time, there's no output in the developer console, but when reloading an intermittent form of the bug (by wrapping the node-ipc connectTo call in an async function with a delay) following stack trace is sometimes displayed:
. Although the error is displayed as being on line 1 of my html file, line 1 is simply `<html>`, so that's obviously not correct.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Install [this minimal example project. ](https://github.com/Patronics/example-electron-hang) by runing
```sh
$ git clone https://github.com/Patronics/example-electron-hang.git
$ npm install
$ npm start
```
Notice that when running the app, the big iframe's contents never load, and the app is unresponsive to the normal keyboard shortcuts to interact with it (Quit, open the, dev tools, etc.). Look at the source code (especially index.html) to see that the JS abruptly stops running, unlike it expected behavior. The comments describe which lines seem necessary to trigger the bug, and which are just to demonstrate the behavior.
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
I'm submitting the issue here as well as node-ipc's repository, as the issue seems to be in the interaction of the two codebases. However, the set of unique circumstances in the electron configuration needed to cause this, as well as the fact that the normal debugging tools like the developer console are rendered non-functional, would seem to indicate that the issue is primarly regarding electron, and not node-ipc. The fact that electron 8.5.5 and eariler don't have this issue would seem to confirm that conclusion.
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/27457
|
https://github.com/electron/electron/pull/27582
|
980b32fce72b95cac6a061737e1fea02bdc974fd
|
642d6fca910ed30ce086d76aac0dc17ee093aa3b
| 2021-01-24T06:32:27Z |
c++
| 2021-02-17T03:42:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,426 |
["shell/browser/net/url_pipe_loader.cc"]
|
interceptHttpProtocol introduces random data corruption
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v11.1.1
* **Operating System:**
* Linux 5.10.7 / Windows 10 (1803)
* **Last Known Working Electron version:**
* unknown
### Expected Behavior
Using `interceptHttpProtocol` should not introduce random data corruption.
### Actual Behavior
Apparently, when `interceptHttpProtocol` is used (by itself), it introduces random corruption in transfered data.
### To Reproduce
Enable `interceptHttpProtocol` with no other behavior, e.g.:
```js
protocol.interceptHttpProtocol('http', (request, callback) => {
console.log('interceptHttpProtocol:', request)
request.session = null
callback(request)
})
```
Then load a large file. I noticed this issue with JavaScript scripts, possibly other file types are affected.
Full test case can be found here:
https://github.com/lucybythec/electron-intercept-bug/blob/master/main.js
```sh
$ git clone https://github.com/lucybythec/electron-intercept-bug
$ cd electron-intercept-bug
$ npm install
$ npm start
```
In the example, the loaded page should print the MD5 of data contained in a big file.
However, very often the data corruption results in a syntax error instead.
(Check the "Console" tab in the Dev Tools).
I reproduce the problem on Windows and Linux.
Due to the random nature of the problem, it may not reproduce the first time. The application may need to be restarted several times.
### Screenshots
Example of corruption:
### Additional Information
<!-- Add any other context about the problem here. -->
Tested on different machines, so this is not a hardware defect.
|
https://github.com/electron/electron/issues/27426
|
https://github.com/electron/electron/pull/29567
|
af7181b93fb2be37b6d25f104b036e484dba9bc8
|
e8c9a814d6bafa4ce7eece0e4c9c006abe6fc365
| 2021-01-21T01:32:13Z |
c++
| 2021-06-14T01:18:52Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,378 |
["package.json", "shell/browser/native_browser_view_mac.mm"]
|
BrowserView: flickers when switching between view
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 10.1.7 and beyond (I tested on latest 11.2.0 too)
* **Operating System** macOS 10.15.7
* **Last Known Working Electron version:** 10.1.6
NOTE: tested in windows, the bug is not present.
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Switching browser view should **not flickers**.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Switching browser view **flickers**.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Load electron fiddle friendly gist here https://gist.github.com/kevinlinv/eada1e5bdd1282db338971c4c42c671e
<details>
<summary>Collapse here for the code in case gist is not loading</summary>
`index.html`
```html
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Hello World!</title>
<link rel="stylesheet" type="text/css" href="./styles.css">
</head>
<body>
<div style="display:flex">
<p style="margin:0px; padding: 5px">MyApp</p>
<button id="tab1">tab1</button>
<button id="tab2">tab2</button>
</div>
<script>
// You can also require other files to run in this process
require('./renderer.js')
</script>
</body>
</html>
```
`main.js`
```js
const {app, ipcMain, BrowserView, BrowserWindow} = require('electron')
function createWindow () {
const mainWindow = new BrowserWindow({
width: 1080,
height: 720,
webPreferences: { nodeIntegration: true }
})
const views = [
createView({ backgroundColor: '#ddd', url: 'https://www.youtube.com/watch?v=RDfjXj5EGqI' }),
createView({ backgroundColor: '#000', url: 'https://electronjs.org' }),
];
const focusView = (id) => {
const { width, height } = mainWindow.getContentBounds();
const windowContentHeight = 40;
mainWindow.setBrowserView(views[id]);
views[id].setBounds({
x: 0,
y: windowContentHeight,
width,
height: height - windowContentHeight,
});
}
ipcMain.handle('onTabClick', (_, id) => focusView(id))
focusView(0)
mainWindow.loadFile('index.html')
}
function createView({ backgroundColor, url }) {
const browserView = new BrowserView();
browserView.setBackgroundColor(backgroundColor);
browserView.setAutoResize({
width: true,
height: true,
horizontal: false,
vertical: false,
});
browserView.webContents.loadURL(url);
return browserView;
}
app.whenReady().then(createWindow)
app.on('window-all-closed', app.quit)
```
`renderer.js`
```js
const {ipcRenderer} = require('electron')
const handleClick = id => ipcRenderer.invoke('onTabClick', id)
document.getElementById('tab1').addEventListener('click', () => handleClick(0))
document.getElementById('tab2').addEventListener('click', () => handleClick(1))
```
</details>
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
The first part: the problem
The second part: expected behavior
https://user-images.githubusercontent.com/44967897/105120572-93b61280-5b26-11eb-8a18-0846939d0625.mp4
|
https://github.com/electron/electron/issues/27378
|
https://github.com/electron/electron/pull/27585
|
f69c11105ff2a0f7b8778602de5eae4f83736c9b
|
fa09183ed1326238a51e0e7f6370d466276dfc7b
| 2021-01-20T02:52:51Z |
c++
| 2021-02-08T17:14:46Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,364 |
["docs/api/context-bridge.md", "shell/renderer/api/electron_api_context_bridge.cc", "spec-main/api-context-bridge-spec.ts"]
|
Blob is empty if it is passed as a parameter via contextBridge
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 12.0.0-beta.16
* **Operating System:**
* Windows 10 (1909)
* **Last Known Working Electron version:**
* unknown
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Since blobs belong to the cloneable object types, the value should arrive in the function.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
The parameter value is empty.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
preload.js
> const {contextBridge} = require("electron");
> contextBridge.exposeInMainWorld("WebVC", {
> writeBlobToFile: (blob) => {
> console.log(blob);
> }
> });
renderer.js
> window.WebVC.writeBlobToFile(new Blob(["Hello World"]));
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
Electron fiddle: https://gist.github.com/AmarBouchibane/624d61b9208f7d67c768a9a7f3df3109
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/27364
|
https://github.com/electron/electron/pull/29247
|
d0b9a931ccf3437d8f8bb3e5cffd9fb120ed4775
|
f01e35f4eaf3e45eefaef851c61f553c0756e571
| 2021-01-19T11:16:34Z |
c++
| 2021-05-26T17:34:29Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,303 |
["shell/browser/api/electron_api_base_window.cc", "shell/browser/api/electron_api_base_window.h", "shell/common/api/electron_api_native_image.cc", "shell/common/api/electron_api_native_image.h", "spec-main/api-browser-window-spec.ts"]
|
App crashes when icon is set after updating to electron 11.2
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v11.2.0
* **Operating System:**
* macOS 10.15.7
* **Last Known Working Electron version:**
* v11.1.1
### Expected Behavior
Application should open when icon is set, if failed to load icon file I expect to get an exception and not SIGSEGV
### Actual Behavior
Application is terminated on the BrowserWindow constructor when _icon_ is supplied
### To Reproduce
* Update to electron v11.2
* Make sure to have the _icon_ property set when creating new instance of _BrowserWindow_
* In the example below I used VSCode icon as an example, I've also tried to copy the file to the project dir, it has no affect.
This happens with other icns files so the file itself is not important.
```javascript
const { app, BrowserWindow } = require('electron')
function createWindow () {
const win = new BrowserWindow({
icon: "/Applications/Visual Studio Code.app/Contents/Resources/Code.icns", // <-- comment to avoid crash, or use electron 11.1.1
/**
* Jan 13 13:44:22 Electron Helper[26232] <Error>: read failed
Jan 13 13:44:22 Electron Helper[26232] <Error>: SeatbeltExecServer: failed to read buffer length.
Failed to initialize sandbox.
/Users/idanwork/Projects/electron-icon/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron exited with signal SIGSEGV
*/
// icon: `${__dirname}/Code.icns`, // Tried to copy the icon locally, didn't help
})
win.loadURL('https://www.electronjs.org/docs/api/browser-window');
}
app.whenReady().then(createWindow)
app.on('window-all-closed', () => app.quit())
app.on('activate', () => BrowserWindow.getAllWindows().length === 0 && createWindow());
```
package json
```json
{
"name": "electron-icon",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"run": "electron ."
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"electron": "^11.2.0"
}
}
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
The example assumes you have _Visual Studio Code_ in the _Applications_ folder, you can alter it to use any other icon file.
Reverting the same code to electron v11.1.x works
Error can't be caught and the application is terminated
I've tried using other icon files and put the files in the project dir, the issue persists.
_Edited text in comment_
|
https://github.com/electron/electron/issues/27303
|
https://github.com/electron/electron/pull/27441
|
d69e0d05731a7ef474ead8b0d710c184f5e346cd
|
5a8f40ae13f5c2872bef6e6a0deee41c50acf9cf
| 2021-01-13T12:06:46Z |
c++
| 2021-01-25T01:24:10Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,283 |
["shell/browser/native_window_mac.mm"]
|
Fullscreen not working on MacOS
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 12.0.0-beta.14
* **Operating System:**
* macOS 11.0.1
* **Last Known Working Electron version:**
* 11.1.1
### Expected Behavior
The fullscreen button should be enabled and work, see this image from electron 11.1.1
### Actual Behavior
The fullscreen button is disabled and does not work, see this image from electron 12.0.0-beta.14.
### To Reproduce
Simply take any project and update to Electron 12.0.0-beta.14
|
https://github.com/electron/electron/issues/27283
|
https://github.com/electron/electron/pull/27428
|
9baca911a1d00a37a4b04415746b2b4e5525ba08
|
d69e0d05731a7ef474ead8b0d710c184f5e346cd
| 2021-01-12T16:10:48Z |
c++
| 2021-01-25T00:59:06Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,277 |
["patches/boringssl/.patches", "patches/boringssl/expose_des-ede3.patch"]
|
crypto module missing des-ede3 cipher
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.1.1 & 10.1.3
* **Operating System:**
* Windows 10
### Expected Behavior
support `des-ede3` cipher
### Actual Behavior
```js
var encrypto = require("crypto")
encrypto.getCiphers()
```
> 0: "aes-128-cbc"
1: "aes-128-cfb"
2: "aes-128-ctr"
3: "aes-128-ecb"
4: "aes-128-gcm"
5: "aes-128-ofb"
6: "aes-192-cbc"
7: "aes-192-ctr"
8: "aes-192-ecb"
9: "aes-192-gcm"
10: "aes-192-ofb"
11: "aes-256-cbc"
12: "aes-256-cfb"
13: "aes-256-ctr"
14: "aes-256-ecb"
15: "aes-256-gcm"
16: "aes-256-ofb"
17: "des-cbc"
18: "des-ecb"
19: "des-ede"
20: "des-ede-cbc"
21: "des-ede3-cbc"
22: "rc2-cbc"
23: "rc4"
|
https://github.com/electron/electron/issues/27277
|
https://github.com/electron/electron/pull/27897
|
2e091d401e1636bb91e80c9eaa09d82d15fda66e
|
6e121d22509ee0a6d5cedff00cc00d8b32f7b3fa
| 2021-01-12T01:56:16Z |
c++
| 2021-03-04T00:18:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,268 |
["shell/browser/api/electron_api_web_contents_mac.mm"]
|
[OS X] Ctrl+F2 keyboard shortcut to focus menu bar does not work (accessibility)
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [ x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [ x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success. -> I can see one that was resolved in 2016, but it seems to have regressed.
### Issue Details
* **Electron Version:** 9.0.4
* **Operating System:** Mac OS 10.15.7
* **Last Known Working Electron version:**(unknown)
### Expected Behavior
Pressing CTRL F2 should focus on the app menu bar (Apple Logo)
<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
Pressing CTRL F2 does nothing.
The only way to focus the app menu bar is to press CTRL F3 (which focuses the Dock), then press CTRL F2. I am not able to get around this in my project and it does not work in any production electron apps (e.g. VSCode/Slack etc...). Native apps do not have an issue with this.
<!-- A clear and concise description of what actually happened. -->
### To Reproduce
CTRL F2 does not focus app menu bar.
This was reported and fixed in 2016 : https://github.com/electron/electron/issues/6016 , but it seems to have regressed.
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
|
https://github.com/electron/electron/issues/27268
|
https://github.com/electron/electron/pull/27701
|
b0a6eb6a53b8364e502801a8673064b9e764ddd1
|
64eb02b671794d02dc2ed89bd67d721e587bbab9
| 2021-01-11T19:34:31Z |
c++
| 2021-02-18T01:31:53Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,264 |
["docs/api/frameless-window.md", "shell/browser/native_window_views.cc", "shell/browser/native_window_views_win.cc"]
|
Circular corners in the main window does not work correctly
|
### Issue Details
* **Electron Version:**
* [email protected]
* **Operating System:**
* Windows-10-10.0.19041-SP0
### Expected Behavior
Window with circular corners
### Actual Behavior
When the window is maximized and then minimized, the square and black borders appear.
### To Reproduce
Just put in the main.js
``trasnparent = true, frame = false
``
And with html and css create the circular corners (Below I add the code)
### Screenshots
### Additional Information
#### Main.js:
```const { app, BrowserWindow } = require('electron')
let win;
function createWindow () {
win = new BrowserWindow({
width: 800,
height: 600,
minWidth:400,
minHeight: 300,
frame: false,
transparent: true,
webPreferences: {
nodeIntegration: true
}
})
win.loadFile('index.html')
}
app.whenReady().then(createWindow)
app.on('window-all-closed', () => {
if (process.platform !== 'darwin') {
app.quit()
}
})
app.on('activate', () => {
if (BrowserWindow.getAllWindows().length === 0) {
createWindow()
}
})
```
#### index.html:
```<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<link rel="stylesheet" href="styles.css">
</head>
<body>
<div class="Body">
<div class="WindowBar">
<div class="LogoTitleBar">
<div class="LogoBar">
<img class="LogoBar"
src="https://i.pinimg.com/originals/46/0e/78/460e78cb4c61f55da3802ca5d1d68d15.jpg" alt="">
</div>
<div class="TitleBar">
My App
</div>
</div>
<div class="MenuBar">
<div class="btn btn1"></div>
<div class="btn btn2"></div>
<div class="btn btn3"></div>
</div>
</div>
<div class="content">
<!-- <img class="ImgContent" src="https://wallpaperaccess.com/full/3542858.png" alt=""> -->
</div>
</div>
</body>
</html>
```
#### styles.css:
```html,
body {
width : 100%;
height: 100vh;
margin: 0;
}
:root {
--radius_value: 15px;
--radius_btn : 15px;
}
.Body {
width : 100%;
height : 100vh;
/* 100% of the viewport height */
margin : 0px;
border-radius : var(--radius_value);
/* background : #b42424; */
/* background : #212121; */
display : flex;
flex-direction : column;
align-items : stretch;
background-image: url("https://wallpaperaccess.com/full/3542858.png");
background-size: cover;
/* background-size: 100% 100%; */
/* opacity: 0.5; */
}
.WindowBar {
display : flex;
justify-content : space-between;
align-items : center;
width : 100%;
height : 30px;
/* margin : 1px; */
border-top-right-radius : var(--radius_value);
border-top-left-radius : var(--radius_value);
/* border-radius : var(--radius_value); */
background : #313131;
-webkit-app-region : drag;
-webkit-user-select : none;
color : #fff;
opacity: 0.98;
}
.LogoTitleBar {
display : flex;
justify-content: space-between;
align-items : center;
margin-left : 10px;
}
.LogoBar {
width : var(--radius_btn);
height : var(--radius_btn);
border-radius : 50%;
/* background : #000; */
}
.TitleBar {
margin-left : 5px;
display : flex;
align-items : center;
justify-content: center;
font-family : sans-serif;
font-weight : 100;
font-size : 13px;
}
.MenuBar {
display : flex;
align-items : center;
-webkit-app-region : no-drag;
-webkit-user-select: none;
padding-right : 10px;
}
.btn {
display : flex;
justify-content: center;
align-items : center;
margin : 5px;
width : var(--radius_btn);
height : var(--radius_btn);
border-radius : 50%;
cursor : pointer;
}
.btn1 {
background: orange;
}
.btn2 {
background: green;
}
.btn3 {
background: red;
}
.content {
display : flex;
align-items : center;
justify-content : center;
border-bottom-right-radius: var(--radius_value);
border-bottom-left-radius : var(--radius_value);
overflow : hidden;
}
.ImgContent {
width : 100%;
height : 100vh;
}
```
|
https://github.com/electron/electron/issues/27264
|
https://github.com/electron/electron/pull/28207
|
82ea8ea68cabdeea9d89a24965fd886d9233181e
|
19d7a6b76168282b9d62947702eb2ca846ccd3d7
| 2021-01-11T15:15:19Z |
c++
| 2021-04-05T23:53:59Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,252 |
["patches/node/chore_prevent_warn_non_context-aware_native_modules_being_loaded.patch"]
|
v12 renderer process crash with `node-pty` native module
|
### Issue Details
* **Electron Version:**
* 12.0.0-beta.12
* **Operating System:**
* macOS 11.2 x64
* **Last Known Working Electron version:**
* 11.1.1
### To Reproduce
`require('node-pty').spawn('/bin/sh')`
### Additional Information
Tracebacks seem to vary
#### Traceback 1
```
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [72809]
Thread 0 Crashed:: CrRendererMain Dispatch queue: com.apple.main-thread
0 com.github.Electron.framework 0x0000000103c05e69 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 65961
1 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
2 com.github.Electron.framework 0x0000000103bfaf1a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 21082
3 com.github.Electron.framework 0x0000000103cecebf v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1012223
4 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
5 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
6 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
7 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
8 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
9 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
10 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
11 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
12 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
13 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
14 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
15 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
16 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
17 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
18 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
19 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
20 com.github.Electron.framework 0x0000000103c2cf51 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 225937
21 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
22 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
23 com.github.Electron.framework 0x0000000103bfaf1a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 21082
24 com.github.Electron.framework 0x0000000103cecebf v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1012223
25 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
26 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
27 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
28 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
29 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
30 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
31 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
32 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
33 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
34 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
35 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
36 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
37 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
38 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
39 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
40 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
41 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
42 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
43 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
44 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
45 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
46 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
47 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
48 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
49 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
50 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
51 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
52 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
53 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
54 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
55 com.github.Electron.framework 0x0000000103bfde8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
56 com.github.Electron.framework 0x0000000103bfbafb v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 24123
57 com.github.Electron.framework 0x0000000103bfb8d8 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 23576
58 com.github.Electron.framework 0x00000001036c7c57 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 3031
59 com.github.Electron.framework 0x00000001036c711a v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 154
60 com.github.Electron.framework 0x000000010364d38d v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 333
61 com.github.Electron.framework 0x0000000105bc6673 node::CallbackScope::~CallbackScope() + 2003
62 com.github.Electron.framework 0x0000000105bc6975 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) + 181
63 com.github.Electron.framework 0x0000000105c05315 node::EmitAsyncDestroy(node::Environment*, node::async_context) + 235317
64 com.github.Electron.framework 0x0000000102f9e734 uv_check_stop + 212
65 com.github.Electron.framework 0x0000000102f98a4c uv_run + 380
66 com.github.Electron.framework 0x00000001030f617e ElectronInitializeICUandStartNode + 1359342
67 com.github.Electron.framework 0x00000001041fcb99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6319833
68 com.github.Electron.framework 0x000000010420c09f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6382559
69 com.github.Electron.framework 0x000000010420bd5b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6381723
70 com.github.Electron.framework 0x000000010423fad0 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6594064
71 com.github.Electron.framework 0x000000010423c63a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6580602
72 com.github.Electron.framework 0x000000010423f4af v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6592495
73 com.apple.CoreFoundation 0x00007fff2045da0c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
74 com.apple.CoreFoundation 0x00007fff2045d974 __CFRunLoopDoSource0 + 180
75 com.apple.CoreFoundation 0x00007fff2045d6ef __CFRunLoopDoSources0 + 248
76 com.apple.CoreFoundation 0x00007fff2045c121 __CFRunLoopRun + 890
77 com.apple.CoreFoundation 0x00007fff2045b6ce CFRunLoopRunSpecific + 563
78 com.apple.Foundation 0x00007fff211e8fa1 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212
79 com.github.Electron.framework 0x000000010423ff99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6595289
80 com.github.Electron.framework 0x000000010423f02b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6591339
81 com.github.Electron.framework 0x000000010420ccd7 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6385687
82 com.github.Electron.framework 0x00000001041e9249 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6239625
83 com.github.Electron.framework 0x0000000105b78728 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33041000
84 com.github.Electron.framework 0x00000001035f76fa electron::fuses::IsRunAsNodeEnabled() + 4816634
85 com.github.Electron.framework 0x00000001035f62b0 electron::fuses::IsRunAsNodeEnabled() + 4811440
86 com.github.Electron.framework 0x00000001035f6772 electron::fuses::IsRunAsNodeEnabled() + 4812658
87 com.github.Electron.framework 0x0000000102faa358 ElectronMain + 136
88 com.github.Electron.helper 0x0000000102f48ee9 0x102f45000 + 16105
89 libdyld.dylib 0x00007fff20380621 start + 1
```
#### Traceback 2
```
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [67441]
Thread 0 Crashed:: CrRendererMain Dispatch queue: com.apple.main-thread
0 com.github.Electron.framework 0x000000010944be69 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 65961
1 com.github.Electron.framework 0x0000000109443e8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
2 com.github.Electron.framework 0x0000000109440f1a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 21082
3 com.github.Electron.framework 0x0000000109532ebf v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1012223
4 com.github.Electron.framework 0x0000000109443e8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
5 com.github.Electron.framework 0x0000000109443e8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
6 com.github.Electron.framework 0x0000000109441afb v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 24123
7 com.github.Electron.framework 0x00000001094418d8 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 23576
8 com.github.Electron.framework 0x0000000108f0dc57 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 3031
9 com.github.Electron.framework 0x0000000108f0d11a v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 154
10 com.github.Electron.framework 0x0000000108ef691f v8::internal::DateCache::ProbeDST(int) + 1711
11 com.github.Electron.framework 0x0000000108e9d71e v8::debug::EvaluateGlobal(v8::Isolate*, v8::Local<v8::String>, v8::debug::EvaluateGlobalMode, bool) + 270
12 com.github.Electron.framework 0x0000000109235869 v8_inspector::V8InspectorSession::canDispatchMethod(v8_inspector::StringView) + 8137
13 com.github.Electron.framework 0x000000010921eb4b v8::sampler::Sampler::Sampler(v8::Isolate*) + 18603
14 com.github.Electron.framework 0x000000010924756e v8_inspector::V8StackTraceId::V8StackTraceId(unsigned long, std::__1::pair<long long, long long>, bool) + 67086
15 com.github.Electron.framework 0x0000000109234c17 v8_inspector::V8InspectorSession::canDispatchMethod(v8_inspector::StringView) + 4983
16 com.github.Electron.framework 0x000000010aa006fd v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22825533
17 com.github.Electron.framework 0x0000000108e5ba82 electron::fuses::IsRunAsNodeEnabled() + 4940418
18 com.github.Electron.framework 0x0000000109bd40aa v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 7963626
19 com.github.Electron.framework 0x0000000109d0fb8c v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 9256652
20 com.github.Electron.framework 0x0000000109d0e83f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 9251711
21 com.github.Electron.framework 0x0000000109a42b99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6319833
22 com.github.Electron.framework 0x0000000109a5209f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6382559
23 com.github.Electron.framework 0x0000000109a51d5b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6381723
24 com.github.Electron.framework 0x0000000109a85ad0 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6594064
25 com.github.Electron.framework 0x0000000109a8263a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6580602
26 com.github.Electron.framework 0x0000000109a854af v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6592495
27 com.apple.CoreFoundation 0x00007fff2045da0c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
28 com.apple.CoreFoundation 0x00007fff2045d974 __CFRunLoopDoSource0 + 180
29 com.apple.CoreFoundation 0x00007fff2045d6ef __CFRunLoopDoSources0 + 248
30 com.apple.CoreFoundation 0x00007fff2045c121 __CFRunLoopRun + 890
31 com.apple.CoreFoundation 0x00007fff2045b6ce CFRunLoopRunSpecific + 563
32 com.apple.Foundation 0x00007fff211e8fa1 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212
33 com.github.Electron.framework 0x0000000109a85f99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6595289
34 com.github.Electron.framework 0x0000000109a8502b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6591339
35 com.github.Electron.framework 0x0000000109a52cd7 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6385687
36 com.github.Electron.framework 0x0000000109a2f249 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6239625
37 com.github.Electron.framework 0x000000010b3be728 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33041000
38 com.github.Electron.framework 0x0000000108e3d6fa electron::fuses::IsRunAsNodeEnabled() + 4816634
39 com.github.Electron.framework 0x0000000108e3c2b0 electron::fuses::IsRunAsNodeEnabled() + 4811440
40 com.github.Electron.framework 0x0000000108e3c772 electron::fuses::IsRunAsNodeEnabled() + 4812658
41 com.github.Electron.framework 0x00000001087f0358 ElectronMain + 136
42 com.github.Electron.helper 0x00000001087916e0 0x10878d000 + 18144
43 libdyld.dylib 0x00007fff20380621 start + 1
```
|
https://github.com/electron/electron/issues/27252
|
https://github.com/electron/electron/pull/27296
|
dd17250a80fe3e14d11ed4fa55f5ffa8427ce6a3
|
40e80af9a936eb0176d26adccdbfab6315efb350
| 2021-01-09T17:18:47Z |
c++
| 2021-01-14T05:06:43Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,211 |
["lib/renderer/web-view/web-view-impl.ts", "spec-main/webview-spec.ts", "spec/fixtures/pages/webview-trusted-types.html"]
|
[Feature Request]: Enable w3c trusted types usage with electron apps
|
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
VS Code is in the process of adopting trusted types, see https://github.com/microsoft/vscode/issues/103699 and https://github.com/w3c/webappsec-trusted-types. This is going well and electron plays along nicely. However, there is one place in `web-view-impl.ts` which directly assign a string to the `innerHTML` property: https://github.com/electron/electron/blob/34156c424cb1964cdd203293cbed138d19ee9c9d/lib/renderer/web-view/web-view-impl.ts#L47
When using trusted types this isn't allows (due to the potential for XSS) and either needs to be avoided or explicitly allowed via a trusted types policy.
This can reproduced with a renderer like this
```html
<!DOCTYPE html>
<html>
<meta http-equiv="Content-Security-Policy" content="require-trusted-types-for 'script'; trusted-types *">
<head>
<meta charset="UTF-8">
<title>Hello World!</title>
<link rel="stylesheet" type="text/css" href="./styles.css">
</head>
<body>
<h1>Hello World!</h1>
<script>
const webview = document.createElement('webview');
document.body.append(webview);
</script>
</body>
</html>
```
There is also a fiddle for the whole thing but that seems to trigger more/other violations that we don't see in VS Code. Might be related to the way electron fiddles work: https://gist.github.com/edd3cf4923d96a613c13954f546dd7d0
|
https://github.com/electron/electron/issues/27211
|
https://github.com/electron/electron/pull/27445
|
949fd0728fb56d06c33982a5523c5952511606e9
|
4a5c5843c49938edcde156eff5d3bf9fdb5d1455
| 2021-01-07T10:47:27Z |
c++
| 2021-01-25T01:29:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,188 |
["shell/browser/api/electron_api_web_contents.cc"]
|
Using window.history.back() and window.history.forward() does not update BrowserWindow titles.
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
<!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* 8.1.1
* 11.1.1
* **Operating System:**
* macOS 10.14, macOS 10.15<!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:**
* N/A<!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
When using `window.history.back()` or `window.history.forward()`, the title of the BrowserWindow should update to the title of the page you're navigating to.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
When using `window.history.back()` or `window.history.forward()`, the title of the BrowserWindow does not update to the title of the page you're navigating to.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
1) Download and start the `electron-quick-start` example
2) Open Devtools > Console
3) Enter `window.location = 'https://www.google.com'` to get to Google (The window title will update to Google)
4) Enter `window.history.back()` to go back to the page that was originally opened.
The window title will still say `Google` instead of `Hello World!` as it's supposed to.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
Here's a gif where I navigate to two websites and then use `window.history.back()` to show this issue:
### Additional Information:
This does work in the normal Chrome browser, so this looks to be an Electron specific issue.
|
https://github.com/electron/electron/issues/27188
|
https://github.com/electron/electron/pull/27724
|
c99c4117c8fb0cc1903cef66a63d0779a401bf08
|
b0a6eb6a53b8364e502801a8673064b9e764ddd1
| 2021-01-05T01:41:20Z |
c++
| 2021-02-17T18:23:45Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,149 |
["shell/browser/native_browser_view_views.cc"]
|
-webkit-app-region "drag" vs "non-drag" problem
|
Here is how to quickly reproduce the bug: Electron fiddle: https://gist.github.com/josephernest/f3db7d319af407b2dcef04c7c1c514ee
____
I have a `#topleft` red title bar containing multiple "tab" buttons that should fill all the available space *except* a `#topright` blue block.
It is possible to move the main Electron window by click-and-dragging on `#topleft`'s red background, thanks to `-webkit-app-region: drag;`. This works.
[![enter image description here][1]][1]
**Problems**:
1. clicks on `#topright` are ignored: `alert()` is not triggered (same problem for child elements of this block)
2. `#topright span:hover { background-color: black; }` is ignored
3. `#topright { -webkit-app-region: no-drag; }` is ignored: we can still move the window by click-and-dragging on `#topright` whereas it should not
However if we run the same HTML code *in a browser*, all is working correctly.
[1]: https://i.stack.imgur.com/ZZPsJ.png
|
https://github.com/electron/electron/issues/27149
|
https://github.com/electron/electron/pull/27143
|
6d31f1ad4ce6055dc9515bd4d236762e69761c24
|
29c2e2cb97e639346c582ce95508c9b7a1d87a02
| 2020-12-29T18:16:17Z |
c++
| 2021-01-04T19:22:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,131 |
["shell/browser/native_browser_view_views.cc"]
|
Top right part of BrowserView in frameless BrowserWindow is not clickable
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
Top right part of BrowserView in frameless BrowserWindow is not clickable
* **Electron Version:** 11.1.1 (broken with >= 11.0.4)
* **Operating System:** Windows & Linux (tested on Windows 10 20H2, reported by a Linux Mint user)
* **Last Known Working Electron version:** 11.0.3
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Buttons in `BrowserView` should be clickable.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Buttons in `BrowserView` are not clickable.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Replace `main.js` in `electron-quick-start` with the following code.
```js
// Modules to control application life and create native browser window
const {app, BrowserWindow, BrowserView} = require('electron')
const path = require('path')
function createWindow () {
// Create the browser window.
const mainWindow = new BrowserWindow({
width: 800,
height: 600,
frame: false,
webPreferences: {
preload: path.join(__dirname, 'preload.js')
}
})
const view = new BrowserView({})
view.webContents.loadURL('https://discordapp.com/login')
mainWindow.setBrowserView(view)
view.setBounds({
x: 0,
y: 0,
height: 600,
width: 800,
})
view.setAutoResize({ width: true, height: true })
// Open the DevTools.
view.webContents.openDevTools({ mode: 'detach' })
}
// This method will be called when Electron has finished
// initialization and is ready to create browser windows.
// Some APIs can only be used after this event occurs.
app.whenReady().then(() => {
createWindow()
app.on('activate', function () {
// On macOS it's common to re-create a window in the app when the
// dock icon is clicked and there are no other windows open.
if (BrowserWindow.getAllWindows().length === 0) createWindow()
})
})
// Quit when all windows are closed, except on macOS. There, it's common
// for applications and their menu bar to stay active until the user quits
// explicitly with Cmd + Q.
app.on('window-all-closed', function () {
if (process.platform !== 'darwin') app.quit()
})
// In this file you can include the rest of your app's specific main process
// code. You can also put them in separate files and require them here.
```
Login with your Discord account. The top right part of the UI won't be clickable (see screenshot).
Downgrade to Electron 11.0.3 and it will work normally. Upgrade to Electron 11.0.4 and it will break.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
Likely to be regression of https://github.com/electron/electron/pull/26738
@codebytere
|
https://github.com/electron/electron/issues/27131
|
https://github.com/electron/electron/pull/27143
|
6d31f1ad4ce6055dc9515bd4d236762e69761c24
|
29c2e2cb97e639346c582ce95508c9b7a1d87a02
| 2020-12-26T15:55:28Z |
c++
| 2021-01-04T19:22:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,112 |
["shell/browser/native_browser_view_mac.mm", "shell/browser/ui/drag_util.cc"]
|
Why is the BrowserView being dragged?
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [v] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [v] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [v] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->11.1.1
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->macOS 11.1
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->9.0.0
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->It shouldn't be dragged, it should be a click.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->It is dragged in BrowserView and cannot be clicked.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
```
// main.js
const findInpage = new BrowserView({
webPreferences: {
nodeIntegration: true,
},
});
const [viewWidth] = mainWindow.getContentSize();
mainwindow.setBrowserView(findInPage);
findInPage.setBounds({
x: viewWidth - 406,
y: 2,
width: 402,
height: 42,
});
findInPage.webContents.loadURL('..find-in-page.html');
// find-in-page.html
<html>
<head><style>...</style></head>
<body style="-webkit-app-region: no-drag;">
<div>
<input /><span>0/0</span>
<button>Aa</button>
<button>up</button>
<button>down</button>
<button>close</button>
</div>
</body>
</html>
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
https://user-images.githubusercontent.com/11021464/103020822-7bd18a00-458c-11eb-99ca-a31b4d837c8f.mov
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/27112
|
https://github.com/electron/electron/pull/27147
|
3455136e9dec4a693b59f8c42cf00baad412c6d2
|
6307b52dc5070cb589b11e6edbce3a1270d7bcd6
| 2020-12-23T17:23:11Z |
c++
| 2021-01-04T22:01:32Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,080 |
["shell/browser/native_window_mac.mm"]
|
[Big Sur] window corners are not rounded when using vibrancy effects
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11x
* **Operating System:**
* macOS 11.1 [Big Sur]
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
when using BrowserWindow vibrancy effects eg: `vibrancy: 'sidebar'`, the corners of the window are squared.
### Actual Behavior
### To Reproduce
Create a new BrowserWindow with vibrancy effects eg: `vibrancy: 'sidebar'`.
https://gist.github.com/262108f4d281d9aa780ecc18f7ade2ba
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<img width="454" alt="squared-corners" src="https://user-images.githubusercontent.com/1267580/102683285-fcc90400-41cf-11eb-84af-e379d4aba23b.png">
### Additional Information
Adding `titleBarStyle: 'hidden'` rounds the corners, but the corner radius is smaller that normal windows in Big Sur.
<img width="114" alt="small-radius" src="https://user-images.githubusercontent.com/1267580/102683360-b6c07000-41d0-11eb-9dac-59d882f38422.png">
Which seems to be the issue shown here: https://github.com/electron/electron/issues/27061
|
https://github.com/electron/electron/issues/27080
|
https://github.com/electron/electron/pull/28655
|
22a70eb8036825e3dc722473aa1de382e7371dff
|
e12128b65bc370973f43ca06fd2c05677f8d454e
| 2020-12-19T07:04:39Z |
c++
| 2021-04-15T21:22:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,061 |
["shell/browser/native_window_mac.mm"]
|
[Big Sur] Transpearent Window Corners
|
### Issue Details
Possibly related to https://github.com/electron/electron/issues/24319 and https://github.com/electron/electron/pull/24642
* **Electron Version:**
* v11.1.0
* **Operating System:**
* MacOS 11.1 (20C69)
### Expected Behavior
Platform normalized corners
### Actual Behavior
The corners of the window are off by a few pixels
### To Reproduce
```javascript
return new BrowserWindow({
titleBarStyle: 'hidden',
transparent: true,
hasShadow: true,
vibrancy: 'ultra-dark',
});
```
### Screenshots
<img width="141" alt="Screen Shot 2020-12-16 at 10 34 13 PM" src="https://user-images.githubusercontent.com/875022/102444569-20812400-3fef-11eb-8eab-3a00d50da2c9.png">
<img width="674" alt="Screen Shot 2020-12-16 at 10 39 54 PM" src="https://user-images.githubusercontent.com/875022/102444806-aac98800-3fef-11eb-9366-0ac59c05fa6e.png">
|
https://github.com/electron/electron/issues/27061
|
https://github.com/electron/electron/pull/28655
|
22a70eb8036825e3dc722473aa1de382e7371dff
|
e12128b65bc370973f43ca06fd2c05677f8d454e
| 2020-12-17T04:39:16Z |
c++
| 2021-04-15T21:22:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,048 |
["shell/browser/api/electron_api_system_preferences_mac.mm", "shell/common/color_util.cc", "shell/common/color_util.h"]
|
Incorrect values from systemPreferences.getAccentColor()
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v11.0.3
* **Operating System:**
* macOS 11.0.1 (Big Sur)
### Expected Behavior
Values returned from `systemPreferences.getAccentColor()` should match actual system accent colors.
### Actual Behavior
Values returned by Electron are slightly off (too dark).
Here's a comparison of 1) values returned from a native app querying the value of `controlAccentColor` on Big Sur, and 2) `systemPreferences.getAccentColor()`, which also queries controlAccentColor. Color column denotes the built-in accent color options in macOS (in `System Preferences > General > Accent color`).
| Color | Native | Electron |
| ------------- | ------------- | ------------- |
| Blue | #007AFFFF | #0A5FFFFF
| Purple | #A550A7FF | #923796FF
| Pink | #F74F9EFF | #F2318DFF
| Red | #FF5257FF | #FC3845FF
| Orange | #F7821BFF | #F36D16FF
| Yellow | #FFC600FF | #FEBC09FF
| Green | #62BA46FF | #53B036FF
| Graphite | #8C8C8CFF | #797979FF
The values returned from `getAccentColor` are just a bit too dark. And if they're not accurate, they're not very useful, since the point of using `getAccentColor` is to create UI elements that match the user's OS exactly.
### To Reproduce
Here's a [gist](https://gist.github.com/jcarpenter/4c90645e0c4b0035bbdf6f0112d653c0) with a bit of swift for outputting the value of `NSColor.controlAccentColor`.
### Screenshots
Here's what the delta looks like:
### Additional Information
The problem might lie in how the value is being [converted and returned](https://github.com/electron/electron/blob/master/shell/browser/api/electron_api_system_preferences_mac.mm#L391): `return base::SysNSStringToUTF8([sysColor RGBAValue]);`
🤷♀️
|
https://github.com/electron/electron/issues/27048
|
https://github.com/electron/electron/pull/28121
|
a442f11574fc6a6fbc7d482ae1cec89125098494
|
f73256651b83f96bdac3b607844c30061a9a3029
| 2020-12-16T18:55:40Z |
c++
| 2021-03-13T07:31:08Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,039 |
["shell/renderer/api/context_bridge/object_cache.cc"]
|
Memory leak when passing IPC events over contextBridge
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.1.0 and 9.3.5
* **Operating System:**
* Windows 10 2004
* **Last Known Working Electron version:**
* NA
### Expected Behavior
use of webContents.send + ipcRenderer.on cleans up memory after use
### Actual Behavior
In a real-world case, I have a renderer for the UI and a separate browserWindow for an audio process. The audio process monitors audio devices and reports the current volume of all devices via ipcRenderer.send (through preload contextBridge to the main process). The main process then sends this volume data over to the main UI renderer via webContents.send whereas the UI renderer listens via ipcRenderer.on (via preload contextBridge). This happens about once every 100 milliseconds. Memory use of the electron app, especially the renderer, slowly climbs to theoretical Infinitum. The starting memory is about 350MB. Within about a day, it's up to 1,500MB.
It does not matter what kind of content is passed through as arguments, nor its size (garbage collector seems to work on arguments). What matters is how often / frequently webContents.send is called and if there is an ipcRenderer.on listener for it (memory leak still exists even if there is nothing in the listener function so long as the listener exists).
### To Reproduce
Electron fiddle with a very simple example calling webContents.send every millisecond (to make the test quick... but the issue exists if you do every 100 milliseconds too but is much slower) and sending a Math.random() random number to the renderer. Memory use will increase over the course of a few minutes. I tested with a 10,000-item map as an argument as well, which made memory spike very quickly and get garbage-collected repeatedly, resulting in an average memory growth of about the same as Math.random(). This leads me to believe the problem is not the data being sent but the IPC execution itself.
[https://gist.github.com/37cde4adc11b3aa3f435e5d2698d9e05](https://gist.github.com/37cde4adc11b3aa3f435e5d2698d9e05)
### Additional Information
Additional info: Using handle/invoke seems to bypass this memory leak. However this is not ideal because renderer UI has to query main every 100 milliseconds for audio volume, and main has to locally store volume information (via another invoke / handle between main and the audio process). This creates additional VU meter lag.
|
https://github.com/electron/electron/issues/27039
|
https://github.com/electron/electron/pull/27630
|
d06bb7c97b0f1db9ffdbdf82e0ec138b376fc560
|
b6a91ef5dfec14c6a92d62f2c516f1ac967e9522
| 2020-12-16T03:09:51Z |
c++
| 2021-02-05T20:39:05Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 27,036 |
["lib/browser/guest-window-manager.ts", "spec-main/fixtures/snapshots/native-window-open.snapshot.txt", "spec-main/fixtures/snapshots/proxy-window-open.snapshot.txt", "spec-main/guest-window-manager-spec.ts"]
|
BrowserWindow title set to window name by default (from window.open(url, name))
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** Electron 11, 10
* **Operating System:** Windows 10
* **Last Known Working Electron version:** 9.4.0
### Expected Behavior
I expect that the window name doesn't get set into the title
### Actual Behavior
When opening windows via window.open passing in a window name, the title of the window gets defaulted to the window name.
*edit by @ckerr*: since this ticket's caused a little confusion, to restate this: Calling something like `window.open("https://example.com/", "aaa")` creates a window with a default title that is replaced with the real title when example.com's html is parsed and its `<title>` is used. Electron 10 introduced a change where that default title is the window.open() windowName parameter (`aaa` in the example). According to the [window.open() documentation](https://developer.mozilla.org/en-US/docs/Web/API/Window/open#parameters) this parameter "will NOT be used as the window's title", so Electron is in error by using it as the default title.
### To Reproduce
1. npm start -> main.js
2. click "Open Window"
3. Observe that the window title gets set to the window name ("aaa") before being replaced with the <title> of the web page. This didn't used to happen
main.js:
```
const { app, BrowserWindow } = require('electron')
function createWindow() {
const mainWindow = new BrowserWindow({
webPreferences: {
nodeIntegration: true,
nativeWindowOpen: true
}
})
mainWindow.loadFile('index.html')
mainWindow.webContents.on("new-window", (e, url, f, d, op) => {
console.log(op.title);
})
}
app.whenReady().then(() => {
createWindow()
})
app.on('window-all-closed', function () {
if (process.platform !== 'darwin') app.quit()
})
```
index.html:
```
<!DOCTYPE html>
<html>
<body>
<button id="b">Open window</button>
<script src="./renderer.js"></script>
</body>
</html>
```
renderer.js:
```
document.getElementById("b").onclick = () => {
window.open("https://google.com", "aaa");
};
```
|
https://github.com/electron/electron/issues/27036
|
https://github.com/electron/electron/pull/27521
|
40aeb0d9949e3a9bfe5613f5543bb254222ca312
|
357becd11326dbf47c95e1973d53fec10591bea8
| 2020-12-16T01:05:02Z |
c++
| 2021-01-29T13:24:30Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,986 |
["docs/api/global-shortcut.md", "shell/browser/api/electron_api_global_shortcut.cc"]
|
CHECK when globalShortcut.register called before app.on('ready')
|
I have something like this:
```
const { app, BrowserWindow, BrowserView, globalShortcut} = require('electron');
...
globalShortcut.register("F5", () => {
alert();
});
```
Adding this `globalShortcut.register` makes Electron crash on startup.
What's the best way to do an action when F5 is pressed, globally (even if there are other browserviews in the main window)?
|
https://github.com/electron/electron/issues/26986
|
https://github.com/electron/electron/pull/27002
|
ef49fea5eb4817db684ee2c590cb9b7e003f62f5
|
833baa4c54756b6978e0aa60a6f58b5552b7f661
| 2020-12-14T15:06:08Z |
c++
| 2020-12-15T19:13:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,975 |
["shell/browser/api/electron_api_base_window.cc", "spec-main/api-browser-view-spec.ts"]
|
BrowserWindow.addBrowserView doesn't remove BrowserView from old owner window
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v11.1.0
* **Operating System:**
* –
* **Last Known Working Electron version:**
* –
* **Place in code:**
* [atom/browser/api/atom_api_top_level_window.cc:696](https://github.com/electron/electron/blob/5ae3d1a1b2dbe11d3091d366467591d9cb21fdfe/atom/browser/api/atom_api_top_level_window.cc#L696)
* [atom/browser/api/atom_api_top_level_window.cc:709](https://github.com/electron/electron/blob/5ae3d1a1b2dbe11d3091d366467591d9cb21fdfe/atom/browser/api/atom_api_top_level_window.cc#L709)
### Expected Behavior
When `BrowserWindow#addBrowserView` got called, the BrowserView, passed as argument, receives new BrowserWindow and old BrowserWindow could be closed and has no control over BrowserView anymore.
### Actual Behavior
If BrowserView changes owner window (by `BrowserView#addBrowserView` call) and then old parent window closes, then BrowserView disappears from the new parent window.
### To Reproduce
```js
const {app, BrowserWindow, BrowserView} = require('electron')
const {once} = require('events')
async function main () {
await app.whenReady()
const width = 400
const height = 300
// Open two windows
const win1 = new BrowserWindow({
title: 'Window-1',
x: 300,
y: 300,
width,
height,
})
const win2 = new BrowserWindow({
title: 'Window-2',
y: 300,
x: 300 + width,
width,
height,
})
// Create BrowserView and append it to Window-1
const view = new BrowserView()
win1.addBrowserView(view)
view.setBounds({
x: 0, y: 0, width, height,
})
// Change BrowserView's owner window to Window-2 (e.g. to move tab between windows)
win2.addBrowserView(view)
view.webContents.loadURL('https://electronjs.org')
await once(view.webContents, 'did-finish-load')
view.webContents.executeJavaScript('alert("Close this window")')
}
main()
.catch(error => {
console.error(error)
app.exit(1)
})
```
### Additional Information
`TopLevelWindow::AddBrowserView` method should check if WebContents has an owner parent and detach the view. IMO there should be private method like `detachBrowserView` which does it.
|
https://github.com/electron/electron/issues/26975
|
https://github.com/electron/electron/pull/27000
|
6307b52dc5070cb589b11e6edbce3a1270d7bcd6
|
3286b5fa464e989a48e9bba3cb8e36ab489e370a
| 2020-12-12T21:12:20Z |
c++
| 2021-01-05T00:34:22Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,961 |
["script/release/uploaders/upload-symbols.py"]
|
Electron symbol server missing libGLESv2.dll.pdb
|
`electron-v10.1.7-win32-x64-pdb.zip` contains `libGLESv2.dll.pdb`, but they are missing from the symbol server:
* https://symbols.electronjs.org/libGLESv2.dll.pdb/dc9b50f68734d5954c4c44205044422e1/libGLESv2.dll.pdb
* https://symbols.electronjs.org/libGLESv2.dll.pdb/dc9b50f68734d5954c4c44205044422e1/libGLESv2.dll.sym
See also getsentry/sentry-electron#283
cc @MarshallOfSound
|
https://github.com/electron/electron/issues/26961
|
https://github.com/electron/electron/pull/26962
|
28ae68d66cdc1f8149437793b1f6c732c4b9108f
|
44ca6e081867f8fc702238b8dc0b706eee92e6fb
| 2020-12-11T19:19:20Z |
c++
| 2020-12-11T20:34:03Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,929 |
["docs/api/web-contents.md", "shell/browser/api/electron_api_browser_window.cc", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents.h", "spec/api-web-contents-spec.ts"]
|
API: Documented way to close a WebContents
|
There should be a documented way to close a WebContents and allow it to be garbage collected.
I'd prefer not to document the existing `webContents.destroy()` method if possible as it's quite aggressive and makes the underlying WebContents object unusable after being called. Ideally, I'd like to have a `webContents.close()` method that returns the object to the state that it was in prior to `loadURL()` being called, and marks it as available for GC once references are dropped.
i.e. this should work:
```js
const bv = new BrowserView
bv.webContents.loadURL("https://example.com")
// ... later ...
bv.webContents.close()
// If the reference to `bv` were dropped here, both `bv` and the webContents would be available for collection
// ... but if the reference is retained, the WebContents should be re-usable at a later date:
bv.webContents.loadURL("https://example.com")
```
Ref https://github.com/electron/electron/pull/23578.
|
https://github.com/electron/electron/issues/26929
|
https://github.com/electron/electron/pull/35509
|
994834d25a7060c05e89f0e5476eda832c957abc
|
eebf34cc6c4691e2ddca9b5a0a97566aeabd9072
| 2020-12-10T18:55:02Z |
c++
| 2022-09-16T23:22:59Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,911 |
["spec/chromium-spec.ts"]
|
Re-enable reporting api specs
|
Re-enable reporting api specs after they started failing around 12/4
Refs https://github.com/electron/electron/pull/26898
|
https://github.com/electron/electron/issues/26911
|
https://github.com/electron/electron/pull/35936
|
ba835ddac111c47a49d20416f8425138cbb36dfd
|
7e715b66ae15d123bd636c1be41a3301c7f25220
| 2020-12-09T17:18:36Z |
c++
| 2023-04-19T12:24:38Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,905 |
["patches/chromium/.patches", "patches/chromium/fix_setparentacessibile_crash_win.patch"]
|
Windows crash in views::NativeViewHost::SetParentAccessible
|
We're getting lots of crash reports like this on Electron 10.1.6.
Here's one stack (this can be avoided by `--disable-renderer-accessibility`):
```
Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ
Thread 19604 Crashed:
0 Figma.exe 0x7ff7fa80d457 views::NativeViewHost::SetParentAccessible (native_view_host.cc:57)
1 Figma.exe 0x7ff7f791f997 [inlined] base::ObserverList<T>::Iter::EnsureValidIndex (observer_list.h:214)
2 Figma.exe 0x7ff7f791f997 [inlined] base::ObserverList<T>::Iter::Iter (observer_list.h:136)
3 Figma.exe 0x7ff7f791f997 [inlined] base::ObserverList<T>::begin (observer_list.h:240)
4 Figma.exe 0x7ff7f791f997 ui::AXPlatformNode::NotifyAddAXModeFlags (ax_platform_node.cc:98)
5 Figma.exe 0x7ff7f88046cd content::BrowserAccessibilityStateImpl::AddAccessibilityModeFlags (browser_accessibility_state_impl.cc:224)
6 Figma.exe 0x7ff7f795b77c ui::AXPlatformNodeWin::QueryService (ax_platform_node_win.cc:4531)
```
For full stack trace, see: https://sentry.io/share/issue/9d0dab36a8c84cdb84cb6bde1ed39b32/
Here's another (this happens regardless of `--disable-renderer-accessibility`):
```
0 Figma.exe 0x7ff681ffd707 views::NativeViewHost::SetParentAccessible (native_view_host.cc:57)
1 Figma.exe 0x7ff67f10fc17 [inlined] base::ObserverList<T>::Iter::EnsureValidIndex (observer_list.h:214)
2 Figma.exe 0x7ff67f10fc17 [inlined] base::ObserverList<T>::Iter::Iter (observer_list.h:136)
3 Figma.exe 0x7ff67f10fc17 [inlined] base::ObserverList<T>::begin (observer_list.h:240)
4 Figma.exe 0x7ff67f10fc17 ui::AXPlatformNode::NotifyAddAXModeFlags (ax_platform_node.cc:98)
5 Figma.exe 0x7ff67f13f16b ui::AXPlatformNodeWin::get_attributes (ax_platform_node_win.cc:1363)
6 UIAutomationCore.DLL 0x7ffbe4bf8bc1 AccUtils::get_attributes
7 UIAutomationCore.DLL 0x7ffbe4c5a034 MsaaProxy::GetLiveSetting
8 UIAutomationCore.DLL 0x7ffbe4c5977f MsaaProxy::GetIsControlElementPropertyValue
9 UIAutomationCore.DLL 0x7ffbe4b75253 destructor'
10 UIAutomationCore.DLL 0x7ffbe4b02e0e MsaaProxy::GetPropertyValue
11 UIAutomationCore.DLL 0x7ffbe4b27054 UiaNode::ProviderGetPropertyValue
12 UIAutomationCore.DLL 0x7ffbe4b26b7b InProcClientAPIStub::UiaNode_GetPropertyValues
13 UIAutomationCore.DLL 0x7ffbe4b1947d ComInvoker::CallTarget
14 UIAutomationCore.DLL 0x7ffbe4b2c228 InProcClientAPIStub::InvokeInProcAPI
15 UIAutomationCore.DLL 0x7ffbe4b407f7 UiaNode::CrossProcess_GetPropertyValues
16 UIAutomationCore.DLL 0x7ffbe4b0567a RemoteUiaNodeStub::Incoming_GetPropertyValues
17 UIAutomationCore.DLL 0x7ffbe4b08f7f RemoteUiaNodeStub::OnMessage
18 UIAutomationCore.DLL 0x7ffbe4b0585b InvokeOnCorrectContext_Callback
19 UIAutomationCore.DLL 0x7ffbe4b1947d ComInvoker::CallTarget
20 UIAutomationCore.DLL 0x7ffbe4b204e6 ProcessIncomingRequest
21 UIAutomationCore.DLL 0x7ffbe4b1fc38 HookBasedServerConnectionManager::HookCallback
22 UIAutomationCore.DLL 0x7ffbe4b0a316 HookUtil<T>::CallOut
23 UIAutomationCore.DLL 0x7ffbe4aeacf4 HandleSyncHookMessage
24 UIAutomationCore.DLL 0x7ffbe4aea9b6 HookUtil<T>::CallWndProc
25 USER32.dll 0x7ffc13c8e021 fnHkINLPCWPSTRUCTW
26 USER32.dll 0x7ffc13c90bc2 _fnDWORD
27 ntdll.dll 0x7ffc155cfbd3 KiUserCallbackDispatcher
28 win32u.dll 0x7ffc13561063 ZwUserPeekMessage
29 USER32.dll 0x7ffc13c7a5c2 _PeekMessage
30 USER32.dll 0x7ffc13c7a522 PeekMessageW
31 Figma.exe 0x7ff680bcf3e5 base::MessagePumpForUI::ProcessNextWindowsMessage (message_pump_win.cc:500)
32 Figma.exe 0x7ff680bcf2a4 base::MessagePumpForUI::DoRunLoop (message_pump_win.cc:225)
33 Figma.exe 0x7ff680bcecd4 base::MessagePumpWin::Run (message_pump_win.cc:86)
```
Full trace: https://sentry.io/share/issue/6d1b9c9aa09c457795b3f255b27d6f29/
Here is the OS distribution:
% | version | last seen
-- | -- | --
55.66% | Windows 10.0.18362 | a minute ago
44.26% | Windows 10.0.19041 | 2 minutes ago
0.03% | Windows 10.0.17763 | 11 hours ago
0.02% | Windows 10.0.20211 | 4 days ago
0.02% | Windows 10.0.20221 | 3 days ago
0.02% | Windows 10.0.20270 | 18 hours ago
|
https://github.com/electron/electron/issues/26905
|
https://github.com/electron/electron/pull/26924
|
cc09da6233b945de3a7c8ec3da107aa1edbf21cd
|
b4c1e54ed38d8d0ab6e3edbf6370e589bf0f4c7f
| 2020-12-09T10:00:14Z |
c++
| 2020-12-11T17:47:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,900 |
["lib/browser/api/protocol.ts", "spec-main/api-remote-spec.ts"]
|
The object returned by remote.protocol lacks many methods
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->11.0.4
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 --> Windows 10(1909) x64
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 --> 9.3.5
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26900
|
https://github.com/electron/electron/pull/27009
|
9eab298779d3b0450f45a8de1bae5b038c64e567
|
998f17ee59c0d0735c3eb4d21b7a625af8c096ca
| 2020-12-09T02:45:48Z |
c++
| 2020-12-16T07:56:53Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,899 |
["shell/browser/native_window_views_win.cc"]
|
Frozen window appears when app is closed to tray and resolution is changed
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.0.4 and 12.0.0-beta.7
* **Operating System:**
* Windows 10 and 8.1
* **Last Known Working Electron version:**
* N/A
### Expected Behavior
Window does not re-open itself or become unusable.
### Actual Behavior
When you maximize and then close an Electron App to the system tray, and then change the display resolution in Settings, the Electron app will re-open the app window, and that window will be unusable.
### To Reproduce
Here's a gist: https://gist.github.com/devinfoley/7888802bc7f6597f703646a5263d4662
1. Start the application.
2. Maximize the window.
3. Close the window with X.
4. Enter Settings and change your display resolution.
You may need to change the application icon referenced in the above fiddle. It's hardcoded to a location on my machine.
### Screenshots
Open and maximize the app, then close it to system tray by clicking the X button.
<img width="1241" alt="Maximized App" src="https://user-images.githubusercontent.com/139239/101559151-6564e500-3975-11eb-985e-f33a309b9af2.png">
Go into settings and change your resolution.
<img width="1241" alt="Changing Resolution in Settings" src="https://user-images.githubusercontent.com/139239/101559149-6433b800-3975-11eb-820c-919c376b452b.png">
After the resolution is changed, an unusable Electron window will be displayed fullscreen.
<img width="1264" alt="A Broken Window Appears!" src="https://user-images.githubusercontent.com/139239/101559142-6138c780-3975-11eb-81a3-84a4ec72e0ee.png">
### Additional Information
I was able to repro this issue in Parallels, but not VirtualBox.
|
https://github.com/electron/electron/issues/26899
|
https://github.com/electron/electron/pull/27615
|
c175d41ae823d389c6b7f3acc5d7f23c4e05b3fa
|
d06bb7c97b0f1db9ffdbdf82e0ec138b376fc560
| 2020-12-09T00:53:30Z |
c++
| 2021-02-05T20:11:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,884 |
["script/lint.js", "shell/browser/ui/file_dialog_mac.mm", "shell/browser/ui/message_box_mac.mm", "shell/common/gin_helper/promise.h"]
|
Crash with dialog.showMessageBox(Sync) on macOS Big Sur
|
We're getting lots of crash reports from users on macOS Big Sur. The crashing line is either
https://github.com/electron/electron/blob/e3c4bbd21fb0ea2a79d8572add78e4b8c07c64a8/shell/browser/ui/message_box_mac.mm#L117
or
https://github.com/electron/electron/blob/e3c4bbd21fb0ea2a79d8572add78e4b8c07c64a8/shell/browser/ui/message_box_mac.mm#L128
The crash report is annotated with:
>Crashing on exception: -[NSApplication runModalForWindow:] may not be invoked inside of transaction begin/commit pair, or inside of transaction commit (usually this means it was invoked inside of a view's -drawRect: method.)
>ViewBridge hint(s): (
> "bridge key: most-recent-completion"
>)
This is on Electron 10.1.6, I have not tested other versions.
cc @zcbenz
|
https://github.com/electron/electron/issues/26884
|
https://github.com/electron/electron/pull/31606
|
1e618ef06c938e5e2775540347e9941090c1550b
|
c4d35cd18cbeacb82de2c83d28fbf2be52f14de7
| 2020-12-08T09:38:24Z |
c++
| 2021-11-01T21:08:31Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,883 |
["chromium_src/BUILD.gn", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents.h"]
|
Eyedropper does not work
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 12.0.0-beta.7
* **Operating System:**
* macOS / Window
* **Last Known Working Electron version:**
* 8
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
1. Add `<input type="color" />` in HTML code
2. Run the app
3. Click on input - color picker is opening
4. Pick color by Eyedropper
5. Input should be updated by selected color
### Actual Behavior
The eyedropper is not started
### To Reproduce
For reproduce you can use electron fiddle and simply add `<input type="color" />` in HTML code
### Screenshots
|
https://github.com/electron/electron/issues/26883
|
https://github.com/electron/electron/pull/27275
|
96e8620e1bdcf3de88206c7b24c8f1f8bb45d7a6
|
4f930b6e42967d4d72930b1aa9457d0f30b95ed5
| 2020-12-08T09:28:02Z |
c++
| 2021-01-21T21:02:29Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,862 |
["docs/api/app.md", "docs/api/structures/jump-list-category.md", "docs/api/structures/jump-list-item.md", "shell/browser/ui/win/jump_list.cc"]
|
Windows JumpList empty when a single entry has a long description
|
### Issue Details
* **Electron Version:**
* 11.0.3
* **Operating System:**
* Windows 10
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
An invalid entry to the `JumpList` does not cause other entries to disappear.
### Actual Behavior
A single invalid `JumpList` entry makes all other entries disappear.
### To Reproduce
```ts
// Modules to control application life and create native browser window
const { app, BrowserWindow } = require('electron')
// Keep a global reference of the window object, if you don't, the window will
// be closed automatically when the JavaScript object is garbage collected.
let mainWindow
function createWindow() {
// Create the browser window.
mainWindow = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
nodeIntegration: true
}
})
// and load the index.html of the app.
mainWindow.loadFile('index.html')
// Open the DevTools.
// mainWindow.webContents.openDevTools()
// Emitted when the window is closed.
mainWindow.on('closed', function () {
// Dereference the window object, usually you would store windows
// in an array if your app supports multi windows, this is the time
// when you should delete the corresponding element.
mainWindow = null
})
}
// This method will be called when Electron has finished
// initialization and is ready to create browser windows.
// Some APIs can only be used after this event occurs.
app.on('ready', createWindow)
app.setJumpList([
{
type: "custom",
name: "Recent Workspaces",
items: [
{
type: "task",
title: "Title",
description: "Description",
program: process.execPath
},
{
type: "task",
title: "Long Title",
description: "DescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescriptionDescription",
program: process.execPath
}
]
}
])
// Quit when all windows are closed.
app.on('window-all-closed', function () {
// On OS X it is common for applications and their menu bar
// to stay active until the user quits explicitly with Cmd + Q
if (process.platform !== 'darwin') {
app.quit()
}
})
app.on('activate', function () {
// On OS X it's common to re-create a window in the app when the
// dock icon is clicked and there are no other windows open.
if (mainWindow === null) {
createWindow()
}
})
// In this file you can include the rest of your app's specific main process
// code. You can also put them in separate files and require them here.
```
### Additional Information
It looks like this happens when the `description` property exceeds 255 characters length?
|
https://github.com/electron/electron/issues/26862
|
https://github.com/electron/electron/pull/28485
|
c280d770dc93dc194370510d71ed49a4886f5451
|
82ea8ea68cabdeea9d89a24965fd886d9233181e
| 2020-12-07T14:11:12Z |
c++
| 2021-04-05T23:50:39Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,829 |
["lib/renderer/security-warnings.ts"]
|
webview with JavaScript disabled and contextIsolation throws an exception
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 --> 11.0.3
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 --> Linux
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 --> unknown
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Webview should load correctly without any exception because JavaScript is disabled and `contextIsolation` is enabled.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
An exceptions is thrown at start-up:
```
Uncaught (in promise) Error: Script failed to execute, this normally means an error was thrown. Check the renderer console for the error.
at WebFrame.e.startsWith.e.startsWith.WebFrame.<computed> [as _executeJavaScript] (internal-webview://c27197e7-4a5a-430c-9ad7-2b57cd2f5555/electron/js2c/sandbox_bundle.js:67)
at warnAboutInsecureCSP (internal-webview://c27197e7-4a5a-430c-9ad7-2b57cd2f5555/electron/js2c/sandbox_bundle.js:87)
at logSecurityWarnings (internal-webview://c27197e7-4a5a-430c-9ad7-2b57cd2f5555/electron/js2c/sandbox_bundle.js:87)
at internal-webview://c27197e7-4a5a-430c-9ad7-2b57cd2f5555/electron/js2c/sandbox_bundle.js:87
```
### To Reproduce
Create a webview with `webpreferences="nodeIntegration=no,javascript=no,contextIsolation=yes,sandbox=yes"` and load a URL. Everything works fine if either JavaScript is enabled or `contextIsolation` is disabled.
[Example](https://gist.github.com/fxha/f3b9aeb12327574b72ee1fdf84875574)
|
https://github.com/electron/electron/issues/26829
|
https://github.com/electron/electron/pull/26837
|
03b43e4d8c8c86ea11e79c5b4fe82d751bafd371
|
3db4e612f4ca34f996c68a0e3c0d5932ab735f1a
| 2020-12-04T12:00:04Z |
c++
| 2020-12-07T18:58:00Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,824 |
["shell/browser/api/electron_api_web_frame_main.cc", "shell/browser/api/electron_api_web_frame_main.h"]
|
webContents.mainFrame can be undefined
|
### Issue Details
* **Electron Version:**
* 13.0.0-nightly.20201203
* **Operating System:**
* macOS
* **Last Known Working Electron version:**
* N/A
### Expected Behavior
`WebFrameMain.frames` should never contain undefined
### Actual Behavior
```
Uncaught Exception:
TypeError: Cannot read property 'processId' of undefined
at id (/private/var/folders/_7/jm5cr84j7jd4v7btf2d3bqwm0000gn/T/tmp-59557-p4DTr3KWOsNk/main.js:4:38)
at pft (/private/var/folders/_7/jm5cr84j7jd4v7btf2d3bqwm0000gn/T/tmp-59557-p4DTr3KWOsNk/main.js:6:36)
at Timeout._onTimeout (/private/var/folders/_7/jm5cr84j7jd4v7btf2d3bqwm0000gn/T/tmp-59557-p4DTr3KWOsNk/main.js:27:5)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)
```
### To Reproduce
Run https://gist.github.com/f46823470955034b4a456b6275862bfb for a short while and you'll observe the above error.
cc @samuelmaddock
|
https://github.com/electron/electron/issues/26824
|
https://github.com/electron/electron/pull/27648
|
bc7c290601649876aab1cff79983349aed129aab
|
1bbfa934f071985e929e80acff9214edc647b935
| 2020-12-04T00:26:53Z |
c++
| 2021-02-08T19:30:18Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,717 |
["shell/browser/ui/views/menu_bar.cc", "shell/browser/ui/views/menu_bar.h", "shell/browser/ui/views/submenu_button.cc", "shell/browser/ui/views/submenu_button.h"]
|
Menubar not clickable on Electron 12
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 12.0.0-beta.1 to 12.0.0-beta.6
* **Operating System:**
* Windows 10 (2004)
* **Last Known Working Electron version:**
* 11.x.x (all of them)
### Expected Behavior
Click on Menu Item opens the submenu of this item
### Actual Behavior
Clicking on menu set with Menu.setApplicationMenu(Menu.buildFromTemplate(topLevelItems)); is not possible. Pressing "ALT" Highlights the menu but nothing more happens
### To Reproduce
Build Application with menu
|
https://github.com/electron/electron/issues/26717
|
https://github.com/electron/electron/pull/27545
|
79b33937688a6745b7813364bfc732b8084d26d1
|
6edf6c6a957e4f2c2d1f2bdd4ddb7d39ecacc37e
| 2020-11-27T13:31:39Z |
c++
| 2021-01-29T20:43:51Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,713 |
["lib/browser/api/screen.ts"]
|
Electron 11: `remote.screen` EventEmitter methods are undefined
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.03
* **Operating System:**
* macOS 11.0.1
### Expected Behavior
`remote.screen` has EventEmitter methods such as `on` defined, to listen to screen events such as `display-added`
### Actual Behavior
`remote.screen` does not have any defined EventEmitter methods
### To Reproduce
In the devtools, inspect `require('electron').remote.screen` and notice that it does not have the `on` method defined
### Additional Information
There was a PR to address other `remote.screen` methods not being defined that was merged in 11.0.3 (https://github.com/electron/electron/pull/26660), but it did not seem to address this bug
|
https://github.com/electron/electron/issues/26713
|
https://github.com/electron/electron/pull/26809
|
e87061398b53b9d802968fe65153e5ec80dcaaea
|
b788ceb7bd2024f2e0f31290db237d0e39ee81be
| 2020-11-27T08:25:11Z |
c++
| 2020-12-08T04:47:48Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,677 |
["patches/node/.patches", "patches/node/allow_preventing_preparestacktracecallback.patch", "shell/common/node_bindings.cc"]
|
Electron 11 breaks Error stack in a loaded iframe
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.0.3
* **Operating System:**
* All
* **Last Known Working Electron version:**
* 10.1.6
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Should send a full Error stack
### Actual Behavior
In an iframe the error stack = "Error"
<!-- A clear and concise description of what actually happened. -->
### To Reproduce
Website has an iframe. On load the stack is not loaded
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
In a Browser (Chrome)
In Electron 11
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26677
|
https://github.com/electron/electron/pull/26820
|
1a79bedb278ef9c793be2e04ab612c653a9bc581
|
76f721474e353a8ba2e332e55d110b48c4a013cd
| 2020-11-24T17:02:53Z |
c++
| 2020-12-09T19:08:13Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,667 |
["shell/browser/ui/views/autofill_popup_view.cc"]
|
DCHECK in autofill relating to zero-sized windows on macOS
|
Version: 6932e02eb862080f56d5ae811f3f3efce4309221
OS: macOS
No repro unfortunately, observed running Slack under a debug build of Electron.
```
[29366:1123/155917.793910:FATAL:native_widget_ns_window_bridge.mm(499)] Check failed: !clamped_content_size.IsEmpty(). Zero-sized windows not supported on Mac
0 Electron Framework 0x0000000120a74569 base::debug::CollectStackTrace(void**, unsigned long) + 9
1 Electron Framework 0x00000001206fc9f3 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x000000012076cd0a logging::LogMessage::~LogMessage() + 1146
3 Electron Framework 0x000000012076fa6e logging::LogMessage::~LogMessage() + 14
4 Electron Framework 0x0000000128d8b21f remote_cocoa::NativeWidgetNSWindowBridge::SetBounds(gfx::Rect const&, gfx::Size const&) + 799
5 Electron Framework 0x00000001348ef62a views::NativeWidgetMacNSWindowHost::SetBoundsInScreen(gfx::Rect const&) + 794
6 Electron Framework 0x0000000134923cd1 views::NativeWidgetMac::SetBounds(gfx::Rect const&) + 289
7 Electron Framework 0x000000010fb72e49 electron::AutofillPopupView::Show() + 1401
8 Electron Framework 0x000000010f8e45f8 electron::AutofillPopup::CreateView(content::RenderFrameHost*, content::RenderFrameHost*, bool, views::View*, gfx::RectF const&) + 1336
9 Electron Framework 0x000000010f7a376c electron::AutofillDriver::ShowAutofillPopup(gfx::RectF const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > > const&) + 1244
10 Electron Framework 0x000000011e85c519 electron::mojom::ElectronAutofillDriverStubDispatch::Accept(electron::mojom::ElectronAutofillDriver*, mojo::Message*) + 1577
[...]
```
|
https://github.com/electron/electron/issues/26667
|
https://github.com/electron/electron/pull/36121
|
0026fdb78a68c6a4067191826bd1bfc1d9700998
|
85f41d59aceabbdeee1fdec75770249c6335e73a
| 2020-11-24T00:00:52Z |
c++
| 2023-01-27T09:50:19Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,628 |
["docs/api/system-preferences.md", "shell/browser/api/electron_api_system_preferences_mac.mm", "shell/browser/api/electron_api_system_preferences_win.cc", "spec/api-system-preferences-spec.ts"]
|
Support alpha values in systemPreferences.getColor()
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v8.2.5
* **Operating System:**
* macOS 10.15.4
### Expected Behavior
On macOS, [systemPreferences.getColor(color)](https://www.electronjs.org/docs/api/system-preferences#systempreferencesgetcolorcolor-windows-macos) should return 8-digit RGBA values. As-is, they return as 6-digit RGB.
Many of the macOS [Dynamic System Colors](https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/color/#dynamic-system-colors) use alphas. Labels, for example, are always black or white and vary only by alpha.
For comparison's sake, I wrote a bit of Swift code to query the actual label values. As follows (for light mode, w/o high contrast enabled, and converted here to css values):
```css
labelColor: rgba(0, 0, 0, 0.847);
secondaryLabelColor: rgba(0, 0, 0, 0.498);
tertiaryLabelColor: rgba(0, 0, 0, 0.247);
quaternaryLabelColor: rgba(0, 0, 0, 0.098);
```
Without alphas, the returned values from these APIs aren't useful, unfortunately.
|
https://github.com/electron/electron/issues/26628
|
https://github.com/electron/electron/pull/38960
|
dd7395ebedf0cfef3129697f9585035a4ddbde63
|
d002f16157bbc7f4bc70f2db6edde21d74c02276
| 2020-11-21T23:19:03Z |
c++
| 2023-09-28T22:56:16Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,615 |
["lib/browser/api/touch-bar.ts", "shell/browser/ui/cocoa/electron_touch_bar.mm"]
|
TouchBar: Groups and popover-Items not rendering items at all
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.0.2
* **Operating System:**
* macOS 10.15.5 (19F101)
* **Last Known Working Electron version:**
* 10.1.6
### Expected Behavior
Items inside a TouchBarGroup or TouchBarPopover should be rendered.
### Actual Behavior
Items inside a TouchBarGroup or TouchBarPopover don't show up.
### To Reproduce
https://gist.github.com/390d885b1cf4209a81583b0ee1e0d9aa
|
https://github.com/electron/electron/issues/26615
|
https://github.com/electron/electron/pull/27901
|
e5a9a1ebd7cd4847389e0cf2b23a4c89819462f2
|
2d0ad0b96aaee079f30912296c5ef460fd0a1180
| 2020-11-20T09:41:47Z |
c++
| 2021-03-01T21:34:00Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,610 |
["lib/browser/api/screen.ts"]
|
Methods on remote.screen are not defined
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.0.2
* **Operating System:**
* NixOS 21.03 x86_64
* **Last Known Working Electron version:**
* 10.1.6
### Expected Behavior
`remote.screen.getPrimaryDisplay()` works.
### Actual Behavior
`Uncaught TypeError: remote.screen.getPrimaryDisplay is not a function`
### To Reproduce
Electron Fiddle: https://gist.github.com/andersk/6158c0016c56e52c58cec4aa4cd8317e
### Additional Information
This broke between 11.0.0-nightly.20200724 and 11.0.0-nightly.20200729, probably in #24677. Cc @nornagon.
See also electron-userland/spectron#771, webtorrent/webtorrent-desktop#1896.
|
https://github.com/electron/electron/issues/26610
|
https://github.com/electron/electron/pull/26620
|
6932e02eb862080f56d5ae811f3f3efce4309221
|
b1b25607ee08b7524c5f66883e232b535f02de7f
| 2020-11-20T03:10:07Z |
c++
| 2020-11-23T21:44:54Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,607 |
["shell/browser/api/electron_api_content_tracing.cc", "spec-main/api-content-tracing-spec.ts"]
|
contentTracing.stopRecording() never resolves if called when not recording
|
### Issue Details
* **Electron Version:**
* 12, 11, 10, 9
* **Operating System:**
* all
* **Last Known Working Electron version:**
* NA
### Expected Behavior
The Promise returned by `contentTracing.stopTracing()` should always either resolve or reject.
### Actual Behavior
If called when a trace is not in progress, `contentTracing.stopTracing()` never resolves or rejects.
### To Reproduce
https://gist.github.com/8eb40af81ba15dbe4c50735a6ec4489d
note `'done'` is never printed.
|
https://github.com/electron/electron/issues/26607
|
https://github.com/electron/electron/pull/26608
|
329494cfebba5a488f0a0887e8d4251f07cf7da1
|
854d2b1574747ce50fca270b76bbeffb35ef6245
| 2020-11-19T20:27:39Z |
c++
| 2020-11-23T18:20:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,604 |
["shell/browser/browser_mac.mm"]
|
DCHECK in Browser::DockSetIcon
|
Version: f05b8ef57
OS: macOS
```
[18596:1119/090351.901962:FATAL:image_skia.cc(479)] Check failed: g_supported_scales != NULL.
0 Electron Framework 0x0000000114132b69 base::debug::CollectStackTrace(void**, unsigned long) + 9
1 Electron Framework 0x0000000114022993 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x0000000114042aff logging::LogMessage::~LogMessage() + 175
3 Electron Framework 0x00000001140439be logging::LogMessage::~LogMessage() + 14
4 Electron Framework 0x0000000115860dea gfx::ImageSkia::EnsureRepsForSupportedScales() const + 74
5 Electron Framework 0x000000011586fc08 gfx::NSImageFromImageSkiaWithColorSpace(gfx::ImageSkia const&, CGColorSpace*) + 72
6 Electron Framework 0x000000011585c5af gfx::Image::ToNSImage() const + 479
7 Electron Framework 0x000000011585cf44 gfx::Image::AsNSImage() const + 100
8 Electron Framework 0x000000010e8ea3b0 electron::Browser::DockSetIcon(gfx::Image const&) + 48
```
https://source.chromium.org/chromium/chromium/src/+/master:ui/gfx/image/image_skia.cc;l=479;drc=8586102b48a409c634250f31c3fc7bdde5ec3db0
|
https://github.com/electron/electron/issues/26604
|
https://github.com/electron/electron/pull/36279
|
5fc3ed936e7ee5f3258782c0a0312cd9a2ebb174
|
1b1609aa0f7e282286ef2e842d5c895adcedfc86
| 2020-11-19T17:05:45Z |
c++
| 2022-11-09T16:13:24Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,599 |
["docs/api/web-contents.md", "shell/browser/api/electron_api_web_contents.cc", "spec-main/api-web-contents-spec.ts"]
|
Segmentation fault when webContents.fromId() for non existing id
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
webContents.fromId() for non existing id (e.g. removed webview) causes segmentation fault in Electron 11.
In Electron 9 & 10 null was returned.
Same problem on Windows and macOS Catalina
* **Electron Version:**
* 11.0.1
* **Operating System:**
* macOS 11.0.1
* **Last Known Working Electron version:**
* 10.1.6
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
webContents.fromId() returns null for non existing id
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Segmentation fault
### To Reproduce
https://gist.github.com/larssvensby/071353ec109c4975fd28b5a4b1dc7ad5
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26599
|
https://github.com/electron/electron/pull/26609
|
abb1504eccc83ba618982bc8d63f4f0f7b325df8
|
329494cfebba5a488f0a0887e8d4251f07cf7da1
| 2020-11-19T13:53:31Z |
c++
| 2020-11-23T17:21:00Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,588 |
["shell/browser/api/electron_api_browser_window.cc", "shell/browser/api/electron_api_browser_window_mac.mm", "shell/browser/native_browser_view.h", "shell/browser/native_browser_view_mac.h", "shell/browser/native_browser_view_mac.mm"]
|
Draggable region in BrowserWindow causes BrowserView to become draggable
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 10.1.6
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:** macOS Big Sur 11.0.1
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:** 10.1.5
* <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
`BrowserView` is not draggable.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
`BrowserView` is draggable.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
From my test, if I creates a draggable region on the left side of `BrowserWindow` (let's say with width 100px), and then add a `BrowserView` to the right side of the window, the 100px part on the right side of BrowserWindow/BrowserView will become draggable.
You can reproduce the bugs using the following code (modified from `electron-quick-start`).
[electron-1015.zip](https://github.com/electron/electron/files/5564422/electron-1015.zip) ([email protected])
[electron-1016.zip](https://github.com/electron/electron/files/5564423/electron-1016.zip) ([email protected])
The files have identical code, except for the Electron version. It works properly in v10.1.5 but doesn't in v10.1.6
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
Potentially related to https://github.com/electron/electron/pull/26145
|
https://github.com/electron/electron/issues/26588
|
https://github.com/electron/electron/pull/26690
|
4e3e3d414d1a9b62c6f6c52b9ab30f949b92e1ca
|
acfbbe9869960d98a3b8b563e9bc62b9179c68a8
| 2020-11-19T04:49:43Z |
c++
| 2020-12-01T05:02:04Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,567 |
["lib/browser/api/web-contents.ts"]
|
app throws exception on quit() function in electron version 11
|
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x ] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [ x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
electron in version 11. frameless window after closing all windows and quit app with this event
app.on("window-all-closed", () => {
app.exit(0); // or app.quit()
});
electron throws an exception : object has been destroyed
* **Electron Version:**
* 11.0.1
* **Operating System:**
* Windows 10 (1803)
* **Last Known Working Electron version:**
* 10.1.5 and all 10,9,8 versions
### Expected Behavior
quit app without throwing any error
### Actual Behavior
in version 11 app crashes
### Screenshots
### To Reproduce
https://gist.github.com/pejmanpesyan/8540aad65e7c6980c45f23e5eaafafb9
|
https://github.com/electron/electron/issues/26567
|
https://github.com/electron/electron/pull/27038
|
8cbcb04e844c8f747a7c4c07eae226ad6d960344
|
da3d21e5e3c27fa4490776ab68ad0f1e35856557
| 2020-11-18T16:02:57Z |
c++
| 2020-12-17T20:10:29Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,562 |
["shell/browser/native_browser_view_views.cc", "shell/browser/native_browser_view_views.h", "shell/browser/native_window_views.cc", "shell/browser/ui/views/frameless_view.cc"]
|
BrowserView draggable area not working in windows exclusively on BrowserViews
|
### Issue Details
in frameless windows
While setting browserview style to draggable by webkit-app-region : drag. the area won't be draggable after that
and it can not move main window
### Electron Version:
11.0.1
### Operating System:
Windows 10 (1803)
Last Known Working Electron version:
not found
### Expected Behavior
Browser view moves the main window while I set the style of the body or one of the area to
-webkit-app-region: drag;
### Actual Behavior
nothing happen in browserview after styling -webkit-app-region: drag;
I know it is mention that in 11 version it is fixed. but it still dosn't work
### To Reproduce
https://gist.github.com/pejmanpesyan/8540aad65e7c6980c45f23e5eaafafb9
|
https://github.com/electron/electron/issues/26562
|
https://github.com/electron/electron/pull/26738
|
cdcee04bbe9c62807c9376a72c34a4d7f5cbf590
|
528b0f0e746e3a844b2283d5a946e138b6bf89b8
| 2020-11-18T10:26:34Z |
c++
| 2020-12-01T23:03:00Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,540 |
["shell/browser/electron_browser_main_parts.cc"]
|
Use-after-free in extensions::ProcessManager::Shutdown
|
Electron version: tip of tree (358ab79778396c533404652d94a3fc4be688b285).
Platform: Linux
Detected in CI: https://app.circleci.com/pipelines/github/electron/electron/32757/workflows/7653119d-b66b-4c28-a7f0-49a1856b5aeb/jobs/720767/steps
<details>
<summary>ASan report</summary>
```
=================================================================
==551==ERROR: AddressSanitizer: heap-use-after-free on address 0x612000078e58 at pc 0x55a3dc7db807 bp 0x7ffd8b4b5830 sp 0x7ffd8b4b5828
READ of size 8 at 0x612000078e58 thread T0 (electron)
#0 0x55a3dc7db806 in begin ./../../buildtools/third_party/libc++/trunk/include/vector:1516:30
#1 0x55a3dc7db806 in begin<std::__1::vector<base::internal::UncheckedObserverAdapter, std::__1::allocator<base::internal::UncheckedObserverAdapter> > &> ./../../base/ranges/ranges.h:44:37
#2 0x55a3dc7db806 in begin<std::__1::vector<base::internal::UncheckedObserverAdapter, std::__1::allocator<base::internal::UncheckedObserverAdapter> > &> ./../../base/ranges/ranges.h:105:10
#3 0x55a3dc7db806 in find_if<std::__1::vector<base::internal::UncheckedObserverAdapter, std::__1::allocator<base::internal::UncheckedObserverAdapter> > &, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:482:26
#4 0x55a3dc7db806 in base::ObserverList<extensions::ExtensionRegistryObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(extensions::ExtensionRegistryObserver const*) ./../../base/observer_list.h:283:21
#5 0x55a3dc88629c in extensions::ProcessManager::Shutdown() ./../../extensions/browser/process_manager.cc:314:24
#6 0x55a3e0cd7072 in ShutdownFactoriesInOrder ./../../components/keyed_service/core/dependency_manager.cc:128:14
#7 0x55a3e0cd7072 in DependencyManager::DestroyContextServices(void*) ./../../components/keyed_service/core/dependency_manager.cc:84:3
#8 0x55a3cf5e6aff in electron::ElectronBrowserContext::~ElectronBrowserContext() ./../../electron/shell/browser/electron_browser_context.cc:160:51
#9 0x55a3cf5e72cd in electron::ElectronBrowserContext::~ElectronBrowserContext() ./../../electron/shell/browser/electron_browser_context.cc:156:51
#10 0x55a3cf5f54a9 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
#11 0x55a3cf5f54a9 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
#12 0x55a3cf5f54a9 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19
#13 0x55a3cf5f54a9 in ~pair ./../../buildtools/third_party/libc++/trunk/include/utility:297:29
#14 0x55a3cf5f54a9 in __destroy<std::__1::pair<const electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > ./../../buildtools/third_party/libc++/trunk/include/memory:1787:23
#15 0x55a3cf5f54a9 in destroy<std::__1::pair<const electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > ./../../buildtools/third_party/libc++/trunk/include/memory:1619:14
#16 0x55a3cf5f54a9 in std::__1::__tree<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::__map_value_compare<electron::ElectronBrowserContext::PartitionKey, std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::less<electron::ElectronBrowserContext::PartitionKey>, true>, std::__1::allocator<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, void*>*) ./../../buildtools/third_party/libc++/trunk/include/__tree:1833:9
#17 0x55a3cf5f5455 in std::__1::__tree<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::__map_value_compare<electron::ElectronBrowserContext::PartitionKey, std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::less<electron::ElectronBrowserContext::PartitionKey>, true>, std::__1::allocator<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, void*>*) ./../../buildtools/third_party/libc++/trunk/include/__tree:1831:9
#18 0x55a3cf5f4b07 in clear ./../../buildtools/third_party/libc++/trunk/include/__tree:1870:5
#19 0x55a3cf5f4b07 in clear ./../../buildtools/third_party/libc++/trunk/include/map:1309:37
#20 0x55a3cf5f4b07 in electron::ElectronBrowserMainParts::PostMainMessageLoopRun() ./../../electron/shell/browser/electron_browser_main_parts.cc:522:49
#21 0x55a3d941dd71 in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1057:13
#22 0x55a3d942483f in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17
#23 0x55a3d9415103 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16
#24 0x55a3d460bcf3 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:521:10
#25 0x55a3d460bcf3 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1008:10
#26 0x55a3d460ae56 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:883:12
#27 0x55a3d46033ec in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36
#28 0x55a3d46039ac in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10
#29 0x55a3cf2b4da0 in main ./../../electron/shell/app/electron_main.cc:233:10
#30 0x7fb212ab9b96 in __libc_start_main ??:0:0
0x612000078e58 is located 152 bytes inside of 264-byte region [0x612000078dc0,0x612000078ec8)
freed by thread T0 (electron) here:
#0 0x55a3cf26c4dd in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:160:3
#1 0x55a3e0ce0beb in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
#2 0x55a3e0ce0beb in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
#3 0x55a3e0ce0beb in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19
#4 0x55a3e0ce0beb in ~pair ./../../buildtools/third_party/libc++/trunk/include/utility:297:29
#5 0x55a3e0ce0beb in __destroy<std::__1::pair<void *const, std::__1::unique_ptr<KeyedService, std::__1::default_delete<KeyedService> > > > ./../../buildtools/third_party/libc++/trunk/include/memory:1787:23
#6 0x55a3e0ce0beb in destroy<std::__1::pair<void *const, std::__1::unique_ptr<KeyedService, std::__1::default_delete<KeyedService> > > > ./../../buildtools/third_party/libc++/trunk/include/memory:1619:14
#7 0x55a3e0ce0beb in erase ./../../buildtools/third_party/libc++/trunk/include/__tree:2519:5
#8 0x55a3e0ce0beb in erase ./../../buildtools/third_party/libc++/trunk/include/map:1301:56
#9 0x55a3e0ce0beb in KeyedServiceFactory::Disassociate(void*) ./../../components/keyed_service/core/keyed_service_factory.cc:97:14
#10 0x55a3e0ce0e77 in KeyedServiceFactory::ContextDestroyed(void*) ./../../components/keyed_service/core/keyed_service_factory.cc:107:3
#11 0x55a3e0cd7332 in DestroyFactoriesInOrder ./../../components/keyed_service/core/dependency_manager.cc:138:14
#12 0x55a3e0cd7332 in DependencyManager::DestroyContextServices(void*) ./../../components/keyed_service/core/dependency_manager.cc:86:3
#13 0x55a3cf5e6aff in electron::ElectronBrowserContext::~ElectronBrowserContext() ./../../electron/shell/browser/electron_browser_context.cc:160:51
#14 0x55a3cf5e72cd in electron::ElectronBrowserContext::~ElectronBrowserContext() ./../../electron/shell/browser/electron_browser_context.cc:156:51
#15 0x55a3cf5f54a9 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
#16 0x55a3cf5f54a9 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
#17 0x55a3cf5f54a9 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19
#18 0x55a3cf5f54a9 in ~pair ./../../buildtools/third_party/libc++/trunk/include/utility:297:29
#19 0x55a3cf5f54a9 in __destroy<std::__1::pair<const electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > ./../../buildtools/third_party/libc++/trunk/include/memory:1787:23
#20 0x55a3cf5f54a9 in destroy<std::__1::pair<const electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > ./../../buildtools/third_party/libc++/trunk/include/memory:1619:14
#21 0x55a3cf5f54a9 in std::__1::__tree<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::__map_value_compare<electron::ElectronBrowserContext::PartitionKey, std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::less<electron::ElectronBrowserContext::PartitionKey>, true>, std::__1::allocator<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, void*>*) ./../../buildtools/third_party/libc++/trunk/include/__tree:1833:9
#22 0x55a3cf5f5431 in std::__1::__tree<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::__map_value_compare<electron::ElectronBrowserContext::PartitionKey, std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, std::__1::less<electron::ElectronBrowserContext::PartitionKey>, true>, std::__1::allocator<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<electron::ElectronBrowserContext::PartitionKey, std::__1::unique_ptr<electron::ElectronBrowserContext, std::__1::default_delete<electron::ElectronBrowserContext> > >, void*>*) ./../../buildtools/third_party/libc++/trunk/include/__tree:1830:9
#23 0x55a3cf5f4b07 in clear ./../../buildtools/third_party/libc++/trunk/include/__tree:1870:5
#24 0x55a3cf5f4b07 in clear ./../../buildtools/third_party/libc++/trunk/include/map:1309:37
#25 0x55a3cf5f4b07 in electron::ElectronBrowserMainParts::PostMainMessageLoopRun() ./../../electron/shell/browser/electron_browser_main_parts.cc:522:49
#26 0x55a3d941dd71 in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1057:13
#27 0x55a3d942483f in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17
#28 0x55a3d9415103 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16
#29 0x55a3d460bcf3 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:521:10
#30 0x55a3d460bcf3 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1008:10
#31 0x55a3d460ae56 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:883:12
#32 0x55a3d46033ec in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36
#33 0x55a3d46039ac in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10
#34 0x55a3cf2b4da0 in main ./../../electron/shell/app/electron_main.cc:233:10
#35 0x7fb212ab9b96 in __libc_start_main ??:0:0
previously allocated by thread T0 (electron) here:
#0 0x55a3cf26bc7d in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:99:3
#1 0x55a3dc7df243 in extensions::ExtensionRegistryFactory::BuildServiceInstanceFor(content::BrowserContext*) const ./../../extensions/browser/extension_registry_factory.cc:39:10
#2 0x55a3ee782ef7 in BrowserContextKeyedServiceFactory::BuildServiceInstanceFor(void*) const ./../../components/keyed_service/content/browser_context_keyed_service_factory.cc:95:7
#3 0x55a3e0cdf63c in KeyedServiceFactory::GetServiceForContext(void*, bool) ./../../components/keyed_service/core/keyed_service_factory.cc:80:15
#4 0x55a3dc9f344e in extensions::AlarmManager::AlarmManager(content::BrowserContext*) ./../../extensions/browser/api/alarms/alarm_manager.cc:119:36
#5 0x55a3dca00f31 in extensions::BrowserContextKeyedAPIFactory<extensions::AlarmManager>::BuildServiceInstanceFor(content::BrowserContext*) const ./../../extensions/browser/browser_context_keyed_api_factory.h:137:16
#6 0x55a3ee782ef7 in BrowserContextKeyedServiceFactory::BuildServiceInstanceFor(void*) const ./../../components/keyed_service/content/browser_context_keyed_service_factory.cc:95:7
#7 0x55a3e0cdf63c in KeyedServiceFactory::GetServiceForContext(void*, bool) ./../../components/keyed_service/core/keyed_service_factory.cc:80:15
#8 0x55a3e0cd6a67 in DependencyManager::CreateContextServices(void*, bool) ./../../components/keyed_service/core/dependency_manager.cc:0:0
#9 0x55a3ee781cca in BrowserContextDependencyManager::DoCreateBrowserContextServices(content::BrowserContext*, bool) ./../../components/keyed_service/content/browser_context_dependency_manager.cc:46:22
#10 0x55a3cf5e45ef in electron::ElectronBrowserContext::ElectronBrowserContext(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, base::DictionaryValue) ./../../electron/shell/browser/electron_browser_context.cc:146:11
#11 0x55a3cf5ea4d1 in electron::ElectronBrowserContext::From(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, base::DictionaryValue) ./../../electron/shell/browser/electron_browser_context.cc:476:11
#12 0x55a3cf4411af in electron::api::Session::FromPartition(v8::Isolate*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::DictionaryValue) ./../../electron/shell/browser/api/electron_api_session.cc:1128:9
#13 0x55a3cf4a8923 in electron::api::WebContents::WebContents(v8::Isolate*, gin_helper::Dictionary const&) ./../../electron/shell/browser/api/electron_api_web_contents.cc:688:15
#14 0x55a3cf4f1d9a in electron::api::WebContents::Create(v8::Isolate*, gin_helper::Dictionary const&) ./../../electron/shell/browser/api/electron_api_web_contents.cc:3757:38
#15 0x55a3cf542d25 in electron::api::WebContentsView::New(gin_helper::Arguments*, gin_helper::Dictionary const&) ./../../electron/shell/browser/api/electron_api_web_contents_view.cc:116:20
#16 0x55a3cf544235 in Run ./../../base/callback.h:168:12
#17 0x55a3cf544235 in gin_helper::WrappableBase* gin_helper::internal::InvokeFactory<gin_helper::Arguments*, gin_helper::Dictionary const&>(gin::Arguments*, base::RepeatingCallback<gin_helper::WrappableBase* (gin_helper::Arguments*, gin_helper::Dictionary const&)> const&) ./../../electron/shell/common/gin_helper/constructor.h:43:19
#18 0x55a3cf543d5f in void gin_helper::internal::InvokeNew<gin_helper::WrappableBase* (gin_helper::Arguments*, gin_helper::Dictionary const&)>(base::RepeatingCallback<gin_helper::WrappableBase* (gin_helper::Arguments*, gin_helper::Dictionary const&)> const&, v8::Isolate*, gin_helper::Arguments*) ./../../electron/shell/common/gin_helper/constructor.h:132:14
#19 0x55a3cf32fd47 in Run ./../../base/callback.h:168:12
#20 0x55a3cf32fd47 in DispatchToCallback ./../../electron/shell/common/gin_helper/function_template.h:228:14
#21 0x55a3cf32fd47 in gin_helper::Dispatcher<void (v8::Isolate*, gin_helper::Arguments*)>::DispatchToCallback(v8::FunctionCallbackInfo<v8::Value> const&) ./../../electron/shell/common/gin_helper/function_template.h:262:15
#22 0x55a3d530a61f in v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) ./../../v8/src/api/api-arguments-inl.h:158:3
#23 0x55a3d530550a in v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) ./../../v8/src/builtins/builtins-api.cc:111:36
#24 0x55a3d530429e in v8::internal::Builtins::InvokeApiFunction(v8::internal::Isolate*, bool, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, v8::internal::Handle<v8::internal::HeapObject>) ./../../v8/src/builtins/builtins-api.cc:223:16
#25 0x55a3d5694302 in v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) ./../../v8/src/execution/execution.cc:275:20
#26 0x55a3d56975fd in v8::internal::Execution::New(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) ./../../v8/src/execution/execution.cc:486:10
#27 0x55a3d50e6640 in v8::Function::NewInstanceWithSideEffectType(v8::Local<v8::Context>, int, v8::Local<v8::Value>*, v8::SideEffectType) const ./../../v8/src/api/api.cc:4959:7
#28 0x55a3cf54244d in electron::api::WebContentsView::Create(v8::Isolate*, gin_helper::Dictionary const&) ./../../electron/shell/browser/api/electron_api_web_contents_view.cc:76:32
#29 0x55a3cf35cfe5 in electron::api::BrowserWindow::BrowserWindow(gin::Arguments*, gin_helper::Dictionary const&) ./../../electron/shell/browser/api/electron_api_browser_window.cc:70:7
#30 0x55a3cf363b4d in electron::api::BrowserWindow::New(gin_helper::ErrorThrower, gin::Arguments*) ./../../electron/shell/browser/api/electron_api_browser_window.cc:483:14
#31 0x55a3cf36538c in Invoke<gin_helper::WrappableBase *(*const &)(gin_helper::ErrorThrower, gin::Arguments *), gin_helper::ErrorThrower, gin::Arguments *> ./../../base/bind_internal.h:393:12
#32 0x55a3cf36538c in MakeItSo<gin_helper::WrappableBase *(*const &)(gin_helper::ErrorThrower, gin::Arguments *), gin_helper::ErrorThrower, gin::Arguments *> ./../../base/bind_internal.h:637:12
#33 0x55a3cf36538c in RunImpl<gin_helper::WrappableBase *(*const &)(gin_helper::ErrorThrower, gin::Arguments *), const std::__1::tuple<> &> ./../../base/bind_internal.h:710:12
#34 0x55a3cf36538c in base::internal::Invoker<base::internal::BindState<gin_helper::WrappableBase* (*)(gin_helper::ErrorThrower, gin::Arguments*)>, gin_helper::WrappableBase* (gin_helper::ErrorThrower, gin::Arguments*)>::Run(base::internal::BindStateBase*, gin_helper::ErrorThrower&&, gin::Arguments*) ./../../base/bind_internal.h:692:12
#35 0x55a3cf3651b4 in Run ./../../base/callback.h:168:12
#36 0x55a3cf3651b4 in gin_helper::WrappableBase* gin_helper::internal::InvokeFactory<gin_helper::ErrorThrower, gin::Arguments*>(gin::Arguments*, base::RepeatingCallback<gin_helper::WrappableBase* (gin_helper::ErrorThrower, gin::Arguments*)> const&) ./../../electron/shell/common/gin_helper/constructor.h:43:19
SUMMARY: AddressSanitizer: heap-use-after-free (/home/builduser/project/src/out/Default/electron+0x1d151806)
Shadow bytes around the buggy address:
0x0c2480007170: 00 00 00 00 00 00 00 00 00 00 00 00 fa fa fa fa
0x0c2480007180: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
0x0c2480007190: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c24800071a0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
0x0c24800071b0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
=>0x0c24800071c0: fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd fd fd
0x0c24800071d0: fd fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa
0x0c24800071e0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
0x0c24800071f0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c2480007200: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa
0x0c2480007210: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
Shadow gap: cc
==551==ABORTING
```
</details>
|
https://github.com/electron/electron/issues/26540
|
https://github.com/electron/electron/pull/26680
|
662077f153e4f1457e45bda1a25d38c7b23163b2
|
ba629e31273470c4199fd9fe5928a32360091d35
| 2020-11-17T21:18:12Z |
c++
| 2020-11-25T20:29:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,488 |
["lib/browser/api/browser-window.ts", "spec-main/api-browser-window-spec.ts"]
|
BrowserWindow.fromBrowserView throws exception when there are multiple BrowserViews in a window
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
BrowserWindow.fromBrowserView throws an exception when a window has multiple BrowserViews:
```
'(node:19920) UnhandledPromiseRejectionWarning: Error: BrowserWindow have multiple BrowserViews, Use getBrowserViews()
instead\r\n' +
' at Function.i.fromBrowserView
```
* **Electron Version:**
* 10.1.4
* **Operating System:**
* Windows 10
* **Last Known Working Electron version:**
* None
### Expected Behavior
BrowserWindow.fromBrowserView should return the correct window regardless of the number of browserviews in it.
### Actual Behavior
An exception is thrown
### To Reproduce
GitHub Gist from Electron Fiddle:
https://gist.github.com/f2def961729571f8bbfbd89584693ee1
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26488
|
https://github.com/electron/electron/pull/26493
|
040ee66678afea7d53d6e3f66e695e6eb4c10b15
|
7c2ac6b7c180d0ae248540e9bf564a8e6dd207a2
| 2020-11-13T19:49:01Z |
c++
| 2020-11-17T19:12:02Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,482 |
["shell/browser/ui/message_box_gtk.cc"]
|
Message box missing a close button on Ubuntu
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
(I have found similar issues on Windows: https://github.com/electron/electron/issues/2293 and https://github.com/electron/electron/pull/2556)
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 --> 10.1.5
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 --> Ubuntu 20.04.1 LTS x86_64
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 --> N/A
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
The message box created by `dialog.showMessageBox` should contain a close button, e.g. on macOS
<img width="798" alt="截屏2020-11-13 下午5 24 49" src="https://user-images.githubusercontent.com/16272760/99056813-d5ca5180-25d5-11eb-843b-987f40a54941.png">
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Message box missing a close button on Ubuntu
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
-->
```sh
$ git clone https://github.com/stevenjoezhang/electron-quick-start -b master
$ npm install
$ npm start || electron .
```
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
```
:~/electron-quick-start$ screenfetch
./+o+-
yyyyy- -yyyyyy+ OS: Ubuntu 20.04 focal
://+//////-yyyyyyo Kernel: x86_64 Linux 5.4.0-53-generic
.++ .:/++++++/-.+sss/` Uptime: 1h 52m
.:++o: /++++++++/:--:/- Packages: 2103
o:+o+:++.`..```.-/oo+++++/ Shell: bash
.:+o:+o/. `+sssoo+/ Resolution: 3640x1920
.++/+:+oo+o:` /sssooo. DE: GNOME 3.36.4
/+++//+:`oo+o /::--:. WM: Mutter
\+/+o+++`o++o ++////. WM Theme: Adwaita
.++.o+++oo+:` /dddhhh. GTK Theme: Yaru [GTK2/3]
.+.o+oo:. `oddhhhh+ Icon Theme: ubuntu-mono-dark
\+.++o+o``-````.:ohdhhhhh+ Font: Cantarell 11
`:o+++ `ohhhhhhhhyo++os: Disk: 58G / 1.2T (6%)
.o:`.syhhhhhhh/.oo++o` CPU: Intel Core i7-9700 @ 8x 4.7GHz [42.0°C]
/osyyyyyyo++ooo+++/ GPU: Intel Corporation UHD Graphics 630 (Desktop 9 Series) (rev 02)
````` +oo+++o\: RAM: 6407MiB / 15794MiB
`oo++.
```
|
https://github.com/electron/electron/issues/26482
|
https://github.com/electron/electron/pull/26857
|
bc6fed5eda23bd935de56fa0e1c81a1aa91df7d8
|
9908cc363a9522937f8bb47579efae241525ed70
| 2020-11-13T09:36:41Z |
c++
| 2020-12-09T23:28:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,480 |
["chromium_src/BUILD.gn", "shell/browser/api/electron_api_web_contents.cc"]
|
Your app includes a version of an SDK from Electron that violates the App Store Review Guidelines.
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
### Issue Details
* **Electron Version:**
* 11.0.0-beta.22
### Rejection Email
<!-- Paste the contents of your rejection email here, censoring any private information such as app names.-->
Your app includes a version of an SDK from Electron that violates the App Store Review Guidelines. The version of the Electron SDK you are using in your app attempts to hide the use of private APIs. This is a violation Section 2.5.1 of the App Store Review Guidelines.
```
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__CFCopySystemVersionDictionary
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionBuildVersionKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionProductNameKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionProductVersionExtraKey
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/_CTFontDescriptorIsSystemUIFont
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__CFCopyServerVersionDictionary
• Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework/__kCFSystemVersionProductVersionKey
```
Guideline 2.5.1: Apps may only use public APIs.
Next Steps
To resolve this issue, please either remove the Electron SDK entirely from your app, or revise your app to utilize a corrected version of the Electron SDK.
### Additional Information
<!-- Add any other context about the problem here. -->
We need to use electron 11 to support apple silicon
|
https://github.com/electron/electron/issues/26480
|
https://github.com/electron/electron/pull/26491
|
900fbb99c9e71051c99c748f4b4139af5f384200
|
358ab79778396c533404652d94a3fc4be688b285
| 2020-11-13T02:37:05Z |
c++
| 2020-11-16T17:47:09Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,475 |
["shell/browser/api/electron_api_web_contents.cc"]
|
Segfault in electron::api::WebContents::DidStopLoading
|
Segfault in `base::SequenceCheckerImpl::CalledOnValidSequence()`.
Seen [in this CI run](https://app.circleci.com/pipelines/github/electron/electron/32652/workflows/d9f0c307-7021-453d-8bec-6b2eb9bd2bc2/jobs/718582).
```
Received signal 11 <unknown> 000000000000
0 Electron Framework 0x000000011ab9ece9 base::debug::CollectStackTrace(void**, unsigned long) + 9
1 Electron Framework 0x000000011aa931e3 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x000000011ab9ebb1 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2385
3 libsystem_platform.dylib 0x00007fff68b8c5fd _sigtramp + 29
4 ??? 0x0000000000000000 0x0 + 0
5 Electron Framework 0x000000011ab09bda base::SequenceCheckerImpl::CalledOnValidSequence() const + 42
6 Electron Framework 0x000000011ab25bd9 base::SupportsUserData::GetUserData(void const*) const + 25
7 Electron Framework 0x000000011526f1d2 electron::api::WebContents::DidStopLoading() + 50
8 Electron Framework 0x0000000119bc2401 content::WebContentsImpl::LoadingStateChanged(bool, content::LoadNotificationDetails*) + 2049
9 Electron Framework 0x0000000119bcab12 content::WebContentsImpl::DidStopLoading() + 178
10 Electron Framework 0x000000011983fcc8 content::FrameTreeNode::DidStopLoading() + 120
11 Electron Framework 0x0000000119937cd5 content::RenderFrameHostImpl::DidStopLoading() + 133
12 Electron Framework 0x0000000116b3d1fa content::mojom::FrameHostStubDispatch::Accept(content::mojom::FrameHost*, mojo::Message*) + 3610
13 Electron Framework 0x000000011b058953 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) + 931
14 Electron Framework 0x000000011b05c62f mojo::MessageDispatcher::Accept(mojo::Message*) + 191
15 Electron Framework 0x000000011b059e71 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) + 97
16 Electron Framework 0x000000011b0b8132 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread(mojo::Message) + 706
17 Electron Framework 0x000000011b0b4f8c base::internal::Invoker<base::internal::BindState<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message), scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>, mojo::Message>, void ()>::RunOnce(base::internal::BindStateBase*) + 140
18 Electron Framework 0x000000011ab2e20b base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 395
19 Electron Framework 0x000000011ab4d1b0 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) + 528
20 Electron Framework 0x000000011ab4ce08 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 168
21 Electron Framework 0x000000011abbede1 base::MessagePumpCFRunLoopBase::RunWork() + 65
22 Electron Framework 0x000000011abb4162 base::mac::CallWithEHFrame(void () block_pointer) + 10
23 Electron Framework 0x000000011abbe7af base::MessagePumpCFRunLoopBase::RunWorkSource(v
```
|
https://github.com/electron/electron/issues/26475
|
https://github.com/electron/electron/pull/26702
|
7cc571801c8e67d2c98c453b6decaa495a34c057
|
770e245de50c2b235b9da1efa38c2b9179b4dc12
| 2020-11-12T20:56:47Z |
c++
| 2020-11-30T05:03:07Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,460 |
["docs/api/structures/display.md", "shell/common/gin_converters/gfx_converter.cc", "spec-main/api-screen-spec.ts"]
|
Display Refresh Rate
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
Would it be possible to add the display refresh rate to the display object?
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
Adding Refresh rate to the display object https://www.electronjs.org/docs/api/structures/display
### Alternatives Considered
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
We did look at doing the FPS tracker described in a couple of places but doesn't work with windows that band over multiple displays.
Exec platform-specific executables/plist and parse response
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26460
|
https://github.com/electron/electron/pull/26472
|
f65db1df79a75841f552199ac4e4fcf6d0f08632
|
6f6c1b7ca60a5733da764d87c1b2926a9d1fe361
| 2020-11-12T10:33:20Z |
c++
| 2020-11-16T23:33:51Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,457 |
["docs/api/power-monitor.md", "lib/browser/api/power-monitor.ts", "shell/browser/api/electron_api_power_monitor.cc", "spec-main/api-power-monitor-spec.ts"]
|
Add powerMonitor IsOnBatteryPower method
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
[powerMonitor](https://www.electronjs.org/docs/api/power-monitor) triggers events when the computer goes on AC or on battery. But there's no way to know on app startup whether the system is already on battery or AC. An event isn't triggered until the state change happens.
I learned from [this comment](https://github.com/electron/electron/issues/18457#issuecomment-496628006) that Electron inherits powerMonitor from Chromium. Well, Chromium's `PowerMonitor` class has a [IsOnBatteryPower](https://chromium.googlesource.com/chromium/src/+/master/base/power_monitor/power_monitor.h#52) method.
### Proposed Solution
Add an `isOnBatteryPower` method to the [powerMonitor](https://www.electronjs.org/docs/api/power-monitor) module.
### Alternatives Considered
Alternatively, Electron could fire the `on-ac` or `on-battery` event on app startup. In fact, perhaps this should also be the case. (I verified it does not currently do this)
### Additional Information
n/a
|
https://github.com/electron/electron/issues/26457
|
https://github.com/electron/electron/pull/26494
|
8594b55deed57e43fc67ba212e1bd8a846c9c0af
|
a9924e1c32e8445887e3a6b5cdff445d93c2b18f
| 2020-11-12T06:45:12Z |
c++
| 2020-11-17T00:31:46Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,443 |
["shell/browser/electron_browser_main_parts.cc", "spec-main/chromium-spec.ts", "spec/fixtures/api/locale-check/main.js"]
|
LC_ALL set to invalid value
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 9.3.4
* **Operating System:**
* Arch Linux
* **Last Known Working Electron version:**
* 9.3.3
### Expected Behavior
```
❱ echo lang: $LANG lc_all: $LC_ALL
lang: en_US.UTF-8 lc_all:
❱ electron9 -i
> process.env.LC_ALL
undefined
```
### Actual Behavior
```
❱ echo lang: $LANG lc_all: $LC_ALL
lang: en_US.UTF-8 lc_all:
❱ electron9 -i
> process.env.LC_ALL
'en_US'
```
`en_US` is not a valid locale—it has to be `en_US.UTF-8`, however, Electron overrides this, even if `--lang=en_US.UTF-8` is passed or `LC_ALL` is set correctly when invoking Electron. With this invalid value, many C programs fail to run.
### To Reproduce
Run the above commands.
### Additional Information
Problem introduced in #26242
|
https://github.com/electron/electron/issues/26443
|
https://github.com/electron/electron/pull/26507
|
968cb970fc626635553ef6690ea9ffd19a2c94c0
|
cc136f2acd556e24d2a7c74f8a2a8194f5d120f8
| 2020-11-11T02:12:50Z |
c++
| 2020-11-18T02:13:01Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,355 |
["patches/chromium/render_widget_host_view_mac.patch", "shell/browser/native_browser_view_mac.mm"]
|
Cannot click a button in a BrowserView -- MouseEvents are captured by drag?
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** v11.0.0-beta.19
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:** macOS 11.0.1
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
I've created a minimal repro for you. Download the repo:
```sh
git clone [email protected]:ccorcos/electron-browser-view-drag.git
cd electron-browser-view-drag
git checkout side-browser-view
npm install
npm start
```
There's a the default index.html inside the window's webview, and what I did is add a `BrowserView` to render `search.html` and you'll notice that button is not clickable. However, you can drag the whole window when you click in there...
### Expected Behavior
Should be able to click the button inside a BrowserView.
|
https://github.com/electron/electron/issues/26355
|
https://github.com/electron/electron/pull/26496
|
cad2d8b4aa1dfab8af9234ed5b74e65f17093cc6
|
d97612ed21bd63843d88b78f8375f161d19e8317
| 2020-11-05T20:00:44Z |
c++
| 2020-11-17T04:41:37Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,300 |
["shell/browser/ui/inspectable_web_contents.cc"]
|
Open Dev Tools error: Uncaught TypeError: Cannot read property 'setDockSide' of undefined
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
`webContents.openDevTools();` produces error:
`[12703:1102/100312.745262:ERROR:CONSOLE(1)] "Uncaught TypeError: Cannot read property 'setDockSide' of undefined", source: devtools://devtools/bundled/devtools_app.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@1eb8474cd7e4fccfbfa8048eceda1eab8b4d394/&can_dock=true&toolbarColor=rgba(223,223,223,1)&textColor=rgba(0,0,0,1)&experiments=true (1)`
Opening dev tools via these methods also produces the same error:
* Right click background > Inspect element
* Ctrl-Shift-I
* **Electron Version:**
* 11.0.0-beta.18
* **Operating System:**
* Debian 10 Buster x64, KDE Plasma
* **Last Known Working Electron version:**
* 10.1.4
### Expected Behavior
Dev tools should open without error.
### Actual Behavior
Above error appears in the terminal.
### To Reproduce
Running this code will probably do it, although I'm opening a URL, but that shouldn't matter.
https://www.electronjs.org/docs/tutorial/quick-start#create-a-basic-application
### Additional Information
I need the beta because the stable version's node is too old.
|
https://github.com/electron/electron/issues/26300
|
https://github.com/electron/electron/pull/26474
|
358ab79778396c533404652d94a3fc4be688b285
|
ac35787bdb610338e0f50b5e7f756b3428481c4b
| 2020-11-02T08:15:31Z |
c++
| 2020-11-16T18:26:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,154 |
["shell/browser/native_window_views.cc", "shell/browser/native_window_views.h"]
|
Alt+Click Toggles Menu Bar
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v10.1.5
* **Operating System:**
* Ubuntu 20.04 x64
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Using <kbd>Alt</kbd> toggles the electron menu bar.
Holding <kbd>Alt</kbd> + any other key results in the electron menu bar **not** being toggled.
This logic should apply to mouse clicks. Holding <kbd>Alt</kbd> + any mouse click should result in the electron menu bar **not** being toggled.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Holding <kbd>Alt</kbd> + any mouse click results in the electron menu bar being toggled.
The menu toggle can be annoying when <kbd>Alt</kbd> + a mouse click is necessary for interacting with a site.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
1. Create a browser window with `autoHideMenuBar: true`
2. Hold <kbd>Alt</kbd> and right or left click. The electron menu bar is toggled.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
<!-- ### Screenshots -->
<!-- If applicable, add screenshots to help explain your problem. -->
<!-- ### Additional Information -->
<!-- Add any other context about the problem here. -->
This is my first issue on a big project, please let me know if I need to elaborate or fix any problems with this issue.
|
https://github.com/electron/electron/issues/26154
|
https://github.com/electron/electron/pull/29318
|
19dce8caa57b287cf71f581e15642f3d8212f6da
|
0444d74830df5fe06c921fb0fe0f2c9d8166092d
| 2020-10-25T17:38:34Z |
c++
| 2021-06-01T08:42:47Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,143 |
["patches/node/.patches", "patches/node/darwin_libuv_use_posix_spawn.patch"]
|
child_process spawn locks up renderer for 300 - 3000ms on signed app on macOS Big Sur
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.3
* 10.1.4
* 11.0.0-beta.13
* 11.0.0-beta.17
* 11.0.0-beta.19
* **Operating System:**
* macOS 11.0 Beta (20A5395g)
* macOS 11.0.1 Release (20B28)
* **Last Known Working Electron version:**
* works on macOS 10.15 Catalina
### Expected Behavior
If I call `require('child_process').spawn('ls', ['.'])`, it should return quickly (<10ms).
Measurable with:
```javascript
const { spawn } = require('child_process');
const start = Date.now();
spawn('ls', ['.']);
console.log(`spawn sync time: ${Date.now() - start}`);
```
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
If run in a renderer process with `nodeIntegration: true`, it takes 300+ ms. When used with `ffmpeg` (our real-world case), we're seeing it go as long as 2-3 seconds, which leads me to think it's related to the binary size/code signing?
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
To reproduce the bug, you'll need:
* macOS 11 Beta
* an Apple Developer code-signing certificate
Or you can download the version I code-signed: https://github.com/descriptinc/electron-spawn-perf-bug/releases/tag/1.0.0
Repo: https://github.com/descriptinc/electron-spawn-perf-bug
If you want to build/run it locally:
```sh
$ git clone https://github.com/descriptinc/electron-spawn-perf-bug.git
$ yarn install
$ yarn build
$ dist/mac/electron-spawn-bug.app/Contents/MacOS/electron-spawn-bug
```
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="912" alt="image" src="https://user-images.githubusercontent.com/21952/97063176-feb97280-1552-11eb-8ed3-023b427b4351.png">
### Additional Information
<!-- Add any other context about the problem here. -->
I'm not sure if this is an Electron, Electron Builder, or Big Sur bug.
|
https://github.com/electron/electron/issues/26143
|
https://github.com/electron/electron/pull/27026
|
0dcc623ab70e1301aa948f5911c1165e16a9ba73
|
f69c11105ff2a0f7b8778602de5eae4f83736c9b
| 2020-10-24T01:22:16Z |
c++
| 2021-02-08T15:25:04Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,116 |
["shell/browser/api/electron_api_browser_window.cc", "shell/browser/api/electron_api_browser_window_mac.mm", "shell/browser/native_browser_view_mac.h", "shell/browser/native_browser_view_mac.mm"]
|
BrowserView mouse capture region has incorrect bounds.
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** v10.1.4
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:** MacOS Big Sur
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
I created a full repro here: https://github.com/ccorcos/electron-browser-view-bounds
```
git clone [email protected]:ccorcos/electron-browser-view-bounds.git
cd electron-browser-view-bounds
npm install
npm start
```
You can also view the repro example here: https://github.com/ccorcos/electron-browser-view-bounds/blob/main/example.mov
Basically we can resize the view with the window using `view.setAutoResize({ width: true, height: true })` or manually with:
```
mainWindow.on('resize', () => {
const [width, height] = mainWindow.getSize()
view.setBounds({ x: 0, y: 0, width, height })
})
```
And the view does properly resize, but the mouse event capture region that gets passed on to the view remains the same size and fits into the bottom right region of the window.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26116
|
https://github.com/electron/electron/pull/26233
|
7f9b21daa0fd98f5311d87165b4ab2fe1231ad1d
|
e0216394722545a00fb7e47de653bb14fdbb909b
| 2020-10-22T21:26:20Z |
c++
| 2020-10-29T19:51:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,089 |
["docs/api/session.md", "shell/common/gin_converters/content_converter.cc", "spec-main/chromium-spec.ts"]
|
navigator.clipboard.read() requests 'unknown' permission
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 11.0.0-beta.13
* 10.0.1
* **Operating System:**
* Windows 10 (2004)
When calling [`navigator.clipboard.read()`](https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/read) in the renderer process, the session's permission handler receives a request for the permission "unknown".
### Expected Behavior
The permission handler should receive a request for "clipboard-read" permission.
### Actual Behavior
The permission handler receives a request for "unknown" permission.
### To Reproduce
Electron Fiddler: https://gist.github.com/5046d997fb4648edd08ad8a2645e84a0
|
https://github.com/electron/electron/issues/26089
|
https://github.com/electron/electron/pull/26172
|
07ee75b7450451d04aef12803186b321af9bfa7a
|
7f9b21daa0fd98f5311d87165b4ab2fe1231ad1d
| 2020-10-21T22:03:19Z |
c++
| 2020-10-29T18:22:32Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,077 |
["lib/common/parse-features-string.ts"]
|
window.open does not accept size values with "px" at the end
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.4
* **Operating System:**
* Windows
* **Last Known Working Electron version:**
* 9.3.2
### Expected Behavior
The window should open with the correct size
### Actual Behavior
The size is ignored
### To Reproduce
Use nativeWindowOpen and do: window.open("", "", "width=300px")
### Additional Information
This is working in chrome and firefox and was working in electron 9. If the event is intercepted via webContents.on("new-window") then the value is shown as NAN,
|
https://github.com/electron/electron/issues/26077
|
https://github.com/electron/electron/pull/26104
|
f61dedb7e5babef35f3aa81d71646c2983d08b6e
|
d16e61dc856f677b31c1120ae57b15ab9e76cfd4
| 2020-10-21T08:59:49Z |
c++
| 2020-11-02T09:55:59Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,055 |
["shell/common/node_bindings.cc", "spec-main/fixtures/crash-cases/setimmediate-renderer-crash/index.js", "spec-main/fixtures/crash-cases/setimmediate-renderer-crash/preload.js"]
|
setImmediate crash
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
8-,9-,10-
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
windows
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
no
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
console error
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
crash
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
example code
```
setImmediate(function () {
aaa
})
```
Expected Behavior:
aaa is not defined
Actual Behavior:
crashed
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/26055
|
https://github.com/electron/electron/pull/26365
|
ff33fa1970e6eef75c25b26b1e1c1126c3db8360
|
e6db49686b152384c25a3c98d53656eba14c22e0
| 2020-10-20T07:05:29Z |
c++
| 2020-11-10T17:17:58Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,045 |
["spec-main/api-web-contents-spec.ts", "spec-main/webview-spec.ts", "spec/webview-spec.js"]
|
did-change-theme-color tests are flaky on WOA
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* master
* **Operating System:**
* Windows on ARM
* **Last Known Working Electron version:**
* ?
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
`webContents module did-change-theme-color event is triggered with correct theme color` and `<webview> tag did-change-theme-color event emits when theme color changes` tests should pass on Windows on ARM.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
The tests timeout, eg:
```
not ok 397 <webview> tag did-change-theme-color event emits when theme color changes
Error: Timeout of 180000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\vsts-agent-win-x86-2.166.4\_work\1\s\src\electron\spec\webview-spec.js)
```
and
```
not ok 1344 webContents module did-change-theme-color event is triggered with correct theme color
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\vsts-agent-win-x86-2.166.4\_work\1\s\src\electron\spec-main\api-web-contents-spec.ts)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)
```
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Run the did-change-theme-color tests on WOA.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Additional Information
<!-- Add any other context about the problem here. -->
See https://github.visualstudio.com/electron/_test/analytics?definitionId=41&contextType=build for statistics on the flaky failures
|
https://github.com/electron/electron/issues/26045
|
https://github.com/electron/electron/pull/27739
|
0bc782dfe5dbcdaf5974cdd30e986b7ef418345a
|
399216580de88e48f29c56b633b1a380d5ea2203
| 2020-10-19T21:23:12Z |
c++
| 2021-02-16T22:21:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,016 |
["patches/chromium/printing.patch"]
|
Calling window.print() from BrowserView crashes starting in 11.0-beta12
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 11.0.0-beta.12
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:** macOS 10.15.7
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:** 11.0.0-beta.11
* <!-- (if applicable) e.g. 3.1.0 -->
### To Reproduce
```
git clone https://github.com/palmerAL/electron-quick-start.git
cd electron-quick-start
git checkout v11-print-crash
electron .
```
Crash report:
```
Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000038
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [25055]
VM Regions Near 0x38:
-->
__TEXT 0000000106f16000-0000000106f42000 [ 176K] r-x/r-x SM=COW /Users/USER/Documents/*/Electron.app/Contents/MacOS/Electron
Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 com.github.Electron.framework 0x000000010813bcf1 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 11484081
1 com.github.Electron.framework 0x000000010813b246 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 11481350
2 com.github.Electron.framework 0x0000000108138351 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 11469329
3 com.github.Electron.framework 0x00000001081385f8 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 11470008
4 com.github.Electron.framework 0x000000010d630cb3 v8::internal::compiler::ZoneStats::ReturnZone(v8::internal::Zone*) + 53628435
5 com.github.Electron.framework 0x000000010aa92d99 v8::internal::compiler::ZoneStats::ReturnZone(v8::internal::Zone*) + 7892729
6 com.github.Electron.framework 0x000000010d7166db v8::internal::compiler::ZoneStats::ReturnZone(v8::internal::Zone*) + 54569019
7 com.github.Electron.framework 0x0000000107ccf93a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6846458
8 com.github.Electron.framework 0x0000000107cd1ae6 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6855078
9 com.github.Electron.framework 0x0000000107cf96e4 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 7017892
10 com.github.Electron.framework 0x0000000107b98009 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5570249
11 com.github.Electron.framework 0x0000000107ba5112 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5623762
12 com.github.Electron.framework 0x0000000107ba4d0e v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5622734
13 com.github.Electron.framework 0x0000000107bd63a0 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5825120
14 com.github.Electron.framework 0x0000000107bd2f3a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5811706
15 com.github.Electron.framework 0x0000000107bd5d7f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5823551
16 com.apple.CoreFoundation 0x00007fff2d18cd52 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
17 com.apple.CoreFoundation 0x00007fff2d18ccf1 __CFRunLoopDoSource0 + 103
18 com.apple.CoreFoundation 0x00007fff2d18cb0b __CFRunLoopDoSources0 + 209
19 com.apple.CoreFoundation 0x00007fff2d18b83a __CFRunLoopRun + 927
20 com.apple.CoreFoundation 0x00007fff2d18ae3e CFRunLoopRunSpecific + 462
21 com.apple.HIToolbox 0x00007fff2bdb7abd RunCurrentEventLoopInMode + 292
22 com.apple.HIToolbox 0x00007fff2bdb77d5 ReceiveNextEventCommon + 584
23 com.apple.HIToolbox 0x00007fff2bdb7579 _BlockUntilNextEventMatchingListInModeWithFilter + 64
24 com.apple.AppKit 0x00007fff2a3fd039 _DPSNextEvent + 883
25 com.apple.AppKit 0x00007fff2a3fb880 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
26 com.apple.AppKit 0x00007fff2a3ed58e -[NSApplication run] + 658
27 com.github.Electron.framework 0x0000000107bd6966 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5826598
28 com.github.Electron.framework 0x0000000107bd5912 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5822418
29 com.github.Electron.framework 0x0000000107ba5691 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5625169
30 com.github.Electron.framework 0x0000000107b84c29 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 5491433
31 com.github.Electron.framework 0x000000010a532b54 v8::internal::compiler::ZoneStats::ReturnZone(v8::internal::Zone*) + 2256052
32 com.github.Electron.framework 0x0000000107829ca2 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1973090
33 com.github.Electron.framework 0x0000000107825769 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1955369
34 com.github.Electron.framework 0x00000001077f1a31 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1743089
35 com.github.Electron.framework 0x00000001077f1756 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1742358
36 com.github.Electron.framework 0x000000010742fc00 ElectronInitializeICUandStartNode + 5022784
37 com.github.Electron.framework 0x00000001074300d2 ElectronInitializeICUandStartNode + 5024018
38 com.github.Electron.framework 0x0000000106f65788 ElectronMain + 136
39 com.github.Electron 0x0000000106f1a53d 0x106f16000 + 17725
40 libdyld.dylib 0x00007fff671fccc9 start + 1
```
|
https://github.com/electron/electron/issues/26016
|
https://github.com/electron/electron/pull/25989
|
3219812c02a2d087041ab477db0620fea3243a59
|
c6a6f53c8dd8652436d8bef51f56ed13a01f603f
| 2020-10-17T07:37:55Z |
c++
| 2020-10-19T21:31:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 26,009 |
["script/lint.js"]
|
Some Build Linters Silently Fail
|
After poking around and finding several bugs in `lint.js`, here is the current status of the linters as far as I can tell. Making this issue so I can offload it from my brain and track the various PRs.
| | Python | Objc | Gn | Patches | JS/TS | C/C++ |
|:-:|:-:|:-:|:-:|:-:|:-:|:-:|
| Linux | #26253 | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: |
| Windows | #26253 | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | ✔️ | :heavy_check_mark: |
Status:
* The Python linter doesn't work across the board, needs several fixes to ensure it's working robustly.
* ~~Objc and C/C++ on Windows mostly work, just `cpplint` does not. Fix for that incoming shortly.~~
* ~~JS/TS linting on Windows doesn't work, and requires a more involved fix.~~
|
https://github.com/electron/electron/issues/26009
|
https://github.com/electron/electron/pull/26011
|
16caa542484cd0fb9dc5f4956fb1a4bc92d9684c
|
64504536faaa2d6ff0b07911e1f575df041a33f2
| 2020-10-17T01:13:06Z |
c++
| 2020-10-19T19:08:13Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,954 |
["shell/browser/electron_browser_main_parts.cc", "shell/browser/electron_browser_main_parts.h"]
|
ElectronBrowserMainParts wakes up every minute even if everything is idle
|
Found while investigating #25021
ElectronBrowserMainParts has a periodic timer that is used to trigger GC once a minute even on an idle system. While one wakeup per minute isn't bad, it's also been in there [since 2014](https://github.com/electron/electron/commit/4dd78480846557370dd53789d50e6cb0d6a81bcd) and may or may not still be necessary. It might be worth seeing what happens to memory overhead if this is disabled and/or triggered with a different mechanism.
```c++
// Start idle gc.
gc_timer_.Start(
FROM_HERE, base::TimeDelta::FromMinutes(1),
base::Bind(&v8::Isolate::LowMemoryNotification,
base::Unretained(js_env_->isolate())));
```
|
https://github.com/electron/electron/issues/25954
|
https://github.com/electron/electron/pull/25958
|
12e3c85081a3c65ed112e5ad7f96c4e1e97f820c
|
ae5de3d9c59191d87b6161983a891a31c7a20501
| 2020-10-14T22:52:33Z |
c++
| 2020-10-20T01:31:02Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,894 |
["shell/browser/net/electron_url_loader_factory.cc", "spec-main/api-protocol-spec.ts"]
|
`intercept*Protocol` Methods Break Redirect Handling Routines
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* `<=v10.1.3`
* **Operating System:**
* All
* **Last Known Working Electron version:**
* N/A
### Expected Behavior
Redirect handling for non-GET requests in scenarios where HTTP/HTTPS requests are intercepted using the `interceptHttpProtocol` and `interceptStreamProtocol` handlers should follow the same standards as non-intercepted requests. This should be true for `BrowserWindow`, `BrowserView` and `webview`. For example, the following is an example of `GET` request being redirected and the subsequent request thereafter:
```http
client> GET / HTTP/1.1
client> Host: foo.com
client>
client>
server> HTTP/1.1 302 OK
server> Location: http://foo.com/new
server> Content-Length: 0
server>
server>
client> GET /new HTTP/1.1
client> Host: foo.com
client>
client>
```
The same should be true for non-GET requests that result in redirections (with exceptions listed here: [https://developer.mozilla.org/en-US/docs/Web/HTTP/Redirections](https://developer.mozilla.org/en-US/docs/Web/HTTP/Redirections)):
```http
client> POST /form HTTP/1.1
client> Host: foo.com
client> Content-Length: 3
client> Content-Type: application/x-www-form-urlencoded
client>
client> a=b
server> HTTP/1.1 302 OK
server> Location: http://foo.com/new
server> Content-Length: 0
server>
server>
client> GET /new HTTP/1.1
client> Host: foo.com
client>
client>
```
Furthermore, the developer tools should display all the requests and responses that occurred (1 entry per request/response pair).
### Actual Behavior
Redirect handling for non-GET requests in scenarios where HTTP/HTTPS requests are intercepted using the `interceptHttpProtocol` and `interceptStreamProtocol` handlers are NOT following the same standards as non-intercepted requests. This is what happens, instead, with all 3xx responses:
```http
client> POST /form HTTP/1.1
client> Host: foo.com
client> Content-Length: 3
client> Content-Type: application/x-www-form-urlencoded
client>
client> a=b
server> HTTP/1.1 302 OK
server> Location: http://foo.com/new
server> Content-Length: 0
server>
server>
client> POST /new HTTP/1.1
client> Host: foo.com
client> Content-Length: 3
client> Content-Type: application/x-www-form-urlencoded
client>
client> a=b
```
This breaks interaction with a lot of websites; especially in scenarios where client authentication is being processed. For example, logging into Github.com successfully results in a 302 in scenarios where two factor authentication is required. The current implementation (without introducing some awful hacks) would break this interaction.
Furthermore, it appears that 3xx responses are expected to be resolved prior to returning data to the interceptor callback. This creates an inconsistency in the Developer Tools network tab where 3xx responses automatically resolve to the final response code (i.e. 200) if the interaction resulted in a successful redirection. Meaning, the redirect request, response pair is lost in the log.
### To Reproduce
TBD
### Screenshots
The following screenshots demonstrate the issue using a login sequence on GitHub. After initial login request, the server redirects me to the 2FA form which is at `/sessions/two-factor`. The following is what happens when I don't implement redirection detection hacks:
As can be seen, the redirect returns a 422 because the method and body remained unchanged during in the redirecting handling routine.
And the following demonstrates the proper result in the GUI with redirect detection hacks to modify the original request into a `GET` without a body, however, the developer tools network tab does not show an entry for the redirect/response pair to `/sessions/two-factor`:
As can be seen in the image above, the only request is to `/session` and the redirect gets handled internally and resolved to a 200 once the redirect has completed successfully.
### Additional Information
TBD
|
https://github.com/electron/electron/issues/25894
|
https://github.com/electron/electron/pull/26297
|
43341103394b63521cb0b4b5ab568d3ebd31c70e
|
5e7e0a4c7ef326e34930d5cb1218e7abd985aa35
| 2020-10-12T15:59:41Z |
c++
| 2021-01-19T10:06:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,811 |
["shell/browser/native_window_views.cc", "shell/browser/native_window_views.h", "shell/browser/native_window_views_win.cc"]
|
Will-move event listener newBounds parameter incorrect value
|
I have created simple window and add `will-move` listener. After moving window little bit down (few pixels only in vertical direction), `will-move` listener is called with `newBounds` parameter object, that contains incorrect values (`x`, `width`, `height` changed). Please look at simple demonstation:
Script:
```
mainWindow.once('will-move', (e, newBounds) => {
console.log('Window current bounds: ', mainWindow.getBounds());
console.log('Window newBounds', newBounds);
})
```
Result (logs in terminal after moving window little bit down (few pixels only in vertical direction)):
As you can see, here `x` property changed (but it should not, because i'm moving window only in vertical direction), `height` and `width` also changed (but it should not, because i'm not resizing window, i'm just moving it).
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.1
* **Operating System:**
* Windows 10 (version 1903, 18362.1082)
* **Last Known Working Electron version:**
* -
### Expected Behavior
`newBounds` parameter value should have `x`, `width` and `height` values same as in bounds returned by `mainWindow.getBounds()` but only `y` value should be different (because i'm moving window little bit down).
<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
As you can see, here after moving window little bit down (few pixels only in vertical direction), `x`, `width` and `height` properties values in `newBounds` is not same as the corresponding properties values in bounds object returned by `mainWindow.getBounds()`.
### To Reproduce
I have created demo branch from quick start repo: [demo commit](https://github.com/bohdanzhylavskyi/electron-quick-start/commit/fa8f3ef0713b6476eb18d47ad762fc47f2fb0f22). To reproduce please run application `npm start`, try to move window and look at terminal log.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
|
https://github.com/electron/electron/issues/25811
|
https://github.com/electron/electron/pull/29162
|
2806664bd0abf80551873d3cf0099081b95dc4e5
|
d518b6abc887787ac169270cbcf71c4626e2caaf
| 2020-10-07T19:55:18Z |
c++
| 2021-05-19T01:34:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,806 |
["docs/breaking-changes.md", "shell/browser/web_contents_preferences.cc", "shell/renderer/api/electron_api_context_bridge.cc", "shell/renderer/api/electron_api_context_bridge.h", "shell/renderer/api/electron_api_web_frame.cc", "spec-main/api-context-bridge-spec.ts"]
|
(webContents|webFrame).executeJavaScript don't marshal evaled result promises when worldSafeExecuteJavaScript:true
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.3
* **Operating System:**
* win7 sp1 x64
- without worldSafeExecuteJavaScript, `(webFrame|webContents).executeJavaScript('new Promise(resolve => setTimeout(() => resolve(2), 3000));')` works as expected; the executeJavaScript promise waits for the eval promise.
- in the case of webFrame the evaled promise is returned raw
- in the case of webContents the promise is marshaled
- with worldSafeExecuteJavaScript, both error with: "An object could not be cloned"
- webContents should continue marshaling promises, otherwise its an unnecessary breaking change
- webFrame should marshal promises for consistency with webContents
- the clone restriction would be on the promise resolve value
### To Reproduce
`(webFrame|webContents).executeJavaScript('new Promise(resolve => setTimeout(() => resolve(2), 3000));')`
|
https://github.com/electron/electron/issues/25806
|
https://github.com/electron/electron/pull/26889
|
78d4cb9f5c6cf98c08317996ccef7b4aec4be6cb
|
db08f08b88c7dca7b03a6d6ebe1e33be1cb473c9
| 2020-10-07T16:43:07Z |
c++
| 2021-01-26T22:23:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,781 |
["shell/browser/serial/serial_chooser_controller.cc", "shell/browser/serial/serial_chooser_controller.h"]
|
Segfault in SerialChooserController
|
Observed in CI: https://app.circleci.com/pipelines/github/electron/electron/30672/workflows/69ab6601-3698-411b-8906-93c9aca28870/jobs/675633
```
Received signal 11 SEGV_MAPERR 000000000048
0 Electron Framework 0x0000000116967079 base::debug::CollectStackTrace(void**, unsigned long) + 9
1 Electron Framework 0x0000000116861a13 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x0000000116966f41 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2385
3 libsystem_platform.dylib 0x00007fff68c005fd _sigtramp + 29
4 ??? 0x00000001026a2a00 0x0 + 4335479296
5 Electron Framework 0x0000000111155798 base::ObserverList<content::SerialDelegate::Observer, false, true, base::internal::CheckedObserverAdapter>::RemoveObserver(content::SerialDelegate::Observer const*) + 104
6 Electron Framework 0x0000000111158b20 electron::SerialChooserController::~SerialChooserController() + 256
7 Electron Framework 0x00000001111535fc electron::ElectronSerialDelegate::~ElectronSerialDelegate() + 124
8 Electron Framework 0x00000001110ed524 electron::ElectronBrowserClient::~ElectronBrowserClient() + 132
9 Electron Framework 0x00000001110ed5ee electron::ElectronBrowserClient::~ElectronBrowserClient() + 14
10 Electron Framework 0x0000000110fdbde7 ElectronMain + 151
```
|
https://github.com/electron/electron/issues/25781
|
https://github.com/electron/electron/pull/25969
|
6a0221297e767d4c2649d0069e917e27dd806500
|
87d3f3584c57974e7b0e1e2f5340081a4456b0f0
| 2020-10-05T22:13:07Z |
c++
| 2020-10-19T14:51:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,778 |
["shell/browser/ui/devtools_ui.cc"]
|
Pretty-print JS in devtools doesn't work
|
To repro:
1. Launch an Electron app (hello world/default fiddle will do)
2. Open DevTools
3. Find a minified JS file, e.g. renderer_init.js
4. Click the "Pretty Print" button in DevTools
Expected behavior:
The JS in the DevTools view is replaced with a pretty-printed version of the code
Actual behavior:
The JS in the DevTools view is unchanged
Bisected to https://github.com/electron/electron/compare/v11.0.0-nightly.20200721...v11.0.0-nightly.20200723
|
https://github.com/electron/electron/issues/25778
|
https://github.com/electron/electron/pull/25780
|
f31a1c9e4e56ee2f1147d1011e6b0000a9145912
|
a5ca25ba65ef0a60afbf7fee76a0bc5c19f49211
| 2020-10-05T21:15:32Z |
c++
| 2020-10-06T22:59:12Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,758 |
["shell/browser/net/proxying_url_loader_factory.cc"]
|
Every CORS (preflight) request fails when behind a proxy and listener attached
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.3
* **Operating System:**
* Windows
* **Last Known Working Electron version:**
* 8
### Expected Behavior
CORS preflight request should work normally
### Actual Behavior
The console logs net::ERR_FAILED and the request fails
### To Reproduce
We have a company proxy that seems to interfere for certain domains (requiring auth).
This issue only happens when attaching any kind of webRequest listener like onBeforeSendHeaders or onBeforeRequest. When the listener is attached the request fails with net::ERR_FAILED in the devtools console. The response headers (logged via webRequest listener) of the request will look like:
"statusLine":"HTTP/1.1 407 Proxy Authentication Required",
"statusCode":407,
"responseHeaders":{
"Connection":["close"],
"Content-Length":["827"],
"Proxy-Authenticate": ["NEGOTIATE", "NTLM", "BASIC realm=\"Auth_Seq_NTLM_to_ldap\""],
"Proxy-Connection":["close"]
},
This happens for any kind of cors request. i.e.:
fetch("some url", {method: "GET", mode: "cors", headers: {"Content-Type": "application/json"}});
I found this bug report: https://github.com/electron/electron/issues/22242 Maybe it is related?
In the pull request I can see that net::ERR_FAILED responses have been added for cors preflight:
https://github.com/electron/electron/pull/22407/commits/1f59f57908f5f6fae1845209e85300a01a1f264a
|
https://github.com/electron/electron/issues/25758
|
https://github.com/electron/electron/pull/29266
|
d4a1b411297ae7651441cf697b5251445c7a575c
|
507cbdc80a45580acfecf6c1c136471146910c83
| 2020-10-03T06:19:50Z |
c++
| 2021-06-21T05:06:52Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,753 |
["shell/common/api/electron_api_native_image.cc"]
|
nativeImage.getBitmap() allows use-after-free
|
`nativeImage.getBitmap()` allows accessing raw memory after it is freed.
```js
const { nativeImage } = require('electron')
const img = nativeImage.createFromDataURL('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAC0lEQVQYlWNgAAIAAAUAAdafFs0AAAAASUVORK5CYII=')
const bitmap = img.getBitmap()
console.log(bitmap)
setTimeout(() => {
gc()
console.log(bitmap)
}, 1000)
```
The above example produces the following output on my machine:
```
<Buffer 00 00 00 00>
<Buffer 50 b8 41 05>
```
The 2nd log is just an arbitrary chunk of memory. It's random each time I run the program.
|
https://github.com/electron/electron/issues/25753
|
https://github.com/electron/electron/pull/25782
|
0632d59da057e261f53265a8e9e1aec66783d763
|
f31a1c9e4e56ee2f1147d1011e6b0000a9145912
| 2020-10-02T19:38:18Z |
c++
| 2020-10-06T22:58:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,728 |
["shell/browser/native_browser_view_views.cc"]
|
BrowserView's setAutoResize no longer works (since Electron 10.1.3)
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 10.1.3
* **Operating System:** Windows 10
* **Last Known Working Electron version:** 10.1.2
### Expected Behavior
I expect that a BrowserView that's set up to auto resize, will do so
### Actual Behavior
No auto-resizing happens
### To Reproduce
1. start the app below
2. when the page loads in the browserview, resize the window
3. notice the black background. browser view doesn't resize
main.js:
```
const { app, BrowserWindow, BrowserView } = require('electron')
async function createWindow() {
const mainWindow = new BrowserWindow({ backgroundColor: "#000" });
const view = new BrowserView();
mainWindow.setBrowserView(view);
const contentBounds = mainWindow.getContentBounds();
view.setBounds({ x: 0, y: 0, width: contentBounds.width, height: contentBounds.height });
view.setAutoResize({ width: true, height: true });
await view.webContents.loadURL("https://google.com");
}
app.on('ready', createWindow)
```
|
https://github.com/electron/electron/issues/25728
|
https://github.com/electron/electron/pull/25951
|
87d3f3584c57974e7b0e1e2f5340081a4456b0f0
|
11ce55628e019fe8f7e935656174e6391263abf1
| 2020-10-01T19:31:25Z |
c++
| 2020-10-19T16:26:38Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,695 |
["shell/browser/mac/electron_application.mm"]
|
Electron apps based are not accessible via MacOS "Hover Text" unless Voice Over is turned on
|
**Issue: Electron apps based are not accessible via Hover Text unless Voice Over is turned on.**
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* All versions
* **Operating System:**
* MacOS Catalina
* **Last Known Working Electron version:**
* None
### Expected Behavior
Hover Text appears for the text in the Electron app
### Actual Behavior
Hover Text does not appear (but it does on Chromium)
### To Reproduce
1. Install any Electron app.
2. Launch the Electron app.
3. In MacOS System Preferences, go to Accessibility > Zoom, and enable Hover Text.
4. Hover over text in the Electron app.
Now observe what happens when we enable Voice Over...
5. Turn on Voice Over
6. Hover over text in the Electron app.
7. Observe that Hover Text shows for the text in the Electron app now that Voice Over is enabled
### Additional resources
https://support.apple.com/guide/mac-help/use-hover-text-mchlb203bc78/mac#:~:text=%20%20%201%20On%20your%20Mac%2C%20choose,menu%2C%20then%20choose%20a%20location.%20If...%20More%20
|
https://github.com/electron/electron/issues/25695
|
https://github.com/electron/electron/pull/26183
|
3d9d5679c535f84fd2aa86bb8ce88a7269f163aa
|
794940272b7b6ab04ac7f4bc1782c8ce534cc54c
| 2020-09-29T22:44:29Z |
c++
| 2020-10-29T03:24:37Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,649 |
["shell/browser/ui/views/win_frame_view.cc", "shell/browser/ui/views/win_frame_view.h", "shell/browser/ui/win/electron_desktop_window_tree_host_win.cc"]
|
mouse events in 'drag' and 'no-drag' unaligned after 10.1.1
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
10.1.2
* **Operating System:**
Windows 10 (2004)
* **Last Known Working Electron version:**
10.1.0
### Expected Behavior
mouse events aligned to the element
### Actual Behavior
elements with 'drag' and 'no-drag' inside a 'drag' region are 'vertically unaligned' by 8 pixels for mouse hover, click, etc when window is maximized
### To Reproduce
https://gist.github.com/rafma0/e7bc9ad86c17e79b25130b4399d72506
double click any appbar to maximize
move your mouse to the bottom of any button, it wont change color until you go 8 pixels up
you can also click and drag from 8 pixels outside the top of the middle or bottom appbar and it will unmaximize
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
|
https://github.com/electron/electron/issues/25649
|
https://github.com/electron/electron/pull/25940
|
1c44bb8e748bb174a1d45fee306f3a13a4f92c3a
|
20c6677a9c1651aaebccf6c0ad484d62db9ab97d
| 2020-09-27T06:17:16Z |
c++
| 2020-10-15T21:05:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,628 |
["shell/browser/api/electron_api_web_request.cc", "spec-main/api-web-request-spec.ts"]
|
data in other charset like GBK in Content-disposition cannot be encoded correctly
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* All
* **Operating System:**
* All
* **Last Known Working Electron version:**
* Unknown
### Expected Behavior
If the filename encoded other than UTF-8 in http header, the filename in Content-disposition should be returned correctly after webRequest.onHeadersReceived is called.
### Actual Behavior
If the filename in content-disposition encoded in GBK, before passing the http header to js, the head is converted in UTF-8 instead of doing converting code by charset. Therefore, when callback return, the filename become chaos.
### To Reproduce
When visiting a url, server responds a http header:
```
0x0000: 4854 5450 2f31 2e31 2032 3030 0041 6363 HTTP/1.1.200.Acc
0x0010: 6573 732d 436f 6e74 726f 6c2d 416c 6c6f ess-Control-Allo
0x0020: 772d 4f72 6967 696e 3a20 272a 2700 4163 w-Origin:.'*'.Ac
0x0030: 6365 7373 2d43 6f6e 7472 6f6c 2d41 6c6c cess-Control-All
0x0040: 6f77 2d4d 6574 686f 6473 3a20 504f 5354 ow-Methods:.POST
0x0050: 2c20 4745 542c 204f 5054 494f 4e53 0041 ,.GET,.OPTIONS.A
0x0060: 6363 6573 732d 436f 6e74 726f 6c2d 416c ccess-Control-Al
0x0070: 6c6f 772d 4865 6164 6572 733a 206f 7269 low-Headers:.ori
0x0080: 6769 6e2c 2078 2d63 7372 6674 6f6b 656e gin,.x-csrftoken
0x0090: 2c20 636f 6e74 656e 742d 7479 7065 2c20 ,.content-type,.
0x00a0: 6163 6365 7074 0058 2d41 7070 6c69 6361 accept.X-Applica
0x00b0: 7469 6f6e 2d43 6f6e 7465 7874 3a20 6170 tion-Context:.ap
0x00c0: 706c 6963 6174 696f 6e3a 6465 7665 6c6f plication:develo
0x00d0: 706d 656e 743a 3830 3837 0043 6f6e 7465 pment:8087.Conte
0x00e0: 6e74 2d64 6973 706f 7369 7469 6f6e 3a20 nt-disposition:.
0x00f0: 6174 7461 6368 6d65 6e74 3b20 6669 6c65 attachment;.file
0x0100: 6e61 6d65 3dcc eccc ecd5 e2d1 f95f 5f32 name=........__2
0x0110: 3032 3030 3932 345f 3034 3232 3533 3200 0200924_0422532.
0x0120: 436f 6e74 656e 742d 5479 7065 3a20 6170 Content-Type:.ap
0x0130: 706c 6963 6174 696f 6e2f 6f63 7465 742d plication/octet-
0x0140: 7374 7265 616d 0054 7261 6e73 6665 722d stream.Transfer-
0x0150: 456e 636f 6469 6e67 3a20 6368 756e 6b65 Encoding:.chunke
0x0160: 6400 4461 7465 3a20 5468 752c 2032 3420 d.Date:.Thu,.24.
0x0170: 5365 7020 3230 3230 2030 383a 3232 3a31 Sep.2020.08:22:1
0x0180: 3720 474d 5400 00 7.GMT..
```
When the onHeadersReceived is regitered, like the following:
```
session.defaultSession.webRequest.onHeadersReceived((details, callback) => {
callback({
cancel: false,
responseHeaders: details.responseHeaders,
statusLine: details.statusLine,
});
});
```
Then, the response header has been change to:
```
0x0000: 4854 5450 2f31 2e31 2032 3030 0041 6363 HTTP/1.1.200.Acc
0x0010: 6573 732d 436f 6e74 726f 6c2d 416c 6c6f ess-Control-Allo
0x0020: 772d 4865 6164 6572 733a 206f 7269 6769 w-Headers:.origi
0x0030: 6e2c 2078 2d63 7372 6674 6f6b 656e 2c20 n,.x-csrftoken,.
0x0040: 636f 6e74 656e 742d 7479 7065 2c20 6163 content-type,.ac
0x0050: 6365 7074 0041 6363 6573 732d 436f 6e74 cept.Access-Cont
0x0060: 726f 6c2d 416c 6c6f 772d 4d65 7468 6f64 rol-Allow-Method
0x0070: 733a 2050 4f53 542c 2047 4554 2c20 4f50 s:.POST,.GET,.OP
0x0080: 5449 4f4e 5300 4163 6365 7373 2d43 6f6e TIONS.Access-Con
0x0090: 7472 6f6c 2d41 6c6c 6f77 2d4f 7269 6769 trol-Allow-Origi
0x00a0: 6e3a 2027 2a27 0043 6f6e 7465 6e74 2d54 n:.'*'.Content-T
0x00b0: 7970 653a 2061 7070 6c69 6361 7469 6f6e ype:.application
0x00c0: 2f6f 6374 6574 2d73 7472 6561 6d00 436f /octet-stream.Co
0x00d0: 6e74 656e 742d 6469 7370 6f73 6974 696f ntent-dispositio
0x00e0: 6e3a 2061 7474 6163 686d 656e 743b 2066 n:.attachment;.f
0x00f0: 696c 656e 616d 653d efbf bdef bfbd efbf ilename=........
0x0100: bdef bfbd efbf bdef bfbd efbf bdef bfbd ................
0x0110: 5f5f 3230 3230 3039 3234 5f30 3432 3235 __20200924_04225
0x0120: 3332 0044 6174 653a 2054 6875 2c20 3234 32.Date:.Thu,.24
0x0130: 2053 6570 2032 3032 3020 3038 3a32 323a .Sep.2020.08:22:
0x0140: 3137 2047 4d54 0054 7261 6e73 6665 722d 17.GMT.Transfer-
0x0150: 456e 636f 6469 6e67 3a20 6368 756e 6b65 Encoding:.chunke
0x0160: 6400 582d 4170 706c 6963 6174 696f 6e2d d.X-Application-
0x0170: 436f 6e74 6578 743a 2061 7070 6c69 6361 Context:.applica
0x0180: 7469 6f6e 3a64 6576 656c 6f70 6d65 6e74 tion:development
0x0190: 3a38 3038 3700 00 :8087..
```
The original filename in Content-disposition has been lost forever.
### Additional Information
I've investigated the reason. It is because the call
gin::ConvertToV8(v8::Isolate::GetCurrent(), response_headers);
on the function HttpResponseHeadersToV8
in the source file electron_api_web_request.cc.
|
https://github.com/electron/electron/issues/25628
|
https://github.com/electron/electron/pull/25961
|
bb16c6f0be4bab57f87e854b43a1d6c3afe9ca50
|
84a42a050e7d45225e69df5bd2d2bf9f1037ea41
| 2020-09-25T07:04:51Z |
c++
| 2020-10-28T07:00:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,626 |
["DEPS", "patches/squirrel.mac/build_add_gn_config.patch", "spec-main/api-autoupdater-darwin-spec.ts"]
|
autoUpdater.quitAndInstall fails to relaunch on Mac OS 11 Big Sur
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
I wanted to post this in https://github.com/electron/electron/issues/24319 but the issue is locked.
[Related comment with more details](https://github.com/Squirrel/Squirrel.Mac/issues/251#issuecomment-698010499).
* **Electron Version:**
* v8.5.1
* **Operating System:**
* Mac OS 11 Big Sur Beta
* **Last Known Working Electron version:**
* n/a
### Actual Behavior
When restarting an upgraded electron application with [autoUpdater.quitAndInstall](https://www.electronjs.org/docs/api/auto-updater#autoupdaterquitandinstall), the application quits and upgrades successfully, but is NOT relaunched thereafter.
### Expected Behavior
The application should be launched after upgrading.
### To Reproduce
It's very hard for me to reproduce this issue because Squirrel.Mac requires that any MacOS app using auto-update is code-signed, and I can't figure out how to build Squirrel from source successfully so as to artificially remove that restriction.
If there are any guides available for building Squirrel.Mac + Electron together, i would be very thankful to hear about them.
### Additional Information
As mentioned [here](https://github.com/Squirrel/Squirrel.Mac/issues/251#issuecomment-698010499), there are two lines in the Squirrel install log normally present with earlier versions of MacOS which are missing on the Big Sur log.
```
2020-09-17 17:55:15.344 ShipIt[4099:100431] Application launched at file:///Applications/Whatever.app/
2020-09-17 17:55:15.344 ShipIt[4099:100431] ShipIt quitting
```
Those lines are logged from these locations:
https://github.com/Squirrel/Squirrel.Mac/blob/44468f858ce0d25c27bd5e674abfa104e0119738/Squirrel/ShipIt-main.m#L128
https://github.com/Squirrel/Squirrel.Mac/blob/44468f858ce0d25c27bd5e674abfa104e0119738/Squirrel/ShipIt-main.m#L145
My original plan was to add some extra logging statements in Squirrel.Mac's source code and use that to determine why those lines are missing, but i hit a brick wall trying to build Squirrel and Electron together from lack of documentation.
|
https://github.com/electron/electron/issues/25626
|
https://github.com/electron/electron/pull/25864
|
cbe751d349af90f88ed2507bd711aee12a936b3d
|
501900cdc6e06f0962e8857d5fda553ff1e3456f
| 2020-09-25T02:33:28Z |
c++
| 2020-10-13T02:01:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,613 |
["shell/browser/native_window_mac.mm"]
|
Frameless window show the trafficLight when exit full screen
|
Electron Version:
v9.0 or v7.1
Operating System:
macOS 10.15
Expected Behavior:
window.setSimpleFullScreen(true);
window.setSimpleFullScreen(false);
frameless window don't show the traffic light when leave full screen.
Actual Behavior:
frameless window should not have the traffic light, but switch full screen, the hidden traffic light appears.
|
https://github.com/electron/electron/issues/25613
|
https://github.com/electron/electron/pull/26096
|
2d49d820726c1f443e822bdba3810322efcf2ea4
|
6181c03df03f298779db071315103ff5a8bd99ab
| 2020-09-24T02:11:37Z |
c++
| 2020-10-23T06:04:53Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,595 |
["shell/browser/api/electron_api_desktop_capturer.cc", "shell/browser/api/electron_api_desktop_capturer.h"]
|
Electron desktopCapturer.getSources().then is not resolved
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.2
* **Operating System:**
* Ubuntu 18.04.5 LTS
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
`desktopCapturer.getSources().then` should be resolved
### Actual Behavior
`desktopCapturer.getSources().then` is not resolved after 1 minute
### To Reproduce
```js
const { app, desktopCapturer, screen } = require('electron');
const fs = require('fs')
const path = require('path')
function takeScreenshot() {
console.log('Gathering screens...')
const thumbSize = determineScreenShotSize()
const options = { types: ['screen'], thumbnailSize: thumbSize }
desktopCapturer.getSources(options).then((sources) => {
console.log('Sources received:'+sources.length);
sources.forEach(function (source) {
const sourceName = source.name.toLowerCase();
console.log(sourceName);
if ( ['entire screen', 'screen 1'].includes(sourceName)) {
const screenshotPath = path.join(app.getPath('pictures'), 'screenshot-' + new Date().toJSON() + '.png')
fs.writeFile(screenshotPath, source.thumbnail.toPNG(), function (error) {
if (error) return console.log(error)
console.log('Saved screenshot to: ' + screenshotPath);
})
}
})
}).catch(console.error);
}
function determineScreenShotSize() {
var screenSize = screen.getPrimaryDisplay().workAreaSize
return {
width: screenSize.width,
height: screenSize.height
}
}
setInterval(takeScreenshot, 15000);
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
```sh
git clone [email protected]:praveen-knackforge/electron-boilerplate.git -b screenshot
npm install
npm start || electron .
```
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
I used `desktopCapturer` API from the main process
|
https://github.com/electron/electron/issues/25595
|
https://github.com/electron/electron/pull/28273
|
b52ccc97264481fba6a092a24ba8b63058c964fb
|
4057e6b56e7d35575d5b46aaebeee91be05c5782
| 2020-09-23T14:50:26Z |
c++
| 2021-03-18T20:43:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,570 |
["shell/browser/ui/devtools_manager_delegate.cc"]
|
Remote Debugger does not work
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v10.1.2
* **Operating System:**
* Windows 10 (1809)
* **Last Known Working Electron version:**
* 5.0.1 (have not tested others)
### Expected Behavior
From a console, start electron with a remote-debugging-port. E.g.
```
$ electron --remote-debugging-port=9092
```
Now navigate to localhost:9092. We would expect to see devtools remotely attached.
### Actual Behavior
A scrambled mess appears. (output is shortened below)
```��Tmo�0��.......```
### To Reproduce
```
$ electron --remote-debugging-port=9092
```
### Additional Information
If you navigate to `http://localhost:9092/json/list`, and then scrape the URL out of `devtoolsFrontendUrl`, you can access them that way. Although this works, it is somewhat of a chore.
|
https://github.com/electron/electron/issues/25570
|
https://github.com/electron/electron/pull/25576
|
3503d3745b829ea589cfe9da0624ffa95f5d0bb8
|
881ac995da00c318e2ca9b81966e40162f51c6aa
| 2020-09-22T08:15:33Z |
c++
| 2020-09-23T18:47:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,506 |
["chromium_src/chrome/browser/certificate_manager_model.cc"]
|
electron crashes when calling importCertificate
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
10.1.2
9.3.1
8.5.1
* **Operating System:**
Ubuntu 18.04.05 x64
Also under Ubuntu 16, 14, 12, and Fedora
* **Last Known Working Electron version:**
7.3.3
### Expected Behavior
Calling importCertificate should call the provided function with an error code indicating whether the certificate was successfully imported.
### Actual Behavior
Calling `importCertificate` results in a crash (segmentation fault usually) under linux. This appears to happen across all versions of electron back to 7.x, on Ubuntu 12-18 and Fedora (tested in VirtualBox, and 18 on a bare-metal server). This appears to happen regardless of whether the cert and password are valid (or even specified).
### To Reproduce
```
./node_modules/.bin/electron -i <<< "const {app} = require('electron'); app.importCertificate({},console.log);"
# Segfault
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="1433" alt="Screen Shot 2020-09-16 at 3 13 51 PM" src="https://user-images.githubusercontent.com/1534774/93397859-4e5b9e80-f82f-11ea-9597-90156aac2221.png">
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/25506
|
https://github.com/electron/electron/pull/25523
|
ecb7f877a3ed578578a5f24ff1e526447597b264
|
137fc65e2f5ee0e468dbb3ed491b9ec81fb0ba96
| 2020-09-16T22:14:54Z |
c++
| 2020-09-19T02:10:41Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,498 |
["shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents.h"]
|
webContents.print() fails with 'No valid printers available'
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
10.1.1
* **Operating System:**
Ubuntu 20.04 + Linux 5.4.0-47-generic
* **Last Known Working Electron version:**
7.1.2
### Expected Behavior
`webContents.getPrinters()` returns one printer. Besides, the OS provides additional virtual devices.
`webContents.print()` should open the print dialog and show those devices for selection.
### Actual Behavior
`webContents.print()` fails silently; in the print callback, `failureReason` is 'No valid printers available'
### To Reproduce
Just run `webContents.print()`
Electron fiddle: https://gist.github.com/35c5067af8ec104f86bd0cdd4a95b1f5
### Screenshots
### Additional Information
Upgrading an app built on Electron 7.1.2 that had printing working before
|
https://github.com/electron/electron/issues/25498
|
https://github.com/electron/electron/pull/25515
|
ea76788b678193d7e1753f4fffab93c04ed89d52
|
15c30c56490fbfbe8be2165da3cb3d21a072577f
| 2020-09-16T20:19:50Z |
c++
| 2020-09-21T20:42:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,496 |
["shell/renderer/electron_renderer_client.cc", "spec-main/api-browser-window-spec.ts"]
|
Native multi-threaded N-API module callback not working in ES 9.x without allowRendererProcessReuse = false on Windows
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* Any 9.x or higher with `app.allowRendererProcessReuse = true` on Windows
* **Operating System:**
* Tested on Windows 10 and Mac OS Catalina
* **Last Known Working Electron version:**
* Any 8.x or any 9.x with `allowRendererProcessReuse = false` or any on the Mac.
### Expected Behavior
We have a native module that we converted to N-API in the last release which shipped with ES 8.x. This native module does device access and exposes a `EventEmiter` interface to JS running in the renderer. Native code is calling `emit` on the main thread by using a [UV Async handle](http://docs.libuv.org/en/v1.x/async.html). Yes, we called [`napi_get_uv_event_loop`](https://nodejs.org/api/n-api.html#n_api_napi_get_uv_event_loop). For the sake of troubleshooting this issue I have also completely replaced the UV code with [thread safe functions](https://nodejs.org/api/n-api.html#n_api_asynchronous_thread_safe_function_calls) (with a `call_js_cb` and empty `func`) with the same results. Also for troubleshooting I have removed all code from the async worker except [debug outputs](https://docs.microsoft.com/en-us/windows/win32/api/debugapi/nf-debugapi-outputdebugstringa).
On ES 8.x or with `allowRendererProcessReuse = false` notification of the JS works fine and I can see from the debug outputs that the device is detected and the notification worker is called immediately.
### Actual Behavior
On ES 9.x with `allowRendererProcessReuse = true` the async worker seems to be called very inconsistently. It is usually called at least once and then stops being called entirely. I can still see from the debug output that our native module is detecting the device events and the call to `uv_async_send` returns 0 (success) however the async worker is not run any more. Sometimes it is called once more when the app exits, and on one of my colleagues' machine it got called after minutes of delay, but then stopped working again.
During all of this the UI is responsive, JS is running, I can start the JS debugger and do stuff.
### To Reproduce
Please see above. Create a `uv_async` handle and call `uv_async_send` multiple times.
I have no example code I can publish at the moment, however if needed I can try to write a minimal example.
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Additional information
Please let me know if you need any further information.
For now we are releasing with `allowRendererProcessReuse = false` so it's not too urgent (for us). However it seems that the UV main loop stops spinning, which would be a serious issue.
I'm aware of #18397, that's one of the reasons we converted our native modules to N-API.
|
https://github.com/electron/electron/issues/25496
|
https://github.com/electron/electron/pull/25869
|
d57cd09f14c5ba1a3df65d5ddc2d10bf637244b4
|
e8166db9d7c93e53c5275471e8adef0faf54881b
| 2020-09-16T19:13:15Z |
c++
| 2020-10-13T16:19:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,491 |
["shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm"]
|
Crash in RedrawTrafficLights
|
First seen here: https://app.circleci.com/pipelines/github/electron/electron/29873/workflows/923c3f7e-6bea-47bf-93af-a19497f42cf0/jobs/658750
```
Received signal 11 SEGV_MAPERR 07fba4266cd8
0 Electron Framework 0x000000010a75eeb9 base::debug::CollectStackTrace(void**, unsigned long) + 9
1 Electron Framework 0x000000010a659533 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x000000010a75ed81 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2385
3 libsystem_platform.dylib 0x00007fff6a65f5fd _sigtramp + 29
4 ??? 0xf6a3c00070001002 0x0 + 17772259662645694466
5 Electron Framework 0x0000000104faaf35 electron::NativeWindowMac::RedrawTrafficLights() + 53
6 Electron Framework 0x000000010a6eeefb base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 411
7 Electron Framework 0x000000010a70dee7 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) + 519
8 Electron Framework 0x000000010a70db58 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 168
9 Electron Framework 0x000000010a77f651 base::MessagePumpCFRunLoopBase::RunWork() + 65
10 Electron Framework 0x000000010a7746e2 base::mac::CallWithEHFrame(void () block_pointer) + 10
11 Electron Framework 0x000000010a77f01f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
12 CoreFoundation 0x00007fff30468a54 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
13 CoreFoundation 0x00007fff304689f3 __CFRunLoopDoSource0 + 103
14 CoreFoundation 0x00007fff3046880d __CFRunLoopDoSources0 + 209
15 CoreFoundation 0x00007fff30467529 __CFRunLoopRun + 937
16 CoreFoundation 0x00007fff30466b23 CFRunLoopRunSpecific + 466
17 HIToolbox 0x00007fff2f088abd RunCurrentEventLoopInMode + 292
18 HIToolbox 0x00007fff2f0887d5 ReceiveNextEventCommon + 584
19 HIToolbox 0x00007fff2f088579 _BlockUntilNextEventMatchingListInModeWithFilter + 64
20 AppKit 0x00007fff2d6d3c99 _DPSNextEvent + 883
21 AppKit 0x00007fff2d6d24e0 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
22 AppKit 0x00007fff2d6c41ee -[NSApplication run] + 658
23 Electron Framework 0x000000010a78060c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
24 Electron Framework 0x000000010a77eb22 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 130
25 Electron Framework 0x000000010a70e71d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 349
26 Electron Framework 0x000000010a6c206c base::RunLoop::Run() + 956
27 Electron Framework 0x0000000109025f8b content::BrowserMainLoop::RunMainMessageLoopParts() + 203
28 Electron Framework 0x0000000109028352 content::BrowserMainRunnerImpl::Run() + 82
29 Electron Framework 0x0000000109022aab content::BrowserMain(content::MainFunctionParams const&) + 267
30 Electron Framework 0x0000000108e3896e content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 1406
31 Electron Framework 0x0000000108e383c3 content::ContentMainRunnerImpl::Run(bool) + 467
32 Electron Framework 0x000000010ce9225e service_manager::Main(service_manager::MainParams const&) + 3310
33 Electron Framework 0x0000000106d6f708 content::ContentMain(content::ContentMainParams const&) + 120
34 Electron Framework 0x0000000104e62486 ElectronMain + 134
35 Electron 0x0000000103d6f551 main + 289
36 libdyld.dylib 0x00007fff6a462cc9 start + 1
37 ??? 0x0000000000000024 0x0 + 36
[end of stack trace]
```
No reliable repro yet but will update when one is found. Potentially happening near this test? https://github.com/electron/electron/blob/0d2e9679600bc757eeb34356dc9c3779d0edccee/spec-main/api-native-theme-spec.ts#L91-L95
cc @MarshallOfSound
|
https://github.com/electron/electron/issues/25491
|
https://github.com/electron/electron/pull/25554
|
29c6864ee1c12bfbf4189fd5eb7f7c5e4ac26980
|
22c6c891bece410ee495a1d93a1d44fe431df084
| 2020-09-16T16:56:17Z |
c++
| 2020-09-23T01:53:32Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,427 |
["shell/browser/native_window.cc", "shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "shell/browser/ui/cocoa/electron_ns_window.mm", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm", "spec-main/api-browser-window-spec.ts", "spec-main/chromium-spec.ts"]
|
Exit from HTML fullscreen and enter native fullscreen leads to appearance of unclickable fantom window image.
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->v10.1.1
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->macOS 10.15.6
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->consecutive exit from HTML fullscreen and enter native fullscreen do not create unclickable and indestructible fantom window image.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->consecutive exit from HTML fullscreen and enter native fullscreen create unclickable and indestructible fantom window image.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Modified electron quick-start project:
[kirille/electron-fullscreen-fantom-issue](https://github.com/kirille/electron-fullscreen-fantom-issue)
on start, opens app in html-fullscreen, on click on Do Bug button, exit html-fullscreen, wait for exit, enter native fullscreen.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="1143" alt="Screenshot 2020-09-11 at 18 19 32" src="https://user-images.githubusercontent.com/6457945/92944398-97d97180-f45c-11ea-973f-58cf68c9dd42.png">
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/25427
|
https://github.com/electron/electron/pull/25470
|
7063b5ef2cfba729d217a4eb346ef39df514b389
|
503d24a4736e29273bc97cacc1b3abae1b7984be
| 2020-09-11T15:28:46Z |
c++
| 2021-04-21T14:56:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,426 |
["shell/browser/native_window.cc", "shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "shell/browser/ui/cocoa/electron_ns_window.mm", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm", "spec-main/api-browser-window-spec.ts", "spec-main/chromium-spec.ts"]
|
Native close window button disappears on mac after fullscreen off/on
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->v10.1.1
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->macOS 10.15.6
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->don't know
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
sequence of:
window.setFullScreen(false);
window.setFullScreen(true);
does not lead to missing native window control buttons.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
sequence of:
window.setFullScreen(false);
window.setFullScreen(true);
leads to missing native window control buttons.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
updated electron quick start app:
[no-native-window-buttons.zip](https://github.com/electron/electron/files/5209788/no-native-window-buttons.zip)
this will start app in fullscreen mode. Do Bug button just set fullscreen true and false consequentially.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="1920" alt="Screenshot 2020-09-11 at 17 53 12" src="https://user-images.githubusercontent.com/6457945/92941323-e7b63980-f458-11ea-9c28-695ca03c4afb.png">
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/25426
|
https://github.com/electron/electron/pull/25470
|
7063b5ef2cfba729d217a4eb346ef39df514b389
|
503d24a4736e29273bc97cacc1b3abae1b7984be
| 2020-09-11T15:02:47Z |
c++
| 2021-04-21T14:56:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,422 |
["shell/browser/api/electron_api_browser_window.cc", "spec-main/api-browser-window-spec.ts"]
|
Mac OS electron crashes on trying to close browser-window in 'leave-full-screen' event handler
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->v10.1.1
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->macOS 10.15.6
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->never
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->Window can be closed in 'leave-full-screen' event handler without app crash
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->app crashed on trying to close window inside 'leave-full-screen' event handler
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->just add to electron-quick-start project's main.js:
mainWindow.on('leave-full-screen', (event) => mainWindow.close());
steps to reproduce:
run app,
open window in fullscreen mode,
press exit from fullscreen native button.
Expected result: window exits fullscreen mode and closes. App remains running.
Actual result: app crashed with SIGSEGV.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/25422
|
https://github.com/electron/electron/pull/25468
|
2cfa41e6e024559a9f2be187dca6a15acbcd4704
|
a65f7f7d4217b4772c675f151bf17ff7cf07e4be
| 2020-09-11T14:25:37Z |
c++
| 2020-09-17T23:40:07Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,413 |
["shell/common/gin_converters/content_converter.cc", "spec-main/fixtures/crash-cases/webview-attach-destroyed/index.js"]
|
Segfault when closing a window while a webview is attaching
|
OS: macOS, Windows, probably Linux too
Version: v11.x, master
Last working version: v10.1.1
Repro: https://gist.github.com/3eac58d56eede968a9a9e86c899f16a7
```js
const { app, BrowserWindow } = require('electron')
app.whenReady().then(() => {
const w = new BrowserWindow({ show: true, webPreferences: { webviewTag: true } });
w.loadURL('data:text/html,<webview src="data:text/html,hi"></webview>');
app.on('web-contents-created', () => {
w.close();
});
})
```
Stack trace:
```
frame #1: 0x000000010038bf85 Electron Framework`IsVisible at native_window_mac.mm:713:19 [opt]
frame #2: 0x00000001003e8a20 Electron Framework`::AppendCommandLineSwitches() at web_contents_preferences.cc:423:42 [opt]
frame #3: 0x0000000100356dc6 Electron Framework`::AppendExtraCommandLineSwitches() at electron_browser_client.cc:791:26 [opt]
frame #4: 0x000000010494c39f Electron Framework`::AppendRendererCommandLine() at render_process_host_impl.cc:3269:34 [opt]
frame #5: 0x000000010494a08b Electron Framework`::Init() at render_process_host_impl.cc:1878:5 [opt]
frame #6: 0x00000001046a09aa Electron Framework`::InitRenderView() at render_frame_host_manager.cc:2356:40 [opt]
frame #7: 0x0000000104b75c87 Electron Framework`::AttachInnerWebContents() at web_contents_impl.cc:2039:25 [opt]
frame #8: 0x00000001003f0d5d Electron Framework`::AttachToIframe() at web_view_guest_delegate.cc:46:27 [opt]
[...]
```
<details>
<summary>Full stack trace</summary>
```
* thread #1, name = 'CrBrowserMain', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x1ace073f0)
* frame #0: 0x00007fff7289a029 libobjc.A.dylib`objc_msgSend + 41
frame #1: 0x000000010038bf85 Electron Framework`IsVisible at native_window_mac.mm:713:19 [opt]
frame #2: 0x00000001003e8a20 Electron Framework`::AppendCommandLineSwitches() at web_contents_preferences.cc:423:42 [opt]
frame #3: 0x0000000100356dc6 Electron Framework`::AppendExtraCommandLineSwitches() at electron_browser_client.cc:791:26 [opt]
frame #4: 0x000000010494c39f Electron Framework`::AppendRendererCommandLine() at render_process_host_impl.cc:3269:34 [opt]
frame #5: 0x000000010494a08b Electron Framework`::Init() at render_process_host_impl.cc:1878:5 [opt]
frame #6: 0x00000001046a09aa Electron Framework`::InitRenderView() at render_frame_host_manager.cc:2356:40 [opt]
frame #7: 0x0000000104b75c87 Electron Framework`::AttachInnerWebContents() at web_contents_impl.cc:2039:25 [opt]
frame #8: 0x00000001003f0d5d Electron Framework`::AttachToIframe() at web_view_guest_delegate.cc:46:27 [opt]
frame #9: 0x0000000100321df6 Electron Framework`::DispatchToCallback() [inlined] Run at callback.h:133:12 [opt]
frame #10: 0x0000000100321dab Electron Framework`::DispatchToCallback() [inlined] DispatchToCallback at function_template.h:228 [opt]
frame #11: 0x0000000100321d83 Electron Framework`::DispatchToCallback() at function_template.h:262 [opt]
frame #12: 0x0000000102871188 Electron Framework`::Call() at api-arguments-inl.h:158:3 [opt]
frame #13: 0x000000010286f59d Electron Framework`::HandleApiCallHelper<false>() at builtins-api.cc:111:36 [opt]
frame #14: 0x000000010286d89f Electron Framework`::Builtin_Impl_HandleApiCall() at builtins-api.cc:141:5 [opt]
frame #15: 0x000000010286d417 Electron Framework`::Builtin_HandleApiCall() at builtins-api.cc:129:1 [opt]
frame #16: 0x0000000103af887f Electron Framework`Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit + 63
frame #17: 0x00000001038a78d5 Electron Framework`Builtins_InterpreterEntryTrampoline + 213
frame #18: 0x00000001038a78d5 Electron Framework`Builtins_InterpreterEntryTrampoline + 213
frame #19: 0x00000001038a78d5 Electron Framework`Builtins_InterpreterEntryTrampoline + 213
frame #20: 0x00000001038858ff Electron Framework`Builtins_ArgumentsAdaptorTrampoline + 191
frame #21: 0x00000001038a78d5 Electron Framework`Builtins_InterpreterEntryTrampoline + 213
frame #22: 0x00000001038858ff Electron Framework`Builtins_ArgumentsAdaptorTrampoline + 191
frame #23: 0x00000001038a78d5 Electron Framework`Builtins_InterpreterEntryTrampoline + 213
frame #24: 0x00000001038a78d5 Electron Framework`Builtins_InterpreterEntryTrampoline + 213
frame #25: 0x00000001038858ff Electron Framework`Builtins_ArgumentsAdaptorTrampoline + 191
frame #26: 0x000000010389e09a Electron Framework`Builtins_JSEntryTrampoline + 90
frame #27: 0x000000010389de78 Electron Framework`Builtins_JSEntry + 120
frame #28: 0x00000001029c3780 Electron Framework`::Invoke() [inlined] Call at simulator.h:142:12 [opt]
frame #29: 0x00000001029c3775 Electron Framework`::Invoke() at execution.cc:368 [opt]
frame #30: 0x00000001029c2d3b Electron Framework`::Call() at execution.cc:462:10 [opt]
frame #31: 0x000000010279efb5 Electron Framework`::Call() at api.cc:4955:7 [opt]
frame #32: 0x000000010b839bf8 Electron Framework`::InternalMakeCallback() at callback.cc:189:21 [opt]
frame #33: 0x000000010b839e45 Electron Framework`::MakeCallback() at callback.cc:250:7 [opt]
frame #34: 0x000000010042c51d Electron Framework`::CallMethodWithArgs() at event_emitter_caller.cc:23:35 [opt]
frame #35: 0x0000000100317c03 Electron Framework`::EmitEvent<base::BasicStringPiece<std::string>, v8::Local<v8::Object> &, bool &, const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > &, blink::CloneableMessage>() at event_emitter_caller.h:51:10 [opt]
frame #36: 0x0000000100317af6 Electron Framework`::EmitCustomEvent<bool &, const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > &, blink::CloneableMessage>() [inlined] EmitWithEvent<bool &, const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > &, blink::CloneableMessage> at event_emitter_mixin.h:80:5 [opt]
frame #37: 0x0000000100317ac8 Electron Framework`::EmitCustomEvent<bool &, const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > &, blink::CloneableMessage>() at event_emitter_mixin.h:47 [opt]
frame #38: 0x0000000100301fc7 Electron Framework`::EmitWithSender<bool &, const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > &, blink::CloneableMessage>() at electron_api_web_contents.h:428:12 [opt]
frame #39: 0x0000000100302102 Electron Framework`::Invoke() at electron_api_web_contents.cc:1229:3 [opt]
frame #40: 0x00000001051047cb Electron Framework`::AcceptWithResponder() at api.mojom.cc:2539:13 [opt]
frame #41: 0x0000000100317666 Electron Framework`::AcceptWithResponder() at api.mojom.h:506:12 [opt]
frame #42: 0x0000000105fdeb27 Electron Framework`::HandleValidatedMessage() at interface_endpoint_client.cc:528:56 [opt]
frame #43: 0x0000000105fe28df Electron Framework`::Accept() at message_dispatcher.cc:46:24 [opt]
frame #44: 0x0000000105fe00a1 Electron Framework`::HandleIncomingMessage() at interface_endpoint_client.cc:356:22 [opt]
frame #45: 0x0000000105fe893c Electron Framework`::ProcessIncomingMessage() at multiplex_router.cc:953:42 [opt]
frame #46: 0x0000000105fe7dd5 Electron Framework`::Accept() at multiplex_router.cc:620:38 [opt]
frame #47: 0x0000000105fe291b Electron Framework`::Accept() at message_dispatcher.cc:41:19 [opt]
frame #48: 0x0000000105fd7cd4 Electron Framework`::DispatchMessage() at connector.cc:509:49 [opt]
frame #49: 0x0000000105fd87fe Electron Framework`::ReadAllAvailableMessages() at connector.cc:567:14 [opt]
frame #50: 0x0000000105fd8b1f Electron Framework`::CallDispatchNextMessageFromPipe() at connector.cc:536:3 [opt]
frame #51: 0x0000000105fd916b Electron Framework`::RunOnce() [inlined] Invoke<void (mojo::Connector::*)(), base::WeakPtr<mojo::Connector>> at bind_internal.h:498:12 [opt]
frame #52: 0x0000000105fd9101 Electron Framework`::RunOnce() [inlined] MakeItSo<void (mojo::Connector::*)(), base::WeakPtr<mojo::Connector>> at bind_internal.h:657 [opt]
frame #53: 0x0000000105fd90e6 Electron Framework`::RunOnce() [inlined] RunImpl<void (mojo::Connector::*)(), std::__1::tuple<base::WeakPtr<mojo::Connector> >, 0> at bind_internal.h:710 [opt]
frame #54: 0x0000000105fd90e6 Electron Framework`::RunOnce() at bind_internal.h:679 [opt]
frame #55: 0x0000000105acfafb Electron Framework`::RunTask() [inlined] Run at callback.h:99:12 [opt]
frame #56: 0x0000000105acfaa9 Electron Framework`::RunTask() at task_annotator.cc:142 [opt]
frame #57: 0x0000000105aeeae7 Electron Framework`::DoWorkImpl() at thread_controller_with_message_pump_impl.cc:332:23 [opt]
frame #58: 0x0000000105aee758 Electron Framework`::DoWork() at thread_controller_with_message_pump_impl.cc:252:36 [opt]
frame #59: 0x0000000105b60251 Electron Framework`RunWork at message_pump_mac.mm:358:54 [opt]
frame #60: 0x0000000105b552e2 Electron Framework`base::mac::CallWithEHFrame(void () block_pointer) at call_with_eh_frame_asm.S:39
frame #61: 0x0000000105b5fc1f Electron Framework`RunWorkSource at message_pump_mac.mm:334:3 [opt]
frame #62: 0x00007fff3c570b21 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
frame #63: 0x00007fff3c570ac0 CoreFoundation`__CFRunLoopDoSource0 + 103
frame #64: 0x00007fff3c5708d4 CoreFoundation`__CFRunLoopDoSources0 + 209
frame #65: 0x00007fff3c56f740 CoreFoundation`__CFRunLoopRun + 1272
frame #66: 0x00007fff3c56ebd3 CoreFoundation`CFRunLoopRunSpecific + 499
frame #67: 0x00007fff3b0c465d HIToolbox`RunCurrentEventLoopInMode + 292
frame #68: 0x00007fff3b0c439d HIToolbox`ReceiveNextEventCommon + 600
frame #69: 0x00007fff3b0c4127 HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 64
frame #70: 0x00007fff39734ba4 AppKit`_DPSNextEvent + 990
frame #71: 0x00007fff39733380 AppKit`-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
frame #72: 0x00007fff3972509e AppKit`-[NSApplication run] + 658
frame #73: 0x0000000105b6120c Electron Framework`DoRun at message_pump_mac.mm:691:5 [opt]
frame #74: 0x0000000105b5f722 Electron Framework`Run at message_pump_mac.mm:149:3 [opt]
frame #75: 0x0000000105aef31d Electron Framework`::Run() at thread_controller_with_message_pump_impl.cc:446:12 [opt]
frame #76: 0x0000000105aa2c6c Electron Framework`::Run() at run_loop.cc:124:14 [opt]
frame #77: 0x0000000104406b8b Electron Framework`::RunMainMessageLoopParts() [inlined] MainMessageLoopRun at browser_main_loop.cc:1440:12 [opt]
frame #78: 0x0000000104406afe Electron Framework`::RunMainMessageLoopParts() at browser_main_loop.cc:1005 [opt]
frame #79: 0x0000000104408f52 Electron Framework`::Run() at browser_main_runner_impl.cc:150:15 [opt]
frame #80: 0x00000001044036ab Electron Framework`::BrowserMain() at browser_main.cc:47:28 [opt]
frame #81: 0x000000010421956e Electron Framework`::RunServiceManager() [inlined] RunBrowserProcessMain at content_main_runner_impl.cc:525:10 [opt]
frame #82: 0x0000000104219515 Electron Framework`::RunServiceManager() at content_main_runner_impl.cc:997 [opt]
frame #83: 0x0000000104218fc3 Electron Framework`::Run() at content_main_runner_impl.cc:881:12 [opt]
frame #84: 0x0000000108272e5e Electron Framework`::Main() at main.cc:453:29 [opt]
frame #85: 0x0000000102150308 Electron Framework`::ContentMain() at content_main.cc:19:10 [opt]
frame #86: 0x00000001002428c6 Electron Framework`ElectronMain at electron_library_main.mm:23:10 [opt]
frame #87: 0x0000000100001551 Electron`main at electron_main.cc:274:10 [opt]
frame #88: 0x00007fff73c147fd libdyld.dylib`start + 1
```
</details>
|
https://github.com/electron/electron/issues/25413
|
https://github.com/electron/electron/pull/25431
|
1ba46a91b6a68bd9ca358f6a4d9f5f7cb0b968c3
|
ba55aaa53b26c5aed9d4b3f07a0ba795d33d6c91
| 2020-09-10T20:26:15Z |
c++
| 2020-09-16T19:25:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,405 |
["shell/renderer/electron_renderer_client.cc", "spec-main/api-browser-window-spec.ts"]
|
child_process exec callback not called (sometimes)
|
### Issue Details
* **Electron Version:**
* 9.2.1
* 10.1.1
* **Operating System:**
* Windows 64 and 32
* **Last Known Working Electron version:**
* 8.5.1
With version 9.2.1 and 10.1.1 it happens that _sometimes_ the child_process.exec callback is never called. It seems fine with version 8.5.1 (still testing)
We have this code that sometimes doesn't call the callback, meaning it never print 'finished' on Windows 32 and 64bits.
```
const exec = require('child_process').exec;
const execPromise = (cmd, execOpts) => {
return new Promise(function(resolve, reject) {
console.log('start')
exec(cmd, execOpts, (error, stdout, stderr) => {
console.log('finished')
if (error) {
error.stdout = stdout;
error.stderr = stderr
reject(error);
return;
}
resolve({stdout: stdout, stderr: stderr});
});
});
}
```
The command we exec is a Java command and we can see from the task manager the shell process is created and also the Java process, most of the times everything works as expected but sometimes **we can see the processes disappearing from the task manager and the callback is not called** (_finished_ is never printed in the console), causing a major issue with our application because we are not able to notify the user that the task has finished.
* Again, we see the processes disappearing from the task manager **and** the callback doesn't print anything
* It seems to be Windows specific, on Linux it doesn't happen.
* It's shouldn't be related to the cmd, it's always the same command with different args and, anyway, I'd expect the callback with an error if there's something wrong with cmd.
* It usually happens every 4 or 5 executions
* We downgraded to version 8.5.1 and it seems there issue is not there, we can run 20 tasks one after the other and we don't experience any issue
* Same thing happens with `util.promisify` of the require('child_process').exec;
Any idea?
|
https://github.com/electron/electron/issues/25405
|
https://github.com/electron/electron/pull/25869
|
d57cd09f14c5ba1a3df65d5ddc2d10bf637244b4
|
e8166db9d7c93e53c5275471e8adef0faf54881b
| 2020-09-10T16:08:40Z |
c++
| 2020-10-13T16:19:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,352 |
["chromium_src/BUILD.gn", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents.h", "shell/browser/ui/inspectable_web_contents.cc", "shell/browser/ui/inspectable_web_contents_delegate.h"]
|
(Devtools) Bug Color Picker CSS
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
Electron Version: All Version
Operating System: macOS 10.15.3
Last Known Working Electron version: Never
### Bug
The color picker in devtools does not work.
In devtools if you want to change the colors of the CSS code. When you click on a color a color picker is supposed to appear but it does not appear.
### Screenshots
<img width="1013" alt="Capture d’écran 2020-09-07 à 11 42 44" src="https://user-images.githubusercontent.com/70572698/92374841-988ea280-f100-11ea-96be-afc93f6dd645.png">
|
https://github.com/electron/electron/issues/25352
|
https://github.com/electron/electron/pull/29729
|
f00a2d062973327f87d8c7c368713d00b19009be
|
c8412478157c9a506927c3b29d9c73f278d431c4
| 2020-09-07T09:54:03Z |
c++
| 2021-06-17T13:42:51Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,348 |
["shell/browser/native_window_views.cc", "shell/browser/native_window_views_win.cc", "spec-main/api-browser-window-spec.ts"]
|
.isMaximized() always false with transparent:true
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
*I found one but it's been closed since 2017 athough updates are still happening on it either close this issue and reopen that or make this the new issue #9092*
### Issue Details
* **Electron Version:**
* v10.1.1
* **Operating System:**
* Windows 10 18363
* **Last Known Working Electron version:**
* unknown
### Expected Behavior
calling `isMaximized()` to respond if the window is maximized
### Actual Behavior
`isMaximized()` always returns false when transparent is set to true on BrowserWindow
### To Reproduce
https://gist.github.com/293ffab750b019714f12d8e1f203e611
### Additional Information
#9092 is a closed issue with people still reporting this problems but since it's closed I don't think admins are looking hence creating this issue.
|
https://github.com/electron/electron/issues/25348
|
https://github.com/electron/electron/pull/26586
|
acfbbe9869960d98a3b8b563e9bc62b9179c68a8
|
32d4c9ad85cb53f14007cd61460d0b0241cb8fbc
| 2020-09-07T01:14:48Z |
c++
| 2020-12-01T06:27:58Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,338 |
["docs/api/session.md", "shell/browser/api/electron_api_session.cc", "spec-main/api-session-spec.ts"]
|
calling setCertificateVerifyProc cancels requests in an unrelated session with net::ERR_CERT_DATABASE_CHANGED
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [ x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [ x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 --> 10.1.1
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 --> Windows 10
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 --> 6.1.10
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
The request to function normally except the certificate handler works as intended.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
When sending concurrent requests at once, the net request throws an error with net::ERR_CERT_DATABASE_CHANGED.
### To Reproduce
session.setCertificateVerifyProc((r, cb) => cb(0));
// Send net requests as normal
Soon enough, the code will start producing the error shown above.
|
https://github.com/electron/electron/issues/25338
|
https://github.com/electron/electron/pull/26517
|
7c2ac6b7c180d0ae248540e9bf564a8e6dd207a2
|
ead13791a8d5b4ded4c9a8183138ce9756c90ed4
| 2020-09-05T22:39:34Z |
c++
| 2020-11-17T19:12:50Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,314 |
["shell/renderer/electron_renderer_client.cc", "spec-main/api-browser-window-spec.ts"]
|
setImmediate works only on first page load, but not after subsequent reloads.
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->10.1.0
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->windows 10
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->unknown
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
`setImmediate` works the same regardless of whether you have loaded a page for the first time, or after a reload.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
`setImmediate` does execute on first page load, and does not after reloads.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
I've created an [electron fiddle gist](https://gist.github.com/affedc59a009210f18d3d396bb9cc425) which shows the problem. The essence is that on first page load, setImmediate properly executes the given function, however, after reloading the page, with the same code, the invocation gets lost internally and never happens.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
|
https://github.com/electron/electron/issues/25314
|
https://github.com/electron/electron/pull/25869
|
d57cd09f14c5ba1a3df65d5ddc2d10bf637244b4
|
e8166db9d7c93e53c5275471e8adef0faf54881b
| 2020-09-03T21:28:33Z |
c++
| 2020-10-13T16:19:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 25,287 |
["lib/browser/api/browser-window.ts", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents.h", "typings/internal-electron.d.ts"]
|
Missing focus event on app activation, for window created with show: false
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.1.1
* **Operating System:**
* macOS 10.15.4
We recently started launching as hidden on macOS (that is, `show: false` or `browserWindow.hide()` while loading the page, followed by `browserWindow.show()` when the dock icon is clicked). This results in some busted focus behavior on the first activation of the window. The second activation restores it.
### Expected Behavior
The guest page receives a `focus` event on the first activation of the app, when created with `show: false`.
### Actual Behavior
The guest page doesn't receive the first `focus` event. Subsequent activations do trigger a `focus` event.
### To Reproduce
[Electron Fiddle](https://gist.github.com/CharlieHess/c507468cd40630d04f58c6514100b997)
|
https://github.com/electron/electron/issues/25287
|
https://github.com/electron/electron/pull/25292
|
d305fe7d30a1c2f14d21f84842a696e874e53910
|
a6b9f9d8e56d2ea9bdcd37c1326b3a3890f92777
| 2020-09-02T19:00:02Z |
c++
| 2020-09-04T06:57:29Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.