status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,752 |
["shell/common/gin_converters/value_converter.cc"]
|
mate::Converter<base::ListValue>::FromV8
|
Sentry Issue: [ELECTRON-FIDDLE-2Z](https://sentry.io/organizations/electronjs/issues/1570755150/?referrer=github_integration)
```
EXC_BAD_ACCESS / KERN_INVALID_ADDRESS: Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
File "values.h", line 168, in mate::Converter<T>::FromV8
File "converter.h", line 341, in mate::internal::Invoker<T>::Invoker
File "function_template.h", line 241, in mate::internal::Dispatcher<T>::DispatchToCallback
File "api-arguments-inl.h", line 158, in v8::internal::FunctionCallbackArguments::Call
File "builtins-api.cc", line 111, in v8::internal::(anonymous namespace)::HandleApiCallHelper<T>
...
(46 additional frame(s) were not displayed)
```
|
https://github.com/electron/electron/issues/22752
|
https://github.com/electron/electron/pull/22753
|
232ca8af398c08aae5337bdc06d83efb9ac30362
|
f3fd40c2211ffd0fa73aa60d76a87b5d1f81dbfa
| 2020-03-18T20:18:23Z |
c++
| 2020-03-18T20:59:34Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,744 |
["patches/chromium/.patches", "patches/chromium/fix_undo_redo_broken_in_webviews.patch"]
|
Undo/Redo has no effect inside <webview>
|
Calling Cmd+Z (webContents.undo()) and Shift+Cmd+Z (webContents.redo()) have no effect inside a <webview> tag
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* Electron v8.1.1
* **Operating System:**
* macOS 10.15
### Expected Behavior
Calling Cmd+Z (webContents.undo()) and Shift+Cmd+Z (webContents.redo()) inside a <webview> tag will do the functionality that are defined for them i.e, undo and redo. Also by calling them from menu bar inside edit.
### Actual Behavior
Calling undo and redo inside <webview> has no effect. It gives no response. I remains unchanged after calling undo/redo it.
### To Reproduce
I use Electron fiddler to reproduce this issue and the gist link is https://gist.github.com/958fea4350204faf6778121b97af90f7
(no effect of undo and redo inside google search bar)
### Screenshots
|
https://github.com/electron/electron/issues/22744
|
https://github.com/electron/electron/pull/22911
|
22fb4f85e53581a6871d86e2f009ffad0772445a
|
2ce8dff175d8cf7a3761bb971b1b9bec8bdc07a8
| 2020-03-18T13:39:07Z |
c++
| 2020-04-02T17:05:05Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,741 |
["patches/chromium/disable_hidden.patch"]
|
page may freeze when background throttling is disabled
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x ] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x ] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.0.0-nightly.20200317
* **Operating System:**
* Windows 10 pro
* **Last Known Working Electron version:**
* didn't check
### Expected Behavior
Window's content doesn't freeze
### Actual Behavior
Renderer freezes (it's not possible to interact with the page)
### To Reproduce
Launch this app:
```
const { app, BrowserWindow } = require('electron')
function createWindow() {
let win = new BrowserWindow({
show: true,
x: 0,
y: 0,
width: 300,
height: 300,
});
win.loadURL('http://www.example.com');
}
function startTest() {
for (let i = 0; i < 5; ++i) {
createWindow();
}
const win = new BrowserWindow({
show: true
});
win.webContents.setBackgroundThrottling(false);
win.webContents.on('dom-ready', () => {
win.hide();
win.show();
});
win.loadURL('https://www.electronjs.org/');
}
app.on('ready', startTest)
```
and after page content is loaded try to scroll or interact with the page.
### Additional information
This bug is caused by Electron's patch `disable_hidden.patch`. If changes made by this patch in file `content/browser/renderer_host/render_widget_host_impl.cc` are removed issue doesn't reproduce.
When the bug occurs there is a DCHECK in `DelegatedFrameHost::ContinueDelegatedFrameEviction`:
`DCHECK(!client_->DelegatedFrameHostIsVisible());`
It is not visible as you don't support debug config anymore but I've checked this condition is not fulfilled.
|
https://github.com/electron/electron/issues/22741
|
https://github.com/electron/electron/pull/22832
|
74372d65aec2fa039487e07b0a9e8c4b1d33f2e1
|
f9acfc22520d984296237659ab300bbb48599835
| 2020-03-18T12:32:52Z |
c++
| 2020-03-26T19:54:11Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,671 |
["docs/api/dialog.md", "shell/browser/ui/message_box_mac.mm"]
|
message box can't be dismissed on mac
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.0.0-nightly.20200309
* **Operating System:**
* macOS 10.15.2
* **Last Known Working Electron version:**
* Probably never
### Expected Behavior
It's possible to dismiss message box created with `dialog.showMessageBoxSync`
### Actual Behavior
It's not possible to dismiss message box created with `dialog.showMessageBoxSync` if window which is not visible is provided as parameter (it is not possible to focus such box and clicking its ok button doesn't close it).
### To Reproduce
Run following app:
```const { app, dialog, BrowserWindow } = require('electron')
function createWindow() {
let win = new BrowserWindow({
show: false
});
dialog.showMessageBoxSync(win, { message: "Message" });
}
app.on('ready', createWindow)
```
|
https://github.com/electron/electron/issues/22671
|
https://github.com/electron/electron/pull/22672
|
1746ae8c35c3bad34d9617379316f2169af822db
|
c65f41dfbd7671ab15b64f9bb6a2c3c30fd1da1f
| 2020-03-12T14:35:11Z |
c++
| 2020-04-13T08:25:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,667 |
["shell/browser/ui/cocoa/electron_ns_window.mm", "spec-main/api-browser-window-spec.ts"]
|
app window can be placed behind menu bar on mac
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x ] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x ] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 10.0.0-nightly.20200309
* **Operating System:**
* macOS 10.15.2
* **Last Known Working Electron version:**
* Probably never
### Expected Behavior
It's not possible to place app window behind menu bar.
### Actual Behavior
It's possible to place app window behind menu bar making it impossible to drag when `enableLargerThanScreen` is set to true.
### To Reproduce
Launch following app:
```
const { app, BrowserWindow } = require('electron')
function createWindow() {
let win = new BrowserWindow({
width: 300,
height: 300,
enableLargerThanScreen: true
});
win.loadURL('http://www.example.com');
win.setBounds({x: 0, y: 0});
}
app.on('ready', createWindow)
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<img width="694" alt="Screenshot 2020-03-12 at 13 56 23" src="https://user-images.githubusercontent.com/50166166/76523957-986f5c00-6469-11ea-98b8-c80699c5f34b.png">
|
https://github.com/electron/electron/issues/22667
|
https://github.com/electron/electron/pull/22770
|
07cd70a37e62a0203e5d2cc9b2e25f04363a94cc
|
bdef77bad89f762ecb755c028bb2d166493b9f14
| 2020-03-12T12:32:49Z |
c++
| 2020-03-25T02:13:43Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,646 |
["shell/browser/native_window_mac.h", "shell/browser/native_window_mac.mm", "shell/browser/ui/cocoa/electron_ns_window_delegate.mm"]
|
auto re-enable maximizable even if set to false
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, with only a solution not working https://github.com/electron/electron/issues/11756.
### Issue Details
* **Electron Version:**
* 7.1.14
* **Operating System:**
* macOS 10.15.2
### Expected Behavior
`maximizable` property should always work.
### Actual Behavior
`maximizable` property will be ignored when some other properties are changed to the window or an alert is shown.
### To Reproduce
1.
From https://github.com/electron/electron/issues/11756.
> If i create a window like this:
>
> ```javascript
> win = new BrowserWindow({ title: "My App", backgroundColor:'#FF0000', maximizable:false, width: 400, height: 200, resizable: false})
> ```
>
> The window maximize button get disabled as wanted, but if we active the alert function inside
>
> the index.html file by putting `<script> alert("test"); </script>` inside the file then the maximize button get enabled again and we can use it again.
2.
Also, for other kinds of code, like
```javascript
var mainWindow = new BrowserWindow({
width: 800,
height: 600,
maximizable: false,
webPreferences: {
nodeIntegration: true
}
})
nativeTheme.on('updated', function theThemeHasChanged() {
if (nativeTheme.shouldUseDarkColors) {
if (mainWindow != null) {
mainWindow.setBackgroundColor('#393939');
}
} else {
if (mainWindow != null) {
mainWindow.setBackgroundColor('#fefefe');
}
}
})
```
can also produce this problem.
(how to: set dark mode / light mode, and then maximizable property is ignored.)
### Additional Information
These are *extremely old* resources that I found:
- https://github.com/electron/electron/pull/6736
- https://github.com/electron/electron/pull/18425
|
https://github.com/electron/electron/issues/22646
|
https://github.com/electron/electron/pull/22677
|
9583f7dabbef31c716a353364b599b3c3c2dd754
|
f4868c9a28392cd9cd78b37212b03d5d0000a69a
| 2020-03-11T03:12:34Z |
c++
| 2020-03-17T17:58:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,615 |
[".eslintrc.json", "lib/browser/api/menu.js", "lib/browser/api/net.js", "lib/browser/guest-view-manager.js", "lib/browser/utils.ts", "lib/renderer/api/remote.js", "spec/expect-helpers.js"]
|
Adding any Object prototype throws an error
|
* **Electron Version:**
v8.1.0
* **Operating System:**
macOS 10.15.3
* **Last Known Working Electron version:**
N/A
### Expected Behavior
I expect to be able to add an Object prototype without Electron throwing an error.
### Actual Behavior
Electron throws an error on startup, then otherwise seems to work fine.
### To Reproduce
Electron fiddle: https://gist.github.com/d3238b39f2b33493e0d7dbfc4c3b6afe
### Screenshots
A screenshot by another user already exists here (different code than in the Fiddle, though) on this old Stackoverflow Question: https://stackoverflow.com/questions/54179169/object-prototype-break-electron
|
https://github.com/electron/electron/issues/22615
|
https://github.com/electron/electron/pull/22616
|
f4868c9a28392cd9cd78b37212b03d5d0000a69a
|
5e4e50c5eb8ed89f111faf5b18cc2149560d7920
| 2020-03-09T21:23:51Z |
c++
| 2020-03-17T20:17:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,577 |
["patches/chromium/printing.patch"]
|
Printing with silent mode and GdiTextPrinting on Windows is broken
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* issue found on 7.1.14 and reproduced on 9.0.0-beta.5
* **Operating System:**
* Windows 10 Version 10.0.17763 Build 17763
* **Last Known Working Electron version:**
* -
### Expected Behavior
Text printing should be smooth when having GdiTextPrinting feature enabled regardless of using silent printing or not
### Actual Behavior
When using silent printing the GdiTextPrinting feature isn't used and the text comes out uneven
### To Reproduce
clone https://github.com/RobertBorg/electron-windows-gdi-text-print
run `npm install && npm run both`
### Additional Information
more info & possible solution available at https://github.com/RobertBorg/electron-windows-gdi-text-print/blob/master/Readme.md
|
https://github.com/electron/electron/issues/22577
|
https://github.com/electron/electron/pull/25679
|
077c37c6820608a940f956786bea1ae2a0ba5da6
|
e9876aecf9630af180647a9863f59c61d7c0fa48
| 2020-03-06T07:47:48Z |
c++
| 2020-09-30T18:42:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,554 |
["docs/api/app.md", "shell/browser/browser.h", "shell/browser/browser_linux.cc", "shell/browser/browser_mac.mm", "shell/browser/browser_win.cc"]
|
app.focus() not working
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
It would appear that `app.focus()` stopped working in Electron 6, and remains broken in Electron 8.
* **Electron Version:**
* 8.0.3
* **Operating System:**
* macOS
* **Last Known Working Electron version:**
* 5.0.13
### Expected Behavior
`app.focus()` should bring the application to the foreground.
### Actual Behavior
`app.focus()` does nothing.
### To Reproduce
Fiddle: https://gist.github.com/a772265b312329e3f3bc1feb7b6aff7d
1) Start this fiddle.
2) As soon as the window pops up, select another application so that Electron is in the background.
3) Within 5 seconds, the app will attempt to focus itself to no avail.
|
https://github.com/electron/electron/issues/22554
|
https://github.com/electron/electron/pull/22612
|
75cef848770d93f46c450553f5e67b8fa9dfda80
|
b724fbc0ed816828ece7bdcfb10583123c56e78c
| 2020-03-05T18:43:14Z |
c++
| 2020-03-11T16:07:01Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,541 |
["docs/api/client-request.md", "lib/browser/api/net.js", "shell/browser/api/electron_api_url_loader.cc", "spec-main/api-net-spec.ts"]
|
Net request replaces cookie header with session cookies
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* From v7.1.14 to v9.0.0-beta.5
* **Operating System:**
* macOS 10.15.3
* **Last Known Working Electron version:**
* v6.1.9
### Expected Behavior
A `net` request that sets a cookie using `request.setHeader` should include the specified header.
### Actual Behavior
Instead, when cookies from the session cookie jar are present, they are sent instead and the specified header is ignored.
### To Reproduce
Run this code:
```js
const electron = require('electron');
electron.app.on('ready', async () => {
await makeRequest();
// A long timeout is required for it to be reproducible when running this script on the first try, in a clean session
setTimeout(async () => {
console.log(await electron.session.defaultSession.cookies.get({}));
await makeRequest();
}, 10000);
});
function makeRequest() {
return new Promise(resolve => {
const request = electron.net.request({ url: 'https://www.twitter.com' });
request.setHeader('cookie', 'foo=bar');
request.on('close', resolve);
request.end();
});
}
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
When running the above code, all requests after the initial one shows a cookie header with this value, which reflects the value that is present in the session's cookies.
<img width="795" alt="image" src="https://user-images.githubusercontent.com/4505008/75946161-2be4d380-5e51-11ea-81ad-bb2769de8fe0.png">
### Additional Information
* To see the incorrect headers, you must inspect the network request in a proxy such as Fiddler.
* This was previously reported in #8223, fixed in #8258, but now seems to have been regressed.
* Also #8891 seems to be possibly implemented by accident now?
|
https://github.com/electron/electron/issues/22541
|
https://github.com/electron/electron/pull/22704
|
07a049ef1b555d5016e13f92c548c4dc40bdfd93
|
60bd52880f3887894b00665b7ea6262be8e18c67
| 2020-03-05T03:51:04Z |
c++
| 2020-03-20T22:56:02Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,521 |
["docs/api/incoming-message.md"]
|
inaccurate type for IncomingMessage.headers
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
8.0.3
* **Operating System:**
macos
### Expected Behavior
After #8117 was fixed, the shape of IncomingMessage.headers was changed, but we never updated the docs (and therefore the typescript definitions). It should now be a `Record<string, string | string[]>`
|
https://github.com/electron/electron/issues/22521
|
https://github.com/electron/electron/pull/22522
|
66c15721d8992d2c5ca21340dbb8510b1f0f7670
|
2fa499b6825533314bad4cb18a62ac9109860dac
| 2020-03-04T03:12:44Z |
c++
| 2020-03-18T02:32:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,513 |
["shell/browser/network_hints_handler_impl.cc", "shell/browser/network_hints_handler_impl.h"]
|
Navigating away from a page (possibly with an iframe) crashes Electron
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 9.0.0-beta.5
* **Operating System:**
* MacOS 10.15.3
* **Last Known Working Electron version:**
* Unknown
### Expected Behavior
Navigating to a page (afaict when it has an iframe) and then navigating away via "Back" should not crash Electron.
### Actual Behavior
Electron crashes with the following trace (with debug symbols):
<details>
```
Received signal 11 SEGV_MAPERR 058c0000057c
0 Electron Framework 0x0000000117ad7739 base::debug::CollectStackTrace(void**, unsigned long) + 9
1 Electron Framework 0x00000001179a8df3 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x0000000117ad75e1 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2385
3 libsystem_platform.dylib 0x00007fff652b242d _sigtramp + 29
4 ??? 0x00007f9d56173880 0x0 + 140313730955392
5 Electron Framework 0x0000000117231c1c network_hints::mojom::NetworkHintsHandlerStubDispatch::Accept(network_hints::mojom::NetworkHintsHandler*, mojo::Message*) + 1148
6 Electron Framework 0x0000000117ebc45f mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) + 991
7 Electron Framework 0x0000000117ec09fb mojo::MessageDispatcher::Accept(mojo::Message*) + 283
8 Electron Framework 0x0000000117ebdb08 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) + 120
9 Electron Framework 0x0000000117ec65cb mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) + 1451
10 Electron Framework 0x0000000117ec5a7a mojo::internal::MultiplexRouter::Accept(mojo::Message*) + 426
11 Electron Framework 0x0000000117ec09fb mojo::MessageDispatcher::Accept(mojo::Message*) + 283
12 Electron Framework 0x0000000117eb4184 mojo::Connector::DispatchMessage(mojo::Message) + 420
13 Electron Framework 0x0000000117eb5146 mojo::Connector::ReadAllAvailableMessages() + 710
14 Electron Framework 0x0000000117eb4d89 mojo::Connector::OnHandleReadyInternal(unsigned int) + 185
15 Electron Framework 0x0000000112819447 mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) + 103
16 Electron Framework 0x0000000117eea8fb mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) + 443
17 Electron Framework 0x0000000117eeaea1 void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::*&&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) + 193
18 Electron Framework 0x0000000117a3baf4 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 404
19 Electron Framework 0x0000000117a5d195 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) + 485
20 Electron Framework 0x0000000117a5ce8e base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() + 94
21 Electron Framework 0x0000000117af945f base::MessagePumpCFRunLoopBase::RunWork() + 63
22 Electron Framework 0x0000000117aed45a base::mac::CallWithEHFrame(void () block_pointer) + 10
23 Electron Framework 0x0000000117af8c3f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
24 CoreFoundation 0x00007fff2da15b21 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
25 CoreFoundation 0x00007fff2da15ac0 __CFRunLoopDoSource0 + 103
26 CoreFoundation 0x00007fff2da158d4 __CFRunLoopDoSources0 + 209
27 CoreFoundation 0x00007fff2da14740 __CFRunLoopRun + 1272
28 CoreFoundation 0x00007fff2da13bd3 CFRunLoopRunSpecific + 499
29 HIToolbox 0x00007fff2c56965d RunCurrentEventLoopInMode + 292
30 HIToolbox 0x00007fff2c56939d ReceiveNextEventCommon + 600
31 HIToolbox 0x00007fff2c569127 _BlockUntilNextEventMatchingListInModeWithFilter + 64
32 AppKit 0x00007fff2abd9ba4 _DPSNextEvent + 990
33 AppKit 0x00007fff2abd8380 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
34 AppKit 0x00007fff2abca09e -[NSApplication run] + 658
35 Electron Framework 0x0000000117afa5fc base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
36 Electron Framework 0x0000000117af8592 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 130
37 Electron Framework 0x0000000117a5db22 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 242
38 Electron Framework 0x0000000117a0f12a base::RunLoop::Run() + 826
39 Electron Framework 0x00000001164296a1 content::BrowserMainLoop::RunMainMessageLoopParts() + 225
40 Electron Framework 0x000000011642bdf6 content::BrowserMainRunnerImpl::Run() + 102
41 Electron Framework 0x000000011642625d content::BrowserMain(content::MainFunctionParams const&) + 269
42 Electron Framework 0x00000001161c7f06 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 998
43 Electron Framework 0x00000001161c7af3 content::ContentMainRunnerImpl::Run(bool) + 483
44 Electron Framework 0x000000011a1031d9 service_manager::Main(service_manager::MainParams const&) + 3017
45 Electron Framework 0x000000011441da48 content::ContentMain(content::ContentMainParams const&) + 120
46 Electron Framework 0x00000001127d5946 ElectronMain + 134
47 Electron 0x0000000106f22071 main + 289
48 libdyld.dylib 0x00007fff650b97fd start + 1
49 ??? 0x0000000000000002 0x0 + 2
```
</details>
Using lldb I was able to trace the crash to https://github.com/electron/electron/blob/efc11563e8562e87ed56e1e961434730334e9826/shell/browser/network_hints_handler_impl.cc#L33
I'm unable to get lldb to emit any frame variables, but based on some test accesses I added to the code, it appears that `render_frame_host_` is no longer valid.
### To Reproduce
This does not occur frequently, but it seems to happen most when I go "back" from a page with an iframe. I am able to reproduce using the following fiddle:
```js
const {app, BrowserWindow} = require('electron')
let mainWindow
function createWindow () {
mainWindow = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
nodeIntegration: false,
sandbox: true
}
})
mainWindow.loadURL('https://www.google.com/search?q=js+time+interval+format')
mainWindow.on('closed', function () {
mainWindow = null
})
}
app.on('ready', createWindow)
app.on('window-all-closed', function () {
if (process.platform !== 'darwin') {
app.quit()
}
})
app.on('activate', function () {
if (mainWindow === null) createWindow()
})
```
Steps to recreate:
- Wait for the google results
- Click on the second result (html-goodies.com)
- Wait for the page to finish loading (some iframes will load on the right side)
- Go back (use the devtools to enter `history.back()`)
Electron should crash during the "back" navigation.
|
https://github.com/electron/electron/issues/22513
|
https://github.com/electron/electron/pull/23271
|
c438b93f18e041069efa9e41ee6756631b6f05e1
|
94eb4ce38eb4ecda7b76d1e6584a364bd3f15d69
| 2020-03-03T23:05:04Z |
c++
| 2020-05-01T07:37:01Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,490 |
["docs/api/web-frame.md"]
|
WebFrame#executeJavascriptInIsolatedWorld is not rejecting on error
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v9.0.0-beta.5 x86
* **Operating System:**
* win7 x64 sp1
### Expected Behavior
The returned promise should reject if js eval fails.
### Actual Behavior
The promise resolves with `undefined`.
### To Reproduce
1. run this app
```js
'use strict';
const {app, BrowserWindow} = require('electron');
let win;
app.on('ready', async () => {
win = new BrowserWindow({
width: 1440,
height: 900,
useContentSize: true,
webPreferences: {
nodeIntegration: true,
},
});
win.webContents.openDevTools({mode: 'right'});
win.loadURL('about:blank');
});
```
2. eval the following in the js console
```js
try {const r = await require('electron').webFrame.executeJavaScriptInIsolatedWorld(999, [{code: 'thisShouldProduceAnError()'}]); console.log(`executeJavaScriptInIsolatedWorld resolved with ${r}, instead of rejecting`);} catch {}
```
|
https://github.com/electron/electron/issues/22490
|
https://github.com/electron/electron/pull/23653
|
7b55a70a3673fc76ee6ff9e50577ca72536606fd
|
ce77e3327ce4a418b5c7fe3482c160ba275a9524
| 2020-03-02T23:41:24Z |
c++
| 2020-05-21T15:56:22Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,482 |
["docs/api/session.md"]
|
Still cannot figure out how to use setSpellCheckerDictionaryDownloadURL in Electron 8.0.2
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v8.0.2
* **Operating System:**
* Arch Linux
* **Last Known Working Electron version:**
* N/A
### Expected Behavior
Electron to download dictionary files from custom mirror after setting setSpellCheckerDictionaryDownloadURL to the *directory path* containing dictionary files in `hunspell_dictionaries.zip`
### Actual Behavior
It doesn't download the files, and spellchecking doesn't work.
### To Reproduce
Please see sample code at `https://github.com/heronhaye/electron-8-spellchecker-test`. Specifically,
```js
win.webContents.session.setSpellCheckerDictionaryDownloadURL(
'https://modalduality.keybase.pub/dictionaries/'
)
```
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
@MarshallOfSound helped me figure out that I was using this function incorrectly before, but now I believe I am using it correctly, but still cannot get it to work. Is there an working example base path somewhere on the internet that I can test it on?
|
https://github.com/electron/electron/issues/22482
|
https://github.com/electron/electron/pull/22483
|
d731a676f5c06544d9943e75212770b62e7a38fa
|
748a917ffdc238782ab427b442f785b575ddc16a
| 2020-03-02T20:44:34Z |
c++
| 2020-03-02T22:15:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,440 |
["shell/browser/native_window_views_win.cc", "spec-main/api-browser-window-spec.ts"]
|
Frameless minimum sized window is not restored to previous size after maximize and unmaximize
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.2 - 9.0.0-beta.3 (and presumably later versions until this bug is fixed)
* **Operating System:**
* Windows 10 pro (1909)
* **Last Known Working Electron version:**
* 7.1.1
### Preconditions
* Window is frameless
* Window has minimum size
* Window size is minimum size
### Expected behavior
* Window is maximized
* Window is unmaximized
* Window has the same size as before the maximization
### Actual Behavior
* Window is maximized
* Window is unmaximized
* Window is slightly higher and wider than before the maximization
### To Reproduce
```
git clone -b frameless-minsize-maximize-unmaximize-bug https://github.com/christian-judt/electron-quick-start.git
cd electron-quick-start
npm install
npm start
```
### Additional Information
* This seems to be a reappearing problem. (for the last occurence see #13533)
* A similar problem with "minimize-restore" instead of "maximize-unmaximize" has appeared in Electron Version 7.1.10. (see #22393)
### Other maybe related issues
* [Windows] Frameless window size increase on a maximize, unmaximize sequence #2498
* Windows: Restore (after minimize) to wrong window size #7951
* maximize, minimize, restore incorrect size #15702
* Electron 6 - restore after minimize has wrong window size #19816
|
https://github.com/electron/electron/issues/22440
|
https://github.com/electron/electron/pull/25051
|
5ed34607511bead8e810f5c6ec8432db00546f06
|
cd3fadc2fb512161b55f721a599eacc79df4680f
| 2020-02-28T10:40:14Z |
c++
| 2020-08-24T20:32:08Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,414 |
["shell/browser/electron_browser_client.cc", "shell/browser/electron_browser_context.cc", "shell/browser/electron_browser_context.h", "spec-main/crash-spec.ts", "spec-main/fixtures/crash-cases/early-in-memory-session-create/index.js"]
|
session.fromPartition crashes the app since 9.x
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* `9.0.0-beta.1` -- terminates silently
* `9.0.0-beta.3` -- terminates silently
* master (`10.0.0-nightly.20200225`) -- crashes with `[448015:0227/160341.082069:FATAL:dependency_manager.cc(144)] Check failed: false. Attempted to access a context that was ShutDown()`
* **Operating System:**
* Arch Linux current
* **Last Known Working Electron version:**
* 8.0.2
### Expected Behavior
I don't expect `session.fromPartition()` to terminate or crash the app.
I expect that I will be able to use that session later.
Note that attempting to use the returned session does not prevent the crash/termination.
### Actual Behavior
The app terminates in 9.0.0-beta.* and crashes on master.
Crash log:
```
[449023:0227/160822.369119:FATAL:dependency_manager.cc(144)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again.
#0 0x561dae402699 base::debug::CollectStackTrace()
#1 0x561dae32b223 base::debug::StackTrace::StackTrace()
#2 0x561dae3412a4 logging::LogMessage::~LogMessage()
#3 0x561daf440189 DependencyManager::AssertContextWasntDestroyed()
#4 0x561daf43f98c KeyedServiceBaseFactory::AssertContextWasntDestroyed()
#5 0x561db29d3adb BrowserContextKeyedServiceFactory::GetContextToUse()
#6 0x561daf441280 KeyedServiceFactory::GetServiceForContext()
#7 0x561dae031d95 extensions::BrowserContextKeyedAPIFactory<>::BuildServiceInstanceFor()
#8 0x561db29d3a45 BrowserContextKeyedServiceFactory::BuildServiceInstanceFor()
#9 0x561daf44131a KeyedServiceFactory::GetServiceForContext()
#10 0x561daf43fea9 DependencyManager::CreateContextServices()
#11 0x561db29d3727 BrowserContextDependencyManager::DoCreateBrowserContextServices()
#12 0x561daac4b583 electron::ElectronBrowserContext::ElectronBrowserContext()
#13 0x561daac4cddc electron::ElectronBrowserContext::From()
#14 0x561daabe645f electron::api::Session::FromPartition()
#15 0x561daabe8609 (anonymous namespace)::FromPartition()
#16 0x561daabe88b7 gin_helper::Invoker<>::DispatchToCallback<>()
#17 0x561daabe87ab gin_helper::Dispatcher<>::DispatchToCallback()
#18 0x561dabe90a30 v8::internal::FunctionCallbackArguments::Call()
#19 0x561dabe8f0d1 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#20 0x561dabe8d0da v8::internal::Builtin_Impl_HandleApiCall()
#21 0x561dabe8cb89 v8::internal::Builtin_HandleApiCall()
#22 0x561dace0c03f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit
Received signal 6
#0 0x561dae402699 base::debug::CollectStackTrace()
#1 0x561dae32b223 base::debug::StackTrace::StackTrace()
#2 0x561dae4021b0 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f306a24c800 (/usr/lib/libpthread-2.31.so+0x147ff)
#4 0x7f3068c27ce5 __GI_raise
#5 0x7f3068c11857 __GI_abort
#6 0x561dae400f65 base::debug::BreakDebugger()
#7 0x561dae34174e logging::LogMessage::~LogMessage()
#8 0x561daf440189 DependencyManager::AssertContextWasntDestroyed()
#9 0x561daf43f98c KeyedServiceBaseFactory::AssertContextWasntDestroyed()
#10 0x561db29d3adb BrowserContextKeyedServiceFactory::GetContextToUse()
#11 0x561daf441280 KeyedServiceFactory::GetServiceForContext()
#12 0x561dae031d95 extensions::BrowserContextKeyedAPIFactory<>::BuildServiceInstanceFor()
#13 0x561db29d3a45 BrowserContextKeyedServiceFactory::BuildServiceInstanceFor()
#14 0x561daf44131a KeyedServiceFactory::GetServiceForContext()
#15 0x561daf43fea9 DependencyManager::CreateContextServices()
#16 0x561db29d3727 BrowserContextDependencyManager::DoCreateBrowserContextServices()
#17 0x561daac4b583 electron::ElectronBrowserContext::ElectronBrowserContext()
#18 0x561daac4cddc electron::ElectronBrowserContext::From()
#19 0x561daabe645f electron::api::Session::FromPartition()
#20 0x561daabe8609 (anonymous namespace)::FromPartition()
#21 0x561daabe88b7 gin_helper::Invoker<>::DispatchToCallback<>()
#22 0x561daabe87ab gin_helper::Dispatcher<>::DispatchToCallback()
#23 0x561dabe90a30 v8::internal::FunctionCallbackArguments::Call()
#24 0x561dabe8f0d1 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#25 0x561dabe8d0da v8::internal::Builtin_Impl_HandleApiCall()
#26 0x561dabe8cb89 v8::internal::Builtin_HandleApiCall()
#27 0x561dace0c03f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit
r8: 0000000000000000 r9: 00007ffd4147e670 r10: 0000000000000008 r11: 0000000000000246
r12: 00007ffd4147e8d0 r13: aaaaaaaaaaaaaaaa r14: 00007ffd4147f938 r15: 00007ffd4147e8d0
di: 0000000000000002 si: 00007ffd4147e670 bp: 00007ffd4147e8c0 bx: 00007f3067929c40
dx: 0000000000000000 ax: 0000000000000000 cx: 00007f3068c27ce5 sp: 00007ffd4147e670
ip: 00007f3068c27ce5 efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
```
### To Reproduce
```js
const { BrowserWindow, app, session } = require('electron')
console.log(process.versions)
app.on('ready', () => {
const foo = session.fromPartition('foo')
const window = new BrowserWindow({
webPreferences: {
// session: foo
}
})
window.webContents.loadURL('about:blank')
window.show()
})
```
|
https://github.com/electron/electron/issues/22414
|
https://github.com/electron/electron/pull/22772
|
a3ee61f963c9d4dd9d11f96410f03f1d32258259
|
21900fe4f40414e9fabb2a0556597a032002ca9f
| 2020-02-27T13:10:09Z |
c++
| 2020-05-08T18:17:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,411 |
["lib/browser/api/net.ts", "shell/browser/api/electron_api_url_loader.cc", "spec-main/api-net-spec.ts", "typings/internal-ambient.d.ts"]
|
Cant't set referer header when using `net.request`
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
8.0.1
* **Operating System:**
macOS 10.14.6
### Expected Behavior
Send a request with `referer` header. It's worked with Node's `http/https` module, but failed when I change to `net.request`.
### Actual Behavior
No referer header
### To Reproduce
```js
ses.protocol.interceptStreamProtocol("https", (request, callback) => {
const resp = sendRequestWithNetRequest({
url: request.url,
method: request.method,
headers: {
...request.headers,
referer: request.referrer // only referrer has been ignored!!
}
})
callback({
data: resp.body,
statusCode: resp.statusCode,
headers: resp.headers
});
});
```
|
https://github.com/electron/electron/issues/22411
|
https://github.com/electron/electron/pull/23386
|
0a481242f08c8fe0cae1609b4ece6f8e9536c266
|
9d851b879189de05ef5888138d13029f450a07fa
| 2020-02-27T05:54:30Z |
c++
| 2020-05-20T17:28:38Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,409 |
["docs/api/web-contents.md", "shell/browser/api/electron_api_web_contents.cc"]
|
Print crash in Electron 8.0.2, Mac OS Catalina 10.15.3
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
App crashes when call `webContents.print()`
* **Electron Version:**
8.0.2
* **Operating System:**
Mac OS Catalina 10.15.3 (19D76)
* **Last Known Working Electron version:**
Electron 6 did not crash when print but has other bugs with printing
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
App should not crash
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
App crashes
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
Can be reproduced with this Fiddle
https://gist.github.com/1aced5931b191c07adb6a111f937a4e1
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/22409
|
https://github.com/electron/electron/pull/22418
|
efc11563e8562e87ed56e1e961434730334e9826
|
e8c628ecdf0b7e03a4dcdb52c4d188204f717aac
| 2020-02-27T04:11:51Z |
c++
| 2020-03-04T02:20:31Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,400 |
["docs/development/testing.md", "script/lib/utils.js"]
|
error running tests on windows
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* * master (f1fb5130404d41b012c4140b53618234b3df9168)
* **Operating System:**
* win7 x64 sp1
I followed the directions for building headers for testing in the [testing doc](https://github.com/electron/electron/blob/master/docs/development/testing.md)
```
ninja -C out\Testing-x86 third_party\electron_node:headers
cd out\Testing-x86
mkdir gen\node_headers\Release
copy electron.lib gen\node_headers\Release\node.lib
```
```text
C:\electron-build\electron-gn\src\electron>npm run test
> [email protected] test C:\electron-build\electron-gn\src\electron
> node ./script/spec-runner.js
Triggering runners: main, remote, native
npx: installed 1 in 1.884s
yarn install v1.15.2
warning package.json: No license field
warning [email protected]: No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
error C:\electron-build\electron-gn\src\electron\spec\node_modules\is-valid-window: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments:
Directory: C:\electron-build\electron-gn\src\electron\spec\node_modules\is-valid-window
Output:
C:\electron-build\electron-gn\src\electron\spec\node_modules\is-valid-window>if not defined npm_config_node_gyp (node "C:\Users\user1\AppData\Local\Programs\node
\current\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Users\user1\AppData\Local\Programs\node\npm\no
de_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
gyp: C:\electron-build\electron-gn\src\out\undefined\gen\node_headers\common.gypi not found (cwd: C:\electron-build\electron-gn\src\electron\spec\node_modules\i
s-valid-window) while reading includes of binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (C:\Users\user1\AppData\Local\Programs\node\npm\node_modules\npm\node_modules\node-gyp\lib\configure.js:351:16)
gyp ERR! stack at ChildProcess.emit (events.js:210:5)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "C:\\Users\\user1\\AppData\\Local\\Programs\\node\\current\\node.exe" "C:\\Users\\user1\\AppData\\Local\\Programs\\node\\npm\\node_modules\\npm\\
node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\electron-build\electron-gn\src\electron\spec\node_modules\is-valid-window
gyp ERR! node -v v12.13.1
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
✗ Failed to yarn install in 'C:\electron-build\electron-gn\src\electron\spec'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test: `node ./script/spec-runner.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\user1\AppData\Roaming\npm-cache\_logs\2020-02-26T19_39_55_132Z-debug.log
```
The one obvious problem that jumps out is
```
gyp: C:\electron-build\electron-gn\src\out\undefined\gen\node_headers\common.gypi not found
```
Is it trying to refer to `C:\electron-build\electron-gn\src\out\Testing-x86\gen\node_headers\include\node\common.gypi` ?
|
https://github.com/electron/electron/issues/22400
|
https://github.com/electron/electron/pull/22412
|
36f982aee2368c0c73b9f1b448c6c1f54099555b
|
02cf5baa323ea0cb783e8ccd58857c35fb32f0c3
| 2020-02-26T20:35:13Z |
c++
| 2020-02-27T19:32:09Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,393 |
["shell/browser/native_window_views.h", "shell/browser/native_window_views_win.cc", "spec-main/api-browser-window-spec.ts"]
|
Frameless minimum sized window is not restored to previous size after minimize and restore
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.10 - 9.0.0-beta.3 (and presumably later versions until this bug is fixed)
* **Operating System:**
* Windows 10 pro (1909)
* **Last Known Working Electron version:**
* 7.1.9
### Preconditions
* Window is frameless
* Window has minimum size
* Window size is minimum size
### Expected behavior
* Window is minimized
* Window is restored
* Window has the same size as before the minimization
### Actual behavior
* Window is minimized
* Window is restored
* Window is slightly higher and wider than before the minimization
### To Reproduce
```
git clone -b frameless-minsize-minimize-restore-bug https://github.com/christian-judt/electron-quick-start.git
cd electron-quick-start
npm install
npm start
```
### Additional Information
* A similar problem with "maximize-unmaximize" instead of "minimize-restore" has appeared in Electron Version 7.1.2. (see #22440)
### Maybe related issues
* Windows: Restore (after minimize) to wrong window size #7951
* Frameless minimum sized window is not restored to previous size after maximize and unmaximize #13533
* maximize, minimize, restore incorrect size #15702
* Electron 6 - restore after minimize has wrong window size #19816
|
https://github.com/electron/electron/issues/22393
|
https://github.com/electron/electron/pull/25014
|
902184385030064131b74a98466f846784d6ce64
|
52d7afa4efbdaee6fd3d3b3497d0ed6cb17298e6
| 2020-02-26T11:15:34Z |
c++
| 2020-08-19T19:34:15Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,381 |
["patches/chromium/.patches", "patches/chromium/feat_add_support_for_overriding_the_base_spellchecker_download_url.patch", "shell/browser/api/electron_api_session.cc"]
|
Unable to get setSpellCheckerDictionaryDownloadURL to download dictionary
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v8.0.1
* **Operating System:**
* Arch Linux
* **Last Known Working Electron version:**
* N/A (new feature)
### Expected Behavior
I expect that when I use `win.webContents.session.setSpellCheckerDictionaryDownloadURL`, Electron downloads `hunspell_dictionaries.zip` and spell checks input boxes.
### Actual Behavior
Dictionary file is not downloaded to `~/.config/Electron/Dictionaries` and no spellchecking is done.
### To Reproduce
See demo repo at https://github.com/heronhaye/electron-8-spellchecker-test. Relevant excerpt below.
```js
function createWindow () {
win = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
nodeIntegration: true,
spellcheck: true
}
})
win.webContents.session.setSpellCheckerDictionaryDownloadURL(
'https://modalduality.keybase.pub/hunspell801.zip'
)
win.loadFile('index.html')
win.webContents.openDevTools()
win.on('closed', () => {
win = null
})
}
```
When I comment out the call to setSpellCheckerDictionaryDownloadURL, everything works as expected.
I verified that the sha256 hash of the zip file at the URL (`bc64c413308f6582df625833e4d9f35871ca438ba93d72afc3a1cf84779e2d50`) is the same as the hash of the file that was released in Electron 8.0.1.
```sh
$ git clone https://github.com/heronhaye/electron-8-spellchecker-test.git
$ npm install
$ npm start
```
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
Let me know if I can help by doing other tests, thanks!
|
https://github.com/electron/electron/issues/22381
|
https://github.com/electron/electron/pull/22382
|
3bc6809759665e7075fb193fb2312715a7da7e67
|
7cae73fe7afb4c35f69c6eb2431cfb7c3c73621b
| 2020-02-25T21:13:30Z |
c++
| 2020-02-25T22:57:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,370 |
["shell/browser/api/electron_api_web_request.cc", "shell/browser/electron_browser_client.cc", "shell/browser/net/proxying_url_loader_factory.cc", "shell/browser/protocol_registry.cc", "shell/browser/protocol_registry.h", "spec-main/api-web-request-spec.ts"]
|
webRequest API stopped working with file:// urls since 7.0.0 (and up to 9.0.0-beta.3 at least)
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.0.0
* 7.1.13
* 8.0.1
* 8.0.2
* 9.0.0-beta.2
* 9.0.0-beta.3
* **Operating System:**
* `Linux xps 5.5.4-arch1-1 #1 SMP PREEMPT Sat, 15 Feb 2020 00:36:29 +0000 x86_64 GNU/Linux`, Arch Linux current
* **Last Known Working Electron version:**
* 6.1.8
### Expected Behavior
E.g. how 6.x behaves: `onBeforeRequest` callback gets fired before requests are made.
Note: `touch /tmp/1.html` to get `onCompleted`, otherwise check `onErrorOccured`.
```
Electron 6.1.8
onBeforeRequest: file:///tmp/1.html
onCompleted: file:///tmp/1.html
Load finished!
```
See code to reproduce below.
### Actual Behavior
#### With `file:///tmp/1.html` (does not work):
```
Electron 7.0.0
Load finished!
```
```
Electron 7.1.13
Load finished!
```
```
Electron 8.0.2
Load finished!
```
```
Electron 9.0.0-beta.3
Load finished!
```
#### With `https://example.com/` (works):
```
Electron 9.0.0-beta.3
onBeforeRequest: https://example.com/
onCompleted: https://example.com/
Load finished!
```
```
Electron 8.0.2
onBeforeRequest: https://example.com/
onCompleted: https://example.com/
Load finished!
```
```
Electron 7.0.0
onBeforeRequest: https://example.com/
onCompleted: https://example.com/
Load finished!
```
### To Reproduce
```js
const { BrowserWindow, app } = require('electron')
app.on('ready', () => {
const window = new BrowserWindow({})
console.log(`Electron ${process.versions.electron}`)
window.webContents.session.webRequest.onBeforeRequest((details, callback) => {
console.log(`onBeforeRequest: ${details.url}`)
callback({})
})
window.webContents.session.webRequest.onCompleted((details) => {
console.log(`onCompleted: ${details.url}`)
})
window.webContents.session.webRequest.onErrorOccurred((details) => {
console.log(`onErrorOccured: ${details.url}`)
})
window.webContents.loadURL('file:///tmp/1.html') // compare with https://example.com/
window.webContents.on('did-finish-load', () => {
console.log('Load finished!')
})
window.show()
})
```
### Additional Information
* Documented to work with `file:` urls: https://www.electronjs.org/docs/api/web-request#webrequestonbeforerequestfilter-listener
* Specifying filters manually doesn't seem to help
* https://github.com/electron/electron/issues/21308 might be related
* Looks like a regression to me.
|
https://github.com/electron/electron/issues/22370
|
https://github.com/electron/electron/pull/22903
|
bac1c7f532d1456af197fb617128af4411489859
|
e6f2605ad09bffdffffbd8c770ffeb981685013c
| 2020-02-25T05:02:46Z |
c++
| 2020-04-01T07:38:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,350 |
["shell/browser/electron_javascript_dialog_manager.cc"]
|
safeDialogs option is broken since 7.0.0 (up to 9.0.0-beta.2, at least)
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 9.0.0-beta.2
* 8.0.1
* 7.1.13
* 7.0.0
* **Operating System:**
* `Linux xps 5.5.4-arch1-1 #1 SMP PREEMPT Sat, 15 Feb 2020 00:36:29 +0000 x86_64 GNU/Linux` (Arch Linux current)
* macOS 10.15.3
* **Last Known Working Electron version:**
* 6.1.8 -- fine, not affected
### Expected Behavior
* When `safeDialogs` option is used, I expect to see a "Prevent this app from creating additional dialogs" checkbox on all alerts after the first one, like it happened in Electron 6.1.8.
* I expect `safeDialogs` option to do at least something.
Basically, how 6.x behaves.
### Actual Behavior
* That checkbox does not appear on second alert, or on any other subsequent alert (tried about 10).
* There seems to no observable difference at all between turning that option on or off.
### To Reproduce
```js
const { BrowserWindow, app } = require('electron')
app.on('ready', () => {
const window = new BrowserWindow({
webPreferences: {
//partition: 'memory',
safeDialogs: true,
}
})
window.webContents.loadURL('about:blank') // also could be e.g. https://example.com/
window.webContents.on('did-finish-load', () => {
window.webContents.executeJavaScript(`
document.body.innerText = window.navigator.userAgent // (not required)
alert(0)
setTimeout(() => { alert(1) }, 100) // timeout for UA to be shown
`)
})
window.show()
})
```
### Screenshots
#### v6.1.8 (correct behavior)
#### v7.0.0
#### v7.1.13
#### v8.0.1
#### 9.0.0-beta.2
###
### Additional Information
* Documented here: https://www.electronjs.org/docs/api/browser-window#new-browserwindowoptions
* This does not seem to be a duplicate of closed #17543, as this affects only versions starting from v7.0.0.
* This does not seem to be a problem of specific configuration/url/scheme/whatever -- I was not able to make that option work on a recent Electron version with any attempted configuration.
|
https://github.com/electron/electron/issues/22350
|
https://github.com/electron/electron/pull/22353
|
79270e30a60814bd73c05f62499503e328896edf
|
c4f272e28f3f92e3991776347e0035ea9e446870
| 2020-02-23T19:33:10Z |
c++
| 2020-02-25T16:47:59Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,305 |
["shell/browser/api/electron_api_web_contents.cc", "spec-main/api-browser-window-spec.ts"]
|
BrowserWindow.webContents.focus doesn't work on mac
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
10.0.0-nightly.20200220
* **Operating System:**
macOS 10.15.1
* **Last Known Working Electron version:**
I don't know (judging by implementation it never worked)
### Expected Behavior:
Call to BrowserWindow.webContents.focus focuses proper window
### Actual Behavior:
Call to BrowserWindow.webContents.focus does nothing
### To Reproduce:
Run following simple app:
```
const { app, BrowserWindow } = require('electron')
function createWindow () {
let win1 = new BrowserWindow({ x:100, y: 300, width: 300, height: 200 })
win1.on('closed', () => {
win1 = null
})
win1.loadURL('https://github.com')
let win2 = new BrowserWindow({ x:300, y: 300, width: 300, height: 200 })
win2.on('closed', () => {
win1 = null
})
win2.loadURL('http://www.example.com')
setTimeout(() => {
win1.webContents.focus();
}, 3000);
}
app.on('ready', createWindow)
```
It works as expected on Windows: it creates two windows and after three seconds it focuses the first one. On mac it doesn't work and call to `webContents.focus` doesn't change the focus (it stays on the second window).
|
https://github.com/electron/electron/issues/22305
|
https://github.com/electron/electron/pull/22323
|
cad7054e4f101ea5a5edada4e201c5539e0c8bae
|
0bc906853eef24ad753e87c589fabf820467239e
| 2020-02-20T15:41:07Z |
c++
| 2020-03-02T07:51:02Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,242 |
["shell/browser/net/proxying_url_loader_factory.cc", "shell/browser/net/proxying_url_loader_factory.h", "spec-main/api-web-request-spec.ts"]
|
webRequest onBeforeSendHeaders + onHeadersReceived CORS net::ERR_FAILED error
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** v9.0.0-beta.2, 10.0.0-nightly.20200216
* **Operating System:** Linux
* **Last Known Working Electron version:** 8.0.1
### Expected Behavior
The following text gets printed on screen on "Send cross-domain XHR request" button click:
```
{"status":422,"statusText":"Unprocessable Entity","responseText":"{\"Code\":10080,\"Error\":\"[email protected] does not exist. Did you mean [email protected]?\",\"ErrorDescription\":\"\",\"Details\":{}}"}
```
### Actual Behavior
The following text gets printed on screen on "Send cross-domain XHR request" button click:
```
{"status":0,"statusText":"","responseText":"EMPTY"}
XMLHttpRequest error
```
### To Reproduce
https://github.com/vladimiry-playground/electron-quick-start-cors-issue2
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
|
https://github.com/electron/electron/issues/22242
|
https://github.com/electron/electron/pull/22407
|
ced487467c0221c6ec30ddc1c42620b8ad047d82
|
4c6150ea3d6411823c5f056d0794cec5b8258f8e
| 2020-02-17T21:58:05Z |
c++
| 2020-03-02T01:23:43Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,238 |
["docs/api/system-preferences.md"]
|
Is systemPreferences.canPromptTouchID() actually deprecated?
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
Although it is marked as deprecated on the [website](https://www.electronjs.org/docs/api/system-preferences#systempreferencescanprompttouchid-macos), it has no deprecation notice or a replacement to use instead. I suspect it was accidentaly marked as deprecated in [this unrelated commit](https://github.com/electron/electron/pull/18477/files#diff-8330cc91b59f45f220fe480486215c97R385).
|
https://github.com/electron/electron/issues/22238
|
https://github.com/electron/electron/pull/22256
|
3d53a4766f1e545b90a4c95ad4be15e8d20e833b
|
53b4fffff67ea44f5523187eee7623f4d505dd32
| 2020-02-17T18:54:20Z |
c++
| 2020-02-18T21:36:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,201 |
["docs/api/web-contents.md", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/api/electron_api_web_contents.h", "spec-main/api-web-contents-spec.ts"]
|
Add 'focus' & 'blur' events to BrowserView/WebContents
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
When working with BrowserViews, there's no way to listen to focus changes on either BrowserView itself or its WebContents.
### Proposed Solution
On BrowserWindow, there are `focus` and `blur` events. The same events need to be emitted on BrowserView/WebContents.
i.e. :
```
browserView.on('focus', () => {
// view is focused, do stuff
});
```
or
```
browserView.webContents.on('focus', () => {
// contents are focused, do stuff
});
```
### Alternatives Considered
I can't think of a good way of working around this lack of functionality
|
https://github.com/electron/electron/issues/22201
|
https://github.com/electron/electron/pull/25873
|
e34d7f5d6f7c34332a11010ca786e2e1271b2629
|
aeee9cfb7876a770fed9a1dc9669c2beeacf9ed9
| 2020-02-14T21:24:32Z |
c++
| 2022-02-01T10:28:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,192 |
["shell/browser/notifications/win/windows_toast_notification.cc"]
|
Notification timeoutType='never' doesn't work
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 8.0.0
* **Operating System:**
* Windows 10 Pro (1709)
### Expected Behavior
Using Notification API in main process with `timeoutType: 'never` I expected that the notification disappears only when the user clicks on it.
### Actual Behavior
After few seconds the notification disappers.
### To Reproduce
```
const newNotification = new Notification({title: 'I am a main process Notification!', timeoutType: 'never'})
newNotification.show()
```
```sh
$ git clone https://github.com/p-fusi/electron-quick-start -b master
$ npm install
$ npm run start
```
|
https://github.com/electron/electron/issues/22192
|
https://github.com/electron/electron/pull/25820
|
3402fe712c4b60ac07591a446f9aaa6018872fd4
|
0195319b7538b095b5f0bcfe8138f5081adf203c
| 2020-02-14T11:47:13Z |
c++
| 2020-10-09T15:26:39Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,178 |
["shell/browser/extensions/electron_extensions_api_client.cc"]
|
PDF download button doesn't do anything
|
When viewing a PDF, clicking the "download" button has no effect. It should trigger a download (including the `"will-download"` event and associated machinery).
|
https://github.com/electron/electron/issues/22178
|
https://github.com/electron/electron/pull/24946
|
db13dcb8d202cc4cf0c478e49a9fb1cc2f8e4d1a
|
befbbc27d8abe5d41260704b4bacfb99373cc62f
| 2020-02-13T01:37:07Z |
c++
| 2020-08-17T15:25:20Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,144 |
["shell/browser/electron_browser_client.cc", "shell/browser/electron_browser_client.h", "spec-main/chromium-spec.ts"]
|
mediaDevices.enumerateDevices returns different deviceIds on every reload
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* Tested with 8.0.0 and v9.0.0-beta.1
* **Operating System:**
* macOS 10.15.3 (19D76)
* **Last Known Working Electron version:**
* 7.1.12
### Expected Behavior
`navigator.mediaDevices.enumerateDevices()` should return a list of MediaDevices with a `label` and a `deviceId` property. The `deviceId` property should stay the same across reloads and restarts.
### Actual Behavior
The `deviceId` property changes with every reload/restart.
### To Reproduce
Simply execute `navigator.mediaDevices.enumerateDevices()` in the renderer process and compare the ids of the media devices to a different execution.
See this fork for an example:
https://github.com/codedrift/electron-quick-start
```sh
$ git clone https://github.com/codedrift/electron-quick-start -b media-device-ids
$ npm install
$ npm start || electron .
```
### Additional Information
It seems to work fine in a regular Chrome 80 browser.
|
https://github.com/electron/electron/issues/22144
|
https://github.com/electron/electron/pull/22386
|
fc54db11f373c8a1550657817480e55c15e84e1d
|
ee04c7f7ee870f53050148ce842d1c6c1e4a9338
| 2020-02-11T13:16:25Z |
c++
| 2020-02-27T00:03:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,139 |
["script/lib/util.py"]
|
dsym archive contains breakpad symbols on mac
|
The distribution archive for macOS with native dSYM symbols contains also breakapd_symbols directory. This directory has the same contents as archive with breapad symbols.
*For example*:
`electron-v9.0.0-beta.1-darwin-x64-dsym.zip`
also contains directory `breakpad_symbols` which is in
`electron-v9.0.0-beta.1-darwin-x64-symbols.zip`
To fix, please remove breapad_symbols from -dsym archive and leave it only in -symbols archive.
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 4.0.0 - latest
* macOS, all versions
* **Last Known Working Electron version:**
* I don't know
### Expected Behavior
`electron-vX.Y.Z-darwin-x64-dsym.zip` contains just dSYM symbols.
### Actual Behavior
`electron-vX.Y.Z-darwin-x64-dsym.zip` contains dSYM symbols and breakpad_symbols.
### To Reproduce
Download `electron-vX.Y.Z-darwin-x64-dsym.zip` from any version released in last years.
### Screenshots
|
https://github.com/electron/electron/issues/22139
|
https://github.com/electron/electron/pull/22191
|
e6a8906052b7bbec152d87130360237be10b70c8
|
7a7754a3dd87a154fb5e498f559201e5e0d9c06c
| 2020-02-11T09:09:08Z |
c++
| 2020-02-17T00:45:41Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,119 |
["shell/renderer/electron_renderer_client.cc", "spec-main/api-browser-window-spec.ts"]
|
Renderer Node fs API stops working on page reload when allowRendererProcessReuse is true
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 8.0.0
* **Operating System:**
* Windows 10 (1809)
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->Unknown
When setting `app.allowRendererProcessReuse = true` and after reloading the renderer (`Ctrl+R` in developer console), Node `fs` APIs would randomly stop working. Specifically, the callbacks are never called, or if you're using `fs.promises`, the promises are never resolved.
An interesting observation is: when you reload again, for a brief moment before the page is refreshed, the previous `fs` calls are magically unblocked. This can be observed by `console.log` lines suddenly printing the moment you hit `Ctrl+R` which disappears quickly as the whole page reloads.
Possibly related: https://github.com/electron/electron/issues/19554 This issue sounds like the opposite of what's happening here.
Also note: issue does not present itself when `app.allowRendererProcessReuse = false`
### Expected Behavior
From the repro steps, expecting to see local files printed in the console:
```
...
renderer.js:8 Reading file main.js
renderer.js:8 Reading file package-lock.json
renderer.js:8 Reading file package.json
renderer.js:8 Reading file preload.js
renderer.js:8 Reading file README.md
renderer.js:8 Reading file renderer.js
renderer.js:14 done
```
### Actual Behavior
List is printed the first time the app loads. Hit Ctrl+R and observe only a few lines printed, or none at all. Hit Ctrl+R again and observe more lines printed for a split second before renderer reloads.
### To Reproduce
Clone https://github.com/electron/electron-quick-start
rendereer.js
```
(async () => {
const fs = require('fs').promises;
for (let i = 0; i < 10; i++) {
let list = await fs.readdir('.', {withFileTypes: true});
for (let file of list) {
if (file.isFile()) {
console.log('Reading file', file.name);
await fs.readFile(file.name, 'utf-8');
}
}
}
console.log('done');
})();
```
main.js
```
const {app, BrowserWindow} = require('electron');
function createWindow() {
const win = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
nodeIntegration: true
}
});
win.loadFile('index.html');
win.webContents.openDevTools();
}
app.whenReady().then(createWindow);
app.allowRendererProcessReuse = true;
app.on('window-all-closed', () => {
if (process.platform !== 'darwin') {
app.quit();
}
});
app.on('activate', () => {
if (BrowserWindow.getAllWindows().length === 0) {
createWindow();
}
});
```
### Screenshots
First boot:
On reload:
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/22119
|
https://github.com/electron/electron/pull/25869
|
d57cd09f14c5ba1a3df65d5ddc2d10bf637244b4
|
e8166db9d7c93e53c5275471e8adef0faf54881b
| 2020-02-10T09:19:38Z |
c++
| 2020-10-13T16:19:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,108 |
["lib/browser/init.ts"]
|
Calling console.log on windows with no arguments causes 'undefined' in stdout
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.10
* **Operating System:**
* Windows 10 (1909)
* **Last Known Working Electron version:**
* v2.0.18 but probably <= v5.x
### Expected Behavior
When using electron on windows and using `console.log()`, an empty row should be written to stdout.
### Actual Behavior
The string 'undefined' is written to stdout.
### To Reproduce
```js
const { app } = require('electron')
console.log('console.log(""):');
console.log("");
console.log('console.log():');
console.log();
app.quit();
```
### Screenshots
### Additional Information
This is likely caused by #16441, when the arguments for the consoleLog method was altered:
https://github.com/electron/electron/pull/16441/files#diff-fd84dda09f0dbd7e74e2822ff6cf19a8R27
The behaviour can be reproduced in node REPL:
```js
const consoleLog = (format, ...args) => require('util').format(format, ...args);
consoleLog(); // 'undefined'
```
This was discovered when running cypress tests on windows ever since they upgraded their electron version.
Ref: https://github.com/cypress-io/cypress/issues/5995
|
https://github.com/electron/electron/issues/22108
|
https://github.com/electron/electron/pull/22165
|
d1fd237e614be4682e7a849aad9fab8b213b6859
|
5e7c59469156ba68f2e161a81dda372c5d5ec429
| 2020-02-08T22:14:02Z |
c++
| 2020-02-12T17:25:11Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,069 |
["shell/common/api/electron_bindings.cc", "shell/common/api/electron_bindings.h", "shell/common/node_bindings.cc", "shell/common/node_bindings.h"]
|
Crash on web worker close with node integration
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
7.1.2
* **Operating System:**
Mac OS 10.15.2
* **Last Known Working Electron version:**
Unknown, bug has existed since at least 4.0
### Expected Behavior
Web workers with node integration should not crash on shutdown.
### Actual Behavior
Web workers with node integration occasionally crash on shutdown.
--
### To Reproduce
I am sorry, I do not have a repro because this is definitely a timing issue and is difficult to track down.
### Additional Information
I would tell you at least what code is involved in the crash, but the library that is the culprit is rather large, we use Monaco Editor, which is a subset of the VScode codebase. When it shuts down webworkers, we occasionally run into this crash.
It looks like there was a similar issue opened https://github.com/electron/electron/issues/11243, but this has been closed and whatever the actual cause of this segfault is still out there, haunting us.
Stack trace, crashes with EXC_BAD_ACCESS / KERN_INVALID_ADDRESS:
```json
{
"function": "uv_close",
"function_offset": "0xb7",
"module_offset": "0x59fa5c7",
"frame": 0,
"module": "Electron Framework",
"registers": {
"r14": "0x0000000000000000",
"r15": "0x000000010e29b550",
"r12": "0x00007f8718515640",
"r13": "0x000070001c9409b0",
"r10": "0x000000000000002c",
"r11": "0x0000000000000206",
"rsp": "0x000070001c940990",
"rbx": "0x00007f8717bdda18",
"r8": "0x000000000001f60b",
"r9": "0x0000000000000000",
"rip": "0x0000000113b585c7",
"rbp": "0x000070001c9409a0",
"rdx": "0x0000000000000000",
"rcx": "0x000070001c9409b0",
"rdi": "0x00007f8717bdda18",
"rax": "0x000000000000000b",
"rsi": "0x0000000000000000"
},
"file": "/Users/distiller/project/src/out/Default/../../third_party/electron_node/deps/uv/src/unix/core.c",
"offset": "0x113b585c7",
"line": 217,
"trust": "context"
},
{
"function": "uv_walk",
"function_offset": "0xaf",
"module_offset": "0x59f971f",
"frame": 1,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/../../third_party/electron_node/deps/uv/src/uv-common.c",
"offset": "0x113b5771f",
"line": 456,
"trust": "frame_pointer"
},
{
"function": "electron::NodeBindings::~NodeBindings()",
"function_offset": "0x7c",
"module_offset": "0x13baec",
"frame": 2,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/../../electron/shell/common/node_bindings.cc",
"offset": "0x10e299aec",
"line": 104,
"trust": "frame_pointer"
},
{
"function": "electron::NodeBindingsMac::~NodeBindingsMac()",
"function_offset": "0xd",
"module_offset": "0x13d8ed",
"frame": 3,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/../../electron/shell/common/node_bindings_mac.cc",
"offset": "0x10e29b8ed",
"line": 20,
"trust": "frame_pointer"
},
{
"function": "electron::WebWorkerObserver::ContextWillDestroy(v8::Local<v8::Context>)",
"function_offset": "0xcb",
"module_offset": "0x1572bb",
"frame": 4,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/../../electron/shell/renderer/web_worker_observer.cc",
"offset": "0x10e2b52bb",
"line": 38,
"trust": "frame_pointer"
},
{
"function": "blink::WorkerThread::PrepareForShutdownOnWorkerThread()",
"function_offset": "0xc7",
"module_offset": "0x4c91b27",
"frame": 5,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/./../../third_party/blink/renderer/core/workers/worker_thread.cc",
"offset": "0x112defb27",
"line": 668,
"trust": "frame_pointer"
},
{
"function": "base::TaskAnnotator::RunTask(char const*, base::PendingTask*)",
"function_offset": "0x151",
"module_offset": "0x2361141",
"frame": 6,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/../../base/callback.h",
"offset": "0x1104bf141",
"line": 98,
"trust": "frame_pointer"
},
{
"function": "base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*)",
"function_offset": "0x193",
"module_offset": "0x23710d3",
"frame": 7,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc",
"offset": "0x1104cf0d3",
"line": 365,
"trust": "frame_pointer"
},
{
"function": "base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()",
"function_offset": "0x46",
"module_offset": "0x2370db6",
"frame": 8,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc",
"offset": "0x1104cedb6",
"line": 219,
"trust": "frame_pointer"
},
{
"function": "base::MessagePumpDefault::Run(base::MessagePump::Delegate*)",
"function_offset": "0x88",
"module_offset": "0x2326d88",
"frame": 9,
"module": "Electron Framework",
"file": "/Users/distiller/project/src/out/Default/./../../base/message_loop/message_pump_default.cc",
"offset": "0x110484d88",
"line": 39,
"trust": "frame_pointer"
}
```
|
https://github.com/electron/electron/issues/22069
|
https://github.com/electron/electron/pull/25332
|
a3389d017f3a33b9aa5698e0579a2f5924a3ea32
|
70e3aa01821808be311392e4e82bb8ee016e3ddf
| 2020-02-06T16:20:59Z |
c++
| 2020-09-14T00:53:50Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,048 |
["shell/browser/electron_browser_main_parts.cc", "shell/browser/electron_browser_main_parts.h", "shell/browser/electron_browser_main_parts_posix.cc"]
|
LocalStorage does not persist after killing process (CTRL + C)
|
* Electron version: 8.0.0
* Operating system: Linux - Fedora 31 - Kernel 5.4.13-201.fc31.x86_64
### Expected behavior
The local store should persist items even though the app is terminated as soon as the item was added.
### Actual behavior
If the app is terminated in less than 2 seconds after an item is added to local storage, the value is not available after the app is reopened.
### How to reproduce
1. Create a new electron app
(I used the quick start from the website git clone https://github.com/electron/electron-quick-start)
0. Run the app using `npm start`
0. Run a JavaScript code that adds a new key/value pair to localStorage
````
localStorage.setItem("my-key", "my-value")
````
0. Within 3 seconds, terminate the app (killing the process or pressing Ctrl + C)
NOTE: If the app is closed properly (pressing Alt + F4 or click on the "X"), this issue does not occur.
0. Run the app again
0. Check for the localStorage items
````
localStorage.getItem("my-key")
````
Or in the Application tab from Developer Tools.
Both cases are not available neither the key nor the value
|
https://github.com/electron/electron/issues/22048
|
https://github.com/electron/electron/pull/26559
|
b4196ca4862327f7012fd6fdc67bc2a2957a89ae
|
46972abf8b949af80ea18b81df92ceeaa26ce00d
| 2020-02-05T17:39:22Z |
c++
| 2020-11-20T00:00:34Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 22,005 |
["docs/api/environment-variables.md"]
|
Not able to get user's current location
|
### Issue Details
I using electron with react js. I have followed all the steps explained to get Google API Key and activate all google geolocation/ geocoding / maps etc., API's. I have also added process.env.GOOGLE_API_KEY = 'AIza....' to main file.
I'm fetching user's current location using 'navigator.geolocation.getCurrentPosition()' method but it shows 'Network location provider at 'https://www.googleapis.com/' : No response received.'
I have also enabled location services of my mac.
* **Electron Version:** ^7.1.11
* **Operating System:** macOS 10.14.4
### Expected Behavior
navigator.geolocation.getCurrentPosition() must return user current location
### Actual Behavior
getCurrentPosition method returns error 'Network location provider at 'https://www.googleapis.com/' : No response received.'
### To Reproduce
Simply call navigator.geolocation.getCurrentPosition() method
|
https://github.com/electron/electron/issues/22005
|
https://github.com/electron/electron/pull/22034
|
629c2121baf987db282af1ea070008689d9e82cf
|
070e312e8bd778801166c9e8ccf433c61967e14c
| 2020-02-02T14:41:17Z |
c++
| 2020-02-06T17:28:06Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,973 |
["shell/browser/api/atom_api_app.cc"]
|
Browse to https page with invalid certificate causes crash
|
Steps to reproduce:
1. Start local https server with unsigned certificate (I used this https://timonweb.com/posts/running-expressjs-server-over-https/)
2. Create simple app:
```
const { app, BrowserWindow } = require('electron')
function createWindow () {
let win = new BrowserWindow({
width: 800,
height: 600,
show: true
})
win.loadURL('https://www.localhost:3000');
}
app.on('ready', createWindow)
```
3. Launch this app with the newest master's Electron (I tested on 9.0.0-nightly.20200130)
What happens:
Application crashes with following callstack:
```
> [Inline Frame] electron.exe!base::OnceCallback<void (content::CertificateRequestResultType)>::Run(content::CertificateRequestResultType args) Line 98 C++
electron.exe!electron::api::App::AllowCertificateError(content::WebContents * web_contents, int cert_error, const net::SSLInfo & ssl_info, const GURL & request_url, bool is_main_frame_request, bool strict_enforcement, base::OnceCallback<void (content::CertificateRequestResultType)> callback) Line 709 C++
electron.exe!electron::AtomBrowserClient::AllowCertificateError(content::WebContents * web_contents, int cert_error, const net::SSLInfo & ssl_info, const GURL & request_url, bool is_main_frame_request, bool strict_enforcement, base::OnceCallback<void (content::CertificateRequestResultType)> callback) Line 655 C++
electron.exe!content::SSLManager::OnCertErrorInternal(std::__1::unique_ptr<content::SSLErrorHandler,std::__1::default_delete<content::SSLErrorHandler> > handler) Line 360 C++
electron.exe!content::SSLManager::OnCertError(std::__1::unique_ptr<content::SSLErrorHandler,std::__1::default_delete<content::SSLErrorHandler> > handler) Line 313 C++
electron.exe!content::SSLManager::OnSSLCertificateError(const base::WeakPtr<content::SSLErrorHandler::Delegate> & delegate, bool is_main_frame_request, const GURL & url, content::WebContents * web_contents, int net_error, const net::SSLInfo & ssl_info, bool fatal) Line 141 C++
electron.exe!content::StoragePartitionImpl::OnSSLCertificateError(int process_id, int routing_id, const GURL & url, int net_error, const net::SSLInfo & ssl_info, bool fatal, base::OnceCallback<void (int)> response) Line 1810 C++
electron.exe!network::mojom::NetworkContextClientStubDispatch::AcceptWithResponder(network::mojom::NetworkContextClient * impl, mojo::Message * message, std::__1::unique_ptr<mojo::MessageReceiverWithStatus,std::__1::default_delete<mojo::MessageReceiverWithStatus> > responder) Line 4607 C++
electron.exe!network::mojom::NetworkContextClientStub<mojo::RawPtrImplRefTraits<network::mojom::NetworkContextClient> >::AcceptWithResponder(mojo::Message * message, std::__1::unique_ptr<mojo::MessageReceiverWithStatus,std::__1::default_delete<mojo::MessageReceiverWithStatus> > responder) Line 1607 C++
electron.exe!mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message * message) Line 528 C++
electron.exe!mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper * message_wrapper, mojo::internal::MultiplexRouter::ClientCallBehavior client_call_behavior, base::SequencedTaskRunner * current_task_runner) Line 952 C++
electron.exe!mojo::internal::MultiplexRouter::Accept(mojo::Message * message) Line 624 C++
electron.exe!mojo::Connector::DispatchMessageW(mojo::Message message) Line 538 C++
electron.exe!mojo::Connector::ReadAllAvailableMessages() Line 627 C++
[Inline Frame] electron.exe!base::RepeatingCallback<void (unsigned int, const mojo::HandleSignalsState &)>::Run(unsigned int args, const mojo::HandleSignalsState & args) Line 132 C++
electron.exe!mojo::SimpleWatcher::OnHandleReady(int watch_id, unsigned int result, const mojo::HandleSignalsState & state) Line 293 C++
[Inline Frame] electron.exe!base::OnceCallback<void ()>::Run() Line 98 C++
electron.exe!base::TaskAnnotator::RunTask(const char * trace_event_name, base::PendingTask * pending_task) Line 142 C++
electron.exe!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow * continuation_lazy_now, bool * ran_task) Line 366 C++
electron.exe!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() Line 221 C++
electron.exe!base::MessagePumpForUI::DoRunLoop() Line 218 C++
electron.exe!base::MessagePumpWin::Run(base::MessagePump::Delegate * delegate) Line 76 C++
electron.exe!base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool application_tasks_allowed, base::TimeDelta timeout) Line 471 C++
electron.exe!base::RunLoop::Run() Line 157 C++
electron.exe!content::BrowserMainLoop::MainMessageLoopRun() Line 1505 C++
electron.exe!content::BrowserMainLoop::RunMainMessageLoopParts() Line 1062 C++
electron.exe!content::BrowserMainRunnerImpl::Run() Line 151 C++
electron.exe!content::BrowserMain(const content::MainFunctionParams & parameters) Line 47 C++
electron.exe!content::RunBrowserProcessMain(const content::MainFunctionParams & main_function_params, content::ContentMainDelegate * delegate) Line 531 C++
electron.exe!content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams & main_params, bool start_service_manager_only) Line 965 C++
electron.exe!content::ContentMainRunnerImpl::Run(bool start_service_manager_only) Line 876 C++
electron.exe!service_manager::Main(const service_manager::MainParams & params) Line 423 C++
electron.exe!content::ContentMain(const content::ContentMainParams & params) Line 19 C++
electron.exe!wWinMain(HINSTANCE__ * instance, HINSTANCE__ *, wchar_t * cmd, int) Line 158 C++
[External Code]
```
|
https://github.com/electron/electron/issues/21973
|
https://github.com/electron/electron/pull/21976
|
c29ec2d4ccbd8ed713accb19facb8e4d331dd32a
|
45f30ead6106fb5271b7c6fcc424c2e721d150df
| 2020-01-30T18:25:51Z |
c++
| 2020-01-31T17:25:46Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,970 |
["docs/api/app.md", "shell/browser/api/electron_api_app.cc", "shell/browser/api/electron_api_app.h", "shell/browser/api/electron_api_app_mac.mm", "spec-main/api-app-spec.ts"]
|
Request for the ability to control app activation policy on macOS
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
app.dock.hide() crash on OS X Catalina when running as root #19896
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
In macOS Catalina the dock.hide() will cause a crash when activated programmatically by root.
The same function works well on 10.14 and earlier versions.
Could we have an implementation as mentioned in #19896, please?
```
// The application does not appear in the Dock and does not have a menu
// bar, but it may be activated programmatically or by clicking on one
// of its windows.
[NSApp setActivationPolicy: NSApplicationActivationPolicyAccessory];
```
### Alternatives Considered
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
### Additional Information
<!-- Add any other context about the problem here. -->
In my case the Electron app will be open via root from a package installer or LaunchDaemon, as subsequent processes will need to be run as root.
End users do not have admin rights and therefore any UI to request root access will not work.
As well as not showing in the Dock, the app will not have a menu bar too.
Thank you for considering this request.
|
https://github.com/electron/electron/issues/21970
|
https://github.com/electron/electron/pull/21983
|
3341a2c3b4fbbcfd811b591cb57393d7d3153ed6
|
303ca1084638c4236bb6b7b5cd1817ff25934b86
| 2020-01-30T09:14:29Z |
c++
| 2020-02-05T19:12:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,968 |
[".circleci/config.yml", "appveyor.yml", "script/verify-chromedriver.py"]
|
Chromedriver should be built and validated in CI
|
Follow up to #21961
We currently build chromedriver and mksnapshot in CI but only test mksnapshot. We should have a _really simple_ test that just validates chromedriver at least launches successfully.
|
https://github.com/electron/electron/issues/21968
|
https://github.com/electron/electron/pull/21993
|
1fb2b8e00e5846b21d6f7ff4ea9ec828a8ec3aef
|
bdf65a75d0cc202902621a09fc22ae6d9411d5f0
| 2020-01-30T02:16:42Z |
c++
| 2020-02-03T18:31:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,881 |
["patches/chromium/.patches", "patches/chromium/fix_add_executable_to_chromedriver_s_rpath_for_electron_8.patch"]
|
Chromedriver @rpath on electron 8 and higher does not include ffmpeg
|
Chromedriver from electron 8 and higher has this error on start due to a bad rpath.
```
dyld: Library not loaded: @rpath/libffmpeg.dylib
Referenced from: /Users/sattard/projects/electron/spectron/node_modules/electron-chromedriver/bin/chromedriver
Reason: image not found
```
Adding the executable path to the rpath fixes it:
`install_name_tool -add_rpath @executable_path/. chromedriver`
|
https://github.com/electron/electron/issues/21881
|
https://github.com/electron/electron/pull/21961
|
0979bfc9c1a3ad2d9a8d32eb63db6940d278ff02
|
2a47300d619ec2c196e60a07d5a21a6dfd30cccb
| 2020-01-23T23:45:09Z |
c++
| 2020-01-30T00:40:09Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,867 |
["shell/browser/api/electron_api_app.cc", "spec-main/api-app-spec.ts"]
|
certificate-error will not fire did-fail-load on callback(false)
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
5.0.0 to 8.0.0 beta7
* **Operating System:**
Windows 10
### Expected Behavior
The did-fail-load event should be fired.
### Actual Behavior
The did-fail-load event is not fired.
### To Reproduce
Add an event handler to the did-fail-load event.
Add an event handler to the certificate-error event and cancel the default handling. Then call the callback with false.
The did-fail-load event will not be fired.
```
mainWindow.webContents.on("certificate-error", (event, url, error, certificate, callback) => {
event.preventDefault();
callback(false)
});
mainWindow.webContents.on("did-fail-load", (event, url, error, certificate, callback) => {
console.log("did-fail-load");
});
```
Electron fiddle gist:
https://gist.github.com/c1427e38bf0af9a5e78088fcea6e3c66
### Additional Information
loadURL returns a Promise, in the certificate error case this Promise will be rejected. The gist will show this too.
```
mainWindow.loadURL('https://expired.badssl.com')
.then(() => console.log("success"))
.catch(e => console.log("fail"))
```
|
https://github.com/electron/electron/issues/21867
|
https://github.com/electron/electron/pull/29826
|
d9d2f01563410b170d8b5dd17884fc9117c4138a
|
2c01deae03781cf4a19afd4c2ee774df58059144
| 2020-01-22T13:23:01Z |
c++
| 2021-06-23T23:40:51Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,831 |
["shell/browser/ui/message_box_win.cc"]
|
checkboxChecked still not working in 7.1.9
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, **only found a [closed issue](https://github.com/electron/electron/issues/21159) that doesn't works**.
### Issue Details
* **Electron Version:**
* 7.1.9
* **Operating System:**
* Windows 10, 1809
### Expected Behavior
The `checkboxChecked` property of dialog boxes should works in the promise.
### Actual Behavior
It doens't work when the `checkboxChecked` is set to be false, it works when `checkboxChecked` is set to be true.
This problem is said to be solved, but it hasn't been...
### To Reproduce
@jrdiard gave a example in the old and closed 21159 issue,
with the fiddle code in main.js:
```
const { app, BrowserWindow, dialog } = require('electron')
let mainWindow = null
app.on('ready', () => {
mainWindow = new BrowserWindow({ height: 600, width: 600 })
var ret = dialog.showMessageBox(mainWindow, {
type: "question", buttons: ["Yes", "No"],
message: "Do you want to run the demonstration scenes?",
cancelId: 1,
checkboxLabel: "Save images for each scene", checkboxChecked: true, noLink: false
});
ret.then((val) => {
console.log("Run Demo: " + val.response + " Save scenes: " + val.checkboxChecked);
});
})
```
|
https://github.com/electron/electron/issues/21831
|
https://github.com/electron/electron/pull/21852
|
fbc2f8344fc98ba5a6972c67f6dd8dc8d251c611
|
11804dfe2fd27a943632a15c2c410e4e3ae896df
| 2020-01-19T02:13:31Z |
c++
| 2020-01-22T07:38:39Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,764 |
["docs/api/tray.md", "shell/browser/api/atom_api_tray.cc", "shell/browser/api/atom_api_tray.h", "shell/browser/ui/tray_icon.cc", "shell/browser/ui/tray_icon.h", "shell/browser/ui/tray_icon_cocoa.mm", "shell/browser/ui/tray_icon_observer.h"]
|
Add mouse-down event for Tray icon
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, ~~without success~~.
> This was previously requested in #4384, but that issue was closed for reasons that seem to relate to making context menus appear on mouse-down (which is not what I'm requesting here), and it also is a few years old so I'm hoping this might now be a valid time to request it again.
### Problem Description
There are no `mouse-down` and `mouse-up` events on the Tray icon API.
It has a handful of mouse events (`mouse-enter`, `mouse-leave`, `mouse-move`, and `click`, as well as various `drag-*` events), but `mouse-down` and `mouse-up` are missing. This makes it impossible to implement certain UI patterns that other, non-Electron apps use regularly.
### Proposed Solution
Add `mouse-down` and `mouse-up` events. (At least for macOS.)
### Alternatives Considered
None.
### Additional Information
I think these events should be added for the sake of completeness. Other non-Electron Mac menubar apps make use of these events, so Electron apps should be able to do this too.
Here's a couple of specific use cases:
- Updating/animating the tray icon with a new image for an 'active' state (while the mouse button is pressed).
- Showing an application window on `mouse-down`. Other Mac menubar apps such as Dropbox and 1Password do exactly this, and it makes a real difference to perceived performance.
- This is particularly important for menubar apps that show an ephemeral, menu-like window when activated – when a native context menu isn't flexible enough for the desired GUI, but you still want it to feel like an ephemeral pop-out menu, i.e. it should appear instantly on mousedown, positioned as if emerging from the menubar icon itself, and disappear when it loses focus. This UI pattern feels really laggy when implemented with a click event.
- An app that lets the user enable some temporary state while they hold their mouse button down on a menubar icon, such as enabling microphone input briefly, or muting an audio track briefly. Currently this pattern is impossible with Electron.
|
https://github.com/electron/electron/issues/21764
|
https://github.com/electron/electron/pull/21795
|
5feafaceee92b418d331b2e7b2b9e16432a06ba5
|
5c6f9a6947cafe34ac03b9225d096b72a7a4ce79
| 2020-01-14T10:23:40Z |
c++
| 2020-01-17T16:28:34Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,716 |
["lib/browser/api/power-monitor.ts"]
|
importing powerMonitor from electron before 'ready' event causes crash
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
Same as #18966, app crashed when launched.
```typescript
import electron, { app } from "electron";
let mainWindow: electron.BrowserWindow;
app.on("ready", () => {
mainWindow = new electron.BrowserWindow({
width: 800,
height: 600,
});
});
```
Here is my repro sample.
https://github.com/mtgto/sample-electron-crash
Here is compiled index.ts
https://gist.github.com/mtgto/2a60ed4ce2e280c7577412884cde166e
* **Electron Version:**
* v7.1.8
* **Operating System:**
* Ubuntu 18.04.3
* **Last Known Working Electron version:**
* Don't know
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Open an empty window.
### Actual Behavior
```console
$ yarn start
yarn run v1.21.1
$ electron index.js
App threw an error during load
Error: The 'powerMonitor' module can't be used before the app 'ready' event
at Object.module.<computed> [as on] (electron/js2c/browser_init.js:6800:30)
at Object../lib/browser/api/power-monitor.ts (electron/js2c/browser_init.js:2671:18)
at __webpack_require__ (electron/js2c/browser_init.js:20:30)
at loader (electron/js2c/browser_init.js:2060:41)
at Object.powerMonitor (electron/js2c/browser_init.js:7079:17)
at __importStar (/home/user/sample-electron-crash/index.js:5:96)
at Object.<anonymous> (/home/user/sample-electron-crash/index.js:10:18)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
at Module.load (internal/modules/cjs/loader.js:735:32)
A JavaScript error occurred in the main process
Uncaught Exception:
Error: The 'powerMonitor' module can't be used before the app 'ready' event
at Object.module.<computed> [as on] (electron/js2c/browser_init.js:6800:30)
at Object../lib/browser/api/power-monitor.ts (electron/js2c/browser_init.js:2671:18)
at __webpack_require__ (electron/js2c/browser_init.js:20:30)
at loader (electron/js2c/browser_init.js:2060:41)
at Object.powerMonitor (electron/js2c/browser_init.js:7079:17)
at __importStar (/home/user/sample-electron-crash/index.js:5:96)
at Object.<anonymous> (/home/user/sample-electron-crash/index.js:10:18)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
at Module.load (internal/modules/cjs/loader.js:735:32)
```
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
```console
$ git clone https://github.com/mtgto/sample-electron-crash.git
$ cd sample-electron-crash
$ yarn install
$ yarn build
$ yarn start
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
N/A
### Additional Information
Stacktrace says `__importStar` calls powerMonitor. It happens when tsconfig uses `esModuleInterop: true` (default is true)
In macOS, app doesn't crash.
|
https://github.com/electron/electron/issues/21716
|
https://github.com/electron/electron/pull/21927
|
64f484c894fc8c4bc5681211b15b631b6fb36959
|
1b4eb0b67994a2336a6b8d811a13db98403c7f7e
| 2020-01-09T15:30:09Z |
c++
| 2020-01-28T18:19:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,708 |
["patches/chromium/printing.patch", "spec-main/api-web-contents-spec.ts"]
|
webContents.printToPDF rejects in v8.0.0-beta.5
|
### Preflight Checklist
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
Note: related but different issues:
* #21603 -- that one was using the older (callback) API, but this is using the latest (promise) API (and #21639 appears to be a duplicate of that)
* #18093 -- in that case some output is produced, but here a rejection occurs (and the affected electron versions are different).
* #20634 -- that one never ends, but this one rejects shortly after the call occurs
### Issue Details
* **Electron Version:**
* v8.0.0-beta.5 (also happens in 9.0.0-nightly.20191220 & 9.0.0-nightly.20200108)
* **Operating System:**
* Debian (bullseye/sid) x64, 5.3.0 kernel
* **Last Known Working Electron version:**
* 7.1.8, 8.0.0-beta.4, See [bisect](https://github.com/electron/electron/issues/21708#issuecomment-573079603)
### Expected Behavior
Calling `someBrowserWindow.webContents.printToPDF` should not throw exception / generate promise rejection.
### Actual Behavior
Calling `someBrowserWindow.webContents.printToPDF` rejects with `[Error: Failed to generate PDF]`.
### To Reproduce
Fiddle: https://gist.github.com/jacobq/cc5e5e1736b88cb32604f55369afd1c7
Repo: https://github.com/jacobq/electron-quick-start/tree/bug/print-to-pdf
```js
mainWindow.webContents.once('did-finish-load', async function() {
try {
const pdfData = await mainWindow.webContents.printToPDF({})
console.log('Got PDF data -->', pdfData) // never gets here
} catch(e) {
// output --> Call to printToPDF threw exception [Error: Failed to generate PDF]
console.error('Call to printToPDF threw exception', e)
}
});
```
|
https://github.com/electron/electron/issues/21708
|
https://github.com/electron/electron/pull/21783
|
b9eb68c0b45c3f8e0ab23bca1906089f23dcdc1e
|
1e99907acc359cdc59336fe5d6ca1759a8d9b9a2
| 2020-01-08T19:41:07Z |
c++
| 2020-01-16T05:05:36Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,699 |
["filenames.gni", "shell/browser/net/asar/asar_url_loader_factory.cc", "shell/browser/net/asar/asar_url_loader_factory.h", "shell/browser/protocol_registry.cc", "shell/browser/protocol_registry.h", "shell/browser/ui/inspectable_web_contents.cc"]
|
dev tools: unable to load source maps over custom protocol
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.7
* **Operating System:**
* macOS 10.14.6
* **Last Known Working Electron version:**
* 6.1.7
### Expected Behavior
When loading a Javascript file using a custom protocol, opening the dev tools should load the source maps.
### Actual Behavior
It does not load the source maps, and produces no error message other than an `ERR_UNKNOWN_URL_SCHEME` in the net log if net logging is enabled.
### To Reproduce
To see it work properly on Electron 6.1.7:
1. Run [this fiddle](https://gist.github.com/d0cb93e9c7d6ad198fe38db77038495a) on Electron 6.1.7
2. Open the dev tools
3. Note that `source map requested!` was logged to the main process console, and the source map for `test.js` (including `test.ts`) was loaded into the dev tools
To see it fail on Electron 7.1.7:
1. Run [this fiddle](https://gist.github.com/d0cb93e9c7d6ad198fe38db77038495a) on Electron 7.1.7
2. Open the dev tools
3. Note that `source map requested!` was not logged to the main process console, and neither `test.js.map` nor `test.ts` were loaded
### Additional Information
This is probably more fallout from Chromium's network service. When I enable net logging (`app.commandLine.appendSwitch('log-net-log', 'netlog.json')`), I see the following when opening the dev tools:
```
{"params":{"priority":"IDLE","traffic_annotation":129652775,"url":"serve://dist/assets/test.js.map"},"phase":1,"source":{"id":27,"type":1},"time":"20404995","type":2},
{"phase":1,"source":{"id":27,"type":1},"time":"20404995","type":103},
{"phase":2,"source":{"id":27,"type":1},"time":"20404995","type":103},
{"params":{"load_flags":0,"method":"GET","privacy_mode":0,"url":"serve://dist/assets/test.js.map"},"phase":1,"source":{"id":27,"type":1},"time":"20404995","type":99},
{"params":{"net_error":-302},"phase":2,"source":{"id":27,"type":1},"time":"20404995","type":99},
{"phase":1,"source":{"id":27,"type":1},"time":"20404995","type":107},
{"phase":2,"source":{"id":27,"type":1},"time":"20404995","type":107},
{"params":{"net_error":-302},"phase":2,"source":{"id":27,"type":1},"time":"20404995","type":2},
```
Note the `"net_error":-302` -- `-302` is `ERR_UNKNOWN_URL_SCHEME`, so somehow the network service(?) isn't aware of the standard scheme that was registered when trying to load `test.js.map`, even though `test.js` was successfully loaded using that same scheme.
This is currently preventing `ember-electron` apps from loading source maps on 7.x since `ember-electron` relies on a custom protocol to load the Ember app from the filesystem while still allowing Ember's web-based tooling (route recognition, web-style absolute asset URLs, etc.) to function.
|
https://github.com/electron/electron/issues/21699
|
https://github.com/electron/electron/pull/28573
|
ef4954fa1f32ff72c3ed721dd7a022cd9fcc5a3c
|
6bd13cc98f54f5d6274c05cce027f7684bb420a3
| 2020-01-08T06:44:49Z |
c++
| 2021-04-12T04:59:36Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,693 |
["docs/api/environment-variables.md", "shell/common/node_bindings.cc"]
|
There is no way to set the `--http-parser` NODE_OPTION in a packaged app
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Problem Description
In a similar vein to #20831, some `NODE_OPTIONS` should be passable to packaged Electron apps. I think this list should include `--http-parser`.
`--http-parser` is not whitelisted for `NODE_OPTIONS` in packaged apps, but it should be, because Node 11.5.0 changed the default HTTP parser to one that breaks some use cases. See comment here for an explanation: https://github.com/cypress-io/cypress/issues/5602#issuecomment-571685626
### Proposed Solution
Whitelist `--http-parser=parser`.
### Alternatives Considered
- Don't know of any other potential alternatives besides writing a slow HTTP parser in Node.js and giving up the many conveniences that Node's HTTP parsing brings.
|
https://github.com/electron/electron/issues/21693
|
https://github.com/electron/electron/pull/21694
|
75e39be916f09c8cf55b5b1ba3ff690c4ef0cb56
|
bb054716c9bd18602824f151d010c9ab3f082a20
| 2020-01-07T18:11:35Z |
c++
| 2020-01-09T16:09:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,673 |
["lib/browser/chrome-extension.js"]
|
Skipping extension with invalid URL
|
### Preflight Checklist
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
There is an existing issue that was closed because it didn't provide info such as how to reproduce. (https://github.com/electron/electron/issues/14779). LMK if I should do something different than opening this issue.
### Issue Details
* **Electron Version:**
* 7.1.7
* **Operating System:**
* MacOS Mojave 10.14.5
* **Last Known Working Electron version:**
* Unknown
### Expected Behavior
Extension should load without reporting errors
### Actual Behavior
Main process logs error:
`[30712:0102/163027.980187:ERROR:CONSOLE(8007)] "Skipping extension with invalid URL: chrome-extension://my-cool-extension", source: devtools://devtools/bundled/shell.js (8007)`
Extension does appear to run properly, although it's perhaps too simple to see other effects of this error.
### To Reproduce
$ git clone https://github.com/rangerscience/electron-extensions
$ npm install
$ npm start
### Additional Information
This looks relevant: https://github.com/electron/electron/blob/master/lib/browser/chrome-extension.js#L405
I have no idea where to even begin finding `devtools://devtools/bundled/shell.js (8007)`. Any help there would be appreciated.
### Additional Questions
These are other things I'm trying to figure out with regards to extensions, but that are outside the immediate scope of this issue.
- Is there any way to go from the docs (say, [`webContents.loadURL`](https://electronjs.org/docs/api/web-contents#contentsloadurlurl-options) to the implementing code?
- Where would the logs from the background script show up?
- Is there any way to invoke an extension's browser action button? (I'm not seeing any in the doc)
|
https://github.com/electron/electron/issues/21673
|
https://github.com/electron/electron/pull/21711
|
80a037db865615ddfa6f9d024f0f5fb02123741d
|
83c19faf617f75cf2d0addb886b599c86e02a4a7
| 2020-01-03T22:17:24Z |
c++
| 2020-01-14T06:47:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,666 |
["shell/browser/native_browser_view.cc", "shell/browser/native_browser_view.h", "shell/browser/native_browser_view_mac.mm", "shell/browser/native_browser_view_views.cc", "spec-main/fixtures/crash-cases/api-browser-destroy/index.js"]
|
Crashes in NativeBrowserViewViews::AutoResize function on Move/Resize
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 6.0.7 and 6.1.5 <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:**
* Windows 10 x64 <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
App not crashing
<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
It crashes
<!-- A clear and concise description of what actually happened. -->
### To Reproduce
Was not able to reproduce myself or get reports with steps from user.
Only information that we have is crash reports with backtraces.
This backtraces have different call traces but all end with crash in "atom::NativeBrowserViewViews::AutoResize" file native_browser_view_views.cc line 54.
Crashes of this two types of exceptions EXCEPTION_ACCESS_VIOLATION_READ and EXCEPTION_ACCESS_VIOLATION_EXEC.
Calls to AutoResize leading to a crash originated from two different events Move and Resize.
> atom::NativeBrowserViewViews::AutoResize native_browser_view_views.cc:54
> std::list<T>::list list:800
> atom::NativeWindowViews::GetBounds native_window_views.cc:588
> atom::NativeWindowViews::OnWidgetBoundsChanged native_window_views.cc:1222
> base::ObserverList<T>::Iter::EnsureValidIndex observer_list.h:211
> views::Widget::OnNativeWidgetMove widget.cc:1180
> display::win::ScreenWin::GetDisplayNearestPoint screen_win.cc:640
> views::DesktopWindowTreeHostWin::HandleMove desktop_window_tree_host_win.cc:836
> atom::NativeWindow::GetContentMaximumSize native_window.cc:287
> views::HWNDMessageHandler::_ProcessWindowMessage hwnd_message_handler.h:423
> atom::NativeBrowserViewViews::AutoResize native_browser_view_views.cc:54
> std::list<T>::list list:800
> atom::NativeWindowViews::OnWidgetBoundsChanged native_window_views.cc:1222
> base::ObserverList<T>::Iter::EnsureValidIndex observer_list.h:211
> views::Widget::OnNativeWidgetSizeChanged widget.cc:1192
> aura::Window::SetBoundsInternal window.cc:862
> aura::Window::SetBounds window.cc:355
> views::DesktopNativeWidgetAura::OnHostResized desktop_native_widget_aura.cc:1223
> aura::Window::UpdateLocalSurfaceId window.cc:1493
> base::ObserverList<T>::Iter::Iter observer_list.h:135
> aura::WindowTreeHost::OnHostResizedInPixels window_tree_host.cc:457
> atom::api::TopLevelWindow::OnWindowMessage atom_api_top_level_window.cc:292
> base::ObserverList<T>::Iter::EnsureValidIndex observer_list.h:211
> views::HWNDMessageHandler::ClientAreaSizeChanged hwnd_message_handler.cc:1360
> views::HWNDMessageHandler::OnNCPaint hwnd_message_handler.cc:2254
> CThemeWnd::NcHitTest nctheme.cpp:6619
> views::HWNDMessageHandler::OnWindowPosChanged hwnd_message_handler.cc:2763
> views::HWNDMessageHandler::_ProcessWindowMessage hwnd_message_handler.h:440
Crashing line native_browser_view_views.cc line 54.
https://github.com/electron/electron/blob/47ee65c66ce0a1fcd476ac4cefcdc2b3b96cede9/atom/browser/native_browser_view_views.cc#L54
Can object reference returned by GetInspectableWebContentsView() be invalid or object destroyed when Move/Resize event comes from the system?
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
Our crash reporting system receives about 100 crashes a day what involves AutoResize.
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/21666
|
https://github.com/electron/electron/pull/25411
|
e0a25cb1e3a624e355739aa9edf2e422d7bfb97a
|
53aaeb7a16af591f2591a3c72242f9470e83006d
| 2020-01-02T21:08:51Z |
c++
| 2020-09-17T00:10:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,663 |
["shell/common/platform_util_win.cc"]
|
shell.showItemInFolder slow response and double error msg box when access is denied
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v5.0.6
* **Operating System:**
* Windows 10 (1803)
* **Last Known Working Electron version:**
* Not sure
### Expected Behavior
response should be faster and "access is denied" should only popup once.
### Actual Behavior
"access is denied" message popup and UI kind of partially hang. cursor style not changed while UI dom element style change properly like hover event.
### To Reproduce
make sure you haven't grant privilege of "C:\\ProgramData\\Microsoft\\Search\\Data
```
app.on('ready', () => {
console.log(new Date());
shell.showItemInFolder("C:\\ProgramData\\Microsoft\\Search\\Data\\Applications\\Windows\\Windows.edb");
console.log(new Date())
});
```
result:
`2020-01-02T07:37:25.277Z`
`2020-01-02T07:37:45.404Z`
takes 10+ second to continue working and two "access is denied" popup.
### Additional Information
the implementation of showItemInFolder is [here line 290](https://github.com/electron/electron/blob/d3622f9c37e8cd94e47206bb6211346011d5f76b/shell/common/platform_util_win.cc)
code:
```
hr = SHOpenFolderAndSelectItems(dir_item, base::size(highlight), highlight,
NULL);
if (FAILED(hr)) {
// On some systems, the above call mysteriously fails with "file not
// found" even though the file is there. In these cases, ShellExecute()
// seems to work as a fallback (although it won't select the file).
if (hr == ERROR_FILE_NOT_FOUND) {
ShellExecute(NULL, L"open", dir.value().c_str(), NULL, NULL, SW_SHOW);
} else {
LOG(WARNING) << " " << __func__ << "(): Can't open full_path = \""
<< full_path.value() << "\""
<< " hr = " << logging::SystemErrorCodeToString(hr);
ui::win::OpenFolderViaShell(dir);
}
}
```
there's a fallback call OpenFolderViaShell, I think this is the root cause.
better to deal with "access denied" error type and btw I guess there might be other error we don't expect a fallback patch?
|
https://github.com/electron/electron/issues/21663
|
https://github.com/electron/electron/pull/21668
|
c0bde4baa44918cb8dc2dfb759d410dec13dc8d8
|
19ef7a0fc97cba575e64ccb47bbfc566f0c46fcb
| 2020-01-02T07:47:49Z |
c++
| 2020-01-13T00:49:51Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,656 |
["docs-translations/README.md", "docs/development/source-code-directory-structure.md"]
|
Documentation to include understanding of folder structure
|
Can there be more information provided to understand the source code folder structure of this repo.
That is so:
1. We may want to issue a PR for a bug fix but we don't know where to find where the feature is implemented
2. We may want to inspect the code to increase general understanding of what's going on under the hood for the various OS
|
https://github.com/electron/electron/issues/21656
|
https://github.com/electron/electron/pull/21659
|
aef9ab1bb7568823bd7e9c02bad757a04a1a2c49
|
2e7f9bffebd323941ca052c1781face9caec5c13
| 2019-12-31T22:37:01Z |
c++
| 2020-01-13T05:08:00Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,633 |
["shell/browser/ui/message_box_mac.mm"]
|
default button in dialog not working on macOS
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v7.1.5 (also tried 7.1.7)
* **Operating System:**
* macOS 10.14.6 (but I think it doesn't matter. I think it happens on all macOS versions)
* **Last Known Working Electron version:**
* none that I know of
### Expected Behavior
When I set `defaultId` for `showMessageBox*`, the button set should be active by default.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
No button is selected at all:
<img width="217" alt="image" src="https://user-images.githubusercontent.com/223439/71554617-97449c00-29ef-11ea-960d-7a7558120531.png">
### To Reproduce
Minimal example:
`test.js`
```
const {app, BrowserWindow, dialog} = require('electron');
let mainWindow;
app.on('ready', () => {
mainWindow = new BrowserWindow({
height: 200,
width: 440
});
mainWindow.loadURL('file://' + __dirname + '/index.html');
const ok = dialog.showMessageBoxSync(mainWindow, {
type: 'question',
message: 'message here',
buttons: ['Ok', 'Cancel'],
defaultId: 1,
cancelId: 1,
});
});
```
`node_modules/electron/dist/Electron.app/Contents/MacOS/Electron test.js`
<img width="552" alt="image" src="https://user-images.githubusercontent.com/223439/71555100-db3a9f80-29f5-11ea-86f0-0c0e31c91809.png">
---
Context:
An application that uses Electron and experiences this problem is Joplin. Joplin can be built as follows:
```
git clone https://github.com/laurent22/joplin.git
cd joplin
npm install && cd Tools && npm install && cd ..
cd ElectronClient/app
npm install
cd ..
./run.sh
```
To get to such a dialog, create a notebook and a note. Right-click on a note an choose `Delete`.
Or try to delete one of the welcome notes.
### Additional Information
I've seen this problem since Electron 4.x. I can't recall an Electron version where this ever worked on macOS.
|
https://github.com/electron/electron/issues/21633
|
https://github.com/electron/electron/pull/21642
|
ed6a3877a438c1109692a387cef97c21cb3cab3c
|
fbb10beb4094a1a5b9182b33f243a25f7388025d
| 2019-12-29T09:47:01Z |
c++
| 2019-12-31T13:48:43Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,623 |
["docs/api/shell.md"]
|
Wrong shell.openPath() result
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 9.0.0-nightly.20191225
* **Operating System:** Linux
* **Last Known Working Electron version:** new method introduced since v9
### Expected Behavior
- `object { result: {success: true, errorMessage: ""} }` printed to console.
- `app.getPath("userData")` opened
### Actual Behavior
- `string { result: '' }` printed to console.
- `app.getPath("userData")` opened
### To Reproduce
```
git clone [email protected]:vladimiry-playground/electron-quick-start-openpath-issue.git
cd electron-quick-start-openpath-issue
npm ci
npm start
```
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
Ref #20682, CC @codebytere
|
https://github.com/electron/electron/issues/21623
|
https://github.com/electron/electron/pull/21641
|
85382d8f1d989a1cbc86280dbb3afd2af071cdcf
|
181eecd03ecd470d21b950c9a00160204add79ba
| 2019-12-27T05:44:13Z |
c++
| 2019-12-30T19:40:30Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,614 |
["shell/browser/native_window_views.h", "shell/browser/native_window_views_win.cc", "spec-main/api-browser-window-spec.ts"]
|
Crash when showing a hidden window
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 --> 7.1.7 (32-bit and 64-bit) as well as 8.X
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 --> Windows 10 18362
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 --> 6.1.6 (32-bit)
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
The application should not crash when showing a hidden window.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
It crashes consistently.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
> **Note: this reproduce description is outdated. Please check the update below**
You simply need to hide a window then show it again using remote.
#### Repo
```sh
$ git clone https://github.com/aabuhijleh/electron-quick-start
$ cd electron-quick-start
$ npm install
$ npm start
```
#### In the main process
```js
// hide window on minimize
mainWindow.on('minimize', event => {
event.preventDefault()
mainWindow.hide()
})
```
#### In the preload script
```js
// get window using remote
const {remote} = require('electron')
const {Tray} = remote
const mainWindow = remote.getCurrentWindow()
// show window using remote on tray icon click
let tray
window.onload = () => {
tray = new Tray('tray.png')
tray.on('click', () => {
mainWindow.show()
})
}
```
### Screen Recording
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Issue
An Electron process remains alive after the crash occurs and it never dies unless it's killed manually. This is also a very serious issue.
# UPDATE
This crash has nothing to do with the `remote` module.
It's related to showing/restoring a window after it has been minimized and hidden.
#### You only need to have something like this in the main process code
```js
// a crash occurs if window is shown after it's minimized & hidden
mainWindow.on("minimize", () => {
mainWindow.hide()
setTimeout(() => {
mainWindow.show()
}, 2000)
})
```
or simply
```js
mainWindow.minimize()
mainWindow.hide()
mainWindow.show() // or mainWindow.restore()
```
I believe a lot of Windows apps hide their windows to the system tray on `minimize` / `close` events. So this crash will also affect them as well. That's why I think this issue is critical.
|
https://github.com/electron/electron/issues/21614
|
https://github.com/electron/electron/pull/21813
|
bf6e4b1247f3a48e8926080b1852ec5d739f0888
|
42d8933d66b18e08b54b87554146fec80ef2f063
| 2019-12-24T14:11:00Z |
c++
| 2020-01-17T19:29:01Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,608 |
["shell/common/gin_helper/trackable_object.h", "spec-main/api-browser-window-spec.ts"]
|
BrowserWindow.fromWebContents returns undefined for windows created using window.open
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 5.0.7
* **Operating System:** Windows 10
### Expected Behavior
I expect that calling `BrowserWindow.fromWebContents(win.webContents)` returns `win`.
### Actual Behavior
The API returns `undefined`.
### To Reproduce
```
const { app, BrowserWindow } = require('electron')
async function createWindow() {
var mainWindow = new BrowserWindow({
webPreferences: {
nativeWindowOpen: true
}
});
await mainWindow.loadURL("https://google.com");
mainWindow.webContents.openDevTools();
console.log(BrowserWindow.fromWebContents(mainWindow.webContents)); // correctly returns mainWindow
app.on("browser-window-created", (e, window) => {
console.log(BrowserWindow.fromWebContents(window.webContents)); // returns undefined
window.once("will-move", (e) => {
console.log(BrowserWindow.fromWebContents(e.sender)); // extra test; also returns undefined
});
});
}
app.on('ready', createWindow)
```
Run `npm start` and open a window from devtools (e.g. `window.open("https://google.com")`). Notice that `fromWebContents` can't find the browser window for the new window.
|
https://github.com/electron/electron/issues/21608
|
https://github.com/electron/electron/pull/33257
|
b2c5623a13c91a561704b46480b6c3a7a51f2db7
|
e9044860766affd5ded7baa3b44da6d4b9fe89e0
| 2019-12-23T21:05:28Z |
c++
| 2022-03-16T23:23:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,597 |
["shell/browser/atom_browser_client.cc", "shell/browser/net/proxying_url_loader_factory.cc", "shell/browser/net/proxying_url_loader_factory.h", "spec-main/api-web-request-spec.ts"]
|
Crash when going to http://google.com with any `webRequest` listener
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 8.0.0-beta.5
* **Operating System:**
* Windows 10
* **Last Known Working Electron version:**
* 8.0.0-beta,4
### Expected Behavior
http://google.com should load without any crash
### Actual Behavior
Going to http://google.com works for the first time. However, when going to the same URL after the cache has been saved in `userData`, it crashes with `3221225477` exit code. The strange thing is that when going to https://google.com, it works perfectly.
### To Reproduce
(I couldn't use Fiddle, since it saves the `userData` temporarily)
https://github.com/sentialx/electron-quick-start/tree/google-crash
Branch `google-crash`
|
https://github.com/electron/electron/issues/21597
|
https://github.com/electron/electron/pull/21838
|
36fac7bfec0c7f4867d1b329b9490b85c06d1580
|
fbc2f8344fc98ba5a6972c67f6dd8dc8d251c611
| 2019-12-21T19:48:55Z |
c++
| 2020-01-22T01:31:10Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,596 |
["shell/browser/feature_list.cc"]
|
youtube.com not loading on 8.0.0-beta.5
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 8.0.0-beta.5
* **Operating System:**
* Windows 10
* **Last Known Working Electron version:**
* 8.0.0-beta.4
### Expected Behavior
https://youtube.com should load.
### Actual Behavior
https://youtube.com is not loading.
### To Reproduce
https://gist.github.com/e9ea437d3562b951a6619540aaf3da15
### Screenshots
### Additional information
This may be related to #21242
|
https://github.com/electron/electron/issues/21596
|
https://github.com/electron/electron/pull/21858
|
11804dfe2fd27a943632a15c2c410e4e3ae896df
|
a5d5e76b1080461782e396f40fbaf534b71a7208
| 2019-12-21T16:58:53Z |
c++
| 2020-01-22T13:03:17Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,583 |
["patches/chromium/.patches", "patches/chromium/fix_use_native_window_button_positions_when_macos_locale_is_rtl.patch"]
|
[RTL][Mac] Window buttons do not respect system default
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->Electron 9.0.0-nightly.20191217
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->macOS 10.14.6
* **Last Known Working Electron version:**
* _Uncertain_
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
On a Mac with primary language set to an RTL language (say, Arabic), the window buttons (the "traffic lights") _should_ appear on the right side of the window.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
It seems that Electron-based apps still show the window buttons on the left, just like in LTR languages like English.
See below for a screenshot indicating the issue.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
1. Change the MacOS system language to Arabic. (https://support.apple.com/guide/mac-help/change-the-language-your-mac-uses-mh26684/mac)
2. Restart your computer. (Notice how native windows now have window buttons on the right side.)
3. Open an Electron app. The window buttons appear on the left side.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
Here is a screenshot of my Mac in Arabic (with a native window open for reference), along with a test build of the Electron app. Notice that the position of the window buttons is different.
### Additional Information
<!-- Add any other context about the problem here. -->
I was also able to reproduce this issue on various Electron-based apps including VS Code, Skype, WhatsApp, Slack.
|
https://github.com/electron/electron/issues/21583
|
https://github.com/electron/electron/pull/22016
|
f4fd939409a87a38dc051dde1e158bc9edbf0967
|
c8273e375ce0f40a9fea17ae3235e43a8aafae54
| 2019-12-19T19:02:40Z |
c++
| 2020-02-06T21:14:18Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,566 |
["lib/browser/api/net.js"]
|
SimpleURLLoaderWrapper broken with redirects in > 7.1.2
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
v7.1.4
* **Operating System:**
Ubuntu + MacOS
* **Last Known Working Electron version:**
7.1.2
### Expected Behavior
electron and electron-updater should follow redirect URLs
### Actual Behavior
electron-updater / electron-builder breaks with Electron > 7.1.2
```
Redirect was cancelled at SimpleURLLoaderWrapper. (electron/js2c/browser_init.js:2561:23) at SimpleURLLoaderWrapper.emit (events.js:203:13)
```
This NUKED my app update system and I think it's a really critical bug that needs to be fixed.
### To Reproduce
I don't have an easy way to reproduce.
You could TRY to fetch this URL:
```
https://github.com/burtonator/polar-bookshelf/releases/download/v1.80.3/Polar-Bookshelf-1.80.3-mac.zip
```
which is what the auto-updater is fetching and then breaks on.
PS ... Electron rocks! Except for this issue of course.
|
https://github.com/electron/electron/issues/21566
|
https://github.com/electron/electron/pull/21630
|
181eecd03ecd470d21b950c9a00160204add79ba
|
ed6a3877a438c1109692a387cef97c21cb3cab3c
| 2019-12-18T16:22:49Z |
c++
| 2019-12-30T23:47:08Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,555 |
["lib/browser/desktop-capturer.ts"]
|
desktopCapturer.getSources memory leaks
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->6.1.6
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->macOs 10.14.6
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
The Resident set size of the Main process when using desktopCapturer.getSources not growing.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Memory leak in the Main process (rss memory growing) when using the desktopCapturer.getSources method in the Rendering process.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
I just run the code that same with [#19908](https://github.com/electron/electron/issues/19908) in v6.1.6 , and it's well in v4.2.10
#### log in v6.1.6
```
rss=44.941312MB, heapTotal=8.82688MB, heapUsed=4.591224MB, external=1.092509MB
rss=118.259712MB, heapTotal=6.20544MB, heapUsed=4.078576MB, external=1.032391MB
rss=128.548864MB, heapTotal=6.47168MB, heapUsed=4.555952MB, external=1.032391MB
rss=138.698752MB, heapTotal=6.47168MB, heapUsed=4.76792MB, external=1.032391MB
rss=158.441472MB, heapTotal=6.47168MB, heapUsed=4.97628MB, external=1.032391MB
rss=169.381888MB, heapTotal=7.258112MB, heapUsed=5.267584MB, external=1.032391MB
rss=189.546496MB, heapTotal=7.258112MB, heapUsed=5.69024MB, external=1.032391MB
rss=199.540736MB, heapTotal=7.7824MB, heapUsed=5.799064MB, external=1.032391MB
rss=219.68896MB, heapTotal=7.7824MB, heapUsed=6.22848MB, external=1.032391MB
```
#### log in v4.2.10
```
rss=45.207552MB, heapTotal=12.324864MB, heapUsed=6.852656MB, external=0.161429MB
rss=150.91712MB, heapTotal=12.849152MB, heapUsed=6.633424MB, external=1.22608MB
rss=150.892544MB, heapTotal=12.849152MB, heapUsed=6.641872MB, external=1.22608MB
rss=150.859776MB, heapTotal=12.849152MB, heapUsed=6.64536MB, external=1.22608MB
```
> main.js
```js
const {
app,
BrowserWindow
} = require('electron');
const url = require('url');
const path = require('path');
let win;
const logBytes = x => `${x[0]}=${x[1] / (1000.0 * 1000)}MB`;
const logMemory = () => {
console.log(
Object.entries(process.memoryUsage())
.map(logBytes)
.join(', ')
);
};
const createWindow = () => {
win = new BrowserWindow();
win.loadURL(url.format({
pathname: path.join(__dirname, 'index.html'),
protocol: 'file:',
slashes: true
}));
};
try {
app.on('ready', createWindow);
} catch (e) {
console.err(e);
}
logMemory();
setInterval(logMemory, 10000);
```
> index.html
```html
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Hello World!</title>
</head>
<body>
<h1>Hello World!</h1>
We are using Node.js <span id="node-version"></span>,
Chromium <span id="chrome-version"></span>,
and Electron <span id="electron-version"></span>.
<!-- You can also require other files to run in this process -->
<script src="./renderer.js"></script>
</body>
```
> renderer.js
```js
const electron = require('electron');
const desktopCapturer = electron.desktopCapturer;
const getSourcesLoop = () => {
console.log('getSources() call');
desktopCapturer.getSources({
types: ['screen', 'window']
}).then(sources => {
console.log('getSources() success', sources);
setTimeout(getSourcesLoop, 5000);
});
};
getSourcesLoop();
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
|
https://github.com/electron/electron/issues/21555
|
https://github.com/electron/electron/pull/27031
|
8f9058ea720f4078302d0266fcb1edd18bbe8a79
|
6a3679dc5572685b8df76c85d912d9cb9ad1a8dc
| 2019-12-17T09:54:23Z |
c++
| 2020-12-17T00:11:39Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,515 |
["shell/app/node_main.cc", "spec-main/node-spec.ts", "spec/fixtures/module/node-promise-timer.js"]
|
await Promise with Timer behavior regress from previous version
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 5.0.12 - 7.1.10
* **Operating System:**
* Windows 10/macOS 10.15
* **Last Known Working Electron version:**
* 4.2.5
### Expected Behavior
We have been using the piece of code to perform asynchronous operations.
```js
await new Promise((resolve) => { setTimeout(resolve, 1000); }
```
It would pause the execution of the code path containing it for about 1 second and resume it then. This has been working well for a long time.
### Actual Behavior
Since we upgrade to Electron 7, in forked node processes, only the first several timer callbacks are called on time, while the rest of them are called extremely late for unknown reason.
Suppose we call the above piece of code for 10 times in a loop. Only the first two promises are created and resolved correctly. In addition, the process exits for unknown reason. In our production code, since there are other things going on (not computationally intensive) which keeps the process alive, we are seeing the 3rd and the rest of the Timers being created and invoked unreasonably late (around 12s after the 2nd one resolves).
The output in the renderer console is
```
Spawned child process <some_pid>
child process send a message INIT_ACK
child process send a message INIT_ACK
child process exits
```
### To Reproduce
https://github.com/JasonYeMSFT/electron-quick-start/tree/bug/await-Promise
To run the repro steps
```sh
$ git clone https://github.com/JasonYeMSFT/electron-quick-start -b bug/await-Promise
$ npm install
$ npm start
```
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
Electron 4.2.5 behaves correctly for exactly the same code in this repo. The behavior doesn't reproduce in renderer process. Also it doesn't seem to be a nodejs problem because I can run the renderer.js directly with node on the same version and it behaves correctly.
I did some extra experiment and it turns out that `setInterval` is producing much more stable behaviors compared to `setTimeout` (update, I was wrong, `setInterval` also has the weird behavior).
|
https://github.com/electron/electron/issues/21515
|
https://github.com/electron/electron/pull/23153
|
3ada079fe3a28b88e24621756996af81e7d312e6
|
07654c47ecd8a8f530387c9c23797784f8e68ee1
| 2019-12-13T18:28:46Z |
c++
| 2020-04-21T19:18:22Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,499 |
["shell/browser/ui/tray_icon_gtk.cc"]
|
tray.setContextMenu(Menu.buildFromTemplate([...])) doesn't update the tray menu and the app segfaults if menu item clicked several times
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 8.0.0-beta.4, 9.0.0-nightly.20191225
* **Operating System:** Linux (tested on: Manjaro XFCE, Ubuntu 19.04/19.10 Gnome Shell, Kubuntu 19.10)
* **Last Known Working Electron version:** 7.1.3
### Expected Behavior
- `tray.setContextMenu(Menu.buildFromTemplate([...]))` call updates the tray menu.
- Clicking on the tray menu item doesn't lead to the app segfault crash.
- After the 3 seconds delay clicking on the tray menu item prints `clicked { label: '3000ms' }` to console.
### Actual Behavior
- `tray.setContextMenu(Menu.buildFromTemplate([...]))` call does not update the tray menu items.
- Clicking on the tray menu item leads to the app segfault crash.
- After the 3 seconds delay clicking on the tray menu item prints `clicked { label: 'initial' }` to console.
### To Reproduce
https://github.com/vladimiry-playground/electron-quick-start-tray-issue-menu-dynamics
- `npm ci`
- `ELECTRON_ENABLE_LOGGIN=true ./node_modules/electron/dist/electron main.js`
- Wait for 3 seconds (`3000 ms` gets printed in the console).
- Open the tray menu. There should be one item with `3000 ms` label but in fact, the menu item has `initial` label, so the tray menu didn't get updated.
- Start clicking on that tray menu item until the app segfaults (normally 2-4 clicks, rarely up to 10 clicks).
Console output:
```
(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false". It will change to be "true" in Electron 9. For more information please check https://github.com/electron/electron/issues/18397
[3962:1213/042903.974947:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command
3000 ms
clicked { label: 'initial' }
clicked { label: 'initial' }
clicked { label: 'initial' }
clicked { label: 'initial' }
Segmentation fault (core dumped)
```
Number of `clicked { label: 'initial' }` lines count here represents how many times tray menu item was clicked before the app got crashed (normally 2-4 clicks, rarely up to 10 clicks). The click does nothing but printing to console https://github.com/vladimiry-playground/electron-quick-start-tray-issue-menu-dynamics/blob/785866857eec555404e1f3c5e0c0cfd0b1d73e8e/main.js#L51
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
### Additional Information
#21445 is a possibly related issue.
|
https://github.com/electron/electron/issues/21499
|
https://github.com/electron/electron/pull/21883
|
edafbc43e18fc5e015599049cd5e6007155c2e80
|
2743d60f52974ba5d36068fc879908fdb6f28c14
| 2019-12-13T01:49:52Z |
c++
| 2020-01-26T21:02:33Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,470 |
["spec-main/api-debugger-spec.ts"]
|
re-enable test: handles valid unicode characters in message
|
cc @deepak1556
|
https://github.com/electron/electron/issues/21470
|
https://github.com/electron/electron/pull/33227
|
108ee7037f09fd623f473af5b3ecd943b5f6014a
|
d79d3fc7d735b8b67a3121800d9c158d6e777af7
| 2019-12-11T00:17:50Z |
c++
| 2022-03-21T23:38:46Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,464 |
["build/args/all.gn", "patches/node/.patches", "patches/node/enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch"]
|
enable pointer compression and 31 bit smis
|
Ref https://github.com/electron/electron/pull/21000/commits/cefcf43ddf7df06b3b2adc20f61c4d3836f8789b
This means setting those flags in the .gypi file we ship in node headers so that native modules build with the same defines as the v8 we ship.
|
https://github.com/electron/electron/issues/21464
|
https://github.com/electron/electron/pull/21468
|
341df4a8c2494adb2f1e9724defaff361550bf0e
|
c535e0018785f301b7bfd73013732df64465ec8b
| 2019-12-10T22:03:57Z |
c++
| 2019-12-13T18:12:24Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,459 |
["shell/browser/native_window_views.cc", "spec-main/api-browser-window-spec.ts"]
|
Setting focusable:false breaks the focus event
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 6.1.5
* **Operating System:**
* Windows 10
* **Last Known Working Electron version:**
* ?
### Expected Behavior
If the window is focusable then the focus event should be triggered
### Actual Behavior
Setting the window initially to focusable: false and later to true again will not enable the focus events. Even when focusing the window, the event will never be triggered.
### To Reproduce
```
let browserWindow1 = new BrowserWindow({
show: false,
x: 1,
y: 1,
width: 800,
height: 700,
title: "test-title-1",
focusable: false,
});
browserWindow1.on("focus", () => {console.log("focus");});
browserWindow1.loadURL("http://www.google.com");
browserWindow1.setFocusable(true);
browserWindow1.show();
```
|
https://github.com/electron/electron/issues/21459
|
https://github.com/electron/electron/pull/21846
|
100a85f93ae11420ef3e7a6d3853d9c0503e3806
|
36fac7bfec0c7f4867d1b329b9490b85c06d1580
| 2019-12-10T15:27:28Z |
c++
| 2020-01-22T01:13:48Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,445 |
["shell/browser/ui/tray_icon_gtk.cc"]
|
No tray icon on Linux (electron@^8)
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 8.0.0-beta.4
* **Operating System:** Linux (tested on: Manjaro LXDE, Ubuntu 19.04/19.10 Gnome Shell)
* **Last Known Working Electron version:** 7.1.3
### Expected Behavior
Tray icon created.
### Actual Behavior
No tray icon created.
### To Reproduce
https://github.com/vladimiry-playground/electron-quick-start-tray-issue
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
The issue has been partially fixed within https://github.com/electron/electron/issues/21154
CC @codebytere
|
https://github.com/electron/electron/issues/21445
|
https://github.com/electron/electron/pull/21904
|
55ccca922d8cb102deb0eecbda4df635296fc05e
|
5f307381d2548a1567a16924cadd6cbac4145e33
| 2019-12-09T20:27:57Z |
c++
| 2020-01-28T15:17:45Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,440 |
["patches/chromium/.patches", "patches/chromium/fix_handling_non_client_pointer_events_from_pen_on_windows_10.patch"]
|
Cannot resize/maximize/restore/drag or close the window using pen on touchscreen devices
|
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
7.1.0
* **Operating System:**
Windows 10 pro
* **Last Known Working Electron version:**
n/a
### Expected Behavior
Window should respond to pen taps on the screen.
### Actual Behavior
Window does not respond.
### To Reproduce
Download or clone electron-quick-start project on a touchscreen laptop(surface book in my case) and try using pen to resize/maximize/restore/drag or close the window.
#### Clone the repository
git clone https://github.com/electron/electron-quick-start
##### Go into the repository
cd electron-quick-start
##### Install dependencies
npm install
##### Run the app
npm start
### Additional Information
I tried the latest vs code which is based on electron v6 and it works properly. All other apps on the machine also responds normally to pen taps.
|
https://github.com/electron/electron/issues/21440
|
https://github.com/electron/electron/pull/24042
|
7274467f733f1129eeb0155331f96f924f9ecfe5
|
d5f642938dc8a35fda2b419bab518978222c2390
| 2019-12-09T14:26:28Z |
c++
| 2020-06-12T14:26:16Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,438 |
["patches/chromium/printing.patch", "spec-main/api-web-contents-spec.ts"]
|
Enable print-preview specs on master
|
Disabled in https://github.com/electron/electron/pull/21000
Upstream change https://chromium-review.googlesource.com/c/chromium/src/+/1917685
|
https://github.com/electron/electron/issues/21438
|
https://github.com/electron/electron/pull/21783
|
b9eb68c0b45c3f8e0ab23bca1906089f23dcdc1e
|
1e99907acc359cdc59336fe5d6ca1759a8d9b9a2
| 2019-12-09T10:07:00Z |
c++
| 2020-01-16T05:05:36Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,427 |
["shell/browser/electron_browser_main_parts.cc", "shell/browser/electron_browser_main_parts.h"]
|
Always matches `prefers-color-scheme: light` media-query (no dark mode)
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.3 & 8.0.0-beta.4
* **Operating System:**
* Linux Manjaro 18.1.3
### Expected Behavior
Electron should behave like Chromium with `prefers-color-scheme` media-queries.
### Actual Behavior
Electron always matches `prefers-color-scheme: light` so OS dark-mode isn't selected in media-query.
### To Reproduce
I made an electron-fiddle [here](https://gist.github.com/dc86e8931bef1781db8fbd0a6faf76ee). You can reproduce issue by switching to dark theme in your OS. See `<link>` tags in `<head>`.
### Screenshots
This is a comparison of same web-page in electron 7.1.3 (right) and chromium 78.0.3904.97 (left) on Arch/Manjaro. I am switching between "Adwaita-dark" and "Adwaita" themes on gnome.
|
https://github.com/electron/electron/issues/21427
|
https://github.com/electron/electron/pull/23678
|
82924679fe0cfaf01544e204daf8f500d0d1f446
|
fdf40ce07aa9bb4532bce01b35cad074a00fca9b
| 2019-12-07T04:11:02Z |
c++
| 2020-05-21T22:41:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,410 |
["shell/browser/native_browser_view.cc", "shell/browser/native_browser_view.h", "shell/browser/native_browser_view_mac.mm", "shell/browser/native_browser_view_views.cc", "spec-main/fixtures/crash-cases/api-browser-destroy/index.js"]
|
App crashes when BrowserView tries to both resize and destroy itself (almost) simultaneously
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
I'm currently using BrowerView to act as a makeshift tab (so that I may have multiple "tabs" of my application open). When I create 20+ processes and shut them down (shutting them down calls view.destroy()) very quickly and _then_ right afterwards try to resize the window, the app crashes with Error 3221226525.
When I disable the call to view.destroy(), I no longer get this issue. This works, since Javascript garbage collection will collect the processes after a minute or two, but this solution seems a bit suboptimal and unreliable in the case where we may have weak references left over.
I tried to work around this by disabling resizing for those BrowserViews (via view.setAutoResize()) and _then_ calling view.destroy(), but this does not fix the issue.
* **Electron Version:**
* <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 --> 7.1.2
* **Operating System:**
* <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->Windows 10
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->N/A
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
Close many BrowserViews quickly and then Resize right afterwards --> Window should resize without crashing.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Close many BrowserViews quickly and then Resize right afterwards --> App crashes (if I don't resize, no crash).
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
As mentioned above, we need to create 20+ processes and shut them down (shutting them down calls view.destroy()) very quickly and _then_ right afterwards try to resize the window. The app should crash with Error 3221226525.
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
This problem exists in both Electron v5.0.0 and v7.1.2.
Question: Let's say I take the "don't destroy, let processes get garbage collected" route. Is it possible that the app will also crash during garbage collection if the user happens to resize just as a process is being destroyed?
Thank you for your time, and I look forward to hearing from you!
|
https://github.com/electron/electron/issues/21410
|
https://github.com/electron/electron/pull/25411
|
e0a25cb1e3a624e355739aa9edf2e422d7bfb97a
|
53aaeb7a16af591f2591a3c72242f9470e83006d
| 2019-12-06T00:19:46Z |
c++
| 2020-09-17T00:10:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,397 |
["patches/chromium/printing.patch"]
|
Print issue on Electron from v7 - Print only works once (window.print())
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
Not working since v7.00.
Tested on:
* v8.0.0-beta.4
* v7.0.0
* **Operating System:**
* macOS 10.14.5
* **Last Known Working Electron version:**
* v6.1.5
### Expected Behavior
That the ```window.print()``` will work, even after the first time.
Like in versions prior to v7.0.0
### Actual Behavior
The ```window.print()``` function only works one time.
After the first time, it's not working.
The print dialog appears but the actual printing is not.
### To Reproduce
Run ```window.print()``` twice.
On the Electron Fiddle app example, click on the Print Page and print.
After that first time, click on the Print Page button again and try to print again.
[Link to the Gist](https://gist.github.com/ChenAlon/1d2253dc2c5ad1201370700cd200b0fa)
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
[Link to video](https://drive.google.com/file/d/1QfXvhPVGuNv6Zvdn9JkbHGgXAklx2F-N/view?usp=sharing)
|
https://github.com/electron/electron/issues/21397
|
https://github.com/electron/electron/pull/21893
|
37feeb8e5ffafa60b5da731ad94e57a485b0f53a
|
c588658a0153a31ba234637c17aeea9823088355
| 2019-12-05T16:47:22Z |
c++
| 2020-01-27T18:54:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,385 |
["lib/browser/api/net.js", "spec-main/api-net-spec.ts"]
|
`ClientRequest` doesn't report upload progress in 7.1.3
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.3
* **Operating System:**
* macOS 10.15.1
* **Last Known Working Electron version:**
* 6.1.5
### Expected Behavior
`request.getUploadProgress()` returns correct information about upload progress after request has started.
### Actual Behavior
`request.getUploadProgress()` always comes as `{}`.
### Additional Information
I did some debugging, and it's very much likely that it got broken in https://github.com/electron/electron/pull/21244 refactoring. From what I see now is that `this._urlLoader` in net.js doesn't emit `upload-progress` event at all, thus `this._uploadProgress` always remains empty.
Setting `chunkedEncoding` to `false/true` doesn't help either.
I don't have minimal reproduction available right now, but will try to provide one ASAP.
|
https://github.com/electron/electron/issues/21385
|
https://github.com/electron/electron/pull/21388
|
dc9beda182856feadf0dea5747852e82e683f56f
|
092e00f7f025cda8e1212abf6067856f70f0154f
| 2019-12-04T21:38:24Z |
c++
| 2019-12-06T21:14:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,255 |
["shell/browser/net/proxying_url_loader_factory.cc", "shell/browser/net/proxying_url_loader_factory.h"]
|
"--ignore-connections-limit" commandLine switch stopped working in Electron@7
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 7.1.2
* **Operating System:** Ubuntu 18.04 x64
* **Last Known Working Electron version:** 6.x
### Expected Behavior
Setting the "ignore-connections-limit" commandLine switch for localhost should allow more than 4 connections to e.g. the gatsby development server, which limits it to that number. This is the behaviour in Electron@6
### Actual Behavior
The "ignore-connections-limit" seems to have no effect anymore in electron@7.
### To Reproduce
1. Run a gatsby local server, like https://github.com/gatsbyjs/gatsby-starter-hello-world
2. Launch this fiddle with electron@6, and see that all 6 iframes load the site: https://gist.github.com/Kilian/d35badc28200c3229b1028243433cf54
3. Launch the fiddle with electron@7, see that none of the iframes load anymore
4. Remove two iframes, launch with electron@7, see that the iframes now do load
### Note
Note that our documentation still mentions the flag as working: https://electronjs.org/docs/api/chrome-command-line-switches#--ignore-connections-limitdomains
|
https://github.com/electron/electron/issues/21255
|
https://github.com/electron/electron/pull/21286
|
149aaeba949b071324d939da3dab984a3cfbd621
|
4149d768900017a67421ffd579f0da44ee9ac802
| 2019-11-22T15:32:26Z |
c++
| 2019-11-26T21:27:33Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,231 |
["docs/api/web-contents.md", "lib/browser/api/web-contents.js"]
|
Return of webContents.getPrinters() has wrong type definition
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.2
* **Operating System:**
* macOS 10.14.6
* **Last Known Working Electron version:**
* 2.0.18
### Expected Behavior
The type definitions of the function return should be `PrinterInfo[]`, thus matching [`webRequest.getPrinters()`](https://electronjs.org/docs/api/web-contents#contentsgetprinters) documentation.
### Actual Behavior
`electron.d.ts` declares `getPrinters` as
```js
getPrinters(): void
```
### To Reproduce
A snippet to get printers
```js
const printers: PrinterInfo[] = mainWindow.webContents.getPrinters();
```
```sh
error TS2322: Type 'void' is not assignable to type 'PrinterInfo[]'.
```
### Screenshots
### Additional Information
One thing that I also noticed in the [implementation](https://github.com/electron/electron/blob/034f4d5734bb87ec28b21fd76decb162e8f45c8a/lib/browser/api/web-contents.js#L271) of the function is that there is no returned value when the printing is not enabled.
The current implementation is:
```js
WebContents.prototype.getPrinters = function () {
if (features.isPrintingEnabled()) {
return this._getPrinters()
} else {
console.error('Error: Printing feature is disabled.')
}
}
```
Maybe it should return an empty array when printing is disabled:
```js
WebContents.prototype.getPrinters = function () {
if (features.isPrintingEnabled()) {
return this._getPrinters()
} else {
console.error('Error: Printing feature is disabled.')
return [];
}
}
```
or update the function's return definition to be:
```js
getPrinters(): PrinterInfo[] | void
```
Please, let me know if this is something I can be of any assistance. I'm happy to provide a pull request to address it.
|
https://github.com/electron/electron/issues/21231
|
https://github.com/electron/electron/pull/21411
|
5bc8809d644382d15865fe09f90ea9a39615365d
|
4ac575416fe5d22a84c731e73da899b052553b41
| 2019-11-20T16:30:05Z |
c++
| 2019-12-06T20:36:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,203 |
["docs/api/browser-window.md"]
|
Typing in d.ts
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
7.1.1
* **Operating System:**
Linux/Windows/Mac
* **Last Known Working Electron version:**
6.1.4
### Expected Behavior
Currect type definition in electron.t.s
### Actual Behavior
Lines 1978+ in electron.d.ts [https://github.com/electron/electron/releases/download/v7.1.1/electron.d.ts](https://github.com/electron/electron/releases/download/v7.1.1/electron.d.ts) contain code like:
` on(event: 'will-move', listener: (event: Event, newBounds: ``Rectangle``) => void): this;
`
Where newBounds accepts string Rectangle instead of accepting object Rectangle.
### To Reproduce
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/21203
|
https://github.com/electron/electron/pull/21235
|
07b94ff5780868771721ed3f57930becea817a17
|
0cadf2846be05d1dfadd6274d2d989f13ef8f36a
| 2019-11-19T14:36:14Z |
c++
| 2019-11-21T19:12:03Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,189 |
["shell/browser/api/atom_api_browser_window.cc"]
|
white flash when focusing the app after occlusion (regression)
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7, 8
* **Operating System:**
* macOS
* **Last Known Working Electron version:**
* 6.1.x
### To Reproduce
Fiddle: https://gist.github.com/6b61ba6976b93de0d7260308f750ad10
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Additional Information
<!-- Add any other context about the problem here. -->
Regressed https://github.com/electron/electron/issues/19858
|
https://github.com/electron/electron/issues/21189
|
https://github.com/electron/electron/pull/21585
|
19ef7a0fc97cba575e64ccb47bbfc566f0c46fcb
|
a0a932826c6762d7255a59c77dbe062a5fa9cab7
| 2019-11-19T00:46:36Z |
c++
| 2020-01-13T00:56:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,168 |
["docs/api/structures/ipc-main-event.md"]
|
IPCMainEvent.reply throws odd expection according to the doc
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x ] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x ] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.1 <!-- (output of `node_modules/.bin/electron --version`) e.g. 4.0.3 -->
* **Operating System:**
* macOS Catalina <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:**
* <!-- (if applicable) e.g. 3.1.0 -->
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
no exception throws
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
throws odd exception
Error: Missing required channel argument
at WebContents../lib/browser/api/web-contents.js.WebContents.sendToFrame (electron/js2c/browser_init.js:3589:11)
at Object.event.reply (electron/js2c/browser_init.js:3730:18)
at eval (webpack:///./src/common/api/MainAPI.js?:295:15)
at fs.js:1186:7
at FSReqCallback.oncomplete (fs.js:153:23
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
The docs says: with any args
and in the source code requires an string value as the forced channel argument:
```
const addReplyToEvent = (event) => {
event.reply = (...args) => {
event.sender.sendToFrame(event.frameId, ...args)
}
}
WebContents.prototype.sendToFrame = function (frameId, channel, ...args) {
if (typeof channel !== 'string') {
throw new Error('Missing required channel argument')
} else if (typeof frameId !== 'number') {
throw new Error('Missing required frameId argument')
}
const internal = false
const sendToAll = false
return this._sendToFrame(internal, sendToAll, frameId, channel, args)
}
```
so if we call `event.reply({})` it throws Uncaught Exception: Error: Missing required channel argument
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/21168
|
https://github.com/electron/electron/pull/21185
|
145dd33da16525d4b8c60e847e0bb261d58fde6a
|
ea23f18e94bde3c0f1d8f7cf2f3536ce410e3a80
| 2019-11-18T10:27:46Z |
c++
| 2019-11-19T21:17:59Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,167 |
["shell/browser/api/electron_api_web_contents.cc", "spec-main/api-web-contents-spec.ts"]
|
Crash when print with 'margins' option
|
Electron Version: 7.1.1
Operating System: Windows 10 (1803)
If I set the 'margins' option when call webContents.print method,
The app will crash with no error message.
```js
let { remote } = require("electron");
let webContents = remote.getCurrentWebContents();
webContents.print(
{
margins: {
marginType: "custom",
top: 30,
bottom: 0,
left: 0,
right: 0
}
},
(success, errorType) => {
if (!success) console.log(errorType);
}
);
```
|
https://github.com/electron/electron/issues/21167
|
https://github.com/electron/electron/pull/22164
|
f97ce86d08da755be3e82f3afd77e5195d2a0e70
|
6ed396df1780a40fe47cf1aadc58e62a593e55b1
| 2019-11-18T10:09:10Z |
c++
| 2020-02-13T17:15:25Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,160 |
["docs/api/native-image.md"]
|
Wrong type definition for nativeImage.isMacTemplateImage
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.1
Although [`nativeImage.isMacTemplateImage`](https://github.com/electron/electron/blob/b3d44dbe6f49930af886aca6bbd8cef161000988/docs/api/native-image.md#nativeimageismactemplateimage-macos) is an instance property, it is defined with `static` in `electron.d.ts`:
```ts
static isMacTemplateImage: boolean;
```
|
https://github.com/electron/electron/issues/21160
|
https://github.com/electron/electron/pull/21166
|
4045852e6fa0c0e60a97134842fb2a2819041cae
|
c8ed22def32ab359c5df14f763611ac94ee0ce51
| 2019-11-17T17:01:50Z |
c++
| 2019-11-18T18:57:22Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,159 |
["lib/browser/api/dialog.js", "shell/browser/ui/message_box.h", "shell/browser/ui/message_box_win.cc"]
|
checkbox in dialog not working
|
### Issue Details
* **Electron Version:**
* 7.1.1
* **Operating System:**
* Windows 10 (1803)
* **Last Known Working Electron version:**
* 6.1.3
### Expected Behavior
dialog.showMessageBox
https://electronjs.org/docs/api/dialog#dialogshowmessageboxbrowserwindow-options
Returns Promise<Object> - resolves with a promise containing the following properties:
- response Number - The index of the clicked button.
- **checkboxChecked** Boolean - The checked state of the checkbox if checkboxLabel was set. Otherwise false.
### Actual Behavior
checkboxChecked do not change
|
https://github.com/electron/electron/issues/21159
|
https://github.com/electron/electron/pull/21248
|
d25256dcf56616cfb1699dd38c6e6c47d39bb858
|
5f365858c931cc4e0b021f8aaecca51ceeb22e68
| 2019-11-17T15:43:42Z |
c++
| 2019-11-27T07:39:07Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,112 |
["shell/browser/api/atom_api_web_contents.cc"]
|
TypeError: sender.emit is not iterable (cannot read property Symbol(Symbol.iterator))
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v8.0.0-beta.2
* **Operating System:**
* macOS 10.14.5
* **Last Known Working Electron version:**
* v6.1.X
### Expected Behavior
No warnings
### Actual Behavior
The warning
```
[28455:1113/114404.211707:ERROR:CONSOLE(3361)] "Uncaught TypeError: sender.emit is not iterable (cannot read property Symbol(Symbol.iterator))", source: electron/js2c/sandbox_bundle.js (3361)
```
is printed in the console constantly.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
|
https://github.com/electron/electron/issues/21112
|
https://github.com/electron/electron/pull/21419
|
8a06ef11cfef2bbf090818f722844968029ce5c1
|
5bc8809d644382d15865fe09f90ea9a39615365d
| 2019-11-13T19:47:29Z |
c++
| 2019-12-06T20:35:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,088 |
["lib/browser/init.ts", "shell/browser/native_window_views.cc", "spec-main/api-menu-spec.ts", "spec-main/fixtures/api/test-menu-null/main.js", "spec-main/fixtures/api/test-menu-null/package.json", "spec-main/fixtures/api/test-menu-visibility/main.js", "spec-main/fixtures/api/test-menu-visibility/package.json"]
|
BrowserWindow removeMenu method not working on v7.1.1
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
BrowserWindow method `removeMenu()` is not working on v7.1.1. The only change made was upgrading Electron version.
https://electronjs.org/docs/api/browser-window#winremovemenu-linux-windows
* **Electron Version:**
* 7.1.1
* **Operating System:**
* Windows 10 (1903)
* **Last Known Working Electron version:**
* v6.0.3
### Expected Behavior
Menu Bar not visible.<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
Menu Bar is visible.<!-- A clear and concise description of what actually happened. -->
### To Reproduce
For me, just update Electron version.
### Screenshots
With version 7.1.1:
With version 6.0.3:
|
https://github.com/electron/electron/issues/21088
|
https://github.com/electron/electron/pull/21436
|
7f6b308bf1afad31e9e614def47fa6f0bb4bf4f7
|
3cb0ed306b51077772c38acfd610fb25a0063a10
| 2019-11-12T08:52:05Z |
c++
| 2019-12-09T19:17:36Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,087 |
["docs/api/browser-window.md", "docs/api/web-contents.md"]
|
should doc contents.id with more details
|
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
this issue is actually about document enhancement.
quoted from https://electronjs.org/docs/api/web-contents#contentsid-readonly
> A Integer representing the unique ID of this WebContents.
this description is too simple, i think the following information should be documented here:
1. in what scope is this `id` unique ? within entire electron app or owner `BrowserWindow` ?
2. what algorithm is used to generate this unique `id` ?
|
https://github.com/electron/electron/issues/21087
|
https://github.com/electron/electron/pull/21101
|
1da9959f5760f22b08016073eb3f9d7fd80dfadb
|
07b94ff5780868771721ed3f57930becea817a17
| 2019-11-12T08:32:00Z |
c++
| 2019-11-21T19:11:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,062 |
["shell/browser/ui/tray_icon_cocoa.mm"]
|
Unable to click tray icon with VoiceOver
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [ x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [ x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.1.1
* **Operating System:**
* Mac OS 10.15.1
* **Last Known Working Electron version:**
* N/A
### Expected Behavior
When clicking tray icons using the VoiceOver screen reader, the tray click event should fire.
### Actual Behavior
Clicking the tray icon does nothing, unless a context menu is set using `tray.setContextMenu`, in which case the menu opens.
### To Reproduce
Basic demo of the issue (can be reproduced in Electron Fiddle):
https://gist.github.com/oysteinmoseng/bec736b1c2ceec3fa6e5a77d46d3ac08
To reproduce with VoiceOver, start VoiceOver (cmd+F5), navigate to the tray (VO + M M), and attempt to click the icon (VO + spacebar). VoiceOver will announce that the icon was pressed, but no click event will be fired.
|
https://github.com/electron/electron/issues/21062
|
https://github.com/electron/electron/pull/39352
|
1eb6e45a365fd7b73b23302662f29e465a698719
|
dc707ee93835b279ff67dbd5f80ce28a4b9df3e1
| 2019-11-09T16:46:07Z |
c++
| 2023-08-07T07:52:18Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,058 |
["docs/api/structures/printer-info.md", "shell/browser/api/atom_api_web_contents.cc"]
|
The printerinfo status does not determine whether the printer is online or offline
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [ ] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [ ] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [ ] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
when calling webContents.getPrinters(), printer status does not determine whether the printer is online or offline.
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
### Alternatives Considered
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/21058
|
https://github.com/electron/electron/pull/21081
|
8320160fe2c5d8a9b3f13f2965f4c58da0be4a46
|
b8ee8c4eee2e6e087e521a741479532a0fbee30d
| 2019-11-09T02:14:32Z |
c++
| 2019-11-13T05:31:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 21,018 |
["shell/browser/net/node_stream_loader.cc", "spec-main/api-protocol-spec.ts"]
|
Stream protocols and fs.createReadStream sometimes never complete in Electron 7
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.0.0-beta.4 - 8.0.0-beta.2
* **Operating System:**
* macOS 10.14.6, Windows 10
* **Last Known Working Electron version:**
* 7.0.0-beta.3
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
According to the docs, one should be able to register a stream protocol handler which serves files from the file system.
The following code snippet is suggested by the [docs](https://electronjs.org/docs/api/protocol#protocolregisterstreamprotocolscheme-handler-completion):
```
const { protocol } = require('electron')
const fs = require('fs')
protocol.registerStreamProtocol('atom', (request, callback) => {
callback(fs.createReadStream('index.html'))
}, (error) => {
if (error) console.error('Failed to register protocol')
})
```
The expected behavior is that Electron should read from the stream and (assuming no read errors etc.) serve a valid response for the custom protocol request.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
Starting with Electron 7.0.0-beta.4 it looks like the request sometimes randomly never completes on the Renderer side. This can be seen in the Network tab as well as by inspecting AJAX calls at runtime. The read stream seems to be created successfully, and the response starts to be sent back to the renderer, but the final state change never happens.
### To Reproduce
Run the following Fiddle to see the behavior change. In Electron < 7.0.0-beta4, the page can make an AJAX request to the custom scheme in a loop and print the contents. In Electron >= 7.0.0-beta4 the page can occasionally make a few AJAX requests, but it will eventually halt when one request never reaches a `XMLHttpRequest.DONE` state.
https://gist.github.com/33a9b357c606c7cbe7c2cac99bbda973
Good console output (7.0.0-beta3 and bellow) looks like:
```
index.html:22 ajaxStateChange readyState: 1 statusCode: 0
index.html:22 ajaxStateChange readyState: 2 statusCode: 200
index.html:22 ajaxStateChange readyState: 3 statusCode: 200
index.html:22 ajaxStateChange readyState: 4 statusCode: 200
index.html:25 // Just using this file as an example file to be served by the custom scheme handler
index.html:22 ajaxStateChange readyState: 1 statusCode: 0
index.html:22 ajaxStateChange readyState: 2 statusCode: 200
index.html:22 ajaxStateChange readyState: 3 statusCode: 200
index.html:22 ajaxStateChange readyState: 4 statusCode: 200
index.html:25 // Just using this file as an example file to be served by the custom scheme handler
index.html:22 ajaxStateChange readyState: 1 statusCode: 0
index.html:22 ajaxStateChange readyState: 2 statusCode: 200
index.html:22 ajaxStateChange readyState: 3 statusCode: 200
index.html:22 ajaxStateChange readyState: 4 statusCode: 200
index.html:25 // Just using this file as an example file to be served by the custom scheme handler
... and repeat
```
Bad console output (7.0.0-beta4+) looks like:
```
index.html:22 ajaxStateChange readyState: 1 statusCode: 0
index.html:22 ajaxStateChange readyState: 2 statusCode: 200
index.html:22 ajaxStateChange readyState: 3 statusCode: 200
index.html:22 ajaxStateChange readyState: 4 statusCode: 200
index.html:25 // Just using this file as an example file to be served by the custom scheme handler
index.html:22 ajaxStateChange readyState: 1 statusCode: 0
index.html:22 ajaxStateChange readyState: 2 statusCode: 200
index.html:22 ajaxStateChange readyState: 3 statusCode: 200
index.html:22 ajaxStateChange readyState: 4 statusCode: 200
index.html:25 // Just using this file as an example file to be served by the custom scheme handler
index.html:22 ajaxStateChange readyState: 1 statusCode: 0
index.html:22 ajaxStateChange readyState: 2 statusCode: 200
index.html:22 ajaxStateChange readyState: 3 statusCode: 200 <-- stop getting updates here
```
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
Network info for request that completes successfully:
Network info for request that never completes:
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/21018
|
https://github.com/electron/electron/pull/21733
|
7723c2c16d4daf9720e8710e62ebda6f560ad3d0
|
d68f17b32c3ef977cdca9a7f069a237ff4d4cdc2
| 2019-11-07T01:15:04Z |
c++
| 2020-01-13T18:28:21Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,929 |
["docs/api/browser-window.md", "spec/ts-smoke/electron/main.ts"]
|
BrowserWindow.setIcon wrong types
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
The TS types don't match behavior/docs. According to https://electronjs.org/docs/api/native-image, you can pass a string to set the window's icon, and you *can*. Running it works. There is an unexpected compile error, however.
* **Electron Version:**
```
$ npx electron --version
v7.0.0
```
* **Operating System:**
* **Last Known Working Electron version:**
N/A
### Expected Behavior
No TS type error.
<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
Following TS type error
> Argument of type '"foo.ico"' is not assignable to parameter of type 'NativeImage'.ts(2345)
<!-- A clear and concise description of what actually happened. -->
### To Reproduce
În renderer.ts
```ts
import { remote } from 'electron'
remote.getCurrentWindow().setIcon('foo.ico')
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/20929
|
https://github.com/electron/electron/pull/20950
|
d871598d20e07bb1cb9a2eb420838101461898d4
|
05de7277ab75b9bcc09a6071fe5273a7d23daac5
| 2019-11-02T08:40:38Z |
c++
| 2019-11-05T21:47:08Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,923 |
["shell/browser/api/atom_api_web_request.cc", "shell/browser/api/atom_api_web_request.h", "shell/browser/net/proxying_url_loader_factory.cc", "shell/browser/net/proxying_url_loader_factory.h", "spec-main/api-web-request-spec.ts"]
|
The response of the CORS POST request is empty when using webRequest
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
The response of the CORS POST request is empty.
* **Electron Version:** 7.x, 8.x
* **Operating System:** Linux (at least)
* **Last Known Working Electron version:** 6.1.3
### Expected Behavior
<!-- A clear and concise description of what you expected to happen. -->
The response of the CORS POST request is not empty.
### Actual Behavior
<!-- A clear and concise description of what actually happened. -->
The response of the CORS POST request is empty.
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
https://github.com/vladimiry-playground/electron-quick-start-custom-prtocol-cors-issue
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Additional Information
<!-- Add any other context about the problem here. -->
In v7 and v8, the `access-control-allow-origin` and `origin` headers are not shown as modified in the dev console. It shows `https://mail.protonmail.com` value but should be showing `scheme123://index.html` as v6 does.
|
https://github.com/electron/electron/issues/20923
|
https://github.com/electron/electron/pull/21099
|
af1e8a347ea9eb3a0ff4483f08c7a7b248729366
|
b02a20e4dc2597b8597d0acce04437ebf0926394
| 2019-11-01T20:08:12Z |
c++
| 2019-11-14T05:51:24Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,910 |
["lib/browser/api/exports/electron.ts", "lib/renderer/api/exports/electron.ts", "lib/sandboxed_renderer/api/exports/electron.ts"]
|
Electron 8 exports __esModule = true, breaking Webpack bundles
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 8.0.0-beta.1 & 8.0.0-beta.2
* **Operating System:**
* Windows 10 1909 build 18363.449
* **Last Known Working Electron version:**
* 7.0.0
### Expected Behavior
`require('electron').__esModule === undefined`
### Actual Behavior
`require('electron').__esModule === true`
### To Reproduce
- `npm init -y`
- `npm i electron@8`
- `echo "console.log(require('electron').__esModule === true)" > index.js`
- `npm run electron .`
Terminal will have `true` written.
### Additional Information
This breaks Webpack bundles because Webpack's require will check this property and return exports.default which obviously doesn't exist on Electron's exports object. Electron 7 doesn't have __esModule defined on its exports at all.
|
https://github.com/electron/electron/issues/20910
|
https://github.com/electron/electron/pull/20939
|
267821831c9a5e0556b07f6167d4390f14d287bd
|
ee7ce3954a3c43af26cee49933171619324f27ee
| 2019-11-01T11:15:23Z |
c++
| 2019-11-04T22:16:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,903 |
["docs/api/touch-bar-button.md", "lib/browser/api/touch-bar.js", "shell/browser/ui/cocoa/atom_touch_bar.mm"]
|
There is no API to disable TouchBarButton [macOS]
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
Currently we can't disable the TouchBarButton
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
Add API to disable TouchBarButton
### Alternatives Considered
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
### Additional Information
<!-- Add any other context about the problem here. -->
|
https://github.com/electron/electron/issues/20903
|
https://github.com/electron/electron/pull/20945
|
9a198e8ef434d5fb4f73f8516c9a866fcedde3d4
|
5b7382765c3fedc8c1b1d5354a1a4ae2e79dcb0c
| 2019-11-01T03:32:16Z |
c++
| 2019-11-05T23:56:36Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,900 |
["lib/browser/api/module-keys.js", "spec/api-remote-spec.js", "spec/static/main.js"]
|
Cannot access nativeTheme via electron.remote
|
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.0.0
* **Operating System:**
* macOS 10.14.6
### Expected Behavior
I tried the following to access the new nativeTheme module from my renderer process:
```
let electron = window.require('electron')
let { nativeTheme } = electron.remote
console.log(nativeTheme.shouldUseDarkColors)
```
I expected this to print true to the console since dark mode is enabled on my Mac.
### Actual Behavior
Instead I got an error saying cannot read shouldUseDarkColors property of undefined. I also tried console.log(electron.remote) and nativeTheme was not listed. It appears nativeTheme is not accessible from the renderer process via electron.remote. I have no problem accessing things like systemPreferences from electron.remote so I expected this to work.
|
https://github.com/electron/electron/issues/20900
|
https://github.com/electron/electron/pull/20938
|
ee7ce3954a3c43af26cee49933171619324f27ee
|
01e18c2fc343f7f554224ef66a04b971d0f4b878
| 2019-11-01T00:44:07Z |
c++
| 2019-11-04T22:17:03Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,855 |
["lib/browser/api/dialog.js", "shell/browser/ui/message_box.h", "shell/browser/ui/message_box_win.cc", "shell/common/gin_converters/message_box_converter.cc"]
|
dialog.showMessageBoxSync options noLink not work under windows 10, electron v7
|
dialog.showMessageBoxSync(getCurrentWindow(), {
type: "question",
title: "test title",
message: "test message",
buttons: ["OK", "Cancel"],
defaultId: 0,
cancelId: 1,
noLink: true
})
|
https://github.com/electron/electron/issues/20855
|
https://github.com/electron/electron/pull/21386
|
93802a7e6f3ab456f6661ec5206209badc553a0a
|
9e189eac71d7da94734715c0c665f1e8785bae42
| 2019-10-30T16:35:05Z |
c++
| 2019-12-05T21:38:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,850 |
["shell/browser/ui/tray_icon_cocoa.mm"]
|
Memory leak in Tray.setImage()
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
I am experiencing that the memory is not released when setting a new tray image using the tray class.
Therefore calling `Tray.setImage(...)` multiple times increases the used RAM of the app indefinitely.
* **Electron Version:**
* v7.0.0
* **Operating System:**
* macOS 10.15.0 <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
* **Last Known Working Electron version:** -
### Expected Behavior
That the memory is freed once a new image is set.
<!-- A clear and concise description of what you expected to happen. -->
### Actual Behavior
The used ram of the app keeps increasing.
<!-- A clear and concise description of what actually happened. -->
### To Reproduce
<!--
Your best chance of getting this bug looked at quickly is to provide an example.
-->
To reproduce the issue I created a simple and minimal example in a new repo:
https://github.com/D0miH/electron-bug-repo
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone [email protected]:D0miH/electron-bug-repo.git
$ yarn install
$ yarn start
```
-->
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
When letting the app run for about 5 minutes:
<img width="659" alt="Screenshot 2019-10-30 at 16 14 29" src="https://user-images.githubusercontent.com/36657497/67871339-7b786300-fb30-11e9-95de-e0c227a121b1.png">
<img width="208" alt="Screenshot 2019-10-30 at 16 14 40" src="https://user-images.githubusercontent.com/36657497/67871348-7fa48080-fb30-11e9-8ba5-af84e177f1e6.png">
### Additional Information
<!-- Add any other context about the problem here. -->
No additional information.
|
https://github.com/electron/electron/issues/20850
|
https://github.com/electron/electron/pull/20904
|
b194d5d0e22a8b8ff983b4827d4a057b20b7b454
|
ba47c9b9258bf290b510dc466d937a63806c1845
| 2019-10-30T15:17:26Z |
c++
| 2019-11-02T22:14:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,841 |
["docs/tutorial/installation.md"]
|
electron7 install error in mac os 10.15
|
when i install electron with npm i -D electron@latest
when node install.js the error happen:
(node:64243) UnhandledPromiseRejectionWarning: HTTPError: Response code 404 (Not Found)
at EventEmitter.<anonymous> (/Users/zz/workspace/zBase/electron-quick-start/node_modules/got/source/as-stream.js:35:24)
at EventEmitter.emit (events.js:210:5)
at module.exports (/Users/zz/workspace/zBase/electron-quick-start/node_modules/got/source/get-response.js:22:10)
at ClientRequest.handleResponse (/Users/zz/workspace/zBase/electron-quick-start/node_modules/got/source/request-as-event-emitter.js:155:5)
at Object.onceWrapper (events.js:300:26)
at ClientRequest.emit (events.js:215:7)
at ClientRequest.origin.emit (/Users/zz/workspace/zBase/electron-quick-start/node_modules/@szmarczak/http-timer/source/index.js:37:11)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:583:27)
at HTTPParser.parserOnHeadersComplete (_http_common.js:115:17)
at Socket.socketOnData (_http_client.js:456:22)
mac os: 10.15
node： 12.13.0
npm: 6.12.0
|
https://github.com/electron/electron/issues/20841
|
https://github.com/electron/electron/pull/21030
|
c4cc6bd1bfb8f62fda98893d57e07fbd8d975e76
|
145ecb85c2ea1757ae0c35e44ecc64c260d34024
| 2019-10-30T01:37:33Z |
c++
| 2019-11-08T20:39:47Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,795 |
["shell/browser/ui/file_dialog_gtk.cc"]
|
Labels of dialog.showOpenDialog() and dialog.showSaveDialog() wrong
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* 7.0.0
* **Operating System:**
* Ubuntu 18.04 (KDE Neon)
* **Last Known Working Electron version:**
* 6.0.12
### Expected Behavior
dialog.showOpenDialog() should have the default label "Open"
dialog.showSaveDialog() should have the default label "Save"
### Actual Behavior
The labels are erroneously switched.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
|
https://github.com/electron/electron/issues/20795
|
https://github.com/electron/electron/pull/20861
|
dfdf1b54c6f030ee47be6dd9f12f88f850c2b149
|
f0b0614dd79f741b5018c3187a438c24571c722e
| 2019-10-28T23:53:18Z |
c++
| 2019-10-31T14:55:39Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,788 |
["buildflags/BUILD.gn", "buildflags/buildflags.gni", "patches/chromium/command-ismediakey.patch"]
|
Media key global shortcut no longer working on macOS
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v8.0.0-beta.1, all versions from and including 6 seem to be affected
* **Operating System:**
* macOS 10.14.6 (18G103)
* **Last Known Working Electron version:**
* 5
### Expected Behavior
If an application is a trusted accessibility client and `globalShortcut.register("MediaPlayPause", handlerFn)` returns `true`, the registered `handlerFn` should be invoked whenever the play/pause key is pressed.
### Actual Behavior
The handler is not invoked.
### To Reproduce
```js
app.on("ready", () => {
const isTrusted = systemPreferences.isTrustedAccessibilityClient(true);
console.log("isTrustedAccessibilityClient", isTrusted);
const registered = globalShortcut.register("MediaPlayPause", () => {
console.log("MediaPlayPause pressed");
});
console.log("Registered MediaPlayPause?", registered);
const win = new BrowserWindow();
win.loadURL("http://example.com");
});
```
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone https://github.com/salomvary/electron-media-keys-bug -b another-bug
$ npm install
$ cd electron-media-keys-bug
$ npm start
```
When prompted, allow Terminal to control the computer, restart the app and repeat the test.
|
https://github.com/electron/electron/issues/20788
|
https://github.com/electron/electron/pull/21442
|
5cecc230fbfad1137c0dacb2d9a2f675b475db24
|
cbe1e3a1d091e210ccceae5c4c8b13877e1f3ab4
| 2019-10-28T20:56:21Z |
c++
| 2019-12-11T06:48:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,781 |
["spec/api-power-monitor-spec.ts"]
|
Enable powermonitor tests on Arm64 flavor of Linux
|
Its disabled in https://github.com/electron/electron/pull/20649/commits/e89b1afb11b508694031cc04966473ba2eca9684 , due to crashes in ci.
|
https://github.com/electron/electron/issues/20781
|
https://github.com/electron/electron/pull/36015
|
294f27900c20f9b6864e65faf261893fcadf5c07
|
b3073144010730890ba1fa1e3ce4169d7bb56619
| 2019-10-28T16:01:07Z |
c++
| 2022-10-13T14:09:09Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,771 |
["spec-main/api-desktop-capturer-spec.ts"]
|
Enable desktop capturer specs disabled in master
|
https://github.com/electron/electron/pull/20649/commits/ccf65f279dc22015921794bdf9938a7ef22c423e
https://github.com/electron/electron/pull/20314/commits/7c589aea808971bc6273ae7372fffa17a60fb6a9
https://github.com/electron/electron/pull/20314/commits/fee13e102c14418c6eaa88a5ca056d874302c251
/cc @electron/wg-upgrades
|
https://github.com/electron/electron/issues/20771
|
https://github.com/electron/electron/pull/33497
|
f0c22a770d131acb6117f6d07d86fb9b8b66476c
|
8ea0631b823aea7f01b1eb9e410ea74dbb857556
| 2019-10-28T00:50:59Z |
c++
| 2022-03-29T15:57:21Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,751 |
["shell/browser/api/electron_api_web_request.cc", "spec-main/api-web-request-spec.ts"]
|
webRequest.onBeforeSendHeaders callback response requestHeaders not optional in 7.0.0
|
<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:**
* v7.0.0
* **Operating System:**
* macOS
* **Last Known Working Electron version:**
* v6.1.2
### Expected Behavior
Additional headers sent without changes as documented
https://github.com/electron/electron/blob/v7.0.0/docs/api/web-request.md
> https://github.com/electron/electron/blob/v7.0.0/docs/api/web-request.md
```
<head></head><body><pre style="word-wrap: break-word; white-space: pre-wrap;">{
"headers": {
"Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3",
"Accept-Encoding": "gzip, deflate, br",
"Accept-Language": "en-GB",
"Addition-Header": "hello world",
"Host": "httpbin.org",
"Sec-Fetch-Mode": "navigate",
"Sec-Fetch-Site": "none",
"Sec-Fetch-User": "?1",
"Upgrade-Insecure-Requests": "1",
"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.146 Electron/6.1.2 Safari/537.36"
}
}
</pre></body>
```
### Actual Behavior
Additional headers removed and not sent to server.
```
<head></head><body><pre style="word-wrap: break-word; white-space: pre-wrap;">{
"headers": {
"Accept-Encoding": "gzip, deflate, br",
"Accept-Language": "en-GB",
"Host": "httpbin.org",
"Sec-Fetch-Mode": "navigate",
"Sec-Fetch-Site": "none",
"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3905.1 Electron/7.0.0 Safari/537.36"
}
}
</pre></body>
```
### To Reproduce
run following snippet:
https://gist.github.com/binux/3c2023793e1bf1ff03a8fcb24b026162
```
electron electron_bug.webRequest.onBeforeSendHeaders.js
```
<!--
For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report.
-->
<!--
If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes.
-->
<!--
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
```sh
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
```
-->
### Additional Information
<!-- Add any other context about the problem here. -->
Workaround will be change callback as `callback({ requestHeaders: details.requestHeaders })`.
|
https://github.com/electron/electron/issues/20751
|
https://github.com/electron/electron/pull/29798
|
0ad73ac423bcd787405ad619b06934ed47e13a3a
|
bc8cb75e4e7c1d216d8d72a5d53d353b18087282
| 2019-10-25T21:24:29Z |
c++
| 2021-06-22T06:08:52Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 20,746 |
["docs/api/web-contents.md", "shell/browser/api/electron_api_browser_window.cc", "shell/browser/api/electron_api_web_contents.cc", "spec-main/api-web-contents-spec.ts"]
|
beforeunload and unload do not fire when closing a window with a browser view
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
### Issue Details
* **Electron Version:** 5.0.7
* **Operating System:** Windows 10
### Expected Behavior
When I navigate a `BrowserView` to a page that has `beforeunload` and `unload` handlers, I expect that closing the window will cause them to fire.
### Actual Behavior
They do not fire when closing the window.
Notably, if I don't use `BrowserView` and just navigate the `BrowserWindow` to the page, those handlers will execute.
### To Reproduce
`npm start` the code below (in main.js). In the devtools that opens up, run `window.onbeforeunload = () => true;`, then close the window. In the working case, the window will not close. In the broken case that uses `BrowserView`, it will.
```
const { app, BrowserWindow, BrowserView } = require('electron')
function brokenCase() {
const mainWindow = new BrowserWindow();
const view = new BrowserView();
mainWindow.setBrowserView(view);
view.webContents.loadURL("https://google.com");
view.webContents.openDevTools();
}
function workingCase() {
const mainWindow = new BrowserWindow();
mainWindow.webContents.loadURL("https://google.com");
mainWindow.webContents.openDevTools();
}
app.on('ready', brokenCase)
```
Maybe related to [this comment](https://github.com/electron/electron/issues/19194#issuecomment-544407723)
|
https://github.com/electron/electron/issues/20746
|
https://github.com/electron/electron/pull/28382
|
e454bded3c978e792fd6c8fd647e4214719e8191
|
7d04f729d84f2da3aac1daf25b55a5070d308313
| 2019-10-25T18:17:05Z |
c++
| 2021-04-07T07:16:10Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.