status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,679 |
["script/lint.js"]
|
C++ linter doesn't support --fix argument
|
i'm not sure if cpplint has an option to auto-fix the issues it reports, but clang-format does & we should use it.
|
https://github.com/electron/electron/issues/14679
|
https://github.com/electron/electron/pull/14690
|
b8a8bf82ac161be899d713b1bd519fed8522a9bb
|
4f70f0e66a638c0db4830fb9ce552502d6fdcc9f
| 2018-09-19T00:28:18Z |
c++
| 2018-09-19T18:26:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,632 |
["atom/browser/native_window_views.cc", "atom/browser/native_window_views.h", "spec/api-browser-window-spec.js"]
|
Multiple calls to window.setEnabled behave differently on Win, Linux than on Mac
|
* Output of `node_modules/.bin/electron --version`: 2.0.0
* Operating System (Platform and Version): Windows 10
**Expected Behavior**
When I disable a window twice via `setEnabled(false)`, I expect the second disable to have no effect.
**Actual behavior**
The second disable is "queued" up, such that I am forced to enable the window twice to get back to normal.
**To Reproduce**
In the electronquickstart repo, in main.js' `createWindow()`, add these lines:
mainWindow.setEnabled(false);
mainWindow.setEnabled(false);
mainWindow.setEnabled(true);
The window will be disabled when launched.
You see the same issue if you do it in reverse:
mainWindow.setEnabled(true);
mainWindow.setEnabled(false); // this doesn't actually disable it, because the window was enabled from the getgo
If this is expected behavior, can the [docs](https://github.com/electron/electron/blob/master/docs/api/browser-window.md#winsetenabledenable) be updated to explain this behavior.
|
https://github.com/electron/electron/issues/14632
|
https://github.com/electron/electron/pull/15184
|
7cab7b6c7e4e0f9409372c9eea3aa6cd776d8edd
|
51f3fb9bdeee8de9b09aa4ba95ce20713d8bab9b
| 2018-09-14T18:50:08Z |
c++
| 2018-10-18T21:23:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,573 |
["DEPS", "spec/api-remote-spec.js"]
|
Enable "remote module remote promise emits unhandled rejection events in the renderer process" test
|
It has been disabled after the Chromium 67 upgrade.
|
https://github.com/electron/electron/issues/14573
|
https://github.com/electron/electron/pull/14603
|
d9c6dd0254a5bd773fda04be2704c7bb418b883e
|
a55fd1634982e8ce25174e6c3e5c6c6e99e8d373
| 2018-09-12T09:28:49Z |
c++
| 2018-09-13T06:32:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,570 |
["atom/browser/native_window_mac.mm"]
|
macOS window controls missing with 'hiddenInset' and macOS 10.12
|
* Affected version: All of Electron 3.0
* Operating System (Platform and Version): macOS 10.12 and below (Sierra and below)
* Last known working version: Electron 2.0.7
We've discovered that upgrading to Electron 3 results in missing macOS window controls on macOS 10.12 and below. We've isolated that issue to the Electron 3 update.
**Expected Behavior**
`titleBarStyle: 'hiddenInset'` should result in window controls being present.
**Actual behavior**
`titleBarStyle: 'hiddenInset'` results in missing window controls.
**To Reproduce**
https://gist.github.com/3948a9042e60aaa2fa191ef8258e458c
**Screenshots**
|
https://github.com/electron/electron/issues/14570
|
https://github.com/electron/electron/pull/14730
|
1d20057df37eb171c85297f9a90874e0f8d6e0ae
|
6f494b3c5841c7feadd4aecbaa9635b2467addda
| 2018-09-12T07:19:24Z |
c++
| 2018-09-20T17:24:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,568 |
["BUILD.gn", "atom/browser/resources/win/atom.manifest", "atom/browser/resources/win/disable_window_filtering.manifest", "atom/browser/resources/win/dpi_aware.manifest"]
|
Windows GN build does not recognize high DPI screens
|
* Output of `node_modules/.bin/electron --version`: `4.0.0-nightly.20180823`
* Operating System (Platform and Version): Windows
* Output of `node_modules/.bin/electron --version` on last known working Electron version (if applicable): `3.0.0-beta.10`
**Expected Behavior**
Window should not be blurry at high DPI
**Actual behavior**
It's blurry
**To Reproduce**
Just launch the default app on a high DPI screen and see how it's blurry, screenshot is attached.
**Screenshots**
**Additional Information**
This could be related to the GN build
cc @nornagon
|
https://github.com/electron/electron/issues/14568
|
https://github.com/electron/electron/pull/14596
|
22ab85c39ee80240a06bfcbabec7d4961bbd8f14
|
961147151f6b749a2028e5f55e3d266c4682240b
| 2018-09-12T06:18:39Z |
c++
| 2018-09-13T15:40:29Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,544 |
["docs/api/session.md", "docs/breaking-changes.md", "shell/browser/electron_permission_manager.cc"]
|
[C67] Review synchronous permission check implementation
|
See https://github.com/electron/electron/blob/54ad38526095f4a415ad75a1757feae4336c9db4/atom/browser/atom_permission_manager.cc#L213 and https://github.com/electron/electron/blob/54ad38526095f4a415ad75a1757feae4336c9db4/atom/browser/atom_permission_manager.cc#L246
Should probably call out to https://github.com/electron/electron/blob/54ad38526095f4a415ad75a1757feae4336c9db4/atom/browser/atom_permission_manager.cc#L231 and be documented as such
|
https://github.com/electron/electron/issues/14544
|
https://github.com/electron/electron/pull/19903
|
3db4e612f4ca34f996c68a0e3c0d5932ab735f1a
|
771e34a53a03bfaa8299a0eb28589baeae756a7b
| 2018-09-11T08:59:58Z |
c++
| 2020-12-07T23:44:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,501 |
["patches/common/chromium/accelerator.patch"]
|
Shift modifier in accelerator is not displayed in menu in 3.0.x
|
* Output of `node_modules/.bin/electron --version`: v3.0.0-beta.8
* Operating System (Platform and Version): Windows 10
* Output of `node_modules/.bin/electron --version` on last known working Electron version: v2.0.x
**Expected Behavior**
App menu should correctly display accelerators with the Shift modifier.
**Actual behavior**
Accelerators display without the Shift modifier in the app menu. For example, the accelerator `CmdOrCtrl+Shift+N` will show up as `Ctrl+N` on Windows, although pressing Ctrl+Shift+N functions as expected.
**How to reproduce**
```
const menu = Menu.buildFromTemplate([
{
label: 'Test',
submenu: [
{
label: 'Missing shift',
accelerator: 'CmdOrCtrl+Shift+N',
click: () => {
console.log('clicked');
}
}
]
}
]);
Menu.setApplicationMenu(menu);
```
Menu item will display the accelerator as `Ctrl+N`. Another example of a combination that doesn't display correctly is `Shift+f3`.
**Additional Information**
This is the same bug that was reported in https://github.com/electron/electron/issues/11429, which was previously fixed in https://github.com/electron/electron/pull/11589.
|
https://github.com/electron/electron/issues/14501
|
https://github.com/electron/electron/pull/14966
|
038b56e31e8e51ecd3fffdfcc74192c09fb7c7bd
|
d810f08b759d5c0a9223be6be73850852d204025
| 2018-09-08T04:01:26Z |
c++
| 2018-10-04T17:05:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,490 |
["atom/common/native_mate_converters/gfx_converter.cc", "docs/api/structures/point.md"]
|
getDisplayNearestPoint throws an error with not rounded numbers
|
* Output of `node_modules/.bin/electron --version`: 2.0.8
* Operating System (Platform and Version): macOS (reproducible on all platforms)
**Expected Behavior**
When using `electron.screen.getDisplayNearestPoint()` with a not rounded value (like 0.5), electron should round it properly, or at least not crash. (or it should be documented, with a clearer error)
**Actual behavior**
<img width="532" alt="screen shot 2018-09-07 at 14 43 42" src="https://user-images.githubusercontent.com/1311607/45219858-84fb9780-b2ac-11e8-8e7e-75ba8312f20b.png">
TypeScript did not catch this error because the value is still a number and there is no concept of "integer-only" variables in JS
**To Reproduce**
Anywhere on `app.ready`
``` javascript
const display = electron.screen.getDisplayNearestPoint({
x: 100.5, // HERE -> x_x
y: 100
});
```
|
https://github.com/electron/electron/issues/14490
|
https://github.com/electron/electron/pull/14604
|
7d7401987a1b5ab1ac7d7d21454ef6e3fbf3f78b
|
73a1a8b3f010b592cdcbfa28a927e5892a3a91a5
| 2018-09-07T12:48:07Z |
c++
| 2018-09-13T13:28:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,470 |
["atom/browser/api/atom_api_app.cc", "atom/browser/api/atom_api_app.h", "atom/browser/api/atom_api_app_mac.mm", "atom/browser/atom_browser_main_parts.cc", "atom/browser/atom_browser_main_parts.h", "atom/browser/atom_browser_main_parts_mac.mm", "docs/api/app.md", "filenames.gni"]
|
Inconsistent "appData" and "logs" path names
|
Electron v2.0.8
Mac and Windows
As package.json does not allow spaces in the name field, my app is named "MyApp". In my build settings my productName is set to "My App" so that the user sees the name with spaces.
Using app.getPath('appData') the app data path clearly uses the "name" and saves all data in a folder named "MyApp" in my library.
Using app.getPath('logs') the log path uses the "productName" field and saves all logs in a folder named "My App". This is inconsistent, and results in multiple folders being created instead of just 1.
Using third-party log apps such as "electron-store" saves logs to the folder "MyApp" along with the appData, so it seems it is just Electron's logs path that is wrong.
```
{
"name": "MyApp",
"version": "0.0.1",
"main": "./js/app.js",
"scripts": {
"start": "electron .",
"build": "electron-builder --dir -mw --ia32 --x64",
"ship": "electron-builder -mw --ia32 --x64 -p always",
"postinstall": "electron-builder install-app-deps"
},
"build": {
"appId": "com.my.app",
"productName": "My App"
```
|
https://github.com/electron/electron/issues/14470
|
https://github.com/electron/electron/pull/17841
|
841e31b7e63c9eddabc5f2cf0b89a46dbf545b02
|
0749dc4cc1bc4bfd4b9aa27ec51d72007d67d699
| 2018-09-05T20:00:39Z |
c++
| 2019-04-19T05:04:58Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,412 |
["atom/browser/api/atom_api_browser_window_mac.mm", "atom/browser/native_window_mac.mm", "docs/api/browser-window.md", "docs/api/frameless-window.md"]
|
customButtonsOnHover - buttons do not function on click
|
* Output of `node_modules/.bin/electron --version`: `[email protected]`
* Operating System (Platform and Version): macOS 10.13.6
* Output of `node_modules/.bin/electron --version` on last known working Electron version (if applicable): Unknown
**Expected Behavior**
Buttons maximize, minimize, close window
**Actual behavior**
Nothing happens.
http://recordit.co/mhd54NzzMz
**To Reproduce**
Unknown. Having this issue even with a nearly empty DOM
**Screenshots**
**Additional Information**
None so far
|
https://github.com/electron/electron/issues/14412
|
https://github.com/electron/electron/pull/15564
|
163361ee6a58ceca4717178fd0b677c5b7aae47c
|
45a937df0aff45c918eedf9c9dd09a85cb8d4c6a
| 2018-09-01T00:20:51Z |
c++
| 2018-12-10T19:05:30Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,383 |
["brightray/browser/inspectable_web_contents_impl.cc"]
|
Windows 10 webview DevTools open in a too small window
|
* Output of `node_modules/.bin/electron --version`: v3.0.0-beta.8
* Operating System (Platform and Version): Windows 10 10.0.16299 Build 16299
* Output of `node_modules/.bin/electron --version` on last known working Electron version (if applicable): v2.0.8
**Expected Behavior**
Webview DevTools should open in a window that is properly sized.
**Actual behavior**
Webview DevTools open in window with minimal size and are therefore not visible.
**To Reproduce**
**Edit** Works in BrowserWindow.webContents.openDevTools() Works **not** in webView.openDevTools()
**Screenshots**
**Additional Information**
Only reproducible on Windows 10 10.0.16299 Build 16299. Works correctly on MacOS High Sierra 10.13.4
|
https://github.com/electron/electron/issues/14383
|
https://github.com/electron/electron/pull/14922
|
b23c389f89ccb3ca218ca7b598c92ca8c218393e
|
74badfeb5621e48090103606bb78dd69c8a15ff5
| 2018-08-30T09:01:49Z |
c++
| 2018-10-02T14:56:33Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,346 |
["spec/api-browser-window-spec.js", "spec/fixtures/api/isolated-fetch-preload.js", "spec/fixtures/api/isolated-preload.js", "spec/fixtures/api/isolated.html", "spec/webview-spec.js"]
|
Flake: BrowserWindow module contextIsolation option with and without sandbox option recreates the contexts on reload
|
E.g.
https://circleci.com/gh/electron/electron/48472
https://circleci.com/gh/electron/electron/49939
https://circleci.com/gh/electron/electron/49943
```
AssertionError [ERR_ASSERTION]: { pageContext: [Getter/Setter],
preloadContext: [Getter/Setter] } deepEqual { preloadContext:
{ preloadProperty: 'number',
pageProperty: 'undefined',
typeofRequire: 'function',
typeof...
at ipcMain.once (/Users/distiller/project/src/electron/spec/api-browser-window-spec.js:3286:18)
at CallbacksRegistry.apply (/Users/distiller/project/src/out/Default/Electron.app/Contents/Resources/electron.asar/common/api/callbacks-registry.js:47:25)
at EventEmitter.ipcRenderer.on (/Users/distiller/project/src/out/Default/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:284:21)
at EventEmitter.emit (events.js:182:13)
```
|
https://github.com/electron/electron/issues/14346
|
https://github.com/electron/electron/pull/14394
|
3a79eacb6f44eadb6c17d725755d4278f62993dc
|
32158ca5dd5586a6cdb4c589639ea509fcff1ef0
| 2018-08-28T07:56:24Z |
c++
| 2018-08-31T20:51:29Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,340 |
["BUILD.gn", "atom/browser/api/atom_api_view.cc"]
|
gn: add missing enable_view_api build flag
|
It is present in the features.gypi but not in the BUILD.gn.
|
https://github.com/electron/electron/issues/14340
|
https://github.com/electron/electron/pull/14351
|
07d017dc0140eae59c0ff064d4e3258d542b82c6
|
7edd37bca153c824e56142d7dd0792820de49155
| 2018-08-27T20:44:08Z |
c++
| 2018-08-28T17:55:31Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,339 |
["BUILD.gn", "components/pepper_flash/BUILD.gn", "electron.gyp"]
|
gn: add missing enable_pepper_flash build flag
|
It is present in the features.gypi but not in the BUILD.gn.
|
https://github.com/electron/electron/issues/14339
|
https://github.com/electron/electron/pull/14349
|
2f759151d2a6873d505e70f33d79680466dc31e1
|
ccd63b5ed0e583596c97dbe24c7f42572f9a6bbe
| 2018-08-27T20:43:18Z |
c++
| 2018-08-29T08:39:47Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,288 |
["docs/api/web-frame.md"]
|
webFrame.executeJavaScriptInIsolatedWorld isn't well documented.
|
* Output of `node_modules/.bin/electron --version`: 2.0.8
* Operating System (Platform and Version): Windows 10 x64
**Expected Behavior**
executeJavaScriptInIsolatedWorld should be well documented
**Actual behavior**
executeJavaScriptInIsolatedWorld is barely documented
**To Reproduce**
Read the [webFrame documentation](https://electronjs.org/docs/api/web-frame#webframeexecutejavascriptinisolatedworldworldid-scripts-usergesture-callback).
**Additional Information**
If I enable contextIsolation in my app, how do I execute javascript into the correct context for a specific webview?
I understand that the JS needs to be akin to ```[{code: 'blahblahblah' }]```, but world_id doesn't seem to be the id from webContents, so what is it? Where do I obtain the correct id?
|
https://github.com/electron/electron/issues/14288
|
https://github.com/electron/electron/pull/14309
|
2a253c73dbaa9f1cb72b8385a645ec8f2b4898da
|
90545bda954015b93d18a582f6ae2635da388f16
| 2018-08-24T01:37:32Z |
c++
| 2018-08-25T19:48:57Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,261 |
["shell/browser/api/electron_api_menu_mac.mm"]
|
Having config menu popping up above bottom of windows instead of having to scroll.
|
**Is your feature request related to a problem? Please describe.**
I use VS Code maximized or full screen, and clicking on the config gear always bring a truncated menu. I'd rather have it in full and higher because I have to scroll every time.
I filed this previously on VS Code and they correctly redirected me here: https://github.com/Microsoft/vscode/issues/56921
**Describe the solution you'd like**
Having config menu popping up above bottom and expanded in full instead of having to scroll.
**Describe alternatives you've considered**
I can scroll instead.
**Additional context**
I'm using MacOS 10.13.16
Showing might help, please see my two screen shots.
Thank you for your time.
<img width="285" alt="44414137-088e5800-a53b-11e8-8228-76cda8f27744" src="https://user-images.githubusercontent.com/1154213/44468739-e99fcc80-a5f3-11e8-9259-809c696bee0a.png">
<img width="210" alt="44414136-07f5c180-a53b-11e8-9fc0-39286d6a14d3" src="https://user-images.githubusercontent.com/1154213/44468740-e99fcc80-a5f3-11e8-9278-4c1419fc3b88.png">
|
https://github.com/electron/electron/issues/14261
|
https://github.com/electron/electron/pull/35194
|
7b8fb2b07418c7bad6ce811ca75c926ee53663fc
|
afa4f5052bf5984821b01729a94dcd5b0e04d794
| 2018-08-22T14:15:16Z |
c++
| 2022-08-03T08:52:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,259 |
["docs/api/webview-tag.md"]
|
Webview: window.onfocus fired whenever clicking into webview
|
* Electron Version: 3.0.0-beta.6
* Operating System (Platform and Version): macOS
* Last known working Electron version: 3.0.0-beta.5
**Expected Behavior**
The `onfocus` event is not fired when contents inside the webview element is focused
**Actual behavior**
The `onfocus` event is not fired whenever focus moves between webview contents and page contents
**To Reproduce**
* run this fiddle: https://gist.github.com/bpasero/d53f48f04af6b4a94c284189079c246d
* click into the input box of the GitHub landing page
* observe that the `onfocus` event is emitted
* click into the page
* observe that the `onfocus` event is emitted again
This breaks VSCode's assumption about the entire window loosing or gaining focus.
|
https://github.com/electron/electron/issues/14259
|
https://github.com/electron/electron/pull/14401
|
32158ca5dd5586a6cdb4c589639ea509fcff1ef0
|
586a6f2e6d1b21e3f19df8596ec0629380a82b2b
| 2018-08-22T10:58:56Z |
c++
| 2018-08-31T20:52:09Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,252 |
["atom/browser/native_window_views.cc", "atom/browser/ui/views/root_view.cc", "atom/browser/ui/views/root_view.h", "spec/api-menu-spec.js"]
|
MenuItem Accelerators Not Working in Ubuntu 16.04.2 LTS for 3.0.0-beta.1~6
|
* Electron Version: 3.0.0-beta.1 ~ 3.0.0-beta.6
* Operating System (Platform and Version): Ubuntu 16.04.2 LTS
* Last known working Electron version: versions before 3.0.0-beta.1
**Expected Behavior**
Console prints out `time to print stuff` when `Ctrl+P` is pressed.
```
const {Menu, MenuItem} = require('electron')
const menu = new Menu()
app.on('ready', () => {
createWindow()
menu.append(new MenuItem({
label: 'Print',
accelerator: 'CmdOrCtrl+P',
click: () => { console.log('time to print stuff') }
}))
Menu.setApplicationMenu(menu)
})
```
https://github.com/hackjutsu/electron-quick-start/commit/6ceb5d7dcd2d946c071b43a3fdd1b0434ddebff5
**Actual behavior**
No output. The accelerator event is not triggered.
**To Reproduce**
```sh
git clone https://github.com/hackjutsu/electron-quick-start
cd electron-quick-start
npm install
npm run start
```
Try pressing `Ctrl+P`, and observe the output. (nothing happen...)
Change the electron version back to 2.0.0 in `pakcage.json`
```sh
npm install
npm run start
```
Try pressing `Ctrl+P`, and observe the output. (the log `time to print stuff` will show up in console)
|
https://github.com/electron/electron/issues/14252
|
https://github.com/electron/electron/pull/15094
|
9e2b7dbea54ccacd25731a8a49010ee439aea06d
|
5994bf6745d36c3ffb278e2067803fe0ea009322
| 2018-08-22T04:59:57Z |
c++
| 2018-11-09T21:54:16Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,246 |
["atom/app/atom_main.cc"]
|
GPU compositing bug on arm64
|
* Electron Version: [electron-v3.0.0-beta.5-linux-armv7l](https://github.com/electron/electron/releases/download/v3.0.0-beta.5/electron-v3.0.0-beta.5-linux-armv7l.zip)
* Operating System (Platform and Version): [debian stretch for armhf](https://dl.vamrs.com/products/rock960/images/debian/rock960_debian_stretch_desktop_armhf_20180115.tar.gz) on a 64 bit arm single board computer
* Target hardware: [rock960](https://www.96boards.org/product/rock960/)
* Last known working Electron version: none
**Expected Behavior**
Electron should be able to boot on it's default asar without crashing.
**Actual behavior**
When you boot electron on the target hardware it hangs and seems to be unable to do GPU compositing. When you disable GPU compositing, the system is able to start. Chromium 61 on the same board is able to GPU composite without issue. Just launching chromium 61 demonstrates this, but you can also see GPU rendering in action at https://get.webgl.org, for example.
**To Reproduce**
1. Get an arm 64 single board computer (we're using the rock 960)
2. Install the debian stretch for armhf (32 bit) image
3. open electron with it's default asar and watch it hang.
While we're using the rock960 (arm 64) board with the armhf build of debian stretch, we think this is reproducible on other arm64 boards running armhf. So far we've heard of this same bug reproducing with the same armhf build of debian stretch on a [Odroid XU4](https://www.hardkernel.com/main/products/prdt_info.php).
**Additional Information**
We realize that this may not be an electron bug, but rather an OS driver or other integration bug. We thought we should open this issue here in case this sounds familiar to anyone, or if there is anyone in the electron community who is able to help us further diagnose this issue.
Thank you for reading and for contributing to or maintaining the electron project! We really appreciate all your hard work, and are thankful for how great electron is for distributing node and chromium, and bringing the web platform to more places. Thanks again!
|
https://github.com/electron/electron/issues/14246
|
https://github.com/electron/electron/pull/15555
|
b97d7e7ecd6ed403cea700ab4aab0d0d20624f7f
|
51cb36fa9b2c9c829050b6612bc6770f048db245
| 2018-08-21T20:37:11Z |
c++
| 2018-11-19T16:53:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,211 |
["atom/browser/api/atom_api_web_contents.cc", "lib/browser/guest-view-manager.js", "lib/renderer/web-view/guest-view-internal.js", "lib/renderer/web-view/web-view.js", "vendor/libchromiumcontent"]
|
OOPIF webview freezes occasionally on navigation
|
* Electron Version: v3.0.0-nightly.20180818
* Operating System (Platform and Version): Windows 10 1803
* Last known working Electron version: v3.0.0-beta.5
**Expected Behavior**
webview will not be freezed
**Actual behavior**
webview freezed occasionlly on navigation
**To Reproduce**
1. clone https://github.com/KochiyaOcean/electron-bugs
2. run `electron .` using electron v3.0.0-nightly.20180818
3. run scripts below in devtools
```javascript
require('electron').remote.webContents.getAllWebContents()
```
there are 3 webcontents (BrowserWindow, WebView, DevTool)
4. run scripts below in devtools
```javascript
document.querySelector('webview').addEventListener('did-finish-load', () => document.querySelector('webview').loadURL('http://dmm.com'))
document.querySelector('webview').loadURL('http://dmm.com')
```
5. webview will freeze occasionally, and call any method of webview will throw an error
6. run `require('electron').remote.webContents.getAllWebContents()` again, and there are only 2 webcontents left (webcontents of webview is removed)
**Additional Information**
This bug occurs easier on complex websites, such as https://amazon.com , https://ebay.com , etc.
|
https://github.com/electron/electron/issues/14211
|
https://github.com/electron/electron/pull/14487
|
c7bec13069c98a14bfdad3e5c18c7822d43e167b
|
e96433243c34abb63911547578372c27c656321c
| 2018-08-20T04:30:52Z |
c++
| 2018-09-07T15:27:38Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,161 |
["shell/browser/window_list.cc"]
|
EXC_BAD_ACCESS: atom::WindowList::CloseAllWindows() [window_list.cc : 88 + 0x3]
|
* Electron Version: 2.0.5
* Operating System (Platform and Version): macOS
Data from our crash reporter shows this as one of the top crashes:
```
Package: VSCode
Version: 1.26.0
OS: Mac OS X 10.13.6 (17G65)
Operating system: Mac OS X
10.13.6 17G65
CPU: amd64
family 6 model 60 stepping 3
4 CPUs
GPU: UNKNOWN
Crash reason: EXC_BAD_ACCESS / EXC_I386_GPFLT
Crash address: 0x10ac4d8e6
Process uptime: 14298 seconds
Thread 0 (crashed)
0 Electron Framework!atom::WindowList::CloseAllWindows() [window_list.cc : 88 + 0x3]
rax = 0x6000000000000000 rdx = 0x00007ffee764fa88
rcx = 0x0000000000000000 rbx = 0x00006040002004d8
rsi = 0x0000000000003830 rdi = 0x00007fe126f490d0
rbp = 0x00007ffee764fc20 rsp = 0x00007ffee764fbf0
r8 = 0x00000000000003ff r9 = 0x000060000039c630
r10 = 0x00007fe127390a30 r11 = 0x00007fe127a6df10
r12 = 0x0000000000000064 r13 = 0x000060000017bc00
r14 = 0x00006040002004e0 r15 = 0x0000000000000000
rip = 0x000000010ac4d8e6
Found by: given as instruction pointer in context
1 Electron Framework!<name omitted> [browser.cc : 52 + 0x5]
rbp = 0x00007ffee764fc40 rsp = 0x00007ffee764fc30
rip = 0x000000010abfa516
Found by: previous frame's frame pointer
2 Electron Framework!-[AtomApplication terminate:] [atom_application.mm : 38 + 0x8]
rbp = 0x00007ffee764fc60 rsp = 0x00007ffee764fc50
rip = 0x000000010ac04e55
Found by: previous frame's frame pointer
3 AppKit + 0x404008
rbp = 0x00007ffee764fd00 rsp = 0x00007ffee764fc70
rip = 0x00007fff553ff008
Found by: previous frame's frame pointer
4 AppKit + 0x403e6d
rbp = 0x00007ffee764fd20 rsp = 0x00007ffee764fd10
rip = 0x00007fff553fee6d
Found by: previous frame's frame pointer
5 AppKit + 0x468c01
rbp = 0x00007ffee764fd40 rsp = 0x00007ffee764fd30
rip = 0x00007fff55463c01
Found by: previous frame's frame pointer
6 CoreFoundation + 0xa387c
rbp = 0x00007ffee764fd50 rsp = 0x00007ffee764fd50
rip = 0x00007fff57abf87c
Found by: previous frame's frame pointer
7 CoreFoundation + 0x86253
rbp = 0x00007ffee764fdd0 rsp = 0x00007ffee764fd60
rip = 0x00007fff57aa2253
Found by: previous frame's frame pointer
8 CoreFoundation + 0x858de
rbp = 0x00007ffee7650ac0 rsp = 0x00007ffee764fde0
rip = 0x00007fff57aa18de
Found by: previous frame's frame pointer
9 CoreFoundation + 0x85153
rbp = 0x00007ffee7650b50 rsp = 0x00007ffee7650ad0
rip = 0x00007fff57aa1153
Found by: previous frame's frame pointer
10 HIToolbox + 0x2fd96
rbp = 0x00007ffee7650ba0 rsp = 0x00007ffee7650b60
rip = 0x00007fff56d8bd96
Found by: previous frame's frame pointer
11 HIToolbox + 0x2fa0f
rbp = 0x00007ffee7650c20 rsp = 0x00007ffee7650bb0
rip = 0x00007fff56d8ba0f
Found by: previous frame's frame pointer
12 HIToolbox + 0x2f884
rbp = 0x00007ffee7650c40 rsp = 0x00007ffee7650c30
rip = 0x00007fff56d8b884
Found by: previous frame's frame pointer
13 AppKit + 0x41a73
rbp = 0x00007ffee7651080 rsp = 0x00007ffee7650c50
rip = 0x00007fff5503ca73
Found by: previous frame's frame pointer
14 AppKit + 0x7d7e34
rbp = 0x00007ffee7651300 rsp = 0x00007ffee7651090
rip = 0x00007fff557d2e34
Found by: previous frame's frame pointer
15 AppKit + 0x36885
rbp = 0x00007ffee76513b0 rsp = 0x00007ffee7651310
rip = 0x00007fff55031885
Found by: previous frame's frame pointer
16 Electron Framework!base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) [message_pump_mac.mm : 749 + 0xd]
rbp = 0x00007ffee7651410 rsp = 0x00007ffee76513c0
rip = 0x000000010de8e8fe
Found by: previous frame's frame pointer
17 Electron Framework!base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) [message_pump_mac.mm : 141 + 0xc]
rbp = 0x00007ffee7651440 rsp = 0x00007ffee7651420
rip = 0x000000010de8d2fc
Found by: previous frame's frame pointer
18 Electron Framework!<name omitted> [run_loop.cc : 111 + 0x5]
rbp = 0x00007ffee76514d0 rsp = 0x00007ffee7651450
rip = 0x000000010de301b3
Found by: previous frame's frame pointer
19 Electron Framework!content::BrowserMainLoop::MainMessageLoopRun() [browser_main_loop.cc : 1696 + 0x8]
rbp = 0x00007ffee7651540 rsp = 0x00007ffee76514e0
rip = 0x000000010c3900ef
Found by: previous frame's frame pointer
20 Electron Framework!content::BrowserMainLoop::RunMainMessageLoopParts() [browser_main_loop.cc : 1172 + 0x8]
rbp = 0x00007ffee7651570 rsp = 0x00007ffee7651550
rip = 0x000000010c38ff10
Found by: previous frame's frame pointer
21 Electron Framework!content::BrowserMainRunnerImpl::Run() [browser_main_runner.cc : 142 + 0x5]
rbp = 0x00007ffee7651590 rsp = 0x00007ffee7651580
rip = 0x000000010c0ca852
Found by: previous frame's frame pointer
22 Electron Framework!content::BrowserMain(content::MainFunctionParams const&) [browser_main.cc : 46 + 0x9]
rbp = 0x00007ffee76515c0 rsp = 0x00007ffee76515a0
rip = 0x000000010c47fb3c
Found by: previous frame's frame pointer
23 Electron Framework!content::ContentMainRunnerImpl::Run() [content_main_runner.cc : 686 + 0x8]
rbp = 0x00007ffee7651630 rsp = 0x00007ffee76515d0
rip = 0x000000010c01faa0
Found by: previous frame's frame pointer
24 Electron Framework!service_manager::Main(service_manager::MainParams const&) [main.cc : 469 + 0xa]
rbp = 0x00007ffee7651ab0 rsp = 0x00007ffee7651640
rip = 0x000000010e702da4
Found by: previous frame's frame pointer
25 Electron Framework!content::ContentMain(content::ContentMainParams const&) [content_main.cc : 19 + 0x8]
rbp = 0x00007ffee7651b30 rsp = 0x00007ffee7651ac0
rip = 0x000000010c01f084
Found by: previous frame's frame pointer
26 Electron Framework!AtomMain [atom_library_main.mm : 23 + 0x5]
rbp = 0x00007ffee7651bb0 rsp = 0x00007ffee7651b40
rip = 0x000000010ab50044
Found by: previous frame's frame pointer
27 Electron + 0xf26
rbp = 0x00007ffee7651bd0 rsp = 0x00007ffee7651bc0
rip = 0x00000001085aef26
Found by: previous frame's frame pointer
28 libdyld.dylib + 0x1015
rbp = 0x00007ffee7651be0 rsp = 0x00007ffee7651be0
rip = 0x00007fff7f8e2015
Found by: previous frame's frame pointer
```
|
https://github.com/electron/electron/issues/14161
|
https://github.com/electron/electron/pull/22948
|
a7469f82ac0ea35c91b4e95d61627f06eb70cf06
|
54f8c4e6a3cbb92212077a50bd7ba01e1ec03d13
| 2018-08-17T08:04:38Z |
c++
| 2020-04-08T03:41:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,160 |
["atom/browser/ui/message_box_mac.mm"]
|
Dialog does not close on ESCAPE if defaultId is set (Mac)
|
* Electron Version: ^2.0.6
* Operating System (Platform and Version): mac 10.12
* Last known working Electron version: -
**Expected Behavior**
Pressing the `escape` key should close the dialog.
**Actual behavior**
On macOS nothing happens when you press `escape` as long as your dialog has `defaultId` set.
On Linux and Windows everything works as expected.
**To Reproduce**
```sh
$ git clone https://github.com/0x6431346e/electron-dialog-bug
$ npm i
$ npm start
```
(The code is in the renderer file)
|
https://github.com/electron/electron/issues/14160
|
https://github.com/electron/electron/pull/14196
|
3715719b7262c91f877575f5153472031d1d4a5e
|
5b48e03c7ccf9f598105d651dd6edf59b1a744c5
| 2018-08-17T07:20:45Z |
c++
| 2018-08-19T20:41:03Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,127 |
["npm/install.js"]
|
[MAC] Electron rebuild issue on version v3.0.0
|
* Electron Version: `v3.0.0`
* Operating System (Platform and Version): `Mac`
* Last known working Electron version: `2.0.7`
**Expected Behavior**
Run `npm rebuild` should not fail
**Actual behavior**
```
$ npm rebuild
> [email protected] postinstall /Users/${user}/Desktop/ele/node_modules/electron
> node install.js
/Users/${user}/Desktop/ele/node_modules/electron/install.js:47
throw err
^
Error: EEXIST: file already exists, symlink 'Versions/Current/Electron Framework' -> '/Users/${user}/Desktop/ele/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Electron Framework'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/${user}/.npm/_logs/2018-08-16T11_03_51_217Z-debug.log
```
**To Reproduce**
```
$ npm install [email protected]
$ npm rebuild
```
|
https://github.com/electron/electron/issues/14127
|
https://github.com/electron/electron/pull/14177
|
466fe816d519696034e3be5565e00353095bb61d
|
59e118925a7c82dc075fb8d84805b84b551e2e8c
| 2018-08-16T11:34:52Z |
c++
| 2018-08-19T16:40:12Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 14,126 |
["docs/api/crash-reporter.md"]
|
companyName is a required option to crashReporter.start
|
* Electron Version: 2.0.7
* Operating System (Platform and Version): Linux 4.17.14-arch1-1-ARCH
**Expected Behavior**
`crashReporter.start` should work without setting the `companyName` field for the options parameter (as defined in https://github.com/tong/hxelectron/blob/fb01da3b1a3f454e3ff99f17e0ec09c00504bdc5/electron-api.json#L6576).
**Actual behavior**
```sh
A JavaScript error occurred in the main process
Uncaught Exception:
Error: companyName is a required option to crashReporter.start
at CrashReporter.start (/usr/lib/electron/resources/electron.asar/common/api/crash-reporter.js:40:13)
```
**To Reproduce**
https://github.com/tong/hxelectron/blob/fb01da3b1a3f454e3ff99f17e0ec09c00504bdc5/demo/src/Main.hx#L22
|
https://github.com/electron/electron/issues/14126
|
https://github.com/electron/electron/pull/14132
|
a58c7c74478f143c099702e0dac0e0d9f3a102c9
|
74426ad45edd5e7599b056eac828d000259204ca
| 2018-08-16T11:05:10Z |
c++
| 2018-08-16T16:22:16Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,969 |
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h", "spec/api-web-contents-spec.js", "spec/fixtures/api/is-currently-audible.html"]
|
isCurrentlyAudible() disabled because flaky
|
should be reenabled. cc @felixrieseberg
|
https://github.com/electron/electron/issues/13969
|
https://github.com/electron/electron/pull/14410
|
4d23e200f01aa33ccdbd6a3b04a5b04a65dca82f
|
8441d09a1808ee95a71849a141b85e479b2ae68e
| 2018-08-07T16:57:59Z |
c++
| 2018-09-05T21:00:05Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,943 |
["docs/tutorial/security.md"]
|
[Docs] security.md - Disable navigation example not working + typo
|
#13884 added **13) Disable or limit navigation** to tutorial docs (security.md) with the following example:
```
const URL = require('url')
app.on('web-contents-created', (event, contents) => {
contents.on('will-navigate', (event, navigationUrl) => {
const parsedUrl = new URL(navigationUrl)
if (url.hostname !== 'my-own-server.com') {
event.preventDefault()
}
})
})
```
However, I can't get this to work.
Is it just me being stupid or why is the const parsedUrl declared but not used?
Also typos for links: will-navigate and new-window
|
https://github.com/electron/electron/issues/13943
|
https://github.com/electron/electron/pull/13999
|
9a1ad2b93f774a6d46898abec862db8d5218f398
|
9005803667e7aa17e3c46f2f4e6fff16cc8024e7
| 2018-08-05T14:22:41Z |
c++
| 2018-08-09T15:04:03Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,913 |
["atom/browser/api/atom_api_top_level_window.cc", "atom/browser/api/atom_api_top_level_window.h", "atom/browser/native_window_views.cc", "spec/api-browser-window-spec.js", "spec/api-web-contents-spec.js"]
|
[3.0.x] Wrong focus when minimizing main window
|
**Electron Version:** v3.0.x
**OS:** Windows 10 (1803) x64
**Last known working Electron version:** v2.0.x
**Expected Behavior**
Minimizing the main window while child window is focused should minimize the main window and do nothing else.
**Actual behavior**
Minimizing the main window while a child window is focused changes focus to main window and brings the main window back up. Electron also tries to change the focus back to the child window afterwards and either fails to do so (Windows 10 focus bug?) or starts to constantly change the focus back and forth between the child and main window. The latter is happening with a singleInstance lock (happens with both the new and old syntax).
**To Reproduce**
Open Electron twice. Focus child (2.) window and minimize the main (1.) window.
Cannot reproduce on Linux. Works fine in v2.0.x.
**Additional Information**
App example for singleInstance lock. Opening the App a second time creates a new window without creating a second instance. Reproducing this way constantly changes the focus back and forth between the two windows.
```
const {app, BrowserWindow} = require('electron')
const path = require('path')
app.on('second-instance', (commandLine, workingDirectory) => {
let child = new BrowserWindow({
width: 1280,
height: 800,
title: "Child Window",
show: false,
autoHideMenuBar: true,
webPreferences: {plugins: true, sandbox: true}})
child.loadURL(`file://${__dirname}/index.html`);
child.once('ready-to-show', () => {child.show()})
child.on('page-title-updated', (e) => {e.preventDefault()})
child.on('closed', () => {child = null})
child.webContents.on('new-window', (event, url, frameName, disposition, options) => {
event.defaultPrevented = true;})})
if (!app.requestSingleInstanceLock()) {return app.quit()}
if(process.platform != 'linux') {app.enableMixedSandbox()}
app.on('ready', () => {
let win = new BrowserWindow({
width: 1280,
height: 800,
title: "Main Window",
show: false,
autoHideMenuBar: true,
webPreferences: {plugins: true, sandbox: true}
})
win.on('page-title-updated', (e) => {e.preventDefault()})
win.loadURL(`file://${__dirname}/index.html`);
win.once('ready-to-show', () => {win.show();win.maximize()})
win.on('closed', () => {win = null; app.quit()})
})
```
|
https://github.com/electron/electron/issues/13913
|
https://github.com/electron/electron/pull/14453
|
e96433243c34abb63911547578372c27c656321c
|
a2ab0d8ebe80909f0504d412ee492d658ca604ad
| 2018-08-02T14:26:53Z |
c++
| 2018-09-07T18:21:58Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,820 |
["shell/browser/api/atom_api_menu.h", "shell/browser/ui/atom_menu_model.h", "shell/browser/ui/tray_icon_cocoa.h", "shell/browser/ui/tray_icon_cocoa.mm"]
|
tray.popUpContextMenu blocks javascript main thread on mac
|
* Electron Version: latest
* Operating System (Platform and Version): mac
* Last known working Electron version: n/a
**Expected Behavior**
When the tray icon menu is popped up manually (but on a tray click event callback), I expect the menu to open up but not necessarily block the main process.
**Actual behavior**
It blocks the main process until the menu is closed. This is creating issues with other timers etc that I have running on the main process.
|
https://github.com/electron/electron/issues/13820
|
https://github.com/electron/electron/pull/18880
|
24ffc3cfb0e1ec02140b2bd83513cc6ff2af4fc7
|
dc2cd8e7806336361ffca3f04e783861bf2ece39
| 2018-07-26T13:54:55Z |
c++
| 2019-06-25T02:30:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,770 |
["atom/app/atom_main_delegate.cc"]
|
Re-enable mixed-sandbox tests for Windows CI
|
As described in https://github.com/electron/electron/pull/13769, we had to disable mixed sandbox related tests for Windows CI. We should re-enable them back after finding out the root reason.
|
https://github.com/electron/electron/issues/13770
|
https://github.com/electron/electron/pull/18199
|
5a7b56b042975c14c9c50d02801e0f80a3c3be3f
|
9c21c66b9760e11ec0bfc5b29a43f2c578d9896f
| 2018-07-23T09:04:51Z |
c++
| 2019-05-20T17:41:30Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,764 |
["atom/browser/web_contents_preferences.cc"]
|
No subpixel AA fonts rendered on Ubuntu Linux
|
* Electron Version: 3.0.0-beta.3
* Operating System Ubuntu 18.04
* Last known working Electron version: none ... still fails on 2.0.5
**Expected Behavior**
Font Subpixel AA should work... only works when rendering a .HTML file, not via BrowserWindow.
**Actual behavior**
Subpixel AA only works when I load a .html file.. not a .js file.
**To Reproduce**
https://github.com/burtonator/electron3-fuzzy-text
Here is a repo.
This works:
```
./node_modules/.bin/electron test.html
```
This will fail:
```
./node_modules/.bin/electron index.js
```
The only way to actually see that it's failing is to use a zoom tool like ```kmag```
**Screenshots**
Here's loading the .html file on the command line. Notice the AA is working by the orange color on the outside of the text:
Here is the SAME text and same test.html file but I loaded it via BrowserWindow in my index.js script.
Electron fails to use AA text rendering in the new window.
Hopefully this might help track down the bug.
|
https://github.com/electron/electron/issues/13764
|
https://github.com/electron/electron/pull/14932
|
319d9e519f9d8ee1646ee897b5017952c38b2f40
|
a1b2162563fa5c411eeab8f094502a2d378f15d7
| 2018-07-21T16:02:14Z |
c++
| 2018-10-03T03:09:18Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,754 |
["docs/api/menu-item.md", "lib/browser/api/menu.js", "spec/api-menu-spec.js"]
|
`Menu.buildFromTemplate()` should filter out falsy values
|
**Is your feature request related to a problem? Please describe.**
The behavior of `Menu.buildFromTemplate()` is quite undefined. If you give it an array with an empty object `[{}]` it will show nothing on macOS, but show an empty menu on Linux and Windows. If you give it `[null]` it will still show nothing on macOS, but throw an error on Linux: `TypeError: Cannot read property 'visible' of null`.
**Describe the solution you'd like**
Would be nice if `Menu.buildFromTemplate()` would just filter out falsy values so there are no surprises. I thought my conditional menu inclusion worked fine when I tested on macOS, but then tried on Linux and got an empty menu.
I'm aware I could filter it out myself, but I didn't realize it was an actual problem until long after because I develop on macOS and the problem was only visible on Windows and Linux.
**Describe alternatives you've considered**
If you don't like this idea, you should at least do stricter checks so it's not possible to specify anything other than an array of non-empty objects.
|
https://github.com/electron/electron/issues/13754
|
https://github.com/electron/electron/pull/13992
|
76a592a4198e9c21db0727f6fad9376f39227b35
|
5ea05ddee768893fb61ba63a1bfaf34807c22ba3
| 2018-07-20T14:56:12Z |
c++
| 2018-08-17T20:10:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,722 |
["atom/browser/ui/cocoa/atom_ns_window.h", "atom/browser/ui/cocoa/atom_ns_window.mm"]
|
Window title in third party app switcher
|
* Electron Version: 3.0.0.beta.3
* Operating System (Platform and Version): Mac OS X 10.13.6
* Last known working Electron version: 2.0.5
**Expected Behavior**
Window title (`document.title`) shows as window title using third party window switcher like [Contexts](https://contexts.co/)
**Actual behavior**
It shows app name (`Electron`) instead of window title
**To Reproduce**
1. Install contexts app or other window switcher that shows window titles
2. Clone and run untouched [electron-quick-start](https://github.com/electron/electron-quick-start) with `npm start`
3. Run app switcher and you see app with `Hello World!` title (see screenshot)
4. Install electron beta 3 `npm install --save-dev [email protected]` and run app again `npm start`
5. Run app switcher and you see app with `Electron` title (see screenshot)
**Screenshots**
Electron v2:
<img width="678" alt="ss1" src="https://user-images.githubusercontent.com/8137000/42895558-94145726-8aba-11e8-8c23-c9dcce152e06.png">
Electron Beta:
<img width="683" alt="ss2" src="https://user-images.githubusercontent.com/8137000/42895724-05a06fce-8abb-11e8-8f8a-7f42c774ef17.png">
**Additional Information**
I know is it some sort of corner case but it is still a regression plus this can indicate non-native windowing
|
https://github.com/electron/electron/issues/13722
|
https://github.com/electron/electron/pull/14472
|
53f7fd126dc80865bdbdbc41a95e98a40bfccde8
|
826af1d676f68c9fa871858c35339953099cda11
| 2018-07-18T16:49:22Z |
c++
| 2018-09-06T23:47:31Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,655 |
["atom/browser/api/frame_subscriber.cc", "atom/browser/api/frame_subscriber.h"]
|
Random crash in the main process when running tests
|
Electron Version: 3.0.0-beta.1
Operating System (Platform and Version): macOS
Last known working Electron version: 2.0.3
When running test on macOS, a random crash may happen in the main process:
```
Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 libcontent.dylib 0x000000010f75c36b 0x10f463000 + 3117931
1 libcontent.dylib 0x000000010f75be82 0x10f463000 + 3116674
2 libcontent.dylib 0x000000011439caff 0x10f463000 + 83073791
3 libcontent.dylib 0x000000011439c559 0x10f463000 + 83072345
4 com.apple.SkyLight 0x00007fffc9c0d677 displayWillConfigNotifyProc + 440
5 com.apple.SkyLight 0x00007fffc9c0dc1d displayAcceleratorChangedProc + 422
6 com.apple.SkyLight 0x00007fffc9d1508d CGSPostLocalNotification + 612
7 com.apple.SkyLight 0x00007fffc9d14ae4 (anonymous namespace)::notify_datagram_handler(unsigned int, CGSDatagramType, void*, unsigned long, void*) + 82
8 com.apple.SkyLight 0x00007fffc9cc48c9 CGSDatagramReadStream::dispatch_next_main_queue_datagram() + 283
9 com.apple.SkyLight 0x00007fffc9cc4799 ___ZN21CGSDatagramReadStream35dispatch_main_queue_datagrams_asyncEP16dispatch_queue_sPS__block_invoke + 55
10 libdispatch.dylib 0x00007fffcd818524 _dispatch_call_block_and_release + 12
11 libdispatch.dylib 0x00007fffcd80f8fc _dispatch_client_callout + 8
12 libdispatch.dylib 0x00007fffcd81caac _dispatch_main_queue_callback_4CF + 925
```
It seems to be related to GPU rendering, and I believe it is responsible for our flaky macOS CI.
|
https://github.com/electron/electron/issues/13655
|
https://github.com/electron/electron/pull/13657
|
ffc15e02a6ae480763d7d5a52bf0217467ba56de
|
77ca5b7d64afb0651ec606eeea3ddd0f2f68d8ef
| 2018-07-13T01:21:41Z |
c++
| 2018-07-13T09:54:49Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,652 |
["docs/api/app.md"]
|
`second-instance` event doesn't provide expected arguments
|
Electron Version: 3.0.0-beta.1
Platform: Windows 10
Documentation indicates the the arguments given to the event are the executing command line and the working directory as the second parameter. Instead I'm given the object below as the first argument, the executing command line as the second parameter, and the working directory as the third.
```
[Arguments] {
'0':
{ preventDefault: [Function: preventDefault],
sender:
App {
_events: [Object],
_eventsCount: 10,
_maxListeners: undefined,
whenReady: [Function: whenReady],
setApplicationMenu: [Function: setApplicationMenu],
getApplicationMenu: [Function: getApplicationMenu],
commandLine: [Object],
isPackaged: false,
allowNTLMCredentialsForAllDomains: [Function],
releaseSingleInstance: [Function],
makeSingleInstance: [Function] } },
'1':
[ 'C:\\Users\\computerquip\\Projects\\slobs\\slobs-staging\\node_modules\\electron\\dist\\electron.exe',
'.',
'--test' ],
'2': 'C:\\Users\\computerquip\\Projects\\slobs\\slobs-staging' }
```
|
https://github.com/electron/electron/issues/13652
|
https://github.com/electron/electron/pull/13656
|
ede6fd91d0e0c077bf60f1627f226fe94bd0e150
|
b44e7fb1f1da41cade2683d24ff0bfdc79a9ed3e
| 2018-07-12T20:26:29Z |
c++
| 2018-07-16T14:59:44Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,628 |
["atom/browser/api/atom_api_browser_window.cc", "atom/browser/api/atom_api_browser_window.h", "atom/browser/api/atom_api_browser_window_mac.mm", "spec/api-browser-window-spec.js"]
|
Electron crash during open DevTools on MacOS (v3.0.0-beta.2)
|
* Electron Version: v3.0.0-beta.2
* Operating System (Platform and Version): macOS 10.13.5
* Last known working Electron version: v3.0.0-beta.1
**Expected Behavior**
Launching DevTools
**Actual behavior**
Electron crash with current dump:
```
Crashing on exception: *** -[__NSArrayM objectAtIndex:]: index 1 beyond bounds [0 .. 0]
Application Specific Backtrace 1:
0 CoreFoundation 0x00007fff489d332b __exceptionPreprocess + 171
1 libobjc.A.dylib 0x00007fff6fb41c76 objc_exception_throw + 48
2 CoreFoundation 0x00007fff48a14634 _CFThrowFormattedException + 202
3 CoreFoundation 0x00007fff488f2290 __CFStringDecodeByteStream3 + 0
4 Electron Framework 0x000000010e7554c2 _ZN9brightray8IOThread7CleanUpEv + 2210
...
```
**Additional info**
`BrowserWindow` should contain `titleBarStyle` with `hiddenInset` value.
Full dump attached to [link](https://github.com/electron/electron/files/2185677/dump.txt)
|
https://github.com/electron/electron/issues/13628
|
https://github.com/electron/electron/pull/13673
|
5b81fde8a72cf2e69a10e9f5c4f0bea0a2b8c3e0
|
ede6fd91d0e0c077bf60f1627f226fe94bd0e150
| 2018-07-11T18:06:34Z |
c++
| 2018-07-16T13:39:16Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,620 |
["brightray/browser/platform_notification_service.cc"]
|
HTML5 Notifications broken in 3.0.0-beta
|
* Electron Version: 3.0.0-beta.1 or 3.0.0-beta.2
* Operating System (Platform and Version): macOS 10.13 (High Sierra)
* Last known working Electron version: 2.0.4
**Expected Behavior**
When a html5 notification is triggered from the renderer, a toast alert should appear
**Actual behavior**
No toast alert is appearing when a html5 notification is triggered from the renderer
**To Reproduce**
```sh
$ git clone https://github.com/VishwasShashidhar/electron-quick-start -b notifications-3beta
$ npm install
$ npm start || electron .
```
Click on the "send notification" button in the renderer.
**Screenshots**
***Working (2.0.4)***
***Not Working (3.0.0-beta.2)***
**Additional Information**
N/A
|
https://github.com/electron/electron/issues/13620
|
https://github.com/electron/electron/pull/13621
|
376094fc0c19de2715b7041d7059e3779ba552e7
|
addac43bbc398eddaffcaef071c6f8de95ccda27
| 2018-07-11T06:26:39Z |
c++
| 2018-07-11T17:21:47Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,618 |
["appveyor-gn.yml", "appveyor.yml"]
|
[3.0.0-beta.2] fetch fails with POST requests
|
* Electron Version: 3.0.0-beta.2
* Operating System (Platform and Version): Windows 10
* Last known working Electron version: 2.0.3
**Expected Behavior**
window.fetch should work with POST
**Actual behavior**
TypeError: Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body.
**To Reproduce**
Add this line of code:
```
// example uri for testing: 'https://httpbin.org/post'
let response = await fetch(uri, {method: 'POST', body: 'body'});
```
**Screenshots**
If applicable, add screenshots to help explain your problem.
|
https://github.com/electron/electron/issues/13618
|
https://github.com/electron/electron/pull/14081
|
3ac8aad495a68784d027660a310a3045dd4d5bc4
|
8c21762bee3036703d4ccc08f2b87f423d07035c
| 2018-07-11T01:53:08Z |
c++
| 2018-08-14T16:50:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,617 |
["atom/browser/api/atom_api_desktop_capturer.cc", "spec/api-desktop-capturer-spec.js"]
|
desktopCapture return only Entire screen and an invalid window (3.0.0-beta.2)
|
* Electron Version: 3.0.0-beta.2
* Operating System (Platform and Version): Current Windows 10, 64bit
* Last known working Electron version: 2.0.4
**Expected Behavior**
Full screen and all opened windows to be returned.
**Actual behavior**
Only full screen and a seemingly identical item are returned. Independent of the number of opened windows.
**To Reproduce**
Call
```
desktopCapturer.getSources({
types: ['window', 'screen'],
thumbnailSize: {
width: 250,
height: 250
}
}, function (err, sources) {
});
```
The `sources` contains only two items, the first one, which is the entire desktop screen is valid, the other one is not.
|
https://github.com/electron/electron/issues/13617
|
https://github.com/electron/electron/pull/13689
|
ad9e64d086d8a5d12a046b6a38ed54d371068ee2
|
777d0113d5a31d8d627225f35d79f1e391abdca2
| 2018-07-10T22:29:31Z |
c++
| 2018-07-17T04:20:50Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,608 |
["atom/renderer/api/atom_api_spell_check_client.cc", "atom/renderer/api/atom_api_spell_check_client.h", "spec/api-web-frame-spec.js", "spec/fixtures/pages/webframe-spell-check.html"]
|
Spellcheck-provider never called, spellchecking thus broken
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): macOS 10.13 (but all others seem affected, too)
* Last known working Electron version: 2.0.x
**Expected Behavior**
Spellchecking should work: After calling `webFrame.setSpellCheckProvider` with a given provider, that provider's `spellCheck()` method should be called.
**Actual behavior**
Calling `webFrame.setSpellCheckProvider` seems to have no effect - the provider is simply never called.
**To Reproduce**
Clone the repo below and start the app. The spellcheck provider is configured to log each input word. However, it appears that `spellCheck` is never called.
```sh
git clone https://github.com/felixrieseberg/electron-3-spellcheck
cd electron-3-spellcheck
npm install
npm start || electron .
```
|
https://github.com/electron/electron/issues/13608
|
https://github.com/electron/electron/pull/13616
|
6fbec9d5a962470590171c48aa639d603eea0c5d
|
bdceea6acaf87c61e4284ceca0ac8f8292d1f27a
| 2018-07-10T14:29:05Z |
c++
| 2018-07-11T17:27:56Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,596 |
["patches/common/chromium/.patches", "patches/common/chromium/color_chooser.patch", "patches/common/chromium/color_chooser_mac.patch", "patches/common/chromium/color_chooser_win.patch"]
|
Segmentation fault on color picker close
|
* Electron Version: 1.8.7
* Operating System (Platform and Version): macOS High Sierra (10.13.5)
* Last known working Electron version: Unsure
**Expected Behavior**
Electron application should not crash when a user closes the color picker in macOS.
**Actual behavior**
Occasionally (not every time) when the end user closes a native color picker (from `<input type="color" />`), the browser process crashes.
Sometimes the termination signal is a `Bus error: 10`:
```
Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x00007fff8b4060f0
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Bus error: 10
Termination Reason: Namespace SIGNAL, Code 0xa
Terminating Process: exc handler [0]
VM Regions Near 0x7fff8b4060f0:
unused shlib __DATA 00007fff8b3d4000-00007fff8b404000 [ 192K] rw-/rwx SM=COW system shared lib __DATA not used by this process
--> __DATA 00007fff8b404000-00007fff8b591000 [ 1588K] rw-/rwx SM=COW /usr/lib/libobjc.A.dylib
unused shlib __DATA 00007fff8b591000-00007fff8b59a000 [ 36K] rw-/rwx SM=COW system shared lib __DATA not used by this process
Application Specific Information:
Performing @selector(didChooseColor:) from sender NSColorPanel 0x7f90a462a5d0
Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 ??? 0x00007fff8b4060f0 OBJC_METACLASS_$_NSObject + 0
1 com.github.electron.framework 0x0000000106c029f4 0x106ab3000 + 1374708
2 com.apple.AppKit 0x00007fff28ab1a43 -[NSApplication(NSResponder) sendAction:to:from:] + 312
3 com.apple.AppKit 0x00007fff287defab __61-[NSColorPanel _forceSendAction:notification:firstResponder:]_block_invoke + 100
4 com.apple.AppKit 0x00007fff287dee15 -[NSColorPanel _withColorSettingDisabled:] + 37
5 com.apple.AppKit 0x00007fff287def41 -[NSColorPanel _forceSendAction:notification:firstResponder:] + 88
6 com.apple.AppKit 0x00007fff287df136 -[NSColorPanel setColor:] + 182
...
```
Other times it's a `Segmentation fault: 11`:
```
Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [0]
Application Specific Information:
Performing @selector(didChooseColor:) from sender NSColorPanel 0x7fd8d6f2ce60
Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 com.github.electron.framework 0x000000010d9cd760 ColorChooserMac::DidChooseColorInColorPanel(unsigned int) + 16
1 com.github.electron.framework 0x000000010d9cd9f4 0x10d87e000 + 1374708
2 com.apple.AppKit 0x00007fff28ab1a43 -[NSApplication(NSResponder) sendAction:to:from:] + 312
3 com.apple.AppKit 0x00007fff287defab __61-[NSColorPanel _forceSendAction:notification:firstResponder:]_block_invoke + 100
4 com.apple.AppKit 0x00007fff287dee15 -[NSColorPanel _withColorSettingDisabled:] + 37
5 com.apple.AppKit 0x00007fff287def41 -[NSColorPanel _forceSendAction:notification:firstResponder:] + 88
6 com.apple.AppKit 0x00007fff287df136 -[NSColorPanel setColor:] + 182
...
```
**To Reproduce**
The easiest way to reproduce is with the packaged application, which can be downloaded from the [GitHub releases page](https://github.com/mjswensen/themer-gui/releases/tag/v0.18.0).
I have not been able to reproduce the problem in development mode, but here is the information if it's helpful:
```sh
$ git clone [email protected]:mjswensen/themer-gui.git
$ npm install
$ npm start
```
1. Hover over a label to reveal the droplet icon.
- <img width="310" alt="screen shot 2018-07-09 at 4 42 29 pm" src="https://user-images.githubusercontent.com/1591879/42479676-37cf45ea-8397-11e8-93ca-db32b4706cfd.png">
2. Click the droplet icon to open the color picker.
3. Use the eyedropper tool to select a color from elsewhere on the screen.
- 
4. Click the red dot to close the color picker.
- 
This is the point the application crashes. (Try a few times if it doesn't happen the first time.)
**Screenshots**
**Additional Information**
The issue _appears_ to only manifest when the eyedropper is used, specifically when selecting colors from a different application. (I haven't seen a crash when the color picker sliders are used to select a color, for example.)
|
https://github.com/electron/electron/issues/13596
|
https://github.com/electron/electron/pull/17227
|
27336978193d4e09819811d7c334560a78afa5fc
|
5422fd9941219156edfe14f222ede567ee275b6b
| 2018-07-09T22:52:41Z |
c++
| 2019-03-07T01:55:15Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,558 |
["lib/browser/guest-view-manager.js", "lib/renderer/web-view/guest-view-internal.js", "lib/renderer/web-view/web-view-attributes.js", "lib/renderer/web-view/web-view.js", "spec/webview-spec.js"]
|
'will-attach-webview' is fired before `src` is set
|
* Electron Version: 2.0.x
* Operating System (Platform and Version): All
* Last known working Electron version: 1.8.x
**Expected Behavior**
['will-attach-webview'](https://github.com/electron/electron/blob/master/docs/api/web-contents.md#event-will-attach-webview) used to be fired only after an `src` attribute is set.
**Actual behavior**
'will-attach-webview' is fired when `src` is empty.
We use 'will-attach-webview' event in Teams to validate webview's url, and destroy a guest page if the url is not valid (by calling `event.preventDefault()` as described in the docs). This check is not possible to make with the new behaviour.
The change was made in 59476f0b30979a3bd895b68dbb4bcd24785b17ea in #11300.
/cc @zcbenz, @juturu
|
https://github.com/electron/electron/issues/13558
|
https://github.com/electron/electron/pull/13713
|
014832237c4636923834a8cb89bb5cc50a5868b9
|
9d6f1a372ed842d408c85ea75ce46dc2a8949132
| 2018-07-04T09:39:16Z |
c++
| 2018-07-21T02:11:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,549 |
["atom/browser/api/atom_api_top_level_window.cc", "atom/browser/api/atom_api_top_level_window.h", "atom/browser/native_window_views.cc", "spec/api-browser-window-spec.js", "spec/api-web-contents-spec.js"]
|
Temporary OS freeze and flickering when opening BrowserWindows simultaneously.
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): Windows 8/10 x64
* Last known working Electron version: 2.0.3
**Expected Behavior**
BrowserWindows should open and be functional. OS should react normally.
**Actual behavior**
BrowserWindows flicker (content and non-client area), the whole operating system seems to hang.
Problem can be resolved by opening the task manager, in this case the OS reacts normally and the faulty windows can be closed.
**To Reproduce**
Simply create and display two BrowserWindows. May require several attempts.
Alternatively, one can click the "Show Desktop" button (the rightmost button in the taskbar, right of the notifications icon) multiple times, the result is similar and does not even need that the windows are opened simultaneously.
Chance of effect increases when more BrowserWindows are open.
|
https://github.com/electron/electron/issues/13549
|
https://github.com/electron/electron/pull/14453
|
e96433243c34abb63911547578372c27c656321c
|
a2ab0d8ebe80909f0504d412ee492d658ca604ad
| 2018-07-03T13:29:00Z |
c++
| 2018-09-07T18:21:58Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,504 |
["lib/browser/api/web-contents.js"]
|
BrowserWindow.webContents.executeJavaScript does not work in 3.0.0-beta.1
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): Arch Linux x64
* Last known working Electron version: 2.0.3
on `did-finish-load` the following code is not executed at all:
```javascript
mainWindow.webContents.executeJavaScript(`console.log("hello world");`);
```
It was working with version 2.0.x
|
https://github.com/electron/electron/issues/13504
|
https://github.com/electron/electron/pull/13691
|
12fcac59a27605c86f959bcffad99a6588eacf58
|
ad9e64d086d8a5d12a046b6a38ed54d371068ee2
| 2018-06-29T12:06:41Z |
c++
| 2018-07-17T03:32:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,426 |
["atom/browser/api/atom_api_desktop_capturer.cc", "atom/browser/api/atom_api_desktop_capturer.h"]
|
[3.0.0-beta.1] desktopCapturer API is broken on Windows 7
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): Windows 7 SP1
* Last known working Electron version: 2.0.3
**Expected Behavior**
Desktop Capturer should work as expected on Windows 7.
**Actual behavior**
Desktop Capturer crashes Electron with the following debug output
```bash
[4180:0625/110943.169:WARNING:d3d_device.cc(48)] D3D11CreateDevice returns an in
stance without DirectX 11 support, level 40960. Following initialization may fai
l.
[4180:0625/110943.169:WARNING:dxgi_output_duplicator.cc(106)] Failed to duplicat
e output from IDXGIOutput1, error 000000000924BFB0, with code -2005270524
[4180:0625/110943.184:WARNING:dxgi_adapter_duplicator.cc(85)] Failed to initiali
ze DxgiOutputDuplicator on output 0
[4180:0625/110943.184:WARNING:dxgi_adapter_duplicator.cc(108)] Cannot initialize
any DxgiOutputDuplicator instance.
[4180:0625/110943.184:WARNING:dxgi_duplicator_controller.cc(259)] Failed to init
ialize DxgiAdapterDuplicator on adapter 0
[4180:0625/110943.184:WARNING:dxgi_duplicator_controller.cc(281)] Cannot initial
ize any DxgiAdapterDuplicator instance.
[4180:0625/110943.200:WARNING:dxgi_duplicator_controller.cc(82)] Count of refere
nces reaches zero, DxgiDuplicatorController will be unloaded.
[4180:0625/110943.356:WARNING:d3d_device.cc(48)] D3D11CreateDevice returns an in
stance without DirectX 11 support, level 40960. Following initialization may fai
l.
[4180:0625/110943.356:WARNING:dxgi_output_duplicator.cc(106)] Failed to duplicat
e output from IDXGIOutput1, error 000000000924B920, with code -2005270524
[4180:0625/110943.356:WARNING:dxgi_adapter_duplicator.cc(85)] Failed to initiali
ze DxgiOutputDuplicator on output 0
[4180:0625/110943.371:WARNING:dxgi_adapter_duplicator.cc(108)] Cannot initialize
any DxgiOutputDuplicator instance.
[4180:0625/110943.371:WARNING:dxgi_duplicator_controller.cc(259)] Failed to init
ialize DxgiAdapterDuplicator on adapter 0
[4180:0625/110943.371:WARNING:dxgi_duplicator_controller.cc(281)] Cannot initial
ize any DxgiAdapterDuplicator instance.
[4180:0625/110943.387:WARNING:dxgi_duplicator_controller.cc(82)] Count of refere
nces reaches zero, DxgiDuplicatorController will be unloaded.
[4180:0625/110943.621:WARNING:d3d_device.cc(48)] D3D11CreateDevice returns an in
stance without DirectX 11 support, level 40960. Following initialization may fai
l.
[4180:0625/110943.621:WARNING:dxgi_output_duplicator.cc(106)] Failed to duplicat
e output from IDXGIOutput1, error 000000000924B7E0, with code -2005270524
[4180:0625/110943.621:WARNING:dxgi_adapter_duplicator.cc(85)] Failed to initiali
ze DxgiOutputDuplicator on output 0
[4180:0625/110943.621:WARNING:dxgi_adapter_duplicator.cc(108)] Cannot initialize
any DxgiOutputDuplicator instance.
[4180:0625/110943.637:WARNING:dxgi_duplicator_controller.cc(259)] Failed to init
ialize DxgiAdapterDuplicator on adapter 0
[4180:0625/110943.637:WARNING:dxgi_duplicator_controller.cc(281)] Cannot initial
ize any DxgiAdapterDuplicator instance.
[4180:0625/110943.652:WARNING:dxgi_duplicator_controller.cc(82)] Count of refere
nces reaches zero, DxgiDuplicatorController will be unloaded.
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
(No symbol) [0x000000013FA4FDA8]
(No symbol) [0x000000013FB5C011]
(No symbol) [0x000000013FB8F55C]
(No symbol) [0x000000013FB8EA59]
(No symbol) [0x000000013FB87F94]
(No symbol) [0x000000013FB959D2]
BaseThreadInitThunk [0x00000000779059CD+13]
RtlUserThreadStart [0x0000000077A6383D+29]
error Command failed with exit code 3221225477.
```
**To Reproduce**
Clone this repo on Windows 7 and run it. It will instantly crash and print a stack trace:
```sh
# Clone this repository
git clone https://github.com/levinunnink/electron-quick-start.git
# Go into the repository
cd electron-quick-start
# Install dependencies
npm install
# Run the app
npm start
```
**Additional Information**
It looks like this commit is the culprit: https://github.com/electron/electron/pull/12417
|
https://github.com/electron/electron/issues/13426
|
https://github.com/electron/electron/pull/13543
|
f2a7fd44cead0ba9b2b5711a1b15b6660d269704
|
f8b646c90a60e336fe422b9c04b8a372fbdd23df
| 2018-06-25T18:17:19Z |
c++
| 2018-07-19T19:11:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,417 |
["atom/browser/browser_mac.mm", "spec/api-app-spec.js", "vsts.yml"]
|
setLoginItemSettings does not work in macOS Mojave
|
* Electron Version: All
* Operating System (Platform and Version): macOS Mojave
* Last known working Electron version: N/A
```js
app.setLoginItemSettings({ openAtLogin: false });
```
This does not work in Mojave
|
https://github.com/electron/electron/issues/13417
|
https://github.com/electron/electron/pull/15010
|
e61b88fc2ab443e62a3032079b4789a1f582a654
|
6fc2a2a051712ec063e52543e124f0e6c108d0ad
| 2018-06-25T16:08:11Z |
c++
| 2018-10-12T22:19:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,415 |
["atom/app/atom_main.cc"]
|
[v3.0.0-beta.1] gpu acceleration stopped working
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): Debian 9.1
* Last known working Electron version: 2.0.3
I'm trying the most basic thing: opening a browser window (e.g. just running https://github.com/electron/electron-quick-start )
**Expected Behavior**
I get to see the page
**Actual behavior**
Window seems to freeze immediately (never get to see the content). The window does emit the 'show' event and I don't see any errors.
I can make it work by disabling gpu usage (`app.disableHardwareAcceleration()`).
**To Reproduce**
Run https://github.com/electron/electron-quick-start with electron 3.0.0-beta.1. But it seems OS related, since it does work on my ubuntu 18.04...
I already tried upgrading:
- Mesa
- Libva
- intel-vaapi
- xserver-xorg-video-intel
But without luck.
I have no problems running chrome 66 with hardware acceleration, and there doesn't seem to be any relevant change in the GPU info with chrome 61. So it seems to be an electron thing. (gpu info for chrome 61/66: [chrome-gpu-info.zip](https://github.com/electron/electron/files/2154479/chrome-gpu-info.zip) )
|
https://github.com/electron/electron/issues/13415
|
https://github.com/electron/electron/pull/15555
|
b97d7e7ecd6ed403cea700ab4aab0d0d20624f7f
|
51cb36fa9b2c9c829050b6612bc6770f048db245
| 2018-06-25T13:04:54Z |
c++
| 2018-11-19T16:53:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,410 |
["vendor/libchromiumcontent"]
|
MAS Build rejected: App uses non-public APIs
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): macOS High Sierra 10.13.5
**Actual behavior**
Correctly packaged and signed app got rejected on the Mac AppStore. The current version 3.0.0-beta.1 didn't pass the review with the following message:
Your app uses or references the following non-public API(s):
'/System/Library/Frameworks/IOBluetooth.framework/Versions/A/IOBluetooth'
‘IOBluetoothPreferenceSetControllerPowerState’
'/usr/lib/libSystem.B.dylib'
‘APP_SANDBOX_READ’
‘dyld_dynamic_interpose’
‘sandbox_extension_consume’
‘sandbox_extension_issue_file’
‘sandbox_extension_release’
The use of non-public APIs is not permitted on the App Store as it can lead to a poor user experience should these APIs change.
|
https://github.com/electron/electron/issues/13410
|
https://github.com/electron/electron/pull/13529
|
eb223f8bc3bb131775b1b19881e0438be065bf17
|
cb6ab4de2023fca8eadbff45cd44031b8d622892
| 2018-06-25T08:18:59Z |
c++
| 2018-07-03T02:24:43Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,408 |
["brightray/browser/devtools_embedder_message_dispatcher.cc", "brightray/browser/devtools_embedder_message_dispatcher.h", "brightray/browser/inspectable_web_contents_impl.cc", "brightray/browser/inspectable_web_contents_impl.h", "spec/api-browser-window-spec.js"]
|
Dev tools extension tabs don't appear in 3.0.0-beta.1
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): macOS 10.13.5
* Last known working Electron version: 2.0.3
**Expected Behavior**
Dev tools extension tabs should appear after being added with the `BrowserWindow.addDevToolsExtension` API. I specifically tested the React and Redux extensions. I can tell the React extension is getting installed but not being shown because the usual
> Download the React DevTools for a better development experience
warning is absent.
**Actual behavior**
Dev tools extension tabs do not appear.
**To Reproduce**
Manually obtain the extension paths following the instructions here:
https://electronjs.org/docs/tutorial/devtools-extension
and supply them to `addDevToolsExtensions`.
Alternately, use [electron-devtools-installer](https://github.com/MarshallOfSound/electron-devtools-installer), which I have a repro case for using just Redux here:
https://github.com/ajmacd/electron-quick-start-typescript
Working with 2.0.3:
```sh
$ git clone https://github.com/ajmacd/electron-quick-start-typescript -b 2.0.3-devtools-working
$ cd electron-quick-start-typescript
$ npm install
$ npm start
```
Not working with 3.0.0-beta.1:
```sh
$ git checkout 3.0.0-beta.1-devtools-not-working
$ npm install
$ npm start
```
|
https://github.com/electron/electron/issues/13408
|
https://github.com/electron/electron/pull/13562
|
5aa136a23dcee67d9bf48579635179ee6fa46644
|
dd46b3ec854c505f8ddbf240d15fa697f7ffda7d
| 2018-06-25T00:27:44Z |
c++
| 2018-07-06T01:11:43Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,388 |
["vendor/node"]
|
fs.statSyncNoException throws exceptions in 3.0.0-beta.1
|
* Electron Version: 3.0.0-beta.1
* Operating System (Platform and Version): All
* Last known working Electron version: 2.x
**Expected Behavior**
`fs.statSyncNoException` to not throw errors
**Actual behavior**
`fs.statSyncNoException` throws errors, example below:
```
eferenceError: statsFromValues is not defined
at fs.statSyncNoException (fs.js:959:16)
at Object.fs.statSyncNoException (ELECTRON_ASAR.js:303:16)
at findPackageJson (/Users/x/code/x/foobar2/node_modules/electron-prebuilt-compile/lib/es6-init.js:25:20)
at main (/Users/x/code/x/foobar2/node_modules/electron-prebuilt-compile/lib/es6-init.js:44:23)
at Object.<anonymous> (/Users/x/code/x/foobar2/node_modules/electron-prebuilt-compile/lib/es6-init.js:61:1)
at Object.<anonymous> (/Users/x/code/x/foobar2/node_modules/electron-prebuilt-compile/lib/es6-init.js:63:3)
at Module._compile (internal/modules/cjs/loader.js:711:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:722:10)
at Module.load (internal/modules/cjs/loader.js:620:32)
at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
```
**To Reproduce**
```js
fs.statSyncNoException (__filename) // will throw
```
**Additional Information**
Originates from: https://github.com/electron/node/commit/71f8f8aa22d1af44bad645aad11a0b7d33aee96d
cc: @daviwil @jasonrudolph @codebytere @paulcbetts @alexeykuzmin
|
https://github.com/electron/electron/issues/13388
|
https://github.com/electron/electron/pull/13390
|
a96fc9170c6958184a56b9a123b00b935c1f8cd2
|
1c64ac8c41f2db71e18ebaf2e2735bbab08cf1b5
| 2018-06-22T17:17:59Z |
c++
| 2018-06-23T07:01:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,387 |
["atom/browser/api/atom_api_system_preferences.cc", "atom/browser/api/atom_api_system_preferences.h", "atom/browser/api/atom_api_system_preferences_mac.mm", "atom/browser/mac/atom_application.h", "atom/browser/mac/atom_application.mm", "default_app/default_app.js", "docs/api/system-preferences.md", "lib/browser/api/system-preferences.js"]
|
Add API's to support dark mode in Mojave
|
macOS Mojave adds a whole bunch of API's and utilities around a OS level concept of "dark mode", we should add API's to Electron that allow users to determine the current OS level "dark mode" setting and to configure the dark mode setting for the individual application.
#### Proposed APIs
```js
// Main Process
/**
* This API already exists but it should continue operating as it currently does
* on macOS < mojave and on >= mojave it should hit the the "effective appearance"
* API linked below and respond correctly.
**/
systemPreferences.isDarkMode()
/**
* This API should return the current appearance setting being applied to this app as a string enum.
* There are actually multiple different appearances that can be considered "dark mode"
* so users can use this method to figure out EXACTLY which appearance the system is
* using.
*
* By default this will return the OS level appearance settings, if users call `setAppLevelAppearance`
* it will start returning the appearance setting that was chosen. This behavior is controlled by macOS
**/
systemPreferences.getEffectiveAppearance()
/**
* Exactly the same as `getSystemAppearance()` but at the app level, each app on mojave
* can set it's "appearance" setting independently of the system, this allows individual apps
* to turn dark mode on / off for their app alone.
**/
systemPreferences.getAppLevelAppearance()
/**
* Setting but for app level appearance, this will set the `appearance` value so that mojave
* updates its rendering and will give dark mode / light mode to the app.
**/
systemPreferences.setAppLevelAppearance()
/**
* Self explanatory event, should be fired when the effective appearance changes
*/
systemPreferences.on('change-effective-appearance', (newAppearance) => {})
```
API Docs:
* [Effective Appearance](https://developer.apple.com/documentation/appkit/nsapplication/2967171-effectiveappearance?language=objc) - The current appearance being applied to this application.
* App Level [Appearance](https://developer.apple.com/documentation/appkit/nsapplication/2967170-appearance?language=objc) - The current app level setting for "dark mode"
* [Possible values for `NSAppearance`](https://developer.apple.com/documentation/appkit/nsappearancename?language=objc) - These are the enum values we will have to use for the `get` and `set` APIs
* [KVO](https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/KeyValueObserving/Articles/KVOBasics.html) - The reccomended strategy for monitoring changes on `effectiveAppearance`
* [Guidelines and reccomendations for supporting dark mode](https://developer.apple.com/documentation/appkit/supporting_dark_mode_in_your_interface?language=objc)
Notes:
* We will need to forward declare these API's, they are only in the `10.14` SDK
* Will need a Mojave machine to test these actually work 😆
#### Additional context
People like dark mode... 😄
|
https://github.com/electron/electron/issues/13387
|
https://github.com/electron/electron/pull/14755
|
8963529238972affaab4d10a2e5f50474241aac9
|
0d2a0c758353667aaf37450612585562a9ef1b55
| 2018-06-22T15:55:55Z |
c++
| 2018-09-27T15:33:31Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,381 |
["atom/browser/ui/views/menu_bar.cc", "patches/common/chromium/libgtkui_export.patch"]
|
[Linux] Menubar background color is always white
|
* Electron Version: 2.x, 3.x
* Operating System (Platform and Version): Linux
* Last known working Electron version: 1.8
**Expected Behavior**
I would expect the menubar's background color to use a background based on the GTK theme. Up to Electron 2.0 this used to work (albeit only for the light theme variant), see for example the screenshot below:
**Actual behavior**
In Electron 2.x and 3.x the menubar is always white. Using both the light and dark theme variant.
**To Reproduce**
This is reproducible for me with Electron Quick Start. Is it supposed to be this way or might this be caused by my Desktop configuration?
|
https://github.com/electron/electron/issues/13381
|
https://github.com/electron/electron/pull/14785
|
18c2574350f7ef2918eda08e16e9fd79443211f9
|
c9bc3471e7bf30c8b0a485c8d739f42a2aa071d8
| 2018-06-22T09:27:08Z |
c++
| 2018-09-25T20:57:06Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,373 |
["atom/browser/native_window_views.cc", "spec/api-browser-window-spec.js"]
|
Calling setResizable(false) and then setResizable(true) changes maximizible state of window
|
* Electron Version: 2.0.2
* Operating System (Platform and Version): Win10 x64 version 1803
* Last known working Electron version: 1.9.0
**Expected Behavior**
Calling win.setResizable(false) and then win.setResizable(true) should return the window to it's original state. Specifically, it should not change the result of win.isMaximizable().
**Actual behavior**
Calling win.setResizable(false) and then win.setResizable(true) results in the window not being maximizable. The maximize button is disabled and win.isMaximizable returns false.
**To Reproduce**
In any electron application with a window that is resizable, call win.setResizable(false) and then win.setResizable(true). The window will now be impossible to maximize.
|
https://github.com/electron/electron/issues/13373
|
https://github.com/electron/electron/pull/14648
|
c9bc3471e7bf30c8b0a485c8d739f42a2aa071d8
|
560b1c17af6fa42d42615b3a3ccbae73f5bbaf25
| 2018-06-21T21:07:37Z |
c++
| 2018-09-26T01:41:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,358 |
["atom/browser/api/atom_api_browser_window.cc", "atom/browser/api/atom_api_browser_window.h", "atom/browser/api/atom_api_browser_window_mac.mm", "atom/browser/native_window_mac.h", "atom/browser/native_window_mac.mm"]
|
[Bug] 3.0.0-beta1 CSS3 `-webkit-app-region: drag` not working
|
* Electron Version: 3.0.0-beta1
* Operating System (Platform and Version): macOS
* Last known working Electron version: 2.0.2
**Expected Behavior**
```css
html, body, * {
-webkit-app-region: drag;
-webkit-user-select: none;
cursor: default;
}
```
should allow users to move the position of the window by dragging it directly.
**Actual behavior**
The window is not draggable.
The `cursor` and `-webkit-user-select` properties work well.
**To Reproduce**
copy the CSS above, paste it into a frameless app's `<style>` tag, and run the app.
**Screenshots**
**Additional Information**
|
https://github.com/electron/electron/issues/13358
|
https://github.com/electron/electron/pull/13599
|
28d4f7f25acbc9e623a7135c3640c33076db179f
|
0ec4ad288d52f0eb7b25c664b307c592c057572b
| 2018-06-21T07:22:13Z |
c++
| 2018-07-10T01:43:42Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,344 |
["spec/api-browser-window-spec.js", "vendor/node"]
|
Enable disabled DevTools extensions tests
|
They have been disabled after the Chromium 66 upgrade.
- extensions and dev tools extensions
- BrowserWindow.addDevToolsExtension
- for a valid extension / *
- works when used with partitions
This console message is probably related to the failures:
> `ERROR:CONSOLE(17)] "Uncaught (in promise) TypeError: Cannot read property 'setMainWidget' of undefined", source: chrome-devtools://devtools/bundled/inspector.js`
|
https://github.com/electron/electron/issues/13344
|
https://github.com/electron/electron/pull/13584
|
17fc7bb9fd6381c417f00ccde2af574590dbd85f
|
35b867ff7d01d15ed1bdbdd4cabb63f245ad39c9
| 2018-06-20T16:10:21Z |
c++
| 2018-07-09T14:38:48Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,309 |
["spec/chromium-spec.js", "spec/package-lock.json", "spec/package.json"]
|
Update Mocha to v5
|
https://github.com/mochajs/mocha/releases
We use v3 right now.
|
https://github.com/electron/electron/issues/13309
|
https://github.com/electron/electron/pull/13310
|
1a8c986fb15ef2c93f8994aa6a5c4af11813e6a2
|
562eddf0e9937f91e1635d0c34ab9054fd1ff56f
| 2018-06-19T21:14:00Z |
c++
| 2018-06-20T07:18:24Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,308 |
["electron.gyp"]
|
MAS release build fails on linking
|
Build from latest master, commit https://github.com/electron/electron/commit/fc12b5cab330fa14456401d40917eb5bd5beb911:
```
2018-06-19T19:11:53.9416500Z Undefined symbols for architecture x86_64:
2018-06-19T19:11:53.9436030Z "crashpad::Annotation::Clear()", referenced from:
2018-06-19T19:11:53.9456690Z media::CdmAdapter::Decrypt(media::Decryptor::StreamType, scoped_refptr<media::DecoderBuffer> const&, base::RepeatingCallback<void (media::Decryptor::Status, scoped_refptr<media::DecoderBuffer> const&)> const&) in libmedia.a(cdm_adapter.o)
2018-06-19T19:11:53.9479000Z media::CdmAdapter::DecryptAndDecodeAudio(scoped_refptr<media::DecoderBuffer> const&, base::RepeatingCallback<void (media::Decryptor::Status, std::__1::list<scoped_refptr<media::AudioBuffer>, std::__1::allocator<scoped_refptr<media::AudioBuffer> > > const&)> const&) in libmedia.a(cdm_adapter.o)
2018-06-19T19:11:53.9501300Z media::CdmAdapter::DecryptAndDecodeVideo(scoped_refptr<media::DecoderBuffer> const&, base::RepeatingCallback<void (media::Decryptor::Status, scoped_refptr<media::VideoFrame> const&)> const&) in libmedia.a(cdm_adapter.o)
2018-06-19T19:11:53.9522060Z "crashpad::Annotation::SetSize(unsigned int)", referenced from:
2018-06-19T19:11:53.9542330Z (anonymous namespace)::ZombieObjectCrash(objc_object*, objc_selector*, objc_selector*) in libcomponents.a(objc_zombie.o)
2018-06-19T19:11:53.9563080Z void crash_reporter::SetCrashKeyStringToStackTrace<1024u>(crashpad::StringAnnotation<1024u>*, base::debug::StackTrace const&) in libcomponents.a(objc_zombie.o)
2018-06-19T19:11:53.9584490Z discardable_memory::DiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory(int, unsigned long, int, base::SharedMemoryHandle*) in libcomponents.a(discardable_shared_memory_manager.o)
2018-06-19T19:11:53.9605670Z discardable_memory::DiscardableSharedMemoryManager::DeletedDiscardableSharedMemory(int, int) in libcomponents.a(discardable_shared_memory_manager.o)
2018-06-19T19:11:53.9626350Z discardable_memory::DiscardableSharedMemoryManager::ClientRemoved(int) in libcomponents.a(discardable_shared_memory_manager.o)
2018-06-19T19:11:53.9647220Z discardable_memory::DiscardableSharedMemoryManager::ReduceMemoryUsageUntilWithinLimit(unsigned long) in libcomponents.a(discardable_shared_memory_manager.o)
2018-06-19T19:11:53.9676260Z gpu::SetKeysForCrashLogging(gpu::GPUInfo const&) in libchromiumcontent.a(gpu_util.o)
2018-06-19T19:11:53.9695750Z ...
2018-06-19T19:11:53.9714820Z ld: symbol(s) not found for architecture x86_64
2018-06-19T19:11:53.9737180Z clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
/cc @jkleinsc
|
https://github.com/electron/electron/issues/13308
|
https://github.com/electron/electron/pull/13334
|
55d1dde0f7071c6215521f5f077dd6803b5082eb
|
552399af2f0e1c7ba4d57704fba44a8281051b8b
| 2018-06-19T21:07:52Z |
c++
| 2018-06-20T13:59:46Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,289 |
["atom/browser/ui/accelerator_util.cc"]
|
Wrong state of event object properties in MenuItem callback
|
* Electron Version: 2.0.0
* Operating System (Platform and Version): Fedora 25
* Last known working Electron version:
Didn't tested all previous versions, however the bug is already present in 1.7.8
**Expected Behavior**
I'm currently trying to figure out if a `MenuItem` was triggered through the accelerator. This is possible to achieve through the information available in the `event` object of the `click` callback.
The structure seems to be the following but isn't currently [documented](https://electronjs.org/docs/api/menu-item).
```js
{
shiftKey: boolean;
ctrlKey: boolean;
altKey: boolean;
metaKey: boolean;
}
```
When a menu item is triggered through the accelerator, the corresponding flags should normally be set to `true`.
**Actual behavior**
This seems to work fine on MacOS. However, on both Windows (10) and Linux (Fedora 25) all this flags are always `false`.
**To Reproduce**
I quickly setup a [repository](https://github.com/njakob/electron-menuitem-bug) to test the current behavior and how to reproduce it.
```sh
$ git clone https://github.com/njakob/electron-menuitem-bug
$ npm install
$ npm start
```
On Fedora 25:
```js
{ shiftKey: false, ctrlKey: false, altKey: false, metaKey: false }
```
While on MacOS:
```js
{ shiftKey: false, ctrlKey: true, altKey: false, metaKey: false }
```
|
https://github.com/electron/electron/issues/13289
|
https://github.com/electron/electron/pull/14830
|
40bc4afcb3e32828a8adab797f7d523e086eef2a
|
0e1365fc94732e76c49ff55c6e0911c1f54e668e
| 2018-06-19T07:41:26Z |
c++
| 2018-09-28T11:59:00Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,279 |
["shell/browser/api/electron_api_menu_mac.mm"]
|
Select box near top of screen opens upwards, leaving little space for the items (and a scrollbar)
|
I [raised this against VS Code](https://github.com/Microsoft/vscode/issues/52194), but they advise it's Electron's doing. When I go to select a debug session and there are several, the dropdown menu grows upwards but there's limited space on the screen so it ends up being quite difficult to use.
* Electron Version: 1.7.12
* Operating System (Platform and Version): macOS High Seirra
* Last known working Electron version: Unknown
**Expected Behavior**
Drop-down lists near the edge of the screen should expand away from the edge of the screen.
**Actual behavior**
Drop-down renders upwards when at the top of the screen, making a tiny scrollable menu.
**To Reproduce**
Open VS Code; and start several debugging sessions, then open the drop-down that lets you select between them.
**Screenshots**
|
https://github.com/electron/electron/issues/13279
|
https://github.com/electron/electron/pull/28224
|
8476bed36eb4e7c5c58b50bc6b186fa82263fd21
|
b52ccc97264481fba6a092a24ba8b63058c964fb
| 2018-06-18T14:38:06Z |
c++
| 2021-03-18T20:37:14Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,278 |
["lib/renderer/web-view/web-view.js"]
|
webview: resizing webview triggers resize event on window
|
* Electron Version: 1.7.x and 2.0.x
* Operating System (Platform and Version): macoS 10.13
* Last known working Electron version: unknown
**Expected Behavior**
The resize event should only be triggered when the window size changes.
**Actual behavior**
The resize event fires when the webview size is changed.
**To Reproduce**
**renderer.js**
```js
window.addEventListener('resize', () => {
console.log("RESIZE");
});
setTimeout(() => {
document.getElementById("foo").style.width = "100%";
}, 2000);
```
**HTML**
```html
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Hello World!</title>
</head>
<body>
<h1>Hello World!</h1>
<!-- All of the Node.js APIs are available in this renderer process. -->
We are using Node.js <script>document.write(process.versions.node)</script>,
Chromium <script>document.write(process.versions.chrome)</script>,
and Electron <script>document.write(process.versions.electron)</script>.
<webview id="foo" style="width: 50%; height: 50%; border: 1px solid red;"></webview>
<script>
// You can also require other files to run in this process
require('./renderer.js')
</script>
</body>
</html>
```
After 2 seconds there is a resize event on the Window once the webview resizes.
/cc @joaomoreno
|
https://github.com/electron/electron/issues/13278
|
https://github.com/electron/electron/pull/14271
|
cd8bb1d3b4bad192759d3b1e3db69cff3f136a11
|
6736d4ef296b960b5157155515ef949a1c3524be
| 2018-06-18T09:43:23Z |
c++
| 2018-08-23T06:42:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,230 |
[".github/config.yml", "docs/README.md", "docs/api/webview-tag.md", "docs/development/pull-requests.md", "docs/tutorial/code-signing.md", "docs/tutorial/macos-dock.md", "docs/tutorial/windows-taskbar.md"]
|
404 Error on Pull Review Page, semantic commit message hyperlink
|
* Electron Version: N/A
* Operating System (Platform and Version): MacOS 10.13.15 (accessed via Chrome 67.0.3396.79)
* Last known working Electron version: N/A
**Expected Behavior**
The first link from the welcome bot contains a link for semantic commit messages, expected to be redirected to a webpage.
**Actual behavior**
GitHub 404 Error
**To Reproduce**
Make a pull request (unsure if the welcome bot is displayed to all pull requests or just new members), and click on semantic commit message link.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Additional Information**
looking at the config.yml file it currently links to
https://github.com/electron/electron/blob/semantic-first-pr/docs/development/pull-requests.md#commit-message-guidelines
I think it should link to here: https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines
Didn't want to create a pull request incase I totally misunderstood.
|
https://github.com/electron/electron/issues/13230
|
https://github.com/electron/electron/pull/13233
|
1647c12c732faf56ab5ef33dae7f48ed4ad2c840
|
a67c992c3699a60c1bec3e2b23b3033591d8bcf3
| 2018-06-13T04:33:13Z |
c++
| 2018-06-16T00:43:03Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,219 |
["atom/browser/web_dialog_helper.cc"]
|
Application bundles can be selected in <input file="type"> file selector on macOS
|
* Electron Version: master
* Operating System (Platform and Version): macOS 10.13
* Last known working Electron version: N/A
**Expected Behavior**
Application bundles cannot be selected as they are directories, not files
**Actual behavior**
Application bundles can be selected, but are not handled properly as they are not files
**To Reproduce**
in Electron default_app:
```
var input = document.createElement('input');
input.type = 'file';
input.click();
```
**Additional Information**
- Firefox: uses `[dialog setTreatsFilePackagesAsDirectories:YES]`
- Chrome & Safari: creates a ZIP file containing the bundle contents automatically
|
https://github.com/electron/electron/issues/13219
|
https://github.com/electron/electron/pull/13220
|
2d15b8fe7854e9903f8b72e668164015e288997c
|
c4942d931c749869a63b3d26616c9a870fbb5512
| 2018-06-11T20:03:22Z |
c++
| 2018-06-15T20:51:38Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,190 |
["docs/api/web-contents.md", "docs/api/webview-tag.md", "lib/browser/api/web-contents.js", "spec-main/api-web-contents-spec.ts"]
|
printToPDF does not allow pageRanges?
|
* Electron Version: 2.0.2
* Operating System MacOS High Sierra:
**Expected Behavior**
Perhaps it's not documented but this does not work at all as
`webContents.printToPDF({pageRanges:1}, callback);`
**Actual behavior**
To print a PDF with only the pages specified
**To Reproduce**
Test it on any operating system in any version of electron
In this file
https://github.com/electron/electron/blob/b89fe86fa1f7c935046b5bbdd82ae645c01838a4/lib/browser/api/web-contents.js
there is what i believe a typo also on Line 62 it says 'pageRage':[] Should this not be pageRange? and if so, is there a way for us to override these defaultPrintSettings? Currently in the printToPDF function there is no way to change some of these settings, only the specific ones that the electron function overwrites
|
https://github.com/electron/electron/issues/13190
|
https://github.com/electron/electron/pull/21906
|
1b4eb0b67994a2336a6b8d811a13db98403c7f7e
|
548b290ea773703bd101f4c70ead5f7d7758eb0e
| 2018-06-08T01:48:07Z |
c++
| 2020-01-28T20:47:24Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,185 |
["lib/common/asar.js", "spec/asar-spec.js"]
|
Can't find module error when running app with asar archive in chromium 66
|
* Electron Version: latest upgrade-to-chromium-66 branch (b655a6f5f5f0863bf1a1f72f47daf01a3f2eb5e5)
* Operating System (Platform and Version): macOS 10.13.5
* Last known working Electron version: 2.0.2
**Expected Behavior**
Should not see "Cannot find module error" when requiring dependent packages
**Actual behavior**
When running the app an exception pop shows "Cannot find module error".
If run the app from command line or packaging without asar then error will not show.
**To Reproduce**
1. Add any dependency in the app and require it in the main JS.
2. Package the app with electron-builder and asar enabled.
3. Run the generated binary and the error will happen.
**Additional Information**
After investigation, it looks like its related to this change in node module [node #17076](https://github.com/nodejs/node/issues/17076)
internalModuleReadFile has been renamed to internalModuleReadJSON, and in **vendor/node/lib/internal/modules/cjs/loader.js** it will call internalModuleReadJSON and can't read the package.json file.
In `lib/common/asar.js`, there is an override for `internalModuleReadFile`, I renamed it to `internalModuleReadJSON` and issue is solved.
|
https://github.com/electron/electron/issues/13185
|
https://github.com/electron/electron/pull/13283
|
04a7a34c42743d04d89b07575ae38e0230204f8a
|
fc12b5cab330fa14456401d40917eb5bd5beb911
| 2018-06-07T18:11:56Z |
c++
| 2018-06-19T18:58:37Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,113 |
["atom/common/api/atom_api_v8_util.cc", "atom/common/api/remote_callback_freer.cc", "atom/common/api/remote_callback_freer.h", "atom/common/api/remote_object_freer.cc", "atom/common/api/remote_object_freer.h", "lib/browser/objects-registry.js", "lib/browser/rpc-server.js", "lib/renderer/api/remote.js", "lib/renderer/web-view/web-view.js"]
|
Electron throwing an error when changing webview partition attribute before its first navigation
|
* Electron Version: 2.0.0 - 2.0.2
* Operating System (Platform and Version): tested on Mac OS X 10.13.4
* Last known working Electron version: 1.8.7
**Expected Behavior**
Setting Webview tag "partition" attribute should not trigger error before its first navigation and load the session partition.
**Actual behavior**
In 2.0.0 - 2.0.2 versions, when setting "partition" attribute before the first navigation, it throws
> "The object has already navigated, so its partition cannot be changed."
and doesn't load the partition. When attribute is set directly in HTML, it works but if it is done via code after some time even before first navigation, it doesn't. It seems something changed in Electron Webview initialisation in versions after 1.8.7.
**To Reproduce**
- Git clone https://github.com/Evoks/electron-webview-bug
- launch commands `npm install ; npm start`
1.8.7 version throws 1 error, 2.0.x versions throws 2 errors.
See file `renderer.js` for code and `package.json` to change Electron version. I added timeouts to simulate execution delay in big application.
|
https://github.com/electron/electron/issues/13113
|
https://github.com/electron/electron/pull/13603
|
bdceea6acaf87c61e4284ceca0ac8f8292d1f27a
|
e90c4abc0d7971f5b64bcff7d25fdbebf88148b7
| 2018-05-30T10:32:34Z |
c++
| 2018-07-12T02:10:22Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,047 |
["atom/browser/browser.h", "atom/browser/browser_mac.mm", "docs/api/app.md", "spec/api-app-spec.js"]
|
Return promise for asynchronous method app.dock.show()
|
**Is your feature request related to a problem? Please describe.**
The following cause a bad effect with the window appearing/exploding (glitch?) from top-left :
```
//user clicks on tray-icon => context-menu => show and I'm supposed to pop-up the app window
app.dock.show();
window.show();
```
This happens because app.dock.show() is not synchronous thus genie effect from the dockbar can't take place because the dock icon is not yet created when we call window.show().
**Describe the solution you'd like**
app.dock.show() should return a promise fullfilled when the icon is in the dock.
**Describe alternatives you've considered**
Right now I'm doing this and it works:
```
app.dock.show();
app.dock.setIcon(appIcon);
setTimeout(window.show, 500);
```
Another is to provide a way to disable system animation (OSX) for window.show() / window.hide().
**Additional context**
Of course I have no idea about internal API availability/functionality. If not possible we can just close this issue and other people will have a reference about it! :)
|
https://github.com/electron/electron/issues/13047
|
https://github.com/electron/electron/pull/16904
|
cd9bf72ee895202071c268911e0208fbd43018cd
|
ca83d3642680b6d6f06788a4126dc729b447a806
| 2018-05-23T12:26:52Z |
c++
| 2019-02-13T05:06:33Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 13,043 |
["shell/browser/native_window_views.cc", "shell/browser/native_window_views.h", "shell/browser/native_window_views_win.cc"]
|
Window size changes when being moved if resizable is false
|
* Electron Version: 2.0.0
* Operating System (Platform and Version): Windows 10
* Last known working Electron version: before commit bb5eecc16cff8053c7b04e0b9396803fbbb8c4df
**Expected Behavior**
Width and height of a window should not change while being dragged
**Actual behavior**
Width and height become smaller.
**To Reproduce**
Create a window with:
var mainWindow = new BrowserWindow({width: 1024, height: 880, x: 30, y: 30,
resizable: false })
Then drag the window. Width and height become smaller than specified (1024, 880)
**Additional Information**
NativeWindowViews::SetBounds calls SetMin/MaxSize(bounds) when resizable_ is false. bounds get adjusted to smaller numbers by WindowBoundsToContentBounds.
|
https://github.com/electron/electron/issues/13043
|
https://github.com/electron/electron/pull/19886
|
cddbddc5439351eaf4d0c45165ea47c7f6f84dc5
|
d04072d1eba8085acae4b58c0fed26e3088262f2
| 2018-05-22T21:06:10Z |
c++
| 2019-08-26T21:04:20Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,989 |
["atom/browser/native_window.cc"]
|
now, frameless transparent windows can't bigger than 64x64 on Windows v2.0.1
|
* Electron Version: v2.0.1
* Operating System (Platform and Version): windows10
* Last known working Electron version: 1.7.9
Allow frameless transparent windows to be sized smaller than 64x64 on Windows #12923
but，now, it can't bigger than 64x64 on Windows
my `height/width` don't work
when i set `frame: true`, it can't resize
remove `transparent: true`, all work right
|
https://github.com/electron/electron/issues/12989
|
https://github.com/electron/electron/pull/13003
|
156a97b80d1fe1cf701d035e6481dc00fbd56677
|
8b2bffcf9ed5bff406eeec9a36076474bbdd4a32
| 2018-05-18T03:06:13Z |
c++
| 2018-05-21T00:56:45Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,960 |
["atom/browser/ui/tray_icon_cocoa.mm"]
|
Tray title no longer inverts when highlighted
|
* Electron Version: 2.0.0
* Operating System (Platform and Version): MacOS 10.13.4
* Last known working Electron version: ^1.8.2-beta.5
**Expected Behavior**
Tray title should invert colour when highlighted
**Actual behavior**
Tray title text color remains dark when highlighted
**To Reproduce**
Add the following to the `createWindow` function of the electron-quick-start repo
```
tray = new Tray('./tray-dark.png')
const contextMenu = Menu.buildFromTemplate([
{label: 'Item1', type: 'radio'}
])
tray.setContextMenu(contextMenu)
tray.setTitle('Test')
```
**Screenshots**
|
https://github.com/electron/electron/issues/12960
|
https://github.com/electron/electron/pull/13085
|
83dc8cc13b7d148f5cce43f83af13684f0d3b0fa
|
ef1e2d6fe0190ca90f31033146297cc43897817b
| 2018-05-16T09:13:25Z |
c++
| 2018-06-16T06:24:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,956 |
["atom/browser/web_dialog_helper.cc"]
|
When a single file extension is given (<input type="file" accept=".txt" />), the format description in the open file dialog is empty.
|
* Electron Version: Electron 2.0.0
* Operating System: Windows 10
**Expected Behavior**
When a single file extension is given (`<input type="file" accept=".txt" />`), the format description in the open file dialog should not be empty.
**Actual behavior**
When a single file extension is given (`<input type="file" accept=".txt" />`), the format description in the open file dialog is empty.
**To Reproduce**
- open the devtools console in the Electron default app
- run `document.body.innerHTML = '<input type="file" accept=".txt" />';`
- click the "Choose File" button
- observe the file format selection combo box in the bottom-right corner
**Screenshots**
```
<input type="file" accept=".txt" />
```
```
<input type="file" accept=".txt,.zip" />
```
|
https://github.com/electron/electron/issues/12956
|
https://github.com/electron/electron/pull/12954
|
211d7825d31ab5d72a7a1575616d2a3fe8f7f390
|
e1c374de6e5a9bb6d7657cc3a44e75e5370f5c9c
| 2018-05-15T21:09:59Z |
c++
| 2018-05-16T14:15:54Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,937 |
["atom/app/atom_main.cc"]
|
Blank window in any app on Raspberry Pi with OpenGL enabled (used to work in v1.7.x)
|
* Electron Version: 2.0.0
* Operating System (Platform and Version): Raspbian Stretch
* Last known working Electron version: 1.7.14
**Expected Behavior**
App renders correctly
**Actual behavior**
Blank / empty glitchy window
**To Reproduce**
Enable OpenGL (Full KMS) in raspi-config
Run the quickstart app on electron 2.0
**Additional Information**
I need to have OpenGL enabled to run some WebGL apps. Works on 1.7.x and earlier but no longer works on 2.0.0.
|
https://github.com/electron/electron/issues/12937
|
https://github.com/electron/electron/pull/15555
|
b97d7e7ecd6ed403cea700ab4aab0d0d20624f7f
|
51cb36fa9b2c9c829050b6612bc6770f048db245
| 2018-05-15T10:15:20Z |
c++
| 2018-11-19T16:53:55Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,929 |
["docs/tutorial/security.md"]
|
Disable `eval()` in the renderer by default
|
**Is your feature request related to a problem? Please describe.**
Electron is known for being insecure. It should come with better security defaults.
**Describe the solution you'd like**
The Electron [security checklist](https://github.com/electron/electron/blob/master/docs/tutorial/security.md#7-override-and-disable-eval) recommends overriding `eval()` to disable it, but I would argue it's better to disable it by default and let users opt into having it with a `BrowserWindow` option. Most apps will not need `eval()`, so we should optimize for that.
CSP is also able to disable `eval`, but I still argue `eval()` should be disabled by default regardless of whether you use CSP or not.
If users really need it, they could enable it like so:
```js
const win = BrowserWindow({
allowEval: true
});
```
|
https://github.com/electron/electron/issues/12929
|
https://github.com/electron/electron/pull/15675
|
a54dd1085a128f51de6123dc9bc9d80cc0d2b0b1
|
c9d0960f472d2fc474a9ad1b4443a27c7036effa
| 2018-05-15T03:29:08Z |
c++
| 2018-11-12T16:13:48Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,919 |
["atom/browser/common_web_contents_delegate.cc", "atom/browser/common_web_contents_delegate.h", "spec/chromium-spec.js", "spec/fixtures/pages/tab-focus-loop-elements-wv.html", "spec/fixtures/pages/tab-focus-loop-elements.html"]
|
Browser windows have an extra tab focus which can not be disabled and is not visible
|
* Electron Version: 2.0.0
* Operating System (Platform and Version): Windows 10
* Last known working Electron version: N/A
**Expected Behavior**
If the last focusable HTML element is focused and I press 'tab', then the next thing that is focused should either be the first focusable HTML element, or if not, then whatever is focused should have a visible focus.
**Actual behavior**
Something is being focused (I think it is the entire HTML document?) and there is no visual indication as to what it is. It is fine that this other thing is being focused, what is not fine is that I/a user does not know where the keyboard focus has gone.
**To Reproduce**
- Checkout the [electron-quick-start](https://github.com/electron/electron-quick-start)- Put an `<input type="text"/>` before the `renderer.js` script
- Launch quick start
- Set focus in the input
- Press 'tab'
|
https://github.com/electron/electron/issues/12919
|
https://github.com/electron/electron/pull/16042
|
ed3e5739dca35ac3914fb6519f56544a1caf64be
|
9c783f53ba7ba4158de7c6a48aafc64071b4eebc
| 2018-05-14T17:45:05Z |
c++
| 2018-12-19T06:44:51Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,915 |
["docs/api/menu.md", "lib/browser/api/menu.js", "spec/api-menu-spec.js"]
|
menu.popup options object should be optional
|
I have the following code that worked in versions before 2.0.0
------------------------------------------
const remote = require('electron').remote
const contextMenu = new remote.Menu();
contextMenu.append(new remote.MenuItem({label: "myLabel", click: () => console.log("click")}));
function showContextMenu() {
contextMenu.popup();
}
<body onContextMenu="showContextMenu()" />
------------------------------------------
This code throws:
remote.js:209 Uncaught Error: Could not call remote function ''. Check that the function signature is correct. Underlying error: Options must be an object
Error: Could not call remote function ''. Check that the function signature is correct. Underlying error: Options must be an object
at callFunction (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:257:11)
at EventEmitter.<anonymous> (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:357:5)
at emitMany (events.js:147:13)
at EventEmitter.emit (events.js:224:7)
at WebContents.<anonymous> (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:295:13)
at emitTwo (events.js:126:13)
at WebContents.emit (events.js:214:7)
at callFunction (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:257:11)
at EventEmitter.<anonymous> (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:357:5)
at emitMany (events.js:147:13)
at EventEmitter.emit (events.js:224:7)
at WebContents.<anonymous> (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:295:13)
at emitTwo (events.js:126:13)
at WebContents.emit (events.js:214:7)
at Object.exception (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:209:30)
at metaToValue (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:213:28)
at Object.remoteMemberFunction (/Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:113:16)
at showContextMenu (file:///Users/vassilev/Projects/electron-test-app/index.js:49:14)
at HTMLBodyElement.oncontextmenu (file:///Users/vassilev/Projects/electron-test-app/index.html:8:96)
exception @ /Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:209
metaToValue @ /Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:213
remoteMemberFunction @ /Users/vassilev/Projects/electron-test-app/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:113
showContextMenu @ index.js:49
oncontextmenu @ index.html:8
|
https://github.com/electron/electron/issues/12915
|
https://github.com/electron/electron/pull/13977
|
fc4499ebd4a3293e57b7f39b5d4739efb33d4b27
|
a7052efaf4fc6bb2aeedd6579e662e98aa2237dd
| 2018-05-14T13:52:32Z |
c++
| 2018-08-08T22:38:52Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,883 |
["docs/api/session.md", "shell/browser/api/electron_api_session.cc", "shell/browser/api/electron_api_session.h", "spec/api-session-spec.ts"]
|
Custom headers for DownloadItem (e.g. Authorization)
|
**Is your feature request related to a problem? Please describe.**
Download Manager/DownloadItem api does not work for webRequests that require custom headers (e.g. Authorization headers with JWT token).
**Describe the solution you'd like**
Make a per-webRequest way to pass custom headers (e.g. Authorization) through the Download Manager / DownloadItem api.
For example, extend `WebContents::DownloadURL` to allow the passing of custom headers. It currently only supports passing 'url':
`electron/atom/browser/api/atom_api_web_contents.cc` `Line 1061 in cc9771a`
```
void WebContents::DownloadURL(const GURL& url) {
```
**Describe alternatives you've considered**
The only workaround I am aware of is to filter/listen for
`webRequest.onBeforeSendHeaders([filter, ]listener)`
And modify `details.requestHeaders`. But that's a hack.
**Additional context**
Needed for download manager dependent modules like https://github.com/sindresorhus/electron-dl/issues/33
See also https://github.com/electron/electron/issues/10582 which may have been closed prematurely.
|
https://github.com/electron/electron/issues/12883
|
https://github.com/electron/electron/pull/38785
|
74d73166d93e569e96721fa4aaeac03698844240
|
e73edb54817acb8f0e548916a97a9ed9340dfc3f
| 2018-05-10T20:52:48Z |
c++
| 2023-06-21T13:31:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,875 |
["atom/browser/native_window.cc", "atom/browser/native_window.h", "atom/browser/ui/views/frameless_view.cc", "spec/api-browser-window-spec.js"]
|
Windows 10 browser window size < ~70
|
* Electron Version: 2.0.0 & 1.8.6
* Operating System (Platform and Version): Windows 10 Pro, build: 1803
* Last known working Electron version: /
**Expected Behavior**
I expect the value set for a browser window width to be respected across all platforms.
**Actual behavior**
When browser window width is set to 60, it's actually using 48, when it's 55, it's using 28, and when it's 50, it's using 8 as width. Somewhere around ~70+ it starts respecting the value that's set. For some reason, its scalling it.
**To Reproduce**
set browser window options to the following:
```
{
width: 50,
height: 665,
alwaysOnTop: true,
frame: false,
show: false,
transparent: true,
hasShadow: false,
resizable: false,
movable: false,
}
```
I dont know if it will reproduce with `npm start` on windows, so I have included electron-build.
```
git clone [email protected]:alexa026/electron-demo.git
npm install
npm start or npm run build-win
```
**Screenshots**
This is how it looks with width: 50:
<img width="494" alt="screen shot 2018-05-10 at 17 00 38" src="https://user-images.githubusercontent.com/139744/39876833-84eefa2a-5474-11e8-9724-b320df9392ad.png">
This is with width: 70px, although its a litle too big for us, because it is adding additional transparent space that we dont want.
<img width="415" alt="screen shot 2018-05-10 at 17 13 12" src="https://user-images.githubusercontent.com/139744/39877183-84947c66-5475-11e8-9ff6-0364507aa798.png">
**Additional Information**
Not sure if it matters, but the resolution of windows machine is 1680x1050.
Height is respected (as its 665px I guess).
On macOS (retina) it works fine even with 50 width.
When I set `transparent: false`, it's adding the background we don't want, but the width is right how its supposed to be.
|
https://github.com/electron/electron/issues/12875
|
https://github.com/electron/electron/pull/12904
|
0bb29e092d14cee4a818757b3aa21181336d02ff
|
0fd8513c80bc6bdb8c07db1e7608f304d8ed245f
| 2018-05-10T15:15:47Z |
c++
| 2018-05-14T14:46:40Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,843 |
["lib/browser/init.js"]
|
Double trayicon menu when session name does not match hardcoded ones
|
* Electron version: master branch
* Operating system: Ubuntu 18.04
### Expected behavior
Click on tray icon shows only one menu from the system
### Actual behavior
Click on tray icon shows two menus, one from the system and one white
|
https://github.com/electron/electron/issues/12843
|
https://github.com/electron/electron/pull/12844
|
9488ef48675fe5f0733a722725c1314554befe8b
|
2b26206ea2c156c10792876a258cf6c9f94f0835
| 2018-05-07T09:58:01Z |
c++
| 2018-05-16T15:44:04Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,840 |
["npm/cli.js"]
|
CLI wrapper does not respond to SIGINT or SIGTERM
|
### Expected behavior
`SIGINT` / `SIGTERM` kill signals should exit the `electron` child process
### Actual behavior
They don't 😆
### How to reproduce
```js
// From a node.js script
const child = childProcess.spawn(process.execPath, ['./node_modules/electron/cli.js']);
setTimeout(() => {
child.kill('SIGTERM');
}, 2000);
```
|
https://github.com/electron/electron/issues/12840
|
https://github.com/electron/electron/pull/13867
|
a99cc969b593c87051ad1a784aa3298d87f88477
|
eb79ad4dab445f76ee7bf93288863a4e172bb93d
| 2018-05-07T03:21:16Z |
c++
| 2018-07-31T18:44:04Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,835 |
["spec/chromium-spec.js", "spec/fixtures/pages/jquery.html", "vendor/libchromiumcontent"]
|
jquery and URI.js combined crash the renderer
|
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
* Electron version: recent master (82329124ffcb2012d101c79236e82fbe6ba79c36) x86 & x64
* Operating system: win7 sp1 x64
* Last known working Electron version: 2.0.0
### Expected behavior
no crash
### Actual behavior
crash
### How to reproduce
test_app.js
```js
'use strict';
const {app, BrowserWindow} = require('electron');
let brWin;
app.on('ready', () => {
brWin = new BrowserWindow({
width: 1366,
height: 768,
webPreferences: {
nodeIntegration: false,
},
});
for (const eventName of ['did-start-loading', 'did-stop-loading', 'crashed'])
brWin.webContents.on(eventName, () => console.log(eventName));
brWin.loadURL(process.argv[2]);
});
app.on('window-all-closed', () => app.exit());
```
test_page.html
```html
<script src="https://cdn.jsdelivr.net/combine/npm/[email protected]/dist/jquery.js,npm/[email protected]/src/URI.js"></script>
test_page
```
- run `electron.exe test_app.js file:///PATH_TO/test_page.html`
- page does not load and a WebContents crash event is logged
- `electron.exe test_app.js https://jsbin.com` also crashes, not sure if the cause is the same
|
https://github.com/electron/electron/issues/12835
|
https://github.com/electron/electron/pull/13475
|
8ad3a2cc42cce3708678ac0414be145cbca4e273
|
e42c6d3eb72b28b95bd9f9cbf4010834262d15f4
| 2018-05-04T19:45:27Z |
c++
| 2018-06-29T00:42:04Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,803 |
["atom/browser/ui/cocoa/atom_menu_controller.mm"]
|
Electron 2.0 crash related to menu
|
* Electron version: 2.0.0
* Operating system: macOS 10.13.4
* Last known working Electron version: 1.7.13
### Expected behavior
Not crash.
### Actual behavior
Crash.
### How to reproduce
Make changes to a Tray menu while it's open.
1. Click on icon in menubar to open menu.
2. Wait for app to change menu by calling `tray.setContextMenu`
3. Crash
```
Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 com.github.electron.framework 0x000000010aa60f79 0x10a9a8000 + 757625
1 com.github.electron.framework 0x000000010a9bd41f 0x10a9a8000 + 87071
2 com.github.electron.framework 0x000000010aa8d95f 0x10a9a8000 + 940383
3 com.github.electron.framework 0x000000010aa8d720 0x10a9a8000 + 939808
4 libobjc.A.dylib 0x00007fff6bf2fc6a objc_object::sidetable_release(bool) + 266
5 com.github.electron.framework 0x000000010aa60f69 0x10a9a8000 + 757609
6 com.github.electron.framework 0x000000010aa6102f 0x10a9a8000 + 757807
7 com.github.electron.framework 0x000000010aa61049 0x10a9a8000 + 757833
8 com.github.electron.framework 0x000000010aa60619 0x10a9a8000 + 755225
9 com.github.electron.framework 0x000000010aa9b80c atom::TrayIconCocoa::SetContextMenu(atom::AtomMenuModel*) + 108
10 com.github.electron.framework 0x000000010aa0b641 atom::api::Tray::SetContextMenu(v8::Isolate*, mate::Handle<atom::api::Menu>) + 129
11 com.github.electron.framework 0x000000010aa0d368 0x10a9a8000 + 414568
12 com.github.electron.framework 0x000000010aa0d33c 0x10a9a8000 + 414524
13 com.github.electron.framework 0x000000010aa0d312 0x10a9a8000 + 414482
14 com.github.electron.framework 0x000000010aa0ea6d base::internal::Invoker<base::internal::BindState<void (atom::api::Tray::*)(v8::Isolate*, mate::Handle<atom::api::Menu>)>, void (atom::api::Tray*, v8::Isolate*, mate::Handle<atom::api::Menu>)>::Run(base::internal::BindStateBase*, atom::api::Tray*&&, v8::Isolate*&&, mate::Handle<atom::api::Menu>&&) + 29
15 com.github.electron.framework 0x000000010aa0d270 0x10a9a8000 + 414320
16 com.github.electron.framework 0x000000010aa0d0d4 0x10a9a8000 + 413908
17 com.github.electron.framework 0x000000010aa0e82c mate::internal::Dispatcher<void (atom::api::Tray*, v8::Isolate*, mate::Handle<atom::api::Menu>)>::DispatchToCallback(v8::FunctionCallbackInfo<v8::Value> const&) + 124
18 libnode.dylib 0x000000010f77e071 0x10f309000 + 4673649
19 libnode.dylib 0x000000010f831ecc 0x10f309000 + 5410508
20 libnode.dylib 0x000000010f831503 0x10f309000 + 5408003
21 ??? 0x00001a285d40463d 0 + 28760665507389
22 ??? 0x00001a285d51233c 0 + 28760666612540
23 ??? 0x00001a285d4bf9ce 0 + 28760666274254
24 ??? 0x00001a285d4f48a5 0 + 28760666491045
25 ??? 0x00001a285d4bf9ce 0 + 28760666274254
26 ??? 0x00001a285d4f474a 0 + 28760666490698
27 ??? 0x00001a285d4bf9ce 0 + 28760666274254
28 ??? 0x00001a285d4f48a5 0 + 28760666491045
29 ??? 0x00001a285d4bf9ce 0 + 28760666274254
30 ??? 0x00001a285d405d1b 0 + 28760665513243
31 ??? 0x00001a285d4f511e 0 + 28760666493214
32 ??? 0x00001a285d4bf9ce 0 + 28760666274254
33 ??? 0x00001a285d4f4048 0 + 28760666488904
34 ??? 0x00001a285d4bf9ce 0 + 28760666274254
35 ??? 0x00001a285d4f48a5 0 + 28760666491045
36 ??? 0x00001a285d4bf9ce 0 + 28760666274254
37 ??? 0x00001a285d405d1b 0 + 28760665513243
38 ??? 0x00001a285d4be479 0 + 28760666268793
39 ??? 0x00001a285d40410d 0 + 28760665506061
40 libnode.dylib 0x000000010f9e1bd7 0x10f309000 + 7179223
41 libnode.dylib 0x000000010f9e190c v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 140
42 libnode.dylib 0x000000010f79fc20 v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 352
43 libnode.dylib 0x000000010f3ec766 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) + 118
44 libnode.dylib 0x000000010f3ec93d node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) + 109
45 libnode.dylib 0x000000010f3ec8bc node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*, node::async_context) + 92
46 libnode.dylib 0x000000010f3ec83f node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, node::async_context) + 95
47 com.github.electron.framework 0x000000010aac2eef mate::internal::CallMethodWithArgs(v8::Isolate*, v8::Local<v8::Object>, char const*, std::__1::vector<v8::Local<v8::Value>, std::__1::allocator<v8::Local<v8::Value> > >*) + 79
48 com.github.electron.framework 0x000000010aa31a85 0x10a9a8000 + 563845
49 com.github.electron.framework 0x000000010aa3195e 0x10a9a8000 + 563550
50 com.github.electron.framework 0x000000010aa1dba1 0x10a9a8000 + 482209
51 com.github.electron.framework 0x000000010aa1da93 0x10a9a8000 + 481939
52 com.github.electron.framework 0x000000010aa18976 atom::api::WebContents::OnRendererMessage(content::RenderFrameHost*, std::__1::basic_string<unsigned short, base::string16_char_traits, std::__1::allocator<unsigned short> > const&, base::ListValue const&) + 86
53 com.github.electron.framework 0x000000010aa249b5 0x10a9a8000 + 510389
54 com.github.electron.framework 0x000000010aa24989 0x10a9a8000 + 510345
55 com.github.electron.framework 0x000000010aa18887 0x10a9a8000 + 460935
56 com.github.electron.framework 0x000000010aa1844f atom::api::WebContents::OnMessageReceived(IPC::Message const&, content::RenderFrameHost*) + 399
57 com.github.electron.framework 0x000000010aa18f10 non-virtual thunk to atom::api::WebContents::OnMessageReceived(IPC::Message const&, content::RenderFrameHost*) + 16
58 com.github.electron.framework 0x000000010b2e377d 0x10a9a8000 + 9680765
59 com.github.electron.framework 0x000000010b111ea0 0x10a9a8000 + 7773856
60 com.github.electron.framework 0x000000010b853a1b 0x10a9a8000 + 15383067
61 com.github.electron.framework 0x000000010ac6e402 0x10a9a8000 + 2909186
62 com.github.electron.framework 0x000000010ac336bb 0x10a9a8000 + 2668219
63 com.github.electron.framework 0x000000010ac33aa5 0x10a9a8000 + 2669221
64 com.github.electron.framework 0x000000010ac33d79 0x10a9a8000 + 2669945
65 com.github.electron.framework 0x000000010ac3722a 0x10a9a8000 + 2683434
66 com.github.electron.framework 0x000000010abeb9da 0x10a9a8000 + 2374106
67 com.github.electron.framework 0x000000010ac36b4f 0x10a9a8000 + 2681679
68 com.apple.CoreFoundation 0x00007fff447b2d81 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
69 com.apple.CoreFoundation 0x00007fff4486a65c __CFRunLoopDoSource0 + 108
70 com.apple.CoreFoundation 0x00007fff44795d30 __CFRunLoopDoSources0 + 208
71 com.apple.CoreFoundation 0x00007fff447951ad __CFRunLoopRun + 1293
72 com.apple.CoreFoundation 0x00007fff44794a07 CFRunLoopRunSpecific + 487
73 com.apple.HIToolbox 0x00007fff43a72d96 RunCurrentEventLoopInMode + 286
74 com.apple.HIToolbox 0x00007fff43a72b06 ReceiveNextEventCommon + 613
75 com.apple.HIToolbox 0x00007fff43a72884 _BlockUntilNextEventMatchingListInModeWithFilter + 64
76 com.apple.AppKit 0x00007fff41d25a73 _DPSNextEvent + 2085
77 com.apple.AppKit 0x00007fff424bbe34 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
78 com.apple.AppKit 0x00007fff424bd254 _NSHLTBMenuEventProc + 179
79 com.apple.HIToolbox 0x00007fff43ac6e50 IsUserStillTracking(MenuSelectData*, unsigned char*) + 195
80 com.apple.HIToolbox 0x00007fff43adf676 CheckDragging(MenuSelectData*, unsigned char*) + 1029
81 com.apple.HIToolbox 0x00007fff43bedf5a TrackMenuCommon(MenuSelectData&, unsigned char*, SelectionData*, MenuResult*, MenuResult*) + 368
82 com.apple.HIToolbox 0x00007fff43bea7d0 PopUpMenuSelectCore(MenuData*, Point, double, Point, unsigned short, unsigned int, unsigned int, Rect const*, unsigned short, unsigned int, Rect const*, Rect const*, __CFDictionary const*, __CFString const*, OpaqueMenuRef**, unsigned short*) + 1490
83 com.apple.HIToolbox 0x00007fff43be9cf7 _HandlePopUpMenuSelection8(OpaqueMenuRef*, OpaqueEventRef*, unsigned int, Point, unsigned short, unsigned int, unsigned int, Rect const*, unsigned short, Rect const*, Rect const*, __CFDictionary const*, __CFString const*, OpaqueMenuRef**, unsigned short*) + 409
84 com.apple.HIToolbox 0x00007fff43ab240c _HandlePopUpMenuSelectionWithDictionary + 268
85 com.apple.AppKit 0x00007fff41fce79a _NSSLMPopUpCarbonMenu3 + 5632
86 com.apple.AppKit 0x00007fff41fcd0f4 -[NSCarbonMenuImpl popUpMenu:atLocation:width:forView:withSelectedItem:withFont:withFlags:withOptions:] + 439
87 com.apple.AppKit 0x00007fff424a8c6b +[NSStatusBarButtonCell popupStatusBarMenu:inRect:ofView:withEvent:] + 1003
88 com.apple.AppKit 0x00007fff424acf82 -[NSStatusItem popUpStatusItemMenu:] + 183
89 com.github.electron.framework 0x000000010aa9a8e1 0x10a9a8000 + 993505
90 com.apple.AppKit 0x00007fff42659836 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 1961
91 com.apple.AppKit 0x00007fff42658c70 -[NSWindow(NSEventRouting) sendEvent:] + 497
92 com.apple.AppKit 0x00007fff424ab885 -[NSStatusBarWindow sendEvent:] + 348
93 com.apple.AppKit 0x00007fff424ba236 -[NSApplication(NSEvent) sendEvent:] + 2462
94 com.github.electron.framework 0x000000010aa6040b 0x10a9a8000 + 754699
95 com.apple.AppKit 0x00007fff41d1a8b5 -[NSApplication run] + 812
96 com.github.electron.framework 0x000000010ac37a5e 0x10a9a8000 + 2685534
97 com.github.electron.framework 0x000000010ac3645c 0x10a9a8000 + 2679900
98 com.github.electron.framework 0x000000010ac4c9b3 0x10a9a8000 + 2771379
99 com.github.electron.framework 0x000000010aeb8e3f 0x10a9a8000 + 5312063
100 com.github.electron.framework 0x000000010aeb8c60 0x10a9a8000 + 5311584
101 com.github.electron.framework 0x000000010aebb2e2 0x10a9a8000 + 5321442
102 com.github.electron.framework 0x000000010aeb4cbc 0x10a9a8000 + 5295292
103 com.github.electron.framework 0x000000010adfde90 0x10a9a8000 + 4546192
104 com.github.electron.framework 0x000000010c9f3314 0x10a9a8000 + 33862420
105 com.github.electron.framework 0x000000010adfcca4 0x10a9a8000 + 4541604
106 com.github.electron.framework 0x000000010a9aaac4 AtomMain + 68
107 com.github.electron 0x000000010a9a5f26 main + 38
108 libdyld.dylib 0x00007fff6cb4c015 start + 1
```
|
https://github.com/electron/electron/issues/12803
|
https://github.com/electron/electron/pull/13513
|
67673cbf7ffa378674922f79082d2a42900fd832
|
6cf68f82471e3611220d19a6d8f4e39f1be2686c
| 2018-05-02T22:32:58Z |
c++
| 2018-06-29T21:48:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,774 |
["atom/browser/browser_mac.mm", "atom/browser/net/atom_network_delegate.cc", "atom/browser/net/js_asker.cc", "atom/browser/net/url_request_async_asar_job.cc", "atom/browser/net/url_request_string_job.cc", "atom/common/native_mate_converters/v8_value_converter.cc"]
|
Most of base::Value::GetAs* methods are deprecated
|
All except `GetAsDictionary()`. Please use new shiny methods instead.
https://chromium.googlesource.com/chromium/src/+/master/base/values.h
|
https://github.com/electron/electron/issues/12774
|
https://github.com/electron/electron/pull/13425
|
fa0704665fae875bf939de69e8dd513451f1dd0f
|
003a92e0990fa4ba1bd7b93450eb3afae0533090
| 2018-05-01T21:18:45Z |
c++
| 2018-06-27T21:52:48Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,772 |
["atom/browser/net/atom_network_delegate.cc", "atom/common/asar/archive.cc", "atom/common/native_mate_converters/net_converter.cc"]
|
base::Value:: HasKey is deprecated
|
> // DEPRECATED, use Value::FindKey(key) instead.
|
https://github.com/electron/electron/issues/12772
|
https://github.com/electron/electron/pull/13312
|
0802f82356299199b5329c8002fa32bfbafed281
|
c20e0c30a24d77361a6f14bcf73610e6753b7adf
| 2018-05-01T20:55:01Z |
c++
| 2018-06-20T03:07:10Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,771 |
["atom/browser/api/atom_api_debugger.cc", "atom/browser/render_process_preferences.cc"]
|
base::Value DeepCopy and CreateDeepCopy are deprecated
|
> // DEPRECATED, use Value::Clone() instead.
|
https://github.com/electron/electron/issues/12771
|
https://github.com/electron/electron/pull/14420
|
8e1452d316d6d8997dff5b79f13831e77a43dc25
|
aa01a7337c029762996772d3f8c2d51689fdbf61
| 2018-05-01T20:45:26Z |
c++
| 2018-09-02T22:38:35Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,770 |
["atom/common/native_mate_converters/net_converter.cc", "atom/common/native_mate_converters/network_converter.cc", "atom/common/native_mate_converters/v8_value_converter.cc"]
|
base::Value::CreateWithCopiedBuffer is deprecated
|
> // DEPRECATED, use std::make_unique<Value>(const BlobStorage&) instead.
We use it in a few files in `atom/common/native_mate_converters/*.cc`.
|
https://github.com/electron/electron/issues/12770
|
https://github.com/electron/electron/pull/13436
|
39e6943f1e48be3d16f9c69cab001c98ad41de63
|
1dde9492c988b588aee63564b7b0d7f34d6f1898
| 2018-05-01T20:37:42Z |
c++
| 2018-06-26T22:08:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,752 |
["atom/browser/api/atom_api_app.cc", "atom/browser/api/atom_api_app.h", "docs/api/app.md", "docs/tutorial/planned-breaking-changes.md", "lib/browser/api/app.js", "spec/api-app-spec.js", "spec/fixtures/api/singleton-old/main.js", "spec/fixtures/api/singleton-old/package.json", "spec/fixtures/api/singleton/main.js"]
|
New event for `makeSingleInstance`
|
Currently, when a user calls `makeSingleInstance` they need to handle the second instance in a callback.
A better pattern for both users and third-party modules who want to use this information would be to emit an event on the `app` module when the second instance starts.
A pattern like:
```js
app.makeSingleInstance();
app.on('second-instance', (e, argv) => {
// do-stuff
});
```
As step 1 I'll introduce support for the event and deprecate the callback. Then in a major version, we can remove the callback.
|
https://github.com/electron/electron/issues/12752
|
https://github.com/electron/electron/pull/12782
|
9c8952aef04f570b2212aa66c65e079ca9aed3f0
|
5b5c161601810be9c223244dbf20c9d4f7d1dd6d
| 2018-04-30T14:55:15Z |
c++
| 2018-05-07T15:29:18Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,710 |
["docs/api/web-contents.md"]
|
unresponsive event is undocumented on webContents
|
The `unresponsive` event is only [documented on BrowserWindow](https://electronjs.org/docs/api/browser-window#event-unresponsive) but appears to also work on `webContents`.
Is this just a matter of updating the docs?
|
https://github.com/electron/electron/issues/12710
|
https://github.com/electron/electron/pull/12786
|
36c4519d7e989c6717ac69798354262bce0c4f89
|
82329124ffcb2012d101c79236e82fbe6ba79c36
| 2018-04-25T14:36:07Z |
c++
| 2018-05-02T16:19:52Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,706 |
["atom/browser/api/atom_api_power_monitor.cc", "atom/browser/api/atom_api_power_monitor.h", "atom/browser/api/atom_api_power_monitor_mac.mm", "atom/browser/api/atom_api_power_monitor_win.cc", "docs/api/power-monitor.md", "electron.gyp", "filenames.gypi"]
|
Detecting 'Put display to sleep' on MacOS
|
Both hot corners and 'CTRL + SHIFT + EJECT' can put the display to sleep without actually suspending the device. This means the `powerMonitor.on('suspend'` event is not emitted, which makes sense, but we still require a way of detecting this use case in electron.
Is there any known way to detect this situation? And if not, would it be possible to add this functionality to electron's powerMonitor? Ideally something like a `'screen-lock'` or `'display-sleep'` event emitted from `powerMonitor`. This would likely apply to other OS as well.
Ideally we would like to be able to detect:
- Screen-lock
- Putting display to sleep via hot corner
- Putting display to sleep via 'CTRL + SHIFT + EJECT'
Not necessarily with the same powerMonitor events.
|
https://github.com/electron/electron/issues/12706
|
https://github.com/electron/electron/pull/12714
|
c1381ac598d35c97d5b49128ad3eed0966a9ef1b
|
338a816ffd181116a373855ded8349ab8be7ed28
| 2018-04-24T15:51:21Z |
c++
| 2018-04-30T16:04:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,701 |
["atom/browser/api/atom_api_top_level_window.cc", "atom/browser/api/atom_api_top_level_window.h", "atom/browser/native_window.cc", "atom/browser/native_window.h", "atom/browser/native_window_mac.h", "atom/browser/native_window_mac.mm", "docs/api/browser-window.md", "spec/api-browser-window-spec.js"]
|
Add setTitleBarStyle method to BrowserWindow
|
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
* Electron version: >= 1.8.2
* Operating system: Any macOS
### Feature request
Currently, the `titleBarStyle` option can only be passed an as option to the `BrowserWindow` constructor when initializing a new BrowserWindow to customize the behavior of the macOS title bar and traffic lights. This cannot be changed after the BrowserWindow been created.
Our team would like to be able to set the `titleBarStyle` on-the-fly after a BrowserWindow has been created. This functionality could be added to the BrowserWindow class as an instance method called, for instance, `setTitleBarStyle`. As an argument this method would accept the same values as set in the configuration in the constructor when creating a `new BrowserWindow`.
If this feature request sounds like a good idea we would like to contribute with the necessary code changes in a Pull Request. What do you think?
|
https://github.com/electron/electron/issues/12701
|
https://github.com/electron/electron/pull/13546
|
a42ca9eecc6e82c087604f92a3e6581de66ece5a
|
f788143c1ac92c6d1b90e4012fcb435bc483f352
| 2018-04-24T14:12:21Z |
c++
| 2018-07-25T17:12:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,698 |
["lib/browser/api/menu.js"]
|
`Menu.buildFromTemplate` uses an incomplete check to determine if passed template is an Array
|
* Electron version: 1.8.4
* Operating system: Windows 10 x64
* Last known working Electron version: 1.8.1
We're having trouble with an array failing [this check](https://github.com/electron/electron/blob/v1.8.4/lib/browser/api/menu.js#L170) in the `menu.buildTemplate` function as it has been created in a different context (using [nodeJs vm](https://nodejs.org/api/vm.html)). It used to pass the [previous more "graceful" check](https://github.com/electron/electron/commit/3fc5d51a96557974db9349565ae18fd20e75b371#diff-dbe4ca7fd990d54f7d388a3f3f930602L214) but now it fails.
Is it a necessity to have such a specific check instead of the more generic one? Reverting to its previous version would solve this problem.
### How to reproduce
Just a simple example to illustrate this behaviour
```
const electron = require('electron')
const Menu = electron.Menu;
const app = electron.app;
const vm = require('vm');
// some dummy function
function createSimpleMenuItem() {
menuTemplate = {
label: "Item from context"
};
return menuTemplate;
}
app.on('ready', function () {
// Taken from the https://nodejs.org/api/vm.html#vm_vm_executing_javascript
const context = {
menuTemplate: [],
createSimpleMenuItem: createSimpleMenuItem
};
vm.createContext(context); // Contextify the context.
// create the template array in the context
const code = 'menuTemplate = []; menuTemplate.push(createSimpleMenuItem());)';
vm.runInContext(code, context);
// create a template using the array created in the new context
var template = Menu.buildFromTemplate(context.menuTemplate);
});
```
|
https://github.com/electron/electron/issues/12698
|
https://github.com/electron/electron/pull/12699
|
9c65abd7464226f9b9205b8e059b6c92806b838a
|
7c4964fae6b8ee0165d70188bbe5c6b8f958f4f9
| 2018-04-24T12:44:24Z |
c++
| 2018-04-24T15:21:26Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,695 |
["common.gypi"]
|
2.0.x: Segmentation fault when starting with NODE_OPTIONS=--max-old-space-size=4096
|
* Electron version: 2.0-beta.7
* Operating system: macOS 10.13.4
<!-- If this used to work -->
* Last known working Electron version: 1.7.9
### Expected behavior
It should not crash.
### Actual behavior
It crashes.
### How to reproduce
* open a terminal
* `export NODE_OPTIONS=--max-old-space-size=4096`
* `./Electron`
Output:
`Segmentation fault: 11`
```
Process: Electron [36848]
Path: /Users/USER/Desktop/*/Electron.app/Contents/MacOS/Electron
Identifier: Electron
Version: 2.0.0 (2.0.0)
Code Type: X86-64 (Native)
Parent Process: bash [33208]
Responsible: Electron [36848]
User ID: 501
Date/Time: 2018-04-24 11:16:03.250 +0200
OS Version: Mac OS X 10.13.4 (17E199)
Report Version: 12
Anonymous UUID: E22FC843-9C95-2329-B911-4033726E6AFD
Sleep/Wake UUID: 8E3050B7-C177-4084-A5E0-7C8406AEB847
Time Awake Since Boot: 24000 seconds
Time Since Wake: 740 seconds
System Integrity Protection: enabled
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [0]
VM Regions Near 0:
-->
__TEXT 000000010d9f6000-000000010d9f7000 [ 4K] r-x/rwx SM=COW /Users/USER/Desktop/*/Electron.app/Contents/MacOS/Electron
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libnode.dylib 0x000000010dc1bf7b node::Init(int*, char const**, int*, char const***) + 747 (node.cc:4641)
1 com.github.electron.framework 0x000000010f2fc879 atom::NodeBindings::Initialize() + 41 (node_bindings.cc:180)
2 com.github.electron.framework 0x000000010f2681f0 atom::AtomBrowserMainParts::PostEarlyInitialization() + 192 (atom_browser_main_parts.cc:135)
3 com.github.electron.framework 0x000000010f6ce679 content::BrowserMainLoop::EarlyInitialization() + 233 (browser_main_loop.cc:613)
4 com.github.electron.framework 0x000000010f6d42a2 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 610 (browser_main_runner.cc:111)
5 com.github.electron.framework 0x000000010f6cde44 content::BrowserMain(content::MainFunctionParams const&) + 100 (browser_main.cc:42)
6 com.github.electron.framework 0x000000010f617030 content::ContentMainRunnerImpl::Run() + 368 (content_main_runner.cc:686)
7 com.github.electron.framework 0x000000011120c494 service_manager::Main(service_manager::MainParams const&) + 2772 (main.cc:469)
8 com.github.electron.framework 0x000000010f615e44 content::ContentMain(content::ContentMainParams const&) + 68 (content_main.cc:19)
9 com.github.electron.framework 0x000000010f1c3cc4 AtomMain + 68 (atom_library_main.mm:24)
10 com.github.electron 0x000000010d9f6f26 main + 38 (atom_main.cc:185)
11 libdyld.dylib 0x00007fff5b3d3015 start + 1
```
|
https://github.com/electron/electron/issues/12695
|
https://github.com/electron/electron/pull/13311
|
c20e0c30a24d77361a6f14bcf73610e6753b7adf
|
951aa83bdf662aca25f60a1e3c3ddc50aa970dbc
| 2018-04-24T09:19:36Z |
c++
| 2018-06-20T03:08:24Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,653 |
["atom/browser/api/atom_api_browser_window.cc", "atom/browser/api/atom_api_browser_window.h", "spec/api-browser-window-spec.js"]
|
HTML fullscreen mode not exited when window-level fullscreen mode is left
|
* Electron version: 2.0.0-beta.7
* Operating system: macOS 10.13.4
### Expected behavior
<!-- What do you think should happen? -->
When HTML fullscreen mode is active, exiting fullscreen on the window level (clicking the green button or calling `win.setFullScreen(false)` should also exit HTML fullscreen mode.
### Actual behavior
HTML fullscreen mode stays active. Chrome correctly exits HTML fullscreen mode.
### How to reproduce
Use console in the default_app:
```
document.addEventListener('webkitfullscreenchange', () => console.log('webkitfullscreenchange'));
document.documentElement.webkitRequestFullscreen();
```
now exit fullscreen by clicking the green button or run `require('electron').remote.getCurrentWindow().setFullScreen(false);`
Compare to what happens when you do the same in Chrome/Chromium
`webkitfullscreenchange` should be logged twice (once for enter, once for exit)
`document.webkitFullscreenElement` should also be `null`
Possible workaround is:
```
win.on('leave-full-screen', () => {
win.webContents.executeJavaScript('document.webkitExitFullscreen();');
});
```
|
https://github.com/electron/electron/issues/12653
|
https://github.com/electron/electron/pull/13090
|
28fd571d0cc70c88f275ba9c319b162f04771d2f
|
2eb5b751f336adb89d17cd2383d95d9b8f5f3b25
| 2018-04-18T15:48:13Z |
c++
| 2018-06-18T07:48:20Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,640 |
["chromium_src/chrome/browser/certificate_manager_model.cc", "chromium_src/chrome/browser/certificate_manager_model.h", "shell/browser/api/electron_api_app.cc", "shell/browser/api/electron_api_app.h", "shell/browser/electron_javascript_dialog_manager.cc"]
|
Do not use base::Passed
|
It's going to be removed from Chromium, see https://crbug.com/812523.
/cc @electron/code-owners
|
https://github.com/electron/electron/issues/12640
|
https://github.com/electron/electron/pull/22871
|
658f8d0abbe02c7bab0c8d664994485f85be9d19
|
714d6c536f777705b576055fa34d647a4c708099
| 2018-04-17T11:37:34Z |
c++
| 2020-04-13T20:52:07Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,636 |
["atom/browser/api/atom_api_menu_mac.mm"]
|
Main app menu is buggy on macOS if user interacts with it while it's being updated
|
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
* Electron version: 2.0.0-beta.7
* Operating system: macOS 10.13.4
### Expected behavior
<!-- What do you think should happen? -->
I expected Electron to not update the menu while it's being interacted with.
It should behave like native and not update when open.
### Actual behavior
### How to reproduce
Run this and try to click the Electron menu and hover Bar menu item multiple times.
```js
const electron = require('electron');
const buildMenu = () => {
electron.Menu.setApplicationMenu(electron.Menu.buildFromTemplate([{
label: 'Foo',
submenu: [
{
label: 'Bar'
}
]
}]));
};
electron.app.on('ready', () => {
setInterval(buildMenu, 1000);
});
```
Since Electron has no good way to make dynamic menus, rebuilding it based on events in the renderer process is the only way to keep the menu in sync with the content in the renderer.
|
https://github.com/electron/electron/issues/12636
|
https://github.com/electron/electron/pull/12809
|
f068ed9ee744c18e90cb30b02365ce2278083bee
|
d2653e819293c9145bfb256ff05950c3b54ec1fa
| 2018-04-17T10:56:46Z |
c++
| 2018-05-17T01:19:28Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,634 |
["atom/browser/web_contents_preferences.cc", "atom/renderer/atom_renderer_client.cc", "docs/api/breaking-changes.md", "docs/api/browser-window.md", "patches/common/chromium/.patches", "patches/common/chromium/web_preferences.patch", "spec/api-browser-window-spec.js", "spec/fixtures/api/native-window-open-argv.html"]
|
window.open with nativeWindowOpen option causes memory leak
|
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
* Electron version: 2.0.0-beta.7
* Operating system: Windows 10 x64
### Expected behavior
<!-- What do you think should happen? -->
When `webPreferences.nativeWindowOpen` is set to true, BrowserWindows opened by `window.open`'s memory will be released after be closed.
### Actual behavior
<!-- What actually happens? -->
The memory is not released and caused memory leak
### How to reproduce
- Clone https://github.com/KochiyaOcean/electron-bugs/tree/native-open-memory-leak
- Run `electron . ` in the cloned repo
- Memory usage of electron process will be increasing in task manager
<!--
Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run.
You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes.
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
-->
|
https://github.com/electron/electron/issues/12634
|
https://github.com/electron/electron/pull/15213
|
7a23980f4b044a9e69473517bfeedb1b838e116b
|
2f3a8ecd42d70d6466aec5bb1748dfea8f08764e
| 2018-04-17T07:38:28Z |
c++
| 2018-10-25T06:31:07Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,611 |
["docs/api/structures/upload-file-system.md", "docs/api/web-contents.md", "docs/api/webview-tag.md"]
|
Deprecate UploadFileSystem
|
https://electronjs.org/docs/api/structures/upload-file-system
It has been removed in the Chromium 66 (or slightly earlier).
/cc @deepak1556, @codebytere
|
https://github.com/electron/electron/issues/12611
|
https://github.com/electron/electron/pull/13064
|
fd25f594cd4ce6121b339f9553fec3dde6562178
|
265aa3da292c92eee3120194a860013d1ffa14cf
| 2018-04-13T14:02:45Z |
c++
| 2018-05-25T17:50:27Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,597 |
["atom/browser/api/atom_api_web_contents.cc", "docs/api/web-contents.md", "docs/api/webview-tag.md", "lib/browser/api/web-contents.js", "lib/browser/guest-view-manager.js", "lib/common/api/deprecate.js", "lib/renderer/web-view/guest-view-internal.js", "spec/api-browser-window-spec.js", "spec/api-web-contents-spec.js", "spec/webview-spec.js"]
|
Deprecate did-get-response-details and did-get-redirect-request events
|
These events are emitted for every navigation request which isn't really efficient. Also upstream has removed the observers that provide these details as part of network servification https://chromium-review.googlesource.com/c/chromium/src/+/805008 and https://chromium-review.googlesource.com/c/chromium/src/+/786320. We are removing it as a part of chromium 66 upgrade.
Proposed alternative: Users can use the [webRequest](https://github.com/electron/electron/blob/master/docs/api/web-request.md) module which provides similar navigation details on a subscription basis.
|
https://github.com/electron/electron/issues/12597
|
https://github.com/electron/electron/pull/12615
|
975964f9f0ebf91de0be55b488fe755a83ddaafd
|
2579071b989e75f65f622a05f1619d3f2173d1a9
| 2018-04-11T16:27:05Z |
c++
| 2018-04-23T19:46:12Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,555 |
["atom/browser/web_contents_preferences.cc"]
|
webSecurity false no longer implies allowRunningInsecureContent
|
* Electron version: 2.0.0-beta.7
* Operating system: Windows 7
### Expected behavior
`new BrowserWindow({webPreferences:{webSecurity:false}})` should not show mixed-content errors. It should show warnings and continue to load the content.
### Actual behavior
mixed-content errors are shown unless *allowRunningInsecureContent* is specified which is contrary to the documentation:
> Disabling webSecurity will disable the same-origin policy and set allowRunningInsecureContent property to true.
This was working as expected in 1.8.2
### How to reproduce
Open a new BrowserWindow as above and load a page via `https` that contains elements using `http`.
|
https://github.com/electron/electron/issues/12555
|
https://github.com/electron/electron/pull/12556
|
7cc3b877dcf4863f15b1c49bf001761437cf2454
|
d06c79f5d34f9b1e2af084228966e547441acb58
| 2018-04-06T15:21:01Z |
c++
| 2018-04-16T13:28:54Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,528 |
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/common_web_contents_delegate.h", "atom/browser/common_web_contents_delegate_views.cc", "atom/browser/ui/autofill_popup.cc", "atom/browser/ui/autofill_popup.h"]
|
Typing into textbox in an offscreen webivew crashes electron
|
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
# Description
* Electron version: 1.8.4
* Operating system: Windows 10
Calling `webContents.sendInputEvent` with type as `"char"` to a document containing a webview is rendered offscreen and an input panel is focused
<!-- What do you think should happen? -->
# Expected result
Keyboard input should be placed into the input panel
<!-- What actually happens? -->
# Actual result
Electron crashes
<!--
Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run.
You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes.
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
-->
# Repro steps
[I have a repo set up that will demonstrate the issue.](https://github.com/ImOnALampshade/electron-webview-char-crash) Clone that to see. Read the readme in that for more information.
```bash
git clone https://github.com/ImOnALampshade/electron-webview-char-crash.git
npm install
npm start
```
|
https://github.com/electron/electron/issues/12528
|
https://github.com/electron/electron/pull/13184
|
fe94bf7c1de2c4271e684fbf7f9adde149bd9a41
|
90911a423a3655d525fc98704da707e94466879a
| 2018-04-04T01:05:37Z |
c++
| 2018-06-18T15:15:37Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,516 |
["atom/browser/api/atom_api_top_level_window.cc", "atom/browser/api/atom_api_top_level_window.h", "atom/browser/native_window.h", "atom/browser/native_window_views.cc", "atom/browser/native_window_views.h", "atom/browser/ui/x/x_window_utils.cc", "atom/browser/ui/x/x_window_utils.h", "docs/api/browser-window.md", "spec/api-browser-window-spec.js"]
|
Implement moveTop() for Linux
|
Need a Linux impl for https://github.com/electron/electron/pull/12485
|
https://github.com/electron/electron/issues/12516
|
https://github.com/electron/electron/pull/16629
|
db11b9b13bb2f4726d963f42f1dc9b477e8ac3cb
|
27bd47a3336ea176bb3f092fc428d7f1758e782f
| 2018-04-03T13:04:17Z |
c++
| 2019-02-07T20:48:19Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,508 |
["lib/browser/api/touch-bar.js"]
|
Encourage Touch Bar items reusability OR add a warning in the docs
|
If Touch Bar items are used over 10 times a `MaxListenersExceededWarning` is being emitted:
```
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 change listeners added. Use emitter.setMaxListeners() to increase limit
```
The problem: every time `BrowserWindow.setTouchBar` is called, every Touch Bar item gets an event listener for the `change` event. However this event is never detached from those items.
Example code for achieving this warning (`mainWindow` is a `BrowserWindow` instance)
```
const button = new TouchBarButton({
label: 'Test',
backgroundColor: '#32DB7E'
});
for(let i = 0; i < 11; i++){
mainWindow.setTouchBar(new TouchBar([
button
]));
}
```
My ask is either detach the change listener of the items when the Touch Bar is removed/changed or add a warning somewhere in the docs for people to keep in mind to not reuse Touch Bar items.
Escape hatch (very bad practice): `TouchBarItem.removeAllListeners('change')`
|
https://github.com/electron/electron/issues/12508
|
https://github.com/electron/electron/pull/12527
|
cd8278dceb9ec9d0eae1c17b42e0ee463784acb6
|
7cc3b877dcf4863f15b1c49bf001761437cf2454
| 2018-04-02T21:48:27Z |
c++
| 2018-04-15T15:24:47Z |
closed
|
electron/electron
|
https://github.com/electron/electron
| 12,506 |
["atom/browser/api/atom_api_content_tracing.cc", "docs/api/content-tracing.md", "docs/api/structures/trace-categories-and-options.md", "docs/api/structures/trace-config.md", "spec/api-content-tracing-spec.js"]
|
contentTracing categoryFilter regression on 2.0.0-beta.6
|
<!--
Thanks for opening an issue! A few things to keep in mind:
- The issue tracker is only for bugs and feature requests.
- Before reporting a bug, please try reproducing your issue against
the latest version of Electron.
- If you need general advice, join our Slack: http://atom-slack.herokuapp.com
-->
* Electron version: 2.0.0-beta.6
* Operating system: confirmed on macOS locally, assume same on other OS
### Expected behavior
`disabled-by-default-memory-infra` should be collected.
<!-- What do you think should happen? -->
### Actual behavior
It is not.
**It does seem some of other categories are also not working correctly, but hard to verify what's working vs. what's not working**
<!-- What actually happens? -->
### How to reproduce
Below's minimal code to automatically trigger content tracing, with single category filter `disabled-by-default-memory-infra` specified:
index.js
```
const { app, BrowserView, BrowserWindow, contentTracing } = require('electron')
const path = require('path')
const url = require('url')
let win
function createWindow() {
win = new BrowserWindow({ width: 800, height: 600 })
win.loadURL(url.format({
pathname: path.join(`${__dirname}/src`, 'index.html'),
protocol: 'file:',
slashes: true
}));
//setup browserview to create dummy `load` to capture memory change
let view = new BrowserView({
webPreferences: {
nodeIntegration: false
}
})
win.setBrowserView(view)
view.setBounds({ x: 0, y: 0, width: 300, height: 300 })
view.webContents.loadURL('https://web.basemark.com/')
win.on('closed', () => {
win = null
})
const options = {
traceOptions: 'record-until-full',
categoryFilter: '-*,disabled-by-default-memory-infra' //exclude all category, set memory-infra only
}
contentTracing.startRecording(options, () => {
console.log('Tracing started')
setTimeout(() => {
contentTracing.stopRecording('./a.trace', (path) => {
console.log('Tracing data recorded to ' + path)
})
}, 10000)
})
}
app.on('ready', createWindow)
app.on('window-all-closed', () => {
if (process.platform !== 'darwin') {
app.quit()
}
})
app.on('activate', () => {
if (win === null) {
createWindow()
}
})
```
index.html
```
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Hello World!</title>
</head>
<body>
<h1>Hello World!</h1>
We are using node <script>document.write(process.versions.node)</script>,
Chrome <script>document.write(process.versions.chrome)</script>,
and Electron <script>document.write(process.versions.electron)</script>.
</body>
</html>
```
On 1.8.4, it collects memory infra stats correctly:
On 2.0.0, the collected trace is simply empty:
this is full trace metadata on 2.0.0. As you could see below, it doesn't contain any actual trace but only initial metadata when trace kicked off
```
{"traceEvents":[{"pid":93553,"tid":0,"ts":0,"ph":"M","cat":"__metadata","name":"num_cpus","args":{"number":8}},
{"pid":93553,"tid":13827,"ts":0,"ph":"M","cat":"__metadata","name":"process_sort_index","args":{"sort_index":-1}},
{"pid":93553,"tid":13827,"ts":0,"ph":"M","cat":"__metadata","name":"process_name","args":{"name":"GPU Process"}},
{"pid":93553,"tid":13827,"ts":0,"ph":"M","cat":"__metadata","name":"process_uptime_seconds","args":{"uptime":10}},{"pid":93565,"tid":0,"ts":0,"ph":"M","cat":"__metadata","name":"num_cpus","args":{"number":8}},
{"pid":93565,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_sort_index","args":{"sort_index":-5}},
{"pid":93565,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_name","args":{"name":"Renderer"}},
{"pid":93565,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_uptime_seconds","args":{"uptime":0}},
{"pid":93565,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_labels","args":{"labels":"Basemark Web 3.0 | Main page"}},
{"pid":93565,"tid":775,"ts":0,"ph":"M","cat":"__metadata","name":"thread_sort_index","args":{"sort_index":-1}},{"pid":93556,"tid":0,"ts":0,"ph":"M","cat":"__metadata","name":"num_cpus","args":{"number":8}},
{"pid":93556,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_sort_index","args":{"sort_index":-5}},
{"pid":93556,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_name","args":{"name":"Renderer"}},
{"pid":93556,"tid":21511,"ts":0,"ph":"M","cat":"__metadata","name":"process_uptime_seconds","args":{"uptime":10}},
{"pid":93556,"tid":775,"ts":0,"ph":"M","cat":"__metadata","name":"thread_sort_index","args":{"sort_index":-1}},{"pid":93554,"tid":0,"ts":0,"ph":"M","cat":"__metadata","name":"num_cpus","args":{"number":8}},
{"pid":93554,"tid":8455,"ts":0,"ph":"M","cat":"__metadata","name":"process_sort_index","args":{"sort_index":-5}},
{"pid":93554,"tid":8455,"ts":0,"ph":"M","cat":"__metadata","name":"process_name","args":{"name":"Renderer"}},
{"pid":93554,"tid":8455,"ts":0,"ph":"M","cat":"__metadata","name":"process_uptime_seconds","args":{"uptime":10}},
{"pid":93554,"tid":8455,"ts":0,"ph":"M","cat":"__metadata","name":"process_labels","args":{"labels":"Hello World!"}},
{"pid":93554,"tid":775,"ts":0,"ph":"M","cat":"__metadata","name":"thread_sort_index","args":{"sort_index":-1}},{"pid":93551,"tid":775,"ts":473973638595,"ph":"M","cat":"__metadata","name":"IsTimeTicksHighResolution","args":{"value":true},"tts":311029},
{"pid":93551,"tid":0,"ts":0,"ph":"M","cat":"__metadata","name":"num_cpus","args":{"number":8}},
{"pid":93551,"tid":26883,"ts":0,"ph":"M","cat":"__metadata","name":"process_sort_index","args":{"sort_index":-6}},
{"pid":93551,"tid":26883,"ts":0,"ph":"M","cat":"__metadata","name":"process_name","args":{"name":"Browser"}},
{"pid":93551,"tid":26883,"ts":0,"ph":"M","cat":"__metadata","name":"process_uptime_seconds","args":{"uptime":10}}],"metadata": {"clock-domain":"MAC_MACH_ABSOLUTE_TIME","command_line":"/Users/ojkwon/github/dummy-electron/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron --no-sandbox --allow-file-access-from-files --enable-avfoundation ./src/index.js","cpu-brand":"Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz","cpu-family":6,"cpu-model":70,"cpu-stepping":1,"gpu-devid":26657,"gpu-driver":"","gpu-glver":"","gpu-psver":"","gpu-venid":4098,"gpu-vsver":"","highres-ticks":true,"network-type":"WiFi","num-cpus":8,"os-arch":"x86_64","os-name":"Mac OS X","os-version":"10.13.3","physical-memory":16384,"product-version":"Chrome/61.0.3163.100","trace-capture-datetime":"2018-4-2 17:23:53","trace-config":"{\"enable_argument_filter\":false,\"enable_systrace\":false,\"excluded_categories\":[\"*\"],\"included_categories\":[\"disabled-by-default-memory-infra\"],\"memory_dump_config\":{\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],\"triggers\":[]},\"record_mode\":\"record-until-full\"}","user-agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Electron/2.0.0-beta.6 Safari/537.36","v8-version":"6.1.534.41"}}
```
**Both (1.8.4/2.0.0) getCategories reports given trace category is supported one**
I couldn't verify each category, but it does seem few other categories are not working as well (mostly around `net-*` related, but based on limited testing)
<!--
Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run.
You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes.
If you provide a URL, please list the commands required to clone/setup/run your repo e.g.
$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .
-->
|
https://github.com/electron/electron/issues/12506
|
https://github.com/electron/electron/pull/13914
|
4ff79760607555e9138ea4db88cc7381e0c07960
|
51cfb5cff1ae5176ac991ec4f084b818f050387d
| 2018-04-02T17:33:20Z |
c++
| 2018-12-20T12:11:17Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.