status
stringclasses
1 value
repo_name
stringlengths
9
24
repo_url
stringlengths
28
43
issue_id
int64
1
104k
updated_files
stringlengths
8
1.76k
title
stringlengths
4
369
body
stringlengths
0
254k
issue_url
stringlengths
37
56
pull_url
stringlengths
37
54
before_fix_sha
stringlengths
40
40
after_fix_sha
stringlengths
40
40
report_datetime
timestamp[ns, tz=UTC]
language
stringclasses
5 values
commit_datetime
timestamp[us, tz=UTC]
closed
electron/electron
https://github.com/electron/electron
12,497
["atom/browser/api/atom_api_browser_window.cc"]
Offscreen windows ignore focus, must use focusOnWebView instead
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.8.4 * Operating system: Windows ### Expected behavior Off screen windows should respond to the `.focus()` method being called by making the content appear to be focused. ### Actual behavior Currently the undocumented method `focusOnWebView()` method must be called in order to "focus" an offscreen window. This behaviour should either be documented [in the off-screen rendering guide](https://electronjs.org/docs/tutorial/offscreen-rendering), or the `.focus()` method should fix this ### How to reproduce * Create an offscreen window, and have its content output to some location (In my case an OpenGL texture) * Go to a web page, such as google * Observe no caret in focused text box, and selected text is the wrong colour Not sure if this is just a documentation issue or a bug... Feel free to resolve as if it were working as intended and document this issue in the off-screen rendering guide.
https://github.com/electron/electron/issues/12497
https://github.com/electron/electron/pull/12507
c1404ff2c1077c44da1bf09a79fcdc77173efd77
52b1065b3b007ae2ff059033c0027f0478b24a5d
2018-04-02T02:17:14Z
c++
2018-04-05T06:14:42Z
closed
electron/electron
https://github.com/electron/electron
12,471
["lib/browser/api/in-app-purchase.js"]
CircleCI Spectron / Mocha tests failing in 2.0.0.beta1
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 2.0.0.beta1^ * Operating system: Mac / Linux / CircleCi ### Expected behavior In stable `1.8.4` version the tests run using Spectron in CircleCi. ### Actual behavior Tests do not run and give this error. ``` Error: An unknown server-side error occurred while processing the command. at execute(<Function>, "require") - api.js:73:26 type: RuntimeError seleniumStack: type: UnknownError message: An unknown server-side error occurred while processing the command. orgStatusMessage: unknown error: The inAppPurchase module can only be used on macOS Error: The inAppPurchase module can only be used on macOS at Object.<anonymous> (/home/circleci/repo/node_modules/electron/dist/resources/electron.asar/browser/api/in-app-purchase.js:4:9) at Object.<anonymous> (/home/circleci/repo/node_modules/electron/dist/resources/electron.asar/browser/api/in-app-purchase.js:16:3) at Module._compile (module.js:642:30) at Object.Module._extensions..js (module.js:653:10) at Module.load (module.js:561:32) at tryModuleLoad (module.js:504:12) at Function.Module._load (module.js:496:3) at Module.require (module.js:586:17) at require (internal/module.js:11:18) at Object.get [as inAppPurchase] (/home/circleci/repo/node_modules/electron/dist/resources/electron.asar/browser/api/exports/electron.js:11:16) (Session info: content shell=) (Driver info: chromedriver=2.29 (8e8216e581c512667203931f81c1a1ead47222e5),platform=Linux 4.4.0-116-generic x86_64) ``` ### How to reproduce Run Spectron + Mocha with CircleCI using this config.yml ``` version: 2 jobs: build: docker: - image: circleci/node:9.8-browsers working_directory: ~/repo steps: - checkout - restore_cache: keys: - v1-dependencies-{{ checksum "package.json" }} - v1-dependencies- - run: npm install - save_cache: paths: - node_modules key: v1-dependencies-{{ checksum "package.json" }} - run: npm install --save-dev electron-chromedriver - run: npm test ```
https://github.com/electron/electron/issues/12471
https://github.com/electron/electron/pull/12511
a7352e57d52cf629b89d2653086b54ae479e97fd
1a649a6ac36100c7a28234a0492464d4ad605e22
2018-03-29T06:44:09Z
c++
2018-04-02T23:55:44Z
closed
electron/electron
https://github.com/electron/electron
12,466
["atom/browser/api/atom_api_top_level_window.cc", "atom/browser/api/atom_api_top_level_window.h", "atom/browser/native_window.cc", "atom/browser/native_window.h", "atom/browser/native_window_observer.h", "atom/browser/native_window_views.cc", "docs/api/browser-window.md"]
[Feature Request] BrowserWindow listener for setAlwaysOnTop toggle
I'm looking to build a feature in my app to give user feedback if they have set their window to always show on top of other apps using a shortcut or application menu item, but find that there is a lot of hacking needed to do so. It may be more efficient to have an event listener set on the window to determine if it enters or leaves `win.setAlwaysOnTop()` i'm thinking it would be `win.on('enter-always-on-top')` and `win.on('leave-always-on-top')`
https://github.com/electron/electron/issues/12466
https://github.com/electron/electron/pull/14951
d810f08b759d5c0a9223be6be73850852d204025
27bbf6a3c618c64b66841cbd6e5741580ad9ce18
2018-03-28T22:55:34Z
c++
2018-10-04T18:02:16Z
closed
electron/electron
https://github.com/electron/electron
12,458
["docs/api/notification.md", "shell/browser/api/atom_api_notification.cc", "shell/browser/api/atom_api_notification.h", "shell/browser/notifications/linux/libnotify_notification.cc", "shell/browser/notifications/notification.h", "shell/browser/notifications/win/windows_toast_notification.cc", "shell/browser/notifications/win/windows_toast_notification.h"]
Timeout parameter for Notification for Linux
Libnotify supports a timeout parameter which allows developers to control for how long the notification will stay. Some DEs has also implemented options to create persistent notification if the value is -1 for this parameter. Which is particularly helpful in GNOME since they removed System Tray altogether. Developers can create persistent notification instead of Tray Icon if the timeout is supported. Please add this.
https://github.com/electron/electron/issues/12458
https://github.com/electron/electron/pull/20153
5e11be689851d9bb1e658832680c57b49e3e8cf8
f80a17c5be84ef780ab2c5693bea48ea9411ce31
2018-03-28T06:17:50Z
c++
2019-10-09T15:22:21Z
closed
electron/electron
https://github.com/electron/electron
12,420
["docs/api/browser-window.md"]
typo in docs - additionALarguments, not additionArguments
The `BrowserWindow`'s `webPreferences` option `additionalArguments` is mistakenly named `additionArguments` in the [docs](https://github.com/electron/electron/blob/master/docs/api/browser-window.md).
https://github.com/electron/electron/issues/12420
https://github.com/electron/electron/pull/12422
95cbd69e48fde434ea4298ab74b0b4af4d537210
cfd91a3b5639bceb78667cd92318bd887f7c6eb6
2018-03-23T20:15:04Z
c++
2018-03-23T22:35:14Z
closed
electron/electron
https://github.com/electron/electron
12,413
[".gitignore", "docs/api/environment-variables.md", "npm/index.js", "npm/install.js"]
Add option to use prebuilt Electron from local
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: Any * Operating system: FreeBSD 11.1+ x64 ### Expected behavior <!-- What do you think should happen? --> As part of the work on #3797, Electron dist/ can now be built and installed on FreeBSD. Since it is unlikely to get official support for FreeBSD from Electron team soon, it would be great if Electron can detect and use local dist when installed as a node_module of any Electron apps. ``` ~ cd /usr/local/share/electron && ls -l total 162125 -rw-r--r-- 1 root wheel 1060 Feb 6 20:29 LICENSE -rw-r--r-- 1 root wheel 1788525 Mar 10 09:47 LICENSES.chromium.html -rw-r--r-- 1 root wheel 25856 Mar 10 01:39 blink_image_resources_200_percent.pak -rw-r--r-- 1 root wheel 7305848 Mar 22 15:31 chromedriver -rw-r--r-- 1 root wheel 4033070 Mar 22 15:31 chromedriver-v1.8.2-freebsd-x64.zip -rw-r--r-- 1 root wheel 15 Mar 10 01:39 content_resources_200_percent.pak -rw-r--r-- 1 root wheel 10282427 Mar 10 01:50 content_shell.pak -rwxr-xr-x 1 root wheel 104013096 Mar 22 15:31 electron -rw-r--r-- 1 root wheel 659579 Mar 22 15:31 electron-api.json -rw-r--r-- 1 root wheel 57732748 Mar 22 15:31 electron-v1.8.2-freebsd-x64.zip -rw-r--r-- 1 root wheel 355202 Mar 22 15:31 electron.d.ts -rw-r--r-- 1 root wheel 1523849 Mar 22 15:31 ffmpeg-v1.8.2-freebsd-x64.zip -rw-r--r-- 1 root wheel 10130560 Jun 26 2017 icudtl.dat -rw-r--r-- 1 root wheel 2939664 Mar 22 15:31 libffmpeg.so -rw-r--r-- 1 root wheel 24187344 Mar 22 15:31 libnode.so drwxr-xr-x 2 root wheel 56 Mar 22 15:32 locales -rw-r--r-- 1 root wheel 11520672 Mar 22 15:31 mksnapshot -rw-r--r-- 1 root wheel 5083066 Mar 22 15:31 mksnapshot-v1.8.2-freebsd-x64.zip -rw-r--r-- 1 root wheel 239010 Mar 10 03:32 natives_blob.bin -rw-r--r-- 1 root wheel 140979 Mar 22 15:21 pdf_viewer_resources.pak drwxr-xr-x 2 root wheel 4 Mar 22 15:32 resources -rw-r--r-- 1 root wheel 1559008 Mar 10 04:01 snapshot_blob.bin -rw-r--r-- 1 root wheel 151829 Mar 10 01:50 ui_resources_200_percent.pak -rw-r--r-- 1 root wheel 6 Mar 22 15:31 version -rw-r--r-- 1 root wheel 57761 Mar 10 01:50 views_resources_200_percent.pak ``` The installed content should be the same to downloaded archives (from `electron-vx.x.x-platform-x64.zip `). ### Actual behavior <!-- What actually happens? --> It has the following error since the prebuilt for FreeBSD is not exist: ``` > [email protected] postinstall /usr/home/guangyuan/cryptocat/node_modules/electron > node install.js Downloading electron-v1.8.4-freebsd-x64.zip Error: GET https://github.com/electron/electron/releases/download/v1.8.4/electron-v1.8.4-freebsd-x64.zip returned 404 /usr/home/guangyuan/cryptocat/node_modules/electron/install.js:47 throw err ^ Error: Failed to find Electron v1.8.4 for freebsd-x64 at https://github.com/electron/electron/releases/download/v1.8.4/electron-v1.8.4-freebsd-x64.zip at Request.<anonymous> (/usr/home/guangyuan/cryptocat/node_modules/nugget/index.js:169:61) at Request.emit (events.js:159:13) at Request.onRequestResponse (/usr/home/guangyuan/cryptocat/node_modules/request/request.js:1068:10) at ClientRequest.emit (events.js:159:13) at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:550:21) at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23) at TLSSocket.socketOnData (_http_client.js:439:20) at TLSSocket.emit (events.js:159:13) at addChunk (_stream_readable.js:265:12) at readableAddChunk (_stream_readable.js:252:11) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! [email protected] postinstall: `node install.js` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the [email protected] postinstall script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /home/guangyuan/.npm/_logs/2018-03-22T19_35_18_972Z-debug.log ``` <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . -->
https://github.com/electron/electron/issues/12413
https://github.com/electron/electron/pull/12426
cfd91a3b5639bceb78667cd92318bd887f7c6eb6
2e5cb930de80e79000887ba02372960fe1efbb20
2018-03-22T19:39:28Z
c++
2018-03-25T04:03:17Z
closed
electron/electron
https://github.com/electron/electron
12,405
["lib/browser/api/browser-window.js", "spec/api-browser-window-spec.js"]
`BrowserWindow.getFocusedWindow()` returns `null` when DevTools is undocked and focused
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 2.0.0-beta.5 * Operating system: macOS 10.13.3 ### Expected behavior <!-- What do you think should happen? --> Calling `BrowserWindow.getFocusedWindow()` when DevTools is undocked and focused should return the owner window. Technically DevTools is the focused window, but it's not a normal window and it breaks expectations, and causes issues with differing behavior in development and production, as it's normal to not open DevTools in production. Alternatively, there should be an option in `getFocusedWindow()` to ignore DevTools windows, preferably set to `true` by default. But I would strongly prefer this just being handled by Electron by default. ### Actual behavior Calling `BrowserWindow.getFocusedWindow()` when DevTools is undocked and focused returns `null`. <!-- What actually happens? --> ### How to reproduce ```js const electron = require('electron'); electron.app.on('ready', () => { const win = new electron.BrowserWindow(); win.webContents.openDevTools({mode: 'undocked'}); setTimeout(() => { console.log('Focused window', electron.BrowserWindow.getFocusedWindow()); //=> null }, 1000); }); ``` <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . -->
https://github.com/electron/electron/issues/12405
https://github.com/electron/electron/pull/12526
82f8914f9e7ac38fe503b95a264c848934241f87
970f79e32f6b69e2fe635c53dabbb66bd8493be7
2018-03-22T08:24:24Z
c++
2018-04-06T13:21:32Z
closed
electron/electron
https://github.com/electron/electron
12,386
["atom/browser/ui/tray_icon_gtk.cc"]
"Put your app in the tray" demo crashes 2-0-x and master
2-0-x and master both pulled and built today Wed Mar 21. OS is Ubuntu 18.04 When clicking on "View Demo" in electron-api-demo's "Put your app in the tray", Electron crashes with this backtrace: ```text [18597:0321/101124.474288:FATAL:app_indicator_icon.cc(241)] Check failed: !tool_tip_.empty(). #0 0x7f949e291dbb base::debug::StackTrace::StackTrace() #1 0x7f949e29084c base::debug::StackTrace::StackTrace() #2 0x7f949e303d23 logging::LogMessage::~LogMessage() #3 0x00000130782f libgtkui::AppIndicatorIcon::SetToolTip() #4 0x0000010e4600 atom::TrayIconGtk::SetToolTip() #5 0x000000f67193 atom::api::Tray::SetToolTip() #6 0x000000f709f5 _ZN4base8internal13FunctorTraitsIMN4atom3api4TrayEFvRKSsEvE6InvokeIPS4_JS6_EEEvS8_OT_DpOT0_ #7 0x000000f70946 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4atom3api4TrayEFvRKSsEJPS6_S8_EEEvOT_DpOT0_ #8 0x000000f708cb _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api4TrayEFvRKSsEJEEEFvPS5_S7_EE7RunImplIRKS9_RKSt5tupleIJEEJEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOSB_S7_ #9 0x000000f707ee _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api4TrayEFvRKSsEJEEEFvPS5_S7_EE3RunEPNS0_13BindStateBaseEOSB_S7_ #10 0x000000f706da _ZNKR4base8CallbackIFvPN4atom3api4TrayERKSsELNS_8internal8CopyModeE1ELNS8_10RepeatModeE1EE3RunES4_S6_ #11 0x000000f70579 _ZN4mate8internal7InvokerINS0_13IndicesHolderIJLm0ELm1EEEEJPN4atom3api4TrayERKSsEE18DispatchToCallbackEN4base8CallbackIFvS7_S9_ELNSB_8internal8CopyModeE1ELNSE_10RepeatModeE1EEE #12 0x000000f70355 mate::internal::Dispatcher<>::DispatchToCallback() #13 0x7f94ac4b9ad1 <unknown> #14 0x7f94ac57d130 <unknown> #15 0x7f94ac57bf60 <unknown> #16 0x1e0b333844c4 <unknown> Received signal 6 #0 0x7f949e291dbb base::debug::StackTrace::StackTrace() #1 0x7f949e29084c base::debug::StackTrace::StackTrace() #2 0x7f949e2917c5 <unknown> #3 0x7f949479c890 <unknown> #4 0x7f948e348e97 gsignal #5 0x7f948e34a801 abort #6 0x7f949e28e846 <unknown> #7 0x7f949e28e828 base::debug::BreakDebugger() #8 0x7f949e3041a4 logging::LogMessage::~LogMessage() #9 0x00000130782f libgtkui::AppIndicatorIcon::SetToolTip() #10 0x0000010e4600 atom::TrayIconGtk::SetToolTip() #11 0x000000f67193 atom::api::Tray::SetToolTip() #12 0x000000f709f5 _ZN4base8internal13FunctorTraitsIMN4atom3api4TrayEFvRKSsEvE6InvokeIPS4_JS6_EEEvS8_OT_DpOT0_ #13 0x000000f70946 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4atom3api4TrayEFvRKSsEJPS6_S8_EEEvOT_DpOT0_ #14 0x000000f708cb _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api4TrayEFvRKSsEJEEEFvPS5_S7_EE7RunImplIRKS9_RKSt5tupleIJEEJEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOSB_S7_ #15 0x000000f707ee _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api4TrayEFvRKSsEJEEEFvPS5_S7_EE3RunEPNS0_13BindStateBaseEOSB_S7_ #16 0x000000f706da _ZNKR4base8CallbackIFvPN4atom3api4TrayERKSsELNS_8internal8CopyModeE1ELNS8_10RepeatModeE1EE3RunES4_S6_ #17 0x000000f70579 _ZN4mate8internal7InvokerINS0_13IndicesHolderIJLm0ELm1EEEEJPN4atom3api4TrayERKSsEE18DispatchToCallbackEN4base8CallbackIFvS7_S9_ELNSB_8internal8CopyModeE1ELNSE_10RepeatModeE1EEE #18 0x000000f70355 mate::internal::Dispatcher<>::DispatchToCallback() #19 0x7f94ac4b9ad1 <unknown> #20 0x7f94ac57d130 <unknown> #21 0x7f94ac57bf60 <unknown> #22 0x1e0b333844c4 <unknown> r8: 0000000000000000 r9: 00007ffd8e57d300 r10: 0000000000000008 r11: 0000000000000246 r12: 00007ffd8e57e2d8 r13: 0000000004492000 r14: 0000000000f70270 r15: 00007ffd8e57e260 di: 0000000000000002 si: 00007ffd8e57d300 bp: 00007ffd8e57d550 bx: 00007f94adf96710 dx: 0000000000000000 ax: 0000000000000000 cx: 00007f948e348e97 sp: 00007ffd8e57d300 ip: 00007f948e348e97 efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. ```
https://github.com/electron/electron/issues/12386
https://github.com/electron/electron/pull/12388
6fa4ec22c5cbbf1bf08674c536321d0e1bfe1d9b
0d7becff87743924f4fe639b802c405af47672aa
2018-03-21T15:14:07Z
c++
2018-03-21T17:15:30Z
closed
electron/electron
https://github.com/electron/electron
12,384
["lib/browser/api/menu.js"]
Disable accelerator for specific menu item roles
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.8.4 * Operating system: win32 (Windows 10) ### Expected behavior I have a case where I should disable some menu shortcuts (accelerators). For example, I defined a menu role "reload" and disabled the shortcut ("Ctrl+R") as shown below. As a result, the click behavior of this menu item is the same. But he doesn't listen to "Ctrl+R" anymore and he doesn't show the shortcut next to the label. This has worked fine in version 1.7.11. ![expected](https://user-images.githubusercontent.com/2511622/37760322-95d361d0-2db6-11e8-87c7-beb69552c23f.jpg) <!-- What do you think should happen? --> ### Actual behavior In the latest version, the way how I disabled the accelerators doesn't work anymore. The shortcut is still displayed next to the label and still listens to the input events (for example "Ctrl+R"). ![actual](https://user-images.githubusercontent.com/2511622/37760330-9dda4100-2db6-11e8-9373-0ab5e84d4af5.jpg) <!-- What actually happens? --> ### How to reproduce Basically, I disabled shortcuts for some menu items as follows: ``` const template = [{ label: 'View', submenu: [{ role: 'reload', accelerator: '' // disable accelerator }] }]; ``` I uploaded a full example [here](https://github.com/strikeflare/electron-quick-start). As I mentioned, this has worked in version 1.7.11. Is there a way to fix this or is there another way how to disable accelerators?
https://github.com/electron/electron/issues/12384
https://github.com/electron/electron/pull/12449
5f7c6ccfe43239a3d661821164066fdcd04ef5b9
a677c22e1f22a9f11b08446c6660eac7c7679552
2018-03-21T13:58:16Z
c++
2018-03-28T00:32:55Z
closed
electron/electron
https://github.com/electron/electron
12,366
["atom/browser/ui/tray_icon_cocoa.mm"]
Tray icon is always highlighted with dark menu bar on macOS
* Electron version: 2.0.0-beta.4 * Operating system: macOS 10.13.3 Tray icon highlighting works as expected with the light menu bar, but with the dark menu bar it's always highlighted. I believe this is a regression in 2.0 as it does not occur 1.8.4 or earlier. Seen here in the https://github.com/electron/electron-api-demos app with the Electron version bumped to 2.0.0-beta.4: ![screen recording 2018-03-20 at 07 10 am](https://user-images.githubusercontent.com/5355/37651547-d936c8e4-2c0e-11e8-8163-372ba624fbf3.gif) Seeing the same behavior in our Basecamp 3 app while testing 2.0.
https://github.com/electron/electron/issues/12366
https://github.com/electron/electron/pull/12395
0d7becff87743924f4fe639b802c405af47672aa
05dc04dacc2a139eee03e19eb3dd2940acb8f20c
2018-03-20T11:20:14Z
c++
2018-03-21T23:03:57Z
closed
electron/electron
https://github.com/electron/electron
12,343
["atom/browser/ui/tray_icon_cocoa.mm"]
Setting the title of the tray to a blank string causes a crash on Electron 2.0.0
* Electron version: `2.0.0-beta4` (it has been present in all the betas, so far) * Operating system: MacOS 10.13.3 ### Expected behavior Using the `tray.setTitle(string)` method, with an empty string, should clear the current tray title. ```javascript tray = new Tray(path.join(__dirname, 'icon.png')) tray.setTitle("test") tray.setTitle("") ``` In my [app](https://github.com/klinker24/messenger-desktop), I use the tray title as an unread badge for the number of unread messages, so I need to be able to update that title (and clear it), as the user receives new messages and reads their currently unread messages. Setting the title to a single space works fine, but this creates an oddly spaced tray icon. ### Actual behavior Setting the tray title to a blank string causes a crash for the app. It isn't the typical Electron JavaScript crash that I am used to - it doesn't give the JavaScript stacktrace. It opens up the Apple crash report dialog, which provides me with the following output: ``` Process: Electron [27956] Path: /usr/local/lib/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron Identifier: com.github.electron Version: 2.0.0 (2.0.0) Code Type: X86-64 (Native) Parent Process: node [27955] Responsible: Electron [27956] User ID: 501 Date/Time: 2018-03-18 21:16:36.877 -0500 OS Version: Mac OS X 10.13.3 (17D102) Report Version: 12 Bridge OS Version: 3.0 (14Y661) Anonymous UUID: 787FB0DE-0D38-60AA-0F9B-D8D120E45D8A Sleep/Wake UUID: A93F2BA5-AE3F-4F65-87CC-143E6573E9C2 Time Awake Since Boot: 220000 seconds Time Since Wake: 17000 seconds System Integrity Protection: enabled Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Illegal instruction: 4 Termination Reason: Namespace SIGNAL, Code 0x4 Terminating Process: exc handler [0] Application Specific Information: Crashing on exception: NSConcreteMutableAttributedString initWithString:attributes:: nil value Application Specific Backtrace 1: 0 CoreFoundation 0x00007fff36e86fcb __exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff5db28c76 objc_exception_throw + 48 2 CoreFoundation 0x00007fff36f189ed +[NSException raise:format:] + 205 3 Foundation 0x00007fff38f381ca -[NSConcreteMutableAttributedString initWithString:attributes:] + 140 4 Electron Framework 0x00000001073f3650 _ZN4atom8TrayIcon15NotifyDragEndedEv + 3520 5 Electron Framework 0x00000001073f34e6 _ZN4atom8TrayIcon15NotifyDragEndedEv + 3158 6 Electron Framework 0x00000001073f4631 _ZN4atom13TrayIconCocoa8SetTitleERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE + 49 7 Electron Framework 0x000000010736678e _ZN4atom3api4Tray8SetTitleERKNSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEE + 30 8 Electron Framework 0x000000010730f1fe _ZN4base8internal7InvokerINS0_9BindStateIMNS_11CommandLineEFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvSC_EE3RunEPNS0_13BindStateBaseESC_ + 206 9 Electron Framework 0x000000010730f1bf _ZN4base8internal7InvokerINS0_9BindStateIMNS_11CommandLineEFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvSC_EE3RunEPNS0_13BindStateBaseESC_ + 143 10 Electron Framework 0x000000010731910f _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api3AppEFvRKNS_8FilePathEEJEEEFvPS5_S8_EE3RunEPNS0_13BindStateBaseEOSC_S8_ + 79 11 Electron Framework 0x0000000107368cc0 _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api4TrayEFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEEEJEEEFvPS5_SE_EE3RunEPNS0_13BindStateBaseEOSI_SE_ + 32 12 Electron Framework 0x000000010730b2a1 _ZN4atom3api3App11GetFileIconERKN4base8FilePathEPN4mate9ArgumentsE + 929 13 Electron Framework 0x0000000107318ffc _ZN4mate8internal10DispatcherIFvPN4atom3api3AppERKN4base8FilePathEEE18DispatchToCallbackERKN2v820FunctionCallbackInfoINSC_5ValueEEE + 460 14 Electron Framework 0x0000000107368b1c _ZN4mate8internal10DispatcherIFvPN4atom3api4TrayERKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEEEE18DispatchToCallbackERKN2v820FunctionCallbackInfoINSH_5ValueEEE + 124 15 libnode.dylib 0x0000000104bde071 _ZN2v88internal6StrDupEPKc + 609 16 libnode.dylib 0x0000000104c91ecc _ZNK2v88internal8compiler17BranchElimination21ControlPathConditionseqERKS3_ + 4028 17 libnode.dylib 0x0000000104c91503 _ZNK2v88internal8compiler17BranchElimination21ControlPathConditionseqERKS3_ + 1523 18 ??? 0x000008c5efb0463d 0x0 + 9646222886461 19 ??? 0x000008c5efbf45fc 0x0 + 9646223869436 20 ??? 0x000008c5efbbf9ce 0x0 + 9646223653326 21 ??? 0x000008c5efbf4da1 0x0 + 9646223871393 22 ??? 0x000008c5efbbf9ce 0x0 + 9646223653326 23 ??? 0x000008c5efb05d1b 0x0 + 9646222892315 24 ??? 0x000008c5efbf4048 0x0 + 9646223867976 25 ??? 0x000008c5efbbf9ce 0x0 + 9646223653326 ... more below that I can provide if we need it. ``` ### How to reproduce You will need a mac to reproduce this, since the tray title is a Mac only method: https://github.com/electron/electron/blob/master/docs/api/tray.md I have included a `zip` file that you can download and use to replicate this issue. I have not uploaded it to a repo though. I can if that would be easier. ```javascript const {app, Tray} = require('electron') const path = require('path') let tray = null app.on('ready', () => { createTray() }) // Quit the app when the window is closed app.on('window-all-closed', () => { app.quit() }) const createTray = () => { tray = new Tray(path.join(__dirname, 'tray.png')) tray.setTitle("") } ``` **Steps to reproduce:** 1. Download and unzip this file: [tray.zip](https://github.com/electron/electron/files/1823536/tray.zip) 2. run the app: ``` $ cd tray-example $ npm install $ npm start ```
https://github.com/electron/electron/issues/12343
https://github.com/electron/electron/pull/12352
6b80865bfef782c320870a61a9d1d3083453b4f0
9599615b234d2dbfaa2226ec544ea65b2d7b2d82
2018-03-19T02:36:55Z
c++
2018-03-19T15:49:39Z
closed
electron/electron
https://github.com/electron/electron
12,324
["lib/browser/api/menu.js", "spec/api-menu-spec.js"]
`menu.popup()` doesn't work without passing in window
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 2.0.0-beta.4 * Operating system: win x64 (inside a VM) NodeJs version: 8.10.0 ### Expected behavior <!-- What do you think should happen? --> When you right-click on the window a menu should popup like a context-menu ### Actual behavior <!-- What actually happens? --> The menu doesn't popup and instead gives this error: ![image](https://user-images.githubusercontent.com/11504707/37522595-dc8dc818-293d-11e8-824d-9f29df4c8094.png) ### How to reproduce Clone https://github.com/Mike-Wood/electron-context-menu-bug $ git clone [email protected]:Mike-Wood/electron-context-menu-bug.git $ npm install $ npm start || electron . This is the right-click code: ``` mainWindow.webContents.on('context-menu', function (e, params) { const template = [ { label: 'Edit', submenu: [ {role: 'undo'}, {role: 'redo'}, {type: 'separator'}, {role: 'cut'}, {role: 'copy'}, {role: 'paste'}, {role: 'pasteandmatchstyle'}, {role: 'delete'}, {role: 'selectall'} ] } ]; Menu.buildFromTemplate(template).popup(); }); ``` I found that just doing `Menu.buildFromTemplate(template).popup();` doesn't work but passing in the window does work (like this: `Menu.buildFromTemplate(template).popup(mainWindow);`) Its just that in the [docs](https://electronjs.org/docs/api/menu#menupopupbrowserwindow-options) it says its optional I tried this on version `1.8.3` and it works.
https://github.com/electron/electron/issues/12324
https://github.com/electron/electron/pull/12325
792837bd7184db318e2f00e9630a40e5dd83928f
31d688ad3dcf00852c45a00107e8ea95efee0f1e
2018-03-16T13:34:54Z
c++
2018-03-16T21:31:10Z
closed
electron/electron
https://github.com/electron/electron
12,316
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h", "atom/browser/atom_browser_client.cc", "atom/common/options_switches.cc", "atom/common/options_switches.h", "lib/browser/rpc-server.js", "lib/renderer/api/remote.js"]
Error: Cannot get property 'id' on missing remote object
* Electron version: 2.0.0-beta.4 * Operating system: macOS 10.13.3 ### Expected behavior A reload of the window works. ### Actual behavior A reload of the window does not work. ### How to reproduce * run VSCode exploration ([download](https://az764295.vo.msecnd.net/exploration/6bc3274250cc949c7fb1d654cbb6e59c8ddad697/VSCode-darwin-exploration.zip)) * run "Reload Window" command * sometimes I see the window stay blank after doing so and checking the console I see: ``` Uncaught (in promise) Error: Cannot get property 'id' on missing remote object 3 Error: Cannot get property 'id' on missing remote object 3 at throwRPCError (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/browser/rpc-server.js:143:17) at EventEmitter.<anonymous> (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/browser/rpc-server.js:384:7) at emitThree (events.js:136:13) at EventEmitter.emit (events.js:217:7) at WebContents.<anonymous> (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/browser/api/web-contents.js:295:13) at emitTwo (events.js:126:13) at WebContents.emit (events.js:214:7) at throwRPCError (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/browser/rpc-server.js:143:17) at EventEmitter.<anonymous> (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/browser/rpc-server.js:384:7) at emitThree (events.js:136:13) at EventEmitter.emit (events.js:217:7) at WebContents.<anonymous> (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/browser/api/web-contents.js:295:13) at emitTwo (events.js:126:13) at WebContents.emit (events.js:214:7) at Object.exception (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/renderer/api/remote.js:209:30) at metaToValue (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/renderer/api/remote.js:213:28) at Object.descriptor.get [as id] (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/electron.asar/renderer/api/remote.js:132:16) at file:///Applications/Visual%20Studio%20Code%20-%20Exploration.app/Contents/Resources/app/out/vs/workbench/electron-browser/bootstrap/index.js:11:97 at new Promise (<anonymous>) at file:///Applications/Visual%20Studio%20Code%20-%20Exploration.app/Contents/Resources/app/out/vs/workbench/electron-browser/bootstrap/index.js:10:838 ```
https://github.com/electron/electron/issues/12316
https://github.com/electron/electron/pull/12342
9599615b234d2dbfaa2226ec544ea65b2d7b2d82
0ac883c6d4d268d300f2ceba13946ce70e17e138
2018-03-16T05:40:51Z
c++
2018-03-20T04:54:47Z
closed
electron/electron
https://github.com/electron/electron
12,310
["atom/browser/api/atom_api_session.cc", "docs/api/session.md"]
No way to clear cache storage data
Steps: 1. Put some things in cache storage 2. Call `session.clearStorageData` Expected: Some way of clearing cache storage data Actual: No way of clearing cache storage data This seems like it might just be missing an option, in `atom/browser/api/atom_api_session.cc#GetStorageMask` there are only options for some storages. What's missing is a way of setting any of these: ``` REMOVE_DATA_MASK_CACHE_STORAGE REMOVE_DATA_MASK_PLUGIN_PRIVATE_DATA ``` * Electron version: 1.8.2 * Operating system: macos 10.13.3 Note: I didn't make a test app for this because it seems like the issue is obvious, let me know if you'd line one though.
https://github.com/electron/electron/issues/12310
https://github.com/electron/electron/pull/12546
ad2baccefa75f61c02cb03d6154a8d8a16b0f084
a0cac0555570b1c55d011d72e32f48ef6e0c9e28
2018-03-15T20:20:22Z
c++
2018-04-13T17:03:16Z
closed
electron/electron
https://github.com/electron/electron
12,308
["atom/browser/api/atom_api_web_contents.cc", "spec/api-browser-window-spec.js"]
Transparency from browserWindow.capturePage is lost after calling nativeImage.resize
* Electron version: 2.0.0beta3 & 1.8.3 * Operating system: OSX & Windows 10 64bit ### Expected behavior Resizing a nativeImage that is a product of calling BrowserWindow.capturePage should maintain transparency in all cases, not just when hardware acceleration is disabled ### Actual behavior Resizing a nativeImage that is a product of calling BrowserWindow.capturePage converts tranparent pixels to black. If you instantiate your app disabling the gpu / hardware acceleration (app.disableHardwareAcceleration) it works as one would expect. ### How to reproduce ``` git clone https://github.com/countravioli/electron-native-image-resize-transparency-bug cd electron-native-image-resize-transparency-bug npm install npm start npm run start-works ``` npm start - will run the app normally, illustrating the bug. Two images are written in the directory at the same level as app.js (original.png and resized.png) npm run start-works - will run the app with disableHardwareAcceleration showing things work. The same to pngs are created. The app will quit when its done. If you are on mac the pngs will open in your default application associated with the file type.
https://github.com/electron/electron/issues/12308
https://github.com/electron/electron/pull/12561
eca0436f5801fbb8342888ed079b4f54d648ce9f
6fc819dae1cbe3f2845ff53ca2ff01ec4087c342
2018-03-15T19:04:24Z
c++
2018-04-10T10:07:15Z
closed
electron/electron
https://github.com/electron/electron
12,275
["atom/browser/native_window_views.cc", "atom/browser/ui/views/menu_bar.cc", "atom/browser/ui/views/menu_bar.h", "atom/browser/ui/views/submenu_button.cc", "atom/browser/ui/views/submenu_button.h"]
Invisible menu on Linux
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 2.0.0-beta.3 * Operating system: Ubuntu 16.04.04 LTS ### Expected behavior App menu should be visible ### Actual behavior App menu is invisible ### How to reproduce - Run `electron` - Observe that the app menu is invisible. It is still possible to open submenus. ![screenshot from 2018-03-14 17-01-18](https://user-images.githubusercontent.com/19880051/37415303-7296c25e-27ab-11e8-8284-d213c8bf5230.png)
https://github.com/electron/electron/issues/12275
https://github.com/electron/electron/pull/12300
31d688ad3dcf00852c45a00107e8ea95efee0f1e
558ef7352d314f681215739f7458149eef5e9cd8
2018-03-14T16:16:58Z
c++
2018-03-16T21:37:36Z
closed
electron/electron
https://github.com/electron/electron
12,268
["lib/renderer/init.js"]
Windows: Require does not work when launched from a '\\' network share path
Hi, I ran in an issue when an electron executable is run through a server/network share path (`\\SERVERNAME\appdir\appname.exe`). The use of the require function runs into _Cannot find module_ errors. To reproduce the error, create a shortcut to launch an application directly from the server path (`\\SERVERNAME\appdir\appname.exe`). If you use the associated drive letter in Windows (e.g. drive letter `E:\` being mapped to `\\SERVERNAME` resulting in `E:\appdir\appname.exe`) it will work. I was able to track the error to a wrong `Module.filename` property in `internal/module::makeRequireFunction::require` once the renderer started loading modules from the web content. During calls to _require_ by electron in `renderer\init.js` the Module.filename property refers to the correct path beginning with `\\SERVERNAME\` but once require is called from within web contents the path is missing the `\\SERVERNAME\` (Module.filename is only `appdir\appname.exe` instead of `\\SERVERNAME\appdir\appname.exe`) which results in all required modules being not found. I think the point where this scenario is not cared for is in `renderer\init.js`: https://github.com/electron/electron/blob/9ed9885c8dd37f3da19a65328728261fdfb04703/lib/renderer/init.js#L143-L149 In my case the relevant`window.location` properties are: ``` { "host": "vboxsvr", "hostname": "vboxsvr", "href": "file://vboxsvr/VBox_Shared/appdir/resources/app.asar/templates/splashscreen.html", "origin": "file://", "pathname": "/VBox_Shared/appdir/resources/app.asar/templates/splashscreen.html", "port": "", "protocol": "file:", } ``` The in this scenario important `hostname` property seems to be discarded. Minimal example is the use of a page like this: ``` <!DOCTYPE html> <html> <body class="splashscreen"> <script> var package = require('../package.json') document.write(package.version) </script> </div> </body> </html> ``` * Electron version: 1.7.9 * Operating system: Windows 10 x64 I found references to this behavior in #3043 and some related issues from 2015 so this bug seems to exist for a long time. **Workaround**: As described above, use the associated network share drive letter instead of the server host: e.g. `E:\appdir\appname.exe` instead of `\\SERVERNAME\appdir\appname.exe` **Why it is still relevant:** When using NSIS installer and choosing an installation directory on a network share the _server host path_ will be used for any created shortcuts and _not the drive letter version_. So the shortcuts will not work if the user chooses to install on a network share.
https://github.com/electron/electron/issues/12268
https://github.com/electron/electron/pull/12282
1f8de33e751e89af1836e143df5007366f4a0b6b
9aeb61181ad71267f5735cd7a8ee5d4583b94514
2018-03-14T08:40:53Z
c++
2018-03-15T02:45:13Z
closed
electron/electron
https://github.com/electron/electron
12,237
["spec/node-spec.js"]
Possible CI flake: node feature contexts setInterval called under Chromium event loop in browser process can be scheduled in time
Found in the wild at [here](https://arm64-ci.electronjs.org/blue/organizations/jenkins/Electron%20ARM64%2Felectron/detail/PR-12236/1/pipeline) in a one-liner backport branch that had already passed & merged in master. ```text not ok 831 node feature contexts setInterval called under Chromium event loop in browser process can be scheduled in time Error: done() called multiple times at Suite.describe (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12236-EU723A3C757G34V6S3IPEHQZT3NDQJBEQF7J74MEHBDS44S6XKYA/spec/node-spec.js:185:7) at Suite.describe (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12236-EU723A3C757G34V6S3IPEHQZT3NDQJBEQF7J74MEHBDS44S6XKYA/spec/node-spec.js:184:5) at Suite.describe (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12236-EU723A3C757G34V6S3IPEHQZT3NDQJBEQF7J74MEHBDS44S6XKYA/spec/node-spec.js:136:3) at Object.<anonymous> (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12236-EU723A3C757G34V6S3IPEHQZT3NDQJBEQF7J74MEHBDS44S6XKYA/spec/node-spec.js:10:1) at Object.<anonymous> (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12236-EU723A3C757G34V6S3IPEHQZT3NDQJBEQF7J74MEHBDS44S6XKYA/spec/node-spec.js:400:3) at Module._compile (module.js:642:30) at Object.Module._extensions..js (module.js:653:10) ```
https://github.com/electron/electron/issues/12237
https://github.com/electron/electron/pull/12263
e7181eb89c7b58425e3a33cfe54203081cd1ffdc
9ed9885c8dd37f3da19a65328728261fdfb04703
2018-03-13T02:33:42Z
c++
2018-03-14T05:51:47Z
closed
electron/electron
https://github.com/electron/electron
12,200
["lib/renderer/security-warnings.js"]
"Electron Security Warning (Disabled webSecurity)" issued on webview incorrectly?
* Electron version: 2.0.0-beta.3 ### Expected behavior I have a renderer process with webSecurity disabled, but the webviews it contains have webSecurity enabled. I expect a webSecurity warning to be shown on the devtools of the renderer but not the webviews. ### Actual behavior The "Electron Security Warning (Disabled webSecurity)" is given in the devtools of the renderer as well as the devtools of the webviews. It appears that the code that decides whether to log the warning only uses the webContents of the renderer, not of the webview (https://github.com/electron/electron/blob/d586ef2f39d650f117054f32a523fd9786087e9f/lib/renderer/security-warnings.js#L80). My tests have shown that webSecurity is enabled on the webview, even though it's disabled on the renderer. Am I wrong about that? ### How to reproduce Create a renderer process with webSecurity disabled, and inside put a webview with webSecurity enabled. Check the devtools of both.
https://github.com/electron/electron/issues/12200
https://github.com/electron/electron/pull/12234
dd2c2660b91647acd97d1ed109e540888a055328
71795ecc620415d1a0893215dd001aa0dd0a1287
2018-03-09T18:10:04Z
c++
2018-03-13T01:55:32Z
closed
electron/electron
https://github.com/electron/electron
12,150
["atom/browser/api/atom_api_browser_view.cc", "atom/browser/api/atom_api_browser_window.cc", "atom/browser/api/atom_api_browser_window_mac.mm", "atom/browser/native_browser_view.cc", "atom/browser/native_browser_view.h", "atom/browser/native_browser_view_mac.h", "atom/browser/native_browser_view_mac.mm", "atom/browser/native_browser_view_views.cc", "atom/browser/native_browser_view_views.h"]
-webkit-app-region: drag prevents clicks on overlapping browser view
* Electron version: 1.8.2 * Operating system: macos 10.13.3 Reproducing repo: https://github.com/ibash/electron-webkit-app-drag Demonstrates a bug where `-webkit-app-region: drag` causes a browser view in front of it to miss click events. Oddly - it does not prevent hover events. Steps: 1. Clone https://github.com/ibash/electron-webkit-app-drag, `yarn install`, `yarn start` 2. Click "button1" 3. Click "button2" Expected: Clicking button1 or button2 pops up an alert: "button clicked!" Actual: Only clicking button2 pops up an alert: "button clicked!"
https://github.com/electron/electron/issues/12150
https://github.com/electron/electron/pull/12348
cd30a4e2d40a82aec722064c3bf3cafc53bee0d2
060b592fc83404f8131cf3fc64b678fb3381f723
2018-03-06T23:51:50Z
c++
2018-03-20T14:40:27Z
closed
electron/electron
https://github.com/electron/electron
12,126
["atom/browser/api/atom_api_screen_mac.mm", "lib/browser/api/screen.js", "spec/api-screen-spec.js"]
Deprecate getMenuBarHeight on macOS
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: some * Operating system: macos ### Expected behavior There is absolutely no need to expose `getMenubarHeight` specifically for macOS since screen provides a `workarea` which already reflects that. ``` $ require('electron').screen.getPrimaryDisplay().workArea Object {x: 0, y: 22, width: 1440, height: 829} $ require('electron').screen.getMenuBarHeight() 22 ``` ### Actual behavior <!-- What actually happens? --> ### How to reproduce <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . -->
https://github.com/electron/electron/issues/12126
https://github.com/electron/electron/pull/12135
642dc9695661b2db90fd1f7dad53d580bbba1bba
a3d4d461a3b4ba7c0b40b9e943a5cbfc163fd5ae
2018-03-05T15:17:36Z
c++
2018-03-06T01:56:51Z
closed
electron/electron
https://github.com/electron/electron
12,125
["lib/browser/guest-window-manager.js", "spec/chromium-spec.js"]
Bug: 2.0.0-beta.1 window.open(…) not showing when called from new BrowserWindow({show: false}).show()
* Electron version: 2.0.0-beta.1 * Operating system: macOS High 10.13.3 (17D102) ### Expected behavior When creating a BrowserWindow: ```js browserWindow = new BrowserWindow({ show: false }); browserWindow.once('ready-to-show', () => browserWindow.show()); ``` Which show the following: ```html <button onclick="() => window.open('…', 'custom-target')">Open</button> ``` Clicking the button should open a "shown" window, regardless of the `show` parameter passed when creating the initial browserWindow. ### Actual behavior What happens is that the window opens but is not visible. If instead we modified `main.js` as follows: ```js browserWindow = new BrowserWindow(); browserWindow.hide(); // dynamically hide instead browserWindow.once('ready-to-show', () => browserWindow.show()); ``` Then the child window created by `window.open(…)` opens and is shown as expected. ### How to reproduce This is a straightforward scenario: **main.js** ```js browserWindow = new BrowserWindow({ // Disable this in test b show: false, }); // Disable this in test a browserWindow.hide(); browserWindow.loadURL(`file://${__dirname}/index.html`) browserWindow.once('ready-to-show', () => browserWindow.show()); ``` **index.html** ```html <script> window.open('chrome://gpu', 'chrome-gpu'); </script> ``` But let me know if you can't reproduce it.
https://github.com/electron/electron/issues/12125
https://github.com/electron/electron/pull/12228
e648662cfd75d7cbb9297595b43e22a46e212996
8e07e7483f4ece8fcd7a025d42d48cdac7562d4f
2018-03-05T12:57:10Z
c++
2018-03-13T08:41:00Z
closed
electron/electron
https://github.com/electron/electron
12,085
["docs/tutorial/boilerplates-and-clis.md"]
Broken links in documentation
Almost every link on [this page in the docs](https://electronjs.org/docs/tutorial/boilerplates-and-clis) is pointing to the page that you are currently on.
https://github.com/electron/electron/issues/12085
https://github.com/electron/electron/pull/12103
a3e33a313ada1c9153788bfbdc5886cf2450c78f
1413f22095b9d6d4f9f4ffc2178b5b5be70024db
2018-02-28T23:25:55Z
c++
2018-03-06T15:52:08Z
closed
electron/electron
https://github.com/electron/electron
12,079
["docs/development/build-instructions-linux.md", "docs/development/build-instructions-osx.md", "script/bootstrap.py", "script/tls.py"]
Reflect Python version requirement in the dev docs
Mac OS default Python 2.7.10 is not sufficient anymore, see discussion in the #12020 for details. Dev docs should mention it and have a code snippet or step-by-step instruction how to install a proper Python version on all supported platforms. cc @codebytere, @jkleinsc, @zeke
https://github.com/electron/electron/issues/12079
https://github.com/electron/electron/pull/12276
b160093b91b562765b002c271e5ff04dc172d327
e8735cc005d539b935598c2aa455db35912c43af
2018-02-28T15:15:52Z
c++
2018-05-16T21:19:49Z
closed
electron/electron
https://github.com/electron/electron
12,050
["spec/api-app-spec.js", "spec/fixtures/api/singleton/main.js"]
not ok 11 app module app.exit(exitCode) exits gracefully on macos
This causes intermittent CI failures, showing up several times a week but is not reliably reproducible. [Example](https://mac-ci.electronjs.org/blue/organizations/jenkins/Electron%20org%2Felectron/detail/PR-12037/3/pipeline) ```text not ok 11 app module app.exit(exitCode) exits gracefully on macos AssertionError [ERR_ASSERTION]: false == true at ChildProcess.exec (/Users/electron/workspace/ctron_org_electron_PR-12037-TWW4HVB7PMGXB75WUNR2QMXJH33XQBHCRTABBUJLBSRYSKBW4FWA/spec/api-app-spec.js:172:11) at ChildProcess.exithandler (child_process.js:294:5) at emitTwo (events.js:126:13) at ChildProcess.emit (events.js:214:7) at maybeClose (internal/child_process.js:925:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5) ```
https://github.com/electron/electron/issues/12050
https://github.com/electron/electron/pull/12139
f170914def12638880f13658b0a54ecb5fd41f8b
65ee977a865b683af7766a39419bd340738ba4f2
2018-02-26T14:42:02Z
c++
2018-03-07T03:01:17Z
closed
electron/electron
https://github.com/electron/electron
12,046
["atom/browser/api/atom_api_browser_window.cc", "atom/browser/api/atom_api_browser_window.h", "atom/browser/native_window.cc", "atom/browser/native_window.h", "atom/browser/native_window_mac.h", "atom/browser/native_window_mac.mm", "spec/api-browser-window-spec.js"]
Calling addTabbedWindow on the same window crashes natively
* Electron version: 2.0.0-beta.1 * Operating system: macOS 10.13.3 ### Expected behavior Electron should not crash. ### Actual behavior Electron crashes natively: ``` Application Specific Backtrace 1: 0 CoreFoundation 0x00007fff44cebfcb __exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff6b98dc76 objc_exception_throw + 48 2 CoreFoundation 0x00007fff44cf1d62 +[NSException raise:format:arguments:] + 98 3 Foundation 0x00007fff46df0300 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 193 4 AppKit 0x00007fff42aa6708 -[NSWindowStackController insertWindow:atIndex:] + 246 5 AppKit 0x00007fff42aabbda -[NSWindowStackController moveWindow:toWindowStackController:atIndex:] + 236 6 AppKit 0x00007fff42635f48 -[NSWindow(NSWindowTabbing) _addTabbedWindow:ordered:] + 225 7 Electron Framework 0x000000010b5990d8 _ZN4atom15NativeWindowMac15AddTabbedWindowEPNS_12NativeWindowE + 104 8 Electron Framework 0x000000010b562984 _ZN4atom3api6Window15AddTabbedWindowEPNS_12NativeWindowE + 36 9 Electron Framework 0x000000010b4e5bf1 _ZN4base8internal7InvokerINS0_9BindStateIMN4atom7BrowserEFvPN4mate9ArgumentsEEJNS0_17UnretainedWrapperIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseEOS7_ + 193 10 Electron Framework 0x000000010b4e5bbf _ZN4base8internal7InvokerINS0_9BindStateIMN4atom7BrowserEFvPN4mate9ArgumentsEEJNS0_17UnretainedWrapperIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseEOS7_ + 143 11 Electron Framework 0x000000010b4ec0ef _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api3AppEFbPN4mate9ArgumentsEEJEEEFbPS5_S8_EE3RunEPNS0_13BindStateBaseEOSC_OS8_ + 79 12 Electron Framework 0x000000010b56b060 _ZN4base8internal7InvokerINS0_9BindStateIMN4atom3api6WindowEFvPNS3_12NativeWindowEEJEEEFvPS5_S7_EE3RunEPNS0_13BindStateBaseEOSB_OS7_ + 32 13 Electron Framework 0x000000010b4ec044 _ZN4mate8internal10DispatcherIFbPN4atom3api3AppEPNS_9ArgumentsEEE18DispatchToCallbackERKN2v820FunctionCallbackInfoINSA_5ValueEEE + 500 14 Electron Framework 0x000000010b4ecc6c _ZN4mate8internal10DispatcherIFvPN4atom3api3AppEPNS_9ArgumentsEEE18DispatchToCallbackERKN2v820FunctionCallbackInfoINSA_5ValueEEE + 396 15 Electron Framework 0x000000010b56aecc _ZN4mate8internal10DispatcherIFvPN4atom3api6WindowEPNS2_12NativeWindowEEE18DispatchToCallbackERKN2v820FunctionCallbackInfoINSA_5ValueEEE + 124 16 libnode.dylib 0x000000011015e071 _ZN2v88internal6StrDupEPKc + 609 17 libnode.dylib 0x0000000110211ecc _ZNK2v88internal8compiler17BranchElimination21ControlPathConditionseqERKS3_ + 4028 18 libnode.dylib 0x0000000110211503 _ZNK2v88internal8compiler17BranchElimination21ControlPathConditionseqERKS3_ + 1523 19 ??? 0x00000446c2c0463d 0x0 + 4701961602621 20 ??? 0x00000446c2cf45fc 0x0 + 4701962585596 21 ??? 0x00000446c2cbf9ce 0x0 + 4701962369486 22 ??? 0x00000446c2c05d1b 0x0 + 4701961608475 23 ??? 0x00000446c2cf4048 0x0 + 4701962584136 24 ??? 0x00000446c2cbf9ce 0x0 + 4701962369486 ``` ### How to reproduce * run the electron quick start example * after creating the main window, add: `mainWindow.addTabbedWindow(mainWindow);`
https://github.com/electron/electron/issues/12046
https://github.com/electron/electron/pull/12059
1db05a265589a60b8b35841adfb40969efb90d89
dfa1dc43df17037df68b5f39ca7c3c2bb424e9c1
2018-02-26T11:14:06Z
c++
2018-02-28T09:18:10Z
closed
electron/electron
https://github.com/electron/electron
12,029
["atom/browser/api/atom_api_session.cc", "atom/browser/api/atom_api_web_request.cc", "atom/browser/net/atom_network_delegate.cc", "atom/browser/net/atom_network_delegate.h", "brightray/browser/url_request_context_getter.h"]
Crash on startup in 2.0.0-beta.1 (using onBeforeRequest)
* Electron version: 2.0.0-beta.1 * Operating system: MacOS 10.12 We've got a call to `session.defaultSession.webRequest.onBeforeRequest()` during startup which seems to frequently (but not always) crash the process. Based on the stack dump, it looks like [this line](https://github.com/electron/electron/blob/6bc7c8cc496a2bd899b2511de39f8fa1b0d7147c/atom/browser/net/atom_network_delegate.cc#L245) might be the culprit. Maybe a race on memory initialization where `response_listeners_` isn't ready to use? <details> Process: Electron [42562] Path: /Users/USER/*/Electron.app/Contents/MacOS/Electron Identifier: com.github.electron Version: 2.0.0 (2.0.0) Code Type: X86-64 (Native) Parent Process: ??? [42551] Responsible: Electron [42562] User ID: 501 Date/Time: 2018-02-23 12:11:57.458 -0600 OS Version: Mac OS X 10.12.6 (16G1114) Report Version: 12 Anonymous UUID: 0C178369-565E-AB38-0223-08ACFC1273F4 Sleep/Wake UUID: E6947A8A-611C-4278-A70E-182EB6700183 Time Awake Since Boot: 2400000 seconds Time Since Wake: 170000 seconds System Integrity Protection: enabled Crashed Thread: 26 Chrome_IOThread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000040 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [0] VM Regions Near 0x40: --> __TEXT 000000010ae2c000-000000010ae2d000 [ 4K] r-x/rwx SM=COW /Users/USER/*/Electron.app/Contents/MacOS/Electron Thread 0:: CrBrowserMain Dispatch queue: com.apple.main-thread 0 ??? 0x0000132168bbf6ec 0 + 21034211997420 1 ??? 0x0000132168bbf9ce 0 + 21034211998158 2 ??? 0x0000132168b05743 0 + 21034211235651 3 ??? 0x0000132168bf5d87 0 + 21034212220295 4 ??? 0x0000132168bbf9ce 0 + 21034211998158 5 ??? 0x0000132168b05d1b 0 + 21034211237147 6 ??? 0x0000132168b57d30 0 + 21034211573040 7 ??? 0x0000132168bf45fc 0 + 21034212214268 8 ??? 0x0000132168bbf9ce 0 + 21034211998158 9 ??? 0x0000132168bf45fc 0 + 21034212214268 10 ??? 0x0000132168bbf9ce 0 + 21034211998158 11 ??? 0x0000132168b05743 0 + 21034211235651 12 ??? 0x0000132168bf5d87 0 + 21034212220295 13 ??? 0x0000132168bbf9ce 0 + 21034211998158 14 ??? 0x0000132168b05d1b 0 + 21034211237147 15 ??? 0x0000132168b57d30 0 + 21034211573040 16 ??? 0x0000132168bf45fc 0 + 21034212214268 17 ??? 0x0000132168bbf9ce 0 + 21034211998158 18 ??? 0x0000132168bf45fc 0 + 21034212214268 19 ??? 0x0000132168bbf9ce 0 + 21034211998158 20 ??? 0x0000132168b05d1b 0 + 21034211237147 21 ??? 0x0000132168bf4da1 0 + 21034212216225 22 ??? 0x0000132168bbf9ce 0 + 21034211998158 23 ??? 0x0000132168bf4da1 0 + 21034212216225 24 ??? 0x0000132168bbf9ce 0 + 21034211998158 25 ??? 0x0000132168b05d1b 0 + 21034211237147 26 ??? 0x0000132168bf4048 0 + 21034212212808 27 ??? 0x0000132168bbf9ce 0 + 21034211998158 28 ??? 0x0000132168bf48a5 0 + 21034212214949 29 ??? 0x0000132168bbf9ce 0 + 21034211998158 30 ??? 0x0000132168b05d1b 0 + 21034211237147 31 ??? 0x0000132168bbe479 0 + 21034211992697 32 ??? 0x0000132168b0410d 0 + 21034211229965 33 libnode.dylib 0x000000010fe56bd7 0x10f77e000 + 7179223 34 libnode.dylib 0x000000010fe5690c v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 140 35 libnode.dylib 0x000000010fc14c20 v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 352 36 libnode.dylib 0x000000010f861766 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) + 118 37 libnode.dylib 0x000000010f86193d node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) + 109 38 libnode.dylib 0x000000010f8618bc node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*, node::async_context) + 92 39 libnode.dylib 0x000000010f86183f node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, node::async_context) + 95 40 com.github.electron.framework 0x000000010af48bff mate::internal::CallMethodWithArgs(v8::Isolate*, v8::Local<v8::Object>, char const*, std::__1::vector<v8::Local<v8::Value>, std::__1::allocator<v8::Local<v8::Value> > >*) + 79 41 com.github.electron.framework 0x000000010ae3f975 0x10ae2f000 + 67957 42 com.github.electron.framework 0x000000010ae3f84e 0x10ae2f000 + 67662 43 com.github.electron.framework 0x000000010ae3f7b1 0x10ae2f000 + 67505 44 com.github.electron.framework 0x000000010ae36153 0x10ae2f000 + 29011 45 com.github.electron.framework 0x000000010ae36128 atom::api::App::OnFinishLaunching(base::DictionaryValue const&) + 56 46 com.github.electron.framework 0x000000010ae3616d non-virtual thunk to atom::api::App::OnFinishLaunching(base::DictionaryValue const&) + 13 47 com.github.electron.framework 0x000000010aedc564 atom::Browser::DidFinishLaunching(base::DictionaryValue const&) + 164 48 com.github.electron.framework 0x000000010aee709c 0x10ae2f000 + 753820 49 com.apple.CoreFoundation 0x00007fffb066f45c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12 50 com.apple.CoreFoundation 0x00007fffb066f35b _CFXRegistrationPost + 427 51 com.apple.CoreFoundation 0x00007fffb066f0c2 ___CFXNotificationPost_block_invoke + 50 52 com.apple.CoreFoundation 0x00007fffb062c523 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1827 53 com.apple.CoreFoundation 0x00007fffb062b55c _CFXNotificationPost + 604 54 com.apple.Foundation 0x00007fffb2050677 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66 55 com.apple.AppKit 0x00007fffae29274f -[NSApplication _postDidFinishNotification] + 297 56 com.apple.AppKit 0x00007fffae2924b4 -[NSApplication _sendFinishLaunchingNotification] + 208 57 com.apple.AppKit 0x00007fffae155819 -[NSApplication(NSAppleEventHandling) _handleAEOpenEvent:] + 552 58 com.apple.AppKit 0x00007fffae15546b -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 661 59 com.apple.Foundation 0x00007fffb209bafd -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 290 60 com.apple.Foundation 0x00007fffb209b977 _NSAppleEventManagerGenericHandler + 102 61 com.apple.AE 0x00007fffb149ff26 aeDispatchAppleEvent(AEDesc const*, AEDesc*, unsigned int, unsigned char*) + 544 62 com.apple.AE 0x00007fffb149fc9d dispatchEventAndSendReply(AEDesc const*, AEDesc*) + 39 63 com.apple.AE 0x00007fffb149fba9 aeProcessAppleEvent + 312 64 com.apple.HIToolbox 0x00007fffafbcaddf AEProcessAppleEvent + 55 65 com.apple.AppKit 0x00007fffae150d1d _DPSNextEvent + 1833 66 com.apple.AppKit 0x00007fffae8cc7ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 67 com.apple.AppKit 0x00007fffae1453db -[NSApplication run] + 926 68 com.github.electron.framework 0x000000010b0bd8ce 0x10ae2f000 + 2681038 69 com.github.electron.framework 0x000000010b0bc2cc 0x10ae2f000 + 2675404 70 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 71 com.github.electron.framework 0x000000010b334d6f 0x10ae2f000 + 5266799 72 com.github.electron.framework 0x000000010b334b90 0x10ae2f000 + 5266320 73 com.github.electron.framework 0x000000010b337212 0x10ae2f000 + 5276178 74 com.github.electron.framework 0x000000010b330bec 0x10ae2f000 + 5250028 75 com.github.electron.framework 0x000000010b283d00 0x10ae2f000 + 4541696 76 com.github.electron.framework 0x000000010ce6cfe4 0x10ae2f000 + 33808356 77 com.github.electron.framework 0x000000010b282b14 0x10ae2f000 + 4537108 78 com.github.electron.framework 0x000000010ae31404 AtomMain + 68 79 com.github.electron 0x000000010ae2cf26 main + 38 80 libdyld.dylib 0x00007fffc5ddf235 start + 1 Thread 1: 0 libsystem_kernel.dylib 0x00007fffc5f0e44e __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffc5ff848e _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffc5ff807d start_wqthread + 13 Thread 2: 0 libsystem_kernel.dylib 0x00007fffc5f0e44e __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffc5ff8621 _pthread_wqthread + 1426 2 libsystem_pthread.dylib 0x00007fffc5ff807d start_wqthread + 13 Thread 3: 0 libsystem_kernel.dylib 0x00007fffc5f0e44e __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffc5ff848e _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffc5ff807d start_wqthread + 13 Thread 4: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f8b3259 0x10f77e000 + 1266265 4 libnode.dylib 0x000000010f8b324c 0x10f77e000 + 1266252 5 libnode.dylib 0x000000010f8b3194 0x10f77e000 + 1266068 6 libnode.dylib 0x000000010f8b2ac2 0x10f77e000 + 1264322 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 5: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f8b3259 0x10f77e000 + 1266265 4 libnode.dylib 0x000000010f8b324c 0x10f77e000 + 1266252 5 libnode.dylib 0x000000010f8b3194 0x10f77e000 + 1266068 6 libnode.dylib 0x000000010f8b2ac2 0x10f77e000 + 1264322 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 6: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f8b3259 0x10f77e000 + 1266265 4 libnode.dylib 0x000000010f8b324c 0x10f77e000 + 1266252 5 libnode.dylib 0x000000010f8b3194 0x10f77e000 + 1266068 6 libnode.dylib 0x000000010f8b2ac2 0x10f77e000 + 1264322 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 7: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f92ba83 0x10f77e000 + 1759875 4 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 5 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 6 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 8: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f92ba83 0x10f77e000 + 1759875 4 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 5 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 6 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 9: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f92ba83 0x10f77e000 + 1759875 4 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 5 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 6 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 10: 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010f938179 uv_cond_wait + 9 3 libnode.dylib 0x000000010f92ba83 0x10f77e000 + 1759875 4 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 5 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 6 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 11:: NetworkConfigWatcher 0 libsystem_kernel.dylib 0x00007fffc5f0634a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffc5f05797 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fffb065a434 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fffb06598c1 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fffb0659114 CFRunLoopRunSpecific + 420 5 com.apple.Foundation 0x00007fffb206c252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 6 com.github.electron.framework 0x000000010b0bd71e 0x10ae2f000 + 2680606 7 com.github.electron.framework 0x000000010b0bc2cc 0x10ae2f000 + 2675404 8 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 9 com.github.electron.framework 0x000000010b0f69f9 0x10ae2f000 + 2914809 10 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 11 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 13 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 12:: DnsConfigService 0 libsystem_kernel.dylib 0x00007fffc5f0ed96 kevent + 10 1 com.github.electron.framework 0x000000010b124169 0x10ae2f000 + 3101033 2 com.github.electron.framework 0x000000010b1232fd 0x10ae2f000 + 3097341 3 com.github.electron.framework 0x000000010b0bc12f 0x10ae2f000 + 2674991 4 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 5 com.github.electron.framework 0x000000010b0f69f9 0x10ae2f000 + 2914809 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 13:: WorkerPool/28931 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff9833 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010b0767cb 0x10ae2f000 + 2389963 3 com.github.electron.framework 0x000000010b11ed46 0x10ae2f000 + 3079494 4 com.github.electron.framework 0x000000010b11f1d8 0x10ae2f000 + 3080664 5 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 6 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 14:: WorkerPool/29187 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff9833 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010b0767cb 0x10ae2f000 + 2389963 3 com.github.electron.framework 0x000000010b11ed46 0x10ae2f000 + 3079494 4 com.github.electron.framework 0x000000010b11f1d8 0x10ae2f000 + 3080664 5 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 6 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 15:: CrShutdownDetector 0 libsystem_kernel.dylib 0x00007fffc5f0f246 read + 10 1 com.github.electron.framework 0x000000010aed61af 0x10ae2f000 + 684463 2 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 3 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 4 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 5 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 16:: TaskSchedulerServiceThread 0 libsystem_kernel.dylib 0x00007fffc5f0ed96 kevent + 10 1 com.github.electron.framework 0x000000010b124169 0x10ae2f000 + 3101033 2 com.github.electron.framework 0x000000010b1232fd 0x10ae2f000 + 3097341 3 com.github.electron.framework 0x000000010b0bc116 0x10ae2f000 + 2674966 4 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 5 com.github.electron.framework 0x000000010b0f69f9 0x10ae2f000 + 2914809 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 17:: TaskSchedulerBackgroundWorker0 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff9833 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010b0767cb 0x10ae2f000 + 2389963 3 com.github.electron.framework 0x000000010b11c130 0x10ae2f000 + 3068208 4 com.github.electron.framework 0x000000010b11c261 0x10ae2f000 + 3068513 5 com.github.electron.framework 0x000000010b0d5d58 0x10ae2f000 + 2780504 6 com.github.electron.framework 0x000000010b0d619a 0x10ae2f000 + 2781594 7 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 8 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 9 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 10 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 18:: TaskSchedulerBackgroundBlockingWorker0 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff9833 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010b0767cb 0x10ae2f000 + 2389963 3 com.github.electron.framework 0x000000010b11c130 0x10ae2f000 + 3068208 4 com.github.electron.framework 0x000000010b11c261 0x10ae2f000 + 3068513 5 com.github.electron.framework 0x000000010b0d5d58 0x10ae2f000 + 2780504 6 com.github.electron.framework 0x000000010b0d63c4 0x10ae2f000 + 2782148 7 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 8 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 9 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 10 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 19:: TaskSchedulerForegroundWorker0 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff9833 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010b0767cb 0x10ae2f000 + 2389963 3 com.github.electron.framework 0x000000010b11c130 0x10ae2f000 + 3068208 4 com.github.electron.framework 0x000000010b11c261 0x10ae2f000 + 3068513 5 com.github.electron.framework 0x000000010b0d5d58 0x10ae2f000 + 2780504 6 com.github.electron.framework 0x000000010b0d619a 0x10ae2f000 + 2781594 7 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 8 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 9 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 10 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 20:: TaskSchedulerForegroundBlockingWorker0 0 com.github.electron.framework 0x000000010b29bb70 0x10ae2f000 + 4639600 1 com.github.electron.framework 0x000000010b2af22c 0x10ae2f000 + 4719148 2 com.github.electron.framework 0x000000010b0f4272 0x10ae2f000 + 2904690 3 com.github.electron.framework 0x000000010b0f5ab1 0x10ae2f000 + 2910897 4 com.github.electron.framework 0x000000010b0f5fe3 0x10ae2f000 + 2912227 5 com.github.electron.framework 0x000000010b0f5724 0x10ae2f000 + 2909988 6 com.github.electron.framework 0x000000010b0d6268 0x10ae2f000 + 2781800 7 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 8 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 9 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 10 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 21:: TaskSchedulerSingleThreadForegroundBlocking0 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010b11c10e 0x10ae2f000 + 3068174 3 com.github.electron.framework 0x000000010b11bfbf 0x10ae2f000 + 3067839 4 com.github.electron.framework 0x000000010b0d5d4a 0x10ae2f000 + 2780490 5 com.github.electron.framework 0x000000010b0d619a 0x10ae2f000 + 2781594 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 22:: TaskSchedulerSingleThreadForegroundBlocking1 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010b11c10e 0x10ae2f000 + 3068174 3 com.github.electron.framework 0x000000010b11bfbf 0x10ae2f000 + 3067839 4 com.github.electron.framework 0x000000010b0d5d4a 0x10ae2f000 + 2780490 5 com.github.electron.framework 0x000000010b0d619a 0x10ae2f000 + 2781594 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 23:: TaskSchedulerSingleThreadForegroundBlocking2 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010b11c10e 0x10ae2f000 + 3068174 3 com.github.electron.framework 0x000000010b11bfbf 0x10ae2f000 + 3067839 4 com.github.electron.framework 0x000000010b0d5d4a 0x10ae2f000 + 2780490 5 com.github.electron.framework 0x000000010b0d619a 0x10ae2f000 + 2781594 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 24:: TaskSchedulerSingleThreadForegroundBlocking3 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010b11c10e 0x10ae2f000 + 3068174 3 com.github.electron.framework 0x000000010b11bfbf 0x10ae2f000 + 3067839 4 com.github.electron.framework 0x000000010b0d5d4a 0x10ae2f000 + 2780490 5 com.github.electron.framework 0x000000010b0d63c4 0x10ae2f000 + 2782148 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 25:: TaskSchedulerSingleThreadForegroundBlocking4 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010b11c10e 0x10ae2f000 + 3068174 3 com.github.electron.framework 0x000000010b11bfbf 0x10ae2f000 + 3067839 4 com.github.electron.framework 0x000000010b0d5d4a 0x10ae2f000 + 2780490 5 com.github.electron.framework 0x000000010b0d619a 0x10ae2f000 + 2781594 6 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 7 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 26 Crashed:: Chrome_IOThread 0 com.github.electron.framework 0x000000010ae59735 0x10ae2f000 + 173877 1 com.github.electron.framework 0x000000010aefe28d 0x10ae2f000 + 848525 2 com.github.electron.framework 0x000000010aefcad0 0x10ae2f000 + 842448 3 com.github.electron.framework 0x000000010aefcc15 atom::AtomNetworkDelegate::SetResponseListenerInIO(atom::AtomNetworkDelegate::ResponseEvent, std::__1::set<URLPattern, std::__1::less<URLPattern>, std::__1::allocator<URLPattern> > const&, base::Callback<void (base::DictionaryValue const&, base::Callback<void (base::DictionaryValue const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 245 4 com.github.electron.framework 0x000000010aebaf35 0x10ae2f000 + 573237 5 com.github.electron.framework 0x000000010aebaeff 0x10ae2f000 + 573183 6 com.github.electron.framework 0x000000010aebaec7 0x10ae2f000 + 573127 7 com.github.electron.framework 0x000000010aebae44 base::internal::Invoker<base::internal::BindState<void (atom::AtomNetworkDelegate::*)(atom::AtomNetworkDelegate::ResponseEvent, std::__1::set<URLPattern, std::__1::less<URLPattern>, std::__1::allocator<URLPattern> > const&, base::Callback<void (base::DictionaryValue const&, base::Callback<void (base::DictionaryValue const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), base::internal::UnretainedWrapper<atom::AtomNetworkDelegate>, atom::AtomNetworkDelegate::ResponseEvent, std::__1::set<URLPattern, std::__1::less<URLPattern>, std::__1::allocator<URLPattern> >, base::Callback<void (base::DictionaryValue const&, base::Callback<void (base::DictionaryValue const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> >, void ()>::Run(base::internal::BindStateBase*) + 20 8 com.github.electron.framework 0x000000010b0f4272 0x10ae2f000 + 2904690 9 com.github.electron.framework 0x000000010b0b952b 0x10ae2f000 + 2663723 10 com.github.electron.framework 0x000000010b0b9915 0x10ae2f000 + 2664725 11 com.github.electron.framework 0x000000010b0b9be9 0x10ae2f000 + 2665449 12 com.github.electron.framework 0x000000010b0bc055 0x10ae2f000 + 2674773 13 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 14 com.github.electron.framework 0x000000010b342914 0x10ae2f000 + 5323028 15 com.github.electron.framework 0x000000010b3429d4 0x10ae2f000 + 5323220 16 com.github.electron.framework 0x000000010b0f69f9 0x10ae2f000 + 2914809 17 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 18 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 19 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 20 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 27:: CompositorTileWorker1/36611 0 libsystem_kernel.dylib 0x00007fffc5f0dbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffc5ff97fa _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010b21eaa8 0x10ae2f000 + 4127400 3 com.github.electron.framework 0x000000010b0e1b3d 0x10ae2f000 + 2829117 4 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 5 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 6 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 7 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 28:: AudioThread 0 libsystem_kernel.dylib 0x00007fffc5f0634a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffc5f05797 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fffb065a434 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fffb06598c1 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fffb0659114 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010b0bd40f 0x10ae2f000 + 2679823 6 com.github.electron.framework 0x000000010b0bc2cc 0x10ae2f000 + 2675404 7 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 8 com.github.electron.framework 0x000000010b0f69f9 0x10ae2f000 + 2914809 9 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 10 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 11 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 12 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 29: 0 libsystem_kernel.dylib 0x00007fffc5f06386 semaphore_wait_trap + 10 1 libnode.dylib 0x000000010f938020 uv_sem_wait + 16 2 com.github.electron.framework 0x000000010af69e80 atom::NodeBindings::EmbedThreadRunner(void*) + 48 3 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 4 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 5 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 30:: NetworkConfigWatcher 0 libsystem_kernel.dylib 0x00007fffc5f0634a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffc5f05797 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fffb065a434 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fffb06598c1 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fffb0659114 CFRunLoopRunSpecific + 420 5 com.apple.Foundation 0x00007fffb206c252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 6 com.github.electron.framework 0x000000010b0bd71e 0x10ae2f000 + 2680606 7 com.github.electron.framework 0x000000010b0bc2cc 0x10ae2f000 + 2675404 8 com.github.electron.framework 0x000000010b0d2823 0x10ae2f000 + 2766883 9 com.github.electron.framework 0x000000010b0f69f9 0x10ae2f000 + 2914809 10 com.github.electron.framework 0x000000010b0c73b7 0x10ae2f000 + 2720695 11 libsystem_pthread.dylib 0x00007fffc5ff893b _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffc5ff8887 _pthread_start + 286 13 libsystem_pthread.dylib 0x00007fffc5ff808d thread_start + 13 Thread 26 crashed with X86 Thread State (64-bit): rax: 0x0000000000000040 rbx: 0x0000000000000038 rcx: 0x0000700010de6850 rdx: 0x0000700010de68a4 rdi: 0x0000000000000040 rsi: 0x0000700010de6808 rbp: 0x0000700010de67e0 rsp: 0x0000700010de67b0 r8: 0x0000700010de6858 r9: 0x00007f9bddf4b808 r10: 0x00007fffcba33320 r11: 0x00007f9bddd0fab0 r12: 0x0000000000000038 r13: 0x0000000000000040 r14: 0x0000700010de6850 r15: 0x0000700010de68a4 rip: 0x000000010ae59735 rfl: 0x0000000000010206 cr2: 0x0000000000000040 Logical CPU: 1 Error Code: 0x00000004 Trap Number: 14 Binary Images: 0x10ae2c000 - 0x10ae2cff7 +com.github.electron (2.0.0 - 2.0.0) <CA88D587-5BC4-350E-A4C7-CA76B93C54F3> /Users/USER/*/Electron.app/Contents/MacOS/Electron 0x10ae2f000 - 0x10f0c5f1f +com.github.electron.framework (0) <EA39D127-5C25-323F-94F0-9B0A7C5EB45F> /Users/USER/*/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework 0x10f646000 - 0x10f661fff +com.github.Squirrel (1.0 - 1) <E4398068-33D3-3A00-9DBE-5ACC9B022501> /Users/USER/*/Electron.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel 0x10f683000 - 0x10f6e6ff7 +org.reactivecocoa.ReactiveCocoa (1.0 - 1) <701B20DE-3ADD-3643-B52A-E05744C30DB3> /Users/USER/*/Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa 0x10f758000 - 0x10f76cfff +org.mantle.Mantle (1.0 - ???) <31915DD6-48E6-3706-A076-C9D4CE17F4F6> /Users/USER/*/Electron.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle 0x10f77e000 - 0x1105fafff +libnode.dylib (0) <C1396426-0F8C-3106-A969-80C082D65A54> /Users/USER/*/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib 0x1108a2000 - 0x1108e0ff7 com.apple.audio.midi.CoreMIDI (1.10 - 88) <5E2D1F53-B466-312E-AEA7-117B68C9A7F0> /System/Library/Frameworks/CoreMIDI.framework/Versions/A/CoreMIDI 0x110908000 - 0x11091efff com.apple.SafariServices.framework (12604 - 12604.5.6.1.1) <8B44CF12-8B46-3E05-A6E6-8B726BEDF7D5> /System/Library/Frameworks/SafariServices.framework/Versions/A/SafariServices 0x110939000 - 0x110952fff libexpat.1.dylib (15.1) <588CA992-60BB-363B-BEE7-3CC0A26C1AFA> /usr/lib/libexpat.1.dylib 0x110ad7000 - 0x110b14dc7 dyld (433.5) <322C06B7-8878-311D-888C-C8FD2CA96FF3> /usr/lib/dyld 0x110b62000 - 0x110dcffe7 +libffmpeg.dylib (0) <875948D9-4D04-3B2E-9235-A52EFAD781D0> /Users/USER/*/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib 0x110fd9000 - 0x110feaff7 +electron-57.node (???) <52A72948-3C1E-35B3-BD68-8435FA7417B7> /Users/USER/*/electron-57.node 0x113e10000 - 0x113f94ff7 +node_sqlite3.node (???) <A05081C3-6C43-3CFF-94D9-DD6B42E95B52> /Users/USER/*/node_sqlite3.node 0x113fb2000 - 0x113fcefff +electron-57.node (???) <8C665CB6-3FA5-3513-8FBA-3C137AE7F191> /Users/USER/*/electron-57.node 0x113fdb000 - 0x11402cfcb +libsodium.dylib (0) <AC1AE9B6-CF1E-35AD-B47E-BADBF5BCC4D9> /Users/USER/*/libsodium.dylib 0x114039000 - 0x11404eff7 +ad-block.node (0) <846053BD-4961-302C-9852-353D008A3051> /Users/USER/*/ad-block.node 0x11406b000 - 0x11406eff7 +fse.node (???) <589AB341-5B15-33E9-8877-5444303E2CED> /Users/USER/*/fse.node 0x7fffacdfd000 - 0x7fffacfbefff com.apple.avfoundation (2.0 - 1187.36) <2F390EAD-07BB-3788-9E73-13104C2E04CD> /System/Library/Frameworks/AVFoundation.framework/Versions/A/AVFoundation 0x7fffacfbf000 - 0x7fffad061ff7 com.apple.audio.AVFAudio (1.0 - ???) <7997D588-B542-3EBB-B822-D719C1114BB4> /System/Library/Frameworks/AVFoundation.framework/Versions/A/Frameworks/AVFAudio.framework/Versions/A/AVFAudio 0x7fffad12c000 - 0x7fffad12cfff com.apple.Accelerate (1.11 - Accelerate 1.11) <916E360F-323C-3AE1-AB3D-D1F3B284AEE9> /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x7fffad145000 - 0x7fffad65efeb com.apple.vImage (8.1 - ???) <B58A7937-BEE2-38FE-87F4-5D5F40D31DC9> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x7fffad65f000 - 0x7fffad7d0ff3 libBLAS.dylib (1185.50.4) <4087FFE0-627E-3623-96B4-F0A9A1991E09> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x7fffad7d1000 - 0x7fffad7e5ffb libBNNS.dylib (15) <254698C7-7D36-3FFF-864E-ADEEEE543076> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBNNS.dylib 0x7fffad7e6000 - 0x7fffadbdcfef libLAPACK.dylib (1185.50.4) <C35FFB2F-A0E6-3903-8A3C-113A74BCBCA2> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x7fffadbdd000 - 0x7fffadbf3fff libLinearAlgebra.dylib (1185.50.4) <345CAACF-7263-36EF-B69B-793EA8B390AF> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLinearAlgebra.dylib 0x7fffadbf4000 - 0x7fffadbfafff libQuadrature.dylib (3) <EF56C8E6-DE22-3C69-B543-A8648F335FDD> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libQuadrature.dylib 0x7fffadbfb000 - 0x7fffadc0fff7 libSparseBLAS.dylib (1185.50.4) <67BA432E-FB59-3C78-A8BE-ED4274CBC359> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libSparseBLAS.dylib 0x7fffadc10000 - 0x7fffadd97fe7 libvDSP.dylib (600.60.1) <4155F45B-41CD-3782-AE8F-7AE740FD83C3> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x7fffadd98000 - 0x7fffade4afff libvMisc.dylib (600.60.1) <E18365D7-DCC4-3304-A8D1-395E656D7B99> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x7fffade4b000 - 0x7fffade4bfff com.apple.Accelerate.vecLib (3.11 - vecLib 3.11) <7C5733E7-0568-3E7D-AF61-160F19FED544> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x7fffae10a000 - 0x7fffaeee3ff3 com.apple.AppKit (6.9 - 1504.83.101) <12BF4F22-5FDE-309E-8A19-BC97CC293D46> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x7fffaeef5000 - 0x7fffaeef5fff com.apple.ApplicationServices (48 - 48) <DA687F9A-7B2D-342B-8796-16E45344F853> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x7fffaeef6000 - 0x7fffaef64ff7 com.apple.ApplicationServices.ATS (377 - 422.3) <73C230CF-3213-3DCA-B528-664FEC76A90C> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x7fffaeffe000 - 0x7fffaf12dfff libFontParser.dylib (194.13) <BE507D17-17D0-37E8-A317-6921118BD283> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontParser.dylib 0x7fffaf12e000 - 0x7fffaf178fff libFontRegistry.dylib (196.4) <EA96AE47-3369-3DEA-BB82-98348ADBD85B> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontRegistry.dylib 0x7fffaf275000 - 0x7fffaf31fff7 com.apple.ColorSync (4.12.0 - 502.2) <ACA4001E-A0E3-33F6-9CD6-EEC2AA15E322> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x7fffaf320000 - 0x7fffaf371fff com.apple.HIServices (1.22 - 593) <045870A9-1D92-3FEF-8722-671E99A35E71> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x7fffaf372000 - 0x7fffaf381ff3 com.apple.LangAnalysis (1.7.0 - 1.7.0) <2CBE7F61-2056-3F96-99A1-0D527796AFA6> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x7fffaf382000 - 0x7fffaf3cffff com.apple.print.framework.PrintCore (12 - 491) <5027FD58-F0EE-33E4-8577-934CA06CD2AF> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x7fffaf3d0000 - 0x7fffaf40bfff com.apple.QD (3.12 - 313) <B339C41D-8CDF-3342-8414-F9717DCCADD4> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x7fffaf40c000 - 0x7fffaf417fff com.apple.speech.synthesis.framework (6.6.2 - 6.6.2) <7853EFF4-62B9-394E-B7B8-41A645656820> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x7fffaf418000 - 0x7fffaf624ff7 com.apple.audio.toolbox.AudioToolbox (1.14 - 1.14) <AF56E94D-5F38-3718-99A3-D23BA0B56BA9> /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x7fffaf625000 - 0x7fffaf625fff com.apple.audio.units.AudioUnit (1.14 - 1.14) <860636FF-F3B1-32AB-BD6E-75357FB16625> /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x7fffaf78e000 - 0x7fffafb6afff com.apple.CFNetwork (811.8 - 811.8) <3FB812CB-F4BF-3C47-B772-042FC4D59A33> /System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x7fffafb84000 - 0x7fffafb84fff com.apple.Carbon (154 - 157) <69F403C7-F0CB-34E6-89B0-235CF4978C17> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x7fffafb85000 - 0x7fffafb88fff com.apple.CommonPanels (1.2.6 - 98) <BF04BB22-D54C-309E-9F5C-897D969CAF70> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels 0x7fffafb89000 - 0x7fffafe92fff com.apple.HIToolbox (2.1.1 - 857.8) <5367366E-747E-32CF-8E76-93CD8E7424C7> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x7fffafe93000 - 0x7fffafe96ff7 com.apple.help (1.3.5 - 49) <B1A930E3-5907-3677-BACD-858EF68B172D> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help 0x7fffafe97000 - 0x7fffafe9cfff com.apple.ImageCapture (9.0 - 9.0) <341252B4-E082-361A-B756-6A330259C741> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture 0x7fffafe9d000 - 0x7fffaff34ff3 com.apple.ink.framework (10.9 - 219) <1BD40B45-FD33-3177-A935-565EE5FC79D7> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink 0x7fffaff35000 - 0x7fffaff4ffff com.apple.openscripting (1.7 - 172.1) <78F3256B-AF4C-324A-A591-ECA4443A469F> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting 0x7fffaff50000 - 0x7fffaff51ff3 com.apple.print.framework.Print (12 - 267) <E2F82F1F-DC27-3EF0-9F75-B354F701450A> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print 0x7fffaff52000 - 0x7fffaff54ff7 com.apple.securityhi (9.0 - 55006) <3CC6C7D1-613E-36A9-8159-113A634AEE6C> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI 0x7fffaff55000 - 0x7fffaff5bff7 com.apple.speech.recognition.framework (6.0.1 - 6.0.1) <082895DC-3AC7-3DEF-ADCA-5B018C19C9D3> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x7fffb003c000 - 0x7fffb003cfff com.apple.Cocoa (6.11 - 22) <85EDFBE1-75F0-369E-8CA8-C6A639B98FA6> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x7fffb0186000 - 0x7fffb0213fff com.apple.audio.CoreAudio (4.3.0 - 4.3.0) <78767F88-91D4-31CE-AAC6-1F9407F479BB> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x7fffb0214000 - 0x7fffb0227fff com.apple.CoreBluetooth (1.0 - 1) <BCB78777-76F0-3CC1-8443-9E61AEF7EF63> /System/Library/Frameworks/CoreBluetooth.framework/Versions/A/CoreBluetooth 0x7fffb0228000 - 0x7fffb0523fff com.apple.CoreData (120 - 754.2) <4C9CAB2C-60D4-3694-A0A0-5B04B14BD14E> /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x7fffb0524000 - 0x7fffb05d1ff7 com.apple.CoreDisplay (1.0 - 1) <53D1EAFE-23A4-398D-BF52-E4299E670DB6> /System/Library/Frameworks/CoreDisplay.framework/Versions/A/CoreDisplay 0x7fffb05d2000 - 0x7fffb0a6bff7 com.apple.CoreFoundation (6.9 - 1349.90) <F07A2387-602E-3D9E-8708-3B3430BD7D82> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x7fffb0a6c000 - 0x7fffb10eefff com.apple.CoreGraphics (2.0 - 1070.22) <FAB476BB-B5CD-3936-8AFC-41229DBDF0E8> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x7fffb10ef000 - 0x7fffb1332ffb com.apple.CoreImage (12.4.0 - 451.4.9) <BE4303C9-C9D9-361D-AC94-DBE40EB6700E> /System/Library/Frameworks/CoreImage.framework/Versions/A/CoreImage 0x7fffb1399000 - 0x7fffb144afff com.apple.CoreMedia (1.0 - 1907.59.1.6) <570690D8-A956-3629-9E46-4F8BDDB8A82C> /System/Library/Frameworks/CoreMedia.framework/Versions/A/CoreMedia 0x7fffb144b000 - 0x7fffb1496ff7 com.apple.CoreMediaIO (805.0 - 4932) <B12C56E0-2FE8-3734-8C45-4B03CAA18A0B> /System/Library/Frameworks/CoreMediaIO.framework/Versions/A/CoreMediaIO 0x7fffb1497000 - 0x7fffb1497fff com.apple.CoreServices (775.19 - 775.19) <5046FF69-034E-3570-AC30-D14AA469F669> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x7fffb1498000 - 0x7fffb14e9fff com.apple.AE (712.5 - 712.5) <61F2AE2C-E04E-3FDF-9E88-201325136C83> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x7fffb14ea000 - 0x7fffb17c5ff7 com.apple.CoreServices.CarbonCore (1159.6 - 1159.6) <08AC074C-965B-3EDF-8E45-0707C8DE9EAD> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x7fffb17c6000 - 0x7fffb17f9fff com.apple.DictionaryServices (1.2 - 274) <D23866E2-F7C8-3984-A9D4-96552CCDE573> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices 0x7fffb17fa000 - 0x7fffb1802ff3 com.apple.CoreServices.FSEvents (1230.50.1 - 1230.50.1) <2AD1B0E5-7214-37C4-8D11-A27C9CAC0F74> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents 0x7fffb1803000 - 0x7fffb196fff7 com.apple.LaunchServices (775.19 - 775.19) <76F27409-F3E0-31A7-BA40-060FBD10CB8B> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x7fffb1970000 - 0x7fffb1a20ffb com.apple.Metadata (10.7.0 - 1075.40) <B734F567-EC70-39AF-BB86-46C97065580F> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x7fffb1a21000 - 0x7fffb1a80fff com.apple.CoreServices.OSServices (775.19 - 775.19) <E6EB5564-B9AB-366F-ACF0-723D394482C0> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x7fffb1a81000 - 0x7fffb1af1fff com.apple.SearchKit (1.4.0 - 1.4.0) <7A6DDA2B-03F1-3137-BA9E-1CC211973E26> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x7fffb1af2000 - 0x7fffb1b37ff7 com.apple.coreservices.SharedFileList (38 - 38) <DA096678-93AB-3291-BDE2-482F1D544589> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList 0x7fffb1bc0000 - 0x7fffb1d0dffb com.apple.CoreText (352.0 - 544.16) <543AFBA5-4E6B-3F81-BC45-81ED9707BD9C> /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText 0x7fffb1d0e000 - 0x7fffb1d43ff3 com.apple.CoreVideo (1.8 - 235.3) <AC11D5FB-C77B-34F5-B942-F698E84C229F> /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x7fffb1d44000 - 0x7fffb1db5ffb com.apple.framework.CoreWLAN (11.0 - 1200.31) <64338DCB-8204-3B62-A9C5-0CDDC89F60D6> /System/Library/Frameworks/CoreWLAN.framework/Versions/A/CoreWLAN 0x7fffb1eb3000 - 0x7fffb1eb8fff com.apple.DiskArbitration (2.7 - 2.7) <70F56042-EF04-3BAF-9E04-90F423FB2BCC> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x7fffb204a000 - 0x7fffb23f0fff com.apple.Foundation (6.9 - 1349.91) <F24B1521-454A-3AE7-B41F-F8FA95BA0490> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x7fffb241c000 - 0x7fffb244dff7 com.apple.GSS (4.0 - 2.0) <30A77A95-CBD4-3BD7-9BFF-8426071F5D9D> /System/Library/Frameworks/GSS.framework/Versions/A/GSS 0x7fffb244e000 - 0x7fffb2466ff7 com.apple.GameController (1.0 - 1) <DAC8C83B-7EC8-3A88-A725-E13DD905BF4F> /System/Library/Frameworks/GameController.framework/Versions/A/GameController 0x7fffb250d000 - 0x7fffb25b0fff com.apple.Bluetooth (5.0.5 - 5.0.5f1) <5C79A832-84A9-3DC0-9F46-F2B10A3072DC> /System/Library/Frameworks/IOBluetooth.framework/Versions/A/IOBluetooth 0x7fffb25b1000 - 0x7fffb2647ff7 com.apple.framework.IOKit (2.0.2 - 1324.60.4) <454036AD-86AA-3ABB-8C53-B5F654A6824D> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x7fffb2648000 - 0x7fffb264effb com.apple.IOSurface (159.12 - 159.12) <E3D6FCED-F938-30A3-AD08-0998B674A492> /System/Library/Frameworks/IOSurface.framework/Versions/A/IOSurface 0x7fffb264f000 - 0x7fffb26a0ff7 com.apple.ImageCaptureCore (7.0 - 7.0) <A640CA2F-8093-34AB-947C-26679ECB8A6D> /System/Library/Frameworks/ImageCaptureCore.framework/Versions/A/ImageCaptureCore 0x7fffb26a1000 - 0x7fffb2801fef com.apple.ImageIO.framework (3.3.0 - 1599.13) <443879A7-48C6-37ED-AC0B-166EEEABA662> /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x7fffb2802000 - 0x7fffb2806fff libGIF.dylib (1599.13) <11C5D9D7-B8A1-3D53-BA50-B25976FE6379> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0x7fffb2807000 - 0x7fffb28f7ff7 libJP2.dylib (1599.13) <C495FB08-0CD2-36FC-8196-FAD3D598A010> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJP2.dylib 0x7fffb28f8000 - 0x7fffb291bffb libJPEG.dylib (1599.13) <D22E2431-76A5-39B4-AF0B-174CF282A1CE> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x7fffb291c000 - 0x7fffb2943ff7 libPng.dylib (1599.13) <561865FA-A51B-3EFF-ABFF-B4566B90B1A2> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x7fffb2944000 - 0x7fffb2946ff3 libRadiance.dylib (1599.13) <6559253B-8FE2-3884-BC93-95BB7705A6D1> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x7fffb2947000 - 0x7fffb2995ffb libTIFF.dylib (1599.13) <8FC594B3-6BBF-3A70-9994-203E9B330B5F> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x7fffb2af3000 - 0x7fffb36fdfff com.apple.JavaScriptCore (12603 - 12603.3.8) <9557271A-1838-38DD-93E3-D8A9ECDE3B6B> /System/Library/Frameworks/JavaScriptCore.framework/Versions/A/JavaScriptCore 0x7fffb36fe000 - 0x7fffb3717ff7 com.apple.Kerberos (3.0 - 1) <B9D242EB-E325-3A21-9812-C77CBBFB0D51> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos 0x7fffb39a1000 - 0x7fffb39a7fff com.apple.MediaAccessibility (1.0 - 97.1.1) <0BD82735-6644-37CE-B13D-8E7CC59A1752> /System/Library/Frameworks/MediaAccessibility.framework/Versions/A/MediaAccessibility 0x7fffb39bd000 - 0x7fffb3ef6ff7 com.apple.MediaToolbox (1.0 - 1907.59.1.6) <FA068C6F-0506-35C3-A637-C4AFF82411DB> /System/Library/Frameworks/MediaToolbox.framework/Versions/A/MediaToolbox 0x7fffb3ef7000 - 0x7fffb3f52fff com.apple.Metal (87.18 - 87.18) <E3618B54-C728-34CA-9E8A-9BD33A295D31> /System/Library/Frameworks/Metal.framework/Versions/A/Metal 0x7fffb483b000 - 0x7fffb4843fff com.apple.NetFS (6.0 - 4.0) <14A24D00-5673-330A-959D-87F72040DEFF> /System/Library/Frameworks/NetFS.framework/Versions/A/NetFS 0x7fffb4a23000 - 0x7fffb4a71ff3 com.apple.opencl (2.8.6 - 2.8.6) <A6140AC4-7579-3AC2-B7EE-08A8899BC811> /System/Library/Frameworks/OpenCL.framework/Versions/A/OpenCL 0x7fffb4a72000 - 0x7fffb4a8bffb com.apple.CFOpenDirectory (10.12 - 194) <A64E9A01-3F6E-36EA-9C10-88C564A68C9D> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/Frameworks/CFOpenDirectory.framework/Versions/A/CFOpenDirectory 0x7fffb4a8c000 - 0x7fffb4a97ff7 com.apple.OpenDirectory (10.12 - 194) <4298FFD0-B1A7-3064-AF5B-708B3FA38671> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/OpenDirectory 0x7fffb4a98000 - 0x7fffb4a9afff libCVMSPluginSupport.dylib (14.0.16) <AA2468D1-9169-3424-8EE4-0470E9050E21> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCVMSPluginSupport.dylib 0x7fffb4a9b000 - 0x7fffb4a9eff7 libCoreFSCache.dylib (156.3) <687C4CC3-6537-344B-8BE1-5234C8CB2864> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreFSCache.dylib 0x7fffb4a9f000 - 0x7fffb4aa3fff libCoreVMClient.dylib (156.3) <E7AEFCBE-B6BF-3C7C-9A4E-E78CB04DB794> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreVMClient.dylib 0x7fffb4aa4000 - 0x7fffb4aadff7 libGFXShared.dylib (14.0.16) <170D07F3-2D30-3D4B-80A0-971E0A765709> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGFXShared.dylib 0x7fffb4aae000 - 0x7fffb4ab9fff libGL.dylib (14.0.16) <0801F3B9-A525-32BB-9BC0-478947CE21D9> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x7fffb4aba000 - 0x7fffb4af6ff7 libGLImage.dylib (14.0.16) <FE39C57B-056C-3CBF-B653-A8F2005631C1> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x7fffb4c6e000 - 0x7fffb4cafff7 libGLU.dylib (14.0.16) <B285EAD6-B3AA-3753-BB85-75864BD6E76C> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x7fffb5617000 - 0x7fffb5625fff com.apple.opengl (14.0.16 - 14.0.16) <B428BB89-8FE1-3527-BF3E-F8F0A1060884> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0x7fffb56c2000 - 0x7fffb5809fff com.apple.QTKit (7.7.3 - 2978.8) <80B27C5D-087F-3B83-AF99-AD6BA2E1105D> /System/Library/Frameworks/QTKit.framework/Versions/A/QTKit 0x7fffb580a000 - 0x7fffb5a74ff7 com.apple.imageKit (3.0 - 1023) <9C547565-CBAA-3ACB-A3F6-1366A0DCDCB4> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/ImageKit.framework/Versions/A/ImageKit 0x7fffb5a75000 - 0x7fffb5b3cfff com.apple.PDFKit (1.0 - 1) <BE82F14C-B20C-3771-B16C-F0723F6552AD> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/PDFKit.framework/Versions/A/PDFKit 0x7fffb5b3d000 - 0x7fffb6063ff7 com.apple.QuartzComposer (5.1 - 356) <C66293F6-EF05-3B36-8524-081CEB9FADD7> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzComposer.framework/Versions/A/QuartzComposer 0x7fffb6064000 - 0x7fffb6087ffb com.apple.quartzfilters (1.10.0 - 1.10.0) <365342ED-7A1A-3C75-AE60-90764E96034C> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzFilters.framework/Versions/A/QuartzFilters 0x7fffb6088000 - 0x7fffb6175fff com.apple.QuickLookUIFramework (5.0 - 720.7) <3136C23E-399E-3296-928A-B18EC9FC423C> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuickLookUI.framework/Versions/A/QuickLookUI 0x7fffb6176000 - 0x7fffb6176fff com.apple.quartzframework (1.5 - 21) <09455972-8A33-3D61-B193-BA7E7CF984CA> /System/Library/Frameworks/Quartz.framework/Versions/A/Quartz 0x7fffb6177000 - 0x7fffb6377fff com.apple.QuartzCore (1.11 - 453.39.4) <31B739DC-81E1-3249-9A43-E501FECA8240> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x7fffb6378000 - 0x7fffb63cdfff com.apple.QuickLookFramework (5.0 - 720.7) <3BD7BA2F-924C-3EFF-B26E-3F930E62E6B4> /System/Library/Frameworks/QuickLook.framework/Versions/A/QuickLook 0x7fffb68df000 - 0x7fffb6be1ff7 com.apple.security (7.0 - 57740.60.20) <A7DA9073-C3C2-3FEA-B531-471AB9F40609> /System/Library/Frameworks/Security.framework/Versions/A/Security 0x7fffb6be2000 - 0x7fffb6c57fff com.apple.securityfoundation (6.0 - 55132.50.7) <1276FFB8-05B8-3760-9EA7-2037B7FE2FBC> /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation 0x7fffb6c58000 - 0x7fffb6c81fff com.apple.securityinterface (10.0 - 55079.50.4) <62F43A76-80F3-3C98-BAD0-357141D6111F> /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface 0x7fffb6c82000 - 0x7fffb6c85ff3 com.apple.xpc.ServiceManagement (1.0 - 1) <BE0F9708-0B55-3E78-A15E-C287B8ED13BA> /System/Library/Frameworks/ServiceManagement.framework/Versions/A/ServiceManagement 0x7fffb6ec5000 - 0x7fffb6ed0ffb com.apple.StoreKit (1.0 - 584) <A3111CF4-FB8C-3A75-8953-36EB447D4809> /System/Library/Frameworks/StoreKit.framework/Versions/A/StoreKit 0x7fffb700c000 - 0x7fffb707bff7 com.apple.SystemConfiguration (1.14 - 1.14) <B471E0FA-3AC6-3A34-82C8-4FCF4B389368> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x7fffb707c000 - 0x7fffb742afff com.apple.VideoToolbox (1.0 - 1907.59.1.6) <EB2577A4-DCDF-3FD1-B5FA-42A55653A74D> /System/Library/Frameworks/VideoToolbox.framework/Versions/A/VideoToolbox 0x7fffb98d2000 - 0x7fffb98edff3 com.apple.AppContainer (4.0 - 307.50.21) <C2E6BA3D-81FF-39C3-B4BF-DBB9A17DE078> /System/Library/PrivateFrameworks/AppContainer.framework/Versions/A/AppContainer 0x7fffb98ee000 - 0x7fffb98fbff3 com.apple.AppSandbox (4.0 - 307.50.21) <BF9FA426-8C11-358B-9E1F-A3901E3F2B14> /System/Library/PrivateFrameworks/AppSandbox.framework/Versions/A/AppSandbox 0x7fffb98fc000 - 0x7fffb991effb com.apple.framework.Apple80211 (12.0 - 1200.47) <6C01014A-49D0-312D-A4EF-BFB5B7882F9C> /System/Library/PrivateFrameworks/Apple80211.framework/Versions/A/Apple80211 0x7fffb991f000 - 0x7fffb992efeb com.apple.AppleFSCompression (88.50.3 - 1.0) <478E8BFF-8BA2-375E-BE02-BA27F115C15A> /System/Library/PrivateFrameworks/AppleFSCompression.framework/Versions/A/AppleFSCompression 0x7fffb9a19000 - 0x7fffb9aa497f com.apple.AppleJPEG (1.0 - 1) <B9E9570D-04A4-34E4-B756-D200043B25B8> /System/Library/PrivateFrameworks/AppleJPEG.framework/Versions/A/AppleJPEG 0x7fffb9add000 - 0x7fffb9ae0ff3 com.apple.AppleSystemInfo (3.1.5 - 3.1.5) <42A1731A-A576-307A-B07C-9F8F64696CB7> /System/Library/PrivateFrameworks/AppleSystemInfo.framework/Versions/A/AppleSystemInfo 0x7fffb9ae1000 - 0x7fffb9b33fff com.apple.AppleVAFramework (5.0.36 - 5.0.36) <B272678B-2EA8-3F04-BB0F-3CE62D1E4F58> /System/Library/PrivateFrameworks/AppleVA.framework/Versions/A/AppleVA 0x7fffb9ed7000 - 0x7fffb9f55ff7 com.apple.backup.framework (1.8.5 - 1.8.5) <CC679891-E8F5-3166-8EB6-AEA06954A52D> /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup 0x7fffbabe0000 - 0x7fffbac07ff3 com.apple.ChunkingLibrary (173 - 173) <FC2165F9-FC93-39C0-8323-C2F43A5E00A3> /System/Library/PrivateFrameworks/ChunkingLibrary.framework/Versions/A/ChunkingLibrary 0x7fffbb520000 - 0x7fffbb52bff7 com.apple.CommerceCore (1.0 - 584) <F13121B4-5F5B-3BDE-AFE3-341F56A8DD11> /System/Library/PrivateFrameworks/CommerceKit.framework/Versions/A/Frameworks/CommerceCore.framework/Versions/A/CommerceCore 0x7fffbb52c000 - 0x7fffbb535ffb com.apple.CommonAuth (4.0 - 2.0) <44E4467E-90BB-3CC4-9E57-9B09D7E90081> /System/Library/PrivateFrameworks/CommonAuth.framework/Versions/A/CommonAuth 0x7fffbb6ba000 - 0x7fffbba99ff7 com.apple.CoreAUC (226.0.0 - 226.0.0) <FBF6C5BC-5937-3957-B6BA-E101DF9B0DF6> /System/Library/PrivateFrameworks/CoreAUC.framework/Versions/A/CoreAUC 0x7fffbba9a000 - 0x7fffbbacafff com.apple.CoreAVCHD (5.9.0 - 5900.4.1) <3F6857D1-AE7C-3593-B064-930F5BB7269E> /System/Library/PrivateFrameworks/CoreAVCHD.framework/Versions/A/CoreAVCHD 0x7fffbbc7e000 - 0x7fffbbc8efff com.apple.CoreEmoji (1.0 - 40.3.3) <E9A28301-2D79-3A97-A046-028258A6ABE5> /System/Library/PrivateFrameworks/CoreEmoji.framework/Versions/A/CoreEmoji 0x7fffbbd53000 - 0x7fffbbd69ff3 com.apple.CoreMediaAuthoring (2.2 - 956) <AEBFF55F-BF1E-3CA5-AA9C-1CE22218A665> /System/Library/PrivateFrameworks/CoreMediaAuthoring.framework/Versions/A/CoreMediaAuthoring 0x7fffbbd70000 - 0x7fffbbe00ffb com.apple.CorePDF (4.0 - 4) <7F50E4A6-940C-33F5-BE4E-7E01AFE98A8F> /System/Library/PrivateFrameworks/CorePDF.framework/Versions/A/CorePDF 0x7fffbbfc9000 - 0x7fffbbff9ff3 com.apple.CoreServicesInternal (276.2 - 276.2) <05EB7D45-DD4C-3A0F-AC63-A0C2A68E6481> /System/Library/PrivateFrameworks/CoreServicesInternal.framework/Versions/A/CoreServicesInternal 0x7fffbc28a000 - 0x7fffbc319ff7 com.apple.CoreSymbolication (62046) <9685A34A-C6FD-3681-8F7E-211D48298DD2> /System/Library/PrivateFrameworks/CoreSymbolication.framework/Versions/A/CoreSymbolication 0x7fffbc31a000 - 0x7fffbc459fe7 com.apple.coreui (2.1 - 431.3) <8D0FA478-9B6C-3D6D-8ADF-8677BA0BF134> /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI 0x7fffbc45a000 - 0x7fffbc52aff3 com.apple.CoreUtils (5.1 - 510.31) <7FBB03B5-13E2-3284-B5DF-6C73AD774479> /System/Library/PrivateFrameworks/CoreUtils.framework/Versions/A/CoreUtils 0x7fffbc57a000 - 0x7fffbc5dfff3 com.apple.framework.CoreWiFi (12.0 - 1200.31) <926A9CE7-6F3F-3EB6-A392-81FF485F0B7A> /System/Library/PrivateFrameworks/CoreWiFi.framework/Versions/A/CoreWiFi 0x7fffbc5e0000 - 0x7fffbc5eeff7 com.apple.CrashReporterSupport (10.12 - 827) <802A9B81-E349-348B-90AB-10E40B654250> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport 0x7fffbc660000 - 0x7fffbc66affb com.apple.framework.DFRFoundation (1.0 - 104.25) <7CFF896C-EF22-3941-BB3D-F3615CE4C908> /System/Library/PrivateFrameworks/DFRFoundation.framework/Versions/A/DFRFoundation 0x7fffbc66b000 - 0x7fffbc66fff3 com.apple.DSExternalDisplay (3.1 - 380) <4B5E3FF0-E8C3-38CC-BF72-418C928956AB> /System/Library/PrivateFrameworks/DSExternalDisplay.framework/Versions/A/DSExternalDisplay 0x7fffbc6a5000 - 0x7fffbc71affb com.apple.datadetectorscore (7.0 - 539.1) <84F04DEF-DF0A-3F93-AEE9-B6FAC781164B> /System/Library/PrivateFrameworks/DataDetectorsCore.framework/Versions/A/DataDetectorsCore 0x7fffbc756000 - 0x7fffbc795fff com.apple.DebugSymbols (137 - 137) <58A70B66-2628-3CFE-B103-2200D95FC5F7> /System/Library/PrivateFrameworks/DebugSymbols.framework/Versions/A/DebugSymbols 0x7fffbc796000 - 0x7fffbc8a7fff com.apple.desktopservices (1.11.5 - 1.11.5) <46A9D4F3-1EF8-373C-98A4-AD48D285E484> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x7fffbc9ea000 - 0x7fffbc9f5fff com.apple.DisplayServicesFW (3.1 - 380) <0BDF6C17-5E5F-33F8-8E99-C7350C6F9667> /System/Library/PrivateFrameworks/DisplayServices.framework/Versions/A/DisplayServices 0x7fffbcb8f000 - 0x7fffbcfc0ff7 com.apple.vision.FaceCore (3.3.2 - 3.3.2) <9391D5A3-738C-3136-9D07-518CB43DBADA> /System/Library/PrivateFrameworks/FaceCore.framework/Versions/A/FaceCore 0x7fffbe317000 - 0x7fffbe317fff libmetal_timestamp.dylib (600.0.49.9) <E5EED927-1671-3390-BCBB-D76201D63C73> /System/Library/PrivateFrameworks/GPUCompiler.framework/libmetal_timestamp.dylib 0x7fffbe5e8000 - 0x7fffbe604fff com.apple.GenerationalStorage (2.0 - 267.1) <3DE1C580-D089-362D-8582-8DE68A3C5F13> /System/Library/PrivateFrameworks/GenerationalStorage.framework/Versions/A/GenerationalStorage 0x7fffbed15000 - 0x7fffbed8bff3 com.apple.Heimdal (4.0 - 2.0) <9541C717-96FF-32D3-8F0B-5048525DAA70> /System/Library/PrivateFrameworks/Heimdal.framework/Versions/A/Heimdal 0x7fffbf3a6000 - 0x7fffbf3adffb com.apple.IOAccelerator (311.16.2 - 311.16.2) <96FA28B6-B03D-3A5E-AF07-0AE4486D2968> /System/Library/PrivateFrameworks/IOAccelerator.framework/Versions/A/IOAccelerator 0x7fffbf3af000 - 0x7fffbf3c3ff7 com.apple.IOPresentment (1.0 - 29.10) <30DF04EE-10E2-353F-845F-A97B87DF3207> /System/Library/PrivateFrameworks/IOPresentment.framework/Versions/A/IOPresentment 0x7fffbf3c4000 - 0x7fffbf3e6fff com.apple.IconServices (74.4 - 74.4) <218DDD05-35F4-3833-B98D-471ED0EBC031> /System/Library/PrivateFrameworks/IconServices.framework/Versions/A/IconServices 0x7fffbf482000 - 0x7fffbf492ff3 com.apple.IntlPreferences (2.0 - 216) <15B0DF1F-24C3-3A51-9032-1DD150B7D321> /System/Library/PrivateFrameworks/IntlPreferences.framework/Versions/A/IntlPreferences 0x7fffbf4cd000 - 0x7fffbf684fff com.apple.LanguageModeling (1.0 - 123.2.5) <A8CA965F-0399-310D-91C3-B93DDDE9A442> /System/Library/PrivateFrameworks/LanguageModeling.framework/Versions/A/LanguageModeling 0x7fffbfcf4000 - 0x7fffbfcf7fff com.apple.Mangrove (1.0 - 1) <98814966-FD65-302B-B47E-00928DC34E5C> /System/Library/PrivateFrameworks/Mangrove.framework/Versions/A/Mangrove 0x7fffbffa5000 - 0x7fffc001eff7 com.apple.MetalPerformanceShaders.MetalPerformanceShaders (1.0 - 1) <C323FC94-FFA5-3EE6-B2AC-7E61EA92F304> /System/Library/PrivateFrameworks/MetalPerformanceShaders.framework/Versions/A/MetalPerformanceShaders 0x7fffc0183000 - 0x7fffc0191fff com.apple.MobileKeyBag (2.0 - 1.0) <D0983DB7-EF9D-3E19-A084-21319ECE5846> /System/Library/PrivateFrameworks/MobileKeyBag.framework/Versions/A/MobileKeyBag 0x7fffc01a2000 - 0x7fffc01caff7 com.apple.MultitouchSupport.framework (368.16 - 368.16) <E2FE1821-C7CC-3C35-BEB3-6DC693F5128D> /System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/A/MultitouchSupport 0x7fffc027c000 - 0x7fffc0287fff com.apple.NetAuth (6.2 - 6.2) <97F487D6-8089-31A8-B68C-6C1EAC6ED1B5> /System/Library/PrivateFrameworks/NetAuth.framework/Versions/A/NetAuth 0x7fffc0b5f000 - 0x7fffc0ba0ff3 com.apple.PerformanceAnalysis (1.148.3 - 148.3) <ED3CFDFC-878E-30C2-929B-C2CD43D702DE> /System/Library/PrivateFrameworks/PerformanceAnalysis.framework/Versions/A/PerformanceAnalysis 0x7fffc1288000 - 0x7fffc12a2fff com.apple.ProtocolBuffer (1 - 249.1) <A1F1B0F3-078F-378F-A9A9-0DEEA70E816A> /System/Library/PrivateFrameworks/ProtocolBuffer.framework/Versions/A/ProtocolBuffer 0x7fffc12a3000 - 0x7fffc12b2ff7 com.apple.QuickLookThumbnailing (1.0 - 1) <173EE873-1700-3FCA-9782-C060FBB5BCAD> /System/Library/PrivateFrameworks/QuickLookThumbnailing.framework/Versions/A/QuickLookThumbnailing 0x7fffc12bb000 - 0x7fffc12deff3 com.apple.RemoteViewServices (2.0 - 124) <6B967FDA-6591-302C-BA0A-76C4856E584E> /System/Library/PrivateFrameworks/RemoteViewServices.framework/Versions/A/RemoteViewServices 0x7fffc1fa8000 - 0x7fffc1fabfff com.apple.SecCodeWrapper (4.0 - 307.50.21) <F8E957B2-D3F0-3B73-B38C-AE8868F00939> /System/Library/PrivateFrameworks/SecCodeWrapper.framework/Versions/A/SecCodeWrapper 0x7fffc203a000 - 0x7fffc20c7fff com.apple.Sharing (696.2.67 - 696.2.67) <F681EE28-153F-3216-97A6-6F5E4148AB2E> /System/Library/PrivateFrameworks/Sharing.framework/Versions/A/Sharing 0x7fffc20e8000 - 0x7fffc234efeb com.apple.SkyLight (1.600.0 - 170.3) <38AC05EF-3A9E-3E3E-9849-04E0223DF7B9> /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/SkyLight 0x7fffc252d000 - 0x7fffc2539ff7 com.apple.SpeechRecognitionCore (3.3.2 - 3.3.2) <684BD1EA-8268-331C-A5A9-080EB375C658> /System/Library/PrivateFrameworks/SpeechRecognitionCore.framework/Versions/A/SpeechRecognitionCore 0x7fffc2c25000 - 0x7fffc2c99fdf com.apple.Symbolication (62048.1) <1A30ED19-7532-3F46-9DD3-9879A973D0CF> /System/Library/PrivateFrameworks/Symbolication.framework/Versions/A/Symbolication 0x7fffc30d8000 - 0x7fffc30deff7 com.apple.TCC (1.0 - 1) <911B534B-4AC7-34E4-935E-E42ECD008CBC> /System/Library/PrivateFrameworks/TCC.framework/Versions/A/TCC 0x7fffc316a000 - 0x7fffc3230ff7 com.apple.TextureIO (2.8 - 2.8) <3D61E533-4156-3B21-B7ED-CB823E680DFC> /System/Library/PrivateFrameworks/TextureIO.framework/Versions/A/TextureIO 0x7fffc32a6000 - 0x7fffc3436ff3 com.apple.UIFoundation (1.0 - 490.7) <2A3063FE-1790-3510-8A0E-AEC581D42B7E> /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation 0x7fffc3f05000 - 0x7fffc3fc5fff com.apple.ViewBridge (283 - 283) <25A635B3-C87C-3D3A-ADF3-539713FA1048> /System/Library/PrivateFrameworks/ViewBridge.framework/Versions/A/ViewBridge 0x7fffc4410000 - 0x7fffc4416fff com.apple.XPCService (2.0 - 1) <4B28B225-2105-33F4-9ED0-F04288FF4FB1> /System/Library/PrivateFrameworks/XPCService.framework/Versions/A/XPCService 0x7fffc44e7000 - 0x7fffc44e9ffb com.apple.loginsupport (1.0 - 1) <F3140B97-12C3-35A7-9D3D-43DA2D13C113> /System/Library/PrivateFrameworks/login.framework/Versions/A/Frameworks/loginsupport.framework/Versions/A/loginsupport 0x7fffc453e000 - 0x7fffc4559ff7 libCRFSuite.dylib (34) <F78B7F5F-0B4F-35C6-AA2F-84EE9CB22137> /usr/lib/libCRFSuite.dylib 0x7fffc455a000 - 0x7fffc4565fff libChineseTokenizer.dylib (21) <0886E908-A825-36AF-B94B-2361FD8BC2A1> /usr/lib/libChineseTokenizer.dylib 0x7fffc45f7000 - 0x7fffc45f8ff3 libDiagnosticMessagesClient.dylib (102) <84A04D24-0E60-3810-A8C0-90A65E2DF61A> /usr/lib/libDiagnosticMessagesClient.dylib 0x7fffc45f9000 - 0x7fffc480cfff libFosl_dynamic.dylib (16.39) <E22A4243-D148-3C74-BA15-2D906A3D1F9E> /usr/lib/libFosl_dynamic.dylib 0x7fffc4828000 - 0x7fffc482ffff libMatch.1.dylib (27) <70D4BD2A-9383-37F2-B0D6-9B592D236601> /usr/lib/libMatch.1.dylib 0x7fffc4830000 - 0x7fffc4830fff libOpenScriptingUtil.dylib (172.1) <0F1BA407-97D1-36F6-882D-A355EAAD5E00> /usr/lib/libOpenScriptingUtil.dylib 0x7fffc4831000 - 0x7fffc4835ffb libScreenReader.dylib (477.40.6) <CBE6420C-EF60-3ACD-A0B6-7CBE936BA3B8> /usr/lib/libScreenReader.dylib 0x7fffc4836000 - 0x7fffc4837ffb libSystem.B.dylib (1238.60.2) <03D8D904-05E2-3A15-B14E-3472703550DC> /usr/lib/libSystem.B.dylib 0x7fffc48a3000 - 0x7fffc48ceff3 libarchive.2.dylib (41.70.2) <907D1FB1-9A65-33F5-AFC8-0B6E5AE9D83A> /usr/lib/libarchive.2.dylib 0x7fffc48cf000 - 0x7fffc494bfc7 libate.dylib (1.12.13) <D0767875-D02E-3377-84D8-5F174C27BEA9> /usr/lib/libate.dylib 0x7fffc494f000 - 0x7fffc494fff3 libauto.dylib (187) <34388D0B-C539-3C1B-9408-2BC152162E43> /usr/lib/libauto.dylib 0x7fffc4950000 - 0x7fffc4960ff3 libbsm.0.dylib (34) <20084796-B04D-3B35-A003-EA11459557A9> /usr/lib/libbsm.0.dylib 0x7fffc4961000 - 0x7fffc496fff7 libbz2.1.0.dylib (38) <ADFA329A-DCE7-356D-8F09-A3168DFC6610> /usr/lib/libbz2.1.0.dylib 0x7fffc4970000 - 0x7fffc49c6ff7 libc++.1.dylib (307.5) <0B43BB5D-E6EB-3464-8DE9-B41AC8ED9D1C> /usr/lib/libc++.1.dylib 0x7fffc49c7000 - 0x7fffc49f0ff7 libc++abi.dylib (307.4) <BC271AD3-831B-362A-9DA7-E8C51F285FE4> /usr/lib/libc++abi.dylib 0x7fffc49f1000 - 0x7fffc4a01ffb libcmph.dylib (6) <2B5D405E-2D0B-3320-ABD6-622934C86ABE> /usr/lib/libcmph.dylib 0x7fffc4a02000 - 0x7fffc4a18fcf libcompression.dylib (39) <F2726F95-F54E-3B21-BCB5-F7151DEFDC2F> /usr/lib/libcompression.dylib 0x7fffc4a19000 - 0x7fffc4a19ff7 libcoretls.dylib (121.50.4) <64B1001E-10F6-3542-A3B2-C4B49F51817F> /usr/lib/libcoretls.dylib 0x7fffc4a1a000 - 0x7fffc4a1bff3 libcoretls_cfhelpers.dylib (121.50.4) <1A10303E-5EB0-3C7C-9165-021FCDFD934D> /usr/lib/libcoretls_cfhelpers.dylib 0x7fffc4d57000 - 0x7fffc4daaff7 libcups.2.dylib (450) <9950BFCB-7882-33C9-9ECF-CE66773C5657> /usr/lib/libcups.2.dylib 0x7fffc4dfe000 - 0x7fffc4e05ff3 libdscsym.dylib (148.3) <2A78774F-6679-3B72-9903-B295B9825872> /usr/lib/libdscsym.dylib 0x7fffc4e27000 - 0x7fffc4e27fff libenergytrace.dylib (15) <A1B040A2-7977-3097-9ADF-34FF181EB970> /usr/lib/libenergytrace.dylib 0x7fffc4e37000 - 0x7fffc4e3cff7 libheimdal-asn1.dylib (498.50.9) <92C953A2-5E1D-39E9-875E-92F29A12D6FB> /usr/lib/libheimdal-asn1.dylib 0x7fffc4e3d000 - 0x7fffc4f2fff7 libiconv.2.dylib (50) <42125B35-81D7-3FC4-9475-A26DBE10884D> /usr/lib/libiconv.2.dylib 0x7fffc4f30000 - 0x7fffc5155ffb libicucore.A.dylib (57167.0.1) <E720801C-2D92-3108-B853-469551EDF21F> /usr/lib/libicucore.A.dylib 0x7fffc515b000 - 0x7fffc515cfff liblangid.dylib (126) <2085E7A7-9A34-3735-87F4-F174EF8EABF0> /usr/lib/liblangid.dylib 0x7fffc515d000 - 0x7fffc5176ffb liblzma.5.dylib (10) <44BD0279-99DD-36B5-8A6E-C11432E2098D> /usr/lib/liblzma.5.dylib 0x7fffc5177000 - 0x7fffc518dff7 libmarisa.dylib (5) <9030D214-5D0F-30CB-AC03-902C63909362> /usr/lib/libmarisa.dylib 0x7fffc518e000 - 0x7fffc5436ff7 libmecabra.dylib (744.8) <D429FCC9-42A4-38B3-8784-44024BC859EF> /usr/lib/libmecabra.dylib 0x7fffc5469000 - 0x7fffc54e3ff3 libnetwork.dylib (856.60.1) <191E99F5-4723-3180-8013-02AF2F9AE4B8> /usr/lib/libnetwork.dylib 0x7fffc54e4000 - 0x7fffc58b6047 libobjc.A.dylib (709.1) <70614861-0340-32E2-85ED-FE65759CDFFA> /usr/lib/libobjc.A.dylib 0x7fffc58b9000 - 0x7fffc58bdfff libpam.2.dylib (21.30.1) <71EB0D88-DE84-3C8D-A2C5-58AA282BC5BC> /usr/lib/libpam.2.dylib 0x7fffc58be000 - 0x7fffc58effff libpcap.A.dylib (67.60.2) <B2D36AD8-D5C8-3875-AC81-4787A15E44C2> /usr/lib/libpcap.A.dylib 0x7fffc590c000 - 0x7fffc5928ffb libresolv.9.dylib (64) <A244AE4C-00B0-396C-98FF-97FE4DB3DA30> /usr/lib/libresolv.9.dylib 0x7fffc5929000 - 0x7fffc5962fff libsandbox.1.dylib (592.70.2) <1A879867-1FB4-382F-8139-CCF034D835E9> /usr/lib/libsandbox.1.dylib 0x7fffc5976000 - 0x7fffc5977ff3 libspindump.dylib (231.3) <9E50A114-FC58-3E22-9027-5002B60005BE> /usr/lib/libspindump.dylib 0x7fffc5978000 - 0x7fffc5ac6ff7 libsqlite3.dylib (254.8) <1ECF7DF7-7A07-3B4B-A63B-F4EFF6BC7ACF> /usr/lib/libsqlite3.dylib 0x7fffc5bbb000 - 0x7fffc5bc8fff libxar.1.dylib (357) <69547C64-E811-326F-BBED-490C6361BDCB> /usr/lib/libxar.1.dylib 0x7fffc5bc9000 - 0x7fffc5cb8ff3 libxml2.2.dylib (30.18) <75135C3D-47B1-3217-AC2B-B566E2E1A4A3> /usr/lib/libxml2.2.dylib 0x7fffc5cb9000 - 0x7fffc5ce2fff libxslt.1.dylib (15.9.1) <A1EFC225-2115-3710-A2FD-B11FDE15B01F> /usr/lib/libxslt.1.dylib 0x7fffc5ce3000 - 0x7fffc5cf4ff3 libz.1.dylib (67) <46E3FFA2-4328-327A-8D34-A03E20BFFB8E> /usr/lib/libz.1.dylib 0x7fffc5d03000 - 0x7fffc5d07ff7 libcache.dylib (79) <093A4DAB-8385-3D47-A350-E20CB7CCF7BF> /usr/lib/system/libcache.dylib 0x7fffc5d08000 - 0x7fffc5d12fff libcommonCrypto.dylib (60092.50.5) <8A64D1B0-C70E-385C-92F0-E669079FDA90> /usr/lib/system/libcommonCrypto.dylib 0x7fffc5d13000 - 0x7fffc5d1afff libcompiler_rt.dylib (62) <55D47421-772A-32AB-B529-1A46C2F43B4D> /usr/lib/system/libcompiler_rt.dylib 0x7fffc5d1b000 - 0x7fffc5d23fff libcopyfile.dylib (138) <819BEA3C-DF11-3E3D-A1A1-5A51C5BF1961> /usr/lib/system/libcopyfile.dylib 0x7fffc5d24000 - 0x7fffc5da7fdf libcorecrypto.dylib (442.50.19) <65D7165E-2E71-335D-A2D6-33F78E2DF0C1> /usr/lib/system/libcorecrypto.dylib 0x7fffc5da8000 - 0x7fffc5dd9fff libdispatch.dylib (703.50.37) <6582BAD6-ED27-3B30-B620-90B1C5A4AE3C> /usr/lib/system/libdispatch.dylib 0x7fffc5dda000 - 0x7fffc5ddfffb libdyld.dylib (433.5) <990CF9D7-4AD1-310D-A4B4-010F6D84FFD8> /usr/lib/system/libdyld.dylib 0x7fffc5de0000 - 0x7fffc5de0ffb libkeymgr.dylib (28) <7AA011A9-DC21-3488-BF73-3B5B14D1FDD6> /usr/lib/system/libkeymgr.dylib 0x7fffc5de1000 - 0x7fffc5dedfff libkxld.dylib (3789.72.11) <FB155780-34ED-3EC4-A478-764061D1EC32> /usr/lib/system/libkxld.dylib 0x7fffc5dee000 - 0x7fffc5deefff liblaunch.dylib (972.70.1) <B856ABD2-896E-3DE0-B2C8-146A6AF8E2A7> /usr/lib/system/liblaunch.dylib 0x7fffc5def000 - 0x7fffc5df4ff3 libmacho.dylib (898) <17D5D855-F6C3-3B04-B680-E9BF02EF8AED> /usr/lib/system/libmacho.dylib 0x7fffc5df5000 - 0x7fffc5df7ff3 libquarantine.dylib (85.50.1) <12448CC2-378E-35F3-BE33-9DC395A5B970> /usr/lib/system/libquarantine.dylib 0x7fffc5df8000 - 0x7fffc5df9ffb libremovefile.dylib (45) <38D4CB9C-10CD-30D3-8B7B-A515EC75FE85> /usr/lib/system/libremovefile.dylib 0x7fffc5dfa000 - 0x7fffc5e12ff7 libsystem_asl.dylib (349.50.5) <096E4228-3B7C-30A6-8B13-EC909A64499A> /usr/lib/system/libsystem_asl.dylib 0x7fffc5e13000 - 0x7fffc5e13ff7 libsystem_blocks.dylib (67) <10DC5404-73AB-35B3-A277-A8AFECB476EB> /usr/lib/system/libsystem_blocks.dylib 0x7fffc5e14000 - 0x7fffc5ea1fef libsystem_c.dylib (1158.50.2) <E5AE5244-7D0C-36AC-8BB6-C7AE7EA52A4B> /usr/lib/system/libsystem_c.dylib 0x7fffc5ea2000 - 0x7fffc5ea5ffb libsystem_configuration.dylib (888.60.2) <BECC01A2-CA8D-31E6-BCDF-D452965FA976> /usr/lib/system/libsystem_configuration.dylib 0x7fffc5ea6000 - 0x7fffc5ea9fff libsystem_coreservices.dylib (41.4) <7D26DE79-B424-3450-85E1-F7FAB32714AB> /usr/lib/system/libsystem_coreservices.dylib 0x7fffc5eaa000 - 0x7fffc5ec2fff libsystem_coretls.dylib (121.50.4) <EC6FCF07-DCFB-3A03-9CC9-6DD3709974C6> /usr/lib/system/libsystem_coretls.dylib 0x7fffc5ec3000 - 0x7fffc5ec9fff libsystem_dnssd.dylib (765.50.9) <CC960215-0B1B-3822-A13A-3DDE96FA796F> /usr/lib/system/libsystem_dnssd.dylib 0x7fffc5eca000 - 0x7fffc5ef3ff7 libsystem_info.dylib (503.50.4) <611DB84C-BF70-3F92-8702-B9F28A900920> /usr/lib/system/libsystem_info.dylib 0x7fffc5ef4000 - 0x7fffc5f16ff7 libsystem_kernel.dylib (3789.72.11) <EADB8F12-726C-3E26-855B-062924729F42> /usr/lib/system/libsystem_kernel.dylib 0x7fffc5f17000 - 0x7fffc5f5efe7 libsystem_m.dylib (3121.6) <86D499B5-BBDC-3D3B-8A4E-97AE8E6672A4> /usr/lib/system/libsystem_m.dylib 0x7fffc5f5f000 - 0x7fffc5f7dff7 libsystem_malloc.dylib (116.50.8) <A3D15F17-99A6-3367-8C7E-4280E8619C95> /usr/lib/system/libsystem_malloc.dylib 0x7fffc5f7e000 - 0x7fffc5fd7ffb libsystem_network.dylib (856.60.1) <369D0221-56CA-3C3E-9EDE-94B41CAE77B7> /usr/lib/system/libsystem_network.dylib 0x7fffc5fd8000 - 0x7fffc5fe1ff3 libsystem_networkextension.dylib (563.60.2) <B021F2B3-8A75-3633-ABB0-FC012B8E9B0C> /usr/lib/system/libsystem_networkextension.dylib 0x7fffc5fe2000 - 0x7fffc5febff3 libsystem_notify.dylib (165.20.1) <B8160190-A069-3B3A-BDF6-2AA408221FAE> /usr/lib/system/libsystem_notify.dylib 0x7fffc5fec000 - 0x7fffc5ff4fe7 libsystem_platform.dylib (126.50.8) <897462FD-B318-321B-A554-E61982630F7E> /usr/lib/system/libsystem_platform.dylib 0x7fffc5ff5000 - 0x7fffc5fffff7 libsystem_pthread.dylib (218.60.3) <B8FB5E20-3295-39E2-B5EB-B464D1D4B104> /usr/lib/system/libsystem_pthread.dylib 0x7fffc6000000 - 0x7fffc6003ff7 libsystem_sandbox.dylib (592.70.2) <19320A42-2E3B-361B-BBDA-2F5F2E87B100> /usr/lib/system/libsystem_sandbox.dylib 0x7fffc6004000 - 0x7fffc6005ff3 libsystem_secinit.dylib (24.50.4) <F78B847B-3565-3E4B-98A6-F7AD40392E2D> /usr/lib/system/libsystem_secinit.dylib 0x7fffc6006000 - 0x7fffc600dffb libsystem_symptoms.dylib (532.50.47) <3390E07C-C1CE-348F-ADBD-2C5440B45EAA> /usr/lib/system/libsystem_symptoms.dylib 0x7fffc600e000 - 0x7fffc6021ff7 libsystem_trace.dylib (518.70.1) <AC63A7FE-50D9-3A30-96E6-F6B7FF16E465> /usr/lib/system/libsystem_trace.dylib 0x7fffc6022000 - 0x7fffc6027ffb libunwind.dylib (35.3) <3D50D8A8-C460-334D-A519-2DA841102C6B> /usr/lib/system/libunwind.dylib 0x7fffc6028000 - 0x7fffc6051ff7 libxpc.dylib (972.70.1) <BF896DF0-D8E9-31A8-A4B3-01120BFEEE52> /usr/lib/system/libxpc.dylib External Modification Summary: Calls made by other processes targeting this process: task_for_pid: 0 thread_create: 0 thread_set_state: 0 Calls made by this process: task_for_pid: 0 thread_create: 0 thread_set_state: 0 Calls made by all processes on this machine: task_for_pid: 1014573 thread_create: 0 thread_set_state: 0 VM Region Summary: ReadOnly portion of Libraries: Total=372.1M resident=0K(0%) swapped_out_or_unallocated=372.1M(100%) Writable regions: Total=304.9M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=304.9M(100%) VIRTUAL REGION REGION TYPE SIZE COUNT (non-coalesced) =========== ======= ======= Activity Tracing 256K 2 CoreUI image file 164K 3 Dispatch continuations 8192K 2 Kernel Alloc Once 8K 2 MALLOC 38.8M 18 MALLOC guard page 32K 7 Memory Tag 242 12K 2 Memory Tag 255 545.2M 98 STACK GUARD 56.1M 32 Stack 203.8M 32 VM_ALLOCATE 76K 8 __DATA 30.9M 262 __IMAGE 528K 2 __LINKEDIT 119.5M 19 __TEXT 252.6M 259 __UNICODE 556K 2 mapped file 58.5M 11 shared memory 16.3M 12 =========== ======= ======= TOTAL 1.3G 755 Model: MacBookAir6,1, BootROM MBA61.0103.B00, 2 processors, Intel Core i5, 1.4 GHz, 4 GB, SMC 2.12f143 Graphics: Intel HD Graphics 5000, Intel HD Graphics 5000, Built-In Memory Module: BANK 0/DIMM0, 2 GB, DDR3, 1600 MHz, 0x80AD, 0x483943434E4E4E384A544D4C41522D4E544D Memory Module: BANK 1/DIMM0, 2 GB, DDR3, 1600 MHz, 0x80AD, 0x483943434E4E4E384A544D4C41522D4E544D AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x117), Broadcom BCM43xx 1.0 (7.21.171.133.1a2) Bluetooth: Version 5.0.5f1, 3 services, 27 devices, 1 incoming serial ports Network Service: Wi-Fi, AirPort, en0 Serial ATA Device: APPLE SSD SD0128F, 121.33 GB USB Device: USB 3.0 Bus USB Device: BRCM20702 Hub USB Device: Bluetooth USB Host Controller USB Device: Natural® Ergonomic Keyboard 4000 USB Device: USB Receiver Thunderbolt Bus: MacBook Air, Apple Inc., 23.6 </details>
https://github.com/electron/electron/issues/12029
https://github.com/electron/electron/pull/12044
fdd66bd76d38898da4fe7f335305b5848ccb805d
53229e3d6c544c68137497ed09a074250c1af0fc
2018-02-23T18:35:15Z
c++
2018-02-26T14:23:59Z
closed
electron/electron
https://github.com/electron/electron
12,025
["lib/browser/api/menu.js"]
Regression: Invisible menu items no longer work via their accelerator keys
With Electron `1.8`, it was possible to create an *invisible* menu item in the application menu and, assuming it was still enabled, it could be invoked via its accelerator key. This provided a mechanism for creating application-wide shortcut keys that were independent from content. For example, this menu-item template worked just fine: { visible: false, accelerator: "F12", click: () => { mainWindow.webContents.openDevTools({ mode: "detach" }); } }, Since upgrading to `Electron2.0.0-beta.1`, this no longer works. Instead, I have to make the menu item visible and give it a name in order for it to be triggered by its accelerator key: { visible: true, label: "Developer Tools", accelerator: "F12", click: () => { mainWindow.webContents.openDevTools({ mode: "detach" }); } }, Is this just a regression or is this by design? If it is by design, is there any way to achieve window-level shortcut keys without resorting to nasty `keydown` and `keyup` handlers on the content level?
https://github.com/electron/electron/issues/12025
https://github.com/electron/electron/pull/12825
b280ea5579887d44b3155025ebc64ac050e04978
f67c625e6acd6548826e3da537bfd6658adf85cf
2018-02-23T14:24:14Z
c++
2018-05-04T14:59:40Z
closed
electron/electron
https://github.com/electron/electron
12,002
["lib/browser/api/app.js", "spec/api-app-spec.js"]
Menu crash in 2.0.0-beta1
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 2.0.0-beta1 * Operating system: macOS 10.12.6 ### Expected behavior Should work without crashing. <!-- What do you think should happen? --> ### Actual behavior I don't have a consistent way to reproduce this yet, but since upgrading to 2.0.0 from 1.8.2, our app is crashing constantly whenever I try to use the menu items. Crash report: ``` Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000068 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [0] VM Regions Near 0x68: --> __TEXT 0000000103f57000-0000000103f58000 [ 4K] r-x/rwx SM=COW /Users/USER/Documents/*/Min.app/Contents/MacOS/Min Application Specific Information: Validating menu item 'New Tab' with action @selector(itemSelected:) Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread 0 com.github.electron.framework 0x0000000105ad6af4 0x1059f1000 + 940788 1 com.apple.AppKit 0x00007fffd21c05ff -[NSMenu _enableItem:] + 869 2 com.apple.AppKit 0x00007fffd21c023b -[NSMenu _enableItems] + 240 3 com.apple.AppKit 0x00007fffd21bfe8a -[NSApplication _flattenMenu:flatList:] + 68 4 com.apple.AppKit 0x00007fffd21bf646 -[NSApplication _createDockMenu:] + 364 5 com.apple.AppKit 0x00007fffd21bf4ae __44-[NSApplication _copyPublicPersistentUIInfo]_block_invoke + 42 6 com.apple.CoreFoundation 0x00007fffd455a17c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12 7 com.apple.CoreFoundation 0x00007fffd453af84 __CFRunLoopDoBlocks + 356 8 com.apple.CoreFoundation 0x00007fffd453aac6 __CFRunLoopRun + 1878 9 com.apple.CoreFoundation 0x00007fffd453a114 CFRunLoopRunSpecific + 420 10 com.apple.HIToolbox 0x00007fffd3a9aebc RunCurrentEventLoopInMode + 240 11 com.apple.HIToolbox 0x00007fffd3a9acf1 ReceiveNextEventCommon + 432 12 com.apple.HIToolbox 0x00007fffd3a9ab26 _BlockUntilNextEventMatchingListInModeWithFilter + 71 13 com.apple.AppKit 0x00007fffd2031a54 _DPSNextEvent + 1120 14 com.apple.AppKit 0x00007fffd27ad7ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 15 com.apple.AppKit 0x00007fffd20263db -[NSApplication run] + 926 16 com.github.electron.framework 0x0000000105c7f8ce 0x1059f1000 + 2681038 17 com.github.electron.framework 0x0000000105c7e2cc 0x1059f1000 + 2675404 18 com.github.electron.framework 0x0000000105c94823 0x1059f1000 + 2766883 19 com.github.electron.framework 0x0000000105ef6d6f 0x1059f1000 + 5266799 20 com.github.electron.framework 0x0000000105ef6b90 0x1059f1000 + 5266320 21 com.github.electron.framework 0x0000000105ef9212 0x1059f1000 + 5276178 22 com.github.electron.framework 0x0000000105ef2bec 0x1059f1000 + 5250028 23 com.github.electron.framework 0x0000000105e45d00 0x1059f1000 + 4541696 24 com.github.electron.framework 0x0000000107a2efe4 0x1059f1000 + 33808356 25 com.github.electron.framework 0x0000000105e44b14 0x1059f1000 + 4537108 26 com.github.electron.framework 0x00000001059f3404 AtomMain + 68 27 com.electron.min 0x0000000103f57f26 main + 38 28 libdyld.dylib 0x00007fffe9cc1235 start + 1 Thread 1: 0 libsystem_kernel.dylib 0x00007fffe9df044e __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffe9eda48e _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffe9eda07d start_wqthread + 13 Thread 2:: Dispatch queue: NSPersistentUI Work 0 com.apple.CoreFoundation 0x00007fffd44c1bc0 -[__NSDictionaryI getObjects:andKeys:count:] + 208 1 com.apple.CoreFoundation 0x00007fffd4547837 -[__NSDictionaryI mutableCopyWithZone:] + 231 2 com.apple.AppKit 0x00007fffd21bfaee -[NSPersistentUIWindowInfo copyAllPublicProperties] + 38 3 com.apple.AppKit 0x00007fffd21bf847 -[NSPersistentUIManager writePublicPlistWithOpenWindowIDs:optionallyWaitingUntilDone:] + 334 4 com.apple.AppKit 0x00007fffd2a7e7b8 __85-[NSPersistentUIManager flushAllChangesOptionallyWaitingUntilDone:updatingSnapshots:]_block_invoke.337 + 2047 5 com.apple.AppKit 0x00007fffd2a82db4 ___NSPersistentUIDispatchQueueAsync_block_invoke + 31 6 libdispatch.dylib 0x00007fffe9c94524 _dispatch_call_block_and_release + 12 7 libdispatch.dylib 0x00007fffe9c8b8fc _dispatch_client_callout + 8 8 libdispatch.dylib 0x00007fffe9ca19a0 _dispatch_queue_serial_drain + 896 9 libdispatch.dylib 0x00007fffe9c94306 _dispatch_queue_invoke + 1046 10 libdispatch.dylib 0x00007fffe9c8d6b5 _dispatch_root_queue_drain + 476 11 libdispatch.dylib 0x00007fffe9c8d48c _dispatch_worker_thread3 + 99 12 libsystem_pthread.dylib 0x00007fffe9eda5a2 _pthread_wqthread + 1299 13 libsystem_pthread.dylib 0x00007fffe9eda07d start_wqthread + 13 Thread 3: 0 libsystem_kernel.dylib 0x00007fffe9defbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffe9edb7fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010424c179 uv_cond_wait + 9 3 libnode.dylib 0x00000001041c7259 0x104092000 + 1266265 4 libnode.dylib 0x00000001041c724c 0x104092000 + 1266252 5 libnode.dylib 0x00000001041c7194 0x104092000 + 1266068 6 libnode.dylib 0x00000001041c6ac2 0x104092000 + 1264322 7 libsystem_pthread.dylib 0x00007fffe9eda93b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffe9eda887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffe9eda08d thread_start + 13 Thread 4: 0 libsystem_kernel.dylib 0x00007fffe9defbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffe9edb7fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010424c179 uv_cond_wait + 9 3 libnode.dylib 0x00000001041c7259 0x104092000 + 1266265 4 libnode.dylib 0x00000001041c724c 0x104092000 + 1266252 5 libnode.dylib 0x00000001041c7194 0x104092000 + 1266068 6 libnode.dylib 0x00000001041c6ac2 0x104092000 + 1264322 7 libsystem_pthread.dylib 0x00007fffe9eda93b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffe9eda887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffe9eda08d thread_start + 13 Thread 5: 0 libsystem_kernel.dylib 0x00007fffe9defbf2 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffe9edb7fa _pthread_cond_wait + 712 2 libnode.dylib 0x000000010424c179 uv_cond_wait + 9 3 libnode.dylib 0x00000001041c7259 0x104092000 + 1266265 4 libnode.dylib 0x00000001041c724c 0x104092000 + 1266252 5 libnode.dylib 0x00000001041c7194 0x104092000 + 1266068 6 libnode.dylib 0x00000001041c6ac2 0x104092000 + 1264322 7 libsystem_pthread.dylib 0x00007fffe9eda93b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffe9eda887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffe9eda08d thread_start + 13 Thread 6:: Dispatch queue: NSPersistentUI I/O 0 libobjc.A.dylib 0x00007fffe93d270c objc_class::demangledName(bool) + 46 1 com.apple.Foundation 0x00007fffd5f354b9 -[NSURL(NSURL) _cfurl] + 23 2 com.apple.Foundation 0x00007fffd5f41008 -[NSURL(NSURL) isFileURL] + 27 3 com.apple.Foundation 0x00007fffd5f45b1e -[NSURL(NSURLPathUtilities) URLByAppendingPathComponent:] + 128 4 com.apple.AppKit 0x00007fffd2228cc7 -[NSPersistentUIManager openPersistentStateFile] + 87 5 com.apple.AppKit 0x00007fffd2228b64 -[NSPersistentUIManager writeRecords:withWindowInfos:flushingStaleData:] + 94 6 com.apple.AppKit 0x00007fffd2a7e84c __85-[NSPersistentUIManager flushAllChangesOptionallyWaitingUntilDone:updatingSnapshots:]_block_invoke_2.354 + 85 7 com.apple.AppKit 0x00007fffd2a82db4 ___NSPersistentUIDispatchQueueAsync_block_invoke + 31 8 libdispatch.dylib 0x00007fffe9c94524 _dispatch_call_block_and_release + 12 9 libdispatch.dylib 0x00007fffe9c8b8fc _dispatch_client_callout + 8 10 libdispatch.dylib 0x00007fffe9ca19a0 _dispatch_queue_serial_drain + 896 11 libdispatch.dylib 0x00007fffe9c94306 _dispatch_queue_invoke + 1046 12 libdispatch.dylib 0x00007fffe9c8d6b5 _dispatch_root_queue_drain + 476 13 libdispatch.dylib 0x00007fffe9c8d48c _dispatch_worker_thread3 + 99 14 libsystem_pthread.dylib 0x00007fffe9eda5a2 _pthread_wqthread + 1299 15 libsystem_pthread.dylib 0x00007fffe9eda07d start_wqthread + 13 Thread 7: 0 libsystem_kernel.dylib 0x00007fffe9df044e __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffe9eda48e _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffe9eda07d start_wqthread + 13 Thread 8:: NetworkConfigWatcher 0 libsystem_kernel.dylib 0x00007fffe9de834a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffe9de7797 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fffd453b434 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fffd453a8c1 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fffd453a114 CFRunLoopRunSpecific + 420 5 com.apple.Foundation 0x00007fffd5f4d252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 6 com.github.electron.framework 0x0000000105c7f71e 0x1059f1000 + 2680606 7 com.github.electron.framework 0x0000000105c7e2cc 0x1059f1000 + 2675404 8 com.github.electron.framework 0x0000000105c94823 0x1059f1000 + 2766883 9 com.github.electron.framework 0x0000000105cb89f9 0x1059f1000 + 2914809 10 com.github.electron.framework 0x0000000105c893b7 0x1059f1000 + 2720695 11 libsystem_pthread.dylib 0x00007fffe9eda93b _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffe9eda887 _pthread_start + 286 13 libsystem_pthread.dylib 0x00007fffe9eda08d thread_start + 13 Thread 9:: DnsConfigService 0 libsystem_kernel.dylib 0x00007fffe9df0d96 kevent + 10 1 com.github.electron.framework 0x0000000105ce6169 0x1059f1000 + 3101033 2 com.github.electron.framework 0x0000000105ce52fd 0x1059f1000 + 3097341 3 com.github.electron.framework 0x0000000105c7e12f 0x1059f1000 + 2674991 4 com.github.electron.framework 0x0000000105c94823 0x1059f1000 + 2766883 5 com.github.electron.framework 0x0000000105cb89f9 0x1059f1000 + 2914809 6 com.github.electron.framework 0x0000000105c893b7 0x1059f1000 + 2720695 7 libsystem_pthread.dylib 0x00007fffe9eda93b _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffe9eda887 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffe9eda08d thread_start + 13 Thread 10:: CrShutdownDetector 0 libsystem_kernel.dylib 0x00007fffe9df1246 read + 10 1 com.github.electron.framework 0x0000000105a981af 0x1059f1000 + 684463 2 com.github.electron.framework 0x0000000105c893b7 0x1059f1000 + 2720695 3 libsystem_pthread.dylib 0x00007fffe9eda93b _pthread_body + 180 4 libsystem_pthread.dylib 0x00007fffe9eda887 _pthread_start + 286 5 libsystem_pthread.dylib 0x00007fffe9eda08d thread_start + 13 ``` (I've only included the first part of the crash report, I can include the rest if necessary). The code for the menu item in question is this: ``` { label: "New Tab", accelerator: 'CmdOrCtrl+t', click: function (item, window) { sendIPCToWindow(window, 'addTab') } } ``` Where ```sendIPCToWindow``` looks like this: ``` function sendIPCToWindow (window, action, data) { // if there are no windows, create a new one if (!mainWindow) { createWindow(function () { mainWindow.webContents.send(action, data || {}) }) } else { mainWindow.webContents.send(action, data || {}) } } ``` I'll try to see if I can create a reduced testcase for this. Let me know if there is any other information I can provide!
https://github.com/electron/electron/issues/12002
https://github.com/electron/electron/pull/12062
53229e3d6c544c68137497ed09a074250c1af0fc
35cbe9d14078a0a6676fd66d5099606bb7e6112a
2018-02-21T23:42:36Z
c++
2018-02-27T06:15:06Z
closed
electron/electron
https://github.com/electron/electron
11,990
["BUILD.gn", "lib/browser/init.ts", "patches/node/.patches", "patches/node/call_process_log_from_fallback_stream_on_windows.patch", "shell/app/node_main.cc", "shell/common/api/electron_bindings.cc", "shell/common/api/electron_bindings.h", "spec-main/node-spec.ts", "spec/fixtures/module/run-as-node.js", "spec/node-spec.js"]
console.log does not log to the dev tools console window
* Electron version: debug version built from master (7e2f7602c1d3f383bb859f4af96e74e683a49d8e) * Operating system: win7 sp1 x64 ### Expected behavior `node --inspect-brk -e console.log('hello')` logs to stdout and the dev tools console so one expects electron to do the same ### Actual behavior electron with attached dev tools only logs to stdout ### How to reproduce `console_log.js` with `console.log('hello');` `electron.exe --inspect-brk console_log.js`
https://github.com/electron/electron/issues/11990
https://github.com/electron/electron/pull/25765
9717dff4fa89fa1aab9fcad1f040becc37033beb
57dc170e8122be8646c48e0c22d448b9afa188ad
2018-02-20T21:47:20Z
c++
2020-10-05T17:10:38Z
closed
electron/electron
https://github.com/electron/electron
11,939
["vendor/native_mate"]
Test failures with FATAL:wrappable.cc(27)] Check failed: !wrapper_.IsEmpty().
This appears to be a timing issue, as the symptom is that it happens only during some CI runs, causing them to fail. Here is a sample log from a failed `electron-osx-x64` run: ```text ok 979 <webview> tag nativeWindowOpen option opens window of about:blank with cross-scripting enabled ok 980 <webview> tag nativeWindowOpen option opens window of same domain with cross-scripting enabled ok 981 <webview> tag nativeWindowOpen option returns null from window.open when allowpopups is not set [17317:0216/104904.669474:FATAL:wrappable.cc(27)] Check failed: !wrapper_.IsEmpty(). 0 libbase.dylib 0x000000011199360e base::debug::StackTrace::StackTrace(unsigned long) + 174 1 libbase.dylib 0x00000001119936dd base::debug::StackTrace::StackTrace(unsigned long) + 29 2 libbase.dylib 0x000000011199197c base::debug::StackTrace::StackTrace() + 28 3 libbase.dylib 0x0000000111a304af logging::LogMessage::~LogMessage() + 479 4 libbase.dylib 0x0000000111a2de25 logging::LogMessage::~LogMessage() + 21 5 Electron Framework 0x000000010dc0b22f mate::WrappableBase::GetWrapper() + 175 6 Electron Framework 0x000000010d8717f5 mate::EventEmitter<atom::api::WebContents>::GetWrapper() + 21 7 Electron Framework 0x000000010d87ac02 bool mate::EventEmitter<atom::api::WebContents>::EmitWithSender<int>(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&, content::WebContents*, IPC::Message*, int const&) + 98 8 Electron Framework 0x000000010d860a2c bool mate::EventEmitter<atom::api::WebContents>::Emit<int>(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&, int const&) + 44 9 Electron Framework 0x000000010d8609ef atom::api::WebContents::RenderViewDeleted(content::RenderViewHost*) + 95 10 Electron Framework 0x000000010d85de13 atom::api::WebContents::~WebContents() + 307 11 Electron Framework 0x000000010d85e225 atom::api::WebContents::~WebContents() + 21 12 Electron Framework 0x000000010d85e309 atom::api::WebContents::~WebContents() + 25 13 Electron Framework 0x000000010dc0b808 mate::WrappableBase::SecondWeakCallback(v8::WeakCallbackInfo<mate::WrappableBase> const&) + 56 14 libv8.dylib 0x000000011108594c v8::internal::FlagList::Hash() + 91916 15 libv8.dylib 0x00000001110864a3 v8::internal::FlagList::Hash() + 94819 16 libv8.dylib 0x000000011108653f v8::internal::FlagList::Hash() + 94975 17 libv8.dylib 0x000000011109c8ea v8::internal::Heap::CreateFillerObjectAt(unsigned char*, int, v8::internal::ClearRecordedSlots) + 3146 18 libv8.dylib 0x000000011109b584 v8::internal::GCTracer::NotifyIncrementalMarkingStart() + 30196 19 libv8.dylib 0x000000011109ba1b v8::internal::GCTracer::NotifyIncrementalMarkingStart() + 31371 20 libv8.dylib 0x0000000110c6797a v8::Isolate::LowMemoryNotification() + 314 21 Electron Framework 0x000000010d8fde4d void base::internal::FunctorTraits<void (v8::Isolate::*)(), void>::Invoke<v8::Isolate*>(void (v8::Isolate::*)(), v8::Isolate*&&) + 125 22 Electron Framework 0x000000010d8fdd94 void base::internal::InvokeHelper<false, void>::MakeItSo<void (v8::Isolate::* const&)(), v8::Isolate*>(void (v8::Isolate::* const&&&)(), v8::Isolate*&&) + 68 23 Electron Framework 0x000000010d8fdd45 void base::internal::Invoker<base::internal::BindState<void (v8::Isolate::*)(), base::internal::UnretainedWrapper<v8::Isolate> >, void ()>::RunImpl<void (v8::Isolate::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<v8::Isolate> > const&, 0ul>(void (v8::Isolate::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<v8::Isolate> > const&&&, base::IndexSequence<0ul>) + 85 24 Electron Framework 0x000000010d8fdc8c base::internal::Invoker<base::internal::BindState<void (v8::Isolate::*)(), base::internal::UnretainedWrapper<v8::Isolate> >, void ()>::Run(base::internal::BindStateBase*) + 44 25 libbase.dylib 0x00000001119279ad base::AtExitManager::RegisterTask(base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>) + 637 26 libbase.dylib 0x0000000111ca4846 base::Timer::RunScheduledTask() + 294 27 libbase.dylib 0x0000000111ca46a9 base::Timer::GetTaskRunner() + 329 28 libbase.dylib 0x0000000111ca4b9d base::Timer::RunScheduledTask() + 1149 29 libbase.dylib 0x0000000111ca4ae4 base::Timer::RunScheduledTask() + 964 30 libbase.dylib 0x0000000111ca4a73 base::Timer::RunScheduledTask() + 851 31 libbase.dylib 0x0000000111ca49b9 base::Timer::RunScheduledTask() + 665 32 libbase.dylib 0x0000000111930d8f base::BarrierClosure(int, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>) + 703 33 libbase.dylib 0x0000000111995bb0 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1040 34 libbase.dylib 0x0000000111a8c26e base::MessageLoop::RunTask(base::PendingTask*) + 894 35 libbase.dylib 0x0000000111a8c7c7 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 71 36 libbase.dylib 0x0000000111a8e072 base::MessageLoop::DoDelayedWork(base::TimeTicks*) + 2178 37 libbase.dylib 0x0000000111a9d92d base::MessagePumpCFRunLoopBase::RunWork() + 157 38 libbase.dylib 0x0000000111a9d87c base::MessagePumpCFRunLoopBase::CanInvalidateCFRunLoopTimers() + 716 39 libbase.dylib 0x0000000111a3886a base::mac::CallWithEHFrame(void () block_pointer) + 10 40 libbase.dylib 0x0000000111a9cd85 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101 41 CoreFoundation 0x00007fffb7f113e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 42 CoreFoundation 0x00007fffb7ef265c __CFRunLoopDoSources0 + 556 43 CoreFoundation 0x00007fffb7ef1b46 __CFRunLoopRun + 934 44 CoreFoundation 0x00007fffb7ef1544 CFRunLoopRunSpecific + 420 45 HIToolbox 0x00007fffb7450ebc RunCurrentEventLoopInMode + 240 46 HIToolbox 0x00007fffb7450cf1 ReceiveNextEventCommon + 432 47 HIToolbox 0x00007fffb7450b26 _BlockUntilNextEventMatchingListInModeWithFilter + 71 48 AppKit 0x00007fffb59e7a54 _DPSNextEvent + 1120 49 AppKit 0x00007fffb61637ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 50 AppKit 0x00007fffb59dc3db -[NSApplication run] + 926 51 libbase.dylib 0x0000000111a9e5bc base::MessagePumpNSRunLoop::Quit() + 604 52 libbase.dylib 0x0000000111a9c56e base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 53 libbase.dylib 0x0000000111a8bb2b base::MessageLoop::Run() + 299 54 libbase.dylib 0x0000000111b80cfe base::RunLoop::Run() + 286 55 libcontent.dylib 0x000000011e5d2fb4 content::BrowserMainLoop::MainMessageLoopRun() + 420 56 libcontent.dylib 0x000000011e5d2cc8 content::BrowserMainLoop::RunMainMessageLoopParts() + 488 57 libcontent.dylib 0x000000011e5dcf7c content::BrowserMainRunner::ExitedMainMessageLoop() + 3676 58 libcontent.dylib 0x000000011e5c67dd content::BrowserMain(content::MainFunctionParams const&) + 397 59 libcontent.dylib 0x0000000120c14c55 content::ContentMain(content::ContentMainParams const&) + 741 60 libcontent.dylib 0x0000000120c1643c content::ContentMainRunner::Create() + 5772 61 libcontent.dylib 0x0000000120c1326d content::CreateInProcessUtilityThread(content::InProcessChildThreadParams const&) + 281085 script returned exit code 251 ```
https://github.com/electron/electron/issues/11939
https://github.com/electron/electron/pull/11944
f3415c04cd1755f31a5d708ed3d39e44ae9415e8
55d4d74624d6546947547c7bd2105907cdb1db93
2018-02-16T19:57:12Z
c++
2018-02-18T14:20:22Z
closed
electron/electron
https://github.com/electron/electron
11,922
["atom/renderer/atom_sandboxed_renderer_client.cc", "spec/api-ipc-renderer-spec.js", "spec/fixtures/module/preload-inject-ipc.js", "spec/fixtures/module/preload-ipc-ping-pong.js", "spec/fixtures/pages/ping-pong.html"]
Some ipc messages are not sent when contextIsolation and sandbox are set to true
* Electron version: 1.8.2 * Operating system: MacOS, Windows10 ### Expected behavior ipc messages from the main process should be sent to the renderer process when both `sandbox` and `contextIsolation` are set. ### Actual behavior ipc messages sent in listeners to webview events are not visible in the renderer process. ### How to reproduce ``` $ git clone https://gist.github.com/4f6c4450cff194838e746ce23e60116d.git $ cd 4f6c4450cff194838e746ce23e60116d/ $ electron main.js ``` The devtools will open and the console will log one message. But the second message on the ipc `ping` channel is not observed. Toggling either `sandbox` or `contextIsolation` to false allows the `ping` to travel to the renderer process. In the 1.7.X branch setting both values to true still allows the message to pass through successfully.
https://github.com/electron/electron/issues/11922
https://github.com/electron/electron/pull/16352
134792a5944492637218d8c34e4803697d1fb894
dcb670fa4648dab2cdc7ff62a3e9a4735009a6de
2018-02-14T15:58:29Z
c++
2019-01-12T13:19:20Z
closed
electron/electron
https://github.com/electron/electron
11,919
["atom/browser/api/atom_api_web_contents.cc"]
Fire `console-message` even when rendering in offscreen
I propose removing the constraint that prevents the `console-message` event from bubbling up when rendering a BrowserWindow in `offscreen` mode. Currently, this line here is the culprit... https://github.com/electron/electron/blob/9bd7d53cf85ac36e81a080c4fd0572ca34d395ff/atom/browser/api/atom_api_web_contents.cc#L484 Is there a technical constraint I'm not aware of preventing this from working? [Cypress](https://github.com/cypress-io/cypress) drives automated tests in Electron and we'd love the ability to capture console messages programmatically like this. We currently run Electron primarily in offscreen mode. I'm aware that it's possible to redirect the internal chromium logger, but it doesn't stringify objects so it's fairly useless. All you primarily see is [object Object].
https://github.com/electron/electron/issues/11919
https://github.com/electron/electron/pull/11921
6f0080be4c6e8be6808e3bb3e25734d1ed66a43e
7e2f7602c1d3f383bb859f4af96e74e683a49d8e
2018-02-14T04:35:45Z
c++
2018-02-14T16:02:18Z
closed
electron/electron
https://github.com/electron/electron
11,869
["docs/api/web-contents.md"]
setZoomLevel doesn't zoom 20%
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.12 * Operating system: Windows and macOS ### Expected behavior <!-- What do you think should happen? --> https://electronjs.org/docs/all#contentssetzoomlevellevel says the following: ![image](https://user-images.githubusercontent.com/12807659/36011350-55addd40-0d0b-11e8-99f7-d73d2f044b65.png) I expect setZoomLevel to increase/decrease zoom 20% with each level increased/decreased in the following manner: Level -3: 40% Level -2: 60% Level -1: 80% **Level 0: 100% (default)** Level 1: 120% Level 2: 140% Level 3: 160% (% increase/decrease with respect to the original level 0) ### Actual behavior <!-- What actually happens? --> Level -3: 57.87% Level -2: 69.4% Level -1: 83.3% Level 0: 100% Level 1: 120% Level 2: 144% Level 3: 172.8% It looks as though zoom increase adds 20% to the immediately preceding zoom level. For example Level 1: 120% = 20% increase from 100% Level 2: 144% = 20% increase from 120%, not 40% increase from 100% Level 3: 172.8% = 20% increase from 144%, not 60% increase from 100% If this was the case, shouldn't I get 140% when the initial zoom level is 0 and setZoomLevel(2) is called? It's still 144%. While these are 20% increases in a different way than I expected, zoom decreases by a different %. Level -1: 83.3% = 16.67% decrease from 100% Level -2: 69.4% = 16.67% decrease from 83.3% Level -3: 57.87% = 16.67% decrease from 69.4% I don't even know why 16.67% instead of 20% for decrease. setZoomFactor, on the other hand, works as I described in the Expected behavior section. ### How to reproduce <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . --> $ git clone https://github.com/fancyydk/electron-quick-start.git -b dokang/bug/zoom-level-factor $ npm install $ npm start || electron . You can play around with this sample app to test different zoom levels and zoom factors. ### Zoom level change **Default** ![image](https://user-images.githubusercontent.com/12807659/36011134-3b6f753e-0d0a-11e8-917d-db8069d7ba87.png) **Zoom level +1** ![image](https://user-images.githubusercontent.com/12807659/36011181-84af2b2c-0d0a-11e8-89c0-33f23888b68c.png) **Zoom level +2** ![image](https://user-images.githubusercontent.com/12807659/36011161-68603e52-0d0a-11e8-81f1-70f673806a56.png) **Zoom level +3** ![image](https://user-images.githubusercontent.com/12807659/36011167-73c8c1d8-0d0a-11e8-98fd-570ab4eb8cac.png) **Zoom level -1** ![image](https://user-images.githubusercontent.com/12807659/36011185-93fc799a-0d0a-11e8-899f-6110be55892a.png) **Zoom level -2** ![image](https://user-images.githubusercontent.com/12807659/36011192-9e597488-0d0a-11e8-8cb0-09392043a2f3.png) **Zoom level -3** ![image](https://user-images.githubusercontent.com/12807659/36011204-a8764162-0d0a-11e8-9f5f-bea32ca8188d.png) ### Zoom factor change **Default** ![image](https://user-images.githubusercontent.com/12807659/36011134-3b6f753e-0d0a-11e8-917d-db8069d7ba87.png) **Zoom factor +0.2** ![image](https://user-images.githubusercontent.com/12807659/36011270-e6008d30-0d0a-11e8-825f-b7e30f30a978.png) **Zoom factor +0.4** ![image](https://user-images.githubusercontent.com/12807659/36011278-f0869614-0d0a-11e8-86b9-1100146441ed.png) **Zoom factor +0.6** ![image](https://user-images.githubusercontent.com/12807659/36011283-fa508466-0d0a-11e8-91b5-bb086daa82fc.png) **Zoom factor -0.2** ![image](https://user-images.githubusercontent.com/12807659/36011306-14bb60c8-0d0b-11e8-9057-7fcfb512d905.png) **Zoom factor -0.4** ![image](https://user-images.githubusercontent.com/12807659/36011309-1d850132-0d0b-11e8-8bf9-aa63c0214a76.png) **Zoom factor -0.6** ![image](https://user-images.githubusercontent.com/12807659/36011323-2c233e16-0d0b-11e8-9574-64e93ca87253.png)
https://github.com/electron/electron/issues/11869
https://github.com/electron/electron/pull/11881
647d04cf923f9f85a76e3ce2e3be3a6b504a7a30
1657c37761a80f44239bd22adce1f3c186f2dfd3
2018-02-09T04:04:01Z
c++
2018-02-10T14:08:59Z
closed
electron/electron
https://github.com/electron/electron
11,858
["atom/browser/api/atom_api_app.cc", "atom/browser/api/atom_api_app.h", "atom/browser/api/atom_api_app_mac.mm", "atom/browser/atom_browser_main_parts.cc", "atom/browser/atom_browser_main_parts.h", "atom/browser/atom_browser_main_parts_mac.mm", "docs/api/app.md", "filenames.gni"]
getPath("logs") use the wrong "userData" path
Hi, getPath("logs") return the wrong path. getPath("logs") return : %APPDATA% + ProductName from the executable of Electron when it should return : "userData" (when edited) + productName from package.json The consequence is that Electron creates an empty folder "logs" in the wrong place. It seems to me that the problem has occurred since this fix : #10911 * Electron version: 1.8.2 (since 1.8.2-beta.2) * Operating system: Windows 7 64 bit
https://github.com/electron/electron/issues/11858
https://github.com/electron/electron/pull/17841
841e31b7e63c9eddabc5f2cf0b89a46dbf545b02
0749dc4cc1bc4bfd4b9aa27ec51d72007d67d699
2018-02-08T01:46:53Z
c++
2019-04-19T05:04:58Z
closed
electron/electron
https://github.com/electron/electron
11,833
["atom/renderer/renderer_client_base.cc"]
Closing OSR devtools in software rendering mode causes OnPaint callback for transparent window to be permanently filled with white background
* Electron version: 1.8.2beta5 * Operating system: Windows 32-bit ### Expected behavior After closing devtools, OSR rendered window should remain transparent. This is the case with 1.7.12 (latest 1.7 version as of this bug report) ### Actual behavior OSR rendered window is filled with white background. ### How to reproduce `electron main.js` (with the following two files stuck somewhere). dev tools will open themselves. OSR onpaint gets the correct transparent window, until devtools is closed, at which point, background becomes permanently white, destroying transparency. main.js: ``` const {app, BrowserWindow} = require('electron') const fs = require('fs'); app.disableHardwareAcceleration() var counter = 0; let win app.once('ready', () => { win = new BrowserWindow({ webPreferences: { offscreen: true, }, show: false, transparent: true, width: 800, height: 600, frame: false, }) win.loadURL(`file://${__dirname}/index.html`); win.webContents.on('paint', (event, dirty, image) => { // updateBitmap(dirty, image.getBitmap()) ++counter; fs.writeFile('bitmap' + counter + '.raw', image.getBitmap(), (err) => { if (err) throw err; console.log('It\'s saved!'); }); }) win.webContents.setFrameRate(30) win.toggleDevTools(); }) ``` index.html: ``` <!DOCTYPE html> <html> <head> <meta charset="UTF-8"> <title>OSR test</title> <style> html, body { background: rgba(0, 0, 0, 0); } </style> </head> <body><font color=#ffffff>testing</font></body> </html> ```
https://github.com/electron/electron/issues/11833
https://github.com/electron/electron/pull/11956
772a69e24ad3f0685870ca613836b05508d195f0
f7ec346e9ff8a5df1ce15d67a7f4010e9d83d906
2018-02-05T22:03:03Z
c++
2018-02-21T10:54:35Z
closed
electron/electron
https://github.com/electron/electron
11,818
["atom/browser/ui/cocoa/atom_menu_controller.mm"]
Popup MenuItem click handlers not being called
* Electron version: Electron built at aea06ed * Operating system: macOS 10.13.2 ### Expected behavior `MenuItem` click handlers should get called in the popped up context menu. ### Actual behavior Click handlers never getting called back. ### How to reproduce Open a popup in the main window: ``` window.webContents.on('context-menu', (event) => { const menu = new Menu() menu.append(new MenuItem({label: 'MenuItem1', click() { console.log('item 1 clicked') }})) menu.append(new MenuItem({type: 'separator'})) menu.append(new MenuItem({label: 'MenuItem2', type: 'checkbox', checked: true})) menu.popup(mainWindow) }) ``` Right click on the running window and select `MenuItem1`, the log `item 1 clicked` should print but doesn't.
https://github.com/electron/electron/issues/11818
https://github.com/electron/electron/pull/13513
67673cbf7ffa378674922f79082d2a42900fd832
6cf68f82471e3611220d19a6d8f4e39f1be2686c
2018-02-02T21:45:17Z
c++
2018-06-29T21:48:26Z
closed
electron/electron
https://github.com/electron/electron
11,790
["lib/browser/guest-window-manager.js"]
Closing a window opened from a browserview does not close
* Electron version: Electron built at aea06ed95f0ae88b33a5853caa76cf921b11a7af * Operating system: macOS 10.13.2 ### How to reproduce 1. Load an app in a browser view 2. Within the browser view call `window.open` with another page (creating a popup) 3. Click the red "x" on the new window to close the popup ### Expected behavior Popup window closes ### Actual behavior Popup window fires a "close" event but is not destroyed This happens because the popup inheirit options from the browser view. In particular `webPreferences.isBrowserView` is true, even though the guest window is not a browser view. This can be fixed in the application by listening for the `new-window` event and removing that option. Repo to reproduce: https://github.com/ibash/browserview-bug ``` Steps: 1. `yarn install` 2. `yarn start` 3. Try to close the popup window with google in it ```
https://github.com/electron/electron/issues/11790
https://github.com/electron/electron/pull/11799
b32a7d4cb464ca5189e81fcccb97423f224ed0fa
1545a95782fde4af3b77d8f5bf743f57c783467d
2018-01-31T18:28:50Z
c++
2018-02-01T19:36:56Z
closed
electron/electron
https://github.com/electron/electron
11,788
["lib/renderer/web-view/web-view.js"]
createShadowRoot is deprecated
FYI, `createShadowRoot`, which is used [here](https://github.com/electron/electron/blob/51d6a550610188347601bdb93fabcbf8f8b81607/lib/renderer/web-view/web-view.js#L30) has been deprecated in favor of `attachShadow`. See [here](https://developer.mozilla.org/en-US/docs/Web/API/Element/createShadowRoot). * Electron version: 1.7.9
https://github.com/electron/electron/issues/11788
https://github.com/electron/electron/pull/11798
278c58055ed36f6f22cea05a9cd85a5ab4fb3010
b32a7d4cb464ca5189e81fcccb97423f224ed0fa
2018-01-31T18:07:59Z
c++
2018-02-01T05:09:33Z
closed
electron/electron
https://github.com/electron/electron
11,761
["atom/browser/ui/cocoa/atom_touch_bar.mm", "lib/browser/api/touch-bar.js"]
`TouchBarButton` doesn't update when inside a `TouchBarGroup`
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: v1.7.11 * Operating system: macOS ### Expected behavior Changing `TouchBarButton` properties should immediately update the button on the touch bar. ### Actual behavior Changing `TouchBarButton` properties has no effect when the `TouchBarButton` is inside a `TouchBarGroup`. ### How to reproduce ```js const updatingButton = new TouchBarButton({'label': 'change'}); setInterval(() => updatingButton.label = '' + Math.random(), 1000); // Button label updates every second const touchBar = new TouchBar([updatingButton]); // Button label never updates const touchBar = new TouchBar([new TouchBarGroup({items: [updatingButton]})]);
https://github.com/electron/electron/issues/11761
https://github.com/electron/electron/pull/11812
6943ada7e8dcb64c0127324e9d90fe6c4a355f3e
66b57858b87658890db616ba8b982246401aaec8
2018-01-28T14:03:06Z
c++
2018-02-12T17:53:04Z
closed
electron/electron
https://github.com/electron/electron
11,715
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/osr/osr_render_widget_host_view.cc", "atom/browser/osr/osr_render_widget_host_view.h", "atom/browser/osr/osr_web_contents_view.cc", "atom/browser/osr/osr_web_contents_view.h"]
How to use stopPainting() ?
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.11 * Operating system: win10 x64 i want record every frame to make a video, ### Expected behavior stop painting page, until call startPainting() ### Actual behavior not stop painting page ### How to reproduce ```js const electron = require('electron'); const fs = require('fs'); const app = electron.app const BrowserWindow = electron.BrowserWindow let mainWindow // app.disableHardwareAcceleration() function createWindow() { mainWindow = new BrowserWindow({ width: 480, height: 800, frame: false, resizable: false, // show: false, webPreferences: { offscreen: true } }) // mainWindow = new BrowserWindow({ width: 480, height: 800 }) var i = 0; mainWindow.webContents.on('paint', (event, dirty, image) => { mainWindow.webContents.stopPainting() const data = image.toPNG() fs.writeFileSync('./f/' + i++ + '.png', data) // mainWindow.webContents.startPainting() }) mainWindow.webContents.setFrameRate(1) mainWindow.on('closed', function () { mainWindow = null }) var url = 'https://github.com'; mainWindow.loadURL(url) //mainWindow.webContents.openDevTools() } app.on('ready', createWindow) app.on('window-all-closed', function () { if (process.platform !== 'darwin') { app.quit() } }) app.on('activate', function () { if (mainWindow === null) { createWindow() } }) ```
https://github.com/electron/electron/issues/11715
https://github.com/electron/electron/pull/11728
fae71f9987bdbcbecc145801dda0161492e4a93c
e6ac2637d393e9eb4a64811bcedbfc01d7ab9ace
2018-01-24T09:36:57Z
c++
2018-02-12T17:29:11Z
closed
electron/electron
https://github.com/electron/electron
11,703
["script/publish-to-npm.js"]
Missing license file in npm release
When installing this library via npm, the license file is missing. This makes automated license generation complicated. Could you add the file to upcoming npm releases?
https://github.com/electron/electron/issues/11703
https://github.com/electron/electron/pull/11705
39554566cc40121501aa20cd84951b4c3aa42a01
4757980f9ccb737e4b2923abc5337d45eda7020b
2018-01-23T18:02:16Z
c++
2018-01-23T23:09:08Z
closed
electron/electron
https://github.com/electron/electron
11,683
["docs/api/tray.md", "shell/browser/api/atom_api_tray.cc", "shell/browser/api/atom_api_tray.h", "shell/browser/ui/tray_icon.cc", "shell/browser/ui/tray_icon.h", "shell/browser/ui/tray_icon_cocoa.h", "shell/browser/ui/tray_icon_cocoa.mm", "shell/browser/ui/win/notify_icon.cc", "shell/browser/ui/win/notify_icon.h", "spec-main/api-tray-spec.ts"]
More control over tray context menu state/visibility
Would it be possible to add methods and/or events to expose the visibility state of Menu instances? For example methods like `Menu#isVisible()` and `Menu#isHidden()` and events like "show" and "hide".
https://github.com/electron/electron/issues/11683
https://github.com/electron/electron/pull/21807
87af95be3e73bbe34d6c3e8b745b163f987d6073
b90537a629aad5e1b22e25697ea7e84da35b8180
2018-01-22T01:10:00Z
c++
2020-01-22T23:25:17Z
closed
electron/electron
https://github.com/electron/electron
11,668
["docs/api/menu.md", "filenames.gypi", "lib/browser/api/menu-utils.js", "lib/browser/api/menu.js", "spec/api-menu-spec.js"]
Menu position property behaves in a confusing way when referencing items that occur later in the list
* Electron version: 1.7.8 * Operating system: Mac OS High Sierra The `position` attribute of context menu items passed to [`buildFromTemplate`](https://electronjs.org/docs/api/menu#menubuildfromtemplatetemplate) lets you position items relative to other items. However, it has an undocumented limitation that the referenced item must precede the item that references it. This can be clearly seen by the fact that `indexToInsertByPosition` only gets passed the "positioned" elements. https://github.com/electron/electron/blob/249bd41e11443feb8949f21367eb1802b19f9544/lib/browser/api/menu.js#L192 A complete solution would probably involve building a graph and then sorting that graph and handling any potential cycles. The potential for, and handling of, cycles is another fact that the documentation does not touch on. An API which offers to order items for you, but also requires you to ensure a specific order of input seems less than useful. In fact, it makes me question to what degree is this property being actively used. Additionally, it only sorts items within an ordered list which was explicitly handed to Electron. I don't see a clear use-case where the application itself couldn't simply pre-order the menu items before passing them to `buildTemplate`. I believe the property was added as a precursor to adding positioning to Atom. Atom support was never added, and after spending some time looking into it this week, I don't think this API will work for Atom at all. ### Possible solutions 1. Document the shortcomings of this property. 2. Deprecate this property and discourage its use going forward. 3. Fix the implementation with a graph sort (I'm not sure how/if the `endof` could be implemented). ### Expected behavior Menu lists items in order: "One, Two" ### Actual behavior Menu lists items out of order: "Two, One" <img width="805" alt="screen shot 2018-01-18 at 9 59 16 am" src="https://user-images.githubusercontent.com/162735/35113444-46f3180a-fc36-11e7-86d7-be0ce27e1595.png"> ### How to reproduce ```JavaScript const {remote} = require('electron') const {Menu, MenuItem} = remote const menu = Menu.buildFromTemplate([ {label: 'Two', id: '2', position: 'after=1'}, {label: 'One', id: '1'}, ]) menu.popup(remote.getCurrentWindow()) ```
https://github.com/electron/electron/issues/11668
https://github.com/electron/electron/pull/12362
118da36b52c582551b61a1b233b16c60ad9bb662
9c8952aef04f570b2212aa66c65e079ca9aed3f0
2018-01-18T18:09:00Z
c++
2018-05-05T16:37:29Z
closed
electron/electron
https://github.com/electron/electron
11,657
["atom/browser/api/atom_api_protocol.h", "atom/browser/net/atom_url_request.cc", "atom/browser/net/atom_url_request_job_factory.cc", "atom/browser/net/atom_url_request_job_factory.h", "spec/api-session-spec.js"]
Downloads are failing with state 'interrupted' from custom protocols in 1.8.2-beta.3
* Electron version: 1.8.2-beta.3 * Operating system: MacOS 10.12 ### Expected behavior File downloads from custom protocols should complete without issue. ### Actual behavior Before even triggering the custom protocol handler, the download-item emits 'done' with a state of 'interrupted'. In my demo linked below, I use the new registerStreamProtocol, but I was able to reproduce using registerHttpProtocol as well. ### How to reproduce Use https://github.com/pfrazee/electron-download-interrupt-bug
https://github.com/electron/electron/issues/11657
https://github.com/electron/electron/pull/11804
78ccfa0612b50bd9c70b1f0932266416702a0563
f3415c04cd1755f31a5d708ed3d39e44ae9415e8
2018-01-17T03:53:27Z
c++
2018-02-16T19:17:46Z
closed
electron/electron
https://github.com/electron/electron
11,639
["docs/tutorial/installation.md"]
Prevent Connection to Github on install
In `npm/install.js`, the post-install step talks out to github. On networks where github.com is blocked, this means we cannot install Electron.
https://github.com/electron/electron/issues/11639
https://github.com/electron/electron/pull/11640
2b4cc0a5254b11dce6f3414a5d9d349edd3e6c7f
8a4c76d6558cffa53400e54317f0f9b1da22f7ef
2018-01-15T06:15:17Z
c++
2018-01-19T21:33:36Z
closed
electron/electron
https://github.com/electron/electron
11,638
["docs/tutorial/installation.md"]
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: * Operating system: Win 10 x64 ### Expected behavior <!-- What do you think should happen? --> ### Actual behavior <!-- What actually happens? --> ### How to reproduce <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . --> When i run command ```npm i [email protected]``` Eset Nod32 Antivirus shout NSIS/TrojanDownloader.Adload
https://github.com/electron/electron/issues/11638
https://github.com/electron/electron/pull/11640
2b4cc0a5254b11dce6f3414a5d9d349edd3e6c7f
8a4c76d6558cffa53400e54317f0f9b1da22f7ef
2018-01-14T19:31:56Z
c++
2018-01-19T21:33:36Z
closed
electron/electron
https://github.com/electron/electron
11,609
["atom/browser/api/atom_api_desktop_capturer.cc"]
Windows 10 navigator.mediaDevices.getUserMedia captures the wrong screen.
* Electron version: 1.7.0+ (it works in 1.6.15) * Operating system: Windows 10 x64 ### Expected behavior When passing in a screen id getUserMedia should return a stream for the corresponding screen. ### Actual behavior When passing in a screen id getUserMedia returns a stream from a different screen, or a broken stream in some situations. ** means primary monitor Monitor configuration and results: - [ 1**, 2 ] - Capturing either screen works - [ 1, 2** ] - Capturing screen 1 returns a stream for screen 2, capturing screen 2 returns a broken stream - [ 2, 1** ] - Capturing screen 1 works, capturing screen 2 returns a broken stream. - [ 2**, 1 ] - capturing screen 1 returns a stream for screen 2, capturing screen 2 returns stream for screen 1. ### How to reproduce If you provide a URL, please list the commands required to clone/setup/run your repo e.g. ```bash git clone https://github.com/hokein/electron-screen-recorder.git cd electron-screen-recorder npm install npm uninstall electron-prebuilt --save-dev npm install [email protected] --save ./node_modules/.bin/electron . ``` Attempt one of the broken configurations above to see results.
https://github.com/electron/electron/issues/11609
https://github.com/electron/electron/pull/11664
868e792572466ccb33b3a27e1472e87b53173096
0207aebad1b9ad5c2195299bb1fa7437ba39f683
2018-01-09T20:59:37Z
c++
2018-01-24T05:38:32Z
closed
electron/electron
https://github.com/electron/electron
11,594
["atom/browser/api/atom_api_notification.cc", "atom/browser/api/atom_api_notification.h", "brightray/browser/mac/cocoa_notification.mm", "brightray/browser/notification.h", "docs/api/notification.md", "spec/api-notification-spec.js"]
Feature request: Ability to change close label in notifications (Mac)
* Electron version: 1.7.10 * Operating system: MacOS ### How to reproduce Currently I am using a separate module for Mac notifications with action buttons (node-notifier). Action buttons are necessary for such scenarios: when user has incoming call, notification has two buttons: 'answer' and 'decline'. Recently I found out that Electron has its own implementation of notifications and allows to add action buttons. That's great feature, but the issue I found is that I can't add two actions. I see two possible solutions: add ability to change 'close' label or add ability to display several actions (e.g. under 'More' button, as it is implemented in Chrome). Is there any plans to implement it? Thank you!
https://github.com/electron/electron/issues/11594
https://github.com/electron/electron/pull/11654
fdda1c55c5f8d399a8954fa87828f52f5a699acf
af92b04eb9bc064732087c7966d3cdcf2344db73
2018-01-08T09:34:07Z
c++
2018-02-15T07:01:30Z
closed
electron/electron
https://github.com/electron/electron
11,593
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_window.cc", "spec/api-browser-window-spec.js"]
Segfault calling Browser window with options Proxy.
* Electron version: 1.6.15 * Operating system: Linux ### Expected behavior Open a `BrowserWindow` with passed options ### Actual behavior - Usually a Segmentation fault. - Sometimes `[12843:0100/000000.043847:FATAL:zygote_linux.cc(479)] Failed to synchronise with parent zygote process` - Sometimes `[12819:0100/000000.719122:FATAL:zygote_linux.cc(509)] Check failed: len > 0 (0 vs. 0)` ### How to reproduce I'm still working on making a smaller reproduction case. The issue goes away with small tweaks. 1. Starting from https://github.com/daurnimator/fengari-electron-example 2. Modify main.lua to contain: ```lua local js = require "js" local electron = require "electron" electron.app:on("ready", function() local win = js.new(electron.BrowserWindow, js.createproxy({ backgroundColor = '#2e2c29'; }, "object")) win:loadURL("https://fengari.io") end) ```
https://github.com/electron/electron/issues/11593
https://github.com/electron/electron/pull/11598
181169b74313e280d1cd649f1e2054bfd7029e9c
9bd7d53cf85ac36e81a080c4fd0572ca34d395ff
2018-01-08T09:29:55Z
c++
2018-02-12T19:46:29Z
closed
electron/electron
https://github.com/electron/electron
11,587
["patches/chromium/.patches", "patches/chromium/remove_menu_window_task_item.patch", "shell/browser/ui/win/notify_icon.cc", "shell/browser/ui/win/notify_icon.h"]
Accessibility issue: Electron system tray context menu on Windows is not keyboard navigable
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.10 * Operating system: Windows 10 ### Expected behavior It is possible to access system tray items and their respective context menus on Windows using the keyboard only. This functionality is important for accessibility reasons. The system tray is selected using the key combination **WINDOWS+B** and then opened using the **ENTER** key. It is then possible to navigate to a specific icon using the arrow keys and select it with **ENTER** to open the icon's context menu. It _should_ be possible to then navigate through this menu using the arrow keys and select a specific item with **ENTER**. ### Actual behavior Arrow key navigation and ENTER selection is not available for Electron apps' system tray icon context menus. Pressing the arrow keys while the system tray icon's context menu is open, after being opened using the keyboard steps above, produces no result. ### How to reproduce 1. **WINDOWS+B** and then **ENTER** to open the list of icons 2. Arrow keys and to select the Electron app's icon 3. Press **SHIFT+F-10** to open the icon's context menu 4. Observe that arrow keys are not useable within this icon's menu, but are for other icons. ### Technical details See **notify_icon.cc**'s function `NotifyIcon::PopUpContextMenu` which makes a call to the `->RunMenuAt`. I am new to the Electron codebase, but as far as I can tell, this is `RunMenuAt` call is defined in Chromium, meaning we can't change it directly, but will need to find another way to show context menus that is keyboard accessible.
https://github.com/electron/electron/issues/11587
https://github.com/electron/electron/pull/24097
b665eb6d43d5238ffcd1bb7239e75797cf1bd5d5
2376c45443fc75347acb9f92fddc19276c552e29
2018-01-08T03:25:21Z
c++
2020-06-18T04:21:43Z
closed
electron/electron
https://github.com/electron/electron
11,571
["atom/browser/native_window_mac.mm", "atom/browser/ui/cocoa/atom_menu_controller.mm"]
[Mac OSX] Can't change the label for "Enter Full Screen" menu item
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.10 * Operating system: Mac OSX High Sierra ### Expected behavior Label for "Enter Full Screen" changes ### Actual behavior Label for "Enter Full Screen" is not changing ### How to reproduce Here is my "View" menu ``` { label: i18n.__('MENU.VIEW.TITLE'), submenu: [ { label: i18n.__('MENU.VIEW.RELOAD'), role: "reload" }, { type: "separator" }, { label: i18n.__('MENU.VIEW.FULL_SCREEN'), role: "togglefullscreen" }, { label: i18n.__('MENU.VIEW.ZOOM_IN'), role: "zoomin" }, { label: i18n.__('MENU.VIEW.ZOOM_OUT'), role: "zoomout" }, ] }, ``` All other menu item change according to the language file. <img width="202" alt="screen shot 2018-01-05 at 11 01 10 am" src="https://user-images.githubusercontent.com/5366008/34592562-64ddaaa2-f208-11e7-954a-735f35f28de9.png"> <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . -->
https://github.com/electron/electron/issues/11571
https://github.com/electron/electron/pull/11633
d0af17e601710fbdef75d4ea1bc3c3c1e101e458
2b4cc0a5254b11dce6f3414a5d9d349edd3e6c7f
2018-01-05T02:09:07Z
c++
2018-01-19T14:27:36Z
closed
electron/electron
https://github.com/electron/electron
11,560
["docs/api/browser-window.md", "docs/api/web-contents.md", "lib/browser/api/browser-window.js", "lib/browser/api/web-contents.js"]
Add `browserWindow.loadFile()` convenience method
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.10 * Operating system: macOS 10.13.2 ### Description The most common use-case for Electron is to load a local HTML file. The default way to do this is pretty verbose and ugly ```win.loadURL(`file://${__dirname}/index.html`)```. I propose adding a convenience method to make the most common use-case simpler and nicer. A `win.loadFile()` method which loads a file relative to the root of the app: ```js win.loadFile('index.html'); ``` Which would be almost equivalent to: ```js const loadFile = filePath => win.loadURL(`file://${path.resolve(electron.app.getAppPath(), filePath)}`); ``` We should also add `file` option to the `BrowserWindow` constructor, so all you needed to do to create a window with a local file (which is what most would do) is just: ```js const win = new BrowserWindow({file: 'index.html'}); ``` Ergonomics are important, and this is something that would benefit most Electron apps. I would be happy to do a PR if this is accepted. I've added support for it in my Electron utility module if you want it today: https://github.com/sindresorhus/electron-util#loadfilewindow-filepath
https://github.com/electron/electron/issues/11560
https://github.com/electron/electron/pull/11565
8a4c76d6558cffa53400e54317f0f9b1da22f7ef
32a1395bcfd6db9cb3eb35e8072caca085be38c1
2018-01-03T11:25:16Z
c++
2018-01-22T22:08:23Z
closed
electron/electron
https://github.com/electron/electron
11,556
["atom/browser/api/atom_api_system_preferences_win.cc"]
hexColorDWORDToRGBA is broken for transparent colors
* Electron version: 1.7.10 * Operating system: Windows 8.1 ### Expected behavior 8 character hexadecimal string is returned ### Actual behavior 1. _CxxThrowException | throw.cpp 2. std::_Xout_of_range | xthrow.cpp 3. std::basic_string_char,std::char_traits_char_,std::allocator_char_ _::assign | xstring 4. std::basic_string_char,std::char_traits_char_,std::allocator_char_ _::substr | xstring 5. atom::api::hexColorDWORDToRGBA ### How to reproduce Call `hexColorDWORDToRGBA` for any value less than 256 to throw an exception. Additionally, incorrect results are returned in many cases when the alpha channel or red component is less than two hexadecimal digits.
https://github.com/electron/electron/issues/11556
https://github.com/electron/electron/pull/11557
f5962538f45fca4c89d3afff5871e5a67073451e
fa43cb6ef0ad650220481eeca7cc36baffcdff5e
2018-01-02T21:25:59Z
c++
2018-01-11T16:28:53Z
closed
electron/electron
https://github.com/electron/electron
11,549
["atom/browser/browser.cc", "atom/browser/browser.h", "atom/common/linux/application_info.cc", "brightray/browser/linux/libnotify_notification.cc", "brightray/common/application_info.cc", "brightray/common/application_info_win.cc", "script/lib/dbus_mock.py", "script/test.py", "spec/api-notification-dbus-spec.js"]
Every app with electron has app-name "Electron" in web notifications
* Electron version: 1.7.8 * Operating system: Debian 9.3 ### Expected behavior "App-name" field (libnotify) in notifications coming from BrowserWindow (WebView perhaps?) should be filled with the name of the app (either "name" or "productName" from package.json), or at least it should be allowed to modify its value within Electron. ### Actual behavior Every notification have "app-name" field set to "Electron" ### How to reproduce Open a BrowserWindow object on any page which contains web notifications, such as https://developer.mozilla.org/en-US/docs/Web/API/notification
https://github.com/electron/electron/issues/11549
https://github.com/electron/electron/pull/12192
9d090e00f24567f06b72aad642b0eeba2545d459
86af20ded062598fbc71244fd180e3e608954ba6
2018-01-01T21:48:24Z
c++
2018-03-12T00:33:06Z
closed
electron/electron
https://github.com/electron/electron
11,429
["vendor/libchromiumcontent"]
Menuitem display missing shift modifier in accelerator
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.8.2-beta.3 * Operating system: Windows / Linux ### Expected behavior Expect accelerator correctly includes modifier <!-- What do you think should happen? --> ### Actual behavior For some key combination, shift modifier is not displayed while functionwise it works. ![image](https://user-images.githubusercontent.com/1210596/33964550-a0ca46a4-e00d-11e7-93b1-832317f60436.png) <!-- What actually happens? --> ### How to reproduce ``` const menu = Menu.buildFromTemplate([ { label: 'Test', submenu: [ { label: 'Missing modifier', accelerator: 'Control+Shift+F' }, { label: 'Working', accelerator: 'Control+Shift+Tab' } ] } ]); Menu.setApplicationMenu(menu); ``` then ctrl-shift-f will be displayed as ctrl-f only. This started from 1.8.2-beta.2, peeking history between version it seems like patch change around accelerator in libchromiumcontent might be reason - but I couldn't verify it by myself. <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . -->
https://github.com/electron/electron/issues/11429
https://github.com/electron/electron/pull/11589
4298aecb7c9ad60bcd11527b51bc67aa0a0bd7e2
c1d68974ab3897af31852b93142e4040bb485062
2017-12-13T21:56:24Z
c++
2018-01-08T07:15:28Z
closed
electron/electron
https://github.com/electron/electron
11,399
["atom/browser/lib/bluetooth_chooser.cc"]
Web bluetooth takes 1 minute before returning a device
* Electron version: 1.7.9 * Operating system: macOS Sierra ### Expected behavior We should have some type of bluetooth dialog (like in chrome). ### Actual behavior A 1 minute timeout before a device (even with specified name) is selected and connected to.
https://github.com/electron/electron/issues/11399
https://github.com/electron/electron/pull/11492
8ac52b418b01b5aee186e5128005c6ba99d2efe6
42fa018277743a82b2d0b874bb31da437515d63f
2017-12-11T03:13:54Z
c++
2018-02-05T11:44:42Z
closed
electron/electron
https://github.com/electron/electron
11,389
["atom/browser/ui/message_box_mac.mm"]
checkbox in dialog not working
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.8.2-beta.3 * Operating system: Mac OS X 10.12.6 ### Expected behavior When ticking the checkbox on a dialog box we should receive a true value in the callback <!-- What do you think should happen? --> ### Actual behavior I always receive false value checked or not <!-- What actually happens? --> ### How to reproduce clone https://github.com/electron/electron-quick-start project and add this to renderer.js `require('electron').remote.dialog.showMessageBox({ type: "question", buttons: ["OK", "Cancel"], message: "This is a test.", checkboxLabel: "Do not show this message again." }, function (...args) { console.log(...args) })` It will always display `0 false` I also tested on Windows 10 and it's working as expected. And I tested the [email protected] on both windows and mac OS X, it works too.
https://github.com/electron/electron/issues/11389
https://github.com/electron/electron/pull/11658
4dab824c6b7b833a4e3af878b1d021d60822d3e0
4f0e1826e5470f1574e528ff6ca7478a4ee89a46
2017-12-09T14:58:47Z
c++
2018-01-17T13:51:49Z
closed
electron/electron
https://github.com/electron/electron
11,376
["lib/browser/api/menu.js", "spec/api-menu-spec.js"]
menu.popup() doesn't accept the "async" option anymore.
* Electron version: fails only on 1.8.2-beta.2, 1.8.2-beta.3 (works on 1.8.2-beta.1) * Operating system: macOS 10.13.2 ### Expected behavior Calling `menu.popup({async: true})` from the main or renderer process should work (it does in versions 1.8.2-beta.1 and 1.7.9 and below). ### Actual behavior When calling `menu.popup({async: true})` with 1.8.2-beta.2 and 1.8.2-beta.3, it throws the following error: From main process: `Uncaught Exception: TypeError: Error processing argument at index 0, conversion failure from #<Object>` From renderer process: `Error: Could not call remote function ''. Check that the function signature is correct. Underlying error: Error processing argument at index 0, conversion failure from #<Object>` ### How to reproduce https://github.com/romaincointepas/electron-quick-start - menu will show after 3 seconds behind at the pointer position with electron 1.7.9 and 1.8.2-beta.1 - menu will now show (error in console) when using electron 1.8.2-beta.2 and 1.8.2-beta.2
https://github.com/electron/electron/issues/11376
https://github.com/electron/electron/pull/11385
76ee1e1cb6abd1be8f544b1380e9dd3d2f4a3802
e73fe100d533c20372b3248df957bb910a279e0d
2017-12-07T20:04:50Z
c++
2017-12-12T00:02:33Z
closed
electron/electron
https://github.com/electron/electron
11,371
["docs/api/web-request.md", "shell/browser/api/atom_api_web_request.cc", "spec-main/api-net-spec.ts"]
Filters don't work in webRequest
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.9 * Operating system: macOS ### Expected behavior The callback should be used only for URLs matching the filter. ``` const filter = { urls: ['*://www.googleapis.com'] }; session.defaultSession.webRequest.onBeforeRequest(filter, (details, callback) => { console.log('onBeforeRequest: ', details); callback({ cancel: true }); }); ``` <!-- What do you think should happen? --> ### Actual behavior The callback is called for random URLs. ``` onBeforeRequest: { id: 1, method: 'GET', referrer: '', resourceType: 'mainFrame', timestamp: 1512654154551.9841, url: 'file:///Users/pronebird/apple/mail/build/index.html' } onBeforeRequest: { id: 4, method: 'GET', referrer: '', resourceType: 'mainFrame', timestamp: 1512654154564.2021, url: 'chrome-devtools://devtools/bundled/inspector.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@691bdb490962d4e6ae7f25c6ab1fdd0faaf19cd0/&can_dock=&toolbarColor=rgba(223,223,223,1)&textColor=rgba(0,0,0,1)&experiments=true' } ``` <!-- What actually happens? -->
https://github.com/electron/electron/issues/11371
https://github.com/electron/electron/pull/19337
65648756b547577ee50449e5d173804bc69332dc
49096c23591ea88b3bba465c405281c526a9492b
2017-12-07T13:45:47Z
c++
2019-07-25T17:20:02Z
closed
electron/electron
https://github.com/electron/electron
11,353
["script/create-dist.py"]
script/create-dist.py doesn't allow custom libchromiumcontent directory
* Electron version: 1.8.2 beta 3 * Operating system: Fedora 27 ### Expected behavior I'd expect the `script/create-dist.py` to accept an argument (like `--chromium_dir <path>`) in order to specify a custom libcc dist folder ### Actual behavior There is no such option ### How to reproduce Just compile libchromiumcontent in a different folder than electron's `vendor/libchromiumcontent` and after bootstrap, update and build, run the `create-dist.py` script. Note: I'm going to create a pull request for this
https://github.com/electron/electron/issues/11353
https://github.com/electron/electron/pull/11354
732af93fc9ab826829b4e304708b3ba196137568
28d96e2d29c2e371de9c89095f9d89bf659f6aec
2017-12-06T08:52:34Z
c++
2018-02-05T06:08:57Z
closed
electron/electron
https://github.com/electron/electron
11,331
["atom/browser/browser.cc", "atom/browser/browser.h", "atom/browser/browser_win.cc", "brightray/browser/win/windows_toast_notification.cc", "brightray/common/application_info.cc", "brightray/common/application_info.h", "brightray/common/application_info_win.cc", "brightray/filenames.gypi"]
GetLoginItemSettings implicitly sets the processes AppUserModelId
Calls to GetLoginItemSettings (amonst others) will get GetAppUserModelId which will implicit set a new one if there hasn't been a user defined one yet. This causes an issue in a UWP environment where the AppUserModelId is system defined. On the latest versions of windows the AppUserModelId defined for your notification must match exactly the one defined for your process or no notification will appear. Got a fix in the works for this just raising here for tracking purposes.
https://github.com/electron/electron/issues/11331
https://github.com/electron/electron/pull/11344
9676c0a4f9478cf87ebeb894019b65a9716118b1
8ac52b418b01b5aee186e5128005c6ba99d2efe6
2017-12-04T20:03:25Z
c++
2018-02-05T08:29:59Z
closed
electron/electron
https://github.com/electron/electron
11,319
["atom/browser/api/atom_api_app.cc", "atom/browser/api/atom_api_app.h", "atom/browser/atom_browser_client.cc", "brightray/browser/browser_main_parts.cc", "brightray/browser/media/media_capture_devices_dispatcher.cc"]
`MediaCaptureDevicesDispatcher` is constructed on a wrong thread
In https://github.com/electron/electron/commit/7613afe6d70eadd7446db921918dca086cd324c0 I had to disable the check that validates that the constructor is called on the right thread, because the check fails when the tests run. Let's make sure the check doesn't fail and re-enable it. Or refactor so that the thread affinity is not required and remove the check.
https://github.com/electron/electron/issues/11319
https://github.com/electron/electron/pull/11370
63c91e7dd3764499d846f7e0b384d82d1da2bbc5
f10c279322fe4878895293a95df83f73a52a1d65
2017-12-02T10:41:58Z
c++
2017-12-07T20:55:33Z
closed
electron/electron
https://github.com/electron/electron
11,318
["atom/browser/api/atom_api_app.cc", "atom/browser/api/atom_api_app.h", "atom/browser/atom_browser_client.cc", "brightray/browser/browser_main_parts.cc", "brightray/browser/media/media_capture_devices_dispatcher.cc"]
`AtomBrowserClient::CanCreateWindow` is called on wrong thread
In https://github.com/electron/electron/commit/7613afe6d70eadd7446db921918dca086cd324c0 I had to disable the check that validates that the call is made on the right thread, because the check fails when the tests run. Let's make sure the check doesn't fail and re-enable it. Or refactor so that the thread affinity is not required and remove the check.
https://github.com/electron/electron/issues/11318
https://github.com/electron/electron/pull/11370
63c91e7dd3764499d846f7e0b384d82d1da2bbc5
f10c279322fe4878895293a95df83f73a52a1d65
2017-12-02T10:40:21Z
c++
2017-12-07T20:55:33Z
closed
electron/electron
https://github.com/electron/electron
11,289
["vendor/pdf_viewer"]
DCHECK on shared_resources_data_source.cc:106
_DCHECK is actually in the libcc, but probably Electron does something weird to trigger it._ ``` [17694:1129/072103.910993:FATAL:shared_resources_data_source.cc(106)] Check failed: -1 != idr (-1 vs. -1) path: polymer/v1_0/paper-dialog/paper-dialog.html ``` Right now it is simply commented out via a libcc patch: ```diff - DCHECK_NE(-1, idr) << " path: " << path; + // DCHECK_NE(-1, idr) << " path: " << path; ``` "chrome://resources/..." is Chromium internal "protocol" to access shared resources like libraries, fonts, images, etc. from internal pages. If we get a request to load some Polymer stuff (used on most internal pages of Chromium), it means we are definitely trying to load one of them. Can it be related to the Chromium PDF viewer? /cc @alespergl, @deepak1556, @zcbenz
https://github.com/electron/electron/issues/11289
https://github.com/electron/electron/pull/11302
aab35073ee85c2e2db71e06da51b55e4992e2900
c2ee0854f403c9c9fca9295f2fbdd08cc06276a9
2017-11-29T23:14:42Z
c++
2017-12-01T10:57:25Z
closed
electron/electron
https://github.com/electron/electron
11,288
[".gitignore", "README.md", "script/cibuild", "spec/api-crash-reporter-spec.js", "spec/api-protocol-spec.js", "spec/chromium-spec.js", "spec/node-spec.js", "spec/package-lock.json", "spec/webview-spec.js"]
Remove outdated references to Travis CI
Travis CI will soon be disabled for electron/electron and electron/libchromiumcontent, but there are still some lingering references to it in the tests: https://github.com/electron/electron/search?utf8=%E2%9C%93&q=travis&type= There are also some docs about how to test on Travis: I'm not sure if those should be removed or if they might still be useful to some folks.
https://github.com/electron/electron/issues/11288
https://github.com/electron/electron/pull/11297
e989005122590392fffca7ee2f673fcd64235bef
3e056eec9ef4d0a2332370721cef341dc30c9412
2017-11-29T22:56:13Z
c++
2017-12-04T16:56:53Z
closed
electron/electron
https://github.com/electron/electron
11,269
["lib/browser/api/auto-updater/squirrel-update-win.js"]
Update.exe Flashes on Screen for Windows
* Electron version: 1.7.9 * Operating system: Windows 10 / 8.1 ### Expected behavior On running `electron.autoUpdater.checkForUpdates()`, Update.exe should run in the background. ### Actual behavior On running `electron.autoUpdater.checkForUpdates()`, Update.exe flashes on the screen. ### How to reproduce In `package.json` set `electronVersion` to `1.7.9` or higher Build application that calls `electron.autoUpdater.checkForUpdates()` Update.exe will flash momentarily in the foreground. ### More details This is not an issue for `electronVersion: 1.6.8.` Looking quickly at `squirrel-update-win.js` and https://nodejs.org/api/child_process.html, it might be possible to hide this window by setting `windowsHide` to true when calling `spawn` in `spawnUpdate`
https://github.com/electron/electron/issues/11269
https://github.com/electron/electron/pull/11316
9c109daa4b882902239d0d3531ecda6c70390405
46f79146ad9622ecee7789a0238070908dfe2f32
2017-11-27T21:37:35Z
c++
2017-12-06T05:50:12Z
closed
electron/electron
https://github.com/electron/electron
11,248
["atom/common/api/atom_api_clipboard.cc"]
FIXME: Use sk_tool_utils::copy_to() instead of .deepCopyTo().
[atom/common/api/atom_api_clipboard.cc](https://github.com/electron/electron/blob/master/atom/common/api/atom_api_clipboard.cc) See TODO in the code. /cc @gavignus
https://github.com/electron/electron/issues/11248
https://github.com/electron/electron/pull/12616
40ff17c9f969e7ec651a61614b59795c39fa087a
7a8a0f6b4b5c2f54876994b5ae38318e0c436bbd
2017-11-24T11:01:22Z
c++
2018-04-17T02:18:23Z
closed
electron/electron
https://github.com/electron/electron
11,246
["spec/api-crash-reporter-spec.js"]
Fix "crashReporter module" tests
They were disabled during the Chromium 61 upgrade. Fix them and enable. /cc @codebytere
https://github.com/electron/electron/issues/11246
https://github.com/electron/electron/pull/11254
d09e8cc37f485efd58d563e6315b38008527867c
2d75eea82a6210085638c2237c0eca336d4a0027
2017-11-24T09:57:45Z
c++
2017-11-30T17:55:49Z
closed
electron/electron
https://github.com/electron/electron
11,245
["atom/common/api/atom_api_native_image.cc", "spec/api-native-image-spec.js"]
Fix "nativeImage module addRepresentation() ..." tests
They were disabled during the Chromium 61 upgrade. Fix them and enable. /cc @alespergl
https://github.com/electron/electron/issues/11245
https://github.com/electron/electron/pull/11255
c1728720a761fa235e75afb97cbb4ea1732b334c
aab35073ee85c2e2db71e06da51b55e4992e2900
2017-11-24T09:56:55Z
c++
2017-11-30T18:48:11Z
closed
electron/electron
https://github.com/electron/electron
11,244
["spec/webview-spec.js"]
Fix "<webview> tag found-in-page event emits when a request is made" test
It was disabled during the Chromium 61 upgrade. Fix it and enable. /cc @deepak1556
https://github.com/electron/electron/issues/11244
https://github.com/electron/electron/pull/11256
2bc8b33c2acdbaaba7d08ea3483ec811ec86063d
c1728720a761fa235e75afb97cbb4ea1732b334c
2017-11-24T09:55:45Z
c++
2017-11-30T18:48:00Z
closed
electron/electron
https://github.com/electron/electron
11,242
["docs/api/menu.md"]
Remove async menu from the docs
It was removed by Chromium in the version 61, so we don't have it anymore. Remove it from the docs. /cc @zeke
https://github.com/electron/electron/issues/11242
https://github.com/electron/electron/pull/11257
141c4e9a0e949b9da42dc973511abacd052cd482
defa42b458f4f244b66b45f446116dd32965344e
2017-11-24T09:50:58Z
c++
2017-11-27T15:41:56Z
closed
electron/electron
https://github.com/electron/electron
11,216
["atom/renderer/api/atom_api_web_frame.cc"]
Pinch Zoom enables again when changing from external monitor to laptop monitor
* Electron version: 1.7.9 * Operating system: macOS 10.13.1 ### Expected behavior If pinch-zoom is disabled via `webFrame.setVisualZoomLevelLimits(1, 1);` it should stay disabled. ### Actual behavior Pinch zoom is possible. ### How to reproduce * connect an external monitor and open any electron app there, keep the macbook pro lid closed * disconnect the external monitor * open the lid => you can now pinch zoom
https://github.com/electron/electron/issues/11216
https://github.com/electron/electron/pull/12488
fbff355742336179371ba728ce83e4d4111360d0
a7352e57d52cf629b89d2653086b54ae479e97fd
2017-11-22T09:08:36Z
c++
2018-04-02T22:20:13Z
closed
electron/electron
https://github.com/electron/electron
11,189
["atom/browser/notifications/win/win32_desktop_notifications/toast.cc", "atom/browser/notifications/win/win32_notification.cc"]
Notification with tag works only once
After creating a notification and passing a tag, then subsequent notifications with the same tag don't show up for the entire lifespan of the app. * Electron version: 1.8.1 * Operating system: Windows 7 x64 ### Expected behavior New notifications should open after the last one has closed. ### Actual behavior Nothing happens ### How to reproduce $ git clone https://github.com/electron/electron-quick-start . $ npm install $ npm start Then in the app open dev tools and paste this in the console: new Notification("test", { tag: "test" }); Wait for the notification to disappear and paste it again, observe nothingness.
https://github.com/electron/electron/issues/11189
https://github.com/electron/electron/pull/18401
0e3ab7c1285d92ee597ecc8b5045779be6267840
0bf83b7183c2bd9883a3af8e063e6ead372dddb3
2017-11-20T20:13:49Z
c++
2019-06-11T23:39:25Z
closed
electron/electron
https://github.com/electron/electron
11,182
["lib/common/asar.js"]
fs.readFile(path, null, cb) TypeError: Bad arguments
Hello! When read file from asar I see error: TypeError: Bad arguments. `fs.readFile(path, null, cb)` This code work fine: `fs.readFile(path, {}, cb)` If use fs-extra throw same error: `fse.readFile(path)` Tested in 1.8.2-beta.2
https://github.com/electron/electron/issues/11182
https://github.com/electron/electron/pull/11185
dafd3d69bcddfb218c375685f708f6b00e4e845c
fa37d49fb6928e665e60187f20f6e35159b2fee6
2017-11-20T14:43:39Z
c++
2017-11-20T16:57:31Z
closed
electron/electron
https://github.com/electron/electron
11,155
["lib/browser/api/web-contents.js", "lib/renderer/init.js", "spec/api-browser-window-spec.js", "spec/static/main.js"]
executeJavaScript does not reject with the Error of the rejected eval result Promise
* Electron version: 1.7.9 x86 * Operating system: Win7 x64 ```js try { await web.executeJavaScript('new Promise(() => {throw new Error("exec error");});'); // or await web.executeJavaScript('Promise.reject(new Error("exec error"));'); } catch (e) { // e should be an Error('exec error') } ``` ### Expected behavior e should be an Error('exec error') ### Actual behavior e is an empty Object
https://github.com/electron/electron/issues/11155
https://github.com/electron/electron/pull/11158
4c04f1c7edbdea334c9882d2e18c3762ceaf0514
5eb00e45aaf5419faa72f66aa714fc79f784b1ca
2017-11-17T22:59:10Z
c++
2017-11-20T15:14:05Z
closed
electron/electron
https://github.com/electron/electron
11,150
["atom/browser/native_window_mac.mm"]
titleBarStyle: hidden logs an error
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.8.2 * Operating system: macOS 10.13.1 ### Expected behavior The use of `titleBarStyle: hidden` should not log an error. ### Actual behavior When using `titleBarStyle: hidden`, the following error gets logged. ``` Electron[10655:980586] *** WARNING: Textured window <AtomNSWindow: 0x7fcb0f71bdb0> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead. ``` ### How to reproduce Set the `titleBarStyle` of the electron window to `hidden`.
https://github.com/electron/electron/issues/11150
https://github.com/electron/electron/pull/11164
596a61f1ad666091d3e987cdd3d76d872d709724
dba91816116ab84faaa7345b7d60afacf3f1b284
2017-11-17T16:04:31Z
c++
2017-11-21T06:51:47Z
closed
electron/electron
https://github.com/electron/electron
11,147
["atom/renderer/api/atom_api_web_frame.cc"]
Spellchecking broken in iFrames in 1.8.*
* Electron version: 1.8.x only. Tested with 1.8.1, 1.8.2-beta.1, 1.8.2-beta.2. Not seen with any 1.7 or 1.6 * Operating system: macOS, ubuntu 17.04, probably others ### Expected behavior Setting the following should result in all words being marked as mispelled on the page as in electron versions prior to 1.8. ```js require('electron').webFrame.setSpellCheckProvider('enUS', true, { spellCheck: (word) => false }) ``` ### Actual behavior In 1.8.* Words are marked as mispelled in the main frame, but not child iframes. See screenshots below.... **1.8.2-beta.2** ![screen shot 2017-11-17 at 11 35 55](https://user-images.githubusercontent.com/103586/32945726-79af89b6-cb8c-11e7-8b03-7b1d3628ad22.png) **1.7.9** ![screen shot 2017-11-17 at 11 36 56](https://user-images.githubusercontent.com/103586/32945755-8ad98052-cb8c-11e7-8bec-74a81d6f0556.png) ### How to reproduce ``` git clone https://github.com/wavebox/electron-quick-start.git cd electron-quick-start git checkout 1_8_spellchecker npm install npm start ``` I've done a little bit of digging, but haven't come up with a solid solution. It looks like the way the spell check provider works was changed between chrome 58 and 59. `SetTextCheckClient` was added to `atom_api_web_frame.cc` in the 1.8 upgrade and a little searching on that reveals [this conversation chromium](https://bugs.chromium.org/p/chromium/issues/detail?id=638361) which talks about the refactoring the spell checker to be frame-based rather than view-based.
https://github.com/electron/electron/issues/11147
https://github.com/electron/electron/pull/11238
06e1fb923b9e15a94cd35f997126f0b454240c16
65871cd5679f74301fbd44f7e2ff48012e1051b2
2017-11-17T11:50:03Z
c++
2017-12-21T08:00:01Z
closed
electron/electron
https://github.com/electron/electron
11,132
["atom/browser/api/atom_api_browser_view.cc", "docs/api/browser-view.md", "lib/browser/api/browser-view.js", "spec/api-browser-view-spec.js"]
remote.getCurrentWindow() returns null in a BrowserView
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.6.15 * Operating system: Linux ### Expected behavior Inside a `BrowserView`, I want to access the [`view.id`](https://github.com/electron/electron/blob/master/docs/api/browser-view.md#viewid-experimental). I would have expected `remote.getCurrentWindow()` to return the `view`. ### Actual behavior Calling `remote.getCurrentWindow()` returns `null`. --- I understand if you want to expose a different API here since the method _is_ called <code>getCurrent**Window**()</code>. However, there should be _some_ way to access the `view` from within a `BrowserView` process.
https://github.com/electron/electron/issues/11132
https://github.com/electron/electron/pull/11225
fded32dc4fbcdbc4898c547550b405c2550a63d5
3c607394d794a97625b422b8cab7038d583ca218
2017-11-15T18:29:50Z
c++
2017-11-23T08:49:11Z
closed
electron/electron
https://github.com/electron/electron
11,128
["docs/api/window-open.md", "lib/browser/api/web-contents.ts", "lib/browser/guest-window-manager.ts", "typings/internal-electron.d.ts"]
Opened windows will be closed when the opener window closes.
* Electron version: 1.7.5, 1.7.9 * Operating system: Windows 10 x64, Windows 7 x86 ### Expected behavior Opened windows will remain open when closing the opener window. ### Actual behavior Opened windows will automatically close when the opener window is closed. ### How to reproduce 1. Open an electron instance with a BrowserWindow (window A). 2. Navigate to https://www.w3schools.com/jsref/met_win_open.asp (or similar pages) 3. Open a new window (window B) by clicking the "Try It Yourself" button. 4. Open a new window (window C) by clicking the "Try It" button in Window B. 4. Close window B (opener window of window C) Result: Window C closes. This only closes the opened windows (and the opened windows in the opened window, eg.) when closing the opener window. All other windows remain unaffected: Closing window A results in the closing of window B and window C.
https://github.com/electron/electron/issues/11128
https://github.com/electron/electron/pull/31314
bcf060fab67fe1912d03ad253de98b3091b2a61b
41b2945ced7f93568fb3771ab6989d490214ab91
2017-11-15T16:01:05Z
c++
2022-02-23T07:59:50Z
closed
electron/electron
https://github.com/electron/electron
11,107
["atom/browser/ui/cocoa/NSColor+Hex.h", "atom/browser/ui/cocoa/NSColor+Hex.mm", "atom/browser/ui/cocoa/NSString+ANSI.h", "atom/browser/ui/cocoa/NSString+ANSI.mm", "atom/browser/ui/tray_icon_cocoa.mm", "docs/api/tray.md", "filenames.gypi", "script/cpplint.py"]
[OSX] Support ANSI color in the Tray menubar
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: all * Operating system: OSX ### Expected behavior The `setTitle()` method can support the ANSI colors <!-- What do you think should happen? --> ### Actual behavior The `setTitle()` method do not support the ANSI colors <!-- What actually happens? --> ### How to reproduce <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . -->
https://github.com/electron/electron/issues/11107
https://github.com/electron/electron/pull/11108
124667c29b249b5f79c57c8abbf2912157370cc7
d09e8cc37f485efd58d563e6315b38008527867c
2017-11-13T11:35:32Z
c++
2017-11-29T09:37:52Z
closed
electron/electron
https://github.com/electron/electron
11,101
["atom/common/atom_version.h", "script/bump-version.py", "spec/node-spec.js"]
process.versions does not include new version format
* Electron version: 1.8.2-beta.2 * Operating system: macOS ### Expected behavior process.versions should print `1.8.2-beta.2` for electron ### Actual behavior `1.8.2` is printed ### How to reproduce Use devtools and execute `process.versions`
https://github.com/electron/electron/issues/11101
https://github.com/electron/electron/pull/11103
58bd0986c8f1b30ee405f667c1c3297eafd9a13e
3a1106d0265ab7a91366dc9dcb7a883fb037c02b
2017-11-12T17:27:00Z
c++
2017-11-15T01:18:03Z
closed
electron/electron
https://github.com/electron/electron
11,098
["SECURITY.md", "docs/tutorial/security.md"]
Show actual settings in security documentation
https://github.com/electron/electron/blob/master/docs/tutorial/security.md This page tells a whole bunch of things to do in words but it would be infinitely more useful if it showed the code.
https://github.com/electron/electron/issues/11098
https://github.com/electron/electron/pull/11770
f24eab74d8c3e3c8b27d4c7f6aed359aaa6fe53b
67196bdd3ed49bd3fd3fe6fe89e52d0ee1d1dd74
2017-11-12T12:23:40Z
c++
2018-01-30T22:03:43Z
closed
electron/electron
https://github.com/electron/electron
11,084
["default_app/main.js"]
Electron v1.8.2-beta.2 --abi option disappear
* Electron version: electron v1.8.2-beta.2 * Operating system: macOS 10.13 $ electron --abi rebuilds some native module need to know this abi version.
https://github.com/electron/electron/issues/11084
https://github.com/electron/electron/pull/11087
a06a8a6f79795eaa9db8dc46cc148d06fbfd2431
40b94e97e5dfe8fe17ae8982ee52c1b3d2a702e2
2017-11-10T19:38:20Z
c++
2017-11-11T03:47:45Z
closed
electron/electron
https://github.com/electron/electron
11,075
["atom/browser/atom_permission_manager.cc", "atom/browser/atom_permission_manager.h", "atom/browser/atom_resource_dispatcher_host_delegate.cc", "atom/browser/web_contents_permission_helper.cc", "atom/browser/web_contents_permission_helper.h", "docs/api/session.md"]
feat: PermissionRequestHandler should be provided a url on openExternal
* Electron version: 1.7.9 * Operating system: macOS 10.12.6 ### Expected behavior Often Electron apps want to get in front of `openExternal` calls to prevent them, or display a "are you sure you want to open" dialog for possibly unsafe url schemes like `ssh://`. At the moment, you can either blanket deny these or allow all for a give host via a `permissionRequestHandler`. It would be helpful for the permission handler to be given the url that the window is attempting to navigate to better determine the action it should take. ``` $ git clone [email protected]:gerges/electron-quick-start.git -b feat/set-permission-handler-openexternal-url $ npm install $ npm run start ```
https://github.com/electron/electron/issues/11075
https://github.com/electron/electron/pull/11092
39ec40b90176f618d0c61d4e893dca0bac9d5afd
5a9221e1dcc730b6edde4c3844028abb1e8107f1
2017-11-09T19:05:24Z
c++
2017-12-20T03:56:00Z
closed
electron/electron
https://github.com/electron/electron
11,057
["docs/api/session.md", "package.json"]
No way to clear permission request handlers
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.8 * Operating system: All ### Expected behavior There should be an API to clear permission request handlers created using ```setPermissionRequestHandler```. <!-- What do you think should happen? --> ### Actual behavior There is no way to do this (as far as I can tell; let me know if I'm missing something). <!-- What actually happens? --> ### How to reproduce It would be really useful to have a ```session.clearPermissionRequestHandler``` API to go with ```setPermissionRequestHandler```. The use-case for this is that our web browser app (https://github.com/minbrowser/min) provides the ability to load webpages in a private tab, isolated from all other tabs. To do this, we randomly generate an ID for each new tab, and use that ID to set the partition of the webview. Then, we get the session that goes with the webview, and set the permission request handler by doing this: ``` remote.session.fromPartition(partition).setPermissionRequestHandler(pagePermissionRequestHandler) ``` The problem is that each added listener consumes additional memory, causing our app's memory usage to gradually increase each time a tab is created. After the tab has been closed, we don't use the session any more, so we should be able to just unregister the listener, but because there is no way to remove the handler, it sticks around consuming memory. I've personally seen our app's main process grow by hundreds of MB's after the app has been left open for a long time and a bunch of tabs have been created and destroyed. Would it be possible to add this? If it's relatively simple to do so, I could look into doing it myself, although I'm not very familiar with C++.
https://github.com/electron/electron/issues/11057
https://github.com/electron/electron/pull/11059
0711e1e5e197cc93cd1a04262e80b16d53b6e17d
596a61f1ad666091d3e987cdd3d76d872d709724
2017-11-08T04:15:18Z
c++
2017-11-21T00:50:17Z
closed
electron/electron
https://github.com/electron/electron
11,052
["lib/browser/api/menu.js", "spec/api-menu-spec.js"]
Exception with Menu.setApplicationMenu(null) since 1.8.2-beta.2
* Electron version: 1.8.2-beta.2 * Operating system: macOS 10.13.1 ### Expected behavior As per documentation `Menu.setApplicationMenu(null)` should remove menu bar in Windows/Linux and do nothing in macOS. ### Actual behavior Exception is thrown (starting with Electron 1.8.2-beta.2 version): ``` TypeError: Cannot read property 'constructor' of null at Function.Menu.setApplicationMenu (<hidden>/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/menu.js:136:21) at App._electron.app.on (<hidden>) at emitTwo (events.js:130:20) at App.emit (events.js:213:7) ``` ### How to reproduce Try calling static `Menu.setApplicationMenu(null)` from app `ready` event.
https://github.com/electron/electron/issues/11052
https://github.com/electron/electron/pull/11055
9291ab95dd55bfca1fe4b9350a6ba01e19bdc4a2
ba754cf5c3f36d66a3b23f409613a348bfa6b308
2017-11-07T20:02:19Z
c++
2017-11-11T03:33:18Z
closed
electron/electron
https://github.com/electron/electron
10,955
["docs/faq.md"]
No subpixel rendering on Linux
* Electron version: 1.7.9 * Operating system: Linux (same behavior on Arch and a fresh Ubuntu 17.04 install) ### Expected behavior Text is rendered with subpixel font antialiasing when that feature is enable at the OS level ### Actual behavior Electron uses greyscale font antialiasing no matter what: ![2017-10-23-130950_324x76_scrot](https://user-images.githubusercontent.com/30617489/31985527-44e89b66-b91a-11e7-970b-4993df129934.png) (on top is Electron 1.7.9, on the bottom, nwjs 0.26.0 (Chrome 62), purple border is a window manager border - these are running side-by-side on the same machine) Here's the pixel difference: ![2017-10-23-130950_324x76_scrot_diff](https://user-images.githubusercontent.com/30617489/32012206-fc530a9c-b96b-11e7-8dde-e820e59403f5.png) Instrumenting `atom/browser/native_window.cc` after line 88 shows that system-level font rendering settings are being picked up correctly (antialiasing is on, subpixel is set to RGB which is correct for my monitor, etc), indicating that the problem probably exists somewhere inside libchromiumcontent. Right now this is the only app on my systems affected this way, and it occurs on multiple machines and flavors of Linux. Significantly, installing a patched fontconfig/freetype/etc bundle (Infinality) has no effect on font rendering in Electron while working as expected everywhere else including Chromium. ### How to reproduce ``` $ git clone [email protected]:sorentycho/blackmirror.git $ npm install $ npm start || electron . ``` ...and then observe any text in the application.
https://github.com/electron/electron/issues/10955
https://github.com/electron/electron/pull/18101
0ab3d7a0beb99ae897ad5572cde490d2adc81e4e
e63f527e76719aaa6de5e2a9baf3981ef82123ea
2017-10-28T01:16:29Z
c++
2019-05-07T19:49:08Z
closed
electron/electron
https://github.com/electron/electron
10,940
["brightray/browser/mac/notification_center_delegate.mm"]
Notification onclick is triggered when clicking Close on alert Style MacOS High Sierra notification
* Electron version: 1.7.9 * Operating system: 10.13 High Sierra ### Expected behavior `Notification.onclick` should not be triggered when `Close` is clicked ### Actual behavior `Notification.onclick` is triggered when `Close` is clicked ![notification-triggers-click](https://user-images.githubusercontent.com/320654/32076487-c1d4f4ca-ba65-11e7-9986-873ea3bd60ef.gif) ### How to reproduce Enable alert style notifications for Electron in MacOS ``` $ git clone [email protected]:gerges/electron-quick-start.git -b issue/notification-close-triggers-click $ npm install $ npm run start ```
https://github.com/electron/electron/issues/10940
https://github.com/electron/electron/pull/10943
dc8b58336357b8d92153f103e894e6328e67d757
5c6d418b59182b1c4d42d674420fed3cf13786d7
2017-10-26T20:53:47Z
c++
2017-10-27T23:35:07Z
closed
electron/electron
https://github.com/electron/electron
10,921
["docs/api/browser-window.md", "spec/api-browser-view-spec.js"]
Reload BrowserView of window
electron 1.8.2. beta 2 osx 10.11.6 How is supposed to get the attached BrowserView of a window? Specially I would like to refresh the contents of the browser view in togehter with the window when I resize it. This is what I'm doing now: ``` menu.append(new MenuItem({ label: 'Apple MacBook', submenu: [{ label: 'MacBook', click() { var window = remote.getCurrentWindow(); window.setSize(1152, 761); window.setAspectRatio(16 / 10); document.getElementById("device").innerHTML = "Apple MacBook | 1152 x 720"; } }, { label: 'MacBook Air', click() { var window = remote.getCurrentWindow(); window.setSize(1440, 941); window.setAspectRatio(16 / 10); document.getElementById("device").innerHTML = "Apple MacBook Air | 1440 x 900"; } }, { label: 'MacBook Pro', click() { var window = remote.getCurrentWindow(); window.setSize(1440, 941); window.setAspectRatio(16 / 10); document.getElementById("device").innerHTML = "Apple MacBook Pro | 1440 x 900"; } }, ] })) ```
https://github.com/electron/electron/issues/10921
https://github.com/electron/electron/pull/10953
60f539789df8dcd8d7f9e477db0215f08a6b27f1
04cce89fdc3d5a07835e1d784eece9396418c058
2017-10-26T12:09:31Z
c++
2017-10-27T20:05:51Z
closed
electron/electron
https://github.com/electron/electron
10,877
["default_app/main.js"]
Electron 1.8.2 only runs 1 require script
* Electron version: 1.8.2 * Operating system: MacOS Git Repo to reproduce: https://github.com/dpgraham/electron-repro ### Description The command `electron -r ./a -r ./b main` is only running `./a.js` on Electron 1.8.2-beta.1 When the same command is run on Electron 1.7, all three (`./a.js`, `./b.js`, `./main.js`) are run (the three files all just run one console log with the name of the file) ### Expected behavior This is what happens with Electron 1.7 and Electron 1.8.1 ``` npm test ``` Output: ``` > electron -r ./a -r ./b main A B Main ``` ### Actual behavior This is what happens with Electron 1.8.2 ``` npm install electron@beta npm test ``` Output: ``` > electron -r ./a -r ./b main A ``` It never runs module b or main ### How to reproduce ``` git clone https://github.com/dpgraham/electron-repro cd electron-repro npm install npm test # Success with Electron 1.7 npm install electron@beta npm test # Fails with Electron 1.8.2 ```
https://github.com/electron/electron/issues/10877
https://github.com/electron/electron/pull/10900
36a51bbf4dc7d62324538b2e30bf6d8bbf162860
8d1ff1c59a1ce7dce986d772450d5e49f7593a5d
2017-10-23T04:24:52Z
c++
2017-10-25T00:21:08Z
closed
electron/electron
https://github.com/electron/electron
10,867
["docs/api/structures/web-request-filter.md", "shell/browser/api/electron_api_web_request.cc", "shell/browser/api/electron_api_web_request.h", "spec/api-web-request-spec.ts"]
Add types property to onHeaderReceived's filter parameter.
According to [this](https://developer.chrome.com/extensions/webRequest) page, the filter that gets passed to `onHeadersReceived` is a `RequestFilter`, which has a `types` property to allow filtering on resource types. Can this be added to electron's `onHeadersReceived` function, which according to [this](https://github.com/electron/electron/blob/master/docs/api/web-request.md), only supports the `urls` filter?
https://github.com/electron/electron/issues/10867
https://github.com/electron/electron/pull/30914
edf887bdc52bac4563ae3cba1bc02aa6d397d7ff
ed7b5c44a2c7bfd57a44a04891452e967f07dd8e
2017-10-20T21:46:05Z
c++
2023-02-27T19:16:59Z
closed
electron/electron
https://github.com/electron/electron
10,780
["Dockerfile.arm64", "Dockerfile.armv7", "atom/browser/ui/file_dialog_gtk.cc", "atom/browser/ui/message_box_gtk.cc", "atom/browser/ui/views/menu_bar.cc", "brightray/filename_rules.gypi", "docs/development/build-instructions-linux.md", "docs/tutorial/snapcraft.md", "script/cibuild"]
Fix GTK deprecation warnings
During upgrade to the Chromium 61 we have switched from GTK2 to GTK3 and now we have a few warnings about stuff being deprecated in GTK3. Check any Linux build to get a list of them. /cc @zcbenz
https://github.com/electron/electron/issues/10780
https://github.com/electron/electron/pull/11879
67fa13d7cf56b99d8c257f8b12ab7edae40629bf
78ccfa0612b50bd9c70b1f0932266416702a0563
2017-10-13T00:30:12Z
c++
2018-02-16T15:01:01Z
closed
electron/electron
https://github.com/electron/electron
10,775
["docs/api/browser-window.md"]
"paused" missing in possibleValues for setProgressBar in API doc
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.7.7 * Operating system: N/A ### Expected behavior electron.d.ts and electron-api.json should have "paused" as a possible value for mode passed to setProgressBar ### Actual behavior "paused" is not recognized. <!-- What actually happens? --> ### How to reproduce <!-- Your best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run. You can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes. If you provide a URL, please list the commands required to clone/setup/run your repo e.g. $ git clone $YOUR_URL -b $BRANCH $ npm install $ npm start || electron . --> Get electron-api.json and search for "setProgressBar"
https://github.com/electron/electron/issues/10775
https://github.com/electron/electron/pull/12428
22da843efab7dcd4a7f89246e0b7ebb08a3d1710
5f7c6ccfe43239a3d661821164066fdcd04ef5b9
2017-10-12T16:48:30Z
c++
2018-03-27T23:29:31Z
closed
electron/electron
https://github.com/electron/electron
10,747
["npm/install.js"]
Provide useful output when `npm install electron` takes too long.
On slow networks, `npm install electron` can take quite a while. We should display something useful to users as they wait for the download to complete, both to put them at ease that something is actually happening, but also to potentially add useful info while they wait. Some ideas: - A progress bar - Information: platform, architecture, download size, etc - recovery techniques if the installation fails - ProTips™ - other info? See also https://github.com/electron-userland/electron-prebuilt/issues/236, an issue opened by @MarshallOfSound that was closed when we retired electron-prebuilt. @bclicn articulated the problem well in https://github.com/electron/electron-quick-start/issues/127#issuecomment-326376235 > Since this project is mainly for luring people to use electron, adding a progress bar for npm install is vital. If I followed the guide of electron.atom.io, got stuck, retired several times, googled it, and ended up here with no official solution, then how many people do you think will just give up trying Electron then? This came up a lot today at the GitHub Universe Electron workshop. cc @hollenberry @nathos @codebytere
https://github.com/electron/electron/issues/10747
https://github.com/electron/electron/pull/10758
f2a1f0124dde415280556c39c4f69cb1e258ba3a
26220f2b31a0f4e8fe6c9137b3cbf7236e3ebe20
2017-10-11T01:13:44Z
c++
2017-10-11T22:18:11Z
closed
electron/electron
https://github.com/electron/electron
10,738
["docs/api/browser-window.md"]
Unreferenced link in BrowserWindow docs page
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.6.11 * Operating system: W10 X64 ### Expected behavior The link should be properly referneced. ### Actual behavior Link to Page Visibility API is not referenced correctly in https://github.com/electron/electron/blob/master/docs/api/browser-window.md#new-browserwindowoptions in the `backgroundThrottling` property. Should I send a PR ?
https://github.com/electron/electron/issues/10738
https://github.com/electron/electron/pull/11048
6b9e67c9729d7bbe43fd5016b492036258566d11
bf42426acc927601330f922fd030dc0a2574969c
2017-10-10T13:08:39Z
c++
2017-11-07T14:14:36Z
closed
electron/electron
https://github.com/electron/electron
10,722
["vendor/libchromiumcontent"]
Build fails when running on Windows 10, trying to build for x64 arch type
Trying to build electron from the master branch, the bootstrap.py command succeeds but build fails with this : ``` ninja: Entering directory `out\R' [938/1192] LINK_EMBED(DLL) node.dll FAILED: C:\Python27\python.exe gyp-win-tool link-with-manifests environment.x64 True node.dll "C:\Python27\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:node.dll.lib /DLL /OUT:node.dll @node.dll.rsp" 2 mt.exe rc.exe "obj\vendor\node\node.node.dll.intermediate.manifest" obj\vendor\node\node.node.dll.generated.manifest v8.lib(api.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance C:\Users\denimuser\playground\electron\vendor\download\libchromiumcontent\static_library\v8.lib : fatal error LNK1107: invalid or corrupt file: cannot read at 0x1260DFEC Traceback (most recent call last): File "gyp-win-tool", line 323, in <module> sys.exit(main(sys.argv[1:])) File "gyp-win-tool", line 29, in main exit_code = executor.Dispatch(args) File "gyp-win-tool", line 71, in Dispatch return getattr(self, method)(*args[1:]) File "gyp-win-tool", line 179, in ExecLinkWithManifests subprocess.check_call(ldcmd + add_to_ld) File "C:\Python27\lib\subprocess.py", line 186, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command 'C:\Python27\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:node.dll.lib /DLL /OUT:node.dll @node.dll.rsp node.dll.manifest.res' returned non-zero exit status 1107 [938/1192] CXX obj\atom\browser\api\electron_lib.atom_api_app.obj ninja: build stopped: subcommand failed. ``` I have node js and python 64 bit installed with Visual Studio 2015 update 3 x64 build. Any help is greatly appreciated.
https://github.com/electron/electron/issues/10722
https://github.com/electron/electron/pull/10759
88616df2e5c3e0d508081b03a1ad7c22504e6321
f2a1f0124dde415280556c39c4f69cb1e258ba3a
2017-10-09T12:51:34Z
c++
2017-10-11T19:37:02Z
closed
electron/electron
https://github.com/electron/electron
10,707
["atom/browser/native_window_mac.mm", "lib/browser/api/browser-window.js", "lib/browser/api/web-contents.js", "spec/api-browser-view-spec.js"]
window.open windows not visible when created from BrowserView with nativeWindowOpen enabled
* Electron version: 1.7.8 * Operating system: MacOS Sierra 10.12.6 ### Expected behavior The new window should be opened, and visible ### Actual behavior The new window is created, but it never becomes visible to the user. These windows can be accessed via the return of `window.open` and appear to be loading content internally. ### How to reproduce Example repo here: https://github.com/gerges/electron-quick-start/tree/issue/browser-view-native-window-open
https://github.com/electron/electron/issues/10707
https://github.com/electron/electron/pull/12686
23de301955be3b0cfe1b2015b37c64c80d9a992b
aafbd865bf45c26434ffc6e706fd47efd05e5289
2017-10-06T18:28:49Z
c++
2018-11-27T06:59:17Z
closed
electron/electron
https://github.com/electron/electron
10,697
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h"]
Electron crashes if user clicks Dev Tools & Zoom options
[Crash Dump.txt](https://github.com/electron/electron/files/1361356/Crash.Dump.txt) * Electron version: 1.7.8, 1.7.5 * Operating system: macOS, Windows 10 ### Expected behavior The app should zoom in or zoom out like how it does when the dev tools is not open. ### Actual behavior Electron Crashes and quits ### How to reproduce 1. Setup a sample Electron App 2. Make sure Zoom options and Toggle Dev Tools options are available 3. Start the app 4. Open Dev Tools using the menu or the keyboard shortcut 5. Zoom In or Zoom Out 6. Observe the crash that happens
https://github.com/electron/electron/issues/10697
https://github.com/electron/electron/pull/10873
306b62709017e12f6f4865e3d2b069cc7177db1f
67f0eb7b3b1913dd0a1175f9642ee4917a5426d3
2017-10-06T02:19:52Z
c++
2017-10-23T13:32:28Z
closed
electron/electron
https://github.com/electron/electron
10,685
["spec/api-browser-window-spec.js"]
Master tests failing on macOS
* Electron version: Master * Operating system: macOS / MAS Raising this in case I forget at some point 😆 Master tests have been failing on macOS and MAS since https://github.com/electron/electron/commit/745fa707dda6bd679ac91b7deb7e3d48a9c3b422
https://github.com/electron/electron/issues/10685
https://github.com/electron/electron/pull/10690
8c5bb5969cb7c65cede007de4e2e3c14daea0e06
2d269fb7f1990a3b82cfc1a586ec757074c0afa7
2017-10-04T04:26:19Z
c++
2017-10-04T18:29:38Z