status
stringclasses 1
value | repo_name
stringclasses 31
values | repo_url
stringclasses 31
values | issue_id
int64 1
104k
| title
stringlengths 4
233
| body
stringlengths 0
186k
⌀ | issue_url
stringlengths 38
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[us, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] | updated_file
stringlengths 7
188
| chunk_content
stringlengths 1
1.03M
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | ProcessInstanceMap instanceMap = findWorkProcessMapByParent(parentProcessInstance.getId(), task.getId());
if (null != instanceMap && CommandType.RECOVER_TOLERANCE_FAULT_PROCESS == parentProcessInstance.getCommandType()) {
return;
}
instanceMap = setProcessInstanceMap(parentProcessInstance, task);
ProcessInstance childInstance = null;
if (instanceMap.getProcessInstanceId() != 0) {
childInstance = findProcessInstanceById(instanceMap.getProcessInstanceId());
}
Command subProcessCommand = createSubProcessCommand(parentProcessInstance, childInstance, instanceMap, task);
updateSubProcessDefinitionByParent(parentProcessInstance, subProcessCommand.getProcessDefinitionCode());
initSubInstanceState(childInstance);
createCommand(subProcessCommand);
logger.info("sub process command created: {} ", subProcessCommand);
}
/**
* complement data needs transform parent parameter to child.
*/
protected String getSubWorkFlowParam(ProcessInstanceMap instanceMap, ProcessInstance parentProcessInstance, Map<String, String> fatherParams) {
String processMapStr = JSONUtils.toJsonString(instanceMap);
Map<String, String> cmdParam = JSONUtils.toMap(processMapStr);
if (parentProcessInstance.isComplementData()) {
Map<String, String> parentParam = JSONUtils.toMap(parentProcessInstance.getCommandParam());
String endTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE);
String startTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, endTime);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_START_DATE, startTime);
processMapStr = JSONUtils.toJsonString(cmdParam); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | }
if (fatherParams.size() != 0) {
cmdParam.put(CMD_PARAM_FATHER_PARAMS, JSONUtils.toJsonString(fatherParams));
processMapStr = JSONUtils.toJsonString(cmdParam);
}
return processMapStr;
}
@Override
public Map<String, String> getGlobalParamMap(String globalParams) {
List<Property> propList;
Map<String, String> globalParamMap = new HashMap<>();
if (StringUtils.isNotEmpty(globalParams)) {
propList = JSONUtils.toList(globalParams, Property.class);
globalParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue));
}
return globalParamMap;
}
/**
* create sub work process command
*/
@Override
public Command createSubProcessCommand(ProcessInstance parentProcessInstance,
ProcessInstance childInstance,
ProcessInstanceMap instanceMap,
TaskInstance task) {
CommandType commandType = getSubCommandType(parentProcessInstance, childInstance);
Map<String, Object> subProcessParam = JSONUtils.toMap(task.getTaskParams(), String.class, Object.class);
long childDefineCode = 0L;
if (subProcessParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE)) {
childDefineCode = NumberUtils.toLong(String.valueOf(subProcessParam.get(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE))); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | }
ProcessDefinition subProcessDefinition = processDefineMapper.queryByCode(childDefineCode);
Object localParams = subProcessParam.get(Constants.LOCAL_PARAMS);
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> globalMap = this.getGlobalParamMap(task.getVarPool());
Map<String, String> fatherParams = new HashMap<>();
if (CollectionUtils.isNotEmpty(allParam)) {
for (Property info : allParam) {
if (Direct.OUT == info.getDirect()) {
continue;
}
fatherParams.put(info.getProp(), globalMap.get(info.getProp()));
}
}
String processParam = getSubWorkFlowParam(instanceMap, parentProcessInstance, fatherParams);
int subProcessInstanceId = childInstance == null ? 0 : childInstance.getId();
return new Command(
commandType,
TaskDependType.TASK_POST,
parentProcessInstance.getFailureStrategy(),
parentProcessInstance.getExecutorId(),
subProcessDefinition.getCode(),
processParam,
parentProcessInstance.getWarningType(),
parentProcessInstance.getWarningGroupId(),
parentProcessInstance.getScheduleTime(),
task.getWorkerGroup(),
task.getEnvironmentCode(),
parentProcessInstance.getProcessInstancePriority(),
parentProcessInstance.getDryRun(), |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | subProcessInstanceId,
subProcessDefinition.getVersion()
);
}
/**
* initialize sub work flow state
* child instance state would be initialized when 'recovery from pause/stop/failure'
*/
private void initSubInstanceState(ProcessInstance childInstance) {
if (childInstance != null) {
childInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
updateProcessInstance(childInstance);
}
}
/**
* get sub work flow command type
* child instance exist: child command = fatherCommand
* child instance not exists: child command = fatherCommand[0]
*/
private CommandType getSubCommandType(ProcessInstance parentProcessInstance, ProcessInstance childInstance) {
CommandType commandType = parentProcessInstance.getCommandType();
if (childInstance == null) {
String fatherHistoryCommand = parentProcessInstance.getHistoryCmd();
commandType = CommandType.valueOf(fatherHistoryCommand.split(Constants.COMMA)[0]);
}
return commandType;
}
/**
* update sub process definition
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * @param parentProcessInstance parentProcessInstance
* @param childDefinitionCode childDefinitionId
*/
private void updateSubProcessDefinitionByParent(ProcessInstance parentProcessInstance, long childDefinitionCode) {
ProcessDefinition fatherDefinition = this.findProcessDefinition(parentProcessInstance.getProcessDefinitionCode(),
parentProcessInstance.getProcessDefinitionVersion());
ProcessDefinition childDefinition = this.findProcessDefinitionByCode(childDefinitionCode);
if (childDefinition != null && fatherDefinition != null) {
childDefinition.setWarningGroupId(fatherDefinition.getWarningGroupId());
processDefineMapper.updateById(childDefinition);
}
}
/**
* submit task to mysql
*
* @param taskInstance taskInstance
* @param processInstance processInstance
* @return task instance
*/
@Override
public TaskInstance submitTaskInstanceToDB(TaskInstance taskInstance, ProcessInstance processInstance) {
ExecutionStatus processInstanceState = processInstance.getState();
if (processInstanceState.typeIsFinished() || processInstanceState == ExecutionStatus.READY_STOP) {
logger.warn("processInstance {} was {}, skip submit task", processInstance.getProcessDefinitionCode(), processInstanceState);
return null;
}
if (processInstanceState == ExecutionStatus.READY_PAUSE) {
taskInstance.setState(ExecutionStatus.PAUSE);
}
taskInstance.setExecutorId(processInstance.getExecutorId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | taskInstance.setState(getSubmitTaskState(taskInstance, processInstance));
if (taskInstance.getSubmitTime() == null) {
taskInstance.setSubmitTime(new Date());
}
if (taskInstance.getFirstSubmitTime() == null) {
taskInstance.setFirstSubmitTime(taskInstance.getSubmitTime());
}
boolean saveResult = saveTaskInstance(taskInstance);
if (!saveResult) {
return null;
}
return taskInstance;
}
/**
* get submit task instance state by the work process state
* cannot modify the task state when running/kill/submit success, or this
* task instance is already exists in task queue .
* return pause if work process state is ready pause
* return stop if work process state is ready stop
* if all of above are not satisfied, return submit success
*
* @param taskInstance taskInstance
* @param processInstance processInstance
* @return process instance state
*/
@Override
public ExecutionStatus getSubmitTaskState(TaskInstance taskInstance, ProcessInstance processInstance) {
ExecutionStatus state = taskInstance.getState(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | if (
state == ExecutionStatus.RUNNING_EXECUTION
|| state == ExecutionStatus.DELAY_EXECUTION
|| state == ExecutionStatus.KILL
|| state == ExecutionStatus.DISPATCH
) {
return state;
}
if (processInstance.getState() == ExecutionStatus.READY_PAUSE) {
state = ExecutionStatus.PAUSE;
} else if (processInstance.getState() == ExecutionStatus.READY_STOP
|| !checkProcessStrategy(taskInstance, processInstance)) {
state = ExecutionStatus.KILL;
} else {
state = ExecutionStatus.SUBMITTED_SUCCESS;
}
return state;
}
/**
* check process instance strategy
*
* @param taskInstance taskInstance
* @return check strategy result
*/
private boolean checkProcessStrategy(TaskInstance taskInstance, ProcessInstance processInstance) {
FailureStrategy failureStrategy = processInstance.getFailureStrategy();
if (failureStrategy == FailureStrategy.CONTINUE) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | return true;
}
List<TaskInstance> taskInstances = this.findValidTaskListByProcessId(taskInstance.getProcessInstanceId());
for (TaskInstance task : taskInstances) {
if (task.getState() == ExecutionStatus.FAILURE
&& task.getRetryTimes() >= task.getMaxRetryTimes()) {
return false;
}
}
return true;
}
/**
* insert or update work process instance to data base
*
* @param processInstance processInstance
*/
@Override
public void saveProcessInstance(ProcessInstance processInstance) {
if (processInstance == null) {
logger.error("save error, process instance is null!");
return;
}
if (processInstance.getId() != 0) {
processInstanceMapper.updateById(processInstance);
} else {
processInstanceMapper.insert(processInstance);
}
}
/**
* insert or update command |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | *
* @param command command
* @return save command result
*/
@Override
public int saveCommand(Command command) {
if (command.getId() != 0) {
return commandMapper.updateById(command);
} else {
return commandMapper.insert(command);
}
}
/**
* insert or update task instance
*
* @param taskInstance taskInstance
* @return save task instance result
*/
@Override
public boolean saveTaskInstance(TaskInstance taskInstance) {
if (taskInstance.getId() != 0) {
return updateTaskInstance(taskInstance);
} else {
return createTaskInstance(taskInstance);
}
}
/**
* insert task instance
*
* @param taskInstance taskInstance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * @return create task instance result
*/
@Override
public boolean createTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.insert(taskInstance);
return count > 0;
}
/**
* update task instance
*
* @param taskInstance taskInstance
* @return update task instance result
*/
@Override
public boolean updateTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.updateById(taskInstance);
return count > 0;
}
/**
* find task instance by id
*
* @param taskId task id
* @return task instance
*/
@Override
public TaskInstance findTaskInstanceById(Integer taskId) {
return taskInstanceMapper.selectById(taskId);
}
/**
* find task instance list by id list |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | *
* @param idList task id list
* @return task instance list
*/
@Override
public List<TaskInstance> findTaskInstanceByIdList(List<Integer> idList) {
if (CollectionUtils.isEmpty(idList)) {
return new ArrayList<>();
}
return taskInstanceMapper.selectBatchIds(idList);
}
/**
* package task instance
*/
@Override
public void packageTaskInstance(TaskInstance taskInstance, ProcessInstance processInstance) {
taskInstance.setProcessInstance(processInstance);
taskInstance.setProcessDefine(processInstance.getProcessDefinition());
taskInstance.setProcessInstancePriority(processInstance.getProcessInstancePriority());
TaskDefinition taskDefinition = this.findTaskDefinition(
taskInstance.getTaskCode(),
taskInstance.getTaskDefinitionVersion());
this.updateTaskDefinitionResources(taskDefinition);
taskInstance.setTaskDefine(taskDefinition);
}
/**
* Update {@link ResourceInfo} information in {@link TaskDefinition}
*
* @param taskDefinition the given {@link TaskDefinition}
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | @Override
public void updateTaskDefinitionResources(TaskDefinition taskDefinition) {
Map<String, Object> taskParameters = JSONUtils.parseObject(
taskDefinition.getTaskParams(),
new TypeReference<Map<String, Object>>() {
});
if (taskParameters != null) {
if (taskParameters.containsKey("mainJar")) {
Object mainJarObj = taskParameters.get("mainJar");
ResourceInfo mainJar = JSONUtils.parseObject(
JSONUtils.toJsonString(mainJarObj),
ResourceInfo.class);
ResourceInfo resourceInfo = updateResourceInfo(mainJar);
if (resourceInfo != null) {
taskParameters.put("mainJar", resourceInfo);
}
}
if (taskParameters.containsKey("resourceList")) {
String resourceListStr = JSONUtils.toJsonString(taskParameters.get("resourceList"));
List<ResourceInfo> resourceInfos = JSONUtils.toList(resourceListStr, ResourceInfo.class);
List<ResourceInfo> updatedResourceInfos = resourceInfos
.stream()
.map(this::updateResourceInfo)
.filter(Objects::nonNull)
.collect(Collectors.toList());
taskParameters.put("resourceList", updatedResourceInfos);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | taskDefinition.setTaskParams(JSONUtils.toJsonString(taskParameters));
}
}
/**
* update {@link ResourceInfo} by given original ResourceInfo
*
* @param res origin resource info
* @return {@link ResourceInfo}
*/
private ResourceInfo updateResourceInfo(ResourceInfo res) {
ResourceInfo resourceInfo = null;
if (res != null) {
int resourceId = res.getId();
if (resourceId <= 0) {
logger.error("invalid resourceId, {}", resourceId);
return null;
}
resourceInfo = new ResourceInfo();
Resource resource = getResourceById(resourceId);
resourceInfo.setId(resourceId);
resourceInfo.setRes(resource.getFileName());
resourceInfo.setResourceName(resource.getFullName());
if (logger.isInfoEnabled()) {
logger.info("updated resource info {}",
JSONUtils.toJsonString(resourceInfo));
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | return resourceInfo;
}
/**
* get id list by task state
*
* @param instanceId instanceId
* @param state state
* @return task instance states
*/
@Override
public List<Integer> findTaskIdByInstanceState(int instanceId, ExecutionStatus state) {
return taskInstanceMapper.queryTaskByProcessIdAndState(instanceId, state.ordinal());
}
/**
* find valid task list by process definition id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
@Override
public List<TaskInstance> findValidTaskListByProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.YES);
}
/**
* find previous task list by work process id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | public List<TaskInstance> findPreviousTaskListByWorkProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.NO);
}
/**
* update work process instance map
*
* @param processInstanceMap processInstanceMap
* @return update process instance result
*/
@Override
public int updateWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
return processInstanceMapMapper.updateById(processInstanceMap);
}
/**
* create work process instance map
*
* @param processInstanceMap processInstanceMap
* @return create process instance result
*/
@Override
public int createWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
int count = 0;
if (processInstanceMap != null) {
return processInstanceMapMapper.insert(processInstanceMap);
}
return count;
}
/**
* find work process map by parent process id and parent task id.
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * @param parentWorkProcessId parentWorkProcessId
* @param parentTaskId parentTaskId
* @return process instance map
*/
@Override
public ProcessInstanceMap findWorkProcessMapByParent(Integer parentWorkProcessId, Integer parentTaskId) {
return processInstanceMapMapper.queryByParentId(parentWorkProcessId, parentTaskId);
}
/**
* delete work process map by parent process id
*
* @param parentWorkProcessId parentWorkProcessId
* @return delete process map result
*/
@Override
public int deleteWorkProcessMapByParentId(int parentWorkProcessId) {
return processInstanceMapMapper.deleteByParentProcessId(parentWorkProcessId);
}
/**
* find sub process instance
*
* @param parentProcessId parentProcessId
* @param parentTaskId parentTaskId
* @return process instance
*/
@Override
public ProcessInstance findSubProcessInstance(Integer parentProcessId, Integer parentTaskId) {
ProcessInstance processInstance = null;
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryByParentId(parentProcessId, parentTaskId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getProcessInstanceId());
return processInstance;
}
/**
* find parent process instance
*
* @param subProcessId subProcessId
* @return process instance
*/
@Override
public ProcessInstance findParentProcessInstance(Integer subProcessId) {
ProcessInstance processInstance = null;
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(subProcessId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
return processInstance;
}
/**
* update process instance
*
* @param processInstance processInstance
* @return update process instance result
*/
@Override
public int updateProcessInstance(ProcessInstance processInstance) {
return processInstanceMapper.updateById(processInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | }
/**
* for show in page of taskInstance
*/
@Override
public void changeOutParam(TaskInstance taskInstance) {
if (StringUtils.isEmpty(taskInstance.getVarPool())) {
return;
}
List<Property> properties = JSONUtils.toList(taskInstance.getVarPool(), Property.class);
if (CollectionUtils.isEmpty(properties)) {
return;
}
Map<String, Object> taskParams = JSONUtils.parseObject(taskInstance.getTaskParams(), new TypeReference<Map<String, Object>>() {
});
Object localParams = taskParams.get(LOCAL_PARAMS);
if (localParams == null) {
return;
}
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> outProperty = new HashMap<>();
for (Property info : properties) {
if (info.getDirect() == Direct.OUT) {
outProperty.put(info.getProp(), info.getValue());
}
}
for (Property info : allParam) {
if (info.getDirect() == Direct.OUT) {
String paramName = info.getProp(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | info.setValue(outProperty.get(paramName));
}
}
taskParams.put(LOCAL_PARAMS, allParam);
taskInstance.setTaskParams(JSONUtils.toJsonString(taskParams));
}
/**
* convert integer list to string list
*
* @param intList intList
* @return string list
*/
@Override
public List<String> convertIntListToString(List<Integer> intList) {
if (intList == null) {
return new ArrayList<>();
}
List<String> result = new ArrayList<>(intList.size());
for (Integer intVar : intList) {
result.add(String.valueOf(intVar));
}
return result;
}
/**
* query schedule by id
*
* @param id id
* @return schedule
*/
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | public Schedule querySchedule(int id) {
return scheduleMapper.selectById(id);
}
/**
* query Schedule by processDefinitionCode
*
* @param processDefinitionCode processDefinitionCode
* @see Schedule
*/
@Override
public List<Schedule> queryReleaseSchedulerListByProcessDefinitionCode(long processDefinitionCode) {
return scheduleMapper.queryReleaseSchedulerListByProcessDefinitionCode(processDefinitionCode);
}
/**
* query Schedule by processDefinitionCode
*
* @param processDefinitionCodeList processDefinitionCodeList
* @see Schedule
*/
@Override
public Map<Long, String> queryWorkerGroupByProcessDefinitionCodes(List<Long> processDefinitionCodeList) {
List<Schedule> processDefinitionScheduleList = scheduleMapper.querySchedulesByProcessDefinitionCodes(processDefinitionCodeList);
return processDefinitionScheduleList.stream().collect(Collectors.toMap(Schedule::getProcessDefinitionCode,
Schedule::getWorkerGroup));
}
/**
* query dependent process definition by process definition code
*
* @param processDefinitionCode processDefinitionCode
* @see DependentProcessDefinition |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | */
@Override
public List<DependentProcessDefinition> queryDependentProcessDefinitionByProcessDefinitionCode(long processDefinitionCode) {
return workFlowLineageMapper.queryDependentProcessDefinitionByProcessDefinitionCode(processDefinitionCode);
}
/**
* query need failover process instance
*
* @param host host
* @return process instance list
*/
@Override
public List<ProcessInstance> queryNeedFailoverProcessInstances(String host) {
return processInstanceMapper.queryByHostAndStatus(host, stateArray);
}
@Override
public List<String> queryNeedFailoverProcessInstanceHost() {
return processInstanceMapper.queryNeedFailoverProcessInstanceHost(stateArray);
}
/**
* process need failover process instance
*
* @param processInstance processInstance
*/
@Override
@Transactional(rollbackFor = RuntimeException.class)
public void processNeedFailoverProcessInstances(ProcessInstance processInstance) {
processInstance.setHost(Constants.NULL);
processInstanceMapper.updateById(processInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | ProcessDefinition processDefinition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
Command cmd = new Command();
cmd.setProcessDefinitionCode(processDefinition.getCode());
cmd.setProcessDefinitionVersion(processDefinition.getVersion());
cmd.setProcessInstanceId(processInstance.getId());
cmd.setCommandParam(String.format("{\"%s\":%d}", Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING, processInstance.getId()));
cmd.setExecutorId(processInstance.getExecutorId());
cmd.setCommandType(CommandType.RECOVER_TOLERANCE_FAULT_PROCESS);
createCommand(cmd);
}
/**
* query all need failover task instances by host
*
* @param host host
* @return task instance list
*/
@Override
public List<TaskInstance> queryNeedFailoverTaskInstances(String host) {
return taskInstanceMapper.queryByHostAndStatus(host,
stateArray);
}
/**
* find data source by id
*
* @param id id
* @return datasource
*/
@Override
public DataSource findDataSourceById(int id) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | return dataSourceMapper.selectById(id);
}
/**
* update process instance state by id
*
* @param processInstanceId processInstanceId
* @param executionStatus executionStatus
* @return update process result
*/
@Override
public int updateProcessInstanceState(Integer processInstanceId, ExecutionStatus executionStatus) {
ProcessInstance instance = processInstanceMapper.selectById(processInstanceId);
instance.setState(executionStatus);
return processInstanceMapper.updateById(instance);
}
/**
* find process instance by the task id
*
* @param taskId taskId
* @return process instance
*/
@Override
public ProcessInstance findProcessInstanceByTaskId(int taskId) {
TaskInstance taskInstance = taskInstanceMapper.selectById(taskId);
if (taskInstance != null) {
return processInstanceMapper.selectById(taskInstance.getProcessInstanceId());
}
return null;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * find udf function list by id list string
*
* @param ids ids
* @return udf function list
*/
@Override
public List<UdfFunc> queryUdfFunListByIds(Integer[] ids) {
return udfFuncMapper.queryUdfByIdStr(ids, null);
}
/**
* find tenant code by resource name
*
* @param resName resource name
* @param resourceType resource type
* @return tenant code
*/
@Override
public String queryTenantCodeByResName(String resName, ResourceType resourceType) {
String fullName = resName.startsWith("/") ? resName : String.format("/%s", resName);
List<Resource> resourceList = resourceMapper.queryResource(fullName, resourceType.ordinal());
if (CollectionUtils.isEmpty(resourceList)) {
return StringUtils.EMPTY;
}
int userId = resourceList.get(0).getUserId();
User user = userMapper.selectById(userId);
if (Objects.isNull(user)) {
return StringUtils.EMPTY;
}
Tenant tenant = tenantMapper.queryById(user.getTenantId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | if (Objects.isNull(tenant)) {
return StringUtils.EMPTY;
}
return tenant.getTenantCode();
}
/**
* find schedule list by process define codes.
*
* @param codes codes
* @return schedule list
*/
@Override
public List<Schedule> selectAllByProcessDefineCode(long[] codes) {
return scheduleMapper.selectAllByProcessDefineArray(codes);
}
/**
* find last scheduler process instance in the date interval
*
* @param definitionCode definitionCode
* @param dateInterval dateInterval
* @return process instance
*/
@Override
public ProcessInstance findLastSchedulerProcessInterval(Long definitionCode, DateInterval dateInterval) {
return processInstanceMapper.queryLastSchedulerProcess(definitionCode,
dateInterval.getStartTime(),
dateInterval.getEndTime());
}
/**
* find last manual process instance interval |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | *
* @param definitionCode process definition code
* @param dateInterval dateInterval
* @return process instance
*/
@Override
public ProcessInstance findLastManualProcessInterval(Long definitionCode, DateInterval dateInterval) {
return processInstanceMapper.queryLastManualProcess(definitionCode,
dateInterval.getStartTime(),
dateInterval.getEndTime());
}
/**
* find last running process instance
*
* @param definitionCode process definition code
* @param startTime start time
* @param endTime end time
* @return process instance
*/
@Override
public ProcessInstance findLastRunningProcess(Long definitionCode, Date startTime, Date endTime) {
return processInstanceMapper.queryLastRunningProcess(definitionCode,
startTime,
endTime,
stateArray);
}
/**
* query user queue by process instance
*
* @param processInstance processInstance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * @return queue
*/
@Override
public String queryUserQueueByProcessInstance(ProcessInstance processInstance) {
String queue = "";
if (processInstance == null) {
return queue;
}
User executor = userMapper.selectById(processInstance.getExecutorId());
if (executor != null) {
queue = executor.getQueue();
}
return queue;
}
/**
* query project name and user name by processInstanceId.
*
* @param processInstanceId processInstanceId
* @return projectName and userName
*/
@Override
public ProjectUser queryProjectWithUserByProcessInstanceId(int processInstanceId) {
return projectMapper.queryProjectWithUserByProcessInstanceId(processInstanceId);
}
/**
* get task worker group
*
* @param taskInstance taskInstance
* @return workerGroupId
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | @Override
public String getTaskWorkerGroup(TaskInstance taskInstance) {
String workerGroup = taskInstance.getWorkerGroup();
if (StringUtils.isNotBlank(workerGroup)) {
return workerGroup;
}
int processInstanceId = taskInstance.getProcessInstanceId();
ProcessInstance processInstance = findProcessInstanceById(processInstanceId);
if (processInstance != null) {
return processInstance.getWorkerGroup();
}
logger.info("task : {} will use default worker group", taskInstance.getId());
return Constants.DEFAULT_WORKER_GROUP;
}
/**
* get have perm project list
*
* @param userId userId
* @return project list
*/
@Override
public List<Project> getProjectListHavePerm(int userId) {
List<Project> createProjects = projectMapper.queryProjectCreatedByUser(userId);
List<Project> authedProjects = projectMapper.queryAuthedProjectListByUserId(userId);
if (createProjects == null) {
createProjects = new ArrayList<>();
}
if (authedProjects != null) {
createProjects.addAll(authedProjects);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | return createProjects;
}
/**
* list unauthorized udf function
*
* @param userId user id
* @param needChecks data source id array
* @return unauthorized udf function list
*/
@Override
public <T> List<T> listUnauthorized(int userId, T[] needChecks, AuthorizationType authorizationType) {
List<T> resultList = new ArrayList<>();
if (Objects.nonNull(needChecks) && needChecks.length > 0) {
Set<T> originResSet = new HashSet<>(Arrays.asList(needChecks));
switch (authorizationType) {
case RESOURCE_FILE_ID:
case UDF_FILE:
List<Resource> ownUdfResources = resourceMapper.listAuthorizedResourceById(userId, needChecks);
addAuthorizedResources(ownUdfResources, userId);
Set<Integer> authorizedResourceFiles = ownUdfResources.stream().map(Resource::getId).collect(toSet());
originResSet.removeAll(authorizedResourceFiles);
break;
case RESOURCE_FILE_NAME:
List<Resource> ownResources = resourceMapper.listAuthorizedResource(userId, needChecks);
addAuthorizedResources(ownResources, userId);
Set<String> authorizedResources = ownResources.stream().map(Resource::getFullName).collect(toSet());
originResSet.removeAll(authorizedResources);
break;
case DATASOURCE:
Set<Integer> authorizedDatasources = dataSourceMapper.listAuthorizedDataSource(userId, needChecks).stream().map(DataSource::getId).collect(toSet()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | originResSet.removeAll(authorizedDatasources);
break;
case UDF:
Set<Integer> authorizedUdfs = udfFuncMapper.listAuthorizedUdfFunc(userId, needChecks).stream().map(UdfFunc::getId).collect(toSet());
originResSet.removeAll(authorizedUdfs);
break;
default:
break;
}
resultList.addAll(originResSet);
}
return resultList;
}
/**
* get user by user id
*
* @param userId user id
* @return User
*/
@Override
public User getUserById(int userId) {
return userMapper.selectById(userId);
}
/**
* get resource by resource id
*
* @param resourceId resource id
* @return Resource
*/
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | public Resource getResourceById(int resourceId) {
return resourceMapper.selectById(resourceId);
}
/**
* list resources by ids
*
* @param resIds resIds
* @return resource list
*/
@Override
public List<Resource> listResourceByIds(Integer[] resIds) {
return resourceMapper.listResourceByIds(resIds);
}
/**
* format task app id in task instance
*/
@Override
public String formatTaskAppId(TaskInstance taskInstance) {
ProcessInstance processInstance = findProcessInstanceById(taskInstance.getProcessInstanceId());
if (processInstance == null) {
return "";
}
ProcessDefinition definition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
if (definition == null) {
return "";
}
return String.format("%s_%s_%s", definition.getId(), processInstance.getId(), taskInstance.getId());
}
/**
* switch process definition version to process definition log version |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | */
@Override
public int switchVersion(ProcessDefinition processDefinition, ProcessDefinitionLog processDefinitionLog) {
if (null == processDefinition || null == processDefinitionLog) {
return Constants.DEFINITION_FAILURE;
}
processDefinitionLog.setId(processDefinition.getId());
processDefinitionLog.setReleaseState(ReleaseState.OFFLINE);
processDefinitionLog.setFlag(Flag.YES);
int result = processDefineMapper.updateById(processDefinitionLog);
if (result > 0) {
result = switchProcessTaskRelationVersion(processDefinitionLog);
if (result <= 0) {
return Constants.EXIT_CODE_FAILURE;
}
}
return result;
}
@Override
public int switchProcessTaskRelationVersion(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
if (!processTaskRelationList.isEmpty()) {
processTaskRelationMapper.deleteByCode(processDefinition.getProjectCode(), processDefinition.getCode());
}
List<ProcessTaskRelationLog> processTaskRelationLogList = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion());
int batchInsert = processTaskRelationMapper.batchInsert(processTaskRelationLogList);
if (batchInsert == 0) {
return Constants.EXIT_CODE_FAILURE;
} else {
int result = 0; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | for (ProcessTaskRelationLog taskRelationLog : processTaskRelationLogList) {
int switchResult = switchTaskDefinitionVersion(taskRelationLog.getPostTaskCode(), taskRelationLog.getPostTaskVersion());
if (switchResult != Constants.EXIT_CODE_FAILURE) {
result++;
}
}
return result;
}
}
@Override
public int switchTaskDefinitionVersion(long taskCode, int taskVersion) {
TaskDefinition taskDefinition = taskDefinitionMapper.queryByCode(taskCode);
if (taskDefinition == null) {
return Constants.EXIT_CODE_FAILURE;
}
if (taskDefinition.getVersion() == taskVersion) {
return Constants.EXIT_CODE_SUCCESS;
}
TaskDefinitionLog taskDefinitionUpdate = taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, taskVersion);
if (taskDefinitionUpdate == null) {
return Constants.EXIT_CODE_FAILURE;
}
taskDefinitionUpdate.setUpdateTime(new Date());
taskDefinitionUpdate.setId(taskDefinition.getId());
return taskDefinitionMapper.updateById(taskDefinitionUpdate);
}
/**
* get resource ids
*
* @param taskDefinition taskDefinition |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * @return resource ids
*/
@Override
public String getResourceIds(TaskDefinition taskDefinition) {
Set<Integer> resourceIds = null;
AbstractParameters params = taskPluginManager.getParameters(ParametersNode.builder().taskType(taskDefinition.getTaskType()).taskParams(taskDefinition.getTaskParams()).build());
if (params != null && CollectionUtils.isNotEmpty(params.getResourceFilesList())) {
resourceIds = params.getResourceFilesList().
stream()
.filter(t -> t.getId() != 0)
.map(ResourceInfo::getId)
.collect(toSet());
}
if (CollectionUtils.isEmpty(resourceIds)) {
return StringUtils.EMPTY;
}
return StringUtils.join(resourceIds, ",");
}
@Override
public int saveTaskDefine(User operator, long projectCode, List<TaskDefinitionLog> taskDefinitionLogs, Boolean syncDefine) {
Date now = new Date();
List<TaskDefinitionLog> newTaskDefinitionLogs = new ArrayList<>();
List<TaskDefinitionLog> updateTaskDefinitionLogs = new ArrayList<>();
for (TaskDefinitionLog taskDefinitionLog : taskDefinitionLogs) {
taskDefinitionLog.setProjectCode(projectCode);
taskDefinitionLog.setUpdateTime(now);
taskDefinitionLog.setOperateTime(now);
taskDefinitionLog.setOperator(operator.getId());
taskDefinitionLog.setResourceIds(getResourceIds(taskDefinitionLog));
if (taskDefinitionLog.getCode() == 0) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | try {
taskDefinitionLog.setCode(CodeGenerateUtils.getInstance().genCode());
} catch (CodeGenerateException e) {
logger.error("Task code get error, ", e);
return Constants.DEFINITION_FAILURE;
}
}
if (taskDefinitionLog.getVersion() == 0) {
taskDefinitionLog.setVersion(Constants.VERSION_FIRST);
}
TaskDefinitionLog definitionCodeAndVersion = taskDefinitionLogMapper
.queryByDefinitionCodeAndVersion(taskDefinitionLog.getCode(), taskDefinitionLog.getVersion());
if (definitionCodeAndVersion == null) {
taskDefinitionLog.setUserId(operator.getId());
taskDefinitionLog.setCreateTime(now);
newTaskDefinitionLogs.add(taskDefinitionLog);
continue;
}
if (taskDefinitionLog.equals(definitionCodeAndVersion)) {
continue;
}
taskDefinitionLog.setUserId(definitionCodeAndVersion.getUserId());
Integer version = taskDefinitionLogMapper.queryMaxVersionForDefinition(taskDefinitionLog.getCode());
taskDefinitionLog.setVersion(version + 1);
taskDefinitionLog.setCreateTime(definitionCodeAndVersion.getCreateTime());
updateTaskDefinitionLogs.add(taskDefinitionLog);
}
int insertResult = 0; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | int updateResult = 0;
for (TaskDefinitionLog taskDefinitionToUpdate : updateTaskDefinitionLogs) {
TaskDefinition task = taskDefinitionMapper.queryByCode(taskDefinitionToUpdate.getCode());
if (task == null) {
newTaskDefinitionLogs.add(taskDefinitionToUpdate);
} else {
insertResult += taskDefinitionLogMapper.insert(taskDefinitionToUpdate);
if (Boolean.TRUE.equals(syncDefine)) {
taskDefinitionToUpdate.setId(task.getId());
updateResult += taskDefinitionMapper.updateById(taskDefinitionToUpdate);
} else {
updateResult++;
}
}
}
if (!newTaskDefinitionLogs.isEmpty()) {
insertResult += taskDefinitionLogMapper.batchInsert(newTaskDefinitionLogs);
if (Boolean.TRUE.equals(syncDefine)) {
updateResult += taskDefinitionMapper.batchInsert(newTaskDefinitionLogs);
} else {
updateResult += newTaskDefinitionLogs.size();
}
}
return (insertResult & updateResult) > 0 ? 1 : Constants.EXIT_CODE_SUCCESS;
}
/**
* save processDefinition (including create or update processDefinition)
*/
@Override
public int saveProcessDefine(User operator, ProcessDefinition processDefinition, Boolean syncDefine, Boolean isFromProcessDefine) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | ProcessDefinitionLog processDefinitionLog = new ProcessDefinitionLog(processDefinition);
Integer version = processDefineLogMapper.queryMaxVersionForDefinition(processDefinition.getCode());
int insertVersion = version == null || version == 0 ? Constants.VERSION_FIRST : version + 1;
processDefinitionLog.setVersion(insertVersion);
processDefinitionLog.setReleaseState(!isFromProcessDefine || processDefinitionLog.getReleaseState() == ReleaseState.ONLINE ? ReleaseState.ONLINE : ReleaseState.OFFLINE);
processDefinitionLog.setOperator(operator.getId());
processDefinitionLog.setOperateTime(processDefinition.getUpdateTime());
int insertLog = processDefineLogMapper.insert(processDefinitionLog);
int result = 1;
if (Boolean.TRUE.equals(syncDefine)) {
if (0 == processDefinition.getId()) {
result = processDefineMapper.insert(processDefinitionLog);
} else {
processDefinitionLog.setId(processDefinition.getId());
result = processDefineMapper.updateById(processDefinitionLog);
}
}
return (insertLog & result) > 0 ? insertVersion : 0;
}
/**
* save task relations
*/
@Override
public int saveTaskRelation(User operator, long projectCode, long processDefinitionCode, int processDefinitionVersion,
List<ProcessTaskRelationLog> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs,
Boolean syncDefine) {
if (taskRelationList.isEmpty()) {
return Constants.EXIT_CODE_SUCCESS;
}
Map<Long, TaskDefinitionLog> taskDefinitionLogMap = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | if (CollectionUtils.isNotEmpty(taskDefinitionLogs)) {
taskDefinitionLogMap = taskDefinitionLogs.stream()
.collect(Collectors.toMap(TaskDefinition::getCode, taskDefinitionLog -> taskDefinitionLog));
}
Date now = new Date();
for (ProcessTaskRelationLog processTaskRelationLog : taskRelationList) {
processTaskRelationLog.setProjectCode(projectCode);
processTaskRelationLog.setProcessDefinitionCode(processDefinitionCode);
processTaskRelationLog.setProcessDefinitionVersion(processDefinitionVersion);
if (taskDefinitionLogMap != null) {
TaskDefinitionLog preTaskDefinitionLog = taskDefinitionLogMap.get(processTaskRelationLog.getPreTaskCode());
if (preTaskDefinitionLog != null) {
processTaskRelationLog.setPreTaskVersion(preTaskDefinitionLog.getVersion());
}
TaskDefinitionLog postTaskDefinitionLog = taskDefinitionLogMap.get(processTaskRelationLog.getPostTaskCode());
if (postTaskDefinitionLog != null) {
processTaskRelationLog.setPostTaskVersion(postTaskDefinitionLog.getVersion());
}
}
processTaskRelationLog.setCreateTime(now);
processTaskRelationLog.setUpdateTime(now);
processTaskRelationLog.setOperator(operator.getId());
processTaskRelationLog.setOperateTime(now);
}
int insert = taskRelationList.size();
if (Boolean.TRUE.equals(syncDefine)) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode);
if (!processTaskRelationList.isEmpty()) {
Set<Integer> processTaskRelationSet = processTaskRelationList.stream().map(ProcessTaskRelation::hashCode).collect(toSet());
Set<Integer> taskRelationSet = taskRelationList.stream().map(ProcessTaskRelationLog::hashCode).collect(toSet()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | boolean result = CollectionUtils.isEqualCollection(processTaskRelationSet, taskRelationSet);
if (result) {
return Constants.EXIT_CODE_SUCCESS;
}
processTaskRelationMapper.deleteByCode(projectCode, processDefinitionCode);
}
insert = processTaskRelationMapper.batchInsert(taskRelationList);
}
int resultLog = processTaskRelationLogMapper.batchInsert(taskRelationList);
return (insert & resultLog) > 0 ? Constants.EXIT_CODE_SUCCESS : Constants.EXIT_CODE_FAILURE;
}
@Override
public boolean isTaskOnline(long taskCode) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByTaskCode(taskCode);
if (!processTaskRelationList.isEmpty()) {
Set<Long> processDefinitionCodes = processTaskRelationList
.stream()
.map(ProcessTaskRelation::getProcessDefinitionCode)
.collect(toSet());
List<ProcessDefinition> processDefinitionList = processDefineMapper.queryByCodes(processDefinitionCodes);
for (ProcessDefinition processDefinition : processDefinitionList) {
if (processDefinition.getReleaseState() == ReleaseState.ONLINE) {
return true;
}
}
}
return false;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | * Generate the DAG Graph based on the process definition id
* Use temporarily before refactoring taskNode
*
* @param processDefinition process definition
* @return dag graph
*/
@Override
public DAG<String, TaskNode, TaskNodeRelation> genDagGraph(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> taskRelations = this.findRelationByCode(processDefinition.getCode(), processDefinition.getVersion());
List<TaskNode> taskNodeList = transformTask(taskRelations, Lists.newArrayList());
ProcessDag processDag = DagHelper.getProcessDag(taskNodeList, new ArrayList<>(taskRelations));
return DagHelper.buildDagGraph(processDag);
}
/**
* generate DagData
*/
@Override
public DagData genDagData(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> taskRelations = this.findRelationByCode(processDefinition.getCode(), processDefinition.getVersion());
List<TaskDefinitionLog> taskDefinitionLogList = genTaskDefineList(taskRelations);
List<TaskDefinition> taskDefinitions = taskDefinitionLogList.stream().map(t -> (TaskDefinition) t).collect(Collectors.toList());
return new DagData(processDefinition, taskRelations, taskDefinitions);
}
@Override
public List<TaskDefinitionLog> genTaskDefineList(List<ProcessTaskRelation> processTaskRelations) {
Set<TaskDefinition> taskDefinitionSet = new HashSet<>();
for (ProcessTaskRelation processTaskRelation : processTaskRelations) {
if (processTaskRelation.getPreTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPreTaskCode(), processTaskRelation.getPreTaskVersion())); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | }
if (processTaskRelation.getPostTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion()));
}
}
if (taskDefinitionSet.isEmpty()) {
return Lists.newArrayList();
}
return taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet);
}
@Override
public List<TaskDefinitionLog> getTaskDefineLogListByRelation(List<ProcessTaskRelation> processTaskRelations) {
List<TaskDefinitionLog> taskDefinitionLogs = new ArrayList<>();
Map<Long, Integer> taskCodeVersionMap = new HashMap<>();
for (ProcessTaskRelation processTaskRelation : processTaskRelations) {
if (processTaskRelation.getPreTaskCode() > 0) {
taskCodeVersionMap.put(processTaskRelation.getPreTaskCode(), processTaskRelation.getPreTaskVersion());
}
if (processTaskRelation.getPostTaskCode() > 0) {
taskCodeVersionMap.put(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion());
}
}
taskCodeVersionMap.forEach((code, version) -> {
taskDefinitionLogs.add((TaskDefinitionLog) this.findTaskDefinition(code, version));
});
return taskDefinitionLogs;
}
/**
* find task definition by code and version
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | @Override
public TaskDefinition findTaskDefinition(long taskCode, int taskDefinitionVersion) {
return taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, taskDefinitionVersion);
}
/**
* find process task relation list by process
*/
@Override
public List<ProcessTaskRelation> findRelationByCode(long processDefinitionCode, int processDefinitionVersion) {
List<ProcessTaskRelationLog> processTaskRelationLogList = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinitionCode, processDefinitionVersion);
return processTaskRelationLogList.stream().map(r -> (ProcessTaskRelation) r).collect(Collectors.toList());
}
/**
* add authorized resources
*
* @param ownResources own resources
* @param userId userId
*/
private void addAuthorizedResources(List<Resource> ownResources, int userId) {
List<Integer> relationResourceIds = resourceUserMapper.queryResourcesIdListByUserIdAndPerm(userId, 7);
List<Resource> relationResources = CollectionUtils.isNotEmpty(relationResourceIds) ? resourceMapper.queryResourceListById(relationResourceIds) : new ArrayList<>();
ownResources.addAll(relationResources);
}
/**
* Use temporarily before refactoring taskNode
*/
@Override
public List<TaskNode> transformTask(List<ProcessTaskRelation> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) {
Map<Long, List<Long>> taskCodeMap = new HashMap<>();
for (ProcessTaskRelation processTaskRelation : taskRelationList) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | taskCodeMap.compute(processTaskRelation.getPostTaskCode(), (k, v) -> {
if (v == null) {
v = new ArrayList<>();
}
if (processTaskRelation.getPreTaskCode() != 0L) {
v.add(processTaskRelation.getPreTaskCode());
}
return v;
});
}
if (CollectionUtils.isEmpty(taskDefinitionLogs)) {
taskDefinitionLogs = genTaskDefineList(taskRelationList);
}
Map<Long, TaskDefinitionLog> taskDefinitionLogMap = taskDefinitionLogs.stream()
.collect(Collectors.toMap(TaskDefinitionLog::getCode, taskDefinitionLog -> taskDefinitionLog));
List<TaskNode> taskNodeList = new ArrayList<>();
for (Entry<Long, List<Long>> code : taskCodeMap.entrySet()) {
TaskDefinitionLog taskDefinitionLog = taskDefinitionLogMap.get(code.getKey());
if (taskDefinitionLog != null) {
TaskNode taskNode = new TaskNode();
taskNode.setCode(taskDefinitionLog.getCode());
taskNode.setVersion(taskDefinitionLog.getVersion());
taskNode.setName(taskDefinitionLog.getName());
taskNode.setDesc(taskDefinitionLog.getDescription());
taskNode.setType(taskDefinitionLog.getTaskType().toUpperCase());
taskNode.setRunFlag(taskDefinitionLog.getFlag() == Flag.YES ? Constants.FLOWNODE_RUN_FLAG_NORMAL : Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
taskNode.setMaxRetryTimes(taskDefinitionLog.getFailRetryTimes());
taskNode.setRetryInterval(taskDefinitionLog.getFailRetryInterval());
Map<String, Object> taskParamsMap = taskNode.taskParamsToJsonObj(taskDefinitionLog.getTaskParams());
taskNode.setConditionResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.CONDITION_RESULT))); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | taskNode.setSwitchResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.SWITCH_RESULT)));
taskNode.setDependence(JSONUtils.toJsonString(taskParamsMap.get(Constants.DEPENDENCE)));
taskParamsMap.remove(Constants.CONDITION_RESULT);
taskParamsMap.remove(Constants.DEPENDENCE);
taskNode.setParams(JSONUtils.toJsonString(taskParamsMap));
taskNode.setTaskInstancePriority(taskDefinitionLog.getTaskPriority());
taskNode.setWorkerGroup(taskDefinitionLog.getWorkerGroup());
taskNode.setEnvironmentCode(taskDefinitionLog.getEnvironmentCode());
taskNode.setTimeout(JSONUtils.toJsonString(new TaskTimeoutParameter(taskDefinitionLog.getTimeoutFlag() == TimeoutFlag.OPEN,
taskDefinitionLog.getTimeoutNotifyStrategy(),
taskDefinitionLog.getTimeout())));
taskNode.setDelayTime(taskDefinitionLog.getDelayTime());
taskNode.setPreTasks(JSONUtils.toJsonString(code.getValue().stream().map(taskDefinitionLogMap::get).map(TaskDefinition::getCode).collect(Collectors.toList())));
taskNode.setTaskGroupId(taskDefinitionLog.getTaskGroupId());
taskNode.setTaskGroupPriority(taskDefinitionLog.getTaskGroupPriority());
taskNodeList.add(taskNode);
}
}
return taskNodeList;
}
@Override
public Map<ProcessInstance, TaskInstance> notifyProcessList(int processId) {
HashMap<ProcessInstance, TaskInstance> processTaskMap = new HashMap<>();
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(processId);
if (processInstanceMap == null) {
return processTaskMap;
}
ProcessInstance fatherProcess = this.findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
TaskInstance fatherTask = this.findTaskInstanceById(processInstanceMap.getParentTaskInstanceId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | if (fatherProcess != null) {
processTaskMap.put(fatherProcess, fatherTask);
}
return processTaskMap;
}
@Override
public DqExecuteResult getDqExecuteResultByTaskInstanceId(int taskInstanceId) {
return dqExecuteResultMapper.getExecuteResultById(taskInstanceId);
}
@Override
public int updateDqExecuteResultUserId(int taskInstanceId) {
DqExecuteResult dqExecuteResult =
dqExecuteResultMapper.selectOne(new QueryWrapper<DqExecuteResult>().eq(TASK_INSTANCE_ID, taskInstanceId));
if (dqExecuteResult == null) {
return -1;
}
ProcessInstance processInstance = processInstanceMapper.selectById(dqExecuteResult.getProcessInstanceId());
if (processInstance == null) {
return -1;
}
ProcessDefinition processDefinition = processDefineMapper.queryByCode(processInstance.getProcessDefinitionCode());
if (processDefinition == null) {
return -1;
}
dqExecuteResult.setProcessDefinitionId(processDefinition.getId());
dqExecuteResult.setUserId(processDefinition.getUserId());
dqExecuteResult.setState(DqTaskState.DEFAULT.getCode());
return dqExecuteResultMapper.updateById(dqExecuteResult);
}
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | public int updateDqExecuteResultState(DqExecuteResult dqExecuteResult) {
return dqExecuteResultMapper.updateById(dqExecuteResult);
}
@Override
public int deleteDqExecuteResultByTaskInstanceId(int taskInstanceId) {
return dqExecuteResultMapper.delete(
new QueryWrapper<DqExecuteResult>()
.eq(TASK_INSTANCE_ID, taskInstanceId));
}
@Override
public int deleteTaskStatisticsValueByTaskInstanceId(int taskInstanceId) {
return dqTaskStatisticsValueMapper.delete(
new QueryWrapper<DqTaskStatisticsValue>()
.eq(TASK_INSTANCE_ID, taskInstanceId));
}
@Override
public DqRule getDqRule(int ruleId) {
return dqRuleMapper.selectById(ruleId);
}
@Override
public List<DqRuleInputEntry> getRuleInputEntry(int ruleId) {
return DqRuleUtils.transformInputEntry(dqRuleInputEntryMapper.getRuleInputEntryList(ruleId));
}
@Override
public List<DqRuleExecuteSql> getDqExecuteSql(int ruleId) {
return dqRuleExecuteSqlMapper.getExecuteSqlList(ruleId);
}
@Override
public DqComparisonType getComparisonTypeById(int id) {
return dqComparisonTypeMapper.selectById(id); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | }
/**
* the first time (when submit the task ) get the resource of the task group
*
* @param taskId task id
*/
@Override
public boolean acquireTaskGroup(int taskId,
String taskName, int groupId,
int processId, int priority) {
TaskGroup taskGroup = taskGroupMapper.selectById(groupId);
if (taskGroup == null) {
return true;
}
if (taskGroup.getStatus() == Flag.NO.getCode()) {
return true;
}
TaskGroupQueue taskGroupQueue = this.taskGroupQueueMapper.queryByTaskId(taskId);
if (taskGroupQueue == null) {
taskGroupQueue = insertIntoTaskGroupQueue(taskId, taskName, groupId, processId, priority, TaskGroupQueueStatus.WAIT_QUEUE);
} else {
if (taskGroupQueue.getStatus() == TaskGroupQueueStatus.ACQUIRE_SUCCESS) {
return true;
}
taskGroupQueue.setInQueue(Flag.NO.getCode());
taskGroupQueue.setStatus(TaskGroupQueueStatus.WAIT_QUEUE);
this.taskGroupQueueMapper.updateById(taskGroupQueue);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | List<TaskGroupQueue> highPriorityTasks = taskGroupQueueMapper.queryHighPriorityTasks(groupId, priority, TaskGroupQueueStatus.WAIT_QUEUE.getCode());
if (CollectionUtils.isNotEmpty(highPriorityTasks)) {
this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId());
return false;
}
int count = taskGroupMapper.selectAvailableCountById(groupId);
if (count == 1 && robTaskGroupResouce(taskGroupQueue)) {
return true;
}
this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId());
return false;
}
/**
* try to get the task group resource(when other task release the resource)
*/
@Override
public boolean robTaskGroupResouce(TaskGroupQueue taskGroupQueue) {
TaskGroup taskGroup = taskGroupMapper.selectById(taskGroupQueue.getGroupId());
int affectedCount = taskGroupMapper.updateTaskGroupResource(taskGroup.getId(), taskGroupQueue.getId(),
TaskGroupQueueStatus.WAIT_QUEUE.getCode());
if (affectedCount > 0) {
taskGroupQueue.setStatus(TaskGroupQueueStatus.ACQUIRE_SUCCESS);
this.taskGroupQueueMapper.updateById(taskGroupQueue);
this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId());
return true;
}
return false;
}
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | public boolean acquireTaskGroupAgain(TaskGroupQueue taskGroupQueue) {
return robTaskGroupResouce(taskGroupQueue);
}
@Override
public void releaseAllTaskGroup(int processInstanceId) {
List<TaskInstance> taskInstances = this.taskInstanceMapper.loadAllInfosNoRelease(processInstanceId, TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode());
for (TaskInstance info : taskInstances) {
releaseTaskGroup(info);
}
}
/**
* release the TGQ resource when the corresponding task is finished.
*
* @return the result code and msg
*/
@Override
public TaskInstance releaseTaskGroup(TaskInstance taskInstance) {
TaskGroup taskGroup = taskGroupMapper.selectById(taskInstance.getTaskGroupId());
if (taskGroup == null) {
return null;
}
TaskGroupQueue thisTaskGroupQueue = this.taskGroupQueueMapper.queryByTaskId(taskInstance.getId());
if (thisTaskGroupQueue.getStatus() == TaskGroupQueueStatus.RELEASE) {
return null;
}
try {
while (taskGroupMapper.releaseTaskGroupResource(taskGroup.getId(), taskGroup.getUseSize()
, thisTaskGroupQueue.getId(), TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode()) != 1) {
thisTaskGroupQueue = this.taskGroupQueueMapper.queryByTaskId(taskInstance.getId());
if (thisTaskGroupQueue.getStatus() == TaskGroupQueueStatus.RELEASE) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | return null;
}
taskGroup = taskGroupMapper.selectById(taskInstance.getTaskGroupId());
}
} catch (Exception e) {
logger.error("release the task group error", e);
}
logger.info("updateTask:{}", taskInstance.getName());
changeTaskGroupQueueStatus(taskInstance.getId(), TaskGroupQueueStatus.RELEASE);
TaskGroupQueue taskGroupQueue = this.taskGroupQueueMapper.queryTheHighestPriorityTasks(taskGroup.getId(),
TaskGroupQueueStatus.WAIT_QUEUE.getCode(), Flag.NO.getCode(), Flag.NO.getCode());
if (taskGroupQueue == null) {
return null;
}
while (this.taskGroupQueueMapper.updateInQueueCAS(Flag.NO.getCode(), Flag.YES.getCode(), taskGroupQueue.getId()) != 1) {
taskGroupQueue = this.taskGroupQueueMapper.queryTheHighestPriorityTasks(taskGroup.getId(),
TaskGroupQueueStatus.WAIT_QUEUE.getCode(), Flag.NO.getCode(), Flag.NO.getCode());
if (taskGroupQueue == null) {
return null;
}
}
return this.taskInstanceMapper.selectById(taskGroupQueue.getTaskId());
}
/**
* release the TGQ resource when the corresponding task is finished.
*
* @param taskId task id
* @return the result code and msg
*/
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | public void changeTaskGroupQueueStatus(int taskId, TaskGroupQueueStatus status) {
TaskGroupQueue taskGroupQueue = taskGroupQueueMapper.queryByTaskId(taskId);
taskGroupQueue.setStatus(status);
taskGroupQueue.setUpdateTime(new Date(System.currentTimeMillis()));
taskGroupQueueMapper.updateById(taskGroupQueue);
}
/**
* insert into task group queue
*
* @param taskId task id
* @param taskName task name
* @param groupId group id
* @param processId process id
* @param priority priority
* @return result and msg code
*/
@Override
public TaskGroupQueue insertIntoTaskGroupQueue(Integer taskId,
String taskName, Integer groupId,
Integer processId, Integer priority, TaskGroupQueueStatus status) {
TaskGroupQueue taskGroupQueue = new TaskGroupQueue(taskId, taskName, groupId, processId, priority, status);
taskGroupQueue.setCreateTime(new Date());
taskGroupQueue.setUpdateTime(new Date());
taskGroupQueueMapper.insert(taskGroupQueue);
return taskGroupQueue;
}
@Override
public int updateTaskGroupQueueStatus(Integer taskId, int status) {
return taskGroupQueueMapper.updateStatusByTaskId(taskId, status);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,811 | [Bug] [ProcessInstance] Replace default global params value failed at "COMPLEMENT_DATA" mode | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
<img width="822" alt="process_definition" src="https://user-images.githubusercontent.com/7680235/165489435-14b3f989-9c93-4ac6-be39-bc3561fc6622.png">
The process have several global params default blank. When I run the process at "START_PROCESS" mode, the global_params could be replaced correctly, but if I run the process at "COMPLEMENT_DATA" mode, the replace string all loss.
In database, table t_ds_process_instance: Both two modes have the correct command_param, but only "START_PROCESS" have the correct replaced global_params, "COMPLEMENT_DATA" only have the same as process defined.
"START_PROCESS":
"COMPLEMENT_DATA":
### What you expected to happen
Global params can be replaced correctly at "COMPLEMENT_DATA" mode.
### How to reproduce
Create a new process, set some global params default blank.
try run at START_PROCESS and COMPLEMENT_DATA mode, see different in t_ds_process_instance.
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9811 | https://github.com/apache/dolphinscheduler/pull/9952 | bc1c15b142ea02cdbd9533e890f8f0af897d1cec | d4aeee16e5f3f67e37a31fa606acf0b313189655 | 2022-04-27T09:55:39Z | java | 2022-05-11T10:37:03Z | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java | @Override
public int updateTaskGroupQueue(TaskGroupQueue taskGroupQueue) {
return taskGroupQueueMapper.updateById(taskGroupQueue);
}
@Override
public TaskGroupQueue loadTaskGroupQueue(int taskId) {
return this.taskGroupQueueMapper.queryByTaskId(taskId);
}
@Override
public void sendStartTask2Master(ProcessInstance processInstance, int taskId,
org.apache.dolphinscheduler.remote.command.CommandType taskType) {
String host = processInstance.getHost();
String address = host.split(":")[0];
int port = Integer.parseInt(host.split(":")[1]);
TaskEventChangeCommand taskEventChangeCommand = new TaskEventChangeCommand(
processInstance.getId(), taskId
);
stateEventCallbackService.sendResult(address, port, taskEventChangeCommand.convert2Command(taskType));
}
@Override
public ProcessInstance loadNextProcess4Serial(long code, int state, int id) {
return this.processInstanceMapper.loadNextProcess4Serial(code, state, id);
}
protected void deleteCommandWithCheck(int commandId) {
int delete = this.commandMapper.deleteById(commandId);
if (delete != 1) {
throw new ServiceException("delete command fail, id:" + commandId);
}
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /*
* Lcensed to the Apache Software Foundaton (ASF) under one or more
* contrbutor lcense agreements. See the NOTICE fle dstrbuted wth
* ths work for addtonal nformaton regardng copyrght ownershp.
* The ASF lcenses ths fle to You under the Apache Lcense, Verson 2.0
* (the "Lcense"); you may not use ths fle except n complance wth
* the Lcense. You may obtan a copy of the Lcense at
*
* http://www.apache.org/lcenses/LICENSE-2.0
*
* Unless requred by applcable law or agreed to n wrtng, software
* dstrbuted under the Lcense s dstrbuted on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, ether express or mpled.
* See the Lcense for the specfc language governng permssons and
* lmtatons under the Lcense.
*/
package org.apache.dolphnscheduler.server.master.runner;
mport statc org.apache.dolphnscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | mport statc org.apache.dolphnscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE;
mport statc org.apache.dolphnscheduler.common.Constants.CMD_PARAM_RECOVERY_START_NODE_STRING;
mport statc org.apache.dolphnscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING;
mport statc org.apache.dolphnscheduler.common.Constants.CMD_PARAM_START_NODES;
mport statc org.apache.dolphnscheduler.common.Constants.DEFAULT_WORKER_GROUP;
mport statc org.apache.dolphnscheduler.plugn.task.ap.TaskConstants.TASK_TYPE_BLOCKING;
mport statc org.apache.dolphnscheduler.plugn.task.ap.enums.DataType.VARCHAR;
mport statc org.apache.dolphnscheduler.plugn.task.ap.enums.Drect.IN;
mport org.apache.dolphnscheduler.common.Constants;
mport org.apache.dolphnscheduler.common.enums.CommandType;
mport org.apache.dolphnscheduler.common.enums.FalureStrategy;
mport org.apache.dolphnscheduler.common.enums.Flag;
mport org.apache.dolphnscheduler.common.enums.Prorty;
mport org.apache.dolphnscheduler.common.enums.StateEvent;
mport org.apache.dolphnscheduler.common.enums.StateEventType;
mport org.apache.dolphnscheduler.common.enums.TaskDependType;
mport org.apache.dolphnscheduler.common.enums.TaskGroupQueueStatus;
mport org.apache.dolphnscheduler.common.enums.TmeoutFlag;
mport org.apache.dolphnscheduler.common.graph.DAG;
mport org.apache.dolphnscheduler.common.model.TaskNode;
mport org.apache.dolphnscheduler.common.model.TaskNodeRelaton;
mport org.apache.dolphnscheduler.common.process.ProcessDag;
mport org.apache.dolphnscheduler.common.utls.DateUtls;
mport org.apache.dolphnscheduler.common.utls.JSONUtls;
mport org.apache.dolphnscheduler.common.utls.NetUtls;
mport org.apache.dolphnscheduler.common.utls.ParameterUtls;
mport org.apache.dolphnscheduler.dao.entty.Command;
mport org.apache.dolphnscheduler.dao.entty.Envronment;
mport org.apache.dolphnscheduler.dao.entty.ProcessDefnton;
mport org.apache.dolphnscheduler.dao.entty.ProcessInstance; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | mport org.apache.dolphnscheduler.dao.entty.ProcessTaskRelaton;
mport org.apache.dolphnscheduler.dao.entty.ProjectUser;
mport org.apache.dolphnscheduler.dao.entty.Schedule;
mport org.apache.dolphnscheduler.dao.entty.TaskDefntonLog;
mport org.apache.dolphnscheduler.dao.entty.TaskGroupQueue;
mport org.apache.dolphnscheduler.dao.entty.TaskInstance;
mport org.apache.dolphnscheduler.dao.utls.DagHelper;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.DependResult;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.Drect;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.ExecutonStatus;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.TaskTmeoutStrategy;
mport org.apache.dolphnscheduler.plugn.task.ap.model.Property;
mport org.apache.dolphnscheduler.plugn.task.ap.parameters.BlockngParameters;
mport org.apache.dolphnscheduler.remote.command.HostUpdateCommand;
mport org.apache.dolphnscheduler.remote.utls.Host;
mport org.apache.dolphnscheduler.server.master.confg.MasterConfg;
mport org.apache.dolphnscheduler.server.master.dspatch.executor.NettyExecutorManager;
mport org.apache.dolphnscheduler.server.master.runner.task.ITaskProcessor;
mport org.apache.dolphnscheduler.server.master.runner.task.TaskActon;
mport org.apache.dolphnscheduler.server.master.runner.task.TaskProcessorFactory;
mport org.apache.dolphnscheduler.servce.alert.ProcessAlertManager;
mport org.apache.dolphnscheduler.servce.process.ProcessServce;
mport org.apache.dolphnscheduler.servce.quartz.cron.CronUtls;
mport org.apache.dolphnscheduler.servce.queue.PeerTaskInstancePrortyQueue;
mport org.apache.commons.collectons.CollectonUtls;
mport org.apache.commons.lang.StrngUtls;
mport org.apache.commons.lang.math.NumberUtls;
mport java.utl.ArrayLst;
mport java.utl.Arrays;
mport java.utl.Collecton; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | mport java.utl.Date;
mport java.utl.HashMap;
mport java.utl.Iterator;
mport java.utl.Lst;
mport java.utl.Map;
mport java.utl.Objects;
mport java.utl.Set;
mport java.utl.concurrent.ConcurrentHashMap;
mport java.utl.concurrent.ConcurrentLnkedQueue;
mport java.utl.concurrent.atomc.AtomcBoolean;
mport java.utl.stream.Collectors;
mport org.slf4j.Logger;
mport org.slf4j.LoggerFactory;
mport com.google.common.collect.Lsts;
/**
* master exec thread,splt dag
*/
publc class WorkflowExecuteThread {
/**
* logger of WorkflowExecuteThread
*/
prvate statc fnal Logger logger = LoggerFactory.getLogger(WorkflowExecuteThread.class);
/**
* master confg
*/
prvate MasterConfg masterConfg;
/**
* process servce
*/
prvate ProcessServce processServce; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /**
* alert manager
*/
prvate ProcessAlertManager processAlertManager;
/**
* netty executor manager
*/
prvate NettyExecutorManager nettyExecutorManager;
/**
* process nstance
*/
prvate ProcessInstance processInstance;
/**
* process defnton
*/
prvate ProcessDefnton processDefnton;
/**
* the object of DAG
*/
prvate DAG<Strng, TaskNode, TaskNodeRelaton> dag;
/**
* key of workflow
*/
prvate Strng key;
/**
* start flag, true: start nodes submt completely
*/
prvate boolean sStart = false;
/**
* submt falure nodes |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | */
prvate boolean taskFaledSubmt = false;
/**
* task nstance hash map, taskId as key
*/
prvate Map<Integer, TaskInstance> taskInstanceMap = new ConcurrentHashMap<>();
/**
* runnng taskProcessor, taskCode as key, taskProcessor as value
* only on taskProcessor per taskCode
*/
prvate fnal Map<Long, ITaskProcessor> actveTaskProcessorMaps = new ConcurrentHashMap<>();
/**
* vald task map, taskCode as key, taskId as value
* n a DAG, only one taskInstance per taskCode s vald
*/
prvate Map<Long, Integer> valdTaskMap = new ConcurrentHashMap<>();
/**
* error task map, taskCode as key, taskInstanceId as value
* n a DAG, only one taskInstance per taskCode s vald
*/
prvate Map<Long, Integer> errorTaskMap = new ConcurrentHashMap<>();
/**
* complete task map, taskCode as key, taskInstanceId as value
* n a DAG, only one taskInstance per taskCode s vald
*/
prvate Map<Long, Integer> completeTaskMap = new ConcurrentHashMap<>();
/**
* depend faled task map, taskCode as key, taskId as value
*/
prvate Map<Long, Integer> dependFaledTaskMap = new ConcurrentHashMap<>(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /**
* forbdden task map, code as key
*/
prvate Map<Long, TaskNode> forbddenTaskMap = new ConcurrentHashMap<>();
/**
* skp task map, code as key
*/
prvate Map<Strng, TaskNode> skpTaskNodeMap = new ConcurrentHashMap<>();
/**
* complement date lst
*/
prvate Lst<Date> complementLstDate = Lsts.newLnkedLst();
/**
* state event queue
*/
prvate ConcurrentLnkedQueue<StateEvent> stateEvents = new ConcurrentLnkedQueue<>();
/**
* ready to submt task queue
*/
prvate PeerTaskInstancePrortyQueue readyToSubmtTaskQueue = new PeerTaskInstancePrortyQueue();
/**
* wat to retry taskInstance map, taskCode as key, taskInstance as value
* before retry, the taskInstance d s 0
*/
prvate Map<Long, TaskInstance> watToRetryTaskInstanceMap = new ConcurrentHashMap<>();
/**
* state wheel execute thread
*/
prvate StateWheelExecuteThread stateWheelExecuteThread;
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * constructor of WorkflowExecuteThread
*
* @param processInstance processInstance
* @param processServce processServce
* @param nettyExecutorManager nettyExecutorManager
* @param processAlertManager processAlertManager
* @param masterConfg masterConfg
* @param stateWheelExecuteThread stateWheelExecuteThread
*/
publc WorkflowExecuteThread(ProcessInstance processInstance
, ProcessServce processServce
, NettyExecutorManager nettyExecutorManager
, ProcessAlertManager processAlertManager
, MasterConfg masterConfg
, StateWheelExecuteThread stateWheelExecuteThread) {
ths.processServce = processServce;
ths.processInstance = processInstance;
ths.masterConfg = masterConfg;
ths.nettyExecutorManager = nettyExecutorManager;
ths.processAlertManager = processAlertManager;
ths.stateWheelExecuteThread = stateWheelExecuteThread;
}
/**
* the process start nodes are submtted completely.
*/
publc boolean sStart() {
return ths.sStart;
}
/**
* handle event |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | */
publc vod handleEvents() {
f (!sStart) {
return;
}
whle (!ths.stateEvents.sEmpty()) {
try {
StateEvent stateEvent = ths.stateEvents.peek();
f (stateEventHandler(stateEvent)) {
ths.stateEvents.remove(stateEvent);
}
} catch (Excepton e) {
logger.error("state handle error:", e);
}
}
}
publc Strng getKey() {
f (StrngUtls.sNotEmpty(key)
|| ths.processDefnton == null) {
return key;
}
key = Strng.format("%d_%d_%d",
ths.processDefnton.getCode(),
ths.processDefnton.getVerson(),
ths.processInstance.getId());
return key;
}
publc boolean addStateEvent(StateEvent stateEvent) {
f (processInstance.getId() != stateEvent.getProcessInstanceId()) {
logger.nfo("state event would be abounded :{}", stateEvent.toStrng()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return false;
}
ths.stateEvents.add(stateEvent);
return true;
}
publc nt eventSze() {
return ths.stateEvents.sze();
}
publc ProcessInstance getProcessInstance() {
return ths.processInstance;
}
prvate boolean stateEventHandler(StateEvent stateEvent) {
logger.nfo("process event: {}", stateEvent.toStrng());
f (!checkProcessInstance(stateEvent)) {
return false;
}
boolean result = false;
swtch (stateEvent.getType()) {
case PROCESS_STATE_CHANGE:
result = pr
break;
case TASK_STATE_CHANGE:
result = taskStateChangeHandler(stateEvent);
break;
case PROCESS_TIMEOUT:
result = processTmeout();
break;
case TASK_TIMEOUT:
result = taskTmeout(stateEvent);
break; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | case WAIT_TASK_GROUP:
result = checkForceStartAndWakeUp(stateEvent);
break;
case TASK_RETRY:
result = taskRetryEventHandler(stateEvent);
break;
case PROCESS_BLOCKED:
result = processBlockHandler(stateEvent);
break;
default:
break;
}
f (result) {
ths.stateEvents.remove(stateEvent);
}
return result;
}
prvate boolean checkForceStartAndWakeUp(StateEvent stateEvent) {
TaskGroupQueue taskGroupQueue = ths.processServce.loadTaskGroupQueue(stateEvent.getTaskInstanceId());
f (taskGroupQueue.getForceStart() == Flag.YES.getCode()) {
TaskInstance taskInstance = ths.processServce.fndTaskInstanceById(stateEvent.getTaskInstanceId());
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskInstance.getTaskCode());
taskProcessor.acton(TaskActon.DISPATCH);
ths.processServce.updateTaskGroupQueueStatus(taskGroupQueue.getTaskId(), TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode());
return true;
}
f (taskGroupQueue.getInQueue() == Flag.YES.getCode()) {
boolean acqureTaskGroup = processServce.acqureTaskGroupAgan(taskGroupQueue);
f (acqureTaskGroup) {
TaskInstance taskInstance = ths.processServce.fndTaskInstanceById(stateEvent.getTaskInstanceId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskInstance.getTaskCode());
taskProcessor.acton(TaskActon.DISPATCH);
return true;
}
}
return false;
}
prvate boolean taskTmeout(StateEvent stateEvent) {
f (!checkTaskInstanceByStateEvent(stateEvent)) {
return true;
}
TaskInstance taskInstance = taskInstanceMap.get(stateEvent.getTaskInstanceId());
f (TmeoutFlag.CLOSE == taskInstance.getTaskDefne().getTmeoutFlag()) {
return true;
}
TaskTmeoutStrategy taskTmeoutStrategy = taskInstance.getTaskDefne().getTmeoutNotfyStrategy();
f (TaskTmeoutStrategy.FAILED == taskTmeoutStrategy || TaskTmeoutStrategy.WARNFAILED == taskTmeoutStrategy) {
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskInstance.getTaskCode());
taskProcessor.acton(TaskActon.TIMEOUT);
}
f (TaskTmeoutStrategy.WARN == taskTmeoutStrategy || TaskTmeoutStrategy.WARNFAILED == taskTmeoutStrategy) {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
processAlertManager.sendTaskTmeoutAlert(processInstance, taskInstance, projectUser);
}
return true;
}
prvate boolean processTmeout() {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
ths.processAlertManager.sendProcessTmeoutAlert(ths.processInstance, projectUser);
return true; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
prvate boolean taskStateChangeHandler(StateEvent stateEvent) {
f (!checkTaskInstanceByStateEvent(stateEvent)) {
return true;
}
TaskInstance task = getTaskInstance(stateEvent.getTaskInstanceId());
f (task.getState() == null) {
logger.error("task state s null, state handler error: {}", stateEvent);
return true;
}
f (task.getState().typeIsFnshed()) {
f (completeTaskMap.contansKey(task.getTaskCode()) && completeTaskMap.get(task.getTaskCode()) == task.getId()) {
return true;
}
taskFnshed(task);
f (task.getTaskGroupId() > 0) {
releaseTaskGroup(task);
}
return true;
}
f (actveTaskProcessorMaps.contansKey(task.getTaskCode())) {
ITaskProcessor TaskProcessor = actveTaskProcessorMaps.get(task.getTaskCode());
TaskProcessor.acton(TaskActon.RUN);
f (TaskProcessor.taskInstance().getState().typeIsFnshed()) {
f (TaskProcessor.taskInstance().getState() != task.getState()) {
task.setState(TaskProcessor.taskInstance().getState());
}
taskFnshed(task);
}
return true; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
logger.error("state handler error: {}", stateEvent);
return true;
}
prvate vod taskFnshed(TaskInstance taskInstance) {
logger.nfo("work flow {} task d:{} code:{} state:{} ",
processInstance.getId(),
taskInstance.getId(),
taskInstance.getTaskCode(),
taskInstance.getState());
actveTaskProcessorMaps.remove(taskInstance.getTaskCode());
stateWheelExecuteThread.removeTask4TmeoutCheck(processInstance, taskInstance);
stateWheelExecuteThread.removeTask4RetryCheck(processInstance, taskInstance);
stateWheelExecuteThread.removeTask4StateCheck(processInstance, taskInstance);
f (taskInstance.getState().typeIsSuccess()) {
completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
processInstance.setVarPool(taskInstance.getVarPool());
processServce.saveProcessInstance(processInstance);
f (!processInstance.sBlocked()) {
submtPostNode(Long.toStrng(taskInstance.getTaskCode()));
}
} else f (taskInstance.taskCanRetry() && processInstance.getState() != ExecutonStatus.READY_STOP) {
retryTaskInstance(taskInstance);
} else f (taskInstance.getState().typeIsFalure()) {
completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
f (DagHelper.haveAllNodeAfterNode(Long.toStrng(taskInstance.getTaskCode()), dag)
&& processInstance.getFalureStrategy() == FalureStrategy.CONTINUE) {
submtPostNode(Long.toStrng(taskInstance.getTaskCode())); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | } else {
errorTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
f (processInstance.getFalureStrategy() == FalureStrategy.END) {
kllAllTasks();
}
}
} else f (taskInstance.getState().typeIsFnshed()) {
completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
}
ths.updateProcessInstanceState();
}
/**
* release task group
*
* @param taskInstance
*/
prvate vod releaseTaskGroup(TaskInstance taskInstance) {
f (taskInstance.getTaskGroupId() > 0) {
TaskInstance nextTaskInstance = ths.processServce.releaseTaskGroup(taskInstance);
f (nextTaskInstance != null) {
f (nextTaskInstance.getProcessInstanceId() == taskInstance.getProcessInstanceId()) {
StateEvent nextEvent = new StateEvent();
nextEvent.setProcessInstanceId(ths.processInstance.getId());
nextEvent.setTaskInstanceId(nextTaskInstance.getId());
nextEvent.setType(StateEventType.WAIT_TASK_GROUP);
ths.stateEvents.add(nextEvent);
} else {
ProcessInstance processInstance = ths.processServce.fndProcessInstanceById(nextTaskInstance.getProcessInstanceId());
ths.processServce.sendStartTask2Master(processInstance, nextTaskInstance.getId(),
org.apache.dolphnscheduler.remote.command.CommandType.TASK_WAKEUP_EVENT_REQUEST); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
}
}
}
/**
* crate new task nstance to retry, dfferent objects from the orgnal
*
* @param taskInstance
*/
prvate vod retryTaskInstance(TaskInstance taskInstance) {
f (!taskInstance.taskCanRetry()) {
return;
}
TaskInstance newTaskInstance = cloneRetryTaskInstance(taskInstance);
f (newTaskInstance == null) {
logger.error("retry fal, new taskInstancce s null, task code:{}, task d:{}", taskInstance.getTaskCode(), taskInstance.getId());
return;
}
watToRetryTaskInstanceMap.put(newTaskInstance.getTaskCode(), newTaskInstance);
f (!taskInstance.retryTaskIntervalOverTme()) {
logger.nfo("falure task wll be submtted: process d: {}, task nstance code: {} state:{} retry tmes:{} / {}, nterval:{}",
processInstance.getId(),
newTaskInstance.getTaskCode(),
newTaskInstance.getState(),
newTaskInstance.getRetryTmes(),
newTaskInstance.getMaxRetryTmes(),
newTaskInstance.getRetryInterval());
stateWheelExecuteThread.addTask4TmeoutCheck(processInstance, newTaskInstance);
stateWheelExecuteThread.addTask4RetryCheck(processInstance, newTaskInstance);
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | addTaskToStandByLst(newTaskInstance);
submtStandByTask();
watToRetryTaskInstanceMap.remove(newTaskInstance.getTaskCode());
}
}
/**
* handle task retry event
*
* @param stateEvent
* @return
*/
prvate boolean taskRetryEventHandler(StateEvent stateEvent) {
TaskInstance taskInstance = watToRetryTaskInstanceMap.get(stateEvent.getTaskCode());
addTaskToStandByLst(taskInstance);
submtStandByTask();
watToRetryTaskInstanceMap.remove(stateEvent.getTaskCode());
return true;
}
/**
* update process nstance
*/
publc vod refreshProcessInstance(nt processInstanceId) {
logger.nfo("process nstance update: {}", processInstanceId);
processInstance = processServce.fndProcessInstanceById(processInstanceId);
processDefnton = processServce.fndProcessDefnton(processInstance.getProcessDefntonCode(),
processInstance.getProcessDefntonVerson());
processInstance.setProcessDefnton(processDefnton);
}
/**
* update task nstance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | */
publc vod refreshTaskInstance(nt taskInstanceId) {
logger.nfo("task nstance update: {} ", taskInstanceId);
TaskInstance taskInstance = processServce.fndTaskInstanceById(taskInstanceId);
f (taskInstance == null) {
logger.error("can not fnd task nstance, d:{}", taskInstanceId);
return;
}
processServce.packageTaskInstance(taskInstance, processInstance);
taskInstanceMap.put(taskInstance.getId(), taskInstance);
valdTaskMap.remove(taskInstance.getTaskCode());
f (Flag.YES == taskInstance.getFlag()) {
valdTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
}
}
/**
* check process nstance by state event
*/
publc boolean checkProcessInstance(StateEvent stateEvent) {
f (ths.processInstance.getId() != stateEvent.getProcessInstanceId()) {
logger.error("msmatch process nstance d: {}, state event:{}",
ths.processInstance.getId(),
stateEvent);
return false;
}
return true;
}
/**
* check f task nstance exst by state event
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | publc boolean checkTaskInstanceByStateEvent(StateEvent stateEvent) {
f (stateEvent.getTaskInstanceId() == 0) {
logger.error("task nstance d null, state event:{}", stateEvent);
return false;
}
f (!taskInstanceMap.contansKey(stateEvent.getTaskInstanceId())) {
logger.error("msmatch task nstance d, event:{}", stateEvent);
return false;
}
return true;
}
/**
* check f task nstance exst by task code
*/
publc boolean checkTaskInstanceByCode(long taskCode) {
f (taskInstanceMap == null || taskInstanceMap.sze() == 0) {
return false;
}
for (TaskInstance taskInstance : taskInstanceMap.values()) {
f (taskInstance.getTaskCode() == taskCode) {
return true;
}
}
return false;
}
/**
* check f task nstance exst by d
*/
publc boolean checkTaskInstanceById(nt taskInstanceId) {
f (taskInstanceMap == null || taskInstanceMap.sze() == 0) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return false;
}
return taskInstanceMap.contansKey(taskInstanceId);
}
/**
* get task nstance from memory
*/
publc TaskInstance getTaskInstance(nt taskInstanceId) {
f (taskInstanceMap.contansKey(taskInstanceId)) {
return taskInstanceMap.get(taskInstanceId);
}
return null;
}
publc TaskInstance getTaskInstance(long taskCode) {
f (taskInstanceMap == null || taskInstanceMap.sze() == 0) {
return null;
}
for (TaskInstance taskInstance : taskInstanceMap.values()) {
f (taskInstance.getTaskCode() == taskCode) {
return taskInstance;
}
}
return null;
}
publc TaskInstance getActveTaskInstanceByTaskCode(long taskCode) {
f (actveTaskProcessorMaps.contansKey(taskCode)) {
return actveTaskProcessorMaps.get(taskCode).taskInstance();
}
return null;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | publc TaskInstance getRetryTaskInstanceByTaskCode(long taskCode) {
f (watToRetryTaskInstanceMap.contansKey(taskCode)) {
return watToRetryTaskInstanceMap.get(taskCode);
}
return null;
}
prvate boolean processStateChangeHandler(StateEvent stateEvent) {
try {
logger.nfo("process:{} state {} change to {}", processInstance.getId(), processInstance.getState(), stateEvent.getExecutonStatus());
f (stateEvent.getExecutonStatus() == ExecutonStatus.STOP) {
f (processDefnton.getExecutonType().typeIsSeralWat()){
endProcess();
return true;
}
ths.updateProcessInstanceState(stateEvent);
return true;
}
f (processComplementData()) {
return true;
}
f (stateEvent.getExecutonStatus().typeIsFnshed()) {
endProcess();
}
f (processInstance.getState() == ExecutonStatus.READY_STOP) {
kllAllTasks();
}
return true;
} catch (Excepton e) {
logger.error("process state change error:", e); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
return true;
}
prvate boolean processBlockHandler(StateEvent stateEvent) {
try {
TaskInstance task = getTaskInstance(stateEvent.getTaskInstanceId());
f (!checkTaskInstanceByStateEvent(stateEvent)) {
logger.error("task {} s not a blockng task", task.getTaskCode());
return false;
}
BlockngParameters parameters = JSONUtls.parseObject(task.getTaskParams(), BlockngParameters.class);
f (parameters.sAlertWhenBlockng()) {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
processAlertManager.sendProcessBlockngAlert(processInstance, projectUser);
logger.nfo("processInstance {} block alert send successful!", processInstance.getId());
}
} catch (Excepton e) {
logger.error("sendng blockng message error:", e);
}
return true;
}
prvate boolean processComplementData() throws Excepton {
f (!needComplementProcess()) {
return false;
}
f (processInstance.getState() == ExecutonStatus.READY_STOP) {
return false;
}
Date scheduleDate = processInstance.getScheduleTme();
f (scheduleDate == null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | scheduleDate = complementLstDate.get(0);
} else f (processInstance.getState().typeIsFnshed()) {
endProcess();
f (complementLstDate.sze() <= 0) {
logger.nfo("process complement end. process d:{}", processInstance.getId());
return true;
}
nt ndex = complementLstDate.ndexOf(scheduleDate);
f (ndex >= complementLstDate.sze() - 1 || !processInstance.getState().typeIsSuccess()) {
logger.nfo("process complement end. process d:{}", processInstance.getId());
return true;
}
logger.nfo("process complement contnue. process d:{}, schedule tme:{} complementLstDate:{}",
processInstance.getId(),
processInstance.getScheduleTme(),
complementLstDate.toStrng());
scheduleDate = complementLstDate.get(ndex + 1);
}
nt create = ths.createComplementDataCommand(scheduleDate);
f (create > 0) {
logger.nfo("create complement data command successfully.");
}
return true;
}
prvate nt createComplementDataCommand(Date scheduleDate) {
Command command = new Command();
command.setScheduleTme(scheduleDate);
command.setCommandType(CommandType.COMPLEMENT_DATA); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | command.setProcessDefntonCode(processInstance.getProcessDefntonCode());
Map<Strng, Strng> cmdParam = JSONUtls.toMap(processInstance.getCommandParam());
f (cmdParam.contansKey(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING)) {
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
}
cmdParam.replace(CMDPARAM_COMPLEMENT_DATA_START_DATE, DateUtls.format(scheduleDate, "yyyy-MM-dd HH:mm:ss", null));
command.setCommandParam(JSONUtls.toJsonStrng(cmdParam));
command.setTaskDependType(processInstance.getTaskDependType());
command.setFalureStrategy(processInstance.getFalureStrategy());
command.setWarnngType(processInstance.getWarnngType());
command.setWarnngGroupId(processInstance.getWarnngGroupId());
command.setStartTme(new Date());
command.setExecutorId(processInstance.getExecutorId());
command.setUpdateTme(new Date());
command.setProcessInstanceProrty(processInstance.getProcessInstanceProrty());
command.setWorkerGroup(processInstance.getWorkerGroup());
command.setEnvronmentCode(processInstance.getEnvronmentCode());
command.setDryRun(processInstance.getDryRun());
command.setProcessInstanceId(0);
command.setProcessDefntonVerson(processInstance.getProcessDefntonVerson());
return processServce.createCommand(command);
}
prvate boolean needComplementProcess() {
f (processInstance.sComplementData()
&& Flag.NO == processInstance.getIsSubProcess()) {
return true;
}
return false;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * process start handle
*/
publc vod startProcess() {
f (ths.taskInstanceMap.sze() > 0) {
return;
}
try {
sStart = false;
buldFlowDag();
ntTaskQueue();
submtPostNode(null);
sStart = true;
} catch (Excepton e) {
logger.error("start process error, process nstance d:{}", processInstance.getId(), e);
}
}
/**
* process end handle
*/
publc vod endProcess() {
ths.stateEvents.clear();
f (processDefnton.getExecutonType().typeIsSeralWat()) {
checkSeralProcess(processDefnton);
}
f (processInstance.getState().typeIsWatngThread()) {
processServce.createRecoveryWatngThreadCommand(null, processInstance);
}
f (processAlertManager.sNeedToSendWarnng(processInstance)) {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
processAlertManager.sendAlertProcessInstance(processInstance, getValdTaskLst(), projectUser); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
f (checkTaskQueue()) {
processServce.releaseAllTaskGroup(processInstance.getId());
}
}
publc vod checkSeralProcess(ProcessDefnton processDefnton) {
nt nextInstanceId = processInstance.getNextProcessInstanceId();
f (nextInstanceId == 0) {
ProcessInstance nextProcessInstance = ths.processServce.loadNextProcess4Seral(processInstance.getProcessDefnton().getCode(), ExecutonStatus.SERIAL_WAIT.getCode(), processInstance.getId());
f (nextProcessInstance == null) {
return;
}
nextInstanceId = nextProcessInstance.getId();
}
ProcessInstance nextProcessInstance = ths.processServce.fndProcessInstanceById(nextInstanceId);
f (nextProcessInstance.getState().typeIsFnshed() || nextProcessInstance.getState().typeIsRunnng()) {
return;
}
Map<Strng, Object> cmdParam = new HashMap<>();
cmdParam.put(CMD_PARAM_RECOVER_PROCESS_ID_STRING, nextInstanceId);
Command command = new Command();
command.setCommandType(CommandType.RECOVER_SERIAL_WAIT);
command.setProcessInstanceId(nextProcessInstance.getId());
command.setProcessDefntonCode(processDefnton.getCode());
command.setProcessDefntonVerson(processDefnton.getVerson());
command.setCommandParam(JSONUtls.toJsonStrng(cmdParam));
processServce.createCommand(command);
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * generate process dag
*
* @throws Excepton excepton
*/
prvate vod buldFlowDag() throws Excepton {
f (ths.dag != null) {
return;
}
processDefnton = processServce.fndProcessDefnton(processInstance.getProcessDefntonCode(),
processInstance.getProcessDefntonVerson());
processInstance.setProcessDefnton(processDefnton);
Lst<TaskInstance> recoverNodeLst = getStartTaskInstanceLst(processInstance.getCommandParam());
Lst<ProcessTaskRelaton> processTaskRelatons = processServce.fndRelatonByCode(processDefnton.getCode(), processDefnton.getVerson());
Lst<TaskDefntonLog> taskDefntonLogs = processServce.getTaskDefneLogLstByRelaton(processTaskRelatons);
Lst<TaskNode> taskNodeLst = processServce.transformTask(processTaskRelatons, taskDefntonLogs);
forbddenTaskMap.clear();
taskNodeLst.forEach(taskNode -> {
f (taskNode.sForbdden()) {
forbddenTaskMap.put(taskNode.getCode(), taskNode);
}
});
Lst<Strng> recoveryNodeCodeLst = getRecoveryNodeCodeLst(recoverNodeLst);
Lst<Strng> startNodeNameLst = parseStartNodeName(processInstance.getCommandParam());
ProcessDag processDag = generateFlowDag(taskNodeLst,
startNodeNameLst, recoveryNodeCodeLst, processInstance.getTaskDependType());
f (processDag == null) {
logger.error("processDag s null");
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | dag = DagHelper.buldDagGraph(processDag);
}
/**
* nt task queue
*/
prvate vod ntTaskQueue() {
taskFaledSubmt = false;
actveTaskProcessorMaps.clear();
dependFaledTaskMap.clear();
completeTaskMap.clear();
errorTaskMap.clear();
f (!sNewProcessInstance()) {
Lst<TaskInstance> valdTaskInstanceLst = processServce.fndValdTaskLstByProcessId(processInstance.getId());
for (TaskInstance task : valdTaskInstanceLst) {
f (valdTaskMap.contansKey(task.getTaskCode())) {
nt oldTaskInstanceId = valdTaskMap.get(task.getTaskCode());
TaskInstance oldTaskInstance = taskInstanceMap.get(oldTaskInstanceId);
f (!oldTaskInstance.getState().typeIsFnshed() && task.getState().typeIsFnshed()) {
task.setFlag(Flag.NO);
processServce.updateTaskInstance(task);
contnue;
}
logger.warn("have same taskCode taskInstance when nt task queue, taskCode:{}", task.getTaskCode());
}
valdTaskMap.put(task.getTaskCode(), task.getId());
taskInstanceMap.put(task.getId(), task);
f (task.sTaskComplete()) {
completeTaskMap.put(task.getTaskCode(), task.getId());
contnue; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
f (task.sCondtonsTask() || DagHelper.haveCondtonsAfterNode(Long.toStrng(task.getTaskCode()), dag)) {
contnue;
}
f (task.taskCanRetry()) {
f (task.getState() == ExecutonStatus.NEED_FAULT_TOLERANCE) {
TaskInstance tolerantTaskInstance = cloneTolerantTaskInstance(task);
addTaskToStandByLst(tolerantTaskInstance);
} else {
retryTaskInstance(task);
}
contnue;
}
f (task.getState().typeIsFalure()) {
errorTaskMap.put(task.getTaskCode(), task.getId());
}
}
}
f (processInstance.sComplementData() && complementLstDate.sze() == 0) {
Map<Strng, Strng> cmdParam = JSONUtls.toMap(processInstance.getCommandParam());
f (cmdParam != null && cmdParam.contansKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {
setGlobalParamIfCommanded(processDefnton, cmdParam);
Date start = DateUtls.strngToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
Date end = DateUtls.strngToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE));
Lst<Schedule> schedules = processServce.queryReleaseSchedulerLstByProcessDefntonCode(processInstance.getProcessDefntonCode());
f (complementLstDate.sze() == 0 && needComplementProcess()) {
complementLstDate = CronUtls.getSelfFreDateLst(start, end, schedules);
logger.nfo(" process defnton code:{} complement data: {}", |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | processInstance.getProcessDefntonCode(), complementLstDate.toStrng());
f (complementLstDate.sze() > 0 && Flag.NO == processInstance.getIsSubProcess()) {
processInstance.setScheduleTme(complementLstDate.get(0));
processInstance.setGlobalParams(ParameterUtls.curngGlobalParams(
processDefnton.getGlobalParamMap(),
processDefnton.getGlobalParamLst(),
CommandType.COMPLEMENT_DATA, processInstance.getScheduleTme(), cmdParam.get(Constants.SCHEDULE_TIMEZONE)));
processServce.updateProcessInstance(processInstance);
}
}
}
}
}
/**
* submt task to execute
*
* @param taskInstance task nstance
* @return TaskInstance
*/
prvate TaskInstance submtTaskExec(TaskInstance taskInstance) {
try {
processServce.packageTaskInstance(taskInstance, processInstance);
ITaskProcessor taskProcessor = TaskProcessorFactory.getTaskProcessor(taskInstance.getTaskType());
taskProcessor.nt(taskInstance, processInstance);
f (taskInstance.getState() == ExecutonStatus.RUNNING_EXECUTION
&& taskProcessor.getType().equalsIgnoreCase(Constants.COMMON_TASK_TYPE)) {
notfyProcessHostUpdate(taskInstance);
}
boolean submt = taskProcessor.acton(TaskActon.SUBMIT); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (!submt) {
logger.error("process d:{} name:{} submt standby task d:{} name:{} faled!",
processInstance.getId(), processInstance.getName(),
taskInstance.getId(), taskInstance.getName());
return null;
}
f (valdTaskMap.contansKey(taskInstance.getTaskCode())) {
nt oldTaskInstanceId = valdTaskMap.get(taskInstance.getTaskCode());
f (taskInstance.getId() != oldTaskInstanceId) {
TaskInstance oldTaskInstance = taskInstanceMap.get(oldTaskInstanceId);
oldTaskInstance.setFlag(Flag.NO);
processServce.updateTaskInstance(oldTaskInstance);
valdTaskMap.remove(taskInstance.getTaskCode());
actveTaskProcessorMaps.remove(taskInstance.getTaskCode());
}
}
valdTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
taskInstanceMap.put(taskInstance.getId(), taskInstance);
actveTaskProcessorMaps.put(taskInstance.getTaskCode(), taskProcessor);
taskProcessor.acton(TaskActon.RUN);
stateWheelExecuteThread.addTask4TmeoutCheck(processInstance, taskInstance);
stateWheelExecuteThread.addTask4StateCheck(processInstance, taskInstance);
f (taskProcessor.taskInstance().getState().typeIsFnshed()) {
f (processInstance.sBlocked()) {
StateEvent processBlockEvent = new StateEvent();
processBlockEvent.setProcessInstanceId(ths.processInstance.getId());
processBlockEvent.setTaskInstanceId(taskInstance.getId());
processBlockEvent.setExecutonStatus(taskProcessor.taskInstance().getState());
processBlockEvent.setType(StateEventType.PROCESS_BLOCKED); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | ths.stateEvents.add(processBlockEvent);
}
StateEvent taskStateChangeEvent = new StateEvent();
taskStateChangeEvent.setProcessInstanceId(ths.processInstance.getId());
taskStateChangeEvent.setTaskInstanceId(taskInstance.getId());
taskStateChangeEvent.setExecutonStatus(taskProcessor.taskInstance().getState());
taskStateChangeEvent.setType(StateEventType.TASK_STATE_CHANGE);
ths.stateEvents.add(taskStateChangeEvent);
}
return taskInstance;
} catch (Excepton e) {
logger.error("submt standby task error", e);
return null;
}
}
prvate vod notfyProcessHostUpdate(TaskInstance taskInstance) {
f (StrngUtls.sEmpty(taskInstance.getHost())) {
return;
}
try {
HostUpdateCommand hostUpdateCommand = new HostUpdateCommand();
hostUpdateCommand.setProcessHost(NetUtls.getAddr(masterConfg.getLstenPort()));
hostUpdateCommand.setTaskInstanceId(taskInstance.getId());
Host host = new Host(taskInstance.getHost());
nettyExecutorManager.doExecute(host, hostUpdateCommand.convert2Command());
} catch (Excepton e) {
logger.error("notfy process host update", e);
}
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * fnd task nstance n db.
* n case submt more than one same name task n the same tme.
*
* @param taskCode task code
* @param taskVerson task verson
* @return TaskInstance
*/
prvate TaskInstance fndTaskIfExsts(Long taskCode, nt taskVerson) {
Lst<TaskInstance> valdTaskInstanceLst = getValdTaskLst();
for (TaskInstance taskInstance : valdTaskInstanceLst) {
f (taskInstance.getTaskCode() == taskCode && taskInstance.getTaskDefntonVerson() == taskVerson) {
return taskInstance;
}
}
return null;
}
/**
* encapsulaton task
*
* @param processInstance process nstance
* @param taskNode taskNode
* @return TaskInstance
*/
prvate TaskInstance createTaskInstance(ProcessInstance processInstance, TaskNode taskNode) {
TaskInstance taskInstance = fndTaskIfExsts(taskNode.getCode(), taskNode.getVerson());
f (taskInstance != null) {
return taskInstance;
}
return newTaskInstance(processInstance, taskNode);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /**
* clone a new taskInstance for retry and reset some logc felds
*
* @return
*/
publc TaskInstance cloneRetryTaskInstance(TaskInstance taskInstance) {
TaskNode taskNode = dag.getNode(Long.toStrng(taskInstance.getTaskCode()));
f (taskNode == null) {
logger.error("taskNode s null, code:{}", taskInstance.getTaskCode());
return null;
}
TaskInstance newTaskInstance = newTaskInstance(processInstance, taskNode);
newTaskInstance.setTaskDefne(taskInstance.getTaskDefne());
newTaskInstance.setProcessDefne(taskInstance.getProcessDefne());
newTaskInstance.setProcessInstance(processInstance);
newTaskInstance.setRetryTmes(taskInstance.getRetryTmes() + 1);
newTaskInstance.setState(taskInstance.getState());
newTaskInstance.setEndTme(taskInstance.getEndTme());
return newTaskInstance;
}
/**
* clone a new taskInstance for tolerant and reset some logc felds
*
* @return
*/
publc TaskInstance cloneTolerantTaskInstance(TaskInstance taskInstance) {
TaskNode taskNode = dag.getNode(Long.toStrng(taskInstance.getTaskCode()));
f (taskNode == null) {
logger.error("taskNode s null, code:{}", taskInstance.getTaskCode()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return null;
}
TaskInstance newTaskInstance = newTaskInstance(processInstance, taskNode);
newTaskInstance.setTaskDefne(taskInstance.getTaskDefne());
newTaskInstance.setProcessDefne(taskInstance.getProcessDefne());
newTaskInstance.setProcessInstance(processInstance);
newTaskInstance.setRetryTmes(taskInstance.getRetryTmes());
newTaskInstance.setState(taskInstance.getState());
return newTaskInstance;
}
/**
* new a taskInstance
*
* @param processInstance
* @param taskNode
* @return
*/
publc TaskInstance newTaskInstance(ProcessInstance processInstance, TaskNode taskNode) {
TaskInstance taskInstance = new TaskInstance();
taskInstance.setTaskCode(taskNode.getCode());
taskInstance.setTaskDefntonVerson(taskNode.getVerson());
taskInstance.setName(taskNode.getName());
taskInstance.setState(ExecutonStatus.SUBMITTED_SUCCESS);
taskInstance.setProcessInstanceId(processInstance.getId());
taskInstance.setTaskType(taskNode.getType().toUpperCase()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | taskInstance.setAlertFlag(Flag.NO);
taskInstance.setStartTme(null);
taskInstance.setFlag(Flag.YES);
taskInstance.setDryRun(processInstance.getDryRun());
taskInstance.setRetryTmes(0);
taskInstance.setMaxRetryTmes(taskNode.getMaxRetryTmes());
taskInstance.setRetryInterval(taskNode.getRetryInterval());
taskInstance.setTaskParams(taskNode.getTaskParams());
taskInstance.setTaskGroupId(taskNode.getTaskGroupId());
taskInstance.setTaskGroupProrty(taskNode.getTaskGroupProrty());
f (taskNode.getTaskInstanceProrty() == null) {
taskInstance.setTaskInstanceProrty(Prorty.MEDIUM);
} else {
taskInstance.setTaskInstanceProrty(taskNode.getTaskInstanceProrty());
}
Strng processWorkerGroup = processInstance.getWorkerGroup();
processWorkerGroup = StrngUtls.sBlank(processWorkerGroup) ? DEFAULT_WORKER_GROUP : processWorkerGroup;
Strng taskWorkerGroup = StrngUtls.sBlank(taskNode.getWorkerGroup()) ? processWorkerGroup : taskNode.getWorkerGroup();
Long processEnvronmentCode = Objects.sNull(processInstance.getEnvronmentCode()) ? -1 : processInstance.getEnvronmentCode();
Long taskEnvronmentCode = Objects.sNull(taskNode.getEnvronmentCode()) ? processEnvronmentCode : taskNode.getEnvronmentCode();
f (!processWorkerGroup.equals(DEFAULT_WORKER_GROUP) && taskWorkerGroup.equals(DEFAULT_WORKER_GROUP)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | taskInstance.setWorkerGroup(processWorkerGroup);
taskInstance.setEnvronmentCode(processEnvronmentCode);
} else {
taskInstance.setWorkerGroup(taskWorkerGroup);
taskInstance.setEnvronmentCode(taskEnvronmentCode);
}
f (!taskInstance.getEnvronmentCode().equals(-1L)) {
Envronment envronment = processServce.fndEnvronmentByCode(taskInstance.getEnvronmentCode());
f (Objects.nonNull(envronment) && StrngUtls.sNotEmpty(envronment.getConfg())) {
taskInstance.setEnvronmentConfg(envronment.getConfg());
}
}
taskInstance.setDelayTme(taskNode.getDelayTme());
return taskInstance;
}
publc vod getPreVarPool(TaskInstance taskInstance, Set<Strng> preTask) {
Map<Strng, Property> allProperty = new HashMap<>();
Map<Strng, TaskInstance> allTaskInstance = new HashMap<>();
f (CollectonUtls.sNotEmpty(preTask)) {
for (Strng preTaskCode : preTask) {
Integer taskId = completeTaskMap.get(Long.parseLong(preTaskCode));
f (taskId == null) {
contnue;
}
TaskInstance preTaskInstance = taskInstanceMap.get(taskId);
f (preTaskInstance == null) {
contnue;
}
Strng preVarPool = preTaskInstance.getVarPool(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (StrngUtls.sNotEmpty(preVarPool)) {
Lst<Property> propertes = JSONUtls.toLst(preVarPool, Property.class);
for (Property nfo : propertes) {
setVarPoolValue(allProperty, allTaskInstance, preTaskInstance, nfo);
}
}
}
f (allProperty.sze() > 0) {
taskInstance.setVarPool(JSONUtls.toJsonStrng(allProperty.values()));
}
} else {
f (StrngUtls.sNotEmpty(processInstance.getVarPool())) {
taskInstance.setVarPool(processInstance.getVarPool());
}
}
}
prvate vod setVarPoolValue(Map<Strng, Property> allProperty, Map<Strng, TaskInstance> allTaskInstance, TaskInstance preTaskInstance, Property thsProperty) {
thsProperty.setDrect(Drect.IN);
Strng proName = thsProperty.getProp();
f (allProperty.contansKey(proName)) {
Property otherPro = allProperty.get(proName);
f (StrngUtls.sEmpty(thsProperty.getValue())) {
allProperty.put(proName, otherPro);
} else f (StrngUtls.sNotEmpty(otherPro.getValue())) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | TaskInstance otherTask = allTaskInstance.get(proName);
f (otherTask.getEndTme().getTme() > preTaskInstance.getEndTme().getTme()) {
allProperty.put(proName, thsProperty);
allTaskInstance.put(proName, preTaskInstance);
} else {
allProperty.put(proName, otherPro);
}
} else {
allProperty.put(proName, thsProperty);
allTaskInstance.put(proName, preTaskInstance);
}
} else {
allProperty.put(proName, thsProperty);
allTaskInstance.put(proName, preTaskInstance);
}
}
/**
* get complete task nstance map, taskCode as key
*/
prvate Map<Strng, TaskInstance> getCompleteTaskInstanceMap() {
Map<Strng, TaskInstance> completeTaskInstanceMap = new HashMap<>();
for (Integer taskInstanceId : completeTaskMap.values()) {
TaskInstance taskInstance = taskInstanceMap.get(taskInstanceId);
completeTaskInstanceMap.put(Long.toStrng(taskInstance.getTaskCode()), taskInstance);
}
return completeTaskInstanceMap;
}
/**
* get vald task lst
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | prvate Lst<TaskInstance> getValdTaskLst() {
Lst<TaskInstance> valdTaskInstanceLst = new ArrayLst<>();
for (Integer taskInstanceId : valdTaskMap.values()) {
valdTaskInstanceLst.add(taskInstanceMap.get(taskInstanceId));
}
return valdTaskInstanceLst;
}
prvate vod submtPostNode(Strng parentNodeCode) {
Set<Strng> submtTaskNodeLst = DagHelper.parsePostNodes(parentNodeCode, skpTaskNodeMap, dag, getCompleteTaskInstanceMap());
Lst<TaskInstance> taskInstances = new ArrayLst<>();
for (Strng taskNode : submtTaskNodeLst) {
TaskNode taskNodeObject = dag.getNode(taskNode);
TaskInstance exstTaskInstance = getTaskInstance(taskNodeObject.getCode());
f (exstTaskInstance != null) {
taskInstances.add(exstTaskInstance);
contnue;
}
TaskInstance task = createTaskInstance(processInstance, taskNodeObject);
taskInstances.add(task);
}
f (StrngUtls.sNotEmpty(parentNodeCode) && dag.getEndNode().contans(parentNodeCode)) {
TaskInstance endTaskInstance = taskInstanceMap.get(completeTaskMap.get(NumberUtls.toLong(parentNodeCode)));
Strng taskInstanceVarPool = endTaskInstance.getVarPool();
f (StrngUtls.sNotEmpty(taskInstanceVarPool)) {
Set<Property> taskPropertes = JSONUtls.toLst(taskInstanceVarPool, Property.class)
.stream().collect(Collectors.toSet());
Strng processInstanceVarPool = processInstance.getVarPool();
f (StrngUtls.sNotEmpty(processInstanceVarPool)) {
Set<Property> propertes = JSONUtls.toLst(processInstanceVarPool, Property.class) |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | .stream().collect(Collectors.toSet());
propertes.addAll(taskPropertes);
processInstance.setVarPool(JSONUtls.toJsonStrng(propertes));
} else {
processInstance.setVarPool(JSONUtls.toJsonStrng(taskPropertes));
}
}
}
for (TaskInstance task : taskInstances) {
f (readyToSubmtTaskQueue.contans(task)) {
contnue;
}
f (task.getId() > 0 && completeTaskMap.contansKey(task.getTaskCode())) {
logger.nfo("task {} has already run success", task.getName());
contnue;
}
f (task.getState().typeIsPause() || task.getState().typeIsCancel()) {
logger.nfo("task {} stopped, the state s {}", task.getName(), task.getState());
contnue;
}
addTaskToStandByLst(task);
}
submtStandByTask();
updateProcessInstanceState();
}
/**
* determne whether the dependences of the task node are complete
*
* @return DependResult |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | */
prvate DependResult sTaskDepsComplete(Strng taskCode) {
Collecton<Strng> startNodes = dag.getBegnNode();
f (startNodes.contans(taskCode)) {
return DependResult.SUCCESS;
}
TaskNode taskNode = dag.getNode(taskCode);
Lst<Strng> ndrectDepCodeLst = new ArrayLst<>();
setIndrectDepLst(taskCode, ndrectDepCodeLst);
for (Strng depsNode : ndrectDepCodeLst) {
f (dag.contansNode(depsNode) && !skpTaskNodeMap.contansKey(depsNode)) {
Long despNodeTaskCode = Long.parseLong(depsNode);
f (!completeTaskMap.contansKey(despNodeTaskCode)) {
return DependResult.WAITING;
}
Integer depsTaskId = completeTaskMap.get(despNodeTaskCode);
ExecutonStatus depTaskState = taskInstanceMap.get(depsTaskId).getState();
f (depTaskState.typeIsPause() || depTaskState.typeIsCancel()) {
return DependResult.NON_EXEC;
}
f (taskNode.sCondtonsTask() || taskNode.sBlockngTask()) {
contnue;
}
f (!dependTaskSuccess(depsNode, taskCode)) {
return DependResult.FAILED;
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
logger.nfo("taskCode: {} completeDependTaskLst: {}", taskCode, Arrays.toStrng(completeTaskMap.keySet().toArray()));
return DependResult.SUCCESS;
}
/**
* Ths functon s specally used to handle the dependency stuaton where the parent node s a prohbted node.
* When the parent node s a forbdden node, the dependency relatonshp should contnue to be traced
*
* @param taskCode taskCode
* @param ndrectDepCodeLst All ndrectly dependent nodes
*/
prvate vod setIndrectDepLst(Strng taskCode, Lst<Strng> ndrectDepCodeLst) {
TaskNode taskNode = dag.getNode(taskCode);
Lst<Strng> depCodeLst = taskNode.getDepLst();
for (Strng depsNode : depCodeLst) {
f (forbddenTaskMap.contansKey(Long.parseLong(depsNode))) {
setIndrectDepLst(depsNode, ndrectDepCodeLst);
} else {
ndrectDepCodeLst.add(depsNode);
}
}
}
/**
* depend node s completed, but here need check the condton task branch s the next node
*/
prvate boolean dependTaskSuccess(Strng dependNodeName, Strng nextNodeName) {
f (dag.getNode(dependNodeName).sCondtonsTask()) {
Lst<Strng> nextTaskLst = DagHelper.parseCondtonTask(dependNodeName, skpTaskNodeMap, dag, getCompleteTaskInstanceMap());
f (!nextTaskLst.contans(nextNodeName)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return false;
}
} else {
long taskCode = Long.parseLong(dependNodeName);
Integer taskInstanceId = completeTaskMap.get(taskCode);
ExecutonStatus depTaskState = taskInstanceMap.get(taskInstanceId).getState();
f (depTaskState.typeIsFalure()) {
return false;
}
}
return true;
}
/**
* query task nstance by complete state
*
* @param state state
* @return task nstance lst
*/
prvate Lst<TaskInstance> getCompleteTaskByState(ExecutonStatus state) {
Lst<TaskInstance> resultLst = new ArrayLst<>();
for (Integer taskInstanceId : completeTaskMap.values()) {
TaskInstance taskInstance = taskInstanceMap.get(taskInstanceId);
f (taskInstance != null && taskInstance.getState() == state) {
resultLst.add(taskInstance);
}
}
return resultLst;
}
/**
* where there are ongong tasks |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | *
* @param state state
* @return ExecutonStatus
*/
prvate ExecutonStatus runnngState(ExecutonStatus state) {
f (state == ExecutonStatus.READY_STOP
|| state == ExecutonStatus.READY_PAUSE
|| state == ExecutonStatus.WAITING_THREAD
|| state == ExecutonStatus.READY_BLOCK
|| state == ExecutonStatus.DELAY_EXECUTION) {
return state;
} else {
return ExecutonStatus.RUNNING_EXECUTION;
}
}
/**
* exsts falure task,contans submt falure、dependency falure,execute falure(retry after)
*
* @return Boolean whether has faled task
*/
prvate boolean hasFaledTask() {
f (ths.taskFaledSubmt) {
return true;
}
f (ths.errorTaskMap.sze() > 0) {
return true;
}
return ths.dependFaledTaskMap.sze() > 0;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /**
* process nstance falure
*
* @return Boolean whether process nstance faled
*/
prvate boolean processFaled() {
f (hasFaledTask()) {
f (processInstance.getFalureStrategy() == FalureStrategy.END) {
return true;
}
f (processInstance.getFalureStrategy() == FalureStrategy.CONTINUE) {
return readyToSubmtTaskQueue.sze() == 0
&& actveTaskProcessorMaps.sze() == 0
&& watToRetryTaskInstanceMap.sze() == 0;
}
}
return false;
}
/**
* whether task for watng thread
*
* @return Boolean whether has watng thread task
*/
prvate boolean hasWatngThreadTask() {
Lst<TaskInstance> watngLst = getCompleteTaskByState(ExecutonStatus.WAITING_THREAD);
return CollectonUtls.sNotEmpty(watngLst);
}
/**
* prepare for pause
* 1，faled retry task n the preparaton queue , returns to falure drectly |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * 2，exsts pause task，complement not completed, pendng submsson of tasks, return to suspenson
* 3，success
*
* @return ExecutonStatus
*/
prvate ExecutonStatus processReadyPause() {
f (hasRetryTaskInStandBy()) {
return ExecutonStatus.FAILURE;
}
Lst<TaskInstance> pauseLst = getCompleteTaskByState(ExecutonStatus.PAUSE);
f (CollectonUtls.sNotEmpty(pauseLst)
|| processInstance.sBlocked()
|| !sComplementEnd()
|| readyToSubmtTaskQueue.sze() > 0) {
return ExecutonStatus.PAUSE;
} else {
return ExecutonStatus.SUCCESS;
}
}
/**
* prepare for block
* f process has tasks stll runnng, pause them
* f readyToSubmtTaskQueue s not empty, kll them
* else return block status drectly
*
* @return ExecutonStatus
*/
prvate ExecutonStatus processReadyBlock() {
f (actveTaskProcessorMaps.sze() > 0) {
for (ITaskProcessor taskProcessor : actveTaskProcessorMaps.values()) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 9,975 | [Bug-BE] The selected task instance was recreated when the Master service failed over | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
The selected task instance was recreated when the Master service failed over
### What you expected to happen
No new instances should be created.
### How to reproduce
Stop the Master service during workflow execution, and then start the Master again.
### Anything else
No Response.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/9975 | https://github.com/apache/dolphinscheduler/pull/9976 | 00f102959b5a07f56cb2d6f8973949cc4eee22b0 | dbdbfeaeee4b6aaaa738ef642a908f700f0cb9bc | 2022-05-10T18:52:26Z | java | 2022-05-12T08:31:53Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (!TASK_TYPE_BLOCKING.equals(taskProcessor.getType())) {
taskProcessor.acton(TaskActon.PAUSE);
}
}
}
f (readyToSubmtTaskQueue.sze() > 0) {
for (Iterator<TaskInstance> ter = readyToSubmtTaskQueue.terator(); ter.hasNext(); ) {
ter.next().setState(ExecutonStatus.KILL);
}
}
return ExecutonStatus.BLOCK;
}
/**
* generate the latest process nstance status by the tasks state
*
* @return process nstance executon status
*/
prvate ExecutonStatus getProcessInstanceState(ProcessInstance nstance) {
ExecutonStatus state = nstance.getState();
f (actveTaskProcessorMaps.sze() > 0 || hasRetryTaskInStandBy()) {
// actve
return runnngState(state);
}
// block
f (state == ExecutonStatus.READY_BLOCK) {
return processReadyBlock();
}
// watng thread
f (hasWatngThreadTask()) {
return ExecutonStatus.WAITING_THREAD; |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.