status
stringclasses 1
value | repo_name
stringclasses 31
values | repo_url
stringclasses 31
values | issue_id
int64 1
104k
| title
stringlengths 4
233
| body
stringlengths 0
186k
⌀ | issue_url
stringlengths 38
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[us, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] | updated_file
stringlengths 7
188
| chunk_content
stringlengths 1
1.03M
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * SINGLE_SLASH /
*/
public static final String SINGLE_SLASH = "/";
/**
* DOUBLE_SLASH //
*/
public static final String DOUBLE_SLASH = "//";
/**
* EQUAL SIGN
*/
public static final String EQUAL_SIGN = "=";
/**
* AT SIGN
*/
public static final String AT_SIGN = "@";
/**
* date format of yyyy-MM-dd HH:mm:ss
*/
public static final String YYYY_MM_DD_HH_MM_SS = "yyyy-MM-dd HH:mm:ss";
/**
* date format of yyyyMMdd
*/
public static final String YYYYMMDD = "yyyyMMdd";
/**
* date format of yyyyMMddHHmmss
*/
public static final String YYYYMMDDHHMMSS = "yyyyMMddHHmmss";
/**
* date format of yyyyMMddHHmmssSSS
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String YYYYMMDDHHMMSSSSS = "yyyyMMddHHmmssSSS";
/**
* http connect time out
*/
public static final int HTTP_CONNECT_TIMEOUT = 60 * 1000;
/**
* http connect request time out
*/
public static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 60 * 1000;
/**
* httpclient soceket time out
*/
public static final int SOCKET_TIMEOUT = 60 * 1000;
/**
* registry session timeout
*/
public static final int REGISTRY_SESSION_TIMEOUT = 10 * 1000;
/**
* http header
*/
public static final String HTTP_HEADER_UNKNOWN = "unKnown";
/**
* http X-Forwarded-For
*/
public static final String HTTP_X_FORWARDED_FOR = "X-Forwarded-For";
/**
* http X-Real-IP
*/
public static final String HTTP_X_REAL_IP = "X-Real-IP";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * UTF-8
*/
public static final String UTF_8 = "UTF-8";
/**
* user name regex
*/
public static final Pattern REGEX_USER_NAME = Pattern.compile("^[a-zA-Z0-9._-]{3,39}$");
/**
* read permission
*/
public static final int READ_PERMISSION = 2;
/**
* write permission
*/
public static final int WRITE_PERMISSION = 2 * 2;
/**
* execute permission
*/
public static final int EXECUTE_PERMISSION = 1;
/**
* default admin permission
*/
public static final int DEFAULT_ADMIN_PERMISSION = 7;
/**
* default hash map size
*/
public static final int DEFAULT_HASH_MAP_SIZE = 16;
/**
* all permissions
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final int ALL_PERMISSIONS = READ_PERMISSION | WRITE_PERMISSION | EXECUTE_PERMISSION;
/**
* max task timeout
*/
public static final int MAX_TASK_TIMEOUT = 24 * 3600;
/**
* worker host weight
*/
public static final int DEFAULT_WORKER_HOST_WEIGHT = 100;
/**
* time unit secong to minutes
*/
public static final int SEC_2_MINUTES_TIME_UNIT = 60;
/***
*
* rpc port
*/
public static final String RPC_PORT = "rpc.port";
/**
* forbid running task
*/
public static final String FLOWNODE_RUN_FLAG_FORBIDDEN = "FORBIDDEN";
/**
* normal running task
*/
public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL";
public static final String COMMON_TASK_TYPE = "common";
public static final String DEFAULT = "default";
public static final String PASSWORD = "password";
public static final String XXXXXX = "******"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String NULL = "NULL";
public static final String THREAD_NAME_MASTER_SERVER = "Master-Server";
public static final String THREAD_NAME_WORKER_SERVER = "Worker-Server";
public static final String THREAD_NAME_ALERT_SERVER = "Alert-Server";
/**
* command parameter keys
*/
public static final String CMD_PARAM_RECOVER_PROCESS_ID_STRING = "ProcessInstanceId";
public static final String CMD_PARAM_RECOVERY_START_NODE_STRING = "StartNodeIdList";
public static final String CMD_PARAM_RECOVERY_WAITING_THREAD = "WaitingThreadInstanceId";
public static final String CMD_PARAM_SUB_PROCESS = "processInstanceId";
public static final String CMD_PARAM_EMPTY_SUB_PROCESS = "0";
public static final String CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID = "parentProcessInstanceId";
public static final String CMD_PARAM_SUB_PROCESS_DEFINE_CODE = "processDefinitionCode";
public static final String CMD_PARAM_START_NODES = "StartNodeList";
public static final String CMD_PARAM_START_PARAMS = "StartParams";
public static final String CMD_PARAM_FATHER_PARAMS = "fatherParams";
/**
* complement data start date
*/
public static final String CMDPARAM_COMPLEMENT_DATA_START_DATE = "complementStartDate";
/**
* complement data end date
*/
public static final String CMDPARAM_COMPLEMENT_DATA_END_DATE = "complementEndDate";
/**
* complement date default cron string
*/
public static final String DEFAULT_CRON_STRING = "0 0 0 * * ? *";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * sleep 1000ms
*/
public static final int SLEEP_TIME_MILLIS = 1000;
/**
* short sleep 100ms
*/
public static final int SLEEP_TIME_MILLIS_SHORT = 100;
/**
* one second mils
*/
public static final int SECOND_TIME_MILLIS = 1000;
/**
* master task instance cache-database refresh interval
*/
public static final int CACHE_REFRESH_TIME_MILLIS = 20 * 1000;
/**
* heartbeat for zk info length
*/
public static final int HEARTBEAT_FOR_ZOOKEEPER_INFO_LENGTH = 13;
/**
* jar
*/
public static final String JAR = "jar";
/**
* hadoop
*/
public static final String HADOOP = "hadoop";
/**
* -D <property>=<value>
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String D = "-D";
/**
* exit code success
*/
public static final int EXIT_CODE_SUCCESS = 0;
/**
* exit code failure
*/
public static final int EXIT_CODE_FAILURE = -1;
/**
* process or task definition failure
*/
public static final int DEFINITION_FAILURE = -1;
/**
* process or task definition first version
*/
public static final int VERSION_FIRST = 1;
/**
* date format of yyyyMMdd
*/
public static final String PARAMETER_FORMAT_DATE = "yyyyMMdd";
/**
* date format of yyyyMMddHHmmss
*/
public static final String PARAMETER_FORMAT_TIME = "yyyyMMddHHmmss";
/**
* system date(yyyyMMddHHmmss)
*/
public static final String PARAMETER_DATETIME = "system.datetime";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * system date(yyyymmdd) today
*/
public static final String PARAMETER_CURRENT_DATE = "system.biz.curdate";
/**
* system date(yyyymmdd) yesterday
*/
public static final String PARAMETER_BUSINESS_DATE = "system.biz.date";
/**
* ACCEPTED
*/
public static final String ACCEPTED = "ACCEPTED";
/**
* SUCCEEDED
*/
public static final String SUCCEEDED = "SUCCEEDED";
/**
* ENDED
*/
public static final String ENDED = "ENDED";
/**
* NEW
*/
public static final String NEW = "NEW";
/**
* NEW_SAVING
*/
public static final String NEW_SAVING = "NEW_SAVING";
/**
* SUBMITTED
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String SUBMITTED = "SUBMITTED";
/**
* FAILED
*/
public static final String FAILED = "FAILED";
/**
* KILLED
*/
public static final String KILLED = "KILLED";
/**
* RUNNING
*/
public static final String RUNNING = "RUNNING";
/**
* underline "_"
*/
public static final String UNDERLINE = "_";
/**
* quartz job prifix
*/
public static final String QUARTZ_JOB_PREFIX = "job";
/**
* quartz job group prifix
*/
public static final String QUARTZ_JOB_GROUP_PREFIX = "jobgroup";
/**
* projectId
*/
public static final String PROJECT_ID = "projectId";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * processId
*/
public static final String SCHEDULE_ID = "scheduleId";
/**
* schedule
*/
public static final String SCHEDULE = "schedule";
/**
* application regex
*/
public static final String APPLICATION_REGEX = "application_\\d+_\\d+";
public static final String PID = SystemUtils.IS_OS_WINDOWS ? "handle" : "pid";
/**
* month_begin
*/
public static final String MONTH_BEGIN = "month_begin";
/**
* add_months
*/
public static final String ADD_MONTHS = "add_months";
/**
* month_end
*/
public static final String MONTH_END = "month_end";
/**
* week_begin
*/
public static final String WEEK_BEGIN = "week_begin";
/**
* week_end |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | */
public static final String WEEK_END = "week_end";
/**
* timestamp
*/
public static final String TIMESTAMP = "timestamp";
public static final char SUBTRACT_CHAR = '-';
public static final char ADD_CHAR = '+';
public static final char MULTIPLY_CHAR = '*';
public static final char DIVISION_CHAR = '/';
public static final char LEFT_BRACE_CHAR = '(';
public static final char RIGHT_BRACE_CHAR = ')';
public static final String ADD_STRING = "+";
public static final String STAR = "*";
public static final String DIVISION_STRING = "/";
public static final String LEFT_BRACE_STRING = "(";
public static final char P = 'P';
public static final char N = 'N';
public static final String SUBTRACT_STRING = "-";
public static final String GLOBAL_PARAMS = "globalParams";
public static final String LOCAL_PARAMS = "localParams";
public static final String SUBPROCESS_INSTANCE_ID = "subProcessInstanceId";
public static final String PROCESS_INSTANCE_STATE = "processInstanceState";
public static final String PARENT_WORKFLOW_INSTANCE = "parentWorkflowInstance";
public static final String CONDITION_RESULT = "conditionResult";
public static final String SWITCH_RESULT = "switchResult";
public static final String WAIT_START_TIMEOUT = "waitStartTimeout";
public static final String DEPENDENCE = "dependence";
public static final String TASK_LIST = "taskList";
public static final String QUEUE = "queue"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String QUEUE_NAME = "queueName";
public static final int LOG_QUERY_SKIP_LINE_NUMBER = 0;
public static final int LOG_QUERY_LIMIT = 4096;
public static final String BLOCKING_CONDITION = "blockingCondition";
public static final String ALERT_WHEN_BLOCKING = "alertWhenBlocking";
/**
* master/worker server use for zk
*/
public static final String MASTER_TYPE = "master";
public static final String WORKER_TYPE = "worker";
public static final String DELETE_OP = "delete";
public static final String ADD_OP = "add";
public static final String ALIAS = "alias";
public static final String CONTENT = "content";
public static final String DEPENDENT_SPLIT = ":||";
public static final long DEPENDENT_ALL_TASK_CODE = 0;
/**
* preview schedule execute count
*/
public static final int PREVIEW_SCHEDULE_EXECUTE_COUNT = 5;
/**
* kerberos
*/
public static final String KERBEROS = "kerberos";
/**
* kerberos expire time
*/
public static final String KERBEROS_EXPIRE_TIME = "kerberos.expire.time";
/**
* java.security.krb5.conf |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | */
public static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf";
/**
* java.security.krb5.conf.path
*/
public static final String JAVA_SECURITY_KRB5_CONF_PATH = "java.security.krb5.conf.path";
/**
* hadoop.security.authentication
*/
public static final String HADOOP_SECURITY_AUTHENTICATION = "hadoop.security.authentication";
/**
* hadoop.security.authentication
*/
public static final String HADOOP_SECURITY_AUTHENTICATION_STARTUP_STATE = "hadoop.security.authentication.startup.state";
/**
* com.amazonaws.services.s3.enableV4
*/
public static final String AWS_S3_V4 = "com.amazonaws.services.s3.enableV4";
/**
* loginUserFromKeytab user
*/
public static final String LOGIN_USER_KEY_TAB_USERNAME = "login.user.keytab.username";
/**
* loginUserFromKeytab path
*/
public static final String LOGIN_USER_KEY_TAB_PATH = "login.user.keytab.path";
/**
* task log info format
*/
public static final String TASK_LOG_INFO_FORMAT = "TaskLogInfo-%s"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final int[] NOT_TERMINATED_STATES = new int[]{
ExecutionStatus.SUBMITTED_SUCCESS.ordinal(),
ExecutionStatus.DISPATCH.ordinal(),
ExecutionStatus.RUNNING_EXECUTION.ordinal(),
ExecutionStatus.DELAY_EXECUTION.ordinal(),
ExecutionStatus.READY_PAUSE.ordinal(),
ExecutionStatus.READY_STOP.ordinal(),
ExecutionStatus.NEED_FAULT_TOLERANCE.ordinal(),
ExecutionStatus.WAITING_THREAD.ordinal(),
ExecutionStatus.WAITING_DEPEND.ordinal()
};
public static final int[] RUNNING_PROCESS_STATE = new int[]{
ExecutionStatus.RUNNING_EXECUTION.ordinal(),
ExecutionStatus.SUBMITTED_SUCCESS.ordinal(),
ExecutionStatus.DISPATCH.ordinal(),
ExecutionStatus.SERIAL_WAIT.ordinal()
};
/**
* status
*/
public static final String STATUS = "status";
/**
* message
*/
public static final String MSG = "msg";
/**
* data total
*/
public static final String COUNT = "count";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * page size
*/
public static final String PAGE_SIZE = "pageSize";
/**
* current page no
*/
public static final String PAGE_NUMBER = "pageNo";
/**
*
*/
public static final String DATA_LIST = "data";
public static final String TOTAL_LIST = "totalList";
public static final String CURRENT_PAGE = "currentPage";
public static final String TOTAL_PAGE = "totalPage";
public static final String TOTAL = "total";
/**
* workflow
*/
public static final String WORKFLOW_LIST = "workFlowList";
public static final String WORKFLOW_RELATION_LIST = "workFlowRelationList";
/**
* session user
*/
public static final String SESSION_USER = "session.user";
public static final String SESSION_ID = "sessionId";
/**
* locale
*/
public static final String LOCALE_LANGUAGE = "language";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * database type
*/
public static final String MYSQL = "MYSQL";
public static final String HIVE = "HIVE";
public static final String ADDRESS = "address";
public static final String DATABASE = "database";
public static final String OTHER = "other";
public static final String USER = "user";
public static final String JDBC_URL = "jdbcUrl";
/**
* session timeout
*/
public static final int SESSION_TIME_OUT = 7200;
public static final int MAX_FILE_SIZE = 1024 * 1024 * 1024;
public static final String UDF = "UDF";
public static final String CLASS = "class";
/**
* dataSource sensitive param
*/
public static final String DATASOURCE_PASSWORD_REGEX = "(?<=((?i)password((\\\\\":\\\\\")|(=')))).*?(?=((\\\\\")|(')))";
/**
* default worker group
*/
public static final String DEFAULT_WORKER_GROUP = "default";
/**
* authorize writable perm
*/
public static final int AUTHORIZE_WRITABLE_PERM = 7;
/**
* authorize readable perm |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | */
public static final int AUTHORIZE_READABLE_PERM = 4;
public static final int NORMAL_NODE_STATUS = 0;
public static final int ABNORMAL_NODE_STATUS = 1;
public static final int BUSY_NODE_STATUE = 2;
public static final String START_TIME = "start time";
public static final String END_TIME = "end time";
public static final String START_END_DATE = "startDate,endDate";
/**
* system line separator
*/
public static final String SYSTEM_LINE_SEPARATOR = System.getProperty("line.separator");
/**
* datasource encryption salt
*/
public static final String DATASOURCE_ENCRYPTION_SALT_DEFAULT = "!@#$%^&*";
public static final String DATASOURCE_ENCRYPTION_ENABLE = "datasource.encryption.enable";
public static final String DATASOURCE_ENCRYPTION_SALT = "datasource.encryption.salt";
/**
* network interface preferred
*/
public static final String DOLPHIN_SCHEDULER_NETWORK_INTERFACE_PREFERRED = "dolphin.scheduler.network.interface.preferred";
/**
* network IP gets priority, default inner outer
*/
public static final String DOLPHIN_SCHEDULER_NETWORK_PRIORITY_STRATEGY = "dolphin.scheduler.network.priority.strategy";
/**
* exec shell scripts
*/
public static final String SH = "sh"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,080 | [Bug] [API]When the created tenant name is too long, an error message will be prompted | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When the created tenant name is too long, an error message will be prompted
### What you expected to happen
When the created tenant name is too long, an error message will be prompted
### How to reproduce
created tenant name is too long
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10080 | https://github.com/apache/dolphinscheduler/pull/10081 | 0cc0ee77faabf1bed495a55ccd7653c03c26a550 | 67cf7b280087d4424bf0c2a698c9c12ab874bd2e | 2022-05-17T13:35:22Z | java | 2022-05-17T17:36:40Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | /**
* pstree, get pud and sub pid
*/
public static final String PSTREE = "pstree";
public static final Boolean KUBERNETES_MODE = !StringUtils.isEmpty(System.getenv("KUBERNETES_SERVICE_HOST")) && !StringUtils.isEmpty(System.getenv("KUBERNETES_SERVICE_PORT"));
/**
* dry run flag
*/
public static final int DRY_RUN_FLAG_NO = 0;
public static final int DRY_RUN_FLAG_YES = 1;
/**
* data.quality.error.output.path
*/
public static final String DATA_QUALITY_ERROR_OUTPUT_PATH = "data-quality.error.output.path";
public static final String CACHE_KEY_VALUE_ALL = "'all'";
/**
* use for k8s
*/
public static final String NAMESPACE = "namespace";
public static final String K8S = "k8s";
public static final String LIMITS_CPU = "limitsCpu";
public static final String LIMITS_MEMORY = "limitsMemory";
public static final String K8S_LOCAL_TEST_CLUSTER = "ds_null_k8s";
/**
* schedule timezone
*/
public static final String SCHEDULE_TIMEZONE = "schedule_timezone";
public static final int RESOURCE_FULL_NAME_MAX_LENGTH = 128;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /*
* Lcensed to the Apache Software Foundaton (ASF) under one or more
* contrbutor lcense agreements. See the NOTICE fle dstrbuted wth
* ths work for addtonal nformaton regardng copyrght ownershp.
* The ASF lcenses ths fle to You under the Apache Lcense, Verson 2.0
* (the "Lcense"); you may not use ths fle except n complance wth
* the Lcense. You may obtan a copy of the Lcense at
*
* http://www.apache.org/lcenses/LICENSE-2.0
*
* Unless requred by applcable law or agreed to n wrtng, software
* dstrbuted under the Lcense s dstrbuted on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, ether express or mpled.
* See the Lcense for the specfc language governng permssons and
* lmtatons under the Lcense.
*/
package org.apache.dolphnscheduler.server.master.runner;
mport statc org.apache.dolphnscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE;
mport statc org.apache.dolphnscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE;
mport statc org.apache.dolphnscheduler.common.Constants.CMD_PARAM_RECOVERY_START_NODE_STRING;
mport statc org.apache.dolphnscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | mport statc org.apache.dolphnscheduler.common.Constants.CMD_PARAM_START_NODES;
mport statc org.apache.dolphnscheduler.common.Constants.DEFAULT_WORKER_GROUP;
mport statc org.apache.dolphnscheduler.plugn.task.ap.TaskConstants.TASK_TYPE_BLOCKING;
mport statc org.apache.dolphnscheduler.plugn.task.ap.enums.DataType.VARCHAR;
mport statc org.apache.dolphnscheduler.plugn.task.ap.enums.Drect.IN;
mport org.apache.dolphnscheduler.common.Constants;
mport org.apache.dolphnscheduler.common.enums.CommandType;
mport org.apache.dolphnscheduler.common.enums.FalureStrategy;
mport org.apache.dolphnscheduler.common.enums.Flag;
mport org.apache.dolphnscheduler.common.enums.Prorty;
mport org.apache.dolphnscheduler.common.enums.StateEvent;
mport org.apache.dolphnscheduler.common.enums.StateEventType;
mport org.apache.dolphnscheduler.common.enums.TaskDependType;
mport org.apache.dolphnscheduler.common.enums.TaskGroupQueueStatus;
mport org.apache.dolphnscheduler.common.enums.TmeoutFlag;
mport org.apache.dolphnscheduler.common.graph.DAG;
mport org.apache.dolphnscheduler.common.model.TaskNode;
mport org.apache.dolphnscheduler.common.model.TaskNodeRelaton;
mport org.apache.dolphnscheduler.common.process.ProcessDag;
mport org.apache.dolphnscheduler.common.utls.DateUtls;
mport org.apache.dolphnscheduler.common.utls.JSONUtls;
mport org.apache.dolphnscheduler.common.utls.NetUtls;
mport org.apache.dolphnscheduler.common.utls.ParameterUtls;
mport org.apache.dolphnscheduler.dao.entty.Command;
mport org.apache.dolphnscheduler.dao.entty.Envronment;
mport org.apache.dolphnscheduler.dao.entty.ProcessDefnton;
mport org.apache.dolphnscheduler.dao.entty.ProcessInstance;
mport org.apache.dolphnscheduler.dao.entty.ProcessTaskRelaton;
mport org.apache.dolphnscheduler.dao.entty.ProjectUser;
mport org.apache.dolphnscheduler.dao.entty.Schedule; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | mport org.apache.dolphnscheduler.dao.entty.TaskDefntonLog;
mport org.apache.dolphnscheduler.dao.entty.TaskGroupQueue;
mport org.apache.dolphnscheduler.dao.entty.TaskInstance;
mport org.apache.dolphnscheduler.dao.utls.DagHelper;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.DependResult;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.Drect;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.ExecutonStatus;
mport org.apache.dolphnscheduler.plugn.task.ap.enums.TaskTmeoutStrategy;
mport org.apache.dolphnscheduler.plugn.task.ap.model.Property;
mport org.apache.dolphnscheduler.plugn.task.ap.parameters.BlockngParameters;
mport org.apache.dolphnscheduler.remote.command.HostUpdateCommand;
mport org.apache.dolphnscheduler.remote.utls.Host;
mport org.apache.dolphnscheduler.server.master.confg.MasterConfg;
mport org.apache.dolphnscheduler.server.master.dspatch.executor.NettyExecutorManager;
mport org.apache.dolphnscheduler.server.master.runner.task.ITaskProcessor;
mport org.apache.dolphnscheduler.server.master.runner.task.TaskActon;
mport org.apache.dolphnscheduler.server.master.runner.task.TaskProcessorFactory;
mport org.apache.dolphnscheduler.servce.alert.ProcessAlertManager;
mport org.apache.dolphnscheduler.servce.process.ProcessServce;
mport org.apache.dolphnscheduler.servce.quartz.cron.CronUtls;
mport org.apache.dolphnscheduler.servce.queue.PeerTaskInstancePrortyQueue;
mport org.apache.commons.collectons.CollectonUtls;
mport org.apache.commons.lang.StrngUtls;
mport org.apache.commons.lang.math.NumberUtls;
mport java.utl.ArrayLst;
mport java.utl.Arrays;
mport java.utl.Collecton;
mport java.utl.Date;
mport java.utl.HashMap;
mport java.utl.Iterator; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | mport java.utl.Lst;
mport java.utl.Map;
mport java.utl.Objects;
mport java.utl.Set;
mport java.utl.concurrent.ConcurrentHashMap;
mport java.utl.concurrent.ConcurrentLnkedQueue;
mport java.utl.concurrent.atomc.AtomcBoolean;
mport java.utl.stream.Collectors;
mport org.slf4j.Logger;
mport org.slf4j.LoggerFactory;
mport com.google.common.collect.Lsts;
/**
* master exec thread,splt dag
*/
publc class WorkflowExecuteThread {
/**
* logger of WorkflowExecuteThread
*/
prvate statc fnal Logger logger = LoggerFactory.getLogger(WorkflowExecuteThread.class);
/**
* master confg
*/
prvate MasterConfg masterConfg;
/**
* process servce
*/
prvate ProcessServce processServce;
/**
* alert manager
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | prvate ProcessAlertManager processAlertManager;
/**
* netty executor manager
*/
prvate NettyExecutorManager nettyExecutorManager;
/**
* process nstance
*/
prvate ProcessInstance processInstance;
/**
* process defnton
*/
prvate ProcessDefnton processDefnton;
/**
* the object of DAG
*/
prvate DAG<Strng, TaskNode, TaskNodeRelaton> dag;
/**
* key of workflow
*/
prvate Strng key;
/**
* start flag, true: start nodes submt completely
*/
prvate boolean sStart = false;
/**
* submt falure nodes
*/
prvate boolean taskFaledSubmt = false;
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * task nstance hash map, taskId as key
*/
prvate Map<Integer, TaskInstance> taskInstanceMap = new ConcurrentHashMap<>();
/**
* runnng taskProcessor, taskCode as key, taskProcessor as value
* only on taskProcessor per taskCode
*/
prvate fnal Map<Long, ITaskProcessor> actveTaskProcessorMaps = new ConcurrentHashMap<>();
/**
* vald task map, taskCode as key, taskId as value
* n a DAG, only one taskInstance per taskCode s vald
*/
prvate Map<Long, Integer> valdTaskMap = new ConcurrentHashMap<>();
/**
* error task map, taskCode as key, taskInstanceId as value
* n a DAG, only one taskInstance per taskCode s vald
*/
prvate Map<Long, Integer> errorTaskMap = new ConcurrentHashMap<>();
/**
* complete task map, taskCode as key, taskInstanceId as value
* n a DAG, only one taskInstance per taskCode s vald
*/
prvate Map<Long, Integer> completeTaskMap = new ConcurrentHashMap<>();
/**
* depend faled task map, taskCode as key, taskId as value
*/
prvate Map<Long, Integer> dependFaledTaskMap = new ConcurrentHashMap<>();
/**
* forbdden task map, code as key
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | prvate Map<Long, TaskNode> forbddenTaskMap = new ConcurrentHashMap<>();
/**
* skp task map, code as key
*/
prvate Map<Strng, TaskNode> skpTaskNodeMap = new ConcurrentHashMap<>();
/**
* complement date lst
*/
prvate Lst<Date> complementLstDate = Lsts.newLnkedLst();
/**
* state event queue
*/
prvate ConcurrentLnkedQueue<StateEvent> stateEvents = new ConcurrentLnkedQueue<>();
/**
* ready to submt task queue
*/
prvate PeerTaskInstancePrortyQueue readyToSubmtTaskQueue = new PeerTaskInstancePrortyQueue();
/**
* wat to retry taskInstance map, taskCode as key, taskInstance as value
* before retry, the taskInstance d s 0
*/
prvate Map<Long, TaskInstance> watToRetryTaskInstanceMap = new ConcurrentHashMap<>();
/**
* state wheel execute thread
*/
prvate StateWheelExecuteThread stateWheelExecuteThread;
/**
* constructor of WorkflowExecuteThread
*
* @param processInstance processInstance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * @param processServce processServce
* @param nettyExecutorManager nettyExecutorManager
* @param processAlertManager processAlertManager
* @param masterConfg masterConfg
* @param stateWheelExecuteThread stateWheelExecuteThread
*/
publc WorkflowExecuteThread(ProcessInstance processInstance
, ProcessServce processServce
, NettyExecutorManager nettyExecutorManager
, ProcessAlertManager processAlertManager
, MasterConfg masterConfg
, StateWheelExecuteThread stateWheelExecuteThread) {
ths.processServce = processServce;
ths.processInstance = processInstance;
ths.masterConfg = masterConfg;
ths.nettyExecutorManager = nettyExecutorManager;
ths.processAlertManager = processAlertManager;
ths.stateWheelExecuteThread = stateWheelExecuteThread;
}
/**
* the process start nodes are submtted completely.
*/
publc boolean sStart() {
return ths.sStart;
}
/**
* handle event
*/
publc vod handleEvents() {
f (!sStart) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return;
}
whle (!ths.stateEvents.sEmpty()) {
try {
StateEvent stateEvent = ths.stateEvents.peek();
f (stateEventHandler(stateEvent)) {
ths.stateEvents.remove(stateEvent);
}
} catch (Excepton e) {
logger.error("state handle error:", e);
}
}
}
publc Strng getKey() {
f (StrngUtls.sNotEmpty(key)
|| ths.processDefnton == null) {
return key;
}
key = Strng.format("%d_%d_%d",
ths.processDefnton.getCode(),
ths.processDefnton.getVerson(),
ths.processInstance.getId());
return key;
}
publc boolean addStateEvent(StateEvent stateEvent) {
f (processInstance.getId() != stateEvent.getProcessInstanceId()) {
logger.nfo("state event would be abounded :{}", stateEvent.toStrng());
return false;
}
ths.stateEvents.add(stateEvent); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return true;
}
publc nt eventSze() {
return ths.stateEvents.sze();
}
publc ProcessInstance getProcessInstance() {
return ths.processInstance;
}
prvate boolean stateEventHandler(StateEvent stateEvent) {
logger.nfo("process event: {}", stateEvent.toStrng());
f (!checkProcessInstance(stateEvent)) {
return false;
}
boolean result = false;
swtch (stateEvent.getType()) {
case PROCESS_STATE_CHANGE:
result = pr
break;
case TASK_STATE_CHANGE:
result = taskStateChangeHandler(stateEvent);
break;
case PROCESS_TIMEOUT:
result = processTmeout();
break;
case TASK_TIMEOUT:
result = taskTmeout(stateEvent);
break;
case WAIT_TASK_GROUP:
result = checkForceStartAndWakeUp(stateEvent);
break; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | case TASK_RETRY:
result = taskRetryEventHandler(stateEvent);
break;
case PROCESS_BLOCKED:
result = processBlockHandler(stateEvent);
break;
default:
break;
}
f (result) {
ths.stateEvents.remove(stateEvent);
}
return result;
}
prvate boolean checkForceStartAndWakeUp(StateEvent stateEvent) {
TaskGroupQueue taskGroupQueue = ths.processServce.loadTaskGroupQueue(stateEvent.getTaskInstanceId());
f (taskGroupQueue.getForceStart() == Flag.YES.getCode()) {
TaskInstance taskInstance = ths.processServce.fndTaskInstanceById(stateEvent.getTaskInstanceId());
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskInstance.getTaskCode());
taskProcessor.acton(TaskActon.DISPATCH);
ths.processServce.updateTaskGroupQueueStatus(taskGroupQueue.getTaskId(), TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode());
return true;
}
f (taskGroupQueue.getInQueue() == Flag.YES.getCode()) {
boolean acqureTaskGroup = processServce.acqureTaskGroupAgan(taskGroupQueue);
f (acqureTaskGroup) {
TaskInstance taskInstance = ths.processServce.fndTaskInstanceById(stateEvent.getTaskInstanceId());
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskInstance.getTaskCode());
taskProcessor.acton(TaskActon.DISPATCH);
return true; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
}
return false;
}
prvate boolean taskTmeout(StateEvent stateEvent) {
f (!checkTaskInstanceByStateEvent(stateEvent)) {
return true;
}
TaskInstance taskInstance = taskInstanceMap.get(stateEvent.getTaskInstanceId());
f (TmeoutFlag.CLOSE == taskInstance.getTaskDefne().getTmeoutFlag()) {
return true;
}
TaskTmeoutStrategy taskTmeoutStrategy = taskInstance.getTaskDefne().getTmeoutNotfyStrategy();
f (TaskTmeoutStrategy.FAILED == taskTmeoutStrategy || TaskTmeoutStrategy.WARNFAILED == taskTmeoutStrategy) {
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskInstance.getTaskCode());
taskProcessor.acton(TaskActon.TIMEOUT);
}
f (TaskTmeoutStrategy.WARN == taskTmeoutStrategy || TaskTmeoutStrategy.WARNFAILED == taskTmeoutStrategy) {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
processAlertManager.sendTaskTmeoutAlert(processInstance, taskInstance, projectUser);
}
return true;
}
prvate boolean processTmeout() {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
ths.processAlertManager.sendProcessTmeoutAlert(ths.processInstance, projectUser);
return true;
}
prvate boolean taskStateChangeHandler(StateEvent stateEvent) {
f (!checkTaskInstanceByStateEvent(stateEvent)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return true;
}
TaskInstance task = getTaskInstance(stateEvent.getTaskInstanceId());
f (task.getState() == null) {
logger.error("task state s null, state handler error: {}", stateEvent);
return true;
}
f (task.getState().typeIsFnshed()) {
f (completeTaskMap.contansKey(task.getTaskCode()) && completeTaskMap.get(task.getTaskCode()) == task.getId()) {
return true;
}
taskFnshed(task);
f (task.getTaskGroupId() > 0) {
releaseTaskGroup(task);
}
return true;
}
f (actveTaskProcessorMaps.contansKey(task.getTaskCode())) {
ITaskProcessor TaskProcessor = actveTaskProcessorMaps.get(task.getTaskCode());
TaskProcessor.acton(TaskActon.RUN);
f (TaskProcessor.taskInstance().getState().typeIsFnshed()) {
f (TaskProcessor.taskInstance().getState() != task.getState()) {
task.setState(TaskProcessor.taskInstance().getState());
}
taskFnshed(task);
}
return true;
}
logger.error("state handler error: {}", stateEvent);
return true; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
prvate vod taskFnshed(TaskInstance taskInstance) {
logger.nfo("work flow {} task d:{} code:{} state:{} ",
processInstance.getId(),
taskInstance.getId(),
taskInstance.getTaskCode(),
taskInstance.getState());
actveTaskProcessorMaps.remove(taskInstance.getTaskCode());
stateWheelExecuteThread.removeTask4TmeoutCheck(processInstance, taskInstance);
stateWheelExecuteThread.removeTask4RetryCheck(processInstance, taskInstance);
stateWheelExecuteThread.removeTask4StateCheck(processInstance, taskInstance);
f (taskInstance.getState().typeIsSuccess()) {
completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
processInstance.setVarPool(taskInstance.getVarPool());
processServce.saveProcessInstance(processInstance);
f (!processInstance.sBlocked()) {
submtPostNode(Long.toStrng(taskInstance.getTaskCode()));
}
} else f (taskInstance.taskCanRetry() && processInstance.getState() != ExecutonStatus.READY_STOP) {
retryTaskInstance(taskInstance);
} else f (taskInstance.getState().typeIsFalure()) {
completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
f (DagHelper.haveAllNodeAfterNode(Long.toStrng(taskInstance.getTaskCode()), dag)
&& processInstance.getFalureStrategy() == FalureStrategy.CONTINUE) {
submtPostNode(Long.toStrng(taskInstance.getTaskCode()));
} else {
errorTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
f (processInstance.getFalureStrategy() == FalureStrategy.END) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | kllAllTasks();
}
}
} else f (taskInstance.getState().typeIsFnshed()) {
completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
}
ths.updateProcessInstanceState();
}
/**
* release task group
*
* @param taskInstance
*/
prvate vod releaseTaskGroup(TaskInstance taskInstance) {
f (taskInstance.getTaskGroupId() > 0) {
TaskInstance nextTaskInstance = ths.processServce.releaseTaskGroup(taskInstance);
f (nextTaskInstance != null) {
f (nextTaskInstance.getProcessInstanceId() == taskInstance.getProcessInstanceId()) {
StateEvent nextEvent = new StateEvent();
nextEvent.setProcessInstanceId(ths.processInstance.getId());
nextEvent.setTaskInstanceId(nextTaskInstance.getId());
nextEvent.setType(StateEventType.WAIT_TASK_GROUP);
ths.stateEvents.add(nextEvent);
} else {
ProcessInstance processInstance = ths.processServce.fndProcessInstanceById(nextTaskInstance.getProcessInstanceId());
ths.processServce.sendStartTask2Master(processInstance, nextTaskInstance.getId(),
org.apache.dolphnscheduler.remote.command.CommandType.TASK_WAKEUP_EVENT_REQUEST);
}
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
/**
* crate new task nstance to retry, dfferent objects from the orgnal
*
* @param taskInstance
*/
prvate vod retryTaskInstance(TaskInstance taskInstance) {
f (!taskInstance.taskCanRetry()) {
return;
}
TaskInstance newTaskInstance = cloneRetryTaskInstance(taskInstance);
f (newTaskInstance == null) {
logger.error("retry fal, new taskInstancce s null, task code:{}, task d:{}", taskInstance.getTaskCode(), taskInstance.getId());
return;
}
watToRetryTaskInstanceMap.put(newTaskInstance.getTaskCode(), newTaskInstance);
f (!taskInstance.retryTaskIntervalOverTme()) {
logger.nfo("falure task wll be submtted: process d: {}, task nstance code: {} state:{} retry tmes:{} / {}, nterval:{}",
processInstance.getId(),
newTaskInstance.getTaskCode(),
newTaskInstance.getState(),
newTaskInstance.getRetryTmes(),
newTaskInstance.getMaxRetryTmes(),
newTaskInstance.getRetryInterval());
stateWheelExecuteThread.addTask4TmeoutCheck(processInstance, newTaskInstance);
stateWheelExecuteThread.addTask4RetryCheck(processInstance, newTaskInstance);
} else {
addTaskToStandByLst(newTaskInstance);
submtStandByTask();
watToRetryTaskInstanceMap.remove(newTaskInstance.getTaskCode()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
}
/**
* handle task retry event
*
* @param stateEvent
* @return
*/
prvate boolean taskRetryEventHandler(StateEvent stateEvent) {
TaskInstance taskInstance = watToRetryTaskInstanceMap.get(stateEvent.getTaskCode());
addTaskToStandByLst(taskInstance);
submtStandByTask();
watToRetryTaskInstanceMap.remove(stateEvent.getTaskCode());
return true;
}
/**
* update process nstance
*/
publc vod refreshProcessInstance(nt processInstanceId) {
logger.nfo("process nstance update: {}", processInstanceId);
processInstance = processServce.fndProcessInstanceById(processInstanceId);
processDefnton = processServce.fndProcessDefnton(processInstance.getProcessDefntonCode(),
processInstance.getProcessDefntonVerson());
processInstance.setProcessDefnton(processDefnton);
}
/**
* update task nstance
*/
publc vod refreshTaskInstance(nt taskInstanceId) {
logger.nfo("task nstance update: {} ", taskInstanceId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | TaskInstance taskInstance = processServce.fndTaskInstanceById(taskInstanceId);
f (taskInstance == null) {
logger.error("can not fnd task nstance, d:{}", taskInstanceId);
return;
}
processServce.packageTaskInstance(taskInstance, processInstance);
taskInstanceMap.put(taskInstance.getId(), taskInstance);
valdTaskMap.remove(taskInstance.getTaskCode());
f (Flag.YES == taskInstance.getFlag()) {
valdTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
}
}
/**
* check process nstance by state event
*/
publc boolean checkProcessInstance(StateEvent stateEvent) {
f (ths.processInstance.getId() != stateEvent.getProcessInstanceId()) {
logger.error("msmatch process nstance d: {}, state event:{}",
ths.processInstance.getId(),
stateEvent);
return false;
}
return true;
}
/**
* check f task nstance exst by state event
*/
publc boolean checkTaskInstanceByStateEvent(StateEvent stateEvent) {
f (stateEvent.getTaskInstanceId() == 0) {
logger.error("task nstance d null, state event:{}", stateEvent); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return false;
}
f (!taskInstanceMap.contansKey(stateEvent.getTaskInstanceId())) {
logger.error("msmatch task nstance d, event:{}", stateEvent);
return false;
}
return true;
}
/**
* check f task nstance exst by task code
*/
publc boolean checkTaskInstanceByCode(long taskCode) {
f (taskInstanceMap == null || taskInstanceMap.sze() == 0) {
return false;
}
for (TaskInstance taskInstance : taskInstanceMap.values()) {
f (taskInstance.getTaskCode() == taskCode) {
return true;
}
}
return false;
}
/**
* check f task nstance exst by d
*/
publc boolean checkTaskInstanceById(nt taskInstanceId) {
f (taskInstanceMap == null || taskInstanceMap.sze() == 0) {
return false;
}
return taskInstanceMap.contansKey(taskInstanceId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
/**
* get task nstance from memory
*/
publc TaskInstance getTaskInstance(nt taskInstanceId) {
f (taskInstanceMap.contansKey(taskInstanceId)) {
return taskInstanceMap.get(taskInstanceId);
}
return null;
}
publc TaskInstance getTaskInstance(long taskCode) {
f (taskInstanceMap == null || taskInstanceMap.sze() == 0) {
return null;
}
for (TaskInstance taskInstance : taskInstanceMap.values()) {
f (taskInstance.getTaskCode() == taskCode) {
return taskInstance;
}
}
return null;
}
publc TaskInstance getActveTaskInstanceByTaskCode(long taskCode) {
f (actveTaskProcessorMaps.contansKey(taskCode)) {
return actveTaskProcessorMaps.get(taskCode).taskInstance();
}
return null;
}
publc TaskInstance getRetryTaskInstanceByTaskCode(long taskCode) {
f (watToRetryTaskInstanceMap.contansKey(taskCode)) {
return watToRetryTaskInstanceMap.get(taskCode); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
return null;
}
prvate boolean processStateChangeHandler(StateEvent stateEvent) {
try {
logger.nfo("process:{} state {} change to {}", processInstance.getId(), processInstance.getState(), stateEvent.getExecutonStatus());
f (stateEvent.getExecutonStatus() == ExecutonStatus.STOP) {
f (processDefnton.getExecutonType().typeIsSeralWat()){
endProcess();
return true;
}
ths.updateProcessInstanceState(stateEvent);
return true;
}
f (processComplementData()) {
return true;
}
f (stateEvent.getExecutonStatus().typeIsFnshed()) {
endProcess();
}
f (processInstance.getState() == ExecutonStatus.READY_STOP) {
kllAllTasks();
}
return true;
} catch (Excepton e) {
logger.error("process state change error:", e);
}
return true;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | prvate boolean processBlockHandler(StateEvent stateEvent) {
try {
TaskInstance task = getTaskInstance(stateEvent.getTaskInstanceId());
f (!checkTaskInstanceByStateEvent(stateEvent)) {
logger.error("task {} s not a blockng task", task.getTaskCode());
return false;
}
BlockngParameters parameters = JSONUtls.parseObject(task.getTaskParams(), BlockngParameters.class);
f (parameters.sAlertWhenBlockng()) {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
processAlertManager.sendProcessBlockngAlert(processInstance, projectUser);
logger.nfo("processInstance {} block alert send successful!", processInstance.getId());
}
} catch (Excepton e) {
logger.error("sendng blockng message error:", e);
}
return true;
}
prvate boolean processComplementData() throws Excepton {
f (!needComplementProcess()) {
return false;
}
f (processInstance.getState() == ExecutonStatus.READY_STOP) {
return false;
}
Date scheduleDate = processInstance.getScheduleTme();
f (scheduleDate == null) {
scheduleDate = complementLstDate.get(0);
} else f (processInstance.getState().typeIsFnshed()) {
endProcess(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (complementLstDate.sze() <= 0) {
logger.nfo("process complement end. process d:{}", processInstance.getId());
return true;
}
nt ndex = complementLstDate.ndexOf(scheduleDate);
f (ndex >= complementLstDate.sze() - 1 || !processInstance.getState().typeIsSuccess()) {
logger.nfo("process complement end. process d:{}", processInstance.getId());
return true;
}
logger.nfo("process complement contnue. process d:{}, schedule tme:{} complementLstDate:{}",
processInstance.getId(),
processInstance.getScheduleTme(),
complementLstDate.toStrng());
scheduleDate = complementLstDate.get(ndex + 1);
}
nt create = ths.createComplementDataCommand(scheduleDate);
f (create > 0) {
logger.nfo("create complement data command successfully.");
}
return true;
}
prvate nt createComplementDataCommand(Date scheduleDate) {
Command command = new Command();
command.setScheduleTme(scheduleDate);
command.setCommandType(CommandType.COMPLEMENT_DATA);
command.setProcessDefntonCode(processInstance.getProcessDefntonCode());
Map<Strng, Strng> cmdParam = JSONUtls.toMap(processInstance.getCommandParam());
f (cmdParam.contansKey(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
}
cmdParam.replace(CMDPARAM_COMPLEMENT_DATA_START_DATE, DateUtls.format(scheduleDate, "yyyy-MM-dd HH:mm:ss", null));
command.setCommandParam(JSONUtls.toJsonStrng(cmdParam));
command.setTaskDependType(processInstance.getTaskDependType());
command.setFalureStrategy(processInstance.getFalureStrategy());
command.setWarnngType(processInstance.getWarnngType());
command.setWarnngGroupId(processInstance.getWarnngGroupId());
command.setStartTme(new Date());
command.setExecutorId(processInstance.getExecutorId());
command.setUpdateTme(new Date());
command.setProcessInstanceProrty(processInstance.getProcessInstanceProrty());
command.setWorkerGroup(processInstance.getWorkerGroup());
command.setEnvronmentCode(processInstance.getEnvronmentCode());
command.setDryRun(processInstance.getDryRun());
command.setProcessInstanceId(0);
command.setProcessDefntonVerson(processInstance.getProcessDefntonVerson());
return processServce.createCommand(command);
}
prvate boolean needComplementProcess() {
f (processInstance.sComplementData()
&& Flag.NO == processInstance.getIsSubProcess()) {
return true;
}
return false;
}
/**
* process start handle
*/
publc vod startProcess() { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (ths.taskInstanceMap.sze() > 0) {
return;
}
try {
sStart = false;
buldFlowDag();
ntTaskQueue();
submtPostNode(null);
sStart = true;
} catch (Excepton e) {
logger.error("start process error, process nstance d:{}", processInstance.getId(), e);
}
}
/**
* process end handle
*/
publc vod endProcess() {
ths.stateEvents.clear();
f (processDefnton.getExecutonType().typeIsSeralWat()) {
checkSeralProcess(processDefnton);
}
f (processInstance.getState().typeIsWatngThread()) {
processServce.createRecoveryWatngThreadCommand(null, processInstance);
}
f (processAlertManager.sNeedToSendWarnng(processInstance)) {
ProjectUser projectUser = processServce.queryProjectWthUserByProcessInstanceId(processInstance.getId());
processAlertManager.sendAlertProcessInstance(processInstance, getValdTaskLst(), projectUser);
}
f (checkTaskQueue()) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | processServce.releaseAllTaskGroup(processInstance.getId());
}
}
publc vod checkSeralProcess(ProcessDefnton processDefnton) {
nt nextInstanceId = processInstance.getNextProcessInstanceId();
f (nextInstanceId == 0) {
ProcessInstance nextProcessInstance = ths.processServce.loadNextProcess4Seral(processInstance.getProcessDefnton().getCode(), ExecutonStatus.SERIAL_WAIT.getCode(), processInstance.getId());
f (nextProcessInstance == null) {
return;
}
nextInstanceId = nextProcessInstance.getId();
}
ProcessInstance nextProcessInstance = ths.processServce.fndProcessInstanceById(nextInstanceId);
f (nextProcessInstance.getState().typeIsFnshed() || nextProcessInstance.getState().typeIsRunnng()) {
return;
}
Map<Strng, Object> cmdParam = new HashMap<>();
cmdParam.put(CMD_PARAM_RECOVER_PROCESS_ID_STRING, nextInstanceId);
Command command = new Command();
command.setCommandType(CommandType.RECOVER_SERIAL_WAIT);
command.setProcessInstanceId(nextProcessInstance.getId());
command.setProcessDefntonCode(processDefnton.getCode());
command.setProcessDefntonVerson(processDefnton.getVerson());
command.setCommandParam(JSONUtls.toJsonStrng(cmdParam));
processServce.createCommand(command);
}
/**
* generate process dag
*
* @throws Excepton excepton |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | */
prvate vod buldFlowDag() throws Excepton {
f (ths.dag != null) {
return;
}
processDefnton = processServce.fndProcessDefnton(processInstance.getProcessDefntonCode(),
processInstance.getProcessDefntonVerson());
processInstance.setProcessDefnton(processDefnton);
Lst<TaskInstance> recoverNodeLst = getStartTaskInstanceLst(processInstance.getCommandParam());
Lst<ProcessTaskRelaton> processTaskRelatons = processServce.fndRelatonByCode(processDefnton.getCode(), processDefnton.getVerson());
Lst<TaskDefntonLog> taskDefntonLogs = processServce.getTaskDefneLogLstByRelaton(processTaskRelatons);
Lst<TaskNode> taskNodeLst = processServce.transformTask(processTaskRelatons, taskDefntonLogs);
forbddenTaskMap.clear();
taskNodeLst.forEach(taskNode -> {
f (taskNode.sForbdden()) {
forbddenTaskMap.put(taskNode.getCode(), taskNode);
}
});
Lst<Strng> recoveryNodeCodeLst = getRecoveryNodeCodeLst(recoverNodeLst);
Lst<Strng> startNodeNameLst = parseStartNodeName(processInstance.getCommandParam());
ProcessDag processDag = generateFlowDag(taskNodeLst,
startNodeNameLst, recoveryNodeCodeLst, processInstance.getTaskDependType());
f (processDag == null) {
logger.error("processDag s null");
return;
}
dag = DagHelper.buldDagGraph(processDag);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /**
* nt task queue
*/
prvate vod ntTaskQueue() {
taskFaledSubmt = false;
actveTaskProcessorMaps.clear();
dependFaledTaskMap.clear();
completeTaskMap.clear();
errorTaskMap.clear();
f (!sNewProcessInstance()) {
Lst<TaskInstance> valdTaskInstanceLst = processServce.fndValdTaskLstByProcessId(processInstance.getId());
for (TaskInstance task : valdTaskInstanceLst) {
f (valdTaskMap.contansKey(task.getTaskCode())) {
nt oldTaskInstanceId = valdTaskMap.get(task.getTaskCode());
TaskInstance oldTaskInstance = taskInstanceMap.get(oldTaskInstanceId);
f (!oldTaskInstance.getState().typeIsFnshed() && task.getState().typeIsFnshed()) {
task.setFlag(Flag.NO);
processServce.updateTaskInstance(task);
contnue;
}
logger.warn("have same taskCode taskInstance when nt task queue, taskCode:{}", task.getTaskCode());
}
valdTaskMap.put(task.getTaskCode(), task.getId());
taskInstanceMap.put(task.getId(), task);
f (task.sTaskComplete()) {
completeTaskMap.put(task.getTaskCode(), task.getId());
contnue;
}
f (task.sCondtonsTask() || DagHelper.haveCondtonsAfterNode(Long.toStrng(task.getTaskCode()), dag)) {
contnue; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
f (task.taskCanRetry()) {
f (task.getState() == ExecutonStatus.NEED_FAULT_TOLERANCE) {
TaskInstance tolerantTaskInstance = cloneTolerantTaskInstance(task);
addTaskToStandByLst(tolerantTaskInstance);
} else {
retryTaskInstance(task);
}
contnue;
}
f (task.getState().typeIsFalure()) {
errorTaskMap.put(task.getTaskCode(), task.getId());
}
}
}
f (processInstance.sComplementData() && complementLstDate.sze() == 0) {
Map<Strng, Strng> cmdParam = JSONUtls.toMap(processInstance.getCommandParam());
f (cmdParam != null && cmdParam.contansKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {
setGlobalParamIfCommanded(processDefnton, cmdParam);
Date start = DateUtls.strngToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
Date end = DateUtls.strngToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE));
Lst<Schedule> schedules = processServce.queryReleaseSchedulerLstByProcessDefntonCode(processInstance.getProcessDefntonCode());
f (complementLstDate.sze() == 0 && needComplementProcess()) {
complementLstDate = CronUtls.getSelfFreDateLst(start, end, schedules);
logger.nfo(" process defnton code:{} complement data: {}",
processInstance.getProcessDefntonCode(), complementLstDate.toStrng());
f (complementLstDate.sze() > 0 && Flag.NO == processInstance.getIsSubProcess()) {
processInstance.setScheduleTme(complementLstDate.get(0)); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | processInstance.setGlobalParams(ParameterUtls.curngGlobalParams(
processDefnton.getGlobalParamMap(),
processDefnton.getGlobalParamLst(),
CommandType.COMPLEMENT_DATA, processInstance.getScheduleTme(), cmdParam.get(Constants.SCHEDULE_TIMEZONE)));
processServce.updateProcessInstance(processInstance);
}
}
}
}
}
/**
* submt task to execute
*
* @param taskInstance task nstance
* @return TaskInstance
*/
prvate TaskInstance submtTaskExec(TaskInstance taskInstance) {
try {
processServce.packageTaskInstance(taskInstance, processInstance);
ITaskProcessor taskProcessor = TaskProcessorFactory.getTaskProcessor(taskInstance.getTaskType());
taskProcessor.nt(taskInstance, processInstance);
f (taskInstance.getState() == ExecutonStatus.RUNNING_EXECUTION
&& taskProcessor.getType().equalsIgnoreCase(Constants.COMMON_TASK_TYPE)) {
notfyProcessHostUpdate(taskInstance);
}
boolean submt = taskProcessor.acton(TaskActon.SUBMIT);
f (!submt) {
logger.error("process d:{} name:{} submt standby task d:{} name:{} faled!",
processInstance.getId(), processInstance.getName(), |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | taskInstance.getId(), taskInstance.getName());
return null;
}
f (valdTaskMap.contansKey(taskInstance.getTaskCode())) {
nt oldTaskInstanceId = valdTaskMap.get(taskInstance.getTaskCode());
f (taskInstance.getId() != oldTaskInstanceId) {
TaskInstance oldTaskInstance = taskInstanceMap.get(oldTaskInstanceId);
oldTaskInstance.setFlag(Flag.NO);
processServce.updateTaskInstance(oldTaskInstance);
valdTaskMap.remove(taskInstance.getTaskCode());
actveTaskProcessorMaps.remove(taskInstance.getTaskCode());
}
}
valdTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
taskInstanceMap.put(taskInstance.getId(), taskInstance);
actveTaskProcessorMaps.put(taskInstance.getTaskCode(), taskProcessor);
taskProcessor.acton(TaskActon.RUN);
stateWheelExecuteThread.addTask4TmeoutCheck(processInstance, taskInstance);
stateWheelExecuteThread.addTask4StateCheck(processInstance, taskInstance);
f (taskProcessor.taskInstance().getState().typeIsFnshed()) {
f (processInstance.sBlocked()) {
StateEvent processBlockEvent = new StateEvent();
processBlockEvent.setProcessInstanceId(ths.processInstance.getId());
processBlockEvent.setTaskInstanceId(taskInstance.getId());
processBlockEvent.setExecutonStatus(taskProcessor.taskInstance().getState());
processBlockEvent.setType(StateEventType.PROCESS_BLOCKED);
ths.stateEvents.add(processBlockEvent);
}
StateEvent taskStateChangeEvent = new StateEvent(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | taskStateChangeEvent.setProcessInstanceId(ths.processInstance.getId());
taskStateChangeEvent.setTaskInstanceId(taskInstance.getId());
taskStateChangeEvent.setExecutonStatus(taskProcessor.taskInstance().getState());
taskStateChangeEvent.setType(StateEventType.TASK_STATE_CHANGE);
ths.stateEvents.add(taskStateChangeEvent);
}
return taskInstance;
} catch (Excepton e) {
logger.error("submt standby task error", e);
return null;
}
}
prvate vod notfyProcessHostUpdate(TaskInstance taskInstance) {
f (StrngUtls.sEmpty(taskInstance.getHost())) {
return;
}
try {
HostUpdateCommand hostUpdateCommand = new HostUpdateCommand();
hostUpdateCommand.setProcessHost(NetUtls.getAddr(masterConfg.getLstenPort()));
hostUpdateCommand.setTaskInstanceId(taskInstance.getId());
Host host = new Host(taskInstance.getHost());
nettyExecutorManager.doExecute(host, hostUpdateCommand.convert2Command());
} catch (Excepton e) {
logger.error("notfy process host update", e);
}
}
/**
* fnd task nstance n db.
* n case submt more than one same name task n the same tme.
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * @param taskCode task code
* @param taskVerson task verson
* @return TaskInstance
*/
prvate TaskInstance fndTaskIfExsts(Long taskCode, nt taskVerson) {
Lst<TaskInstance> valdTaskInstanceLst = getValdTaskLst();
for (TaskInstance taskInstance : valdTaskInstanceLst) {
f (taskInstance.getTaskCode() == taskCode && taskInstance.getTaskDefntonVerson() == taskVerson) {
return taskInstance;
}
}
return null;
}
/**
* encapsulaton task
*
* @param processInstance process nstance
* @param taskNode taskNode
* @return TaskInstance
*/
prvate TaskInstance createTaskInstance(ProcessInstance processInstance, TaskNode taskNode) {
TaskInstance taskInstance = fndTaskIfExsts(taskNode.getCode(), taskNode.getVerson());
f (taskInstance != null) {
return taskInstance;
}
return newTaskInstance(processInstance, taskNode);
}
/**
* clone a new taskInstance for retry and reset some logc felds
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * @return
*/
publc TaskInstance cloneRetryTaskInstance(TaskInstance taskInstance) {
TaskNode taskNode = dag.getNode(Long.toStrng(taskInstance.getTaskCode()));
f (taskNode == null) {
logger.error("taskNode s null, code:{}", taskInstance.getTaskCode());
return null;
}
TaskInstance newTaskInstance = newTaskInstance(processInstance, taskNode);
newTaskInstance.setTaskDefne(taskInstance.getTaskDefne());
newTaskInstance.setProcessDefne(taskInstance.getProcessDefne());
newTaskInstance.setProcessInstance(processInstance);
newTaskInstance.setRetryTmes(taskInstance.getRetryTmes() + 1);
newTaskInstance.setState(taskInstance.getState());
newTaskInstance.setEndTme(taskInstance.getEndTme());
return newTaskInstance;
}
/**
* clone a new taskInstance for tolerant and reset some logc felds
*
* @return
*/
publc TaskInstance cloneTolerantTaskInstance(TaskInstance taskInstance) {
TaskNode taskNode = dag.getNode(Long.toStrng(taskInstance.getTaskCode()));
f (taskNode == null) {
logger.error("taskNode s null, code:{}", taskInstance.getTaskCode());
return null;
}
TaskInstance newTaskInstance = newTaskInstance(processInstance, taskNode); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | newTaskInstance.setTaskDefne(taskInstance.getTaskDefne());
newTaskInstance.setProcessDefne(taskInstance.getProcessDefne());
newTaskInstance.setProcessInstance(processInstance);
newTaskInstance.setRetryTmes(taskInstance.getRetryTmes());
newTaskInstance.setState(taskInstance.getState());
return newTaskInstance;
}
/**
* new a taskInstance
*
* @param processInstance
* @param taskNode
* @return
*/
publc TaskInstance newTaskInstance(ProcessInstance processInstance, TaskNode taskNode) {
TaskInstance taskInstance = new TaskInstance();
taskInstance.setTaskCode(taskNode.getCode());
taskInstance.setTaskDefntonVerson(taskNode.getVerson());
taskInstance.setName(taskNode.getName());
taskInstance.setState(ExecutonStatus.SUBMITTED_SUCCESS);
taskInstance.setProcessInstanceId(processInstance.getId());
taskInstance.setTaskType(taskNode.getType().toUpperCase());
taskInstance.setAlertFlag(Flag.NO);
taskInstance.setStartTme(null); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | taskInstance.setFlag(Flag.YES);
taskInstance.setDryRun(processInstance.getDryRun());
taskInstance.setRetryTmes(0);
taskInstance.setMaxRetryTmes(taskNode.getMaxRetryTmes());
taskInstance.setRetryInterval(taskNode.getRetryInterval());
taskInstance.setTaskParams(taskNode.getTaskParams());
taskInstance.setTaskGroupId(taskNode.getTaskGroupId());
taskInstance.setTaskGroupProrty(taskNode.getTaskGroupProrty());
f (taskNode.getTaskInstanceProrty() == null) {
taskInstance.setTaskInstanceProrty(Prorty.MEDIUM);
} else {
taskInstance.setTaskInstanceProrty(taskNode.getTaskInstanceProrty());
}
Strng processWorkerGroup = processInstance.getWorkerGroup();
processWorkerGroup = StrngUtls.sBlank(processWorkerGroup) ? DEFAULT_WORKER_GROUP : processWorkerGroup;
Strng taskWorkerGroup = StrngUtls.sBlank(taskNode.getWorkerGroup()) ? processWorkerGroup : taskNode.getWorkerGroup();
Long processEnvronmentCode = Objects.sNull(processInstance.getEnvronmentCode()) ? -1 : processInstance.getEnvronmentCode();
Long taskEnvronmentCode = Objects.sNull(taskNode.getEnvronmentCode()) ? processEnvronmentCode : taskNode.getEnvronmentCode();
f (!processWorkerGroup.equals(DEFAULT_WORKER_GROUP) && taskWorkerGroup.equals(DEFAULT_WORKER_GROUP)) {
taskInstance.setWorkerGroup(processWorkerGroup);
taskInstance.setEnvronmentCode(processEnvronmentCode);
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | taskInstance.setWorkerGroup(taskWorkerGroup);
taskInstance.setEnvronmentCode(taskEnvronmentCode);
}
f (!taskInstance.getEnvronmentCode().equals(-1L)) {
Envronment envronment = processServce.fndEnvronmentByCode(taskInstance.getEnvronmentCode());
f (Objects.nonNull(envronment) && StrngUtls.sNotEmpty(envronment.getConfg())) {
taskInstance.setEnvronmentConfg(envronment.getConfg());
}
}
taskInstance.setDelayTme(taskNode.getDelayTme());
return taskInstance;
}
publc vod getPreVarPool(TaskInstance taskInstance, Set<Strng> preTask) {
Map<Strng, Property> allProperty = new HashMap<>();
Map<Strng, TaskInstance> allTaskInstance = new HashMap<>();
f (CollectonUtls.sNotEmpty(preTask)) {
for (Strng preTaskCode : preTask) {
Integer taskId = completeTaskMap.get(Long.parseLong(preTaskCode));
f (taskId == null) {
contnue;
}
TaskInstance preTaskInstance = taskInstanceMap.get(taskId);
f (preTaskInstance == null) {
contnue;
}
Strng preVarPool = preTaskInstance.getVarPool();
f (StrngUtls.sNotEmpty(preVarPool)) {
Lst<Property> propertes = JSONUtls.toLst(preVarPool, Property.class);
for (Property nfo : propertes) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | setVarPoolValue(allProperty, allTaskInstance, preTaskInstance, nfo);
}
}
}
f (allProperty.sze() > 0) {
taskInstance.setVarPool(JSONUtls.toJsonStrng(allProperty.values()));
}
} else {
f (StrngUtls.sNotEmpty(processInstance.getVarPool())) {
taskInstance.setVarPool(processInstance.getVarPool());
}
}
}
prvate vod setVarPoolValue(Map<Strng, Property> allProperty, Map<Strng, TaskInstance> allTaskInstance, TaskInstance preTaskInstance, Property thsProperty) {
thsProperty.setDrect(Drect.IN);
Strng proName = thsProperty.getProp();
f (allProperty.contansKey(proName)) {
Property otherPro = allProperty.get(proName);
f (StrngUtls.sEmpty(thsProperty.getValue())) {
allProperty.put(proName, otherPro);
} else f (StrngUtls.sNotEmpty(otherPro.getValue())) {
TaskInstance otherTask = allTaskInstance.get(proName);
f (otherTask.getEndTme().getTme() > preTaskInstance.getEndTme().getTme()) {
allProperty.put(proName, thsProperty); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | allTaskInstance.put(proName, preTaskInstance);
} else {
allProperty.put(proName, otherPro);
}
} else {
allProperty.put(proName, thsProperty);
allTaskInstance.put(proName, preTaskInstance);
}
} else {
allProperty.put(proName, thsProperty);
allTaskInstance.put(proName, preTaskInstance);
}
}
/**
* get complete task nstance map, taskCode as key
*/
prvate Map<Strng, TaskInstance> getCompleteTaskInstanceMap() {
Map<Strng, TaskInstance> completeTaskInstanceMap = new HashMap<>();
for (Integer taskInstanceId : completeTaskMap.values()) {
TaskInstance taskInstance = taskInstanceMap.get(taskInstanceId);
completeTaskInstanceMap.put(Long.toStrng(taskInstance.getTaskCode()), taskInstance);
}
return completeTaskInstanceMap;
}
/**
* get vald task lst
*/
prvate Lst<TaskInstance> getValdTaskLst() {
Lst<TaskInstance> valdTaskInstanceLst = new ArrayLst<>();
for (Integer taskInstanceId : valdTaskMap.values()) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | valdTaskInstanceLst.add(taskInstanceMap.get(taskInstanceId));
}
return valdTaskInstanceLst;
}
prvate vod submtPostNode(Strng parentNodeCode) {
Set<Strng> submtTaskNodeLst = DagHelper.parsePostNodes(parentNodeCode, skpTaskNodeMap, dag, getCompleteTaskInstanceMap());
Lst<TaskInstance> taskInstances = new ArrayLst<>();
for (Strng taskNode : submtTaskNodeLst) {
TaskNode taskNodeObject = dag.getNode(taskNode);
TaskInstance exstTaskInstance = getTaskInstance(taskNodeObject.getCode());
f (exstTaskInstance != null) {
taskInstances.add(exstTaskInstance);
contnue;
}
TaskInstance task = createTaskInstance(processInstance, taskNodeObject);
taskInstances.add(task);
}
f (StrngUtls.sNotEmpty(parentNodeCode) && dag.getEndNode().contans(parentNodeCode)) {
TaskInstance endTaskInstance = taskInstanceMap.get(completeTaskMap.get(NumberUtls.toLong(parentNodeCode)));
Strng taskInstanceVarPool = endTaskInstance.getVarPool();
f (StrngUtls.sNotEmpty(taskInstanceVarPool)) {
Set<Property> taskPropertes = JSONUtls.toLst(taskInstanceVarPool, Property.class)
.stream().collect(Collectors.toSet());
Strng processInstanceVarPool = processInstance.getVarPool();
f (StrngUtls.sNotEmpty(processInstanceVarPool)) {
Set<Property> propertes = JSONUtls.toLst(processInstanceVarPool, Property.class)
.stream().collect(Collectors.toSet());
propertes.addAll(taskPropertes);
processInstance.setVarPool(JSONUtls.toJsonStrng(propertes)); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | } else {
processInstance.setVarPool(JSONUtls.toJsonStrng(taskPropertes));
}
}
}
for (TaskInstance task : taskInstances) {
f (readyToSubmtTaskQueue.contans(task)) {
contnue;
}
f (task.getId() > 0 && completeTaskMap.contansKey(task.getTaskCode())) {
logger.nfo("task {} has already run success", task.getName());
contnue;
}
f (task.getState().typeIsPause() || task.getState().typeIsCancel()) {
logger.nfo("task {} stopped, the state s {}", task.getName(), task.getState());
contnue;
}
addTaskToStandByLst(task);
}
submtStandByTask();
updateProcessInstanceState();
}
/**
* determne whether the dependences of the task node are complete
*
* @return DependResult
*/
prvate DependResult sTaskDepsComplete(Strng taskCode) {
Collecton<Strng> startNodes = dag.getBegnNode(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (startNodes.contans(taskCode)) {
return DependResult.SUCCESS;
}
TaskNode taskNode = dag.getNode(taskCode);
Lst<Strng> ndrectDepCodeLst = new ArrayLst<>();
setIndrectDepLst(taskCode, ndrectDepCodeLst);
for (Strng depsNode : ndrectDepCodeLst) {
f (dag.contansNode(depsNode) && !skpTaskNodeMap.contansKey(depsNode)) {
Long despNodeTaskCode = Long.parseLong(depsNode);
f (!completeTaskMap.contansKey(despNodeTaskCode)) {
return DependResult.WAITING;
}
Integer depsTaskId = completeTaskMap.get(despNodeTaskCode);
ExecutonStatus depTaskState = taskInstanceMap.get(depsTaskId).getState();
f (depTaskState.typeIsPause() || depTaskState.typeIsCancel()) {
return DependResult.NON_EXEC;
}
f (taskNode.sCondtonsTask() || taskNode.sBlockngTask()) {
contnue;
}
f (!dependTaskSuccess(depsNode, taskCode)) {
return DependResult.FAILED;
}
}
}
logger.nfo("taskCode: {} completeDependTaskLst: {}", taskCode, Arrays.toStrng(completeTaskMap.keySet().toArray()));
return DependResult.SUCCESS; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
/**
* Ths functon s specally used to handle the dependency stuaton where the parent node s a prohbted node.
* When the parent node s a forbdden node, the dependency relatonshp should contnue to be traced
*
* @param taskCode taskCode
* @param ndrectDepCodeLst All ndrectly dependent nodes
*/
prvate vod setIndrectDepLst(Strng taskCode, Lst<Strng> ndrectDepCodeLst) {
TaskNode taskNode = dag.getNode(taskCode);
Lst<Strng> depCodeLst = taskNode.getDepLst();
for (Strng depsNode : depCodeLst) {
f (forbddenTaskMap.contansKey(Long.parseLong(depsNode))) {
setIndrectDepLst(depsNode, ndrectDepCodeLst);
} else {
ndrectDepCodeLst.add(depsNode);
}
}
}
/**
* depend node s completed, but here need check the condton task branch s the next node
*/
prvate boolean dependTaskSuccess(Strng dependNodeName, Strng nextNodeName) {
f (dag.getNode(dependNodeName).sCondtonsTask()) {
Lst<Strng> nextTaskLst = DagHelper.parseCondtonTask(dependNodeName, skpTaskNodeMap, dag, getCompleteTaskInstanceMap());
f (!nextTaskLst.contans(nextNodeName)) {
return false;
}
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | long taskCode = Long.parseLong(dependNodeName);
Integer taskInstanceId = completeTaskMap.get(taskCode);
ExecutonStatus depTaskState = taskInstanceMap.get(taskInstanceId).getState();
f (depTaskState.typeIsFalure()) {
return false;
}
}
return true;
}
/**
* query task nstance by complete state
*
* @param state state
* @return task nstance lst
*/
prvate Lst<TaskInstance> getCompleteTaskByState(ExecutonStatus state) {
Lst<TaskInstance> resultLst = new ArrayLst<>();
for (Integer taskInstanceId : completeTaskMap.values()) {
TaskInstance taskInstance = taskInstanceMap.get(taskInstanceId);
f (taskInstance != null && taskInstance.getState() == state) {
resultLst.add(taskInstance);
}
}
return resultLst;
}
/**
* where there are ongong tasks
*
* @param state state
* @return ExecutonStatus |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | */
prvate ExecutonStatus runnngState(ExecutonStatus state) {
f (state == ExecutonStatus.READY_STOP
|| state == ExecutonStatus.READY_PAUSE
|| state == ExecutonStatus.WAITING_THREAD
|| state == ExecutonStatus.READY_BLOCK
|| state == ExecutonStatus.DELAY_EXECUTION) {
return state;
} else {
return ExecutonStatus.RUNNING_EXECUTION;
}
}
/**
* exsts falure task,contans submt falure、dependency falure,execute falure(retry after)
*
* @return Boolean whether has faled task
*/
prvate boolean hasFaledTask() {
f (ths.taskFaledSubmt) {
return true;
}
f (ths.errorTaskMap.sze() > 0) {
return true;
}
return ths.dependFaledTaskMap.sze() > 0;
}
/**
* process nstance falure
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * @return Boolean whether process nstance faled
*/
prvate boolean processFaled() {
f (hasFaledTask()) {
f (processInstance.getFalureStrategy() == FalureStrategy.END) {
return true;
}
f (processInstance.getFalureStrategy() == FalureStrategy.CONTINUE) {
return readyToSubmtTaskQueue.sze() == 0
&& actveTaskProcessorMaps.sze() == 0
&& watToRetryTaskInstanceMap.sze() == 0;
}
}
return false;
}
/**
* whether task for watng thread
*
* @return Boolean whether has watng thread task
*/
prvate boolean hasWatngThreadTask() {
Lst<TaskInstance> watngLst = getCompleteTaskByState(ExecutonStatus.WAITING_THREAD);
return CollectonUtls.sNotEmpty(watngLst);
}
/**
* prepare for pause
* 1，faled retry task n the preparaton queue , returns to falure drectly
* 2，exsts pause task，complement not completed, pendng submsson of tasks, return to suspenson
* 3，success
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * @return ExecutonStatus
*/
prvate ExecutonStatus processReadyPause() {
f (hasRetryTaskInStandBy()) {
return ExecutonStatus.FAILURE;
}
Lst<TaskInstance> pauseLst = getCompleteTaskByState(ExecutonStatus.PAUSE);
f (CollectonUtls.sNotEmpty(pauseLst)
|| processInstance.sBlocked()
|| !sComplementEnd()
|| readyToSubmtTaskQueue.sze() > 0) {
return ExecutonStatus.PAUSE;
} else {
return ExecutonStatus.SUCCESS;
}
}
/**
* prepare for block
* f process has tasks stll runnng, pause them
* f readyToSubmtTaskQueue s not empty, kll them
* else return block status drectly
*
* @return ExecutonStatus
*/
prvate ExecutonStatus processReadyBlock() {
f (actveTaskProcessorMaps.sze() > 0) {
for (ITaskProcessor taskProcessor : actveTaskProcessorMaps.values()) {
f (!TASK_TYPE_BLOCKING.equals(taskProcessor.getType())) {
taskProcessor.acton(TaskActon.PAUSE);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
}
f (readyToSubmtTaskQueue.sze() > 0) {
for (Iterator<TaskInstance> ter = readyToSubmtTaskQueue.terator(); ter.hasNext(); ) {
ter.next().setState(ExecutonStatus.KILL);
}
}
return ExecutonStatus.BLOCK;
}
/**
* generate the latest process nstance status by the tasks state
*
* @return process nstance executon status
*/
prvate ExecutonStatus getProcessInstanceState(ProcessInstance nstance) {
ExecutonStatus state = nstance.getState();
f (actveTaskProcessorMaps.sze() > 0 || hasRetryTaskInStandBy()) {
// actve
return runnngState(state);
}
// block
f (state == ExecutonStatus.READY_BLOCK) {
return processReadyBlock();
}
// watng thread
f (hasWatngThreadTask()) {
return ExecutonStatus.WAITING_THREAD;
}
// pause
f (state == ExecutonStatus.READY_PAUSE) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return processReadyPause();
}
// stop
f (state == ExecutonStatus.READY_STOP) {
Lst<TaskInstance> stopLst = getCompleteTaskByState(ExecutonStatus.STOP);
Lst<TaskInstance> kllLst = getCompleteTaskByState(ExecutonStatus.KILL);
Lst<TaskInstance> falLst = getCompleteTaskByState(ExecutonStatus.FAILURE);
f (CollectonUtls.sNotEmpty(stopLst)
|| CollectonUtls.sNotEmpty(kllLst)
|| CollectonUtls.sNotEmpty(falLst)
|| !sComplementEnd()) {
return ExecutonStatus.STOP;
} else {
return ExecutonStatus.SUCCESS;
}
}
// process falure
f (processFaled()) {
return ExecutonStatus.FAILURE;
}
// success
f (state == ExecutonStatus.RUNNING_EXECUTION) {
Lst<TaskInstance> kllTasks = getCompleteTaskByState(ExecutonStatus.KILL);
f (readyToSubmtTaskQueue.sze() > 0 || watToRetryTaskInstanceMap.sze() > 0) {
//tasks cu
return ExecutonStatus.RUNNING_EXECUTION;
} else f (CollectonUtls.sNotEmpty(kllTasks)) {
// tasks m
return ExecutonStatus.FAILURE;
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | // f the
return ExecutonStatus.SUCCESS;
}
}
return state;
}
/**
* whether complement end
*
* @return Boolean whether s complement end
*/
prvate boolean sComplementEnd() {
f (!processInstance.sComplementData()) {
return true;
}
try {
Map<Strng, Strng> cmdParam = JSONUtls.toMap(processInstance.getCommandParam());
Date endTme = DateUtls.getScheduleDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE));
return processInstance.getScheduleTme().equals(endTme);
} catch (Excepton e) {
logger.error("complement end faled ", e);
return false;
}
}
/**
* updateProcessInstance process nstance state
* after each batch of tasks s executed, the status of the process nstance s updated
*/
prvate vod updateProcessInstanceState() {
ExecutonStatus state = getProcessInstanceState(processInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | f (processInstance.getState() != state) {
logger.nfo(
"work flow process nstance [d: {}, name:{}], state change from {} to {}, cmd type: {}",
processInstance.getId(), processInstance.getName(),
processInstance.getState(), state,
processInstance.getCommandType());
processInstance.setState(state);
f (state.typeIsFnshed()) {
processInstance.setEndTme(new Date());
}
processServce.updateProcessInstance(processInstance);
StateEvent stateEvent = new StateEvent();
stateEvent.setExecutonStatus(processInstance.getState());
stateEvent.setProcessInstanceId(ths.processInstance.getId());
stateEvent.setType(StateEventType.PROCESS_STATE_CHANGE);
// ths.pr
// replace
ths.stateEvents.add(stateEvent);
}
}
/**
* stateEvent's executon status as process nstance state
*/
prvate vod updateProcessInstanceState(StateEvent stateEvent) {
ExecutonStatus state = stateEvent.getExecutonStatus();
f (processInstance.getState() != state) {
logger.nfo(
"work flow process nstance [d: {}, name:{}], state change from {} to {}, cmd type: {}",
processInstance.getId(), processInstance.getName(),
processInstance.getState(), state, |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | processInstance.getCommandType());
processInstance.setState(state);
f (state.typeIsFnshed()) {
processInstance.setEndTme(new Date());
}
processServce.updateProcessInstance(processInstance);
}
}
/**
* get task dependency result
*
* @param taskInstance task nstance
* @return DependResult
*/
prvate DependResult getDependResultForTask(TaskInstance taskInstance) {
return sTaskDepsComplete(Long.toStrng(taskInstance.getTaskCode()));
}
/**
* add task to standby lst
*
* @param taskInstance task nstance
*/
prvate vod addTaskToStandByLst(TaskInstance taskInstance) {
try {
f (readyToSubmtTaskQueue.contans(taskInstance)) {
logger.warn("task was found n ready submt queue, task code:{}", taskInstance.getTaskCode());
return;
}
logger.nfo("add task to stand by lst, task name:{}, task d:{}, task code:{}",
taskInstance.getName(), taskInstance.getId(), taskInstance.getTaskCode()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | readyToSubmtTaskQueue.put(taskInstance);
} catch (Excepton e) {
logger.error("add task nstance to readyToSubmtTaskQueue, taskName:{}, task d:{}", taskInstance.getName(), taskInstance.getId(), e);
}
}
/**
* remove task from stand by lst
*
* @param taskInstance task nstance
*/
prvate vod removeTaskFromStandbyLst(TaskInstance taskInstance) {
logger.nfo("remove task from stand by lst, d: {} name:{}",
taskInstance.getId(),
taskInstance.getName());
try {
readyToSubmtTaskQueue.remove(taskInstance);
} catch (Excepton e) {
logger.error("remove task nstance from readyToSubmtTaskQueue error, task d:{}, Name: {}",
taskInstance.getId(),
taskInstance.getName(), e);
}
}
/**
* has retry task n standby
*
* @return Boolean whether has retry task n standby
*/
prvate boolean hasRetryTaskInStandBy() {
for (Iterator<TaskInstance> ter = readyToSubmtTaskQueue.terator(); ter.hasNext(); ) {
f (ter.next().getState().typeIsFalure()) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | return true;
}
}
return false;
}
/**
* close the on gong tasks
*/
prvate vod kllAllTasks() {
logger.nfo("kll called on process nstance d: {}, num: {}", processInstance.getId(),
actveTaskProcessorMaps.sze());
f (readyToSubmtTaskQueue.sze() > 0) {
readyToSubmtTaskQueue.clear();
}
for (long taskCode : actveTaskProcessorMaps.keySet()) {
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskCode);
Integer taskInstanceId = valdTaskMap.get(taskCode);
f (taskInstanceId == null || taskInstanceId.equals(0)) {
contnue;
}
TaskInstance taskInstance = processServce.fndTaskInstanceById(taskInstanceId);
f (taskInstance == null || taskInstance.getState().typeIsFnshed()) {
contnue;
}
taskProcessor.acton(TaskActon.STOP);
f (taskProcessor.taskInstance().getState().typeIsFnshed()) {
StateEvent stateEvent = new StateEvent();
stateEvent.setType(StateEventType.TASK_STATE_CHANGE);
stateEvent.setProcessInstanceId(ths.processInstance.getId());
stateEvent.setTaskInstanceId(taskInstance.getId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | stateEvent.setExecutonStatus(taskProcessor.taskInstance().getState());
ths.addStateEvent(stateEvent);
}
}
}
publc boolean workFlowFnsh() {
return ths.processInstance.getState().typeIsFnshed();
}
/**
* handlng the lst of tasks to be submtted
*/
prvate vod submtStandByTask() {
try {
nt length = readyToSubmtTaskQueue.sze();
for (nt = 0; < length; ++) {
TaskInstance task = readyToSubmtTaskQueue.peek();
f (task == null) {
contnue;
}
// stop ta
f (task.taskCanRetry()) {
TaskInstance retryTask = processServce.fndTaskInstanceById(task.getId());
f (retryTask != null && retryTask.getState().equals(ExecutonStatus.FORCED_SUCCESS)) {
task.setState(retryTask.getState());
logger.nfo("task: {} has been forced success, put t nto complete task lst and stop retryng", task.getName());
removeTaskFromStandbyLst(task);
completeTaskMap.put(task.getTaskCode(), task.getId());
taskInstanceMap.put(task.getId(), task);
submtPostNode(Long.toStrng(task.getTaskCode()));
contnue; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
}
//nt var
f (task.sFrstRun()) {
//get pre
Set<Strng> preTask = dag.getPrevousNodes(Long.toStrng(task.getTaskCode()));
getPreVarPool(task, preTask);
}
DependResult dependResult = getDependResultForTask(task);
f (DependResult.SUCCESS == dependResult) {
TaskInstance taskInstance = submtTaskExec(task);
f (taskInstance == null) {
ths.taskFaledSubmt = true;
// Remove
removeTaskFromStandbyLst(task);
completeTaskMap.put(task.getTaskCode(), task.getId());
errorTaskMap.put(task.getTaskCode(), task.getId());
logger.error("process {}, task {}, code:{} submt task faled.", task.getProcessInstanceId(), task.getName(), task.getTaskCode());
} else {
removeTaskFromStandbyLst(task);
}
} else f (DependResult.FAILED == dependResult) {
// f the
dependFaledTaskMap.put(task.getTaskCode(), task.getId());
removeTaskFromStandbyLst(task);
logger.nfo("task {},d:{} depend result : {}", task.getName(), task.getId(), dependResult);
} else f (DependResult.NON_EXEC == dependResult) {
// for som
removeTaskFromStandbyLst(task);
logger.nfo("remove task {},d:{} , because depend result : {}", task.getName(), task.getId(), dependResult); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | }
}
} catch (Excepton e) {
logger.error("submt standby task error", e);
}
}
/**
* get recovery task nstance lst
*
* @param taskIdArray task d array
* @return recovery task nstance lst
*/
prvate Lst<TaskInstance> getRecoverTaskInstanceLst(Strng[] taskIdArray) {
f (taskIdArray == null || taskIdArray.length == 0) {
return new ArrayLst<>();
}
Lst<Integer> taskIdLst = new ArrayLst<>(taskIdArray.length);
for (Strng taskId : taskIdArray) {
try {
Integer d = Integer.valueOf(taskId);
taskIdLst.add(d);
} catch (Excepton e) {
logger.error("get recovery task nstance faled ", e);
}
}
return processServce.fndTaskInstanceByIdLst(taskIdLst);
}
/**
* get start task nstance lst
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * @param cmdParam command param
* @return task nstance lst
*/
prvate Lst<TaskInstance> getStartTaskInstanceLst(Strng cmdParam) {
Lst<TaskInstance> nstanceLst = new ArrayLst<>();
Map<Strng, Strng> paramMap = JSONUtls.toMap(cmdParam);
f (paramMap != null && paramMap.contansKey(CMD_PARAM_RECOVERY_START_NODE_STRING)) {
Strng[] dLst = paramMap.get(CMD_PARAM_RECOVERY_START_NODE_STRING).splt(Constants.COMMA);
nstanceLst = getRecoverTaskInstanceLst(dLst);
}
return nstanceLst;
}
/**
* parse "StartNodeNameLst" from cmd param
*
* @param cmdParam command param
* @return start node name lst
*/
prvate Lst<Strng> parseStartNodeName(Strng cmdParam) {
Lst<Strng> startNodeNameLst = new ArrayLst<>();
Map<Strng, Strng> paramMap = JSONUtls.toMap(cmdParam);
f (paramMap == null) {
return startNodeNameLst;
}
f (paramMap.contansKey(CMD_PARAM_START_NODES)) {
startNodeNameLst = Arrays.asLst(paramMap.get(CMD_PARAM_START_NODES).splt(Constants.COMMA));
}
return startNodeNameLst;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | * generate start node code lst from parsng command param;
* f "StartNodeIdLst" exsts n command param, return StartNodeIdLst
*
* @return recovery node code lst
*/
prvate Lst<Strng> getRecoveryNodeCodeLst(Lst<TaskInstance> recoverNodeLst) {
Lst<Strng> recoveryNodeCodeLst = new ArrayLst<>();
f (CollectonUtls.sNotEmpty(recoverNodeLst)) {
for (TaskInstance task : recoverNodeLst) {
recoveryNodeCodeLst.add(Long.toStrng(task.getTaskCode()));
}
}
return recoveryNodeCodeLst;
}
/**
* generate flow dag
*
* @param totalTaskNodeLst total task node lst
* @param startNodeNameLst start node name lst
* @param recoveryNodeCodeLst recovery node code lst
* @param depNodeType depend node type
* @return ProcessDag process dag
* @throws Excepton excepton
*/
publc ProcessDag generateFlowDag(Lst<TaskNode> totalTaskNodeLst,
Lst<Strng> startNodeNameLst,
Lst<Strng> recoveryNodeCodeLst,
TaskDependType depNodeType) throws Excepton {
return DagHelper.generateFlowDag(totalTaskNodeLst, startNodeNameLst, recoveryNodeCodeLst, depNodeType);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | /**
* check task queue
*/
prvate boolean checkTaskQueue() {
AtomcBoolean result = new AtomcBoolean(false);
taskInstanceMap.forEach((d, taskInstance) -> {
f (taskInstance != null && taskInstance.getTaskGroupId() > 0) {
result.set(true);
}
});
return result.get();
}
/**
* s new process nstance
*/
prvate boolean sNewProcessInstance() {
f (ExecutonStatus.RUNNING_EXECUTION == processInstance.getState() && processInstance.getRunTmes() == 1) {
return true;
} else f (processInstance.getRecovery().equals(Flag.YES)) {
// host s
return false;
} else {
return false;
}
}
prvate vod setGlobalParamIfCommanded(ProcessDefnton processDefnton, Map<Strng, Strng> cmdParam) {
// get start params from command param
Map<Strng, Strng> startParamMap = new HashMap<>();
f (cmdParam.contansKey(Constants.CMD_PARAM_START_PARAMS)) {
Strng startParamJson = cmdParam.get(Constants.CMD_PARAM_START_PARAMS); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java | startParamMap = JSONUtls.toMap(startParamJson);
}
Map<Strng, Strng> fatherParamMap = new HashMap<>();
f (cmdParam.contansKey(Constants.CMD_PARAM_FATHER_PARAMS)) {
Strng fatherParamJson = cmdParam.get(Constants.CMD_PARAM_FATHER_PARAMS);
fatherParamMap = JSONUtls.toMap(fatherParamJson);
}
startParamMap.putAll(fatherParamMap);
// set start param nto global params
Map<Strng, Strng> globalMap = processDefnton.getGlobalParamMap();
Lst<Property> globalParamLst = processDefnton.getGlobalParamLst();
f (startParamMap.sze() > 0 && globalMap != null) {
//start pa
for (Map.Entry<Strng, Strng> param : globalMap.entrySet()) {
Strng val = startParamMap.get(param.getKey());
f (val != null) {
param.setValue(val);
}
}
//start pa
for (Map.Entry<Strng, Strng> startParam : startParamMap.entrySet()) {
f (!globalMap.contansKey(startParam.getKey())) {
globalMap.put(startParam.getKey(), startParam.getValue());
globalParamLst.add(new Property(startParam.getKey(), IN, VARCHAR, startParam.getValue()));
}
}
}
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ConditionTaskProcessor.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License. |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ConditionTaskProcessor.java | */
package org.apache.dolphinscheduler.server.master.runner.task;
import static org.apache.dolphinscheduler.plugin.task.api.TaskConstants.TASK_TYPE_CONDITIONS;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.plugin.task.api.enums.TaskTimeoutStrategy;
import org.apache.dolphinscheduler.common.utils.NetUtils;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.plugin.task.api.enums.DependResult;
import org.apache.dolphinscheduler.plugin.task.api.enums.ExecutionStatus;
import org.apache.dolphinscheduler.plugin.task.api.model.DependentItem;
import org.apache.dolphinscheduler.plugin.task.api.model.DependentTaskModel;
import org.apache.dolphinscheduler.plugin.task.api.parameters.DependentParameters;
import org.apache.dolphinscheduler.plugin.task.api.utils.DependentUtils;
import org.apache.dolphinscheduler.server.utils.LogUtils;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import com.google.auto.service.AutoService;
/**
* condition task processor
*/
@AutoService(ITaskProcessor.class)
public class ConditionTaskProcessor extends BaseTaskProcessor {
/**
* dependent parameters
*/
private DependentParameters dependentParameters;
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ConditionTaskProcessor.java | * condition result
*/
private DependResult conditionResult = DependResult.WAITING;
/**
* complete task map
*/
private Map<Long, ExecutionStatus> completeTaskList = new ConcurrentHashMap<>();
@Override
public boolean submitTask() {
this.taskInstance = processService.submitTaskWithRetry(processInstance, taskInstance, maxRetryTimes, commitInterval);
if (this.taskInstance == null) {
return false;
}
this.setTaskExecutionLogger();
initTaskParameters();
logger.info("dependent task start");
return true;
}
@Override
public boolean runTask() {
if (conditionResult.equals(DependResult.WAITING)) {
setConditionResult();
endTask();
} else {
endTask();
}
return true;
}
@Override
protected boolean dispatchTask() { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ConditionTaskProcessor.java | return true;
}
@Override
protected boolean pauseTask() {
this.taskInstance.setState(ExecutionStatus.PAUSE);
this.taskInstance.setEndTime(new Date());
processService.saveTaskInstance(taskInstance);
return true;
}
@Override
protected boolean taskTimeout() {
TaskTimeoutStrategy taskTimeoutStrategy = taskInstance.getTaskDefine().getTimeoutNotifyStrategy();
if (taskTimeoutStrategy == TaskTimeoutStrategy.WARN) {
return true;
}
logger.info("condition task {} timeout, strategy {} ",
taskInstance.getId(), taskTimeoutStrategy.getDescp());
conditionResult = DependResult.FAILED;
endTask();
return true;
}
@Override
protected boolean killTask() {
this.taskInstance.setState(ExecutionStatus.KILL);
this.taskInstance.setEndTime(new Date());
processService.saveTaskInstance(taskInstance);
return true;
}
@Override
public String getType() { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ConditionTaskProcessor.java | return TASK_TYPE_CONDITIONS;
}
private void initTaskParameters() {
taskInstance.setLogPath(LogUtils.getTaskLogPath(taskInstance.getFirstSubmitTime(), processInstance.getProcessDefinitionCode(),
processInstance.getProcessDefinitionVersion(),
taskInstance.getProcessInstanceId(),
taskInstance.getId()));
this.taskInstance.setHost(NetUtils.getAddr(masterConfig.getListenPort()));
taskInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
taskInstance.setStartTime(new Date());
this.processService.saveTaskInstance(taskInstance);
this.dependentParameters = taskInstance.getDependency();
}
private void setConditionResult() {
List<TaskInstance> taskInstances = processService.findValidTaskListByProcessId(taskInstance.getProcessInstanceId());
for (TaskInstance task : taskInstances) {
completeTaskList.putIfAbsent(task.getTaskCode(), task.getState());
}
List<DependResult> modelResultList = new ArrayList<>();
for (DependentTaskModel dependentTaskModel : dependentParameters.getDependTaskList()) {
List<DependResult> itemDependResult = new ArrayList<>();
for (DependentItem item : dependentTaskModel.getDependItemList()) {
itemDependResult.add(getDependResultForItem(item));
}
DependResult modelResult = DependentUtils.getDependResultForRelation(dependentTaskModel.getRelation(), itemDependResult);
modelResultList.add(modelResult);
}
conditionResult = DependentUtils.getDependResultForRelation(dependentParameters.getRelation(), modelResultList);
logger.info("the conditions task depend result : {}", conditionResult);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,049 | [BUG] [Plugin] Conditions Task branch flow failed | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10049 | https://github.com/apache/dolphinscheduler/pull/10077 | 701b535ae6a9fdd7c67797528fb9ff8f650db514 | 225cb332d18e2fef58bf653d644f415dfcce2e99 | 2022-05-17T02:10:46Z | java | 2022-05-18T03:40:32Z | dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/ConditionTaskProcessor.java | /**
* depend result for depend item
*/
private DependResult getDependResultForItem(DependentItem item) {
DependResult dependResult = DependResult.SUCCESS;
if (!completeTaskList.containsKey(item.getDepTaskCode())) {
logger.info("depend item: {} have not completed yet.", item.getDepTaskCode());
dependResult = DependResult.FAILED;
return dependResult;
}
ExecutionStatus executionStatus = completeTaskList.get(item.getDepTaskCode());
if (executionStatus != item.getStatus()) {
logger.info("depend item : {} expect status: {}, actual status: {}", item.getDepTaskCode(), item.getStatus(), executionStatus);
dependResult = DependResult.FAILED;
}
logger.info("dependent item complete {} {},{}",
Constants.DEPENDENT_SPLIT, item.getDepTaskCode(), dependResult);
return dependResult;
}
/**
*
*/
private void endTask() {
ExecutionStatus status = (conditionResult == DependResult.SUCCESS) ? ExecutionStatus.SUCCESS : ExecutionStatus.FAILURE;
taskInstance.setState(status);
taskInstance.setEndTime(new Date());
processService.updateTaskInstance(taskInstance);
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.common;
import org.apache.dolphinscheduler.plugin.task.api.enums.ExecutionStatus;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang.SystemUtils;
import java.util.regex.Pattern;
/**
* Constants
*/
public final class Constants { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | private Constants() {
throw new UnsupportedOperationException("Construct Constants");
}
/**
* common properties path
*/
public static final String COMMON_PROPERTIES_PATH = "/common.properties";
/**
* registry properties
*/
public static final String REGISTRY_DOLPHINSCHEDULER_MASTERS = "/nodes/master";
public static final String REGISTRY_DOLPHINSCHEDULER_WORKERS = "/nodes/worker";
public static final String REGISTRY_DOLPHINSCHEDULER_DEAD_SERVERS = "/dead-servers";
public static final String REGISTRY_DOLPHINSCHEDULER_NODE = "/nodes";
public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_MASTERS = "/lock/masters";
public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_FAILOVER_MASTERS = "/lock/failover/masters";
public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_FAILOVER_WORKERS = "/lock/failover/workers";
public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_FAILOVER_STARTUP_MASTERS = "/lock/failover/startup-masters";
public static final String FORMAT_SS = "%s%s";
public static final String FORMAT_S_S = "%s/%s";
public static final String AWS_ACCESS_KEY_ID = "aws.access.key.id";
public static final String AWS_SECRET_ACCESS_KEY = "aws.secret.access.key";
public static final String AWS_REGION = "aws.region";
public static final String FOLDER_SEPARATOR = "/";
public static final String RESOURCE_TYPE_FILE = "resources"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String RESOURCE_TYPE_UDF = "udfs";
public static final String STORAGE_S3 = "S3";
public static final String STORAGE_HDFS = "HDFS";
public static final String BUCKET_NAME = "dolphinscheduler-test";
/**
* fs.defaultFS
*/
public static final String FS_DEFAULT_FS = "fs.defaultFS";
/**
* hadoop configuration
*/
public static final String HADOOP_RM_STATE_ACTIVE = "ACTIVE";
public static final String HADOOP_RESOURCE_MANAGER_HTTPADDRESS_PORT = "resource.manager.httpaddress.port";
/**
* yarn.resourcemanager.ha.rm.ids
*/
public static final String YARN_RESOURCEMANAGER_HA_RM_IDS = "yarn.resourcemanager.ha.rm.ids";
/**
* yarn.application.status.address
*/
public static final String YARN_APPLICATION_STATUS_ADDRESS = "yarn.application.status.address";
/**
* yarn.job.history.status.address
*/
public static final String YARN_JOB_HISTORY_STATUS_ADDRESS = "yarn.job.history.status.address";
/**
* hdfs configuration
* hdfs.root.user
*/
public static final String HDFS_ROOT_USER = "hdfs.root.user"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | /**
* hdfs/s3 configuration
* resource.upload.path
*/
public static final String RESOURCE_UPLOAD_PATH = "resource.upload.path";
/**
* data basedir path
*/
public static final String DATA_BASEDIR_PATH = "data.basedir.path";
/**
* dolphinscheduler.env.path
*/
public static final String DOLPHINSCHEDULER_ENV_PATH = "dolphinscheduler.env.path";
/**
* environment properties default path
*/
public static final String ENV_PATH = "dolphinscheduler_env.sh";
/**
* resource.view.suffixs
*/
public static final String RESOURCE_VIEW_SUFFIXES = "resource.view.suffixs";
public static final String RESOURCE_VIEW_SUFFIXES_DEFAULT_VALUE = "txt,log,sh,bat,conf,cfg,py,java,sql,xml,hql,properties,json,yml,yaml,ini,js";
/**
* development.state
*/
public static final String DEVELOPMENT_STATE = "development.state";
/**
* sudo enable
*/
public static final String SUDO_ENABLE = "sudo.enable"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | /**
* string true
*/
public static final String STRING_TRUE = "true";
/**
* resource storage type
*/
public static final String RESOURCE_STORAGE_TYPE = "resource.storage.type";
public static final String AWS_END_POINT = "aws.endpoint";
/**
* comma ,
*/
public static final String COMMA = ",";
/**
* COLON :
*/
public static final String COLON = ":";
/**
* QUESTION ?
*/
public static final String QUESTION = "?";
/**
* SPACE " "
*/
public static final String SPACE = " ";
/**
* SINGLE_SLASH /
*/
public static final String SINGLE_SLASH = "/";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * DOUBLE_SLASH //
*/
public static final String DOUBLE_SLASH = "//";
/**
* EQUAL SIGN
*/
public static final String EQUAL_SIGN = "=";
/**
* AT SIGN
*/
public static final String AT_SIGN = "@";
/**
* date format of yyyy-MM-dd HH:mm:ss
*/
public static final String YYYY_MM_DD_HH_MM_SS = "yyyy-MM-dd HH:mm:ss";
/**
* date format of yyyyMMdd
*/
public static final String YYYYMMDD = "yyyyMMdd";
/**
* date format of yyyyMMddHHmmss
*/
public static final String YYYYMMDDHHMMSS = "yyyyMMddHHmmss";
/**
* date format of yyyyMMddHHmmssSSS
*/
public static final String YYYYMMDDHHMMSSSSS = "yyyyMMddHHmmssSSS";
/**
* http connect time out
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final int HTTP_CONNECT_TIMEOUT = 60 * 1000;
/**
* http connect request time out
*/
public static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 60 * 1000;
/**
* httpclient soceket time out
*/
public static final int SOCKET_TIMEOUT = 60 * 1000;
/**
* registry session timeout
*/
public static final int REGISTRY_SESSION_TIMEOUT = 10 * 1000;
/**
* http header
*/
public static final String HTTP_HEADER_UNKNOWN = "unKnown";
/**
* http X-Forwarded-For
*/
public static final String HTTP_X_FORWARDED_FOR = "X-Forwarded-For";
/**
* http X-Real-IP
*/
public static final String HTTP_X_REAL_IP = "X-Real-IP";
/**
* UTF-8
*/
public static final String UTF_8 = "UTF-8";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * user name regex
*/
public static final Pattern REGEX_USER_NAME = Pattern.compile("^[a-zA-Z0-9._-]{3,39}$");
/**
* read permission
*/
public static final int READ_PERMISSION = 2;
/**
* write permission
*/
public static final int WRITE_PERMISSION = 2 * 2;
/**
* execute permission
*/
public static final int EXECUTE_PERMISSION = 1;
/**
* default admin permission
*/
public static final int DEFAULT_ADMIN_PERMISSION = 7;
/**
* default hash map size
*/
public static final int DEFAULT_HASH_MAP_SIZE = 16;
/**
* all permissions
*/
public static final int ALL_PERMISSIONS = READ_PERMISSION | WRITE_PERMISSION | EXECUTE_PERMISSION;
/**
* max task timeout
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final int MAX_TASK_TIMEOUT = 24 * 3600;
/**
* worker host weight
*/
public static final int DEFAULT_WORKER_HOST_WEIGHT = 100;
/**
* time unit secong to minutes
*/
public static final int SEC_2_MINUTES_TIME_UNIT = 60;
/***
*
* rpc port
*/
public static final String RPC_PORT = "rpc.port";
/**
* forbid running task
*/
public static final String FLOWNODE_RUN_FLAG_FORBIDDEN = "FORBIDDEN";
/**
* normal running task
*/
public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL";
public static final String COMMON_TASK_TYPE = "common";
public static final String DEFAULT = "default";
public static final String PASSWORD = "password";
public static final String XXXXXX = "******";
public static final String NULL = "NULL";
public static final String THREAD_NAME_MASTER_SERVER = "Master-Server";
public static final String THREAD_NAME_WORKER_SERVER = "Worker-Server";
public static final String THREAD_NAME_ALERT_SERVER = "Alert-Server"; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | /**
* command parameter keys
*/
public static final String CMD_PARAM_RECOVER_PROCESS_ID_STRING = "ProcessInstanceId";
public static final String CMD_PARAM_RECOVERY_START_NODE_STRING = "StartNodeIdList";
public static final String CMD_PARAM_RECOVERY_WAITING_THREAD = "WaitingThreadInstanceId";
public static final String CMD_PARAM_SUB_PROCESS = "processInstanceId";
public static final String CMD_PARAM_EMPTY_SUB_PROCESS = "0";
public static final String CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID = "parentProcessInstanceId";
public static final String CMD_PARAM_SUB_PROCESS_DEFINE_CODE = "processDefinitionCode";
public static final String CMD_PARAM_START_NODES = "StartNodeList";
public static final String CMD_PARAM_START_PARAMS = "StartParams";
public static final String CMD_PARAM_FATHER_PARAMS = "fatherParams";
/**
* complement data start date
*/
public static final String CMDPARAM_COMPLEMENT_DATA_START_DATE = "complementStartDate";
/**
* complement data end date
*/
public static final String CMDPARAM_COMPLEMENT_DATA_END_DATE = "complementEndDate";
/**
* complement date default cron string
*/
public static final String DEFAULT_CRON_STRING = "0 0 0 * * ? *";
/**
* sleep 1000ms
*/
public static final int SLEEP_TIME_MILLIS = 1000;
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * short sleep 100ms
*/
public static final int SLEEP_TIME_MILLIS_SHORT = 100;
/**
* one second mils
*/
public static final int SECOND_TIME_MILLIS = 1000;
/**
* master task instance cache-database refresh interval
*/
public static final int CACHE_REFRESH_TIME_MILLIS = 20 * 1000;
/**
* heartbeat for zk info length
*/
public static final int HEARTBEAT_FOR_ZOOKEEPER_INFO_LENGTH = 13;
/**
* jar
*/
public static final String JAR = "jar";
/**
* hadoop
*/
public static final String HADOOP = "hadoop";
/**
* -D <property>=<value>
*/
public static final String D = "-D";
/**
* exit code success
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final int EXIT_CODE_SUCCESS = 0;
/**
* exit code failure
*/
public static final int EXIT_CODE_FAILURE = -1;
/**
* process or task definition failure
*/
public static final int DEFINITION_FAILURE = -1;
/**
* process or task definition first version
*/
public static final int VERSION_FIRST = 1;
/**
* date format of yyyyMMdd
*/
public static final String PARAMETER_FORMAT_DATE = "yyyyMMdd";
/**
* date format of yyyyMMddHHmmss
*/
public static final String PARAMETER_FORMAT_TIME = "yyyyMMddHHmmss";
/**
* system date(yyyyMMddHHmmss)
*/
public static final String PARAMETER_DATETIME = "system.datetime";
/**
* system date(yyyymmdd) today
*/
public static final String PARAMETER_CURRENT_DATE = "system.biz.curdate";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * system date(yyyymmdd) yesterday
*/
public static final String PARAMETER_BUSINESS_DATE = "system.biz.date";
/**
* ACCEPTED
*/
public static final String ACCEPTED = "ACCEPTED";
/**
* SUCCEEDED
*/
public static final String SUCCEEDED = "SUCCEEDED";
/**
* ENDED
*/
public static final String ENDED = "ENDED";
/**
* NEW
*/
public static final String NEW = "NEW";
/**
* NEW_SAVING
*/
public static final String NEW_SAVING = "NEW_SAVING";
/**
* SUBMITTED
*/
public static final String SUBMITTED = "SUBMITTED";
/**
* FAILED
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | public static final String FAILED = "FAILED";
/**
* KILLED
*/
public static final String KILLED = "KILLED";
/**
* RUNNING
*/
public static final String RUNNING = "RUNNING";
/**
* underline "_"
*/
public static final String UNDERLINE = "_";
/**
* quartz job prifix
*/
public static final String QUARTZ_JOB_PREFIX = "job";
/**
* quartz job group prifix
*/
public static final String QUARTZ_JOB_GROUP_PREFIX = "jobgroup";
/**
* projectId
*/
public static final String PROJECT_ID = "projectId";
/**
* processId
*/
public static final String SCHEDULE_ID = "scheduleId";
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 10,092 | [Bug] [TaskGroup] Task group does not take effect | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Detailed scenario: the task group configures three resources and creates a workflow. Six tasks in the workflow (all of which are executed for 30s) use this task group. The priority in the group is 1 to 6, which corresponds to the task name. The six tasks are in parallel relationship. After startup, 2, 3 and 4 run first, and 1, 5 and 6 run in the second batch. According to the description in the document, the higher the priority number, the higher the priority. The expectation should be 4, 5, 6 and then 1, 2 and 3
Task group does not take effect.
### What you expected to happen
Submit higher priority tasks firstly. The order should be 4,5,6 and then 1,2,3
### How to reproduce
up
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/10092 | https://github.com/apache/dolphinscheduler/pull/10093 | 63f835715f8ca8bff79c0e7177ebfa5917ebb3bd | ee2b855ced2e46bcdaf3ae7068941ac7e1c03c17 | 2022-05-18T07:08:16Z | java | 2022-05-18T10:40:36Z | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java | * schedule
*/
public static final String SCHEDULE = "schedule";
/**
* application regex
*/
public static final String APPLICATION_REGEX = "application_\\d+_\\d+";
public static final String PID = SystemUtils.IS_OS_WINDOWS ? "handle" : "pid";
/**
* month_begin
*/
public static final String MONTH_BEGIN = "month_begin";
/**
* add_months
*/
public static final String ADD_MONTHS = "add_months";
/**
* month_end
*/
public static final String MONTH_END = "month_end";
/**
* week_begin
*/
public static final String WEEK_BEGIN = "week_begin";
/**
* week_end
*/
public static final String WEEK_END = "week_end";
/**
* timestamp |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.