status
stringclasses 1
value | repo_name
stringclasses 31
values | repo_url
stringclasses 31
values | issue_id
int64 1
104k
| title
stringlengths 4
233
| body
stringlengths 0
186k
⌀ | issue_url
stringlengths 38
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown | updated_file
stringlengths 7
188
| chunk_content
stringlengths 1
1.03M
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/process/ResourceInfo.java | /**
* res the name of the resource that was uploaded
*/
private int id;
public int getId() {
return id;
}
public void setId(int id) {
this.id = id;
}
private String res;
public String getRes() {
return res;
}
public void setRes(String res) {
this.res = res;
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * limitations under the License.
*/
package org.apache.dolphinscheduler.service.process;
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE;
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_EMPTY_SUB_PROCESS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_FATHER_PARAMS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID;
import static org.apache.dolphinscheduler.common.Constants.LOCAL_PARAMS;
import static org.apache.dolphinscheduler.common.Constants.YYYY_MM_DD_HH_MM_SS;
import static java.util.stream.Collectors.toSet;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.AuthorizationType;
import org.apache.dolphinscheduler.common.enums.CommandType;
import org.apache.dolphinscheduler.common.enums.Direct;
import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
import org.apache.dolphinscheduler.common.enums.FailureStrategy;
import org.apache.dolphinscheduler.common.enums.Flag;
import org.apache.dolphinscheduler.common.enums.ReleaseState;
import org.apache.dolphinscheduler.common.enums.ResourceType;
import org.apache.dolphinscheduler.common.enums.TaskDependType;
import org.apache.dolphinscheduler.common.enums.TimeoutFlag;
import org.apache.dolphinscheduler.common.enums.WarningType;
import org.apache.dolphinscheduler.common.graph.DAG;
import org.apache.dolphinscheduler.common.model.DateInterval;
import org.apache.dolphinscheduler.common.model.TaskNode;
import org.apache.dolphinscheduler.common.model.TaskNodeRelation; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import org.apache.dolphinscheduler.common.process.ProcessDag;
import org.apache.dolphinscheduler.common.process.Property;
import org.apache.dolphinscheduler.common.process.ResourceInfo;
import org.apache.dolphinscheduler.common.task.AbstractParameters;
import org.apache.dolphinscheduler.common.task.TaskTimeoutParameter;
import org.apache.dolphinscheduler.common.task.subprocess.SubProcessParameters;
import org.apache.dolphinscheduler.common.utils.CollectionUtils;
import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.ParameterUtils;
import org.apache.dolphinscheduler.common.utils.SnowFlakeUtils;
import org.apache.dolphinscheduler.common.utils.SnowFlakeUtils.SnowFlakeException;
import org.apache.dolphinscheduler.common.utils.TaskParametersUtils;
import org.apache.dolphinscheduler.dao.entity.Command;
import org.apache.dolphinscheduler.dao.entity.DagData;
import org.apache.dolphinscheduler.dao.entity.DataSource;
import org.apache.dolphinscheduler.dao.entity.Environment;
import org.apache.dolphinscheduler.dao.entity.ErrorCommand;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinition;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.ProcessInstanceMap;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelation;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelationLog;
import org.apache.dolphinscheduler.dao.entity.Project;
import org.apache.dolphinscheduler.dao.entity.ProjectUser;
import org.apache.dolphinscheduler.dao.entity.Resource;
import org.apache.dolphinscheduler.dao.entity.Schedule;
import org.apache.dolphinscheduler.dao.entity.TaskDefinition;
import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.dao.entity.Tenant;
import org.apache.dolphinscheduler.dao.entity.UdfFunc;
import org.apache.dolphinscheduler.dao.entity.User;
import org.apache.dolphinscheduler.dao.mapper.CommandMapper;
import org.apache.dolphinscheduler.dao.mapper.DataSourceMapper;
import org.apache.dolphinscheduler.dao.mapper.EnvironmentMapper;
import org.apache.dolphinscheduler.dao.mapper.ErrorCommandMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationMapper;
import org.apache.dolphinscheduler.dao.mapper.ProjectMapper;
import org.apache.dolphinscheduler.dao.mapper.ResourceMapper;
import org.apache.dolphinscheduler.dao.mapper.ResourceUserMapper;
import org.apache.dolphinscheduler.dao.mapper.ScheduleMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.TenantMapper;
import org.apache.dolphinscheduler.dao.mapper.UdfFuncMapper;
import org.apache.dolphinscheduler.dao.mapper.UserMapper;
import org.apache.dolphinscheduler.dao.utils.DagHelper;
import org.apache.dolphinscheduler.remote.utils.Host;
import org.apache.dolphinscheduler.service.log.LogClientService;
import org.apache.commons.lang.StringUtils;
import java.util.ArrayList;
import java.util.Arrays; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import java.util.Date;
import java.util.EnumMap;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
import org.springframework.transaction.annotation.Transactional;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.facebook.presto.jdbc.internal.guava.collect.Lists;
import com.fasterxml.jackson.databind.node.ObjectNode;
/**
* process relative dao that some mappers in this.
*/
@Component
public class ProcessService {
private final Logger logger = LoggerFactory.getLogger(getClass());
private final int[] stateArray = new int[]{ExecutionStatus.SUBMITTED_SUCCESS.ordinal(),
ExecutionStatus.RUNNING_EXECUTION.ordinal(),
ExecutionStatus.DELAY_EXECUTION.ordinal(),
ExecutionStatus.READY_PAUSE.ordinal(),
ExecutionStatus.READY_STOP.ordinal()};
@Autowired |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | private UserMapper userMapper;
@Autowired
private ProcessDefinitionMapper processDefineMapper;
@Autowired
private ProcessDefinitionLogMapper processDefineLogMapper;
@Autowired
private ProcessInstanceMapper processInstanceMapper;
@Autowired
private DataSourceMapper dataSourceMapper;
@Autowired
private ProcessInstanceMapMapper processInstanceMapMapper;
@Autowired
private TaskInstanceMapper taskInstanceMapper;
@Autowired
private CommandMapper commandMapper;
@Autowired
private ScheduleMapper scheduleMapper;
@Autowired
private UdfFuncMapper udfFuncMapper;
@Autowired
private ResourceMapper resourceMapper;
@Autowired
private ResourceUserMapper resourceUserMapper;
@Autowired
private ErrorCommandMapper errorCommandMapper;
@Autowired
private TenantMapper tenantMapper;
@Autowired
private ProjectMapper projectMapper;
@Autowired |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | private TaskDefinitionMapper taskDefinitionMapper;
@Autowired
private TaskDefinitionLogMapper taskDefinitionLogMapper;
@Autowired
private ProcessTaskRelationMapper processTaskRelationMapper;
@Autowired
private ProcessTaskRelationLogMapper processTaskRelationLogMapper;
@Autowired
private EnvironmentMapper environmentMapper;
/**
* handle Command (construct ProcessInstance from Command) , wrapped in transaction
*
* @param logger logger
* @param host host
* @param validThreadNum validThreadNum
* @param command found command
* @return process instance
*/
@Transactional(rollbackFor = Exception.class)
public ProcessInstance handleCommand(Logger logger, String host, int validThreadNum, Command command) {
ProcessInstance processInstance = constructProcessInstance(command, host);
if (processInstance == null) {
logger.error("scan command, command parameter is error: {}", command);
moveToErrorCommand(command, "process instance is null");
return null;
}
if (!checkThreadNum(command, validThreadNum)) {
logger.info("there is not enough thread for this command: {}", command);
return setWaitingThreadProcess(command, processInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
processInstance.setCommandType(command.getCommandType());
processInstance.addHistoryCmd(command.getCommandType());
saveProcessInstance(processInstance);
this.setSubProcessParam(processInstance);
this.commandMapper.deleteById(command.getId());
return processInstance;
}
/**
* save error command, and delete original command
*
* @param command command
* @param message message
*/
@Transactional(rollbackFor = Exception.class)
public void moveToErrorCommand(Command command, String message) {
ErrorCommand errorCommand = new ErrorCommand(command, message);
this.errorCommandMapper.insert(errorCommand);
this.commandMapper.deleteById(command.getId());
}
/**
* set process waiting thread
*
* @param command command
* @param processInstance processInstance
* @return process instance
*/
private ProcessInstance setWaitingThreadProcess(Command command, ProcessInstance processInstance) {
processInstance.setState(ExecutionStatus.WAITING_THREAD);
if (command.getCommandType() != CommandType.RECOVER_WAITING_THREAD) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.addHistoryCmd(command.getCommandType());
}
saveProcessInstance(processInstance);
this.setSubProcessParam(processInstance);
createRecoveryWaitingThreadCommand(command, processInstance);
return null;
}
/**
* check thread num
*
* @param command command
* @param validThreadNum validThreadNum
* @return if thread is enough
*/
private boolean checkThreadNum(Command command, int validThreadNum) {
int commandThreadCount = this.workProcessThreadNumCount(command.getProcessDefinitionCode());
return validThreadNum >= commandThreadCount;
}
/**
* insert one command
*
* @param command command
* @return create result
*/
public int createCommand(Command command) {
int result = 0;
if (command != null) {
result = commandMapper.insert(command);
}
return result; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* find one command from queue list
*
* @return command
*/
public Command findOneCommand() {
return commandMapper.getOneToRun();
}
/**
* get command page
*
* @param pageSize
* @param pageNumber
* @return
*/
public List<Command> findCommandPage(int pageSize, int pageNumber) {
Page<Command> commandPage = new Page<>(pageNumber, pageSize);
return commandMapper.queryCommandPage(commandPage).getRecords();
}
/**
* check the input command exists in queue list
*
* @param command command
* @return create command result
*/
public boolean verifyIsNeedCreateCommand(Command command) {
boolean isNeedCreate = true;
EnumMap<CommandType, Integer> cmdTypeMap = new EnumMap<>(CommandType.class);
cmdTypeMap.put(CommandType.REPEAT_RUNNING, 1); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | cmdTypeMap.put(CommandType.RECOVER_SUSPENDED_PROCESS, 1);
cmdTypeMap.put(CommandType.START_FAILURE_TASK_PROCESS, 1);
CommandType commandType = command.getCommandType();
if (cmdTypeMap.containsKey(commandType)) {
ObjectNode cmdParamObj = JSONUtils.parseObject(command.getCommandParam());
int processInstanceId = cmdParamObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt();
List<Command> commands = commandMapper.selectList(null);
for (Command tmpCommand : commands) {
if (cmdTypeMap.containsKey(tmpCommand.getCommandType())) {
ObjectNode tempObj = JSONUtils.parseObject(tmpCommand.getCommandParam());
if (tempObj != null && processInstanceId == tempObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt()) {
isNeedCreate = false;
break;
}
}
}
}
return isNeedCreate;
}
/**
* find process instance detail by id
*
* @param processId processId
* @return process instance
*/
public ProcessInstance findProcessInstanceDetailById(int processId) {
return processInstanceMapper.queryDetailById(processId);
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * get task node list by definitionId
*/
public List<TaskDefinition> getTaskNodeListByDefinitionId(Integer defineId) {
ProcessDefinition processDefinition = processDefineMapper.selectById(defineId);
if (processDefinition == null) {
logger.error("process define not exists");
return new ArrayList<>();
}
List<ProcessTaskRelationLog> processTaskRelations = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion());
Set<TaskDefinition> taskDefinitionSet = new HashSet<>();
for (ProcessTaskRelationLog processTaskRelation : processTaskRelations) {
if (processTaskRelation.getPostTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion()));
}
}
List<TaskDefinitionLog> taskDefinitionLogs = taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet);
return new ArrayList<>(taskDefinitionLogs);
}
/**
* find process instance by id
*
* @param processId processId
* @return process instance
*/
public ProcessInstance findProcessInstanceById(int processId) {
return processInstanceMapper.selectById(processId);
}
/**
* find process define by id.
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param processDefinitionId processDefinitionId
* @return process definition
*/
public ProcessDefinition findProcessDefineById(int processDefinitionId) {
return processDefineMapper.selectById(processDefinitionId);
}
/**
* find process define by code and version.
*
* @param processDefinitionCode processDefinitionCode
* @return process definition
*/
public ProcessDefinition findProcessDefinition(Long processDefinitionCode, int version) {
ProcessDefinition processDefinition = processDefineMapper.queryByCode(processDefinitionCode);
if (processDefinition == null || processDefinition.getVersion() != version) {
processDefinition = processDefineLogMapper.queryByDefinitionCodeAndVersion(processDefinitionCode, version);
if (processDefinition != null) {
processDefinition.setId(0);
}
}
return processDefinition;
}
/**
* find process define by code.
*
* @param processDefinitionCode processDefinitionCode
* @return process definition
*/
public ProcessDefinition findProcessDefinitionByCode(Long processDefinitionCode) {
return processDefineMapper.queryByCode(processDefinitionCode); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* delete work process instance by id
*
* @param processInstanceId processInstanceId
* @return delete process instance result
*/
public int deleteWorkProcessInstanceById(int processInstanceId) {
return processInstanceMapper.deleteById(processInstanceId);
}
/**
* delete all sub process by parent instance id
*
* @param processInstanceId processInstanceId
* @return delete all sub process instance result
*/
public int deleteAllSubWorkProcessByParentId(int processInstanceId) {
List<Integer> subProcessIdList = processInstanceMapMapper.querySubIdListByParentId(processInstanceId);
for (Integer subId : subProcessIdList) {
deleteAllSubWorkProcessByParentId(subId);
deleteWorkProcessMapByParentId(subId);
removeTaskLogFile(subId);
deleteWorkProcessInstanceById(subId);
}
return 1;
}
/**
* remove task log file
*
* @param processInstanceId processInstanceId |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
public void removeTaskLogFile(Integer processInstanceId) {
List<TaskInstance> taskInstanceList = findValidTaskListByProcessId(processInstanceId);
if (CollectionUtils.isEmpty(taskInstanceList)) {
return;
}
try (LogClientService logClient = new LogClientService()) {
for (TaskInstance taskInstance : taskInstanceList) {
String taskLogPath = taskInstance.getLogPath();
if (StringUtils.isEmpty(taskInstance.getHost())) {
continue;
}
int port = Constants.RPC_PORT;
String ip = "";
try {
ip = Host.of(taskInstance.getHost()).getIp();
} catch (Exception e) {
ip = taskInstance.getHost();
}
logClient.removeTaskLog(ip, port, taskLogPath);
}
}
}
/**
* calculate sub process number in the process define.
*
* @param processDefinitionCode processDefinitionCode
* @return process thread num count |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
private Integer workProcessThreadNumCount(long processDefinitionCode) {
ProcessDefinition processDefinition = processDefineMapper.queryByCode(processDefinitionCode);
List<Integer> ids = new ArrayList<>();
recurseFindSubProcessId(processDefinition.getId(), ids);
return ids.size() + 1;
}
/**
* recursive query sub process definition id by parent id.
*
* @param parentId parentId
* @param ids ids
*/
public void recurseFindSubProcessId(int parentId, List<Integer> ids) {
List<TaskDefinition> taskNodeList = this.getTaskNodeListByDefinitionId(parentId);
if (taskNodeList != null && !taskNodeList.isEmpty()) {
for (TaskDefinition taskNode : taskNodeList) {
String parameter = taskNode.getTaskParams();
ObjectNode parameterJson = JSONUtils.parseObject(parameter);
if (parameterJson.get(CMD_PARAM_SUB_PROCESS_DEFINE_ID) != null) {
SubProcessParameters subProcessParam = JSONUtils.parseObject(parameter, SubProcessParameters.class);
ids.add(subProcessParam.getProcessDefinitionId());
recurseFindSubProcessId(subProcessParam.getProcessDefinitionId(), ids);
}
}
}
}
/**
* create recovery waiting thread command when thread pool is not enough for the process instance.
* sub work process instance need not to create recovery command. |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * create recovery waiting thread command and delete origin command at the same time.
* if the recovery command is exists, only update the field update_time
*
* @param originCommand originCommand
* @param processInstance processInstance
*/
public void createRecoveryWaitingThreadCommand(Command originCommand, ProcessInstance processInstance) {
if (processInstance.getIsSubProcess() == Flag.YES) {
if (originCommand != null) {
commandMapper.deleteById(originCommand.getId());
}
return;
}
Map<String, String> cmdParam = new HashMap<>();
cmdParam.put(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD, String.valueOf(processInstance.getId()));
if (originCommand == null) {
Command command = new Command(
CommandType.RECOVER_WAITING_THREAD,
processInstance.getTaskDependType(),
processInstance.getFailureStrategy(),
processInstance.getExecutorId(),
processInstance.getProcessDefinition().getCode(),
JSONUtils.toJsonString(cmdParam),
processInstance.getWarningType(),
processInstance.getWarningGroupId(),
processInstance.getScheduleTime(),
processInstance.getWorkerGroup(),
processInstance.getEnvironmentCode(), |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.getProcessInstancePriority()
);
saveCommand(command);
return;
}
if (originCommand.getCommandType() == CommandType.RECOVER_WAITING_THREAD) {
originCommand.setUpdateTime(new Date());
saveCommand(originCommand);
} else {
commandMapper.deleteById(originCommand.getId());
originCommand.setId(0);
originCommand.setCommandType(CommandType.RECOVER_WAITING_THREAD);
originCommand.setUpdateTime(new Date());
originCommand.setCommandParam(JSONUtils.toJsonString(cmdParam));
originCommand.setProcessInstancePriority(processInstance.getProcessInstancePriority());
saveCommand(originCommand);
}
}
/**
* get schedule time from command
*
* @param command command
* @param cmdParam cmdParam map
* @return date
*/
private Date getScheduleTime(Command command, Map<String, String> cmdParam) {
Date scheduleTime = command.getScheduleTime();
if (scheduleTime == null && cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | scheduleTime = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
}
return scheduleTime;
}
/**
* generate a new work process instance from command.
*
* @param processDefinition processDefinition
* @param command command
* @param cmdParam cmdParam map
* @return process instance
*/
private ProcessInstance generateNewProcessInstance(ProcessDefinition processDefinition,
Command command,
Map<String, String> cmdParam) {
ProcessInstance processInstance = new ProcessInstance(processDefinition);
processInstance.setProcessDefinitionCode(processDefinition.getCode());
processInstance.setProcessDefinitionVersion(processDefinition.getVersion());
processInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
processInstance.setRecovery(Flag.NO);
processInstance.setStartTime(new Date());
processInstance.setRunTimes(1);
processInstance.setMaxTryTimes(0);
processInstance.setCommandParam(command.getCommandParam());
processInstance.setCommandType(command.getCommandType());
processInstance.setIsSubProcess(Flag.NO);
processInstance.setTaskDependType(command.getTaskDependType());
processInstance.setFailureStrategy(command.getFailureStrategy());
processInstance.setExecutorId(command.getExecutorId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | WarningType warningType = command.getWarningType() == null ? WarningType.NONE : command.getWarningType();
processInstance.setWarningType(warningType);
Integer warningGroupId = command.getWarningGroupId() == null ? 0 : command.getWarningGroupId();
processInstance.setWarningGroupId(warningGroupId);
Date scheduleTime = getScheduleTime(command, cmdParam);
if (scheduleTime != null) {
processInstance.setScheduleTime(scheduleTime);
}
processInstance.setCommandStartTime(command.getStartTime());
processInstance.setLocations(processDefinition.getLocations());
setGlobalParamIfCommanded(processDefinition, cmdParam);
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
getCommandTypeIfComplement(processInstance, command),
processInstance.getScheduleTime()));
processInstance.setProcessInstancePriority(command.getProcessInstancePriority());
String workerGroup = StringUtils.isBlank(command.getWorkerGroup()) ? Constants.DEFAULT_WORKER_GROUP : command.getWorkerGroup();
processInstance.setWorkerGroup(workerGroup);
processInstance.setEnvironmentCode(Objects.isNull(command.getEnvironmentCode()) ? -1 : command.getEnvironmentCode());
processInstance.setTimeout(processDefinition.getTimeout());
processInstance.setTenantId(processDefinition.getTenantId());
return processInstance;
}
private void setGlobalParamIfCommanded(ProcessDefinition processDefinition, Map<String, String> cmdParam) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | Map<String, String> startParamMap = new HashMap<>();
if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_START_PARAMS)) {
String startParamJson = cmdParam.get(Constants.CMD_PARAM_START_PARAMS);
startParamMap = JSONUtils.toMap(startParamJson);
}
Map<String, String> fatherParamMap = new HashMap<>();
if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_FATHER_PARAMS)) {
String fatherParamJson = cmdParam.get(Constants.CMD_PARAM_FATHER_PARAMS);
fatherParamMap = JSONUtils.toMap(fatherParamJson);
}
startParamMap.putAll(fatherParamMap);
if (startParamMap.size() > 0
&& processDefinition.getGlobalParamMap() != null) {
for (Map.Entry<String, String> param : processDefinition.getGlobalParamMap().entrySet()) {
String val = startParamMap.get(param.getKey());
if (val != null) {
param.setValue(val);
}
}
}
}
/**
* get process tenant
* there is tenant id in definition, use the tenant of the definition.
* if there is not tenant id in the definiton or the tenant not exist
* use definition creator's tenant.
*
* @param tenantId tenantId
* @param userId userId |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @return tenant
*/
public Tenant getTenantForProcess(int tenantId, int userId) {
Tenant tenant = null;
if (tenantId >= 0) {
tenant = tenantMapper.queryById(tenantId);
}
if (userId == 0) {
return null;
}
if (tenant == null) {
User user = userMapper.selectById(userId);
tenant = tenantMapper.queryById(user.getTenantId());
}
return tenant;
}
/**
* get an environment
* use the code of the environment to find a environment.
*
* @param environmentCode environmentCode
* @return Environment
*/
public Environment findEnvironmentByCode(Long environmentCode) {
Environment environment = null;
if (environmentCode >= 0) {
environment = environmentMapper.queryByEnvironmentCode(environmentCode);
}
return environment;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* check command parameters is valid
*
* @param command command
* @param cmdParam cmdParam map
* @return whether command param is valid
*/
private Boolean checkCmdParam(Command command, Map<String, String> cmdParam) {
if (command.getTaskDependType() == TaskDependType.TASK_ONLY || command.getTaskDependType() == TaskDependType.TASK_PRE) {
if (cmdParam == null
|| !cmdParam.containsKey(Constants.CMD_PARAM_START_NODE_NAMES)
|| cmdParam.get(Constants.CMD_PARAM_START_NODE_NAMES).isEmpty()) {
logger.error("command node depend type is {}, but start nodes is null ", command.getTaskDependType());
return false;
}
}
return true;
}
/**
* construct process instance according to one command.
*
* @param command command
* @param host host
* @return process instance
*/
private ProcessInstance constructProcessInstance(Command command, String host) {
ProcessInstance processInstance;
CommandType commandType = command.getCommandType();
Map<String, String> cmdParam = JSONUtils.toMap(command.getCommandParam());
ProcessDefinition processDefinition = getProcessDefinitionByCommand(command.getProcessDefinitionCode(), cmdParam); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (processDefinition == null) {
logger.error("cannot find the work process define! define code : {}", command.getProcessDefinitionCode());
return null;
}
if (cmdParam != null) {
int processInstanceId = 0;
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)) {
String processId = cmdParam.get(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING);
processInstanceId = Integer.parseInt(processId);
if (processInstanceId == 0) {
logger.error("command parameter is error, [ ProcessInstanceId ] is 0");
return null;
}
} else if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
String pId = cmdParam.get(Constants.CMD_PARAM_SUB_PROCESS);
processInstanceId = Integer.parseInt(pId);
} else if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)) {
String pId = cmdParam.get(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD);
processInstanceId = Integer.parseInt(pId);
}
if (processInstanceId == 0) {
processInstance = generateNewProcessInstance(processDefinition, command, cmdParam);
} else {
processInstance = this.findProcessInstanceDetailById(processInstanceId);
if (processInstance == null) {
return processInstance;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | CommandType commandTypeIfComplement = getCommandTypeIfComplement(processInstance, command);
if (commandTypeIfComplement == CommandType.REPEAT_RUNNING) {
setGlobalParamIfCommanded(processDefinition, cmdParam);
}
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
commandTypeIfComplement,
processInstance.getScheduleTime()));
processInstance.setProcessDefinition(processDefinition);
}
if (processInstance.getCommandParam() != null) {
Map<String, String> processCmdParam = JSONUtils.toMap(processInstance.getCommandParam());
for (Map.Entry<String, String> entry : processCmdParam.entrySet()) {
if (!cmdParam.containsKey(entry.getKey())) {
cmdParam.put(entry.getKey(), entry.getValue());
}
}
}
if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
processInstance.setCommandParam(command.getCommandParam());
}
} else {
processInstance = generateNewProcessInstance(processDefinition, command, cmdParam);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (Boolean.FALSE.equals(checkCmdParam(command, cmdParam))) {
logger.error("command parameter check failed!");
return null;
}
if (command.getScheduleTime() != null) {
processInstance.setScheduleTime(command.getScheduleTime());
}
processInstance.setHost(host);
ExecutionStatus runStatus = ExecutionStatus.RUNNING_EXECUTION;
int runTime = processInstance.getRunTimes();
switch (commandType) {
case START_PROCESS:
break;
case START_FAILURE_TASK_PROCESS:
List<Integer> failedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.FAILURE);
List<Integer> toleranceList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.NEED_FAULT_TOLERANCE);
List<Integer> killedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.KILL);
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
failedList.addAll(killedList);
failedList.addAll(toleranceList);
for (Integer taskId : failedList) {
initTaskInstance(this.findTaskInstanceById(taskId));
}
cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING,
String.join(Constants.COMMA, convertIntListToString(failedList)));
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
processInstance.setRunTimes(runTime + 1);
break;
case START_CURRENT_TASK_PROCESS: |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | break;
case RECOVER_WAITING_THREAD:
break;
case RECOVER_SUSPENDED_PROCESS:
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
List<Integer> suspendedNodeList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.PAUSE);
List<Integer> stopNodeList = findTaskIdByInstanceState(processInstance.getId(),
ExecutionStatus.KILL);
suspendedNodeList.addAll(stopNodeList);
for (Integer taskId : suspendedNodeList) {
initTaskInstance(this.findTaskInstanceById(taskId));
}
cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING, String.join(",", convertIntListToString(suspendedNodeList)));
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
processInstance.setRunTimes(runTime + 1);
break;
case RECOVER_TOLERANCE_FAULT_PROCESS:
processInstance.setRecovery(Flag.YES);
runStatus = processInstance.getState();
break;
case COMPLEMENT_DATA:
List<TaskInstance> taskInstanceList = this.findValidTaskListByProcessId(processInstance.getId());
for (TaskInstance taskInstance : taskInstanceList) {
taskInstance.setFlag(Flag.NO);
this.updateTaskInstance(taskInstance);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | initComplementDataParam(processDefinition, processInstance, cmdParam);
break;
case REPEAT_RUNNING:
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING)) {
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
}
List<TaskInstance> validTaskList = findValidTaskListByProcessId(processInstance.getId());
for (TaskInstance taskInstance : validTaskList) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
}
processInstance.setStartTime(new Date());
processInstance.setEndTime(null);
processInstance.setRunTimes(runTime + 1);
initComplementDataParam(processDefinition, processInstance, cmdParam);
break;
case SCHEDULER:
break;
default:
break;
}
processInstance.setState(runStatus);
return processInstance;
}
/**
* get process definition by command
* If it is a fault-tolerant command, get the specified version of ProcessDefinition through ProcessInstance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * Otherwise, get the latest version of ProcessDefinition
*
* @return ProcessDefinition
*/
private ProcessDefinition getProcessDefinitionByCommand(long processDefinitionCode, Map<String, String> cmdParam) {
if (cmdParam != null) {
int processInstanceId = 0;
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)) {
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING));
} else if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_SUB_PROCESS));
} else if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)) {
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD));
}
if (processInstanceId != 0) {
ProcessInstance processInstance = this.findProcessInstanceDetailById(processInstanceId);
if (processInstance == null) {
return null;
}
return processDefineLogMapper.queryByDefinitionCodeAndVersion(
processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
}
}
return processDefineMapper.queryByCode(processDefinitionCode);
}
/**
* return complement data if the process start with complement data
*
* @param processInstance processInstance
* @param command command |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @return command type
*/
private CommandType getCommandTypeIfComplement(ProcessInstance processInstance, Command command) {
if (CommandType.COMPLEMENT_DATA == processInstance.getCmdTypeIfComplement()) {
return CommandType.COMPLEMENT_DATA;
} else {
return command.getCommandType();
}
}
/**
* initialize complement data parameters
*
* @param processDefinition processDefinition
* @param processInstance processInstance
* @param cmdParam cmdParam
*/
private void initComplementDataParam(ProcessDefinition processDefinition,
ProcessInstance processInstance,
Map<String, String> cmdParam) {
if (!processInstance.isComplementData()) {
return;
}
Date startComplementTime = DateUtils.parse(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE),
YYYY_MM_DD_HH_MM_SS);
if (Flag.NO == processInstance.getIsSubProcess()) {
processInstance.setScheduleTime(startComplementTime);
}
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(), |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | CommandType.COMPLEMENT_DATA, processInstance.getScheduleTime()));
}
/**
* set sub work process parameters.
* handle sub work process instance, update relation table and command parameters
* set sub work process flag, extends parent work process command parameters
*
* @param subProcessInstance subProcessInstance
*/
public void setSubProcessParam(ProcessInstance subProcessInstance) {
String cmdParam = subProcessInstance.getCommandParam();
if (StringUtils.isEmpty(cmdParam)) {
return;
}
Map<String, String> paramMap = JSONUtils.toMap(cmdParam);
if (paramMap.containsKey(CMD_PARAM_SUB_PROCESS)
&& CMD_PARAM_EMPTY_SUB_PROCESS.equals(paramMap.get(CMD_PARAM_SUB_PROCESS))) {
paramMap.remove(CMD_PARAM_SUB_PROCESS);
paramMap.put(CMD_PARAM_SUB_PROCESS, String.valueOf(subProcessInstance.getId()));
subProcessInstance.setCommandParam(JSONUtils.toJsonString(paramMap));
subProcessInstance.setIsSubProcess(Flag.YES);
this.saveProcessInstance(subProcessInstance);
}
String parentInstanceId = paramMap.get(CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID);
if (StringUtils.isNotEmpty(parentInstanceId)) {
ProcessInstance parentInstance = findProcessInstanceDetailById(Integer.parseInt(parentInstanceId));
if (parentInstance != null) {
subProcessInstance.setGlobalParams( |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | joinGlobalParams(parentInstance.getGlobalParams(), subProcessInstance.getGlobalParams()));
this.saveProcessInstance(subProcessInstance);
} else {
logger.error("sub process command params error, cannot find parent instance: {} ", cmdParam);
}
}
ProcessInstanceMap processInstanceMap = JSONUtils.parseObject(cmdParam, ProcessInstanceMap.class);
if (processInstanceMap == null || processInstanceMap.getParentProcessInstanceId() == 0) {
return;
}
processInstanceMap.setProcessInstanceId(subProcessInstance.getId());
this.updateWorkProcessInstanceMap(processInstanceMap);
}
/**
* join parent global params into sub process.
* only the keys doesn't in sub process global would be joined.
*
* @param parentGlobalParams parentGlobalParams
* @param subGlobalParams subGlobalParams
* @return global params join
*/
private String joinGlobalParams(String parentGlobalParams, String subGlobalParams) {
List<Property> parentPropertyList = JSONUtils.toList(parentGlobalParams, Property.class);
List<Property> subPropertyList = JSONUtils.toList(subGlobalParams, Property.class);
Map<String, String> subMap = subPropertyList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue));
for (Property parent : parentPropertyList) {
if (!subMap.containsKey(parent.getProp())) {
subPropertyList.add(parent);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
return JSONUtils.toJsonString(subPropertyList);
}
/**
* initialize task instance
*
* @param taskInstance taskInstance
*/
private void initTaskInstance(TaskInstance taskInstance) {
if (!taskInstance.isSubProcess()
&& (taskInstance.getState().typeIsCancel() || taskInstance.getState().typeIsFailure())) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
return;
}
taskInstance.setState(ExecutionStatus.SUBMITTED_SUCCESS);
updateTaskInstance(taskInstance);
}
/**
* retry submit task to db
*
* @param taskInstance
* @param commitRetryTimes
* @param commitInterval
* @return
*/
public TaskInstance submitTask(TaskInstance taskInstance, int commitRetryTimes, int commitInterval) {
int retryTimes = 1;
boolean submitDB = false;
TaskInstance task = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | while (retryTimes <= commitRetryTimes) {
try {
if (!submitDB) {
task = submitTask(taskInstance);
if (task != null && task.getId() != 0) {
submitDB = true;
break;
}
}
if (!submitDB) {
logger.error("task commit to db failed , taskId {} has already retry {} times, please check the database", taskInstance.getId(), retryTimes);
}
Thread.sleep(commitInterval);
} catch (Exception e) {
logger.error("task commit to mysql failed", e);
}
retryTimes += 1;
}
return task;
}
/**
* submit task to db
* submit sub process to command
*
* @param taskInstance taskInstance
* @return task instance
*/
@Transactional(rollbackFor = Exception.class)
public TaskInstance submitTask(TaskInstance taskInstance) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessInstance processInstance = this.findProcessInstanceDetailById(taskInstance.getProcessInstanceId());
logger.info("start submit task : {}, instance id:{}, state: {}",
taskInstance.getName(), taskInstance.getProcessInstanceId(), processInstance.getState());
TaskInstance task = submitTaskInstanceToDB(taskInstance, processInstance);
if (task == null) {
logger.error("end submit task to db error, task name:{}, process id:{} state: {} ",
taskInstance.getName(), taskInstance.getProcessInstance(), processInstance.getState());
return task;
}
if (!task.getState().typeIsFinished()) {
createSubWorkProcess(processInstance, task);
}
logger.info("end submit task to db successfully:{} {} state:{} complete, instance id:{} state: {} ",
taskInstance.getId(), taskInstance.getName(), task.getState(), processInstance.getId(), processInstance.getState());
return task;
}
/**
* set work process instance map
* consider o
* repeat running does not generate new sub process instance
* set map {parent instance id, task instance id, 0(child instance id)}
*
* @param parentInstance parentInstance
* @param parentTask parentTask
* @return process instance map
*/
private ProcessInstanceMap setProcessInstanceMap(ProcessInstance parentInstance, TaskInstance parentTask) {
ProcessInstanceMap processMap = findWorkProcessMapByParent(parentInstance.getId(), parentTask.getId());
if (processMap != null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return processMap;
}
if (parentInstance.getCommandType() == CommandType.REPEAT_RUNNING) {
processMap = findPreviousTaskProcessMap(parentInstance, parentTask);
if (processMap != null) {
processMap.setParentTaskInstanceId(parentTask.getId());
updateWorkProcessInstanceMap(processMap);
return processMap;
}
}
processMap = new ProcessInstanceMap();
processMap.setParentProcessInstanceId(parentInstance.getId());
processMap.setParentTaskInstanceId(parentTask.getId());
createWorkProcessInstanceMap(processMap);
return processMap;
}
/**
* find previous task work process map.
*
* @param parentProcessInstance parentProcessInstance
* @param parentTask parentTask
* @return process instance map
*/
private ProcessInstanceMap findPreviousTaskProcessMap(ProcessInstance parentProcessInstance,
TaskInstance parentTask) {
Integer preTaskId = 0;
List<TaskInstance> preTaskList = this.findPreviousTaskListByWorkProcessId(parentProcessInstance.getId());
for (TaskInstance task : preTaskList) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (task.getName().equals(parentTask.getName())) {
preTaskId = task.getId();
ProcessInstanceMap map = findWorkProcessMapByParent(parentProcessInstance.getId(), preTaskId);
if (map != null) {
return map;
}
}
}
logger.info("sub process instance is not found,parent task:{},parent instance:{}",
parentTask.getId(), parentProcessInstance.getId());
return null;
}
/**
* create sub work process command
*
* @param parentProcessInstance parentProcessInstance
* @param task task
*/
public void createSubWorkProcess(ProcessInstance parentProcessInstance, TaskInstance task) {
if (!task.isSubProcess()) {
return;
}
ProcessInstanceMap instanceMap = findWorkProcessMapByParent(parentProcessInstance.getId(), task.getId());
if (null != instanceMap && CommandType.RECOVER_TOLERANCE_FAULT_PROCESS == parentProcessInstance.getCommandType()) {
return;
}
instanceMap = setProcessInstanceMap(parentProcessInstance, task);
ProcessInstance childInstance = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (instanceMap.getProcessInstanceId() != 0) {
childInstance = findProcessInstanceById(instanceMap.getProcessInstanceId());
}
Command subProcessCommand = createSubProcessCommand(parentProcessInstance, childInstance, instanceMap, task);
updateSubProcessDefinitionByParent(parentProcessInstance, subProcessCommand.getProcessDefinitionCode());
initSubInstanceState(childInstance);
createCommand(subProcessCommand);
logger.info("sub process command created: {} ", subProcessCommand);
}
/**
* complement data needs transform parent parameter to child.
*/
private String getSubWorkFlowParam(ProcessInstanceMap instanceMap, ProcessInstance parentProcessInstance, Map<String, String> fatherParams) {
String processMapStr = JSONUtils.toJsonString(instanceMap);
Map<String, String> cmdParam = JSONUtils.toMap(processMapStr);
if (parentProcessInstance.isComplementData()) {
Map<String, String> parentParam = JSONUtils.toMap(parentProcessInstance.getCommandParam());
String endTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE);
String startTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, endTime);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_START_DATE, startTime);
processMapStr = JSONUtils.toJsonString(cmdParam);
}
if (fatherParams.size() != 0) {
cmdParam.put(CMD_PARAM_FATHER_PARAMS, JSONUtils.toJsonString(fatherParams));
processMapStr = JSONUtils.toJsonString(cmdParam);
}
return processMapStr;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public Map<String, String> getGlobalParamMap(String globalParams) {
List<Property> propList;
Map<String, String> globalParamMap = new HashMap<>();
if (StringUtils.isNotEmpty(globalParams)) {
propList = JSONUtils.toList(globalParams, Property.class);
globalParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue));
}
return globalParamMap;
}
/**
* create sub work process command
*/
public Command createSubProcessCommand(ProcessInstance parentProcessInstance,
ProcessInstance childInstance,
ProcessInstanceMap instanceMap,
TaskInstance task) {
CommandType commandType = getSubCommandType(parentProcessInstance, childInstance);
Map<String, String> subProcessParam = JSONUtils.toMap(task.getTaskParams());
int childDefineId = Integer.parseInt(subProcessParam.get(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID));
ProcessDefinition processDefinition = processDefineMapper.queryByDefineId(childDefineId);
Object localParams = subProcessParam.get(Constants.LOCAL_PARAMS);
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> globalMap = this.getGlobalParamMap(parentProcessInstance.getGlobalParams());
Map<String, String> fatherParams = new HashMap<>();
if (CollectionUtils.isNotEmpty(allParam)) {
for (Property info : allParam) {
fatherParams.put(info.getProp(), globalMap.get(info.getProp()));
}
}
String processParam = getSubWorkFlowParam(instanceMap, parentProcessInstance, fatherParams); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return new Command(
commandType,
TaskDependType.TASK_POST,
parentProcessInstance.getFailureStrategy(),
parentProcessInstance.getExecutorId(),
processDefinition.getCode(),
processParam,
parentProcessInstance.getWarningType(),
parentProcessInstance.getWarningGroupId(),
parentProcessInstance.getScheduleTime(),
task.getWorkerGroup(),
task.getEnvironmentCode(),
parentProcessInstance.getProcessInstancePriority()
);
}
/**
* initialize sub work flow state
* child instance state would be initialized when 'recovery from pause/stop/failure'
*/
private void initSubInstanceState(ProcessInstance childInstance) {
if (childInstance != null) {
childInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
updateProcessInstance(childInstance);
}
}
/**
* get sub work flow command type
* child instance exist: child command = fatherCommand
* child instance not exists: child command = fatherCommand[0]
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | private CommandType getSubCommandType(ProcessInstance parentProcessInstance, ProcessInstance childInstance) {
CommandType commandType = parentProcessInstance.getCommandType();
if (childInstance == null) {
String fatherHistoryCommand = parentProcessInstance.getHistoryCmd();
commandType = CommandType.valueOf(fatherHistoryCommand.split(Constants.COMMA)[0]);
}
return commandType;
}
/**
* update sub process definition
*
* @param parentProcessInstance parentProcessInstance
* @param childDefinitionCode childDefinitionId
*/
private void updateSubProcessDefinitionByParent(ProcessInstance parentProcessInstance, long childDefinitionCode) {
ProcessDefinition fatherDefinition = this.findProcessDefinition(parentProcessInstance.getProcessDefinitionCode(),
parentProcessInstance.getProcessDefinitionVersion());
ProcessDefinition childDefinition = this.findProcessDefinitionByCode(childDefinitionCode);
if (childDefinition != null && fatherDefinition != null) {
childDefinition.setWarningGroupId(fatherDefinition.getWarningGroupId());
processDefineMapper.updateById(childDefinition);
}
}
/**
* submit task to mysql
*
* @param taskInstance taskInstance
* @param processInstance processInstance
* @return task instance
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public TaskInstance submitTaskInstanceToDB(TaskInstance taskInstance, ProcessInstance processInstance) {
ExecutionStatus processInstanceState = processInstance.getState();
if (taskInstance.getState().typeIsFailure()) {
if (taskInstance.isSubProcess()) {
taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
} else {
if (processInstanceState != ExecutionStatus.READY_STOP
&& processInstanceState != ExecutionStatus.READY_PAUSE) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
if (taskInstance.getState() != ExecutionStatus.NEED_FAULT_TOLERANCE) {
taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
}
taskInstance.setSubmitTime(null);
taskInstance.setStartTime(null);
taskInstance.setEndTime(null);
taskInstance.setFlag(Flag.YES);
taskInstance.setHost(null);
taskInstance.setId(0);
}
}
}
taskInstance.setExecutorId(processInstance.getExecutorId());
taskInstance.setProcessInstancePriority(processInstance.getProcessInstancePriority());
taskInstance.setState(getSubmitTaskState(taskInstance, processInstanceState));
if (taskInstance.getSubmitTime() == null) {
taskInstance.setSubmitTime(new Date());
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (taskInstance.getFirstSubmitTime() == null) {
taskInstance.setFirstSubmitTime(taskInstance.getSubmitTime());
}
boolean saveResult = saveTaskInstance(taskInstance);
if (!saveResult) {
return null;
}
return taskInstance;
}
/**
* get submit task instance state by the work process state
* cannot modify the task state when running/kill/submit success, or this
* task instance is already exists in task queue .
* return pause if work process state is ready pause
* return stop if work process state is ready stop
* if all of above are not satisfied, return submit success
*
* @param taskInstance taskInstance
* @param processInstanceState processInstanceState
* @return process instance state
*/
public ExecutionStatus getSubmitTaskState(TaskInstance taskInstance, ExecutionStatus processInstanceState) {
ExecutionStatus state = taskInstance.getState();
if (
state == ExecutionStatus.RUNNING_EXECUTION
|| state == ExecutionStatus.DELAY_EXECUTION
|| state == ExecutionStatus.KILL |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ) {
return state;
}
if (processInstanceState == ExecutionStatus.READY_PAUSE) {
state = ExecutionStatus.PAUSE;
} else if (processInstanceState == ExecutionStatus.READY_STOP
|| !checkProcessStrategy(taskInstance)) {
state = ExecutionStatus.KILL;
} else {
state = ExecutionStatus.SUBMITTED_SUCCESS;
}
return state;
}
/**
* check process instance strategy
*
* @param taskInstance taskInstance
* @return check strategy result
*/
private boolean checkProcessStrategy(TaskInstance taskInstance) {
ProcessInstance processInstance = this.findProcessInstanceById(taskInstance.getProcessInstanceId());
FailureStrategy failureStrategy = processInstance.getFailureStrategy();
if (failureStrategy == FailureStrategy.CONTINUE) {
return true;
}
List<TaskInstance> taskInstances = this.findValidTaskListByProcessId(taskInstance.getProcessInstanceId());
for (TaskInstance task : taskInstances) {
if (task.getState() == ExecutionStatus.FAILURE |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | && task.getRetryTimes() >= task.getMaxRetryTimes()) {
return false;
}
}
return true;
}
/**
* insert or update work process instance to data base
*
* @param processInstance processInstance
*/
public void saveProcessInstance(ProcessInstance processInstance) {
if (processInstance == null) {
logger.error("save error, process instance is null!");
return;
}
if (processInstance.getId() != 0) {
processInstanceMapper.updateById(processInstance);
} else {
processInstanceMapper.insert(processInstance);
}
}
/**
* insert or update command
*
* @param command command
* @return save command result
*/
public int saveCommand(Command command) {
if (command.getId() != 0) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return commandMapper.updateById(command);
} else {
return commandMapper.insert(command);
}
}
/**
* insert or update task instance
*
* @param taskInstance taskInstance
* @return save task instance result
*/
public boolean saveTaskInstance(TaskInstance taskInstance) {
if (taskInstance.getId() != 0) {
return updateTaskInstance(taskInstance);
} else {
return createTaskInstance(taskInstance);
}
}
/**
* insert task instance
*
* @param taskInstance taskInstance
* @return create task instance result
*/
public boolean createTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.insert(taskInstance);
return count > 0;
}
/**
* update task instance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | *
* @param taskInstance taskInstance
* @return update task instance result
*/
public boolean updateTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.updateById(taskInstance);
return count > 0;
}
/**
* find task instance by id
*
* @param taskId task id
* @return task intance
*/
public TaskInstance findTaskInstanceById(Integer taskId) {
return taskInstanceMapper.selectById(taskId);
}
/**
* package task instance，associate processInstance and processDefine
*
* @param taskInstId taskInstId
* @return task instance
*/
public TaskInstance getTaskInstanceDetailByTaskId(int taskInstId) {
//
TaskInstance taskInstance = findTaskInstanceById(taskInstId);
if (taskInstance == null) {
return null;
}
// |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessInstance processInstance = findProcessInstanceDetailById(taskInstance.getProcessInstanceId());
//
ProcessDefinition processDefine = findProcessDefinition(processInstance.getProcessDefinitionCode(),
processInstance.getProcessDefinitionVersion());
taskInstance.setProcessInstance(processInstance);
taskInstance.setProcessDefine(processDefine);
TaskDefinition taskDefinition = taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(
taskInstance.getTaskCode(),
taskInstance.getTaskDefinitionVersion());
taskInstance.setTaskDefine(taskDefinition);
return taskInstance;
}
/**
* get id list by task state
*
* @param instanceId instanceId
* @param state state
* @return task instance states
*/
public List<Integer> findTaskIdByInstanceState(int instanceId, ExecutionStatus state) {
return taskInstanceMapper.queryTaskByProcessIdAndState(instanceId, state.ordinal());
}
/**
* find valid task list by process definition id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
public List<TaskInstance> findValidTaskListByProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.YES); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* find previous task list by work process id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
public List<TaskInstance> findPreviousTaskListByWorkProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.NO);
}
/**
* update work process instance map
*
* @param processInstanceMap processInstanceMap
* @return update process instance result
*/
public int updateWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
return processInstanceMapMapper.updateById(processInstanceMap);
}
/**
* create work process instance map
*
* @param processInstanceMap processInstanceMap
* @return create process instance result
*/
public int createWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
int count = 0;
if (processInstanceMap != null) {
return processInstanceMapMapper.insert(processInstanceMap);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return count;
}
/**
* find work process map by parent process id and parent task id.
*
* @param parentWorkProcessId parentWorkProcessId
* @param parentTaskId parentTaskId
* @return process instance map
*/
public ProcessInstanceMap findWorkProcessMapByParent(Integer parentWorkProcessId, Integer parentTaskId) {
return processInstanceMapMapper.queryByParentId(parentWorkProcessId, parentTaskId);
}
/**
* delete work process map by parent process id
*
* @param parentWorkProcessId parentWorkProcessId
* @return delete process map result
*/
public int deleteWorkProcessMapByParentId(int parentWorkProcessId) {
return processInstanceMapMapper.deleteByParentProcessId(parentWorkProcessId);
}
/**
* find sub process instance
*
* @param parentProcessId parentProcessId
* @param parentTaskId parentTaskId
* @return process instance
*/
public ProcessInstance findSubProcessInstance(Integer parentProcessId, Integer parentTaskId) {
ProcessInstance processInstance = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryByParentId(parentProcessId, parentTaskId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getProcessInstanceId());
return processInstance;
}
/**
* find parent process instance
*
* @param subProcessId subProcessId
* @return process instance
*/
public ProcessInstance findParentProcessInstance(Integer subProcessId) {
ProcessInstance processInstance = null;
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(subProcessId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
return processInstance;
}
/**
* change task state
*
* @param state state
* @param startTime startTime
* @param host host
* @param executePath executePath
* @param logPath logPath |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param taskInstId taskInstId
*/
public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state, Date startTime, String host,
String executePath,
String logPath,
int taskInstId) {
taskInstance.setState(state);
taskInstance.setStartTime(startTime);
taskInstance.setHost(host);
taskInstance.setExecutePath(executePath);
taskInstance.setLogPath(logPath);
saveTaskInstance(taskInstance);
}
/**
* update process instance
*
* @param processInstance processInstance
* @return update process instance result
*/
public int updateProcessInstance(ProcessInstance processInstance) {
return processInstanceMapper.updateById(processInstance);
}
/**
* change task state
*
* @param state state
* @param endTime endTime
* @param taskInstId taskInstId
* @param varPool varPool
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state,
Date endTime,
int processId,
String appIds,
int taskInstId,
String varPool) {
taskInstance.setPid(processId);
taskInstance.setAppLink(appIds);
taskInstance.setState(state);
taskInstance.setEndTime(endTime);
taskInstance.setVarPool(varPool);
changeOutParam(taskInstance);
saveTaskInstance(taskInstance);
}
/**
* for show in page of taskInstance
*
* @param taskInstance
*/
public void changeOutParam(TaskInstance taskInstance) {
if (StringUtils.isEmpty(taskInstance.getVarPool())) {
return;
}
List<Property> properties = JSONUtils.toList(taskInstance.getVarPool(), Property.class);
if (CollectionUtils.isEmpty(properties)) {
return;
}
//
Map<String, Object> taskParams = JSONUtils.toMap(taskInstance.getTaskParams(), String.class, Object.class);
Object localParams = taskParams.get(LOCAL_PARAMS); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (localParams == null) {
return;
}
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> outProperty = new HashMap<>();
for (Property info : properties) {
if (info.getDirect() == Direct.OUT) {
outProperty.put(info.getProp(), info.getValue());
}
}
for (Property info : allParam) {
if (info.getDirect() == Direct.OUT) {
String paramName = info.getProp();
info.setValue(outProperty.get(paramName));
}
}
taskParams.put(LOCAL_PARAMS, allParam);
taskInstance.setTaskParams(JSONUtils.toJsonString(taskParams));
}
/**
* convert integer list to string list
*
* @param intList intList
* @return string list
*/
public List<String> convertIntListToString(List<Integer> intList) {
if (intList == null) {
return new ArrayList<>();
}
List<String> result = new ArrayList<>(intList.size()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | for (Integer intVar : intList) {
result.add(String.valueOf(intVar));
}
return result;
}
/**
* query schedule by id
*
* @param id id
* @return schedule
*/
public Schedule querySchedule(int id) {
return scheduleMapper.selectById(id);
}
/**
* query Schedule by processDefinitionCode
*
* @param processDefinitionCode processDefinitionCode
* @see Schedule
*/
public List<Schedule> queryReleaseSchedulerListByProcessDefinitionCode(long processDefinitionCode) {
return scheduleMapper.queryReleaseSchedulerListByProcessDefinitionCode(processDefinitionCode);
}
/**
* query need failover process instance
*
* @param host host
* @return process instance list
*/
public List<ProcessInstance> queryNeedFailoverProcessInstances(String host) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return processInstanceMapper.queryByHostAndStatus(host, stateArray);
}
/**
* process need failover process instance
*
* @param processInstance processInstance
*/
@Transactional(rollbackFor = RuntimeException.class)
public void processNeedFailoverProcessInstances(ProcessInstance processInstance) {
//
processInstance.setHost(Constants.NULL);
processInstanceMapper.updateById(processInstance);
ProcessDefinition processDefinition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
//
Command cmd = new Command();
cmd.setProcessDefinitionCode(processDefinition.getCode());
cmd.setCommandParam(String.format("{\"%s\":%d}", Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING, processInstance.getId()));
cmd.setExecutorId(processInstance.getExecutorId());
cmd.setCommandType(CommandType.RECOVER_TOLERANCE_FAULT_PROCESS);
createCommand(cmd);
}
/**
* query all need failover task instances by host
*
* @param host host
* @return task instance list
*/
public List<TaskInstance> queryNeedFailoverTaskInstances(String host) {
return taskInstanceMapper.queryByHostAndStatus(host,
stateArray); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* find data source by id
*
* @param id id
* @return datasource
*/
public DataSource findDataSourceById(int id) {
return dataSourceMapper.selectById(id);
}
/**
* update process instance state by id
*
* @param processInstanceId processInstanceId
* @param executionStatus executionStatus
* @return update process result
*/
public int updateProcessInstanceState(Integer processInstanceId, ExecutionStatus executionStatus) {
ProcessInstance instance = processInstanceMapper.selectById(processInstanceId);
instance.setState(executionStatus);
return processInstanceMapper.updateById(instance);
}
/**
* find process instance by the task id
*
* @param taskId taskId
* @return process instance
*/
public ProcessInstance findProcessInstanceByTaskId(int taskId) {
TaskInstance taskInstance = taskInstanceMapper.selectById(taskId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (taskInstance != null) {
return processInstanceMapper.selectById(taskInstance.getProcessInstanceId());
}
return null;
}
/**
* find udf function list by id list string
*
* @param ids ids
* @return udf function list
*/
public List<UdfFunc> queryUdfFunListByIds(int[] ids) {
return udfFuncMapper.queryUdfByIdStr(ids, null);
}
/**
* find tenant code by resource name
*
* @param resName resource name
* @param resourceType resource type
* @return tenant code
*/
public String queryTenantCodeByResName(String resName, ResourceType resourceType) {
//
String fullName = resName.startsWith("/") ? resName : String.format("/%s", resName);
List<Resource> resourceList = resourceMapper.queryResource(fullName, resourceType.ordinal());
if (CollectionUtils.isEmpty(resourceList)) {
return StringUtils.EMPTY;
}
int userId = resourceList.get(0).getUserId();
User user = userMapper.selectById(userId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (Objects.isNull(user)) {
return StringUtils.EMPTY;
}
Tenant tenant = tenantMapper.selectById(user.getTenantId());
if (Objects.isNull(tenant)) {
return StringUtils.EMPTY;
}
return tenant.getTenantCode();
}
/**
* find schedule list by process define codes.
*
* @param codes codes
* @return schedule list
*/
public List<Schedule> selectAllByProcessDefineCode(long[] codes) {
return scheduleMapper.selectAllByProcessDefineArray(codes);
}
/**
* find last scheduler process instance in the date interval
*
* @param definitionCode definitionCode
* @param dateInterval dateInterval
* @return process instance
*/
public ProcessInstance findLastSchedulerProcessInterval(Long definitionCode, DateInterval dateInterval) {
return processInstanceMapper.queryLastSchedulerProcess(definitionCode,
dateInterval.getStartTime(),
dateInterval.getEndTime());
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* find last manual process instance interval
*
* @param definitionCode process definition code
* @param dateInterval dateInterval
* @return process instance
*/
public ProcessInstance findLastManualProcessInterval(Long definitionCode, DateInterval dateInterval) {
return processInstanceMapper.queryLastManualProcess(definitionCode,
dateInterval.getStartTime(),
dateInterval.getEndTime());
}
/**
* find last running process instance
*
* @param definitionCode process definition code
* @param startTime start time
* @param endTime end time
* @return process instance
*/
public ProcessInstance findLastRunningProcess(Long definitionCode, Date startTime, Date endTime) {
return processInstanceMapper.queryLastRunningProcess(definitionCode,
startTime,
endTime,
stateArray);
}
/**
* query user queue by process instance id
*
* @param processInstanceId processInstanceId |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @return queue
*/
public String queryUserQueueByProcessInstanceId(int processInstanceId) {
String queue = "";
ProcessInstance processInstance = processInstanceMapper.selectById(processInstanceId);
if (processInstance == null) {
return queue;
}
User executor = userMapper.selectById(processInstance.getExecutorId());
if (executor != null) {
queue = executor.getQueue();
}
return queue;
}
/**
* query project name and user name by processInstanceId.
*
* @param processInstanceId processInstanceId
* @return projectName and userName
*/
public ProjectUser queryProjectWithUserByProcessInstanceId(int processInstanceId) {
return projectMapper.queryProjectWithUserByProcessInstanceId(processInstanceId);
}
/**
* get task worker group
*
* @param taskInstance taskInstance
* @return workerGroupId
*/
public String getTaskWorkerGroup(TaskInstance taskInstance) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | String workerGroup = taskInstance.getWorkerGroup();
if (StringUtils.isNotBlank(workerGroup)) {
return workerGroup;
}
int processInstanceId = taskInstance.getProcessInstanceId();
ProcessInstance processInstance = findProcessInstanceById(processInstanceId);
if (processInstance != null) {
return processInstance.getWorkerGroup();
}
logger.info("task : {} will use default worker group", taskInstance.getId());
return Constants.DEFAULT_WORKER_GROUP;
}
/**
* get have perm project list
*
* @param userId userId
* @return project list
*/
public List<Project> getProjectListHavePerm(int userId) {
List<Project> createProjects = projectMapper.queryProjectCreatedByUser(userId);
List<Project> authedProjects = projectMapper.queryAuthedProjectListByUserId(userId);
if (createProjects == null) {
createProjects = new ArrayList<>();
}
if (authedProjects != null) {
createProjects.addAll(authedProjects);
}
return createProjects;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * list unauthorized udf function
*
* @param userId user id
* @param needChecks data source id array
* @return unauthorized udf function list
*/
public <T> List<T> listUnauthorized(int userId, T[] needChecks, AuthorizationType authorizationType) {
List<T> resultList = new ArrayList<>();
if (Objects.nonNull(needChecks) && needChecks.length > 0) {
Set<T> originResSet = new HashSet<>(Arrays.asList(needChecks));
switch (authorizationType) {
case RESOURCE_FILE_ID:
case UDF_FILE:
List<Resource> ownUdfResources = resourceMapper.listAuthorizedResourceById(userId, needChecks);
addAuthorizedResources(ownUdfResources, userId);
Set<Integer> authorizedResourceFiles = ownUdfResources.stream().map(Resource::getId).collect(toSet());
originResSet.removeAll(authorizedResourceFiles);
break;
case RESOURCE_FILE_NAME:
List<Resource> ownResources = resourceMapper.listAuthorizedResource(userId, needChecks);
addAuthorizedResources(ownResources, userId);
Set<String> authorizedResources = ownResources.stream().map(Resource::getFullName).collect(toSet());
originResSet.removeAll(authorizedResources);
break;
case DATASOURCE:
Set<Integer> authorizedDatasources = dataSourceMapper.listAuthorizedDataSource(userId, needChecks).stream().map(DataSource::getId).collect(toSet());
originResSet.removeAll(authorizedDatasources);
break;
case UDF:
Set<Integer> authorizedUdfs = udfFuncMapper.listAuthorizedUdfFunc(userId, needChecks).stream().map(UdfFunc::getId).collect(toSet()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | originResSet.removeAll(authorizedUdfs);
break;
default:
break;
}
resultList.addAll(originResSet);
}
return resultList;
}
/**
* get user by user id
*
* @param userId user id
* @return User
*/
public User getUserById(int userId) {
return userMapper.selectById(userId);
}
/**
* get resource by resource id
*
* @param resourceId resource id
* @return Resource
*/
public Resource getResourceById(int resourceId) {
return resourceMapper.selectById(resourceId);
}
/**
* list resources by ids
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param resIds resIds
* @return resource list
*/
public List<Resource> listResourceByIds(Integer[] resIds) {
return resourceMapper.listResourceByIds(resIds);
}
/**
* format task app id in task instance
*/
public String formatTaskAppId(TaskInstance taskInstance) {
ProcessInstance processInstance = findProcessInstanceById(taskInstance.getProcessInstanceId());
if (processInstance == null) {
return "";
}
ProcessDefinition definition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
if (definition == null) {
return "";
}
return String.format("%s_%s_%s", definition.getId(), processInstance.getId(), taskInstance.getId());
}
/**
* switch process definition version to process definition log version
*/
public int switchVersion(ProcessDefinition processDefinition, ProcessDefinitionLog processDefinitionLog) {
if (null == processDefinition || null == processDefinitionLog) {
return Constants.DEFINITION_FAILURE;
}
processDefinitionLog.setId(processDefinition.getId());
processDefinitionLog.setReleaseState(ReleaseState.OFFLINE);
processDefinitionLog.setFlag(Flag.YES); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | int result = processDefineMapper.updateById(processDefinitionLog);
if (result > 0) {
result = switchProcessTaskRelationVersion(processDefinition);
if (result <= 0) {
return Constants.DEFINITION_FAILURE;
}
}
return result;
}
public int switchProcessTaskRelationVersion(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
if (!processTaskRelationList.isEmpty()) {
processTaskRelationMapper.deleteByCode(processDefinition.getProjectCode(), processDefinition.getCode());
}
List<ProcessTaskRelationLog> processTaskRelationLogList = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion());
return processTaskRelationMapper.batchInsert(processTaskRelationLogList);
}
/**
* get resource ids
*
* @param taskDefinition taskDefinition
* @return resource ids
*/
public String getResourceIds(TaskDefinition taskDefinition) {
Set<Integer> resourceIds = null;
AbstractParameters params = TaskParametersUtils.getParameters(taskDefinition.getTaskType(), taskDefinition.getTaskParams());
if (params != null && CollectionUtils.isNotEmpty(params.getResourceFilesList())) {
resourceIds = params.getResourceFilesList().
stream()
.filter(t -> t.getId() != 0) |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | .map(ResourceInfo::getId)
.collect(Collectors.toSet());
}
if (CollectionUtils.isEmpty(resourceIds)) {
return StringUtils.EMPTY;
}
return StringUtils.join(resourceIds, ",");
}
public int saveTaskDefine(User operator, long projectCode, List<TaskDefinitionLog> taskDefinitionLogs) {
Date now = new Date();
List<TaskDefinitionLog> newTaskDefinitionLogs = new ArrayList<>();
List<TaskDefinitionLog> updateTaskDefinitionLogs = new ArrayList<>();
for (TaskDefinitionLog taskDefinitionLog : taskDefinitionLogs) {
taskDefinitionLog.setProjectCode(projectCode);
taskDefinitionLog.setUpdateTime(now);
taskDefinitionLog.setOperateTime(now);
taskDefinitionLog.setOperator(operator.getId());
taskDefinitionLog.setResourceIds(getResourceIds(taskDefinitionLog));
if (taskDefinitionLog.getCode() > 0 && taskDefinitionLog.getVersion() > 0) {
TaskDefinitionLog definitionCodeAndVersion = taskDefinitionLogMapper
.queryByDefinitionCodeAndVersion(taskDefinitionLog.getCode(), taskDefinitionLog.getVersion());
if (definitionCodeAndVersion != null) {
if (!taskDefinitionLog.equals(definitionCodeAndVersion)) {
taskDefinitionLog.setUserId(definitionCodeAndVersion.getUserId());
Integer version = taskDefinitionLogMapper.queryMaxVersionForDefinition(taskDefinitionLog.getCode());
taskDefinitionLog.setVersion(version + 1);
taskDefinitionLog.setCreateTime(definitionCodeAndVersion.getCreateTime());
updateTaskDefinitionLogs.add(taskDefinitionLog);
}
continue; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
}
taskDefinitionLog.setUserId(operator.getId());
taskDefinitionLog.setVersion(Constants.VERSION_FIRST);
taskDefinitionLog.setCreateTime(now);
if (taskDefinitionLog.getCode() == 0) {
try {
taskDefinitionLog.setCode(SnowFlakeUtils.getInstance().nextId());
} catch (SnowFlakeException e) {
logger.error("Task code get error, ", e);
return Constants.DEFINITION_FAILURE;
}
}
newTaskDefinitionLogs.add(taskDefinitionLog);
}
int insertResult = 0;
int updateResult = 0;
for (TaskDefinitionLog taskDefinitionToUpdate : updateTaskDefinitionLogs) {
TaskDefinition task = taskDefinitionMapper.queryByCode(taskDefinitionToUpdate.getCode());
if (task == null) {
newTaskDefinitionLogs.add(taskDefinitionToUpdate);
} else {
insertResult += taskDefinitionLogMapper.insert(taskDefinitionToUpdate);
taskDefinitionToUpdate.setId(task.getId());
updateResult += taskDefinitionMapper.updateById(taskDefinitionToUpdate);
}
}
if (!newTaskDefinitionLogs.isEmpty()) {
updateResult += taskDefinitionMapper.batchInsert(newTaskDefinitionLogs);
insertResult += taskDefinitionLogMapper.batchInsert(newTaskDefinitionLogs); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
return (insertResult & updateResult) > 0 ? 1 : Constants.EXIT_CODE_SUCCESS;
}
/**
* save processDefinition (including create or update processDefinition)
*/
public int saveProcessDefine(User operator, ProcessDefinition processDefinition, Boolean isFromProcessDefine) {
ProcessDefinitionLog processDefinitionLog = new ProcessDefinitionLog(processDefinition);
Integer version = processDefineLogMapper.queryMaxVersionForDefinition(processDefinition.getCode());
int insertVersion = version == null || version == 0 ? Constants.VERSION_FIRST : version + 1;
processDefinitionLog.setVersion(insertVersion);
processDefinitionLog.setReleaseState(isFromProcessDefine ? ReleaseState.OFFLINE : ReleaseState.ONLINE);
processDefinitionLog.setOperator(operator.getId());
processDefinitionLog.setOperateTime(processDefinition.getUpdateTime());
int insertLog = processDefineLogMapper.insert(processDefinitionLog);
int result;
if (0 == processDefinition.getId()) {
result = processDefineMapper.insert(processDefinitionLog);
} else {
processDefinitionLog.setId(processDefinition.getId());
result = processDefineMapper.updateById(processDefinitionLog);
}
return (insertLog & result) > 0 ? insertVersion : 0;
}
/**
* save task relations
*/
public int saveTaskRelation(User operator, long projectCode, long processDefinitionCode, int processDefinitionVersion,
List<ProcessTaskRelationLog> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) {
Map<Long, TaskDefinitionLog> taskDefinitionLogMap = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (CollectionUtils.isNotEmpty(taskDefinitionLogs)) {
taskDefinitionLogMap = taskDefinitionLogs.stream()
.collect(Collectors.toMap(TaskDefinition::getCode, taskDefinitionLog -> taskDefinitionLog));
}
Date now = new Date();
for (ProcessTaskRelationLog processTaskRelationLog : taskRelationList) {
processTaskRelationLog.setProjectCode(projectCode);
processTaskRelationLog.setProcessDefinitionCode(processDefinitionCode);
processTaskRelationLog.setProcessDefinitionVersion(processDefinitionVersion);
if (taskDefinitionLogMap != null) {
TaskDefinitionLog taskDefinitionLog = taskDefinitionLogMap.get(processTaskRelationLog.getPreTaskCode());
if (taskDefinitionLog != null) {
processTaskRelationLog.setPreTaskVersion(taskDefinitionLog.getVersion());
}
processTaskRelationLog.setPostTaskVersion(taskDefinitionLogMap.get(processTaskRelationLog.getPostTaskCode()).getVersion());
}
processTaskRelationLog.setCreateTime(now);
processTaskRelationLog.setUpdateTime(now);
processTaskRelationLog.setOperator(operator.getId());
processTaskRelationLog.setOperateTime(now);
}
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode);
if (!processTaskRelationList.isEmpty()) {
Set<Integer> processTaskRelationSet = processTaskRelationList.stream().map(ProcessTaskRelation::hashCode).collect(toSet());
Set<Integer> taskRelationSet = taskRelationList.stream().map(ProcessTaskRelationLog::hashCode).collect(toSet());
if (CollectionUtils.isEqualCollection(processTaskRelationSet, taskRelationSet)) {
return Constants.EXIT_CODE_SUCCESS;
}
processTaskRelationMapper.deleteByCode(projectCode, processDefinitionCode);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | int result = processTaskRelationMapper.batchInsert(taskRelationList);
int resultLog = processTaskRelationLogMapper.batchInsert(taskRelationList);
return (result & resultLog) > 0 ? Constants.EXIT_CODE_SUCCESS : Constants.EXIT_CODE_FAILURE;
}
public boolean isTaskOnline(long taskCode) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByTaskCode(taskCode);
if (!processTaskRelationList.isEmpty()) {
Set<Long> processDefinitionCodes = processTaskRelationList
.stream()
.map(ProcessTaskRelation::getProcessDefinitionCode)
.collect(Collectors.toSet());
List<ProcessDefinition> processDefinitionList = processDefineMapper.queryByCodes(processDefinitionCodes);
//
for (ProcessDefinition processDefinition : processDefinitionList) {
if (processDefinition.getReleaseState() == ReleaseState.ONLINE) {
return true;
}
}
}
return false;
}
/**
* Generate the DAG Graph based on the process definition id
*
* @param processDefinition process definition
* @return dag graph
*/
public DAG<String, TaskNode, TaskNodeRelation> genDagGraph(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
List<TaskNode> taskNodeList = transformTask(processTaskRelations, Lists.newArrayList()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessDag processDag = DagHelper.getProcessDag(taskNodeList, new ArrayList<>(processTaskRelations));
//
return DagHelper.buildDagGraph(processDag);
}
/**
* generate DagData
*/
public DagData genDagData(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
List<TaskDefinitionLog> taskDefinitionLogList = genTaskDefineList(processTaskRelations);
List<TaskDefinition> taskDefinitions = taskDefinitionLogList.stream()
.map(taskDefinitionLog -> JSONUtils.parseObject(JSONUtils.toJsonString(taskDefinitionLog), TaskDefinition.class))
.collect(Collectors.toList());
return new DagData(processDefinition, processTaskRelations, taskDefinitions);
}
public List<TaskDefinitionLog> genTaskDefineList(List<ProcessTaskRelation> processTaskRelations) {
Set<TaskDefinition> taskDefinitionSet = new HashSet<>();
for (ProcessTaskRelation processTaskRelation : processTaskRelations) {
if (processTaskRelation.getPreTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPreTaskCode(), processTaskRelation.getPreTaskVersion()));
}
if (processTaskRelation.getPostTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion()));
}
}
return taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet);
}
/**
* find task definition by code and version
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public TaskDefinition findTaskDefinition(long taskCode, int taskDefinitionVersion) {
return taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, taskDefinitionVersion);
}
/**
* find process task relation list by projectCode and processDefinitionCode
*/
public List<ProcessTaskRelation> findRelationByCode(long projectCode, long processDefinitionCode) {
return processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode);
}
/**
* add authorized resources
*
* @param ownResources own resources
* @param userId userId
*/
private void addAuthorizedResources(List<Resource> ownResources, int userId) {
List<Integer> relationResourceIds = resourceUserMapper.queryResourcesIdListByUserIdAndPerm(userId, 7);
List<Resource> relationResources = CollectionUtils.isNotEmpty(relationResourceIds) ? resourceMapper.queryResourceListById(relationResourceIds) : new ArrayList<>();
ownResources.addAll(relationResources);
}
/**
* Use temporarily before refactoring taskNode
*/
public List<TaskNode> transformTask(List<ProcessTaskRelation> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) {
Map<Long, List<Long>> taskCodeMap = new HashMap<>();
for (ProcessTaskRelation processTaskRelation : taskRelationList) {
taskCodeMap.compute(processTaskRelation.getPostTaskCode(), (k, v) -> {
if (v == null) {
v = new ArrayList<>();
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (processTaskRelation.getPreTaskCode() != 0L) {
v.add(processTaskRelation.getPreTaskCode());
}
return v;
});
}
if (CollectionUtils.isEmpty(taskDefinitionLogs)) {
taskDefinitionLogs = genTaskDefineList(taskRelationList);
}
Map<Long, TaskDefinitionLog> taskDefinitionLogMap = taskDefinitionLogs.stream()
.collect(Collectors.toMap(TaskDefinitionLog::getCode, taskDefinitionLog -> taskDefinitionLog));
List<TaskNode> taskNodeList = new ArrayList<>();
for (Entry<Long, List<Long>> code : taskCodeMap.entrySet()) {
TaskDefinitionLog taskDefinitionLog = taskDefinitionLogMap.get(code.getKey());
if (taskDefinitionLog != null) {
TaskNode taskNode = new TaskNode();
taskNode.setCode(taskDefinitionLog.getCode());
taskNode.setVersion(taskDefinitionLog.getVersion());
taskNode.setName(taskDefinitionLog.getName());
taskNode.setDesc(taskDefinitionLog.getDescription());
taskNode.setType(taskDefinitionLog.getTaskType().toUpperCase());
taskNode.setRunFlag(taskDefinitionLog.getFlag() == Flag.YES ? Constants.FLOWNODE_RUN_FLAG_NORMAL : Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
taskNode.setMaxRetryTimes(taskDefinitionLog.getFailRetryTimes());
taskNode.setRetryInterval(taskDefinitionLog.getFailRetryInterval());
Map<String, Object> taskParamsMap = taskNode.taskParamsToJsonObj(taskDefinitionLog.getTaskParams());
taskNode.setConditionResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.CONDITION_RESULT)));
taskNode.setSwitchResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.SWITCH_RESULT)));
taskNode.setDependence(JSONUtils.toJsonString(taskParamsMap.get(Constants.DEPENDENCE)));
taskParamsMap.remove(Constants.CONDITION_RESULT);
taskParamsMap.remove(Constants.DEPENDENCE); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | taskNode.setParams(JSONUtils.toJsonString(taskParamsMap));
taskNode.setTaskInstancePriority(taskDefinitionLog.getTaskPriority());
taskNode.setWorkerGroup(taskDefinitionLog.getWorkerGroup());
taskNode.setEnvironmentCode(taskDefinitionLog.getEnvironmentCode());
taskNode.setTimeout(JSONUtils.toJsonString(new TaskTimeoutParameter(taskDefinitionLog.getTimeoutFlag() == TimeoutFlag.OPEN,
taskDefinitionLog.getTimeoutNotifyStrategy(),
taskDefinitionLog.getTimeout())));
taskNode.setDelayTime(taskDefinitionLog.getDelayTime());
taskNode.setPreTasks(JSONUtils.toJsonString(code.getValue().stream().map(taskDefinitionLogMap::get).map(TaskDefinition::getName).collect(Collectors.toList())));
taskNodeList.add(taskNode);
}
}
return taskNodeList;
}
public Map<ProcessInstance, TaskInstance> notifyProcessList(int processId, int taskId) {
HashMap<ProcessInstance, TaskInstance> processTaskMap = new HashMap<>();
//
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(processId);
if (processInstanceMap == null) {
return processTaskMap;
}
ProcessInstance fatherProcess = this.findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
TaskInstance fatherTask = this.findTaskInstanceById(processInstanceMap.getParentTaskInstanceId());
if (fatherProcess != null) {
processTaskMap.put(fatherProcess, fatherTask);
}
return processTaskMap;
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.service.process;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_START_PARAMS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID;
import static org.mockito.ArgumentMatchers.any;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.CommandType;
import org.apache.dolphinscheduler.common.enums.Flag;
import org.apache.dolphinscheduler.common.enums.TaskType;
import org.apache.dolphinscheduler.common.enums.UserType;
import org.apache.dolphinscheduler.common.enums.WarningType;
import org.apache.dolphinscheduler.common.graph.DAG;
import org.apache.dolphinscheduler.common.model.TaskNode;
import org.apache.dolphinscheduler.common.model.TaskNodeRelation; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.dao.entity.Command;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinition;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.ProcessInstanceMap;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelation;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelationLog;
import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.dao.entity.User;
import org.apache.dolphinscheduler.dao.mapper.CommandMapper;
import org.apache.dolphinscheduler.dao.mapper.ErrorCommandMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.UserMapper;
import org.apache.dolphinscheduler.service.quartz.cron.CronUtilsTest;
import java.util.ArrayList;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.junit.Assert; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.junit.MockitoJUnitRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.fasterxml.jackson.databind.JsonNode;
import com.google.common.collect.Lists;
/**
* process service test
*/
@RunWith(MockitoJUnitRunner.class)
public class ProcessServiceTest {
private static final Logger logger = LoggerFactory.getLogger(CronUtilsTest.class);
@InjectMocks
private ProcessService processService;
@Mock
private CommandMapper commandMapper;
@Mock
private ProcessTaskRelationLogMapper processTaskRelationLogMapper;
@Mock
private ErrorCommandMapper errorCommandMapper;
@Mock
private ProcessDefinitionMapper processDefineMapper;
@Mock
private ProcessInstanceMapper processInstanceMapper;
@Mock
private UserMapper userMapper; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | @Mock
private TaskInstanceMapper taskInstanceMapper;
@Mock
private TaskDefinitionLogMapper taskDefinitionLogMapper;
@Mock
private TaskDefinitionMapper taskDefinitionMapper;
@Mock
private ProcessTaskRelationMapper processTaskRelationMapper;
@Mock
private ProcessDefinitionLogMapper processDefineLogMapper;
@Test
public void testCreateSubCommand() {
ProcessInstance parentInstance = new ProcessInstance();
parentInstance.setWarningType(WarningType.SUCCESS);
parentInstance.setWarningGroupId(0);
TaskInstance task = new TaskInstance();
task.setTaskParams("{\"processDefinitionId\":100}}");
task.setId(10);
task.setTaskCode(1L);
task.setTaskDefinitionVersion(1);
ProcessInstance childInstance = null;
ProcessInstanceMap instanceMap = new ProcessInstanceMap();
instanceMap.setParentProcessInstanceId(1);
instanceMap.setParentTaskInstanceId(10);
Command command;
parentInstance.setHistoryCmd("START_PROCESS");
parentInstance.setCommandType(CommandType.START_PROCESS);
ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setCode(1L); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | Mockito.when(processDefineMapper.queryByDefineId(100)).thenReturn(processDefinition);
command = processService.createSubProcessCommand(parentInstance, childInstance, instanceMap, task);
Assert.assertEquals(CommandType.START_PROCESS, command.getCommandType());
parentInstance.setCommandType(CommandType.START_FAILURE_TASK_PROCESS);
parentInstance.setHistoryCmd("START_PROCESS,START_FAILURE_TASK_PROCESS");
command = processService.createSubProcessCommand(parentInstance, childInstance, instanceMap, task);
Assert.assertEquals(CommandType.START_PROCESS, command.getCommandType());
parentInstance.setCommandType(CommandType.START_FAILURE_TASK_PROCESS);
parentInstance.setHistoryCmd("SCHEDULER,START_FAILURE_TASK_PROCESS");
command = processService.createSubProcessCommand(parentInstance, childInstance, instanceMap, task);
Assert.assertEquals(CommandType.SCHEDULER, command.getCommandType());
String startString = "2020-01-01 00:00:00";
String endString = "2020-01-10 00:00:00";
parentInstance.setCommandType(CommandType.START_FAILURE_TASK_PROCESS);
parentInstance.setHistoryCmd("COMPLEMENT_DATA,START_FAILURE_TASK_PROCESS");
Map<String, String> complementMap = new HashMap<>();
complementMap.put(Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE, startString);
complementMap.put(Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE, endString);
parentInstance.setCommandParam(JSONUtils.toJsonString(complementMap));
command = processService.createSubProcessCommand(parentInstance, childInstance, instanceMap, task);
Assert.assertEquals(CommandType.COMPLEMENT_DATA, command.getCommandType());
JsonNode complementDate = JSONUtils.parseObject(command.getCommandParam());
Date start = DateUtils.stringToDate(complementDate.get(Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE).asText());
Date end = DateUtils.stringToDate(complementDate.get(Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE).asText());
Assert.assertEquals(startString, DateUtils.dateToString(start));
Assert.assertEquals(endString, DateUtils.dateToString(end)); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | childInstance = new ProcessInstance();
parentInstance.setCommandType(CommandType.START_FAILURE_TASK_PROCESS);
parentInstance.setHistoryCmd("START_PROCESS,START_FAILURE_TASK_PROCESS");
command = processService.createSubProcessCommand(parentInstance, childInstance, instanceMap, task);
Assert.assertEquals(CommandType.START_FAILURE_TASK_PROCESS, command.getCommandType());
}
@Test
public void testVerifyIsNeedCreateCommand() {
List<Command> commands = new ArrayList<>();
Command command = new Command();
command.setCommandType(CommandType.REPEAT_RUNNING);
command.setCommandParam("{\"" + CMD_PARAM_RECOVER_PROCESS_ID_STRING + "\":\"111\"}");
commands.add(command);
Mockito.when(commandMapper.selectList(null)).thenReturn(commands);
Assert.assertFalse(processService.verifyIsNeedCreateCommand(command));
Command command1 = new Command();
command1.setCommandType(CommandType.REPEAT_RUNNING);
command1.setCommandParam("{\"" + CMD_PARAM_RECOVER_PROCESS_ID_STRING + "\":\"222\"}");
Assert.assertTrue(processService.verifyIsNeedCreateCommand(command1));
Command command2 = new Command();
command2.setCommandType(CommandType.PAUSE);
Assert.assertTrue(processService.verifyIsNeedCreateCommand(command2));
}
@Test
public void testCreateRecoveryWaitingThreadCommand() {
int id = 123;
Mockito.when(commandMapper.deleteById(id)).thenReturn(1);
ProcessInstance subProcessInstance = new ProcessInstance();
subProcessInstance.setIsSubProcess(Flag.YES);
Command originCommand = new Command(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | originCommand.setId(id);
processService.createRecoveryWaitingThreadCommand(originCommand, subProcessInstance);
ProcessInstance processInstance = new ProcessInstance();
processInstance.setId(111);
processService.createRecoveryWaitingThreadCommand(null, subProcessInstance);
Command recoverCommand = new Command();
recoverCommand.setCommandType(CommandType.RECOVER_WAITING_THREAD);
processService.createRecoveryWaitingThreadCommand(recoverCommand, subProcessInstance);
Command repeatRunningCommand = new Command();
recoverCommand.setCommandType(CommandType.REPEAT_RUNNING);
processService.createRecoveryWaitingThreadCommand(repeatRunningCommand, subProcessInstance);
ProcessInstance subProcessInstance2 = new ProcessInstance();
subProcessInstance2.setId(111);
subProcessInstance2.setIsSubProcess(Flag.NO);
processService.createRecoveryWaitingThreadCommand(repeatRunningCommand, subProcessInstance2);
}
@Test
public void testHandleCommand() {
String host = "127.0.0.1";
int validThreadNum = 1;
Command command = new Command();
command.setProcessDefinitionCode(222);
command.setCommandType(CommandType.REPEAT_RUNNING);
command.setCommandParam("{\"" + CMD_PARAM_RECOVER_PROCESS_ID_STRING + "\":\"111\",\""
+ CMD_PARAM_SUB_PROCESS_DEFINE_ID + "\":\"222\"}");
Assert.assertNull(processService.handleCommand(logger, host, validThreadNum, command));
Command command1 = new Command();
command1.setProcessDefinitionCode(123); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | command1.setCommandParam("{\"ProcessInstanceId\":222}");
command1.setCommandType(CommandType.START_PROCESS);
ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setId(123);
processDefinition.setName("test");
processDefinition.setVersion(1);
processDefinition.setCode(11L);
processDefinition.setGlobalParams("[{\"prop\":\"startParam1\",\"direct\":\"IN\",\"type\":\"VARCHAR\",\"value\":\"\"}]");
ProcessInstance processInstance = new ProcessInstance();
processInstance.setId(222);
processInstance.setProcessDefinitionCode(11L);
processInstance.setProcessDefinitionVersion(1);
Mockito.when(processDefineMapper.queryByCode(command1.getProcessDefinitionCode())).thenReturn(processDefinition);
Mockito.when(processDefineLogMapper.queryByDefinitionCodeAndVersion(processInstance.getProcessDefinitionCode(),
processInstance.getProcessDefinitionVersion())).thenReturn(new ProcessDefinitionLog(processDefinition));
Mockito.when(processInstanceMapper.queryDetailById(222)).thenReturn(processInstance);
Assert.assertNotNull(processService.handleCommand(logger, host, validThreadNum, command1));
Command command2 = new Command();
command2.setCommandParam("{\"ProcessInstanceId\":222,\"StartNodeIdList\":\"n1,n2\"}");
command2.setProcessDefinitionCode(123);
command2.setCommandType(CommandType.RECOVER_SUSPENDED_PROCESS);
Assert.assertNotNull(processService.handleCommand(logger, host, validThreadNum, command2));
Command command3 = new Command();
command3.setProcessDefinitionCode(123);
command3.setCommandParam("{\"WaitingThreadInstanceId\":222}");
command3.setCommandType(CommandType.START_FAILURE_TASK_PROCESS);
Assert.assertNotNull(processService.handleCommand(logger, host, validThreadNum, command3));
Command command4 = new Command();
command4.setProcessDefinitionCode(123);
command4.setCommandParam("{\"WaitingThreadInstanceId\":222,\"StartNodeIdList\":\"n1,n2\"}"); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | command4.setCommandType(CommandType.REPEAT_RUNNING);
Assert.assertNotNull(processService.handleCommand(logger, host, validThreadNum, command4));
Command command5 = new Command();
command5.setProcessDefinitionCode(123);
HashMap<String, String> startParams = new HashMap<>();
startParams.put("startParam1", "testStartParam1");
HashMap<String, String> commandParams = new HashMap<>();
commandParams.put(CMD_PARAM_START_PARAMS, JSONUtils.toJsonString(startParams));
command5.setCommandParam(JSONUtils.toJsonString(commandParams));
command5.setCommandType(CommandType.START_PROCESS);
ProcessInstance processInstance1 = processService.handleCommand(logger, host, validThreadNum, command5);
Assert.assertTrue(processInstance1.getGlobalParams().contains("\"testStartParam1\""));
}
@Test
public void testGetUserById() {
User user = new User();
user.setId(123);
Mockito.when(userMapper.selectById(123)).thenReturn(user);
Assert.assertEquals(user, processService.getUserById(123));
}
@Test
public void testFormatTaskAppId() {
TaskInstance taskInstance = new TaskInstance();
taskInstance.setId(333);
taskInstance.setProcessInstanceId(222);
Mockito.when(processService.findProcessInstanceById(taskInstance.getProcessInstanceId())).thenReturn(null);
Assert.assertEquals("", processService.formatTaskAppId(taskInstance));
ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setId(111);
ProcessInstance processInstance = new ProcessInstance(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | processInstance.setId(222);
processInstance.setProcessDefinitionVersion(1);
processInstance.setProcessDefinitionCode(1L);
Mockito.when(processService.findProcessInstanceById(taskInstance.getProcessInstanceId())).thenReturn(processInstance);
Assert.assertEquals("", processService.formatTaskAppId(taskInstance));
}
@Test
public void testRecurseFindSubProcessId() {
int parentProcessDefineId = 1;
long parentProcessDefineCode = 1L;
int parentProcessDefineVersion = 1;
ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setCode(parentProcessDefineCode);
processDefinition.setVersion(parentProcessDefineVersion);
Mockito.when(processDefineMapper.selectById(parentProcessDefineId)).thenReturn(processDefinition);
long postTaskCode = 2L;
int postTaskVersion = 2;
List<ProcessTaskRelationLog> relationLogList = new ArrayList<>();
ProcessTaskRelationLog processTaskRelationLog = new ProcessTaskRelationLog();
processTaskRelationLog.setPostTaskCode(postTaskCode);
processTaskRelationLog.setPostTaskVersion(postTaskVersion);
relationLogList.add(processTaskRelationLog);
Mockito.when(processTaskRelationLogMapper.queryByProcessCodeAndVersion(parentProcessDefineCode
, parentProcessDefineVersion)).thenReturn(relationLogList);
List<TaskDefinitionLog> taskDefinitionLogs = new ArrayList<>();
TaskDefinitionLog taskDefinitionLog1 = new TaskDefinitionLog();
taskDefinitionLog1.setTaskParams("{\"processDefinitionId\": 123}");
taskDefinitionLogs.add(taskDefinitionLog1);
Mockito.when(taskDefinitionLogMapper.queryByTaskDefinitions(Mockito.anySet())).thenReturn(taskDefinitionLogs);
List<Integer> ids = new ArrayList<>(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | processService.recurseFindSubProcessId(parentProcessDefineId, ids);
Assert.assertEquals(1, ids.size());
}
@Test
public void testSwitchVersion() {
ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setCode(1L);
processDefinition.setProjectCode(1L);
processDefinition.setId(123);
processDefinition.setName("test");
processDefinition.setVersion(1);
ProcessDefinitionLog processDefinitionLog = new ProcessDefinitionLog();
processDefinitionLog.setCode(1L);
processDefinitionLog.setVersion(2);
Assert.assertEquals(0, processService.switchVersion(processDefinition, processDefinitionLog));
}
@Test
public void testSaveTaskDefine() {
User operator = new User();
operator.setId(-1);
operator.setUserType(UserType.GENERAL_USER);
long projectCode = 751485690568704L;
String taskJson = "[{\"code\":751500437479424,\"name\":\"aa\",\"version\":1,\"description\":\"\",\"delayTime\":0,"
+ "\"taskType\":\"SHELL\",\"taskParams\":{\"resourceList\":[],\"localParams\":[],\"rawScript\":\"sleep 1s\\necho 11\","
+ "\"dependence\":{},\"conditionResult\":{\"successNode\":[\"\"],\"failedNode\":[\"\"]},\"waitStartTimeout\":{}},"
+ "\"flag\":\"YES\",\"taskPriority\":\"MEDIUM\",\"workerGroup\":\"yarn\",\"failRetryTimes\":0,\"failRetryInterval\":1,"
+ "\"timeoutFlag\":\"OPEN\",\"timeoutNotifyStrategy\":\"FAILED\",\"timeout\":1,\"environmentCode\":751496815697920},"
+ "{\"code\":751516889636864,\"name\":\"bb\",\"description\":\"\",\"taskType\":\"SHELL\",\"taskParams\":{\"resourceList\":[],"
+ "\"localParams\":[],\"rawScript\":\"echo 22\",\"dependence\":{},\"conditionResult\":{\"successNode\":[\"\"],\"failedNode\":[\"\"]},"
+ "\"waitStartTimeout\":{}},\"flag\":\"YES\",\"taskPriority\":\"MEDIUM\",\"workerGroup\":\"default\",\"failRetryTimes\":\"0\"," |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | + "\"failRetryInterval\":\"1\",\"timeoutFlag\":\"CLOSE\",\"timeoutNotifyStrategy\":\"\",\"timeout\":0,\"delayTime\":\"0\",\"environmentCode\":-1}]";
List<TaskDefinitionLog> taskDefinitionLogs = JSONUtils.toList(taskJson, TaskDefinitionLog.class);
TaskDefinitionLog taskDefinition = new TaskDefinitionLog();
taskDefinition.setCode(751500437479424L);
taskDefinition.setName("aa");
taskDefinition.setProjectCode(751485690568704L);
taskDefinition.setTaskType(TaskType.SHELL.getDesc());
taskDefinition.setUserId(-1);
taskDefinition.setVersion(1);
taskDefinition.setCreateTime(new Date());
taskDefinition.setUpdateTime(new Date());
Mockito.when(taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskDefinition.getCode(), taskDefinition.getVersion())).thenReturn(taskDefinition);
Mockito.when(taskDefinitionLogMapper.queryMaxVersionForDefinition(taskDefinition.getCode())).thenReturn(1);
Mockito.when(taskDefinitionMapper.queryByCode(taskDefinition.getCode())).thenReturn(taskDefinition);
int result = processService.saveTaskDefine(operator, projectCode, taskDefinitionLogs);
Assert.assertEquals(0, result);
}
@Test
public void testGenDagGraph() {
ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setCode(1L);
processDefinition.setId(123);
processDefinition.setName("test");
processDefinition.setVersion(1);
processDefinition.setCode(11L);
ProcessTaskRelation processTaskRelation = new ProcessTaskRelation();
processTaskRelation.setName("def 1");
processTaskRelation.setProcessDefinitionVersion(1);
processTaskRelation.setProjectCode(1L);
processTaskRelation.setProcessDefinitionCode(1L); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | processTaskRelation.setPostTaskCode(3L);
processTaskRelation.setPreTaskCode(2L);
processTaskRelation.setUpdateTime(new Date());
processTaskRelation.setCreateTime(new Date());
List<ProcessTaskRelation> list = new ArrayList<>();
list.add(processTaskRelation);
TaskDefinitionLog taskDefinition = new TaskDefinitionLog();
taskDefinition.setCode(3L);
taskDefinition.setName("1-test");
taskDefinition.setProjectCode(1L);
taskDefinition.setTaskType(TaskType.SHELL.getDesc());
taskDefinition.setUserId(1);
taskDefinition.setVersion(2);
taskDefinition.setCreateTime(new Date());
taskDefinition.setUpdateTime(new Date());
TaskDefinitionLog td2 = new TaskDefinitionLog();
td2.setCode(2L);
td2.setName("unit-test");
td2.setProjectCode(1L);
td2.setTaskType(TaskType.SHELL.getDesc());
td2.setUserId(1);
td2.setVersion(1);
td2.setCreateTime(new Date());
td2.setUpdateTime(new Date());
List<TaskDefinitionLog> taskDefinitionLogs = new ArrayList<>();
taskDefinitionLogs.add(taskDefinition);
taskDefinitionLogs.add(td2);
Mockito.when(taskDefinitionLogMapper.queryByTaskDefinitions(any())).thenReturn(taskDefinitionLogs);
Mockito.when(processTaskRelationMapper.queryByProcessCode(Mockito.anyLong(), Mockito.anyLong())).thenReturn(list);
DAG<String, TaskNode, TaskNodeRelation> stringTaskNodeTaskNodeRelationDAG = processService.genDagGraph(processDefinition); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,292 | [Bug] [Task] Spark task execute failed due to NPE | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
when execute spark task, a NullPointerException occurs due to `mainJar ` has no `resourceName` field.
it is because the master only saves `resourceId` of `mainJar` in the database, when the worker fetch task data from database, it does not query resource information, so the `mainJar ` field of `SparkParameters` is like this:
```json
{"id": 1}
```
`res` and `resourceName` are lost, and became `null` value in the object. this causes NPE when execute `mainJar.getResourceName()` method
### What you expected to happen
spark task execute successfully
### How to reproduce
create a new spark task, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6292 | https://github.com/apache/dolphinscheduler/pull/6295 | 35312fd498bf5f2059b0e77b68f557c388870310 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | "2021-09-22T12:03:42Z" | java | "2021-09-23T14:23:17Z" | dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java | Assert.assertEquals(1, stringTaskNodeTaskNodeRelationDAG.getNodesCount());
}
@Test
public void testCreateCommand() {
Command command = new Command();
command.setProcessDefinitionCode(123);
command.setCommandParam("{\"ProcessInstanceId\":222}");
command.setCommandType(CommandType.START_PROCESS);
int mockResult = 1;
Mockito.when(commandMapper.insert(command)).thenReturn(mockResult);
int exeMethodResult = processService.createCommand(command);
Assert.assertEquals(mockResult, exeMethodResult);
Mockito.verify(commandMapper, Mockito.times(1)).insert(command);
}
@Test
public void testChangeOutParam() {
TaskInstance taskInstance = new TaskInstance();
taskInstance.setProcessInstanceId(62);
ProcessInstance processInstance = new ProcessInstance();
processInstance.setId(62);
taskInstance.setVarPool("[{\"direct\":\"OUT\",\"prop\":\"test1\",\"type\":\"VARCHAR\",\"value\":\"\"}]");
taskInstance.setTaskParams("{\"type\":\"MYSQL\",\"datasource\":1,\"sql\":\"select id from tb_test limit 1\","
+ "\"udfs\":\"\",\"sqlType\":\"0\",\"sendEmail\":false,\"displayRows\":10,\"title\":\"\","
+ "\"groupId\":null,\"localParams\":[{\"prop\":\"test1\",\"direct\":\"OUT\",\"type\":\"VARCHAR\",\"value\":\"12\"}],"
+ "\"connParams\":\"\",\"preStatements\":[],\"postStatements\":[],\"conditionResult\":\"{\\\"successNode\\\":[\\\"\\\"],"
+ "\\\"failedNode\\\":[\\\"\\\"]}\",\"dependence\":\"{}\"}");
processService.changeOutParam(taskInstance);
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.api.service.impl;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID;
import org.apache.dolphinscheduler.api.dto.DagDataSchedule;
import org.apache.dolphinscheduler.api.dto.treeview.Instance;
import org.apache.dolphinscheduler.api.dto.treeview.TreeViewDto;
import org.apache.dolphinscheduler.api.enums.Status;
import org.apache.dolphinscheduler.api.exceptions.ServiceException;
import org.apache.dolphinscheduler.api.service.ProcessDefinitionService;
import org.apache.dolphinscheduler.api.service.ProcessInstanceService;
import org.apache.dolphinscheduler.api.service.ProjectService;
import org.apache.dolphinscheduler.api.service.SchedulerService;
import org.apache.dolphinscheduler.api.utils.CheckUtils;
import org.apache.dolphinscheduler.api.utils.FileUtils;
import org.apache.dolphinscheduler.api.utils.PageInfo;
import org.apache.dolphinscheduler.api.utils.Result;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.AuthorizationType;
import org.apache.dolphinscheduler.common.enums.ReleaseState;
import org.apache.dolphinscheduler.common.enums.UserType;
import org.apache.dolphinscheduler.common.graph.DAG;
import org.apache.dolphinscheduler.common.model.TaskNode;
import org.apache.dolphinscheduler.common.model.TaskNodeRelation;
import org.apache.dolphinscheduler.common.thread.Stopper;
import org.apache.dolphinscheduler.common.utils.CollectionUtils;
import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | import org.apache.dolphinscheduler.common.utils.SnowFlakeUtils;
import org.apache.dolphinscheduler.common.utils.SnowFlakeUtils.SnowFlakeException;
import org.apache.dolphinscheduler.dao.entity.DagData;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinition;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelation;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelationLog;
import org.apache.dolphinscheduler.dao.entity.Project;
import org.apache.dolphinscheduler.dao.entity.Schedule;
import org.apache.dolphinscheduler.dao.entity.TaskDefinition;
import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.dao.entity.Tenant;
import org.apache.dolphinscheduler.dao.entity.User;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationMapper;
import org.apache.dolphinscheduler.dao.mapper.ProjectMapper;
import org.apache.dolphinscheduler.dao.mapper.ScheduleMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.TenantMapper;
import org.apache.dolphinscheduler.dao.mapper.UserMapper;
import org.apache.dolphinscheduler.service.permission.PermissionCheck;
import org.apache.dolphinscheduler.service.process.ProcessService;
import org.apache.commons.lang.StringUtils;
import java.io.BufferedOutputStream; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Date;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.stream.Collectors;
import javax.servlet.ServletOutputStream;
import javax.servlet.http.HttpServletResponse;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import org.springframework.web.multipart.MultipartFile;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.google.common.collect.Lists;
/**
* process definition service impl
*/
@Service |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | public class ProcessDefinitionServiceImpl extends BaseServiceImpl implements ProcessDefinitionService {
private static final Logger logger = LoggerFactory.getLogger(ProcessDefinitionServiceImpl.class);
private static final String RELEASESTATE = "releaseState";
@Autowired
private ProjectMapper projectMapper;
@Autowired
private ProjectService projectService;
@Autowired
private UserMapper userMapper;
@Autowired
private ProcessDefinitionLogMapper processDefinitionLogMapper;
@Autowired
private ProcessDefinitionMapper processDefinitionMapper;
@Autowired
private ProcessInstanceService processInstanceService;
@Autowired
private TaskInstanceMapper taskInstanceMapper;
@Autowired
private ScheduleMapper scheduleMapper;
@Autowired |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | private ProcessService processService;
@Autowired
private ProcessTaskRelationMapper processTaskRelationMapper;
@Autowired
private ProcessTaskRelationLogMapper processTaskRelationLogMapper;
@Autowired
TaskDefinitionLogMapper taskDefinitionLogMapper;
@Autowired
private TaskDefinitionMapper taskDefinitionMapper;
@Autowired
private SchedulerService schedulerService;
@Autowired
private TenantMapper tenantMapper;
/**
* create process definition
*
* @param loginUser login user
* @param projectCode project code
* @param name process definition name
* @param description description
* @param globalParams global params
* @param locations locations for nodes
* @param timeout timeout
* @param tenantCode tenantCode
* @param taskRelationJson relation json for nodes
* @param taskDefinitionJson taskDefinitionJson
* @return create result code
*/
@Override
@Transactional(rollbackFor = RuntimeException.class) |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | public Map<String, Object> createProcessDefinition(User loginUser,
long projectCode,
String name,
String description,
String globalParams,
String locations,
int timeout,
String tenantCode,
String taskRelationJson,
String taskDefinitionJson) {
Project project = projectMapper.queryByCode(projectCode);
Map<String, Object> result = projectService.checkProjectAndAuth(loginUser, project, projectCode);
if (result.get(Constants.STATUS) != Status.SUCCESS) {
return result;
}
ProcessDefinition definition = processDefinitionMapper.verifyByDefineName(project.getCode(), name);
if (definition != null) {
putMsg(result, Status.PROCESS_DEFINITION_NAME_EXIST, name);
return result;
}
List<TaskDefinitionLog> taskDefinitionLogs = JSONUtils.toList(taskDefinitionJson, TaskDefinitionLog.class);
Map<String, Object> checkTaskDefinitions = checkTaskDefinitionList(taskDefinitionLogs, taskDefinitionJson);
if (checkTaskDefinitions.get(Constants.STATUS) != Status.SUCCESS) {
return checkTaskDefinitions;
}
List<ProcessTaskRelationLog> taskRelationList = JSONUtils.toList(taskRelationJson, ProcessTaskRelationLog.class);
Map<String, Object> checkRelationJson = checkTaskRelationList(taskRelationList, taskRelationJson, taskDefinitionLogs);
if (checkRelationJson.get(Constants.STATUS) != Status.SUCCESS) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | return checkRelationJson;
}
int tenantId = -1;
if (!Constants.DEFAULT.equals(tenantCode)) {
Tenant tenant = tenantMapper.queryByTenantCode(tenantCode);
if (tenant == null) {
putMsg(result, Status.TENANT_NOT_EXIST);
return result;
}
tenantId = tenant.getId();
}
long processDefinitionCode;
try {
processDefinitionCode = SnowFlakeUtils.getInstance().nextId();
} catch (SnowFlakeException e) {
putMsg(result, Status.INTERNAL_SERVER_ERROR_ARGS);
return result;
}
ProcessDefinition processDefinition = new ProcessDefinition(projectCode, name, processDefinitionCode, description,
globalParams, locations, timeout, loginUser.getId(), tenantId);
return createDagDefine(loginUser, taskRelationList, processDefinition, taskDefinitionLogs);
}
private Map<String, Object> createDagDefine(User loginUser,
List<ProcessTaskRelationLog> taskRelationList,
ProcessDefinition processDefinition,
List<TaskDefinitionLog> taskDefinitionLogs) {
Map<String, Object> result = new HashMap<>();
int saveTaskResult = processService.saveTaskDefine(loginUser, processDefinition.getProjectCode(), taskDefinitionLogs);
if (saveTaskResult == Constants.EXIT_CODE_SUCCESS) {
logger.info("The task has not changed, so skip"); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | }
if (saveTaskResult == Constants.DEFINITION_FAILURE) {
putMsg(result, Status.CREATE_TASK_DEFINITION_ERROR);
throw new ServiceException(Status.CREATE_TASK_DEFINITION_ERROR);
}
int insertVersion = processService.saveProcessDefine(loginUser, processDefinition, true);
if (insertVersion == 0) {
putMsg(result, Status.CREATE_PROCESS_DEFINITION_ERROR);
throw new ServiceException(Status.CREATE_PROCESS_DEFINITION_ERROR);
}
int insertResult = processService.saveTaskRelation(loginUser, processDefinition.getProjectCode(), processDefinition.getCode(), insertVersion, taskRelationList, taskDefinitionLogs);
if (insertResult == Constants.EXIT_CODE_SUCCESS) {
putMsg(result, Status.SUCCESS);
result.put(Constants.DATA_LIST, processDefinition);
} else {
putMsg(result, Status.CREATE_PROCESS_TASK_RELATION_ERROR);
throw new ServiceException(Status.CREATE_PROCESS_TASK_RELATION_ERROR);
}
return result;
}
private Map<String, Object> checkTaskDefinitionList(List<TaskDefinitionLog> taskDefinitionLogs, String taskDefinitionJson) {
Map<String, Object> result = new HashMap<>();
try {
if (taskDefinitionLogs.isEmpty()) {
logger.error("taskDefinitionJson invalid: {}", taskDefinitionJson);
putMsg(result, Status.DATA_IS_NOT_VALID, taskDefinitionJson);
return result;
}
for (TaskDefinitionLog taskDefinitionLog : taskDefinitionLogs) {
if (!CheckUtils.checkTaskDefinitionParameters(taskDefinitionLog)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,320 | [Bug] [API] batch delete process definition bug | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
batch delete process definition fail
### What you expected to happen
batch delete process definition success
### How to reproduce
batch delete process definition
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6320 | https://github.com/apache/dolphinscheduler/pull/6321 | c4375a54c167f8e96d80c3cc67ad0a607ba2ef7b | 99f593cf42d6abd4312c74511f60ac8a2eeafb25 | "2021-09-23T12:44:06Z" | java | "2021-09-23T14:43:15Z" | dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java | logger.error("task definition {} parameter invalid", taskDefinitionLog.getName());
putMsg(result, Status.PROCESS_NODE_S_PARAMETER_INVALID, taskDefinitionLog.getName());
return result;
}
}
putMsg(result, Status.SUCCESS);
} catch (Exception e) {
result.put(Constants.STATUS, Status.REQUEST_PARAMS_NOT_VALID_ERROR);
result.put(Constants.MSG, e.getMessage());
}
return result;
}
private Map<String, Object> checkTaskRelationList(List<ProcessTaskRelationLog> taskRelationList, String taskRelationJson, List<TaskDefinitionLog> taskDefinitionLogs) {
Map<String, Object> result = new HashMap<>();
try {
if (taskRelationList == null || taskRelationList.isEmpty()) {
logger.error("task relation list is null");
putMsg(result, Status.DATA_IS_NOT_VALID, taskRelationJson);
return result;
}
List<ProcessTaskRelation> processTaskRelations = taskRelationList.stream()
.map(processTaskRelationLog -> JSONUtils.parseObject(JSONUtils.toJsonString(processTaskRelationLog), ProcessTaskRelation.class))
.collect(Collectors.toList());
List<TaskNode> taskNodeList = processService.transformTask(processTaskRelations, taskDefinitionLogs);
if (taskNodeList.size() != taskRelationList.size()) {
Set<Long> postTaskCodes = taskRelationList.stream().map(ProcessTaskRelationLog::getPostTaskCode).collect(Collectors.toSet());
Set<Long> taskNodeCodes = taskNodeList.stream().map(TaskNode::getCode).collect(Collectors.toSet());
Collection<Long> codes = CollectionUtils.subtract(postTaskCodes, taskNodeCodes);
if (CollectionUtils.isNotEmpty(codes)) {
logger.error("the task code is not exit"); |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.