status
stringclasses 1
value | repo_name
stringclasses 31
values | repo_url
stringclasses 31
values | issue_id
int64 1
104k
| title
stringlengths 4
233
| body
stringlengths 0
186k
⌀ | issue_url
stringlengths 38
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown | updated_file
stringlengths 7
188
| chunk_content
stringlengths 1
1.03M
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | public void setAppLink(String appLink) {
this.appLink = appLink;
}
public Long getEnvironmentCode() {
return this.environmentCode;
}
public void setEnvironmentCode(Long environmentCode) {
this.environmentCode = environmentCode;
}
public String getEnvironmentConfig() {
return this.environmentConfig;
}
public void setEnvironmentConfig(String environmentConfig) {
this.environmentConfig = environmentConfig;
}
public DependentParameters getDependency() {
if (this.dependency == null) {
Map<String, Object> taskParamsMap = JSONUtils.toMap(this.getTaskParams(), String.class, Object.class);
this.dependency = JSONUtils.parseObject((String) taskParamsMap.get(Constants.DEPENDENCE), DependentParameters.class);
}
return this.dependency;
}
public void setDependency(DependentParameters dependency) {
this.dependency = dependency;
}
public SwitchParameters getSwitchDependency() {
if (this.switchDependency == null) {
Map<String, Object> taskParamsMap = JSONUtils.toMap(this.getTaskParams(), String.class, Object.class);
this.switchDependency = JSONUtils.parseObject((String) taskParamsMap.get(Constants.SWITCH_RESULT), SwitchParameters.class);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | return this.switchDependency;
}
public void setSwitchDependency(SwitchParameters switchDependency) {
Map<String, Object> taskParamsMap = JSONUtils.toMap(this.getTaskParams(), String.class, Object.class);
taskParamsMap.put(Constants.SWITCH_RESULT,JSONUtils.toJsonString(switchDependency));
this.setTaskParams(JSONUtils.toJsonString(taskParamsMap));
}
public Flag getFlag() {
return flag;
}
public void setFlag(Flag flag) {
this.flag = flag;
}
public String getProcessInstanceName() {
return processInstanceName;
}
public void setProcessInstanceName(String processInstanceName) {
this.processInstanceName = processInstanceName;
}
public String getDuration() {
return duration;
}
public void setDuration(String duration) {
this.duration = duration;
}
public int getMaxRetryTimes() {
return maxRetryTimes;
}
public void setMaxRetryTimes(int maxRetryTimes) {
this.maxRetryTimes = maxRetryTimes; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | }
public int getRetryInterval() {
return retryInterval;
}
public void setRetryInterval(int retryInterval) {
this.retryInterval = retryInterval;
}
public int getExecutorId() {
return executorId;
}
public void setExecutorId(int executorId) {
this.executorId = executorId;
}
public String getExecutorName() {
return executorName;
}
public void setExecutorName(String executorName) {
this.executorName = executorName;
}
public boolean isTaskComplete() {
return this.getState().typeIsPause()
|| this.getState().typeIsSuccess()
|| this.getState().typeIsCancel()
|| (this.getState().typeIsFailure() && !taskCanRetry());
}
public Map<String, String> getResources() {
return resources;
}
public void setResources(Map<String, String> resources) {
this.resources = resources; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | }
public boolean isSubProcess() {
return TaskType.SUB_PROCESS.getDesc().equalsIgnoreCase(this.taskType);
}
public boolean isDependTask() {
return TaskType.DEPENDENT.getDesc().equalsIgnoreCase(this.taskType);
}
public boolean isConditionsTask() {
return TaskType.CONDITIONS.getDesc().equalsIgnoreCase(this.taskType);
}
public boolean isSwitchTask() {
return TaskType.SWITCH.getDesc().equalsIgnoreCase(this.taskType);
}
/**
* determine if you can try again
*
* @return can try result
*/
public boolean taskCanRetry() {
if (this.isSubProcess()) {
return false;
}
if (this.getState() == ExecutionStatus.NEED_FAULT_TOLERANCE) {
return true;
} else {
return (this.getState().typeIsFailure()
&& this.getRetryTimes() < this.getMaxRetryTimes());
}
}
public Priority getTaskInstancePriority() { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | return taskInstancePriority;
}
public void setTaskInstancePriority(Priority taskInstancePriority) {
this.taskInstancePriority = taskInstancePriority;
}
public Priority getProcessInstancePriority() {
return processInstancePriority;
}
public void setProcessInstancePriority(Priority processInstancePriority) {
this.processInstancePriority = processInstancePriority;
}
public String getWorkerGroup() {
return workerGroup;
}
public void setWorkerGroup(String workerGroup) {
this.workerGroup = workerGroup;
}
public String getDependentResult() {
return dependentResult;
}
public void setDependentResult(String dependentResult) {
this.dependentResult = dependentResult;
}
public int getDelayTime() {
return delayTime;
}
public void setDelayTime(int delayTime) {
this.delayTime = delayTime;
}
@Override |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | public String toString() {
return "TaskInstance{"
+ "id=" + id
+ ", name='" + name + '\''
+ ", taskType='" + taskType + '\''
+ ", processInstanceId=" + processInstanceId
+ ", processInstanceName='" + processInstanceName + '\''
+ ", state=" + state
+ ", firstSubmitTime=" + firstSubmitTime
+ ", submitTime=" + submitTime
+ ", startTime=" + startTime
+ ", endTime=" + endTime
+ ", host='" + host + '\''
+ ", executePath='" + executePath + '\''
+ ", logPath='" + logPath + '\''
+ ", retryTimes=" + retryTimes
+ ", alertFlag=" + alertFlag
+ ", processInstance=" + processInstance
+ ", processDefine=" + processDefine
+ ", pid=" + pid
+ ", appLink='" + appLink + '\''
+ ", flag=" + flag
+ ", dependency='" + dependency + '\''
+ ", duration=" + duration
+ ", maxRetryTimes=" + maxRetryTimes
+ ", retryInterval=" + retryInterval
+ ", taskInstancePriority=" + taskInstancePriority
+ ", processInstancePriority=" + processInstancePriority
+ ", dependentResult='" + dependentResult + '\''
+ ", workerGroup='" + workerGroup + '\'' |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java | + ", environmentCode=" + environmentCode
+ ", environmentConfig='" + environmentConfig + '\''
+ ", executorId=" + executorId
+ ", executorName='" + executorName + '\''
+ ", delayTime=" + delayTime
+ '}';
}
public long getTaskCode() {
return taskCode;
}
public void setTaskCode(long taskCode) {
this.taskCode = taskCode;
}
public int getTaskDefinitionVersion() {
return taskDefinitionVersion;
}
public void setTaskDefinitionVersion(int taskDefinitionVersion) {
this.taskDefinitionVersion = taskDefinitionVersion;
}
public String getTaskParams() {
return taskParams;
}
public void setTaskParams(String taskParams) {
this.taskParams = taskParams;
}
public boolean isFirstRun() {
return endTime == null;
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.service.process;
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE;
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_EMPTY_SUB_PROCESS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_FATHER_PARAMS; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID;
import static org.apache.dolphinscheduler.common.Constants.LOCAL_PARAMS;
import static org.apache.dolphinscheduler.common.Constants.YYYY_MM_DD_HH_MM_SS;
import static java.util.stream.Collectors.toSet;
import com.fasterxml.jackson.core.type.TypeReference;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.AuthorizationType;
import org.apache.dolphinscheduler.common.enums.CommandType;
import org.apache.dolphinscheduler.common.enums.Direct;
import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
import org.apache.dolphinscheduler.common.enums.FailureStrategy;
import org.apache.dolphinscheduler.common.enums.Flag;
import org.apache.dolphinscheduler.common.enums.ReleaseState;
import org.apache.dolphinscheduler.common.enums.ResourceType;
import org.apache.dolphinscheduler.common.enums.TaskDependType;
import org.apache.dolphinscheduler.common.enums.TimeoutFlag;
import org.apache.dolphinscheduler.common.enums.WarningType;
import org.apache.dolphinscheduler.common.graph.DAG;
import org.apache.dolphinscheduler.common.model.DateInterval;
import org.apache.dolphinscheduler.common.model.TaskNode;
import org.apache.dolphinscheduler.common.model.TaskNodeRelation;
import org.apache.dolphinscheduler.common.process.ProcessDag;
import org.apache.dolphinscheduler.common.process.Property;
import org.apache.dolphinscheduler.common.process.ResourceInfo;
import org.apache.dolphinscheduler.common.task.AbstractParameters;
import org.apache.dolphinscheduler.common.task.TaskTimeoutParameter;
import org.apache.dolphinscheduler.common.task.subprocess.SubProcessParameters; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import org.apache.dolphinscheduler.common.utils.CollectionUtils;
import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.ParameterUtils;
import org.apache.dolphinscheduler.common.utils.SnowFlakeUtils;
import org.apache.dolphinscheduler.common.utils.SnowFlakeUtils.SnowFlakeException;
import org.apache.dolphinscheduler.common.utils.TaskParametersUtils;
import org.apache.dolphinscheduler.dao.entity.Command;
import org.apache.dolphinscheduler.dao.entity.DagData;
import org.apache.dolphinscheduler.dao.entity.DataSource;
import org.apache.dolphinscheduler.dao.entity.Environment;
import org.apache.dolphinscheduler.dao.entity.ErrorCommand;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinition;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.ProcessInstanceMap;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelation;
import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelationLog;
import org.apache.dolphinscheduler.dao.entity.Project;
import org.apache.dolphinscheduler.dao.entity.ProjectUser;
import org.apache.dolphinscheduler.dao.entity.Resource;
import org.apache.dolphinscheduler.dao.entity.Schedule;
import org.apache.dolphinscheduler.dao.entity.TaskDefinition;
import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.dao.entity.Tenant;
import org.apache.dolphinscheduler.dao.entity.UdfFunc;
import org.apache.dolphinscheduler.dao.entity.User;
import org.apache.dolphinscheduler.dao.mapper.CommandMapper;
import org.apache.dolphinscheduler.dao.mapper.DataSourceMapper; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import org.apache.dolphinscheduler.dao.mapper.EnvironmentMapper;
import org.apache.dolphinscheduler.dao.mapper.ErrorCommandMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationLogMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationMapper;
import org.apache.dolphinscheduler.dao.mapper.ProjectMapper;
import org.apache.dolphinscheduler.dao.mapper.ResourceMapper;
import org.apache.dolphinscheduler.dao.mapper.ResourceUserMapper;
import org.apache.dolphinscheduler.dao.mapper.ScheduleMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionLogMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.TenantMapper;
import org.apache.dolphinscheduler.dao.mapper.UdfFuncMapper;
import org.apache.dolphinscheduler.dao.mapper.UserMapper;
import org.apache.dolphinscheduler.dao.utils.DagHelper;
import org.apache.dolphinscheduler.remote.utils.Host;
import org.apache.dolphinscheduler.service.log.LogClientService;
import org.apache.commons.lang.StringUtils;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Date;
import java.util.EnumMap;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import java.util.Map.Entry;
import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
import org.springframework.transaction.annotation.Transactional;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.facebook.presto.jdbc.internal.guava.collect.Lists;
import com.fasterxml.jackson.databind.node.ObjectNode;
/**
* process relative dao that some mappers in this.
*/
@Component
public class ProcessService {
private final Logger logger = LoggerFactory.getLogger(getClass());
private final int[] stateArray = new int[]{ExecutionStatus.SUBMITTED_SUCCESS.ordinal(),
ExecutionStatus.RUNNING_EXECUTION.ordinal(),
ExecutionStatus.DELAY_EXECUTION.ordinal(),
ExecutionStatus.READY_PAUSE.ordinal(),
ExecutionStatus.READY_STOP.ordinal()};
@Autowired
private UserMapper userMapper;
@Autowired
private ProcessDefinitionMapper processDefineMapper;
@Autowired
private ProcessDefinitionLogMapper processDefineLogMapper;
@Autowired |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | private ProcessInstanceMapper processInstanceMapper;
@Autowired
private DataSourceMapper dataSourceMapper;
@Autowired
private ProcessInstanceMapMapper processInstanceMapMapper;
@Autowired
private TaskInstanceMapper taskInstanceMapper;
@Autowired
private CommandMapper commandMapper;
@Autowired
private ScheduleMapper scheduleMapper;
@Autowired
private UdfFuncMapper udfFuncMapper;
@Autowired
private ResourceMapper resourceMapper;
@Autowired
private ResourceUserMapper resourceUserMapper;
@Autowired
private ErrorCommandMapper errorCommandMapper;
@Autowired
private TenantMapper tenantMapper;
@Autowired
private ProjectMapper projectMapper;
@Autowired
private TaskDefinitionMapper taskDefinitionMapper;
@Autowired
private TaskDefinitionLogMapper taskDefinitionLogMapper;
@Autowired
private ProcessTaskRelationMapper processTaskRelationMapper;
@Autowired |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | private ProcessTaskRelationLogMapper processTaskRelationLogMapper;
@Autowired
private EnvironmentMapper environmentMapper;
/**
* handle Command (construct ProcessInstance from Command) , wrapped in transaction
*
* @param logger logger
* @param host host
* @param validThreadNum validThreadNum
* @param command found command
* @return process instance
*/
@Transactional(rollbackFor = Exception.class)
public ProcessInstance handleCommand(Logger logger, String host, int validThreadNum, Command command) {
ProcessInstance processInstance = constructProcessInstance(command, host);
if (processInstance == null) {
logger.error("scan command, command parameter is error: {}", command);
moveToErrorCommand(command, "process instance is null");
return null;
}
if (!checkThreadNum(command, validThreadNum)) {
logger.info("there is not enough thread for this command: {}", command);
return setWaitingThreadProcess(command, processInstance);
}
processInstance.setCommandType(command.getCommandType());
processInstance.addHistoryCmd(command.getCommandType());
saveProcessInstance(processInstance);
this.setSubProcessParam(processInstance);
this.commandMapper.deleteById(command.getId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return processInstance;
}
/**
* save error command, and delete original command
*
* @param command command
* @param message message
*/
@Transactional(rollbackFor = Exception.class)
public void moveToErrorCommand(Command command, String message) {
ErrorCommand errorCommand = new ErrorCommand(command, message);
this.errorCommandMapper.insert(errorCommand);
this.commandMapper.deleteById(command.getId());
}
/**
* set process waiting thread
*
* @param command command
* @param processInstance processInstance
* @return process instance
*/
private ProcessInstance setWaitingThreadProcess(Command command, ProcessInstance processInstance) {
processInstance.setState(ExecutionStatus.WAITING_THREAD);
if (command.getCommandType() != CommandType.RECOVER_WAITING_THREAD) {
processInstance.addHistoryCmd(command.getCommandType());
}
saveProcessInstance(processInstance);
this.setSubProcessParam(processInstance);
createRecoveryWaitingThreadCommand(command, processInstance);
return null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* check thread num
*
* @param command command
* @param validThreadNum validThreadNum
* @return if thread is enough
*/
private boolean checkThreadNum(Command command, int validThreadNum) {
int commandThreadCount = this.workProcessThreadNumCount(command.getProcessDefinitionCode());
return validThreadNum >= commandThreadCount;
}
/**
* insert one command
*
* @param command command
* @return create result
*/
public int createCommand(Command command) {
int result = 0;
if (command != null) {
result = commandMapper.insert(command);
}
return result;
}
/**
* find one command from queue list
*
* @return command
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public Command findOneCommand() {
return commandMapper.getOneToRun();
}
/**
* get command page
*
* @param pageSize
* @param pageNumber
* @return
*/
public List<Command> findCommandPage(int pageSize, int pageNumber) {
Page<Command> commandPage = new Page<>(pageNumber, pageSize);
return commandMapper.queryCommandPage(commandPage).getRecords();
}
/**
* check the input command exists in queue list
*
* @param command command
* @return create command result
*/
public boolean verifyIsNeedCreateCommand(Command command) {
boolean isNeedCreate = true;
EnumMap<CommandType, Integer> cmdTypeMap = new EnumMap<>(CommandType.class);
cmdTypeMap.put(CommandType.REPEAT_RUNNING, 1);
cmdTypeMap.put(CommandType.RECOVER_SUSPENDED_PROCESS, 1);
cmdTypeMap.put(CommandType.START_FAILURE_TASK_PROCESS, 1);
CommandType commandType = command.getCommandType();
if (cmdTypeMap.containsKey(commandType)) {
ObjectNode cmdParamObj = JSONUtils.parseObject(command.getCommandParam());
int processInstanceId = cmdParamObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | List<Command> commands = commandMapper.selectList(null);
for (Command tmpCommand : commands) {
if (cmdTypeMap.containsKey(tmpCommand.getCommandType())) {
ObjectNode tempObj = JSONUtils.parseObject(tmpCommand.getCommandParam());
if (tempObj != null && processInstanceId == tempObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt()) {
isNeedCreate = false;
break;
}
}
}
}
return isNeedCreate;
}
/**
* find process instance detail by id
*
* @param processId processId
* @return process instance
*/
public ProcessInstance findProcessInstanceDetailById(int processId) {
return processInstanceMapper.queryDetailById(processId);
}
/**
* get task node list by definitionId
*/
public List<TaskDefinition> getTaskNodeListByDefinitionId(Integer defineId) {
ProcessDefinition processDefinition = processDefineMapper.selectById(defineId);
if (processDefinition == null) {
logger.error("process define not exists"); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return new ArrayList<>();
}
List<ProcessTaskRelationLog> processTaskRelations = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion());
Set<TaskDefinition> taskDefinitionSet = new HashSet<>();
for (ProcessTaskRelationLog processTaskRelation : processTaskRelations) {
if (processTaskRelation.getPostTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion()));
}
}
List<TaskDefinitionLog> taskDefinitionLogs = taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet);
return new ArrayList<>(taskDefinitionLogs);
}
/**
* find process instance by id
*
* @param processId processId
* @return process instance
*/
public ProcessInstance findProcessInstanceById(int processId) {
return processInstanceMapper.selectById(processId);
}
/**
* find process define by id.
*
* @param processDefinitionId processDefinitionId
* @return process definition
*/
public ProcessDefinition findProcessDefineById(int processDefinitionId) {
return processDefineMapper.selectById(processDefinitionId);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* find process define by code and version.
*
* @param processDefinitionCode processDefinitionCode
* @return process definition
*/
public ProcessDefinition findProcessDefinition(Long processDefinitionCode, int version) {
ProcessDefinition processDefinition = processDefineMapper.queryByCode(processDefinitionCode);
if (processDefinition == null || processDefinition.getVersion() != version) {
processDefinition = processDefineLogMapper.queryByDefinitionCodeAndVersion(processDefinitionCode, version);
if (processDefinition != null) {
processDefinition.setId(0);
}
}
return processDefinition;
}
/**
* find process define by code.
*
* @param processDefinitionCode processDefinitionCode
* @return process definition
*/
public ProcessDefinition findProcessDefinitionByCode(Long processDefinitionCode) {
return processDefineMapper.queryByCode(processDefinitionCode);
}
/**
* delete work process instance by id
*
* @param processInstanceId processInstanceId
* @return delete process instance result |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
public int deleteWorkProcessInstanceById(int processInstanceId) {
return processInstanceMapper.deleteById(processInstanceId);
}
/**
* delete all sub process by parent instance id
*
* @param processInstanceId processInstanceId
* @return delete all sub process instance result
*/
public int deleteAllSubWorkProcessByParentId(int processInstanceId) {
List<Integer> subProcessIdList = processInstanceMapMapper.querySubIdListByParentId(processInstanceId);
for (Integer subId : subProcessIdList) {
deleteAllSubWorkProcessByParentId(subId);
deleteWorkProcessMapByParentId(subId);
removeTaskLogFile(subId);
deleteWorkProcessInstanceById(subId);
}
return 1;
}
/**
* remove task log file
*
* @param processInstanceId processInstanceId
*/
public void removeTaskLogFile(Integer processInstanceId) {
List<TaskInstance> taskInstanceList = findValidTaskListByProcessId(processInstanceId);
if (CollectionUtils.isEmpty(taskInstanceList)) {
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | try (LogClientService logClient = new LogClientService()) {
for (TaskInstance taskInstance : taskInstanceList) {
String taskLogPath = taskInstance.getLogPath();
if (StringUtils.isEmpty(taskInstance.getHost())) {
continue;
}
int port = Constants.RPC_PORT;
String ip = "";
try {
ip = Host.of(taskInstance.getHost()).getIp();
} catch (Exception e) {
ip = taskInstance.getHost();
}
logClient.removeTaskLog(ip, port, taskLogPath);
}
}
}
/**
* calculate sub process number in the process define.
*
* @param processDefinitionCode processDefinitionCode
* @return process thread num count
*/
private Integer workProcessThreadNumCount(long processDefinitionCode) {
ProcessDefinition processDefinition = processDefineMapper.queryByCode(processDefinitionCode);
List<Integer> ids = new ArrayList<>();
recurseFindSubProcessId(processDefinition.getId(), ids);
return ids.size() + 1; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* recursive query sub process definition id by parent id.
*
* @param parentId parentId
* @param ids ids
*/
public void recurseFindSubProcessId(int parentId, List<Integer> ids) {
List<TaskDefinition> taskNodeList = this.getTaskNodeListByDefinitionId(parentId);
if (taskNodeList != null && !taskNodeList.isEmpty()) {
for (TaskDefinition taskNode : taskNodeList) {
String parameter = taskNode.getTaskParams();
ObjectNode parameterJson = JSONUtils.parseObject(parameter);
if (parameterJson.get(CMD_PARAM_SUB_PROCESS_DEFINE_ID) != null) {
SubProcessParameters subProcessParam = JSONUtils.parseObject(parameter, SubProcessParameters.class);
ids.add(subProcessParam.getProcessDefinitionId());
recurseFindSubProcessId(subProcessParam.getProcessDefinitionId(), ids);
}
}
}
}
/**
* create recovery waiting thread command when thread pool is not enough for the process instance.
* sub work process instance need not to create recovery command.
* create recovery waiting thread command and delete origin command at the same time.
* if the recovery command is exists, only update the field update_time
*
* @param originCommand originCommand
* @param processInstance processInstance
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public void createRecoveryWaitingThreadCommand(Command originCommand, ProcessInstance processInstance) {
if (processInstance.getIsSubProcess() == Flag.YES) {
if (originCommand != null) {
commandMapper.deleteById(originCommand.getId());
}
return;
}
Map<String, String> cmdParam = new HashMap<>();
cmdParam.put(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD, String.valueOf(processInstance.getId()));
if (originCommand == null) {
Command command = new Command(
CommandType.RECOVER_WAITING_THREAD,
processInstance.getTaskDependType(),
processInstance.getFailureStrategy(),
processInstance.getExecutorId(),
processInstance.getProcessDefinition().getCode(),
JSONUtils.toJsonString(cmdParam),
processInstance.getWarningType(),
processInstance.getWarningGroupId(),
processInstance.getScheduleTime(),
processInstance.getWorkerGroup(),
processInstance.getEnvironmentCode(),
processInstance.getProcessInstancePriority()
);
saveCommand(command);
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (originCommand.getCommandType() == CommandType.RECOVER_WAITING_THREAD) {
originCommand.setUpdateTime(new Date());
saveCommand(originCommand);
} else {
commandMapper.deleteById(originCommand.getId());
originCommand.setId(0);
originCommand.setCommandType(CommandType.RECOVER_WAITING_THREAD);
originCommand.setUpdateTime(new Date());
originCommand.setCommandParam(JSONUtils.toJsonString(cmdParam));
originCommand.setProcessInstancePriority(processInstance.getProcessInstancePriority());
saveCommand(originCommand);
}
}
/**
* get schedule time from command
*
* @param command command
* @param cmdParam cmdParam map
* @return date
*/
private Date getScheduleTime(Command command, Map<String, String> cmdParam) {
Date scheduleTime = command.getScheduleTime();
if (scheduleTime == null && cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {
scheduleTime = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
}
return scheduleTime;
}
/**
* generate a new work process instance from command. |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | *
* @param processDefinition processDefinition
* @param command command
* @param cmdParam cmdParam map
* @return process instance
*/
private ProcessInstance generateNewProcessInstance(ProcessDefinition processDefinition,
Command command,
Map<String, String> cmdParam) {
ProcessInstance processInstance = new ProcessInstance(processDefinition);
processInstance.setProcessDefinitionCode(processDefinition.getCode());
processInstance.setProcessDefinitionVersion(processDefinition.getVersion());
processInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
processInstance.setRecovery(Flag.NO);
processInstance.setStartTime(new Date());
processInstance.setRunTimes(1);
processInstance.setMaxTryTimes(0);
processInstance.setCommandParam(command.getCommandParam());
processInstance.setCommandType(command.getCommandType());
processInstance.setIsSubProcess(Flag.NO);
processInstance.setTaskDependType(command.getTaskDependType());
processInstance.setFailureStrategy(command.getFailureStrategy());
processInstance.setExecutorId(command.getExecutorId());
WarningType warningType = command.getWarningType() == null ? WarningType.NONE : command.getWarningType();
processInstance.setWarningType(warningType);
Integer warningGroupId = command.getWarningGroupId() == null ? 0 : command.getWarningGroupId();
processInstance.setWarningGroupId(warningGroupId);
Date scheduleTime = getScheduleTime(command, cmdParam); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (scheduleTime != null) {
processInstance.setScheduleTime(scheduleTime);
}
processInstance.setCommandStartTime(command.getStartTime());
processInstance.setLocations(processDefinition.getLocations());
setGlobalParamIfCommanded(processDefinition, cmdParam);
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
getCommandTypeIfComplement(processInstance, command),
processInstance.getScheduleTime()));
processInstance.setProcessInstancePriority(command.getProcessInstancePriority());
String workerGroup = StringUtils.isBlank(command.getWorkerGroup()) ? Constants.DEFAULT_WORKER_GROUP : command.getWorkerGroup();
processInstance.setWorkerGroup(workerGroup);
processInstance.setEnvironmentCode(Objects.isNull(command.getEnvironmentCode()) ? -1 : command.getEnvironmentCode());
processInstance.setTimeout(processDefinition.getTimeout());
processInstance.setTenantId(processDefinition.getTenantId());
return processInstance;
}
private void setGlobalParamIfCommanded(ProcessDefinition processDefinition, Map<String, String> cmdParam) {
Map<String, String> startParamMap = new HashMap<>();
if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_START_PARAMS)) {
String startParamJson = cmdParam.get(Constants.CMD_PARAM_START_PARAMS);
startParamMap = JSONUtils.toMap(startParamJson);
}
Map<String, String> fatherParamMap = new HashMap<>(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_FATHER_PARAMS)) {
String fatherParamJson = cmdParam.get(Constants.CMD_PARAM_FATHER_PARAMS);
fatherParamMap = JSONUtils.toMap(fatherParamJson);
}
startParamMap.putAll(fatherParamMap);
if (startParamMap.size() > 0
&& processDefinition.getGlobalParamMap() != null) {
for (Map.Entry<String, String> param : processDefinition.getGlobalParamMap().entrySet()) {
String val = startParamMap.get(param.getKey());
if (val != null) {
param.setValue(val);
}
}
}
}
/**
* get process tenant
* there is tenant id in definition, use the tenant of the definition.
* if there is not tenant id in the definiton or the tenant not exist
* use definition creator's tenant.
*
* @param tenantId tenantId
* @param userId userId
* @return tenant
*/
public Tenant getTenantForProcess(int tenantId, int userId) {
Tenant tenant = null;
if (tenantId >= 0) {
tenant = tenantMapper.queryById(tenantId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
if (userId == 0) {
return null;
}
if (tenant == null) {
User user = userMapper.selectById(userId);
tenant = tenantMapper.queryById(user.getTenantId());
}
return tenant;
}
/**
* get an environment
* use the code of the environment to find a environment.
*
* @param environmentCode environmentCode
* @return Environment
*/
public Environment findEnvironmentByCode(Long environmentCode) {
Environment environment = null;
if (environmentCode >= 0) {
environment = environmentMapper.queryByEnvironmentCode(environmentCode);
}
return environment;
}
/**
* check command parameters is valid
*
* @param command command
* @param cmdParam cmdParam map
* @return whether command param is valid |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
private Boolean checkCmdParam(Command command, Map<String, String> cmdParam) {
if (command.getTaskDependType() == TaskDependType.TASK_ONLY || command.getTaskDependType() == TaskDependType.TASK_PRE) {
if (cmdParam == null
|| !cmdParam.containsKey(Constants.CMD_PARAM_START_NODE_NAMES)
|| cmdParam.get(Constants.CMD_PARAM_START_NODE_NAMES).isEmpty()) {
logger.error("command node depend type is {}, but start nodes is null ", command.getTaskDependType());
return false;
}
}
return true;
}
/**
* construct process instance according to one command.
*
* @param command command
* @param host host
* @return process instance
*/
private ProcessInstance constructProcessInstance(Command command, String host) {
ProcessInstance processInstance;
CommandType commandType = command.getCommandType();
Map<String, String> cmdParam = JSONUtils.toMap(command.getCommandParam());
ProcessDefinition processDefinition = getProcessDefinitionByCommand(command.getProcessDefinitionCode(), cmdParam);
if (processDefinition == null) {
logger.error("cannot find the work process define! define code : {}", command.getProcessDefinitionCode());
return null;
}
if (cmdParam != null) {
int processInstanceId = 0; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)) {
String processId = cmdParam.get(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING);
processInstanceId = Integer.parseInt(processId);
if (processInstanceId == 0) {
logger.error("command parameter is error, [ ProcessInstanceId ] is 0");
return null;
}
} else if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
String pId = cmdParam.get(Constants.CMD_PARAM_SUB_PROCESS);
processInstanceId = Integer.parseInt(pId);
} else if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)) {
String pId = cmdParam.get(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD);
processInstanceId = Integer.parseInt(pId);
}
if (processInstanceId == 0) {
processInstance = generateNewProcessInstance(processDefinition, command, cmdParam);
} else {
processInstance = this.findProcessInstanceDetailById(processInstanceId);
if (processInstance == null) {
return processInstance;
}
CommandType commandTypeIfComplement = getCommandTypeIfComplement(processInstance, command);
if (commandTypeIfComplement == CommandType.REPEAT_RUNNING) {
setGlobalParamIfCommanded(processDefinition, cmdParam);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
commandTypeIfComplement,
processInstance.getScheduleTime()));
processInstance.setProcessDefinition(processDefinition);
}
if (processInstance.getCommandParam() != null) {
Map<String, String> processCmdParam = JSONUtils.toMap(processInstance.getCommandParam());
for (Map.Entry<String, String> entry : processCmdParam.entrySet()) {
if (!cmdParam.containsKey(entry.getKey())) {
cmdParam.put(entry.getKey(), entry.getValue());
}
}
}
if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
processInstance.setCommandParam(command.getCommandParam());
}
} else {
processInstance = generateNewProcessInstance(processDefinition, command, cmdParam);
}
if (Boolean.FALSE.equals(checkCmdParam(command, cmdParam))) {
logger.error("command parameter check failed!");
return null;
}
if (command.getScheduleTime() != null) {
processInstance.setScheduleTime(command.getScheduleTime()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
processInstance.setHost(host);
ExecutionStatus runStatus = ExecutionStatus.RUNNING_EXECUTION;
int runTime = processInstance.getRunTimes();
switch (commandType) {
case START_PROCESS:
break;
case START_FAILURE_TASK_PROCESS:
List<Integer> failedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.FAILURE);
List<Integer> toleranceList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.NEED_FAULT_TOLERANCE);
List<Integer> killedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.KILL);
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
failedList.addAll(killedList);
failedList.addAll(toleranceList);
for (Integer taskId : failedList) {
initTaskInstance(this.findTaskInstanceById(taskId));
}
cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING,
String.join(Constants.COMMA, convertIntListToString(failedList)));
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
processInstance.setRunTimes(runTime + 1);
break;
case START_CURRENT_TASK_PROCESS:
break;
case RECOVER_WAITING_THREAD:
break;
case RECOVER_SUSPENDED_PROCESS:
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | List<Integer> suspendedNodeList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.PAUSE);
List<Integer> stopNodeList = findTaskIdByInstanceState(processInstance.getId(),
ExecutionStatus.KILL);
suspendedNodeList.addAll(stopNodeList);
for (Integer taskId : suspendedNodeList) {
initTaskInstance(this.findTaskInstanceById(taskId));
}
cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING, String.join(",", convertIntListToString(suspendedNodeList)));
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
processInstance.setRunTimes(runTime + 1);
break;
case RECOVER_TOLERANCE_FAULT_PROCESS:
processInstance.setRecovery(Flag.YES);
runStatus = processInstance.getState();
break;
case COMPLEMENT_DATA:
List<TaskInstance> taskInstanceList = this.findValidTaskListByProcessId(processInstance.getId());
for (TaskInstance taskInstance : taskInstanceList) {
taskInstance.setFlag(Flag.NO);
this.updateTaskInstance(taskInstance);
}
initComplementDataParam(processDefinition, processInstance, cmdParam);
break;
case REPEAT_RUNNING:
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING)) {
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
}
List<TaskInstance> validTaskList = findValidTaskListByProcessId(processInstance.getId());
for (TaskInstance taskInstance : validTaskList) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
}
processInstance.setStartTime(new Date());
processInstance.setEndTime(null);
processInstance.setRunTimes(runTime + 1);
initComplementDataParam(processDefinition, processInstance, cmdParam);
break;
case SCHEDULER:
break;
default:
break;
}
processInstance.setState(runStatus);
return processInstance;
}
/**
* get process definition by command
* If it is a fault-tolerant command, get the specified version of ProcessDefinition through ProcessInstance
* Otherwise, get the latest version of ProcessDefinition
*
* @return ProcessDefinition
*/
private ProcessDefinition getProcessDefinitionByCommand(long processDefinitionCode, Map<String, String> cmdParam) {
if (cmdParam != null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | int processInstanceId = 0;
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)) {
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING));
} else if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_SUB_PROCESS));
} else if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)) {
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD));
}
if (processInstanceId != 0) {
ProcessInstance processInstance = this.findProcessInstanceDetailById(processInstanceId);
if (processInstance == null) {
return null;
}
return processDefineLogMapper.queryByDefinitionCodeAndVersion(
processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
}
}
return processDefineMapper.queryByCode(processDefinitionCode);
}
/**
* return complement data if the process start with complement data
*
* @param processInstance processInstance
* @param command command
* @return command type
*/
private CommandType getCommandTypeIfComplement(ProcessInstance processInstance, Command command) {
if (CommandType.COMPLEMENT_DATA == processInstance.getCmdTypeIfComplement()) {
return CommandType.COMPLEMENT_DATA;
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return command.getCommandType();
}
}
/**
* initialize complement data parameters
*
* @param processDefinition processDefinition
* @param processInstance processInstance
* @param cmdParam cmdParam
*/
private void initComplementDataParam(ProcessDefinition processDefinition,
ProcessInstance processInstance,
Map<String, String> cmdParam) {
if (!processInstance.isComplementData()) {
return;
}
Date startComplementTime = DateUtils.parse(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE),
YYYY_MM_DD_HH_MM_SS);
if (Flag.NO == processInstance.getIsSubProcess()) {
processInstance.setScheduleTime(startComplementTime);
}
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
CommandType.COMPLEMENT_DATA, processInstance.getScheduleTime()));
}
/**
* set sub work process parameters.
* handle sub work process instance, update relation table and command parameters
* set sub work process flag, extends parent work process command parameters |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | *
* @param subProcessInstance subProcessInstance
*/
public void setSubProcessParam(ProcessInstance subProcessInstance) {
String cmdParam = subProcessInstance.getCommandParam();
if (StringUtils.isEmpty(cmdParam)) {
return;
}
Map<String, String> paramMap = JSONUtils.toMap(cmdParam);
if (paramMap.containsKey(CMD_PARAM_SUB_PROCESS)
&& CMD_PARAM_EMPTY_SUB_PROCESS.equals(paramMap.get(CMD_PARAM_SUB_PROCESS))) {
paramMap.remove(CMD_PARAM_SUB_PROCESS);
paramMap.put(CMD_PARAM_SUB_PROCESS, String.valueOf(subProcessInstance.getId()));
subProcessInstance.setCommandParam(JSONUtils.toJsonString(paramMap));
subProcessInstance.setIsSubProcess(Flag.YES);
this.saveProcessInstance(subProcessInstance);
}
String parentInstanceId = paramMap.get(CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID);
if (StringUtils.isNotEmpty(parentInstanceId)) {
ProcessInstance parentInstance = findProcessInstanceDetailById(Integer.parseInt(parentInstanceId));
if (parentInstance != null) {
subProcessInstance.setGlobalParams(
joinGlobalParams(parentInstance.getGlobalParams(), subProcessInstance.getGlobalParams()));
this.saveProcessInstance(subProcessInstance);
} else {
logger.error("sub process command params error, cannot find parent instance: {} ", cmdParam);
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessInstanceMap processInstanceMap = JSONUtils.parseObject(cmdParam, ProcessInstanceMap.class);
if (processInstanceMap == null || processInstanceMap.getParentProcessInstanceId() == 0) {
return;
}
processInstanceMap.setProcessInstanceId(subProcessInstance.getId());
this.updateWorkProcessInstanceMap(processInstanceMap);
}
/**
* join parent global params into sub process.
* only the keys doesn't in sub process global would be joined.
*
* @param parentGlobalParams parentGlobalParams
* @param subGlobalParams subGlobalParams
* @return global params join
*/
private String joinGlobalParams(String parentGlobalParams, String subGlobalParams) {
List<Property> parentPropertyList = JSONUtils.toList(parentGlobalParams, Property.class);
List<Property> subPropertyList = JSONUtils.toList(subGlobalParams, Property.class);
Map<String, String> subMap = subPropertyList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue));
for (Property parent : parentPropertyList) {
if (!subMap.containsKey(parent.getProp())) {
subPropertyList.add(parent);
}
}
return JSONUtils.toJsonString(subPropertyList);
}
/**
* initialize task instance
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param taskInstance taskInstance
*/
private void initTaskInstance(TaskInstance taskInstance) {
if (!taskInstance.isSubProcess()
&& (taskInstance.getState().typeIsCancel() || taskInstance.getState().typeIsFailure())) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
return;
}
taskInstance.setState(ExecutionStatus.SUBMITTED_SUCCESS);
updateTaskInstance(taskInstance);
}
/**
* retry submit task to db
*
* @param taskInstance
* @param commitRetryTimes
* @param commitInterval
* @return
*/
public TaskInstance submitTask(TaskInstance taskInstance, int commitRetryTimes, int commitInterval) {
int retryTimes = 1;
boolean submitDB = false;
TaskInstance task = null;
while (retryTimes <= commitRetryTimes) {
try {
if (!submitDB) {
task = submitTask(taskInstance);
if (task != null && task.getId() != 0) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | submitDB = true;
break;
}
}
if (!submitDB) {
logger.error("task commit to db failed , taskId {} has already retry {} times, please check the database", taskInstance.getId(), retryTimes);
}
Thread.sleep(commitInterval);
} catch (Exception e) {
logger.error("task commit to mysql failed", e);
}
retryTimes += 1;
}
return task;
}
/**
* submit task to db
* submit sub process to command
*
* @param taskInstance taskInstance
* @return task instance
*/
@Transactional(rollbackFor = Exception.class)
public TaskInstance submitTask(TaskInstance taskInstance) {
ProcessInstance processInstance = this.findProcessInstanceDetailById(taskInstance.getProcessInstanceId());
logger.info("start submit task : {}, instance id:{}, state: {}",
taskInstance.getName(), taskInstance.getProcessInstanceId(), processInstance.getState());
TaskInstance task = submitTaskInstanceToDB(taskInstance, processInstance);
if (task == null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | logger.error("end submit task to db error, task name:{}, process id:{} state: {} ",
taskInstance.getName(), taskInstance.getProcessInstance(), processInstance.getState());
return task;
}
if (!task.getState().typeIsFinished()) {
createSubWorkProcess(processInstance, task);
}
logger.info("end submit task to db successfully:{} {} state:{} complete, instance id:{} state: {} ",
taskInstance.getId(), taskInstance.getName(), task.getState(), processInstance.getId(), processInstance.getState());
return task;
}
/**
* set work process instance map
* consider o
* repeat running does not generate new sub process instance
* set map {parent instance id, task instance id, 0(child instance id)}
*
* @param parentInstance parentInstance
* @param parentTask parentTask
* @return process instance map
*/
private ProcessInstanceMap setProcessInstanceMap(ProcessInstance parentInstance, TaskInstance parentTask) {
ProcessInstanceMap processMap = findWorkProcessMapByParent(parentInstance.getId(), parentTask.getId());
if (processMap != null) {
return processMap;
}
if (parentInstance.getCommandType() == CommandType.REPEAT_RUNNING) {
processMap = findPreviousTaskProcessMap(parentInstance, parentTask);
if (processMap != null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processMap.setParentTaskInstanceId(parentTask.getId());
updateWorkProcessInstanceMap(processMap);
return processMap;
}
}
processMap = new ProcessInstanceMap();
processMap.setParentProcessInstanceId(parentInstance.getId());
processMap.setParentTaskInstanceId(parentTask.getId());
createWorkProcessInstanceMap(processMap);
return processMap;
}
/**
* find previous task work process map.
*
* @param parentProcessInstance parentProcessInstance
* @param parentTask parentTask
* @return process instance map
*/
private ProcessInstanceMap findPreviousTaskProcessMap(ProcessInstance parentProcessInstance,
TaskInstance parentTask) {
Integer preTaskId = 0;
List<TaskInstance> preTaskList = this.findPreviousTaskListByWorkProcessId(parentProcessInstance.getId());
for (TaskInstance task : preTaskList) {
if (task.getName().equals(parentTask.getName())) {
preTaskId = task.getId();
ProcessInstanceMap map = findWorkProcessMapByParent(parentProcessInstance.getId(), preTaskId);
if (map != null) {
return map;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
}
logger.info("sub process instance is not found,parent task:{},parent instance:{}",
parentTask.getId(), parentProcessInstance.getId());
return null;
}
/**
* create sub work process command
*
* @param parentProcessInstance parentProcessInstance
* @param task task
*/
public void createSubWorkProcess(ProcessInstance parentProcessInstance, TaskInstance task) {
if (!task.isSubProcess()) {
return;
}
ProcessInstanceMap instanceMap = findWorkProcessMapByParent(parentProcessInstance.getId(), task.getId());
if (null != instanceMap && CommandType.RECOVER_TOLERANCE_FAULT_PROCESS == parentProcessInstance.getCommandType()) {
return;
}
instanceMap = setProcessInstanceMap(parentProcessInstance, task);
ProcessInstance childInstance = null;
if (instanceMap.getProcessInstanceId() != 0) {
childInstance = findProcessInstanceById(instanceMap.getProcessInstanceId());
}
Command subProcessCommand = createSubProcessCommand(parentProcessInstance, childInstance, instanceMap, task);
updateSubProcessDefinitionByParent(parentProcessInstance, subProcessCommand.getProcessDefinitionCode());
initSubInstanceState(childInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | createCommand(subProcessCommand);
logger.info("sub process command created: {} ", subProcessCommand);
}
/**
* complement data needs transform parent parameter to child.
*/
private String getSubWorkFlowParam(ProcessInstanceMap instanceMap, ProcessInstance parentProcessInstance, Map<String, String> fatherParams) {
String processMapStr = JSONUtils.toJsonString(instanceMap);
Map<String, String> cmdParam = JSONUtils.toMap(processMapStr);
if (parentProcessInstance.isComplementData()) {
Map<String, String> parentParam = JSONUtils.toMap(parentProcessInstance.getCommandParam());
String endTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE);
String startTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, endTime);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_START_DATE, startTime);
processMapStr = JSONUtils.toJsonString(cmdParam);
}
if (fatherParams.size() != 0) {
cmdParam.put(CMD_PARAM_FATHER_PARAMS, JSONUtils.toJsonString(fatherParams));
processMapStr = JSONUtils.toJsonString(cmdParam);
}
return processMapStr;
}
public Map<String, String> getGlobalParamMap(String globalParams) {
List<Property> propList;
Map<String, String> globalParamMap = new HashMap<>();
if (StringUtils.isNotEmpty(globalParams)) {
propList = JSONUtils.toList(globalParams, Property.class);
globalParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue)); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
return globalParamMap;
}
/**
* create sub work process command
*/
public Command createSubProcessCommand(ProcessInstance parentProcessInstance,
ProcessInstance childInstance,
ProcessInstanceMap instanceMap,
TaskInstance task) {
CommandType commandType = getSubCommandType(parentProcessInstance, childInstance);
Map<String, String> subProcessParam = JSONUtils.toMap(task.getTaskParams());
int childDefineId = Integer.parseInt(subProcessParam.get(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID));
ProcessDefinition processDefinition = processDefineMapper.queryByDefineId(childDefineId);
Object localParams = subProcessParam.get(Constants.LOCAL_PARAMS);
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> globalMap = this.getGlobalParamMap(parentProcessInstance.getGlobalParams());
Map<String, String> fatherParams = new HashMap<>();
if (CollectionUtils.isNotEmpty(allParam)) {
for (Property info : allParam) {
fatherParams.put(info.getProp(), globalMap.get(info.getProp()));
}
}
String processParam = getSubWorkFlowParam(instanceMap, parentProcessInstance, fatherParams);
return new Command(
commandType,
TaskDependType.TASK_POST,
parentProcessInstance.getFailureStrategy(),
parentProcessInstance.getExecutorId(),
processDefinition.getCode(), |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processParam,
parentProcessInstance.getWarningType(),
parentProcessInstance.getWarningGroupId(),
parentProcessInstance.getScheduleTime(),
task.getWorkerGroup(),
task.getEnvironmentCode(),
parentProcessInstance.getProcessInstancePriority()
);
}
/**
* initialize sub work flow state
* child instance state would be initialized when 'recovery from pause/stop/failure'
*/
private void initSubInstanceState(ProcessInstance childInstance) {
if (childInstance != null) {
childInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
updateProcessInstance(childInstance);
}
}
/**
* get sub work flow command type
* child instance exist: child command = fatherCommand
* child instance not exists: child command = fatherCommand[0]
*/
private CommandType getSubCommandType(ProcessInstance parentProcessInstance, ProcessInstance childInstance) {
CommandType commandType = parentProcessInstance.getCommandType();
if (childInstance == null) {
String fatherHistoryCommand = parentProcessInstance.getHistoryCmd();
commandType = CommandType.valueOf(fatherHistoryCommand.split(Constants.COMMA)[0]);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return commandType;
}
/**
* update sub process definition
*
* @param parentProcessInstance parentProcessInstance
* @param childDefinitionCode childDefinitionId
*/
private void updateSubProcessDefinitionByParent(ProcessInstance parentProcessInstance, long childDefinitionCode) {
ProcessDefinition fatherDefinition = this.findProcessDefinition(parentProcessInstance.getProcessDefinitionCode(),
parentProcessInstance.getProcessDefinitionVersion());
ProcessDefinition childDefinition = this.findProcessDefinitionByCode(childDefinitionCode);
if (childDefinition != null && fatherDefinition != null) {
childDefinition.setWarningGroupId(fatherDefinition.getWarningGroupId());
processDefineMapper.updateById(childDefinition);
}
}
/**
* submit task to mysql
*
* @param taskInstance taskInstance
* @param processInstance processInstance
* @return task instance
*/
public TaskInstance submitTaskInstanceToDB(TaskInstance taskInstance, ProcessInstance processInstance) {
ExecutionStatus processInstanceState = processInstance.getState();
if (taskInstance.getState().typeIsFailure()) {
if (taskInstance.isSubProcess()) {
taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (processInstanceState != ExecutionStatus.READY_STOP
&& processInstanceState != ExecutionStatus.READY_PAUSE) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
if (taskInstance.getState() != ExecutionStatus.NEED_FAULT_TOLERANCE) {
taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
}
taskInstance.setSubmitTime(null);
taskInstance.setStartTime(null);
taskInstance.setEndTime(null);
taskInstance.setFlag(Flag.YES);
taskInstance.setHost(null);
taskInstance.setId(0);
}
}
}
taskInstance.setExecutorId(processInstance.getExecutorId());
taskInstance.setProcessInstancePriority(processInstance.getProcessInstancePriority());
taskInstance.setState(getSubmitTaskState(taskInstance, processInstanceState));
if (taskInstance.getSubmitTime() == null) {
taskInstance.setSubmitTime(new Date());
}
if (taskInstance.getFirstSubmitTime() == null) {
taskInstance.setFirstSubmitTime(taskInstance.getSubmitTime());
}
boolean saveResult = saveTaskInstance(taskInstance);
if (!saveResult) {
return null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
return taskInstance;
}
/**
* get submit task instance state by the work process state
* cannot modify the task state when running/kill/submit success, or this
* task instance is already exists in task queue .
* return pause if work process state is ready pause
* return stop if work process state is ready stop
* if all of above are not satisfied, return submit success
*
* @param taskInstance taskInstance
* @param processInstanceState processInstanceState
* @return process instance state
*/
public ExecutionStatus getSubmitTaskState(TaskInstance taskInstance, ExecutionStatus processInstanceState) {
ExecutionStatus state = taskInstance.getState();
if (
state == ExecutionStatus.RUNNING_EXECUTION
|| state == ExecutionStatus.DELAY_EXECUTION
|| state == ExecutionStatus.KILL
) {
return state;
}
if (processInstanceState == ExecutionStatus.READY_PAUSE) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | state = ExecutionStatus.PAUSE;
} else if (processInstanceState == ExecutionStatus.READY_STOP
|| !checkProcessStrategy(taskInstance)) {
state = ExecutionStatus.KILL;
} else {
state = ExecutionStatus.SUBMITTED_SUCCESS;
}
return state;
}
/**
* check process instance strategy
*
* @param taskInstance taskInstance
* @return check strategy result
*/
private boolean checkProcessStrategy(TaskInstance taskInstance) {
ProcessInstance processInstance = this.findProcessInstanceById(taskInstance.getProcessInstanceId());
FailureStrategy failureStrategy = processInstance.getFailureStrategy();
if (failureStrategy == FailureStrategy.CONTINUE) {
return true;
}
List<TaskInstance> taskInstances = this.findValidTaskListByProcessId(taskInstance.getProcessInstanceId());
for (TaskInstance task : taskInstances) {
if (task.getState() == ExecutionStatus.FAILURE
&& task.getRetryTimes() >= task.getMaxRetryTimes()) {
return false;
}
}
return true;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* insert or update work process instance to data base
*
* @param processInstance processInstance
*/
public void saveProcessInstance(ProcessInstance processInstance) {
if (processInstance == null) {
logger.error("save error, process instance is null!");
return;
}
if (processInstance.getId() != 0) {
processInstanceMapper.updateById(processInstance);
} else {
processInstanceMapper.insert(processInstance);
}
}
/**
* insert or update command
*
* @param command command
* @return save command result
*/
public int saveCommand(Command command) {
if (command.getId() != 0) {
return commandMapper.updateById(command);
} else {
return commandMapper.insert(command);
}
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * insert or update task instance
*
* @param taskInstance taskInstance
* @return save task instance result
*/
public boolean saveTaskInstance(TaskInstance taskInstance) {
if (taskInstance.getId() != 0) {
return updateTaskInstance(taskInstance);
} else {
return createTaskInstance(taskInstance);
}
}
/**
* insert task instance
*
* @param taskInstance taskInstance
* @return create task instance result
*/
public boolean createTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.insert(taskInstance);
return count > 0;
}
/**
* update task instance
*
* @param taskInstance taskInstance
* @return update task instance result
*/
public boolean updateTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.updateById(taskInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return count > 0;
}
/**
* find task instance by id
*
* @param taskId task id
* @return task intance
*/
public TaskInstance findTaskInstanceById(Integer taskId) {
return taskInstanceMapper.selectById(taskId);
}
/**
* package task instance，associate processInstance and processDefine
*
* @param taskInstId taskInstId
* @return task instance
*/
public TaskInstance getTaskInstanceDetailByTaskId(int taskInstId) {
//
TaskInstance taskInstance = findTaskInstanceById(taskInstId);
if (taskInstance == null) {
return null;
}
//
ProcessInstance processInstance = findProcessInstanceDetailById(taskInstance.getProcessInstanceId());
//
ProcessDefinition processDefine = findProcessDefinition(processInstance.getProcessDefinitionCode(),
processInstance.getProcessDefinitionVersion());
taskInstance.setProcessInstance(processInstance);
taskInstance.setProcessDefine(processDefine); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | TaskDefinition taskDefinition = taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(
taskInstance.getTaskCode(),
taskInstance.getTaskDefinitionVersion());
updateTaskDefinitionResources(taskDefinition);
taskInstance.setTaskDefine(taskDefinition);
return taskInstance;
}
/**
* Update {@link ResourceInfo} information in {@link TaskDefinition}
*
* @param taskDefinition the given {@link TaskDefinition}
*/
private void updateTaskDefinitionResources(TaskDefinition taskDefinition) {
Map<String, Object> taskParameters = JSONUtils.parseObject(
taskDefinition.getTaskParams(),
new TypeReference<Map<String, Object>>() { });
if (taskParameters != null) {
//
//
if (taskParameters.containsKey("mainJar")) {
Object mainJarObj = taskParameters.get("mainJar");
ResourceInfo mainJar = JSONUtils.parseObject(
JSONUtils.toJsonString(mainJarObj),
ResourceInfo.class);
ResourceInfo resourceInfo = updateResourceInfo(mainJar);
if (resourceInfo != null) {
taskParameters.put("mainJar", resourceInfo);
}
}
// |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (taskParameters.containsKey("resourceList")) {
String resourceListStr = JSONUtils.toJsonString(taskParameters.get("resourceList"));
List<ResourceInfo> resourceInfos = JSONUtils.toList(resourceListStr, ResourceInfo.class);
List<ResourceInfo> updatedResourceInfos = resourceInfos
.stream()
.map(this::updateResourceInfo)
.filter(Objects::nonNull)
.collect(Collectors.toList());
taskParameters.put("resourceList", updatedResourceInfos);
}
//
taskDefinition.setTaskParams(JSONUtils.toJsonString(taskParameters));
}
}
/**
* update {@link ResourceInfo} by given original ResourceInfo
*
* @param res origin resource info
* @return {@link ResourceInfo}
*/
private ResourceInfo updateResourceInfo(ResourceInfo res) {
ResourceInfo resourceInfo = null;
//
if (res != null) {
int resourceId = res.getId();
if (resourceId <= 0) {
logger.error("invalid resourceId, {}", resourceId);
return null;
}
resourceInfo = new ResourceInfo(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | //
Resource resource = getResourceById(resourceId);
resourceInfo.setId(resourceId);
resourceInfo.setRes(resource.getFileName());
resourceInfo.setResourceName(resource.getFullName());
if (logger.isInfoEnabled()) {
logger.info("updated resource info {}",
JSONUtils.toJsonString(resourceInfo));
}
}
return resourceInfo;
}
/**
* get id list by task state
*
* @param instanceId instanceId
* @param state state
* @return task instance states
*/
public List<Integer> findTaskIdByInstanceState(int instanceId, ExecutionStatus state) {
return taskInstanceMapper.queryTaskByProcessIdAndState(instanceId, state.ordinal());
}
/**
* find valid task list by process definition id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
public List<TaskInstance> findValidTaskListByProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.YES); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* find previous task list by work process id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
public List<TaskInstance> findPreviousTaskListByWorkProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.NO);
}
/**
* update work process instance map
*
* @param processInstanceMap processInstanceMap
* @return update process instance result
*/
public int updateWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
return processInstanceMapMapper.updateById(processInstanceMap);
}
/**
* create work process instance map
*
* @param processInstanceMap processInstanceMap
* @return create process instance result
*/
public int createWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
int count = 0;
if (processInstanceMap != null) {
return processInstanceMapMapper.insert(processInstanceMap);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return count;
}
/**
* find work process map by parent process id and parent task id.
*
* @param parentWorkProcessId parentWorkProcessId
* @param parentTaskId parentTaskId
* @return process instance map
*/
public ProcessInstanceMap findWorkProcessMapByParent(Integer parentWorkProcessId, Integer parentTaskId) {
return processInstanceMapMapper.queryByParentId(parentWorkProcessId, parentTaskId);
}
/**
* delete work process map by parent process id
*
* @param parentWorkProcessId parentWorkProcessId
* @return delete process map result
*/
public int deleteWorkProcessMapByParentId(int parentWorkProcessId) {
return processInstanceMapMapper.deleteByParentProcessId(parentWorkProcessId);
}
/**
* find sub process instance
*
* @param parentProcessId parentProcessId
* @param parentTaskId parentTaskId
* @return process instance
*/
public ProcessInstance findSubProcessInstance(Integer parentProcessId, Integer parentTaskId) {
ProcessInstance processInstance = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryByParentId(parentProcessId, parentTaskId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getProcessInstanceId());
return processInstance;
}
/**
* find parent process instance
*
* @param subProcessId subProcessId
* @return process instance
*/
public ProcessInstance findParentProcessInstance(Integer subProcessId) {
ProcessInstance processInstance = null;
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(subProcessId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
return processInstance;
}
/**
* change task state
*
* @param state state
* @param startTime startTime
* @param host host
* @param executePath executePath
* @param logPath logPath |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param taskInstId taskInstId
*/
public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state, Date startTime, String host,
String executePath,
String logPath,
int taskInstId) {
taskInstance.setState(state);
taskInstance.setStartTime(startTime);
taskInstance.setHost(host);
taskInstance.setExecutePath(executePath);
taskInstance.setLogPath(logPath);
saveTaskInstance(taskInstance);
}
/**
* update process instance
*
* @param processInstance processInstance
* @return update process instance result
*/
public int updateProcessInstance(ProcessInstance processInstance) {
return processInstanceMapper.updateById(processInstance);
}
/**
* change task state
*
* @param state state
* @param endTime endTime
* @param taskInstId taskInstId
* @param varPool varPool
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state,
Date endTime,
int processId,
String appIds,
int taskInstId,
String varPool) {
taskInstance.setPid(processId);
taskInstance.setAppLink(appIds);
taskInstance.setState(state);
taskInstance.setEndTime(endTime);
taskInstance.setVarPool(varPool);
changeOutParam(taskInstance);
saveTaskInstance(taskInstance);
}
/**
* for show in page of taskInstance
*
* @param taskInstance
*/
public void changeOutParam(TaskInstance taskInstance) {
if (StringUtils.isEmpty(taskInstance.getVarPool())) {
return;
}
List<Property> properties = JSONUtils.toList(taskInstance.getVarPool(), Property.class);
if (CollectionUtils.isEmpty(properties)) {
return;
}
//
Map<String, Object> taskParams = JSONUtils.toMap(taskInstance.getTaskParams(), String.class, Object.class);
Object localParams = taskParams.get(LOCAL_PARAMS); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (localParams == null) {
return;
}
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> outProperty = new HashMap<>();
for (Property info : properties) {
if (info.getDirect() == Direct.OUT) {
outProperty.put(info.getProp(), info.getValue());
}
}
for (Property info : allParam) {
if (info.getDirect() == Direct.OUT) {
String paramName = info.getProp();
info.setValue(outProperty.get(paramName));
}
}
taskParams.put(LOCAL_PARAMS, allParam);
taskInstance.setTaskParams(JSONUtils.toJsonString(taskParams));
}
/**
* convert integer list to string list
*
* @param intList intList
* @return string list
*/
public List<String> convertIntListToString(List<Integer> intList) {
if (intList == null) {
return new ArrayList<>();
}
List<String> result = new ArrayList<>(intList.size()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | for (Integer intVar : intList) {
result.add(String.valueOf(intVar));
}
return result;
}
/**
* query schedule by id
*
* @param id id
* @return schedule
*/
public Schedule querySchedule(int id) {
return scheduleMapper.selectById(id);
}
/**
* query Schedule by processDefinitionCode
*
* @param processDefinitionCode processDefinitionCode
* @see Schedule
*/
public List<Schedule> queryReleaseSchedulerListByProcessDefinitionCode(long processDefinitionCode) {
return scheduleMapper.queryReleaseSchedulerListByProcessDefinitionCode(processDefinitionCode);
}
/**
* query need failover process instance
*
* @param host host
* @return process instance list
*/
public List<ProcessInstance> queryNeedFailoverProcessInstances(String host) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return processInstanceMapper.queryByHostAndStatus(host, stateArray);
}
/**
* process need failover process instance
*
* @param processInstance processInstance
*/
@Transactional(rollbackFor = RuntimeException.class)
public void processNeedFailoverProcessInstances(ProcessInstance processInstance) {
//
processInstance.setHost(Constants.NULL);
processInstanceMapper.updateById(processInstance);
ProcessDefinition processDefinition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
//
Command cmd = new Command();
cmd.setProcessDefinitionCode(processDefinition.getCode());
cmd.setCommandParam(String.format("{\"%s\":%d}", Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING, processInstance.getId()));
cmd.setExecutorId(processInstance.getExecutorId());
cmd.setCommandType(CommandType.RECOVER_TOLERANCE_FAULT_PROCESS);
createCommand(cmd);
}
/**
* query all need failover task instances by host
*
* @param host host
* @return task instance list
*/
public List<TaskInstance> queryNeedFailoverTaskInstances(String host) {
return taskInstanceMapper.queryByHostAndStatus(host,
stateArray); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* find data source by id
*
* @param id id
* @return datasource
*/
public DataSource findDataSourceById(int id) {
return dataSourceMapper.selectById(id);
}
/**
* update process instance state by id
*
* @param processInstanceId processInstanceId
* @param executionStatus executionStatus
* @return update process result
*/
public int updateProcessInstanceState(Integer processInstanceId, ExecutionStatus executionStatus) {
ProcessInstance instance = processInstanceMapper.selectById(processInstanceId);
instance.setState(executionStatus);
return processInstanceMapper.updateById(instance);
}
/**
* find process instance by the task id
*
* @param taskId taskId
* @return process instance
*/
public ProcessInstance findProcessInstanceByTaskId(int taskId) {
TaskInstance taskInstance = taskInstanceMapper.selectById(taskId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (taskInstance != null) {
return processInstanceMapper.selectById(taskInstance.getProcessInstanceId());
}
return null;
}
/**
* find udf function list by id list string
*
* @param ids ids
* @return udf function list
*/
public List<UdfFunc> queryUdfFunListByIds(int[] ids) {
return udfFuncMapper.queryUdfByIdStr(ids, null);
}
/**
* find tenant code by resource name
*
* @param resName resource name
* @param resourceType resource type
* @return tenant code
*/
public String queryTenantCodeByResName(String resName, ResourceType resourceType) {
//
String fullName = resName.startsWith("/") ? resName : String.format("/%s", resName);
List<Resource> resourceList = resourceMapper.queryResource(fullName, resourceType.ordinal());
if (CollectionUtils.isEmpty(resourceList)) {
return StringUtils.EMPTY;
}
int userId = resourceList.get(0).getUserId();
User user = userMapper.selectById(userId); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (Objects.isNull(user)) {
return StringUtils.EMPTY;
}
Tenant tenant = tenantMapper.selectById(user.getTenantId());
if (Objects.isNull(tenant)) {
return StringUtils.EMPTY;
}
return tenant.getTenantCode();
}
/**
* find schedule list by process define codes.
*
* @param codes codes
* @return schedule list
*/
public List<Schedule> selectAllByProcessDefineCode(long[] codes) {
return scheduleMapper.selectAllByProcessDefineArray(codes);
}
/**
* find last scheduler process instance in the date interval
*
* @param definitionCode definitionCode
* @param dateInterval dateInterval
* @return process instance
*/
public ProcessInstance findLastSchedulerProcessInterval(Long definitionCode, DateInterval dateInterval) {
return processInstanceMapper.queryLastSchedulerProcess(definitionCode,
dateInterval.getStartTime(),
dateInterval.getEndTime());
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* find last manual process instance interval
*
* @param definitionCode process definition code
* @param dateInterval dateInterval
* @return process instance
*/
public ProcessInstance findLastManualProcessInterval(Long definitionCode, DateInterval dateInterval) {
return processInstanceMapper.queryLastManualProcess(definitionCode,
dateInterval.getStartTime(),
dateInterval.getEndTime());
}
/**
* find last running process instance
*
* @param definitionCode process definition code
* @param startTime start time
* @param endTime end time
* @return process instance
*/
public ProcessInstance findLastRunningProcess(Long definitionCode, Date startTime, Date endTime) {
return processInstanceMapper.queryLastRunningProcess(definitionCode,
startTime,
endTime,
stateArray);
}
/**
* query user queue by process instance id
*
* @param processInstanceId processInstanceId |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @return queue
*/
public String queryUserQueueByProcessInstanceId(int processInstanceId) {
String queue = "";
ProcessInstance processInstance = processInstanceMapper.selectById(processInstanceId);
if (processInstance == null) {
return queue;
}
User executor = userMapper.selectById(processInstance.getExecutorId());
if (executor != null) {
queue = executor.getQueue();
}
return queue;
}
/**
* query project name and user name by processInstanceId.
*
* @param processInstanceId processInstanceId
* @return projectName and userName
*/
public ProjectUser queryProjectWithUserByProcessInstanceId(int processInstanceId) {
return projectMapper.queryProjectWithUserByProcessInstanceId(processInstanceId);
}
/**
* get task worker group
*
* @param taskInstance taskInstance
* @return workerGroupId
*/
public String getTaskWorkerGroup(TaskInstance taskInstance) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | String workerGroup = taskInstance.getWorkerGroup();
if (StringUtils.isNotBlank(workerGroup)) {
return workerGroup;
}
int processInstanceId = taskInstance.getProcessInstanceId();
ProcessInstance processInstance = findProcessInstanceById(processInstanceId);
if (processInstance != null) {
return processInstance.getWorkerGroup();
}
logger.info("task : {} will use default worker group", taskInstance.getId());
return Constants.DEFAULT_WORKER_GROUP;
}
/**
* get have perm project list
*
* @param userId userId
* @return project list
*/
public List<Project> getProjectListHavePerm(int userId) {
List<Project> createProjects = projectMapper.queryProjectCreatedByUser(userId);
List<Project> authedProjects = projectMapper.queryAuthedProjectListByUserId(userId);
if (createProjects == null) {
createProjects = new ArrayList<>();
}
if (authedProjects != null) {
createProjects.addAll(authedProjects);
}
return createProjects;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * list unauthorized udf function
*
* @param userId user id
* @param needChecks data source id array
* @return unauthorized udf function list
*/
public <T> List<T> listUnauthorized(int userId, T[] needChecks, AuthorizationType authorizationType) {
List<T> resultList = new ArrayList<>();
if (Objects.nonNull(needChecks) && needChecks.length > 0) {
Set<T> originResSet = new HashSet<>(Arrays.asList(needChecks));
switch (authorizationType) {
case RESOURCE_FILE_ID:
case UDF_FILE:
List<Resource> ownUdfResources = resourceMapper.listAuthorizedResourceById(userId, needChecks);
addAuthorizedResources(ownUdfResources, userId);
Set<Integer> authorizedResourceFiles = ownUdfResources.stream().map(Resource::getId).collect(toSet());
originResSet.removeAll(authorizedResourceFiles);
break;
case RESOURCE_FILE_NAME:
List<Resource> ownResources = resourceMapper.listAuthorizedResource(userId, needChecks);
addAuthorizedResources(ownResources, userId);
Set<String> authorizedResources = ownResources.stream().map(Resource::getFullName).collect(toSet());
originResSet.removeAll(authorizedResources);
break;
case DATASOURCE:
Set<Integer> authorizedDatasources = dataSourceMapper.listAuthorizedDataSource(userId, needChecks).stream().map(DataSource::getId).collect(toSet());
originResSet.removeAll(authorizedDatasources);
break;
case UDF:
Set<Integer> authorizedUdfs = udfFuncMapper.listAuthorizedUdfFunc(userId, needChecks).stream().map(UdfFunc::getId).collect(toSet()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | originResSet.removeAll(authorizedUdfs);
break;
default:
break;
}
resultList.addAll(originResSet);
}
return resultList;
}
/**
* get user by user id
*
* @param userId user id
* @return User
*/
public User getUserById(int userId) {
return userMapper.selectById(userId);
}
/**
* get resource by resource id
*
* @param resourceId resource id
* @return Resource
*/
public Resource getResourceById(int resourceId) {
return resourceMapper.selectById(resourceId);
}
/**
* list resources by ids
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param resIds resIds
* @return resource list
*/
public List<Resource> listResourceByIds(Integer[] resIds) {
return resourceMapper.listResourceByIds(resIds);
}
/**
* format task app id in task instance
*/
public String formatTaskAppId(TaskInstance taskInstance) {
ProcessInstance processInstance = findProcessInstanceById(taskInstance.getProcessInstanceId());
if (processInstance == null) {
return "";
}
ProcessDefinition definition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion());
if (definition == null) {
return "";
}
return String.format("%s_%s_%s", definition.getId(), processInstance.getId(), taskInstance.getId());
}
/**
* switch process definition version to process definition log version
*/
public int switchVersion(ProcessDefinition processDefinition, ProcessDefinitionLog processDefinitionLog) {
if (null == processDefinition || null == processDefinitionLog) {
return Constants.DEFINITION_FAILURE;
}
processDefinitionLog.setId(processDefinition.getId());
processDefinitionLog.setReleaseState(ReleaseState.OFFLINE);
processDefinitionLog.setFlag(Flag.YES); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | int result = processDefineMapper.updateById(processDefinitionLog);
if (result > 0) {
result = switchProcessTaskRelationVersion(processDefinition);
if (result <= 0) {
return Constants.DEFINITION_FAILURE;
}
}
return result;
}
public int switchProcessTaskRelationVersion(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
if (!processTaskRelationList.isEmpty()) {
processTaskRelationMapper.deleteByCode(processDefinition.getProjectCode(), processDefinition.getCode());
}
List<ProcessTaskRelationLog> processTaskRelationLogList = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion());
return processTaskRelationMapper.batchInsert(processTaskRelationLogList);
}
/**
* get resource ids
*
* @param taskDefinition taskDefinition
* @return resource ids
*/
public String getResourceIds(TaskDefinition taskDefinition) {
Set<Integer> resourceIds = null;
AbstractParameters params = TaskParametersUtils.getParameters(taskDefinition.getTaskType(), taskDefinition.getTaskParams());
if (params != null && CollectionUtils.isNotEmpty(params.getResourceFilesList())) {
resourceIds = params.getResourceFilesList().
stream()
.filter(t -> t.getId() != 0) |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | .map(ResourceInfo::getId)
.collect(Collectors.toSet());
}
if (CollectionUtils.isEmpty(resourceIds)) {
return StringUtils.EMPTY;
}
return StringUtils.join(resourceIds, ",");
}
public int saveTaskDefine(User operator, long projectCode, List<TaskDefinitionLog> taskDefinitionLogs) {
Date now = new Date();
List<TaskDefinitionLog> newTaskDefinitionLogs = new ArrayList<>();
List<TaskDefinitionLog> updateTaskDefinitionLogs = new ArrayList<>();
for (TaskDefinitionLog taskDefinitionLog : taskDefinitionLogs) {
taskDefinitionLog.setProjectCode(projectCode);
taskDefinitionLog.setUpdateTime(now);
taskDefinitionLog.setOperateTime(now);
taskDefinitionLog.setOperator(operator.getId());
taskDefinitionLog.setResourceIds(getResourceIds(taskDefinitionLog));
if (taskDefinitionLog.getCode() > 0 && taskDefinitionLog.getVersion() > 0) {
TaskDefinitionLog definitionCodeAndVersion = taskDefinitionLogMapper
.queryByDefinitionCodeAndVersion(taskDefinitionLog.getCode(), taskDefinitionLog.getVersion());
if (definitionCodeAndVersion != null) {
if (!taskDefinitionLog.equals(definitionCodeAndVersion)) {
taskDefinitionLog.setUserId(definitionCodeAndVersion.getUserId());
Integer version = taskDefinitionLogMapper.queryMaxVersionForDefinition(taskDefinitionLog.getCode());
taskDefinitionLog.setVersion(version + 1);
taskDefinitionLog.setCreateTime(definitionCodeAndVersion.getCreateTime());
updateTaskDefinitionLogs.add(taskDefinitionLog);
}
continue; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
}
taskDefinitionLog.setUserId(operator.getId());
taskDefinitionLog.setVersion(Constants.VERSION_FIRST);
taskDefinitionLog.setCreateTime(now);
if (taskDefinitionLog.getCode() == 0) {
try {
taskDefinitionLog.setCode(SnowFlakeUtils.getInstance().nextId());
} catch (SnowFlakeException e) {
logger.error("Task code get error, ", e);
return Constants.DEFINITION_FAILURE;
}
}
newTaskDefinitionLogs.add(taskDefinitionLog);
}
int insertResult = 0;
int updateResult = 0;
for (TaskDefinitionLog taskDefinitionToUpdate : updateTaskDefinitionLogs) {
TaskDefinition task = taskDefinitionMapper.queryByCode(taskDefinitionToUpdate.getCode());
if (task == null) {
newTaskDefinitionLogs.add(taskDefinitionToUpdate);
} else {
insertResult += taskDefinitionLogMapper.insert(taskDefinitionToUpdate);
taskDefinitionToUpdate.setId(task.getId());
updateResult += taskDefinitionMapper.updateById(taskDefinitionToUpdate);
}
}
if (!newTaskDefinitionLogs.isEmpty()) {
updateResult += taskDefinitionMapper.batchInsert(newTaskDefinitionLogs);
insertResult += taskDefinitionLogMapper.batchInsert(newTaskDefinitionLogs); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
return (insertResult & updateResult) > 0 ? 1 : Constants.EXIT_CODE_SUCCESS;
}
/**
* save processDefinition (including create or update processDefinition)
*/
public int saveProcessDefine(User operator, ProcessDefinition processDefinition, Boolean isFromProcessDefine) {
ProcessDefinitionLog processDefinitionLog = new ProcessDefinitionLog(processDefinition);
Integer version = processDefineLogMapper.queryMaxVersionForDefinition(processDefinition.getCode());
int insertVersion = version == null || version == 0 ? Constants.VERSION_FIRST : version + 1;
processDefinitionLog.setVersion(insertVersion);
processDefinitionLog.setReleaseState(isFromProcessDefine ? ReleaseState.OFFLINE : ReleaseState.ONLINE);
processDefinitionLog.setOperator(operator.getId());
processDefinitionLog.setOperateTime(processDefinition.getUpdateTime());
int insertLog = processDefineLogMapper.insert(processDefinitionLog);
int result;
if (0 == processDefinition.getId()) {
result = processDefineMapper.insert(processDefinitionLog);
} else {
processDefinitionLog.setId(processDefinition.getId());
result = processDefineMapper.updateById(processDefinitionLog);
}
return (insertLog & result) > 0 ? insertVersion : 0;
}
/**
* save task relations
*/
public int saveTaskRelation(User operator, long projectCode, long processDefinitionCode, int processDefinitionVersion,
List<ProcessTaskRelationLog> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) {
Map<Long, TaskDefinitionLog> taskDefinitionLogMap = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (CollectionUtils.isNotEmpty(taskDefinitionLogs)) {
taskDefinitionLogMap = taskDefinitionLogs.stream()
.collect(Collectors.toMap(TaskDefinition::getCode, taskDefinitionLog -> taskDefinitionLog));
}
Date now = new Date();
for (ProcessTaskRelationLog processTaskRelationLog : taskRelationList) {
processTaskRelationLog.setProjectCode(projectCode);
processTaskRelationLog.setProcessDefinitionCode(processDefinitionCode);
processTaskRelationLog.setProcessDefinitionVersion(processDefinitionVersion);
if (taskDefinitionLogMap != null) {
TaskDefinitionLog taskDefinitionLog = taskDefinitionLogMap.get(processTaskRelationLog.getPreTaskCode());
if (taskDefinitionLog != null) {
processTaskRelationLog.setPreTaskVersion(taskDefinitionLog.getVersion());
}
processTaskRelationLog.setPostTaskVersion(taskDefinitionLogMap.get(processTaskRelationLog.getPostTaskCode()).getVersion());
}
processTaskRelationLog.setCreateTime(now);
processTaskRelationLog.setUpdateTime(now);
processTaskRelationLog.setOperator(operator.getId());
processTaskRelationLog.setOperateTime(now);
}
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode);
if (!processTaskRelationList.isEmpty()) {
Set<Integer> processTaskRelationSet = processTaskRelationList.stream().map(ProcessTaskRelation::hashCode).collect(toSet());
Set<Integer> taskRelationSet = taskRelationList.stream().map(ProcessTaskRelationLog::hashCode).collect(toSet());
if (CollectionUtils.isEqualCollection(processTaskRelationSet, taskRelationSet)) {
return Constants.EXIT_CODE_SUCCESS;
}
processTaskRelationMapper.deleteByCode(projectCode, processDefinitionCode);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | int result = processTaskRelationMapper.batchInsert(taskRelationList);
int resultLog = processTaskRelationLogMapper.batchInsert(taskRelationList);
return (result & resultLog) > 0 ? Constants.EXIT_CODE_SUCCESS : Constants.EXIT_CODE_FAILURE;
}
public boolean isTaskOnline(long taskCode) {
List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByTaskCode(taskCode);
if (!processTaskRelationList.isEmpty()) {
Set<Long> processDefinitionCodes = processTaskRelationList
.stream()
.map(ProcessTaskRelation::getProcessDefinitionCode)
.collect(Collectors.toSet());
List<ProcessDefinition> processDefinitionList = processDefineMapper.queryByCodes(processDefinitionCodes);
//
for (ProcessDefinition processDefinition : processDefinitionList) {
if (processDefinition.getReleaseState() == ReleaseState.ONLINE) {
return true;
}
}
}
return false;
}
/**
* Generate the DAG Graph based on the process definition id
*
* @param processDefinition process definition
* @return dag graph
*/
public DAG<String, TaskNode, TaskNodeRelation> genDagGraph(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
List<TaskNode> taskNodeList = transformTask(processTaskRelations, Lists.newArrayList()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessDag processDag = DagHelper.getProcessDag(taskNodeList, new ArrayList<>(processTaskRelations));
//
return DagHelper.buildDagGraph(processDag);
}
/**
* generate DagData
*/
public DagData genDagData(ProcessDefinition processDefinition) {
List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode());
List<TaskDefinitionLog> taskDefinitionLogList = genTaskDefineList(processTaskRelations);
List<TaskDefinition> taskDefinitions = taskDefinitionLogList.stream()
.map(taskDefinitionLog -> JSONUtils.parseObject(JSONUtils.toJsonString(taskDefinitionLog), TaskDefinition.class))
.collect(Collectors.toList());
return new DagData(processDefinition, processTaskRelations, taskDefinitions);
}
public List<TaskDefinitionLog> genTaskDefineList(List<ProcessTaskRelation> processTaskRelations) {
Set<TaskDefinition> taskDefinitionSet = new HashSet<>();
for (ProcessTaskRelation processTaskRelation : processTaskRelations) {
if (processTaskRelation.getPreTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPreTaskCode(), processTaskRelation.getPreTaskVersion()));
}
if (processTaskRelation.getPostTaskCode() > 0) {
taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion()));
}
}
return taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet);
}
/**
* find task definition by code and version
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public TaskDefinition findTaskDefinition(long taskCode, int taskDefinitionVersion) {
return taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, taskDefinitionVersion);
}
/**
* find process task relation list by projectCode and processDefinitionCode
*/
public List<ProcessTaskRelation> findRelationByCode(long projectCode, long processDefinitionCode) {
return processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode);
}
/**
* add authorized resources
*
* @param ownResources own resources
* @param userId userId
*/
private void addAuthorizedResources(List<Resource> ownResources, int userId) {
List<Integer> relationResourceIds = resourceUserMapper.queryResourcesIdListByUserIdAndPerm(userId, 7);
List<Resource> relationResources = CollectionUtils.isNotEmpty(relationResourceIds) ? resourceMapper.queryResourceListById(relationResourceIds) : new ArrayList<>();
ownResources.addAll(relationResources);
}
/**
* Use temporarily before refactoring taskNode
*/
public List<TaskNode> transformTask(List<ProcessTaskRelation> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) {
Map<Long, List<Long>> taskCodeMap = new HashMap<>();
for (ProcessTaskRelation processTaskRelation : taskRelationList) {
taskCodeMap.compute(processTaskRelation.getPostTaskCode(), (k, v) -> {
if (v == null) {
v = new ArrayList<>();
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (processTaskRelation.getPreTaskCode() != 0L) {
v.add(processTaskRelation.getPreTaskCode());
}
return v;
});
}
if (CollectionUtils.isEmpty(taskDefinitionLogs)) {
taskDefinitionLogs = genTaskDefineList(taskRelationList);
}
Map<Long, TaskDefinitionLog> taskDefinitionLogMap = taskDefinitionLogs.stream()
.collect(Collectors.toMap(TaskDefinitionLog::getCode, taskDefinitionLog -> taskDefinitionLog));
List<TaskNode> taskNodeList = new ArrayList<>();
for (Entry<Long, List<Long>> code : taskCodeMap.entrySet()) {
TaskDefinitionLog taskDefinitionLog = taskDefinitionLogMap.get(code.getKey());
if (taskDefinitionLog != null) {
TaskNode taskNode = new TaskNode();
taskNode.setCode(taskDefinitionLog.getCode());
taskNode.setVersion(taskDefinitionLog.getVersion());
taskNode.setName(taskDefinitionLog.getName());
taskNode.setDesc(taskDefinitionLog.getDescription());
taskNode.setType(taskDefinitionLog.getTaskType().toUpperCase());
taskNode.setRunFlag(taskDefinitionLog.getFlag() == Flag.YES ? Constants.FLOWNODE_RUN_FLAG_NORMAL : Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
taskNode.setMaxRetryTimes(taskDefinitionLog.getFailRetryTimes());
taskNode.setRetryInterval(taskDefinitionLog.getFailRetryInterval());
Map<String, Object> taskParamsMap = taskNode.taskParamsToJsonObj(taskDefinitionLog.getTaskParams());
taskNode.setConditionResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.CONDITION_RESULT)));
taskNode.setSwitchResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.SWITCH_RESULT)));
taskNode.setDependence(JSONUtils.toJsonString(taskParamsMap.get(Constants.DEPENDENCE)));
taskParamsMap.remove(Constants.CONDITION_RESULT);
taskParamsMap.remove(Constants.DEPENDENCE); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,072 | [Bug][common] Generics type is invalid in JsonUtils.toMap | **Describe the bug**
This method is hope to deserialize a JSON to Map.
https://github.com/apache/dolphinscheduler/blob/e866d1be86464d812551e8c38ba60767a204c82e/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java#L249-L251
But the generics type in the Map is not what we expected.
We can write a simple test case:
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
System.out.println(param);
```
It will execute success, and print
```
{id=[], test1=6}
```
The value type of `id` is `List`, the value type of `test1` is `String`.
But If we loop the map, it will throw a exception, because the value in this map has different type
```java
String sqlResult = "{\"id\":[],\"test1\":\"6\"}";
Map<String, List> param = toMap(sqlResult, String.class, List.class);
param.forEach((key, value) -> System.out.println(value));
```
```
[]
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.List
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.apache.dolphinscheduler.common.utils.JSONUtils.main(JSONUtils.java:256)
```
I don't find out the deep reason, but I think we should remove this method.
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/6072 | https://github.com/apache/dolphinscheduler/pull/6283 | c855a5926ceb9cfb6efb0c901c8d92fe3774e999 | 46257834792d3316c9f5ef885f38e069e4eb6452 | "2021-08-31T10:30:15Z" | java | "2021-09-23T15:06:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | taskNode.setParams(JSONUtils.toJsonString(taskParamsMap));
taskNode.setTaskInstancePriority(taskDefinitionLog.getTaskPriority());
taskNode.setWorkerGroup(taskDefinitionLog.getWorkerGroup());
taskNode.setEnvironmentCode(taskDefinitionLog.getEnvironmentCode());
taskNode.setTimeout(JSONUtils.toJsonString(new TaskTimeoutParameter(taskDefinitionLog.getTimeoutFlag() == TimeoutFlag.OPEN,
taskDefinitionLog.getTimeoutNotifyStrategy(),
taskDefinitionLog.getTimeout())));
taskNode.setDelayTime(taskDefinitionLog.getDelayTime());
taskNode.setPreTasks(JSONUtils.toJsonString(code.getValue().stream().map(taskDefinitionLogMap::get).map(TaskDefinition::getName).collect(Collectors.toList())));
taskNodeList.add(taskNode);
}
}
return taskNodeList;
}
public Map<ProcessInstance, TaskInstance> notifyProcessList(int processId, int taskId) {
HashMap<ProcessInstance, TaskInstance> processTaskMap = new HashMap<>();
//
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(processId);
if (processInstanceMap == null) {
return processTaskMap;
}
ProcessInstance fatherProcess = this.findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
TaskInstance fatherTask = this.findTaskInstanceById(processInstanceMap.getParentTaskInstanceId());
if (fatherProcess != null) {
processTaskMap.put(fatherProcess, fatherTask);
}
return processTaskMap;
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,323 | [Bug] [MasterServer] make CPU 100% even without task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
master-server make CPU high even without task.
because EventExecuteService run loop without sleep.
### What you expected to happen
low CPU usage when idle
### How to reproduce
run master-server and observe CPU usage.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6323 | https://github.com/apache/dolphinscheduler/pull/6324 | c3324cc101b39eb789cccd9dee7e3cc5aae8722b | 89cc045961477168ac8ff74c5d6604b606214775 | "2021-09-24T02:13:49Z" | java | "2021-09-24T08:19:02Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/EventExecuteService.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License. |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,323 | [Bug] [MasterServer] make CPU 100% even without task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
master-server make CPU high even without task.
because EventExecuteService run loop without sleep.
### What you expected to happen
low CPU usage when idle
### How to reproduce
run master-server and observe CPU usage.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6323 | https://github.com/apache/dolphinscheduler/pull/6324 | c3324cc101b39eb789cccd9dee7e3cc5aae8722b | 89cc045961477168ac8ff74c5d6604b606214775 | "2021-09-24T02:13:49Z" | java | "2021-09-24T08:19:02Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/EventExecuteService.java | */
package org.apache.dolphinscheduler.server.master.runner;
import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
import org.apache.dolphinscheduler.common.enums.StateEvent;
import org.apache.dolphinscheduler.common.enums.StateEventType;
import org.apache.dolphinscheduler.common.thread.Stopper;
import org.apache.dolphinscheduler.common.thread.ThreadUtils;
import org.apache.dolphinscheduler.common.utils.NetUtils;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.remote.command.StateEventChangeCommand;
import org.apache.dolphinscheduler.remote.processor.StateEventCallbackService;
import org.apache.dolphinscheduler.server.master.config.MasterConfig;
import org.apache.dolphinscheduler.service.bean.SpringApplicationContext;
import org.apache.dolphinscheduler.service.process.ProcessService;
import org.apache.commons.lang.StringUtils;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ExecutorService;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.common.util.concurrent.MoreExecutors;
@Service
public class EventExecuteService extends Thread { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,323 | [Bug] [MasterServer] make CPU 100% even without task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
master-server make CPU high even without task.
because EventExecuteService run loop without sleep.
### What you expected to happen
low CPU usage when idle
### How to reproduce
run master-server and observe CPU usage.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6323 | https://github.com/apache/dolphinscheduler/pull/6324 | c3324cc101b39eb789cccd9dee7e3cc5aae8722b | 89cc045961477168ac8ff74c5d6604b606214775 | "2021-09-24T02:13:49Z" | java | "2021-09-24T08:19:02Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/EventExecuteService.java | private static final Logger logger = LoggerFactory.getLogger(EventExecuteService.class);
/**
* dolphinscheduler database interface
*/
@Autowired
private ProcessService processService;
@Autowired
private MasterConfig masterConfig;
private ExecutorService eventExecService;
/**
*
*/
private StateEventCallbackService stateEventCallbackService;
private ConcurrentHashMap<Integer, WorkflowExecuteThread> processInstanceExecMaps;
private ConcurrentHashMap<String, WorkflowExecuteThread> eventHandlerMap = new ConcurrentHashMap();
ListeningExecutorService listeningExecutorService;
public void init(ConcurrentHashMap<Integer, WorkflowExecuteThread> processInstanceExecMaps) {
eventExecService = ThreadUtils.newDaemonFixedThreadExecutor("MasterEventExecution", masterConfig.getMasterExecThreads());
this.processInstanceExecMaps = processInstanceExecMaps;
listeningExecutorService = MoreExecutors.listeningDecorator(eventExecService);
this.stateEventCallbackService = SpringApplicationContext.getBean(StateEventCallbackService.class);
}
@Override
public synchronized void start() {
super.setName("EventServiceStarted");
super.start();
}
public void close() {
eventExecService.shutdown();
logger.info("event service stopped..."); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,323 | [Bug] [MasterServer] make CPU 100% even without task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
master-server make CPU high even without task.
because EventExecuteService run loop without sleep.
### What you expected to happen
low CPU usage when idle
### How to reproduce
run master-server and observe CPU usage.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6323 | https://github.com/apache/dolphinscheduler/pull/6324 | c3324cc101b39eb789cccd9dee7e3cc5aae8722b | 89cc045961477168ac8ff74c5d6604b606214775 | "2021-09-24T02:13:49Z" | java | "2021-09-24T08:19:02Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/EventExecuteService.java | }
@Override
public void run() {
logger.info("Event service started");
while (Stopper.isRunning()) {
try {
eventHandler();
} catch (Exception e) {
logger.error("Event service thread error", e);
}
}
}
private void eventHandler() {
for (WorkflowExecuteThread workflowExecuteThread : this.processInstanceExecMaps.values()) {
if (workflowExecuteThread.eventSize() == 0
|| StringUtils.isEmpty(workflowExecuteThread.getKey())
|| eventHandlerMap.containsKey(workflowExecuteThread.getKey())) {
continue;
}
int processInstanceId = workflowExecuteThread.getProcessInstance().getId();
logger.info("handle process instance : {} events, count:{}",
processInstanceId,
workflowExecuteThread.eventSize());
logger.info("already exists handler process size:{}", this.eventHandlerMap.size());
eventHandlerMap.put(workflowExecuteThread.getKey(), workflowExecuteThread);
ListenableFuture future = this.listeningExecutorService.submit(workflowExecuteThread);
FutureCallback futureCallback = new FutureCallback() {
@Override
public void onSuccess(Object o) {
if (workflowExecuteThread.workFlowFinish()) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,323 | [Bug] [MasterServer] make CPU 100% even without task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
master-server make CPU high even without task.
because EventExecuteService run loop without sleep.
### What you expected to happen
low CPU usage when idle
### How to reproduce
run master-server and observe CPU usage.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6323 | https://github.com/apache/dolphinscheduler/pull/6324 | c3324cc101b39eb789cccd9dee7e3cc5aae8722b | 89cc045961477168ac8ff74c5d6604b606214775 | "2021-09-24T02:13:49Z" | java | "2021-09-24T08:19:02Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/EventExecuteService.java | processInstanceExecMaps.remove(processInstanceId);
notifyProcessChanged();
logger.info("process instance {} finished.", processInstanceId);
}
if (workflowExecuteThread.getProcessInstance().getId() != processInstanceId) {
processInstanceExecMaps.remove(processInstanceId);
processInstanceExecMaps.put(workflowExecuteThread.getProcessInstance().getId(), workflowExecuteThread);
}
eventHandlerMap.remove(workflowExecuteThread.getKey());
}
private void notifyProcessChanged() {
Map<ProcessInstance, TaskInstance> fatherMaps
= processService.notifyProcessList(processInstanceId, 0);
for (ProcessInstance processInstance : fatherMaps.keySet()) {
String address = NetUtils.getAddr(masterConfig.getListenPort());
if (processInstance.getHost().equalsIgnoreCase(address)) {
notifyMyself(processInstance, fatherMaps.get(processInstance));
} else {
notifyProcess(processInstance, fatherMaps.get(processInstance));
}
}
}
private void notifyMyself(ProcessInstance processInstance, TaskInstance taskInstance) {
logger.info("notify process {} task {} state change", processInstance.getId(), taskInstance.getId());
if (!processInstanceExecMaps.containsKey(processInstance.getId())) {
return;
}
WorkflowExecuteThread workflowExecuteThreadNotify = processInstanceExecMaps.get(processInstance.getId());
StateEvent stateEvent = new StateEvent();
stateEvent.setTaskInstanceId(taskInstance.getId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,323 | [Bug] [MasterServer] make CPU 100% even without task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
master-server make CPU high even without task.
because EventExecuteService run loop without sleep.
### What you expected to happen
low CPU usage when idle
### How to reproduce
run master-server and observe CPU usage.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6323 | https://github.com/apache/dolphinscheduler/pull/6324 | c3324cc101b39eb789cccd9dee7e3cc5aae8722b | 89cc045961477168ac8ff74c5d6604b606214775 | "2021-09-24T02:13:49Z" | java | "2021-09-24T08:19:02Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/EventExecuteService.java | stateEvent.setType(StateEventType.TASK_STATE_CHANGE);
stateEvent.setProcessInstanceId(processInstance.getId());
stateEvent.setExecutionStatus(ExecutionStatus.RUNNING_EXECUTION);
workflowExecuteThreadNotify.addStateEvent(stateEvent);
}
private void notifyProcess(ProcessInstance processInstance, TaskInstance taskInstance) {
String host = processInstance.getHost();
if (StringUtils.isEmpty(host)) {
logger.info("process {} host is empty, cannot notify task {} now.",
processInstance.getId(), taskInstance.getId());
return;
}
String address = host.split(":")[0];
int port = Integer.parseInt(host.split(":")[1]);
logger.info("notify process {} task {} state change, host:{}",
processInstance.getId(), taskInstance.getId(), host);
StateEventChangeCommand stateEventChangeCommand = new StateEventChangeCommand(
processInstanceId, 0, workflowExecuteThread.getProcessInstance().getState(), processInstance.getId(), taskInstance.getId()
);
stateEventCallbackService.sendResult(address, port, stateEventChangeCommand.convert2Command());
}
@Override
public void onFailure(Throwable throwable) {
}
};
Futures.addCallback(future, futureCallback, this.listeningExecutorService);
}
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.plugin.task.sql;
import org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor;
import org.apache.dolphinscheduler.plugin.task.api.TaskException;
import org.apache.dolphinscheduler.plugin.task.datasource.BaseConnectionParam;
import org.apache.dolphinscheduler.plugin.task.datasource.DatasourceUtil;
import org.apache.dolphinscheduler.plugin.task.util.MapUtils;
import org.apache.dolphinscheduler.spi.enums.DbType;
import org.apache.dolphinscheduler.spi.enums.TaskTimeoutStrategy;
import org.apache.dolphinscheduler.spi.task.AbstractParameters;
import org.apache.dolphinscheduler.spi.task.Direct;
import org.apache.dolphinscheduler.spi.task.Property;
import org.apache.dolphinscheduler.spi.task.TaskAlertInfo;
import org.apache.dolphinscheduler.spi.task.TaskConstants;
import org.apache.dolphinscheduler.spi.task.paramparser.ParamUtils; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | import org.apache.dolphinscheduler.spi.task.paramparser.ParameterUtils;
import org.apache.dolphinscheduler.spi.task.request.SQLTaskExecutionContext;
import org.apache.dolphinscheduler.spi.task.request.TaskRequest;
import org.apache.dolphinscheduler.spi.task.request.UdfFuncRequest;
import org.apache.dolphinscheduler.spi.utils.CollectionUtils;
import org.apache.dolphinscheduler.spi.utils.JSONUtils;
import org.apache.dolphinscheduler.spi.utils.StringUtils;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
import java.sql.SQLException;
import java.sql.Statement;
import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.slf4j.Logger;
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
public class SqlTask extends AbstractTaskExecutor {
/**
* taskExecutionContext
*/
private TaskRequest taskExecutionContext; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | /**
* sql parameters
*/
private SqlParameters sqlParameters;
/**
* base datasource
*/
private BaseConnectionParam baseConnectionParam;
/**
* create function format
*/
private static final String CREATE_FUNCTION_FORMAT = "create temporary function {0} as ''{1}''";
/**
* Abstract Yarn Task
*
* @param taskRequest taskRequest
*/
public SqlTask(TaskRequest taskRequest) {
super(taskRequest);
this.taskExecutionContext = taskRequest;
this.sqlParameters = JSONUtils.parseObject(taskExecutionContext.getTaskParams(), SqlParameters.class);
assert sqlParameters != null;
if (!sqlParameters.checkParameters()) {
throw new RuntimeException("sql task params is not valid");
}
}
@Override
public AbstractParameters getParameters() {
return sqlParameters;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | @Override
public void handle() throws Exception {
String threadLoggerInfoName = String.format(TaskConstants.TASK_LOG_INFO_FORMAT, taskExecutionContext.getTaskAppId());
Thread.currentThread().setName(threadLoggerInfoName);
logger.info("Full sql parameters: {}", sqlParameters);
logger.info("sql type : {}, datasource : {}, sql : {} , localParams : {},udfs : {},showType : {},connParams : {},varPool : {} ,query max result limit {}",
sqlParameters.getType(),
sqlParameters.getDatasource(),
sqlParameters.getSql(),
sqlParameters.getLocalParams(),
sqlParameters.getUdfs(),
sqlParameters.getShowType(),
sqlParameters.getConnParams(),
sqlParameters.getVarPool(),
sqlParameters.getLimit());
try {
SQLTaskExecutionContext sqlTaskExecutionContext = taskExecutionContext.getSqlTaskExecutionContext();
baseConnectionParam = (BaseConnectionParam) DatasourceUtil.buildConnectionParams(
DbType.valueOf(sqlParameters.getType()),
sqlTaskExecutionContext.getConnectionParams());
SqlBinds mainSqlBinds = getSqlAndSqlParamsMap(sqlParameters.getSql());
List<SqlBinds> preStatementSqlBinds = Optional.ofNullable(sqlParameters.getPreStatements())
.orElse(new ArrayList<>())
.stream()
.map(this::getSqlAndSqlParamsMap)
.collect(Collectors.toList());
List<SqlBinds> postStatementSqlBinds = Optional.ofNullable(sqlParameters.getPostStatements()) |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | .orElse(new ArrayList<>())
.stream()
.map(this::getSqlAndSqlParamsMap)
.collect(Collectors.toList());
List<String> createFuncs = createFuncs(sqlTaskExecutionContext.getUdfFuncTenantCodeMap(),
logger);
executeFuncAndSql(mainSqlBinds, preStatementSqlBinds, postStatementSqlBinds, createFuncs);
setExitStatusCode(TaskConstants.EXIT_CODE_SUCCESS);
} catch (Exception e) {
setExitStatusCode(TaskConstants.EXIT_CODE_FAILURE);
logger.error("sql task error: {}", e.toString());
throw e;
}
}
/**
* execute function and sql
*
* @param mainSqlBinds main sql binds
* @param preStatementsBinds pre statements binds
* @param postStatementsBinds post statements binds
* @param createFuncs create functions
*/
public void executeFuncAndSql(SqlBinds mainSqlBinds,
List<SqlBinds> preStatementsBinds,
List<SqlBinds> postStatementsBinds,
List<String> createFuncs) throws Exception {
Connection connection = null;
PreparedStatement stmt = null;
ResultSet resultSet = null; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | try {
connection = DatasourceUtil.getConnection(DbType.valueOf(sqlParameters.getType()), baseConnectionParam);
if (CollectionUtils.isNotEmpty(createFuncs)) {
createTempFunction(connection, createFuncs);
}
preSql(connection, preStatementsBinds);
stmt = prepareStatementAndBind(connection, mainSqlBinds);
String result = null;
if (sqlParameters.getSqlType() == SqlType.QUERY.ordinal()) {
resultSet = stmt.executeQuery();
result = resultProcess(resultSet);
} else if (sqlParameters.getSqlType() == SqlType.NON_QUERY.ordinal()) {
String updateResult = String.valueOf(stmt.executeUpdate());
result = setNonQuerySqlReturn(updateResult, sqlParameters.getLocalParams());
}
sqlParameters.dealOutParam(result);
postSql(connection, postStatementsBinds);
} catch (Exception e) {
logger.error("execute sql error: {}", e.getMessage());
throw e;
} finally {
close(resultSet, stmt, connection);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | }
private String setNonQuerySqlReturn(String updateResult, List<Property> properties) {
String result = null;
for (Property info : properties) {
if (Direct.OUT == info.getDirect()) {
List<Map<String, String>> updateRL = new ArrayList<>();
Map<String, String> updateRM = new HashMap<>();
updateRM.put(info.getProp(), updateResult);
updateRL.add(updateRM);
result = JSONUtils.toJsonString(updateRL);
break;
}
}
return result;
}
/**
* result process
*
* @param resultSet resultSet
* @throws Exception Exception
*/
private String resultProcess(ResultSet resultSet) throws Exception {
ArrayNode resultJSONArray = JSONUtils.createArrayNode();
if (resultSet != null) {
ResultSetMetaData md = resultSet.getMetaData();
int num = md.getColumnCount();
int rowCount = 0;
while (rowCount < sqlParameters.getLimit() && resultSet.next()) {
ObjectNode mapOfColValues = JSONUtils.createObjectNode();
for (int i = 1; i <= num; i++) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | mapOfColValues.set(md.getColumnLabel(i), JSONUtils.toJsonNode(resultSet.getObject(i)));
}
resultJSONArray.add(mapOfColValues);
rowCount++;
}
int displayRows = sqlParameters.getDisplayRows() > 0 ? sqlParameters.getDisplayRows() : TaskConstants.DEFAULT_DISPLAY_ROWS;
displayRows = Math.min(displayRows, resultJSONArray.size());
logger.info("display sql result {} rows as follows:", displayRows);
for (int i = 0; i < displayRows; i++) {
String row = JSONUtils.toJsonString(resultJSONArray.get(i));
logger.info("row {} : {}", i + 1, row);
}
}
String result = JSONUtils.toJsonString(resultJSONArray);
if (sqlParameters.getSendEmail() == null || sqlParameters.getSendEmail()) {
sendAttachment(sqlParameters.getGroupId(), StringUtils.isNotEmpty(sqlParameters.getTitle())
? sqlParameters.getTitle()
: taskExecutionContext.getTaskName() + " query result sets", result);
}
logger.debug("execute sql result : {}", result);
return result;
}
/**
* send alert as an attachment
*
* @param title title
* @param content content
*/
private void sendAttachment(int groupId, String title, String content) {
setNeedAlert(Boolean.TRUE); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | TaskAlertInfo taskAlertInfo = new TaskAlertInfo();
taskAlertInfo.setAlertGroupId(groupId);
taskAlertInfo.setContent(content);
taskAlertInfo.setTitle(title);
}
/**
* pre sql
*
* @param connection connection
* @param preStatementsBinds preStatementsBinds
*/
private void preSql(Connection connection,
List<SqlBinds> preStatementsBinds) throws Exception {
for (SqlBinds sqlBind : preStatementsBinds) {
try (PreparedStatement pstmt = prepareStatementAndBind(connection, sqlBind)) {
int result = pstmt.executeUpdate();
logger.info("pre statement execute result: {}, for sql: {}", result, sqlBind.getSql());
}
}
}
/**
* post sql
*
* @param connection connection
* @param postStatementsBinds postStatementsBinds
*/
private void postSql(Connection connection,
List<SqlBinds> postStatementsBinds) throws Exception {
for (SqlBinds sqlBind : postStatementsBinds) {
try (PreparedStatement pstmt = prepareStatementAndBind(connection, sqlBind)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 6,331 | [Bug] [TaskPlugin] PSQLException: statement has been closed when run sql task | ### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
branch: dev
model: dev-run, master-server、worker-server、api-server run by idea
dolphinscheduler-server worker.properties config:
`task.plugin.binding=./dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-python/pom.xml,./dolphinscheduler-task-plugin/dolphinscheduler-task-sql/pom.xml`
dolphinscheduler-task-sql pom.xml add jar dependency:
```
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
</dependency>`
```
exception:
```
[INFO] 2021-09-24 15:54:37.813 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[386] - prepare statement replace sql : select count(1) from t_ds_task_instance
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[202] - execute sql error: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.815 /home/csf/javapath/dolphinscheduler/logs/754963903078400_1/28/52.log:[153] - sql task error: org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
[ERROR] 2021-09-24 15:54:37.817 org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread:[212] - task scheduler failure
org.postgresql.util.PSQLException: 这个 statement 已经被关闭。
at org.postgresql.jdbc.PgStatement.checkClosed(PgStatement.java:694)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:137)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:106)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:190)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:147)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:198)
```
### What you expected to happen
run sql task success
### How to reproduce
create a process contains sql task with pgsql source, and run it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
| https://github.com/apache/dolphinscheduler/issues/6331 | https://github.com/apache/dolphinscheduler/pull/6334 | 89cc045961477168ac8ff74c5d6604b606214775 | 61c64619949b2098f7efcd2cfcc701ef98564083 | "2021-09-24T08:21:29Z" | java | "2021-09-24T10:39:04Z" | dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | int result = pstmt.executeUpdate();
logger.info("post statement execute result: {},for sql: {}", result, sqlBind.getSql());
}
}
}
/**
* create temp function
*
* @param connection connection
* @param createFuncs createFuncs
*/
private void createTempFunction(Connection connection,
List<String> createFuncs) throws Exception {
try (Statement funcStmt = connection.createStatement()) {
for (String createFunc : createFuncs) {
logger.info("hive create function sql: {}", createFunc);
funcStmt.execute(createFunc);
}
}
}
/**
* close jdbc resource
*
* @param resultSet resultSet
* @param pstmt pstmt
* @param connection connection
*/
private void close(ResultSet resultSet,
PreparedStatement pstmt,
Connection connection) { |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.